Translated using Weblate (Lithuanian)

Currently translated at 95.4% (9663 of 10123 strings)

Translation: KiCad EDA/v9
Translate-URL: https://hosted.weblate.org/projects/kicad/v9/lt/

.gitlab/doxygen.yml

@@ -1,7 +1,7 @@
 build_doxygen_docker:
-  image: docker:stable
+  image: docker:24.0.5-cli
   services:
-    - docker:dind
+    - docker:24.0.5-dind
   stage: build
   rules:
     - if: $CI_PIPELINE_SOURCE == "schedule" && $SCHEDULED_JOB_NAME == "doxygen"

3d-viewer/3d_viewer/eda_3d_viewer_frame.cpp

@@ -202,6 +202,10 @@ EDA_3D_VIEWER_FRAME::EDA_3D_VIEWER_FRAME( KIWAY* aKiway, PCB_BASE_FRAME* aParent
 
 EDA_3D_VIEWER_FRAME::~EDA_3D_VIEWER_FRAME()
 {
+    // Shutdown all running tools
+    if( m_toolManager )
+        m_toolManager->ShutdownAllTools();
+
     Prj().GetProjectFile().m_Viewports3D = m_appearancePanel->GetUserViewports();
 
     m_canvas->SetEventDispatcher( nullptr );

3d-viewer/dialogs/panel_preview_3d_model.cpp

@@ -185,6 +185,10 @@ PANEL_PREVIEW_3D_MODEL::PANEL_PREVIEW_3D_MODEL( wxWindow* aParent, PCB_BASE_FRAM
 
 PANEL_PREVIEW_3D_MODEL::~PANEL_PREVIEW_3D_MODEL()
 {
+    // Shutdown all running tools
+    if( m_toolManager )
+        m_toolManager->ShutdownAllTools();
+
     // Restore the 3D viewer Render settings, that can be modified by the panel tools
     if( m_boardAdapter.m_Cfg )
         m_boardAdapter.m_Cfg->m_Render = m_initialRender;

api/proto/board/board_commands.proto

@@ -115,6 +115,20 @@ message SetBoardOrigin
   kiapi.common.types.Vector2 origin = 3;
 }
 
+message GetBoardLayerName
+{
+  kiapi.common.types.DocumentSpecifier board = 1;
+
+  kiapi.board.types.BoardLayer layer = 2;
+}
+
+message BoardLayerNameResponse
+{
+  // The name of the layer shown in the KiCad GUI, which may be a default value like "F.Cu" or may
+  // have been customized by the user.
+  string name = 1;
+}
+
 /*
  * Net management
  */

api/proto/board/board_types.proto

@@ -464,6 +464,18 @@ message ThermalSpokeSettings
   kiapi.common.types.Distance gap = 3;
 }
 
+message SymbolPinInfo
+{
+  // The pin name for the associated symbol pin, if one exists
+  string name = 1;
+
+  // The electrical type of the associated symbol pin, if one exists (EPT_UNKNOWN if not)
+  kiapi.common.types.ElectricalPinType type = 2;
+
+  // True if the pin is attached to a no-connect marker in the schematic
+  bool no_connect = 3;
+}
+
 message Pad
 {
   kiapi.common.types.KIID id = 1;
@@ -481,6 +493,10 @@ message Pad
 
   // Since: 9.0.4
   kiapi.common.types.Distance pad_to_die_length = 9;
+
+  // Information about the associated symbol pin, if one exists
+  // Since: 9.0.7
+  SymbolPinInfo symbol_pin = 10;
 }
 
 enum ZoneType
@@ -830,6 +846,9 @@ message FootprintAttributes
   bool exempt_from_courtyard_requirement = 6;
   bool do_not_populate = 7;
   FootprintMountingStyle mounting_style = 8;
+
+  // Since: 9.0.7
+  bool allow_soldermask_bridges = 9;
 }
 
 message NetTieDefinition
@@ -902,4 +921,19 @@ message FootprintInstance
 
   // The sheet path to the associated symbol for this footprint instance, if one exists
   kiapi.common.types.SheetPath symbol_path = 13;
+
+  // The name of the hierarchical sheet the associated symbol for this footprint exists on,
+  // or the empty string if there is no associated symbol
+  // Since: 9.0.7
+  string symbol_sheet_name = 14;
+
+  // The filename of the hierarchical sheet the associated symbol for this footprint exists on,
+  // or the empty string if there is no associated symbol
+  // Since: 9.0.7
+  string symbol_sheet_filename = 15;
+
+  // The the footprint filters given by the symbol this footprint is associated with,
+  // or the empty string if there is no associated symbol
+  // Since: 9.0.7
+  string symbol_footprint_filters = 16;
 }

api/proto/common/types/base_types.proto

@@ -451,3 +451,25 @@ enum MapMergeMode
   // The existing map will be cleared and replaced with the incoming map
   MMM_REPLACE = 2;
 }
+
+enum ElectricalPinType
+{
+  EPT_UNKNOWN = 0;
+  EPT_INPUT = 1;
+  EPT_OUTPUT = 2;
+  EPT_BIDIRECTIONAL = 3;
+  EPT_TRISTATE = 4;
+  EPT_PASSIVE = 5;
+
+  // A free pin is not internally connected and may connect to any net (route-through)
+  EPT_FREE = 6;
+
+  EPT_UNSPECIFIED = 7;
+  EPT_POWER_INPUT = 8;
+  EPT_POWER_OUTPUT = 9;
+  EPT_OPEN_COLLECTOR = 10;
+  EPT_OPEN_EMITTER = 11;
+
+  // A no-connect pin should not be connected to any net
+  EPT_NO_CONNECT = 12;
+}

bitmap2component/bitmap2cmp_frame.cpp

@@ -205,7 +205,12 @@ BITMAP2CMP_FRAME::BITMAP2CMP_FRAME( KIWAY* aKiway, wxWindow* aParent ) :
 
 BITMAP2CMP_FRAME::~BITMAP2CMP_FRAME()
 {
+    // Shutdown all running tools
+    if( m_toolManager )
+        m_toolManager->ShutdownAllTools();
+
     SaveSettings( config() );
+
     /*
      * This needed for OSX: avoids further OnDraw processing after this
      * destructor and before the native window is destroyed

cmake/BuildSteps/CreateDocsetDoxyfile.cmake

@@ -51,5 +51,7 @@ DOCSET_BUNDLE_ID        = ${DOCSET_BUNDLE_ID}
 DISABLE_INDEX           = YES
 GENERATE_TREEVIEW       = NO
 SEARCHENGINE            = NO
-GENERATE_TAGFILE        = ${DOXY_TAG_FILE}"
+GENERATE_TAGFILE        = ${DOXY_TAG_FILE}
+# Doxygen-awesome doesn't look great without the index
+HTML_EXTRA_STYLESHEET   = "
     )

cmake/FindOCC.cmake

@@ -28,18 +28,12 @@
 
 # Set the needed libraries
 set( OCC_LIBS_COMMON
-    TKBinL
-    TKBin
-    TKBinTObj
-    TKBinXCAF
     TKBool
     TKBO
     TKBRep
     TKCAF
     TKCDF
     TKernel
-    TKFeat
-    TKFillet
     TKG2d
     TKG3d
     TKGeomAlgo
@@ -48,22 +42,13 @@ set( OCC_LIBS_COMMON
     TKLCAF
     TKMath
     TKMesh
-    TKMeshVS
-    TKOffset
-    TKOpenGl
     TKPrim
     TKRWMesh
     TKService
     TKShHealing
-    TKTObj
     TKTopAlgo
     TKV3d
     TKXCAF
-    TKXMesh
-    TKXmlL
-    TKXml
-    TKXmlTObj
-    TKXmlXCAF
     TKXSBase
 )
 
@@ -140,6 +125,7 @@ else(WIN32)
     /usr
     /usr/local
     /usr/local/opencascade
+    /usr/opencascade
     /opt/opencascade
     /opt/opencascade/lin64/gcc
     PATH_SUFFIXES lib

cmake/KiCadVersion.cmake

@@ -2,7 +2,7 @@
 #  This program source code file is part of KICAD, a free EDA CAD application.
 #
 #  Copyright (C) 2016 Wayne Stambaugh <stambaughw@gmail.com>
-#  Copyright (C) 2016-2023, 2024 KiCad Developers, see AUTHORS.txt for contributors.
+#  Copyright (C) 2016-2023, 2024, 2025 KiCad Developers, see AUTHORS.txt for contributors.
 #
 #  This program is free software; you can redistribute it and/or
 #  modify it under the terms of the GNU General Public License
@@ -37,7 +37,7 @@
 # KiCad.
 #
 # Note: This version string should follow the semantic versioning system
-set( KICAD_SEMANTIC_VERSION "9.0.6-rc1" )
+set( KICAD_SEMANTIC_VERSION "9.0.8-unknown" )
 
 # Default the version to the semantic version.
 # This is overridden by the git repository tag though (if using git)

cmake/Warnings.cmake

@@ -184,6 +184,13 @@ if( CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang" )
         set( HAVE_WIMPLICIT_FLOAT_CONVERSION true )
     endif()
 
+    CHECK_CXX_COMPILER_FLAG( "-Wambiguous-conditional" COMPILER_SUPPORTS_WAMBIGUOUS_CONDITIONAL )
+
+    # Add this to match MSVC's warning about ambiguous conditionals
+    if( COMPILER_SUPPORTS_WAMBIGUOUS_CONDITIONAL )
+        set( WARN_FLAGS_CXX "${WARN_FLAGS_CXX} -Wambiguous-conditional" )
+    endif()
+
     # See if the compiler will throw warnings on these conversions
     CHECK_CXX_COMPILER_FLAG( "-Wunused-const-variable" COMPILER_SUPPORTS_WUNUSED_CONST_VARIABLE )
 

common/CMakeLists.txt

@@ -11,6 +11,7 @@ include_directories(
     ./dialogs
     ./widgets
     ./dialog_about
+    ${CMAKE_SOURCE_DIR}/libs/sexpr/include
     ${CMAKE_SOURCE_DIR}/resources/bitmaps_png
     ${CMAKE_SOURCE_DIR}/3d-viewer
     ${CMAKE_SOURCE_DIR}/pcbnew
@@ -128,6 +129,7 @@ set( KICOMMON_SRCS
     widgets/kistatusbar.cpp
     widgets/number_badge.cpp
     widgets/progress_reporter_base.cpp
+    widgets/report_severity.cpp
     widgets/std_bitmap_button.cpp
     widgets/ui_common.cpp
     widgets/wx_html_report_panel.cpp
@@ -237,6 +239,7 @@ target_link_libraries( kicommon
     fmt::fmt
     CURL::libcurl
     picosha2
+    sexpr
     ${ZSTD_LIBRARY}
     ${wxWidgets_LIBRARIES}
     ${LIBGIT2_LIBRARIES}

common/advanced_config.cpp

@@ -121,6 +121,8 @@ static const wxChar EnableExtensionSnaps[] = wxT( "EnableExtensionSnaps" );
 static const wxChar ExtensionSnapTimeoutMs[] = wxT( "ExtensionSnapTimeoutMs" );
 static const wxChar ExtensionSnapActivateOnHover[] = wxT( "ExtensionSnapActivateOnHover" );
 static const wxChar EnableSnapAnchorsDebug[] = wxT( "EnableSnapAnchorsDebug" );
+static const wxChar SnapHysteresis[] = wxT( "SnapHysteresis" );
+static const wxChar SnapToAnchorMargin[] = wxT( "SnapToAnchorMargin" );
 static const wxChar MinParallelAngle[] = wxT( "MinParallelAngle" );
 static const wxChar HoleWallPaintingMultiplier[] = wxT( "HoleWallPaintingMultiplier" );
 static const wxChar MsgPanelShowUuids[] = wxT( "MsgPanelShowUuids" );
@@ -131,6 +133,7 @@ static const wxChar ExcludeFromSimulationLineWidth[] = wxT( "ExcludeFromSimulati
 static const wxChar GitIconRefreshInterval[] = wxT( "GitIconRefreshInterval" );
 static const wxChar MaxPastedTextLength[] = wxT( "MaxPastedTextLength" );
 static const wxChar PNSProcessClusterTimeout[] = wxT( "PNSProcessClusterTimeout" );
+static const wxChar FollowBranchTimeout[] = wxT( "FollowBranchTimeoutMs" );
 
 } // namespace KEYS
 
@@ -301,6 +304,8 @@ ADVANCED_CFG::ADVANCED_CFG()
     m_ExtensionSnapTimeoutMs = 500;
     m_ExtensionSnapActivateOnHover = true;
     m_EnableSnapAnchorsDebug = false;
+    m_SnapHysteresis = 5;
+    m_SnapToAnchorMargin = 1.1;
 
     m_MinParallelAngle = 0.001;
     m_HoleWallPaintingMultiplier = 1.5;
@@ -318,6 +323,7 @@ ADVANCED_CFG::ADVANCED_CFG()
     m_MaxPastedTextLength = 100;
 
     m_PNSProcessClusterTimeout = 100; // Default: 100 ms
+    m_FollowBranchTimeout = 500; // Default: 500 ms
 
     loadFromConfigFile();
 }
@@ -582,6 +588,14 @@ void ADVANCED_CFG::loadSettings( wxConfigBase& aCfg )
                                                 &m_EnableSnapAnchorsDebug,
                                                 m_EnableSnapAnchorsDebug ) );
 
+    configParams.push_back( new PARAM_CFG_INT( true, AC_KEYS::SnapHysteresis,
+                                               &m_SnapHysteresis, m_SnapHysteresis,
+                                               0, 100 ) );
+
+    configParams.push_back( new PARAM_CFG_DOUBLE( true, AC_KEYS::SnapToAnchorMargin,
+                                                  &m_SnapToAnchorMargin, m_SnapToAnchorMargin,
+                                                  1.0, 2.0 ) );
+
     configParams.push_back( new PARAM_CFG_DOUBLE( true, AC_KEYS::MinParallelAngle,
                                                   &m_MinParallelAngle, m_MinParallelAngle,
                                                   0.0, 45.0 ) );
@@ -619,6 +633,9 @@ void ADVANCED_CFG::loadSettings( wxConfigBase& aCfg )
     configParams.push_back( new PARAM_CFG_INT( true, AC_KEYS::PNSProcessClusterTimeout,
                                                &m_PNSProcessClusterTimeout, 100, 10, 10000 ) );
 
+    configParams.push_back( new PARAM_CFG_INT( true, AC_KEYS::FollowBranchTimeout,
+                                               &m_FollowBranchTimeout, 500, 50, 5000 ) );
+
     // Special case for trace mask setting...we just grab them and set them immediately
     // Because we even use wxLogTrace inside of advanced config
     wxString traceMasks;

common/api/api_enums.cpp

@@ -26,6 +26,7 @@
 #include <core/typeinfo.h>
 #include <font/text_attributes.h>
 #include <layer_ids.h>
+#include <pin_type.h>
 #include <stroke_params.h>
 
 using namespace kiapi;
@@ -498,3 +499,54 @@ types::StrokeLineStyle ToProtoEnum( LINE_STYLE aValue )
                      "Unhandled case in ToProtoEnum<LINE_STYLE>");
     }
 }
+
+
+template<>
+ELECTRICAL_PINTYPE FromProtoEnum( types::ElectricalPinType aValue )
+{
+    switch( aValue )
+    {
+    case types::ElectricalPinType::EPT_INPUT:           return ELECTRICAL_PINTYPE::PT_INPUT;
+    case types::ElectricalPinType::EPT_OUTPUT:          return ELECTRICAL_PINTYPE::PT_OUTPUT;
+    case types::ElectricalPinType::EPT_BIDIRECTIONAL:   return ELECTRICAL_PINTYPE::PT_BIDI;
+    case types::ElectricalPinType::EPT_TRISTATE:        return ELECTRICAL_PINTYPE::PT_TRISTATE;
+    case types::ElectricalPinType::EPT_PASSIVE:         return ELECTRICAL_PINTYPE::PT_PASSIVE;
+    case types::ElectricalPinType::EPT_FREE:            return ELECTRICAL_PINTYPE::PT_NIC;
+    case types::ElectricalPinType::EPT_UNSPECIFIED:     return ELECTRICAL_PINTYPE::PT_UNSPECIFIED;
+    case types::ElectricalPinType::EPT_POWER_INPUT:     return ELECTRICAL_PINTYPE::PT_POWER_IN;
+    case types::ElectricalPinType::EPT_POWER_OUTPUT:    return ELECTRICAL_PINTYPE::PT_POWER_OUT;
+    case types::ElectricalPinType::EPT_OPEN_COLLECTOR:  return ELECTRICAL_PINTYPE::PT_OPENCOLLECTOR;
+    case types::ElectricalPinType::EPT_OPEN_EMITTER:    return ELECTRICAL_PINTYPE::PT_OPENEMITTER;
+    case types::ElectricalPinType::EPT_NO_CONNECT:      return ELECTRICAL_PINTYPE::PT_NC;
+    case types::ElectricalPinType::EPT_UNKNOWN:
+    default:
+        wxCHECK_MSG( false, ELECTRICAL_PINTYPE::PT_UNSPECIFIED,
+                     "Unhandled case in FromProtoEnum<types::ElectricalPinType>" );
+    }
+}
+
+
+template<>
+types::ElectricalPinType ToProtoEnum( ELECTRICAL_PINTYPE aValue )
+{
+    switch( aValue )
+    {
+    case ELECTRICAL_PINTYPE::PT_INPUT:         return types::ElectricalPinType::EPT_INPUT;
+    case ELECTRICAL_PINTYPE::PT_OUTPUT:        return types::ElectricalPinType::EPT_OUTPUT;
+    case ELECTRICAL_PINTYPE::PT_BIDI:          return types::ElectricalPinType::EPT_BIDIRECTIONAL;
+    case ELECTRICAL_PINTYPE::PT_TRISTATE:      return types::ElectricalPinType::EPT_TRISTATE;
+    case ELECTRICAL_PINTYPE::PT_PASSIVE:       return types::ElectricalPinType::EPT_PASSIVE;
+    case ELECTRICAL_PINTYPE::PT_NIC:           return types::ElectricalPinType::EPT_FREE;
+    case ELECTRICAL_PINTYPE::PT_UNSPECIFIED:   return types::ElectricalPinType::EPT_UNSPECIFIED;
+    case ELECTRICAL_PINTYPE::PT_POWER_IN:      return types::ElectricalPinType::EPT_POWER_INPUT;
+    case ELECTRICAL_PINTYPE::PT_POWER_OUT:     return types::ElectricalPinType::EPT_POWER_OUTPUT;
+    case ELECTRICAL_PINTYPE::PT_OPENCOLLECTOR: return types::ElectricalPinType::EPT_OPEN_COLLECTOR;
+    case ELECTRICAL_PINTYPE::PT_OPENEMITTER:   return types::ElectricalPinType::EPT_OPEN_EMITTER;
+    case ELECTRICAL_PINTYPE::PT_NC:            return types::ElectricalPinType::EPT_NO_CONNECT;
+    // Inherit shouldn't be serialized, it's an internal flag
+    case ELECTRICAL_PINTYPE::PT_INHERIT:
+    default:
+        wxCHECK_MSG( false, types::ElectricalPinType::EPT_UNKNOWN,
+                     "Unhandled case in ToProtoEnum<ELECTRICAL_PINTYPE>");
+    }
+}

common/api/api_utils.cpp

@@ -122,10 +122,9 @@ KICOMMON_API void PackPolyLine( types::PolyLine& aOutput, const SHAPE_LINE_CHAIN
         if( vertex < 0 )
             break;
 
-        types::PolyLineNode* node = aOutput.mutable_nodes()->Add();
-
-        if( aSlc.IsPtOnArc( vertex ) )
+        if( aSlc.IsArcStart( vertex ) )
         {
+            types::PolyLineNode* node = aOutput.mutable_nodes()->Add();
             const SHAPE_ARC& arc = aSlc.Arc( aSlc.ArcIndex( vertex ) );
             node->mutable_arc()->mutable_start()->set_x_nm( arc.GetP0().x );
             node->mutable_arc()->mutable_start()->set_y_nm( arc.GetP0().y );
@@ -134,8 +133,9 @@ KICOMMON_API void PackPolyLine( types::PolyLine& aOutput, const SHAPE_LINE_CHAIN
             node->mutable_arc()->mutable_end()->set_x_nm( arc.GetP1().x );
             node->mutable_arc()->mutable_end()->set_y_nm( arc.GetP1().y );
         }
-        else
+        else if( !aSlc.IsPtOnArc( vertex ) )
         {
+            types::PolyLineNode* node = aOutput.mutable_nodes()->Add();
             node->mutable_point()->set_x_nm( aSlc.CPoint( vertex ).x );
             node->mutable_point()->set_y_nm( aSlc.CPoint( vertex ).y );
         }
@@ -241,4 +241,14 @@ KICOMMON_API void PackSheetPath( types::SheetPath& aOutput, const KIID_PATH& aIn
         aOutput.add_path()->set_value( entry.AsStdString() );
 }
 
+KICOMMON_API KIID_PATH UnpackSheetPath( const types::SheetPath& aInput )
+{
+    KIID_PATH output;
+
+    for( const types::KIID& sheet : aInput.path() )
+        output.push_back( KIID( sheet.value() ) );
+
+    return output;
+}
+
 } // namespace kiapi::common

common/array_axis.cpp

@@ -37,7 +37,11 @@ static bool schemeNonUnitColsStartAt0( ARRAY_AXIS::NUMBERING_TYPE type )
 }
 
 
-ARRAY_AXIS::ARRAY_AXIS() : m_type( NUMBERING_TYPE::NUMBERING_NUMERIC ), m_offset( 0 ), m_step( 1 )
+ARRAY_AXIS::ARRAY_AXIS() :
+        m_type( NUMBERING_TYPE::NUMBERING_NUMERIC ),
+        m_offset( 0 ),
+        m_step( 1 ),
+        m_useLowercase( false )
 {
 }
 
@@ -76,7 +80,14 @@ std::optional<int> ARRAY_AXIS::getNumberingOffset( const wxString& str ) const
 
     for( unsigned i = 0; i < str.length(); i++ )
     {
-        int chIndex = alphabet.Find( str[i], false );
+        wxUniChar ch = str[i];
+
+        // For alphabetic types, convert to uppercase for lookup since our alphabets
+        // are defined with uppercase letters. This allows users to enter lowercase.
+        if( !TypeIsNumeric( m_type ) && ch >= 'a' && ch <= 'z' )
+            ch = ch - 'a' + 'A';
+
+        int chIndex = alphabet.Find( ch, false );
 
         if( chIndex == wxNOT_FOUND )
             return std::optional<int>{};
@@ -109,6 +120,18 @@ bool ARRAY_AXIS::SetOffset( const wxString& aOffsetName )
     if( !offset )
         return false;
 
+    // For alphabetic types, check if the user entered lowercase letters.
+    // If so, we'll output lowercase letters as well.
+    if( !TypeIsNumeric( m_type ) && !aOffsetName.IsEmpty() )
+    {
+        wxUniChar firstChar = aOffsetName[0];
+        m_useLowercase = ( firstChar >= 'a' && firstChar <= 'z' );
+    }
+    else
+    {
+        m_useLowercase = false;
+    }
+
     SetOffset( *offset );
     return true;
 }
@@ -140,5 +163,11 @@ wxString ARRAY_AXIS::GetItemNumber( int n ) const
 
     n = m_offset + m_step * n;
 
-    return AlphabeticFromIndex( n, alphabet, nonUnitColsStartAt0 );
+    wxString result = AlphabeticFromIndex( n, alphabet, nonUnitColsStartAt0 );
+
+    // If the user entered a lowercase starting value, output lowercase letters
+    if( m_useLowercase )
+        result = result.Lower();
+
+    return result;
 }

common/bitmap_base.cpp

@@ -450,7 +450,8 @@ void BITMAP_BASE::Rotate( bool aRotateCCW )
         int resY = m_image->GetOptionInt( wxIMAGE_OPTION_RESOLUTIONY );
         int unit = m_image->GetOptionInt( wxIMAGE_OPTION_RESOLUTIONUNIT );
 
-        *m_image = m_image->Rotate90( aRotateCCW );
+        // wxImage::Rotate90 parameter is "clockwise", so invert for CCW rotation
+        *m_image = m_image->Rotate90( !aRotateCCW );
 
         m_image->SetOption( wxIMAGE_OPTION_RESOLUTIONUNIT, unit );
         m_image->SetOption( wxIMAGE_OPTION_RESOLUTIONX, resX );

common/dialog_about/AboutDialog_main.cpp

@@ -909,7 +909,13 @@ static void buildKicadAboutBanner( EDA_BASE_FRAME* aParent, ABOUT_APP_INFO& aInf
 #define FOOTPRINT_LIB_CONTRIBUTION _( "Footprints" )
     aInfo.AddLibrarian( new CONTRIBUTOR( wxS( "Scripts by Maui" ),
                                          MODELS_3D_CONTRIBUTION,
-                                         wxS( "https://gitlab.com/kicad/libraries/kicad-footprint-generator" ) ) );
+                                         wxS( "https://github.com/easyw" ) ) );
+    aInfo.AddLibrarian( new CONTRIBUTOR( wxS( "Hasan Yavuz Özderya" ),
+                                         MODELS_3D_CONTRIBUTION,
+                                         wxS( "https://bitbucket.org/hyOzd/freecad-macros/src/master/" ) ) );
+    aInfo.AddLibrarian( new CONTRIBUTOR( wxS( "GitHub contributors" ),
+                                         MODELS_3D_CONTRIBUTION,
+                                         wxS( "https://github.com/easyw/kicad-3d-models-in-freecad/graphs/contributors" ) ) );
     aInfo.AddLibrarian( new CONTRIBUTOR( wxS( "GitLab contributors" ),
                                          MODELS_3D_CONTRIBUTION,
                                          wxS( "https://gitlab.com/kicad/libraries/kicad-packages3D/-/graphs/master" ) ) );

common/dialog_shim.cpp

@@ -752,7 +752,10 @@ void DIALOG_SHIM::OnCharHook( wxKeyEvent& aEvt )
 
         for( size_t i = 0; i < m_tabOrder.size(); ++i )
         {
-            if( m_tabOrder[i] == currentWindow )
+            // Check for exact match or if currentWindow is a child of the control
+            // (e.g., the text entry inside a wxComboBox)
+            if( m_tabOrder[i] == currentWindow
+                || ( currentWindow && m_tabOrder[i]->IsDescendant( currentWindow ) ) )
             {
                 currentIdx = (int) i;
                 break;
@@ -763,6 +766,17 @@ void DIALOG_SHIM::OnCharHook( wxKeyEvent& aEvt )
         {
             advance( currentIdx );
 
+            // Skip hidden or disabled controls
+            int startIdx = currentIdx;
+
+            while( !m_tabOrder[currentIdx]->IsShown() || !m_tabOrder[currentIdx]->IsEnabled() )
+            {
+                advance( currentIdx );
+
+                if( currentIdx == startIdx )
+                    break;  // Avoid infinite loop if all controls are hidden
+            }
+
             //todo: We don't currently have non-textentry dialog boxes but this will break if
             // we add them.
 #ifdef __APPLE__

common/dialogs/dialog_hotkey_list.cpp

@@ -39,7 +39,8 @@ DIALOG_LIST_HOTKEYS::DIALOG_LIST_HOTKEYS( EDA_BASE_FRAME* aParent ):
     wxBoxSizer* main_sizer = new wxBoxSizer( wxVERTICAL );
     KIFACE*     kiface = nullptr;
 
-    m_hk_list = new PANEL_HOTKEYS_EDITOR( aParent, this, true );
+    m_hk_list = new PANEL_HOTKEYS_EDITOR( aParent, this );
+    m_hk_list->SetIncludeGestures( true );
 
     wxWindow* kicadMgr_window = wxWindow::FindWindowByName( KICAD_MANAGER_FRAME_NAME );
 
@@ -71,6 +72,7 @@ DIALOG_LIST_HOTKEYS::DIALOG_LIST_HOTKEYS( EDA_BASE_FRAME* aParent ):
 
     wxStdDialogButtonSizer* sdb_sizer = new wxStdDialogButtonSizer;
     sdb_sizer->AddButton( new wxButton( this, wxID_OK ) );
+    sdb_sizer->AddButton( new wxButton( this, wxID_CANCEL ) );
     sdb_sizer->Realize();
 
     main_sizer->Add( sdb_sizer, 0, wxEXPAND | wxALL, margin );

common/dialogs/eda_view_switcher.cpp

@@ -36,7 +36,8 @@
 EDA_VIEW_SWITCHER::EDA_VIEW_SWITCHER( wxWindow* aParent, const wxArrayString& aItems,
                                       wxKeyCode aCtrlKey ) :
         EDA_VIEW_SWITCHER_BASE( aParent ),
-        m_tabState( true ),
+        // Start with the tab marked as "up" so the initial ctrl-tab press advances selection.
+        m_tabState( false ),
         m_receivingEvents( false ),
         m_ctrlKey( aCtrlKey )
 {

common/dialogs/panel_embedded_files.cpp

@@ -90,8 +90,12 @@ void EMBEDDED_FILES_GRID_TRICKS::doPopupSelection( wxCommandEvent& event )
 /* ---------- End of GRID_TRICKS for embedded files grid ---------- */
 
 
-PANEL_EMBEDDED_FILES::PANEL_EMBEDDED_FILES( wxWindow* parent, EMBEDDED_FILES* aFiles ) :
-        PANEL_EMBEDDED_FILES_BASE( parent ), m_files( aFiles ), m_localFiles( new EMBEDDED_FILES() )
+PANEL_EMBEDDED_FILES::PANEL_EMBEDDED_FILES( wxWindow* aParent, EMBEDDED_FILES* aFiles, int aFlags,
+                                            std::vector<const EMBEDDED_FILES*> aInheritedFiles ) :
+        PANEL_EMBEDDED_FILES_BASE( aParent ),
+        m_files( aFiles ),
+        m_localFiles( new EMBEDDED_FILES() ),
+        m_inheritedFiles( std::move( aInheritedFiles ) )
 {
     for( auto& [name, file] : m_files->EmbeddedFileMap() )
     {
@@ -99,6 +103,19 @@ PANEL_EMBEDDED_FILES::PANEL_EMBEDDED_FILES( wxWindow* parent, EMBEDDED_FILES* aF
         m_localFiles->AddFile( newFile );
     }
 
+    for( const EMBEDDED_FILES* inheritedFiles : m_inheritedFiles )
+    {
+        for( auto& [name, file] : inheritedFiles->EmbeddedFileMap() )
+        {
+            if( m_localFiles->HasFile( name ) )
+                continue;
+
+            EMBEDDED_FILES::EMBEDDED_FILE* newFile = new EMBEDDED_FILES::EMBEDDED_FILE( *file );
+            m_localFiles->AddFile( newFile );
+            m_inheritedFileNames.insert( name );
+        }
+    }
+
     // Set up the standard buttons
     m_delete_button->SetBitmap( KiBitmapBundle( BITMAPS::small_trash ) );
     m_browse_button->SetBitmap( KiBitmapBundle( BITMAPS::small_folder ) );
@@ -131,6 +148,7 @@ PANEL_EMBEDDED_FILES::~PANEL_EMBEDDED_FILES()
 {
     // Remove the GRID_TRICKS handler
     m_files_grid->PopEventHandler( true );
+    delete m_localFiles;
 }
 
 
@@ -242,6 +260,9 @@ bool PANEL_EMBEDDED_FILES::TransferDataFromWindow()
 
     for( auto& file : files )
     {
+        if( m_inheritedFileNames.count( file->name ) )
+            continue;
+
         m_files->AddFile( file );
         m_localFiles->RemoveFile( file->name, false );
     }
@@ -378,6 +399,14 @@ bool PANEL_EMBEDDED_FILES::RemoveEmbeddedFile( const wxString& aFileName )
     if( name.StartsWith( FILEEXT::KiCadUriPrefix ) )
         name = name.Mid( FILEEXT::KiCadUriPrefix.size() + 3 );
 
+    if( m_inheritedFileNames.count( name ) )
+    {
+        wxString msg = _( "Embedded files inherited from a parent symbol cannot be removed." );
+
+        DisplayErrorMessage( this, msg );
+        return false;
+    }
+
     int row = std::max( 0, m_files_grid->GetGridCursorRow() );
 
     for( int ii = 0; ii < m_files_grid->GetNumberRows(); ii++ )
@@ -409,14 +438,7 @@ void PANEL_EMBEDDED_FILES::onDeleteEmbeddedFile( wxCommandEvent& event )
 
     wxString name = m_files_grid->GetCellValue( row, 0 );
 
-    m_localFiles->RemoveFile( name );
-
-    m_files_grid->DeleteRows( row );
-
-    if( row < m_files_grid->GetNumberRows() )
-        m_files_grid->SetGridCursor( row, 0 );
-    else if( m_files_grid->GetNumberRows() > 0 )
-        m_files_grid->SetGridCursor( m_files_grid->GetNumberRows() - 1, 0 );
+    RemoveEmbeddedFile( name );
 }
 
 

common/dialogs/panel_embedded_files.h

@@ -24,6 +24,9 @@
 #ifndef PANEL_EMBEDDED_FILES_H
 #define PANEL_EMBEDDED_FILES_H
 
+#include <set>
+#include <vector>
+
 #include <embedded_files.h>
 #include "panel_embedded_files_base.h"
 
@@ -55,7 +58,8 @@ protected:
 class PANEL_EMBEDDED_FILES : public PANEL_EMBEDDED_FILES_BASE
 {
 public:
-    PANEL_EMBEDDED_FILES( wxWindow* parent, EMBEDDED_FILES* aFiles );
+    PANEL_EMBEDDED_FILES( wxWindow* aParent, EMBEDDED_FILES* aFiles, int aFlags = 0,
+                          std::vector<const EMBEDDED_FILES*> aInheritedFiles = {} );
     ~PANEL_EMBEDDED_FILES() override;
 
     bool TransferDataFromWindow() override;
@@ -79,6 +83,8 @@ private:
 
     EMBEDDED_FILES* m_files;
     EMBEDDED_FILES* m_localFiles;
+    std::vector<const EMBEDDED_FILES*> m_inheritedFiles;
+    std::set<wxString>                 m_inheritedFileNames;
 };
 
 

common/dialogs/panel_hotkeys_editor.cpp

@@ -65,11 +65,10 @@ static wxSearchCtrl* CreateTextFilterBox( wxWindow* aParent, const wxString& aDe
 }
 
 
-PANEL_HOTKEYS_EDITOR::PANEL_HOTKEYS_EDITOR( EDA_BASE_FRAME* aFrame, wxWindow* aWindow,
-                                            bool aReadOnly ) :
+PANEL_HOTKEYS_EDITOR::PANEL_HOTKEYS_EDITOR( EDA_BASE_FRAME* aFrame, wxWindow* aWindow ) :
         RESETTABLE_PANEL( aWindow, wxID_ANY, wxDefaultPosition, wxDefaultSize ),
         m_frame( aFrame ),
-        m_readOnly( aReadOnly ),
+        m_includeGestures( false ),
         m_hotkeyStore()
 {
     wxBoxSizer* mainSizer = new wxBoxSizer( wxVERTICAL );
@@ -78,11 +77,10 @@ PANEL_HOTKEYS_EDITOR::PANEL_HOTKEYS_EDITOR( EDA_BASE_FRAME* aFrame, wxWindow* aW
     m_filterSearch = CreateTextFilterBox( this, _( "Type filter text" ) );
     bMargins->Add( m_filterSearch, 0, wxEXPAND | wxTOP | wxRIGHT, 5 );
 
-    m_hotkeyListCtrl = new WIDGET_HOTKEY_LIST( this, m_hotkeyStore, m_readOnly );
+    m_hotkeyListCtrl = new WIDGET_HOTKEY_LIST( this, m_hotkeyStore );
     bMargins->Add( m_hotkeyListCtrl, 1, wxEXPAND | wxTOP | wxRIGHT, 5 );
 
-    if( !m_readOnly )
-        installButtons( bMargins );
+    installButtons( bMargins );
 
     mainSizer->Add( bMargins, 1, wxEXPAND, 0 );
 
@@ -166,7 +164,7 @@ void PANEL_HOTKEYS_EDITOR::installButtons( wxSizer* aSizer )
 
 bool PANEL_HOTKEYS_EDITOR::TransferDataToWindow()
 {
-    m_hotkeyStore.Init( m_actions, m_readOnly );
+    m_hotkeyStore.Init( m_actions, m_includeGestures );
 
     if( !m_hotkeyListCtrl->TransferDataToControl() )
         return false;
@@ -177,9 +175,6 @@ bool PANEL_HOTKEYS_EDITOR::TransferDataToWindow()
 
 bool PANEL_HOTKEYS_EDITOR::TransferDataFromWindow()
 {
-    if( m_readOnly )
-        return true;
-
     if( !m_hotkeyListCtrl->TransferDataFromControl() )
         return false;
 

common/draw_panel_gal.cpp

@@ -626,6 +626,12 @@ void EDA_DRAW_PANEL_GAL::onLostFocus( wxFocusEvent& aEvent )
 
     m_viewControls->CancelDrag();
 
+    // Reset the tool dispatcher's button state when focus is lost. This prevents
+    // the dispatcher from thinking the button is still pressed when focus returns,
+    // which can cause selection and drag operations to stop working.
+    if( m_eventDispatcher )
+        m_eventDispatcher->ResetState();
+
     aEvent.Skip();
 }
 

common/eda_base_frame.cpp

@@ -220,6 +220,12 @@ wxWindow* EDA_BASE_FRAME::findQuasiModalDialog()
 
 void EDA_BASE_FRAME::windowClosing( wxCloseEvent& event )
 {
+    // Guard against re-entrant close events. GTK can deliver a second wxEVT_CLOSE_WINDOW
+    // while we are still processing the first one (e.g. during Destroy() calls), which leads
+    // to use-after-free crashes when child objects have already been torn down.
+    if( m_isClosing )
+        return;
+
     // Don't allow closing when a quasi-modal is open.
     wxWindow* quasiModal = findQuasiModalDialog();
 
@@ -1064,7 +1070,7 @@ void EDA_BASE_FRAME::ShowPreferences( wxString aStartPage, wxString aStartParent
         WX_BUSY_INDICATOR busy_cursor;
 
         WX_TREEBOOK*            book = dlg.GetTreebook();
-        PANEL_HOTKEYS_EDITOR*   hotkeysPanel = new PANEL_HOTKEYS_EDITOR( this, book, false );
+        PANEL_HOTKEYS_EDITOR*   hotkeysPanel = new PANEL_HOTKEYS_EDITOR( this, book );
         KIFACE*                 kiface = nullptr;
         std::vector<int>        expand;
 

common/eda_draw_frame.cpp

@@ -318,7 +318,7 @@ void EDA_DRAW_FRAME::CommonSettingsChanged( int aFlags )
 
     m_galDisplayOptions.ReadCommonConfig( *settings, this );
 
-    GetToolManager()->RunAction( ACTIONS::gridPreset, config()->m_Window.grid.last_size_idx );
+    GetToolManager()->RunAction( ACTIONS::gridPreset, GetWindowSettings( config() )->grid.last_size_idx );
     UpdateGridSelectBox();
 
     if( m_lastToolbarIconSize == 0
@@ -373,7 +373,7 @@ void EDA_DRAW_FRAME::UpdateGridSelectBox()
 
     wxCHECK( config(), /* void */ );
 
-    GRID_MENU::BuildChoiceList( &gridsList, config(), this );
+    GRID_MENU::BuildChoiceList( &gridsList, GetWindowSettings( config() ), this );
 
     for( const wxString& grid : gridsList )
         m_gridSelectBox->Append( grid );
@@ -381,7 +381,7 @@ void EDA_DRAW_FRAME::UpdateGridSelectBox()
     m_gridSelectBox->Append( wxT( "---" ) );
     m_gridSelectBox->Append( _( "Edit Grids..." ) );
 
-    m_gridSelectBox->SetSelection( config()->m_Window.grid.last_size_idx );
+    m_gridSelectBox->SetSelection( GetWindowSettings( config() )->grid.last_size_idx );
 }
 
 
@@ -394,7 +394,7 @@ void EDA_DRAW_FRAME::OnUpdateSelectGrid( wxUpdateUIEvent& aEvent )
 
     wxCHECK( config(), /* void */ );
 
-    int idx = config()->m_Window.grid.last_size_idx;
+    int idx = GetWindowSettings( config() )->grid.last_size_idx;
     idx = std::clamp( idx, 0, (int) m_gridSelectBox->GetCount() - 1 );
 
     if( idx != m_gridSelectBox->GetSelection() )
@@ -414,10 +414,10 @@ void EDA_DRAW_FRAME::OnUpdateSelectZoom( wxUpdateUIEvent& aEvent )
 
     wxCHECK( config(), /* void */ );
 
-    const std::vector<double>& zoomList = config()->m_Window.zoom_factors;
-    int curr_selection = m_zoomSelectBox->GetSelection();
-    int new_selection = 0;      // select zoom auto
-    double last_approx = 1e9;   // large value to start calculation
+    const std::vector<double>& zoomList = GetWindowSettings( config() )->zoom_factors;
+    int                        curr_selection = m_zoomSelectBox->GetSelection();
+    int                        new_selection = 0;      // select zoom auto
+    double                     last_approx = 1e9;      // large value to start calculation
 
     // Search for the nearest available value to the current zoom setting, and select it
     for( size_t jj = 0; jj < zoomList.size(); ++jj )
@@ -484,11 +484,11 @@ void EDA_DRAW_FRAME::OnSelectGrid( wxCommandEvent& event )
 }
 
 
-bool EDA_DRAW_FRAME::IsGridVisible() const
+bool EDA_DRAW_FRAME::IsGridVisible()
 {
     wxCHECK( config(), true );
 
-    return config()->m_Window.grid.show;
+    return GetWindowSettings( config() )->grid.show;
 }
 
 
@@ -496,7 +496,7 @@ void EDA_DRAW_FRAME::SetGridVisibility( bool aVisible )
 {
     wxCHECK( config(), /* void */ );
 
-    config()->m_Window.grid.show = aVisible;
+    GetWindowSettings( config() )->grid.show = aVisible;
 
     // Update the display with the new grid
     if( GetCanvas() )
@@ -514,11 +514,11 @@ void EDA_DRAW_FRAME::SetGridVisibility( bool aVisible )
 }
 
 
-bool EDA_DRAW_FRAME::IsGridOverridden() const
+bool EDA_DRAW_FRAME::IsGridOverridden()
 {
     wxCHECK( config(), false );
 
-    return config()->m_Window.grid.overrides_enabled;
+    return GetWindowSettings( config() )->grid.overrides_enabled;
 }
 
 
@@ -526,7 +526,7 @@ void EDA_DRAW_FRAME::SetGridOverrides( bool aOverride )
 {
     wxCHECK( config(), /* void */ );
 
-    config()->m_Window.grid.overrides_enabled = aOverride;
+    GetWindowSettings( config() )->grid.overrides_enabled = aOverride;
 }
 
 
@@ -549,14 +549,14 @@ void EDA_DRAW_FRAME::UpdateZoomSelectBox()
 
     wxCHECK( config(), /* void */ );
 
-    for( unsigned i = 0;  i < config()->m_Window.zoom_factors.size();  ++i )
+    for( unsigned ii = 0;  ii < GetWindowSettings( config() )->zoom_factors.size();  ++ii )
     {
-        double current = config()->m_Window.zoom_factors[i];
+        double current = GetWindowSettings( config() )->zoom_factors[ii];
 
         m_zoomSelectBox->Append( wxString::Format( _( "Zoom %.2f" ), current ) );
 
         if( zoom == current )
-            m_zoomSelectBox->SetSelection( i + 1 );
+            m_zoomSelectBox->SetSelection( ii + 1 );
     }
 }
 

common/eda_text.cpp

@@ -189,14 +189,14 @@ void EDA_TEXT::Serialize( google::protobuf::Any &aContainer ) const
     using namespace kiapi::common;
     types::Text text;
 
-    text.set_text( GetText().ToStdString() );
-    text.set_hyperlink( GetHyperlink().ToStdString() );
+    text.set_text( GetText().ToUTF8() );
+    text.set_hyperlink( GetHyperlink().ToUTF8() );
     PackVector2( *text.mutable_position(), GetTextPos() );
 
     types::TextAttributes* attrs = text.mutable_attributes();
 
     if( GetFont() )
-        attrs->set_font_name( GetFont()->GetName().ToStdString() );
+        attrs->set_font_name( GetFont()->GetName().ToUTF8() );
 
     attrs->set_horizontal_alignment(
             ToProtoEnum<GR_TEXT_H_ALIGN_T, types::HorizontalAlignment>( GetHorizJustify() ) );

common/embedded_files.cpp

@@ -591,6 +591,21 @@ EMBEDDED_FILES::EMBEDDED_FILES( const EMBEDDED_FILES& other ) :
 }
 
 
+EMBEDDED_FILES::EMBEDDED_FILES( const EMBEDDED_FILES& other, bool aDeepCopy ) :
+        m_embedFonts( other.m_embedFonts )
+{
+    if( aDeepCopy )
+    {
+        for( const auto& [name, file] : other.m_files )
+            m_files[name] = new EMBEDDED_FILE( *file );
+
+        m_fontFiles = other.m_fontFiles;
+    }
+
+    m_fileAddedCallback = other.m_fileAddedCallback;
+}
+
+
 // Copy assignment operator
 EMBEDDED_FILES& EMBEDDED_FILES::operator=( const EMBEDDED_FILES& other )
 {

common/font/outline_font.cpp

@@ -355,7 +355,7 @@ VECTOR2I OUTLINE_FONT::getTextAsGlyphsUnlocked( BOX2I* aBBox,
                                                 // contents
 
     hb_font_t* referencedFont = hb_ft_font_create_referenced( face );
-    hb_ft_font_set_funcs( referencedFont );
+
     hb_shape( referencedFont, buf, nullptr, 0 );
 
     unsigned int         glyphCount;
@@ -376,10 +376,6 @@ VECTOR2I OUTLINE_FONT::getTextAsGlyphsUnlocked( BOX2I* aBBox,
 
     for( unsigned int i = 0; i < glyphCount; i++ )
     {
-        // Don't process glyphs that were already included in a previous cluster
-        if( i > 0 && glyphInfo[i].cluster == glyphInfo[i-1].cluster )
-            continue;
-
         if( aGlyphs )
         {
             GLYPH_CACHE_KEY key = { face, glyphInfo[i].codepoint, scaleFactor, m_forDrawingSheet,
@@ -557,9 +553,8 @@ void OUTLINE_FONT::RenderToOpenGLCanvas( KIGFX::OPENGL_GAL& aGal, const wxString
 
     std::lock_guard<std::mutex> guard( m_freeTypeMutex );
 
-    hb_font_t*           referencedFont = hb_ft_font_create_referenced( m_face );
+    hb_font_t* referencedFont = hb_ft_font_create_referenced( m_face );
 
-    hb_ft_font_set_funcs( referencedFont );
     hb_shape( referencedFont, buf, nullptr, 0 );
 
     const double mirror_factor = ( aIsMirrored ? 1 : -1 );

common/gal/cairo/cairo_gal.cpp

@@ -29,6 +29,7 @@
 
 #include <wx/image.h>
 #include <wx/log.h>
+#include <wx/dcclient.h>
 
 #include <gal/cairo/cairo_gal.h>
 #include <gal/cairo/cairo_compositor.h>
@@ -1650,6 +1651,10 @@ void CAIRO_GAL::setCompositor()
 
 void CAIRO_GAL::onPaint( wxPaintEvent& aEvent )
 {
+    // A wxPaintDC must be created in wxEVT_PAINT handlers. Without this, the system keeps
+    // sending paint events because it thinks the window still needs to be painted, causing
+    // high CPU usage in fallback mode (Cairo).
+    wxPaintDC dc( this );
     PostPaint( aEvent );
 }
 

common/gestfich.cpp

@@ -38,12 +38,15 @@
 #include <string_utils.h>
 #include <launch_ext.h>
 #include "wx/tokenzr.h"
+#include <sexpr/sexpr.h>
+#include <sexpr/sexpr_parser.h>
 
 #include <wx/wfstream.h>
 #include <wx/fs_zip.h>
 #include <wx/zipstrm.h>
 
 #include <filesystem>
+#include <core/kicad_algo.h>
 
 void QuoteString( wxString& string )
 {
@@ -302,6 +305,79 @@ void KiCopyFile( const wxString& aSrcPath, const wxString& aDestPath, wxString&
 }
 
 
+static void traverseSEXPR( SEXPR::SEXPR* aNode, const std::function<void( SEXPR::SEXPR* )>& aVisitor )
+{
+    aVisitor( aNode );
+
+    if( aNode->IsList() )
+    {
+        for( unsigned i = 0; i < aNode->GetNumberOfChildren(); i++ )
+            traverseSEXPR( aNode->GetChild( i ), aVisitor );
+    }
+}
+
+
+void CopySexprFile( const wxString& aSrcPath, const wxString& aDestPath,
+                    std::function<bool( const std::string& token, wxString& value )> aCallback,
+                    wxString& aErrors )
+{
+    bool success = false;
+
+    try
+    {
+        SEXPR::PARSER parser;
+        std::unique_ptr<SEXPR::SEXPR> sexpr( parser.ParseFromFile( TO_UTF8( aSrcPath ) ) );
+
+        traverseSEXPR( sexpr.get(),
+                [&]( SEXPR::SEXPR* node )
+                {
+                    if( node->IsList() && node->GetNumberOfChildren() > 1 && node->GetChild( 0 )->IsSymbol() )
+                    {
+                        std::string          token = node->GetChild( 0 )->GetSymbol();
+                        SEXPR::SEXPR_STRING* pathNode = dynamic_cast<SEXPR::SEXPR_STRING*>( node->GetChild( 1 ) );
+                        SEXPR::SEXPR_SYMBOL* symNode = dynamic_cast<SEXPR::SEXPR_SYMBOL*>( node->GetChild( 1 ) );
+                        wxString             path;
+
+                        if( pathNode )
+                            path = pathNode->m_value;
+                        else if( symNode )
+                            path = symNode->m_value;
+
+                        if( aCallback( token, path ) )
+                        {
+                            if( pathNode )
+                                pathNode->m_value = path;
+                            else if( symNode )
+                                symNode->m_value = path;
+                        }
+                    }
+                } );
+
+        wxFFile destFile( aDestPath, "wb" );
+
+        if( destFile.IsOpened() )
+            success = destFile.Write( sexpr->AsString( 0 ) );
+
+        // wxFFile dtor will close the file
+    }
+    catch( ... )
+    {
+        success = false;
+    }
+
+    if( !success )
+    {
+        wxString msg;
+
+        if( !aErrors.empty() )
+            aErrors += wxS( "\n" );
+
+        msg.Printf( _( "Cannot copy file '%s'." ), aDestPath );
+        aErrors += msg;
+    }
+}
+
+
 wxString QuoteFullPath( wxFileName& fn, wxPathFormat format )
 {
     return wxT( "\"" ) + fn.GetFullPath( format ) + wxT( "\"" );
@@ -347,8 +423,7 @@ bool RmDirRecursive( const wxString& aFileName, wxString* aErrors )
     catch( const fs::filesystem_error& e )
     {
         if( aErrors )
-            *aErrors = wxString::Format( _( "Error removing directory '%s': %s" ),
-                                         aFileName, e.what() );
+            *aErrors = wxString::Format( _( "Error removing directory '%s': %s" ), aFileName, e.what() );
 
         return false;
     }
@@ -357,7 +432,8 @@ bool RmDirRecursive( const wxString& aFileName, wxString* aErrors )
 }
 
 
-bool CopyDirectory( const wxString& aSourceDir, const wxString& aDestDir, wxString& aErrors )
+bool CopyDirectory( const wxString& aSourceDir, const wxString& aDestDir,
+                    const std::vector<wxString>& aPathsWithOverwriteDisallowed, wxString& aErrors )
 {
     wxDir dir( aSourceDir );
 
@@ -380,23 +456,25 @@ bool CopyDirectory( const wxString& aSourceDir, const wxString& aDestDir, wxStri
 
     while( cont )
     {
-        wxString sourcePath = aSourceDir + wxFileName::GetPathSeparator() + filename;
+        wxString sourcePath = dir.GetNameWithSep() + filename;
         wxString destPath = aDestDir + wxFileName::GetPathSeparator() + filename;
 
         if( wxFileName::DirExists( sourcePath ) )
         {
             // Recursively copy subdirectories
-            if( !CopyDirectory( sourcePath, destPath, aErrors ) )
+            if( !CopyDirectory( sourcePath, destPath, aPathsWithOverwriteDisallowed, aErrors ) )
                 return false;
         }
         else
         {
             // Copy files
-            if( !wxCopyFile( sourcePath, destPath ) )
+            if( alg::contains( aPathsWithOverwriteDisallowed, sourcePath ) && wxFileExists( destPath ) )
             {
-                aErrors += wxString::Format( _( "Could not copy file: %s to %s" ),
-                                             sourcePath,
-                                             destPath );
+                // Presumably user does not want an error on a no-overwrite condition....
+            }
+            else if( !wxCopyFile( sourcePath, destPath ) )
+            {
+                aErrors += wxString::Format( _( "Could not copy file: %s to %s" ), sourcePath, destPath );
                 return false;
             }
         }
@@ -408,8 +486,8 @@ bool CopyDirectory( const wxString& aSourceDir, const wxString& aDestDir, wxStri
 }
 
 
-bool CopyFilesOrDirectory( const wxString& aSourcePath, const wxString& aDestDir, wxString& aErrors,
-                           int& aFileCopiedCount, const std::vector<wxString>& aExclusions )
+bool CopyFilesOrDirectory( const wxString& aSourcePath, const wxString& aDestDir, bool aAllowOverwrites,
+                           wxString& aErrors, std::vector<wxString>& aPathsWritten )
 {
     // Parse source path and determine if it's a directory
     wxFileName sourceFn( aSourcePath );
@@ -417,85 +495,72 @@ bool CopyFilesOrDirectory( const wxString& aSourcePath, const wxString& aDestDir
     bool       isSourceDirectory = wxFileName::DirExists( sourcePath );
     wxString   baseDestDir = aDestDir;
 
-    auto performCopy = [&]( const wxString& src, const wxString& dest ) -> bool
-    {
-        if( wxCopyFile( src, dest ) )
-        {
-            aFileCopiedCount++;
-            return true;
-        }
-
-        aErrors += wxString::Format( _( "Could not copy file: %s to %s" ), src, dest );
-        aErrors += wxT( "\n" );
-        return false;
-    };
-
-    auto processEntries = [&]( const wxString& srcDir, const wxString& pattern,
-                               const wxString& destDir ) -> bool
-    {
-        wxDir dir( srcDir );
-
-        if( !dir.IsOpened() )
-        {
-            aErrors += wxString::Format( _( "Could not open source directory: %s" ), srcDir );
-            aErrors += wxT( "\n" );
-            return false;
-        }
-
-        wxString filename;
-        bool     success = true;
-
-        // Find all entries matching pattern (files + directories + hidden items)
-        bool cont = dir.GetFirst( &filename, pattern, wxDIR_FILES | wxDIR_DIRS | wxDIR_HIDDEN );
-
-        while( cont )
-        {
-            const wxString entrySrc = srcDir + wxFileName::GetPathSeparator() + filename;
-            const wxString entryDest = destDir + wxFileName::GetPathSeparator() + filename;
-
-            // Apply exclusion filters
-            bool exclude =
-                    filename.Matches( wxT( "~*.lck" ) ) || filename.Matches( wxT( "*.lck" ) );
-
-            for( const auto& exclusion : aExclusions )
+    auto performCopy =
+            [&]( const wxString& src, const wxString& dest ) -> bool
             {
-                if( entrySrc.Matches( exclusion ) )
+                if( wxCopyFile( src, dest, aAllowOverwrites ) )
                 {
-                    exclude = true;
-                    break;
+                    aPathsWritten.push_back( dest );
+                    return true;
                 }
-            }
 
-            if( !exclude )
+                aErrors += wxString::Format( _( "Could not copy file: %s to %s" ), src, dest );
+                aErrors += wxT( "\n" );
+                return false;
+            };
+
+    auto processEntries =
+            [&]( const wxString& srcDir, const wxString& pattern, const wxString& destDir ) -> bool
             {
-                if( wxFileName::DirExists( entrySrc ) )
+                wxDir dir( srcDir );
+
+                if( !dir.IsOpened() )
                 {
-                    // Recursively process subdirectories
-                    if( !CopyFilesOrDirectory( entrySrc, destDir, aErrors, aFileCopiedCount,
-                                               aExclusions ) )
-                    {
-                        aErrors += wxString::Format( _( "Could not copy directory: %s to %s" ),
-                                                     entrySrc, entryDest );
-                        aErrors += wxT( "\n" );
-
-                        success = false;
-                    }
+                    aErrors += wxString::Format( _( "Could not open source directory: %s" ), srcDir );
+                    aErrors += wxT( "\n" );
+                    return false;
                 }
-                else
+
+                wxString filename;
+                bool     success = true;
+
+                // Find all entries matching pattern (files + directories + hidden items)
+                bool cont = dir.GetFirst( &filename, pattern, wxDIR_FILES | wxDIR_DIRS | wxDIR_HIDDEN );
+
+                while( cont )
                 {
-                    // Copy individual files
-                    if( !performCopy( entrySrc, entryDest ) )
+                    const wxString entrySrc = srcDir + wxFileName::GetPathSeparator() + filename;
+                    const wxString entryDest = destDir + wxFileName::GetPathSeparator() + filename;
+
+                    if( !filename.Matches( wxT( "~*.lck" ) ) && !filename.Matches( wxT( "*.lck" ) ) )
                     {
-                        success = false;
+                        if( wxFileName::DirExists( entrySrc ) )
+                        {
+                            // Recursively process subdirectories
+                            if( !CopyFilesOrDirectory( entrySrc, destDir, aAllowOverwrites, aErrors, aPathsWritten ) )
+                            {
+                                aErrors += wxString::Format( _( "Could not copy directory: %s to %s" ),
+                                                             entrySrc, entryDest );
+                                aErrors += wxT( "\n" );
+
+                                success = false;
+                            }
+                        }
+                        else
+                        {
+                            // Copy individual files
+                            if( !performCopy( entrySrc, entryDest ) )
+                            {
+                                success = false;
+                            }
+                        }
                     }
+
+                    cont = dir.GetNext( &filename );
                 }
-            }
 
-            cont = dir.GetNext( &filename );
-        }
-
-        return success;
-    };
+                return success;
+            };
 
     // If copying a directory, append its name to destination path
     if( isSourceDirectory )
@@ -507,8 +572,7 @@ bool CopyFilesOrDirectory( const wxString& aSourcePath, const wxString& aDestDir
     // Create destination directory hierarchy
     if( !wxFileName::Mkdir( baseDestDir, wxS_DIR_DEFAULT, wxPATH_MKDIR_FULL ) )
     {
-        aErrors +=
-                wxString::Format( _( "Could not create destination directory: %s" ), baseDestDir );
+        aErrors += wxString::Format( _( "Could not create destination directory: %s" ), baseDestDir );
         aErrors += wxT( "\n" );
 
         return false;
@@ -531,6 +595,7 @@ bool CopyFilesOrDirectory( const wxString& aSourcePath, const wxString& aDestDir
 
                 return false;
             }
+
             // Process all matching files in source directory
             return processEntries( dirPath, fileName, baseDestDir );
         }

common/git/git_pull_handler.cpp

@@ -378,6 +378,14 @@ PullResult GIT_PULL_HANDLER::handleFastForward()
 PullResult GIT_PULL_HANDLER::handleMerge( const git_annotated_commit** aMergeHeads,
                                           size_t                       aMergeHeadsCount )
 {
+    if( hasUnstagedChanges( GetRepo() ) )
+    {
+        AddErrorString(
+                _( "Cannot merge: you have unstaged changes. "
+                   "Please commit or stash them before pulling." ) );
+        return PullResult::DirtyWorkdir;
+    }
+
     git_merge_options merge_opts;
     git_merge_options_init( &merge_opts, GIT_MERGE_OPTIONS_VERSION );
 
@@ -481,6 +489,14 @@ PullResult GIT_PULL_HANDLER::handleMerge( const git_annotated_commit** aMergeHea
 
 PullResult GIT_PULL_HANDLER::handleRebase( const git_annotated_commit** aMergeHeads, size_t aMergeHeadsCount )
 {
+    if( hasUnstagedChanges( GetRepo() ) )
+    {
+        AddErrorString(
+                _( "Cannot rebase: you have unstaged changes. "
+                   "Please commit or stash them before pulling." ) );
+        return PullResult::DirtyWorkdir;
+    }
+
     // Get the current branch reference
     git_reference* head_ref = nullptr;
 
@@ -563,6 +579,40 @@ PullResult GIT_PULL_HANDLER::handleRebase( const git_annotated_commit** aMergeHe
 }
 
 
+bool GIT_PULL_HANDLER::hasUnstagedChanges( git_repository* aRepo )
+{
+    if( !aRepo )
+        return false;
+
+    git_status_options opts;
+    git_status_init_options( &opts, GIT_STATUS_OPTIONS_VERSION );
+
+    opts.show = GIT_STATUS_SHOW_WORKDIR_ONLY;
+    opts.flags = GIT_STATUS_OPT_INCLUDE_UNTRACKED;
+
+    git_status_list* status_list = nullptr;
+
+    if( git_status_list_new( &status_list, aRepo, &opts ) != GIT_OK )
+    {
+        wxLogTrace( traceGit, "Failed to get status list: %s", KIGIT_COMMON::GetLastGitError() );
+        return false;
+    }
+
+    KIGIT::GitStatusListPtr status_list_ptr( status_list );
+    size_t count = git_status_list_entrycount( status_list );
+
+    for( size_t ii = 0; ii < count; ++ii )
+    {
+        const git_status_entry* entry = git_status_byindex( status_list, ii );
+
+        if( entry->status & ( GIT_STATUS_WT_MODIFIED | GIT_STATUS_WT_DELETED | GIT_STATUS_WT_TYPECHANGE ) )
+            return true;
+    }
+
+    return false;
+}
+
+
 void GIT_PULL_HANDLER::UpdateProgress( int aCurrent, int aTotal, const wxString& aMessage )
 {
 

common/git/git_pull_handler.h

@@ -43,6 +43,7 @@ struct CommitDetails
 // Enum for result codes, error codes are negative, success codes are positive
 enum class PullResult : int
 {
+    DirtyWorkdir = -3,
     MergeFailed = -2,
     Error = -1,
     Success = 0,
@@ -86,6 +87,8 @@ private:
     PullResult  handleFastForward();
     PullResult  handleMerge( const git_annotated_commit** aMergeHeads, size_t aMergeHeadsCount );
     PullResult  handleRebase( const git_annotated_commit** aMergeHeads, size_t aMergeHeadsCount );
+
+    static bool hasUnstagedChanges( git_repository* aRepo );
 };
 
 #endif // _GIT_PULL_HANDLER_H_

common/git/kicad_git_common.cpp

@@ -258,7 +258,7 @@ std::pair<std::set<wxString>,std::set<wxString>> KIGIT_COMMON::GetDifferentFiles
         std::set<wxString> modified_set;
         git_revwalk* walker = nullptr;
 
-        if( !m_repo || !from_oid )
+        if( !m_repo || !from_oid || IsCancelled() )
             return modified_set;
 
         if( git_revwalk_new( &walker, m_repo ) != GIT_OK )
@@ -286,6 +286,10 @@ std::pair<std::set<wxString>,std::set<wxString>> KIGIT_COMMON::GetDifferentFiles
         // iterate over all local commits not in remote
         while( git_revwalk_next( &oid, walker ) == GIT_OK )
         {
+            // Check for cancellation to allow early exit during shutdown
+            if( IsCancelled() )
+                return modified_set;
+
             if( git_commit_lookup( &commit, m_repo, &oid ) != GIT_OK )
             {
                 wxLogTrace( traceGit, "Failed to lookup commit: %s", KIGIT_COMMON::GetLastGitError() );
@@ -371,7 +375,7 @@ std::pair<std::set<wxString>,std::set<wxString>> KIGIT_COMMON::GetDifferentFiles
 
     std::pair<std::set<wxString>,std::set<wxString>> modified_files;
 
-    if( !m_repo )
+    if( !m_repo || IsCancelled() )
         return modified_files;
 
     git_reference* head = nullptr;

common/git/kicad_git_common.h

@@ -26,6 +26,7 @@
 
 #include <git/kicad_git_errors.h>
 
+#include <atomic>
 #include <git2.h>
 #include <mutex>
 #include <set>
@@ -138,6 +139,12 @@ public:
 
     int HandleSSHAgentAuthentication( git_cred** aOut, const wxString& aUsername );
 
+    bool IsCancelled() const { return m_cancel.load(); }
+
+    void SetCancelled( bool aCancel ) { m_cancel.store( aCancel ); }
+
+    std::mutex& GetMutex() { return m_gitActionMutex; }
+
     static wxString GetLastGitError()
     {
         const git_error* error = git_error_last();
@@ -174,6 +181,8 @@ private:
     int m_nextPublicKey;
     bool m_secretFetched;
 
+    std::atomic<bool> m_cancel{ false };
+
     // Create a dummy flag to tell if we have tested ssh agent credentials separately
     // from the ssh key credentials
     static const unsigned KIGIT_CREDENTIAL_SSH_AGENT = 1 << sizeof( m_testedTypes - 1 );

common/hotkeys_basic.cpp

@@ -324,7 +324,9 @@ int KeyCodeFromKeyName( const wxString& keyname )
 void DisplayHotkeyList( EDA_BASE_FRAME* aParent )
 {
     DIALOG_LIST_HOTKEYS dlg( aParent );
-    dlg.ShowModal();
+
+    if( dlg.ShowModal() == wxID_OK )
+        dlg.Kiway().CommonSettingsChanged( HOTKEYS_CHANGED );
 }
 
 

common/http_lib/http_lib_connection.cpp

@@ -323,11 +323,7 @@ bool HTTP_LIB_CONNECTION::SelectAll( const HTTP_LIB_CATEGORY& aCategory, std::ve
             part.id = item.at( "id" );
 
             if( item.contains( "description" ) )
-            {
-                // At this point we don't display anything so just set it to false
-                part.fields.push_back( std::make_pair( "description",
-                                                       std::make_tuple( item.at( "description" ), false ) ) );
-            }
+                part.desc = item.at( "description" );
 
             // API might not want to return an optional name.
             if( item.contains( "name" ) )

common/import_gfx/graphics_importer_buffer.cpp

@@ -132,10 +132,12 @@ void GRAPHICS_IMPORTER_BUFFER::ImportTo( GRAPHICS_IMPORTER& aImporter )
     // the graphics in the KiCad drawing area.
     else if( aImporter.GetImportOffsetMM() == VECTOR2D( 0, 0 ) )
     {
-        if( boundingBox.GetRight() > std::numeric_limits<int>::max()
-            || boundingBox.GetBottom() > std::numeric_limits<int>::max()
-            || boundingBox.GetLeft() < std::numeric_limits<int>::min()
-            || boundingBox.GetTop() < std::numeric_limits<int>::min() )
+        double iuFactor = aImporter.GetMillimeterToIuFactor();
+
+        if( boundingBox.GetRight() * iuFactor > std::numeric_limits<int>::max()
+            || boundingBox.GetBottom() * iuFactor > std::numeric_limits<int>::max()
+            || boundingBox.GetLeft() * iuFactor < std::numeric_limits<int>::min()
+            || boundingBox.GetTop() * iuFactor < std::numeric_limits<int>::min() )
         {
             VECTOR2D offset = boundingBox.GetOrigin();
             aImporter.SetImportOffsetMM( -offset );

common/io/altium/altium_binary_parser.cpp

@@ -382,7 +382,7 @@ std::map<wxString, wxString> ALTIUM_BINARY_PARSER::ReadProperties(
 
     // we use std::string because std::string can handle NULL-bytes
     // wxString would end the string at the first NULL-byte
-    std::string str = std::string( m_pos, length - ( hasNullByte ? 1 : 0 ) );
+    std::string str = std::string( m_pos, length - ( ( hasNullByte && !isBinary ) ? 1 : 0 ) );
     m_pos += length;
 
     if( isBinary )

common/io/eagle/eagle_parser.cpp

@@ -327,7 +327,8 @@ bool EURN::IsValid() const
         "footprint",
         "library",
         "package",
-        "symbol"
+        "symbol",
+        "fs.file"
     };
 
     if( validAssetTypes.count( assetType ) == 0 )
@@ -407,11 +408,29 @@ EROT Convert<EROT>( const wxString& aRot )
 
     value.spin    = aRot.find( 'S' ) != aRot.npos;
     value.mirror  = aRot.find( 'M' ) != aRot.npos;
-    value.degrees = strtod( aRot.c_str()
-                            + 1                        // skip leading 'R'
-                            + int( value.spin )       // skip optional leading 'S'
-                            + int( value.mirror ),    // skip optional leading 'M'
-                            nullptr );
+
+    size_t rPos = aRot.find( 'R' );
+
+    if( rPos == wxString::npos )
+    {
+        value.degrees = 0.0;
+        return value;
+    }
+
+    // Calculate the offset after 'R', 'S', and 'M'
+    size_t offset;
+
+    for( offset = 0; offset < aRot.size(); offset++ )
+    {
+        if( wxIsdigit( aRot[offset] ) )
+            break;
+    }
+
+    wxString degreesStr = aRot.Mid( offset );
+
+    // Use locale-independent conversion
+    if( !degreesStr.ToCDouble( &value.degrees ) )
+        value.degrees = 0.0;
 
     return value;
 }

common/io/eagle/eagle_parser.h

@@ -428,6 +428,9 @@ struct EAGLE_BASE
  *   The "/<VERSION>" is omitted when referencing the asset without specifying a particular version.
  *   For example, "urn:adsk.eagle:component:60986/2" references version 2 of component 60986 and
  *   "urn:adsk.eagle:library:60968" references library 60986 without specifying a version.
+ * 
+ * Autodesk Fusion can use a different format instead, e.g.:
+ * "urn:adsk.wipprod:fs.file:vf.RSKzNVZVQPeDNm7Bnfr3WQ"
  */
 struct EURN : public EAGLE_BASE
 {

common/io/easyedapro/easyedapro_import_utils.cpp

@@ -72,7 +72,17 @@ EASYEDAPRO::ProjectToSelectorDialog( const nlohmann::json& aProject, bool aPcbOn
 
     std::map<wxString, EASYEDAPRO::PRJ_SCHEMATIC> prjSchematics = aProject.at( "schematics" );
     std::map<wxString, EASYEDAPRO::PRJ_BOARD>     prjBoards = aProject.at( "boards" );
-    std::map<wxString, wxString>                  prjPcbNames = aProject.at( "pcbs" );
+
+    std::map<wxString, wxString>       prjPcbNames;
+    std::map<wxString, nlohmann::json> prjPcbs = aProject.at( "pcbs" );
+
+    for( const auto& [pcbUuid, pcbJsonEntry] : prjPcbs )
+    {
+        if( pcbJsonEntry.is_string() )
+            prjPcbNames.emplace( pcbUuid, pcbJsonEntry );
+        else if( pcbJsonEntry.is_object() )
+            prjPcbNames.emplace( pcbUuid, pcbJsonEntry.at( "title" ) );
+    }
 
     for( const auto& [prjName, board] : prjBoards )
     {

common/io/easyedapro/easyedapro_parser.cpp

@@ -220,7 +220,7 @@ void EASYEDAPRO::from_json( const nlohmann::json& j, EASYEDAPRO::PRJ_SYMBOL& d )
     if( j.at( "type" ).is_number() )
         d.type = j.at( "type" );
 
-    if( j.at( "tags" ).is_object() )
+    if( j.find( "tags" ) != j.end() && j.at( "tags" ).is_object() )
         d.tags = j.at( "tags" );
 
     if( j.find( "custom_tags" ) != j.end() && j.at( "custom_tags" ).is_object() )
@@ -249,7 +249,7 @@ void EASYEDAPRO::from_json( const nlohmann::json& j, EASYEDAPRO::PRJ_FOOTPRINT&
     if( j.at( "type" ).is_number() )
         d.type = j.at( "type" );
 
-    if( j.at( "tags" ).is_object() )
+    if( j.find( "tags" ) != j.end() && j.at( "tags" ).is_object() )
         d.tags = j.at( "tags" );
 
     if( j.find( "custom_tags" ) != j.end() && j.at( "custom_tags" ).is_object() )
@@ -275,7 +275,7 @@ void EASYEDAPRO::from_json( const nlohmann::json& j, EASYEDAPRO::PRJ_DEVICE& d )
     if( j.at( "version" ).is_string() )
         d.version = j.at( "version" ).get<wxString>();
 
-    if( j.at( "tags" ).is_object() )
+    if( j.find( "tags" ) != j.end() && j.at( "tags" ).is_object() )
         d.tags = j.at( "tags" );
 
     if( j.find( "custom_tags" ) != j.end() && j.at( "custom_tags" ).is_object() )

common/jobs/job.cpp

@@ -97,27 +97,24 @@ void PrependDirectoryToPath( wxFileName& aFileName, const wxString aDirPath )
 }
 
 
-wxString JOB::GetFullOutputPath( PROJECT* aProject ) const
+wxString JOB::ResolveOutputPath( const wxString& aPath, bool aPathIsDirectory, PROJECT* aProject ) const
 {
     std::function<bool( wxString* )> textResolver =
             [&]( wxString* token ) -> bool
             {
                 if( m_titleBlock.TextVarResolver( token, aProject ) )
                     return true;
-
                 if( aProject )
                     return aProject->TextVarResolver( token );
-
                 return false;
             };
 
-    // use the working output path (nonsaved) over the configured path if its not empty
-    wxString outPath = m_workingOutputPath.IsEmpty() ? m_outputPath : m_workingOutputPath;
+    wxString outPath = aPath;
     outPath = ExpandTextVars( outPath, &textResolver );
 
     if( !m_tempOutputDirectory.IsEmpty() )
     {
-        if( m_outputPathIsDirectory )
+        if( aPathIsDirectory )
         {
             wxFileName fn( outPath );
 
@@ -144,12 +141,19 @@ wxString JOB::GetFullOutputPath( PROJECT* aProject ) const
 
             return fn.GetFullPath();
         }
-	}
+    }
 
     return outPath;
 }
 
 
+wxString JOB::GetFullOutputPath( PROJECT* aProject ) const
+{
+    return ResolveOutputPath( m_workingOutputPath.IsEmpty() ? m_outputPath : m_workingOutputPath,
+                              m_outputPathIsDirectory, aProject );
+}
+
+
 void JOB::SetConfiguredOutputPath( const wxString& aPath )
 {
     m_outputPath = aPath;

common/jobs/job.h

@@ -249,6 +249,8 @@ public:
      */
     wxString GetFullOutputPath( PROJECT* aProject ) const;
 
+    wxString ResolveOutputPath( const wxString& aPath, bool aPathIsDirectory, PROJECT* aProject ) const;
+
     bool GetOutputPathIsDirectory() const { return m_outputPathIsDirectory; }
 
 protected:
@@ -261,6 +263,11 @@ protected:
     wxString m_outputPath;
     bool     m_outputPathIsDirectory;
     wxString m_description;
+
+    /**
+     * The working output path is a transient path that takes priority over the configured
+     * output path when determining where to write output files.
+     */
     wxString m_workingOutputPath;
 
     std::vector<JOB_PARAM_BASE*> m_params;

common/jobs/job_export_pcb_drill.cpp

@@ -70,7 +70,8 @@ JOB_EXPORT_PCB_DRILL::JOB_EXPORT_PCB_DRILL() :
         m_zeroFormat( ZEROS_FORMAT::DECIMAL ),
         m_mapFormat( MAP_FORMAT::PDF ),
         m_gerberPrecision( 5 ),
-        m_generateMap( false )
+        m_generateMap( false ),
+        m_generateReport( false )
 {
     m_params.emplace_back( new JOB_PARAM<bool>( "excellon.mirror_y",
                                                 &m_excellonMirrorY,
@@ -115,6 +116,14 @@ JOB_EXPORT_PCB_DRILL::JOB_EXPORT_PCB_DRILL() :
     m_params.emplace_back( new JOB_PARAM<int>( "gerber_precision",
                                                &m_gerberPrecision,
                                                m_gerberPrecision ) );
+    
+    m_params.emplace_back( new JOB_PARAM<bool>( "generate_report",
+                                                &m_generateReport,
+                                                m_generateReport ) );
+
+    m_params.emplace_back( new JOB_PARAM<wxString>( "report_filename", 
+                                                        &m_reportPath, 
+                                                         m_reportPath ) );
 }
 
 

common/jobs/job_export_pcb_drill.h

@@ -85,6 +85,9 @@ public:
     MAP_FORMAT   m_mapFormat;
     int          m_gerberPrecision;
     bool         m_generateMap;
+
+    bool         m_generateReport;
+    wxString     m_reportPath;
 };
 
 #endif

common/jobs/jobs_output.h

@@ -44,6 +44,7 @@ public:
     virtual bool OutputPrecheck() { return true; }
     virtual bool HandleOutputs( const wxString&                aBaseTempPath,
                                 PROJECT*                       aProject,
+                                const std::vector<wxString>&   aPathsWithOverwriteDisallowed,
                                 const std::vector<JOB_OUTPUT>& aOutputsToHandle ) = 0;
 
     virtual void FromJson( const nlohmann::json& j ) = 0;

common/jobs/jobs_output_archive.cpp

@@ -42,7 +42,9 @@ bool JOBS_OUTPUT_ARCHIVE::OutputPrecheck()
 }
 
 
-bool JOBS_OUTPUT_ARCHIVE::HandleOutputs( const wxString& baseTempPath, PROJECT* aProject,
+bool JOBS_OUTPUT_ARCHIVE::HandleOutputs( const wxString&                baseTempPath,
+                                         PROJECT*                       aProject,
+                                         const std::vector<wxString>&   aPathsWithOverwriteDisallowed,
                                          const std::vector<JOB_OUTPUT>& aOutputsToHandle )
 {
     bool success = true;

common/jobs/jobs_output_archive.h

@@ -32,8 +32,9 @@ public:
         ZIP
     };
 
-    bool HandleOutputs( const wxString& aBaseTempPath,
-                        PROJECT* aProject,
+    bool HandleOutputs( const wxString&                aBaseTempPath,
+                        PROJECT*                       aProject,
+                        const std::vector<wxString>&   aPathsWithOverwriteDisallowed,
                         const std::vector<JOB_OUTPUT>& aOutputsToHandle ) override;
     bool OutputPrecheck() override;
 

common/jobs/jobs_output_folder.cpp

@@ -30,7 +30,9 @@ JOBS_OUTPUT_FOLDER::JOBS_OUTPUT_FOLDER() :
 }
 
 
-bool JOBS_OUTPUT_FOLDER::HandleOutputs( const wxString& baseTempPath, PROJECT* aProject,
+bool JOBS_OUTPUT_FOLDER::HandleOutputs( const wxString&                baseTempPath,
+                                        PROJECT*                       aProject,
+                                        const std::vector<wxString>&   aPathsWithOverwriteDisallowed,
                                         const std::vector<JOB_OUTPUT>& aOutputsToHandle )
 {
     wxString outputPath = ExpandTextVars( m_outputPath, aProject );
@@ -47,7 +49,7 @@ bool JOBS_OUTPUT_FOLDER::HandleOutputs( const wxString& baseTempPath, PROJECT* a
 
     wxString errors;
 
-    if( !CopyDirectory( baseTempPath, outputPath, errors ) )
+    if( !CopyDirectory( baseTempPath, outputPath, aPathsWithOverwriteDisallowed, errors ) )
         return false;
 
     return true;

common/jobs/jobs_output_folder.h

@@ -27,8 +27,9 @@ class JOBS_OUTPUT_FOLDER : public JOBS_OUTPUT_HANDLER
 public:
     JOBS_OUTPUT_FOLDER();
 
-    bool HandleOutputs( const wxString& aBaseTempPath,
-                        PROJECT* aProject,
+    bool HandleOutputs( const wxString&                aBaseTempPath,
+                        PROJECT*                       aProject,
+                        const std::vector<wxString>&   aPathsWithOverwriteDisallowed,
                         const std::vector<JOB_OUTPUT>& aOutputsToHandle ) override;
 
     bool OutputPrecheck() override;

common/kicad_curl/kicad_curl_easy.cpp

@@ -139,6 +139,12 @@ KICAD_CURL_EASY::KICAD_CURL_EASY() :
     curl_easy_setopt( m_CURL, CURLOPT_PROTOCOLS, CURLPROTO_HTTP | CURLPROTO_HTTPS );
 #endif
 
+    // Set connection timeout to prevent long freezes when network is unreachable.
+    // Without this, CURL can wait up to 5 minutes for DNS resolution or connection
+    // establishment, which causes the UI to freeze on macOS when behind a proxy with
+    // restricted internet access.
+    curl_easy_setopt( m_CURL, CURLOPT_CONNECTTIMEOUT, 30L );
+
 #ifdef _WIN32
     long sslOpts = CURLSSLOPT_NATIVE_CA;
 
@@ -345,6 +351,12 @@ bool KICAD_CURL_EASY::SetOutputStream( const std::ostream* aOutput )
 }
 
 
+bool KICAD_CURL_EASY::SetConnectTimeout( long aTimeoutSecs )
+{
+    return setOption( CURLOPT_CONNECTTIMEOUT, aTimeoutSecs ) == CURLE_OK;
+}
+
+
 int KICAD_CURL_EASY::GetTransferTotal( uint64_t& aDownloadedBytes ) const
 {
 #if LIBCURL_VERSION_NUM >= 0x073700 // 7.55.0

common/kiid.cpp

@@ -285,6 +285,17 @@ void KIID::Increment()
 }
 
 
+KIID KIID::Combine( const KIID& aFirst, const KIID& aSecond )
+{
+    KIID result( 0 );
+
+    for( int i = 0; i < 16; ++i )
+        result.m_uuid.data[i] = aFirst.m_uuid.data[i] ^ aSecond.m_uuid.data[i];
+
+    return result;
+}
+
+
 void KIID::CreateNilUuids( bool aNil )
 {
     g_createNilUuids = aNil;

common/lib_tree_model_adapter.cpp

@@ -48,7 +48,20 @@ public:
 
     wxSize GetSize() const override
     {
-        return wxSize( GetOwner()->GetWidth(), GetTextExtent( m_text ).y + 2 );
+        wxSize size( GetOwner()->GetWidth(), GetTextExtent( m_text ).y + 2 );
+
+#if defined( __WXGTK__ ) && !wxCHECK_VERSION( 3, 2, 7 )
+        // Somehow returning 0 or negative width prevents the returned height from
+        // being taken into account at all, even if we return strictly positive
+        // width from later calls to GetSize(), meaning that it's enough to return
+        // 0 from it once to completely break the layout for the entire lifetime of
+        // the control.
+        //
+        // As this is completely unexpected, forcefully prevent this from happening
+        size.IncTo( wxSize( 1, 1 ) );
+#endif
+
+        return size;
     }
 
     bool GetValue( wxVariant& aValue ) const override

common/paths.cpp

@@ -22,6 +22,7 @@
 #include <wx/stdpaths.h>
 #include <wx/string.h>
 #include <wx/utils.h>
+#include <wx/msgdlg.h>
 
 #include <kiplatform/environment.h>
 #include <paths.h>
@@ -151,6 +152,7 @@ wxString PATHS::GetDefaultUserProjectsPath()
 }
 
 
+#if !defined( __WXMAC__ ) && !defined( __WXMSW__ )
 /**
  * Get the CMake build root directory for the current executable
  * (which assumes the executable is in a build directory).
@@ -191,6 +193,48 @@ static wxString getBuildDirectoryRoot()
 
     return fn.GetPath();
 }
+#elif defined( __WXMAC__ )
+/**
+ * Get the main .app bundle root with symlinks resolved.
+ * Handles both main KiCad binaries and aux binaries inside the bundle.
+ * This is the single source of truth for bundle root resolution on macOS.
+ */
+static wxString getOSXBundleRoot()
+{
+    static wxString bundleRoot;
+
+    if( bundleRoot.empty() )
+    {
+        wxFileName fn( wxStandardPaths::Get().GetExecutablePath() );
+        WX_FILENAME::ResolvePossibleSymlinks( fn );
+        fn.SetFullName( wxEmptyString ); // Remove binary name
+
+        // Navigate from .../Contents/MacOS/ up to the .app bundle root
+        // e.g., /Applications/KiCad/KiCad.app/Contents/MacOS -> /Applications/KiCad/KiCad.app
+        if( fn.GetDirCount() >= 2 && fn.GetDirs().Last() == wxT( "MacOS" ) )
+        {
+            fn.RemoveLastDir(); // MacOS
+            fn.RemoveLastDir(); // Contents
+        }
+
+        // Handle aux binaries inside main bundle
+        // From: .../main.app/Contents/Applications/standalone.app
+        // To:   .../main.app
+        const wxArrayString dirs = fn.GetDirs();
+        if( dirs.GetCount() >= 4 && dirs[dirs.GetCount() - 2] == wxT( "Applications" )
+            && dirs[dirs.GetCount() - 4].Lower().EndsWith( wxT( "app" ) ) )
+        {
+            fn.RemoveLastDir(); // standalone.app
+            fn.RemoveLastDir(); // Applications
+            fn.RemoveLastDir(); // Contents
+        }
+
+        bundleRoot = fn.GetPath();
+    }
+
+    return bundleRoot;
+}
+#endif
 
 
 wxString PATHS::GetStockDataPath( bool aRespectRunFromBuildDir )
@@ -201,12 +245,10 @@ wxString PATHS::GetStockDataPath( bool aRespectRunFromBuildDir )
     {
         // Allow debugging from build dir by placing relevant files/folders in the build root
 #if defined( __WXMAC__ )
-        wxFileName fn = wxStandardPaths::Get().GetExecutablePath();
-
-        fn.RemoveLastDir();
-        fn.RemoveLastDir();
-        fn.RemoveLastDir();
-        fn.RemoveLastDir();
+        wxFileName fn;
+        fn.AssignDir( getOSXBundleRoot() );
+        fn.RemoveLastDir(); // Above the .app bundle
+        fn.RemoveLastDir(); // Above the target subdirectory to build root
         path = fn.GetPath();
 #elif defined( __WXMSW__ )
         path = getWindowsKiCadRoot();
@@ -361,32 +403,25 @@ wxString PATHS::GetStockPlugins3DPath()
 
     fn.AppendDir( wxT( "plugins" ) );
 #elif defined( __WXMAC__ )
-    fn.Assign( wxStandardPaths::Get().GetPluginsDir(), wxEmptyString );
-
-    // This must be mapped to main bundle for everything but kicad.app
-    const wxArrayString dirs = fn.GetDirs();
-
-    // Check if we are the main kicad binary.  in this case, the path will be
-    //     /path/to/bundlename.app/Contents/PlugIns
-    // If we are an aux binary, the path will be something like
-    //     /path/to/bundlename.app/Contents/Applications/<standalone>.app/Contents/PlugIns
-    if( dirs.GetCount() >= 6 &&
-        dirs[dirs.GetCount() - 4] == wxT( "Applications" ) &&
-        dirs[dirs.GetCount() - 6].Lower().EndsWith( wxT( "app" ) ) )
-    {
-        fn.RemoveLastDir();
-        fn.RemoveLastDir();
-        fn.RemoveLastDir();
-        fn.RemoveLastDir();
-        fn.AppendDir( wxT( "PlugIns" ) );
-    }
+    fn.AssignDir( getOSXBundleRoot() );
+    fn.AppendDir( wxT( "Contents" ) );
+    fn.AppendDir( wxT( "PlugIns" ) );
 #else
-    // KICAD_PLUGINDIR = CMAKE_INSTALL_FULL_LIBDIR path is the absolute path
-    // corresponding to the install path used for constructing KICAD_USER_PLUGIN
-    wxString tfname = wxString::FromUTF8Unchecked( KICAD_PLUGINDIR );
-    fn.Assign( tfname, "" );
-    fn.AppendDir( wxT( "kicad" ) );
-    fn.AppendDir( wxT( "plugins" ) );
+    if( wxGetEnv( wxT( "KICAD_RUN_FROM_BUILD_DIR" ), nullptr ) )
+    {
+        fn.Assign( wxStandardPaths::Get().GetExecutablePath() );
+        fn.AppendDir( wxT( ".." ) );
+        fn.AppendDir( wxT( "plugins" ) );
+    }
+    else
+    {
+        // KICAD_PLUGINDIR = CMAKE_INSTALL_FULL_LIBDIR path is the absolute path
+        // corresponding to the install path used for constructing KICAD_USER_PLUGIN
+        wxString tfname = wxString::FromUTF8Unchecked( KICAD_PLUGINDIR );
+        fn.Assign( tfname, "" );
+        fn.AppendDir( wxT( "kicad" ) );
+        fn.AppendDir( wxT( "plugins" ) );
+    }
 #endif
 
     fn.AppendDir( wxT( "3d" ) );
@@ -502,6 +537,25 @@ void PATHS::EnsureUserPathsExist()
     EnsurePathExists( GetDefaultUserFootprintsPath() );
     EnsurePathExists( GetDefaultUser3DModelsPath() );
     EnsurePathExists( GetDefault3rdPartyPath() );
+
+#ifdef _WIN32
+    // Warn about Controlled folder access
+    wxFileName tmp;
+    getUserDocumentPath( tmp );
+
+    if( !tmp.DirExists() )
+    {
+        wxString msg = wxString::Format(
+                _( "KiCad was unable to use '%s'.\n"
+                   "\n"
+                   "1. Disable 'Controlled folder access' in Windows settings or Group Policy\n"
+                   "2. Make sure no other antivirus software interferes with KiCad\n"
+                   "3. Make sure you have correct permissions set up" ),
+                tmp.GetPath() );
+
+        wxMessageBox( msg, _( "Warning" ), wxICON_WARNING );
+    }
+#endif
 }
 
 
@@ -530,28 +584,10 @@ wxString PATHS::GetOSXKicadMachineDataDir()
 
 wxString PATHS::GetOSXKicadDataDir()
 {
-    // According to wxWidgets documentation for GetDataDir:
-    // Mac: appname.app/Contents/SharedSupport bundle subdirectory
-    wxFileName ddir( wxStandardPaths::Get().GetDataDir(), wxEmptyString );
-
-    // This must be mapped to main bundle for everything but kicad.app
-    const wxArrayString dirs = ddir.GetDirs();
-
-    // Check if we are the main kicad binary.  in this case, the path will be
-    //     /path/to/bundlename.app/Contents/SharedSupport
-    // If we are an aux binary, the path will be something like
-    //     /path/to/bundlename.app/Contents/Applications/<standalone>.app/Contents/SharedSupport
-    if( dirs.GetCount() >= 6 &&
-        dirs[dirs.GetCount() - 4] == wxT( "Applications" ) &&
-        dirs[dirs.GetCount() - 6].Lower().EndsWith( wxT( "app" ) ) )
-    {
-        ddir.RemoveLastDir();
-        ddir.RemoveLastDir();
-        ddir.RemoveLastDir();
-        ddir.RemoveLastDir();
-        ddir.AppendDir( wxT( "SharedSupport" ) );
-    }
-
+    wxFileName ddir;
+    ddir.AssignDir( getOSXBundleRoot() );
+    ddir.AppendDir( wxT( "Contents" ) );
+    ddir.AppendDir( wxT( "SharedSupport" ) );
     return ddir.GetPath();
 }
 #endif
@@ -622,33 +658,12 @@ const wxString& PATHS::GetExecutablePath()
 
     if( exe_path.empty() )
     {
+#ifdef __WXMAC__
+        // Use bundle root helper which handles symlink resolution and aux binaries
+        exe_path = getOSXBundleRoot() + wxT( "/" );
+#else
         wxString bin_dir = wxStandardPaths::Get().GetExecutablePath();
 
-#ifdef __WXMAC__
-        // On OSX GetExecutablePath() will always point to main
-        // bundle directory, e.g., /Applications/kicad.app/
-
-        wxFileName fn( bin_dir );
-        WX_FILENAME::ResolvePossibleSymlinks( fn );
-
-        if( fn.GetName() == wxT( "kicad" ) || fn.GetName() == wxT( "kicad-cli" ) )
-        {
-            // kicad launcher, so just remove the Contents/MacOS part
-            fn.RemoveLastDir();
-            fn.RemoveLastDir();
-        }
-        else
-        {
-            // standalone binaries live in Contents/Applications/<standalone>.app/Contents/MacOS
-            fn.RemoveLastDir();
-            fn.RemoveLastDir();
-            fn.RemoveLastDir();
-            fn.RemoveLastDir();
-            fn.RemoveLastDir();
-        }
-
-        bin_dir = fn.GetPath() + wxT( "/" );
-#else
         // Use unix notation for paths. I am not sure this is a good idea,
         // but it simplifies compatibility between Windows and Unices.
         // However it is a potential problem in path handling under Windows.
@@ -657,8 +672,9 @@ const wxString& PATHS::GetExecutablePath()
         // Remove file name form command line:
         while( bin_dir.Last() != '/' && !bin_dir.IsEmpty() )
             bin_dir.RemoveLast();
-#endif
+
         exe_path = bin_dir;
+#endif
     }
 
     return exe_path;

common/pgm_base.cpp

@@ -176,6 +176,8 @@ void PGM_BASE::Destroy()
 #endif
 
     m_pgm_checker.reset();
+
+    m_singleton.Shutdown();
 }
 
 

common/plotters/DXF_plotter.cpp

@@ -141,12 +141,14 @@ void DXF_PLOTTER::SetUnits( DXF_UNITS aUnit )
     case DXF_UNITS::MM:
         m_unitScalingFactor = 0.00254;
         m_measurementDirective = 1;
+        m_insUnits = 4;
         break;
 
     case DXF_UNITS::INCH:
     default:
         m_unitScalingFactor = 0.0001;
         m_measurementDirective = 0;
+        m_insUnits = 1;
     }
 }
 
@@ -219,6 +221,10 @@ bool DXF_PLOTTER::StartPlot( const wxString& aPageNumber )
             "$MEASUREMENT\n"
             "  70\n"
             "%u\n"
+            "  9\n"
+            "$INSUNITS\n"
+            "  70\n"
+            "%u\n"
             "  0\n"
             "ENDSEC\n"
             "  0\n"
@@ -313,7 +319,7 @@ bool DXF_PLOTTER::StartPlot( const wxString& aPageNumber )
             "-0.2\n"
             "  0\n"
             "ENDTAB\n",
-             GetMeasurementDirective() );
+             GetMeasurementDirective(), GetInsUnits() );
 
     // Text styles table
     // Defines 4 text styles, one for each bold/italic combination

common/plotters/PDF_plotter.cpp

@@ -415,7 +415,7 @@ void PDF_PLOTTER::PlotPoly( const std::vector<VECTOR2I>& aCornerList, FILL_T aFi
     if( aFill == FILL_T::NO_FILL )
         fputs( "S\n", m_workFile );
     else if( aWidth == 0 )
-        fputs( "f\n", m_workFile );
+        fputs( "h f\n", m_workFile );
     else
         fputs( "b\n", m_workFile );
 }

common/plotters/SVG_plotter.cpp

@@ -683,10 +683,10 @@ void SVG_PLOTTER::PlotImage( const wxImage& aImage, const VECTOR2I& aPos, double
         img_stream.CopyTo( buffer.data(), buffer.size() );
         base64::encode( buffer, encoded );
 
+        VECTOR2D pos = userToDeviceCoordinates( start );
         fprintf( m_outputFile,
                  "<image x=\"%f\" y=\"%f\" xlink:href=\"data:image/png;base64,",
-                 userToDeviceSize( start.x ),
-                 userToDeviceSize( start.y ) );
+                 pos.x, pos.y );
 
         for( size_t i = 0; i < encoded.size(); i++ )
         {

common/project/net_settings.cpp

@@ -316,9 +316,12 @@ NET_SETTINGS::NET_SETTINGS( JSON_SETTINGS* aParent, const std::string& aPath ) :
                         wxString pattern = entry["pattern"].get<wxString>();
                         wxString netclass = entry["netclass"].get<wxString>();
 
-                        m_netClassPatternAssignments.push_back(
-                                { std::make_unique<EDA_COMBINED_MATCHER>( pattern, CTX_NETCLASS ),
-                                  netclass } );
+                        // Expand bus patterns so individual bus member nets can be matched
+                        ForEachBusMember( pattern,
+                                          [&]( const wxString& memberPattern )
+                                          {
+                                              addSinglePatternAssignment( memberPattern, netclass );
+                                          } );
                     }
                 }
             },
@@ -557,6 +560,21 @@ bool NET_SETTINGS::HasNetclassLabelAssignment( const wxString& netName ) const
 
 
 void NET_SETTINGS::SetNetclassPatternAssignment( const wxString& pattern, const wxString& netclass )
+{
+    // Expand bus patterns (vector buses and bus groups) to individual member patterns.
+    // This is necessary because the regex/wildcard matchers interpret brackets and braces
+    // as special characters, not as bus notation.
+    ForEachBusMember( pattern,
+                      [&]( const wxString& memberPattern )
+                      {
+                          addSinglePatternAssignment( memberPattern, netclass );
+                      } );
+
+    ClearAllCaches();
+}
+
+
+void NET_SETTINGS::addSinglePatternAssignment( const wxString& pattern, const wxString& netclass )
 {
     // Avoid exact duplicates - these shouldn't cause problems, due to later de-duplication
     // but they are unnecessary.
@@ -569,8 +587,6 @@ void NET_SETTINGS::SetNetclassPatternAssignment( const wxString& pattern, const
     // No assignment, add a new one
     m_netClassPatternAssignments.push_back(
             { std::make_unique<EDA_COMBINED_MATCHER>( pattern, CTX_NETCLASS ), netclass } );
-
-    ClearAllCaches();
 }
 
 
@@ -733,6 +749,44 @@ std::shared_ptr<NETCLASS> NET_SETTINGS::GetEffectiveNetClass( const wxString& aN
     // Handle zero resolved netclasses
     if( resolvedNetclasses.size() == 0 )
     {
+        // For bus patterns, check if all members share the same netclass.
+        // If they do, the bus inherits that netclass for coloring purposes.
+        std::shared_ptr<NETCLASS> sharedNetclass;
+        bool                      allSameNetclass = true;
+        bool                      isBusPattern = false;
+
+        ForEachBusMember( aNetName,
+                          [&]( const wxString& member )
+                          {
+                              // If ForEachBusMember gives us back the same name, it's not a bus.
+                              // Skip to avoid infinite recursion.
+                              if( member == aNetName )
+                                  return;
+
+                              isBusPattern = true;
+
+                              if( !allSameNetclass )
+                                  return;
+
+                              std::shared_ptr<NETCLASS> memberNc = GetEffectiveNetClass( member );
+
+                              if( !sharedNetclass )
+                              {
+                                  sharedNetclass = memberNc;
+                              }
+                              else if( memberNc->GetName() != sharedNetclass->GetName() )
+                              {
+                                  allSameNetclass = false;
+                              }
+                          } );
+
+        if( isBusPattern && allSameNetclass && sharedNetclass
+            && sharedNetclass->GetName() != NETCLASS::Default )
+        {
+            m_effectiveNetclassCache[aNetName] = sharedNetclass;
+            return sharedNetclass;
+        }
+
         m_effectiveNetclassCache[aNetName] = m_defaultNetClass;
 
         return m_defaultNetClass;
@@ -1015,6 +1069,33 @@ static bool isSuperSubOverbar( wxChar c )
 }
 
 
+/**
+ * Check if a character at the given position is escaped by a backslash.
+ *
+ * @param aStr The string to check
+ * @param aPos Position of the character to check
+ * @return true if the character is preceded by a backslash escape
+ */
+static bool isEscaped( const wxString& aStr, size_t aPos )
+{
+    if( aPos == 0 )
+        return false;
+
+    // Count consecutive backslashes before this position
+    int backslashCount = 0;
+    size_t pos = aPos;
+
+    while( pos > 0 && aStr[pos - 1] == '\\' )
+    {
+        backslashCount++;
+        pos--;
+    }
+
+    // If odd number of backslashes, the character is escaped
+    return ( backslashCount % 2 ) == 1;
+}
+
+
 bool NET_SETTINGS::ParseBusVector( const wxString& aBus, wxString* aName,
                                    std::vector<wxString>* aMemberList )
 {
@@ -1032,6 +1113,7 @@ bool NET_SETTINGS::ParseBusVector( const wxString& aBus, wxString* aName,
     long     begin = 0;
     long     end = 0;
     int      braceNesting = 0;
+    bool     inQuotes = false;
 
     prefix.reserve( busLen );
 
@@ -1039,18 +1121,57 @@ bool NET_SETTINGS::ParseBusVector( const wxString& aBus, wxString* aName,
     //
     for( ; i < busLen; ++i )
     {
+        // Handle quoted strings (allows spaces inside)
+        if( aBus[i] == '"' && !isEscaped( aBus, i ) )
+        {
+            inQuotes = !inQuotes;
+            continue;
+        }
+
+        if( inQuotes )
+        {
+            // Inside quotes, add characters directly (including spaces)
+            if( aBus[i] == '\\' && i + 1 < busLen )
+            {
+                // Handle escaped characters inside quotes
+                prefix += aBus[++i];
+            }
+            else
+            {
+                prefix += aBus[i];
+            }
+
+            continue;
+        }
+
         if( aBus[i] == '{' )
         {
             if( i > 0 && isSuperSubOverbar( aBus[i-1] ) )
+            {
                 braceNesting++;
+
+                if( !prefix.IsEmpty() )
+                    prefix.RemoveLast();
+
+                continue;
+            }
             else
                 return false;
         }
         else if( aBus[i] == '}' )
         {
             braceNesting--;
+            continue;
         }
 
+        // Handle backslash-escaped spaces
+        if( aBus[i] == '\\' && i + 1 < busLen && aBus[i + 1] == ' ' )
+        {
+            prefix += aBus[++i];
+            continue;
+        }
+
+        // Unescaped space or ] in bus vector prefix is not allowed
         if( aBus[i] == ' ' || aBus[i] == ']' )
             return false;
 
@@ -1111,6 +1232,9 @@ bool NET_SETTINGS::ParseBusVector( const wxString& aBus, wxString* aName,
         if( aBus[i] == '}' )
         {
             braceNesting--;
+        }
+        else if( aBus[i] == '+' || aBus[i] == '-' || aBus[i] == 'P' || aBus[i] == 'N' )
+        {
             suffix += aBus[i];
         }
         else
@@ -1154,17 +1278,68 @@ bool NET_SETTINGS::ParseBusGroup( const wxString& aGroup, wxString* aName,
     wxString prefix;
     wxString tmp;
     int      braceNesting = 0;
+    bool     inQuotes = false;
 
     prefix.reserve( groupLen );
 
+    // Escape spaces in member names so recursive parsing by ForEachBusMember works correctly.
+    // Both quoted strings and backslash-escaped spaces collapse to bare spaces during parsing,
+    // so we must re-escape them for subsequent ParseBusVector/ParseBusGroup calls.
+    auto escapeSpacesForBus =
+            []( const wxString& aMember ) -> wxString
+            {
+                wxString escaped;
+                escaped.reserve( aMember.length() * 2 );
+
+                for( wxUniChar c : aMember )
+                {
+                    if( c == ' ' )
+                        escaped += wxT( "\\ " );
+                    else
+                        escaped += c;
+                }
+
+                return escaped;
+            };
+
     // Parse prefix
     //
     for( ; i < groupLen; ++i )
     {
+        // Handle quoted strings (allows spaces inside)
+        if( aGroup[i] == '"' && !isEscaped( aGroup, i ) )
+        {
+            inQuotes = !inQuotes;
+            continue;
+        }
+
+        if( inQuotes )
+        {
+            // Inside quotes, add characters directly (including spaces)
+            if( aGroup[i] == '\\' && i + 1 < groupLen )
+            {
+                // Handle escaped characters inside quotes
+                prefix += aGroup[++i];
+            }
+            else
+            {
+                prefix += aGroup[i];
+            }
+
+            continue;
+        }
+
         if( aGroup[i] == '{' )
         {
             if( i > 0 && isSuperSubOverbar( aGroup[i-1] ) )
+            {
                 braceNesting++;
+
+                if( !prefix.IsEmpty() )
+                    prefix.RemoveLast();
+
+                continue;
+            }
             else
                 break;
         }
@@ -1173,6 +1348,14 @@ bool NET_SETTINGS::ParseBusGroup( const wxString& aGroup, wxString* aName,
             braceNesting--;
         }
 
+        // Handle backslash-escaped spaces
+        if( aGroup[i] == '\\' && i + 1 < groupLen && aGroup[i + 1] == ' ' )
+        {
+            prefix += aGroup[++i];
+            continue;
+        }
+
+        // Unescaped space, [, or ] in bus group prefix is not allowed
         if( aGroup[i] == ' ' || aGroup[i] == '[' || aGroup[i] == ']' )
             return false;
 
@@ -1192,12 +1375,44 @@ bool NET_SETTINGS::ParseBusGroup( const wxString& aGroup, wxString* aName,
     if( i >= groupLen )
         return false;
 
+    inQuotes = false;
+
     for( ; i < groupLen; ++i )
     {
+        // Handle quoted strings (allows spaces inside member names)
+        if( aGroup[i] == '"' && !isEscaped( aGroup, i ) )
+        {
+            inQuotes = !inQuotes;
+            continue;
+        }
+
+        if( inQuotes )
+        {
+            // Inside quotes, add characters directly (including spaces)
+            if( aGroup[i] == '\\' && i + 1 < groupLen )
+            {
+                // Handle escaped characters inside quotes
+                tmp += aGroup[++i];
+            }
+            else
+            {
+                tmp += aGroup[i];
+            }
+
+            continue;
+        }
+
         if( aGroup[i] == '{' )
         {
             if( i > 0 && isSuperSubOverbar( aGroup[i-1] ) )
+            {
                 braceNesting++;
+
+                if( !tmp.IsEmpty() )
+                    tmp.RemoveLast();
+
+                continue;
+            }
             else
                 return false;
         }
@@ -1206,21 +1421,29 @@ bool NET_SETTINGS::ParseBusGroup( const wxString& aGroup, wxString* aName,
             if( braceNesting )
             {
                 braceNesting--;
+                continue;
             }
             else
             {
                 if( aMemberList && !tmp.IsEmpty() )
-                    aMemberList->push_back( EscapeString( tmp, CTX_NETNAME ) );
+                    aMemberList->push_back( EscapeString( escapeSpacesForBus( tmp ), CTX_NETNAME ) );
 
                 return true;
             }
         }
 
-        // Commas aren't strictly legal, but we can be pretty sure what the author had in mind.
+        // Handle backslash-escaped spaces in member names
+        if( aGroup[i] == '\\' && i + 1 < groupLen && aGroup[i + 1] == ' ' )
+        {
+            tmp += aGroup[++i];
+            continue;
+        }
+
+        // Unescaped space or comma separates members
         if( aGroup[i] == ' ' || aGroup[i] == ',' )
         {
             if( aMemberList && !tmp.IsEmpty() )
-                aMemberList->push_back( EscapeString( tmp, CTX_NETNAME ) );
+                aMemberList->push_back( EscapeString( escapeSpacesForBus( tmp ), CTX_NETNAME ) );
 
             tmp.Clear();
             continue;
@@ -1231,3 +1454,28 @@ bool NET_SETTINGS::ParseBusGroup( const wxString& aGroup, wxString* aName,
 
     return false;
 }
+
+
+void NET_SETTINGS::ForEachBusMember( const wxString&                              aBusPattern,
+                                     const std::function<void( const wxString& )>& aFunction )
+{
+    std::vector<wxString> members;
+
+    if( ParseBusVector( aBusPattern, nullptr, &members ) )
+    {
+        // Vector bus: call function for each expanded member
+        for( const wxString& member : members )
+            aFunction( member );
+    }
+    else if( ParseBusGroup( aBusPattern, nullptr, &members ) )
+    {
+        // Bus group: recursively expand each member (which may itself be a vector or group)
+        for( const wxString& member : members )
+            ForEachBusMember( member, aFunction );
+    }
+    else
+    {
+        // Not a bus pattern: call function with the original pattern
+        aFunction( aBusPattern );
+    }
+}

common/project/project_file.cpp

@@ -117,6 +117,8 @@ PROJECT_FILE::PROJECT_FILE( const wxString& aFullPath ) :
                     m_LegacyLibNames.push_back( entry.get<wxString>() );
             }, {} ) );
 
+
+
     m_NetSettings = std::make_shared<NET_SETTINGS>( this, "net_settings" );
 
     m_params.emplace_back( new PARAM_LAYER_PRESET( "board.layer_presets", &m_LayerPresets ) );

common/project/project_local_settings.cpp

@@ -45,6 +45,7 @@ PROJECT_LOCAL_SETTINGS::PROJECT_LOCAL_SETTINGS( PROJECT* aProject, const wxStrin
         m_ShapeOpacity( 1.0 ),
         m_ImageOpacity( 0.6 ),
         m_PcbSelectionFilter(),
+        m_GitIntegrationDisabled( false ),
         m_project( aProject ),
         m_wasMigrated( false )
 {
@@ -207,6 +208,8 @@ PROJECT_LOCAL_SETTINGS::PROJECT_LOCAL_SETTINGS( PROJECT* aProject, const wxStrin
 
     m_params.emplace_back( new PARAM<wxString>( "git.ssh_key", &m_GitSSHKey, "" ) );
 
+    m_params.emplace_back( new PARAM<bool>( "git.integration_disabled", &m_GitIntegrationDisabled, false ) );
+
     m_params.emplace_back( new PARAM<wxString>( "net_inspector_panel.filter_text",
                                                 &m_NetInspectorPanel.filter_text, "" ) );
     m_params.emplace_back( new PARAM<bool>( "net_inspector_panel.filter_by_net_name",

common/properties/pg_editors.cpp

@@ -311,13 +311,21 @@ wxPGWindowList PG_COLOR_EDITOR::CreateControls( wxPropertyGrid* aGrid, wxPGPrope
     editor->SetPosition( aPos );
     editor->SetSize( aSize );
 
+    // Capture property name instead of pointer to avoid dangling pointer if grid is rebuilt
+    wxString propName = colorProp->GetName();
+
     editor->Bind( COLOR_SWATCH_CHANGED,
                   [=]( wxCommandEvent& aEvt )
                   {
-                      wxVariant val;
-                      auto data = new COLOR4D_VARIANT_DATA( editor->GetSwatchColor() );
-                      val.SetData( data );
-                      aGrid->ChangePropertyValue( colorProp, val );
+                      wxPGProperty* prop = aGrid->GetPropertyByName( propName );
+
+                      if( prop )
+                      {
+                          wxVariant val;
+                          auto data = new COLOR4D_VARIANT_DATA( editor->GetSwatchColor() );
+                          val.SetData( data );
+                          aGrid->ChangePropertyValue( prop, val );
+                      }
                   } );
 
 #if wxCHECK_VERSION( 3, 3, 0 )
@@ -330,6 +338,11 @@ wxPGWindowList PG_COLOR_EDITOR::CreateControls( wxPropertyGrid* aGrid, wxPGPrope
                 [=]()
                 {
                     editor->GetNewSwatchColor();
+
+                    wxPGProperty* prop = aGrid->GetPropertyByName( propName );
+
+                    if( prop )
+                        aGrid->DrawItem( prop );
                 } );
     }
 

common/rc_item.cpp

@@ -174,6 +174,9 @@ void RC_ITEM::GetJsonViolation( RC_JSON::VIOLATION& aViolation, UNITS_PROVIDER*
     aViolation.type = GetSettingsKey();
     aViolation.excluded = ( m_parent && m_parent->IsExcluded() );
 
+    if( m_parent && m_parent->IsExcluded() && !m_parent->GetComment().IsEmpty() )
+        aViolation.comment = m_parent->GetComment();
+
     EDA_ITEM* mainItem = nullptr;
     EDA_ITEM* auxItem = nullptr;
 

common/scintilla_tricks.cpp

@@ -206,10 +206,12 @@ void SCINTILLA_TRICKS::onModified( wxStyledTextEvent& aEvent )
     {
         // If the font is larger than the height of a single-line text box we can get issues
         // with the text disappearing every other character due to dodgy scrolling behaviour.
-        CallAfter( [this]()
-                   {
-                       m_te->ScrollToStart();
-                   } );
+        CallAfter(
+                [this]()
+                {
+                    if( !m_te->AutoCompActive() )
+                        m_te->ScrollToStart();
+                } );
     }
 }
 

common/singleton.cpp

@@ -20,18 +20,37 @@
 #include <singleton.h>
 #include <bs_thread_pool.hpp>
 #include <gal/opengl/gl_context_mgr.h>
+#include <thread_pool.h>
 
 
 KICAD_SINGLETON::~KICAD_SINGLETON()
 {
-    // This will wait for all threads to finish and then join them to the main thread
-    delete m_ThreadPool;
+    // Shutdown() should have been called before static destruction.
+    // If not, we still try to clean up, but this may crash on macOS
+    // during static destruction due to condition variable issues.
+    Shutdown();
+}
 
-    m_ThreadPool = nullptr;
 
-    m_GLContextManager->DeleteAll();
-    delete m_GLContextManager;
-    m_GLContextManager = nullptr;
+void KICAD_SINGLETON::Shutdown()
+{
+    // This will wait for all threads to finish and then join them to the main thread.
+    // Must be called before static destruction begins to avoid crashes on macOS.
+    if( m_ThreadPool )
+    {
+        delete m_ThreadPool;
+        m_ThreadPool = nullptr;
+
+        // Clear the cached thread pool pointer to prevent dangling reference
+        InvalidateKiCadThreadPool();
+    }
+
+    if( m_GLContextManager )
+    {
+        m_GLContextManager->DeleteAll();
+        delete m_GLContextManager;
+        m_GLContextManager = nullptr;
+    }
 }
 
 

common/string_utils.cpp

@@ -155,7 +155,7 @@ bool ConvertSmartQuotesAndDashes( wxString* aString )
 
     for( wxString::iterator ii = aString->begin(); ii != aString->end(); ++ii )
     {
-        if( *ii == L'\u00B4' || *ii == L'\u2018' || *ii == L'\u2019' )
+        if( *ii == L'\u2018' || *ii == L'\u2019' )
         {
             *ii = '\'';
             retVal = true;

common/thread_pool.cpp

@@ -26,6 +26,7 @@
 #include <thread_pool.h>
 
 static thread_pool* tp = nullptr;
+static bool         tp_owned = false;  // True if we created the thread pool ourselves
 
 thread_pool& GetKiCadThreadPool()
 {
@@ -36,6 +37,7 @@ thread_pool& GetKiCadThreadPool()
     if( PGM_BASE* pgm = PgmOrNull() )
     {
         tp = &pgm->GetThreadPool();
+        tp_owned = false;
         return *tp;
     }
 
@@ -43,6 +45,20 @@ thread_pool& GetKiCadThreadPool()
     // so we need to create our own thread pool
     int num_threads = std::max( 0, ADVANCED_CFG::GetCfg().m_MaximumThreads );
     tp = new thread_pool( num_threads );
+    tp_owned = true;
 
     return *tp;
 }
+
+
+void InvalidateKiCadThreadPool()
+{
+    // If we own the thread pool (scripting context), delete it
+    if( tp && tp_owned )
+    {
+        delete tp;
+    }
+
+    tp = nullptr;
+    tp_owned = false;
+}

common/tool/action_toolbar.cpp

@@ -477,13 +477,17 @@ void ACTION_TOOLBAR::onToolEvent( wxAuiToolBarEvent& aEvent )
 
     bool handled = false;
 
-    if( m_toolManager && type == wxEVT_COMMAND_TOOL_CLICKED  && id >= TOOL_ACTION::GetBaseUIId() )
+    if( m_toolManager && type == wxEVT_COMMAND_TOOL_CLICKED )
     {
         const auto actionIt = m_toolActions.find( id );
+        const auto cancelIt = m_toolCancellable.find( id );
+
+        // Determine if the tool is actually cancellable
+        bool isCancellable = ( cancelIt != m_toolCancellable.end() ) ? cancelIt->second : false;
 
         // The toolbar item is toggled before the event is sent, so we check for it not being
         // toggled to see if it was toggled originally
-        if( m_toolCancellable[id] && !GetToolToggled( id ) )
+        if( isCancellable && !GetToolToggled( id ) )
         {
             // Send a cancel event
             m_toolManager->CancelTool();

common/tool/common_tools.cpp

@@ -612,6 +612,7 @@ int COMMON_TOOLS::GridProperties( const TOOL_EVENT& aEvent )
     case FRAME_SCH_SYMBOL_EDITOR: showGridPrefs( _( "Symbol Editor" ) );        break;
     case FRAME_PCB_EDITOR:        showGridPrefs( _( "PCB Editor" ) );           break;
     case FRAME_FOOTPRINT_EDITOR:  showGridPrefs( _( "Footprint Editor" ) );     break;
+    case FRAME_FOOTPRINT_VIEWER:  showGridPrefs( _( "Footprint Browser" ) );    break;
     case FRAME_PL_EDITOR:         showGridPrefs( _( "Drawing Sheet Editor" ) ); break;
     case FRAME_GERBER:            showGridPrefs( _( "Gerber Viewer" ) );        break;
     default:                      wxFAIL_MSG( "Unknown frame: " + GetName() );  break;

common/tool/construction_manager.cpp

@@ -32,10 +32,12 @@
 
 #include <wx/timer.h>
 #include <wx/debug.h>
+#include <wx/log.h>
 
 #include <advanced_config.h>
 #include <math/util.h>
 #include <hash.h>
+#include <trace_helpers.h>
 
 
 /**
@@ -555,21 +557,38 @@ void SNAP_LINE_MANAGER::SetSnappedAnchor( const VECTOR2I& aAnchorPos )
 OPT_VECTOR2I SNAP_LINE_MANAGER::GetNearestSnapLinePoint( const VECTOR2I&    aCursor,
                                                          const VECTOR2I&    aNearestGrid,
                                                          std::optional<int> aDistToNearest,
-                                                         int                aSnapRange ) const
+                                                         int                aSnapRange,
+                                                         const VECTOR2D&    aGridSize,
+                                                         const VECTOR2I&    aGridOrigin ) const
 {
-    wxUnusedVar( aNearestGrid );
+    wxLogTrace( traceSnap, "GetNearestSnapLinePoint: cursor=(%d, %d), nearestGrid=(%d, %d), distToNearest=%s, snapRange=%d",
+                aCursor.x, aCursor.y, aNearestGrid.x, aNearestGrid.y,
+                aDistToNearest ? wxString::Format( "%d", *aDistToNearest ) : wxString( "none" ), aSnapRange );
 
     if( !m_snapLineOrigin || m_directions.empty() )
+    {
+        wxLogTrace( traceSnap, "  No snap line origin or no directions, returning nullopt" );
         return std::nullopt;
+    }
 
     const bool gridBetterThanNearest = !aDistToNearest || *aDistToNearest > aSnapRange;
+    const bool gridActive = aGridSize.x > 0 && aGridSize.y > 0;
+
+    wxLogTrace( traceSnap, "  snapLineOrigin=(%d, %d), directions count=%zu, gridBetterThanNearest=%d, gridActive=%d",
+                m_snapLineOrigin->x, m_snapLineOrigin->y, m_directions.size(), gridBetterThanNearest, gridActive );
 
     if( !gridBetterThanNearest )
+    {
+        wxLogTrace( traceSnap, "  Grid not better than nearest, returning nullopt" );
         return std::nullopt;
+    }
 
     const int       escapeRange = 2 * aSnapRange;
     const EDA_ANGLE longRangeEscapeAngle( 4, DEGREES_T );
 
+    wxLogTrace( traceSnap, "  escapeRange=%d, longRangeEscapeAngle=%.1f deg",
+                escapeRange, longRangeEscapeAngle.AsDegrees() );
+
     const VECTOR2D origin( *m_snapLineOrigin );
     const VECTOR2D cursor( aCursor );
     const VECTOR2D delta = cursor - origin;
@@ -577,13 +596,17 @@ OPT_VECTOR2I SNAP_LINE_MANAGER::GetNearestSnapLinePoint( const VECTOR2I&    aCur
     double                        bestPerpDistance = std::numeric_limits<double>::max();
     std::optional<VECTOR2I>       bestSnapPoint;
 
-    for( const VECTOR2I& direction : m_directions )
+    for( size_t ii = 0; ii < m_directions.size(); ++ii )
     {
+        const VECTOR2I& direction = m_directions[ii];
         VECTOR2D dirVector( direction );
         double   dirLength = dirVector.EuclideanNorm();
 
         if( dirLength == 0.0 )
+        {
+            wxLogTrace( traceSnap, "    Direction %zu: zero length, skipping", ii );
             continue;
+        }
 
         VECTOR2D dirUnit = dirVector / dirLength;
 
@@ -592,8 +615,14 @@ OPT_VECTOR2I SNAP_LINE_MANAGER::GetNearestSnapLinePoint( const VECTOR2I&    aCur
         VECTOR2D  offset = delta - dirUnit * distanceAlong;
         double    perpDistance = offset.EuclideanNorm();
 
+        wxLogTrace( traceSnap, "    Direction %zu: dir=(%d, %d), perpDist=%.1f, distAlong=%.1f",
+                    ii, direction.x, direction.y, perpDistance, distanceAlong );
+
         if( perpDistance > aSnapRange )
+        {
+            wxLogTrace( traceSnap, "      perpDistance > snapRange, skipping" );
             continue;
+        }
 
         bool escaped = false;
 
@@ -603,20 +632,113 @@ OPT_VECTOR2I SNAP_LINE_MANAGER::GetNearestSnapLinePoint( const VECTOR2I&    aCur
             EDA_ANGLE directionAngle( dirVector );
             double    angleDiff = ( deltaAngle - directionAngle ).Normalize180().AsDegrees();
 
+            wxLogTrace( traceSnap, "      In escape range: deltaAngle=%.1f, dirAngle=%.1f, angleDiff=%.1f",
+                        deltaAngle.AsDegrees(), directionAngle.AsDegrees(), angleDiff );
+
             if( std::abs( angleDiff ) > longRangeEscapeAngle.AsDegrees() )
+            {
                 escaped = true;
+                wxLogTrace( traceSnap, "      ESCAPED (angle diff too large)" );
+            }
         }
 
-        if( !escaped && perpDistance < bestPerpDistance )
+        if( escaped )
+        {
+            wxLogTrace( traceSnap, "      Not updating (escaped)" );
+            continue;
+        }
+
+        // Now snap the projection to the grid if the grid is active
+        VECTOR2D snapPoint = projection;
+
+        if( gridActive )
+        {
+            // For horizontal/vertical lines, snap to grid intersections
+            if( direction.x == 0 && direction.y != 0 )
+            {
+                // Vertical line: keep origin X, snap Y to grid
+                snapPoint.x = origin.x;
+                snapPoint.y = aNearestGrid.y;
+                wxLogTrace( traceSnap, "      Vertical line: snapping to grid Y, snapPoint=(%.1f, %.1f)",
+                            snapPoint.x, snapPoint.y );
+            }
+            else if( direction.y == 0 && direction.x != 0 )
+            {
+                // Horizontal line: snap X to grid, keep origin Y
+                snapPoint.x = aNearestGrid.x;
+                snapPoint.y = origin.y;
+                wxLogTrace( traceSnap, "      Horizontal line: snapping to grid X, snapPoint=(%.1f, %.1f)",
+                            snapPoint.x, snapPoint.y );
+            }
+            else
+            {
+                // Diagonal line: find nearest grid intersection along the line
+                VECTOR2D gridOriginD( aGridOrigin );
+                VECTOR2D relProjection = projection - gridOriginD;
+
+                // Find nearby grid points (check 3x3 grid around projection)
+                double   bestGridScore = std::numeric_limits<double>::max();
+                VECTOR2D bestGridPoint = projection;
+
+                for( int dx = -1; dx <= 1; ++dx )
+                {
+                    for( int dy = -1; dy <= 1; ++dy )
+                    {
+                        double gridX = std::round( relProjection.x / aGridSize.x ) * aGridSize.x + dx * aGridSize.x;
+                        double gridY = std::round( relProjection.y / aGridSize.y ) * aGridSize.y + dy * aGridSize.y;
+                        VECTOR2D gridPt( gridX + gridOriginD.x, gridY + gridOriginD.y );
+
+                        // Calculate perpendicular distance from grid point to construction line
+                        VECTOR2D gridDelta = gridPt - origin;
+                        double   gridDistAlong = gridDelta.Dot( dirUnit );
+                        VECTOR2D gridProjection = origin + dirUnit * gridDistAlong;
+                        double   gridPerpDist = ( gridPt - gridProjection ).EuclideanNorm();
+
+                        // Also consider distance from cursor
+                        double distFromCursor = ( gridPt - cursor ).EuclideanNorm();
+
+                        // Prefer grid points that are close to the line and close to cursor
+                        double score = gridPerpDist + distFromCursor * 0.1;
+
+                        if( score < bestGridScore )
+                        {
+                        bestGridScore = score;
+                            bestGridPoint = gridPt;
+                        }
+                    }
+                }
+
+                snapPoint = bestGridPoint;
+                wxLogTrace( traceSnap, "      Diagonal line: snapping to grid intersection, snapPoint=(%.1f, %.1f)",
+                            snapPoint.x, snapPoint.y );
+            }
+        }
+        else
+        {
+            wxLogTrace( traceSnap, "      Grid not active, using projection" );
+        }
+
+        if( perpDistance < bestPerpDistance )
         {
             bestPerpDistance = perpDistance;
-            bestSnapPoint = VECTOR2I( KiROUND( projection.x ), KiROUND( projection.y ) );
+            bestSnapPoint = VECTOR2I( KiROUND( snapPoint.x ), KiROUND( snapPoint.y ) );
+            wxLogTrace( traceSnap, "      NEW BEST: perpDist=%.1f, snapPoint=(%d, %d)",
+                        bestPerpDistance, bestSnapPoint->x, bestSnapPoint->y );
+        }
+        else
+        {
+            wxLogTrace( traceSnap, "      Not updating (perpDist=%.1f >= bestPerp=%.1f)",
+                        perpDistance, bestPerpDistance );
         }
     }
 
     if( bestSnapPoint )
+    {
+        wxLogTrace( traceSnap, "  RETURNING bestSnapPoint=(%d, %d)", bestSnapPoint->x, bestSnapPoint->y );
         return *bestSnapPoint;
+    }
 
+    wxLogTrace( traceSnap, "  RETURNING nullopt (no valid snap found)" );
     return std::nullopt;
 }
 
@@ -743,3 +865,22 @@ SNAP_MANAGER::GetConstructionItems() const
 
     return batches;
 }
+
+
+void CONSTRUCTION_MANAGER::Clear()
+{
+    std::lock_guard<std::mutex> lock( m_batchesMutex );
+
+    m_persistentConstructionBatch.reset();
+    m_temporaryConstructionBatches.clear();
+    m_involvedItems.clear();
+    CancelProposal();
+}
+
+
+void SNAP_MANAGER::Clear()
+{
+    m_snapLineManager.ClearSnapLine();
+    m_constructionManager.Clear();
+    UpdateSnapGuides();
+}

common/tool/edit_constraints.cpp

@@ -61,7 +61,7 @@ void EC_45DEGREE::Apply( EDIT_POINT& aHandle, const GRID_HELPER& aGrid )
     VECTOR2I lineVector( aHandle.GetPosition() - m_constrainer.GetPosition() );
     VECTOR2I newLineVector = GetVectorSnapped45( lineVector );
 
-    if( aHandle.GetGridConstraint() == SNAP_TO_GRID
+    if( aHandle.GetGridConstraint() == SNAP_TO_GRID && !aGrid.GetSnappedPoint()
             && ( newLineVector.x == 0 || newLineVector.y == 0 ) )
     {
         VECTOR2I snap = aGrid.AlignGrid( m_constrainer.GetPosition() + newLineVector );

common/tool/grid_helper.cpp

@@ -28,6 +28,8 @@
 #include <limits>
 
 #include <advanced_config.h>
+#include <trace_helpers.h>
+#include <wx/log.h>
 #include <gal/graphics_abstraction_layer.h>
 #include <math/util.h>      // for KiROUND
 #include <math/vector2d.h>
@@ -157,14 +159,26 @@ std::optional<VECTOR2I> GRID_HELPER::SnapToConstructionLines( const VECTOR2I& aP
     const SNAP_LINE_MANAGER& snapLineManager = m_snapManager.GetSnapLineManager();
     const OPT_VECTOR2I&      snapOrigin = snapLineManager.GetSnapLineOrigin();
 
+    wxLogTrace( traceSnap, "SnapToConstructionLines: aPoint=(%d, %d), nearestGrid=(%d, %d), snapRange=%.1f",
+                aPoint.x, aPoint.y, aNearestGrid.x, aNearestGrid.y, aSnapRange );
+
     if( !snapOrigin || snapLineManager.GetDirections().empty() )
+    {
+        wxLogTrace( traceSnap, "  No snap origin or no directions, returning nullopt" );
         return std::nullopt;
+    }
 
     const VECTOR2I& origin = *snapOrigin;
 
+    wxLogTrace( traceSnap, "  snapOrigin=(%d, %d), directions count=%zu",
+                origin.x, origin.y, snapLineManager.GetDirections().size() );
+
     const std::vector<VECTOR2I>& directions = snapLineManager.GetDirections();
     const std::optional<int>     activeDirection = snapLineManager.GetActiveDirection();
 
+    if( activeDirection )
+        wxLogTrace( traceSnap, "  activeDirection=%d", *activeDirection );
+
     const VECTOR2D originVec( origin );
     const VECTOR2D cursorVec( aPoint );
     const VECTOR2D delta = cursorVec - originVec;
@@ -180,7 +194,10 @@ std::optional<VECTOR2I> GRID_HELPER::SnapToConstructionLines( const VECTOR2I& aP
         double          dirLength = dirVector.EuclideanNorm();
 
         if( dirLength == 0.0 )
+        {
+            wxLogTrace( traceSnap, "    Direction %zu: zero length, skipping", ii );
             continue;
+        }
 
         VECTOR2D dirUnit = dirVector / dirLength;
 
@@ -192,10 +209,19 @@ std::optional<VECTOR2I> GRID_HELPER::SnapToConstructionLines( const VECTOR2I& aP
         double snapThreshold = aSnapRange;
 
         if( activeDirection && *activeDirection == static_cast<int>( ii ) )
+        {
             snapThreshold *= 1.5;
+            wxLogTrace( traceSnap, "    Direction %zu: ACTIVE, increased snapThreshold=%.1f", ii, snapThreshold );
+        }
+
+        wxLogTrace( traceSnap, "    Direction %zu: dir=(%d, %d), perpDist=%.1f, threshold=%.1f",
+                    ii, dir.x, dir.y, perpDistance, snapThreshold );
 
         if( perpDistance > snapThreshold )
+        {
+            wxLogTrace( traceSnap, "      perpDistance > threshold, skipping" );
             continue;
+        }
 
         VECTOR2D candidate = projection;
 
@@ -203,43 +229,113 @@ std::optional<VECTOR2I> GRID_HELPER::SnapToConstructionLines( const VECTOR2I& aP
         {
             if( dir.x == 0 && dir.y != 0 )
             {
+                // Vertical construction line: snap to grid intersection
                 candidate.x = origin.x;
                 candidate.y = aNearestGrid.y;
+                wxLogTrace( traceSnap, "      Vertical snap: candidate=(%d, %d)",
+                            (int)candidate.x, (int)candidate.y );
             }
             else if( dir.y == 0 && dir.x != 0 )
             {
+                // Horizontal construction line: snap to grid intersection
                 candidate.x = aNearestGrid.x;
                 candidate.y = origin.y;
+                wxLogTrace( traceSnap, "      Horizontal snap: candidate=(%d, %d)",
+                            (int)candidate.x, (int)candidate.y );
             }
             else
             {
-                double stepDistance = std::sqrt( aGrid.x * aGrid.x + aGrid.y * aGrid.y );
+                // Diagonal construction line: find nearest grid intersection along the line
+                // We need to find grid points near the projection point and pick the closest
+                // one that lies on the construction line
 
-                if( stepDistance == 0.0 )
-                    continue;
+                // Get the grid origin for proper alignment
+                VECTOR2D gridOrigin( GetOrigin() );
 
-                double steps = std::round( distanceAlong / stepDistance );
-                candidate = originVec + dirUnit * ( steps * stepDistance );
+                // Calculate the projection point relative to grid
+                VECTOR2D relProjection = projection - gridOrigin;
+
+                // Find nearby grid points (check 9 points in a 3x3 grid around the projection)
+                std::vector<VECTOR2D> gridPoints;
+                for( int dx = -1; dx <= 1; ++dx )
+                {
+                    for( int dy = -1; dy <= 1; ++dy )
+                    {
+                        double gridX = std::round( relProjection.x / aGrid.x ) * aGrid.x + dx * aGrid.x;
+                        double gridY = std::round( relProjection.y / aGrid.y ) * aGrid.y + dy * aGrid.y;
+                        gridPoints.push_back( VECTOR2D( gridX + gridOrigin.x, gridY + gridOrigin.y ) );
+                    }
+                }
+
+                // Find the grid point closest to the construction line
+                double   bestGridDist = std::numeric_limits<double>::max();
+                VECTOR2D bestGridPt = projection;
+
+                for( const VECTOR2D& gridPt : gridPoints )
+                {
+                    // Calculate perpendicular distance from grid point to construction line
+                    VECTOR2D gridDelta = gridPt - originVec;
+                    double   gridDistAlong = gridDelta.Dot( dirUnit );
+                    VECTOR2D gridProjection = originVec + dirUnit * gridDistAlong;
+                    double   gridPerpDist = ( gridPt - gridProjection ).EuclideanNorm();
+
+                    // Also consider distance from cursor
+                    double distFromCursor = ( gridPt - cursorVec ).EuclideanNorm();
+
+                    // Prefer grid points that are close to the line and close to cursor
+                    double score = gridPerpDist + distFromCursor * 0.1;
+
+                    if( score < bestGridDist )
+                    {
+                        bestGridDist = score;
+                        bestGridPt = gridPt;
+                    }
+                }
+
+                candidate = bestGridPt;
+                wxLogTrace( traceSnap, "      Diagonal snap: candidate=(%.1f, %.1f), perpDist=%.1f",
+                            candidate.x, candidate.y, bestGridDist );
             }
         }
+        else
+        {
+            wxLogTrace( traceSnap, "      Grid disabled, using projection candidate=(%.1f, %.1f)",
+                        candidate.x, candidate.y );
+        }
 
         VECTOR2I candidateInt( KiROUND( candidate.x ), KiROUND( candidate.y ) );
 
         if( candidateInt == m_skipPoint )
+        {
+            wxLogTrace( traceSnap, "      candidateInt matches m_skipPoint, skipping" );
             continue;
+        }
 
         VECTOR2D candidateDelta( candidateInt.x - aPoint.x, candidateInt.y - aPoint.y );
         double    candidateDistance = candidateDelta.EuclideanNorm();
 
+        wxLogTrace( traceSnap, "      candidateInt=(%d, %d), candidateDist=%.1f",
+                    candidateInt.x, candidateInt.y, candidateDistance );
+
         if( perpDistance < bestPerp
                 || ( std::abs( perpDistance - bestPerp ) < 1e-9 && candidateDistance < bestDistance ) )
         {
+            wxLogTrace( traceSnap, "      NEW BEST: perpDist=%.1f, candDist=%.1f", perpDistance, candidateDistance );
             bestPerp = perpDistance;
             bestDistance = candidateDistance;
             bestPoint = candidateInt;
         }
     }
 
+    if( bestPoint )
+    {
+        wxLogTrace( traceSnap, "  RETURNING bestPoint=(%d, %d)", bestPoint->x, bestPoint->y );
+    }
+    else
+    {
+        wxLogTrace( traceSnap, "  RETURNING nullopt (no valid snap found)" );
+    }
+
     return bestPoint;
 }
 

common/tool/grid_menu.cpp

@@ -59,12 +59,12 @@ void GRID_MENU::UpdateTitle()
 
 void GRID_MENU::update()
 {
-    APP_SETTINGS_BASE* settings = m_parent->config();
-    unsigned int       current = settings->m_Window.grid.last_size_idx + ID_POPUP_GRID_START;
-    wxArrayString      gridsList;
-    int                i = ID_POPUP_GRID_START;
+    WINDOW_SETTINGS* cfg = m_parent->GetWindowSettings( m_parent->config() );
+    unsigned int     current = cfg->grid.last_size_idx + ID_POPUP_GRID_START;
+    wxArrayString    gridsList;
+    int              i = ID_POPUP_GRID_START;
 
-    GRID_MENU::BuildChoiceList( &gridsList, settings, m_parent );
+    GRID_MENU::BuildChoiceList( &gridsList, cfg, m_parent );
 
     while( GetMenuItemCount() > 0 )
         Delete( FindItemByPosition( 0 ) );
@@ -80,8 +80,7 @@ void GRID_MENU::update()
 }
 
 
-void GRID_MENU::BuildChoiceList( wxArrayString* aGridsList, APP_SETTINGS_BASE* aCfg,
-                                 EDA_DRAW_FRAME* aParent )
+void GRID_MENU::BuildChoiceList( wxArrayString* aGridsList, WINDOW_SETTINGS* aCfg, EDA_DRAW_FRAME* aParent )
 {
     wxString     msg;
     EDA_IU_SCALE scale = aParent->GetIuScale();
@@ -90,7 +89,7 @@ void GRID_MENU::BuildChoiceList( wxArrayString* aGridsList, APP_SETTINGS_BASE* a
 
     aParent->GetUnitPair( primaryUnit, secondaryUnit );
 
-    for( GRID& gridSize : aCfg->m_Window.grid.grids )
+    for( GRID& gridSize : aCfg->grid.grids )
     {
         wxString name;
 

common/tool/tool_dispatcher.cpp

@@ -425,6 +425,28 @@ std::optional<TOOL_EVENT> TOOL_DISPATCHER::GetToolEvent( wxKeyEvent* aKeyEvent,
 }
 
 
+void TOOL_DISPATCHER::flushPendingClicks()
+{
+    // When an escape key event arrives, keyboard events can be processed before mouse button
+    // events due to wxWidgets event queue ordering. If a mouse button was pressed and has since
+    // been released (detected via polling), we need to process that click before handling the
+    // escape to maintain proper event ordering.
+    for( BUTTON_STATE* st : m_buttons )
+    {
+        if( st->pressed && !st->GetState() )
+        {
+            st->pressed = false;
+
+            TOOL_EVENT clickEvt( TC_MOUSE, TA_MOUSE_CLICK, st->button );
+            clickEvt.SetMousePosition( st->downPosition );
+            m_toolMgr->ProcessEvent( clickEvt );
+
+            st->dragging = false;
+        }
+    }
+}
+
+
 void TOOL_DISPATCHER::DispatchWxEvent( wxEvent& aEvent )
 {
     bool            motion = false;
@@ -543,6 +565,12 @@ void TOOL_DISPATCHER::DispatchWxEvent( wxEvent& aEvent )
 
         keyIsEscape = ( ke->GetKeyCode() == WXK_ESCAPE );
 
+        // When escape is pressed shortly after a mouse click, the keyboard event can be
+        // processed before the mouse button release event. Flush any pending clicks first
+        // to ensure proper event ordering.
+        if( keyIsEscape )
+            flushPendingClicks();
+
         if( KIUI::IsInputControlFocused( focus ) )
         {
             bool enabled = KIUI::IsInputControlEditable( focus );

common/trace_helpers.cpp

@@ -60,6 +60,7 @@ const wxChar* const traceGit = wxT( "KICAD_GIT" );
 const wxChar* const traceEagleIo = wxT( "KICAD_EAGLE_IO" );
 const wxChar* const traceDesignBlocks = wxT( "KICAD_DESIGN_BLOCK" );
 const wxChar* const traceLibFieldTable = wxT( "KICAD_LIB_FIELD_TABLE" );
+const wxChar* const traceSnap = wxT( "KICAD_SNAP" );
 
 
 wxString dump( const wxArrayString& aArray )

common/view/wx_view_controls.cpp

@@ -214,6 +214,22 @@ void WX_VIEW_CONTROLS::onMotion( wxMouseEvent& aEvent )
     int      y = mouseRel.y;
     VECTOR2D mousePos( x, y );
 
+    // Clear keyboard cursor position flag when actual mouse motion is detected
+    // (i.e., not from cursor warping and position has changed)
+    if( !m_cursorWarped && m_settings.m_lastKeyboardCursorPositionValid )
+    {
+        VECTOR2I screenPos( x, y );
+        VECTOR2I keyboardScreenPos = m_view->ToScreen( m_settings.m_lastKeyboardCursorPosition );
+
+        // If mouse has moved to a different position than the keyboard cursor position,
+        // clear the keyboard position flag to allow mouse control
+        if( screenPos != keyboardScreenPos )
+        {
+            m_settings.m_lastKeyboardCursorPositionValid = false;
+            m_settings.m_lastKeyboardCursorPosition = { 0.0, 0.0 };
+        }
+    }
+
     // Automatic focus switching between SCH and PCB windows on canvas mouse motion
     if( m_settings.m_focusFollowSchPcb )
     {

common/widgets/app_progress_dialog.cpp

@@ -22,9 +22,9 @@
  */
 
 #include <wx/version.h>
+#include <wx/sizer.h>
 #include <widgets/app_progress_dialog.h>
 
-
 APP_PROGRESS_DIALOG::APP_PROGRESS_DIALOG( const wxString& aTitle, const wxString& aMessage,
                                           int aMaximum, wxWindow* aParent,
                                           bool aIndeterminateTaskBarStatus, int aStyle )
@@ -39,6 +39,11 @@ APP_PROGRESS_DIALOG::APP_PROGRESS_DIALOG( const wxString& aTitle, const wxString
     {
         m_appProgressIndicator.Pulse();
     }
+
+    Layout();
+
+    if( GetSizer() )
+        GetSizer()->Fit( this );
 }
 
 

common/widgets/color_swatch.cpp

@@ -208,11 +208,7 @@ void COLOR_SWATCH::setupEvents( bool aTriggerWithSingleClick )
 {
     if( dynamic_cast<DIALOG_SHIM*>( wxGetTopLevelParent( this ) ) )
     {
-        m_swatch->Bind( wxEVT_LEFT_DOWN,
-                        [this] ( wxMouseEvent& aEvt )
-                        {
-                            GetNewSwatchColor();
-                        } );
+        m_swatch->Bind( wxEVT_LEFT_DOWN, &COLOR_SWATCH::onMouseEvent, this );
     }
     else
     {
@@ -220,27 +216,15 @@ void COLOR_SWATCH::setupEvents( bool aTriggerWithSingleClick )
         m_swatch->Bind( wxEVT_LEFT_DOWN, &COLOR_SWATCH::rePostEvent, this );
 
         // bind the events that trigger the dialog
-        m_swatch->Bind( wxEVT_LEFT_DCLICK,
-                        [this] ( wxMouseEvent& aEvt )
-                        {
-                            GetNewSwatchColor();
-                        } );
+        m_swatch->Bind( wxEVT_LEFT_DCLICK, &COLOR_SWATCH::onMouseEvent, this );
 
         if( aTriggerWithSingleClick )
         {
-            m_swatch->Bind( wxEVT_LEFT_UP,
-                        [this] ( wxMouseEvent& aEvt )
-                        {
-                            GetNewSwatchColor();
-                        } );
+            m_swatch->Bind( wxEVT_LEFT_UP, &COLOR_SWATCH::onMouseEvent, this );
         }
     }
 
-    m_swatch->Bind( wxEVT_MIDDLE_DOWN,
-                    [this] ( wxMouseEvent& aEvt )
-                    {
-                        GetNewSwatchColor();
-                    } );
+    m_swatch->Bind( wxEVT_MIDDLE_DOWN, &COLOR_SWATCH::onMouseEvent, this );
 
     m_swatch->Bind( wxEVT_RIGHT_DOWN, &COLOR_SWATCH::rePostEvent, this );
 }
@@ -252,6 +236,12 @@ void COLOR_SWATCH::rePostEvent( wxEvent& aEvent )
 }
 
 
+void COLOR_SWATCH::onMouseEvent( wxEvent& )
+{
+    GetNewSwatchColor();
+}
+
+
 static void sendSwatchChangeEvent( COLOR_SWATCH& aSender )
 {
     wxCommandEvent changeEvt( COLOR_SWATCH_CHANGED, aSender.GetId() );

common/widgets/kistatusbar.cpp

@@ -193,7 +193,12 @@ void KISTATUSBAR::HideBackgroundProgressBar()
 
 void KISTATUSBAR::SetBackgroundProgress( int aAmount )
 {
-    m_backgroundProgressBar->SetValue( aAmount );
+    int value = m_backgroundProgressBar->GetRange();
+
+    if( value <= aAmount )
+        value = aAmount;
+
+    m_backgroundProgressBar->SetValue( value );
 }
 
 

common/widgets/mathplot.cpp

@@ -624,7 +624,11 @@ void mpFXY::Plot( wxDC& dc, mpWindow& w )
 #else
             int chunkSize = 100000;
 #endif
-            if( dc.GetPen().GetStyle() == wxPENSTYLE_DOT )
+            wxPenStyle penStyle = dc.GetPen().GetStyle();
+            bool isSolidPen = ( penStyle == wxPENSTYLE_SOLID
+                                || penStyle == wxPENSTYLE_TRANSPARENT );
+
+            if( !isSolidPen )
                 chunkSize /= 500;
 
             drawPoints.push_back( pointList[0] );   // push the first point in list
@@ -632,9 +636,11 @@ void mpFXY::Plot( wxDC& dc, mpWindow& w )
             for( size_t ii = 1; ii < pointList.size()-1; ii++ )
             {
                 // Skip intermediate points between the first point and the last point of the
-                // segment candidate
-                if( drawPoints.back().y == pointList[ii].y &&
-                    drawPoints.back().y == pointList[ii+1].y )
+                // segment candidate. This optimization merges horizontal line segments, which
+                // breaks non-solid pen styles by altering segment lengths.
+                if( isSolidPen
+                    && drawPoints.back().y == pointList[ii].y
+                    && drawPoints.back().y == pointList[ii+1].y )
                 {
                     continue;
                 }

common/widgets/report_severity.cpp

@@ -0,0 +1,53 @@
+/*
+ * This program source code file is part of KiCad, a free EDA CAD application.
+ *
+ * Copyright The KiCad Developers, see AUTHORS.txt for contributors.
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation, either version 3 of the License, or (at your
+ * option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#include <widgets/report_severity.h>
+#include <wx/intl.h>
+#include <i18n_utility.h>
+#include <vector>
+
+
+wxString formatSeverities( int aSeverities )
+{
+    wxString result;
+    std::vector<wxString> items;
+
+    if( aSeverities & RPT_SEVERITY_ERROR )
+        items.push_back( _( "Errors" ) );
+
+    if( aSeverities & RPT_SEVERITY_WARNING )
+        items.push_back( _( "Warnings" ) );
+
+    if( aSeverities & RPT_SEVERITY_EXCLUSION )
+        items.push_back( _( "Exclusions" ) );
+
+    if( items.empty() )
+        return _( "None" );
+
+    for( size_t i = 0; i < items.size(); i++ )
+    {
+        result += items[i];
+
+        if( i < items.size() - 1 )
+            result += wxS( ", " );
+    }
+
+    return result;
+}
+

common/widgets/widget_hotkey_list.cpp

@@ -513,16 +513,11 @@ bool WIDGET_HOTKEY_LIST::resolveKeyConflicts( TOOL_ACTION* aAction, long aKey )
 }
 
 
-WIDGET_HOTKEY_LIST::WIDGET_HOTKEY_LIST( wxWindow* aParent, HOTKEY_STORE& aHotkeyStore,
-                                        bool aReadOnly ) :
+WIDGET_HOTKEY_LIST::WIDGET_HOTKEY_LIST( wxWindow* aParent, HOTKEY_STORE& aHotkeyStore ) :
         wxTreeListCtrl( aParent, wxID_ANY, wxDefaultPosition, wxDefaultSize, wxTL_SINGLE ),
-        m_hk_store( aHotkeyStore ),
-        m_readOnly( aReadOnly )
+        m_hk_store( aHotkeyStore )
 {
-    wxString command_header = _( "Command" );
-
-    if( !m_readOnly )
-        command_header << wxS( " " ) << _( "(double-click to edit)" );
+    wxString command_header = _( "Command (double-click to edit)" );
 
     AppendColumn( command_header, 450, wxALIGN_LEFT, wxCOL_RESIZABLE | wxCOL_SORTABLE );
     AppendColumn( _( "Hotkey" ), 120, wxALIGN_LEFT, wxCOL_RESIZABLE | wxCOL_SORTABLE );
@@ -568,13 +563,9 @@ WIDGET_HOTKEY_LIST::WIDGET_HOTKEY_LIST( wxWindow* aParent, HOTKEY_STORE& aHotkey
 
     GetDataView()->SetIndent( 10 );
 
-    if( !m_readOnly )
-    {
-        // The event only apply if the widget is in editable mode
-        Bind( wxEVT_TREELIST_ITEM_ACTIVATED, &WIDGET_HOTKEY_LIST::onActivated, this );
-        Bind( wxEVT_TREELIST_ITEM_CONTEXT_MENU, &WIDGET_HOTKEY_LIST::onContextMenu, this );
-        Bind( wxEVT_MENU, &WIDGET_HOTKEY_LIST::onMenu, this );
-    }
+    Bind( wxEVT_TREELIST_ITEM_ACTIVATED, &WIDGET_HOTKEY_LIST::onActivated, this );
+    Bind( wxEVT_TREELIST_ITEM_CONTEXT_MENU, &WIDGET_HOTKEY_LIST::onContextMenu, this );
+    Bind( wxEVT_MENU, &WIDGET_HOTKEY_LIST::onMenu, this );
 }
 
 

common/widgets/wx_infobar.cpp

@@ -30,6 +30,7 @@
 #include <wx/sizer.h>
 #include <wx/stattext.h>
 #include <wx/timer.h>
+#include <wx/dcclient.h>
 #include <eda_base_frame.h>
 
 #ifdef __WXMSW__
@@ -236,11 +237,28 @@ void WX_INFOBAR::onSize( wxSizeEvent& aEvent )
     if( !sizer )
         return;
 
-    wxSizerItem* text = sizer->GetItem( 1 );
+    // wx3.3 moved the sizer we previously wanted deeper into sizers...
+    // do we actually still need this for wx3.3?
+    #if wxCHECK_VERSION( 3, 3, 0 )
+    wxSizerItem* outerSizer = sizer->GetItem( (size_t) 0 );
+    wxSizerItem* textSizer = nullptr;
 
-    if( text )
+    if (outerSizer->IsSizer())
     {
-        if( auto textCtrl = dynamic_cast<wxStaticText*>( text->GetWindow() ) )
+        wxBoxSizer* innerSizer1 = dynamic_cast<wxBoxSizer*>( outerSizer->GetSizer() );
+        wxBoxSizer* innerSizer2 =
+                dynamic_cast<wxBoxSizer*>( innerSizer1->GetItem((size_t)0)->GetSizer() );
+
+        if( innerSizer2 )
+            textSizer = innerSizer2->GetItem( 1 );
+    }
+    #else
+    wxSizerItem* textSizer = sizer->GetItem( 1 );
+    #endif
+
+    if( textSizer )
+    {
+        if( wxStaticText* textCtrl = dynamic_cast<wxStaticText*>( textSizer->GetWindow() ) )
             textCtrl->SetLabelText( m_message );
     }
 
@@ -257,9 +275,9 @@ void WX_INFOBAR::onSize( wxSizeEvent& aEvent )
     if( barWidth != parentWidth )
         SetSize( parentWidth, GetSize().GetHeight() );
 
-    if( text )
+    if( textSizer )
     {
-        if( auto textCtrl = dynamic_cast<wxStaticText*>( text->GetWindow() ) )
+        if( wxStaticText* textCtrl = dynamic_cast<wxStaticText*>( textSizer->GetWindow() ) )
         {
             // Re-wrap the text (this is done automatically later but we need it now)
             // And count how many lines we need.  If we have embedded newlines, then
@@ -267,10 +285,18 @@ void WX_INFOBAR::onSize( wxSizeEvent& aEvent )
             // min height for the control.  The min height of the text control will be the size
             // of a single line of text.  This assumes that two lines of text are larger
             // than the height of the icon for the bar.
-            textCtrl->Wrap( text->GetSize().GetWidth() );
-            wxString new_text = textCtrl->GetLabel();
-            int      height = ( new_text.Freq( '\n' ) + 1 ) * text->GetMinSize().GetHeight();
-            SetMinSize( wxSize( GetSize().GetWidth(), height ) );
+            textCtrl->Wrap( -1 );
+            wxString wrapped_text = textCtrl->GetLabel();
+            int line_count = wrapped_text.Freq( '\n' ) + 1;
+            int txt_h, txt_v;
+            wxWindowDC dc( textCtrl );
+            dc.GetTextExtent( wxT( "Xp" ), &txt_h, &txt_v );
+
+            int      height = txt_v * line_count;
+            int      margins = txt_v - 1;
+            SetMinSize( wxSize( GetSize().GetWidth(), height + margins ) );
+
+            textCtrl->Wrap( -1 );
         }
     }
 
@@ -323,7 +349,10 @@ void WX_INFOBAR::AddButton( wxButton* aButton )
     element->SetFlag( wxSTRETCH_MASK );
 
     if( IsShownOnScreen() )
-        sizer->Layout();
+    {
+        Layout();
+        sizer->Fit( this );
+    }
 }
 
 
@@ -336,7 +365,10 @@ void WX_INFOBAR::AddButton( wxHyperlinkCtrl* aHypertextButton )
     sizer->Add( aHypertextButton, wxSizerFlags().Centre().Border( wxRIGHT ).Shaped() );
 
     if( IsShownOnScreen() )
-        sizer->Layout();
+    {
+        Layout();
+        sizer->Fit( this );
+    }
 }
 
 
@@ -498,13 +530,13 @@ void INFOBAR_REPORTER::Finalize()
     switch( m_severity )
     {
     case RPT_SEVERITY_UNDEFINED: icon = wxICON_INFORMATION; break;
-    case RPT_SEVERITY_INFO: icon = wxICON_INFORMATION; break;
-    case RPT_SEVERITY_EXCLUSION: icon = wxICON_WARNING; break;
-    case RPT_SEVERITY_ACTION: icon = wxICON_WARNING; break;
-    case RPT_SEVERITY_WARNING: icon = wxICON_WARNING; break;
-    case RPT_SEVERITY_ERROR: icon = wxICON_ERROR; break;
-    case RPT_SEVERITY_IGNORE: icon = wxICON_INFORMATION; break;
-    case RPT_SEVERITY_DEBUG: icon = wxICON_INFORMATION; break;
+    case RPT_SEVERITY_INFO:      icon = wxICON_INFORMATION; break;
+    case RPT_SEVERITY_EXCLUSION: icon = wxICON_WARNING;     break;
+    case RPT_SEVERITY_ACTION:    icon = wxICON_WARNING;     break;
+    case RPT_SEVERITY_WARNING:   icon = wxICON_WARNING;     break;
+    case RPT_SEVERITY_ERROR:     icon = wxICON_ERROR;       break;
+    case RPT_SEVERITY_IGNORE:    icon = wxICON_INFORMATION; break;
+    case RPT_SEVERITY_DEBUG:     icon = wxICON_INFORMATION; break;
     }
 
     if( m_message->EndsWith( wxS( "\n" ) ) )

eeschema/CMakeLists.txt

@@ -32,7 +32,6 @@ include_directories( BEFORE ${INC_BEFORE} )
 include_directories(
     ${CMAKE_SOURCE_DIR}/common
     ${CMAKE_SOURCE_DIR}/common/dialogs
-    ${CMAKE_SOURCE_DIR}/libs/sexpr/include
     ${INC_AFTER}
     ./dialogs
     ./libview
@@ -609,7 +608,6 @@ target_link_libraries( eeschema_kiface
         eeschema_kiface_objects
         markdown_lib
         scripting
-        sexpr
         core
         Boost::headers
         ${wxWidgets_LIBRARIES}

eeschema/bus_alias.h

@@ -45,11 +45,34 @@ public:
         return std::make_shared<BUS_ALIAS>( *this );
     }
 
-    wxString GetName() { return m_name; }
-    void SetName( const wxString& aName ) { m_name = aName; }
+    wxString GetName() const { return m_name; }
+
+    void SetName( const wxString& aName ) { m_name = aName.Strip( wxString::both ); }
 
     const std::vector<wxString>& Members() const { return m_members; }
-    std::vector<wxString>& Members() { return m_members; }
+
+    void SetMembers( const std::vector<wxString>& aMembers )
+    {
+        m_members.clear();
+
+        for( const wxString& member : aMembers )
+        {
+            wxString trimmed = member.Strip( wxString::both );
+
+            if( !trimmed.IsEmpty() )
+                m_members.push_back( trimmed );
+        }
+    }
+
+    void AddMember( const wxString& aMember )
+    {
+        wxString trimmed = aMember.Strip( wxString::both );
+
+        if( !trimmed.IsEmpty() )
+            m_members.push_back( trimmed );
+    }
+
+    void ClearMembers() { m_members.clear(); }
 
     SCH_SCREEN* GetParent() { return m_parent; }
     void SetParent( SCH_SCREEN* aParent ) { m_parent = aParent; }

eeschema/connection_graph.cpp

@@ -151,8 +151,8 @@ bool CONNECTION_SUBGRAPH::ResolveDrivers( bool aCheckMultipleDrivers )
                 SCH_PIN* pa = static_cast<SCH_PIN*>( a );
                 SCH_PIN* pb = static_cast<SCH_PIN*>( b );
 
-                bool aPower = pa->GetLibPin()->GetParentSymbol()->IsPower();
-                bool bPower = pb->GetLibPin()->GetParentSymbol()->IsPower();
+                bool aPower = pa->IsOnPowerSymbol();
+                bool bPower = pb->IsOnPowerSymbol();
 
                 if( aPower && !bPower )
                     return true;
@@ -327,6 +327,7 @@ std::vector<SCH_ITEM*> CONNECTION_SUBGRAPH::GetAllBusLabels() const
         {
         case SCH_LABEL_T:
         case SCH_GLOBAL_LABEL_T:
+        case SCH_HIER_LABEL_T:
         {
             CONNECTION_TYPE type = item->Connection( &m_sheet )->Type();
 
@@ -356,6 +357,7 @@ std::vector<SCH_ITEM*> CONNECTION_SUBGRAPH::GetVectorBusLabels() const
         {
         case SCH_LABEL_T:
         case SCH_GLOBAL_LABEL_T:
+        case SCH_HIER_LABEL_T:
         {
             SCH_CONNECTION* label_conn = item->Connection( &m_sheet );
 
@@ -441,13 +443,13 @@ CONNECTION_SUBGRAPH::GetNetclassesForDriver( SCH_ITEM* aItem ) const
     // Get netclasses on attached rule areas
     for( SCH_RULE_AREA* ruleArea : ruleAreaCache )
     {
-        const std::vector<std::pair<wxString, SCH_ITEM*>> ruleNetclasses =
-                ruleArea->GetResolvedNetclasses();
+        const std::vector<std::pair<wxString, SCH_ITEM*>> ruleAreaNetclasses =
+                ruleArea->GetResolvedNetclasses( &m_sheet );
 
-        if( ruleNetclasses.size() > 0 )
+        if( ruleAreaNetclasses.size() > 0 )
         {
-            foundNetclasses.insert( foundNetclasses.end(), ruleNetclasses.begin(),
-                                    ruleNetclasses.end() );
+            foundNetclasses.insert( foundNetclasses.end(), ruleAreaNetclasses.begin(),
+                                    ruleAreaNetclasses.end() );
         }
     }
 
@@ -1638,6 +1640,10 @@ void CONNECTION_GRAPH::generateBusAliasMembers()
 
             for( const auto& conn : dummy.Members() )
             {
+                // Only create subgraphs for NET members, not nested buses
+                if( !conn->IsNet() )
+                    continue;
+
                 wxString name = conn->FullLocalName();
 
                 CONNECTION_SUBGRAPH* new_sg = new CONNECTION_SUBGRAPH( this );
@@ -1684,6 +1690,32 @@ void CONNECTION_GRAPH::generateGlobalPowerPinSubGraphs()
     // These are NOT limited to power symbols, we support legacy invisible + power-in pins
     // on non-power symbols.
 
+    // Sort power pins for deterministic processing order. This ensures that when multiple
+    // power pins share the same net name, the same pin consistently creates the subgraph
+    // across different ERC runs.
+    std::sort( m_global_power_pins.begin(), m_global_power_pins.end(),
+               []( const std::pair<SCH_SHEET_PATH, SCH_PIN*>& a,
+                   const std::pair<SCH_SHEET_PATH, SCH_PIN*>& b )
+               {
+                   int pathCmp = a.first.Cmp( b.first );
+
+                   if( pathCmp != 0 )
+                       return pathCmp < 0;
+
+                   const SCH_SYMBOL* symA = static_cast<const SCH_SYMBOL*>( a.second->GetParentSymbol() );
+                   const SCH_SYMBOL* symB = static_cast<const SCH_SYMBOL*>( b.second->GetParentSymbol() );
+
+                   wxString refA = symA ? symA->GetRef( &a.first, false ) : wxString();
+                   wxString refB = symB ? symB->GetRef( &b.first, false ) : wxString();
+
+                   int refCmp = refA.Cmp( refB );
+
+                   if( refCmp != 0 )
+                       return refCmp < 0;
+
+                   return a.second->GetNumber().Cmp( b.second->GetNumber() ) < 0;
+               } );
+
     std::unordered_map<int, CONNECTION_SUBGRAPH*> global_power_pin_subgraphs;
 
     for( const auto& it : m_global_power_pins )
@@ -1692,7 +1724,7 @@ void CONNECTION_GRAPH::generateGlobalPowerPinSubGraphs()
         SCH_PIN*       pin   = it.second;
 
         if( !pin->ConnectedItems( sheet ).empty()
-          && !pin->GetLibPin()->GetParentSymbol()->IsPower() )
+          && !pin->IsOnPowerSymbol() )
         {
             // ERC will warn about this: user has wired up an invisible pin
             continue;
@@ -1707,7 +1739,7 @@ void CONNECTION_GRAPH::generateGlobalPowerPinSubGraphs()
         // Proper modern power symbols get their net name from the value field
         // in the symbol, but we support legacy non-power symbols with global
         // power connections based on invisible, power-in, pin's names.
-        if( pin->GetLibPin()->GetParentSymbol()->IsPower() )
+        if( pin->IsOnPowerSymbol() )
             connection->SetName( pin->GetParentSymbol()->GetValue( true, &sheet, false ) );
         else
             connection->SetName( pin->GetShownName() );
@@ -2316,12 +2348,19 @@ void CONNECTION_GRAPH::buildConnectionGraph( std::function<void( SCH_ITEM* )>* a
                     if( jj == m_net_name_to_subgraphs_map.end() )
                         continue;
 
-                    for( CONNECTION_SUBGRAPH* old_sg : jj->second )
+                    // Copy the vector to avoid iterator invalidation when recaching
+                    std::vector<CONNECTION_SUBGRAPH*> old_subgraphs = jj->second;
+
+                    for( CONNECTION_SUBGRAPH* old_sg : old_subgraphs )
                     {
                         while( old_sg->m_absorbed )
                             old_sg = old_sg->m_absorbed_by;
 
+                        wxString old_sg_name = old_sg->m_driver_connection->Name();
                         old_sg->m_driver_connection->Clone( *conn );
+
+                        if( old_sg_name != old_sg->m_driver_connection->Name() )
+                            recacheSubgraphName( old_sg, old_sg_name );
                     }
                 }
             }
@@ -2692,9 +2731,30 @@ void CONNECTION_GRAPH::propagateToNeighbors( CONNECTION_SUBGRAPH* aSubgraph, boo
 
     auto propagate_bus_neighbors = [&]( CONNECTION_SUBGRAPH* aParentGraph )
     {
+        // Sort bus neighbors by name to ensure deterministic processing order.
+        // When multiple bus members (e.g., A0, A1, A2, A3) all connect to the same
+        // shorted net in a child sheet, the first one processed "wins" and sets
+        // the net name. Sorting ensures the alphabetically-first name is chosen.
+        std::vector<std::shared_ptr<SCH_CONNECTION>> sortedMembers;
+
         for( const auto& kv : aParentGraph->m_bus_neighbors )
+            sortedMembers.push_back( kv.first );
+
+        std::sort( sortedMembers.begin(), sortedMembers.end(),
+                   []( const std::shared_ptr<SCH_CONNECTION>& a,
+                       const std::shared_ptr<SCH_CONNECTION>& b )
+                   {
+                       return a->Name() < b->Name();
+                   } );
+
+        for( const std::shared_ptr<SCH_CONNECTION>& member_conn : sortedMembers )
         {
-            for( CONNECTION_SUBGRAPH* neighbor : kv.second )
+            const auto& kv_it = aParentGraph->m_bus_neighbors.find( member_conn );
+
+            if( kv_it == aParentGraph->m_bus_neighbors.end() )
+                continue;
+
+            for( CONNECTION_SUBGRAPH* neighbor : kv_it->second )
             {
                 // May have been absorbed but won't have been deleted
                 while( neighbor->m_absorbed )
@@ -2705,12 +2765,12 @@ void CONNECTION_GRAPH::propagateToNeighbors( CONNECTION_SUBGRAPH* aSubgraph, boo
                 // Now member may be out of date, since we just cloned the
                 // connection from higher up in the hierarchy.  We need to
                 // figure out what the actual new connection is.
-                SCH_CONNECTION* member = matchBusMember( parent, kv.first.get() );
+                SCH_CONNECTION* member = matchBusMember( parent, member_conn.get() );
 
                 if( !member )
                 {
                     // Try harder: we might match on a secondary driver
-                    for( CONNECTION_SUBGRAPH* sg : kv.second )
+                    for( CONNECTION_SUBGRAPH* sg : kv_it->second )
                     {
                         if( sg->m_multiple_drivers )
                         {
@@ -2735,7 +2795,7 @@ void CONNECTION_GRAPH::propagateToNeighbors( CONNECTION_SUBGRAPH* aSubgraph, boo
                 if( !member )
                 {
                     wxLogTrace( ConnTrace, wxS( "Could not match bus member %s in %s" ),
-                                kv.first->Name(), parent->Name() );
+                                member_conn->Name(), parent->Name() );
                     continue;
                 }
 
@@ -2749,9 +2809,27 @@ void CONNECTION_GRAPH::propagateToNeighbors( CONNECTION_SUBGRAPH* aSubgraph, boo
                 if( neighbor_name == member->Name() )
                     continue;
 
-                // Was this neighbor already updated from a different sheet?  Don't rename it again
+                // Was this neighbor already updated from a different sheet?  Don't rename it again,
+                // unless this same parent bus updated it and the bus member name has since changed
+                // (which can happen when a bus member is renamed via stale member update, issue #18299).
                 if( neighbor_conn->Sheet() != neighbor->m_sheet )
-                    continue;
+                {
+                    // If the neighbor's connection sheet doesn't match this parent bus's sheet,
+                    // it was updated by a different bus entirely. Don't override.
+                    if( neighbor_conn->Sheet() != parent->Sheet() )
+                        continue;
+
+                    // If the neighbor's connection sheet matches this parent bus's sheet but
+                    // the names differ, check if the neighbor's current name still matches
+                    // a member of this bus. If it does, the neighbor was updated by a different
+                    // member of this same bus and we should preserve that (determinism).
+                    // If it doesn't match any member, the bus member was renamed and we should update.
+                    SCH_CONNECTION temp( nullptr, neighbor->m_sheet );
+                    temp.ConfigureFromLabel( neighbor_name );
+
+                    if( matchBusMember( parent, &temp ) )
+                        continue;
+                }
 
                 // Safety check against infinite recursion
                 wxCHECK2_MSG( neighbor_conn->IsNet(), continue,
@@ -2776,6 +2854,17 @@ void CONNECTION_GRAPH::propagateToNeighbors( CONNECTION_SUBGRAPH* aSubgraph, boo
                     // Recurse onto this neighbor in case it needs to re-propagate
                     neighbor->m_dirty = true;
                     propagateToNeighbors( neighbor, aForce );
+
+                    // After hierarchy propagation, the neighbor's connection may have been
+                    // updated to a higher-priority driver (e.g., a power symbol discovered
+                    // through hierarchical sheet pins). If so, update the bus member to match.
+                    // This ensures that net names propagate correctly through bus connections
+                    // that span hierarchical boundaries (issue #18119).
+                    if( neighbor_conn->Name() != member->Name() )
+                    {
+                        member->Clone( *neighbor_conn );
+                        stale_bus_members.insert( member );
+                    }
                 }
             }
         }
@@ -3775,7 +3864,7 @@ bool CONNECTION_GRAPH::ercCheckNoConnects( const CONNECTION_SUBGRAPH* aSubgraph
         // net items by name, because usually failing to connect them graphically is a mistake
         if( pin && !has_other_connections
                 && !pin->IsGlobalPower()
-                && !pin->GetLibPin()->GetParentSymbol()->IsPower() )
+                && !pin->IsOnPowerSymbol() )
         {
             wxString name = pin->Connection( &sheet )->Name();
             wxString local_name = pin->Connection( &sheet )->Name( true );
@@ -3814,7 +3903,7 @@ bool CONNECTION_GRAPH::ercCheckNoConnects( const CONNECTION_SUBGRAPH* aSubgraph
                 // We only apply this test to power symbols, because other symbols have
                 // pins that are meant to be dangling, but the power symbols have pins
                 // that are *not* meant to be dangling.
-                if( testPin->GetLibPin()->GetParentSymbol()->IsPower()
+                if( testPin->IsOnPowerSymbol()
                     && testPin->ConnectedItems( sheet ).empty()
                     && settings.IsTestEnabled( ERCE_PIN_NOT_CONNECTED ) )
                 {

eeschema/cross-probing.cpp

@@ -1058,6 +1058,27 @@ void SCH_EDIT_FRAME::KiwayMailIn( KIWAY_EXPRESS& mail )
         SyncView();
         break;
 
+    case MAIL_SCH_NAVIGATE_TO_SHEET:
+    {
+        wxString targetFile( payload );
+
+        for( SCH_SHEET_PATH& sheetPath : Schematic().Hierarchy() )
+        {
+            SCH_SCREEN* screen = sheetPath.LastScreen();
+
+            if( screen && screen->GetFileName() == targetFile )
+            {
+                m_toolManager->RunAction<SCH_SHEET_PATH*>( SCH_ACTIONS::changeSheet, &sheetPath );
+                payload = "success";
+                Raise();
+                return;
+            }
+        }
+
+        payload.clear();
+        break;
+    }
+
     default:;
 
     }

eeschema/dialogs/dialog_change_symbols.cpp

@@ -640,15 +640,6 @@ int DIALOG_CHANGE_SYMBOLS::processSymbols( SCH_COMMIT* aCommit,
         screen->Remove( symbol );
         SCH_SYMBOL* symbol_copy = static_cast<SCH_SYMBOL*>( symbol->Clone() );
         aCommit->Modified( symbol, symbol_copy, screen );
-
-        CONNECTION_GRAPH*           connectionGraph = screen->Schematic()->ConnectionGraph();
-
-        // When we replace the lib symbol below, we free the associated pins if the new symbol has
-        // fewer than the original.  This will cause the connection graph to be out of date unless
-        // we replace references in the graph to the old symbol/pins with references to the ones
-        // stored in the undo stack.
-        if( connectionGraph )
-            connectionGraph->ExchangeItem( symbol, symbol_copy );
     }
 
     for( const auto& [ symbol, symbol_change_info ] : symbols )

eeschema/dialogs/dialog_erc.cpp

@@ -49,7 +49,7 @@
 #include <wx/filedlg.h>
 #include <wx/hyperlink.h>
 #include <wx/msgdlg.h>
-#include <wx/wupdlock.h>
+#include <sch_edit_tool.h>
 
 
 wxDEFINE_EVENT( EDA_EVT_CLOSE_ERC_DIALOG, wxCommandEvent );
@@ -93,6 +93,10 @@ DIALOG_ERC::DIALOG_ERC( SCH_EDIT_FRAME* parent ) :
     m_markerDataView->AssociateModel( m_markerTreeModel );
     m_markerTreeModel->Update( m_markerProvider, m_severities );
 
+    // Prevent RTL locales from mirroring the text in the data views
+    m_markerDataView->SetLayoutDirection( wxLayout_LeftToRight );
+    m_ignoredList->SetLayoutDirection( wxLayout_LeftToRight );
+
     m_ignoredList->InsertColumn( 0, wxEmptyString, wxLIST_FORMAT_LEFT, DEFAULT_SINGLE_COL_WIDTH );
 
     if( m_currentSchematic == g_lastERCSchematic )
@@ -124,13 +128,14 @@ DIALOG_ERC::DIALOG_ERC( SCH_EDIT_FRAME* parent ) :
 
     UpdateAnnotationWarning();
 
-    Layout();
-
     SetFocus();
 
     syncCheckboxes();
     updateDisplayedCounts();
 
+    Layout();
+    GetSizer()->Fit( this );
+
     // Now all widgets have the size fixed, call FinishDialogSettings
     finishDialogSettings();
 }
@@ -1041,7 +1046,7 @@ void DIALOG_ERC::deleteAllMarkers( bool aIncludeExclusions )
     // Clear current selection list to avoid selection of deleted items
     // Freeze to avoid repainting the dialog, which can cause a RePaint()
     // of the screen as well
-    wxWindowUpdateLocker updateLock( this );
+    Freeze();
 
     m_parent->GetToolManager()->RunAction( SCH_ACTIONS::clearSelection );
 
@@ -1049,6 +1054,8 @@ void DIALOG_ERC::deleteAllMarkers( bool aIncludeExclusions )
 
     SCH_SCREENS screens( m_parent->Schematic().Root() );
     screens.DeleteAllMarkers( MARKER_BASE::MARKER_ERC, aIncludeExclusions );
+
+    Thaw();
 }
 
 
@@ -1074,7 +1081,7 @@ void DIALOG_ERC::OnSaveReport( wxCommandEvent& aEvent )
         fn.MakeAbsolute( prj_path );
     }
 
-    ERC_REPORT reportWriter( &m_parent->Schematic(), m_parent->GetUserUnits() );
+    ERC_REPORT reportWriter( &m_parent->Schematic(), m_parent->GetUserUnits(), m_markerProvider );
 
     bool success = false;
     if( fn.GetExt() == FILEEXT::JsonFileExtension )

eeschema/dialogs/dialog_label_properties.cpp

@@ -683,6 +683,7 @@ bool DIALOG_LABEL_PROPERTIES::TransferDataFromWindow()
             case SCH_GLOBAL_LABEL_T:
             {
                 SCH_GLOBALLABEL* label = new SCH_GLOBALLABEL( *static_cast<SCH_GLOBALLABEL*>( m_currentLabel ) );
+                const_cast<KIID&>( label->m_Uuid ) = KIID();     // Gives a new UUID to the copy
                 label->SetText( text );
                 m_labelList->push_back( std::unique_ptr<SCH_LABEL_BASE>( label ) );
                 break;
@@ -690,6 +691,7 @@ bool DIALOG_LABEL_PROPERTIES::TransferDataFromWindow()
             case SCH_HIER_LABEL_T:
             {
                 SCH_HIERLABEL* label = new SCH_HIERLABEL( *static_cast<SCH_HIERLABEL*>( m_currentLabel ) );
+                const_cast<KIID&>( label->m_Uuid ) = KIID();
                 label->SetText( text );
                 m_labelList->push_back( std::unique_ptr<SCH_LABEL_BASE>( label ) );
                 break;
@@ -697,6 +699,7 @@ bool DIALOG_LABEL_PROPERTIES::TransferDataFromWindow()
             case SCH_LABEL_T:
             {
                 SCH_LABEL* label = new SCH_LABEL( *static_cast<SCH_LABEL*>( m_currentLabel ) );
+                const_cast<KIID&>( label->m_Uuid ) = KIID();
                 label->SetText( text );
                 m_labelList->push_back( std::unique_ptr<SCH_LABEL_BASE>( label ) );
                 break;
@@ -956,7 +959,7 @@ void DIALOG_LABEL_PROPERTIES::onMultiLabelCheck( wxCommandEvent& event )
             wxString multiText = m_valueMultiLine->GetValue();
             m_valueCombo->SetValue( multiText.BeforeFirst( '\n' ) );
             m_activeTextEntry = m_valueCombo;
-            SetInitialFocus( m_valueCombo );
+            SetInitialFocus( m_valueCombo->GetTextCtrl() );
         }
     }
     else if( m_currentLabel->Type() == SCH_HIER_LABEL_T )

eeschema/dialogs/dialog_lib_edit_pin_table.cpp

@@ -963,6 +963,7 @@ void DIALOG_LIB_EDIT_PIN_TABLE::OnAddRow( wxCommandEvent& event )
         newPin->SetType( last->GetType() );
         newPin->SetShape( last->GetShape() );
         newPin->SetUnit( last->GetUnit() );
+        newPin->SetBodyStyle( last->GetBodyStyle() );
 
         VECTOR2I pos = last->GetPosition();
 

eeschema/dialogs/dialog_lib_fields.cpp

@@ -399,39 +399,37 @@ void DIALOG_LIB_FIELDS::loadSymbols( const wxArrayString& aSymbolNames )
     // Clear any existing data
     m_symbolsList.clear();
 
-    try
+    wxString libName = m_parent->GetTreeLIBID().GetLibNickname();
+
+    if( aSymbolNames.IsEmpty() )
     {
-        if( aSymbolNames.IsEmpty() )
+        wxMessageBox( wxString::Format( _( "No symbols found in library %s." ), m_libId ) );
+        return;
+    }
+
+    // Load each symbol from the library manager and add it to our list
+    for( const wxString& symbolName : aSymbolNames )
+    {
+        LIB_SYMBOL* canvasSymbol = m_parent->GetCurSymbol();
+
+        if( canvasSymbol && canvasSymbol->GetLibraryName() == libName && canvasSymbol->GetName() == symbolName )
         {
-            wxMessageBox( wxString::Format( _( "No symbols found in library %s." ), m_libId ) );
-            return;
+            m_symbolsList.push_back( canvasSymbol );
         }
-
-        // Load each symbol from the library manager and add it to our list
-        for( const wxString& symbolName : aSymbolNames )
+        else
         {
-            LIB_SYMBOL* symbol = nullptr;
-
             try
             {
-                symbol = m_parent->GetLibManager().GetAlias( symbolName, m_libId );
-
-                if( symbol )
+                if( LIB_SYMBOL* symbol = m_parent->GetLibManager().GetAlias( symbolName, libName ) )
                     m_symbolsList.push_back( symbol );
             }
             catch( const IO_ERROR& ioe )
             {
                 // Log the error and continue
-                wxLogWarning( wxString::Format( _( "Error loading symbol %s: %s" ), symbolName, ioe.What() ) );
+                wxLogWarning( wxString::Format( _( "Error loading symbol '%s': %s" ), symbolName, ioe.What() ) );
             }
         }
     }
-    catch( const IO_ERROR& ioe )
-    {
-        wxString msg = wxString::Format( _( "Error accessing library %s.\n\n%s" ), m_libId, ioe.What() );
-        DisplayErrorMessage( this, msg );
-        return;
-    }
 
     if( m_symbolsList.empty() )
     {
@@ -484,10 +482,15 @@ bool DIALOG_LIB_FIELDS::TransferDataFromWindow()
     if( !wxDialog::TransferDataFromWindow() )
         return false;
 
+    bool updateCanvas = false;
+
     m_dataModel->ApplyData(
-            [&]( LIB_SYMBOL* )
+            [&]( LIB_SYMBOL* symb )
             {
-                m_parent->OnModify();
+                m_parent->GetLibManager().UpdateSymbol( symb, symb->GetLibNickname() );
+
+                if( m_parent->GetCurSymbol() == symb )
+                    updateCanvas = true;
             },
             [&]()
             {
@@ -551,6 +554,15 @@ bool DIALOG_LIB_FIELDS::TransferDataFromWindow()
     wxLogTrace( traceLibFieldTable, "About to rebuild grid rows to include new symbols" );
     RegroupSymbols();
     wxLogTrace( traceLibFieldTable, "Grid rebuild completed" );
+
+    m_parent->RefreshLibraryTree();
+
+    if( updateCanvas )
+    {
+        m_parent->OnModify();
+        m_parent->HardRedraw();
+    }
+
     return true;
 }
 
@@ -907,7 +919,6 @@ void DIALOG_LIB_FIELDS::UpdateFieldList()
     AddField( wxS( "${EXCLUDE_FROM_BOARD}" ), _( "Exclude From Board" ),      true,  false,  false,  true );
 
     AddField( wxS( "Power" ),      _( "Power Symbol" ),       true, false, false, true );
-    AddField( wxS( "LocalPower" ), _( "Local Power Symbol" ), true, false, false, true );
 
     // User fields next
     std::set<wxString> userFieldNames;
@@ -1067,6 +1078,7 @@ void DIALOG_LIB_FIELDS::SetupColumnProperties( int aCol )
     {
         // Create symbol netlist for footprint picker
         wxString symbolNetlist;
+
         if( !m_symbolsList.empty() )
         {
             // Use the first symbol's netlist (all symbols in lib should have similar pin structure)

eeschema/dialogs/dialog_lib_symbol_properties.cpp

@@ -41,6 +41,7 @@
 #include <project_sch.h>
 #include <refdes_utils.h>
 #include <dialog_sim_model.h>
+#include <vector>
 
 #include <panel_embedded_files.h>
 #include <settings/settings_manager.h>
@@ -69,7 +70,19 @@ DIALOG_LIB_SYMBOL_PROPERTIES::DIALOG_LIB_SYMBOL_PROPERTIES( SYMBOL_EDIT_FRAME* a
     m_delayedFocusPage( -1 ),
     m_fpFilterTricks( std::make_unique<LISTBOX_TRICKS>( *this, *m_FootprintFilterListBox ) )
 {
-    m_embeddedFiles = new PANEL_EMBEDDED_FILES( m_NoteBook, m_libEntry );
+    std::vector<const EMBEDDED_FILES*> inheritedEmbeddedFiles;
+
+    if( std::shared_ptr<LIB_SYMBOL> parent = m_libEntry->GetParent().lock() )
+    {
+        while( parent )
+        {
+            inheritedEmbeddedFiles.push_back( parent->GetEmbeddedFiles() );
+            parent = parent->GetParent().lock();
+        }
+    }
+
+    m_embeddedFiles = new PANEL_EMBEDDED_FILES( m_NoteBook, m_libEntry, 0,
+                                                std::move( inheritedEmbeddedFiles ) );
     m_NoteBook->AddPage( m_embeddedFiles, _( "Embedded Files" ) );
 
     // Give a bit more room for combobox editors
@@ -197,7 +210,7 @@ bool DIALOG_LIB_SYMBOL_PROPERTIES::TransferDataToWindow()
     // and mark any matching names as inherited rather than duplicating them.
     if( m_libEntry->IsAlias() )
     {
-        if( LIB_SYMBOL_SPTR parent = m_libEntry->GetParent().lock() )
+        if( std::shared_ptr<LIB_SYMBOL> parent = m_libEntry->GetParent().lock() )
         {
             std::vector<SCH_FIELD*> parentFields;
             parent->GetFields( parentFields );
@@ -330,7 +343,7 @@ bool DIALOG_LIB_SYMBOL_PROPERTIES::TransferDataToWindow()
 
         m_inheritanceSelectCombo->Append( symbolNames );
 
-        if( LIB_SYMBOL_SPTR rootSymbol = m_libEntry->GetParent().lock() )
+        if( std::shared_ptr<LIB_SYMBOL> rootSymbol = m_libEntry->GetParent().lock() )
         {
             wxString parentName = UnescapeString( rootSymbol->GetName() );
             int selection = m_inheritanceSelectCombo->FindString( parentName );
@@ -436,7 +449,7 @@ bool DIALOG_LIB_SYMBOL_PROPERTIES::TransferDataFromWindow()
     if( !wxDialog::TransferDataFromWindow() )
         return false;
 
-    if( !m_grid->CommitPendingChanges() )
+    if( !m_grid->CommitPendingChanges() || !m_embeddedFiles->TransferDataFromWindow() )
         return false;
 
     wxString   newName = EscapeString( m_SymbolNameCtrl->GetValue(), CTX_LIBID );

eeschema/dialogs/dialog_line_properties.cpp

@@ -129,7 +129,10 @@ bool DIALOG_LINE_PROPERTIES::TransferDataFromWindow()
 
     for( SCH_LINE* line : m_lines )
     {
-        commit.Modify( line, m_frame->GetScreen() );
+        // Commit the change only if the line is not new. If new this is useless
+        // and can create dangling pointers if the line creation is aborted
+        if( !line->HasFlag( IS_NEW ) )
+            commit.Modify( line, m_frame->GetScreen() );
 
         if( !m_width.IsIndeterminate() )
             line->SetLineWidth( std::max( 0, m_width.GetIntValue() ) );

eeschema/dialogs/dialog_sch_import_settings.cpp

@@ -59,8 +59,7 @@ void DIALOG_SCH_IMPORT_SETTINGS::OnBrowseClicked( wxCommandEvent& event )
     fn.SetExt( FILEEXT::ProjectFileExtension );
 
     wxFileDialog dlg( this, _( "Import Settings From" ), fn.GetPath(), fn.GetFullName(),
-                      FILEEXT::ProjectFileWildcard(),
-                      wxFD_OPEN | wxFD_FILE_MUST_EXIST | wxFD_CHANGE_DIR );
+                      FILEEXT::ProjectFileWildcard(), wxFD_OPEN | wxFD_FILE_MUST_EXIST );
 
     if( dlg.ShowModal() == wxID_OK )
         m_filePathCtrl->SetValue( dlg.GetPath() );

eeschema/dialogs/dialog_schematic_find.cpp

@@ -85,6 +85,28 @@ DIALOG_SCH_FIND::DIALOG_SCH_FIND( SCH_EDIT_FRAME* aParent, SCH_SEARCH_DATA* aDat
     GetSizer()->Fit( this ); // Needed on Ubuntu/Unity to display the dialog
 
     Connect( wxEVT_CHAR, wxKeyEventHandler( DIALOG_SCH_FIND::OnChar ), nullptr, this );
+
+    // Set up tab order for proper keyboard navigation.
+    // This is needed because wxComboBox on GTK has issues with Tab key navigation.
+    m_tabOrder = {
+        m_comboFind,
+        m_comboReplace,
+        m_radioForward,
+        m_radioBackward,
+        m_checkMatchCase,
+        m_checkWholeWord,
+        m_checkRegexMatch,
+        m_checkAllPins,
+        m_checkAllFields,
+        m_checkCurrentSheetOnly,
+        m_checkSelectedOnly,
+        m_checkReplaceReferences,
+        m_checkConnections,
+        m_buttonFind,
+        m_buttonReplace,
+        m_buttonReplaceAll,
+        m_buttonCancel
+    };
 }
 
 

eeschema/dialogs/dialog_sim_model.cpp

@@ -89,8 +89,21 @@ DIALOG_SIM_MODEL<T>::DIALOG_SIM_MODEL( wxWindow* aParent, EDA_BASE_FRAME* aFrame
     }
 
     if( EMBEDDED_FILES* symbolEmbeddedFiles = aSymbol.GetEmbeddedFiles() )
+    {
         m_filesStack.push_back( symbolEmbeddedFiles );
 
+        if constexpr (std::is_same_v<T, SCH_SYMBOL>)
+        {
+            SCH_SYMBOL* symbol = static_cast<SCH_SYMBOL*>( &aSymbol );
+            symbol->GetLibSymbolRef()->AppendParentEmbeddedFiles( m_filesStack );
+        }
+        else if constexpr (std::is_same_v<T, LIB_SYMBOL>)
+        {
+            LIB_SYMBOL* symbol = static_cast<LIB_SYMBOL*>( &aSymbol );
+            symbol->AppendParentEmbeddedFiles( m_filesStack );
+        }
+    }
+
     m_libraryModelsMgr.SetFilesStack( m_filesStack );
     m_builtinModelsMgr.SetFilesStack( m_filesStack );
 
@@ -387,7 +400,7 @@ bool DIALOG_SIM_MODEL<T>::TransferDataFromWindow()
     SIM_MODEL::SetFieldValue( m_fields, SIM_LIBRARY::LIBRARY_FIELD, path, false );
     SIM_MODEL::SetFieldValue( m_fields, SIM_LIBRARY::NAME_FIELD, name, false );
 
-    if( isIbisLoaded() )
+    if( isIbisLoaded() && !m_libraryModelsMgr.GetModels().empty() )
     {
         int      idx = 0;
         wxString sel = m_modelListBox->GetStringSelection();
@@ -839,7 +852,25 @@ bool DIALOG_SIM_MODEL<T>::loadLibrary( const wxString& aLibraryPath, REPORTER& a
     m_libraryModelsMgr.SetLibrary( aLibraryPath, aReporter );
 
     if( aReporter.HasMessageOfSeverity( RPT_SEVERITY_UNDEFINED | RPT_SEVERITY_ERROR ) )
+    {
+        m_libraryModelsMgr.Clear();
+
+        if( m_modelListBox->GetSelection() != wxNOT_FOUND )
+            m_modelListBox->SetSelection( wxNOT_FOUND );
+
+        if( m_modelListBox->GetCount() )
+            m_modelListBox->Clear();
+
+        wxArrayString emptyArray;
+        m_pinModelCombobox->Set( emptyArray );
+        m_pinCombobox->Set( emptyArray );
+        m_pinModelCombobox->SetSelection( -1 );
+        m_pinCombobox->SetSelection( -1 );
+        m_waveformChoice->Clear();
+        m_prevLibrary.Clear();
+
         return false;
+    }
 
     std::string modelName = SIM_MODEL::GetFieldValue( &m_fields, SIM_LIBRARY::NAME_FIELD );
 
@@ -1124,7 +1155,12 @@ SIM_MODEL& DIALOG_SIM_MODEL<T>::curModel() const
         wxString sel = m_modelListBox->GetStringSelection();
 
         if( m_modelListBoxEntryToLibraryIdx.contains( sel ) )
-            return m_libraryModelsMgr.GetModels().at( m_modelListBoxEntryToLibraryIdx.at( sel ) ).get();
+        {
+            int idx = m_modelListBoxEntryToLibraryIdx.at( sel );
+
+            if( idx >= 0 && idx < (int) m_libraryModelsMgr.GetModels().size() )
+                return m_libraryModelsMgr.GetModels().at( idx ).get();
+        }
     }
     else
     {