electron-rare/kicad-source-mirror
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid printing superfluous bus messages

Browse Source 
If we don't have a bus selected, we don't need the bus-relevant data and
the net might be separate

Fixes https://gitlab.com/kicad/code/kicad/-/issues/18350
This commit is contained in:
Seth Hillbrand
2025-10-14 15:09:35 -07:00
parent b151655b07
commit 430c62d3ca
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
eeschema/sch_connection.cpp
+13 -10
View File
@@ -450,19 +450,22 @@ void SCH_CONNECTION::AppendInfoToMsgPanel( std::vector<MSG_PANEL_ITEM>& aList )
aList.emplace_back( _( "Connection Name" ), UnescapeString( Name() ) );
if( std::shared_ptr<BUS_ALIAS> alias = m_graph->GetBusAlias( m_name ) )
if( IsBus() )
{
msg.Printf( _( "Bus Alias %s Members" ), m_name );
aList.emplace_back( msg, boost::algorithm::join( alias->Members(), " " ) );
}
else if( NET_SETTINGS::ParseBusGroup( m_name, &group_name, &group_members ) )
{
for( const wxString& group_member : group_members )
if( std::shared_ptr<BUS_ALIAS> alias = m_graph->GetBusAlias( m_name ) )
{
if( std::shared_ptr<BUS_ALIAS> group_alias = m_graph->GetBusAlias( group_member ) )
msg.Printf( _( "Bus Alias %s Members" ), m_name );
aList.emplace_back( msg, boost::algorithm::join( alias->Members(), " " ) );
}
else if( NET_SETTINGS::ParseBusGroup( m_name, &group_name, &group_members ) )
{
for( const wxString& group_member : group_members )
{
msg.Printf( _( "Bus Alias %s Members" ), group_alias->GetName() );
aList.emplace_back( msg, boost::algorithm::join( group_alias->Members(), " " ) );
if( std::shared_ptr<BUS_ALIAS> group_alias = m_graph->GetBusAlias( group_member ) )
{
msg.Printf( _( "Bus Alias %s Members" ), group_alias->GetName() );
aList.emplace_back( msg, boost::algorithm::join( group_alias->Members(), " " ) );
}
}
}
}