Compare commits

...

4004 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7) 70fa678586 Moodle release 3.2.2 2017-03-11 22:16:10 +01:00
AMOS bot 0c6de97371 Automatically generated installer lang files 2017-03-12 00:04:17 +08:00
AMOS bot 63981e5a82 Automatically generated installer lang files 2017-03-12 00:04:17 +08:00
Eloy Lafuente (stronk7) 6a0dfc60d6 weekly release 3.2.1+ 2017-03-10 20:59:59 +01:00
Eloy Lafuente (stronk7) 38c4435a37 Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2017-03-10 20:59:55 +01:00
Damyon Wiese 3cc4e2f725 MDL-57596 forms: CLEANHTML in persistent forms
Add special handling for text fields with the CLEANHTML type. This should
be used when students and teachers can edit the same field (you can't trust those students).

Applies cleaning on submitted data, and on data stored in the DB before it is put back in an editing form.
2017-03-10 18:07:55 +00:00
Marina Glancy ca3cbbc233 MDL-58010 user: allow to update only whitelisted user preferences 2017-03-10 18:07:54 +00:00
Andrew Nicols 7d196ef3b3 Merge branch 'wip-mdl-57940-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-03-10 18:07:53 +00:00
Eloy Lafuente (stronk7) 069b9d5820 Merge branch 'MDL-58123-32' of git://github.com/junpataleta/moodle into MOODLE_32_STABLE 2017-03-10 18:07:53 +00:00
Dan Poltawski 454a3d34d5 Merge branch 'MDL-58035_32' of git://github.com/timhunt/moodle into MOODLE_32_STABLE 2017-03-10 18:07:52 +00:00
Ankit Agarwal db3a985faf MDL-56526 userlib: Do not allow not loggedin users if forceloginforprofile is set 2017-03-10 18:07:52 +00:00
Ankit Agarwal c535520966 MDL-56526 globalsearch: Fix bug in phpdocs 2017-03-10 18:07:51 +00:00
David Mudrák e35ad40de1 MDL-57597 competency: Fix serving of prior learning evidence files
For security reasons, all files submitted by students must be disposed
as attachments, not inline contents.
2017-03-10 18:07:51 +00:00
AMOS bot 436acc27fe Automatically generated installer lang files 2017-03-10 00:04:27 +08:00
Dan Poltawski 73fd6f2928 Merge branch 'MDL-57990-32' of git://github.com/crazyserver/moodle into MOODLE_32_STABLE 2017-03-07 13:59:15 -03:00
AMOS bot 84e17f59c5 Automatically generated installer lang files 2017-03-08 00:05:55 +08:00
Eloy Lafuente (stronk7) 63464df041 Merge branch 'MDL-58064-32-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_32_STABLE 2017-03-07 16:37:36 +01:00
Dan Poltawski 17c82085fc Merge branch 'wip-mdl-58056-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-03-07 11:08:23 -03:00
Dan Poltawski 5e3ce67f37 Merge branch 'MDL-57361-32' of git://github.com/jleyva/moodle into MOODLE_32_STABLE 2017-03-07 11:07:46 -03:00
Tim Hunt ec02a34e1f MDL-58035 tool_templatelibrary: fix unit test using removed base theme 2017-03-07 13:35:34 +00:00
Tim Hunt 1e1e1b8229 MDL-58035 lib: log when the expected theme cannot be initialised 2017-03-07 13:35:32 +00:00
David Monllao f7af2c5fc7 Merge branch 'MDL-58106_32' of git://github.com/timhunt/moodle into MOODLE_32_STABLE 2017-03-07 13:38:18 +01:00
David Monllao 92194c1c8d Merge branch 'wip-mdl-58091-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-03-07 13:16:03 +01:00
David Mudrák 7bbe8a1c76 MDL-58064 lang: Clarify the PHP 7.x limitations
These are related to SQL*Server support only and affect all PHP 7
versions, not just 7.0.x. Credit goes to Eloy Lafuente for spotting
this.
2017-03-07 13:00:46 +01:00
Dan Poltawski 22ee65c275 MDL-58040 blocks: add upgrade.txt note 2017-03-07 08:34:54 -03:00
Dan Poltawski 9354f9de64 Merge branch 'MDL-58040_32' of git://github.com/timhunt/moodle into MOODLE_32_STABLE 2017-03-07 08:34:48 -03:00
David Monllao 04d2305788 Merge branch 'wip-MDL-57485-32' of git://github.com/abgreeve/moodle into MOODLE_32_STABLE 2017-03-07 12:16:48 +01:00
David Monllao e21e294072 Merge branch 'MDL-58057-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2017-03-07 12:09:35 +01:00
Dan Poltawski 19b7ac05ad Merge branch 'MDL-55859-32' of git://github.com/ankitagarwal/moodle into MOODLE_32_STABLE 2017-03-07 07:02:31 -03:00
Dan Poltawski 4294bbd50f Merge branch 'MDL-58052_behat_get_session_user_MOODLE_32_STABLE' of https://github.com/gthomas2/moodle into MOODLE_32_STABLE 2017-03-07 06:54:34 -03:00
Adrian Greeve b1ffb73177 MDL-57485 themes: Set images to default display type.
Imported images in atto would no longer hold a URL
tag around it. display: block was the culprit.
2017-03-07 17:33:23 +08:00
Ankit Agarwal cde1ac3eea MDL-57362 assign: Fix permission checks 2017-03-07 13:04:01 +05:30
Jake Dallimore 059759aab9 MDL-58057 core_files: properly trim curl whitelist config when fetching 2017-03-07 09:49:50 +08:00
Dan Poltawski 188d41ccc9 Merge branch 'MDL-57362-32' of git://github.com/ankitagarwal/moodle into MOODLE_32_STABLE 2017-03-06 10:18:30 -03:00
gthomas2 0b5f9f6e60 MDL-58052 behat: user session function - use to edit current profile 2017-03-03 12:29:47 +00:00
Pau Ferrer Ocaña fa60a11522 MDL-57990 course: Add sortorder as public field 2017-03-03 11:52:10 +01:00
Eloy Lafuente (stronk7) 29cdf58116 weekly release 3.2.1+ 2017-03-03 10:33:52 +01:00
Eloy Lafuente (stronk7) 3db24b8015 Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2017-03-03 10:33:47 +01:00
Tim Hunt b21b210f41 MDL-58106 random Q restore: avoid MySQL performance issues 2017-03-02 19:40:53 +00:00
Ankit Agarwal 79482e3fe8 MDL-55859 assign_editpdf: cleanup htmlfile in case of errors 2017-03-02 21:16:37 +05:30
Cameron Ball 3935371599 MDL-57321 theme_boost: Remove extra quotation mark 2017-03-02 16:05:55 +08:00
Jun Pataleta 14026572ae MDL-58123 mod_lesson: Fix lesson table name in refresh_events DB query 2017-03-02 10:55:42 +08:00
Eloy Lafuente (stronk7) ee66d63054 Merge branch 'MDL-57321-32' of git://github.com/cameron1729/moodle into MOODLE_32_STABLE 2017-03-02 00:01:47 +01:00
Juan Leyva af2d6085cd MDL-57361 auth_email: Force policy agreed on sign-up 2017-03-01 18:20:59 +01:00
Cameron Ball e615d70923 MDL-57321 theme_boost: Remove duplicate aria-labelledby attribute 2017-03-01 11:37:29 +08:00
Cameron Ball ae8388d51c MDL-57321 theme_boost: Fix improperly nested ul elements in footer 2017-03-01 11:37:28 +08:00
Cameron Ball 962e3eb662 MDL-57321 theme_boost: Use div instead of span for dropdown items 2017-03-01 11:37:28 +08:00
Cameron Ball 4c586b025e MDL-57321 theme_boost: Consistently apply attributes on elements 2017-03-01 11:37:28 +08:00
Andrew Nicols 8612c8aa3e Merge branch 'MDL-58072_32_tabtree_mustache' of https://github.com/mchurchward/moodle into MOODLE_32_STABLE 2017-03-01 11:10:18 +08:00
Eloy Lafuente (stronk7) a7db91030b Merge branch 'wip-MDL-48228-32' of git://github.com/abgreeve/moodle into MOODLE_32_STABLE 2017-03-01 02:57:16 +01:00
Adrian Greeve d807d3c603 MDL-48228 database: Unit test addition and update. 2017-03-01 09:05:40 +08:00
Adrian Greeve 8f61b909e8 MDL-48228 database: Make utf8mb4 the default character set for mysql.
Thanks to Jetha Chan for providing the initial patch that this is
based on.
2017-03-01 09:05:40 +08:00
Eloy Lafuente (stronk7) e44ce23c9f Merge branch 'MDL-58071-32' of git://github.com/jleyva/moodle into MOODLE_32_STABLE 2017-02-28 23:00:42 +01:00
Eloy Lafuente (stronk7) 6c87b08240 Merge branch 'MDL-55762-32' of git://github.com/ankitagarwal/moodle into MOODLE_32_STABLE 2017-02-28 20:40:51 +01:00
David Monllao 9afdc8fc12 MDL-51833 docs: Move upgrade note under 3.2.2 2017-02-28 11:32:39 +01:00
David Monllao e30a500fb9 Merge branch 'wip-MDL-51833-32' of git://github.com/abgreeve/moodle into MOODLE_32_STABLE 2017-02-28 11:31:09 +01:00
Ankit Agarwal 121d3e0d29 MDL-57362 assignlib: Fix minor bug in phpdocs 2017-02-28 10:34:41 +05:30
Ankit Agarwal 5b7356cdde MDL-57362 assignlib: Check for sep groups edge case 2017-02-28 10:34:41 +05:30
Andrew Nicols 169d972bf6 Merge branch 'MDL-58038-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2017-02-28 12:25:43 +08:00
Rajesh Taneja 4fef0dadf0 MDL-58091 behat: Added missing @_file_upload tag 2017-02-28 11:22:38 +08:00
Andrew Nicols 96a0d1bc7a Merge branch 'MDL-35980-32' of git://github.com/snake/moodle into MOODLE_32_STABLE 2017-02-28 10:34:00 +08:00
Jake Dallimore 01c2ca76c0 MDL-35980 behat: fix link text in submission_comments feature 2017-02-28 10:24:53 +08:00
Andrew Nicols 46c68c1b42 MDL-55547 tool_monitor: Coding style fixes 2017-02-28 09:42:44 +08:00
Andrew Nicols e65f6a7e40 Merge branch 'wip-MDL-55547-32' of git://github.com/marinaglancy/moodle into MOODLE_32_STABLE 2017-02-28 09:42:39 +08:00
Eloy Lafuente (stronk7) 800da1b13d Merge branch 'MDL-58041_32' of https://github.com/sam-moodle/moodle into MOODLE_32_STABLE 2017-02-28 02:35:20 +01:00
Eloy Lafuente (stronk7) a53008f1f0 Merge branch 'MDL-57524_M32' of https://github.com/nadavkav/moodle into MOODLE_32_STABLE 2017-02-28 01:40:54 +01:00
Eloy Lafuente (stronk7) f1a117b86b Merge branch 'MDL-58030_32' of git://github.com/aolley/moodle into MOODLE_32_STABLE 2017-02-27 22:47:22 +01:00
Helen Foster bcbd4140a1 MDL-58064 lang: Merge English strings from the en_fix language pack 2017-02-27 10:20:17 +01:00
Rajesh Taneja c99c5a436e MDL-57940 behat: Allow behat parallel run to start with delay
Behat parallel run if executed together
then selenium might fail to launch browser
and timeout. It would be nice to have a
custom delay between the start of each process
2017-02-27 16:16:06 +08:00
Andrew Nicols b7d36bdbaf Merge branch 'MDL-50719-fast-locks-MOODLE_32_STABLE' of https://github.com/brendanheywood/moodle into MOODLE_32_STABLE 2017-02-27 13:47:02 +08:00
Andrew Nicols c21f12e786 Merge branch 'MDL-35980-32' of git://github.com/snake/moodle into MOODLE_32_STABLE 2017-02-27 12:20:02 +08:00
Ankit Agarwal 2dd1bb44c2 MDL-55762 assignpdf: Handle errored pages better 2017-02-27 09:27:23 +05:30
Ankit Agarwal 63de9b5cdb MDL-55762 assignpdf: Fix bug in phpdocs 2017-02-27 09:27:23 +05:30
Andrew Nicols 24a00cadec Merge branch 'MDL-58032-32' of git://github.com/ankitagarwal/moodle into MOODLE_32_STABLE 2017-02-27 11:51:13 +08:00
Adrian Greeve 3f709d3272 MDL-51833 tool_monitor: Improve access check for monitor. 2017-02-27 09:00:54 +08:00
Nadav Kavalerchik def32a798d MDL-57524 theme_boost: Fix ignored input size on admin pages 2017-02-24 21:51:43 +02:00
Juan Leyva b63524492f MDL-58071 user: Return usernotfullysetup exception in WS
If there is an empty required custom user profile field, Web Services
should return the usernotfullysetup exception instead ignoring it.
The mobile app already handles this exception for core fields
redirecting the user to web in order to fill the missing field.
2017-02-24 20:17:19 +01:00
Mike Churchward 46f0136a5a MDL-58072 theme_boost: Added quotes to title; removed extra spaces. 2017-02-24 11:10:56 -05:00
Brendan Heywood 83dbc72f38 MDL-50719 cron: Fixed parallel task lock contention issues 2017-02-24 13:19:12 +11:00
Jake Dallimore c6911cefb4 MDL-56364 javascript: Prevent bad prototype chains in core dialogue
The DIALOGUE object was using Y.clone to copy the input config, messing
up the prototype chains for any objects in the config param. Really,
this doesn't need to clone the config, so I've refactored to avoid doing
so. Also moved some of the other attribute init and setup calls to the
appropriate places (initializer and modifyAttrs).
2017-02-24 08:27:44 +08:00
Jake Dallimore dfbdf40af9 MDL-35980 comment: add comment info to delete button for screen readers
For each delete button in the comments widget, make the spoken text a
string containing the name of the poster and the datetime.
2017-02-24 08:16:38 +08:00
Jake Dallimore 3e0fb6862e MDL-58038 email: make sure all allowedemaildomain entries are respected
Fixes a bug with exploding the config var, in which trailing carriage
returns were causing string matches to fail.
2017-02-24 08:07:59 +08:00
AMOS bot 0e8eba7e1f Automatically generated installer lang files 2017-02-24 00:07:41 +08:00
David Monllao d0209e611f weekly release 3.2.1+ 2017-02-23 08:07:49 +01:00
David Monllao ec9ed6d067 Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2017-02-23 08:07:48 +01:00
Rajesh Taneja 3e340aba45 MDL-58056 behat: Ensure form element exists
Before getting form field, ensure node is
visible. Else it may fail to get form
field
2017-02-23 14:45:43 +08:00
Rajesh Taneja de80be59bb MDL-58056 behat: Catch webdriver exception if element removed
While checking for element visibility, ensure
that element is there in dom
2017-02-23 14:45:43 +08:00
AMOS bot 310172571b Automatically generated installer lang files 2017-02-23 00:05:42 +08:00
David Monllao a550b70a94 MDL-58014 messaging: Note about behavioural change in message_count_unread_messages 2017-02-22 09:47:12 +01:00
Ankit Agarwal 3cd6842501 MDL-58032 core_user: Fix case when acting user is a visitor 2017-02-22 09:55:58 +05:30
Rajesh Taneja f17c1aadb3 MDL-57765 behat: Allow exact selectors to be used
In Blocks with boost theme selector to
find block with name is partial match
it might fail in some cases. It would
be nice to use exact match to avoid
unexpected failures
2017-02-21 23:57:37 +01:00
Sam Chaffee 043dffdd34 MDL-58041 tool_monitor: Fix event monitor subscription behat failures 2017-02-21 11:24:17 -07:00
Tim Hunt 6fef2ab3db MDL-58040 blocklib: never use global in block manager class
This switches everything to ->page, including coverting static method to real one.
2017-02-21 15:19:55 +00:00
Adam Olley 9ffcf8a3e9 MDL-58030 gradingform_guide: Init $commentchooser before use
The initialisation of $commentschooser was moved into an IF condition,
whilst still using it outside of that IF conditions scope. As such, if
there are no comments to choose from, the variable is never init'd but
it still goes to use it, emitting a PHP notice.
2017-02-21 14:36:49 +10:30
Eloy Lafuente (stronk7) 56b8f8c8be Merge branch 'wip-MDL-57113-MOODLE_32_STABLE' of https://github.com/kwiliarty/moodle into MOODLE_32_STABLE 2017-02-21 01:00:53 +01:00
Eloy Lafuente (stronk7) fede68a0ac Merge branch 'wip-mdl-56616-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-02-21 00:58:13 +01:00
Eloy Lafuente (stronk7) 6588079c5d Merge branch 'MDL-55867_m32v1' of https://github.com/sbourget/moodle into MOODLE_32_STABLE 2017-02-21 00:53:21 +01:00
Eloy Lafuente (stronk7) f7e4c3627c Merge branch 'MDL-56206_32-text-enrolled-users-page-aligned' of https://github.com/lucaboesch/moodle into MOODLE_32_STABLE 2017-02-20 19:26:35 +01:00
David Monllao 6c3f7e0ae6 Merge branch 'MDL-57576-32-updatefeedbackfile' of git://github.com/roperto/moodle into MOODLE_32_STABLE 2017-02-20 12:27:33 +01:00
Dan Poltawski 89d948d86b Merge branch 'MDL-57962-32' of git://github.com/dpalou/moodle into MOODLE_32_STABLE 2017-02-20 11:19:17 +00:00
David Monllao e1dcad3d13 Merge branch 'MDL-57795-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2017-02-20 10:28:23 +01:00
David Monllao 07d000c51e Merge branch 'MDL-57801-32' of https://github.com/lucisgit/moodle into MOODLE_32_STABLE 2017-02-20 10:10:15 +01:00
David Monllao 636e7a13b6 Merge branch 'MDL-58014_32' of git://github.com/markn86/moodle into MOODLE_32_STABLE 2017-02-20 09:34:43 +01:00
David Monllao a57bdfa055 Merge branch 'MDL-56679-32' of git://github.com/junpataleta/moodle into MOODLE_32_STABLE 2017-02-20 09:20:26 +01:00
David Monllao 80a57cf924 Merge branch 'MDL-57274-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2017-02-20 09:07:25 +01:00
David Monllao 059d6ffd9f Merge branch 'MDL-50729-32' of git://github.com/ankitagarwal/moodle into MOODLE_32_STABLE 2017-02-20 08:27:07 +01:00
Mark Nelson fd13953a8a MDL-58014 core_message: fixed unread message count 2017-02-20 13:59:33 +08:00
Marina Glancy 488e115027 MDL-55547 tool_monitor: fix exceptions when course was deleted
Delete subscriptions when course is deleted
2017-02-20 12:16:27 +08:00
Jake Dallimore 72e3ff3c15 MDL-57274 upgrade: fix curl security notices during upgrade/install
Handles the case where $CFG->curlsecurityxxx vars don't yet exist
during install or upgrade by treating not set the same as empty.
2017-02-20 08:56:47 +08:00
Jake Dallimore bd4f6ce186 MDL-57795 mod_assign: fix for filters killing review pane when grading
Fixes a bug in which the review pane was destroyed if the user selected
a combination of filters resulting in no matched users. Now, the pane
is just hidden in such cases, and displayed again if subsequent filter
changes return one or more users.
2017-02-20 08:53:00 +08:00
Dan Poltawski 5416d932d7 Merge branch 'MDL-57967_32' of git://github.com/markn86/moodle into MOODLE_32_STABLE 2017-02-19 19:44:51 +00:00
Matteo Scaramuccia 27e719e709 MDL-57379 Files: Improved file argument evaluation.
get_file_argument() is responsible to extract the relative path
of the file to be served by a specific Moodle component
like a theme or a module.
Some modules like scorm and imscp require slasharguments support
and they force it when creating the URLs to serve their files.
It should honor the slasharguments setting but this could break
those instances where existing hard-coded links still make usage of
the "old" format, the one when slasharguments is set to No i.e. '?file='.

Its logic has been improved by looking at when the URL is related to
serving a plug-in file in a "forced" slasharguments way of serving it
i.e. using '/pluginfile.php/' and not '/pluginfile.php?'.
2017-02-19 18:44:48 +00:00
Tony Butler b577d34861 MDL-57801 core_filestorage: Delete temp file if disk space runs out 2017-02-16 12:46:46 +00:00
Tony Butler dcd27d9cee MDL-57801 core_filestorage: Verify hash of temp file before committing
This addresses an edge scenario on NFS filesystems with no space
remaining, where subsequent uploads fail silently while zero byte files
are saved to the pool (and for some reason the filesize check passes).
2017-02-16 12:46:46 +00:00
Gergely Kún 863dcb14a8 MDL-56679 core: Initialise $SESSION if necessary 2017-02-16 16:19:42 +08:00
Dan Poltawski 1a754e8446 weekly release 3.2.1+ 2017-02-16 08:14:54 +00:00
Dan Poltawski 95e9f4cc02 Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2017-02-16 08:14:48 +00:00
Mark Nelson bac13609ca MDL-57967 core_message: do not process conversations from deleted users 2017-02-16 13:03:02 +08:00
Rajesh Taneja df90a44f3f MDL-57030 behat: Save run status after execution 2017-02-15 10:38:43 +01:00
Eloy Lafuente (stronk7) 23fd4f3afc Merge branch 'MDL-53991_m32v4' of https://github.com/sbourget/moodle into MOODLE_32_STABLE 2017-02-14 18:16:24 +01:00
Eloy Lafuente (stronk7) 9b39a92170 Merge branch 'wip-mdl-57030-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-02-14 16:53:59 +01:00
David Monllao 69c5e60f8c MDL-56122 editpdf: Fix ghostscript checking 2017-02-14 13:45:39 +01:00
Brendan Heywood cc36a37ea4 MDL-57810 lib: Disable nginx buffers when not required 2017-02-14 11:36:01 +00:00
Dani Palou 2678ee4e81 MDL-57962 forum: Allow creating new discussions with groupid -1 2017-02-14 10:44:00 +01:00
David Monllao 5a9f3039a7 Merge branch 'MDL-56122-32' of https://github.com/lucisgit/moodle into MOODLE_32_STABLE 2017-02-14 09:53:39 +01:00
Ankit Agarwal 667784420f MDL-50729 gradelib: Regrade event should be assigned to system 2017-02-14 11:40:54 +05:30
Ankit Agarwal f628e0ecf6 MDL-50729 events: Add user constants to events base class 2017-02-14 11:40:54 +05:30
Damyon Wiese 9ae3b89cc5 MDL-57766 assign: Put back the manual marker filter
I removed too much from gradingtable.php in the last patch.
2017-02-14 10:19:15 +08:00
Eloy Lafuente (stronk7) 098a875e4e Merge branch 'MDL-57868-32' of git://github.com/jleyva/moodle into MOODLE_32_STABLE 2017-02-13 23:42:46 +01:00
Eloy Lafuente (stronk7) 9d64f4f078 Merge branch 'MDL-57708-32' of git://github.com/merrill-oakland/moodle into MOODLE_32_STABLE 2017-02-13 23:33:00 +01:00
Tony Butler 5fac573391 MDL-56122 assignfeedback_editpdf: Add test assertions for pdf generation 2017-02-13 17:30:15 +00:00
Tony Butler def9c15904 MDL-56122 assignfeedback_editpdf: Regenerate PDF & page images if blank 2017-02-13 17:30:15 +00:00
Dan Poltawski d4e9fe521e Merge branch 'MDL-56841_32' of https://github.com/andrewhancox/moodle into MOODLE_32_STABLE 2017-02-13 16:39:39 +00:00
B Krishnan Iyer 343cdba46b MDL-57354 output: Render continue button as a primary button. 2017-02-13 15:50:43 +00:00
Davo Smith aca74d0d74 MDL-57752 session: fix check_security() session termination 2017-02-13 13:54:43 +00:00
Dan Poltawski ce01dbab40 Merge branch 'MDL-57768-webservice-config-error-MOODLE_32_STABLE' of https://github.com/ilya-catalyst/moodle into MOODLE_32_STABLE 2017-02-13 13:31:04 +00:00
David Monllao 21cf201536 Merge branch 'MDL-57766-32' of git://github.com/damyon/moodle into MOODLE_32_STABLE 2017-02-13 09:44:25 +01:00
David Monllao dfefe26665 Merge branch 'wip-MDL-50770-32' of git://github.com/marinaglancy/moodle into MOODLE_32_STABLE 2017-02-13 09:15:08 +01:00
Rajesh Taneja de70bc556c MDL-56616 theme_boost: Fix style for performance info 2017-02-13 14:39:23 +08:00
AMOS bot 7b06a12ef3 Automatically generated installer lang files 2017-02-11 00:11:46 +08:00
Ilya Tregubov a415eb505e MDL-57768 webservice: Delete manual setting of config in test 2017-02-10 11:48:44 +11:00
Damyon Wiese 54a20ea8fc MDL-57766 mod_assign: Marker allocation fixes
Marking allocation was only ever applied in the view for the grading table. It should
have been added to the list_participants function because that is used by webservices and
the new grading UI.
2017-02-09 17:15:10 +08:00
David Monllao a1740aad65 weekly release 3.2.1+ 2017-02-09 08:00:10 +01:00
David Monllao 3680b1efa0 Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2017-02-09 08:00:09 +01:00
Ryan Wyllie b90c2e2627 MDL-57370 message: add unread count to conversation tests 2017-02-09 13:46:31 +08:00
Ryan Wyllie 5c53893f97 MDL-57370 message: improve message union sql 2017-02-09 13:46:30 +08:00
Rajesh Taneja 3049c086a3 MDL-57030 behat: Added option to automatically rerun failures 2017-02-09 07:16:00 +08:00
Eric Merrill c644b03f02 MDL-57708 assign: Fix display of overridden submissions 2017-02-08 14:54:11 -05:00
David Monllao 7693409caa Merge branch 'wip-MDL-57316-32' of git://github.com/marinaglancy/moodle into MOODLE_32_STABLE 2017-02-08 13:11:40 +01:00
Dan Poltawski eac59c38f8 Merge branch 'MDL-57370-32-int-fix-1' of git://github.com/ryanwyllie/moodle into MOODLE_32_STABLE 2017-02-08 09:14:22 +00:00
Dan Poltawski cd6612b079 MDL-57370 messaging: fix mesed up versions
(Again, I didn't have a good day yesterday...)
2017-02-08 09:08:02 +00:00
Ryan Wyllie 7d88829470 MDL-57370 message: fix duplicate ids 2017-02-08 07:43:14 +00:00
Rajesh Taneja 9fde80dfa0 MDL-56954 behat: Fixed string to pass behat
colon is not concatenated to Search courses string
2017-02-08 12:19:26 +08:00
Damyon Wiese e787fa6ab4 MDL-57009 javascript: Fix "failed to prefetch"
The scanForPartials in amd/src/templates.js function is not handling
nested sections (the list of tokens is a tree not a flat list).
2017-02-08 11:17:39 +08:00
Marina Glancy 24cfd4c7d8 MDL-57316 media: create different instances for different pages 2017-02-08 10:17:18 +08:00
AMOS bot de33f85405 Automatically generated installer lang files 2017-02-08 00:09:21 +08:00
Damyon Wiese 57e38e1d12 MDL-57009 javascript: Reject on all errors
Not all error paths were resulting in a reject() call to fail a promise.
2017-02-07 12:37:10 +00:00
Damyon Wiese ddbf8c29ae MDL-57009 javascript: Always use when.apply
Or it does not really wait for the promises.
2017-02-07 12:37:02 +00:00
Dan Poltawski f265312fcf Merge branch 'MDL-57009-32' of git://github.com/damyon/moodle into MOODLE_32_STABLE 2017-02-07 12:36:27 +00:00
Dan Poltawski 7dc6674cc4 MDL-57370 upgrade: fix versions 2017-02-07 10:49:49 +00:00
Dan Poltawski c1b9c51914 Merge branch 'MDL-57370-32' of git://github.com/ryanwyllie/moodle into MOODLE_32_STABLE 2017-02-07 10:25:27 +00:00
Luca Bösch 14da7f58a4 MDL-56206 themes: Text on Enrolled users page well aligned
Helps to align the table row content.
2017-02-07 07:19:37 +01:00
Eloy Lafuente (stronk7) 18221902bc Merge branch 'MDL-56954-32' of git://github.com/lameze/moodle into MOODLE_32_STABLE 2017-02-07 06:35:08 +01:00
Ryan Wyllie 7d9ee66a2f MDL-57370 message: change indexes on message tables 2017-02-07 01:44:39 +00:00
John Okely de60425a16 MDL-57316 media: Setup media plugins in media_manager::instance() 2017-02-07 09:43:49 +08:00
John Okely 4eb3f8d9b7 MDL-57316 videojs: Add behat tests for lesson, url and resource 2017-02-07 09:43:48 +08:00
Ryan Wyllie 994e94bf76 MDL-57370 message: unit tests for get_conversations 2017-02-07 01:43:33 +00:00
Ryan Wyllie 2f9f8b5903 MDL-57370 message: remove joins from get_conversations
I have broken up the single query that was doing multiple joins on the
messaging and user tables. It no longer does any joins and will instead
query each data set individually.

This may cost more in terms of PHP processing but it will mean that
standard database tunings should be able to handle larger data sets.

For example this function was taking a long time to run on moodle.org
and was causing the MySQL join buffer to overflow.
2017-02-07 01:43:32 +00:00
Eloy Lafuente (stronk7) 3923610e6c Merge branch 'wip-mdl-57851-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-02-07 01:26:21 +01:00
Eloy Lafuente (stronk7) 0913eb3c2a Merge branch 'wip-mdl-57853-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-02-06 21:55:05 +01:00
AMOS bot f5b50e0472 Automatically generated installer lang files 2017-02-07 00:05:29 +08:00
Eloy Lafuente (stronk7) 09261027b6 Merge branch 'MDL-53349-32' of https://github.com/xow/moodle into MOODLE_32_STABLE 2017-02-06 16:09:46 +01:00
Dan Poltawski e0c4e6496f Merge branch 'MDL-57660-32' of git://github.com/junpataleta/moodle into MOODLE_32_STABLE 2017-02-06 13:47:29 +00:00
Dan Poltawski 672ce4c6cd Merge branch 'MDL-57587_32' of git://github.com/timhunt/moodle into MOODLE_32_STABLE 2017-02-06 11:04:00 +00:00
Juan Leyva 13a2a8344c MDL-57868 mod_feedback: Fix incorrect query parameters order
get_records_menu call get_records using the same params ordering, it is
causing a duplicated value error for the first column
2017-02-06 11:32:33 +01:00
David Monllao 8184f47d6c Merge branch 'MDL-57777-m32' of https://github.com/micaherne/moodle into MOODLE_32_STABLE 2017-02-06 09:41:52 +01:00
Rajesh Taneja 7a7320af90 MDL-57853 phpunit: Remove use of setExpectedException 2017-02-06 11:45:45 +08:00
Stephen Bourget 70fd9fbb39 MDL-55867 block_activity_results: Sort activities alphabetically. 2017-02-05 21:30:01 -05:00
Rajesh Taneja e16448d3f1 MDL-57851 behat: Add some more wait for scenario to pass
On slow machine with phnatomjs profile
this scenario keeps failing. Add some more
wait to ensure the page is stable and next
step can be executed
2017-02-03 12:54:45 +08:00
AMOS bot 2b4eb2cb71 Automatically generated installer lang files 2017-02-03 00:04:16 +08:00
Andrew Hancox ed798679bb MDL-56841 mod_folder: Display edit and download buttons inline 2017-02-02 15:17:00 +00:00
Simey Lameze 299dcca1b1 MDL-56954 theme_boost: apply bs4 styles to course management page 2017-02-02 15:52:51 +08:00
Andrew Nicols c16c53d137 weekly release 3.2.1+ 2017-02-02 11:32:16 +08:00
Andrew Nicols 52723e1e3f Merge branch 'MDL-57630-m32' of https://github.com/micaherne/moodle into MOODLE_32_STABLE 2017-02-02 09:19:08 +08:00
Rajesh Taneja 0bcbd5b205 MDL-54628 behat: Rerun command now include replace option passed 2017-02-02 08:21:31 +08:00
Nadav Kavalerchik ec319d13df MDL-53349 Autocomplete: Support multi lingual COMMA keycode (44) 2017-02-01 16:30:23 +08:00
Ankit Agarwal 0c4422af0b MDL-57300 lti: Make tool provider page more readable 2017-02-01 11:51:32 +05:30
Ankit Agarwal 40dcbac3d6 MDL-57027 accesslib: Improve perf of sql 2017-02-01 13:06:03 +08:00
Petr Skoda 62eb5ef8eb MDL-57027 fix get_users_by_capability()
Change-Id: I98dc88784dfa0293f88a19c3d36e7a46a3f52672
2017-02-01 13:06:02 +08:00
Eloy Lafuente (stronk7) 434e8abac8 Merge branch 'MDL-57592-32' of https://github.com/mwehr/moodle into MOODLE_32_STABLE 2017-02-01 13:06:01 +08:00
Dan Poltawski 28add18d9b Merge branch 'MDL-57588_32' of git://github.com/timhunt/moodle into MOODLE_32_STABLE 2017-02-01 13:06:01 +08:00
Dan Poltawski f9220d8138 Merge branch 'wip-mdl-54628-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-02-01 13:06:00 +08:00
Dan Poltawski 32237b8308 Merge branch 'MDL-57300-32' of git://github.com/ankitagarwal/moodle into MOODLE_32_STABLE 2017-02-01 13:06:00 +08:00
Dan Poltawski c2ae90c553 Merge branch 'MDL-57728_m32v1' of https://github.com/sbourget/moodle into MOODLE_32_STABLE 2017-02-01 13:05:59 +08:00
Michael Aherne 7035e0f5b5 MDL-57777 rss: Return 404 when context not found. 2017-01-31 09:31:31 +00:00
Andrew Nicols 6a3777f90c Merge branch 'wip-MDL-57785-32' of git://github.com/amygroshek/moodle into MOODLE_32_STABLE 2017-01-31 12:21:37 +08:00
Andrew Nicols de7a6ff47e Merge branch 'MDL-35978-32-blockfix' of https://github.com/snake/moodle into MOODLE_32_STABLE 2017-01-31 11:51:17 +08:00
Jake Dallimore 46e26a1b69 MDL-35978 comments: fix for comments block which has no toggler 2017-01-31 11:33:02 +08:00
Andrew Nicols 0db0a63e50 Merge branch 'MDL-57296-32' of git://github.com/ankitagarwal/moodle into MOODLE_32_STABLE 2017-01-31 08:54:47 +08:00
wehr 120798e85f MDL-57592 assignment: Adds filtering of assignment name in grader view 2017-01-30 18:25:17 +01:00
Tim Hunt 4679634e36 MDL-57588 questions: regrading should not lose flags 2017-01-30 14:32:16 +00:00
Dan Poltawski 1c0462deb3 Merge branch 'wip-MDL-57782-32' of git://github.com/marinaglancy/moodle into MOODLE_32_STABLE 2017-01-30 10:08:28 +00:00
Dan Poltawski 7dc8cc1ab6 Merge branch 'MDL-35978-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2017-01-30 09:54:13 +00:00
Dan Poltawski 170cd579ff Merge branch 'MDL-36233-32' of git://github.com/lameze/moodle into MOODLE_32_STABLE 2017-01-30 09:34:54 +00:00
Ankit Agarwal 6c83de1d51 MDL-57296 gradelib: Fix get_hidding_effect for grade_type_none items 2017-01-30 13:49:57 +05:30
Ankit Agarwal 0ef42d5f6d MDL-57296 gradebook: Fix issue with gradebook while collapsing grades 2017-01-30 13:49:57 +05:30
Mike Churchward ffc60d23b4 MDL-36233 mod_assign: fixed submission time comparison sql and test. 2017-01-30 09:26:39 +08:00
Rajesh Taneja 4f5a6ca40e MDL-54628 behat: Set behat dir for each run under behat_dataroot
Before this patch behat_dataroot for parallel runs
were created at same level as ->behat_dataroot
After this patch, it will be created 1 level under
->behat_dataroot with BEHAT_PARALLEL_SITE_NAME
prefix and run number as suffix. This will allow
common files as test enabled and parallel run info
to be saved in parent directory and access it easily.
2017-01-30 09:23:58 +08:00
Rajesh Taneja a669c6b21e MDL-54628 behat: Show parallel run command with proper rerun option 2017-01-30 09:23:58 +08:00
Kevin Wiliarty e7734513b8 MDL-57113 boost: min-width for region-main in grade views 2017-01-28 11:47:13 -05:00
Amy Groshek 44b4f83298 MDL-57785 scorm: Prevents SCORM nav refresh when nav not shown.
This improvement prevents refresh of SCORM 1.2 navigation menu
when the navigation menu is not displayed.
2017-01-27 09:12:45 -06:00
Marina Glancy 49053808a2 MDL-57782 enrol_self: fix check when email needs to be sent
Thanks to Leandro for providing a fix
2017-01-27 14:25:17 +08:00
Helson Castro 8ea5d72218 MDL-57568 forms: Added missing include for button element. 2017-01-27 14:01:16 +08:00
Jake Dallimore e33b7b342a MDL-35978 comments: expandable comments announce change when toggled
Added role and aria-expanded attributes to the toggler link and added
a key handler for the space and enter keys.
2017-01-27 13:07:12 +08:00
Jun Pataleta f33a8d4eee MDL-57660 mod_forum: Preserve forum ID selection after form submission 2017-01-27 10:09:54 +08:00
Eloy Lafuente (stronk7) 6a4a1d812c weekly release 3.2.1+ 2017-01-27 00:28:06 +01:00
Eloy Lafuente (stronk7) c94dce9c89 Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2017-01-27 00:28:01 +01:00
Tim Hunt a551ea0210 MDL-57587 question file access: fix regression caused by MDL-53744 2017-01-26 18:54:28 +00:00
Michael Aherne 72b489ef65 MDL-57777 rss: Return 404 when context not found. 2017-01-26 10:51:47 +00:00
Eloy Lafuente (stronk7) 827d93f88a Merge branch 'MDL-55915_32' of https://github.com/rezaies/moodle into MOODLE_32_STABLE 2017-01-24 22:11:41 +01:00
AMOS bot 884f4d3ec3 Automatically generated installer lang files 2017-01-25 00:04:42 +08:00
Ankit Agarwal a072271853 MDL-57300 lti: Rename lti2 as registration url
AMOS BEGIN
CPY [registrationurl,mod_lti],[registrationurl,enrol_lti]
AMOS END
2017-01-24 16:41:04 +05:30
Ankit Agarwal 95c794075a MDL-57300 lti: Fix incorrect variable types in docs 2017-01-24 16:41:04 +05:30
Dan Poltawski 890f84cdb2 Merge branch 'MDL-57639-32' of git://github.com/andrewnicols/moodle into MOODLE_32_STABLE 2017-01-24 10:11:29 +00:00
Dan Poltawski b4e1bbef47 Merge branch 'MDL-57667-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2017-01-24 09:40:57 +00:00
Andrew Nicols 678d051bee Merge branch 'm32_MDL-46782' of git://github.com/danmarsden/moodle into MOODLE_32_STABLE 2017-01-24 10:44:03 +08:00
Dan Marsden c83ef7e25b MDL-46782 mod_scorm: fix completion test, remove redundant test. 2017-01-24 13:06:57 +13:00
Dan Poltawski 1ee447d3a4 Merge branch 'wip_32_mdl-50625_ldap_better_check_paged_results_support' of https://github.com/iarenaza/moodle into MOODLE_32_STABLE 2017-01-23 16:21:02 +00:00
Dan Poltawski 217d523d43 Merge branch 'wip-MDL-57511-32' of git://github.com/Beedell/moodle into MOODLE_32_STABLE 2017-01-23 15:39:57 +00:00
Dan Poltawski 76cebe50cb Merge branch 'MDL-57415_m32v1' of https://github.com/sbourget/moodle into MOODLE_32_STABLE 2017-01-23 12:24:11 +00:00
Dan Poltawski 7dfc04ff98 Merge branch 'MDL-57287-32' of git://github.com/snake/moodle into MOODLE_32_STABLE 2017-01-23 12:19:23 +00:00
Dan Poltawski ff037d9698 Merge branch 'mdl57668-moodle32' of https://github.com/tlock/moodle into MOODLE_32_STABLE 2017-01-23 12:05:33 +00:00
Dan Poltawski 39dc183d9f Merge branch 'wip-mdl-57700-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-01-23 11:59:11 +00:00
Dan Poltawski f7ddcd23f8 Merge branch 'MDL-57677-32-usermodified' of git://github.com/mudrd8mz/moodle into MOODLE_32_STABLE 2017-01-23 09:48:12 +00:00
Dan Poltawski 92f57f8397 Merge branch 'm32_MDL-46782' of git://github.com/danmarsden/moodle into MOODLE_32_STABLE 2017-01-23 09:28:31 +00:00
Dan Poltawski 98f246ae97 Merge branch 'MDL-57737-32' of git://github.com/crazyserver/moodle into MOODLE_32_STABLE 2017-01-23 09:26:56 +00:00
Pau Ferrer Ocaña f9e7ee4534 MDL-57737 glossary: Add entry description accepts HTML 2017-01-20 13:26:02 +01:00
Shamim Rezaie b14507a31f MDL-55915 enrol_manual: let fullname()know if user has viewfullnames cap
fullname() relies on its second parameter to determine wheter it should use fullnamedisplay or alternativefullnameformat.
We need to check for moodle/site:viewfullnames capability and pass true as the second parameter to fullname() whereever
the user has this capability.
2017-01-20 19:31:08 +11:00
Shamim Rezaie 4436b9e9dd MDL-55915 core_user: let fullname() know if user has viewfullnames cap
Added $viewfullnames property to the user_selector_base class so anyone using a child class of this class can
let it know if user has viewfullnames capability or not.
2017-01-20 19:30:21 +11:00
Shamim Rezaie 2568183232 MDL-55915 Gradebook: let fullname() know if user has viewfullnames cap
Instruct fullname() to format names on the gradebook grader report with alternativefullnameformat when user
has moodle/site:viewfullnames capability.
2017-01-20 19:28:36 +11:00
Shamim Rezaie bcca23f9c5 MDL-55915 mod_assign: let fullname() know if user has viewfullnames cap
Instruct fullname() to format names on the assignment grading page with alternativefullnameformat when user
has moodle/site:viewfullnames capability.
2017-01-20 19:26:33 +11:00
Rajesh Taneja bab24efe70 MDL-57700 behat: Fixed undefined RuntimeException 2017-01-20 11:05:10 +08:00
Jake Dallimore 45a46ecbd8 MDL-57667 theme: change base layout for boost to columns2
Ensures capability errors are displayed on a page with full navigation.
2017-01-20 08:48:38 +08:00
Stephen Bourget 64cfe467f8 MDL-57728 theme: Fix text display when using tabs 2017-01-19 11:32:52 -05:00
AMOS bot 48f0ebcd49 Automatically generated installer lang files 2017-01-20 00:07:16 +08:00
John Beedell 6537c557b5 MDL-57511 Quiz: Attempts report shows non-unique debugging 2017-01-19 14:44:16 +00:00
Iñaki Arenaza 225e039e73 MDL-50625 auth_ldap: Better check for paged results support
There is at least one LDAP server (Sun Directory Server) that doesn't
support Paged Results extension, even if it supports LDAP version 3. So
checking just for LDAP version is not enough.

If possible, we check the supportedControl attribute of the LDAP rootDSE
and see if the paged results control is available. This needs an LDAP
connection, which might not be possible to establish before we configure
some essential LDAP settings (server, bind user, password, etc.). Thus
we try to establish the connection and check the supportedControl
attribute. But if we fail, we perform only basic checks that are less
accurate and err on the side of cautiousness.
2017-01-19 10:58:13 +01:00
Andrew Nicols c8dddb5ccb MDL-57639 mod_forum: Update to use correct variable name
This addresses a regression where unnecessary attributes were removed
from the old variable. This one was missed.
2017-01-19 13:47:45 +08:00
Andrew Nicols 3e276d6efa weekly release 3.2.1+ 2017-01-19 12:17:57 +08:00
Andrew Nicols adf2ea6166 Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2017-01-19 12:17:56 +08:00
Andrew Nicols fd90d0e925 MDL-57613 enrol_lti: Correct location of upgrade step 2017-01-19 07:56:17 +08:00
Tim Lock 58a4ce4774 MDL-57668 mod_assign: Fix optional_param() form processing 2017-01-19 08:08:07 +10:30
Stephen Bourget b44972cc8b MDL-57415 user: Add missing bootstrap classes to participants page 2017-01-18 10:38:33 -05:00
Dan Poltawski 655570df00 MDL-57604 mod_assign: fix empty case in user selector
Sadly the js arguments object gives an arguments.length of 1 when
no arguments are passed, so we have to explicitly check for it.
2017-01-18 09:59:33 +01:00
Dan Marsden dbf70dec42 MDL-46782 mod_scorm: Load first incomplete sco on re-entry. 2017-01-18 21:03:52 +13:00
Rajesh Taneja c40ed5f6ff MDL-45821 behat: navigate back to scorm to avoid scroll
On Exiting scrom activity, it goes back to course
and scrolls to section. On slow machines next step
fails. To avoid such case navigate to home screen
and then follow next step.
2017-01-18 13:03:07 +08:00
Andrew Nicols 2827c7f997 Merge branch 'MDL-57634-m32' of https://github.com/micaherne/moodle into MOODLE_32_STABLE 2017-01-18 12:38:14 +08:00
Andrew Nicols 2259fb5f36 Merge branch 'wip_MDL-57590_32_forum_search' of https://github.com/mchurchward/moodle into MOODLE_32_STABLE 2017-01-18 08:38:10 +08:00
Dan Poltawski 6dc7039af9 MDL-57604 mod_assign: Adding some missing stuff in 32_STABLE
In order to keep 31, 32 and master the same.
2017-01-18 01:04:48 +01:00
Eloy Lafuente (stronk7) ee7b977a8b Merge branch 'MDL-57604-32' of git://github.com/danpoltawski/moodle into MOODLE_32_STABLE 2017-01-18 00:17:11 +01:00
Eloy Lafuente (stronk7) f4841f394c Merge branch 'wip-MDL-57608-32-3' of git://github.com/marinaglancy/moodle into MOODLE_32_STABLE 2017-01-17 20:46:19 +01:00
David Mudrák 6973e38a91 MDL-57677 mod_forum: Fix wrong user displayed as the last post's author
In the recent issue MDL-56225, we started to record the current user as
the usermodified in the forum_discussions table when updating a forum
post. It made sense but it was a mistake.

Even if the current user really modifies the discussion by updating the
post, the field usermodified has actually been always interpreted and
displayed as the last post' author. Not as the last user who touched the
discussion.

This patch reverts that particular change to the previous behaviour and
adds explicit unit test for it.
2017-01-17 19:39:40 +01:00
AMOS bot c1b158b569 Automatically generated installer lang files 2017-01-18 00:07:24 +08:00
Dan Poltawski 21a8a95869 Merge branch 'wip-mdl-57669-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-01-17 10:28:52 +00:00
sam marshall 359914c8f6 MDL-57515 Resource: 'not very efficient' with a large number of files
Fixes bug where the resource module loads metadata for all files while
building course modinfo, even though it only needs the first file.
(This causes problems if you have ~10k files.)
2017-01-17 10:22:13 +00:00
Jake Dallimore 95208fe135 MDL-57287 themes: fix buttons in default dashboard page header
This fix modifies styling for pages having no navbar, such as the
dashboard, site home and default dashboard pages and fixes an overlap
problem with the buttons and context header.
2017-01-17 15:55:39 +08:00
Rajesh Taneja df428648ee MDL-57669 behat: Exit with error code if step undefined 2017-01-17 10:32:47 +08:00
Dan Poltawski 9148905e9a Merge branch 'MDL-57368-32-2' of https://github.com/snake/moodle into MOODLE_32_STABLE 2017-01-16 16:19:57 +00:00
Dan Poltawski 64df3fed13 Merge branch 'MDL-57613-32' of https://github.com/xow/moodle into MOODLE_32_STABLE 2017-01-16 16:17:16 +00:00
Mike Churchward ed4aaea57b MDL-57590 mod_forum: fixed search form with forumid and actionurl. 2017-01-16 11:16:27 -05:00
AMOS bot 163fc8588d Automatically generated installer lang files 2017-01-17 00:08:10 +08:00
Dan Poltawski 39e34b9586 Merge branch 'MDL-57452_behat_completion_fix_master_MOODLE_32_STABLE' of https://github.com/gthomas2/moodle into MOODLE_32_STABLE 2017-01-16 13:34:09 +00:00
Dan Poltawski 5c63ab7ee8 Merge branch 'MDL-57601-m32' of https://github.com/sammarshallou/moodle into MOODLE_32_STABLE 2017-01-16 12:23:06 +00:00
Dan Poltawski 3e3068cd11 Merge branch 'MDL-57374_m32' of https://github.com/dasistwas/moodle into MOODLE_32_STABLE 2017-01-16 12:10:51 +00:00
Dan Poltawski a27dde0ba7 Merge branch 'MDL-57554-32' of git://github.com/crazyserver/moodle into MOODLE_32_STABLE 2017-01-16 11:17:59 +00:00
Dan Poltawski b92400a49f Merge branch 'm32_MDL-45821' of git://github.com/danmarsden/moodle into MOODLE_32_STABLE 2017-01-16 09:17:50 +00:00
Dan Poltawski a477c8b752 Merge branch 'wip-MDL-56271-32' of git://github.com/marinaglancy/moodle into MOODLE_32_STABLE 2017-01-16 08:01:23 +00:00
Pau Ferrer Ocaña 7f52d5c740 MDL-57554 forum: Mark as read on view_forum_discussion calls 2017-01-13 09:27:06 +01:00
John Okely f52bdbb885 MDL-57613 enrol_lti: Allow longer nonces 2017-01-13 11:22:19 +08:00
David Bogner 7c519588f1 MDL-57374 editor: Pasting plain text in Atto removes all styles/classes 2017-01-12 18:00:37 +01:00
AMOS bot 7345917de4 Automatically generated installer lang files 2017-01-13 00:05:19 +08:00
Stephen Bourget 8a71b10a68 MDL-53991 calendar: fix repeating events on course import 2017-01-12 09:40:38 -05:00
Michael Aherne 18907a51d5 MDL-57634 messaging: Ensure test uses a configured plugin 2017-01-12 12:31:56 +00:00
gthomas2 11d04ffe8a MDL-57452 behat: Make completion check work with manual completion input 2017-01-12 11:38:59 +00:00
Dan Poltawski 5e1014a76e weekly release 3.2.1+ 2017-01-12 07:42:37 +00:00
Dan Poltawski 6e497e6e7d Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2017-01-12 07:42:36 +00:00
Jake Dallimore 66a4a376ee MDL-57368 mod_feeback: fix drag and drop question reordering in boost 2017-01-12 11:37:43 +08:00
Jake Dallimore 3563244314 MDL-57368 templates: add example context to core_form/element-template 2017-01-12 11:37:34 +08:00
Dan Poltawski bf02dc9819 MDL-57608 media_videojs: lazily load videojs on demand
The videojs javascript is over 1MB of javascript which we don't need to
load on every page, now that we only require it demand, the js can be
lazily loaded when its needed, which keeps the first.js smaller and more
likely to stay in browser cache.
2017-01-12 10:56:06 +08:00
Dan Poltawski 8e8c066448 MDL-57608 media_videojs: fix third party locations 2017-01-12 10:56:06 +08:00
Marina Glancy 67f83d9279 MDL-57608 media_videojs: load youtube module only when requested 2017-01-12 10:56:06 +08:00
Michael Aherne bcd1915dd0 MDL-57630 messaging: Pass unit test with third-party plugins 2017-01-11 16:39:31 +00:00
Eloy Lafuente (stronk7) 992ffccfd2 Merge branch 'wip-mdl-57595-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-01-11 02:29:56 +01:00
Dan Poltawski 97fd5a9841 Merge branch 'MDL-57480-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2017-01-10 08:40:12 +00:00
Marina Glancy 6b47a070e7 MDL-56271 mod_feedback: recaptcha was not working 2017-01-10 14:08:26 +08:00
David Monllao b4cfb7d733 Merge branch 'MDL-57385-32-2' of git://github.com/junpataleta/moodle into MOODLE_32_STABLE 2017-01-10 05:27:11 +01:00
Marina Glancy a9fa51024f MDL-50770 blocks: copy sitewide blocks positions when cloning dashboards 2017-01-10 11:40:27 +08:00
Jun Pataleta 2eec6ffc6c MDL-57385 core: Set page layouts of non-mydashboard pages to standard
The following pages are using the "mydashboard" page layout:
* User preferences > Badges > Manage badges
* User preferences > Badges > Backpack settings
* User preferences > Repositories > Manage instances
* Private files
However, the "mydashboard" page layout should only be used for the user's
dashboard page. Changing these to use the "standard" page layout.
2017-01-10 09:46:18 +08:00
Rajesh Taneja 3f1574f849 MDL-57595 behat: Added redirect and wait to ensure next step pass 2017-01-10 08:45:43 +08:00
Jake Dallimore 40b78a23e9 MDL-57480 core_course: make drag and drop fire a dom updated event
When adding media via drag and drop, the notifyFilterContentUpdated
event should be called after the item is added to the DOM. This allows
things like videojs for example, to process the new content.
2017-01-10 07:47:18 +08:00
Dan Poltawski fb5655b5c2 MDL-57604 mod_assign: fix incorrect user being selector from chooser
Previously there was a logic bug where by if some students were filtered
from the list, the label for another student could be attached to the
'filered' student.

This fix reworks the promises a bit so we render the student summary and
then build an row with the explict user id, rather than itterating through
the array later.

I also remove the storing of the initial promise in a varible because
this is an easy way to introduce a bug (not waiting for the .then()
chained promise)
2017-01-09 20:28:01 +00:00
sam marshall 405dcba6f3 MDL-57601 Grade report: Error for ungraded quiz without view hidden
If a course contains an ungraded quiz (max grade set to 0), and there
is a user account which can view the grader reports but does not have
permission to view hidden grades, they will get errors.
2017-01-09 17:14:44 +00:00
Dan Poltawski 7f32c5a447 Merge branch 'MDL-57427_m32' of https://github.com/jrchamp/moodle into MOODLE_32_STABLE 2017-01-09 16:26:18 +00:00
AMOS bot ec3eeb7ace Automatically generated installer lang files 2017-01-10 00:04:55 +08:00
Jonathan Champ 1af3d13bf3 MDL-57427 cache: Use perfdebug only when enabled 2017-01-09 10:18:41 -05:00
David Monllao 84122523ba Merge branch 'wip-mdl-55042-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-01-09 12:56:12 +01:00
godric 382c069e52 MDL-40132 lib: Using compare rule results in fatal error.
In getValidationScript function variable $element can be an array or object.
Function attempt get non-existing attributes.
To avoid this we should check before accessing.
2017-01-09 10:30:03 +00:00
Dan Poltawski 3f58a36504 Merge branch 'wip-mdl-56211-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-01-09 09:58:42 +00:00
Dan Poltawski 9e41e4e8ea Merge branch 'MDL-57373-32' of git://github.com/ankitagarwal/moodle into MOODLE_32_STABLE 2017-01-09 09:42:17 +00:00
Dan Poltawski 7523d99558 Merge branch 'MDL-53367_32' of https://github.com/juancs/moodle into MOODLE_32_STABLE 2017-01-09 08:27:56 +00:00
Dan Marsden 9a375bdf6c MDL-45821 mod_scorm: Check lesson_status correctly for multi-sco. 2017-01-09 20:08:10 +13:00
Eloy Lafuente (stronk7) 07f6358b03 Moodle release 3.2.1 2017-01-08 11:04:37 +01:00
AMOS bot 7ffb98d0f5 Automatically generated installer lang files 2017-01-08 00:04:57 +08:00
Dan Poltawski dda99bb3f2 weekly release 3.2+ 2017-01-06 01:30:59 +00:00
Dan Poltawski 9cff26295b Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2017-01-06 01:30:57 +00:00
Rajesh Taneja 2fd5ceadb5 MDL-56211 behat: Add suite name to faildump path
If suite is not default then add suite name
to end of faildump file name
2017-01-06 09:20:10 +08:00
David Mudrák 5865a6875b MDL-57580 mod_assign: Fix the incorrect type of some input parameters
The PARAM_TEXT has been misused in certain cases here. The 'action'
parameter seems to always be alphabetic, with values like
savesubmission, editsubmission and others as handled in assign::view().

Fixing the action handling fixes the reported XSS issue. While working
on it, I spotted two more places where PARAM_TEXT does not seem
appropriate. I include changes for them too, even if they are no
strictly related to the reported bug and there are no known ways to
abuse it.

* The 'plugin' looks like PARAM_PLUGIN and is even declared as such in
  some other parts of the assignment code (such as feedback forms).

* The 'workflowstate' is one of the ASSIGN_MARKING_WORKFLOW_STATE
  constants and is supposed to be alpha in external function input
  parameters handling, too.
2017-01-05 17:39:51 +01:00
Dan Poltawski ef2eed1b3c Merge branch 'MDL-57563-32-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_32_STABLE 2017-01-05 10:11:40 +00:00
Rajesh Taneja 6601017d02 MDL-57531 behat: Set noreplyaddress to valid address
noreplyaddress should be a valid address, else
it will not be saved. For behat we don't send
email, so set it to noreply@example.com, to
avoid failing validation on localhost
2017-01-05 06:52:06 +00:00
Daniel Thee Roperto a204d7d921 MDL-57576 assignment: Overwrite feedback file if it has the same name. 2017-01-05 15:32:51 +11:00
Damyon Wiese bf345fc4ca MDL-57009 javascript: cibot nagging 2017-01-05 09:36:09 +08:00
Damyon Wiese 2722404791 MDL-57009 javascript: Dont rely on async ajax
Recursively pre-scan mustache templates to extract the list of blocks and partials. Then
we can pre-fetch them all and don't have to rely on jquery async ajax (which is deprecated).

This is part of a refactoring of the promises code in the templates module to prevent duplicate requests.
2017-01-05 09:36:09 +08:00
Damyon Wiese 256f820dfd MDL-57009 js: Do not fetch the same template twice
Also clean up promises use of done vs then.
2017-01-05 09:36:09 +08:00
Damyon Wiese 173f5515e3 MDL-57009 js: Skip ajax request for same string
This is done by caching the first promise generated to fetch a string.
2017-01-05 09:36:09 +08:00
David Mudrák 7ed6f330c6 MDL-57563 lang: Use the new newsitemsnumber wording in behat 2017-01-04 22:19:32 +01:00
Helen Foster 418d01aaf4 MDL-57563 lang: Merge English strings from the en_fix language pack 2017-01-04 22:18:31 +01:00
AMOS bot 11f9ff55e1 Automatically generated installer lang files 2017-01-05 00:05:20 +08:00
Dan Poltawski 04d4796089 Merge branch 'MDL-57531-32-phpmailer' of git://github.com/mudrd8mz/moodle into MOODLE_32_STABLE 2017-01-04 13:28:39 +00:00
David Mudrák e889aee562 MDL-57531 mail: Validate the sender's email address
The patch adds validation for the noreplyaddress setting variable, for
the explicit $replyto parameter and for the sender's email. In case of
misconfigured noreplyaddress setting, it falls back to the default
noreply address value. In case of invalid email in the user's record,
the email is not sent.

The patch also adds unit test for the value returned by the function
generate_email_processing_address() so that it can be considered as a
valid email, too.

This is supposed to significantly minimise the risk of exploiting the
vulnerability in PHPMailer's Sender field.
2017-01-04 12:37:36 +01:00
David Mudrák 228157ebf5 MDL-57531 mail: Do not let admins set invalid email addresses
The noreply and support emails should always be valid.
2017-01-04 12:37:36 +01:00
Eloy Lafuente (stronk7) c77ae4e017 Merge branch 'MDL-57192-32' of git://github.com/ankitagarwal/moodle into MOODLE_32_STABLE 2017-01-04 11:34:23 +00:00
David Mudrák 1da3022e50 MDL-56225 mod_forum: Fix inability to edit attachments
The 'attachments' is not a real DB field here. It comes from the form's
filepicker and holds the id of the attachments filearea. The function
forum_add_attachment() expects it as a property of the first argument.

There were two possible approaches here. Either to pass the raw $newpost
to forum_add_attachment(), or add the attachments into the list
modifiable fields. The second approach is safer.
2017-01-04 11:34:22 +00:00
David Monllao f6507b8e35 Merge branch 'm32_MDL-49557' of git://github.com/danmarsden/moodle into MOODLE_32_STABLE 2017-01-04 11:34:22 +00:00
David Monllao d52b937932 MDL-57338 templates: Fix modal_cancel template name 2017-01-04 11:34:21 +00:00
Rajesh Taneja ce36e3626f MDL-57536 availability: Fixed css for clean theme 2017-01-04 11:34:21 +00:00
Ankit Agarwal 063f7c198b MDL-56992 core_scss: Don't allow invalid files to be included
We allow only .scss files so allow files to be included only and only if they end in .scss and they exist on server under theme directory.
2017-01-04 11:34:20 +00:00
Andrew Nicols 83dedbcd33 MDL-56225 mod_forum: Remove unnecessary attributes from update 2017-01-04 11:34:20 +00:00
Dan Marsden 0ad466926d MDL-49557 mod_scorm: optionally strip quotes. 2017-01-04 15:45:08 +13:00
Ankit Agarwal ced9a33352 MDL-57192 dml: Temporarily disable query logging during setup 2017-01-03 17:27:08 +05:30
Ankit Agarwal 3b4fba5588 MDL-57192 dml: Support temporarily disabling query logs during setup 2017-01-03 17:27:08 +05:30
Rajesh Taneja 926d5a53ff MDL-55042 phpunit: Get sorted sections
Sometimes db doesn't return records in order
So enusre it is in order so that last record
doesn't have section equal 0. As section 0
can't be deleted.
2017-01-03 10:00:05 +08:00
Eloy Lafuente (stronk7) 9cc9dabf17 Merge branch 'wip-mdl-57494-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2017-01-03 02:35:10 +01:00
Eloy Lafuente (stronk7) cb8be0b6b8 Merge branch 'MDL-57536-32' of git://github.com/jleyva/moodle into MOODLE_32_STABLE 2017-01-02 18:59:55 +01:00
Juan Leyva c6bd4c1a45 MDL-57536 availability: Document required selectors changes
MDL-55839 Introduced some changes in CSS selectors used by the form.js
file.

This caused contributed plugins to not work (javascript stop working)
when editing a module.
2017-01-02 18:52:22 +01:00
Davo Smith 31e4c05002 MDL-47198 filelib: fix curl handling headers with no value 2017-01-02 16:43:52 +01:00
Dan Poltawski c5f11c0f3c Merge branch 'm32_MDL-49557' of git://github.com/danmarsden/moodle into MOODLE_32_STABLE 2017-01-02 12:35:10 +00:00
Dan Poltawski 6158379f75 Merge branch 'MDL-57080-m32' of https://github.com/micaherne/moodle into MOODLE_32_STABLE 2017-01-02 12:15:02 +00:00
Dan Poltawski bc076bf1b8 Merge branch 'wip-MDL-57464-32' of git://github.com/abgreeve/moodle into MOODLE_32_STABLE 2017-01-02 11:16:24 +00:00
Dan Poltawski 27a3a42efd MDL-57532 calendar: tidy up button grouping 2017-01-02 10:45:24 +00:00
Dan Poltawski b0c2ea4640 Merge branch 'MDL-57532_m32v1' of https://github.com/sbourget/moodle into MOODLE_32_STABLE 2017-01-02 10:45:20 +00:00
David Monllao 00ef7b1caa Merge branch 'MDL-56926_32' of git://github.com/dmonllao/moodle into MOODLE_32_STABLE 2016-12-30 10:00:08 +01:00
David Monllao 7914b0035f MDL-56926 theme_boost: Restore filepicker's filename and icons original spacing 2016-12-30 09:57:41 +01:00
Nadav Kavalerchik cb358279b7 MDL-56926 Theme/Boost: Fix filepicker folder tree YUI guides 2016-12-30 09:57:35 +01:00
AMOS bot 339edb47e2 Automatically generated installer lang files 2016-12-30 00:05:21 +08:00
Dan Poltawski bd6bc508df Merge branch 'MDL-57512-32' of git://github.com/crazyserver/moodle into MOODLE_32_STABLE 2016-12-29 11:50:58 +00:00
Dan Poltawski c53194f3f9 Merge branch 'm32_MDL-50643' of git://github.com/danmarsden/moodle into MOODLE_32_STABLE 2016-12-29 11:46:48 +00:00
Pau Ferrer Ocaña c477dc23c0 MDL-57512 categories: Use maxcategorydepth only when getting all cats 2016-12-29 12:05:27 +01:00
David Monllao 8cd421e941 Merge branch 'MDL-57338-32' of git://github.com/danpoltawski/moodle into MOODLE_32_STABLE 2016-12-29 10:52:30 +01:00
Dan Poltawski f18c2a9d15 MDL-57338 templates: fix missing example variables
From Davids review, thanks
2016-12-29 08:05:04 +00:00
David Monllao 403e0d96e5 Merge branch 'MDL-57331-32' of https://github.com/xow/moodle into MOODLE_32_STABLE 2016-12-28 22:32:33 +01:00
Dan Poltawski 5984ffded4 Merge branch 'MDL-57451-32' of https://github.com/lucisgit/moodle into MOODLE_32_STABLE 2016-12-28 21:17:48 +00:00
Dan Poltawski cd9a925e6a Merge branch 'MDL-55955_32' of git://github.com/markn86/moodle into MOODLE_32_STABLE 2016-12-28 21:17:47 +00:00
Dan Poltawski 40471ed54c Merge branch 'wip-MDL-57366-32' of git://github.com/abgreeve/moodle into MOODLE_32_STABLE 2016-12-28 21:17:46 +00:00
David Monllao 000b0949e6 Merge branch 'MDL-57491_m32v3' of https://github.com/sbourget/moodle into MOODLE_32_STABLE 2016-12-28 21:17:46 +00:00
Dan Poltawski 6c7f60dbc0 Merge branch 'MDL-57417-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2016-12-28 21:17:45 +00:00
David Monllao 3b37e372f2 Merge branch 'MDL-52366-32-mustachethemedir' of git://github.com/mudrd8mz/moodle into MOODLE_32_STABLE 2016-12-28 12:23:49 +01:00
David Monllao 44b94d9324 Merge branch 'MDL-57450-32' of git://github.com/danpoltawski/moodle into MOODLE_32_STABLE 2016-12-28 11:48:05 +01:00
Dan Poltawski e5bc84f84f MDL-57251 upgrade: bump versions
and remove uncessary ->mark_dirty()
2016-12-28 10:28:37 +00:00
Dan Poltawski a38d0650d4 Merge branch 'wip-MDL-57251-32' of git://github.com/abgreeve/moodle into MOODLE_32_STABLE 2016-12-28 10:28:31 +00:00
David Monllao 8d9edc0e7c Merge branch 'MDL-57357-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2016-12-28 11:17:11 +01:00
David Monllao 4e0357c1e3 Merge branch 'MDL-56488-32' of git://github.com/danpoltawski/moodle into MOODLE_32_STABLE 2016-12-28 10:58:22 +01:00
Dan Poltawski 9efd73abec Merge branch 'wip-MDL-57292-32' of git://github.com/abgreeve/moodle into MOODLE_32_STABLE 2016-12-28 09:13:37 +00:00
Dan Poltawski c31b5bbf9d Merge branch 'MDL-57474-32-messageid' of git://github.com/mudrd8mz/moodle into MOODLE_32_STABLE 2016-12-28 08:56:06 +00:00
Dan Marsden 7606ba2133 MDL-49557 mod_scorm: fix AICC pre-requisite handling. 2016-12-28 10:09:00 +13:00
Ankit Agarwal 88c0fcb03f MDL-57373 navigation: Fix course names in flat nav 2016-12-27 12:21:02 +05:30
Stephen Bourget 51b7f8f0a4 MDL-57532 calendar: Add missing bootstrap classes 2016-12-26 11:41:50 -05:00
AMOS bot 40fdf0f84f Automatically generated installer lang files 2016-12-27 00:08:58 +08:00
AMOS bot 3e99f4f642 Automatically generated installer lang files 2016-12-26 00:05:52 +08:00
AMOS bot 324e613b48 Automatically generated installer lang files 2016-12-25 00:04:37 +08:00
Adrian Greeve 502397dcbc MDL-57464 mod_lesson: fix notice with sub-clusters. 2016-12-23 11:12:27 +08:00
Jake Dallimore f1f83c3ba1 MDL-57357 auth: add behat coverage for remember username login feature 2016-12-23 11:04:19 +08:00
Jake Dallimore 2c3f09ccf7 MDL-57357 auth: fix the remember username feature on login page 2016-12-23 10:45:06 +08:00
Adrian Greeve e2f5592b8f MDL-57366 mod_lesson: Zero now acceptable numeric answer.
When creating a numerical question. If the answer to the
question is 0 then the answer will not save.
2016-12-23 10:36:12 +08:00
Mark Nelson 522fcf2ffc MDL-55955 mod_quiz: ensure duplicated override events are removed 2016-12-23 10:02:47 +08:00
Jake Dallimore 96e743ff78 MDL-57417 navigation: fix legacy_activity_onclick_handler callback scope 2016-12-23 08:43:37 +08:00
Dan Marsden e514ae345e MDL-50643 mod_scorm: redirect using current window instead of parent. 2016-12-23 10:18:52 +13:00
Stephen Bourget 2659b808ab MDL-57491 report_log: Improve filtering code by using static entries 2016-12-22 16:12:34 -05:00
AMOS bot 54037cf3e2 Automatically generated installer lang files 2016-12-23 00:04:18 +08:00
Dan Poltawski b0773d70c6 MDL-57338 message: fix template component 2016-12-22 12:57:11 +00:00
Dan Poltawski 4348fffe0c MDL-57338 templates: add missing example context 2016-12-22 12:57:11 +00:00
Dan Poltawski 216c68b834 MDL-57338 chart: add example context
And fix aria roles
2016-12-22 12:57:11 +00:00
Dan Poltawski a3c1bd86ed MDL-57338 mustache: fix admin_setting_tabs
* Add example context
* Fix validation issue (need role="tablist" to contain the tabs)
2016-12-22 12:57:11 +00:00
Michael Aherne e0006399ff MDL-57080 completion: Update completion expected date on reset 2016-12-22 11:43:39 +00:00
Tony Butler 2084c59b82 MDL-57451 theme_boost: Add checkboxgroup class to checkbox input element 2016-12-22 11:30:24 +00:00
Dan Poltawski a09a9879e5 weekly release 3.2+ 2016-12-22 08:15:17 +00:00
Dan Poltawski a3a095b6eb Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2016-12-22 08:15:15 +00:00
Adrian Greeve 0edf724367 MDL-57292 tool_lpimportcsv: Fix for unit tests. 2016-12-22 14:41:32 +08:00
Simey Lameze a953ac5942 MDL-57292 tool_lpimportcsv: display progress bar for large imports 2016-12-22 14:41:17 +08:00
Rajesh Taneja 5627b0b1a1 MDL-57494 behat: Fixed tags and removed reset in after_scenario
1. Added missing switch_window tags
2. Fixed switch_frame tags to use switch_iframe
3. Removed reset from after_scenario.
2016-12-22 12:44:38 +08:00
David Monllao 5d3a7be453 Merge branch 'MDL-55575_B_32' of https://github.com/bostelm/moodle into MOODLE_32_STABLE 2016-12-21 05:50:17 +01:00
David Mudrák 8f27fdf1ab MDL-57474 mailer: Make sure that our exlicit MessageID is trimmed
The new version of phpmailer shipped with Moodle 3.2 has added check
that the explicitly provided MessageID matches /^<.*@.*>$/.

Values coming from our overridden moodle_phpmailer::addCustomHeader()
had a whitespace at the start. So the requested value was not used as
the Message-ID header and the default phpmailer value was used.

As a result, forum posts threading was broken in email clients.
2016-12-21 01:11:32 +01:00
AMOS bot 1d5c2c6560 Automatically generated installer lang files 2016-12-21 00:04:00 +08:00
Simey Lameze 18317c7c1c MDL-57114 filemanager: apply btn-sm class to buttons
This commit also creates a new css rule to fix the file picker icons misalignment.
2016-12-20 10:34:08 +00:00
Dan Poltawski b83fd5b1fe Merge branch 'MDL-54996_m32v1' of https://github.com/sbourget/moodle into MOODLE_32_STABLE 2016-12-20 09:19:27 +00:00
Juan Segarra Montesinos 972304f4cb MDL-53367 mod_forum: Subscribe current users when importing a forum
Subscribes currently enrolled users when importing a forum with
automatic subscription enabled.
2016-12-20 08:55:34 +01:00
Adrian Greeve 11eeb2e347 MDL-57251 navigation: Correct permission shows site admin
If the user does not have the moodle/site:configview
capability then do not show them the site administration
link.
2016-12-20 14:54:34 +08:00
Adrian Greeve 0aa8b11f5c MDL-57251 administration: Updated coursecreator role.
The coursecreator role now has the moodle/site:configview
capability so that they have access to the required admin
pages.
2016-12-20 14:54:34 +08:00
John Okely 829cafc050 MDL-57331 messaging: Fix sent messages appearing twice. 2016-12-20 10:48:01 +08:00
John Okely 25474b5e84 MDL-57268 auth_db: Unit tests for deletion from a large user set 2016-12-20 02:27:05 +01:00
Rafal Domagalski b7f902b5b3 MDL-52366 themes: check for templates in themedir 2016-12-19 18:08:37 +01:00
Dan Poltawski 11488775eb Merge branch 'MDL-57386-32' of git://github.com/damyon/moodle into MOODLE_32_STABLE 2016-12-19 15:46:59 +00:00
Dan Poltawski 32ec7e3d30 Merge branch 'MDL-55568_m32v2' of https://github.com/sbourget/moodle into MOODLE_32_STABLE 2016-12-19 14:33:06 +00:00
Dan Poltawski 1a1eef4345 Merge branch 'wip-MDL-56912-32' of git://github.com/marinaglancy/moodle into MOODLE_32_STABLE 2016-12-19 12:21:23 +00:00
Eloy Lafuente (stronk7) 4942dfc7cd Merge branch 'MDL-57270_32' of git://github.com/markn86/moodle into MOODLE_32_STABLE 2016-12-19 13:04:25 +01:00
Eloy Lafuente (stronk7) d469fb2181 Merge branch 'MDL-57293-32' of git://github.com/danpoltawski/moodle into MOODLE_32_STABLE 2016-12-19 13:02:16 +01:00
Dan Poltawski 0213ce081c Merge branch 'MDL-52098_32_STABLE' of git://github.com/Chocolate-lightning/moodle into MOODLE_32_STABLE 2016-12-19 11:25:49 +00:00
David Monllao 70b6a6618a Merge branch 'MDL-57402_32' of git://github.com/timhunt/moodle into MOODLE_32_STABLE 2016-12-19 12:23:45 +01:00
Dan Poltawski 089cf944f3 MDL-57450 enviroment: remove tls library check
Unfortunately it has come to light that the version sniffing is just not
reliable at all, operating system vendors backport security patches to
older versions - so in many cases we reporting a problem which is not a
problem. False positives and the solution to self-compile or something
like php will be causing more harm than good.
2016-12-19 10:53:59 +00:00
Dan Poltawski 68d9adcba8 Merge branch 'MDL-53044-m32' of https://github.com/ak4t0sh/moodle into MOODLE_32_STABLE 2016-12-19 08:47:23 +00:00
Dan Poltawski 32636d1757 Merge branch 'MDL-55715_m32v1' of https://github.com/sbourget/moodle into MOODLE_32_STABLE 2016-12-19 08:35:43 +00:00
Stephen Bourget 48ff43d3bd MDL-54996 Calendar: Fix dates for future multi-day events
Thanks to Martin Cunliffe for providing the fix
2016-12-17 10:53:00 -05:00
Mathew May 725863abe4 MDL-52098 enrol: cohort now looks at instance status 2016-12-16 11:22:06 +13:00
Arnaud Trouve 9de4bbf8a8 MDL-53044 auth : force change on expired password 2016-12-15 15:11:30 +01:00
Dan Poltawski cd7ca81fdd MDL-57293 lang/email: Improve emailvia string
* Strip the https? part of url for existing strings
* Switch the string to (via shortname)
2016-12-15 09:54:34 +00:00
Andrew Nicols 1ca30f2503 weekly release 3.2+ 2016-12-15 11:34:25 +08:00
Andrew Nicols c47a9439d3 Merge branch 'install_32_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_32_STABLE 2016-12-15 11:34:21 +08:00
Damyon Wiese 2ce5b1d637 MDL-57386 blocklib: wrong variable in is_block_present
This isn't reachable code in core moodle, but themes/plugins could call is_block_present to trigger it.
2016-12-15 10:51:31 +08:00
Tim Hunt c4ade76ee5 MDL-57402 quiz editing: fix add heading after remove page break 2016-12-14 16:35:17 +00:00
AMOS bot 62fc665ff6 Automatically generated installer lang files 2016-12-15 00:04:14 +08:00
Dan Poltawski 263865899e MDL-56488 boost: validate scss settings for parsable scss
* Parses the scss and fails validation if a parse error is found

* Does not detect the situation when variables are not present - this
  would involve us parsing the entire tree and would be slow. It could
  also change over time, depending on whats defined in the scss
  from themes.

* Introduces a new admin_setting_scsscode to do this
2016-12-14 11:34:25 +00:00
Mark Nelson f927f3e196 MDL-57270 core_message: trim message before it is sent 2016-12-14 12:19:24 +08:00
Stephen Bourget 70f5e9ba61 MDL-55715 calendar: Only update events from the current subscription
The iCal import should only update calendar events from the current
subscription not any subscription that contains the same event.
2016-12-13 22:06:44 -05:00
Andrew Nicols 3b7bf2cee0 Merge branch 'wip-mdl-57380-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2016-12-14 09:56:57 +08:00
Mark Nelson a57a9053d7 MDL-55062 tool_uploaduser: prevent defaults when not selected 2016-12-14 09:49:04 +08:00
Rajesh Taneja 0292245755 MDL-57380 behat: Check for list tags and text
after list tag span can be added on few browsers
like chrome 51.0, so test if text starts with
list tag and contains text
2016-12-14 09:38:35 +08:00
Stephen Bourget dd7aa695b2 MDL-55568 chat: chat_refresh_events should only create published events 2016-12-13 18:53:40 -05:00
Eloy Lafuente (stronk7) 2626dce64c Merge branch 'MDL-55809-32' of https://github.com/xow/moodle into MOODLE_32_STABLE 2016-12-13 20:05:23 +01:00
Dan Poltawski 7e2e135943 Merge branch 'MDL-57125-32' of git://github.com/lameze/moodle into MOODLE_32_STABLE 2016-12-13 16:34:58 +00:00
Matt Davidson cc15b9d46f MDL-56810 unoconv: task fails if user removed
If the user is removed from a course after a submission has been made,
the task will crash and never continue.  This removes submissions from
the cron task if the user isn't enrolled in the course.
2016-12-13 14:56:52 +00:00
Eloy Lafuente (stronk7) ce47bacfe9 Merge branch 'MOODLE_32_STABLE' of https://github.com/fwsl/moodle into MOODLE_32_STABLE 2016-12-13 12:00:58 +01:00
ak4t0sh 7c89091995 MDL-55720 course: fix potential undefined variable and cleaning
This commit replace $e usage by $returnfromfunc.
Indeed $returnfromfunc always exists in the scope and take $e value in case of moodle_exception.

This commit also remove useless $modcontext affectation.
2016-12-13 11:49:32 +01:00
Henning Bostelmann 7766ffc618 MDL-55575 mod_glossary: Allow viewing all entries on one page 2016-12-13 11:46:03 +01:00
Mark Nelson 75efa0860c MDL-57250 core: show admin settings when only one category exists 2016-12-13 10:25:19 +00:00
Dan Poltawski d31412392c Merge branch 'MDL-56859-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2016-12-13 09:45:19 +00:00
Dan Poltawski da694c75ff Merge branch 'MDL-57074-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2016-12-13 09:26:08 +00:00
Adrian Greeve 76f5d7b9ab MDL-57216 navigation: Updated parent behat test. 2016-12-13 09:04:40 +00:00
Adrian Greeve e7d8926583 MDL-57216 navigation: Added missing grade overview link.
For theme_boost the grade overview link has been added
to the user profile page.
2016-12-13 09:04:36 +00:00
Dan Poltawski c87f1ac4c7 Merge branch 'MDL-57182-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2016-12-13 08:47:35 +00:00
Dan Poltawski 75c4f5b0ca Merge branch 'wip-MDL-57257-32' of git://github.com/abgreeve/moodle into MOODLE_32_STABLE 2016-12-13 08:46:03 +00:00
Marina Glancy f7b3774380 MDL-56912 feedback: empty multichoice questions do not submit 2016-12-13 15:01:04 +08:00
Andrew Nicols 78293c74bf Merge branch 'MDL-57213-32-2' of git://github.com/junpataleta/moodle into MOODLE_32_STABLE 2016-12-13 13:06:25 +08:00
Simey Lameze 406fc019c1 MDL-57125 comment: prevent js execution if there are no comments 2016-12-13 11:55:05 +08:00
Jun Pataleta 903cd37434 MDL-57213 navigation: Load all my course categories into navigation tree
* Load all of the relevant course categories of the courses that a user
  is enrolled in.
2016-12-13 11:43:22 +08:00
Nadav Kavalerchik 6fd8b0098a MDL-57056 Theme/Boost: Fix "Skip to" link when Tab key pressed 2016-12-13 10:47:50 +08:00
Jan Dageförde 34954a6050 MDL-57257 lesson: Validate type of numerical answer 2016-12-13 10:34:36 +08:00
Mark Nelson 949d8ae04e MDL-57222 mod_assign: show validation message on visible element 2016-12-13 10:30:38 +08:00
Eloy Lafuente (stronk7) 1c7cbed23c Merge branch 'wip-mdl-57328-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2016-12-13 02:30:06 +01:00
Eloy Lafuente (stronk7) 9156498826 Merge branch 'mdl32_MDL-57324' of git://github.com/danmarsden/moodle into MOODLE_32_STABLE 2016-12-13 02:02:02 +01:00
Jake Dallimore 71adc9a9a3 MDL-57182 navigation: fix login failures display in page footer.
A bug introduced with MDL-45893 meant that the failure count was being
reset, causing the footer code to be skipped. This patch fixes that
bug and adds behat tests covering the displayloginfailures feature.
2016-12-13 07:20:58 +08:00
Eloy Lafuente (stronk7) 49612b733f Merge branch 'MDL-57319-32' of git://github.com/danpoltawski/moodle into MOODLE_32_STABLE 2016-12-12 16:23:20 +01:00
Arnaud Trouve bc0721c7d9 MDL-56525 forum: remove targeted user enrolment check
By removing the check on the targeted user's enrolment we allow to show his forum posts even if he is unenrol from a course (obviouly we need to have access to this course to view them)
2016-12-12 14:10:21 +00:00
Ryan Wyllie c5452484ee MDL-55782 groups: wrap long group names (theme: boost)
In the groups UI if a group name is very long it now no longer underlaps
the user column on its right hand side.
2016-12-12 13:19:18 +00:00
= 74eecb6078 MDL-55782 groups: wrap long group names
In the groups UI if a group name is very long it now no longer underlaps the user
column on its right hand side.
2016-12-12 13:19:15 +00:00
Dan Poltawski 725be51c11 Merge branch 'wip-mdl-52796-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2016-12-12 13:00:56 +00:00
Philipp Hager d0d8a7f984 MDL-57198 course: add css-classes to restrictbygroup-button 2016-12-12 12:46:52 +00:00
Adrian Greeve 4a50811ae3 MDL-57299 Atto: Theme boost fix for manage files.
Theme boost removed a selector that was being used
to remove used files and so the page wasn't loading
properly.
2016-12-12 12:40:09 +00:00
Dan Poltawski b82ddcbcac Merge branch 'wip-mdl-57325-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2016-12-12 12:23:25 +00:00
Dan Poltawski 6e4cc6caf4 Merge branch 'wip-mdl-57314-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2016-12-12 12:21:31 +00:00
Dan Poltawski fe8e9b1b4e Merge branch 'wip-mdl-57343-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2016-12-12 12:21:13 +00:00
Dan Poltawski 72770e9a60 Merge branch 'MDL-57171-32-2' of git://github.com/junpataleta/moodle into MOODLE_32_STABLE 2016-12-12 10:31:13 +00:00
Dan Poltawski a847efc70b Merge branch 'MDL-56566_32' of https://github.com/bostelm/moodle into MOODLE_32_STABLE 2016-12-12 09:20:13 +00:00
Ilya Tregubov 9e99327888 MDL-55906 table: Update user preferences table when reset preferences 2016-12-12 09:07:30 +00:00
Andrew Nicols 9973eebb91 Merge branch 'MDL-46714-32-nadav' of git://github.com/FMCorz/moodle into MOODLE_32_STABLE 2016-12-12 13:26:58 +08:00
Nadav Kavalerchik a162f636d8 MDL-46714 Calendar: Properly order Date & Time fields in RTL mode 2016-12-12 12:38:45 +08:00
Rajesh Taneja 8ff8d598fe MDL-57343 behat: Ensure we wait enough for page to be fully loaded 2016-12-12 10:38:32 +08:00
Ramindu Deshapriya 8704d2e5fc MDL-52796 behat: Behat feature to test reset wiki page, tags & comments 2016-12-12 10:27:44 +08:00
Bram Tassyns f9dd21a17a MDL-56859 SCORM: player shouldn't display TOC while loading 2016-12-12 09:11:50 +08:00
Jake Dallimore eb349bdfc4 MDL-57074 Filepicker: Fix alias and link icons in RTL mode
Fixed alignment of the images in RTL mode. Also fixed a z-index problem
in which the icons were displayed above the open drawer on narrow
screens.
2016-12-12 08:48:15 +08:00
AMOS bot 89d186af72 Automatically generated installer lang files 2016-12-10 00:04:00 +08:00
Dan Poltawski 65de977483 MDL-57319 outputlib: raise timeout for scss/less compilation 2016-12-09 08:47:05 +00:00
Rajesh Taneja e167481759 MDL-57328 core: Remove xdebug extension, so test run faster 2016-12-09 10:24:01 +08:00
Rajesh Taneja 457c913461 MDL-57325 behat: Fixed backup/restore steps to use proper api 2016-12-09 09:31:13 +08:00
Rajesh Taneja 422449dca8 MDL-57328 core: Run tests with php 7.1 2016-12-09 08:49:21 +08:00
Dan Marsden 53c8f0ca3c MDL-57324 scorm: exclude objective raw.score from grade update 2016-12-09 10:13:20 +13:00
Henning Bostelmann b094b88a9a MDL-56566 mod_assign: ignore "doanything" in course overview
Do not count site admin "doanything" capability for determining
what should be shown in the course overview for assignments.
2016-12-08 20:28:10 +00:00
AMOS bot 49e5d04a8d Merge branch 'MOODLE_32_STABLE' into install_32_STABLE 2016-12-09 00:04:15 +08:00
AMOS bot 38e28dfbcd Automatically generated installer lang files 2016-12-08 18:11:21 +08:00
Dan Poltawski 44047dc78d weekly release 3.2+ 2016-12-08 08:43:05 +00:00
Marina Glancy c06b8145b1 MDL-56614 behat: add missing wait for page is ready 2016-12-08 13:51:53 +08:00
Franziska Hübler 79da2c5bfa MDL-55809 glossary: Keep file author and license across import/export 2016-12-08 12:28:22 +08:00
Andrew Nicols a5800adaf0 Merge branch 'MDL-57278-32-5' of https://github.com/xow/moodle into MOODLE_32_STABLE 2016-12-08 10:53:37 +08:00
John Okely c1c3f50965 MDL-57278 signup: Fix double encoding of confirmation links 2016-12-08 10:17:50 +08:00
John Okely cff14cf0d1 MDL-57278 signup: Unit tests covering confirmation link generation 2016-12-08 10:17:50 +08:00
Rajesh Taneja c95ea731bc MDL-57314 behat: Press enter after setting password unmask 2016-12-08 09:24:37 +08:00
Rajesh Taneja b98f14632b MDL-56642 dataformat: Fixed method_exits parameters 2016-12-08 00:37:03 +01:00
Mark Nelson a1e1b45ae7 MDL-57283 core: fixed function call on null 2016-12-07 10:17:36 +00:00
Kenneth Hendricks 2d44bb544b MDL-56674 core: Fix test_get_all_observers 2016-12-07 08:46:04 +00:00
Marina Glancy c60d333578 MDL-56614 behat: corrections to new steps 2016-12-07 14:58:39 +08:00
Andrew Nicols 182690b018 Merge branch 'wip-mdl-56353-m32' of https://github.com/rajeshtaneja/moodle into MOODLE_32_STABLE 2016-12-07 12:03:36 +08:00
Rajesh Taneja b36b54179d MDL-56353 behat: Added test for multi select dependency 2016-12-07 11:19:01 +08:00
Andrew Nicols fc4b768e25 Merge branch 'wip-MDL-56642-32' of git://github.com/marinaglancy/moodle into MOODLE_32_STABLE 2016-12-07 10:00:59 +08:00
Andrew Nicols 7e0f1972f1 Merge branch 'MDL-57266_32' of git://github.com/stronk7/moodle into MOODLE_32_STABLE 2016-12-07 09:54:33 +08:00
Andrew Nicols 93e64c823c Merge branch 'MDL-56240_32' of git://github.com/stronk7/moodle into MOODLE_32_STABLE 2016-12-07 09:51:07 +08:00
Rajesh Taneja 20d598f094 MDL-56614 behat: Fixed steps to use new definition 2016-12-07 09:43:06 +08:00
Marina Glancy e376549179 MDL-56642 dataformat: set temp dir
Thanks to Chien Wen-Chang for proposing a patch
2016-12-07 09:30:25 +08:00
Rajesh Taneja 163a317bcc MDL-57137 behat: Subcategory has black space before name 2016-12-07 09:13:26 +08:00
Dan Poltawski 7ecf13ac1d Merge branch 'MDL-45873_32' of https://github.com/bostelm/moodle into MOODLE_32_STABLE 2016-12-06 15:56:28 +00:00
Ankit Agarwal 2fbe4fca87 MDL-57284 boost: Fix booktool_print icons 2016-12-06 15:50:57 +00:00
Jun Pataleta d07a8ebd7e MDL-57171 admin: Make environment check table look better
* Use Bootstrap label classes for the text under the status column.
* theme_bootstrapbase:
  - Cleanup unnecessary classes and make .error styles consistent
    with .warn styles
* theme_boost:
  - Set font color appropriate for success, warning and error strings.
* Enclose report text in div so that the feedback texts will be
  displayed right below it.
2016-12-06 22:18:55 +08:00
SSRF d4feb70e17 MDL-53677 tool_spamcleaner: CSRF Fix
Resolves minor CSRF within Moodle spamcleaner.
2016-12-06 12:48:31 +00:00
Dan Poltawski f477809e38 Merge branch 'MDL-56836-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2016-12-06 12:46:19 +00:00
Daniel Thee Roperto 94caed45db MDL-56233 forms library: Fixed form identifier when mocking a form.
If the plugin is using namespaces instead of frankenstyle class name,
get_called_class() will return 'type\name' instead of 'type_name'.

Added code to replace backslashes to underscores and fix that issue.
2016-12-06 12:42:17 +00:00
Dan Poltawski 8c4fdb1073 MDL-56778 enrol: add note about legacy css 2016-12-06 12:32:30 +00:00
Nadav Kavalerchik e5bbe44230 MDL-56778 Enrollment: Fix enroll users dialog in RTL mode (theme:Boost) 2016-12-06 12:32:23 +00:00
Tim Hunt d0a58fe035 MDL-57199 question preview: make HTML ids unique 2016-12-06 12:25:45 +00:00
Michael Aherne 9c68157292 MDL-56971 enrol: Use autoloading in enrol_get_plugin() 2016-12-06 11:08:17 +00:00
Grzegorz Ziółek 44f71599df MDL-56830 config_log: Add block plugin visibility changes to config_log. 2016-12-06 11:51:48 +01:00
Alexander Melihov 1fac7b914b MDL-57137 quiz: Create question category with specified parent category
Fix question category generator bug. Now it is possible to specify parent category of subcategory, supply only name of parent category
2016-12-06 15:34:13 +08:00
Tony Butler cede73411f MDL-56346 assignfeedback_editpdf: Correct typo in property name 2016-12-06 14:38:01 +08:00
Andrew Nicols 47deb83b5c Merge branch 'MDL-56301-32' of https://github.com/snake/moodle into MOODLE_32_STABLE 2016-12-06 14:27:03 +08:00
Andrew Nicols 4ea56c1c80 Merge branch 'wip-MDL-56614-m32-2' of https://github.com/marinaglancy/moodle into MOODLE_32_STABLE 2016-12-06 13:38:08 +08:00
Marina Glancy 311121b16c MDL-56614 behat: add navigation block when required
Most of these hacks have links to corresponding MDL issues
2016-12-06 13:35:40 +08:00
Marina Glancy 5863f1b073 MDL-56614 behat: rename step for navigating in the gradebook 2016-12-06 13:35:40 +08:00
Marina Glancy 2bb195f64f MDL-56614 behat: navigate without navigation and admin blocks 2016-12-06 13:35:40 +08:00
Marina Glancy f6b50d9901 MDL-56614 block_navigation: Add block in behat tests 2016-12-06 13:35:39 +08:00
Marina Glancy a0b0234a18 MDL-56614 behat: new steps for navigation without blocks 2016-12-06 13:35:39 +08:00
Andrew Nicols f8b8a363ae Merge branch 'MDL-57161-32' of git://github.com/lameze/moodle into MOODLE_32_STABLE 2016-12-06 13:10:40 +08:00
Donald Barrett b197272987 MDL-56301 course: Use value for intro field if set in a mods function
Respects a module that has set a value for the db field intro in it's lib function modulename_add_instance.
2016-12-06 10:40:49 +08:00
Juan Leyva e4976aefc5 MDL-57255 gradereport_user: Fix default value for graderaw
graderaw is a PARAM_FLOAT, the default to empty string was incorrect
2016-12-06 10:18:53 +08:00
David Monllao dcd408b81f MDL-57161 search: Set the correct HTTP header
All credit goes to Test Valley School
2016-12-06 10:00:07 +08:00
Simey Lameze 4a564ca40b MDL-56759 themes: fix badge list alignment issues 2016-12-06 09:24:31 +08:00
Eloy Lafuente (stronk7) 5da06d632a MDL-57266 upgrade: add 3.2.0 separation line to all upgrade scripts 2016-12-05 17:17:54 +01:00
Eloy Lafuente (stronk7) d797e57255 MDL-56240 upgrade: delete incorrect lines, manually added
Note that, with MDL-57266, we are changine the comment to be:

// Automatically generated Moodle v3.2.0 release upgrade line

in order to make to make to make it clearer that it's an
automatic (part of the release process) comment and should not
be added manually ever.
2016-12-05 16:52:31 +01:00
Frederic Massart 55d2042f0a MDL-56459 competency: Invalid use of indirect property key
This change ensures that PHP7 and earlier work the same way. Before
the patch PHP < 7 would not expand the property as we expected it.

More information here:
http://php.net/manual/en/migration70.incompatible.php#migration70.incompatible.variable-handling.indirect
2016-12-05 15:48:47 +00:00
David Mudrák 8cd6972966 MDL-57256 course: Fix display of the Legacy course files link
The patch fixes the classical operator precedence bug.
2016-12-05 15:45:38 +00:00
Henning Bostelmann 9cbc0a0cdb MDL-45873 mode_data: Allow "0" entries in menu field 2016-12-05 09:21:07 +00:00
John Okely 931d12b589 MDL-54921 signup: Only clear wanturl when necessary
Thanks to Juho Jaakkola for original patch idea.
2016-12-05 15:35:25 +08:00
Shamim Rezaie 0beeb95a8a MDL-52840 assignsubmission_file: Change default setting file size
The default value of the assignsubmission_file/maxbytes setting is changed to $CFG->maxbytes.
2016-12-05 13:02:20 +08:00
Mark Nelson 617f8bb911 MDL-57084 core_message: prevent duplication of day separator 2016-12-05 12:28:56 +08:00
Michael Spall 75dd21a002 MDL-56893 grades: Fix edit grade item when grade_report_showmin is false
Check to make sure $data['grademin'] exists. When grade_report_showmin
is false $data['grademin'] doesn't exist.
2016-12-05 12:05:19 +08:00
Bram Tassyns a0c13477ab MDL-56836 SCORM: player doesn't remember display mode when not logged in 2016-12-05 09:25:31 +08:00
Eloy Lafuente (stronk7) b182239f21 Moodle release 3.2 2016-12-03 14:26:15 +01:00
Eloy Lafuente (stronk7) 9c46f5c6fb NOBUG: Change travis.yml to MOODLE_32_STABLE 2016-12-03 14:26:15 +01:00
Dan Poltawski 1b00e27281 Moodle release 3.2rc5 2016-12-02 15:19:10 +00:00
Dan Poltawski 6a6b1bd782 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-12-02 15:19:09 +00:00
Dan Poltawski 65cc788bb1 Merge branch 'wip-mdl-57232' of https://github.com/rajeshtaneja/moodle 2016-12-02 15:00:48 +00:00
Rajesh Taneja 54348ea6d7 MDL-57232 behat: Add blocks in boost theme
Currently behat in boost depend on blocks
so make sure we have them.
2016-12-02 22:48:13 +08:00
Eloy Lafuente (stronk7) 72edf2ef13 Merge branch 'wip-mdl-57245' of https://github.com/rajeshtaneja/moodle 2016-12-02 14:15:27 +01:00
Rajesh Taneja 43b3cf0f25 MDL-57245 behat: Use correct @_file_upload tag 2016-12-02 19:04:32 +08:00
Eloy Lafuente (stronk7) dadbe55c81 Merge branch 'MDL-57193-master-notest' of git://github.com/FMCorz/moodle 2016-12-02 11:41:02 +01:00
Dan Poltawski 1acd568793 MDL-56553 usertours: fix apostrophe use 2016-12-02 09:22:42 +00:00
Frederic Massart 7fc7486f49 MDL-57193 auth_db: Flip the array outside the loop for better perf
Also as the recent changes where affecting the whitespaces quite
a lot, I took the liberty of aligning a few lines which weren't.
2016-12-02 16:29:47 +08:00
John Okely ec3e79134f MDL-57193 auth_db: Use a recordset and array_key_exists 2016-12-02 16:29:47 +08:00
Josh Willcock 34949c1a55 MDL-57193 auth_db: Fixed bug suspends all users if external DB has > 10k 2016-12-02 16:29:47 +08:00
David Monllao b9278260c7 MDL-56553 usertours: Removing trailing ^M 2016-12-02 16:23:03 +08:00
Ryan Wyllie 1459415f93 MDL-56553 tool_usertours: change add a block step to position right 2016-12-02 07:53:07 +00:00
David Monllao 76e337ab96 Merge branch 'MDL-57232-master' of git://github.com/damyon/moodle 2016-12-02 14:20:17 +08:00
David Monllao 80ee8a3eb0 Merge branch 'MDL-57209-master' of git://github.com/crmpicco/moodle 2016-12-02 13:26:56 +08:00
Damyon Wiese 9d1402abd8 MDL-57232 blocks: Split undeletableblocktypes
There are 2 kinds of blocks that are undeletable. Those required by the
theme and those protected via the admin page ui. We only want the theme
ones to be auto created site wide if they don't exist - so we need to
rename the theme ones and split the logic.
2016-12-02 12:32:03 +08:00
Andrew Nicols 666b9fcb6a MDL-57243 search: Correct todo doc 2016-12-02 10:53:52 +08:00
Andrew Nicols ddcb68b284 Merge branch 'MDL-57243_master' of git://github.com/dmonllao/moodle 2016-12-02 10:49:34 +08:00
David Monllao 5f654ea2c0 MDL-57243 search: Note about search area base classes relocation 2016-12-02 09:51:05 +08:00
Andrew Nicols d8326d8364 MDL-57101 media_videojs: Load legacy events before use 2016-12-02 08:58:19 +08:00
Eloy Lafuente (stronk7) f200f74552 Merge branch 'wip-MDL-57234-master' of https://github.com/Beedell/moodle 2016-12-01 17:58:51 +01:00
John Beedell 6c45e525fc MDL-57234 Quiz report: fix exception in Responses for all users 2016-12-01 16:23:18 +00:00
Dan Poltawski 063d5c28cf Merge branch 'MDL-57220-master' of git://github.com/damyon/moodle 2016-12-01 13:20:15 +00:00
Dan Poltawski a8bac97613 Merge branch 'MDL-57194-master' of git://github.com/lameze/moodle 2016-12-01 12:20:01 +00:00
David Monllao 2b114798b9 Merge branch 'MDL-57210-master' of git://github.com/ryanwyllie/moodle 2016-12-01 16:12:25 +08:00
Andrew Nicols 53cbfac2b9 Merge branch 'MDL-57101-master-fixup' of https://github.com/FMCorz/moodle 2016-12-01 15:07:42 +08:00
Frederic Massart b52c562a8c MDL-57101 media_videojs: Dynamic loader works on self-matching nodes 2016-12-01 14:51:40 +08:00
Frederic Massart 36e6789b27 MDL-57101 filter: Load globally available filters on every page
Previous commits were overlooked, they should have passed the
system context to filter_manager::setup_page_for_fitlers(), the
page context was passed instead. Regardless, the processing of
the latter is too excessive for what we need, but, more importantly,
it does not return "Off, but available" filters which we also need.
2016-12-01 14:51:40 +08:00
Frederic Massart 39a9ac4098 MDL-57101 core_media: Only instantiate enabled plugins 2016-12-01 14:50:04 +08:00
Simey Lameze 7d17256a75 MDL-57194 core_charts: Allow colors to be overridden by setting 2016-12-01 14:44:00 +08:00
Andrew Nicols 8f5de6f268 Merge branch 'MDL-56553-master-2' of git://github.com/ryanwyllie/moodle 2016-12-01 14:31:45 +08:00
Andrew Nicols 1f16e4e68e Merge branch 'MDL-57219-master' of git://github.com/damyon/moodle 2016-12-01 13:30:23 +08:00
Andrew Nicols 995c6d2787 Merge branch 'MDL-57206-master' of https://github.com/snake/moodle 2016-12-01 12:21:25 +08:00
David Monllao bb8b3ba6f8 Merge branch 'wip-mdl-57229' of https://github.com/rajeshtaneja/moodle 2016-12-01 11:38:59 +08:00
Rajesh Taneja 04bfccdce6 MDL-57229 enrol: Enrol dialog should have relative position
On clean theme it is absolute position and on small
screen user can't scroll to enrol user
2016-12-01 11:13:46 +08:00
Ryan Wyllie 3cc12bd747 MDL-57210 theme_boost: fix header buttons on smaller resolutions 2016-12-01 02:21:25 +00:00
Damyon Wiese e7d0de87c9 MDL-57219 blocks: Dont create and empty block for spacing
Change box to an empty container. We are after tiny tiny changes ATM.
2016-12-01 10:12:29 +08:00
Damyon Wiese ef06bc18b0 MDL-57220 boost: Fix for date selector inline template
It was putting the label on a separate line.
2016-12-01 09:48:59 +08:00
Damyon Wiese 52ee200368 MDL-57220 boost: minimal fix for radio button template
It still does not match
http://v4-alpha.getbootstrap.com/components/forms/#radios
but I don't want to make radical changes before 3.2 release.
2016-12-01 09:48:06 +08:00
Ryan Wyllie 10df630ee8 MDL-56553 tool_usertours: add admin and course tours 2016-12-01 00:44:29 +00:00
Ryan Wyllie 3eb3d916cb MDL-56553 tool_usertours: allow tours to be shipped with Moodle 2016-12-01 00:36:02 +00:00
Jake Dallimore bb316e0764 MDL-57206 core: describe newly introduced hooks in upgrade.txt
Added a description and example for the
<component>_course_module_background_deletion_recommended hook.
2016-12-01 08:25:28 +08:00
AMOS bot 5544189dd1 Automatically generated installer lang files 2016-12-01 00:05:38 +08:00
AMOS bot 09ade73632 Merge branch 'master' into install_master 2016-12-01 00:05:38 +08:00
Dan Poltawski ce7149b10c MDL-57197 js: fix AMD module warnings
In 3.2 we are free of AMD lint warnings, unfortunately we can't expose
them through grunt yet due to
"File ignored because of a matching ignore pattern. Use "--no-ignore" to
override"

ps. this isn't related to MDL-57197 at all, i'm just a Rebel
2016-11-30 13:50:38 +00:00
Dan Poltawski 5814817ceb Merge branch 'MDL-57169_master' of git://github.com/markn86/moodle 2016-11-30 11:04:38 +00:00
Dan Poltawski a9b85245f2 Merge branch 'MDL-52199-incoming-nice-fail' of https://github.com/brendanheywood/moodle 2016-11-30 09:52:35 +00:00
Dan Poltawski 10461a04c6 Merge branch 'MDL-57207-master' of git://github.com/cameron1729/moodle 2016-11-30 09:51:21 +00:00
Cameron Ball 9a22c99ea9 MDL-57207 mod_lti: Remove redundant popover() call
Since MDL-56748 popovers are properly delegated. Making manual calls
to .popover redundant.
2016-11-30 17:45:41 +08:00
Andrew Nicols b95107ca83 Merge branch 'MDL-57205-master' of git://github.com/damyon/moodle 2016-11-30 15:03:43 +08:00
Andrew Nicols 432ed35484 Merge branch 'MDL-57127-master' of git://github.com/FMCorz/moodle 2016-11-30 14:27:23 +08:00
David Monllao f4aec377fc Merge branch 'MDL-56682_master' of git://github.com/markn86/moodle 2016-11-30 13:56:08 +08:00
David Monllao 99d2667f5c Merge branch 'MDL-57072-master' of git://github.com/junpataleta/moodle 2016-11-30 13:36:32 +08:00
Andrew Nicols a57699ead8 Merge branch 'MDL-57177-master' of git://github.com/cameron1729/moodle 2016-11-30 13:15:58 +08:00
Craig R Morton f6f0cb49aa MDL-57209 forms: Notice: Undefined index: options in profile edit page
Skipping a loop iteration if the option group has no options.
2016-11-30 13:08:56 +08:00
Frederic Massart 061a39ac5d MDL-57127 output: Increase memory limit when parsing CSS 2016-11-30 12:19:03 +08:00
Andrew Nicols 3f342da584 Merge branch 'MDL-57101-master-2nd' of git://github.com/FMCorz/moodle 2016-11-30 12:13:54 +08:00
David Monllao 4495ddcf9f Merge branch 'MDL-56955-master' of git://github.com/lameze/moodle 2016-11-30 11:34:29 +08:00
Simey Lameze 45cd101f80 MDL-56955 theme_boost: fix login failure displaying on user menu 2016-11-30 11:32:38 +08:00
David Monllao c5a5f26ce2 Merge branch 'MDL-57090-master' of git://github.com/ankitagarwal/moodle 2016-11-30 10:43:16 +08:00
Damyon Wiese 7c0725857a MDL-57205 forms: Prevent debugging in selectgroups
Sometimes the option group has no options I guess. The same check is in
exportValue.
2016-11-30 10:38:51 +08:00
Andrew Nicols 70f0e8353d Merge branch 'wip-MDL-57186-master' of https://github.com/marinaglancy/moodle 2016-11-30 10:20:31 +08:00
David Monllao 8c291fb06e Merge branch 'wip-MDL-56829-master-2' of git://github.com/marinaglancy/moodle 2016-11-30 10:05:16 +08:00
David Monllao 449b730e09 Merge branch 'MDL-57095-master' of git://github.com/ryanwyllie/moodle 2016-11-30 09:26:07 +08:00
Andrew Nicols 8018dc63c7 Merge branch 'MDL-57174_master' of git://github.com/markn86/moodle 2016-11-30 09:12:54 +08:00
Jun Pataleta 8ace7b6c34 MDL-57072 theme_boost: Render action menu for category management 2016-11-30 09:11:32 +08:00
Eloy Lafuente (stronk7) 3f083d9a33 MDL-57197 versions: main version bump 2016-11-29 22:58:22 +01:00
Eloy Lafuente (stronk7) 04649747a4 MDL-57197 versions: bump all versions and requires near release
version = 2016120500 release version
requires= 2016112900 current rc4 version
2016-11-29 22:57:05 +01:00
Eloy Lafuente (stronk7) eb80018202 Merge branch 'MDL-57133-master-enfix' of git://github.com/mudrd8mz/moodle 2016-11-29 22:36:29 +01:00
AMOS bot f3317a0eac Automatically generated installer lang files 2016-11-30 00:04:41 +08:00
Dan Poltawski a0352aa95e Moodle release 3.2rc4 2016-11-29 13:33:15 +00:00
Dan Poltawski d5d1d56f9c Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-11-29 13:33:13 +00:00
David Mudrák 1270616023 MDL-56800 theme_boost: Radios should not have name if soft frozen, too 2016-11-29 11:32:28 +00:00
Andrew Nicols 06ded0ed5f MDL-56800 theme_boost: Remove name from hardFrozen radio 2016-11-29 08:11:31 +00:00
Ryan Wyllie c22141bd0c MDL-57095 theme: fix content styling for notification page 2016-11-29 07:14:05 +00:00
Marina Glancy 6f19da0549 MDL-57186 media: fix link in security report 2016-11-29 13:54:49 +08:00
Andrew Nicols 220f3ac711 MDL-56858 theme_boost: Correct bad merge conflict 2016-11-29 13:49:18 +08:00
David Monllao 1e102ca3ca Merge branch 'wip-mdl-57168-m1' of git://github.com/rajeshtaneja/moodle 2016-11-29 13:41:55 +08:00
David Monllao 7621fe8399 Merge branch 'MDL-57158-int-fix-1' of github.com:ryanwyllie/moodle 2016-11-29 13:36:52 +08:00
Damyon Wiese 0d5f5f7357 MDL-57124 boost: I want really tiny logos.
Said no-one ever.

Use max-height so very small logos will not be scaled up.
2016-11-29 13:21:35 +08:00
Marina Glancy 7d94f001e2 MDL-56829 media_videojs: play inline on iPhone with ios 10 2016-11-29 13:02:31 +08:00
Frederic Massart e37c128686 MDL-57101 filter: Always set-up the page for filters 2016-11-29 12:36:28 +08:00
Frederic Massart a174f2474f MDL-57101 media_videojs: Set-up player on dynamically loaded content 2016-11-29 12:36:26 +08:00
Andrew Nicols 805659e1fa Merge branch 'MDL-56919-master' of git://github.com/junpataleta/moodle 2016-11-29 12:06:56 +08:00
Jun Pataleta 01dc1c11ec MDL-56919 mod_forum: Assign check icon for selected subscription mode 2016-11-29 12:03:34 +08:00
Andrew Nicols 740dbe77a2 Merge branch 'MDL-56858_master-alt-2' of git://github.com/markn86/moodle 2016-11-29 11:52:32 +08:00
David Monllao 8b516a6a55 Merge branch 'MDL-57163_master' of git://github.com/dmonllao/moodle 2016-11-29 11:46:55 +08:00
David Monllao 4a1165ba39 MDL-57163 install: Check curl availability before curl_version() 2016-11-29 11:46:06 +08:00
David Herney 5634310997 MDL-57169 backup: ensure images in category descriptions are shown 2016-11-29 11:40:47 +08:00
Rajesh Taneja 9eb8f6ec56 MDL-57168 behat: Don't press continue as it will go to Annotate PDF
This might cause random failures as the draft files are being accessed by other user
2016-11-29 10:53:02 +08:00
David Monllao dc3e3c0831 Merge branch 'MDL-57097-master' of git://github.com/lameze/moodle 2016-11-29 10:51:10 +08:00
Cameron Ball d91cbe1e62 MDL-57177 theme_boost: Use regular ! for advanced form fields
Previously we used U+2757 on advanced form fields, which was problematic
as it's part of emoji and displays differently on different platforms.
This is a problem since we explicitly style it to be blue, but, for
example on OS X it's red (since it gets replaced with their emoji).
2016-11-29 10:48:38 +08:00
Mark Nelson 8599ac9e56 MDL-57174 mod_lesson: show settings menu on edit.php page 2016-11-29 10:24:55 +08:00
Damyon Wiese 4d41cec8db MDL-57124 boost: Show pageheaderbutton when no navbar
Even if there is no navbar - if there is a pageheaderbutton we need to
show it (E.g. Customise this page on dashboard).
2016-11-29 10:07:16 +08:00
David Mudrák 5e45c34221 MDL-57133 lang: Reword the strings in Behat tests too 2016-11-29 01:59:31 +01:00
Helen Foster 67823776a0 MDL-57133 lang: Merge English strings from the en_fix language pack 2016-11-29 01:49:28 +01:00
Ryan Wyllie 12f7202177 MDL-57158 theme: add margin for icon in pull right menu 2016-11-29 00:34:44 +00:00
Rajesh Taneja 8392a86068 MDL-57168 behat: Check for button not text 2016-11-29 07:36:43 +08:00
Mark Nelson dc801cb6b9 MDL-56858 theme_boost: separate input description and label
Also added missing advanced and required form symbols.
2016-11-28 18:24:16 +08:00
Mark Nelson 4a8c6b4259 MDL-56682 mod_assign: ensure the variable is not null 2016-11-28 16:47:00 +08:00
Dan Poltawski 1cbc346092 Merge branch 'MDL-57176-master' of git://github.com/damyon/moodle 2016-11-28 08:30:37 +00:00
David Monllao c56c23720b Merge branch 'MDL-57124-master' of git://github.com/damyon/moodle 2016-11-28 15:22:46 +08:00
Damyon Wiese 7ad1d2da47 MDL-57124 Boost: Login page styles (and signup)
Center logo / site name.
Add padding to logo / site name.
Serve retina images and resize with css.
Add a line under the logo / site name.
Don't show site name if there is a logo.
Obey nonavbar option in core_renderer.
2016-11-28 15:20:35 +08:00
Ankit Agarwal 3d1be67752 MDL-57090 hubs: Replace smart select with searchableselect 2016-11-28 12:22:25 +05:30
Damyon Wiese 58ec5a315b MDL-57176 blocks: Never never never dup blocks
Dont create duplicate blocks 'requiredbytheme' for any reason.
2016-11-28 14:48:02 +08:00
David Monllao 6ee691d71b Merge branch 'MDL-57158-master' of git://github.com/ryanwyllie/moodle 2016-11-28 14:39:22 +08:00
Ryan Wyllie 60ff24c0f1 MDL-57158 theme: fix icon margin in action menus 2016-11-28 06:37:08 +00:00
David Monllao c811356efb Merge branch 'MDL-57156-master' of https://github.com/snake/moodle 2016-11-28 14:00:50 +08:00
Vladimir Zhirov acefc7d963 MDL-57163 installation: fixed "Call to undefined function curl_version" 2016-11-28 13:25:41 +08:00
David Monllao f59bab60c0 Merge branch 'wip-mdl-57168' of https://github.com/rajeshtaneja/moodle 2016-11-28 12:59:11 +08:00
Rajesh Taneja 47b03b9170 MDL-57168 behat: Fixed xpath to ensure active link is checked 2016-11-28 12:57:56 +08:00
Rajesh Taneja d442a3169c MDL-57168 behat: Return link is the existing category 2016-11-28 12:57:56 +08:00
Rajesh Taneja 3df6e801b5 MDL-57168 behat: Ensure drawer is open before clicking the link 2016-11-28 12:57:55 +08:00
David Monllao 920778eb93 Merge branch 'MDL-56619-master' of git://github.com/ryanwyllie/moodle 2016-11-28 12:45:46 +08:00
David Monllao d826c64c57 Merge branch 'wip-mdl-57147' of https://github.com/rajeshtaneja/moodle 2016-11-28 12:40:27 +08:00
David Monllao 085e077fa3 Merge branch 'MDL-57146-master' of git://github.com/damyon/moodle 2016-11-28 12:15:30 +08:00
Ryan Wyllie 341da3e3fb MDL-56619 theme: filemanager_selectlayout bootstrap 4 form styling 2016-11-28 03:42:40 +00:00
Jake Dallimore 0395ec28e2 MDL-57156 themes: override caption alignment in theme boost 2016-11-28 11:35:11 +08:00
David Monllao dd106016ee Merge branch 'MDL-57122-master' of git://github.com/ankitagarwal/moodle 2016-11-28 11:31:05 +08:00
Ankit Agarwal 2adf5ef946 MDL-57122 boost: Don't escape strings twice
Strings should always be escaped in templates not before
2016-11-28 08:22:41 +05:30
Ankit Agarwal 6c4aba1e7e MDL-57122 boost: Add context docs to login template 2016-11-28 08:22:41 +05:30
Jun Pataleta 894b1825f6 MDL-56919 boost: Render non-action menu items as disabled action links 2016-11-28 10:20:18 +08:00
Jun Pataleta 27a3843d05 MDL-56919 templates: action_link template fixes when disabled
For the case where the action_link template is shown as disabled:
* Allow extra classes to be set on on the class attribute.
* Allow extra attributes to be set.
2016-11-28 10:20:18 +08:00
Rajesh Taneja 96813571b1 MDL-57147 phpunit: Check if time is greater than or equal to
Some windows only have 1/100 microtime resolution
so a lot of times it does not advance enough.
2016-11-28 09:40:21 +08:00
AMOS bot c1722505e1 Automatically generated installer lang files 2016-11-27 00:05:45 +08:00
Dan Poltawski 39f621305d Merge branch 'MDL-57134-master' of git://github.com/lameze/moodle 2016-11-25 12:35:17 +00:00
Dan Poltawski 1f5fbd1696 Merge branch 'wip-mdl-56659' of https://github.com/rajeshtaneja/moodle 2016-11-25 11:17:36 +00:00
Dan Poltawski cdef9e91a3 Merge branch 'MDL-56800-master-radio' of git://github.com/mudrd8mz/moodle 2016-11-25 10:44:19 +00:00
David Monllao 3eabedbb92 Moodle release 3.2rc3 2016-11-25 15:58:02 +08:00
David Monllao 9441af9596 NOBUG: Fixed file access permissions 2016-11-25 15:58:02 +08:00
David Monllao c08a263134 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-11-25 15:58:01 +08:00
Marina Glancy 392367c4f7 MDL-56586 behat: fix behat tests to work with new add block 2016-11-25 14:04:10 +08:00
Rajesh Taneja 350d0ae6b7 MDL-56659 core: Enable password field when label is clicked 2016-11-25 12:09:37 +08:00
Rajesh Taneja dfa707c994 MDL-56659 core: No need for noscript tag and set size later
1. BrowserKitDriver::setValue only checks if the element is
   disabled. It still is able to set value on hidden elements
   So there is no need for noscript tag in password unmask
2. Set size on hidden field is not valid html, so set it later
   when text element is displayed
2016-11-25 12:09:37 +08:00
David Monllao 0d9d55a3ad Merge branch 'MDL-56584-master-fix1' of http://github.com/damyon/moodle 2016-11-25 11:15:32 +08:00
David Monllao b4f82837ba Merge branch 'MDL-55324-master-fix' of git://github.com/cameron1729/moodle 2016-11-25 11:11:20 +08:00
David Monllao bae517c616 Merge branch 'MDL-57094-int-patch-1' of github.com:ryanwyllie/moodle 2016-11-25 10:52:00 +08:00
David Monllao b68af8e6f8 Merge branch 'MDL-56801-master' of git://github.com/lameze/moodle 2016-11-25 10:40:39 +08:00
Ryan Wyllie af46d1dd23 MDL-57094 admin_tool: fix subscription behat tests 2016-11-25 02:24:33 +00:00
David Monllao b35c209d76 MDL-56551 calendar: Update behat test according to DOM changes 2016-11-25 10:06:36 +08:00
Damyon Wiese a1e8265d48 MDL-57146 boost: New tabbed settings page missing branch links
Branches that are also links were not showing as links.
2016-11-25 10:00:22 +08:00
David Monllao b71149c9ac Merge branch 'MDL-56761-master' of git://github.com/ryanwyllie/moodle 2016-11-25 09:36:17 +08:00
Damyon Wiese 262253f624 MDL-56584 boost: Use tabindex-1 on nav drawer
Also use aria-hidden on unicode symbol for hamburger.
2016-11-25 09:27:17 +08:00
David Monllao c15f993cde Merge branch 'wip-mdl-56898-fix4' of https://github.com/rajeshtaneja/moodle 2016-11-25 09:24:24 +08:00
Rajesh Taneja d2a44a71ac MDL-56898 behat: Focus only works with JS 2016-11-25 09:20:52 +08:00
David Monllao 92fa8b8fde Merge branch 'MDL-57126-master' of https://github.com/snake/moodle 2016-11-25 09:18:26 +08:00
David Monllao 29c96d214b Merge branch 'MDL-55857-master' of git://github.com/danpoltawski/moodle 2016-11-25 08:46:04 +08:00
Marina Glancy 1adf21fc1d MDL-57019 behat: corrections to the selectors, adding waiting 2016-11-25 08:38:24 +08:00
Jake Dallimore d714aeb4f5 MDL-57126 core: add 'scss' to list of core filetypes.
This allows filetype restrictions to work when uploading additional
preset files on the Boost admin settings page.
2016-11-25 07:53:59 +08:00
David Mudrák c03f1de198 MDL-56800 theme_boost: Clean up rendering of the radio buttons
The <input type="radio"> element does not support the size attribute so
there is no point of rendering it. Also fixed the example data as the
field name must not contain any whitespace.
2016-11-24 23:50:21 +01:00
David Mudrák edd837038a MDL-56800 theme_boost: Display frozen form's radios as disabled
For frozen (read-only) forms, the radio widget was not displayed at all
and only the legend text was displayed. So it was not possible to see
which one of the radios in a group was selected.

This patch mimics the original quick form rendering and displays the
radio as disabled.
2016-11-24 23:47:39 +01:00
Dan Poltawski ad76556b76 Merge branch 'MDL-56948-master' of https://github.com/lucisgit/moodle 2016-11-24 15:58:05 +00:00
Dan Poltawski 9cc9690575 Merge branch 'MDL-57102-master' of git://github.com/jleyva/moodle 2016-11-24 10:43:21 +00:00
Dan Poltawski b001cd4b17 Merge branch 'MDL-56431-filter-fix' of git://github.com/abgreeve/moodle 2016-11-24 09:45:53 +00:00
Dan Poltawski 74b8557661 Merge branch 'MDL-57013_master' of https://github.com/nadavkav/moodle 2016-11-24 09:44:32 +00:00
Adrian Greeve 72a5842bd7 MDL-56431 messaging: Added aria label to filter.
Added an aria label to the course filter in the
messaging page.
2016-11-24 17:33:22 +08:00
Dan Poltawski 304e8a8d0c Merge branch 'wip-MDL-56586-master-2' of git://github.com/marinaglancy/moodle 2016-11-24 09:30:29 +00:00
Dan Poltawski c5c8f3a6f5 Merge branch 'MDL-57118-master' of git://github.com/damyon/moodle 2016-11-24 09:26:52 +00:00
Marina Glancy 86ac6a3763 MDL-57019 behat: make tab navigation compatible with boost 2016-11-24 16:47:00 +08:00
Simey Lameze 539de849cd MDL-57134 core_badges: add missing badgeslib.php include 2016-11-24 16:45:17 +08:00
David Monllao 68dde67d9f Merge branch 'MDL-57094-master' of git://github.com/ryanwyllie/moodle 2016-11-24 15:53:26 +08:00
David Monllao 8b81daf4dd Merge branch 'MDL-56429-master' of git://github.com/ryanwyllie/moodle 2016-11-24 15:47:31 +08:00
David Monllao 4de871f4ca Merge branch 'MDL-57001-master' of git://github.com/damyon/moodle 2016-11-24 15:29:04 +08:00
Damyon Wiese a955cf531c MDL-57118 boost: Participants cog shows too much
Because 0 == 'participants' in php.
2016-11-24 15:27:17 +08:00
Andrew Nicols 9a102866be Merge branch 'MDL-56564-master-2' of git://github.com/junpataleta/moodle 2016-11-24 15:22:12 +08:00
David Monllao 8411e0a508 Merge branch 'wip-mdl-56797' of https://github.com/rajeshtaneja/moodle 2016-11-24 15:19:18 +08:00
Ryan Wyllie 1fb687ea8f MDL-56761 theme: fix RTL styling for hover tooltip 2016-11-24 07:12:46 +00:00
Damyon Wiese 2fedc0da7c MDL-57001 roles: Do access check for switchroles
Put it in the API so it can't be skipped.
2016-11-24 15:11:19 +08:00
Damyon Wiese 7dba450fd4 MDL-57001 user_menu: Hide switch roles students
Check that there are switchable roles before showing the link in the user menu.
2016-11-24 15:11:19 +08:00
Damyon Wiese 22b8c5b842 MDL-57001 user_menu: Fixes for unit tests
We added a link to the user menu so we have to adjust the tests.
2016-11-24 15:11:19 +08:00
Damyon Wiese 8c224317ee MDL-57001 switchroles: Add a cancel link to the page. 2016-11-24 15:11:19 +08:00
Damyon Wiese 70b03eff02 MDL-57001 switchroles: Move to user menu
Take this out of the navigation and force it in the user menu.
2016-11-24 15:11:19 +08:00
Damyon Wiese 7095f5be97 MDL-57001 usermenu: Add switch role to the bottom of the user menu 2016-11-24 15:11:19 +08:00
Andrew Nicols 4213f7e236 Merge branch 'wip-MDL-57019-fix' of https://github.com/marinaglancy/moodle 2016-11-24 15:09:43 +08:00
Simey Lameze 45d5594ecb MDL-56801 theme_boost: remove registration_textfield rule
The registration_textfield conflicts with the form default styling and breaks form layout.
2016-11-24 14:40:38 +08:00
Marina Glancy bf07b81543 MDL-56586 blocks: use template for non-JS add block selector 2016-11-24 14:24:59 +08:00
Damyon Wiese be2247fb24 MDL-56586 blocks: Do the addblock in a modal 2016-11-24 14:24:59 +08:00
Marina Glancy b1e5624ad9 MDL-56586 blocks: Fix mess with links to permissions
problem 1: links to blocks permissions changes were missing in boost
problem 2: when modifying link from dashboard user is returned to profile ('returnurl' passed but not respected)
problem 3: link to check permissions missing from category management page
fix: instead of respecting both 'return' and 'returnurl' parameter use only 'returnurl'
fix: use 'popup' layout when modifying permissions for a block
2016-11-24 14:24:59 +08:00
Marina Glancy b11916d3e7 MDL-56586 blocks: allow theme to manage "Add a block" select 2016-11-24 14:24:56 +08:00
Ryan Wyllie de4ca62e7a MDL-56429 theme: add margin to processor settings form controls
Add a top margin to the form controls in the processor settings modal on
the notification preferences page to separate the content from the
controls.
2016-11-24 06:12:27 +00:00
Marina Glancy b0842f61f4 MDL-57019 behat: new step to navigate to gradebook section 2016-11-24 12:46:27 +08:00
Cameron Ball 4d85886b5f MDL-55324 atto_media: Reduce maximum height of atto modal
Previously after adding a few sources or expanding a few fieldsets
the modal would be pushed off the bottom of the screen. Here we
reduce the maximum height to allow it to remain visible.
2016-11-24 12:31:30 +08:00
David Monllao 692c1bf345 Merge branch 'MDL-56391_master-fix' of https://github.com/markn86/moodle 2016-11-24 11:28:00 +08:00
Mark Nelson bb3a1d6f39 MDL-56391 core_user: fixed failing behat 2016-11-24 11:24:32 +08:00
Simey Lameze b6f549d139 MDL-57097 mod_assign: add event listener to avoid form submit 2016-11-24 11:24:25 +08:00
Jun Pataleta 144c149704 MDL-56564 mod_lti: Reset fields before updating tool matches 2016-11-24 11:09:03 +08:00
Andrew Nicols 2ecb3ffa97 Merge branch 'wip-mdl-56898-fix3' of https://github.com/rajeshtaneja/moodle 2016-11-24 11:08:55 +08:00
David Monllao fa42b7bc69 Merge branch 'MDL-57069_master' of git://github.com/markn86/moodle 2016-11-24 11:04:28 +08:00
Cameron Ball e24699cc7a MDL-55324 atto_media: Preserve help text when adding sources 2016-11-24 10:55:05 +08:00
David Monllao ff8b71ef7b Merge branch 'MDL-56871_master' of git://github.com/markn86/moodle 2016-11-24 09:53:45 +08:00
David Monllao 55f8edfdf2 Merge branch 'MDL-56993-master' of git://github.com/damyon/moodle 2016-11-24 09:50:31 +08:00
David Monllao 654efef456 Merge branch 'MDL-56551-master' of git://github.com/damyon/moodle 2016-11-24 09:47:18 +08:00
Andrew Nicols 65f0ef9e34 Merge branch 'wip-mdl-57112' of https://github.com/rajeshtaneja/moodle 2016-11-24 08:43:45 +08:00
Rajesh Taneja febbb9f8cd MDL-57112 behat: Social activity block is by default present 2016-11-24 07:45:55 +08:00
Rajesh Taneja 8c35e49b37 MDL-56898 behat: No need to trigger error, as it sometimes hangs behat 2016-11-24 07:31:38 +08:00
Rajesh Taneja b3502be320 MDL-56898 behat: Ensure we have button in viewport and page is stable 2016-11-24 07:27:19 +08:00
Juan Leyva 851b291998 MDL-57102 tool_mobile: Return launchurl when sign-up enabled 2016-11-23 19:35:08 +00:00
Juan Leyva 813320fbb6 MDL-57102 auth: Add new signup_is_enabled function
And apply the function in:
- login/signup.php
- blocks/login/block_login.php
2016-11-23 19:35:08 +00:00
Damyon Wiese 9d44510d60 MDL-57100 JS: Exceptions give exceptions
Exceptions returned from ajax are not in the format expected by the JS, so
an error occurs and the exception popups are not appearing.
2016-11-23 18:07:26 +00:00
Dan Poltawski 4b287476f3 Merge branch 'MDL-53964' of https://github.com/timhunt/moodle 2016-11-23 16:07:28 +00:00
AMOS bot c61d7c0802 Merge branch 'master' into install_master 2016-11-24 00:06:13 +08:00
Dan Poltawski 183b1d6785 MDL-56995 boost: fix css lint warning 2016-11-23 15:47:12 +00:00
Dan Poltawski 2a55269ce8 Merge branch 'MDL-56584-master' of git://github.com/damyon/moodle 2016-11-23 15:44:29 +00:00
Dan Poltawski 2ec4ed4dba Merge branch 'MDL-56995-master' of git://github.com/damyon/moodle 2016-11-23 15:07:26 +00:00
Damyon Wiese 242997744d MDL-56995 boost: Hide navigation for print media
Hide the navigation elements, flat navigation settings menus etc when
printing.
2016-11-23 22:32:20 +08:00
Dan Poltawski 203f51d627 MDL-57064 tests: update externallib test 2016-11-23 13:00:29 +00:00
Dan Poltawski 9f82774a8b Merge branch 'MDL-57064-master' of git://github.com/FMCorz/moodle 2016-11-23 12:46:18 +00:00
Dan Poltawski c8012422eb Merge branch 'MDL-35949' of https://github.com/timhunt/moodle 2016-11-23 12:31:22 +00:00
Dan Poltawski 68153d5cbc Merge branch 'MDL-56564-master-2' of git://github.com/junpataleta/moodle 2016-11-23 11:27:20 +00:00
Dan Poltawski be58f604b5 Merge branch 'MDL-57112-master' of git://github.com/cameron1729/moodle 2016-11-23 10:34:33 +00:00
Dan Poltawski 93b68886e9 Merge branch 'MDL-57093-master' of git://github.com/ryanwyllie/moodle 2016-11-23 10:32:01 +00:00
Dan Poltawski fd111ccabf MDL-57061 boost: build js 2016-11-23 10:23:02 +00:00
Dan Poltawski 2664ef1861 Merge branch 'MDL-57061-master' of git://github.com/FMCorz/moodle 2016-11-23 10:18:48 +00:00
Adrian Greeve 58c2684db2 MDL-56431 messaging: Set focus to the write a message box. 2016-11-23 09:13:51 +00:00
Adrian Greeve d14207fd25 MDL-56431 messaging: Adding access to messaging.
This adds the most crucial elements needed for making
the messaging page accessible. There are still some other
areas that need addressing.
2016-11-23 09:13:50 +00:00
Damyon Wiese c0f89860ec MDL-56993 boost: Add behat tests for boost nav menus 2016-11-23 16:47:25 +08:00
Mark Nelson cb8057531f MDL-56871 core_message: fix inconsistent online status between panels 2016-11-23 16:32:46 +08:00
Dan Poltawski 19d8b0f9e1 Merge branch 'MDL-56182-master' of git://github.com/FMCorz/moodle 2016-11-23 08:26:38 +00:00
Cameron Ball 1b367ac6e8 MDL-57112 blocks: Add back social_activities block for social courses.
Courses in the social format are difficult to use. This patch
simply adds back the social activities block to the social
course format.
2016-11-23 16:06:37 +08:00
Andrew Nicols a954685767 Merge branch 'MDL-56988-master' of git://github.com/lameze/moodle 2016-11-23 15:53:49 +08:00
Andrew Nicols 020fb9d2dc Merge branch 'MDL-56733-master' of git://github.com/ankitagarwal/moodle 2016-11-23 15:50:38 +08:00
Ankit Agarwal 2c0dfa7d33 MDL-56733 boost: Add a preset repo link 2016-11-23 13:14:48 +05:30
Damyon Wiese ea5084f7f1 MDL-56993 boost: Fix navigation for singleactivity format
The single activity course format has no course front page, so we need
to make a special case for it so it's possible to get to the course
admin menu and put the course nodes in the flat navigation.
2016-11-23 15:31:27 +08:00
Simey Lameze 270b2e443c MDL-56988 report: review and apply boosty styles to all reports 2016-11-23 15:30:32 +08:00
Mark Nelson afa68a8174 MDL-57069 core_message: prevent past messages being loaded 2016-11-23 14:26:14 +08:00
Andrew Nicols 2a58fef860 Merge branch 'MDL-57059-master' of git://github.com/lameze/moodle 2016-11-23 14:15:42 +08:00
David Monllao d062d64fb8 Merge branch 'MDL-56116-master' of git://github.com/FMCorz/moodle 2016-11-23 14:01:48 +08:00
Frederic Massart 862816eec3 MDL-56116 theme_boost: Improve developer documentation related to themes 2016-11-23 13:55:28 +08:00
Ryan Wyllie b487a7c028 MDL-57094 message: change view more link in notification popover 2016-11-23 05:54:07 +00:00
Simey Lameze bea19e0dec MDL-57059 theme_boost: add rule to fix slot number misalignment 2016-11-23 13:37:55 +08:00
Jun Pataleta 1b669ebeba MDL-56564 mod_lti: External tool form fixes
* Revert disabling of the Preconfigured tool field on edit mode
* Reset LTI tool configuration fields when selecting a different
  preconfigured tool.
* Behat fixes for UI changes.
2016-11-23 13:10:51 +08:00
Frederic Massart e0c5ffb681 MDL-57061 theme_boost: Focus the invalid form elements on error 2016-11-23 12:11:57 +08:00
Andrew Nicols 5bda9fe900 Merge branch 'MDL-55324-master' of git://github.com/cameron1729/moodle 2016-11-23 12:09:46 +08:00
Cameron Ball 28e93cc41b MDL-55324 atto_media: Implement HTML compliant media plugin
This patch completely reworks the atto media plugin to allow
insertion of HTML media elements.
2016-11-23 11:57:33 +08:00
Cameron Ball a60a98d900 MDL-55324 filepicker: Explicitly set callback from showFilePicker
Prior to this patch the callback passed to showFilePicker was saved
and reused for subsequent calls. This doesn't allow the use of a function
for generating the callback.

This patch explicitly sets the callback each time.
2016-11-23 11:56:40 +08:00
Andrew Nicols 44cf94a877 Merge branch 'wip-MDL-57019-master' of git://github.com/marinaglancy/moodle 2016-11-23 11:54:16 +08:00
David Monllao d5c2829b06 MDL-56902 version: Triggering a major upgrade 2016-11-23 11:50:26 +08:00
David Monllao b3440a13cc Merge branch 'MDL-56902-master-fix1' of http://github.com/damyon/moodle 2016-11-23 11:48:44 +08:00
Ryan Wyllie 52aeda247c MDL-57093 forum: less specific unread styling
Changed the CSS for unread styling to no longer use ids because the
rules are too specific and override other elements with the .unread
class on the forum pages.
2016-11-23 03:40:30 +00:00
Damyon Wiese 48489fb93a MDL-56551 calendar: cibot fixes from this issue 2016-11-23 11:25:57 +08:00
Damyon Wiese 7ee4a28719 MDL-56551 calendar: Events list fixes for boost
The events list is now a list of cards with headers.
Spacing and layout is now done with bootstrap utility classes.
The existing classes were kept - and the styles for bootstrapbase are not changed much.
Also calendar colours can be overridden from a preset.
2016-11-23 11:25:52 +08:00
Damyon Wiese 1ac36fa9f7 MDL-56902 blocks: No theme blocks if fake blocks only
When showing only fake blocks, never auto create the blocks for the
theme. This would give you double blocks.
2016-11-23 11:07:32 +08:00
Frederic Massart 6b7e523b5d MDL-56182 mod_lti: Include the query string when comparing type URLs 2016-11-23 10:16:50 +08:00
David Monllao 8fb1b3bb68 Merge branch 'MDL-56391_master' of git://github.com/markn86/moodle 2016-11-23 09:49:03 +08:00
Dan Poltawski 3fd840072f MDL-56988 report: attempt to improve styling of reports 2016-11-23 08:50:06 +08:00
David Monllao 44c3d0775c Merge branch 'MDL-56902-master' of git://github.com/damyon/moodle 2016-11-23 08:29:41 +08:00
David Monllao 111d6b8f24 Merge branch 'MDL-57089-master' of git://github.com/ankitagarwal/moodle 2016-11-23 08:20:13 +08:00
David Monllao 74138c7cd0 Merge branch 'MDL-57087_master' of git://github.com/markn86/moodle 2016-11-23 08:01:25 +08:00
Dan Poltawski 0484a0d511 Merge branch 'MDL-57075-master' of git://github.com/ryanwyllie/moodle 2016-11-22 21:14:20 +00:00
Dan Poltawski 95b25310ce Merge branch 'MDL-56795-master' of git://github.com/damyon/moodle 2016-11-22 21:01:59 +00:00
Dan Poltawski 1da2cf3bc0 Merge branch 'MDL-57018-master' of git://github.com/damyon/moodle 2016-11-22 20:59:17 +00:00
Dan Poltawski cb151980c4 Merge branch 'MDL-56656-master' of git://github.com/ankitagarwal/moodle 2016-11-22 18:05:10 +00:00
Dan Poltawski 03f450c10d Merge branch 'MDL-56987-master' of git://github.com/damyon/moodle 2016-11-22 18:01:38 +00:00
Dan Poltawski d3b13065ce Merge branch 'MDL-57012-master' of git://github.com/damyon/moodle 2016-11-22 18:01:10 +00:00
Dan Poltawski 73430100ff Merge branch 'MDL-57042-master' of git://github.com/damyon/moodle 2016-11-22 18:00:45 +00:00
AMOS bot 499f4a7823 Automatically generated installer lang files 2016-11-23 00:04:53 +08:00
Eloy Lafuente (stronk7) 0fbe41f4cd Moodle release 3.2rc2 2016-11-22 16:22:21 +01:00
Dan Poltawski e122972d3f Merge branch 'MDL-56938-master-fix1' of http://github.com/damyon/moodle 2016-11-22 10:26:52 +00:00
Ankit Agarwal 7597ab0b99 MDL-56656 messages: Proper multilang formating in messaging pages 2016-11-22 14:51:12 +05:30
Damyon Wiese 57bfb7c30a MDL-56938 filter_media: Responsive size fallback player
Apply responsive sizing to any video element in a media filter div.

This applys to the HTML5 video player and the fall back player if
video.js fails to load.
2016-11-22 17:04:55 +08:00
Ankit Agarwal 2561e79fca MDL-57089 boost: Fix single select rendering
Also added context docs to the template file
2016-11-22 14:06:59 +05:30
John Okely 529e944a8c MDL-56782 custommenu add multilang example 2016-11-22 15:12:55 +08:00
Damyon Wiese 45ed4271b7 MDL-56902 blocks: no nav / settings in boost
Upgraded sites switching to boost should not see nav/settings blocks.
2016-11-22 15:02:51 +08:00
Damyon Wiese 51718b752d MDL-56902 blocks: Prevent blocks returning when switching themes.
Now if the current theme requires some blocks that don't exist, they
will be created - but with a new flag that indicates this block should
only be returned if the current theme requires it. This allows flipping back
and forth between boost and clean without restoring the nav and settings blocks
in boost.
2016-11-22 14:53:24 +08:00
Mark Nelson 9c6c29932a MDL-56391 core_message: addressed confusing links on the profile page
1) Use the string 'Send message' rather than 'View messages'.
2) Removed the 'View messages' string as it is no longer used
   and was introduced in the new messaging UI.
3) Removed the 'View profile' link and made the user's profile
   picture a link to their profile instead, this was only
   recently plausible because of MDL-57036.
2016-11-22 14:35:19 +08:00
Damyon Wiese 8cdff4beda MDL-56584 boost: Focus on drawer when it is opened 2016-11-22 14:05:43 +08:00
Damyon Wiese 95210c6650 MDL-56987 bootstrapbase: Center align in page modals 2016-11-22 13:31:50 +08:00
Mark Nelson 3c1cdac63f MDL-57087 core_message: ignore site policy if logged in as admin 2016-11-22 13:20:49 +08:00
Frederic Massart 84979ab793 MDL-57064 course: Return all properties when getting navigation options 2016-11-22 12:58:52 +08:00
Andrew Nicols 8d294e729f Merge branch 'MDL-57035-master' of git://github.com/FMCorz/moodle 2016-11-22 12:02:45 +08:00
Damyon Wiese a51122983c MDL-57018 boost: Style marking guide entry form
Add boost styles to marking guide entry form.
2016-11-22 11:47:45 +08:00
David Monllao 82f9746962 Merge branch 'MDL-56782-master' of git://github.com/damyon/moodle 2016-11-22 11:46:13 +08:00
Frederic Massart cbca970ab7 MDL-57035 repository_skydrive: Compability with converged type apps
http://go.microsoft.com/fwlink/p/?LinkID=615760
2016-11-22 11:46:05 +08:00
Damyon Wiese e466e337b0 MDL-57018 marking guide: Style frequent comments
Style frequently used comments for bootstrap 4.
2016-11-22 11:46:01 +08:00
Ryan Wyllie a6a277f06c MDL-57075 message: notification popover see all link
The "see all" link in the notification popover should link to the full
notifications page similar to how the "see all" link in the message
popover links to the messaging page.
2016-11-22 03:44:26 +00:00
Andrew Nicols 282f0437f1 Merge branch 'wip-mdl-56898-fixup' of https://github.com/rajeshtaneja/moodle 2016-11-22 11:33:25 +08:00
Andrew Nicols 873a7e1e86 Merge branch 'MDL-56683-master' of git://github.com/damyon/moodle 2016-11-22 11:27:28 +08:00
Andrew Nicols 38a8590ed0 Merge branch 'wip-mdl-56994' of https://github.com/rajeshtaneja/moodle 2016-11-22 11:22:30 +08:00
Rajesh Taneja 45e862c4bd MDL-56898 behat: Wait for pending JS after setting password 2016-11-22 11:20:30 +08:00
Andrew Nicols d51d8ca2af Merge branch 'MDL-55838-master' of git://github.com/damyon/moodle 2016-11-22 11:17:33 +08:00
Rajesh Taneja f4565e7147 MDL-56994 behat: Fixed activity selector to find proper li
Previous to this patch, only 1 activity was
expected and if there are more than 1 activities
then it will fail. Improved step to find the
correct activity node by name
2016-11-22 11:02:52 +08:00
Damyon Wiese 52a51514f6 MDL-56683 theme_boost: Popovers on dynamic content 2016-11-22 10:28:25 +08:00
David Monllao 42cf4a3470 Merge branch 'MDL-57023-master' of git://github.com/andrewnicols/moodle 2016-11-22 10:23:21 +08:00
Damyon Wiese 5d03ab36b5 MDL-55838 theme_boost: Fix secure layout
It was out of date with the columns2 layout and had links outside it's content.
2016-11-22 10:22:17 +08:00
Andrew Nicols 727145bf1c MDL-56407 message: Additional unit test for unblocked user 2016-11-22 09:45:52 +08:00
Brendan Heywood 3d8fbf39f7 MDL-52199 core_message: IMAP errors passed to task api 2016-11-22 12:44:30 +11:00
Andrew Nicols d10ca75b8c Merge branch 'MDL-56407-master-2' of git://github.com/junpataleta/moodle 2016-11-22 09:06:09 +08:00
Andrew Nicols aacdf8e280 MDL-57023 tool_usertours: Ensure that the tour key is unique
The tour key was already unique, but this change makes it unique to the
current user too.
2016-11-22 09:05:31 +08:00
Andrew Nicols aabebc7516 MDL-57023 tool_usertours: Update to v0.9.10
This new version of the library brings with it storage of the current
step number in the browser session storage.

This allows the page to reload whilst viewing a tour and have the tour
continue.
2016-11-22 09:05:31 +08:00
David Monllao 5009bcd9b4 Merge branch 'MDL-56986-master-fix' of https://github.com/lameze/moodle 2016-11-22 09:04:26 +08:00
Andrew Nicols 4b2790c580 Merge branch 'MDL-56809-master' of git://github.com/ankitagarwal/moodle 2016-11-22 08:49:18 +08:00
Simey Lameze 5e43ccd3b9 MDL-56986 block_course_summary: remove edit icon scenario from behat 2016-11-22 08:39:35 +08:00
Andrew Nicols 783ef76bfc Merge branch 'MDL-56716-master' of git://github.com/damyon/moodle 2016-11-22 08:10:11 +08:00
Rajesh Taneja 49cf53dd93 MDL-56797 theme_boost: Fixed css on rubric icon so text wraps 2016-11-22 07:26:25 +08:00
Dan Poltawski 4b631c2d87 Merge branch 'wip-mdl-56898-fix2' of https://github.com/rajeshtaneja/moodle 2016-11-21 15:07:49 +00:00
Damyon Wiese 00f5c95590 MDL-57012 boost: Filepicker layout fix
Use container-fluid which is always 100% wide.
2016-11-21 21:35:12 +08:00
Damyon Wiese 7e81bd114e MDL-56782 custommenu - update docs
We don't support sub-menus in all themes (boost) so we want to update
the docs and example.
2016-11-21 21:17:43 +08:00
Dan Poltawski 9446cb507c Merge branch 'MDL-56318-master' of git://github.com/damyon/moodle 2016-11-21 09:55:09 +00:00
Damyon Wiese ef25d51f5b MDL-56795 boost: Close drawer after navigating on mobile 2016-11-21 17:26:45 +08:00
Damyon Wiese 21a5c3c447 MDL-56318 assign: Polish for assign grading in boost
These styles mostly remove the responsiveness from the grading form.
2016-11-21 16:59:39 +08:00
David Monllao 9557be1542 Merge branch 'MDL-57063-master' of git://github.com/FMCorz/moodle 2016-11-21 16:53:44 +08:00
Dan Poltawski 05551a935a Merge branch 'MDL-56849-master' of git://github.com/damyon/moodle 2016-11-21 08:36:27 +00:00
Dan Poltawski f7d76254fd Merge branch 'MDL-56994-master-2' of git://github.com/junpataleta/moodle 2016-11-21 07:30:58 +00:00
Damyon Wiese 28f2458448 MDL-56849 mod_wiki: Update styles for boost
Make sure all form field have bootstrap styles. Use bootstrap tables on
tables. Remove custom styling. Prefer left-aligned text.
2016-11-21 15:19:16 +08:00
Damyon Wiese e283c6ca33 MDL-56716 boost: Fix styling for review options
The checkbox form template was changed, so this custom rule needs
updating.
2016-11-21 15:08:41 +08:00
Rajesh Taneja 26fef01b6b MDL-56898 behat: Go to a non html page to avoid any unwanted ajax calls
After scenario is finished, go to README.txt, so
there is no JS/AJAX calls pending and site is ready
for reset before next scenario
2016-11-21 14:16:49 +08:00
Rajesh Taneja d9a9a87835 MDL-56898 behat: Ensure the page is stable before executing 2016-11-21 14:16:48 +08:00
David Monllao e0ba33697f Merge branch 'MDL-56938-master' of git://github.com/damyon/moodle 2016-11-21 14:09:43 +08:00
Ankit Agarwal f318b74b49 MDL-56809 boost: Don't escape html in single select options 2016-11-21 11:38:51 +05:30
Ankit Agarwal 63531fff79 MDL-56809 boost: Add template context info 2016-11-21 11:38:51 +05:30
Andrew Nicols 51e8968635 Merge branch 'MDL-56612_master' of git://github.com/dmonllao/moodle 2016-11-21 13:40:00 +08:00
Andrew Nicols e67c14053e Merge branch 'MDL-56974-master' of git://github.com/jleyva/moodle 2016-11-21 13:21:27 +08:00
David Monllao 30f023b1b3 Merge branch 'MDL-56975-master' of git://github.com/jleyva/moodle 2016-11-21 13:15:40 +08:00
Damyon Wiese fce0f1c235 MDL-56938 messages: Images and videos display badly in messaging
Make sure they get minimum and maximum width so they don't overflow and
don't appear tiny.
2016-11-21 13:01:36 +08:00
David Monllao 57c01bca0e MDL-56612 navigation: Remove redundant load_courses_enrolled call 2016-11-21 12:42:09 +08:00
David Monllao 7d432be4e9 Merge branch 'MDL-57017-master' of git://github.com/andrewnicols/moodle 2016-11-21 12:40:26 +08:00
Andrew Nicols 2380daba7b Merge branch 'MDL-57054-master' of git://github.com/jleyva/moodle 2016-11-21 12:38:05 +08:00
Damyon Wiese 9741087ffd MDL-57042 messaging: When selecting a user, go to send message
This is the whole point of this UI - make it the default action after
searching and selecting a user. You can still get to their profile by
clicking their name in the header of the messaging pane.
2016-11-21 12:22:30 +08:00
David Monllao 2f5208ea1b Merge branch 'MDL-57049-master' of https://github.com/snake/moodle 2016-11-21 11:49:59 +08:00
Andrew Nicols 1e9487092d Merge branch 'MDL-56877' of https://github.com/eSrem/moodle 2016-11-21 11:08:01 +08:00
Frederic Massart 3d3fb328b4 MDL-57063 backup: Do not try to set default value on locked setting
We cannot set a default value on settings which are 'config' or
'permission' locked or an exception will be thrown from
base_setting::set_value.
2016-11-21 11:03:41 +08:00
Andrew Nicols 23bb1871b3 Merge branch 'MDL-55275' of https://github.com/tobiasreischmann/moodle 2016-11-21 11:01:40 +08:00
Andrew Nicols 896718ef79 Merge branch 'MDL-56943-master' of git://github.com/danpoltawski/moodle 2016-11-21 10:54:09 +08:00
David Monllao dfe7cbe4cf Merge branch 'MDL-57036_master' of git://github.com/markn86/moodle 2016-11-21 10:51:29 +08:00
Jun Pataleta 25bfa25190 MDL-56994 mod_forum: Auto-create news forum if course format supports it 2016-11-21 10:05:05 +08:00
Jun Pataleta e47d61e198 MDL-56994 course: Show News field only if course format supports news 2016-11-21 10:05:01 +08:00
Jun Pataleta 87799e9fba MDL-56994 course: New method to check if format supports news forum 2016-11-21 09:50:55 +08:00
David Monllao 30cfed3731 Merge branch 'MDL-57052-master' of git://github.com/jleyva/moodle 2016-11-21 09:47:51 +08:00
David Monllao 406f1eb76d Merge branch 'MDL-57051-master' of git://github.com/jleyva/moodle 2016-11-21 09:45:44 +08:00
Marina Glancy fc14932c40 MDL-57019 core_grades: change default navigation to tabs
without navigation block in boost it is not easy to navigation between gradebook sections
2016-11-21 09:31:49 +08:00
Rajesh Taneja 7f24e5e654 MDL-56898 behat: Click on logout link in footer, it's faster 2016-11-21 09:25:35 +08:00
Rajesh Taneja 65eb39c0b4 MDL-56898 behat: Increase autosavefrequency for behat tests
We don't need editor to autosave, as this cause
unwanted ajax request
2016-11-21 09:25:35 +08:00
Rajesh Taneja 1bce723292 MDL-56898 behat: Try data reset if it fails because of pending process 2016-11-21 09:25:35 +08:00
David Monllao f48cc821db Merge branch 'MDL-56972-master' of https://github.com/snake/moodle 2016-11-21 09:05:40 +08:00
Jake Dallimore 0a5cafcbe9 MDL-57049 libraries: update jqueryui version in requirejs path 2016-11-21 08:57:53 +08:00
Andrew Nicols 5084343b3f Merge branch 'MDL-42977-master' of git://github.com/lameze/moodle 2016-11-21 08:52:42 +08:00
David Monllao a4abacc9a6 Merge branch 'MDL-56986-master' of git://github.com/lameze/moodle 2016-11-21 08:51:47 +08:00
David Monllao ff687b9c15 Merge branch 'MDL-56843-master' of git://github.com/lameze/moodle 2016-11-21 08:48:22 +08:00
Andrew Nicols b0db945b11 Merge branch 'MDL-57002-master' of git://github.com/FMCorz/moodle 2016-11-21 08:21:31 +08:00
Tim Hunt edf2f7bdf1 MDL-53964 qtype_ddmarker: marker label 0 should be allowed 2016-11-20 21:32:55 +00:00
Tim Hunt 030d8f22c2 MDL-35949 quiz accessibility: move input outside label 2016-11-20 16:59:00 +00:00
Juan Leyva d0da94cdf4 MDL-56974 auth_email: Incorrect param type for redirect in sign_up WS 2016-11-19 18:21:56 +00:00
Juan Leyva 02bb0c0637 MDL-56975 tool_mobile: Fix page set_url 2016-11-19 18:15:59 +00:00
Juan Leyva 8abfb7b1bb MDL-57054 mod_quiz: check_updates_since not returning questionids 2016-11-19 17:44:48 +00:00
Juan Leyva 0840b3e687 MDL-57052 course: Missing required file in check_module_updates_since 2016-11-19 17:27:01 +00:00
Juan Leyva 6706c1cb12 MDL-57051 course: Do not return directories in check_module_updates 2016-11-19 16:54:31 +00:00
Tony Butler 40e0baf08e MDL-56948 mod_assign: Don't call get_grade_item() unless we have one 2016-11-18 15:37:09 +00:00
Dan Poltawski 835f1f9add Merge branch 'MDL-57038-master' of git://github.com/FMCorz/moodle 2016-11-18 14:41:56 +00:00
Dan Poltawski b3fd942b52 Merge branch 'MDL-56693_master' of git://github.com/dmonllao/moodle 2016-11-18 14:25:20 +00:00
Dan Poltawski cd4a6b8b0b Moodle release 3.2rc1 2016-11-18 10:06:20 +00:00
Dan Poltawski 644444829a Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-11-18 10:06:18 +00:00
Dan Poltawski ff308ab4fb Merge branch 'MDL-56959-master-fixup' of https://github.com/FMCorz/moodle 2016-11-18 07:53:31 +00:00
Frederic Massart 755b013fdf MDL-56959 output: Prevent notice when csstreepostprocess is undefined 2016-11-18 15:47:32 +08:00
EizEddin AlKatrib af28ceb945 MDL-42977 course: Fixed the default behaviour of the Collapse/Expand all link 2016-11-18 14:24:42 +08:00
Frederic Massart 538ce414a5 MDL-57002 repository_webdav: Use default temporary file name
The WebDAV library does not like when there are UTF-8 characters
in the temporary file name. It changes the path but does not return
it, so the file ends up being saved somewhere unknown. As we do not
need the file name at all, we let repository::prepare_file()
generate one.
2016-11-18 12:47:59 +08:00
David Monllao f2e599d51c MDL-56693 boost: Highlight config.php settings in admin UI 2016-11-18 12:22:59 +08:00
Jake Dallimore fe9864f488 MDL-56972 backup: fix question category stamp duplicates during restore
To kerb future stamp duplication, MDL-54864 added a unique index to the
question_categories table (stamp, contextid) and added an upgrade step
to fix existing duplicate stamps. It missed the case where a course with
duplicate stamps in the same context is directly restored into moodle
3.1, causing index clashes. This issue provides a fix for that.
2016-11-18 11:15:02 +08:00
Mark Nelson f4c39cb983 MDL-57036 core_message: always show profile picture on messaging UI 2016-11-18 11:13:36 +08:00
Frederic Massart 3d66b5a100 MDL-57038 theme_bootstrapbase: Fix expand icon with RTL auto-flipped 2016-11-18 11:05:10 +08:00
Andrew Nicols cb3f67364d Merge branch 'MDL-56463_master-fix2' of git://github.com/dmonllao/moodle 2016-11-18 11:02:19 +08:00
Simey Lameze b95a05a536 MDL-56843 theme_boost: remove top margin from repository search div 2016-11-18 09:47:30 +08:00
Simey Lameze 2da36b3750 MDL-56986 block_course_summary: remove unnecessary small cog icon 2016-11-18 09:18:46 +08:00
David Monllao aab30ea828 Merge branch 'MDL-55869_m32v1' of https://github.com/sbourget/moodle 2016-11-18 09:16:06 +08:00
David Monllao 74c21d51d0 Merge branch 'MDL-55566_m32v1' of https://github.com/sbourget/moodle 2016-11-18 09:05:13 +08:00
David Monllao b14a04e0a4 MDL-56463 tool_mobile: Set object properties always in same order
There are differences in http://php.net/manual/en/function.list.php
between PHP 5 and in PHP 7. They neither recommend to rely on the new order
as it may change again in future.
2016-11-18 08:50:08 +08:00
Andrew Nicols 8a668f75a8 Merge branch 'MDL-56989-master' of git://github.com/danpoltawski/moodle 2016-11-18 07:55:42 +08:00
Andrew Nicols 3e5a1d8029 Merge branch 'MDL-57004-master' of git://github.com/ankitagarwal/moodle 2016-11-18 07:27:15 +08:00
Dan Poltawski 099a2aee68 Merge branch 'MDL-56959-master' of git://github.com/FMCorz/moodle 2016-11-17 18:01:58 +00:00
AMOS bot a7c01b5876 Automatically generated installer lang files 2016-11-18 00:06:34 +08:00
David Monllao e23e6c2f64 Merge branch 'MDL-56826-master-fix1' of git://github.com/damyon/moodle 2016-11-17 20:25:31 +08:00
David Monllao f209d76b0d Merge branch 'MDL-57015' of git://github.com/stronk7/moodle 2016-11-17 20:23:20 +08:00
Dan Poltawski abdffed5fc Merge branch 'wip-MDL-56869-master' of https://github.com/marinaglancy/moodle 2016-11-17 11:32:49 +00:00
Ankit Agarwal 40e24fda5b MDL-57004: boost: Show action menu on section pages 2016-11-17 16:31:50 +05:30
Dan Poltawski 486fac73f2 Merge branch 'MDL-56467_master' of git://github.com/markn86/moodle 2016-11-17 10:15:51 +00:00
Virgil Ashruf 5ceb68d169 MDL-56877 autogroup form: no limit on cohorts 2016-11-17 10:46:53 +01:00
Dan Poltawski a0c3ab0b30 Merge branch 'MDL-56767-master-fix' of https://github.com/lameze/moodle 2016-11-17 08:51:18 +00:00
Damyon Wiese 009c57d730 MDL-56826 question: Add bootstrap styles to question preview 2016-11-17 16:14:34 +08:00
David Monllao 820a43510f Merge branch 'MDL-56763-master' of git://github.com/lameze/moodle 2016-11-17 16:10:01 +08:00
Frederic Massart 493ef66ecd MDL-56959 theme: Inherit the parent CSS tree post processor 2016-11-17 15:18:29 +08:00
Frederic Massart 41b973bcbb MDL-56959 theme: SCSS file is inherited from parent
Also added support for the SCSS property to be a Closure
and return content rather than simply being the name of a file.
2016-11-17 15:18:29 +08:00
David Monllao 237af2ba61 Merge branch 'MDL-56734-master' of git://github.com/lameze/moodle 2016-11-17 15:10:52 +08:00
Andrew Nicols 79f15159da Merge branch 'wip-MDL-57007-master' of git://github.com/marinaglancy/moodle 2016-11-17 14:36:02 +08:00
Andrew Nicols 2f0cd733be Merge branch 'MDL-56822-master' of git://github.com/cameron1729/moodle 2016-11-17 14:33:39 +08:00
David Monllao 4006e187f3 MDL-56826 version: Increase version after history rewrite 2016-11-17 14:25:52 +08:00
David Monllao 98f43f1b08 Merge branch 'MDL-56826-master' of git://github.com/damyon/moodle 2016-11-17 14:24:59 +08:00
Damyon Wiese 12d6dfc1ce MDL-56826 questions: Add styling for boost theme
Changes include:
* question: Add bootstrap classes to buttons and selects so they look consistent.

* mod_quiz: Add bootstrap styles to report form elements

* question: Add bootstrap classes to question form elements

* And remove the success/fail styles from boost because they conflict badly
with the quiz plugin styles (making unreadable text).

* quiz: nav block buttons had black background

* quiz: Add bootstrap styles to quiz navigation buttons

* qtype_ddmarker: Remove bullets from list

Edit form coordinates preview had list bullets for each coordinate.

* boost: Prevent menu scrolling on quiz edit

* mod_quiz: Add bootstrap styles to edit quiz fields

Pagination and max grades forms.

* quiz: Undo some custom styles on review options

These checkboxes were laid out in a fake grid with no responsiveness
that conflicts with the bootstrap form-inline templates. Reset the
custom style to bootstrap default.

* quiz: Fix unit tests for boost changes

* qtype_ddwtos: Accurate positioning of drop targets

* questions: Make the review page responsive

* question: bootstrap 4 compatibility

.alert in bs4 contains no colours by default, you need to mix it with
one of the context classes to get some change in colours, borders etc.
2016-11-17 14:20:52 +08:00
Simey Lameze 25ca6f1638 MDL-56763 theme_boost: ignore boostrap popover rtl scss
Because Bootstrap Javascript does is not expecting to be flipped, it breaks the popover on RTL languages.
We already swap the directions on the help icon template so popover scss rules can be ignored.
2016-11-17 14:19:49 +08:00
Simey Lameze 7508e218d2 MDL-56767 theme_boost: change remember username checkbox to bs4 style 2016-11-17 13:36:21 +08:00
Andrew Nicols 3d15dfc9d2 Merge branch 'MDL-56221' of https://github.com/bostelm/moodle 2016-11-17 13:31:33 +08:00
David Monllao c35ef2e9a0 Merge branch 'MDL-56463_master-fix' of git://github.com/dmonllao/moodle 2016-11-17 13:27:21 +08:00
David Monllao 96abc5f1cd MDL-56763 tool_mobile: Unit test fix
Checking external_format_text return instead of just using SITE->summary
2016-11-17 13:25:54 +08:00
Simey Lameze d78207b6c3 MDL-56734 tool_lp: add competency frameworks repo button 2016-11-17 13:15:56 +08:00
David Monllao d41b1ba49e Merge branch 'MDL-56463-master' of git://github.com/jleyva/moodle 2016-11-17 13:10:23 +08:00
Marina Glancy e938ea398c MDL-57007 behat: assume all capabilities during installation 2016-11-17 13:07:09 +08:00
David Monllao 29dfbb422f Merge branch 'MDL-56842-master' of git://github.com/danpoltawski/moodle 2016-11-17 12:28:34 +08:00
David Monllao 9ecf0674ff Merge branch 'MDL-56870-master-v2' of https://github.com/snake/moodle 2016-11-17 12:18:26 +08:00
Cameron Ball b5b7af96bb MDL-56822 messaging: Hide notification icons on site policy screen
If we have the nofications and messaging popovers displaying on the
policy confirmation screen we hit an exception since the webservices
won't work if the policy hasn't been agreed to.

This patch simply stops them from showing if the site policy hasn't
been agreed to.
2016-11-17 12:10:52 +08:00
Andrew Nicols 76acac80eb Merge branch 'MDL-56978_iconv' of https://github.com/mrmark/moodle 2016-11-17 11:20:39 +08:00
Jake Dallimore a428cf4ac8 MDL-56870 lib: block access to deleted module in require_login 2016-11-17 10:57:13 +08:00
David Monllao 0915860e51 Merge branch 'MDL-52186-master' of git://github.com/junpataleta/moodle 2016-11-17 10:42:08 +08:00
Jun Pataleta b62bebbf1c MDL-52186 enrol_meta: Sync only active enrol_meta instances
Thanks to Peter Klinka for the solution!
2016-11-17 10:40:54 +08:00
David Monllao 75166d0627 Merge branch 'wip-mdl-56865' of https://github.com/rajeshtaneja/moodle 2016-11-17 10:35:38 +08:00
David Monllao 6dc3a5b699 Merge branch 'MDL-56915-master' of git://github.com/FMCorz/moodle 2016-11-17 10:32:00 +08:00
Andrew Nicols c6b4421524 MDL-57017 tool_usertours: Allow targetting of the frontpage 2016-11-17 10:23:00 +08:00
Andrew Nicols 50e16a67ab Merge branch 'MDL-56767-master' of git://github.com/danpoltawski/moodle 2016-11-17 10:07:35 +08:00
Eloy Lafuente (stronk7) 7336ba40d5 MDL-57015 tests: Use preventResetByRollback() if test uses transactions 2016-11-17 02:41:31 +01:00
David Monllao a813b0c3dc Merge branch 'MDL-56999-master' of git://github.com/damyon/moodle 2016-11-17 09:31:07 +08:00
Jun Pataleta 26dca05d02 MDL-56407 message: Indicate user is blocked in message area 2016-11-17 09:11:37 +08:00
Rajesh Taneja 920d7ffadd MDL-56865 behat: Don't set error handler for behat install 2016-11-17 08:56:54 +08:00
Andrew Nicols 84c8c00959 Merge branch 'wip-mdl-56603' of https://github.com/rajeshtaneja/moodle 2016-11-17 08:51:47 +08:00
Rajesh Taneja d48c0a1d9a MDL-56603 behat: Fixed search messages string to use id 2016-11-17 08:46:32 +08:00
Eloy Lafuente (stronk7) 7b0057b895 Merge branch 'MDL-56922-master' of git://github.com/danpoltawski/moodle 2016-11-17 01:38:24 +01:00
Henning Bostelmann 9574320a36 MDL-56221 mod_assign: Suppress unwanted grade notifications
* Quick grading: Properly recognize unchanged grades
* Individual grading: Amend JS that transfers checkbox state
2016-11-16 21:53:33 +00:00
Nadav Kavalerchik 6e402aeb0a MDL-57013 Theme_boost: Fix inline edit tooltip in RTL mode. 2016-11-16 23:38:28 +02:00
Mark Nielsen 6670d28fbc MDL-56978 core: fix error handling in min_fix_utf8
Must completely suppress notice from iconv as Behat's
shutdown function uses error_get_last() which is
unable to detect if the error was suppressed or not.
2016-11-16 08:59:15 -08:00
Dan Poltawski a4e2d64571 MDL-56943 boost: correct ARIA roles
* role="navigation" can't go directly on a list
* role="banner" should only be done once and not on a link
2016-11-16 16:52:03 +00:00
AMOS bot 7489d697be Automatically generated installer lang files 2016-11-17 00:04:37 +08:00
Tobias Reischmann 1cca9a3479 MDL-55275 assign: Prevent exception under admin role assignment.
In group mode the submission status was displayed to admins.
This caused an exception when the admins were enrolled as teachers
in a course while being the only member of a group.
2016-11-16 16:55:22 +01:00
Dan Poltawski 310808b778 MDL-56989 boost: fix template lint issues
1) Add example context where missing
2) Don't use an uncessary function in JS
2016-11-16 14:56:29 +00:00
Juan Leyva e2fe3bc081 MDL-56463 tool_mobile: Apply text formatting to tool_mobile WS 2016-11-16 14:54:37 +00:00
Dan Poltawski 6eb6c5fd6d MDL-56989 boost: don't double-escape page titles 2016-11-16 14:41:03 +00:00
Dan Poltawski 6182ec8901 MDL-56842 boost: add example context to login template 2016-11-16 13:59:47 +00:00
Dan Poltawski 16732d0631 MDL-56842 boost: load required js on login page 2016-11-16 13:59:47 +00:00
Dan Poltawski 05a25f86dd MDL-55857 boost: add example context 2016-11-16 13:24:24 +00:00
Dan Poltawski 8515e2d16d MDL-55857 boost: template for checkboxes in repo plugins
Thanks to Damyon for the suggested markup
2016-11-16 13:12:18 +00:00
Dan Poltawski 7d3a7bbd1f Merge branch 'MDL-33960-lti-scroll' of https://github.com/gabrielrosset/moodle 2016-11-16 13:03:38 +00:00
Dan Poltawski 3b195bfb81 MDL-56922 theme_boost: grey out activity icon when hidden
This was present in bootstrapbase and is I think an important visual
distinction.
2016-11-16 11:58:42 +00:00
David Monllao e3cb80f10c Merge branch 'wip-MDL-56847-master' of git://github.com/marinaglancy/moodle 2016-11-16 19:38:08 +08:00
Eloy Lafuente (stronk7) 904fcbee8b Merge branch 'MDL-55362_master' of git://github.com/Chocolate-lightning/moodle 2016-11-16 11:29:01 +01:00
Frederic Massart 6321934c73 MDL-56205 theme_boost: Adjust margin between icon and caret in dropdowns 2016-11-16 10:20:53 +00:00
Eloy Lafuente (stronk7) 751122dbc0 Merge branch 'MDL-56908-master' of git://github.com/danpoltawski/moodle 2016-11-16 11:18:15 +01:00
Dan Poltawski c1e74a0937 Merge branch 'MDL-56965-master' of git://github.com/ankitagarwal/moodle 2016-11-16 10:08:10 +00:00
Dan Poltawski f882aed3b3 Merge branch 'wip-MDL-56776-master' of git://github.com/marinaglancy/moodle 2016-11-16 09:46:10 +00:00
Eloy Lafuente (stronk7) e7b9ea226c Merge branch 'MDL-56911-master' of git://github.com/ankitagarwal/moodle 2016-11-16 10:33:09 +01:00
Dan Poltawski 1bf9d6ac92 Merge branch 'MDL-56889-master' of git://github.com/danpoltawski/moodle 2016-11-16 09:20:28 +00:00
Frederic Massart 35b48c7aed MDL-56915 webdav: Increase maximum expected header size 2016-11-16 17:19:19 +08:00
Dan Poltawski 706e012fd6 MDL-56889 boostrapbase: remove excessive stylelint-disables
From bs4-compat.less, replace with file level disable instead.
2016-11-16 08:50:14 +00:00
Simey Lameze 660b51e013 MDL-56889 bootstrapbase: create static bs4 compatible mixins 2016-11-16 08:50:08 +00:00
Marina Glancy d76dd4d064 MDL-56869 media_videojs: upgrade video.js to 5.12.6 2016-11-16 16:27:30 +08:00
Dan Poltawski 6dc4c68e4e MDL-56767 block_login: Use btn-block as suggested by Andrew 2016-11-16 08:09:14 +00:00
Marina Glancy 4125ce046b MDL-56776 calendar: display month above the dates
month is displayed in table caption which is by default in the bottom in BS4
2016-11-16 15:46:56 +08:00
Andrew Nicols 7da7c1e24a Merge branch 'wip-MDL-56603-master-v2' of git://github.com/abgreeve/moodle 2016-11-16 15:36:37 +08:00
Damyon Wiese 3eb9cc2f6e MDL-56999 boost: Maintenance layout needs padding 2016-11-16 15:18:27 +08:00
Mark Nelson 393eccb077 MDL-56467 message_airnotifier: fixed settings pop-up not displaying 2016-11-16 14:56:32 +08:00
Adrian Greeve d3d0248afc MDL-56603 message: Added see all link to message popup. 2016-11-16 14:51:17 +08:00
Adrian Greeve 8151761378 MDL-56603 messaging: Add a new message link to popup.
Added a link to create a new message from the message
popup menu.
2016-11-16 14:51:17 +08:00
Andrew Nicols faadaedb17 Merge branch 'wip-mdl-56710' of https://github.com/rajeshtaneja/moodle 2016-11-16 14:14:26 +08:00
Andrew Nicols 0064cb1193 Merge branch 'MDL-56967-master' of git://github.com/damyon/moodle 2016-11-16 14:05:07 +08:00
Andrew Nicols a435242491 Merge branch 'wip-mdl-56981' of https://github.com/rajeshtaneja/moodle 2016-11-16 14:00:40 +08:00
David Monllao 70d2c9fcf8 Merge branch 'MDL-56784-master' of git://github.com/cameron1729/moodle 2016-11-16 13:49:51 +08:00
David Monllao 12ebaf1c6b Merge branch 'MDL-56187-master' of git://github.com/damyon/moodle 2016-11-16 13:35:38 +08:00
Cameron Ball 8712a50ec2 MDL-56784 theme_boost: Fix escaped markup in filemanager_fileselect
The markup in the filemanager_fileselect template was being escaped,
causing a help icon not to display.

Additionally, the popover for the help icon was not display since
"loader.js" was not properly delegating the popover calls.
2016-11-16 13:10:51 +08:00
David Monllao 97279f8d5d Merge branch 'MDL-56139_master' of git://github.com/markn86/moodle 2016-11-16 11:51:18 +08:00
Andrew Nicols 90677673da Merge branch 'MDL-56958-master' of git://github.com/damyon/moodle 2016-11-16 11:07:20 +08:00
Mark Nelson af5765b3fb MDL-56139 core_message: removed unused constants 2016-11-16 10:22:52 +08:00
Mark Nelson ffd7798c96 MDL-56139 core: changes after peer review
- No longer use the Fibonacci sequence for delaying the timeout.
  It is too aggressive.
- The backoff_timer AMD module now expects the callback AND the
  backoff function to be passed to the constructor.
- Added ability to specify polling frequency in config.php.
- Added helper function to return the cache key.
- Reworded the parameters for clarity.
2016-11-16 10:22:52 +08:00
Ryan Wyllie fb1469d84f MDL-56139 message: ajax poll for new messages in message area 2016-11-16 10:22:33 +08:00
Andrew Nicols 583278f070 Merge branch 'MDL-56703-master' of git://github.com/damyon/moodle 2016-11-16 10:16:09 +08:00
Andrew Nicols 901c0ea7de Merge branch 'wip_MDL-48055_master_quiz_activity_report_grade_visibility' of https://github.com/POETGroup/moodle 2016-11-16 10:08:13 +08:00
David Monllao 8898725385 Merge branch 'MDL-56921_master' of https://github.com/nadavkav/moodle 2016-11-16 10:04:37 +08:00
Damyon Wiese cee482ca4e MDL-56703 boost: Fix mustache html warnings
Don't put div in a span
2016-11-16 10:01:19 +08:00
Damyon Wiese 7a9309f32e MDL-56703 boost: Escaping bug in flat nav and navbar
The items in the flat navigation were double escaped. Also added
context to template.
2016-11-16 10:01:11 +08:00
Andrew Nicols 4642a8c593 Merge branch 'MDL-56193-master' of git://github.com/damyon/moodle 2016-11-16 09:52:55 +08:00
Damyon Wiese 4682f17c49 MDL-56967 boost: Fix for layout problem with IE11 2016-11-16 09:36:38 +08:00
Mathew May 44002b183c MDL-55362 core: Fixed topic section default name empty h2 tag 2016-11-16 14:19:55 +13:00
Rajesh Taneja 4b371f9769 MDL-56710 editor: Fix box-sizing to context box
With BS4, box-sizing is border-box and this leads to
icon not shown properly. TinyMCE toolbar should use
box-sizing as context-box
2016-11-16 08:37:15 +08:00
David Monllao e466786f78 Merge branch 'master_MDL-56358' of git://github.com/danmarsden/moodle 2016-11-16 08:33:45 +08:00
Andrew Nicols 6aefea74a4 Merge branch 'MDL-55209' of https://github.com/NeillM/moodle 2016-11-16 08:24:39 +08:00
Rajesh Taneja 4ea8f814a0 MDL-56981 behat: Fixed xpath of radio button to contain class 2016-11-16 08:14:07 +08:00
David Monllao 1c70e86b5e Merge branch 'MDL-56942-master' of git://github.com/jleyva/moodle 2016-11-16 08:09:54 +08:00
David Monllao 900a2c554e Merge branch 'm32_MDL-56917_TLS_Env_Checks_Based_On_Caps_Not_Raw_Version' of https://github.com/scara/moodle 2016-11-16 05:31:55 +08:00
Matteo Scaramuccia ade30c673c MDL-56917 core_upgrade: Do not use the raw version to check cURL caps.
Some Linux distros can backport features due to security issues
while keeping the same (old) version. See e.g.:
- RHEL 7, https://rhn.redhat.com/errata/RHSA-2015-2159.html
- RHEL 6, https://rhn.redhat.com/errata/RHBA-2016-0842.html
- Remi PHP 7.0.x, https://github.com/remicollet/remirepo/commit/87954ef9ca41
2016-11-15 21:50:07 +01:00
Mike Churchward 930570b410 MDL-48055 q_u_outline, q_u_complete: added checks for grade visibility. 2016-11-15 12:35:38 -05:00
Dan Poltawski 6027eaebc5 Merge branch 'MDL-55848-master' of git://github.com/lameze/moodle 2016-11-15 16:33:26 +00:00
Dan Poltawski 78b281b24d Merge branch 'wip-mdl-56860' of git://github.com/rajeshtaneja/moodle 2016-11-15 16:29:59 +00:00
Dan Poltawski 1efacd2b35 MDL-56767 block_login: add bootstrap markup
Remove existing overrides forcing the markup off
2016-11-15 15:44:09 +00:00
Dan Poltawski e44bd69aaa MDL-56939 theme_boost: Link to MDL for future 2016-11-15 14:31:45 +00:00
Dan Poltawski dad0b3bfeb Merge branch 'MDL-56939-master' of git://github.com/damyon/moodle 2016-11-15 14:29:35 +00:00
gabrielrosset d030347bce MDL-33960 mod_lti: fix page scroll 2016-11-15 14:40:21 +01:00
Dan Poltawski d25f96b766 MDL-56908 upgrade: bootstrap styling for settings save button 2016-11-15 12:51:14 +00:00
Dan Poltawski b4d6669dd0 on-demand release 3.2beta+ 2016-11-15 11:02:52 +00:00
Dan Poltawski 90d00d0eae Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-11-15 11:02:51 +00:00
Dan Poltawski efe57105d6 Merge branch 'MDL-56903-master-enfix' of git://github.com/mudrd8mz/moodle 2016-11-15 10:42:36 +00:00
Helen Foster 7f6accd448 MDL-56903 lang: Merge English strings from the en_fix language pack 2016-11-15 11:19:48 +01:00
Ankit Agarwal 0d02bb964b MDL-56965 themes: Fix logo CSS for RTL 2016-11-15 15:20:36 +05:30
Jake Dallimore 5cfaecac47 MDL-56931 themes: restrict extra padding to edit mode only 2016-11-15 09:29:57 +00:00
David Monllao 396edc0a5e Merge branch 'MDL-56910-master' of git://github.com/danpoltawski/moodle 2016-11-15 09:07:42 +00:00
Damyon Wiese 998432c2c9 MDL-56724 mod_choice: Improve alignment and checkboxes on dates 2016-11-15 09:07:42 +00:00
David Monllao 2f3ae73ab0 Merge branch 'wip-MDL-56899-master' of git://github.com/marinaglancy/moodle 2016-11-15 09:07:41 +00:00
David Monllao 04fbba050d Merge branch 'MDL-56690-master' of git://github.com/damyon/moodle 2016-11-15 09:07:40 +00:00
Andrew Nicols 1e9f38a487 Merge branch 'MDL-56785-master-fix' of https://github.com/lameze/moodle 2016-11-15 09:07:40 +00:00
Damyon Wiese 813afc6797 MDL-56618 behat: Fix xpath for behat
We changed the output so the test needs to match
2016-11-15 09:07:39 +00:00
Simey Lameze c1584e154c MDL-56785 theme_boost: apply bs4 styles to search options checkboxes 2016-11-15 09:07:39 +00:00
Andrew Nicols ebba556af7 Merge branch 'MDL-56844-master' of git://github.com/damyon/moodle 2016-11-15 09:07:38 +00:00
Andrew Nicols 7afc76fbd6 Merge branch 'MDL-56952-master' of git://github.com/damyon/moodle 2016-11-15 09:07:37 +00:00
David Monllao 92ba7648fe Merge branch 'MDL-56905-master' of git://github.com/jleyva/moodle 2016-11-15 09:07:37 +00:00
Andrew Nicols 2d45ac279d Merge branch 'MDL-56823' of git://github.com/aolley/moodle 2016-11-15 09:07:36 +00:00
David Monllao 1cc10f3f67 Merge branch 'MDL-56895-master' of git://github.com/danpoltawski/moodle 2016-11-15 09:07:35 +00:00
David Monllao 0fef835188 Merge branch 'MDL-56739-master' of git://github.com/jleyva/moodle 2016-11-15 09:07:35 +00:00
Eloy Lafuente (stronk7) 7a677348e4 Merge branch 'MDL-56724-master' of git://github.com/damyon/moodle 2016-11-15 09:07:34 +00:00
Eloy Lafuente (stronk7) 2589802489 Merge branch 'MDL-56910-master' of git://github.com/danpoltawski/moodle 2016-11-15 09:07:33 +00:00
David Monllao 5a9a2c61b9 Merge branch 'MDL-56824-master' of git://github.com/damyon/moodle 2016-11-15 09:07:33 +00:00
David Monllao 39e7d46d89 Merge branch 'MDL-56834-master-fix1' of http://github.com/damyon/moodle 2016-11-15 09:07:32 +00:00
Andrew Nicols 2fd423721f Merge branch 'MDL-56846-master' of git://github.com/damyon/moodle 2016-11-15 09:07:31 +00:00
Dan Poltawski 4f1ba09334 Merge branch 'MDL-54871' of https://github.com/bostelm/moodle 2016-11-15 09:07:31 +00:00
Dan Poltawski 642bbbdd10 Merge branch 'MDL-54782_master' of git://github.com/markn86/moodle 2016-11-15 09:07:30 +00:00
Dan Poltawski 4678592332 Merge branch 'MDL-56426_master' of git://github.com/markn86/moodle 2016-11-15 09:07:29 +00:00
Dan Poltawski 6dad38deed Merge branch 'MDL-56913' of git://github.com/timhunt/moodle 2016-11-15 09:07:29 +00:00
Dan Poltawski d82aa0a2d9 MDL-56910 filepicker: fix eranously removed styles
No idea what happened to my testing of this change, but it was wrong.
2016-11-15 08:27:03 +00:00
Ankit Agarwal dc48cc0a79 MDL-56911 themes: Resolve settings before calling parser 2016-11-15 13:34:52 +05:30
Damyon Wiese fcd412470a MDL-56939 boost: Fix for bootstrap select reset
Bootstrap makes select form elements not using custom-select broken when
they have a size. The contents overflow the field.
2016-11-15 15:41:19 +08:00
Damyon Wiese d9a1d6834c MDL-56193 theme_boost: Make the enrol users modal wider 2016-11-15 15:12:19 +08:00
Marina Glancy 5e5ce443fd MDL-56847 tags: exclude modules that are being deleted
we don't check any access for admins for performance reasons, course modules
that are in the process of deletion should be filtered out on the early stage
2016-11-15 14:34:18 +08:00
Damyon Wiese 946281d282 MDL-56958 ajax: Prefer the general renderer 2016-11-15 12:44:59 +08:00
Damyon Wiese ae9bbd9847 MDL-56193 enrol_manual: Bootstrap styles for assign roles
Use a bootstrap popover for the assign roles form.
2016-11-15 11:29:49 +08:00
Damyon Wiese f10ae4676d MDL-56193 enrol: Modernise the enrol users popup
This just injects bootstrap classes into the old yui2 thing. It needs
rewriting.
2016-11-15 11:29:18 +08:00
Damyon Wiese f25185d7b0 MDL-56844 scorm: Review styles in boost theme
The main change is that in boost we get rid of the random centered text.
To compensate we use "container" which is fixed with with auto margins -
but the text is still left aligned.
2016-11-15 11:19:33 +08:00
David Monllao b09db258e5 Merge branch 'MDL-56905-master' of git://github.com/jleyva/moodle 2016-11-15 10:55:20 +08:00
Andrew Nicols 857a0ab60e Merge branch 'MDL-56952-master' of git://github.com/damyon/moodle 2016-11-15 10:18:01 +08:00
Andrew Nicols d7978641dc Merge branch 'MDL-56823' of git://github.com/aolley/moodle 2016-11-15 10:04:21 +08:00
David Monllao 6f0efcc891 Merge branch 'MDL-56895-master' of git://github.com/danpoltawski/moodle 2016-11-15 09:51:07 +08:00
David Monllao d163d37593 Merge branch 'MDL-56739-master' of git://github.com/jleyva/moodle 2016-11-15 09:40:17 +08:00
Eloy Lafuente (stronk7) de7e277e1f Merge branch 'MDL-56724-master' of git://github.com/damyon/moodle 2016-11-15 02:17:10 +01:00
Eloy Lafuente (stronk7) 852264ad23 Merge branch 'MDL-56910-master' of git://github.com/danpoltawski/moodle 2016-11-15 02:13:40 +01:00
Simey Lameze 3745973281 MDL-55848 assignfeedback_editpdf: remove problematic class_exists check
Due to a bug on opcache, this check had to be removed along the empty class to avoid
error on assignment grading interface.
2016-11-15 09:05:42 +08:00
David Monllao 3a14f060d1 Merge branch 'MDL-56824-master' of git://github.com/damyon/moodle 2016-11-15 09:03:52 +08:00
Damyon Wiese 204413187e MDL-56952 plugininfo: You can uninstall theme_base 2016-11-15 08:55:41 +08:00
David Monllao 4b96878ab6 Merge branch 'MDL-56834-master-fix1' of http://github.com/damyon/moodle 2016-11-15 08:52:34 +08:00
Andrew Nicols 181b5922ce Merge branch 'MDL-56846-master' of git://github.com/damyon/moodle 2016-11-15 08:05:54 +08:00
Dan Poltawski 493ec714fd Merge branch 'MDL-54871' of https://github.com/bostelm/moodle 2016-11-14 16:27:42 +00:00
Dan Poltawski 729132fa6a Merge branch 'MDL-54782_master' of git://github.com/markn86/moodle 2016-11-14 16:23:33 +00:00
Dan Poltawski f6dabb3194 MDL-56910 filepicker: give button BS styling 2016-11-14 15:46:49 +00:00
Dan Poltawski cead8a8138 Merge branch 'MDL-56426_master' of git://github.com/markn86/moodle 2016-11-14 14:03:10 +00:00
Dan Poltawski 8bcc2cbd8a Merge branch 'MDL-56913' of git://github.com/timhunt/moodle 2016-11-14 13:58:47 +00:00
Dan Poltawski 20f576629b Merge branch 'wip_MDL-48055_master_quiz_activity_report_grade_visibility' of https://github.com/POETGroup/moodle 2016-11-14 13:39:56 +00:00
Dan Poltawski 585ba846da Merge branch 'mdl-56831-master' of https://github.com/Dagefoerde/moodle 2016-11-14 13:21:35 +00:00
Dan Poltawski 55e54953a4 Merge branch 'MDL-56916-master-normalizedoc' of git://github.com/mudrd8mz/moodle 2016-11-14 13:09:48 +00:00
Dan Poltawski 8d857d0ecc Merge branch 'MDL-56839-master' of git://github.com/jleyva/moodle 2016-11-14 13:06:48 +00:00
Dan Poltawski 0b96b9c5c2 Merge branch 'MDL-56618-master' of git://github.com/damyon/moodle 2016-11-14 12:38:32 +00:00
Juan Leyva 449e15f092 MDL-56942 login: Add missing required lib in complete_user_login 2016-11-14 12:07:54 +00:00
Eloy Lafuente (stronk7) 2dcb3746b0 Merge branch 'MDL-56794-master' of git://github.com/damyon/moodle 2016-11-14 12:28:29 +01:00
Dan Poltawski 4af34676f7 MDL-56719 mod_chat: clarify 'course theme' change
Plus remove some pointless code.
2016-11-14 11:09:23 +00:00
Dan Poltawski e7bba8ce4d Merge branch 'MDL-56719-master' of git://github.com/damyon/moodle 2016-11-14 11:06:22 +00:00
Eloy Lafuente (stronk7) dd24216a3b Merge branch 'MDL-56880-m' of https://github.com/micaherne/moodle 2016-11-14 12:04:25 +01:00
Dan Poltawski ed81eab309 Merge branch 'MDL-56935-master' of git://github.com/junpataleta/moodle 2016-11-14 10:49:23 +00:00
Eloy Lafuente (stronk7) 95bfa52549 Merge branch 'MDL-56882-master' of git://github.com/crazyserver/moodle 2016-11-14 11:14:37 +01:00
Dan Poltawski ea70612b00 Merge branch 'MDL-56435-master' of git://github.com/damyon/moodle 2016-11-14 10:10:54 +00:00
Dan Poltawski 51d9431e48 Merge branch 'MDL-56931-master' of https://github.com/snake/moodle 2016-11-14 10:03:48 +00:00
Damyon Wiese cf199b4448 MDL-56834 boost: Be cautious about nodes in the navbar
Some pages (fresh install) don't have the navbar yet, so check for null.
2016-11-14 17:18:29 +08:00
Pau Ferrer Ocaña 0ffe8d2f0c MDL-56882 assign: Enable revert outcomes to No outcome 2016-11-14 09:56:35 +01:00
Dan Poltawski d017e3fb48 Merge branch 'MDL-56398-master' of git://github.com/lameze/moodle 2016-11-14 08:34:13 +00:00
David Monllao 337b723b07 Merge branch 'MDL-56803-master' of git://github.com/damyon/moodle 2016-11-14 16:25:43 +08:00
Dan Poltawski 6b8c8f4bc2 Merge branch 'MDL-56711-master' of git://github.com/damyon/moodle 2016-11-14 08:21:14 +00:00
Damyon Wiese f93bdccab7 MDL-56803 boost: hide region-main settings menu on 1 col layouts 2016-11-14 16:02:55 +08:00
Mark Nelson f34df17977 MDL-56426 core_message: prevent page jump when viewing notif. settings 2016-11-14 16:02:42 +08:00
Damyon Wiese 04165cd446 MDL-56803 glossary: More style fixes for glossary
Fix checkbox alignment for search on small screens, and put separation
between glossary items in a list.
2016-11-14 16:02:09 +08:00
Andrew Nicols 125bd58ff9 Merge branch 'MDL-56657-master' of git://github.com/damyon/moodle 2016-11-14 15:46:31 +08:00
Damyon Wiese 1093b461f6 MDL-56803 mod_glossary: Fix styles for boost theme 2016-11-14 15:43:58 +08:00
Marina Glancy f31e1e8b25 MDL-56899 filter: suppress dom parsing errors
Domdocument does not know about <video> and <audio> tags, also it's too strict for html style
solution from http://stackoverflow.com/questions/6090667/php-domdocument-errors-warnings-on-html5-tags
2016-11-14 15:16:09 +08:00
Damyon Wiese 2f3f8e45da MDL-56657 admin: Style all admin/role pages for boost 2016-11-14 15:11:15 +08:00
Damyon Wiese f619064b9b MDL-56719 boost: Style mod_chat for boost
I stayed away from big markup changes. This is a table layout so needs rewriting which is a big job.
2016-11-14 15:08:57 +08:00
Andrew Nicols cfade93cb8 Merge branch 'MDL-56785-master' of git://github.com/lameze/moodle 2016-11-14 15:06:40 +08:00
David Monllao fd887df697 Merge branch 'MDL-56888-master-workshop-leap2a' of git://github.com/mudrd8mz/moodle 2016-11-14 15:01:21 +08:00
Damyon Wiese fe3db0ca08 MDL-56618 theme_boost: Fix backup / restore pages (again)
I removed most of the layout styles and started again.
2016-11-14 15:00:46 +08:00
Andrew Nicols 87264a2022 Merge branch 'MDL-56845-master' of git://github.com/damyon/moodle 2016-11-14 14:44:07 +08:00
Andrew Nicols 622c84f630 Merge branch 'MDL-56853-master' of git://github.com/damyon/moodle 2016-11-14 14:36:45 +08:00
Simey Lameze 27a5b91f45 MDL-56398 core_message: make modals consistent across themes 2016-11-14 14:35:38 +08:00
Andrew Nicols 8f3a295c6e Merge branch 'MDL-56242-master' of git://github.com/damyon/moodle 2016-11-14 14:07:36 +08:00
David Monllao 9444636cb8 Merge branch 'MDL-56834-master' of git://github.com/damyon/moodle 2016-11-14 14:00:45 +08:00
Andrew Nicols 49ae3661d3 Merge branch 'MDL-56769-master' of git://github.com/damyon/moodle 2016-11-14 13:38:00 +08:00
Jun Pataleta cf2bc26911 MDL-56935 theme_boost: Fix double escaping of navbar items 2016-11-14 13:35:26 +08:00
Damyon Wiese c1ae9079db MDL-56187 theme_boost: Atto fields styling for validation errors 2016-11-14 13:13:46 +08:00
Mark Nelson 7dbc501811 MDL-54782 core_message: deprecated/removed strings from lang file 2016-11-14 12:09:46 +08:00
Jake Dallimore 7135bbb188 MDL-56931 themes: fix for module edit menu on course home
Increased bottom padding to allow space for the lower edit menus to be
displayed without a vertical scrollbar.
2016-11-14 11:52:00 +08:00
Damyon Wiese bf5dcc8abb MDL-56724 mod_choice: coding style fixes
For the lines affected by this patch.
2016-11-14 11:38:36 +08:00
Damyon Wiese eaf45bce09 MDL-56724 boost: Update mod_choice to use bootstrap classes for styles 2016-11-14 11:37:45 +08:00
Damyon Wiese 7d41ccf0fb MDL-56794 boost: Styling for forum module 2016-11-14 11:30:17 +08:00
Damyon Wiese 0f76052836 MDL-56824 mod_lesson: Style fixes for theme_boost 2016-11-14 11:20:55 +08:00
Damyon Wiese f2405a5f5c MDL-56242 theme_boost: Fix styling for confirm boxes (js and in page)
They should be left aligned with a header, content and footer (right aligned with the buttons).

There should be a primary continue button and a secondary cancel button.
2016-11-14 11:11:28 +08:00
Damyon Wiese a7bebd0638 MDL-56834 boost: Nav for participants page
On the participants page, hide the small cog and put a region main
settings menu with all the nodes from the "Users" branch in the settings
block.
2016-11-14 10:40:41 +08:00
Damyon Wiese 7b02521c39 MDL-56435 boost: Better styling for competencies in boost
Changes
    - add custom-select to all select fields
    - add btn btn-primary/secondary to all buttons
    - add list-inline to all lists with inline class
    - style dropdowns like a bootstrap menu
    - add col-md-6 to span6
2016-11-14 10:31:01 +08:00
Jan Dageförde c2e123355d MDL-56831 quiz: Declare YUI dependencies explicitly where needed 2016-11-13 23:07:00 +01:00
Nadav Kavalerchik 974573b4ea MDL-56921 Atto: Image alignment should not be RTLed in RTL mode. 2016-11-13 12:31:42 +02:00
David Mudrák 6b6a2ec439 MDL-56916 docs: Fix documentation of the normalize_component return 2016-11-12 10:45:29 +01:00
Tim Hunt f31d0fff2e MDL-56913 quiz: teachers should see a review link for a preview
So what they see is like what students see.
2016-11-11 16:51:54 +00:00
AMOS bot 4827eaa744 Automatically generated installer lang files 2016-11-12 00:28:50 +08:00
Juan Leyva 5222cb1ce8 MDL-56905 tool_mobile: Return private tokens just after log-in 2016-11-11 15:21:01 +00:00
Juan Leyva b5f3e90e1c MDL-56739 auth: Support launching the app upon user confirm 2016-11-11 15:06:36 +00:00
Dan Poltawski b1f3de5793 MDL-56895 porfolio: give buttons bootstrap styling 2016-11-11 12:39:35 +00:00
Dan Poltawski 0b8e0c374f on-demand release 3.2beta+ 2016-11-11 12:06:14 +00:00
Dan Poltawski e9eec33560 Merge branch 'MDL-56602-master-upgrade' of git://github.com/andrewnicols/moodle 2016-11-11 10:22:20 +00:00
Andrew Nicols 9fa6d4e04e Merge branch 'MDL-55121-master' of git://github.com/lameze/moodle 2016-11-11 15:12:50 +08:00
Damyon Wiese 058edbafc8 MDL-56711 theme_boost: Highlight sections at activity level
When looking at an activity, the current section for the course should be active in the flat navigation.
2016-11-11 14:27:56 +08:00
Andrew Nicols ea10a0319b MDL-56602 core: Lock themerev during upgrade
This also changes install to use a fixed themerev.
2016-11-11 14:15:00 +08:00
Andrew Nicols fe86e2f034 Merge branch 'wip-mdl-56189' of https://github.com/rajeshtaneja/moodle 2016-11-11 14:07:10 +08:00
Rajesh Taneja 259d3742f9 MDL-56189 behat: Fixed xpath to use contains class 2016-11-11 13:45:33 +08:00
Andrew Nicols 56fb91bc38 Merge branch 'MDL-55994' of https://github.com/bostelm/moodle 2016-11-11 13:29:57 +08:00
Simey Lameze 51f3693cdb MDL-55121 environment: check for unsuported php version 7.1 2016-11-11 12:37:07 +08:00
Andrew Nicols 9c56f904d2 Merge branch 'MDL-56768-master-fix1' of http://github.com/damyon/moodle 2016-11-11 12:15:55 +08:00
David Monllao 3ecf492a75 Merge branch 'MDL-56811-master' of git://github.com/damyon/moodle 2016-11-11 12:13:30 +08:00
Andrew Nicols 6b7b3e59f2 Merge branch 'MDL-56417_master' of https://github.com/dmonllao/moodle 2016-11-11 11:53:41 +08:00
Andrew Nicols 06cca0158c Merge branch 'MDL-56190-master-fix1' of http://github.com/damyon/moodle 2016-11-11 11:39:48 +08:00
Damyon Wiese 7becb39f63 MDL-56768 gradereport_grader: Fix point the user column floats
Need to account for body margin when calculating whether to float the
user column.
2016-11-11 11:34:48 +08:00
Andrew Nicols a044ff57a1 Merge branch 'MDL-52216_master' of https://github.com/eugeneventer/moodle-fixes 2016-11-11 11:21:26 +08:00
Damyon Wiese f46fab0ea1 MDL-56190 clean: Fix grade restriction styles
Grade restriction is now broken into 3 lines - but it needed custom
padding.
2016-11-11 11:04:18 +08:00
Rajesh Taneja e57c0f41ad MDL-56860 behat: Fixed moodle_list format and printer description 2016-11-11 07:47:34 +08:00
Adrian Greeve f65db49765 MDL-56363 mod_assign: Restrictions added for tutors.
If the grader does not have the accessallgroups capability,
or groups mode is set to separate groups and the user is not
a member of the group then no participants are shown.
2016-11-11 00:28:33 +01:00
Eugene Venter dbd8cadb5c MDL-52216 mod_lesson: prevent invalid view modes 2016-11-11 09:19:37 +13:00
Michael Aherne 51c6d25b3b MDL-56880 webservices: Fix documentation of get_enabled_plugins() 2016-11-10 16:18:06 +00:00
Dan Poltawski 6063f62e7d Merge branch 'MDL-56725-master' of git://github.com/damyon/moodle 2016-11-10 15:37:38 +00:00
Dan Poltawski a3ead7172b Merge branch 'MDL-55249_m32v1' of https://github.com/sbourget/moodle 2016-11-10 15:01:41 +00:00
Dan Poltawski e3cc23ae86 Merge branch 'MDL-56720-master' of git://github.com/junpataleta/moodle 2016-11-10 15:00:21 +00:00
Dan Poltawski 213fc325ad MDL-56652 roles: Add padding to capability filter 2016-11-10 14:44:17 +00:00
Dan Poltawski f41218d9fd Merge branch 'MDL-56652-master' of git://github.com/lameze/moodle 2016-11-10 14:37:00 +00:00
David Mudrák 48ea715da0 MDL-56888 workshop: Fix Leap2A export of the workshop submission
The whole story described in the tracker. Shortly, Mahara seems to have
a bug (or undocumented feature) that it expects the Leap2A content
wrapped in a single container.
2016-11-10 15:30:11 +01:00
Dan Poltawski c220e6d8c7 Merge branch 'MDL-56189-master' of git://github.com/damyon/moodle 2016-11-10 14:06:02 +00:00
Dan Poltawski a4b0cfa3f7 Merge branch 'MDL-56768-master' of git://github.com/damyon/moodle 2016-11-10 13:51:11 +00:00
Dan Poltawski d5d6eda93c Merge branch 'MDL-55777-master' of git://github.com/ankitagarwal/moodle 2016-11-10 13:46:10 +00:00
Dan Poltawski 158ab03e12 Merge branch 'MDL-56190-master' of git://github.com/damyon/moodle 2016-11-10 13:43:35 +00:00
Eloy Lafuente (stronk7) 55f171a1d6 Merge branch 'MDL-53481-master-uniqsqlparam' of git://github.com/mudrd8mz/moodle 2016-11-10 13:11:50 +01:00
Dan Poltawski f670b39e69 Merge branch 'MDL-56602-master-2' of git://github.com/andrewnicols/moodle 2016-11-10 11:26:14 +00:00
Juan Leyva b0f00b3166 MDL-56739 auth: Support new redirect parameter in confirmation 2016-11-10 09:35:21 +00:00
Juan Leyva d6a25bc49a MDL-56739 auth: Support custom confirmation URL 2016-11-10 09:35:21 +00:00
David Mudrák 445aa472b9 MDL-53481 availability: Fix unit test to not execute the huge query
Some DBs have troubles to execute such a huge query as generated in this
test. We do not actually need to execute it. All we need is to make sure
that the parameter placeholders are enumerated correctly. So it is what
this new test does.
2016-11-10 09:52:31 +01:00
Simey Lameze 2e1c739a28 MDL-56652 core_roles: Add BS4 styling to define roles form 2016-11-10 16:46:54 +08:00
Damyon Wiese 560a43f24c MDL-56190 availability: Styling on boost and clean
Update the HTML coming from the JS to include bootstrap classes.
Delete as many styles from boost scss as possible.
Regression test on clean and do final tweaks in less.
2016-11-10 16:30:00 +08:00
Damyon Wiese 930ce60550 MDL-56725 mod_data: better field alignment
Labels containing only accesshide text should have the accesshide class
on the label, not the content so the label does not push the content
down.
2016-11-10 16:25:48 +08:00
Damyon Wiese 398be7c897 MDL-56725 mod_data: coding style
Fixes from lines in the previous commit.
2016-11-10 16:21:01 +08:00
Damyon Wiese e85fda95c6 MDL-56725 mod_data: Style fixes for boost theme 2016-11-10 16:21:01 +08:00
Damyon Wiese 1572a39251 MDL-56768 boost: Special positioning for grader report
Grader report has custom overflow handling which does not cope with a
scrollable content region. So we need to make the content region flow
weirdly out to the right of the page, and push the blocks underneath -
even on really wide screens where it looks bad. We also needed to
upgrade the custom scroll code to handle the margin on the body
changing.
2016-11-10 16:17:49 +08:00
Juan Leyva 1e17258b66 MDL-56268 webservice: Format backtrace to avoid display private data 2016-11-10 16:15:31 +08:00
Simey Lameze face152176 MDL-51347 core_notes: check view notes capability by course context 2016-11-10 16:15:31 +08:00
Tim Hunt cf0b9432d8 MDL-53744 question file access: fix access checks 2016-11-10 16:15:31 +08:00
Juan Leyva 42778e124e MDL-56065 user: Fix update_users Web Service
Users won’t be updated if:
- They are admins and the user updating is not
- They are the guest user
- They are mnet users
- They are deleted users
2016-11-10 16:15:31 +08:00
Dan Poltawski fd9eb89022 Merge branch 'wip-MDL-56855-master' of https://github.com/marinaglancy/moodle 2016-11-10 08:14:42 +00:00
Damyon Wiese f43155b65a MDL-56189 theme_boost: Padding for modgrade form elements 2016-11-10 16:13:34 +08:00
Dan Poltawski da55f3582b Merge branch 'MDL-56705-master' of git://github.com/damyon/moodle 2016-11-10 08:03:37 +00:00
Simey Lameze 1954b9d5c9 MDL-56785 theme_boost: remove unnecessary styling 2016-11-10 15:48:30 +08:00
Damyon Wiese 6fe0b5bd9b MDL-56769 boost: Change last link in settings menu
Was: "Course/Frontpage administration"
Now: "More..."
2016-11-10 15:20:53 +08:00
Damyon Wiese e7bda18de6 MDL-56705 forms: Use [] for multiple values
Some "select" based form elements are not inheriting directly from
MoodleQuickForm_select - so did not have the adjustment to the form
field name that allows multiple values. I moved this fix to the
templateable trait so all the form fields get this fix.
2016-11-10 14:57:58 +08:00
Marina Glancy 69ba7bf659 MDL-56855 media_videojs: MPEG-2 is not supported 2016-11-10 14:46:47 +08:00
Nicholas Hoobin b86c685075 MDL-56417 session: Respect the return value of ignore_timeout_hook. 2016-11-10 14:24:24 +08:00
David Monllao a6fa0d9c97 Merge branch 'MDL-56766-master' of git://github.com/danpoltawski/moodle 2016-11-10 13:54:09 +08:00
Damyon Wiese 16076f1e3d MDL-56811 forum: Auto create the latest news forum
When a course is created or updated, create a news forum if the
newsitems setting is > 0.
2016-11-10 13:51:02 +08:00
David Monllao 8b3a8fa707 Merge branch 'wip-mdl-56397' of https://github.com/rajeshtaneja/moodle 2016-11-10 13:46:37 +08:00
David Monllao 096a418d01 Merge branch 'MDL-56715-master' of https://github.com/xow/moodle 2016-11-10 13:19:01 +08:00
Ankit Agarwal f2330472f0 MDL-55777 installation: Check libcurl version on install 2016-11-10 10:16:19 +05:30
Andrew Nicols 3302e8bfa5 Merge branch 'MDL-56820-master' of https://github.com/snake/moodle 2016-11-10 12:20:17 +08:00
Andrew Nicols 002ea88630 Merge branch 'MDL-54646-master' of git://github.com/junpataleta/moodle 2016-11-10 11:46:59 +08:00
Jake Dallimore 700ef87691 MDL-56820 themes: Fix user search drop down on grading page for boost
Fixes a problem where the drop down list is cut off by overflow.
2016-11-10 11:45:59 +08:00
Andrew Nicols 3b77723701 Merge branch 'MDL-56051-master' of git://github.com/damyon/moodle 2016-11-10 11:45:01 +08:00
David Monllao 5473943cac Merge branch 'MDL-56832-master' of git://github.com/danpoltawski/moodle 2016-11-10 11:43:51 +08:00
David Monllao af49935a53 Merge branch 'MDL-56753-master' of git://github.com/lameze/moodle 2016-11-10 11:38:24 +08:00
John Okely eea9f10900 MDL-56715 form: Allow password unmask fields to be cleared in FF49 2016-11-10 11:22:59 +08:00
Simey Lameze 763f7b05ae MDL-56753 mod_assign: behat tests for groups and grouping counting 2016-11-10 11:09:37 +08:00
Andrew Nicols 96eba6b982 Merge branch 'MDL-55883_m32v1' of https://github.com/sbourget/moodle 2016-11-10 11:06:11 +08:00
Tomasz Muras ff1fc4d9f4 MDL-54646 tags: Hide manage tags in menu if tags disabled. 2016-11-10 10:59:06 +08:00
Simey Lameze 426bb5ae0f MDL-56753 mod_assign: fix groups and submitted counting on grading summary
This also fixes a coding error that was displayed when a group was not part of
assignment grouping.
2016-11-10 10:58:29 +08:00
Andrew Nicols b8af6c1ef0 Merge branch 'MDL-56585-master' of git://github.com/danpoltawski/moodle 2016-11-10 09:53:28 +08:00
Andrew Nicols 743f9c8c42 Merge branch 'wip-mdl-56840' of https://github.com/rajeshtaneja/moodle 2016-11-10 09:38:26 +08:00
Andrew Nicols a6f85967e0 Merge branch 'MDL-56754-master' of git://github.com/jleyva/moodle 2016-11-10 08:29:04 +08:00
Andrew Nicols 9d75a519f3 MDL-56602 themes: Use version number as base themerev 2016-11-10 08:02:31 +08:00
Adam Olley d456bd42c3 MDL-56823 session: redis sessions don't honour $CFG->sessiontimeout
The redis session handler doesn't use the sessiontimeout config setting
to determine session lifetime.

It has a lock expiry, which is set to 7200 (or a config setting) that is
used to determine how long a lock is held onto, but that should be
distinct from the session timeout.
2016-11-10 10:30:04 +10:30
Juan Leyva 6406431537 MDL-56839 upgrade.txt: Fix incorrect information in lib/upgrade.txt 2016-11-09 21:00:33 +00:00
Dan Poltawski 757aef2334 MDL-56766 calendar: improve calendar export labels 2016-11-09 17:00:05 +00:00
Dan Poltawski 2c212753fe MDL-56585 tool_lpimportcsv: adjust help popups 2016-11-09 16:11:41 +00:00
Dan Poltawski bc2aaef4fa MDL-56832 theme_boost: Mention CSS in setting description 2016-11-09 14:50:07 +00:00
Dan Poltawski 224789b79c Merge branch 'MDL-56863-master' of git://github.com/jleyva/moodle 2016-11-09 14:38:26 +00:00
Juan Leyva 678555b499 MDL-56863 tool_mobile: Capture moodle_exception in get_autologin_key 2016-11-09 13:20:49 +00:00
Dan Poltawski 793fe29014 Merge branch 'MDL-48498-master-iv6-undefinedfix' of https://github.com/snake/moodle 2016-11-09 12:16:03 +00:00
Juan Leyva 82f5802a94 MDL-56754 course: Stealth sections should be handled
Right now this WS is returning all the sections without advising if is
a stealth section or not, this have some implications (in the mobile
app right now the stealth sections are displayed)
2016-11-09 09:38:46 +00:00
Andrew Nicols a2567336df Merge branch 'MDL-56755-m' of https://github.com/micaherne/moodle 2016-11-09 15:42:32 +08:00
Andrew Nicols 4cc6477198 Merge branch 'MDL-56790-master' of git://github.com/damyon/moodle 2016-11-09 15:40:16 +08:00
Damyon Wiese b8396c335a MDL-56662 boost: Don't mess with display, set min-height
Changing the display was messing with the layout of some things in the
file picker. Lets set the min-height instead which has less
side-effects.
2016-11-09 15:14:24 +08:00
Damyon Wiese eacf30e61f MDL-56051 blocks: Support drag and drop blocks in boost. 2016-11-09 14:42:18 +08:00
Andrew Nicols 55a3911408 Merge branch 'MDL-56726-master-cfgadmin' of git://github.com/mudrd8mz/moodle 2016-11-09 14:37:47 +08:00
David Monllao 4e2ae9caee Merge branch 'MDL-56596-master-fix' of git://github.com/andrewnicols/moodle 2016-11-09 14:35:41 +08:00
David Monllao 33788800ec Merge branch 'MDL-56133' of https://github.com/NeillM/moodle 2016-11-09 14:23:50 +08:00
David Monllao 3f066469af Merge branch 'wip-mdl-56630-fix2' of git://github.com/rajeshtaneja/moodle 2016-11-09 14:14:51 +08:00
Andrew Nicols f2dab83445 MDL-56596 tool_usertours: Update to tours v0.9.9 2016-11-09 14:10:31 +08:00
David Monllao 38b74ef717 Merge branch 'MDL-56662-master' of git://github.com/damyon/moodle 2016-11-09 13:58:01 +08:00
Rajesh Taneja d514d25e0a MDL-56630 behat: Click on link in specificed block/region 2016-11-09 13:56:49 +08:00
Damyon Wiese f87084f8f1 MDL-56662 theme_boost: Filepickers have 0 height
We need to set a display value on the file picker body so the inline height is ignored.
2016-11-09 13:55:45 +08:00
Rajesh Taneja 26ca972e9e MDL-56840 behat: Wait till pdf conversion progress is finished 2016-11-09 13:39:00 +08:00
Damyon Wiese ba4173384d MDL-56853 mod_folder: Review styles in boost
Remove random center-alignment and put buttons on a single line.
2016-11-09 13:35:08 +08:00
Rajesh Taneja bd955bfea7 MDL-56397 behat: updated composer.lock to use behat 3.2.2
Behat 3.2.2 fixes transformation issue
2016-11-09 13:31:22 +08:00
David Monllao 6e986b2919 Merge branch 'mdl-54852-master' of https://github.com/Dagefoerde/moodle 2016-11-09 13:07:26 +08:00
David Monllao 0c499e0a5c Merge branch 'MDL-53481-master-uniqsqlparam' of git://github.com/mudrd8mz/moodle 2016-11-09 12:49:17 +08:00
David Monllao 7ecf7511f8 Merge branch 'MDL-56694-master' of git://github.com/lameze/moodle 2016-11-09 12:24:17 +08:00
Andrew Nicols 16f9660cfe Merge branch 'MDL-56196-master' of git://github.com/damyon/moodle 2016-11-09 11:59:02 +08:00
Jake Dallimore c02778ac30 MDL-48498 admin: fix get_setting return for mixedhostiplist setting 2016-11-09 11:32:58 +08:00
Damyon Wiese 50302c404a MDL-56790 boost: Styling fixes for mod_feedback
Also fixed are problems with frozen select from elements showing raw
HTML. I checked the other form templates for similar problems and fixed
them all.
2016-11-09 11:29:58 +08:00
Andrew Nicols cfa4b26231 Merge branch 'MDL-56792-master-v2' of git://github.com/lameze/moodle 2016-11-09 11:27:57 +08:00
Simey Lameze cff1f90adf MDL-56792 core_charts: clean html content from title and labels
This commit add cleanData() and call it from all places that has labels or title
to guarantee that html content will not be printed on the chart.
2016-11-09 10:41:12 +08:00
Damyon Wiese 64a5bc94e9 MDL-56846 mod_survey: Fix styles in boost
Add bootstrap classes to form fields and remove random centered text.
2016-11-09 10:02:26 +08:00
Andrew Nicols 43bdbbf682 Merge branch 'MDL-56607-master' of git://github.com/jleyva/moodle 2016-11-09 09:39:48 +08:00
Damyon Wiese 3ae54e045a MDL-56845 admin: Change default for adminlinkcategories
Change the default for adminlinkcategories from false to true because it
helps navigate the site admin settings in boost.
2016-11-09 09:37:37 +08:00
Eloy Lafuente (stronk7) 6c5ee657a7 Merge branch 'MDL-56699-master' of git://github.com/damyon/moodle 2016-11-09 02:11:55 +01:00
David Monllao 0cbfb7ff2a Merge branch 'MDL-56409-master' of git://github.com/ankitagarwal/moodle 2016-11-09 08:36:36 +08:00
Stephen Bourget 3bf46ee717 MDL-55566 chat: Improve next scheduled chat message 2016-11-08 16:00:05 -05:00
Stephen Bourget 3a2f9a2ea4 MDL-55869 mod_chat: Only create calendar events when chat is published 2016-11-08 14:57:32 -05:00
Dan Poltawski 231e2ec99a Merge branch 'MDL-56555-master' of git://github.com/andrewnicols/moodle 2016-11-08 17:56:12 +00:00
Dan Poltawski e20c8ddc80 Merge branch 'MDL-48498-master-iv6' of https://github.com/snake/moodle 2016-11-08 17:51:17 +00:00
Dan Poltawski 674c4f6891 Merge branch 'MDL-56596-master' of git://github.com/andrewnicols/moodle 2016-11-08 13:43:54 +00:00
David Mudrák 93f4f3494a MDL-53481 availability: Fix uniqueness of SQL named param placeholders
Static variables do not behave the way you might expect when accessing
them through the classes inheritance. When accessing a method via self::
or static:: operators, even though the method is inherited, its variable
scope is not. So the method unique_sql_parameter() was using the scope
of the child class and each child class had its own sequence of usp1,
usp2, usp3, ... placeholders. This led to "Incorrect number of query
parameters" error when multiuple condition classes were contributing to
a single SQL query.

All credit should go to Adam Olley who debugged and described the
essence of the problem in the tracker.
2016-11-08 13:36:07 +01:00
Neill Magill 6a6f2e1ca6 MDL-56133 tool_langimport: Changes should be visible after import
Before this change if a language pack was updated by the
\tool_langimport\task\update_langpacks_task scheduled task, changes
would not be available to users until an admin manually cleared the
strings cache.

This change causes the cache to purged when a language pack it update,
this will cause it to rebuild so users will start seeing updates
automatically.
2016-11-08 10:56:56 +00:00
Dan Poltawski 258d07d37e Moodle release 3.2beta
Make Moodle Great Again ;-)
2016-11-08 10:25:31 +00:00
Dan Poltawski fc760dd19e NOBUG: Fixed SVG browser compatibility 2016-11-08 10:19:16 +00:00
Dan Poltawski 060171774b Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-11-08 10:19:15 +00:00
Rajesh Taneja e4c98de168 MDL-56630 behat: Click on link in specificed block/region 2016-11-08 18:06:09 +08:00
Juan Leyva 9d92a3a6ba MDL-56607 settings: Remove Mobile settings from WS overview 2016-11-08 09:52:16 +00:00
Michael Aherne db8514bcff MDL-56755 assign: Improve documentation of assign::get_grade_item() 2016-11-08 08:58:31 +00:00
Ankit Agarwal 20ab51fdbc MDL-56409 messages: Save one db query per page load 2016-11-08 12:50:30 +05:30
Jake Dallimore 605bab84ce MDL-48498 core_files: Add security helper to curl class
Allow injection of security_helper objects into curl, but default
to a core helper tied to http security settings values.
2016-11-08 15:11:15 +08:00
Jake Dallimore f6d9efefaa MDL-48498 core_files: curl_security_helper_base and implementation
Base class and core implementation providing a means to check URLs
against the curl security admin settings entries.
2016-11-08 15:11:15 +08:00
Jake Dallimore 067268942c MDL-48498 admin: new setting types for curl host/port restrictions
Two new classes in lib/adminlib. One providing validation for a
newline-delimited textarea supporting domain names, domain wildcards,
IPv4/IPv6 addresses and IPv4/IPv6 ranges. The second providing
validation for a newline-delimited textarea of port numbers.
2016-11-08 15:10:35 +08:00
Simey Lameze d138d6e2ac MDL-56694 theme_boost: center login button in filepicker 2016-11-08 15:01:03 +08:00
David Monllao d72c9774ae Merge branch 'wip-mdl-56630' of git://github.com/rajeshtaneja/moodle 2016-11-08 14:47:25 +08:00
Rajesh Taneja dc90838aaa MDL-56630 behat: Click on link in specificed block/region 2016-11-08 14:45:43 +08:00
Andrew Nicols 3739b8b886 Merge branch 'wip-mdl-55215' of https://github.com/rajeshtaneja/moodle 2016-11-08 14:31:33 +08:00
Damyon Wiese 9280f62e38 MDL-56196 mod_lti: Fix popups and secret form in boost 2016-11-08 14:27:26 +08:00
Rajesh Taneja eaefd5bc57 MDL-55215 behat: autocomplete field requires javascript 2016-11-08 14:21:52 +08:00
Frédéric Massart 3d979f9676 MDL-56196 mod_lti: Adapt templates for both Boost and Clean 2016-11-08 14:11:14 +08:00
Jake Dallimore 89e20c74d5 MDL-54751 core_course: Fixed event type checks in adhoc deletion tests 2016-11-08 13:53:00 +08:00
Andrew Nicols 592c691c8f MDL-56555 tool_usertours: Update tool sharing link 2016-11-08 13:51:11 +08:00
Andrew Nicols 3e85e02a98 Merge branch 'MDL-55992-master' of git://github.com/jleyva/moodle 2016-11-08 13:41:22 +08:00
Andrew Nicols 11361f35be MDL-56737 externallib: Fetch token after inserting 2016-11-08 12:45:57 +08:00
David Monllao dc3852ae1e Merge branch 'MDL-56601-master-3' of git://github.com/cameron1729/moodle 2016-11-08 12:25:31 +08:00
Cameron Ball c86500a4b7 MDL-56601 core_user: Disable profile picture field if user is not setup
Sometimes it is possible that a user is presented with the profile
edit form, but is in a state where they are not considered fully
set up (one example is when a site is installed using the CLI script)

In these cases the filepicker gets upset when the user tries
to upload a profile picture.

This patch simply disables that field in these cases and replaces it
with an error message explaining what's wrong.
2016-11-08 12:13:51 +08:00
David Monllao 1fd6b25579 MDL-56561 bootstrapbase: Remove empty line 2016-11-08 11:39:28 +08:00
David Monllao 23e6d7f36c Merge branch 'MDL-56561-master' of git://github.com/damyon/moodle 2016-11-08 11:38:49 +08:00
David Monllao d5e22210b6 Merge branch 'MDL-29795-master-fix-backup-restore' of git://github.com/ilya-catalyst/moodle 2016-11-08 11:12:17 +08:00
Damyon Wiese aad8c7167f MDL-56561 admin: Style admin page listing entire admin tree
It was an unstyled list of links. This changes it to tabs with sub-headings.
2016-11-08 11:04:10 +08:00
Andrew Nicols 9c5a55b52a Merge branch 'wip-MDL-56120-master-v2' of git://github.com/abgreeve/moodle 2016-11-08 10:31:12 +08:00
David Monllao 929190533f Merge branch 'MDL-56818-master' of git://github.com/lameze/moodle 2016-11-08 10:27:36 +08:00
Simey Lameze 0b20349f32 MDL-56818 messages: remove duplicated messaging enabled check 2016-11-08 10:26:39 +08:00
Ilya Tregubov f67f5f0245 MDL-29795 assign: add missing sortorder column for overrides when backing up a course 2016-11-08 13:23:22 +11:00
Andrew Nicols f4e203209d Merge branch 'MDL-54751_master-fix-cron-user' of git://github.com/dmonllao/moodle 2016-11-08 10:01:04 +08:00
David Monllao d0cccb4fdb Merge branch 'MDL-53718' of git://github.com/aolley/moodle 2016-11-08 09:59:31 +08:00
David Monllao 44eb1490c4 MDL-54751 course: Set adhoc task user
We should complete the deletion process using the same
user that started it.

Added a new param to loginas() to prevent the event to be generated as
there is no need to generate an new event for that as the user didn't
explicitly loginas again.
2016-11-08 09:45:07 +08:00
Eloy Lafuente (stronk7) 42fe364f41 Merge branch 'MDL-56765-master' of git://github.com/jleyva/moodle 2016-11-08 01:27:39 +01:00
Henning Bostelmann c448ab3f44 MDL-54871 mod_data: Remove text field when forced name present 2016-11-07 21:59:37 +00:00
Eloy Lafuente (stronk7) a584a403cd Merge branch 'MDL-54916' of https://github.com/mr-russ/moodle 2016-11-07 16:19:06 +01:00
Dan Poltawski 77b0bafa6d Merge branch 'MDL-56696-master' of git://github.com/lameze/moodle 2016-11-07 11:33:55 +00:00
Juan Leyva 0c6c86643e MDL-56607 settings: Move mobile settings to top-level
AMOS BEGIN
 MOV [mobilecssurl,core_admin],[mobilecssurl,tool_mobile]
 MOV [configmobilecssurl,core_admin],[configmobilecssurl,tool_mobile]
AMOS END

From Plugins / Web Services / Mobile to Appearance / Mobile
2016-11-07 09:53:29 +00:00
Jan Dageförde f928c24dcc MDL-54852 assignment: Suppress "leave page" warning after save
If the user navigates away from the grading page immediately
after saving the grading form, the browser warning can be
safely omitted, as there are no unsaved changes. This is achieved
by calling `reset_form_dirty_state()` of the core_formchangechecker
YUI module, which is responsible for the warning.
2016-11-07 10:35:06 +01:00
Dan Poltawski 13ab169cb7 Merge branch 'wip-MDL-56788-master' of git://github.com/abgreeve/moodle 2016-11-07 09:01:24 +00:00
Adrian Greeve cbbca0d00f MDL-56120 Calendar: Unit tests for getting events.
Added a unit test for checking that calendar_get_events
will only return events for activated activities.
2016-11-07 16:48:16 +08:00
Adrian Greeve 7a33494d71 MDL-56120 calendar: Fix disabled modules showing events.
calendar_get_events now checks for disabled activities
and only shows events for active modules.
2016-11-07 16:47:14 +08:00
Dan Poltawski 912d854dc8 Merge branch 'MDL-56684-master-fix1' of http://github.com/damyon/moodle 2016-11-07 08:19:16 +00:00
Damyon Wiese c81a34774e MDL-56684 boost: Fix for competency behat tests with boost theme 2016-11-07 16:02:44 +08:00
Andrew Nicols 09b7cfc559 Merge branch 'MDL-56025-master' of git://github.com/damyon/moodle 2016-11-07 15:09:47 +08:00
Andrew Nicols f1b018f511 Merge branch 'MDL-55215-master-fix2' of http://github.com/damyon/moodle 2016-11-07 15:01:46 +08:00
David Monllao 5ffd3f3309 Merge branch 'MDL-54751-master-gradeitemfix' of git://github.com/snake/moodle 2016-11-07 14:43:23 +08:00
Damyon Wiese c3e7274369 MDL-56025 messages: Reduce the height on short screens
On windows shorter than 670px reduce the height of the message area.
2016-11-07 14:41:21 +08:00
Jake Dallimore a9ac13885c MDL-54751 core_grade: Fix missing require_once in grade_item get_name 2016-11-07 14:35:16 +08:00
Simey Lameze b445f4b342 MDL-56696 message: link user full name to contact options 2016-11-07 14:35:13 +08:00
Damyon Wiese 737b54fe9e MDL-55215 lesson: JS is required for some lesson behats
Lesson is using the searchselector which only supports JS - so some
tests need javascript tags.

Also fixed support for filling a passwordunmask field with JS enabled by
id.
2016-11-07 14:23:46 +08:00
David Monllao d7480befdd Merge branch 'wip-MDL-38158-fix3' of https://github.com/marinaglancy/moodle 2016-11-07 14:19:15 +08:00
David Monllao 2a9275601a Merge branch 'master_MDL-54575' of git://github.com/danmarsden/moodle 2016-11-07 13:58:04 +08:00
Adam Olley b4846b88d9 MDL-53718 badges: Dont display course badges when disabled 2016-11-07 15:56:26 +10:30
Andrew Nicols a2c0528802 Merge branch 'MDL-56737-master' of git://github.com/jleyva/moodle 2016-11-07 13:25:41 +08:00
David Monllao b03a53576d Merge branch 'MDL-56630-master' of git://github.com/damyon/moodle 2016-11-07 13:15:03 +08:00
Ankit Agarwal 55af4309f7 MDL-56409 messages: Do not fetch notifications if they are disabled 2016-11-07 09:59:11 +05:30
Marina Glancy fbb36ed1e6 MDL-38158 media: some players do not want fallback to other players
there is already logic to determine whether html5 is supported;
otherwise we may end up with nested <audio> or <video> tags
2016-11-07 11:55:05 +08:00
Marina Glancy 737638d950 MDL-38158 media: mpeg is not html5 supported format 2016-11-07 11:44:59 +08:00
Andrew Nicols 235a80b2d5 Merge branch 'MDL-55215-master-fix1' of http://github.com/damyon/moodle 2016-11-07 11:39:45 +08:00
Adrian Greeve f0568ed9af MDL-56788 themes: Update require to use admin setting.
The renderer now uses the $CFG->admin setting in the
require_once call.
2016-11-07 11:16:34 +08:00
David Monllao d2790f5c8f Merge branch 'MDL-56129-master' of git://github.com/andrewnicols/moodle 2016-11-07 11:15:58 +08:00
Damyon Wiese 9f592c243c MDL-55215 forms: Searchable selector was reindexing keys 2016-11-07 11:03:17 +08:00
David Monllao ab7c5d1068 Merge branch 'MDL-56731_master' of https://github.com/tonynlin/moodle 2016-11-07 10:44:32 +08:00
Damyon Wiese 72deb9c861 MDL-56630 theme_boost: Edit settings menu not always showing when it should 2016-11-07 10:44:19 +08:00
Damyon Wiese a0bdffbd73 MDL-56630 theme_boost: show blocks under content on small screens
This is tablet size and down.
2016-11-07 10:37:13 +08:00
Andrew Nicols 3e24a75ec3 Merge branch 'MDL-56241-master' of git://github.com/damyon/moodle 2016-11-07 10:22:25 +08:00
Jonathon Fowler 6b0d172379 MDL-56129 core: Change HTTP error code for iOS 10 video playback
This patch changes the effective response code from a 407 to a 403 when
erroring on iOS 10 and when a HTTP_X_PLAYBACK_SESSION_ID HTTP header is
found.

This causes the iOS Media framework to send the cookie with the request
which subsequently succeeds.
2016-11-07 09:55:49 +08:00
Damyon Wiese 1d4928003c MDL-56241 boost: Wrap block footer in a div to emulate old layout
Some block styles are looking for .footer so we'll add it back.
2016-11-07 09:51:39 +08:00
David Monllao cf36f123d5 Merge branch 'MDL-55203' of https://github.com/mr-russ/moodle 2016-11-07 09:49:33 +08:00
Dan Poltawski fb42071776 MDL-56241 theme_boost: add example context to block.mustache 2016-11-07 09:41:05 +08:00
Damyon Wiese f93be27185 MDL-56241 theme_boost: Add content class to blocks
Some of the plugin styles assume .content in the selectors.
2016-11-07 09:41:04 +08:00
Marina Glancy 2a63c0b1c2 MDL-38158 media: missing require and videojs fallback
Problems picked up by behat tests
2016-11-07 09:22:32 +08:00
David Monllao b667a67c47 MDL-29795 mod_assign: Remove empty line 2016-11-07 09:22:02 +08:00
David Monllao cf4019cf40 Merge branch 'MDL-29795_master' of https://github.com/dmonllao/moodle 2016-11-07 09:20:59 +08:00
David Monllao 325ac748b2 MDL-29795 behat: Narrow Edit link scope 2016-11-07 09:19:41 +08:00
Andrew Nicols 741c0e6abe MDL-55215 forms: Rename searchableselector params 2016-11-07 09:06:40 +08:00
Andrew Nicols 0e5db67d8e Merge branch 'MDL-55215-master' of git://github.com/damyon/moodle 2016-11-07 09:04:34 +08:00
David Monllao c9af13123d MDL-54751 course_modules: New major upgrade point
Also trailing whitespace cleaned.
2016-11-07 08:59:04 +08:00
David Monllao 90abff01b3 Merge branch 'MDL-54751-master-v5' of https://github.com/snake/moodle 2016-11-07 08:55:44 +08:00
Russell Smith 57a5974a10 MDL-55203 forms: Use correct admin folder name.
When the admin folder if renamed, the system must replace that when
adding the competencies form elements to the QuickForm Library.
2016-11-07 11:15:34 +11:00
David Monllao 1370e6ca52 Merge branch 'MDL-56149-master' of git://github.com/damyon/moodle 2016-11-07 07:47:27 +08:00
Jake Dallimore f939a6d452 MDL-54751 core_completion: Exclude activities pending deletion 2016-11-07 07:41:59 +08:00
Jake Dallimore ff4230d88e MDL-54751 behat: Support for adhoc module and section deletion in behat
Introduced new behat step for running all pending adhoc tasks and
modified the relavant behat tests.
2016-11-07 07:41:59 +08:00
Jake Dallimore 3704ff8cde MDL-54751 phpunit: Support adhoc module and section deletion in phpunit
Created a new phpunit util function run_all_adhoc_tasks which runs any
pending tasks, for use in unit tests. Added new recyclebin and course
unit tests covering the new functionality.
2016-11-07 07:41:59 +08:00
Jake Dallimore 2f6e0d92b7 MDL-54751 core_availability: Module restrictions exclude deletions
To make sure users can't add an access restriction based on a
course module scheduled for deletion, or its respective grade items.
2016-11-07 07:41:59 +08:00
Jake Dallimore 45bd824e59 MDL-54751 core_grades: Gradebook highlights modules pending deletion
Added warning to all gradebook pages if any modules are pending
deletion. Modified the return values for get_name, and is_locked for
affected grade items to indicate their pending deletion.
2016-11-07 07:41:59 +08:00
Jake Dallimore 3869d77411 MDL-54751 core_course: Edit course libs to support deletion flag
Changed the course libs such that module and section deletion is now
handed off to relevant functions in the util class and exempted
modules scheduled for deletion from the course backups.
2016-11-07 07:41:59 +08:00
Jake Dallimore 37da62f360 MDL-54751 core_course: Create adhoc task for course module deletion 2016-11-07 07:41:59 +08:00
Jake Dallimore 048f909b07 MDL-54751 core: introduce deletion flag for course modules
Created a flag, 'deletioninprogress' on the course_modules table to be
used when deleting course modules and course sections. Modified
modinfolib caches such that, when rebuilt, these caches hide the
relevant modules based on the value of the flag.
2016-11-07 07:41:59 +08:00
Henning Bostelmann f8b56ac904 MDL-55994 blog: Resolve warning messages in RSS feed generation 2016-11-06 17:38:26 +00:00
AMOS bot 55cbca98ff Automatically generated installer lang files 2016-11-07 00:04:41 +08:00
Eloy Lafuente (stronk7) b23b9a5b38 MDL-38158 core_media: bump upgrade / version and fix filter test 2016-11-06 02:11:20 +01:00
Eloy Lafuente (stronk7) 6e29346609 Merge branch 'wip-MDL-38158-master' of https://github.com/marinaglancy/moodle 2016-11-06 02:11:19 +01:00
Juan Leyva 1f2e3279b2 MDL-56765 webservice: On new session is started unset old preferences 2016-11-04 19:33:31 +00:00
Juan Leyva a947ecd634 MDL-56737 tool_mobile: Support private tokens in launch.php 2016-11-04 15:37:42 +00:00
Dan Poltawski f0049415af MDL-56684 competencies: fix eslint probs in templates 2016-11-04 14:59:57 +00:00
Damyon Wiese 207136f279 MDL-56684 competencies: Boost for competency templates
Add BS4 markup to all competencies templates. Also tweaked the template library to make it
easier in future when modifying templates and reloading.
2016-11-04 14:45:58 +00:00
Dan Poltawski f95c00e551 Merge branch 'wip-MDL-54986-master' of https://github.com/Beedell/moodle 2016-11-04 14:31:00 +00:00
Dan Poltawski b7b5b35cf5 Merge branch 'MDL-56668-m' of https://github.com/micaherne/moodle 2016-11-04 14:23:10 +00:00
Dan Poltawski 246288c3f9 Merge branch 'MDL-56654-master' of git://github.com/damyon/moodle 2016-11-04 14:20:14 +00:00
Dan Poltawski 1e1e4ff8e5 Merge branch 'MDL-56535-master' of git://github.com/jleyva/moodle 2016-11-04 14:10:48 +00:00
Dan Poltawski 808005ddf9 Merge branch 'MDL-53945' of git://github.com/aolley/moodle 2016-11-04 14:07:26 +00:00
Tony Lin ce1249be58 MDL-56731 groups: Fixes breadcrumb when returning to groups/index.php 2016-11-04 13:21:43 +00:00
Dan Poltawski 7eb34671c1 on-demand release 3.2dev+ 2016-11-04 11:20:34 +00:00
Dan Poltawski 6765172ed1 NOBUG: Fixed file access permissions 2016-11-04 11:20:33 +00:00
Eloy Lafuente (stronk7) ba611c4d61 Merge branch 'MDL-56673-fix' of git://github.com/danpoltawski/moodle 2016-11-04 11:40:43 +01:00
Dan Poltawski 6d368fc2f6 MDL-56673 tool_templatelibrary: fix externallib backwards compat
The function now matches the VALUE_DEFAULT option of the service.
2016-11-04 10:38:15 +00:00
Eloy Lafuente (stronk7) 79322e0087 Merge branch 'MDL-56740-master' of git://github.com/danpoltawski/moodle 2016-11-04 11:11:32 +01:00
Marina Glancy 7e3f637301 MDL-38158 media_videojs: Add Video.JS player 2016-11-04 17:30:43 +08:00
Marina Glancy fab11235d8 MDL-38158 core_media: Convert media players to new plugin type
AMOS BEGIN
  MOV [siteyoutube,core_media],[pluginname,media_youtube]
  MOV [siteyoutube_desc,core_media],[pluginname_help,media_youtube]
  MOV [sitevimeo,core_media],[pluginname,media_vimeo]
  MOV [sitevimeo_desc,core_media],[pluginname_help,media_vimeo]
  MOV [html5audio,core_media],[pluginname,media_html5audio]
  MOV [html5audio_desc,core_media],[pluginname_help,media_html5audio]
  MOV [html5video,core_media],[pluginname,media_html5video]
  MOV [html5video_desc,core_media],[pluginname_help,media_html5video]
  MOV [flashanimation,core_media],[pluginname,media_swf]
  MOV [flashanimation_desc,core_media],[pluginname_help,media_swf]
AMOS END
2016-11-04 17:30:40 +08:00
Marina Glancy 3c73b26c4b MDL-38158 core_media: more correct semantic for html5 video audio tags 2016-11-04 17:30:31 +08:00
Jun Pataleta ac67c97ccb MDL-55825 enrol_lti: Fix display of unenrol count on sync 2016-11-04 09:21:02 +00:00
Dan Poltawski 2fe28e0dc3 MDL-56740 geoip tests: update to a more reliable ipv6 location
Hopefully. It's quite difficult for us to test this funcionality with
altering data sets. Hoping this UCLA v6 address will be more reliable.
2016-11-04 08:52:40 +00:00
David Monllao d3c6ad5892 Merge branch 'MDL-46903-master-fix' of git://github.com/junpataleta/moodle 2016-11-04 14:23:16 +08:00
Andrew Nicols f5ddff27af Merge branch 'MDL-56673-master-fix1' of http://github.com/damyon/moodle 2016-11-04 13:57:16 +08:00
Jun Pataleta 17f63d18a5 MDL-46903 mod_scorm: Apply alias to compare text column 2016-11-04 13:32:24 +08:00
Andrew Nicols 70aa00de87 MDL-56748 cache: Removes cache definition instances in purge_store
Previously a purge_store was only purging caches but it was leaving a
reference to the store instance for the cache definition.

As a result, the cache was never cleared away correctly and, in cases
where the cache store makes a TCP connection to a backend system, the
number of open sockets was increasing for each store instance.

After a complete purge, as found in the unit test reset, the cache
definitions should be both purged and removed.

This change should also lead to a drop in memory consumption for unit
tests as there will no longer be references to unused definition stores.
2016-11-04 13:26:46 +08:00
Damyon Wiese a11c74d186 MDL-56673 tool_templatelibrary: Don't show templates from other themes 2016-11-04 12:52:38 +08:00
Andrew Nicols da31fc5bff Merge branch 'MDL-56576_master-fix' of git://github.com/dmonllao/moodle 2016-11-04 08:28:08 +08:00
David Monllao e1074d6ffd Merge branch 'master_MDL-46903' of https://github.com/danmarsden/moodle 2016-11-04 08:24:43 +08:00
David Monllao 629d3e5770 MDL-56576 theme_boost: Add save-settings param to admin search 2016-11-04 08:16:58 +08:00
Adam Olley 4bd8e65273 MDL-53945 mnet: Use moodle_url to provide string with url
Using moodle_url where possible is preferable to hardcoding uri's as
moodle_url is able to take care of alot of the formatting for us.

In this instance, it handles the $CFG->admin url path for us.
2016-11-04 09:10:31 +10:30
Michael Aherne fc60769302 MDL-56668 competencies: Correct namespacing of coding_exception 2016-11-03 13:59:13 +00:00
David Mudrák abcd53444b MDL-56726 admin: Fix some hard-coded paths to the admin directory 2016-11-03 09:54:28 +01:00
David Monllao 8b0064d5e7 Merge branch 'MDL-56576-master' of git://github.com/damyon/moodle 2016-11-03 15:14:41 +08:00
Andrew Nicols 11bafc2b21 Merge branch 'MDL-56641-master' of git://github.com/damyon/moodle 2016-11-03 15:07:01 +08:00
Andrew Nicols eff0a3e97f Merge branch 'MDL-56677_master-fix' of git://github.com/dmonllao/moodle 2016-11-03 14:56:32 +08:00
David Monllao 34ef8fa13a Merge branch 'MDL-56481-master' of git://github.com/junpataleta/moodle 2016-11-03 14:51:51 +08:00
David Monllao 18bb2883ce MDL-56677 cohort: Fix cohort search box misalignment 2016-11-03 14:33:07 +08:00
Tim Lock 6e10972bec MDL-56481 tool_lpmigrate: Fix notice when cancelling framework migration 2016-11-03 14:16:36 +08:00
Jun Pataleta 3c7387722d MDL-56720 tool_lp: Do not push empty values to IDs array 2016-11-03 14:09:40 +08:00
Andrew Nicols bc378b50ec Merge branch 'wip-MDL-44467-master' of git://github.com/abgreeve/moodle 2016-11-03 14:08:21 +08:00
David Monllao 5d0299e275 Merge branch 'MDL-56666-master' of git://github.com/jleyva/moodle 2016-11-03 10:28:59 +08:00
Damyon Wiese 057e1a1f6d MDL-56576 admin: Cannot edit blocks on search page
Admin search page was processing the blocks delete request before the blocks
could process it.

Added a hidden field to the search results form so it can be sure the form submission
was for saving admin settings.
2016-11-03 09:40:53 +08:00
Damyon Wiese 2a7c540c48 MDL-56641 admin: Managers can access search page 2016-11-03 09:36:33 +08:00
Damyon Wiese 5ae35b9dee MDL-56654 blogs: Display RSS link in the page 2016-11-03 09:22:51 +08:00
Adam Olley 20ec56504f MDL-53945 mnet: replace hardcoded admin dir with cfg
Several places in admin/mnet pull in required files using a hardcoded
admin dir string, as this is configurable it needs to use $CFG->admin
instead.

Places where the url is passed through moodle_url don't need to be
updated as that already automatically translates the urls for us.
2016-11-03 11:12:32 +10:30
David Monllao 205577718b Merge branch 'MDL-56691-master' of git://github.com/damyon/moodle 2016-11-03 08:22:25 +08:00
John Beedell 6e1e299554 MDL-54986 Quiz: Disable add button for quiz with attempts 2016-11-02 17:02:59 +00:00
Dan Poltawski 56f763b1f9 Merge branch 'MDL-55841-master' of https://github.com/xow/moodle 2016-11-02 15:24:33 +00:00
Dan Poltawski ab64cd40b0 Merge branch 'MDL-56372_static_bind_clean_return_val' of https://github.com/BenKelada/moodle 2016-11-02 15:14:46 +00:00
Dan Poltawski cb2b9a905c Merge branch 'MDL-55825-master' of git://github.com/junpataleta/moodle 2016-11-02 14:41:10 +00:00
Dan Poltawski 4d27d62d08 Merge branch 'wip-MDL-55927-master' of git://github.com/abgreeve/moodle 2016-11-02 14:00:29 +00:00
Dan Poltawski 930cae5bb5 MDL-56637 version: bump 2016-11-02 13:56:46 +00:00
Dan Poltawski de8388f529 Merge branch 'MDL-56637-master' of git://github.com/dpalou/moodle 2016-11-02 13:56:22 +00:00
Dan Poltawski 867dc76f64 MDL-56582 boost: add some misisng template context 2016-11-02 13:55:05 +00:00
Dan Poltawski c624351e97 Merge branch 'MDL-56582-master' of https://github.com/xow/moodle 2016-11-02 13:49:50 +00:00
Juan Leyva 2521afd2e8 MDL-56666 message: New WS core_message_get_user_message_preferences 2016-11-02 12:16:23 +00:00
Dan Poltawski ebdd54f476 MDL-56161 boost: fix confict resolution mistake 2016-11-02 10:20:34 +00:00
Dan Poltawski e5c726353f MDL-56161 boost: add missing example context 2016-11-02 10:14:00 +00:00
Neill Magill bd305a3973 MDL-55209 coursecat: Should be able to remove category idnumber
Users should be able to remove an idnumber from a category, before this
change when trying to delete an idnumber users would be told it already
existed.

This change also stops 0 from being allowed multiple times as an idnumber.
2016-11-02 09:50:34 +00:00
Neill Magill c10bfee49f MDL-55209 coursecat: Should be able to remove category idnumber test
A user should be able to remove an idnumber from a category, also 0
should not be allowed multiple times.
2016-11-02 09:50:30 +00:00
Dan Poltawski 540b01b60d Merge branch 'MDL-56161-master' of git://github.com/damyon/moodle 2016-11-02 09:36:09 +00:00
Dan Poltawski 25b0727e50 Merge branch 'MDL-56433-master' of git://github.com/damyon/moodle 2016-11-02 09:33:28 +00:00
Dan Poltawski b4b8d4fcc2 Merge branch 'MDL-56621-master-fix' of http://github.com/damyon/moodle 2016-11-02 09:03:05 +00:00
Damyon Wiese a053229f0f MDL-56690 theme_boost: Allow menus to scroll in the header
The header is fixed - so if menus in the header are longer than the page, you can't scroll
to the bottom of the menu. This sets max height on the menus to the viewport height - the navbar height and sets them to scroll
auto.
2016-11-02 15:48:49 +08:00
Damyon Wiese d8cfd61145 MDL-56582 theme_boost: Insert a proxy div for settings menu
This forces text in the page to wrap around the settings cog. Also
notifications background color goes underneath the div for the
settings cog - so we give it a background color.
2016-11-02 15:40:17 +08:00
Andrew Nicols 0c6fa2e9a8 Merge branch 'MDL-56698-master' of git://github.com/damyon/moodle 2016-11-02 15:34:06 +08:00
Damyon Wiese a5d4b54890 MDL-56698 mod_feedback: Make it look ok in boost 2016-11-02 15:25:18 +08:00
Simey Lameze 1d9356d7e9 MDL-56671 mod_scorm: fix styling issues on scorm module 2016-11-02 14:57:13 +08:00
David Monllao d27db408b9 Merge branch 'MDL-56677-master' of git://github.com/lameze/moodle 2016-11-02 14:55:00 +08:00
Damyon Wiese b07981e1e1 MDL-56621 forms: Give a default value if format not set
For forms with a text area, we need to provide a default for the format.
This only affects boost because it is export_for_template.
2016-11-02 14:42:33 +08:00
Andrew Nicols 8fa816e0b0 Merge branch 'wip-mdl-56273' of https://github.com/rajeshtaneja/moodle 2016-11-02 14:30:08 +08:00
Rajesh Taneja 4a910b9aa6 MDL-56273 cache: Fixed initialise call
After store is created, it should be checked if
it's ready before calling initialise
2016-11-02 14:26:50 +08:00
Simey Lameze 4bd9a67bf1 MDL-56677 core_cohort: fix style issues on cohort search fields 2016-11-02 14:10:24 +08:00
Andrew Nicols e84e836889 Merge branch 'MDL-56634-master' of git://github.com/ankitagarwal/moodle 2016-11-02 14:01:15 +08:00
Damyon Wiese 88e709ae43 MDL-56699 boost: Don't break when activities use onclick in nav
Boost templates were not nicely rendering onclick handlers in the navbar.
2016-11-02 13:35:54 +08:00
David Monllao 93dfcf3274 Merge branch 'MDL-56670-master' of git://github.com/lameze/moodle 2016-11-02 13:29:46 +08:00
Simey Lameze 6e4b3752f2 MDL-56670 mod_lesson: adds padding to end of lesson links 2016-11-02 13:12:32 +08:00
David Monllao eaef8faa61 Merge branch 'MDL-56323-master' of git://github.com/l-campbell/moodle 2016-11-02 13:12:07 +08:00
David Monllao e14f5db6a0 Merge branch 'wip-MDL-55930-master' of https://github.com/Beedell/moodle 2016-11-02 12:49:46 +08:00
David Monllao cf0450185e Merge branch 'wip_MDL-55913_master' of git://github.com/gjb2048/moodle 2016-11-02 12:41:48 +08:00
Ankit Agarwal 9d72acb7ed MDL-56634 webservices: Remove script from api desc and clean desc printing 2016-11-02 10:06:05 +05:30
David Monllao a5f53db190 Merge branch 'MDL-43796_master_blindmarking' of https://github.com/SWiT/moodle 2016-11-02 12:28:43 +08:00
Andrew Nicols 328628544b Merge branch 'MDL-56673-master' of git://github.com/danpoltawski/moodle 2016-11-02 12:07:18 +08:00
Andrew Nicols 8385163bab MDL-56596 tool_usertours: Update to latest version of tours and popper
The updated release of the popper library addresses some issues where
boundaries were not resepected correctly.
2016-11-02 11:37:31 +08:00
Andrew Nicols 6055809311 Merge branch 'MDL-56469-M32' of git://github.com/lazydaisy/moodle 2016-11-02 11:31:32 +08:00
Damyon Wiese 6ec7fb8dc1 MDL-56691 theme_boost: Fix height of nav drawer
It should not be more than the height of the page or you can't scroll to the
last item in the list.
2016-11-02 10:17:41 +08:00
Andrew Nicols c6ae02c184 Merge branch 'MDL-48468' of https://github.com/mr-russ/moodle 2016-11-02 10:13:42 +08:00
David Monllao 2f8b51f4b7 Merge branch 'MDL-56296-master' of git://github.com/damyon/moodle 2016-11-02 09:57:45 +08:00
David Monllao f5d9072e51 Merge branch 'MDL-56462-master' of git://github.com/damyon/moodle 2016-11-02 09:14:09 +08:00
Damyon Wiese 9e2f13125a MDL-56161 boost: alignment static form elements
Wrap the HTML from a static form element with "form-control-static" to apply correct padding.

Also use a span, not a label for unlabelable static form elements.
2016-11-02 09:06:12 +08:00
Dan Poltawski b7959d831d Merge branch 'MDL-54112-master' of https://github.com/hcpss-banderson/moodle 2016-11-01 21:31:04 +00:00
Dan Poltawski 777760b6ae Merge branch 'master_MDL-47500' of git://github.com/danmarsden/moodle 2016-11-01 21:29:32 +00:00
Juan Leyva 56c8413712 MDL-55992 webservice: Fix debugging notice when creating token
This patch also avoid to propagate to logs the private token as is done
in login/token.php
2016-11-01 21:26:40 +00:00
Dan Poltawski f99e7ef116 Merge branch 'mdl55456-master' of https://github.com/tlock/moodle 2016-11-01 21:26:05 +00:00
Dan Poltawski 3a24b255ba Merge branch 'MDL-56402-master' of git://github.com/lameze/moodle 2016-11-01 21:24:57 +00:00
Dan Poltawski 20fd5e538c Merge branch 'MDL-56530-master' of git://github.com/andrewnicols/moodle 2016-11-01 21:21:22 +00:00
Dan Poltawski b9703b8e05 Merge branch 'MDL-56621-master' of git://github.com/damyon/moodle 2016-11-01 21:20:53 +00:00
Juan Leyva 30861fbdaa MDL-56535 forum: Do not return user information in single discussion
This patch fixes the forum external functions
2016-11-01 20:52:58 +00:00
Eloy Lafuente (stronk7) cad8adccc7 on-demand release 3.2dev+ 2016-11-01 19:48:41 +01:00
Mike Churchward a620c573bc MDL-48055 q_u_outline, q_u_complete: added checks for grade visibility. 2016-11-01 14:14:51 -04:00
Dan Poltawski 57911c1f40 Merge branch 'MDL-47162' of https://github.com/stronk7/moodle 2016-11-01 12:13:19 +00:00
Eloy Lafuente (stronk7) f593e8271a MDL-47162 badges: site & profile badges do not have courseid
Because of that, we need to set the, now mandatory, SITEID for
those message events to be happy. This does not affect course or
activity badges, both coming with correct courseid.
2016-11-01 12:47:54 +01:00
Dan Poltawski 9f02188575 Merge branch 'MDL-56587-master' of git://github.com/cameron1729/moodle 2016-11-01 11:35:36 +00:00
John Beedell 7983265241 MDL-55930 Quiz: "Next page button" showing in sequential mode 2016-11-01 11:22:39 +00:00
Dan Poltawski 840ba76c0c MDL-56673 templatelibrary: return false when core template doesn't exist 2016-11-01 10:18:17 +00:00
Dan Poltawski 9bf205fb73 Merge branch 'MDL-55732-master' of git://github.com/damyon/moodle 2016-11-01 09:47:11 +00:00
Dan Poltawski e0d5d8caed Merge branch 'MDL-56651-master' of git://github.com/lameze/moodle 2016-11-01 09:10:08 +00:00
Dan Poltawski 0cbba93206 Merge branch 'MDL-56514-master-fix1' of https://github.com/lameze/moodle 2016-11-01 08:43:09 +00:00
Simey Lameze 67c89858aa MDL-56402 core_message: remove tabindex attr of not selected users 2016-11-01 15:49:16 +08:00
Simey Lameze 56fa3e011a MDL-56514 core_message: remove messaging enabled check 2016-11-01 14:15:32 +08:00
Damyon Wiese 757f42cb15 MDL-56587 theme_boost: Align header items
Remove chunks of conflicting CSS added in various places and add navbar-nav -> nav-link to header items.
2016-11-01 11:36:08 +08:00
Andrew Nicols 326b285467 Merge branch 'MDL-56273' of https://github.com/mr-russ/moodle 2016-11-01 10:55:23 +08:00
Andrew Nicols 0d80a4bd0b Merge branch 'wip-MDL-56489-master-v2' of git://github.com/abgreeve/moodle 2016-11-01 10:45:29 +08:00
Andrew Nicols 41c1314fbd MDL-56509 tool_usertours: Fetch all role shortnames 2016-11-01 10:14:48 +08:00
Adrian Greeve 839b391f74 MDL-56489 Lib: force_settings_menu added to pagelib.
This introduces a flag to force the settings menu
to be displayed on the page if the theme uses a settings
menu. This is for use by activities and resources.
2016-11-01 10:00:12 +08:00
Simey Lameze 0051b08560 MDL-56651 core_role: add styling to submit buttons 2016-11-01 09:40:53 +08:00
Dan Marsden 3dc868478b MDL-54575 scorm: fix typo in data_preprocessing function
thanks to Mike Finch for the patch/report.
2016-11-01 12:11:54 +13:00
Dan Marsden a2096721c7 MDL-46903 scorm: Fix db error in objectives report for oracle.
also improve 2004 report handling to help with testing.
2016-11-01 12:05:35 +13:00
Eloy Lafuente (stronk7) a1f6a27c80 Merge branch 'MDL-47162' of git://github.com/merrill-oakland/moodle 2016-10-31 22:45:37 +01:00
Eloy Lafuente (stronk7) 8df0fb490b Merge branch 'wip-MDL-56615-master' of git://github.com/marinaglancy/moodle 2016-10-31 20:25:31 +01:00
Eloy Lafuente (stronk7) 2fd11f3516 Merge branch 'MDL-56188-master' of git://github.com/damyon/moodle 2016-10-31 19:59:21 +01:00
Eloy Lafuente (stronk7) 5165c9f460 MDL-56297 forms: Normalize uses of 'url' fields to use size=60
While this is not related to this issue, when reviewing it was
detected that the size of those url fields was really small and
looking decided to add this bit of normalization over existing uses.
2016-10-31 19:47:41 +01:00
Eloy Lafuente (stronk7) 7aa17ce256 Merge branch 'MDL-56297-master' of git://github.com/damyon/moodle 2016-10-31 19:47:40 +01:00
Damyon Wiese de1af8a6ed MDL-56588 theme_boost: Nice wrapping text in flat nav
When section titles were too long they did not wrap nicely.
2016-10-31 18:24:43 +00:00
Eric Merrill 880fc15bf0 MDL-47162 core_message: Updating all uses of messaging to add courseid 2016-10-31 14:13:13 -04:00
Eloy Lafuente (stronk7) c40a53775f Merge branch 'MDL-55799-master' of git://github.com/lameze/moodle 2016-10-31 17:23:11 +01:00
Eloy Lafuente (stronk7) 358105b309 Merge branch 'MDL-56155-master' of git://github.com/lameze/moodle 2016-10-31 17:11:21 +01:00
Dan Poltawski 9e972b3da4 Merge branch 'MDL-56627-master' of git://github.com/damyon/moodle 2016-10-31 15:54:22 +00:00
Dan Poltawski a9f119efd6 Merge branch 'wip-MDL-56633-master' of https://github.com/marinaglancy/moodle 2016-10-31 15:36:21 +00:00
Dan Poltawski 6795b0a0c7 Merge branch 'MDL-56580-master' of git://github.com/junpataleta/moodle 2016-10-31 15:20:45 +00:00
Dan Poltawski f2263f7c06 Merge branch 'MDL-56542-master-enfix' of git://github.com/mudrd8mz/moodle 2016-10-31 15:15:09 +00:00
Dan Poltawski 5ad34c43f6 Merge branch 'MDL-56597-master' of git://github.com/damyon/moodle 2016-10-31 15:10:02 +00:00
Dan Poltawski 0e86392133 Merge branch 'MDL-56578-master' of git://github.com/damyon/moodle 2016-10-31 15:04:55 +00:00
Damyon Wiese 155b0bc0b9 MDL-56578 theme_boost: Dismiss help popovers on next click 2016-10-31 22:01:19 +08:00
Damyon Wiese 2259c0f078 MDL-56621 templates: Add missing example contexts 2016-10-31 21:27:52 +08:00
Dan Poltawski b0f7a97c42 Merge branch 'MDL-56610-master' of git://github.com/damyon/moodle 2016-10-31 10:20:08 +00:00
Dan Poltawski f7614c6007 Merge branch 'MDL-56523-master' of git://github.com/lazydaisy/moodle 2016-10-31 10:19:13 +00:00
Dan Poltawski e90d0c90b4 MDL-56514 message: fix whitespace 2016-10-31 10:06:26 +00:00
Dan Poltawski 868f5c8709 Merge branch 'MDL-56514-master' of git://github.com/lameze/moodle 2016-10-31 10:03:59 +00:00
Dan Poltawski 703863ce82 Merge branch 'MDL-56599-master' of git://github.com/damyon/moodle 2016-10-31 09:57:03 +00:00
Dan Poltawski b7f3b1365d Merge branch 'MDL-56509-master' of git://github.com/andrewnicols/moodle 2016-10-31 09:35:21 +00:00
Dan Poltawski 75de2e6199 Merge branch 'MDL-56631-master' of git://github.com/damyon/moodle 2016-10-31 09:10:06 +00:00
Russell Smith a330e83ade MDL-56273 cache: Use is_ready() to determine if cache is really ready. 2016-10-31 19:44:05 +11:00
Damyon Wiese a2d9a89f5a MDL-56149 permissions: Alignment of icons should not wrap
/admin/roles/permissions.php?contextid=2 the icons should not wrap.
2016-10-31 16:24:11 +08:00
Damyon Wiese 6fb8a7ab7e MDL-56621 forms: Hide format menu if only one
This was a regression in the new templates for editors.
2016-10-31 15:06:50 +08:00
Simey Lameze a2c7227ab8 MDL-56514 core_message: add missing is messaging enabled checks 2016-10-31 15:06:50 +08:00
Damyon Wiese ad785e699e MDL-56631 passwordunmask: Admin setting for password unmask not working
Andrew refactored the way it rendered the element, but did not update all the
templates (there is mforms element AND admin settings element).

See 3778a9226f for Andrews original change.
2016-10-31 14:45:07 +08:00
Andrew Nicols 0b03040605 Merge branch 'MDL-56501-master' of git://github.com/lameze/moodle 2016-10-31 14:10:37 +08:00
Simey Lameze 343ba16c31 MDL-56501 message: introduce new manageallmessaging capability 2016-10-31 14:09:03 +08:00
Andrew Nicols de32120676 Merge branch 'MDL-56577-master' of git://github.com/junpataleta/moodle 2016-10-31 14:02:27 +08:00
Andrew Nicols 42a372e20f Merge branch 'MDL-56273' of https://github.com/mr-russ/moodle 2016-10-31 14:00:36 +08:00
Andrew Nicols 711e2ab184 Merge branch 'MDL-56583-master' of git://github.com/crazyserver/moodle 2016-10-31 13:42:46 +08:00
Russell Smith f9599c77cc MDL-56273 cache: Ensure requirements are met for cache stores.
Ensure that the cache store requirements are met prior to attempting
to instantiate a class.  Many of the constructors create connections
to external services requiring the installation and availability of
classes that are specified in are_requirements_met().  If they are
not checked properly you end up with PHP Fatal errors rather than
falling back to a different store that is capabable without the
the extra classes loaded.
2016-10-31 16:04:51 +11:00
Jun Pataleta 6af2ccda91 MDL-56577 core_form: Let other option attrs to be set in select elements 2016-10-31 12:19:21 +08:00
Andrew Nicols 4e5d96ee3a Merge branch 'MDL-56282-master' of git://github.com/damyon/moodle 2016-10-31 12:18:22 +08:00
Frédéric Massart 77bec234e0 MDL-56282 enrol_meta: Fix error when editing existing instances
We had a few problems here.

1/ The auto complete element was displaying the picker though the
   field was frozen.
2/ Checking for existing enrolment including the courses chosen was
   not checking if the courses found were in the instance we edit.
3/ Upon creation we support multiple courses but when editing we
   should not expect more than the course in the instance being edited.
2016-10-31 12:15:02 +08:00
Andrew Nicols c86fb21789 Merge branch 'MDL-56573-master' of git://github.com/junpataleta/moodle 2016-10-31 12:03:00 +08:00
Andrew Nicols 09a05b798b MDL-56138 messaging: Add tests for viewparticipants search restriction 2016-10-31 11:58:29 +08:00
Andrew Nicols 46dd48129b Merge branch 'wip-MDL-56138-master' of git://github.com/abgreeve/moodle 2016-10-31 11:35:47 +08:00
Andrew Nicols cf6fc0abe1 Merge branch 'MDL-56638-master' of git://github.com/crazyserver/moodle 2016-10-31 11:01:25 +08:00
Adrian Greeve 87d4ab654b MDL-56138 messaging: Update to messaging unit tests. 2016-10-31 10:52:05 +08:00
Adrian Greeve f324957724 MDL-56138 messaging: Limit course search to enrolled courses. 2016-10-31 10:52:05 +08:00
Andrew Nicols 72c0d69d5c Merge branch 'wip-MDL-56625-master' of git://github.com/abgreeve/moodle 2016-10-31 10:47:29 +08:00
Andrew Nicols 236778b905 MDL-56078 theme_boost: Update ignorefiles 2016-10-31 10:46:14 +08:00
Andrew Nicols 43dadab50b Merge branch 'MDL-56078-master' of git://github.com/damyon/moodle 2016-10-31 09:30:15 +08:00
Andrew Nicols bcabf4d530 Merge branch 'MDL-56427-master' of git://github.com/lameze/moodle 2016-10-31 09:16:10 +08:00
Jun Pataleta 5a3f6ceb57 MDL-55825 enrol_lti: Unit tests for upgraded memberships sync
* sync_members tests
* data_connector tests for new methods
2016-10-31 09:09:43 +08:00
Jun Pataleta 08237c3aa8 MDL-55825 enrol_lti: Upgrade member sync to use the new LTI library 2016-10-31 09:09:06 +08:00
Stephen Bourget c5176b2968 MDL-55249 mod_feedback: Associate status with current activity
The status screen in mod_feedback simply checks to see if there are any
attempts in progress to return the user status.  This check should be
limited to only include instances of the current feedback activity not
any feedback activity on the site.
2016-10-30 16:01:20 -04:00
Russell Smith a169739d5d MDL-56273 cache: Use cache initialise always.
purge_all() and purge_by_definition() look in the configuration
for which caches are available and then creates them to purge them.
The configuration stores the values used by initialise(), not
initialise_unit_test_instance() and would therefore fail to purge
all caches if they were not purged by another means.

In the case of filestore, it's purged by unit tests, in the case
of memcache(d), it purges the whole store when a single definition
is requested.

Therefore all configuration was moved into the configuration file
during unit tests and does not have any special override codes in
the unit test infrastructure.
2016-10-30 13:42:43 +11:00
Tomasz Sanecki fd7bb5a8d9 MDL-48468 cache: add support for port in server address 2016-10-30 13:34:43 +11:00
Russell Smith 68b1e13094 MDL-48468 cache: Import Redis cachestore
This code was originally taken from; https://github.com/durana/moodle-cachestore_redis
Special thanks to Mark Nielsen and Adam Durana for their work on this.

Since the original import;
- Mode session support has been added.
- Some cleanup of names has been made.
- Data guarantee and references support was added.
2016-10-30 13:34:43 +11:00
Pau Ferrer Ocaña 1f84c2c5ea MDL-56638 assign: Don't check sesskey using submit_grading_form from WS 2016-10-28 13:44:19 +02:00
Dani Palou 6d2f938cbd MDL-56637 ws: Add core_user_update_user_preferences to Mobile service 2016-10-28 12:40:18 +02:00
Dan Poltawski 85c9053aec Merge branch 'MDL-56339-master' of git://github.com/junpataleta/moodle 2016-10-28 09:47:15 +01:00
Marina Glancy c05be214aa MDL-56633 theme_boost: activity label should not be centered 2016-10-28 15:20:47 +08:00
Simey Lameze fd5797aa3b MDL-55799 inplace_editable: add form-control class to fields 2016-10-28 15:04:54 +08:00
Simey Lameze 823ae9f062 MDL-56155 theme_boost: fix wrong padding on inline field help text
Thanks John Okely!
2016-10-28 14:45:28 +08:00
Damyon Wiese 4821f45961 MDL-56188 theme_boost: Better alignment for form fields help 2016-10-28 14:40:00 +08:00
Adrian Greeve 159c2c91be MDL-55927 auth_radius: Move to third party plugin. 2016-10-28 14:35:54 +08:00
Adrian Greeve 25ea0caaa2 MDL-44467 lib: Move lang string to admin file.
AMOS BEGIN
 MOV [allowattachments,message_email],[allowattachments,admin]
 MOV [allowusermailcharset,message_email],[allowusermailcharset,admin]
 MOV [configallowattachments,message_email],[configallowattachments,admin]
 MOV [configallowusermailcharset,message_email],[configallowusermailcharset,admin]
 MOV [configmailnewline,message_email],[configmailnewline,admin]
 MOV [confignoreplyaddress,message_email],[confignoreplyaddress,admin]
 MOV [configsitemailcharset,message_email],[configsitemailcharset,admin]
 MOV [configsmtpauthtype,message_email],[configsmtpauthtype,admin]
 MOV [configsmtphosts,message_email],[configsmtphosts,admin]
 MOV [configsmtpmaxbulk,message_email],[configsmtpmaxbulk,admin]
 MOV [configsmtpsecure,message_email],[configsmtpsecure,admin]
 MOV [configsmtpuser,message_email],[configsmtpuser,admin]
 MOV [doesnotfit,message_email],[doesnotfit,admin]
 MOV [doesnotfitdetail,message_email],[doesnotfitdetail,admin]
 MOV [mailnewline,message_email],[mailnewline,admin]
 MOV [none,message_email],[none,admin]
 MOV [noreplyaddress,message_email],[noreplyaddress,admin]
 MOV [noreplydomain,message_email],[noreplydomain,admin]
 MOV [noreplydomaindetail,message_email],[noreplydomaindetail,admin]
 MOV [sitemailcharset,message_email],[sitemailcharset,admin]
 MOV [smtp,message_email],[smtp,admin]
 MOV [smtpauthtype,message_email],[smtpauthtype,admin]
 MOV [smtpdetail,message_email],[smtpdetail,admin]
 MOV [smtphosts,message_email],[smtphosts,admin]
 MOV [smtpmaxbulk,message_email],[smtpmaxbulk,admin]
 MOV [smtppass,message_email],[smtppass,admin]
 MOV [smtpsecure,message_email],[smtpsecure,admin]
 MOV [smtpuser,message_email],[smtpuser,admin]
AMOS END
2016-10-28 13:27:00 +08:00
Adrian Greeve e0789335ee MDL-44467 lib: Unit test updates. 2016-10-28 13:27:00 +08:00
Adrian Greeve 9715f61a26 MDL-44467 lib: Fix return path to noreply.
Added code to show emails from users on controlled domains.
Moved admin settings from message_email to admin.
2016-10-28 13:27:00 +08:00
Damyon Wiese e2c8fb8515 MDL-55215 forms: Pass options and correctly merge choices 2016-10-28 13:23:48 +08:00
Damyon Wiese f7ed5cee30 MDL-56171 javascript: Make searchableselector wrap autocomplete
One less yui module.

Conflicts:
	lib/upgrade.txt
2016-10-28 13:13:22 +08:00
Simey Lameze 253ae23058 MDL-44467 core: always send email from noreplyaddress 2016-10-28 13:04:09 +08:00
Simey Lameze ff2abc4b7d MDL-44467 core: mail settings and navigation improvements
This commit groups all mail settings under Server node, splitting into
two categories: Outgoing mail configuration and Incoming mail configuration.
Also, it make maildomain setting available on the Email settings page.
2016-10-28 13:04:09 +08:00
Damyon Wiese 0f13ffbc63 MDL-56297 theme_boost: Obey usefilepicker option
URL form fields support 'usefilepicker' option to show/hide the file picker in some forms.
2016-10-28 12:57:08 +08:00
Damyon Wiese 58488d0ff0 MDL-56462 boost: Fix assign grading options form
Classes attribute was not being honoured by all form element templates.
Formchangechecker was only looking for the ignoredirty class on the element,
in boost it is on the container.
Assign had specific styles to hide the submit buttons that were not matching in boost.
2016-10-28 12:24:50 +08:00
Marina Glancy 3abda0332d MDL-56615 portfolio_googledocs: add basic unittests 2016-10-28 12:13:33 +08:00
Jun Pataleta 5306a00ab0 MDL-56580 core_form: Unescape select attributes 2016-10-28 12:02:06 +08:00
Marina Glancy 761ef5d33a MDL-56615 portfolio: fix php 7.0.9 warning 2016-10-28 11:56:42 +08:00
Adrian Greeve 1d4490d366 MDL-56625 authentication: Email registration works again.
Creation via email accounts was broken due to a missing
require for the auth library.
2016-10-28 11:17:28 +08:00
Damyon Wiese 70f0010712 MDL-56627 theme_boost: Move help buttons outside labels
For radios and checkboxes where clicking on the label would toggle the state.
2016-10-28 11:04:28 +08:00
Jun Pataleta 826ee7370e MDL-55825 enrol_lti: Added context type column to enrol_lti_lti2_context 2016-10-28 10:10:43 +08:00
Jun Pataleta a78d184c05 MDL-55825 core_lib: LTI tool provider library fixes
* Define consumer profile member variable for ToolConsumer class
* Added context type property for Context class
* Set context type if 'context_type' parameter was submitted through POST

This commit can be dropped once the pull requests for these changes have
been integrated upstream.
2016-10-28 10:10:43 +08:00
Jun Pataleta f30f627501 MDL-56339 enrol_lti: Force page layout to embedded from custom setting 2016-10-28 10:05:02 +08:00
Jun Pataleta 59eb63612b MDL-56573 enrol_lti: Non-null default for tool_consumer_instance_name 2016-10-28 10:03:19 +08:00
Brian Barnes ea6763e421 MDL-47500 scorm: improved height calculation 2016-10-28 13:41:18 +13:00
Dan Marsden 97223bb356 MDL-56358 tool_lp tool_cohortroles: allow null idnumber 2016-10-28 12:00:44 +13:00
Eloy Lafuente (stronk7) a29bcf7819 MDL-47162 core_message: debug whenever courseid is missing
Instead of silently defaulting to SITEID when courseid (coming
from message_send()/\core\message\manager::send_message()) is missing,
now a debugging message is shown to allow developers to fix their
messages to, always, include courseid.

Raw creation of events via message_sent::create() missing other[courseid]
leads to coding exception since now (there shouldn't be any legacy use, as far as
they are always created via create_from_ids() when sending a message.

Updated upgrade.txt notes a little bit, added references the 3.6 final
deprecation issue (MDL-55449) and covered with unit tests.
2016-10-28 00:30:02 +02:00
Eric Merrill 9d0e8a4f6d MDL-47162 core_message: Remove changes to small messages 2016-10-27 18:12:43 +02:00
Eric Merrill 0e8b51607b MDL-47162 core_message: Cleanup of messaging course ids code 2016-10-27 18:12:42 +02:00
Amanda Doughty cc350fd9c8 MDL-47162 core_message: Add course id to message eventdata 2016-10-27 18:11:27 +02:00
lazydaisy 808955143e MDL-56469 theme_boost: reduce section activity indent when not editing. 2016-10-27 15:22:23 +01:00
lazydaisy 13a8c3d89b MDL-56523 theme_boost: Removed region-main-box in maintenance.mustache 2016-10-27 15:18:58 +01:00
Brendan Anderson c28c76450b MDL-54112 mod_assign: Add scale null grade filter 2016-10-27 09:58:56 -04:00
Pau Ferrer Ocaña 59111fa937 MDL-56583 assign: Add info about the user submission capability 2016-10-27 15:40:03 +02:00
Dan Poltawski 577bd70d38 weekly release 3.2dev 2016-10-27 12:19:27 +01:00
Dan Poltawski 2062b6de90 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-10-27 12:19:25 +01:00
John Okely 3a5e14a5d0 MDL-55841 mod_lti: Improve interface usability & consistency
* Always say "Tool URL"
* Add help strings to cartridge interface
2016-10-27 17:13:22 +08:00
Dan Poltawski 1810eb1bf8 Revert "Merge branch 'MDL-56129-master' of git://github.com/andrewnicols/moodle"
This reverts commit aaa2788e42, reversing
changes made to 80b74762c9.
2016-10-27 09:59:38 +01:00
Eloy Lafuente (stronk7) 6a17bdec92 Merge branch 'MDL-56594-master' of git://github.com/damyon/moodle 2016-10-27 10:47:51 +02:00
Damyon Wiese 7744f89275 MDL-56296 theme_boost: Do not hide server-side validation errors
When the client side validation passes - do not hide errors that were not
generated by client side validation.
2016-10-27 15:51:56 +08:00
Simey Lameze 4a7fdb4abb MDL-56427 message: style fixes for notification and message preferences 2016-10-27 15:27:11 +08:00
Damyon Wiese 9629c86f6c MDL-56433 theme_boost: Fix styling for autocompletes
This is for when the autocomplete is used outside of an mform - the drop down arrow was misaligned because
of conflicts with the bootstrap form-control class.
2016-10-27 15:23:50 +08:00
Andrew Nicols 77cfc19a85 Merge branch 'MDL-56015-master-fix1' of http://github.com/damyon/moodle 2016-10-27 15:12:49 +08:00
Kenneth Hendricks e47c002c75 MDL-29795 assign: Tweak user-info section in grader view
- also mirror due date removal in boost template
2016-10-27 17:09:58 +11:00
Kenneth Hendricks 84a303b5d2 MDL-29795 assign: Fix mustache template 2016-10-27 15:52:28 +11:00
Andrew Nicols ce434c7664 Merge branch 'wip-mdl-55074-fix2' of https://github.com/rajeshtaneja/moodle 2016-10-27 12:16:43 +08:00
Rajesh Taneja 0fa66b5383 MDL-55074 behat: Remove js tag as the feature can run without it 2016-10-27 12:11:45 +08:00
Kenneth Hendricks eeaefbb850 MDL-29795 assign: Add 'Duplicate override' breadcrumb 2016-10-27 14:10:43 +11:00
Kenneth Hendricks a13f1f4996 MDL-29795 assign: Only display date columns if overrides 2016-10-27 14:10:35 +11:00
Damyon Wiese b7d127aa93 MDL-55732 theme_boost: Add separator logic to group templates 2016-10-27 11:05:08 +08:00
Frédéric Massart b24212515c MDL-55732 theme_boost: Export elements separator in groups 2016-10-27 10:54:02 +08:00
Frédéric Massart 4b021492d6 MDL-55732 theme_boost: Bulk user actions form adjustments
- The 'add' and 'remove' buttons consistently wrap on two lines
- Multiple select fields use the size attribute to set the options seen
2016-10-27 10:54:02 +08:00
Damyon Wiese bff9fd896a MDL-56597 theme_boost: Maintenance warning styles 2016-10-27 10:41:42 +08:00
Damyon Wiese f1f6d80e69 MDL-56610 theme_boost: White background on the maintenance pages 2016-10-27 09:39:39 +08:00
lazydaisy 8b590de0b7 MDL-56523 theme_boost: Removed region-main-box in maintenance.mustache 2016-10-27 09:32:19 +08:00
Stephen Bourget 9ff8cdd971 MDL-55883 mod_lesson: Missing include in lesson_update_events 2016-10-26 21:22:01 -04:00
Damyon Wiese 58473a6776 MDL-56015 theme_boost: change theme preview screenshot 2016-10-27 09:20:35 +08:00
Kenneth Hendricks 34fac159fb MDL-29795 assign: Add course to user profile link 2016-10-27 11:38:40 +11:00
Kenneth Hendricks f73c5b519c MDL-29795 assign: Add missing inactiveoverridehelp lang string 2016-10-27 10:39:49 +11:00
Eloy Lafuente (stronk7) 6f01090159 Merge branch 'MDL-56448-master' of git://github.com/danpoltawski/moodle 2016-10-26 16:11:44 +02:00
Dan Poltawski f07cb88c57 MDL-56448 mustache: fix json errors in example context 2016-10-26 12:35:45 +01:00
Dan Poltawski 2300b95dbf Merge branch 'MDL-56184-master-master' of git://github.com/damyon/moodle 2016-10-26 12:11:56 +01:00
Dan Poltawski add9db49f4 MDL-56334 tests: add some trivial cases to domain tests
This gets us to 100% code coverage.
2016-10-26 09:58:05 +01:00
Dan Poltawski e376b4bd64 Merge branch 'MDL-56334-master-v2' of git://github.com/snake/moodle 2016-10-26 09:57:50 +01:00
David Mudrák dfe73442f7 MDL-56542 lang: Fix coding style of qtype_calculated strings file
This patch does not actually change the value of strings. It only fixes
the coding style issues raised by the prechecker (missing spaces around
the assignment operator).
2016-10-26 10:47:15 +02:00
Damyon Wiese 11774d9014 MDL-56599 theme_boost: Move region settings menu out of content div
This is because the content div has it's own rules for scrolling and overflow,
and they don't work well with the action menu for the region.
2016-10-26 16:46:29 +08:00
Eloy Lafuente (stronk7) c64230234f Merge branch 'MDL-56090-master-fix' of github.com:andrewnicols/moodle 2016-10-26 10:38:36 +02:00
Adrian Greeve 020c98e373 MDL-56334 libraries: Addition of domain checker.
Added a function for checking if a domain is allowed
against a list of domains that could contain wildcards.
2016-10-26 15:51:32 +08:00
Jake Dallimore 6d6e36923b MDL-56334 libraries: Add new internet protocol library to core
New library providing utilities for IP addresses, DNS and other
internet-protocol-related information.
2016-10-26 15:49:03 +08:00
Andrew Nicols ebc746dcc2 MDL-56090 message: Make key in union unique
This also fixes the unit test to use the correct indices.
2016-10-26 15:43:56 +08:00
Damyon Wiese 76132d1eb9 MDL-56078 theme_boost: Preset settings for release
Allow user uploaded preset files and remove the bootswatch based existing presets.
2016-10-26 15:27:43 +08:00
David Monllao 01435b4ebd Merge branch 'MDL-53048-master-fix' of git://github.com/andrewnicols/moodle 2016-10-26 15:11:27 +08:00
Frédéric Massart a4a6d85b5b MDL-56184 theme_boost: Constrain inline form elements to form width 2016-10-26 15:06:59 +08:00
Andrew Nicols 7eafebbcf7 Merge branch 'MDL-53366-master' of github.com:ankitagarwal/moodle 2016-10-26 14:15:49 +08:00
Andrew Nicols 3778a9226f MDL-53048 core_form: passwordunmask must exist on page for validation
The initial approach I took was to provide a noscript area containing the
standard input element, and to move it to a hidden input element as part of
the passwordunmask setup.

This allowed behat tests to pass both with and without JS enabled (i.e.
with Goutte and real browsers), and also ensured that the real input did
not appear on screen.

However, the standard formslib validation occurs before other page JS is
run and hooks into the elements on page during its setup.
Since noscript elements are not accessible to scripts as standard elements,
the form validation would fail for _client_ side validation and work for
server-side validation.

This change creates creates the hidden input element in the template
instead, as well as the password element in the noscript tag.

Doing this means that when JS is disabled, the form has two elements of the
same name - one hidden, and the second a visible password field.
Since the latter element will always override the former one on form
submission, and the noscript variant is last, the noscript variant wins
when JS is disabled and tests continue to pass.

When JS is enabled, the noscript variant is not a valid part of the DOM
(the browser sees it as a hidden text field essentially). The password is
not automatically entered into the hidden field, so the autocomplete
prevention continues to work as expected.
2016-10-26 13:33:10 +08:00
Ankit Agarwal ff67562eca MDL-53366 antivirus_clamav: Remove Quarantine directory setting 2016-10-26 09:47:27 +05:30
David Monllao ee61e3ef83 Merge branch 'wip-mdl-55074-fix' of https://github.com/rajeshtaneja/moodle 2016-10-26 10:31:09 +08:00
Damyon Wiese 181179de54 MDL-55074 message: Display modal window in message, BS2 compatible 2016-10-26 10:24:20 +08:00
Damyon Wiese 33cb7031de MDL-55074 behat: Fix zoom in/out dom insertion 2016-10-26 10:18:52 +08:00
Rajesh Taneja eb1335c63c MDL-55074 behat: Click on the internal div to ensure driver don't click at wrong node 2016-10-26 10:15:59 +08:00
Rajesh Taneja 7f8c9bb852 MDL-55074 behat: Use full navigation path 2016-10-26 10:15:18 +08:00
Andrew Nicols 71c47e774f Merge branch 'wip-mdl-56532-fix' of https://github.com/rajeshtaneja/moodle 2016-10-26 10:12:25 +08:00
Rajesh Taneja 0c4c697dac MDL-56532 behat: Fixed language string 2016-10-26 10:11:17 +08:00
Andrew Nicols 7f650fdec8 Merge branch 'MDL-29110-master' of git://github.com/lameze/moodle 2016-10-26 09:48:25 +08:00
Simey Lameze 0ab8b33754 MDL-29110 enrol_self: improve send course welcome message setting
This commit change send course welcome message to a drop-down that now supports sending emails from:
- Course contact
- Enrolment key holder
- No reply address
Also moves part of the logic of handling send welcome email from to a new method get_welcome_email_contact() and unit test for this new method.
2016-10-26 09:38:09 +08:00
Eloy Lafuente (stronk7) 7c7928b2d8 Merge branch 'MDL-56354' of https://github.com/mr-russ/moodle 2016-10-26 03:02:53 +02:00
Andrew Nicols f34d743dd4 Merge branch 'wip-mdl-56532' of https://github.com/rajeshtaneja/moodle 2016-10-26 08:27:14 +08:00
Andrew Nicols dc213b45ec MDL-50888 antivirus: Add note to upgrade.txt 2016-10-26 08:23:20 +08:00
Damyon Wiese 9de8c56136 MDL-56594 theme_boost: The template for checkboxes has a nesting error
This throws and exception which is caught - and the renderer fall back to the
legacy HTML for the element.
2016-10-26 08:19:41 +08:00
Andrew Nicols 8d3c33c693 Merge branch 'MDL-50888-master' of https://github.com/lucisgit/moodle 2016-10-26 08:19:23 +08:00
Rajesh Taneja a4da15d472 MDL-56532 behat: Fixed language string 2016-10-26 08:14:58 +08:00
Russell Smith ef15173794 MDL-56354 unittests: Put debug messages in the failure notice. 2016-10-26 08:39:10 +11:00
Dan Poltawski a360594259 Merge branch 'MDL-56136' of git://github.com/timhunt/moodle 2016-10-25 20:44:42 +01:00
Dan Poltawski 7af5ad97c1 MDL-46942 events: fix naming of other param
originalcourseid matches coding style
2016-10-25 20:18:35 +01:00
Dan Poltawski 7e670910ed Merge branch 'MDL-46942-added-original-course' of https://github.com/jmalmsten-panopto/moodle 2016-10-25 20:15:55 +01:00
Eloy Lafuente (stronk7) 717845b52d Merge branch 'MDL-54833-master-workshopuserplan' of git://github.com/mudrd8mz/moodle 2016-10-25 20:46:30 +02:00
David Mudrák 98892c0467 MDL-56542 lang: Use the reworded string in the Behat scenario 2016-10-25 20:23:56 +02:00
Eloy Lafuente (stronk7) 0d80f6984b Merge branch 'MDL-56250-32-formvalidation' of https://github.com/roperto/moodle 2016-10-25 20:23:12 +02:00
Helen Foster c9636ddd51 MDL-56542 lang: Merge English strings from the en_fix language pack 2016-10-25 20:12:52 +02:00
Eloy Lafuente (stronk7) f07a1ae8a3 Merge branch 'master' of https://github.com/yuriy-os/moodle 2016-10-25 20:11:27 +02:00
Dan Poltawski 607bdc3829 Merge branch 'MDL-53366-master' of https://github.com/lucisgit/moodle 2016-10-25 19:05:00 +01:00
Dan Poltawski d5e902d3ab Merge branch 'MDL-55143' of https://github.com/mr-russ/moodle 2016-10-25 18:40:06 +01:00
Eloy Lafuente (stronk7) c52cc59877 Merge branch 'MDL-54781_master' of git://github.com/markn86/moodle 2016-10-25 19:37:11 +02:00
Eloy Lafuente (stronk7) bab82353f6 Merge branch 'MDL-56444' of https://github.com/mr-russ/moodle 2016-10-25 18:56:00 +02:00
AMOS bot 2c07cc5cf8 Automatically generated installer lang files 2016-10-26 00:04:31 +08:00
Dan Poltawski 98363b9d52 MDL-56017 filter_mathjax: bump version 2016-10-25 10:38:03 +01:00
Dan Poltawski 64ce747448 Merge branch 'MDL-56017-master' of git://github.com/lameze/moodle 2016-10-25 10:36:51 +01:00
David Monllao 26aa08b2f8 Merge branch 'MDL-56307-master' of git://github.com/jleyva/moodle 2016-10-25 17:33:08 +08:00
Dan Poltawski 274c5837e7 Merge branch 'MDL-56536-master' of git://github.com/jleyva/moodle 2016-10-25 10:12:54 +01:00
Juan Leyva 25adfbaa4a MDL-56307 course: Support new returned data in WS 2016-10-25 10:10:55 +01:00
Juan Leyva 65b2669d98 MDL-56307 course: Return time updated and times updated 2016-10-25 10:10:55 +01:00
Russell Smith cebce76f61 MDL-56307 course: Refactor file_storage 2016-10-25 10:10:53 +01:00
Juan Leyva 26659f626a MDL-56307 course: New Web Service core_course_check_module_updates 2016-10-25 10:10:53 +01:00
Juan Leyva 02a73d767c MDL-56307 course: New course_check_module_updates_since method 2016-10-25 10:10:52 +01:00
Juan Leyva 1896b8009a MDL-56307 course: API changes to support retrieve by time 2016-10-25 10:10:52 +01:00
Dan Poltawski ad07960d89 Merge branch 'wip-MDL-56395-master' of https://github.com/Beedell/moodle 2016-10-25 09:30:46 +01:00
Dan Poltawski b580f39556 Merge branch 'MDL-56403_master' of git://github.com/markn86/moodle 2016-10-25 09:27:42 +01:00
John Okely 51478048cd MDL-55841 enrol_lti: Make published tool list more user friendly 2016-10-25 16:13:01 +08:00
John Okely 23146bad48 MDL-55841 core: Allow copy box to be used multiple times in one template 2016-10-25 16:13:01 +08:00
Dan Poltawski 737e3c3b67 Merge branch 'MDL-56487-master' of git://github.com/andrewnicols/moodle 2016-10-25 08:42:58 +01:00
David Monllao ab9ca549e7 Merge branch 'wip-mdl-56347' of https://github.com/rajeshtaneja/moodle 2016-10-25 15:20:06 +08:00
Andrew Nicols 9c792b9861 Merge branch 'MDL-55922' of https://github.com/mr-russ/moodle 2016-10-25 15:11:43 +08:00
Dan Poltawski c435523ac5 Merge branch 'MDL-56468-master' of git://github.com/andrewnicols/moodle 2016-10-25 08:11:05 +01:00
David Monllao bf91437d25 Merge branch 'wip-mdl-55074' of https://github.com/rajeshtaneja/moodle 2016-10-25 15:09:24 +08:00
David Monllao 1d58c301c7 Merge branch 'MDL-56156-master' of git://github.com/damyon/moodle 2016-10-25 15:05:17 +08:00
Andrew Nicols b146ff9451 MDL-56004 theme_bootstrapbase: Rebuild less 2016-10-25 14:24:32 +08:00
Andrew Nicols 2979c25683 Merge branch 'MDL-56004-master' of https://github.com/damyon/moodle 2016-10-25 14:13:19 +08:00
David Monllao 5c39800880 Merge branch 'wip-mdl-53048' of https://github.com/rajeshtaneja/moodle 2016-10-25 14:00:29 +08:00
Dan Poltawski 3b89ce210d Merge branch 'MDL-56442-master' of https://github.com/StudiUM/moodle 2016-10-25 06:56:44 +01:00
Rajesh Taneja c99dffb69c MDL-55074 behat: Fixed new theme related changes 2016-10-25 13:48:51 +08:00
Dan Poltawski 0579372b70 Merge branch 'MDL-56552_master' of git://github.com/dmonllao/moodle 2016-10-25 06:45:15 +01:00
Dan Poltawski 1a2497c3c2 Merge branch 'MDL-55902-master' of git://github.com/junpataleta/moodle 2016-10-25 06:38:13 +01:00
Damyon Wiese fb045b4e15 MDL-56004 theme: upgrade.txt note about bootstrap compatibility 2016-10-25 13:36:29 +08:00
Damyon Wiese 0862719092 MDL-56004 theme: Add some BS2 compatibility to BS4.
This is for user-created texts (e.g. the people have used the generico filter to inject BS2 markup into user tests).

It is also for existing old HTML that we have not had time to upgrade yet.
2016-10-25 13:36:23 +08:00
Damyon Wiese fe4a6c3bdb MDL-56004 theme: Add some BS4 compatibility to BS2 2016-10-25 13:36:18 +08:00
David Monllao 1e56070d34 Merge branch 'wip-mdl-55981' of https://github.com/rajeshtaneja/moodle 2016-10-25 13:29:03 +08:00
Rajesh Taneja 39946dc135 MDL-53048 behat: Fixed unmasked password field to select 2016-10-25 13:23:36 +08:00
Rajesh Taneja cdb4975a44 MDL-55981 behat: Fixed groups seen by user 2016-10-25 13:19:32 +08:00
Dan Poltawski 76a6dc685d Merge branch 'MDL-56534-master' of git://github.com/crazyserver/moodle 2016-10-25 06:08:48 +01:00
David Monllao f5b07540c7 Merge branch 'MDL-56532-master' of git://github.com/andrewnicols/moodle 2016-10-25 12:43:36 +08:00
David Monllao 0add237ef5 Merge branch 'MDL-56516-master' of git://github.com/andrewnicols/moodle 2016-10-25 12:37:44 +08:00
Andrew Nicols 14d9b4fd85 MDL-56532 tool_usertours: Correct langstring uses for top/bottom 2016-10-25 12:15:34 +08:00
David Monllao 74965e29f6 Merge branch 'MDL-56006-master' of git://github.com/damyon/moodle 2016-10-25 11:51:21 +08:00
Rajesh Taneja d87dac7e70 MDL-56006 behat: Load proper context by helper 2016-10-25 11:21:53 +08:00
Russell Smith 261bfabc6f MDL-54916 filestorage: Only write empty zip on change.
In some cases we may inspect an empty zip file. If we do open
an empty zip file, check that it changed before we attempt to write
it to disk.  It may be the case that we were reading the file from
a location that we don't have write access to.
2016-10-25 14:10:36 +11:00
Andrew Nicols 85f33abf3e Merge branch 'MDL-56015-master' of git://github.com/damyon/moodle 2016-10-25 10:37:36 +08:00
Damyon Wiese 848db61636 MDL-56006 blocks: Fix installation with no required blocks
Boost requires no blocks which was causing a failure on installation.
2016-10-25 10:15:20 +08:00
Rajesh Taneja 4422ffc55e MDL-56006 behat: Get proper feature and context for default theme
No matter which theme is default theme, overridden
context and blacklisted features should be respected
2016-10-25 10:15:20 +08:00
Damyon Wiese e56b58e3c9 MDL-56006 theme: Set Boost as the default theme
Units tests have been adjusted e.g. 'boost' instead of 'clean' in pix urls.

Some places I didn't update the test to reflect the boost markup and reset
the theme to clean. This is because the test was not testing the markup - but the
functionality (e.g. looking for specific structures to indicate an error in a form element).
2016-10-25 10:15:20 +08:00
Damyon Wiese 976b635d7b MDL-56015 theme_boost: Clean up pix folder
Add real screenshot of new theme and delete unused images and icons.
2016-10-25 10:09:07 +08:00
Andrew Nicols 6db92c6c37 MDL-56516 tool_usertous: Remove eroneous test 2016-10-25 08:54:33 +08:00
Andrew Nicols 67b49f27a4 MDL-56516 tool_usertours: Adjust tour query for MySQL 2016-10-25 08:39:36 +08:00
Eloy Lafuente (stronk7) 6858c7acec Merge branch 'MDL-48350-M32' of git://github.com/lazydaisy/moodle 2016-10-24 20:30:11 +02:00
Eloy Lafuente (stronk7) d6ab5917fa Merge branch 'MDL-56532-master' of git://github.com/andrewnicols/moodle 2016-10-24 20:05:03 +02:00
jmalmsten-panopto 3480411e0d MDL-46942 core_backup: added original course id to restore event 2016-10-24 09:01:34 -07:00
Dan Poltawski b5c5d741c4 Merge branch 'MDL-56538-master' of git://github.com/crazyserver/moodle 2016-10-24 15:50:55 +01:00
Dan Poltawski b37895a13a Merge branch 'MDL-56531-master' of git://github.com/andrewnicols/moodle 2016-10-24 15:43:27 +01:00
Dan Poltawski 2eb61a66dc Merge branch 'wip-MDL-56439-master' of git://github.com/marinaglancy/moodle 2016-10-24 14:33:53 +01:00
Andrew Nicols c6698a4f0f MDL-56532 tool_usertours: Improve help for step editing 2016-10-24 21:21:44 +08:00
Andrew Nicols 3f41a803e7 MDL-56531 tool_usertours: Run step title/content through filters 2016-10-24 21:18:10 +08:00
Pau Ferrer Ocaña 8845688ce4 MDL-56534 assign: Add grading status on get_submissions WS 2016-10-24 13:24:18 +02:00
John Beedell 0cfeb01496 MDL-56395 Gradebook item titles - adjusting category titles 2016-10-24 11:43:10 +01:00
Juan Leyva a18cb9d84f MDL-29795 assign: Apply overrides to get_assignments
This commit also fix a problem in the previous commit
2016-10-24 11:24:40 +01:00
Damyon Wiese 6b8e798db1 MDL-29795 assign: Apply overrides before saving a submission
From the webservice.
2016-10-24 11:04:10 +01:00
Ilya Tregubov d685b95935 MDL-29795 mod_assign: Add user/group override assignment module 2016-10-24 11:03:49 +01:00
John Beedell 89eacee7a2 MDL-56395 Gradebook: Make long item titles more accessible 2016-10-24 10:51:59 +01:00
Frédéric Massart 17553c6350 MDL-56213 theme_boost: Visual inconsistencies in backup/restore
* Some additional SCSS rules were added to be more visually pleasing
* Javascript had to be tweaked as targets were too specific
2016-10-24 10:29:38 +01:00
Lee Campbell 74866f8f16 MDL-56323 core_user: User profile field default value not on signup page
The default value of a configured text input user profile field is not rendering on signup page
2016-10-24 09:32:32 +01:00
Dan Poltawski a809969691 Merge branch 'MDL-56350-master' of git://github.com/andrewnicols/moodle 2016-10-24 09:17:52 +01:00
David Monllao 8823be0b60 Merge branch 'MDL-56516-master' of git://github.com/andrewnicols/moodle 2016-10-24 15:41:34 +08:00
David Monllao 3ea1fa18cc Merge branch 'mdl56466-master' of https://github.com/tlock/moodle 2016-10-24 15:23:51 +08:00
Andrew Nicols 6511cf7795 MDL-56509 tool_usertours: Remove guest from list and add admin
It is not possible to display a tour to users with the guest role so remove
all users with this archetype from the list.

This also changes behaviour such that it is possible to target a tour just
to administrators and administrators are not shown the tours for roles
which they do not have in the current context.
2016-10-24 15:11:54 +08:00
David Monllao 1b14f1a497 Merge branch 'MDL-55981-master' of git://github.com/andrewnicols/moodle 2016-10-24 14:06:17 +08:00
Andrew Nicols 5fe4bd6422 MDL-55981 core: Correct availability tests to use editingteacher 2016-10-24 13:59:33 +08:00
Andrew Nicols 33492029de Merge branch 'MDL-56321-master' of git://github.com/damyon/moodle 2016-10-24 13:29:31 +08:00
David Monllao c10cd185a9 Merge branch 'MDL-55981-master' of git://github.com/andrewnicols/moodle 2016-10-24 13:20:42 +08:00
David Monllao 0c6cf86925 MDL-55074 theme_boost: Deleting old file 2016-10-24 13:11:38 +08:00
David Monllao 93432c781e MDL-56552 tool_mobile: No phpunit timing issues 2016-10-24 12:57:52 +08:00
David Monllao 947970fc49 MDL-55074 boost: Fixing issues reported by stylelint 2016-10-24 12:40:40 +08:00
David Monllao 48f43096e0 Merge branch 'MDL-55074-master' of git://github.com/damyon/moodle 2016-10-24 12:33:51 +08:00
Damyon Wiese df25a884e8 MDL-56321 theme_boost: Remove extra styling from context_header 2016-10-24 12:11:13 +08:00
Frédéric Massart e9a009dcd6 MDL-56321 theme_boost: Profile page adjustments
- Removed the border overlapping a user's avatar. This only affected
  course profiles and the default preset.
- Do not break the sections when they wrap from one column to another
- Sneaked in a change to remove left/right padding on .box. I've been
  wanting to change that since I added it. The padding on top and bottom
  is sometimes useful to separate boxes, but the left/right padding
  should be applied by the general structure.
2016-10-24 12:11:12 +08:00
Andrew Nicols 49b78f21b4 Merge branch 'MDL-56533-master' of git://github.com/crazyserver/moodle 2016-10-24 12:07:40 +08:00
Damyon Wiese 4b937932a2 MDL-55074 theme_behat: Behat fixes for user_grade_navigation 2016-10-24 12:00:23 +08:00
David Monllao aaa2788e42 Merge branch 'MDL-56129-master' of git://github.com/andrewnicols/moodle 2016-10-24 11:56:06 +08:00
Andrew Nicols c823bfee62 MDL-56129 core: Set a timeout on the session cookie
This is primarily because iOS has changed something under the hood which
means that only session cookies which have an expiry are passed around the
OS.

In order to make media playable outside of the browser (e.g. a video), we
must set a session cookie timeout.

Since the session timeout is configurable, this patch sets the cookie
timeout to the session timeout plus a period of one week.

This ensures that videos continue to work, and that the expired session
message is shown on the login page, but without requiring excessively long
session times.
2016-10-24 11:47:06 +08:00
Andrew Nicols 1093e43bda MDL-56516 tool_usertours: Cache tours and steps 2016-10-24 11:34:10 +08:00
David Monllao 80b74762c9 DML-53048 forms: Remove conflict resultion remaining bit
Change wrong alternative references as well.
2016-10-24 11:16:53 +08:00
David Monllao 8f68e0343a Merge branch 'MDL-53048-master' of git://github.com/andrewnicols/moodle 2016-10-24 11:12:25 +08:00
Luke Carrier 14d6c1cf79 MDL-55902 my: Add additional information to dashboard reset events
* Add $private and $pagetype information to the 'other' parameter of
the dashboard(s) reset events.
2016-10-24 11:03:10 +08:00
Damyon Wiese 3f1fa45771 MDL-55074 theme_boost: Phantomjs robustness
Raj was seeing some fails with phantomjs because the action menus were not open after clicking
on the link to open them. Make sure we look for the open menu before continuing.
2016-10-24 10:38:43 +08:00
David Monllao 055cc7d037 Merge branch 'MDL-56252-master' of git://github.com/ryanwyllie/moodle 2016-10-24 10:25:32 +08:00
Andrew Nicols ab00bf59a5 Merge branch 'MDL-56341-master' of git://github.com/damyon/moodle 2016-10-24 10:11:20 +08:00
David Monllao 40e342718b Merge branch 'MDL-56380_master' of git://github.com/markn86/moodle 2016-10-24 10:04:45 +08:00
Damyon Wiese 8387614051 MDL-55074 theme_boost: Undefined variable in perf footer 2016-10-24 10:03:04 +08:00
Andrew Nicols c071a83c94 Merge branch 'MDL-56355-master' of git://github.com/ryanwyllie/moodle 2016-10-24 09:47:43 +08:00
David Monllao 8cf4139074 Merge branch 'MDL-56090_master' of git://github.com/markn86/moodle 2016-10-24 09:35:28 +08:00
Andrew Nicols ca25005c69 MDL-53048 form: Rewrite passwordunmask
This version:
* should work with the Behat Goutte driver
* should not suffer from password autofill anxiety
* should allow unmasking (and masking) of a password
* should allow editing of passwords in either masked, or unmasked form

AMOS BEGIN
 MOV [revealpassword,core_form],[passwordunmaskrevealhint,core_form]
AMOS END
2016-10-24 09:24:39 +08:00
Andrew Nicols ac157b0bbe MDL-53048 forms: Deprecate prevent_form_autofill_password 2016-10-24 08:19:44 +08:00
Yuriy Osychenko 6e7f41715f MDL-53098 lib: Mark form as submitted in confirmation dialog.
If the quiz attempt use popup window with Javascript security it will
show to the user misleading message that he is going to lose entered
data.
To avoid this we should mark form as submitted to turn off browser`s
pop-up window when user confirms finishing attempt.
Also we need to check if core_formchangechecker is present on a page.
2016-10-24 00:39:28 +03:00
David Mudrák 5b1a074d89 MDL-54833 workshop: Provide accessible links to the current phase tasks
The screen reader had to read through all the phases tasks. This patch
adds an accessibility link to the list of the current phase tasks so the
user can skip directly to them.
2016-10-21 22:57:58 +02:00
David Mudrák 56201bcdef MDL-54833 workshop: Enhance usability of switching to the next phase
Many users did not realize the need to switch the phase manually. This
patch adds a new explicit task to the current phase to do that.
2016-10-21 17:10:32 +02:00
Loc Nguyen 52554b172f MDL-54833 workshop: Enhance accessibility of the userplan widget
Change userplan HTML structure from table to unordered definition list
<dl> <dt> and <dd>. Add accessibility string for task-todo, task-done,
task-fail, task-info to be read by screen reader
2016-10-21 17:03:06 +02:00
Eloy Lafuente (stronk7) bf6cfca285 Merge branch 'MDL-56529-master' of git://github.com/junpataleta/moodle 2016-10-21 13:03:56 +02:00
Ruslan Kabalin 19f8cd61b0 MDL-53366 antivirus_clamav: Remove "Quarantine directory" setting. 2016-10-21 11:49:44 +01:00
Ruslan Kabalin f8927a7cde MDL-50888 antivirus: Unit test refactoring.
Remove all cleanup and exception test references. We expect plugin just to
respond with scanning result constant and notice where applicable.

Add tests for \core\antivirus\manager.
2016-10-21 11:48:49 +01:00
Ruslan Kabalin 4cc1b5bc0c MDL-50888 antivirus: Move post-scan logic to manager.
In the initial implementation, infected file cleanup and exception throwing
was done at the plugin level. This is somewhat incorrect from plugin
responsibility perspective. The patch moves cleanup and exception logic to
the manager. Antivirus plugin responsibility is limited to perform scanning
and respond with one of the result statuses defined in the
\core\antivirus\scanner.
2016-10-21 11:48:49 +01:00
Ruslan Kabalin 83a43b88fe MDL-50888 antivirus_clamav: Unit tests refactoring.
Due to configurable nature of scanning method selection, unit test needs to
be updated to always point to commadline method. There is no need to write
separate tests for socket scanning method, as the scanning method needs to
be mocked anyway (i.e. will be identical to commandline scanning from test
perspective).
2016-10-21 11:48:48 +01:00
Ruslan Kabalin 7be0d4292a MDL-50888 antivirus_clamav: Implement scan using Unix domain sockets.
This is a faster way of scanning files than using command line exec call,
but only available on unix-like systems.
2016-10-21 11:48:48 +01:00
Pau Ferrer Ocaña 896b6e3cb0 MDL-56538 assign: Fix new grading interface UI popouts 2016-10-21 12:29:20 +02:00
lazydaisy d847581601 MDL-48350 theme_bootstrapbase: restyle action icons in docked blocks 2016-10-21 10:49:59 +01:00
Juan Leyva 5d5e30c64d MDL-56536 tool_mobile: Add logos to the get_public_config WS 2016-10-21 10:30:59 +01:00
Pau Ferrer Ocaña 28ff87bec1 MDL-56533 course: Add outcome scale information on get_course_module WS 2016-10-21 10:37:44 +02:00
Mark Nelson 1f64514def MDL-56090 core_message: added API unit tests 2016-10-21 16:22:03 +08:00
Juan Leyva 6492401d1c MDL-56307 mod: Add missing FEATURE_COMMENT in modules 2016-10-21 09:21:28 +01:00
Damyon Wiese ba5c5083c5 MDL-55074 theme_boost: Behat fixes for latest theme changes
Fix I edit profile steps
Apply fixed header in css
Remove transitions from menus for behat
Be more specific about some "I follow" steps
Navigation path changes
"Current course" node removed from nav tree
Adapt tests because there are no default blocks
Force some space between action menu items
2016-10-21 16:06:54 +08:00
Andrew Nicols 741c2d4617 MDL-56350 tool_usertours: Apply aria-hidden to other page elements
Note: This patch is in the upstream library.
2016-10-21 12:41:44 +08:00
Frédéric Massart c9c1e4baf6 MDL-56272 theme_boost: Differentiate between freeze and hardFreeze 2016-10-21 12:41:33 +08:00
Damyon Wiese 245d354c6c MDL-55074 theme_boost: Unit test fixes for all these changes 2016-10-21 12:40:06 +08:00
Damyon Wiese 6e79ea5846 MDL-55074 theme_boost: Styling for grade reports 2016-10-21 12:40:06 +08:00
Damyon Wiese c6d9d29da1 MDL-55074 theme_boost: Improve the display of the menus in the footer 2016-10-21 12:40:06 +08:00
Damyon Wiese d430a7c336 MDL-55074 navigation: Menu and nav changes
"Grades" belongs in the navigation block, not the settings block.
Course / Activity menus should not include a link to the full settings page list, if it is the same as the menu.
Competencies belongs in the navigation block not the settings block.
2016-10-21 12:40:05 +08:00
Damyon Wiese 70fda55e85 MDL-55074 theme_boost: Make dropdowns consistent
Links in drop down menu items should fill the entire row and be
displayed as normal text color (they are like buttons).
2016-10-21 12:40:05 +08:00
Damyon Wiese b45fdc6838 MDL-55074 theme_boost: Move the custom menu into the footer
On mobile screen sizes only.
2016-10-21 12:40:05 +08:00
Damyon Wiese 7f20e8e7cb MDL-55074 theme_boost: Custom renderer fails on book
Handle nav tree nodes with action_links in them.
2016-10-21 12:40:05 +08:00
Damyon Wiese fe009bdeaa MDL-55074 theme_boost: Workaround for popovers
The custom-interaction events have a bug where if they are used twice, they fire 2 events.

The bug still exists - this is a workaround.
2016-10-21 12:40:05 +08:00
Damyon Wiese c13115cbfa MDL-55074 blocks: Remove default blocks from course and site 2016-10-21 12:40:05 +08:00
Damyon Wiese 6afd1c60c0 MDL-55074 theme_boost: Fix weird text wrapping in block titles 2016-10-21 12:40:05 +08:00
Damyon Wiese e85d09635d MDL-55074 theme_boost: Rename default only block region 2016-10-21 12:40:05 +08:00
Damyon Wiese a42a065a20 MDL-55074 theme_boost: Do not show flatnav by default before login 2016-10-21 12:37:33 +08:00
Damyon Wiese c9d6a04743 MDL-55074 nav: Put the course nav above the site nav 2016-10-21 12:37:33 +08:00
Damyon Wiese cbdbe7d812 MDL-55074 theme_boost: Current flat nav node should be subtle 2016-10-21 12:37:33 +08:00
Damyon Wiese 0a58ec243d MDL-55074 theme_boost: Move blocks back into the page 2016-10-21 12:37:33 +08:00
Damyon Wiese 5004baaad4 MDL-55074 theme_boost: Only show activity edit menu on first page 2016-10-21 12:37:33 +08:00
Damyon Wiese e226461dab MDL-55074 navigation: Add editing links back to nav
In theme boost - don't support edit_buttons in the page.
2016-10-21 12:37:33 +08:00
Damyon Wiese 598b3f095f MDL-55074 theme_boost: Make sections different in flat nav 2016-10-21 12:37:33 +08:00
Damyon Wiese 8a2ab5f72d MDL-55074 navigation: Always show dashboard/home in flat nav 2016-10-21 12:37:33 +08:00
Damyon Wiese 0f73f3ab42 MDL-55074 blocks: navigation and settings blocks optional
This is a theme config setting.
They are forced on for behat always.
2016-10-21 12:37:33 +08:00
Damyon Wiese 4a3d8169f3 MDL-55074 theme_boost: Prevent page scrolling when scrolling in a drawer 2016-10-21 12:37:33 +08:00
Damyon Wiese 99061152af MDL-55074 theme_boost: Navigation and blocks
This patch includes a big set of changes that are all designed to work together to provide
a better way to navigate in the new theme, and a different way of working with blocks.

Blocks have been moved to a "drawer" that can be opened and closed (this is remembered in a user pref).

A new "flat navigation" element is also available in a drawer - which should let you do 90% of things
without needing to open the "blocks" drawer.

The flat navigation is build from specific parts of the nav tree - the top nodes like "calendar, dashboard" are
hand picked. There is a mycourses node listing your enrolled courses.

There is a node for the current course, built from the top nodes in the current course node in the nav tree.

Administrators have a link to the Site admin settings here too.

These nav elements are used by the templates for the new theme, which also has a resigned layout for login and signup.

There have also been some additional fixes / improvements to the scss for the new theme which goes along with these
layout changes.

This set of changes is a collaboration between Martin, Damyon and Alberto (thanks!).
2016-10-21 12:37:33 +08:00
Jun Pataleta 0766dd669b MDL-56529 enrol_lti: Fix for tool_provider_test
* Use -1 for simulating a non-existent tool for
  tool_provider_testcase::test_constructor_with_non_existent_tool()
2016-10-21 12:34:00 +08:00
Mark Nelson c7ef6d8f3b MDL-54781 core_theme: removed unused message styles 2016-10-21 11:26:01 +08:00
Andrew Nicols 1e5da52de8 MDL-56530 tool_usertours: Correct arrow location 2016-10-21 11:08:56 +08:00
Andrew Nicols b7daff836d MDL-56487 tool_usertours: Sort blocks alphabetically 2016-10-21 10:53:21 +08:00
Russell Smith ae9e735c77 MDL-56347 caching: Better class variables for notices. 2016-10-21 09:21:11 +08:00
Rajesh Taneja 502b66f53d MDL-56347 phpunit: Set class for alternative cache store
If alternative cache store is sued, then set the class
and warn user about this.
2016-10-21 09:20:37 +08:00
Andrew Nicols 4ceed4dfa6 MDL-55981 core: Remove site:accessallgroups from teacher 2016-10-21 08:55:58 +08:00
Daniel Thee Roperto 8b9ca065d8 MDL-56250 forms library: Changed form to validate once per object.
If two instances of moodleforms are validated in the same run, most
likely a phpunit test run, it would store the first validation result.
Now it stores the validation result per instance, not for all instances.
2016-10-21 10:43:03 +11:00
David Ligne f2510387e5 MDL-56442 administration: Display hours in maintenance mode messages 2016-10-20 13:17:07 -04:00
Eloy Lafuente (stronk7) 919b9dfabd weekly release 3.2dev 2016-10-20 17:52:33 +02:00
Eloy Lafuente (stronk7) 42b5234209 NOBUG: Fixed file access permissions 2016-10-20 17:52:32 +02:00
Eloy Lafuente (stronk7) f8e7143fca Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-10-20 17:52:29 +02:00
Mark Nelson f9408b6dd7 MDL-56403 message_popup: removed unnecessary sesskey from URL 2016-10-20 17:42:10 +08:00
Mark Nelson fcc13c6527 MDL-56380 core_message: prevent default behaviour for links 2016-10-20 16:36:59 +08:00
Dan Poltawski 9876856dca Merge branch 'MDL-52777-master-bug' of github.com:andrewnicols/moodle 2016-10-20 08:02:08 +01:00
Andrew Nicols 31c3b7a2e1 MDL-52777 tool_usertours: Stop testing pending upgrades 2016-10-20 14:51:57 +08:00
Andrew Nicols aea13e1c26 MDL-52777 tool_usertours: Fix matching tour test 2016-10-20 14:51:57 +08:00
Ryan Wyllie 54d83992b4 MDL-56252 message: clean message text in message area
Remove the HTML tags from any message in the message area when updating
the last message on the contact otherwise the styling breaks and also
allows <script> tags to be added to the page.
2016-10-20 06:49:26 +00:00
David Monllao c6509ee31d Merge branch 'MDL-52777-master-bug' of github.com:andrewnicols/moodle 2016-10-20 14:09:57 +08:00
Andrew Nicols 55dba8058f MDL-52777 tool_usertours: Only return tours with steps 2016-10-20 13:44:18 +08:00
Russell Smith 0de42ff66a MDL-56444 logstore: Stop gc during memory size test. 2016-10-20 15:56:42 +11:00
Frédéric Massart a89cf23744 MDL-56341 mustache: JS engines handles strings wrapped in quote
Prior to the patch the strings wrapped as the following one
where not found and replaced when rendering the template via Javascript

{{#quote}}{{#str}}string,component{{/str}}{{/quote}}
2016-10-20 12:13:42 +08:00
David Monllao 1b07e80edf Merge branch 'MDL-52777-master-bug' of github.com:andrewnicols/moodle 2016-10-20 11:50:32 +08:00
David Monllao 664b637101 Merge branch 'wip-mdl-55926' of https://github.com/rajeshtaneja/moodle 2016-10-20 11:48:53 +08:00
Rajesh Taneja 48cf062595 MDL-55926 behat: Fixed undefined steps 2016-10-20 11:26:27 +08:00
Andrew Nicols c4d5fb53ce MDL-52777 tool_usertours: Only check plugin for needs update
The moodle_needs_upgrade() function includes every version.php in Moodle
which poses a performance issue, especially when called on every page.
2016-10-20 11:16:54 +08:00
David Monllao 04ec8f6ef8 Merge branch 'MDL-52777-master-bug' of github.com:andrewnicols/moodle 2016-10-20 10:09:28 +08:00
Andrew Nicols a8dded9bfc MDL-52777 tool_usertours: Correct & to && in test 2016-10-20 09:54:26 +08:00
Eloy Lafuente (stronk7) ed971b90eb Merge branch 'MDL-53832-master-review-fixes' of https://github.com/junpataleta/moodle 2016-10-20 02:25:59 +02:00
Dan Poltawski 2d13900f6d Merge branch 'MDL-55823_master' of git://github.com/markn86/moodle 2016-10-19 10:47:35 +01:00
Damyon Wiese 058f2fb68e MDL-56156 theme_boost: enrol_users filter form styles
Allow wrapping any mform in a "form-inline" div to make it a responsive inline form.
Use this for the enrol users filter for and get rid of a good chunk of custom styles.
2016-10-19 17:10:22 +08:00
Mark Nelson 6aa019682c MDL-55823 core_message: added WS unit tests 2016-10-19 17:07:58 +08:00
Jun Pataleta b75d0f0de2 MDL-53832 enrol_lti: Update codes to use the new DB field names 2016-10-19 17:01:34 +08:00
Jun Pataleta fa015abf7b MDL-53832 enrol_lti: Update data_connector to use the new DB field names 2016-10-19 17:01:30 +08:00
Jun Pataleta d1e85a0045 MDL-53832 enrol_lti: Make DB column names more moodle-ish 2016-10-19 17:01:22 +08:00
Andrew Nicols 68855baecd MDL-52777 tool_usertours: Prepare target data when displaying form 2016-10-19 15:40:53 +08:00
David Monllao c24a410f43 Merge branch 'MDL-52777-master-bug' of github.com:andrewnicols/moodle 2016-10-19 15:02:44 +08:00
Andrew Nicols 42bb3f8b66 MDL-52777 tool_usertours: Less strict comparison for tour ID 2016-10-19 14:57:13 +08:00
Ryan Wyllie 4788031edf MDL-56337 message: fix behat for phantomjs 2016-10-19 06:35:12 +00:00
Andrew Nicols a42a5e21eb MDL-52777 tool_usertours: Remove unused template 2016-10-19 13:26:54 +08:00
Jun Pataleta 6092bbc07a MDL-53832 enrol_lti: Map consumer to tool and handle instance deletion 2016-10-19 11:14:28 +08:00
Jun Pataleta c314d6ed8e MDL-53832 enrol_lti: Unit tests for tool_provider
Original subtask: MDL-55647.
2016-10-19 11:14:27 +08:00
Jun Pataleta daebcd2801 MDL-53832 enrol_lti: Improve provider logic
* onRegister
  - Validate returnUrl and consumer object.
  - Use moodle_url for the returnURL.
  - Set success message on successful registration.
  - Reorganise code.
* Constructor
  - Remove required params we don't need (Original sub-task: MDL-56035)
* onLaunch
  - Validate consumer object.
  - Set appropriate values for OK flag and message.
* Import classes.
2016-10-19 11:14:27 +08:00
John Okely 0b72caebac MDL-53832 enrol_lti: Allow multiple LTI1 consumers with the same key 2016-10-19 11:14:27 +08:00
John Okely a618c707f2 MDL-53832 enrol_lti: Support user images
Original subtask MDL-55718.
2016-10-19 11:14:27 +08:00
John Okely 8e0038f9ea MDL-53832 enrol_lti: Only allow certain consumers for each shared tool
Original subtask: MDL-55753.
2016-10-19 11:14:27 +08:00
John Okely f8307a4b57 MDL-53832 enrol_lti: Unit test more of helper 2016-10-19 11:14:26 +08:00
John Okely 098ee549ee MDL-53832 enrol_lti: Split launch and proxy registration end points
Original subtask: MDL-55752.
2016-10-19 11:14:26 +08:00
John Okely da65fcf027 MDL-53832 enrol_lti: Separate tool launch and proxy registration logic 2016-10-19 11:14:26 +08:00
John Okely 7edf96e265 MDL-53832 enrol_lti: Add language strings and renderers 2016-10-19 11:14:26 +08:00
Jun Pataleta d49f57c886 MDL-53832 enrol_lti: Make LTI1 launch URLs work with new library
Original subtask: MDL-55562.
2016-10-19 11:14:25 +08:00
Jun Pataleta 0d26a2313c MDL-53832 enrol_lti: Unit tests for data_connector
Original subtask: MDL-55529.
2016-10-19 11:14:25 +08:00
Jun Pataleta 9191a94143 MDL-53832 enrol_lti: Add data_connector
Original subtask: MDL-55529.
2016-10-19 11:14:25 +08:00
John Okely 9161e71515 MDL-53832 enrol_lti: Add LTI2 tables to enrol_lti 2016-10-19 11:14:25 +08:00
John Okely 9a709cd5a5 MDL-53832 enrol_lti: Add interface for proxies 2016-10-19 11:14:24 +08:00
John Okely a1f3821ee0 MDL-53832 enrol_lti: Add LTI provider library 2016-10-19 11:14:24 +08:00
Ryan Wyllie 65be5b6c11 MDL-56355 message: add keyboard nav to notification page 2016-10-19 03:05:33 +00:00
David Monllao cfc561d0de MDL-52777 usertours: Toothpaste for tabs again 2016-10-19 10:58:21 +08:00
David Monllao 91aeb866e0 MDL-52777 usertours: Replacing tabs by spaces
Also dos2unix to svgs just in case.
2016-10-19 10:40:40 +08:00
David Monllao 2c2dde28f2 MDL-52777 usertours: Remove empty styles file 2016-10-19 10:34:12 +08:00
David Monllao c66027cf4e Merge branch 'MDL-52777-master' of git://github.com/andrewnicols/moodle 2016-10-19 09:59:27 +08:00
Andrew Nicols 001fc061bd MDL-52777 tool_usertours: Add the new User Tours plugin 2016-10-19 09:48:03 +08:00
David Monllao 27f01529ab Merge branch 'MDL-56218-master' of git://github.com/FMCorz/moodle 2016-10-19 09:33:06 +08:00
Eloy Lafuente (stronk7) be1ff9a1ee MDL-43230 badges: new cap version bump 2016-10-18 22:58:27 +02:00
Eloy Lafuente (stronk7) 8c88830a43 Merge branch 'MDL-43230-master' of git://github.com/ryanwyllie/moodle 2016-10-18 22:35:53 +02:00
Eloy Lafuente (stronk7) ffe9505d2b Merge branch 'MDL-56295-master' of git://github.com/andrewnicols/moodle 2016-10-18 20:02:22 +02:00
Eloy Lafuente (stronk7) e74c54ec4d Merge branch 'MDL-56270-master' of git://github.com/andrewnicols/moodle 2016-10-18 19:11:51 +02:00
Eloy Lafuente (stronk7) 05e588a056 Merge branch 'MDL-56293-master' of git://github.com/andrewnicols/moodle 2016-10-18 19:08:08 +02:00
Eloy Lafuente (stronk7) 881e611c33 Merge branch 'MDL-53752-master' of git://github.com/andrewnicols/moodle 2016-10-18 19:06:26 +02:00
Eloy Lafuente (stronk7) 3fdbba0e27 Merge branch 'MDL-29774-master-by-sam-wilson' of git://github.com/junpataleta/moodle 2016-10-18 18:26:50 +02:00
Dan Poltawski 876fc28255 MDL-56082 auth: minor tweak to login block idp links
No longer set the return url to $SESSION->wantsurl, it doens't make
sense in this context, as the user is probably on the page they want.

Also add a note about this functionality to auth/ugrade.txt
2016-10-18 17:19:03 +01:00
Dan Poltawski a477b761be Merge branch 'master' of https://github.com/rimas-kudelis/moodle 2016-10-18 17:03:21 +01:00
Dan Poltawski ad2eba780a Merge branch 'MDL-55926-master-3' of git://github.com/ryanwyllie/moodle 2016-10-18 16:31:42 +01:00
Eloy Lafuente (stronk7) 0e51800e5f Merge branch 'MDL-55858-master' of git://github.com/andrewnicols/moodle 2016-10-18 17:00:21 +02:00
Dan Poltawski 55c7a86632 Merge branch 'wip-MDL-55833-master' of git://github.com/marinaglancy/moodle 2016-10-18 15:26:31 +01:00
Dan Poltawski 0022812b71 Merge branch 'MDL-55736-master' of git://github.com/FMCorz/moodle 2016-10-18 13:48:46 +01:00
Dan Poltawski cfa69ad260 Merge branch 'MDL-56131-master' of git://github.com/andrewnicols/moodle 2016-10-18 13:44:33 +01:00
Dan Poltawski c0b1f18930 MDL-55924 behat: fix misleading comment 2016-10-18 13:24:08 +01:00
Dan Poltawski 01bc6a35bc Merge branch 'wip-mdl-55924' of https://github.com/rajeshtaneja/moodle 2016-10-18 13:22:56 +01:00
Dan Poltawski 846baba950 Merge branch 'wip-mdl-55746' of https://github.com/rajeshtaneja/moodle 2016-10-18 12:37:32 +01:00
Dan Poltawski 551c7e6c38 Merge branch 'wip-MDL-55087-master' of git://github.com/abgreeve/moodle 2016-10-18 12:32:08 +01:00
Dan Poltawski d98ab2a585 Merge branch 'MDL-56062-master' of https://github.com/lucisgit/moodle 2016-10-18 12:06:27 +01:00
Dan Poltawski 1bcaff71d8 Merge branch 'MDL-56159_master-phpunit-fix' of git://github.com/dmonllao/moodle 2016-10-18 11:26:18 +01:00
David Monllao 8d92dbd1fc MDL-56159 user: Fix unit test
The exception that is being thrown changed to moodle_exception
with usernotfullysetup error code.
2016-10-18 18:24:47 +08:00
Dan Poltawski c70b9e8451 Merge branch 'MDL-56081-master' of git://github.com/andrewnicols/moodle 2016-10-18 11:24:36 +01:00
Eloy Lafuente (stronk7) 772c7b4733 Merge branch 'MDL-56275-master' of git://github.com/danpoltawski/moodle 2016-10-18 12:16:28 +02:00
Dan Poltawski 9def79f79a MDL-56275 blog: do not display the 'choose a link' button
When registereing an external blog the choose a link button is
misleading, we don't have any repos which restrict to RSS feeds, so the
majority of results you get from the repo picker will be wrong.
2016-10-18 11:07:54 +01:00
David Monllao 5f02fd5072 Merge branch 'MDL-56159-master' of git://github.com/jleyva/moodle 2016-10-18 17:27:48 +08:00
Eloy Lafuente (stronk7) 8e13213427 Merge branch 'MDL-56436-master' of git://github.com/danpoltawski/moodle 2016-10-18 11:21:31 +02:00
David Monllao d244cf1fd7 MDL-56277 theme_boost: Converting EOLs to unix style 2016-10-18 17:14:11 +08:00
Juan Leyva 43d8e805bb MDL-56159 webservice: Tolerate exceptions in the get_autologin_key ws 2016-10-18 09:44:10 +01:00
Juan Leyva 80e0f0b85b MDL-56159 webservice: Improve not fully setup and missing pwd checks
Removing the check in login/token.php is secure since the
auth_forcepasswordchange is checked in require_login that is called via
validate_context.
The user must be able to get a token even if that setting is on. With
that token we’ll redirect the user to the site or we’ll change the
password when a new WS for that is available.
2016-10-18 09:44:09 +01:00
David Monllao b7676ef92c Merge branch 'MDL-56277-master' of git://github.com/FMCorz/moodle 2016-10-18 16:33:21 +08:00
Eloy Lafuente (stronk7) 2017a60e11 MDL-55175 course: Fix typo & parenthesis 2016-10-18 10:12:30 +02:00
Eloy Lafuente (stronk7) 1f89aba18f Merge branch 'MDL-55175-master-2' of git://github.com/andrewnicols/moodle 2016-10-18 10:12:29 +02:00
David Monllao 3ac4a74777 Merge branch 'MDL-56328-M32' of git://github.com/lazydaisy/moodle 2016-10-18 16:05:53 +08:00
Eloy Lafuente (stronk7) 5dea1f12fc Merge branch 'MDL-56345-master' of https://github.com/lucisgit/moodle 2016-10-18 09:37:47 +02:00
David Monllao 51607c7ea3 Merge branch 'MDL-56214-master' of git://github.com/FMCorz/moodle 2016-10-18 15:02:41 +08:00
Andrew Nicols 6e39d07e4d MDL-56468 theme_boost: Correct heading level of modal dialogue 2016-10-18 14:19:13 +08:00
David Monllao 36259a1cc3 Merge branch 'MDL-56411-int-fix' of github.com:ryanwyllie/moodle 2016-10-18 14:00:29 +08:00
Simey Lameze acf17832d6 MDL-56017 filters: Update MathJax to version 2.7 2016-10-18 13:29:30 +08:00
Tim Lock 0ee41475ae MDL-55456 course: set context for category ajax requests 2016-10-18 12:50:21 +10:30
Ryan Wyllie f5a174f451 MDL-56411 message: dont render message area without other user
Stop the message area header and footer from being rendered if there is
no other user being messaged, otherwise notices are generated and the
messages fail to send.
2016-10-18 02:00:09 +00:00
Tim Lock 65b4dce6f8 MDL-56466 assign: fix database error with team submissions
This fixes the error when viewing the Grading summary with Blind Marking and Team submission is enabled:

ERROR: Incorrect number of query parameters. Expected 32, got 31.
2016-10-18 12:11:45 +10:30
Sam Wilson 813c0590f7 MDL-29774 core_user: Update group-membership summaries on AJAX calls 2016-10-18 09:31:36 +08:00
David Monllao 326d861978 MDL-45639 ws: Remove trailing whitespace 2016-10-18 08:40:25 +08:00
David Monllao 4455ff2cba Merge branch 'MDL-45639-master' of git://github.com/jleyva/moodle 2016-10-18 08:26:25 +08:00
Ryan Wyllie f05c1013de MDL-55926 message: add behat tests for message ui 2016-10-18 00:26:21 +00:00
Ben Kelada d96030ce07 MDL-56372 lib: use static binding to allow overrides in api 2016-10-18 11:23:49 +11:00
Eloy Lafuente (stronk7) 7da431d2ca Merge branch 'wip-MDL-48629-master' of https://github.com/Beedell/moodle 2016-10-18 01:58:31 +02:00
Eloy Lafuente (stronk7) c74bbbb6d5 Merge branch 'MDL-55518-master' of git://github.com/andrewnicols/moodle 2016-10-18 01:43:52 +02:00
Eloy Lafuente (stronk7) 7b7dbac4e8 Merge branch 'wip-mdl-56369' of https://github.com/rajeshtaneja/moodle 2016-10-18 01:32:58 +02:00
Eloy Lafuente (stronk7) b3a089e864 Merge branch 'wip-mdl-56348' of https://github.com/rajeshtaneja/moodle 2016-10-18 01:10:23 +02:00
Eloy Lafuente (stronk7) 3dd505af7d Merge branch 'MDL-56368-M32' of git://github.com/lazydaisy/moodle 2016-10-18 00:38:47 +02:00
Russell Smith 4f391d7a33 MDL-55143 unittests: Check the db rather than cache for version hash. 2016-10-18 09:35:22 +11:00
Eloy Lafuente (stronk7) a14edb9fbb Merge branch 'MDL-56022_m32v3' of https://github.com/sbourget/moodle 2016-10-18 00:07:17 +02:00
Gareth J Barnard 8deec8835f MDL-55913 themes: Long week names overflow main region. 2016-10-17 22:42:10 +01:00
Eloy Lafuente (stronk7) 682074fe5b MDL-56100 mod_folder: add missing $OUTPUT for recent activity report. 2016-10-17 23:06:54 +02:00
Eloy Lafuente (stronk7) 2aa983c006 Merge branch 'MDL-56100-master' of https://github.com/mackensen/moodle 2016-10-17 22:58:11 +02:00
Stephen Bourget 1b467cb8cf MDL-56022 Assign: Make folders structure in the downloaded zip optional
Special thanks to Matt McDermott for the contributing the Javascript
code to fix this issue.
2016-10-17 16:19:28 -04:00
Eloy Lafuente (stronk7) 087476c711 Merge branch 'MDL-56440-master' of git://github.com/danpoltawski/moodle 2016-10-17 20:55:23 +02:00
Eloy Lafuente (stronk7) b705cefa18 Merge branch 'MDL-56300_master' of git://github.com/reskit/moodle 2016-10-17 18:50:07 +02:00
Eloy Lafuente (stronk7) aa46cb9503 Merge branch 'MDL-56057_master' of git://github.com/dmonllao/moodle 2016-10-17 18:42:14 +02:00
Eloy Lafuente (stronk7) cfe55553e0 Merge branch 'MDL-56005-master' of git://github.com/FMCorz/moodle 2016-10-17 18:12:33 +02:00
Dan Poltawski 54c1da6690 Merge branch 'MDL-56208-master' of git://github.com/andrewnicols/moodle 2016-10-17 12:52:26 +01:00
Dan Poltawski a4c7a0bd95 Merge branch 'MDL-54945-master-workshopportfolio' of git://github.com/mudrd8mz/moodle 2016-10-17 12:06:42 +01:00
Dan Poltawski 2ee939fb19 Merge branch 'MDL-56262-master' of git://github.com/FMCorz/moodle 2016-10-17 11:01:27 +01:00
Dan Poltawski 6578ffe4e0 Merge branch 'MDL-55630-master' of https://github.com/StudiUM/moodle 2016-10-17 10:23:35 +01:00
Dan Poltawski a227cf1278 Merge branch 'MDL-31465-master' of git://github.com/lameze/moodle 2016-10-17 10:00:08 +01:00
David Monllao c8bd606475 Merge branch 'MDL-56423-master' of git://github.com/danpoltawski/moodle 2016-10-17 15:51:51 +08:00
David Monllao 99218e916b Merge branch 'MDL-56393-master' of git://github.com/ryanwyllie/moodle 2016-10-17 15:32:33 +08:00
David Monllao 0998896e9e Merge branch 'MDL-56411-master' of git://github.com/ryanwyllie/moodle 2016-10-17 15:29:13 +08:00
David Monllao 4456e7efa6 Merge branch 'MDL-56415-master' of git://github.com/ryanwyllie/moodle 2016-10-17 15:17:16 +08:00
David Monllao 542452a97e Merge branch 'MDL-56430-master' of git://github.com/ryanwyllie/moodle 2016-10-17 15:03:51 +08:00
David Monllao 94926e5d74 Merge branch 'MDL-55510-master' of git://github.com/danpoltawski/moodle 2016-10-17 14:25:00 +08:00
Michael Aherne 0c5994269f MDL-56131 choice: Set maximum lifetime for lock 2016-10-17 13:50:42 +08:00
Andrew Nicols 608edec5ca MDL-56208 mod_forum: Move Display period below Group 2016-10-17 11:46:36 +08:00
Andrew Nicols f0f4c1939c MDL-55175 course: Begin deprecation process for pring_log_* 2016-10-17 11:08:20 +08:00
Ryan Wyllie fd8eab572d MDL-56415 message: style toggle contact button on user profile page
Changed the styles in theme_bootstrapbase for the ajax toggle
button so that the loading icon is overlaid on the element
rather than replacing it to stop the interface jarring.

Also ported those same styles to theme_boost for consistency.
2016-10-17 03:07:15 +00:00
Ryan Wyllie 54e22257c7 MDL-56338 message_popup: add behat tests for message popover 2016-10-17 01:07:59 +00:00
Adrian Greeve f34d7af0ae MDL-55087 lib: Update to htmlpurifier lib. 2016-10-17 08:43:41 +08:00
Adrian Greeve b36b997b7f MDL-55087 lib: Update htmlpurifier to v4.8.0. 2016-10-17 08:43:41 +08:00
Ryan Wyllie cdff0944b6 MDL-56430 message: fix php7 incompatibility in processor form 2016-10-17 00:27:56 +00:00
Rimas Kudelis 3e82b7ac3c MDL-56082 Expose external authentication methods in login block
Unlike the login page, login block currently does not list any configured external auth methods.
This makes it practically useless in cases where external auth (e.g. OpenID Connect) is the main login method.

This patch adds the necessary bits to make the login block great again.
2016-10-16 22:14:59 +03:00
AMOS bot 40a90b62ac Automatically generated installer lang files 2016-10-17 00:06:40 +08:00
Matthew Switlik f6beb73bdc MDL-43796 assign: Reset revealidentities on restore
Set revealidentities to 0 when restoring with blindmarking and no user data.
2016-10-14 14:10:29 -04:00
AMOS bot 3affb72c12 Automatically generated installer lang files 2016-10-15 00:04:34 +08:00
John Beedell fa677bc9df MDL-48629 Quiz: Change separator for matching correct answer feedback 2016-10-14 16:41:49 +01:00
lazydaisy 7cfb9175ac MDL-56368 theme_bootstrapbase: Settings for Restrict Access not inline. 2016-10-14 15:34:39 +01:00
lazydaisy 3cc973a082 MDL-56328 theme_bootstrapbase: reduce activity indent when not editing 2016-10-14 15:33:04 +01:00
Jean-Philippe Gaudreau 6399ecd743 MDL-55630 mod_assign: Exclude users courses from user details
Exclude users' enrolled courses for performance reason.
A new 'includeenrolments' parameter was added
to mod_assign::list_particpants.
2016-10-14 09:28:18 -04:00
Charles Fulton 1de06aa19b MDL-56100 mod_folder: add support for recent activity 2016-10-14 08:57:56 -04:00
Juan Leyva 961c95499e MDL-45639 tool_mobile: Support auto-login from the app to the site
We din't call it SSO because:
- SSO usually requires a 3rd party for authentication
- SSO term is already used in tool_mobile when supporting using auth methods like CAS or Shibboleth
2016-10-14 12:32:37 +01:00
Juan Leyva 69cbe35943 MDL-45639 webservice: Support private tokens
Private tokens are generated at the same time that the token.
They must be stored safely by the ws client, and they must be transmitted only via  https.
2016-10-14 12:32:30 +01:00
Dan Poltawski 0a51a20928 MDL-55510 upgrade: remove repository_alfresco config
This was missing from MDL-49533 and caused a complaint about alfresco
on every upgrade.
2016-10-14 09:41:31 +01:00
Ryan Wyllie 8387932ddd MDL-56393 themes: unread notification style in popover 2016-10-14 07:52:04 +00:00
Dan Poltawski e816b872ad MDL-56440 theme_boost: fix logic errors in templates 2016-10-14 08:43:22 +01:00
Dan Poltawski f60c7eae73 MDL-56436 mustache: update import docs 2016-10-14 08:31:23 +01:00
Marc Català 260713fc8e MDL-56300 mod_assign: Filtering students throws a javascript error 2016-10-14 09:28:20 +02:00
Ryan Wyllie 703ab16475 MDL-56411 message: new message to user renders message area
When messaging a user for the first time from the message button on
their profile page the message area should still be rendered.
2016-10-14 07:13:58 +00:00
acorbier 1b372a77a5 MDL-56369 behat: Updated comment for i_look_for_exceptions
After upgrade to Behat 3.x, i_look_for_exception is called from
Moodle\BehatExtension\EventDispatcher\Tester\ChainedStepTester
2016-10-14 13:22:04 +08:00
Andrew Nicols 4f1f2a3468 MDL-53752 mod_book: Clarify book title 2016-10-14 12:48:10 +08:00
Andrew Nicols 8ad2afd316 MDL-55518 travis: Enable redis tests 2016-10-14 12:16:36 +08:00
Andrew Nicols 2fff69ec72 MDL-55858 mod_forum: Remove subscription links when not relevant
When a forum is force-subscribed or subscription is disabled, do not
include the subscription link in forum posts.
2016-10-14 12:14:58 +08:00
Andrew Nicols 985ec99359 MDL-56295 mod_book: Refactor of chapter delete page 2016-10-14 12:14:07 +08:00
Andrew Nicols 6942122290 MDL-56295 mod_book: JS Confirmation of chapter removal 2016-10-14 11:29:16 +08:00
Simey Lameze 8490014955 MDL-31465 core_user: Suspended field must be boolean 2016-10-14 10:44:08 +08:00
Andrew Solomon 511db62153 MDL-31465 core_user: Incorporate user suspension into webservices 2016-10-14 10:13:49 +08:00
Ryan Wyllie 658dbdf7dd MDL-56337 message_popup: add behat tests for notification popover 2016-10-14 01:32:29 +00:00
Marina Glancy 5e4f1cfff0 MDL-56439 course: added missing require 2016-10-14 08:20:41 +08:00
Eloy Lafuente (stronk7) 6a69cda97d weekly release 3.2dev 2016-10-13 20:02:19 +02:00
Eloy Lafuente (stronk7) 43f5b288c2 NOBUG: Fixed SVG browser compatibility 2016-10-13 20:02:16 +02:00
Eloy Lafuente (stronk7) b87a9ac7a1 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-10-13 20:02:15 +02:00
Eloy Lafuente (stronk7) 1c56029fa4 Merge branch 'wip-MDL-56110-master' of https://github.com/marinaglancy/moodle 2016-10-13 19:35:48 +02:00
David Monllao dd8f30dd4f Merge branch 'wip-mdl-56299-fix' of https://github.com/rajeshtaneja/moodle 2016-10-13 19:35:48 +02:00
Rajesh Taneja d4b28e0b16 MDL-56299 behat: Popover doesn't work with phantomjs 2016-10-13 19:35:47 +02:00
David Monllao 7edfe14159 Merge branch 'wip-mdl-56087' of https://github.com/rajeshtaneja/moodle 2016-10-13 19:35:46 +02:00
Rajesh Taneja a79c2aace8 MDL-56087 behat: Fixed no messages string 2016-10-13 19:35:46 +02:00
Rajesh Taneja c5a566dc15 MDL-55522 behat: Commented failing transformations
- Reverted the order of transformations in order they are expected
- Commented failing transformation steps - MDL-56397
They should be fixed by https://github.com/Behat/Behat/issues/959
2016-10-13 19:35:45 +02:00
Mark Nelson c96717fcd9 MDL-54682 core_message: do not disable left panel when deleting messages 2016-10-13 19:32:12 +02:00
Dan Poltawski 49ba9f8fd0 Merge branch 'MDL-56384_master' of https://github.com/markn86/moodle 2016-10-13 19:32:11 +02:00
David Monllao 650beea243 Merge branch 'MDL-56095-master-fix' of git://github.com/cameron1729/moodle 2016-10-13 19:32:10 +02:00
Mark Nelson 448212ecf6 MDL-56384 message_popup: fixed oracle PHPUnit failures 2016-10-13 19:32:10 +02:00
Cameron Ball 3aa8696ce6 MDL-56095 output: Properly set prototype on custom event for IE 2016-10-13 19:32:09 +02:00
Rajesh Taneja fbaf5d17d8 MDL-27072 behat: Removed wrong tag from feature 2016-10-13 19:32:08 +02:00
David Monllao d5bd89308e Merge branch 'wip-mdl-27072' of git://github.com/rajeshtaneja/moodle 2016-10-13 19:32:08 +02:00
David Monllao 1686d93a1c MDL-55393 message: Missing latest blocker issue code updates 2016-10-13 19:32:07 +02:00
Rajesh Taneja 25b225a995 MDL-27072 behat: Fixed table separators 2016-10-13 19:32:07 +02:00
Juan Leyva e86f0cb4a1 MDL-55393 message: New WS get_user_notification_preferences 2016-10-13 19:32:06 +02:00
Eloy Lafuente (stronk7) c405d31bef Merge branch 'MDL-56319-m' of https://github.com/micaherne/moodle 2016-10-13 19:32:05 +02:00
Juan Leyva 53522c6e38 MDL-55393 message: Add some external functions to mobile service 2016-10-13 19:32:05 +02:00
Eloy Lafuente (stronk7) 403b817857 Merge branch 'wip-mdl-55522' of https://github.com/rajeshtaneja/moodle 2016-10-13 19:32:04 +02:00
Dan Poltawski 36650f11d3 MDL-56423 stylelint: ignore custom.css files
The files have non-standard css syntax and with stylelint 7.4.1
it can no longer cope with it.
2016-10-13 10:01:31 +01:00
Dan Poltawski 5c8445b5cd MDL-56423 stylelint: bump to v7.4.1
Fixes a false positive with  declaration-block-no-ignored-properties and
display: inline.
2016-10-13 10:01:30 +01:00
Dan Poltawski 53843cc18d MDL-56423 boostrap: fix eranously removed css 2016-10-13 10:01:30 +01:00
Marina Glancy fa8e0af1f0 MDL-55833 mod_feedback: display in outline and complete reports 2016-10-13 13:49:16 +08:00
David Monllao beb505fab1 Merge branch 'wip-mdl-56299-fix' of https://github.com/rajeshtaneja/moodle 2016-10-13 10:51:12 +08:00
Rajesh Taneja 2761e0d604 MDL-56299 behat: Popover doesn't work with phantomjs 2016-10-13 10:47:32 +08:00
David Monllao f5e8a744bf Merge branch 'wip-mdl-56087' of https://github.com/rajeshtaneja/moodle 2016-10-13 10:18:20 +08:00
Rajesh Taneja deb71a0032 MDL-56087 behat: Fixed no messages string 2016-10-13 09:57:53 +08:00
Rajesh Taneja 664a2a2900 MDL-55522 behat: Commented failing transformations
- Reverted the order of transformations in order they are expected
- Commented failing transformation steps - MDL-56397
They should be fixed by https://github.com/Behat/Behat/issues/959
2016-10-13 09:41:15 +08:00
Marina Glancy 62a3c42947 MDL-56110 forms: debug message for php 7.1 compat
Follow up for MDL-55123
2016-10-13 09:18:34 +08:00
David Mudrák 0cc5c64608 MDL-54945 workshop: Improve the portfolio API implementation
* Use a single capability 'mod/workshop:exportsubmissions' to control
  who is able to export a submission and all associated visible
  peer-assessments.
* The export capability is by default granted to teachers and managers
  as well.
* Simplify the integration of the export button into the submission
  page. There is now a single place where the export button appears - at
  the buttom of the submission page.
* Clean up the new strings introduced for this feature.
* Rewrite the portfolio caller class so that it better mimics the
  behaviour of the submission.php page. It must not be possible to get
  access to contents otherwise not available via the UI.
* Fix phpunit tests.
* Improve behat tests so that they can run in headless browser
  (performance).

During the development, some problems were detected in the underlying
portfolio API, especially with LEAP2A format and files collisions
handling. These may be eventually fixed in the future, should there be a
demand for it.
2016-10-12 18:35:02 +02:00
Tony Butler 23f2f64452 MDL-56062 mod_assign: Use $gradeitem->get_decimals() for grade display 2016-10-12 17:33:23 +01:00
Dan Poltawski f6b8aec404 Merge branch 'MDL-54682_master-fix-alt' of https://github.com/markn86/moodle 2016-10-12 15:21:02 +01:00
Dan Poltawski 17ab49e9b1 Merge branch 'MDL-56324-master' of https://github.com/lucisgit/moodle 2016-10-12 14:53:01 +01:00
Mark Nelson 2127ca2cde MDL-54682 core_message: do not disable left panel when deleting messages 2016-10-12 21:45:33 +08:00
Tony Butler 88d309d947 MDL-56324 assignfeedback_editpdf: Use correct page in save_current_page 2016-10-12 14:17:48 +01:00
Dan Poltawski d68472984a Merge branch 'MDL-56384_master' of https://github.com/markn86/moodle 2016-10-12 09:26:26 +01:00
David Monllao 6beb7a780c Merge branch 'MDL-56095-master-fix' of git://github.com/cameron1729/moodle 2016-10-12 15:17:37 +08:00
Mark Nelson d29be93807 MDL-56384 message_popup: fixed oracle PHPUnit failures 2016-10-12 15:14:30 +08:00
Ryan Wyllie 2e39117f75 MDL-43230 badges: fix award_badge behat test 2016-10-12 05:11:13 +00:00
Cameron Ball 00d3a8c5f4 MDL-56095 output: Properly set prototype on custom event for IE 2016-10-12 13:10:30 +08:00
Ryan Wyllie addb9430f9 MDL-43230 badges: move badge revoke event into api 2016-10-12 05:10:17 +00:00
Matt Davidson b7374faca6 MDL-43230 badges: manually revoke awarded badges
A user can be manually awarded a badge, but if given by mistake an
awarded badge cannot be removed.
2016-10-12 05:06:38 +00:00
Rajesh Taneja cd5e416560 MDL-27072 behat: Removed wrong tag from feature 2016-10-12 12:57:22 +08:00
David Monllao 0115782157 Merge branch 'wip-mdl-27072' of git://github.com/rajeshtaneja/moodle 2016-10-12 11:29:59 +08:00
Rajesh Taneja c76e57aace MDL-27072 behat: Fixed table separators 2016-10-12 11:05:07 +08:00
David Monllao bc8a896208 MDL-55393 message: Missing latest blocker issue code updates 2016-10-12 10:45:34 +08:00
Juan Leyva 67d76e2fe2 MDL-55393 message: New WS get_user_notification_preferences 2016-10-12 09:43:16 +08:00
Juan Leyva 311f5e4025 MDL-55393 message: Add some external functions to mobile service 2016-10-12 09:41:59 +08:00
David Monllao b805d3f8ef MDL-56057 search: Fix incorrectly reported no enabled search areas
Also improved performance caching enabled search areas and
all search areas at the same time.
2016-10-12 08:30:23 +08:00
Eloy Lafuente (stronk7) 2660c96098 Merge branch 'MDL-56319-m' of https://github.com/micaherne/moodle 2016-10-11 20:24:13 +02:00
David Mudrák 931bba6054 MDL-54945 workshop: Introduce workshop::check_group_membership() method
This is just a refactored code block present at two different places. We
will need the same logic in the portfolio caller class soit made sense
to implement it as a new method, rather than make another copy&paste.

As a side effect, the logic is now properly unit tested.
2016-10-11 20:23:55 +02:00
Eloy Lafuente (stronk7) d5bc94628c Merge branch 'wip-mdl-55522' of https://github.com/rajeshtaneja/moodle 2016-10-11 20:13:04 +02:00
Dan Poltawski 287a906645 Merge branch 'MDL-56324-master' of https://github.com/lucisgit/moodle 2016-10-11 17:35:07 +01:00
AMOS bot 6ceebb9d56 Automatically generated installer lang files 2016-10-12 00:04:48 +08:00
Eloy Lafuente (stronk7) a34625a17c Merge branch 'MDL-55345' of https://github.com/paulholden/moodle 2016-10-11 17:06:17 +02:00
Dan Poltawski 412a4a6d8b MDL-54682 message: fix eslint issues 2016-10-11 13:29:56 +01:00
Dan Poltawski 34930e37cd MDL-54682 deprecatedlib: fix trailing whitespace 2016-10-11 13:17:42 +01:00
Dan Poltawski c8303131be Merge branch 'MDL-54682_master' of git://github.com/markn86/moodle 2016-10-11 12:53:11 +01:00
Loc Nguyen 5fd75ed889 MDL-54945 workshop: Workshop portfolio API integration
Users can export their own submission
Users can export feedback/assessment received from other users
2016-10-11 12:51:15 +02:00
Eloy Lafuente (stronk7) 1e1dbc669f Merge branch 'MDL-56147-master' of git://github.com/FMCorz/moodle 2016-10-11 12:49:56 +02:00
Eloy Lafuente (stronk7) 77348a62db Merge branch 'MDL-55954_master' of git://github.com/dmonllao/moodle 2016-10-11 12:46:32 +02:00
Eloy Lafuente (stronk7) 44e7b8b827 Merge branch 'wip-mdl-56248' of https://github.com/rajeshtaneja/moodle 2016-10-11 12:15:05 +02:00
David Monllao 85d7a13ab0 Merge branch 'master_MDL-51401' of https://github.com/janeklb/moodle 2016-10-11 17:58:05 +08:00
Eloy Lafuente (stronk7) 537054ec27 Merge branch 'MDL-55921' of https://github.com/mr-russ/moodle 2016-10-11 11:54:23 +02:00
David Monllao b65c33ace5 Merge branch 'MDL-52051-master' of git://github.com/andrewnicols/moodle 2016-10-11 17:11:21 +08:00
Dan Poltawski 988ff9f57f Merge branch 'MDL-36611-master' of git://github.com/junpataleta/moodle 2016-10-11 08:53:06 +01:00
Mark Nelson d4b2c195e1 MDL-54682 core: build amd modules 2016-10-11 14:39:24 +08:00
Mark Nelson 16f91ae12a MDL-56299 core: fixed failing Behat tests
This also involved removing legacy Behat tests.
2016-10-11 14:39:24 +08:00
Ryan Wyllie 6b5d0e976a MDL-56087 message: change conversations to messages 2016-10-11 14:39:24 +08:00
Ryan Wyllie f54a16fc73 MDL-56274 message: unlock tabs and search after delete all 2016-10-11 14:39:24 +08:00
Mark Nelson fd9a64a302 MDL-56336 core_message: fix WS exception when 'forcepasswordchange' set 2016-10-11 14:39:24 +08:00
Ryan Wyllie 963ba88970 MDL-56234 message: fix messaging UI in theme boost 2016-10-11 14:39:24 +08:00
Ryan Wyllie 641b36e2ab MDL-56292 message: move notifications page into popup plugin 2016-10-11 14:39:23 +08:00
Ryan Wyllie 9f7b7b7c88 MDL-56292 message: fix style for notification popover and page 2016-10-11 14:39:23 +08:00
Ryan Wyllie 14617a566b MDL-56292 message: mustache template docs 2016-10-11 14:39:23 +08:00
Ryan Wyllie 8b99e16358 MDL-56292 core: add note to upgrade.txt for context_header change 2016-10-11 14:39:23 +08:00
Ryan Wyllie 7d69958e6b MDL-56292 message: move popover code into output plugin 2016-10-11 14:39:23 +08:00
Ryan Wyllie f8e4145feb MDL-56292 core: change size of 'component' DB column 2016-10-11 14:39:22 +08:00
Rajesh Taneja ca9a79dae3 MDL-56348 cache: Removed second parameter
There is no second parameter in the api
and identifier should be set by set_identifiers
2016-10-11 12:50:10 +08:00
Andrew Nicols 066963cd18 MDL-52051 repository_dropbox: Migrate to v2 API 2016-10-11 11:17:09 +08:00
Kirill Astashov f3ced08622 MDL-36611 outcome: Set page context when editing outcome 2016-10-11 10:01:01 +08:00
Eloy Lafuente (stronk7) db43b23848 Merge branch 'wip-MDL-27072-master' of https://github.com/Beedell/moodle 2016-10-11 02:42:02 +02:00
Eloy Lafuente (stronk7) dcd5c7cd1b Merge branch 'MDL-56228-master' of https://github.com/snake/moodle 2016-10-11 02:02:23 +02:00
Eloy Lafuente (stronk7) 6bf8e9b021 Merge branch 'MDL-55835-master' of git://github.com/danpoltawski/moodle 2016-10-11 01:21:14 +02:00
Eloy Lafuente (stronk7) 209d36cc78 Merge branch 'MDL-56220-m' of https://github.com/micaherne/moodle 2016-10-11 01:17:33 +02:00
Eloy Lafuente (stronk7) 049a4f9a20 Merge branch 'MDL-56331-master' of git://github.com/danpoltawski/moodle 2016-10-11 01:12:00 +02:00
Eloy Lafuente (stronk7) 73c5f7b7a9 Merge branch 'MDL-56261-master-taglist' of git://github.com/mudrd8mz/moodle 2016-10-11 00:32:21 +02:00
Eloy Lafuente (stronk7) 76d521e14c Merge branch 'MDL-56308' of https://github.com/mr-russ/moodle 2016-10-10 19:05:22 +02:00
Eloy Lafuente (stronk7) 45dd1dc052 Merge branch 'MDL-53695-master' of git://github.com/danpoltawski/moodle 2016-10-10 18:25:18 +02:00
Eloy Lafuente (stronk7) f0077d4c42 Merge branch 'MDL-56316-master' of git://github.com/andrewnicols/moodle 2016-10-10 18:11:56 +02:00
Eloy Lafuente (stronk7) 6a8f40c394 Merge branch 'MDL-51633_master' of git://github.com/lazydaisy/moodle 2016-10-10 17:40:34 +02:00
Dan Poltawski 518ba4906d Merge branch 'MDL-56192-master' of git://github.com/FMCorz/moodle 2016-10-10 16:16:17 +01:00
David Monllao 97f1af7575 Merge branch 'MDL-56050-master' of git://github.com/lameze/moodle 2016-10-10 23:14:43 +08:00
Tony Butler c156b7b76d MDL-56345 assignfeedback_editpdf: Use correct strings for tool alt text 2016-10-10 16:13:37 +01:00
David Monllao 3e1dd8791b Merge branch 'MDL-54854-master' of git://github.com/jleyva/moodle 2016-10-10 23:00:31 +08:00
David Monllao 886207f70e Merge branch 'MDL-55923-master' of git://github.com/jleyva/moodle 2016-10-10 22:57:34 +08:00
David Monllao 576ce0af0c Merge branch 'MDL-30179-master' of git://github.com/merrill-oakland/moodle 2016-10-10 22:38:29 +08:00
Dan Poltawski bd296fc280 Merge branch 'MDL-56209-master' of git://github.com/FMCorz/moodle 2016-10-10 15:18:24 +01:00
Dan Poltawski e210a4b2d8 Merge branch 'MDL-56052-master' of git://github.com/damyon/moodle 2016-10-10 14:18:33 +01:00
Eric Merrill ca2cb90fed MDL-30179 gradereport_user: Add ability to view report as other user 2016-10-10 09:03:11 -04:00
Dan Poltawski 5f85134187 Merge branch 'MDL-55999-master' of git://github.com/lameze/moodle 2016-10-10 13:40:16 +01:00
Dan Poltawski 0b7aef7b20 Merge branch 'MDL-51584' of https://github.com/mr-russ/moodle 2016-10-10 13:23:59 +01:00
Dan Poltawski 1573c3031b MDL-53695 lib/javascript.php: ensure full env for core_minify
This applies the same approach to generating minified js as is already
used in theme/javascript.php and other scripts. When we need to do the
minification, we load the full Moodle environment, so we can use the
libraries.

The reason this was required was because now the minifier uses
autoloaded classes, which are not autoloaded when doing
ABORT_AFTER_CONFIG.

Fred persuaded me that it's probably safer to keep it that way, rather
than alllow ABORT_AFTER_CONFIG scripts from autoloading the world and
their dog (especially for resource serving scripts, they are intended to
be lightweight when serving from cache).
2016-10-10 13:17:04 +01:00
Dan Poltawski 4cb24aa9d7 MDL-53695 minify: switch to MatthiasMullie\Minify
The previously used minification libraries were:
a) Unmaintained
b) Had some silly licensing issues (MDL-36457)

The new library is smaller, maintained, active and GPL-compatible.
2016-10-10 13:17:04 +01:00
Dan Poltawski ef3e4d6cc4 Merge branch 'MDL-56095-master-fixup' of https://github.com/FMCorz/moodle 2016-10-10 13:13:08 +01:00
Frédéric Massart fc72f49da3 MDL-56095 output: Moving progress_bar from weblib to outputcomponents
And revert the change in the order of the require_once in setup.php.
2016-10-10 13:25:37 +02:00
Dan Poltawski e99efa171c Merge branch 'MDL-55597-master' of git://github.com/FMCorz/moodle 2016-10-10 11:33:12 +01:00
Dan Poltawski 6a694f9a95 Merge branch 'MDL-56178-master' of git://github.com/FMCorz/moodle 2016-10-10 11:22:16 +01:00
Juan Leyva 78310c30d0 MDL-54854 grade: New WS gradereport_overview_view_grade_report 2016-10-10 11:16:02 +01:00
Juan Leyva 7cd19312f5 MDL-54854 grade: New WS gradereport_overview_get_course_grades 2016-10-10 11:16:01 +01:00
Juan Leyva 91bbfdfeca MDL-54854 grade: Refactor gradereport_overview code 2016-10-10 11:16:01 +01:00
Dan Poltawski 49e12de63f Merge branch 'MDL-56285-master' of git://github.com/StudiUM/moodle 2016-10-10 11:14:22 +01:00
John Beedell 10c4fce520 MDL-27072 Quiz: Remove get_users_by_capability from quiz reports 2016-10-10 11:05:15 +01:00
Frédéric Massart 5d2f105e50 MDL-56178 theme_boost: Display drop zones labels
The markup has changed so we now need to target .sr-only rather
than just .accesshide. I did keep the latter in case it's still used
somewhere, in a custom form field for instance.

The ideal solution was to tell QuickForm to display the labels of
those elements in the group. That works for Boost, but that did not
work for Clean. The rendering mechanics of QuickForm decides to not
print the label, unless it's set as hidden... the CSS hack remains.
2016-10-10 11:32:08 +02:00
Dan Poltawski 80156d01c4 Merge branch 'MDL-56095-master-2nd' of git://github.com/FMCorz/moodle 2016-10-10 10:09:46 +01:00
Frédéric Massart d195128300 MDL-56005 adminlib: Display saved value in colourpicker 2016-10-10 11:00:00 +02:00
Frédéric Massart 258143e34d MDL-56005 output: Support prepending SCSS code instead of variables only 2016-10-10 10:59:52 +02:00
David Monllao e8cd446ecd Merge branch 'MDL-45388-master' of git://github.com/danpoltawski/moodle 2016-10-10 16:59:06 +08:00
Tony Butler 3cd718e859 MDL-56324 assignfeedback_editpdf: Get current page no from page selector
When navigating to next/previous page or jumping to a comment
2016-10-10 09:52:19 +01:00
David Monllao 47e863bb73 Merge branch 'MDL-56162-master' of git://github.com/FMCorz/moodle 2016-10-10 16:48:07 +08:00
Dan Poltawski a4a815f31c MDL-56331 tests: update with current coordinates
The previous commit will minor updates to pass, but this updates
to current values.
2016-10-10 09:10:07 +01:00
Dan Poltawski 0b73876317 MDL-56331 tests: increase tolerance of coordinate tests
1) It seems the maxmind database is getting relatively frequent updates
which are causing differences in exact coordinates

2) GeoIP location lookups are not an exact science, I tried to pick some
ips which I thought would remain fairly static, but these things are
just guesses.

3) Moving to 2 decimal places should give us good enough results for
this test, according to:
http://gis.stackexchange.com/questions/8650/measuring-accuracy-of-latitude-and-longitude

  "The second decimal place is worth up to 1.1 km: it can separate one
   village from the next."
  "The third decimal place is worth up to 110 m: it can identify a
   large agricultural field or institutional campus."
2016-10-10 09:07:38 +01:00
Andrew Nicols 3a4c497c15 MDL-52051 oauth: expires_in is optional 2016-10-10 14:02:20 +08:00
David Monllao e84c33d694 Merge branch 'MDL-56232-master' of git://github.com/junpataleta/moodle 2016-10-10 13:27:50 +08:00
Jun Pataleta 2d3130532c MDL-56232 mod_lti: Fix logic for disabling mod_form fields
* Disable tool "Select content" button if selected preconfigured tool
  does not support Content-Item, and if the selected option is set to
  "Automatic, based on launch URL".
* Disable tool configuration form fields if selected preconfigured tool
  does not support Content-Item, but enable these fields if the selected
  option is set to "Automatic, based on launch URL".
* Behat tests also updated to check disabling/enabling of launch url field.
2016-10-10 13:16:25 +08:00
David Monllao 96d2a6fd5f Merge branch 'MDL-56254-master' of git://github.com/FMCorz/moodle 2016-10-10 13:01:40 +08:00
David Monllao fae446b9cb Merge branch 'MDL-56097' of git://github.com/stronk7/moodle 2016-10-10 12:57:27 +08:00
David Monllao cf489b75ef Merge branch 'MDL-56216-master' of git://github.com/danpoltawski/moodle 2016-10-10 12:49:07 +08:00
Ryan Wyllie a92eda4b26 MDL-56292 core: make popover region event bindings on open 2016-10-10 12:48:52 +08:00
Ryan Wyllie 0d602fdd37 MDL-56292 message: fix message_get_recent_conversations
Renamed the $user param to a more common pattern and removed the
readtable flags from the SQL, which are no longer required.
2016-10-10 12:48:52 +08:00
Ryan Wyllie 2d552f37b8 MDL-56292 core: auto_rows should fire event on element 2016-10-10 12:48:52 +08:00
Ryan Wyllie eea7dd4156 MDL-56292 messages: made popover region css less specific 2016-10-10 12:48:52 +08:00
Ryan Wyllie bab2ec4664 MDL-56292 message: fix param in notificationpreferences.php 2016-10-10 12:48:52 +08:00
Ryan Wyllie df9986c87f MDL-56292 message: split up preferences templates 2016-10-10 12:48:52 +08:00
Ryan Wyllie 5cdebf2d7e MDL-56292 message: simplify get_popup_notifications function 2016-10-10 12:48:51 +08:00
Ryan Wyllie dff7c82ecb MDL-56292 message: fix sql query in mark_all_read_for_user 2016-10-10 12:48:51 +08:00
Mark Nelson cc22b515ea MDL-56333 core_message: fixed return type for get_profile WS 2016-10-10 12:48:51 +08:00
Russell Smith 82905c097c MDL-51584 gradebook: use direct $CFG access for freeze.
get_config() is called a lot of times on freeze and is expensive,
using $CFG is much lower overhead.
2016-10-10 15:42:04 +11:00
Rajesh Taneja 389e5a0ff4 MDL-55522 behat: test realtive dates 2016-10-10 11:54:13 +08:00
Rajesh Taneja 45ff0ff5d8 MDL-55522 behat: Add support for relative dates 2016-10-10 11:54:13 +08:00
Frédéric Massart 7001a3b273 MDL-56081 theme_boost: Adjust user menu for switched role and login as 2016-10-10 10:22:43 +08:00
Jake Dallimore 4c1bc2422d MDL-56228 phpunit: Force sort order in mod data generator test 2016-10-10 09:32:24 +08:00
AMOS bot 3a39ef7fb6 Automatically generated installer lang files 2016-10-09 00:06:11 +08:00
lazydaisy 42bbb05f44 MDL-51633 theme_bootstrapbase: Restyled ADD BLOCK to remove max-width. 2016-10-07 18:50:46 +01:00
AMOS bot 5f9aead5aa Automatically generated installer lang files 2016-10-08 00:04:30 +08:00
Frédéric Massart ba92a049f4 MDL-55736 theme_boost: Subtle highlighting of a section 2016-10-07 16:54:27 +02:00
Frédéric Massart 82b945dbbe MDL-56095 output: Make the progress bar templatable
The order of inclusion of weblib and outputlib had to change
as the progress_bar (weblib) uses interfaces defined in outputlib.
2016-10-07 16:40:38 +02:00
Frédéric Massart ff274ab0e5 MDL-56277 theme_boost: Define core maintenance renderer 2016-10-07 11:38:36 +02:00
Dan Poltawski e4edbce35d MDL-55835 js: fix lint issues
Some caused by eslint checks being better, some just not detected
because we don't show warnings well (MDL-54930).
2016-10-07 10:03:43 +01:00
Dan Poltawski 00c714f05c MDL-55835 eslint: bump to v3.7.1
1) Bump eslint verson in npm
2) Enable tabs rule introduced in 3.2.0
3) With rules deprecated in 3.3.0 to their replacements
   http://eslint.org/blog/2016/08/eslint-v3.3.0-released
4) Deprecate the use of M.str (fixes MDLSITE-3646) with new
   no-restricted-properties introduced in 3.5.0
5) Fixup no-unused-vars - remove argsIgnorePattern which shouldn't have allowed
   partial matches and turns out to be uncesssary
   (detected because of https://github.com/eslint/eslint/issues/7250 in 3.6.0)
2016-10-07 10:00:26 +01:00
Michael Aherne 4582da2464 MDL-56319 blocks: Observe empty default blocks setting 2016-10-07 09:59:09 +01:00
Mark Nelson de55cb1b53 MDL-56089 core_message: modified API so it is not tied to renderables
Also did some minor refactoring/tidying of the code.
2016-10-07 16:37:56 +08:00
Ryan Wyllie a038fcf5d6 MDL-55635 message: create notifications page 2016-10-07 16:37:56 +08:00
Mark Nelson e68a1cbdaa MDL-55942 core: do not show popovers to the guest user 2016-10-07 16:37:56 +08:00
Mark Nelson c476de1872 MDL-55942 core_message: moved SELECTORS and EVENTS to modules
Also took this time to capitalise the local module names.
2016-10-07 16:37:56 +08:00
Mark Nelson 48e8bdba13 MDL-55942 core_message: renamed the term 'people' to 'user' 2016-10-07 16:37:56 +08:00
Mark Nelson 66e1bdda3f MDL-55942 core_message: cleaned the index.php page
Also removed the no longer used send_form.php file.
2016-10-07 16:37:55 +08:00
Mark Nelson 5b0769db68 MDL-54744 core_message: deprecated functions in message/lib.php
Also -

1) Made note of the deprecation as well as the functions and
   files that were removed earlier in upgrade.txt.
2) Added new functions to api.php to replace the deprecated ones
   that were being used in unit tests.
3) Removed files that are no longer being used.
2016-10-07 16:35:25 +08:00
Ryan Wyllie 7b477f5982 MDL-55813 message: add online/offline help icons on preferences page 2016-10-07 16:26:40 +08:00
Ryan Wyllie fadb831658 MDL-56028 message: change forced to locked on preferences page 2016-10-07 16:26:40 +08:00
Mark Nelson 7b55aaa12e MDL-55942 core: obey the mighty CiBoT 2016-10-07 16:26:40 +08:00
Mark Nelson 79f6c36c12 MDL-55942 core_message: moved added functionality from message/lib.php 2016-10-07 16:26:40 +08:00
Mark Nelson c598f278ca MDL-55942 core_message: removed WS function core_user_update_user
This function was ignoring any capabilities and was only used to
update the preferences, but could be potentially used to update
any user attribute. A new WS function has been introduced to
handle user preferences with the necessary capability checks.
2016-10-07 16:26:40 +08:00
Mark Nelson ebf4e53209 MDL-55814 core_message: removed 'Web' notification hack
Reverts: MDL-54698 core_message: remove 'offline' checkbox
for popup processor
2016-10-07 16:26:40 +08:00
Mark Nelson 5f8e4733b8 MDL-56024 core_message: prevent WS error when messaging disabled 2016-10-07 16:26:40 +08:00
Mark Nelson 837941e9bc MDL-55909 core_message: added missing WS capability checks 2016-10-07 16:26:40 +08:00
Ryan Wyllie 9d8f6f4af0 MDL-55972 message: confirmation modal when deleting conversation 2016-10-07 16:26:40 +08:00
Ryan Wyllie 10ea82701a MDL-55972 core: add confirmation modal 2016-10-07 16:26:40 +08:00
Ryan Wyllie eeee7bca80 MDL-55822 message: accessibility improvements for popovers 2016-10-07 16:26:40 +08:00
Ryan Wyllie 99c7f0a731 MDL-55801 message: responsive styling for message app 2016-10-07 16:26:40 +08:00
Mark Nelson 3f4f5d3bd2 MDL-55851 core: fixed AJAX error when user not set up 2016-10-07 16:26:40 +08:00
Ryan Wyllie 0b19d04836 MDL-55812 message: simplify notification popover items 2016-10-07 16:26:40 +08:00
Mark Nelson 30aac24d7a MDL-55947 core_message: fixed order of notifications in popover 2016-10-07 16:26:40 +08:00
Mark Nelson 89a70ba1a5 MDL-55623 core_message: indicate who the message is from 2016-10-07 16:26:40 +08:00
Mark Nelson 94e1db613c MDL-55623 core_message: create helper function for WS to define messages 2016-10-07 16:26:40 +08:00
Mark Nelson 10d38e66b1 MDL-55895 core_message: do not display whole conversation on page load 2016-10-07 16:26:40 +08:00
Mark Nelson 82073cb11d MDL-55870 core_message: fixed order of conversations in popover
Also made changes to message_area_contacts.js as we can not
rely on the number of conversations being displayed for the
limit in our SQL, see MDL-55908.
2016-10-07 16:26:40 +08:00
Mark Nelson 0dc4a56683 MDL-55852 core_message: add properties to renderables
Also improved PHPDocs and performed minor code changes.
2016-10-07 16:26:40 +08:00
Mark Nelson 658d0b2fd7 MDL-55770 core_message: remove the send message pop-up
Revert "MDL-48933 core_message: New dialog to send a message to a user"
Revert "MDL-48933 core_message: Behat tests to cover messenger dialogs"
2016-10-07 16:26:40 +08:00
Mark Nelson 5bf0ff278a MDL-55811 core_message: ensure contact always shown 2016-10-07 16:26:40 +08:00
Mark Nelson dd0c1403a1 MDL-55637 core_message: display icon for blocked users 2016-10-07 16:26:40 +08:00
Mark Nelson a3e3a3a179 MDL-55637 core_message: create helper function for WS to define contacts 2016-10-07 16:26:40 +08:00
Ryan Wyllie 443dbb82b3 MDL-55571 message: change profile information to a list 2016-10-07 16:26:40 +08:00
Mark Nelson 91ac67db9e MDL-55774 core_message: ensure selectors are isolated 2016-10-07 16:26:40 +08:00
Mark Nelson c9ead36a92 MDL-55582 core_message: show message when there are no search results 2016-10-07 16:26:40 +08:00
Ryan Wyllie b6723f5b22 MDL-55595 message: fix message preferences for multiple processors 2016-10-07 16:26:40 +08:00
Mark Nelson d7d7ca2ea1 MDL-55754 core_message: fixed unread message count 2016-10-07 16:26:40 +08:00
Mark Nelson 4d1b76ee36 MDL-55638 core_message: add message when there are no contacts 2016-10-07 16:26:40 +08:00
Mark Nelson ab95d755b4 MDL-55638 core_message: fixed contacts overflow CSS setting 2016-10-07 16:26:40 +08:00
Ryan Wyllie 09c3c73201 MDL-55570 message: replace online asterix with green dot 2016-10-07 16:26:40 +08:00
Ryan Wyllie 9d783a8d2c MDL-55543 message: disabled search when deleting messages 2016-10-07 16:26:40 +08:00
Ryan Wyllie 59181e559c MDL-55624 message: disable textarea when sending message 2016-10-07 16:26:40 +08:00
Ryan Wyllie 07adfdacd1 MDL-55542 message: update popover hover colours 2016-10-07 16:26:40 +08:00
Ryan Wyllie b1e3f76150 MDL-55542 message: update hover colour for message interface 2016-10-07 16:26:40 +08:00
Ryan Wyllie 3a2b3bd97e MDL-55583 message: stop page reload when enter pressed in search 2016-10-07 16:26:40 +08:00
Ryan Wyllie 61868b7956 MDL-54687 message: add unread message count to conversations 2016-10-07 16:26:40 +08:00
Ryan Wyllie c33b7d8913 MDL-54701 message: add unread message count to messages 2016-10-07 16:26:40 +08:00
Ryan Wyllie 52fa054902 MDL-54708 message: remove user profile link from notifications 2016-10-07 16:26:40 +08:00
Ryan Wyllie 6af2bd0985 MDL-54682 message: update js to use data values in selectors 2016-10-07 16:26:40 +08:00
Ryan Wyllie b7e68d1059 MDL-54698 message: consolidate preference page checkbox styling 2016-10-07 16:26:40 +08:00
Mark Nelson 065ff1b0f2 MDL-54698 core_message: remove 'offline' checkbox for popup processor 2016-10-07 16:26:40 +08:00
Mark Nelson 812cc6f63f MDL-54698 core_message: moved 'disable/enable' notifications setting 2016-10-07 16:26:40 +08:00
Mark Nelson e0c67b89cb MDL-54698 core: removed 'title-case' CSS usage and rule 2016-10-07 16:26:40 +08:00
Ryan Wyllie 7e12045152 MDL-54698 message: fix message preferences context blocknoncontacts 2016-10-07 16:26:40 +08:00
Ryan Wyllie c4624a76c9 MDL-54701 message: remove profile link from message popover 2016-10-07 16:26:40 +08:00
Ryan Wyllie fe8664b1ef MDL-54698 message: update preference processor display names 2016-10-07 16:26:40 +08:00
Ryan Wyllie 14501b1c13 MDL-54698 message: add preferences pages to breadcrumbs 2016-10-07 16:26:40 +08:00
Ryan Wyllie 8c125526f1 MDL-54698 message: move notifications prefs into own page 2016-10-07 16:26:40 +08:00
Mark Nelson bf4c393c09 MDL-55573 core_message: keep conversation and contact panels up-to-date 2016-10-07 16:26:40 +08:00
Mark Nelson 6c3b954114 MDL-54687 core_message: mark messages as read when viewing conversation
Also -

- Highlight a conversation when there are unread messages.
- Update the number in the message menu when conversation
  containing unread messages is selected.
2016-10-07 16:26:40 +08:00
Damyon Wiese eaabf0934a MDL-55569 messages: Throw an error when the message fails to send
This shows an alert to the user to let them know something went wrong.
If debugging is 0 - the alert does not contain all the debugging stuff and looks OK.
2016-10-07 16:26:40 +08:00
Damyon Wiese 14968ca9ac MDL-55567 messages: Use FORMAT_MOODLE as default for sending messages
This is like plain text, but it preserves new-lines and has some
other special features.
2016-10-07 16:26:40 +08:00
Damyon Wiese edac7c8003 MDL-55541 messages: Always return at least a minimal record for a user
Messages allows anyone to find anyone on the site - even if they don't share any permissions
in a course. So we need to make at least their name and id discoverable.
2016-10-07 16:26:40 +08:00
Damyon Wiese 4131cf1d6f MDL-54687 messages: Fix height bug with auto-rows textarea
Firefox reserves height for the horizontal scroll bars in a textarea. This
mucks up the height calculations for this element. Prevent it with overflow-x.
2016-10-07 16:26:40 +08:00
Mark Nelson 358e66f913 MDL-54687 core_message: ensure messages wrap 2016-10-07 16:26:40 +08:00
Mark Nelson dd06ca781a MDL-54687 core_message: scroll to bottom of messages on page load 2016-10-07 16:26:40 +08:00
Mark Nelson 62e82a7df9 MDL-54687 core_message: prevent multiple sent messages 2016-10-07 16:26:40 +08:00
Ryan Wyllie 8c250260e6 MDL-54687 message: show most recent conversation by default 2016-10-07 16:26:40 +08:00
Ryan Wyllie c1fec732c6 MDL-54687 message: add enter to send message 2016-10-07 16:26:40 +08:00
Ryan Wyllie 0ae7a72082 MDL-54687 message: adjust messages area height with response height 2016-10-07 16:26:40 +08:00
Mark Nelson bf58081d59 MDL-54687 core_message: return online status for messages and profile 2016-10-07 16:26:40 +08:00
Mark Nelson cd03b8d7f2 MDL-54687 core_message: added search functionality 2016-10-07 16:26:40 +08:00
Mark Nelson d29cdf3a1f MDL-54687 core_message: remove contact from DOM if no messages remain 2016-10-07 16:26:40 +08:00
Mark Nelson 6d3445de77 MDL-54687 core_message: removed unused function and data attribute 2016-10-07 16:26:40 +08:00
Ryan Wyllie 358717d59e MDL-54708 message: style notification popover actions 2016-10-07 16:26:40 +08:00
Mark Nelson 2c1b3775f0 MDL-54687 core_message: do not send message if it is empty 2016-10-07 16:26:40 +08:00
Mark Nelson 2be15a66c4 MDL-54687 core_message: fixed lint errors 2016-10-07 16:26:40 +08:00
Mark Nelson d9fad93dc5 MDL-54687 core_message: removed unused YUI module 2016-10-07 16:26:40 +08:00
Mark Nelson 49aaadc3fb MDL-54687 core_message: corrected return type of webservices
Also minor tidy up of docs.
2016-10-07 16:26:40 +08:00
Ryan Wyllie 4d0fa50125 MDL-54687 message: messaging widget styling 2016-10-07 16:26:40 +08:00
Mark Nelson ef735275de MDL-54687 core_message: removed 'conversationsselected' variable 2016-10-07 16:26:40 +08:00
Ryan Wyllie efa079072c MDL-54698 message: change preferences to on/off text 2016-10-07 16:26:40 +08:00
Ryan Wyllie fbdcd49993 MDL-54687 message: add keyboard navigation to message widget 2016-10-07 16:26:40 +08:00
Mark Nelson 065fd12021 MDL-54687 core_message: changed outder div's CSS class 2016-10-07 16:26:40 +08:00
Mark Nelson ed6a141d5d MDL-54687 core_message: reduce amount of JS in templates 2016-10-07 16:26:40 +08:00
Ryan Wyllie 8c55bd6c34 MDL-54701 message: add message popover count and mark as read 2016-10-07 16:26:40 +08:00
Ryan Wyllie 24a76780f6 MDL-54708 message: add renderer for get_popup_notification 2016-10-07 16:26:40 +08:00
Ryan Wyllie 34eb5fcb60 MDL-54698 message: move general settings from preference page 2016-10-07 16:26:40 +08:00
Mark Nelson 1e5f751ffc MDL-54687 core_message: moved renderables to 'messagearea' namespace 2016-10-07 16:26:40 +08:00
Mark Nelson 8ec78c48fa MDL-54687 core_message: added ajax scrolling for messages 2016-10-07 16:26:40 +08:00
Mark Nelson 90525930e5 MDL-54687 core: added prependNodeContents() to the AMD templates module 2016-10-07 16:26:40 +08:00
Mark Nelson 9661810ea6 MDL-54687 core_message: added ajax scrolling for contacts 2016-10-07 16:26:40 +08:00
Mark Nelson 2a4bbaa3ff MDL-54687 core_message: added SELECTORS and EVENTS variables to tidy JS 2016-10-07 16:26:40 +08:00
Ryan Wyllie a4a804b8f9 MDL-54698 message: add save/cancel button to processor popup 2016-10-07 16:26:40 +08:00
Ryan Wyllie b6cd1c1151 MDL-54698 message: combine message preferences into single table 2016-10-07 16:26:40 +08:00
Ryan Wyllie ada7695d7c MDL-54708 message: notification popover respects message preferences 2016-10-07 16:26:40 +08:00
Ryan Wyllie 643b015db2 MDL-54698 message: make processor settings dialogue 2016-10-07 16:26:40 +08:00
Ryan Wyllie e9cce46cf0 MDL-54698 message: change preferences to checkboxes 2016-10-07 16:26:40 +08:00
Ryan Wyllie 195a683b27 MDL-54701 message: rename module imports in js 2016-10-07 16:26:40 +08:00
Ryan Wyllie d4555a3d03 MDL-54701 message: renamed mdl-popover to popover-region 2016-10-07 16:26:40 +08:00
Mark Nelson 6b2657d981 MDL-54687 core_message: prefixed 'message_area' to JS and template files 2016-10-07 16:26:40 +08:00
Mark Nelson 00d80c7e4a MDL-54687 core_message: decreased size of messaging area 2016-10-07 16:26:40 +08:00
Mark Nelson b8a6beec40 MDL-54687 core_message: removed loading template 2016-10-07 16:26:40 +08:00
Ryan Wyllie e48a092a40 MDL-54698 message: add context to preferences templates 2016-10-07 16:26:40 +08:00
Ryan Wyllie 5ee31614c7 MDL-54698 message: split message preference page into renderables 2016-10-07 16:26:40 +08:00
Ryan Wyllie 39986f5044 MDL-54698 message: split message preferences page js 2016-10-07 16:26:40 +08:00
Ryan Wyllie eda6bc19e6 MDL-54701 message: added isread to data_for_messagearea_conversations 2016-10-07 16:26:40 +08:00
Ryan Wyllie c826fa230a MDL-54701 message: add user profile links to popovers
Make the user name link to the user's profile page for the message and
notification popovers.
2016-10-07 16:26:40 +08:00
Ryan Wyllie 540fec1e86 MDL-54701 message: allow relativeUrl to take params 2016-10-07 16:26:40 +08:00
Ryan Wyllie 9e8a29c95d MDL-54708 message: fix js module naming 2016-10-07 16:26:40 +08:00
Ryan Wyllie 406243381c MDL-54701 message: add message notification popover 2016-10-07 16:26:40 +08:00
Ryan Wyllie 607454d6f3 MDL-54708 message: change popover processor to nav bar notification 2016-10-07 16:26:40 +08:00
Ryan Wyllie c5dd16a111 MDL-54708 message: add ability to block popup notifications 2016-10-07 16:26:40 +08:00
Ryan Wyllie a0eabdd3c8 MDL-54698 message: make preferences page ajax save 2016-10-07 16:26:40 +08:00
Ryan Wyllie a0e358a64a MDL-54708 message: add notification popover to nav bar 2016-10-07 16:26:40 +08:00
Ryan Wyllie 3274d5ca66 MDL-54708 message: add backend APIs for notifications popover 2016-10-07 16:26:40 +08:00
Frédéric Massart d13880db8b MDL-55597 tool_templatelibrary: Re-inforce logic to skip theme templates 2016-10-07 10:24:50 +02:00
Ryan Wyllie 12d8c7b222 MDL-54700 message: added toggle contact button to user profile 2016-10-07 16:20:51 +08:00
Mark Nelson dec0cd9998 MDL-54687 core_message: added ability to delete conversations 2016-10-07 16:20:51 +08:00
Mark Nelson 16245a40b9 MDL-54687 core_message: added menu bar 2016-10-07 16:20:51 +08:00
Mark Nelson e237d2bd39 MDL-54687 core_message: refactored JS
- Created smaller AMD modules to handle specific tasks.
- Used JS events to notify AMD modules when an action has happened.
- Used data-* selectors, rather than CSS selectors (and removed
  any unused CSS selectors).
- Minor changes to behaviour when sending and deleting messages.
- Added JSDocs.
- General improvements to JS.
2016-10-07 16:20:51 +08:00
Mark Nelson f7775c9a0c MDL-54687 core: added appendNodeContents() to the AMD templates module 2016-10-07 16:20:51 +08:00
Mark Nelson 3090f52f9d MDL-54687 core_message: added ability to delete messages 2016-10-07 16:20:51 +08:00
Mark Nelson c6e97f5428 MDL-54687 core_message: added ability to view a contact's profile
Also added functionality to the profile page -

- View user's profile.
- Send the user a message.
- Block the user.
- Remove the user as a contact.
2016-10-07 16:20:51 +08:00
Mark Nelson 34c2f34762 MDL-54687 core_message: added userid parameter for altering contacts 2016-10-07 16:20:51 +08:00
Mark Nelson c060cd4904 MDL-54687 core_message: added ability to send messages 2016-10-07 16:20:51 +08:00
Mark Nelson 3cd13828ff MDL-54687 core_message: added ability to view messages 2016-10-07 16:20:51 +08:00
Mark Nelson 9aa012b5a1 MDL-54687 core_message: added ability to toggle between tabs 2016-10-07 16:20:51 +08:00
Mark Nelson 879e2bef23 MDL-54687 core_message: created page for new messaging interface
This commit introduces the templates, renderer and initial API
that will be used for further development.
2016-10-07 16:20:51 +08:00
Mark Nelson 0dec2f9f23 MDL-54687 theme: removed message related CSS 2016-10-07 16:20:51 +08:00
Mark Nelson f3c0e69232 MDL-54687 core_message: removed 'message_print_*' functions 2016-10-07 16:20:51 +08:00
Janek Lasocki-Biczysko 0bb7f79d31 MDL-51401 enrol: ensures correct order of roles in UI components
Role sort order was not available in the UI (in JavaScript) due to
the use of PHP assoc arrays and JSON encoding/decoding. This patch
addresses this by sending the roles in a json array, rather than
json object.
2016-10-07 08:30:25 +01:00
Andrew Nicols 070015004e MDL-56316 tests: Ensure consistent assertion count 2016-10-07 14:45:36 +08:00
Rajesh Taneja e1ad3a959d MDL-55924 behat: Add core features to specified theme's 2016-10-07 10:55:41 +08:00
Rajesh Taneja 95e1d5e50f MDL-55746 behat: Support blacklist theme features by tags 2016-10-07 09:05:26 +08:00
Russell Smith eca7dd65ad MDL-56308 cache: Fix APC ready rules for CLI scripts
When APCu is enabled, but the CLI is not it's possible for
calls to enable APCu to fail because it's not configured on the
command line.
2016-10-07 12:02:37 +11:00
Rajesh Taneja 5483ef5c7d MDL-56248 phpunit: Update phpunit to 5.5.6 2016-10-07 07:18:38 +08:00
Eloy Lafuente (stronk7) 85ef6fe2d9 MDL-56097 install: update the list of stale files for 3.2 2016-10-07 00:41:11 +02:00
Eloy Lafuente (stronk7) d9520bc04e weekly release 3.2dev 2016-10-06 22:31:27 +02:00
Eloy Lafuente (stronk7) badaed3224 Merge branch 'MDL-56306-master' of git://github.com/danpoltawski/moodle 2016-10-06 22:25:46 +02:00
Dan Poltawski 41a9a9219a MDL-56303 quiz: lack of quiz filtering
Also, correctly feed completiongradeitemnumber with grade item numbers
and not with grade item ids.
2016-10-06 22:24:57 +02:00
Dan Poltawski 636ec5010f MDL-56306 tests: make upgrade_util_test compatible with travis 2016-10-06 18:01:43 +01:00
Issam Taboubi fd8043b2de MDL-56285 competency: fix move competencies capabilities
In learning plan templates, cannot move competencies
around even if capability templatemanage is given
to the role because of bad context check
2016-10-06 10:33:32 -04:00
Frédéric Massart bcc4af3c7c MDL-56262 theme: Missing hash symbol in skip to maincontent anchor link 2016-10-06 12:54:44 +02:00
Dan Poltawski 586cf92909 MDL-45388 admin: warn of themedesignermode in /admin/ and perf footer
This is:
a) To help avoid devs going on a wild goose chase to find a perf issue
when it's caused by css building
b) To make it clearer that this should never be enabled on production
sites (we already have a warning in the performance report, but who
looks at that)

Now that boost is the default theme and builds css itself, it's more
critical.
2016-10-06 11:49:17 +01:00
Eloy Lafuente (stronk7) f73f938469 weekly release 3.2dev 2016-10-06 11:51:28 +02:00
Eloy Lafuente (stronk7) b79069d233 NOBUG: Fixed file access permissions 2016-10-06 11:51:28 +02:00
Eloy Lafuente (stronk7) a2884f8b6c Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-10-06 11:51:24 +02:00
Dan Poltawski 47c12e2095 MDL-56216 theme_boost: correct favicon 2016-10-06 10:45:24 +01:00
Dan Poltawski c6c50e04d9 MDL-22078 lib: bump redirect_if_major_update_required()
Changes to the course table enforce an update
2016-10-06 09:24:52 +01:00
Andrew Nicols d93c3b6890 MDL-56293 mod_book: Add ToC block in chapter edit/deletes 2016-10-06 15:43:03 +08:00
Andrew Nicols 4dfc6a3296 Merge branch 'wip-mdl-55986-fix-2' of https://github.com/rajeshtaneja/moodle 2016-10-06 15:07:16 +08:00
Rajesh Taneja f32c2fd781 MDL-55986 behat: use double quotes not single
On windows we need option value to be in
double quotes, else it fails
2016-10-06 15:03:56 +08:00
Andrew Nicols 0223a663a9 Merge branch 'MDL-22078_master-fix' of git://github.com/dmonllao/moodle 2016-10-06 10:38:24 +08:00
Andrew Nicols a4b2896238 Merge branch 'wip-mdl-55739' of https://github.com/rajeshtaneja/moodle 2016-10-06 10:08:14 +08:00
David Monllao 40eea06c7d MDL-22078 course reset: No enddate time shift if no enddate 2016-10-06 10:07:22 +08:00
Rajesh Taneja 16e62ecc56 MDL-55739 core_course: Check if gradepass is set and not empty
Default value of gradepass is 0.00000 and empty check
passes. But on oracle gradepass value is 0, so just
check if the field is set and that should be enough
2016-10-06 09:50:21 +08:00
Andrew Nicols 952ffbc2b2 MDL-56092 auth_email: Correct assumed ordering in unit test 2016-10-06 09:07:08 +08:00
Eloy Lafuente (stronk7) 21d8921112 Merge branch 'wip-mdl-55713' of https://github.com/rajeshtaneja/moodle 2016-10-06 01:58:58 +02:00
Rajesh Taneja 904306389f MDL-55713 behat: Include named and partial behat selector files 2016-10-06 07:55:51 +08:00
Juan Leyva 5101310d51 MDL-53777 tool_mobile: Fix incorrect and untranslated string 2016-10-06 01:48:19 +02:00
Juan Leyva 9d382a948e MDL-55923 webservice: Allow user to sign-out systems on pwd change 2016-10-05 20:34:06 +01:00
Juan Leyva 6a09295857 MDL-55923 webservice: Add global setting for forcing token deletion 2016-10-05 20:34:01 +01:00
Paul Holden 546bc40c13 MDL-55345 user: correct userid when linking to iplookup from profile 2016-10-05 15:08:38 +01:00
Dan Poltawski 520ee366f4 Merge branch 'MDL-54802-master-fix-2' of git://github.com/cameron1729/moodle 2016-10-05 14:34:11 +01:00
Cameron Ball 2ce9628484 MDL-54802 mod_quiz: Improve validation when editing a quiz uusing require passing grade
When editing a quiz that is using the require passing grade completion method,
the grade to pass cannot be zero. Since the completion method is locked we
cannot recommend that the completion method is changed (as we do when the quiz
is being created). Instead we have to inform the user that the grade to pass
must not be zero.
2016-10-05 19:21:40 +08:00
Eloy Lafuente (stronk7) adc77f07c5 Merge branch 'MDL-22078_master' of https://github.com/dmonllao/moodle 2016-10-05 12:22:07 +02:00
Frédéric Massart d2e09f2b08 MDL-56162 theme_boost: Moodle modals are working and styled for Boost 2016-10-05 12:15:33 +02:00
Dan Poltawski 4f11002077 Merge branch 'MDL-54802-master-fix' of git://github.com/cameron1729/moodle 2016-10-05 10:33:14 +01:00
Dan Poltawski f3da9c49a8 Merge branch 'MDL-56194-master' of git://github.com/FMCorz/moodle 2016-10-05 10:25:30 +01:00
Cameron Ball 26cb467b47 MDL-54802 mod_quiz: Move grade to pass error to require passing grade element
When using a passing grade of zero, with the required passing grade
option, an error was displayed on the "grade to pass" element.
This was confusing as the error message is referring to the
"Require passing grade" element. This patch moves the message to
the "Require passing grade" element.

Additionaly this patch fixes a small typo in a comment.
2016-10-05 17:14:00 +08:00
David Monllao 5be1491759 Merge branch 'wip-mdl-56210-fix' of https://github.com/rajeshtaneja/moodle 2016-10-05 15:51:43 +08:00
Rajesh Taneja 86ebbed6ca MDL-56210 behat: Test for disabled button later
With phantomjs, dom is not updated by the time
next step is executed, so suffle it to ensure
this scenario pass
2016-10-05 15:45:22 +08:00
David Monllao b02c16399e Merge branch 'MDL-55713-master-fix' of git://github.com/andrewnicols/moodle 2016-10-05 15:26:36 +08:00
Andrew Nicols d98217550b MDL-55713 behat: Bad rebase conflict resolution fix 2016-10-05 15:19:07 +08:00
Dan Poltawski e43bab742d Merge branch 'MDL-55129-master' of git://github.com/jleyva/moodle 2016-10-05 08:08:11 +01:00
Andrew Nicols 77371e2d4a Merge branch 'MDL-55767-master-fix1' of http://github.com/damyon/moodle 2016-10-05 14:24:09 +08:00
Damyon Wiese 9b807e6dbf MDL-55767 tool_lpimportcsv: Find existing scales on the site
The code was trying to match the imported scale to an existing scale for the site. It was
not loading the items before comparing them, so the matching always failed.
2016-10-05 14:23:10 +08:00
Andrew Nicols 4187b3e521 MDL-55713 behat: Correct all references to selectortype 2016-10-05 14:10:26 +08:00
David Monllao 8643c576c7 MDL-22078 course: Complete proposed patch
- New site setting to define the default course duration (used to set
  the default end date for some course formats)
- End date setting out of restore
- Fix tool_uploadcourse
- Other fixes here and there
2016-10-05 12:31:05 +08:00
Andrew Nicols b31984d5a2 MDL-55713 2016-10-05 11:46:49 +08:00
Andrew Nicols 3cf1fea55a MDL-56270 mod_book: Add next/prev chapter to attributes
This adds the details of the next/previous chapter to the image
attributes and link for the in-page chapter-to-chapter navigation.
2016-10-05 11:38:18 +08:00
Simey Lameze a4ea86f65a MDL-56050 core: set missing context to maintenance mode 2016-10-05 11:23:38 +08:00
Andrew Nicols 6ee51d010f MDL-55713 behat: Correct copy/paste error 2016-10-05 11:04:56 +08:00
Simey Lameze 9a15bf217f MDL-55999 lib: Update thirdpartylibs.xml and readme_moodle.txt 2016-10-05 10:58:10 +08:00
Simey Lameze f7035bb964 MDL-55999 lib: Update ADOdb to version 5.20.7 2016-10-05 10:57:42 +08:00
Andrew Nicols 9bf212b072 Merge branch 'wip-mdl-56092' of https://github.com/rajeshtaneja/moodle 2016-10-05 10:08:15 +08:00
Rajesh Taneja a4c970ff0e MDL-56092 phpunit: Add auth/tests to phpunit.xml.dist 2016-10-05 10:03:46 +08:00
David Monllao d905fc31bd Merge branch 'wip-mdl-55986-fix' of git://github.com/rajeshtaneja/moodle 2016-10-05 09:46:36 +08:00
David Monllao c7fc66f2ac Merge branch 'MDL-45969-master' of git://github.com/damyon/moodle 2016-10-05 09:42:17 +08:00
Rajesh Taneja b9b474182a MDL-55986 behat: all options are not valid for single run
Sanitize options which are valid for single run only
2016-10-05 09:39:26 +08:00
Andrew Nicols 2a864ee9a8 Merge branch 'MDL-56092-master' of git://github.com/jleyva/moodle 2016-10-05 08:30:35 +08:00
Andrew Nicols 5bba36f63f Merge branch 'MDL-56016-master' of git://github.com/FMCorz/moodle 2016-10-05 08:10:02 +08:00
Eloy Lafuente (stronk7) 7ad3d5db04 Merge branch 'MDL-56231-32-flexible_table-construct-phpdoc' of https://github.com/roperto/moodle 2016-10-05 01:48:49 +02:00
Eloy Lafuente (stronk7) bd1edc8314 MDL-55713 behat: fix mistakenly broken php 2016-10-05 01:21:32 +02:00
Eloy Lafuente (stronk7) 8497955eb4 Merge branch 'MDL-56126-master' of git://github.com/jleyva/moodle 2016-10-05 01:05:27 +02:00
Eloy Lafuente (stronk7) b976e22a7e Merge branch 'MDL-55713-master-3' of git://github.com/andrewnicols/moodle 2016-10-05 00:34:01 +02:00
Eloy Lafuente (stronk7) 2720dce627 Merge branch 'wip-mdl-55986' of https://github.com/rajeshtaneja/moodle 2016-10-05 00:29:29 +02:00
Juan Leyva 30cdddb017 MDL-55129 mod_assign: Allow plugins to handle configs for external
Until now in the get_assignments WS all the settings for assignment
plugins (submission and feedback) are returned, this was bad because:

- It was returning settings for plugins that may not be enabled
- It was returning settings that would be a security risk (a third
party plugin including a password or credentials for connecting a
remote site)
- Some values was returned "raw" without further processing, for
example, maxsubmissionsizebytes returned 0 when using the plugin
default value instead a valid size
- Assignment plugins implemented an API for communication with the
external API, see for example: get_external_parameters, it didn’t make
sense had an API for the received parameters and not the returned data.
2016-10-04 20:28:38 +01:00
Dan Poltawski 4089c42e12 MDL-55404 upgrade: dramatically simplify test code
Fixing http://xunitpatterns.com/Obscure%20Test.html
2016-10-04 20:00:59 +01:00
Dan Poltawski 6658ef6cd9 Merge branch 'MDL-55404-master' of git://github.com/cameron1729/moodle 2016-10-04 18:23:36 +01:00
Dan Poltawski a57e3d3b1f MDL-56011 lib: move Mustache loading to core_component autoloader 2016-10-04 18:17:22 +01:00
Dan Poltawski 38c1cbceb7 Merge branch 'MDL-56011-master' of https://github.com/snake/moodle 2016-10-04 18:16:04 +01:00
Dan Poltawski 55e8426f73 MDL-55739 course: more whitespace 2016-10-04 18:12:41 +01:00
Dan Poltawski c7ecbc9e3d MDL-55739 course: fix trailing whitespace 2016-10-04 18:07:08 +01:00
Dan Poltawski 742d23c68f Merge branch 'MDL-55739-master' of git://github.com/jleyva/moodle 2016-10-04 17:58:27 +01:00
AMOS bot 6600899b37 Automatically generated installer lang files 2016-10-05 00:05:47 +08:00
Dan Poltawski 37705564ec Merge branch 'MDL-55100-master' of git://github.com/jleyva/moodle 2016-10-04 17:00:53 +01:00
Dan Poltawski eedf01895e Merge branch 'MDL-54866-master' of git://github.com/jleyva/moodle 2016-10-04 15:50:44 +01:00
Dan Poltawski ed3956a39a Merge branch 'MDL-55861-master' of https://github.com/dj4452/moodle 2016-10-04 15:43:51 +01:00
Eloy Lafuente (stronk7) 461e98cdd7 Merge branch 'MDL-56069' of git://github.com/timhunt/moodle 2016-10-04 16:34:50 +02:00
Eloy Lafuente (stronk7) aef4de1b61 Merge branch 'empty-checks' of https://github.com/danpoltawski/moodle 2016-10-04 16:16:36 +02:00
Dan Poltawski 038dc234f6 MDL-55059 output: fix empty checks 2016-10-04 15:08:12 +01:00
David Mudrák 4139259cc6 MDL-56261 tags: Do not follow the empty anchor link on more/less toggle
Some browsers tend to follow the empty <a href="#"> link and scroll to
the top of the page.
2016-10-04 15:22:46 +02:00
Andrew Nicols 5736b0e15d Merge branch 'MDL-56168-master-fixup' of https://github.com/FMCorz/moodle 2016-10-04 20:54:27 +08:00
Dan Poltawski d6c8732844 Merge branch 'wip-mdl-55769' of https://github.com/rajeshtaneja/moodle 2016-10-04 13:13:26 +01:00
Dan Poltawski 867b1fad2f Merge branch 'MDL-45890_m32v3' of https://github.com/sbourget/moodle 2016-10-04 13:11:37 +01:00
Juan Leyva 796876b0ab MDL-55739 course: Update get_course_module to return new data 2016-10-04 13:00:35 +01:00
Dan Poltawski a553501042 Merge branch 'wip-MDL-56001-master' of git://github.com/abgreeve/moodle 2016-10-04 12:42:25 +01:00
Juan Leyva 7c1cb3bf5a MDL-54866 tool_mobile: Rename WS get_site_public_settings 2016-10-04 12:14:10 +01:00
Juan Leyva 6b4926281b MDL-54866 tool_mobile: New Web Service tool_mobile_get_config 2016-10-04 12:09:02 +01:00
Juan Leyva 5c6daf139d MDL-55059 tool_mobile: Support Smart App Banners for iOs 2016-10-04 11:49:34 +01:00
Dan Poltawski 43cb92b4b0 MDL-56007 jquery: add back non-minified files
Sorry Simey, I lead you astray (detected by unit tests)
2016-10-04 11:16:29 +01:00
Dan Poltawski 93835cab84 Merge branch 'MDL-56257-master' of git://github.com/FMCorz/moodle 2016-10-04 10:57:35 +01:00
Frédéric Massart 5f22879c3d MDL-56257 theme_boost: Killing that typo monster 2016-10-04 11:37:37 +02:00
Dan Poltawski 8e8b46cd87 Merge branch 'MDL-55226_master' of git://github.com/lazydaisy/moodle 2016-10-04 10:37:36 +01:00
Dan Poltawski a5a86826fd Merge branch 'MDL-56007-master' of git://github.com/lameze/moodle 2016-10-04 10:29:42 +01:00
Juan Leyva 3e8145a37a MDL-56126 user: New WS core_user_agree_site_policy
This commit includes a change in moodlelib to throw the
sitepolicynotagreed exception in a way that can be captured and
identified by external systems.
2016-10-04 10:20:59 +01:00
Dan Poltawski 917a59a1a0 Merge branch 'MDL-55728-master' of git://github.com/jleyva/moodle 2016-10-04 10:15:37 +01:00
Juan Leyva 83e4dc1796 MDL-56092 core_auth: New WS core_auth_confirm_user 2016-10-04 09:50:32 +01:00
Juan Leyva e66a45d994 MDL-56092 auth_email: New WS auth_email_signup_user 2016-10-04 09:50:04 +01:00
Juan Leyva 4e2f7e0cd8 MDL-56092 auth_email: New WS auth_email_get_signup_settings 2016-10-04 09:50:03 +01:00
Juan Leyva 3ee392c8e8 MDL-56092 core_user: Changes in profilelib to support WS 2016-10-04 09:50:02 +01:00
Juan Leyva f1062815e2 MDL-56092 core_auth: Refactor recaptcha lib 2016-10-04 09:49:27 +01:00
Juan Leyva 574b9d86e9 MDL-56092 core_auth: Move signup code from form to authlib 2016-10-04 09:49:26 +01:00
Frédéric Massart 98f1034ccd MDL-56254 theme_boost: Cannot use $this as function parameter 2016-10-04 10:41:15 +02:00
Dan Poltawski c9568860cb Merge branch 'wip-MDL-56012-master' of git://github.com/abgreeve/moodle 2016-10-04 09:40:34 +01:00
Andrew Nicols 1f5ae5f4e6 MDL-56010 libraries: Add missing comment back to loglevel 2016-10-04 16:33:31 +08:00
Andrew Nicols 109c3a1c57 Merge branch 'MDL-56010-master' of git://github.com/lameze/moodle 2016-10-04 16:21:05 +08:00
Frédéric Massart b90843c821 MDL-56168 theme_boost: Cannot use a null value for colour pickers 2016-10-04 10:21:01 +02:00
Simey Lameze f2b169ec03 MDL-56010 libraries: remove jshint changes and update comment block 2016-10-04 16:05:41 +08:00
Simey Lameze 530198c98c MDL-56007 lib: Update readme_moodle.txt and thirdpartylibs.xml 2016-10-04 15:43:17 +08:00
Simey Lameze 9427ff510a MDL-56007 lib: Upgrade JQuery UI to version 1.12.1 2016-10-04 15:41:55 +08:00
Andrew Nicols a955953c41 Merge branch 'MDL-55928-master' of git://github.com/jleyva/moodle 2016-10-04 14:59:11 +08:00
Andrew Nicols d4566644f6 Merge branch 'MDL-56009-master' of git://github.com/lameze/moodle 2016-10-04 14:54:12 +08:00
Andrew Nicols 948673efae Merge branch 'MDL-55886-master' of git://github.com/danpoltawski/moodle 2016-10-04 11:20:24 +08:00
Andrew Nicols febceada8c Merge branch 'MDL-56000-master' of git://github.com/lameze/moodle 2016-10-04 10:59:18 +08:00
Adrian Greeve dd9ee3d837 MDL-56012 lib: Update of readme and xml file.
Also made edits to use the PSR-4 autoloader.
2016-10-04 10:47:06 +08:00
Andrew Nicols eba8a38200 Merge branch 'MDL-56056-master' of git://github.com/FMCorz/moodle 2016-10-04 10:35:25 +08:00
Adrian Greeve cd198eafd6 MDL-56012 lib: Update spout to version 2.6.0 2016-10-04 10:12:29 +08:00
Adrian Greeve ef783842df MDL-56001 lib: Update of moodle documentation.
Update of readme_moodle.txt and thirdpartylibs.xml
with information about the update to 1.4.2
2016-10-04 10:01:15 +08:00
Adrian Greeve d6d51786d5 MDL-56001 lib: Upgrade simplepie to 1.4.2 2016-10-04 09:59:25 +08:00
Andrew Nicols a4bf84ebda Merge branch 'wip-MDL-31243-master' of https://github.com/Beedell/moodle 2016-10-04 09:19:42 +08:00
Andrew Nicols 520071f0bd MDL-55713 behat: Adjust how NamedPartials are loaded 2016-10-04 09:18:02 +08:00
Andrew Nicols c8379882b8 Merge branch 'MDL-56198' of git://github.com/timhunt/moodle 2016-10-04 09:01:25 +08:00
David Monllao d0b4772c88 MDL-55954 search_solr: Check connection before anything else
- Silents the system call when no correct data provided
- Converts long exception messages to standard server
  error + debugging message with the exception
2016-10-04 08:59:59 +08:00
Andrew Nicols 2e80ff16dd MDL-53777 tool_mobile: Adjust langstring 2016-10-04 08:53:19 +08:00
Andrew Nicols 27ed5be84f Merge branch 'MDL-53777-master' of git://github.com/jleyva/moodle 2016-10-04 08:51:24 +08:00
Eloy Lafuente (stronk7) b8c241b1fd Merge branch 'MDL-56172-master' of git://github.com/danpoltawski/moodle 2016-10-04 00:53:02 +02:00
Eloy Lafuente (stronk7) 8f900947e9 Merge branch 'MDL-56166-master' of git://github.com/FMCorz/moodle 2016-10-04 00:41:00 +02:00
Eloy Lafuente (stronk7) ed66d725e6 Merge branch 'MDL-56160-master' of git://github.com/dpalou/moodle 2016-10-04 00:39:06 +02:00
Juan Leyva c8743f62b4 MDL-55728 webservice: Return editor files in Web Services 2016-10-03 16:49:13 +01:00
Dan Poltawski e22ce8ab82 Merge branch 'MDL-56181-master-czechia' of git://github.com/mudrd8mz/moodle 2016-10-03 16:43:52 +01:00
Dan Poltawski b9c3211c92 Merge branch 'MDL-56143-master-typo-boost' of git://github.com/mudrd8mz/moodle 2016-10-03 16:42:39 +01:00
Dan Poltawski 4e0f7f98ec Merge branch 'MDL-52317' of https://github.com/NeillM/moodle 2016-10-03 16:09:25 +01:00
Tim Hunt 9bee35d5ad MDL-56198 assignment: improve grading info responsiveness 2016-10-03 16:09:21 +01:00
Dan Poltawski 8ba8b13bd9 Merge branch 'MDL-55786-master' of git://github.com/jleyva/moodle 2016-10-03 15:44:40 +01:00
Dan Poltawski 2d71da6851 Merge branch 'MDL-54802-master' of git://github.com/lameze/moodle 2016-10-03 14:46:43 +01:00
Juan Leyva afb7799a6d MDL-55786 rating: New Web Service core_rating_add_rating 2016-10-03 12:22:29 +01:00
Juan Leyva a497458c89 MDL-55786 rating: Move common code to new function 2016-10-03 12:17:09 +01:00
Dan Poltawski 5e0e9f3674 MDL-55740 mod_assign: bump version 2016-10-03 11:18:43 +01:00
Dan Poltawski b885488c02 Merge branch 'MDL-55740-master' of git://github.com/jleyva/moodle 2016-10-03 11:16:09 +01:00
Dan Poltawski c59a6ffd53 Merge branch 'MDL-55347-master' of git://github.com/jleyva/moodle 2016-10-03 10:31:52 +01:00
Frédéric Massart 63ff4f27da MDL-56214 theme_boost: Autocomplete element options can contain HTML 2016-10-03 11:30:43 +02:00
Dan Poltawski 3324250395 Merge branch 'wip-MDL-55911-master' of https://github.com/Beedell/moodle 2016-10-03 10:24:59 +01:00
Juan Leyva 649777fb8d MDL-55347 user: New WS core_user_set_users_preferences 2016-10-03 10:22:07 +01:00
Juan Leyva 0a90f6247d MDL-53777 tool_mobile: New script for launching the mobile app 2016-10-03 10:02:33 +01:00
Juan Leyva c951f1fe58 MDL-53777 tool_mobile: New setting typeoflogin, including WS 2016-10-03 10:02:33 +01:00
Juan Leyva 8a0a7414b2 MDL-53777 tool_mobile: Move mobile settings to the admin tool 2016-10-03 10:02:32 +01:00
Frédéric Massart f1ba3b0a52 MDL-56192 theme_bootstrapbase: Properly display theme_boost default tab 2016-10-03 10:05:01 +02:00
Andrew Nicols cd40761f63 Merge branch 'MDL-56003-master-int' of https://github.com/FMCorz/moodle 2016-10-03 15:57:46 +08:00
Frédéric Massart 13ca1c3101 MDL-56003 theme_boost: Update thirdpartylib.xml to reflect BS4 update 2016-10-03 09:48:37 +02:00
Rajesh Taneja a1d92ef25d MDL-55986 behat: Fix unit tests to use fixtures 2016-10-03 15:38:24 +08:00
Rajesh Taneja b04ca8c8a1 MDL-55986 behat: Added option to optimize parallel runs by tags
run.php should only be used for running behat
before this patch if tags were passed, then behat.yml
was being re-written with features havings tags.
As this is not ideal, this option is now removed and
features with tags will be optimally split
by init.php when --optimize-run option is passed
2016-10-03 15:38:04 +08:00
David Monllao c41132f075 Merge branch 'MDL-55168-master' of git://github.com/danpoltawski/moodle 2016-10-03 14:33:24 +08:00
David Monllao 2e5a8fd7aa Merge branch 'wip-mdl-56210' of https://github.com/rajeshtaneja/moodle 2016-10-03 13:53:29 +08:00
David Monllao 6a9dc6b899 Merge branch 'MDL-55165-master' of git://github.com/danpoltawski/moodle 2016-10-03 13:31:36 +08:00
Simey Lameze bc963d98d8 MDL-56009 lib: update RequireJS to 2.3.2 2016-10-03 13:21:33 +08:00
Daniel Thee Roperto 29406dded1 MDL-56231 library: Fixed PhpDoc for flexible_table constructor.
The flexible_table::__construct($uniqueid) accepts a string, not an int
as previously noted in the PhpDoc.
2016-10-03 16:07:11 +11:00
David Monllao 2f234a4af8 Merge branch 'MDL-56164-master' of git://github.com/danpoltawski/moodle 2016-10-03 13:07:01 +08:00
Rajesh Taneja 24c2dcada5 MDl-56210 behat: Ensure page is loaded, before checking button 2016-10-03 13:03:51 +08:00
David Monllao 7b7ddd97b9 Merge branch 'wip-MDL-55990-master' of git://github.com/marinaglancy/moodle 2016-10-03 13:00:08 +08:00
Andrew Nicols dbab30b127 MDL-55767 competency: Deprecate langstring and replace 2016-10-03 12:59:32 +08:00
Andrew Nicols aac3b0bebb Merge branch 'MDL-55767-master' of git://github.com/damyon/moodle 2016-10-03 12:55:06 +08:00
David Monllao dae538606f Merge branch 'MDL-55964_master' of https://github.com/StudiUM/moodle 2016-10-03 12:40:25 +08:00
Jake Dallimore d5553254e9 MDL-56010 libraries: Upgrade loglevel.js to 1.4.1 - post-import changes 2016-10-03 12:25:42 +08:00
Jake Dallimore 0b8cdaf6cb MDL-56010 libraries: Upgrade loglevel.js to 1.4.1 - library import 2016-10-03 12:23:28 +08:00
Damyon Wiese 9e14057444 MDL-55767 competencies: Better exceptions for persistent
The persistent exceptions "squash" all the details and only display
them to developers. This leads to generic "Invalid persistent" messages
with no explanation. Instead lets include the message detail always.
2016-10-03 12:01:56 +08:00
Rajesh Taneja f5d3befb72 MDL-55769 behat: Point to moodle-behat-extension 3.32.3 2016-10-03 11:50:51 +08:00
Damyon Wiese 5e4fffa013 MDL-55767 tool_lpimportcsv: import/export competency fmwks 2016-10-03 11:47:07 +08:00
David Monllao c31610afde Merge branch 'MDL-56127' of git://github.com/stronk7/moodle 2016-10-03 11:09:16 +08:00
David Monllao 92e3294dfc Merge branch 'MDL-56167-master' of git://github.com/danpoltawski/moodle 2016-10-03 11:04:34 +08:00
Andrew Nicols 580d3fe780 Merge branch 'MDL-56003-master' of git://github.com/FMCorz/moodle 2016-10-03 10:51:43 +08:00
Andrew Nicols 5f21d5e8ab Merge branch 'MDL-39117' of git://github.com/mr-russ/moodle 2016-10-03 10:13:09 +08:00
David Monllao 9b7f058cee MDL-22078 course: End date tests 2016-10-03 09:51:36 +08:00
Daniel Neis Araujo fbcdb0d710 MDL-22078 course: add end date 2016-10-03 09:51:36 +08:00
Andrew Nicols 8bb7148a9a Merge branch 'MDL-56168-master' of git://github.com/FMCorz/moodle 2016-10-03 08:20:38 +08:00
lazydaisy 0ef2631d1c MDL-55226 theme/index.php: Tidy up irregular spacing in original markup 2016-10-01 15:14:57 +01:00
lazydaisy 4b58fc61dd MDL-55226 theme/index.php: Make theme selector responsive. 2016-10-01 14:58:12 +01:00
Tim Hunt 67c8c9b493 MDL-56069 quiz: nav buttons don't scroll to the right question
When there is more than one question on a page, say questions 2, 3 & 4.
Then when you click the navigation button for Q4, then it should load
the next page scrolled down so that Q4 is visible. That was not working.
2016-09-30 15:05:02 +01:00
Michael Aherne 220f1cba3e MDL-56220 cache: Call static method correctly 2016-09-30 14:49:46 +01:00
Frédéric Massart 13623ce81e MDL-56147 theme_boost: Styling for fake calendar events filter block 2016-09-30 14:28:36 +02:00
Frédéric Massart 1497268b5e MDL-56218 theme_boost: Retire .boxalign* and .boxwidth* classes 2016-09-30 12:18:13 +02:00
Frédéric Massart a5e92a4183 MDL-56209 question: Fix icon sizing issues apparent in Boost 2016-09-30 11:56:42 +02:00
John Beedell b5cbcc4dfb MDL-55911 Quiz: Accessibility, Label blanks in DD questions 2016-09-30 09:43:59 +01:00
John Beedell 905953909f MDL-31243 access/enrol libs: rename new groups functions 2016-09-30 09:27:59 +01:00
John Beedell 9121bb2d23 MDL-31243 access/enrol libs: new fns returning useful SQL fragments
Refactor similar SQL generation code from get_users_by_capability
and get_enrolled_uses to make get_with_capability_sql.
Modified files: accesslib.php, enrollib.php, grouplib.php, new tests.
2016-09-30 09:27:56 +01:00
John Beedell 9f5170e955 MDL-31243 access/enrol libs: move enrol functions 2016-09-30 09:27:53 +01:00
Dan Poltawski e63d89a51d MDL-55168 assign: fix some incorrectly defined css transitions
The lint error suggests as though we were waiting 0s to do a
transiition of duration of 0s (i.e.  nothing), but thats not actually
the case.
2016-09-30 09:25:30 +01:00
Dan Poltawski efd03a8e71 MDL-55168 report_competency: delete empty css file 2016-09-30 09:25:26 +01:00
Dan Poltawski 693652b78d MDL-55168 css: fix various errors detected by stylelint
Ignored properties, invalid propertiies, duplicates, invalid selectors..

Detected by stylelint rules:

http://stylelint.io/user-guide/rules/declaration-block-no-ignored-properties
http://stylelint.io/user-guide/rules/selector-type-no-unknown
http://stylelint.io/user-guide/rules/declaration-block-no-duplicate-properties
http://stylelint.io/user-guide/rules/max-line-length
http://stylelint.io/user-guide/rules/no-browser-hacks
2016-09-30 09:25:25 +01:00
Dan Poltawski 99fe296eb2 MDL-55168 css: remove 0-length units 2016-09-30 09:25:25 +01:00
Dan Poltawski aea8eaecde MDL-55168 css: use shorthand colour props when possible 2016-09-30 09:25:24 +01:00
Dan Poltawski e90cef839c MDL-55168 css: ignore some stylelint complains
1) Legacy css where it would not be a good use of time to
   update.

2) Ignored some long lines and added todo

3) Fixed some line length issues
2016-09-30 09:25:24 +01:00
Dan Poltawski ed6aea6002 MDL-55168 css: fix spacing of selectors 2016-09-30 09:25:24 +01:00
Dan Poltawski bc33e9bd3f MDL-55168 css: reformat plain css with stylefmt 2016-09-30 09:25:23 +01:00
Dan Poltawski d5dff6316a MDL-55168 grunt: Add plain css linting 2016-09-30 09:25:23 +01:00
Frédéric Massart 6261200f98 MDL-56209 mod_quiz: Override styles inherited from course format
Why is that even using the same classes?!
2016-09-30 10:22:52 +02:00
Dan Poltawski 195f42de40 MDL-56164 theme_boost: remove empty stylesheet 2016-09-30 08:55:06 +01:00
Dan Poltawski ad9da28cb5 MDL-56164 theme_boost: remove empty stylesheet 2016-09-30 08:50:47 +01:00
Neill Magill c3e1c98f04 MDL-52317 Atto: Large resized images may display scroll bars
When an image was added via Atto and it was set to resize automatically
if the alignment was set to Top, Middle or Bottom when it was made
smaller then a vertical scroll bar would be displayed.

This was caused by the interaction of the margin settings on the image
and the 100% width set via the img-responsive css class. The width of
an element only includes the content area and not any borders, padding
or margins.

This change stops atto hardcoding the styles for image alignment into
the images style tag, it instead adds a class that defines the alignment
the image should have.

This change has the benefit that themers will now be able to adjust
how atto image alignments work if they wish.

Images added before this patch will continue to have the issue
until they are edited by the plugin, at which time their legacy style
will be removed and the new alignment method will be added.

Thanks to Andrew Nicols who provided a refactor for the Alignment
and style detection code.
2016-09-30 08:48:33 +01:00
Rajesh Taneja c2b0213b08 MDL-55986 behat: Re-factor exiting api's
Return all features and contexts, so they can
be filtered well at one place
2016-09-30 13:32:20 +08:00
Damyon Wiese f5ba9ac995 MDL-45969 editpdf: The logic for showing a previous attempt is wrong
It originally was only ever going to show static pdfs for older versions,
but this doesn't make sense in the UI for 3.1.
2016-09-30 13:15:00 +08:00
Rajesh Taneja eed52d64bb MDL-56210 behat: Ensure behat waits for dependancy manager 2016-09-30 10:19:09 +08:00
Jake Dallimore 20df227e22 MDL-56011 libraries: upgrade mustache.php to 2.11.1 2016-09-30 08:40:41 +08:00
Dan Poltawski c561b23d8f MDL-55886 block_rss_client: fix oracle compatibility 2016-09-29 16:55:07 +01:00
Deepa Jayaprakash 9b24ebd665 MDL-55861 course: Click drag&drop icon, incorrect activities shown 2016-09-29 16:42:10 +01:00
Dan Poltawski 81c9e018b4 MDL-56172 admin: remove cssoptimiser config options 2016-09-29 16:41:29 +01:00
Dan Poltawski d52ebf11d3 MDL-56172 css: remove css optimiser
This functionality no longer makes sense inside Moodle now that we have
external tools like stylelint to help us with this. It was not able to
be used by any core themes.

The code was always marked as not for external use.
2016-09-29 16:40:40 +01:00
Dan Poltawski cdcfc4bcd2 MDL-55165 bootstrap: built css 2016-09-29 16:39:30 +01:00
Dan Poltawski 13e0d7f3e6 MDL-55165 stylelint: remove unset redundant properities rule
http://stylelint.io/user-guide/rules/shorthand-property-no-redundant-values/

Fred and I had discussed enabling this rule, but think it's better for
CSS newcomers to be disabled, so lets remove trace of it.
2016-09-29 16:39:30 +01:00
Dan Poltawski 07482105c1 MDL-55165 less: use lowercase hex codes for colours
And use shorthand where possible.

Detected by
http://stylelint.io/user-guide/rules/color-hex-case/
http://stylelint.io/user-guide/rules/color-hex-length/

When reviewing this change, you can hide the case changes by
reviewing with:
GIT_EXTERNAL_DIFF='diff -ipu   #' git diff --ext-diff
2016-09-29 16:39:30 +01:00
Dan Poltawski 65f9a71fbd MDL-55165 less: ensure no units on 0 length things
Detected by http://stylelint.io/user-guide/rules/length-zero-no-unit/
2016-09-29 16:39:30 +01:00
Dan Poltawski 62ce522cde MDL-55165 less: fix various errors in less
Detected by stylelint rules:

http://stylelint.io/user-guide/rules/declaration-block-no-ignored-properties/
http://stylelint.io/user-guide/rules/declaration-block-no-duplicate-properties/
http://stylelint.io/user-guide/rules/declaration-block-no-shorthand-property-overrides/
http://stylelint.io/user-guide/rules/value-keyword-case/
http://stylelint.io/user-guide/rules/selector-type-no-unknown/
http://stylelint.io/user-guide/rules/selector-type-no-unknown/
2016-09-29 16:39:30 +01:00
Eloy Lafuente (stronk7) 83edfba240 MDL-56127 forms: multiple select dependencies fixed
This is a fix for a regressions introduced by MDL-54778. It
seems that escaped all our tests because there isn't any case
of such a dependency in core, but Daniele Cordella was facing
it within his surveypro module.
2016-09-29 16:53:08 +02:00
Frédéric Massart 239fd05cc9 MDL-56016 theme_boost: Add plain preset for plain Moodle & Bootstrap 2016-09-29 15:18:40 +02:00
Frédéric Massart a4808411a4 MDL-56056 theme_boost: Align completion icons with activity menus 2016-09-29 15:04:13 +02:00
Dan Poltawski ddd8dc0d1b weekly release 3.2dev 2016-09-29 12:42:50 +01:00
Dan Poltawski e77a0e0922 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-09-29 12:42:48 +01:00
Juan Leyva 80adabef0e MDL-55100 course: New Web Service get_courses_by_field 2016-09-29 12:20:49 +01:00
Frédéric Massart 23faa312a3 MDL-56194 admin: Allow HTML in admin setting headings 2016-09-29 13:18:35 +02:00
David Mudrák b706012657 MDL-56181 lang: Fix CI and CZ country short names to match ISO 3166 2016-09-29 11:47:11 +02:00
Frédéric Massart 36553104da MDL-56168 theme_boost: Make default accent colour match preset 2016-09-29 10:02:13 +02:00
Simey Lameze 48dc4059da MDL-56000 lib: upgrade PHPMailer to 5.2.16 2016-09-29 15:09:10 +08:00
Jun Pataleta 6c43d831f0 MDL-49609 mod_lti: Fixes for problems found in testing
* Load contentitem_return doc before processing
* Also use new AMD modal instead of the YUI one.
* Remove conversion of text columns in union queries
  - Since the value column in lti_types_config was changed to a
    text type, there is no need to use $DB->sql_compare_text()
    for the lti_types columns involved in the union queries in
    lti_get_type_config().
2016-09-29 11:13:50 +08:00
Eloy Lafuente (stronk7) d231f3cb0d Merge branch 'MDL-53870-master' of git://github.com/jleyva/moodle 2016-09-29 01:45:02 +02:00
Eloy Lafuente (stronk7) d0deb28c24 Merge branch 'MDL-55804_master' of git://github.com/dmonllao/moodle 2016-09-29 01:14:33 +02:00
Rajesh Taneja 71ee163664 MDL-49609 behat: Replace deprecated step 2016-09-29 07:06:26 +08:00
Eloy Lafuente (stronk7) b3823c4365 Merge branch 'MDL-56019-master' of git://github.com/dpalou/moodle 2016-09-28 20:08:31 +02:00
Eloy Lafuente (stronk7) 1138bbc69e Merge branch 'wip-mdl-55879' of https://github.com/rajeshtaneja/moodle 2016-09-28 20:05:08 +02:00
Eloy Lafuente (stronk7) 7bc32ebccd Merge branch 'MDL-55785-master' of git://github.com/jleyva/moodle 2016-09-28 19:59:20 +02:00
Serge Gauthier ceee6e9bd8 MDL-55964 report_competency: Missing blocks in Competency breakdown
Fix also the breadcrumb.
2016-09-28 13:16:45 -04:00
Dan Poltawski 2b53e97cd3 MDL-56167 setup: bail out on lower version requirements in all cases
It's quite possible to get incomrehensible errors otherwise
2016-09-28 15:35:34 +01:00
Frédéric Massart d1de864fab MDL-56166 theme_boost: Apply default dashboard styles to dashboard only 2016-09-28 15:31:58 +02:00
Dan Poltawski cf1d2cb073 Merge branch 'MDL-55420-master' of git://github.com/FMCorz/moodle 2016-09-28 14:03:52 +01:00
Frédéric Massart 89d9895b8c MDL-55420 theme_boost: Migrate CSS added since Boost development started 2016-09-28 14:51:29 +02:00
Frédéric Massart bf089a18f3 MDL-56003 theme_boost: Update Bootstrap to v4.0.0-alpha.4 2016-09-28 13:00:58 +02:00
Dan Poltawski 8793ebdd15 Merge branch 'MDL-55071-master-behat-fixes-is-back' of https://github.com/FMCorz/moodle 2016-09-28 12:00:17 +01:00
Dani Palou 43695b6a72 MDL-56160 ws: Return site course ID in get_site_info 2016-09-28 12:26:32 +02:00
Frédéric Massart 17a6f94749 MDL-55071 behat: Action menus can be opened without Javascript
Standard action menus expand automatically when Javascript is disabled
thus there is no need to open them. In Boost, they expand when they're
hovered or when the focus is set on their trigger.
2016-09-28 11:50:09 +02:00
Frédéric Massart a82c49473b MDL-55071 behat: Adapting form_row selector to reflect recent changes
Labels are no longer used for static elements. The form row selector
has been changed to include "labels" from static elements.
2016-09-28 11:13:53 +02:00
Frédéric Massart d8f90ec628 MDL-56042 output: Post process with tree structure always returns CSS
A certain combination of booleans could cause some of the processes
not to take effect as the tree was not converted back into a string.
2016-09-28 09:58:47 +01:00
Juan Leyva 74804b57a4 MDL-53870 mod_quiz: Return sequence and time information for questions 2016-09-28 09:25:19 +01:00
Juan Leyva 5635ead8e6 MDL-53870 mod_quiz: New access rule for allowing offline attempts 2016-09-28 09:25:18 +01:00
Juan Leyva 8a972ab377 MDL-53870 mod_quiz: New settings for quiz attempts in the mobile app 2016-09-28 09:25:18 +01:00
Dan Poltawski 14d6945e65 Merge branch 'MDL-56102-master' of https://github.com/xow/moodle 2016-09-28 08:16:28 +01:00
John Okely 8e55ffc6c3 MDL-56102 enrol_lti: Removed unused lines in unit test 2016-09-28 14:54:04 +08:00
David Mudrák 17f6270175 MDL-56143 theme_boost: Fix a typo in the readme string 2016-09-28 08:30:02 +02:00
David Monllao e1555a7b36 Merge branch 'MDL-56070-master' of git://github.com/jleyva/moodle 2016-09-28 11:20:00 +08:00
David Monllao 303d122ae5 Merge branch 'MDL-55963-master' of git://github.com/lazydaisy/moodle 2016-09-28 09:34:52 +08:00
David Monllao d830f1518a MDL-49609 mod_lti behat: Removing unexisting components 2016-09-28 09:03:09 +08:00
David Monllao f747e45411 Merge branch 'MDL-49609-master-5' of git://github.com/junpataleta/moodle 2016-09-28 08:59:22 +08:00
David Monllao bdab41d71b Merge branch 'MDL-56072-master' of git://github.com/cameron1729/moodle 2016-09-28 08:37:48 +08:00
Eloy Lafuente (stronk7) df4de02f17 Merge branch 'MDL-55866-master' of git://github.com/andrewnicols/moodle 2016-09-28 02:29:45 +02:00
Eloy Lafuente (stronk7) ccc777032d MDL-46946 user: Document user_not_fully_set_up() changes 2016-09-28 02:18:43 +02:00
Eloy Lafuente (stronk7) 4dbddd0874 Merge branch 'MDL-46946-master-reqcusfield' of git://github.com/mudrd8mz/moodle 2016-09-28 02:12:59 +02:00
Rajesh Taneja 2ee249ac90 MDL-55957 behat: Set some text before selecting in Atto 2016-09-28 07:35:26 +08:00
Eloy Lafuente (stronk7) b58bbbd4f1 Merge branch 'MDL-55951-master' of git://github.com/crazyserver/moodle 2016-09-27 23:59:21 +02:00
Tim Hunt 70e85280f4 MDL-56136 restore: better error handling copying file at start 2016-09-27 18:07:50 +01:00
Dan Poltawski 8a28a2a393 Merge branch 'MDL-56013-master' of git://github.com/lameze/moodle 2016-09-27 17:30:02 +01:00
AMOS bot 3388603eda Automatically generated installer lang files 2016-09-28 00:04:32 +08:00
Dan Poltawski f4760ed4bf Merge branch 'MDL-55071-master-behat-fixes' of https://github.com/FMCorz/moodle 2016-09-27 16:42:06 +01:00
Frédéric Massart ce1a09f124 MDL-55071 mod_quiz: Fix behat selector for question chooser
The chooser template now re-uses a core one which caused the
IDs of the fields to be changed. The behat tests have been changed
to target the new IDs. Note: using the label values did not work
because more than one matched due to loose checking.
2016-09-27 17:39:46 +02:00
Frédéric Massart b3d0a8b4a7 MDL-55071 behat: Normalise space on multi-field admin elements 2016-09-27 17:39:29 +02:00
Frédéric Massart adbe0fcb70 MDL-55071 mod_quiz: Action menu items were hidden
The CSS rule was too vague and cause the menu items to be
hidden rather than just the first item.
2016-09-27 17:39:12 +02:00
Dan Poltawski f6acae933c Merge branch 'MDL-56103-master' of git://github.com/dpalou/moodle 2016-09-27 16:17:57 +01:00
Dani Palou 7f98de7d9d MDL-56103 wiki: Return version in get_page_contents 2016-09-27 16:19:23 +02:00
Dan Poltawski ec91fe32c3 Merge branch 'MDL-56040-master' of https://github.com/StudiUM/moodle 2016-09-27 14:57:18 +01:00
Dan Poltawski 6036184fab Merge branch 'MDL-56045-master' of git://github.com/jleyva/moodle 2016-09-27 12:24:59 +01:00
Dan Poltawski 76ff730228 Merge branch 'MDL-55987-master-grademem' of git://github.com/mudrd8mz/moodle 2016-09-27 11:23:51 +01:00
Dan Poltawski 6027b0de05 Merge branch 'MDL-54793-master' of git://github.com/cameron1729/moodle 2016-09-27 11:13:35 +01:00
Dan Poltawski 03b2e3a04d Merge branch 'MDL-55957-master-workshopfiles' of git://github.com/mudrd8mz/moodle 2016-09-27 10:37:06 +01:00
David Monllao d656122f8a Merge branch 'MDL-37669-master' of git://github.com/andrewnicols/moodle 2016-09-27 17:34:24 +08:00
Dan Poltawski 13a18809e6 Merge branch 'MDL-55760-master' of https://github.com/StudiUM/moodle 2016-09-27 10:18:35 +01:00
David Monllao f258a958a4 MDL-55804 tool_uploadcourse: strftime only to user input
Default value already comes as a timestamp.
2016-09-27 08:11:56 +08:00
David Monllao 80180e0f92 MDL-55804 forms: Return exported data through _prepareValue 2016-09-27 08:11:56 +08:00
Dan Poltawski 6e181725ca Merge branch 'MDL-55472-assign-extend-ignored-validation' of https://github.com/ilya-catalyst/moodle 2016-09-26 15:31:30 +01:00
Dan Poltawski 62398cd807 Merge branch 'wip-MDL-55519-master' of git://github.com/abgreeve/moodle 2016-09-26 15:23:32 +01:00
Dan Poltawski c90ad348f1 MDL-55071 theme_boost: fix import-bootswatch.php phpdocs 2016-09-26 13:14:46 +01:00
Frédéric Massart afde59d26b MDL-55071 admin: Remove reference to former localisedtext class 2016-09-26 10:28:47 +01:00
Dan Poltawski dd460c22ed Merge branch 'MDL-55071-rebased' of git://github.com/danpoltawski/moodle 2016-09-26 10:28:12 +01:00
Stephen Bourget 02ce2e413c MDL-45890 Blog: add additional events 2016-09-25 15:06:54 -04:00
Ilya Tregubov ffcfffbe64 MDL-55472 assign: Show userlist on extension form error page 2016-09-25 11:29:43 +10:00
lazydaisy 3299dab377 MDL-55963 theme_bootstrapbase: Remove depreciated Legacy CSS in 3.2 2016-09-24 12:47:00 +01:00
AMOS bot 4f660cea7d Automatically generated installer lang files 2016-09-24 00:04:25 +08:00
Issam Taboubi 22690d6d71 MDL-55760 tool_lp: Wrong rating display when more than one scale set 2016-09-23 11:01:32 -04:00
Jean-Philippe Gaudreau 32a904e0a5 MDL-56040 behat: Fixing missing "|" in tables 2016-09-23 09:19:35 -04:00
Juan Leyva d44e2e42dc MDL-56070 user: New Web Service core_user_update_picture 2016-09-23 12:54:23 +01:00
Frédéric Massart 5142f56402 MDL-56063 theme_boost: Check and remove extraneous !important rules
Progress bar styling has been removed as they do not appear to
be used anywhere, though MDL-56095 has been created to style them
as (with or without the styles) they remain unstyled.

The file responsive.scss has been removed, it was not used.

Part of MDL-55071
2016-09-23 11:04:33 +01:00
Dan Poltawski 5cb8ca8610 MDL-55071 theme_boost: fixup bootswatch thirdpartylibs
Allow longhand colour codes for asthetics..
2016-09-23 10:57:54 +01:00
Dan Poltawski d5d0a8028d MDL-55071 theme_boost: prevent phpcs complaints
The commenting rule is a bit weird, but we can get round it easily.
2016-09-23 10:57:54 +01:00
Dan Poltawski dd9dd09587 MDL-55071 less: fix some lint issues we touched
(These will all be gone soon!)
2016-09-23 10:57:54 +01:00
Dan Poltawski 59652db27f MDL-55071 css: fix some lint issues 2016-09-23 10:57:53 +01:00
Dan Poltawski 0b2dc2751f MDL-55071 css: reformat some css files we touch with stylefmt 2016-09-23 10:57:36 +01:00
Dan Poltawski 46c1713c40 MDL-55071 theme_boost: fix stylelint detected issues in scss
Duplicate properties, star hacks
2016-09-23 10:57:36 +01:00
Frédéric Massart f8ac90a753 MDL-56061 core: Permit usage of REM in CSS
Part of MDL-55071
2016-09-23 10:57:36 +01:00
Damyon Wiese e584e6ae46 MDL-55071 theme/output: PHPCS fixes for new theme branch
Part of MDL-55071
2016-09-23 10:57:36 +01:00
Damyon Wiese e8272e748c MDL-55071 theme_boost: Fix relevant JS warnings
Part of MDL-55071
2016-09-23 10:57:36 +01:00
Dan Poltawski 841d25a984 MDL-55071 grunt: add stylelint:scss to default css task
Part of MDL-55071
2016-09-23 10:57:36 +01:00
Dan Poltawski c037f043ef MDL-55071 theme_boost: remove empty blocks in scss
Part of MDL-55071
2016-09-23 10:57:36 +01:00
Dan Poltawski fde35b8f0f MDL-55071 theme_boost: fix 0px and colour shorthand
Part of MDL-55071
2016-09-23 10:57:36 +01:00
Dan Poltawski f4143537a0 MDL-55071 theme_boost: Use stylefmt to fix css formating issues
Part of MDL-55071
2016-09-23 10:57:36 +01:00
Dan Poltawski 9cb41231fd MDL-55071 theme_boost: fix indentation in scss files
Part of MDL-55071
2016-09-23 10:57:36 +01:00
Dan Poltawski 773e68b0f8 MDL-55071 stylelint: Config & grunt task for scss
Part of MDL-55071
2016-09-23 10:57:36 +01:00
Frederic Massart 8a40bc36a6 MDL-51948 admin: Guess RTL compatibility of settings using PARAM_ types
Part of MDL-55071
2016-09-23 10:57:35 +01:00
Damyon Wiese 80db019249 MDL-55071 theme_boost: We don't need the generated css
Part of MDL-55071
2016-09-23 10:57:35 +01:00
Damyon Wiese 10617d6942 MDL-55071 templates: Add correct docs for new templates
These are just the admin settings templates.

Part of MDL-55071
2016-09-23 10:57:35 +01:00
Damyon Wiese 5d9f0bb3fe MDL-55071 psr4: Use psr4 classloader for scss, rtlcss and cssparser
Part of MDL-55071
2016-09-23 10:57:35 +01:00
Damyon Wiese ff392efc89 MDL-55071 forms: Add upgrade.txt note about submitlink
We are deprecating submitlink because it was added a long time ago
and never used in Moodle. We can't test it or maintain it.

Part of MDL-55071
2016-09-23 10:57:13 +01:00
Damyon Wiese 13075628ab MDL-55071 core_auth: Move new login renderable to core_auth
Part of MDL-55071
2016-09-23 10:57:13 +01:00
Damyon Wiese 256edb99de MDL-55071 theme_boost: Fix stylelint issues
Part of MDL-55071
2016-09-23 10:57:13 +01:00
Damyon Wiese 890c260307 MDL-55071 phpunit: Fix failing tests due to changes in default output
Part of MDL-55071
2016-09-23 10:57:13 +01:00
Damyon Wiese 2ede86d797 MDL-55996 theme_boost: Rename theme noname to theme boost
Part of MDL-55071
2016-09-23 10:57:13 +01:00
Frederic Massart 137c289a19 MDL-55593 theme_noname: Post-prod on preset default styling
Some styles were moved to be part of the core SCSS rules. Extra
variables were removed, and other styles where adapted.

Part of MDL-55071
2016-09-23 10:55:18 +01:00
Frederic Massart a13dd17cf6 MDL-55593 core: Drag & drop accessible menu uses aria attributes
Part of MDL-55071
2016-09-23 10:55:18 +01:00
Frederic Massart f572e724ad MDL-55593 theme_noname: Cancel button should be secondary
Part of MDL-55071
2016-09-23 10:55:18 +01:00
Frederic Massart 3264bf5b56 MDL-55593 form: Wrap skip validation variable in script tag
Part of MDL-55071
2016-09-23 10:55:18 +01:00
Barbara Ramiro 928177d139 MDL-55593 Theme: Style for the course page
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro 77f5a9b01d MDL-55593 Theme: Style for the forums page
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro 6e2aefd527 MDL-55593 Theme: Style for the edit settings page
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro 8d923368a7 MDL-55593 Theme: Style for the frontpage
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro 8e62956e10 MDL-55593 Theme: Style for the blocks heading
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro e1265d001d MDL-55593 Theme: Add top and bottom padding to region-main
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro 771fe96b54 MDL-55593 Theme: Align page container and blocks with the top navbar
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro 4553c8bdca MDL-55593 Theme: Style for the login page
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro 7dbd1f954e MDL-55593 Theme: Remove rounded corners for the top navbar
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro 463ae17699 MDL-55593 Theme: Centering navbar
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro 4a59602a77 MDL-55593 Draft colour swatches and styles
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Barbara Ramiro 2876221386 MDL-55593 Theme: Copy of all variables from _variables.scss
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Frederic Massart 9189888989 MDL-55797 mod_quiz: Convert question chooser to template
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Frederic Massart 891750bcfa MDL-55797 core_question: Make static getter for chooser
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Frederic Massart 7f8b7b2bb3 MDL-55797 output: Support form method in chooser
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Frederic Massart 6f0993ccbc MDL-55797 core_question: Convert the chooser to template
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Frederic Massart 370e7637c6 MDL-55904 output: Deprecate action_menu::do_not_enhance()
Part of MDL-55071
2016-09-23 10:55:17 +01:00
Damyon Wiese 63e4df60f6 MDL-55839 behat: Behat fixes for theme_noname
This is a squash of many small fixes.
The list of changes are:

Initial set of behat selectors overrides required for new theme.

set core behat selectors if not overridden by theme

Remove pause

Fix for checkboxes not saving properly

Custom override for click in the user menu

Fix for behat guessing the field type.

Behat fix for guessing the correct field type.

Fix for missing closeElementBefore mforms mess.

Fix for textareas not displaying their contents.

Fix availability form element

Fix action menu selectors for activities in a course page

Fix textareas not retaining their values

Fix selector for blocks

I had to change the single select template to use an input instead of a button because of a
behat bug we have not tracked down yet.

Fix for frozen attribute in form elements

Use input instead of button while behat is still broken

Fix for navigation selector override

Behat selector fixes and multi-select fixes for templated select

Fix for configure blocks selector + booleans for autocomplete

Fixes for course_summary behat tests

Allow optgroups in single_select

Behat fixes for block_navigation

Fixes for url form element and activity chooser selectors

blocks_social - fix specific selector for behat

Fix export_for_template for selectgroups element.

Dont set empty id on the form

Fix direct call to behat_navigation in backup context

Checkbox empty value fix

Fix for assign grading panel popouts

file picker overrides to find a file manager in the page

Fix chat tests to use element name

Make selectors in mod_data behat less specific

MDL-55839: recent activity behat test relies on time()

SQUASH Honour mform element "class" attribute on the container

SQUASH Fixes for behat in mod_forum

SQUASH search form template showing value as text next to the button

SQUASH undo double selectgroup fix

SQUASH - The slightly different structure to action menus breaks course drag and drop

SQUASH Wrap loading icon in a span so the selector still works.

SQUASH Fix fragile javascript in report_loglive

SQUASH Fix tabtree, and selectgroups for mod_feedback

Also - do-not enhance the action menu - we are dropping support for this.

SQUASH Fix filemanager selector and pix_icon template for mod_forum tests.

SQUASH Fixes to breadcrumb and add formid to single select (fixes mod_glossary tests)

SQUASH lesson behat fixes. 95% of lesson styles were rubbish so they were disgarded.

SQUASH Fix lti behat tests - they were cheating and using a context step from quiz

SQUASH Behat fixes for quiz with new theme

SQUASH behat fixes for mod_wiki

SQUASH Workshop behat fixes

SQUASH Frozen form elements cannot use a readonly form element because it screws with the form JS "disabledIf" stuff.

SQUASH Fixes for grades behat tests

SQUASH behat fixes for groups

SQUASH blacklist action menu tests

SQUASH Fix for tag form element missing "manage standard tags" link

SQUASH Incomplete fixes for course behat tests

SQUASH behat fixes for badges

SQUASH Tags fixes for behat

SQUASH filepicker fixes for behat

SQUASH Abort guessing field type when we hit 'html'

SQUASH Fix for admin/tool/behat tests

SQUASH fix for admin tool behat tests

SQUASH fix for availabilty conditions hiding "aria-hidden" elements

SQUASH give the blocks more room. We get behat files because nav tree nodes are not in view

SQUASH Blocks fixed

Fix behaviour of unchecked checkboxes

SQUASH Remove incorrect step in user test

SQUASH behat fixes for course tests

Part of MDL-55071
2016-09-23 10:55:16 +01:00
Damyon Wiese 428de3dcc3 MDL-55793 theme_noname: Use fixed width container
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart d6a5c5601b MDL-55793 theme_noname: Drop columns3 layout
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Damyon Wiese 60d17ecdfc MDL-55831 blocks: Fix block headings with action menu changes
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart 3fd04d5242 MDL-55831 mod_quiz: Contain input fields within dialogues
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart c2f12b0d16 MDL-55831 mod_quiz: Fix selectors to handle renderer overrides
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart 132093f05c MDL-55831 theme_noname: Adapt action menu templates
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart f15024c18e MDL-55831 output: Convert action menu to templates
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart 45fe470eec MDL-55831 theme_noname: Single button uses new actions partial
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart 11ba3fd4c1 MDL-55831 output: Convert action_link to template
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart 0f24d9cb25 MDL-55830 form: Selectgroups option values where not passed to template
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Barbara Ramiro 4c9a20e84c MDL-55855 Theme: Centering navbar
Conflicts:
	theme/noname/templates/columns1.mustache
	theme/noname/templates/columns2.mustache
	theme/noname/templates/columns3.mustache
	theme/noname/templates/secure.mustache

Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart df07fead55 MDL-55829 form: Define 'skipClientValidation' as a global JS var
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Damyon Wiese ede7f999e8 MDL-55598 filemanager: Fix RTL icon positions in noname
Part of MDL-55071
2016-09-23 10:55:16 +01:00
Frederic Massart b843914d60 MDL-55598 theme: RTL styles for file picker/manager and tree view
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Damyon Wiese 3313fdd690 MDL-55802 output: Hide site name and user name on xs screens
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart 5f18da120e MDL-55802 theme_noname: Navbar is responsive and better styled
Still not perfect, but better...

Conflicts:
	theme/noname/templates/columns1.mustache
	theme/noname/templates/columns2.mustache
	theme/noname/templates/columns3.mustache

Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart ba252fca41 MDL-55798 theme_noname: Choosers adapt to xs screen sizes
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Damyon Wiese 7d547564a8 MDL-55796 output: Add missing include to new chooser renderable
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart 9af62dfc6f MDL-55796 theme_noname: Override default chooser template
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart 9f76a701bf MDL-55796 theme_noname: Keep modchooser items after icon
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart 4f2378d929 MDL-55796 core_course: Convert course modchooser to templates
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart ee9dd6a278 MDL-55796 core: Do not escape pix_icon URLs
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart e119bf6f2b MDL-55805 theme_noname: Arrangments for the choosers
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart 1149c23596 MDL-55805 theme_noname: Adjustments made to block controls
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart 2668487eb3 MDL-55805 theme_noname: Footer adjusments and made sticky
Conflicts:
	theme/noname/templates/columns1.mustache
	theme/noname/templates/columns2.mustache
	theme/noname/templates/columns3.mustache

Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart bc8594bd03 MDL-55805 theme_noname: File manager/picker layout adjustments
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart 4121391d34 MDL-55805 admin: Convert admin search results to use a template
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart d5732f7f40 MDL-55805 admin: Notices displayed on validation errors
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart 32e3a8dd8c MDL-55805 theme_noname: Prevent singleselect from expanding beyond edges
Part of MDL-55071
2016-09-23 10:55:15 +01:00
Frederic Massart e72cb21d44 MDL-55805 theme_nonane: Use darker colour for backdrop
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart b6bd02e7df MDL-55805 block_activity_results: Kill default centering
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart 7a2999e9fe MDL-55805 block_navigation: Tree items should not expand beyond edges
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart e919c48852 MDL-55805 theme_noname: Adjust form fieldsets spacing
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart 1ecc3daf09 MDL-55805 theme_noname: Adjust margins, paddings and grid
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart 7fcfc07344 MDL-55805 theme_noname: Adding padding to all boxes
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart f4c1c30db5 MDL-55805 theme_noname: Padding and selectors for the login page
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart 326a8e0c99 MDL-55805 mod_forum: Convert 'Add a new topic' to true single_button
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart feb1e8d1c3 MDL-55805 course: Convert the course search form to a template
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart b71c82adb8 MDL-55747 theme_noname: Display logos in the different pages
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Damyon Wiese fa02f6e6bf MDL-55657 theme_noname: Re-use the password template.
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Andrew Nicols 2c3a6e2479 MDL-55657 theme_noname: Use a separate template for passwordunmask
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Damyon Wiese 31d288cfa5 MDL-51948 admin: Clarify the upgrade.txt message
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart 525ef9c8b4 MDL-51948 core: Patch core areas for LTR forms
Part of MDL-55071
2016-09-23 10:55:14 +01:00
Frederic Massart fc7f69e7e8 MDL-51948 formslib: Support forcing LTR on form elements
Part of MDL-55071
2016-09-23 10:54:49 +01:00
Frederic Massart 113efed5b0 MDL-51948 admin: Make admin settings RTL friendly
Part of MDL-55071
2016-09-23 10:54:22 +01:00
Frederic Massart a47e73ff7c MDL-55594 output: Adding template name to filenotfound exception
Part of MDL-55071
2016-09-23 10:53:57 +01:00
Frederic Massart 10deddd34e MDL-55594 mod_forum: Convert 'big' search form to templates
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart 14395f9789 MDL-55594 output: Adding template for html_writer::select_time
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Damyon Wiese d893a4111e MDL-55700 theme_noname: Allow text nodes in breadcrumb
The new theme was showing all nodes in the breadcrumb as links even when there is no
valid link.

Part of MDL-55071
2016-09-23 10:53:56 +01:00
Damyon Wiese b4e5fcf5e2 MDL-55711 theme_noname: CSS fix for settings block
Make the branches and leaves line up.

Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart a84eadb88e MDL-55701 output: Adding core template for help_icon
We didn't intend to do this, but as I made the mistake of extending
core/help_icon in a core template without realising that it
works solely because I had that template in the new theme, I
decided to add this template to core too.

Part of MDL-55071
2016-09-23 10:53:56 +01:00
Andrew Nicols ecfad63d28 MDL-55696 output: Correct handling of url_select nothingvalue
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Damyon Wiese 126e1b2436 MDL-55658 theme_noname: Move the footer out of the content region
So it can be 100% wide.

Part of MDL-55071
2016-09-23 10:53:56 +01:00
Damyon Wiese d6f2ce1486 MDL-55656 theme_noname: Include advanced and required field markup
The new form elements were not including the markup for advanced
and required fields. I used an <abbr> tag in the label to give
and accessible indication of the advanced and required fields.

Part of MDL-55071
2016-09-23 10:53:56 +01:00
Damyon Wiese 072364df0f MDL-55607 theme_noname: Remove icon styles - We only need .icon everywhere.
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart c1d6e95b52 MDL-55584 theme_noname: Patching for better feel in grades
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart d68a9ece86 MDL-55584 core_grades: Convert part of set-up screen to template
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart ec3857fee2 MDL-55584 gradereport_singleview: Convert some elements to template
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart 376e14fa34 MDL-55564 theme_noname: Use alert-danger rather than alert-error
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart 2c773bb359 MDL-55564 theme_noname: Override admin setting templates
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart df7602298a MDL-55564 core_admin: Convert admin settings to use templates
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart 58357d41af MDL-55564 output: Single select label wasn't translated
Part of MDL-55071
2016-09-23 10:53:56 +01:00
Frederic Massart cd7a164bdf MDL-55564 output: Use template for password autofill hack
Part of MDL-55071
2016-09-23 10:53:55 +01:00
Frederic Massart d3c35f934a MDL-55399 theme: Update upgrade.txt to reflect API changes
Part of MDL-55071
2016-09-23 10:53:55 +01:00
Frederic Massart bffc0ef1f9 MDL-55508 theme_noname: Fix styling of the assignment grading interface
Part of MDL-55071
2016-09-23 10:53:31 +01:00
Damyon Wiese ce18fb1e86 MDL-55417 forms: Change iscancel property to issecondary for submit buttons
This is more future proof for the template.

Part of MDL-55071
2016-09-23 10:53:31 +01:00
Damyon Wiese 7e2cd5b84e MDL-55417 forms: Improve some of the new templates for form elements
Also - un-deprecate selectwithlink (Fred convinced me).

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese 97a00c9b8e MDL-55417 forms: Keep the JS for autocomplete in the template
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese 4691b2d08e MDL-55417 theme_noname: Update mform templates to re-use javascript
Use an amd module instead of repeating JS in the templates.

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese 344321e1ef MDL-55417 forms: Clean up form element template patch
Use a trait and a base mustache template for all form elements to reduce code
duplication and increase standardisation.

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese 91bda4cd45 MDL-55417 forms: Render form elements with a template
This change allows form elements to be overridden with a mustache template.
The template can even listen for form validation errors and supply the JS to
change the look of the form element when there is/isn't a validation error.

Initial support is for all core form elements including:

text, select, selectyesno and checkboxes, groups, dateselector, datetimeselector,
autocomplete, modvisible, advcheckbox, button, duration, filemanager, filepicker, editor, static, grading,
warning, textarea, password, url, submit, questioncategory, recaptcha.

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese ef18a21f93 MDL-55563 theme_noname: Added a bootswatch importer and 3 default bootswatches
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese 75d6a7d318 MDL-55517 theme_noname: Tweak the size of the username/passwords
They looked a bit to large on smaller screen sizes.

Also removed trailing whitespace from the template.

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart 386f269fae MDL-55517 theme_noname: Style the login page
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart 1fe8e35f54 MDL-55517 login: Converting login page to use renderer/renderable
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Didier 'OdyX' Raboud 23ef5a971c MDL-55517 login: Rework the login/index.php through a mustache template
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Damyon Wiese 400274bc61 MDL-55561 theme_noname: Fix bad padding in settings and nav block
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart d48dbde977 MDL-55384 theme_noname: Admin settings to customise the theme
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Ryan Wyllie 6bde9450b8 MDL-55384 theme_noname: Support tabs in theme settings
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart d6d695b809 MDL-55381 theme_noname: Auto prefix CSS
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart 99a6118f28 MDL-55381 output: Themes can post process CSS using a CSS tree object
Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart 515ceadddd MDL-55381 php-css-parser: Patch for Sabberworm/PHP-CSS-Parser#115
REMOVE ME ONCE Sabberworm/PHP-CSS-Parser#115 is merged

Part of MDL-55071
2016-09-23 10:53:30 +01:00
Frederic Massart 66bb9eadfe MDL-55497 mod_forum: Converted quick forum search to a renderable
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart d7c657528a MDL-55479 output: Single button uses templates
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart f1b34660ed MDL-55495 output: Make url_select a templatable
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Damyon Wiese 8a47abcd8a MDL-55496 theme_noname: Limit the number of pagination pages
The pagination bar is not usable showing > 10 links forwards and backwards.

Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart b0da86e03b MDL-55496 output: Make paging_bar a templatable
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart 270dd87113 MDL-55474 block_search_forums: Convert search form to templates
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Damyon Wiese 9727e142b6 MDL-55388 theme_noname: Define the purpose of bootstrap-rtl.scss
Add a comment explaining what the bootstrap-rtl.scss file is for (and what it is not for).

Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart 92e32fc45c MDL-55388 theme_noname: Adjustments for RTL
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart 11efad5ccc MDL-55473 theme_noname: Use template for admin search form
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart bf7f35e945 MDL-55463 output: Make single select a templatable
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart b42cf867d6 MDL-55377 output: Minor fixes for RTL installation
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart 69b06947d6 MDL-55377 output: Minor adjustments for automatic RTL support
Part of MDL-55071
2016-09-23 10:53:29 +01:00
Frederic Massart d99949ab66 MDL-55377 theme_bootstrapbase: Adapt for RTL auto flipping
Part of MDL-55071
2016-09-23 10:53:08 +01:00
Damyon Wiese b7e95263fd MDL-55462 output: Make help_icon templatable
Render it with a template in the new theme.

Part of MDL-55071
2016-09-23 10:49:50 +01:00
Damyon Wiese a26d57e414 MDL-55471 javascript: Fix conflict between bootstrapbase and bootstrap4
Part of MDL-55071
2016-09-23 10:49:50 +01:00
Damyon Wiese 13d07a01b0 MDL-55416 theme_noname: Bootstrap alpha3 support
Part of MDL-55071
2016-09-23 10:49:50 +01:00
Frederic Massart da92b73840 MDL-55416 theme_noname: Fixes for Bootstrap 4 alpha 3
Part of MDL-55071
2016-09-23 10:49:50 +01:00
Frederic Massart ed7844b5f4 MDL-55224 theme_noname: RTL adjustments for auto-flipping era
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart 1d987cae5f MDL-55224 output: Support automatic flipping to RTL styles
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart fbe18cc022 MDL-55224 core: Import PHP-CSS-Parser into core
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart e86eb6b80d MDL-55224 core: Import RTLCSS-PHP into core
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese ac4a389eb8 MDL-55414 theme_noname: Update preferences page to template
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese 3f0544b839 MDL-55413 theme_noname: action-menu conversion
Convert action-menus to templates using bootstrap4 markup.
Includes changes to iconsmall/smallicon.

Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart da4d9eb7be MDL-55412 theme_noname: Render tabs using bootstrap classes
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart 11268ae1c4 MDL-55412 output: Make tabtree and tabobject templatables
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart 65b8336ed3 MDL-55286 theme: Support compiling SCSS on-demand from a theme
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Frederic Massart 321c986c86 MDL-55285 core: Include library scssphp in core
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese 88af020839 MDL-55411 theme_noname: Style the filepicker for bootstrap 4
Uses templates.

Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese f130c411d9 MDL-55410 theme_noname: Convert custom menu renderer to render bootstrap4 menus.
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese bbe79e0e37 MDL-55409 theme_noname: Add better default button styles
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese 25f908968c MDL-55408 theme_noname: Add more styles for bootstrap modals
Part of MDL-55071
2016-09-23 10:49:49 +01:00
Damyon Wiese d7fbf722c7 MDL-55407 theme_noname: Remove styling and JS from blocks
Also:
Remove styles for the dock.
Remove drag and drop for blocks.
Blocks spacing improvements
After looking for a while - the blocks need some separation, so using .card now.
Adjusted the block column sizes as well.

Part of MDL-55071
2016-09-23 10:49:48 +01:00
Damyon Wiese d2645a6a64 MDL-55403 theme_noname: Add bootstrap4 js to moodle
Part of MDL-55071
2016-09-23 10:49:48 +01:00
Damyon Wiese 536f046033 MDL-55402 theme_noname: Convert bootstrapbase to bs4
All moodle less files are converted to sass with layouts etc
written as mustache templates.

Bootstrap 4 sass files are imported to scss/bootstrap.

Part of MDL-55071
2016-09-23 10:49:48 +01:00
Frederic Massart 3ba0023871 MDL-55401 theme_noname: Scaffolding
Part of MDL-55071
2016-09-23 10:49:48 +01:00
Jun Pataleta 1e7490ad9a MDL-49609 mod_lti: Content-Item message type-related unit tests 2016-09-23 16:29:27 +08:00
Jun Pataleta 6696cdab8f MDL-49609 mod_lti: Content-Item message type-related Behat tests 2016-09-23 16:29:27 +08:00
Jun Pataleta c1fae2b928 MDL-49609 mod_lti: Refactor content-item and make it work using JS
* Rebase and resolve conflicts from initial patch.
* Reorganise contentitem and contentitem_return pages.
* Add capability checks for contentitem and contentitem_return pages.
* Move the building of Content-Item selection request to a local
  lib function.
* Move contentitem_return processing logic to a local lib function.
* Fix type settings update. Content-item checkbox does not get
  checked/unchecked on load.
* Fix  tool settings update. Disabled content-item checkbox gets unchecked when
  tool settings form is submitted.
* Add "Select content" button on load which launches the content item
  selection dialogue.
* Move hardcoded HTML and JS to mustache templates and AMD modules.
* Use standard YUI dialog for displaying the Content-Item selection page.
* Added processing for the following Content-Item properties:
  - text
  - icon
* On ContentItem selection, fill out form with the configuration data retrieved,
  instead of automatically saving the tool and redirecting to the course page.
* Removed section- and sectionreturn-related code since we're not automatically
  adding the tool on ContentItem selection.
* On mod_lti_mod_form, enable configuration fields if they support ContentItem
  selection.
* New form-field module for setting fields using JS
* Change types_config table's 'value' column from char(255) to text
2016-09-23 16:29:19 +08:00
Eloy Lafuente (stronk7) 26162efe4a weekly release 3.2dev 2016-09-23 10:01:31 +02:00
Eloy Lafuente (stronk7) 54caa85cba Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-09-23 10:01:26 +02:00
Cameron Ball 676e5dcdcc MDL-56072 filelib: Add new groups and extensions.
This patch adds the following groups:

* html_audio: For source files of <audio> tags
* html_video: For source files of <video> tags
* html_track: For source files of <track> tags

It also adds the .vtt extension for track sources, and the flac
extension.
2016-09-23 14:13:48 +08:00
Andrew Nicols 352e65861d Merge branch 'MDL-55327' of https://github.com/stronk7/moodle 2016-09-23 10:00:20 +08:00
Eloy Lafuente (stronk7) 0fba5b440d MDL-55327 mod_lesson: better convert back to plain response_editor 2016-09-22 19:17:47 +02:00
AMOS bot 14145ad5ae Automatically generated installer lang files 2016-09-23 00:04:32 +08:00
Andrew Nicols dd193ba2ea Merge branch 'wip-MDL-55327-master-fix' of git://github.com/abgreeve/moodle 2016-09-22 15:51:04 +08:00
Andrew Nicols be16d66087 MDL-55379 phpunit: Coding style fix 2016-09-22 15:11:16 +08:00
Andrew Nicols a2b48e4127 Merge branch 'wip-mdl-55379-fix2' of https://github.com/rajeshtaneja/moodle 2016-09-22 15:09:43 +08:00
Rajesh Taneja 095883d1ea MDL-55379 phpunit: Remove directory seperator if present 2016-09-22 12:56:48 +08:00
Damyon Wiese ecdccb918d MDL-55837 themes: Remove re-setting of user/site/course theme
These themes cannot be chosen, so this part of the upgrade step is not necessary.
2016-09-22 12:34:38 +08:00
David Monllao 791844d25a Merge branch 'wip-mdl-55379-fix' of https://github.com/rajeshtaneja/moodle 2016-09-22 10:59:48 +08:00
Rajesh Taneja 544de35bc3 MDL-55379 phpunit: Preserve config option if passed 2016-09-22 10:45:47 +08:00
Russell Smith 58665ecd62 MDL-39117 cachestore_apcu: Update to APCu
We now use APCu as it's support by PHP7 and provides the
functionality we need.
2016-09-22 11:58:27 +10:00
Simey Lameze 981356b23d MDL-54802 mod_quiz: Add validation to require passing grade greater than 0
This commit adds a form validation to prevent the creation of quizzes
using zero or null grade to pass when using require passing grade.
2016-09-22 08:48:11 +08:00
Andrew Nicols 41ff0ee58b MDL-55982 mod_forum: Allow discussion view in locked blog 2016-09-22 08:22:13 +08:00
Eloy Lafuente (stronk7) 64573a35e9 Merge branch 'MDL-55124' of https://github.com/mr-russ/moodle 2016-09-22 00:52:30 +02:00
Russell Smith d59f1d3150 MDL-55124 database: Mode connection test to after connection.
To verify the client encoding and other data is correct then
the connection must have been made first.
2016-09-22 08:40:03 +10:00
David Mudrák 8df850ad6f MDL-46946 user: Make missing required custom fields trigger profile edit
If there is a required custom field that the user can fill by editing
their profile, and that field is missing, the user should be considered
as not fully set up. Instead, we want to redirect them to edit their
profile first.

There are some exceptions when we want to fall back to the previous
behaviour and check just the name and email fields. These exceptional
cases include checking remote user data in incoming MNet request (no
user id, no custom fields supported) and calls to require_login() with
redirecting disabled (typically ajax filepicker requests on profile
editing page itself).

Additional plugins that call the function user_not_fully_set_up()
themselves, should perform the strict check in most/typical cases. So
the strict mode is enabled by default even if it changes the behaviour
slightly. In improbable case of additional plugins relying on the
previous behaviour of the function, they can use the $strict parameter
and keep performing the lax check. However, I am sure the correct fix in
that case will likely be to stop abusing this function.

Note that custom fields are not currently transferred during the MNet
roaming. So having custom fields configured as required on MNet service
provider site (where users can't edit their profiles) is expected to
display an error (as the site is considered as misconfigured).
2016-09-21 17:46:30 +02:00
Adrian Greeve f4eef5fb25 MDL-55327 mod_lesson: Fix for copying essay and match.
Matching and essay questions would display errors when
being duplicated.
2016-09-21 18:04:08 +08:00
Juan Leyva 65e961e4f2 MDL-56045 message_airnotifier: New WS message_airnotifier_enable_device 2016-09-21 10:45:13 +01:00
Juan Leyva 95f53a652a MDL-56045 message_airnotifier: Move enable device code to manager class 2016-09-21 10:44:56 +01:00
Juan Leyva 618cba3494 MDL-56044 message_airnotifier: New WS message_airnotifier_get_user_devices 2016-09-21 09:47:26 +01:00
Dan Poltawski 948e6e3fca MDL-48766 lib: fix another stupid case sensitivity issue 2016-09-21 09:31:54 +01:00
Damyon Wiese a8225336d9 MDL-56052 block_settings: race condition
YUI events module must be loaded before global events can be used.
2016-09-21 12:21:39 +08:00
Eloy Lafuente (stronk7) 6cc077e90f Merge branch 'MDL-55982-master' of git://github.com/andrewnicols/moodle 2016-09-21 03:04:36 +02:00
Andrew Nicols 0f3bbfd4f8 MDL-55982 mod_forum: Add time-based discussion locking
This patch adds support for time-based locking of discussions.
Discussions are automatically locked after a user-definable period of
inactivity. After this time, only those with the the relevant capability
are able to add replies.

This has been designed to add support for other types of discussion locking
at a later date with relative ease.
2016-09-21 09:03:42 +08:00
Simey Lameze f096f1bdd3 MDL-56013 lib: Create a page to test Chart.js 2016-09-21 08:25:13 +08:00
Simey Lameze e38239b487 MDL-56013 lib: Upgrade Chart.js to version 2.2.2 2016-09-21 08:25:13 +08:00
Eloy Lafuente (stronk7) 349a6430e6 Merge branch 'MDL-45752_m32v3' of https://github.com/sbourget/moodle 2016-09-20 17:36:51 +02:00
Eloy Lafuente (stronk7) 73b2a94c7f MDL-55405 enrol_paypal: Fix set_context() call
Note that setting the page context more than once is not ideal
but as far as system->course switches are allowed, this should
not hurt, while providing more accurate messages than keeping
system context.
2016-09-20 12:27:35 +02:00
Eloy Lafuente (stronk7) 43f53ded83 Merge branch 'MDL-55405-master' of git://github.com/cameron1729/moodle 2016-09-20 12:21:37 +02:00
Eloy Lafuente (stronk7) ce7863ba36 Merge branch 'MDL-55124' of https://github.com/mr-russ/moodle 2016-09-20 12:13:10 +02:00
Russell Smith f834a8f5eb MDL-55124 database: Allow option to not send options.
pgbouncer doesn't accept the PostgreSQL options command as it can't
process it.  If you are using pgBouncer you need to make sure your
database is configured to set client encoding and standard_conforming_strings
correctly on each connection.  pgBouncer can do this, as can ALTER
commands.

Also using sockets without a filename did not allow different ports to work.
This is because you either specify a filename which includes a port or
you just specify a port and libpq works out the correct socket location.
2016-09-20 19:53:01 +10:00
Juan Leyva fad980b26f MDL-55785 mod_glossary: Check user can create new entries 2016-09-20 10:52:53 +01:00
Juan Leyva f0e1808fc4 MDL-55785 mod_glossary: New Web Service mod_glossary_add_entry 2016-09-20 10:52:53 +01:00
Juan Leyva e6de11d7b7 MDL-55785 mod_glossary: Move edit.php code to new lib function
Most of the code that was in mod/glossary/edit.php has been moved to
mod/glossary/lib.php:glossary_edit_entry
2016-09-20 10:48:41 +01:00
Juan Leyva 114eaf519d MDL-55740 assign: Add assignment WS to the mobile service
* mod_assign_submit_grading_form
* mod_assign_get_participant to the mobile service
2016-09-20 10:31:50 +01:00
Sam Hemelryk cb3e2e144a MDL-39117 cachestore_apc: imported into core 2016-09-20 18:52:03 +10:00
Dan Poltawski 89ae98f134 Merge branch 'MDL-55916-maintmode-503-moodle' of https://github.com/brendanheywood/moodle 2016-09-20 09:31:41 +01:00
Cameron Ball 4abbb4180b MDL-55405 enrol_paypal: Create utility class
Some helper functions were in the IPN file. They really should be
in their own utility class to facilitate better testing.
2016-09-20 12:38:31 +08:00
Andrew Nicols 2fc56dd571 MDL-51361 backup: Documentation phpcs fix 2016-09-20 12:21:41 +08:00
Andrew Nicols 91d52985c5 Merge branch 'MDL-51361' of https://github.com/bostelm/moodle 2016-09-20 11:58:24 +08:00
Andrew Nicols 674de8e51e Merge branch 'MDL-55191_master' of git://github.com/dmonllao/moodle 2016-09-20 11:41:03 +08:00
Andrew Nicols 5a766a9e21 MDL-55327 mod_lesson: Whitespace fix 2016-09-20 11:19:28 +08:00
Andrew Nicols 25804281f1 Merge branch 'wip-MDL-55327-master' of git://github.com/abgreeve/moodle 2016-09-20 11:15:54 +08:00
Adrian Greeve 329b68c9ca MDL-55327 mod_lesson: Behat test for page duplication. 2016-09-20 10:36:13 +08:00
Adrian Greeve f847669e33 MDL-55327 mod_lesson: Unit tests for the new function 2016-09-20 10:36:13 +08:00
Adrian Greeve 9f937c3bb3 MDL-55327 mod_lesson: Added the ability to duplicate pages. 2016-09-20 10:36:13 +08:00
Brendan Heywood f1c6d647bc MDL-55916 setup: Maintenance mode serves HTTP 503 2016-09-20 11:59:39 +10:00
Marina Glancy 2b1c3e4d68 MDL-55990 tags: remove unnecessary index creation 2016-09-20 09:30:40 +08:00
Andrew Nicols 77391e9f09 Merge branch 'MDL-55876-master' of git://github.com/lameze/moodle 2016-09-20 09:10:43 +08:00
Adrian Greeve 6965ffe041 MDL-55519 activities: mform element shows correct maxgrade.
In certain circumstances the max grade value would revert
back to the default max grade value.
2016-09-20 08:56:24 +08:00
Andrew Nicols 13c8792606 Merge branch 'MDL-55586-master' of https://github.com/StudiUM/moodle 2016-09-20 08:17:37 +08:00
Eloy Lafuente (stronk7) 0f4b338fbb Merge branch 'wip-mdl-55379' of https://github.com/rajeshtaneja/moodle 2016-09-20 02:06:32 +02:00
Eloy Lafuente (stronk7) 8dcc999d96 Merge branch 'wip-MDL-55827-master' of git://github.com/marinaglancy/moodle 2016-09-20 01:02:06 +02:00
Eloy Lafuente (stronk7) 55a1e66cfc Merge branch 'MDL-55856-master' of git://github.com/danpoltawski/moodle 2016-09-20 00:51:36 +02:00
Ruslan Kabalin 8292fa8184 MDL-55776 enrol: Optimise enrolled users listing.
Here we optimise SQL queries for enrolled users list. Expensive subquery is
replaced with faster LEFT JOIN and the whole groups filtering component is
aded on demand.
2016-09-19 23:46:28 +02:00
Ruslan Kabalin d76749b42c MDL-55776 enrol: Add unit tests for enrolment manager. 2016-09-19 23:46:20 +02:00
AMOS bot dbe75154b6 Automatically generated installer lang files 2016-09-20 00:04:28 +08:00
Issam Taboubi 0d12feb6c8 MDL-55586 report_competency: Translation strings in competencies 2016-09-19 12:02:54 -04:00
Issam Taboubi c2cd126033 MDL-55586 blocks_lp: Translation strings in competencies 2016-09-19 12:01:19 -04:00
Dan Poltawski 771a8d3394 Merge branch 'wip-mdl-55117' of https://github.com/rajeshtaneja/moodle 2016-09-19 11:39:41 +01:00
Dan Poltawski a2184f971f Merge branch 'master_MDL-55820' of git://github.com/danmarsden/moodle 2016-09-19 11:32:19 +01:00
Dan Poltawski daa571af9f Merge branch 'MDL-55944' of https://github.com/mr-russ/moodle 2016-09-19 11:25:12 +01:00
Eloy Lafuente (stronk7) cecba1d92e Merge branch 'wip-MDL-29332-master-3' of git://github.com/marinaglancy/moodle 2016-09-19 11:51:08 +02:00
Dani Palou d33c67bc47 MDL-56019 ws: Use itemid null when getting modules intro 2016-09-19 11:33:55 +02:00
Dan Poltawski a878a09bce MDL-48766 thirdpartylibs: fix incorrect casing on path 2016-09-19 10:30:34 +01:00
David Monllao 9b0cc781c5 Merge branch 'MDL-48766-master' of git://github.com/danpoltawski/moodle 2016-09-19 16:38:17 +08:00
Dan Poltawski c307689792 MDL-48766 tests: move from Liberec to Cambridge
(liberec ip seemed to have been identified as a new location nearby now,
hoping cambridge will be stable)
2016-09-19 08:59:39 +01:00
Dan Poltawski 0ddc7e5582 MDL-48766 lib: remove unused pear::Net::GeoIP
This was used for the previous geoip database.
2016-09-19 08:59:39 +01:00
Dan Poltawski 3fad0f1a24 MDL-48766 iplookup: Update to geoip2 db to support ipv6
The previous maxmind geoip database is now legacy and the GeoIP2
version supports ipv6.
2016-09-19 08:59:39 +01:00
Dan Poltawski eacc36a26b MDL-48766 lib: Import MaxMind GeoIP2 PHP API
No changes from the upstream version have been made, it is recommended by
upstream to install these depdencies via composer - but the composer
installation is bundled with a load of test files, shell scripts etc (and
we don't use composer to manage 'production dependencies') so we have to
do it manually.
2016-09-19 08:59:38 +01:00
Simey Lameze 12b9401602 MDL-55876 core_course: prevent changes on front page course 2016-09-19 15:45:43 +08:00
David Monllao 9df9382e4d Merge branch 'MDL-42041-master' of git://github.com/andrewnicols/moodle 2016-09-19 15:08:56 +08:00
David Monllao 564cabb97a MDL-55837 theme_base: Remove missing file
Probably missed during rebase.
2016-09-19 14:59:56 +08:00
David Monllao 073163ffc3 Merge branch 'MDL-55837-master' of git://github.com/damyon/moodle 2016-09-19 14:15:59 +08:00
Damyon Wiese 644fcbb629 MDL-55837 themes: base and canvas themes removed
Look for them in the plugins DB if you still need them.
2016-09-19 13:35:13 +08:00
Marina Glancy e7ba25f1b1 MDL-29332 question: calculated variables may differ in case only 2016-09-19 10:37:43 +08:00
Andrew Nicols 96872ab271 Merge branch 'MDL-55932-master' of https://github.com/eberhardt/moodle 2016-09-19 08:32:54 +08:00
Henning Bostelmann 4151ed984a MDL-51361 backup: Adding default settings for course import
Also adding "calendar events" and "competencies" default setting for other backup modes.
2016-09-18 23:39:57 +01:00
spvickers d8f9109a12 MDL-49609 mod_lti: Add Content-Item message
Added option for tools to support Content-Item message and redirect
to/from tool provider when creating an instance.
2016-09-18 22:16:10 +08:00
AMOS bot e2625817a1 Automatically generated installer lang files 2016-09-17 00:04:27 +08:00
David Mudrák d676f6bd19 MDL-55987 gradebook: Claim extra memory when updating final grades
As we experienced in a bigger moodle.org course (7500 users, 70 grade
items), the standard memory limit 256M may not be enough here. We were
not able to find any obvious memory leak in the processing. Requiring
extra memory helped in this particular case and it seems reasonable to
have it in the core.
2016-09-16 12:39:47 +02:00
Juan Leyva 08d7965e63 MDL-55928 gradereport_user: New WS for retrieve grade items
It includes a refactor of the complete externallib.
Previously it was not possible to filter the report by groups.
2016-09-16 09:55:14 +01:00
Juan Leyva 345330d172 MDL-55928 gradereport_user: Return grade items data among the table data 2016-09-16 09:55:13 +01:00
AMOS bot fdf5335d70 Automatically generated installer lang files 2016-09-16 00:04:42 +08:00
Eloy Lafuente (stronk7) 03d27c303d MDL-29332 tests: Cover the new sql_equal() function
- For CS, CI and AS
- Not for AI (it's not cross-db)
- equal (=) and not equal (<>)
- delete old test_sql_binary_equal() now with cross-db solution.
2016-09-15 16:33:08 +02:00
Eloy Lafuente (stronk7) 9d5c12bee4 MDL-29332 dml: new sql_equal() to force cs/ci behavior on varchar matching 2016-09-15 16:33:00 +02:00
Dan Poltawski d2c7175a34 MDL-55856 grunt: fail gracefully when node version too old
Unfortunately the engine requirement in packages.json is not a fatal
error, so you can get unhelpful errors with grunt if using an
unsupported version.
2016-09-15 15:32:32 +01:00
Dan Poltawski 054da30ba9 MDL-48766 moodlelib: introduce ip_is_public()
For determining if an IP is publicly addressable
2016-09-15 14:53:14 +01:00
Jan Eberhardt 2c99429375 MDL-55932 block_rss_client: Namespace fixes 2016-09-15 13:24:36 +00:00
Dan Poltawski 1f2744851f weekly release 3.2dev 2016-09-15 11:14:54 +01:00
Dan Poltawski a8cf3454ce Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-09-15 11:14:52 +01:00
David Monllao 37a8e5223d Merge branch 'MDL-55945-master' of https://github.com/snake/moodle 2016-09-15 12:38:43 +08:00
David Monllao e71061a22b MDL-55191 search: Generate an search result viewed event 2016-09-15 09:36:49 +08:00
Jake Dallimore db8c2cf6d4 MDL-55945 login: fix https support for forgot_password.php 2016-09-15 09:19:39 +08:00
Andrew Nicols 4e2e54eed0 MDL-55866 mod_data: Remember editor enabled state for templates
Some templates can legitimately contain invalid HTML (e.g. mismatched tags)
because the templates operate in pairs.

In these instances we should not use an editor because the nature of the
editor (content editable) means that the browser automatically corrects all
HTML supplied to it, thus breaking the template entirely.

Therefore we need to disable HTML editors for some templates, and do so in
a way tied to the instance of the activity, rather than to a specific user.

This patch adds a new 'config' field, with matching setters and getters, to
allow such per-instance values to be stored.
2016-09-15 08:38:10 +08:00
David Mudrák 161131f057 MDL-55957 workshop: Add behat tests for embedded images
This tests basic functionality of the images embedded into the
instructions and conclusion fields.
2016-09-14 14:25:41 +02:00
David Mudrák e46aec4c45 MDL-55957 workshop: Fix the embedded files serving
There was a bug with serving the files from the areas instructauthors,
instructreviewers and conclusion. These three areas should not use the
itemid in the plugininfo URLs. But they did use 0 as the itemid which
broke the file previews when browsing via server files repository.

The first part of the patch fixes all relevant calls to
file_rewrite_pluginfile_urls() so that null is now properly used instead
of zero.

The second part of the fix is that we no longer delete the first $args
element in the workshop_pluginfile() function - the itemid is not
supposed to appear there now.

The last part of the patch is that instead of repeating the same code
block copy&pasted for each file area in workshop_pluginfile(), we now
have a single block covering them all.
2016-09-14 12:14:56 +02:00
David Monllao 8beee5a449 MDL-55921 profiling: Adding missing vars 2016-09-14 13:48:38 +10:00
Russell Smith ff3b8f6c89 MDL-55921 profiling: Enable util script to be profiled.
Enable util scripts to be profiled again and ensure
that non-util script runs that don't include version.php
are also able to provide some output.

See David's commit for how export ensures version is used.
2016-09-14 13:48:15 +10:00
Rajesh Taneja a396321e44 MDL-55117 behat: Re-initialise to ensure modified config is not used
As behat cli process is 1 run for features
Any modification in  will be reflected
in later runs on cli. In this case
- disabling enablebadges in block_badges.feature
- reflected while running cron in award_badges.feature
2016-09-14 10:46:19 +08:00
Andrew Nicols 8bdd97a35a MDL-54872 mod_assign: Allocate Unique IDs before tests 2016-09-14 09:20:33 +08:00
Russell Smith 74ee9d29d2 MDL-55944 testing: Reduce sleep usage.
Remove sleep() and replace with waiting for a second to roll over,
this results in a simpler call the guarantee time() has moved forward
2016-09-14 09:49:30 +10:00
Eloy Lafuente (stronk7) b5830334e7 Merge branch 'wip-mdl-55466' of https://github.com/rajeshtaneja/moodle 2016-09-14 01:38:51 +02:00
Rajesh Taneja 234e1449a1 MDL-55466 lib: Create clean alternateloginurl 2016-09-14 07:37:08 +08:00
Stephen Bourget 768e3613a9 MDL-45752 Course: Add additional events 2016-09-13 19:23:59 -04:00
Dan Poltawski 5d602e314b Merge branch 'wip-MDL-55864-master' of git://github.com/marinaglancy/moodle 2016-09-13 14:56:27 +01:00
Pau Ferrer Ocaña 9201a00a5d MDL-55951 output: Add errorcode to fatal_error when available 2016-09-13 15:30:01 +02:00
Dan Poltawski eb81115f20 Merge commit '2bcef5594aa7aef9329e750210f09c8cd506c85b' 2016-09-13 10:05:57 +01:00
Dan Poltawski 3ec4a8085c Merge branch 'MDL-55791_master' of https://github.com/Syxton/moodle 2016-09-13 09:40:33 +01:00
Ryan Wyllie 2bcef5594a MDL-55727 javascript: Add modal module 2016-09-13 02:44:30 +00:00
David Monllao c46432ad6c Merge branch 'MDL-54872-master' of git://github.com/andrewnicols/moodle 2016-09-13 10:05:26 +08:00
Marina Glancy 9e21f12dbd MDL-55864 general: fix PHP7.1 strict warnings 2016-09-13 09:39:26 +08:00
Eloy Lafuente (stronk7) ed55d47d03 Merge branch 'wip-MDL-55123-master' of git://github.com/marinaglancy/moodle 2016-09-12 19:37:40 +02:00
Eloy Lafuente (stronk7) 9579b52372 Merge branch 'wip-MDL-55505-master' of git://github.com/abgreeve/moodle 2016-09-12 19:19:45 +02:00
Eloy Lafuente (stronk7) 4e25d5e5ea Merge branch 'wip-MDL-55654-master' of git://github.com/marinaglancy/moodle 2016-09-12 19:14:00 +02:00
Eloy Lafuente (stronk7) 61b246fd0e Merge branch 'MDL-55632-master' of git://github.com/andrewnicols/moodle 2016-09-12 19:12:26 +02:00
Eloy Lafuente (stronk7) 9d821b6faf Merge branch 'MDL-55874-master' of git://github.com/danpoltawski/moodle 2016-09-12 18:29:42 +02:00
AMOS bot 415fb6ca10 Automatically generated installer lang files 2016-09-13 00:04:35 +08:00
Eloy Lafuente (stronk7) fa7c2bd050 Merge branch 'MDL-55725-master' of git://github.com/merrill-oakland/moodle 2016-09-12 17:54:59 +02:00
Eloy Lafuente (stronk7) b8c5fc8620 Merge branch 'MDL-55755_master' of git://github.com/dmonllao/moodle 2016-09-12 17:34:21 +02:00
Matt Davidson 59c66f926f MDL-55791 admin: maintenance mode access capability
Add capability to allow certain non-admin users through maintenance
mode.
2016-09-12 10:37:25 -04:00
Dan Poltawski 2a786e7bad Merge branch 'MDL-52798_m32v2' of https://github.com/sbourget/moodle 2016-09-12 12:17:40 +01:00
Dan Poltawski 0fcbfb63a5 Merge branch 'wip-mdl-55353' of https://github.com/rajeshtaneja/moodle 2016-09-12 11:49:33 +01:00
Dan Poltawski 3e6ac53831 Merge branch 'wip-mdl-55759' of https://github.com/rajeshtaneja/moodle 2016-09-12 11:36:18 +01:00
Dan Poltawski 4bbe995c89 Merge branch 'wip-mdl-55610' of https://github.com/rajeshtaneja/moodle 2016-09-12 10:18:18 +01:00
David Monllao a8a75c865f Merge branch 'MDL-55122-master' of git://github.com/lameze/moodle 2016-09-12 12:49:27 +08:00
David Monllao 7f09438a49 Merge branch 'MDL-55626-MASTER' of git://github.com/lazydaisy/moodle 2016-09-12 12:37:44 +08:00
Marina Glancy 721e2def56 MDL-55123 forms: do not call non-static methods statically
this breaks in PHP7.1
2016-09-12 12:06:18 +08:00
Marina Glancy 64c45a2928 MDL-55123 forms: correctly create elements in unittests 2016-09-12 11:56:04 +08:00
David Monllao 1e4233434b Merge branch 'MDL-55873-master' of git://github.com/lameze/moodle 2016-09-12 11:55:51 +08:00
Simey Lameze 90d8bf59e7 MDL-55873 login: change back username fields to use PARAM_RAW 2016-09-12 11:49:14 +08:00
Russell Smith ec4b83b92a MDL-55922 cache: Improve static cache performance
Static cache has a very flexible storage capability
and does not need all the checks performed on it.
Enabling dereferencing handling and multiple identifiers
removes a lot of unneeded overhead for request caches that
have many get calls.

The changes were modelled on the static acceleration changes
done in MDL-53208.
2016-09-12 11:58:55 +10:00
Rajesh Taneja 1b319d3d3b MDL-55379 phpunit: Fix dir separator for cli commands 2016-09-12 09:48:40 +08:00
Rajesh Taneja a7f202de4e MDL-55379 phpunit: Fixed hint_result for rerun 2016-09-12 09:48:39 +08:00
Andrew Nicols eb4c466162 MDL-54872 assign: Order blindly marked assignments more blindly 2016-09-12 09:29:45 +08:00
Ryan Wyllie e845b96b83 MDL-55727 javascript: add custom interaction event module 2016-09-12 01:22:20 +00:00
Ryan Wyllie 57a4aba799 MDL-55727 templates: add loading icon template 2016-09-12 01:22:19 +00:00
lazydaisy 8133912c6f MDL-55626 theme_clean: Fixed clean theme missing desktop-first-column 2016-09-10 01:18:29 +01:00
Marina Glancy 88c9c42da2 MDL-55654 user: apply format_string to field names 2016-09-09 14:31:16 +08:00
Rajesh Taneja 3c0b682d39 MDL-55353 behat: Ensure teacher edit activity at different time
Recent activity is showing activities which were
updated since user last logged in and first modification
done on the activity. So ensure update happens at different
time than activity created.
2016-09-09 10:14:05 +08:00
Simey Lameze 02d6873ff0 MDL-55122 enrol: remove duplicated updown variable 2016-09-09 08:48:00 +08:00
Simey Lameze ddd6bea1c7 MDL-53893 core_badges: Behat for all selected roles award badges 2016-09-09 08:40:48 +08:00
Simey Lameze 294f7773db MDL-53893 core_badges: Add strictness to manual badge criteria 2016-09-09 08:40:48 +08:00
David Monllao 1ef29fd28f MDL-55755 search: Correct event link 2016-09-09 07:57:22 +08:00
Adrian Greeve a14cde804e MDL-55505 mod_assign: Editing previous attempt works correctly.
Editing a previous attempt keeps the current feedback and grades
as it should and does not override them.
2016-09-08 20:31:05 +08:00
Dan Poltawski 0344082208 weekly release 3.2dev 2016-09-08 10:25:48 +01:00
Dan Poltawski 3989f4597c Merge branch 'MDL-55504_no-phpunit-utils' of git://github.com/dmonllao/moodle 2016-09-08 09:15:14 +01:00
David Monllao 30fbc3ecab MDL-55504 profiling: No profiling for PHPUNIT_UTIL stuff 2016-09-08 15:32:46 +08:00
Dan Poltawski d6713a430e MDL-55874 report_particiption: fix invalid html
When messaging disabled.
2016-09-08 08:03:05 +01:00
David Monllao 1e1fa3a23e weekly release 3.2dev 2016-09-08 13:56:33 +08:00
Rajesh Taneja ec757a2ef9 MDL-55415 phpunit: Option values are set to false by default 2016-09-08 07:11:10 +08:00
Eric Merrill 1aaead91f9 MDL-55725 search: Index proper time modified with indexed files 2016-09-07 17:33:28 -04:00
Juan Leyva c874d9aa81 MDL-55415 course: Fix unit tests after fixing beat issues 2016-09-07 15:00:56 +01:00
Dan Poltawski 29788d1b3c Merge branch 'wip-mdl-55415' of https://github.com/rajeshtaneja/moodle 2016-09-07 11:39:16 +01:00
Rajesh Taneja 247bdccfb1 MDL-55415 course: Set default options to false for frontpage 2016-09-07 17:12:50 +08:00
Adrian Greeve 80753d3107 MDL-41174 mod_workshop: Added workshop_refresh_events
This function was missing from this activity.
2016-09-07 14:29:13 +08:00
Rajesh Taneja b468dbf533 MDL-55879 behat: Only hook BeforeSuite once
Before suite check and initialise behat env,
this is valid for the whole run, so no need
to do the inilialsation again
2016-09-07 14:24:09 +08:00
Andrew Nicols 64ebf3955b MDL-37669 mod_forum: Mark posts as read on notify to user pref
Some people prefer to have posts marked as read when they receive them, and
some prefer not to. Let us allow them to choose.
2016-09-07 12:32:42 +08:00
Stephen Bourget 9629790b1b MDL-52798 calendar: Move calendar preferences to a user preferences page
This is based on the work of Shamim Rezaie and will also resolve
MDL-52375 and MDL-50378
2016-09-06 21:29:34 -04:00
Jake Dallimore 7ceab0d993 MDL-50803 login: Remove token from URL in forgot password process
Store the token value in the session and redirect to self, thus
removing the token from the URL and eliminating the problem where
the token is exposed via the http referer header.
2016-09-07 09:07:29 +08:00
Juan Leyva 753504fbe0 MDL-49026 webservice: Remove tokens on password change 2016-09-07 09:07:29 +08:00
Eloy Lafuente (stronk7) 8c2bb3aec8 Merge branch 'wip-mdl-55764' of https://github.com/rajeshtaneja/moodle 2016-09-07 03:06:12 +02:00
Eloy Lafuente (stronk7) a6a787c011 Merge branch 'MDL-55236' of https://github.com/bostelm/moodle 2016-09-06 20:30:49 +02:00
Eloy Lafuente (stronk7) 1cce237bac Merge branch 'MDL-55618' of https://github.com/NeillM/moodle 2016-09-06 16:20:32 +02:00
Eloy Lafuente (stronk7) 8c8057065a Merge branch 'wip-MDL-55844-master' of git://github.com/marinaglancy/moodle 2016-09-06 16:08:17 +02:00
Eloy Lafuente (stronk7) 69e18dbf70 Merge branch 'wip-MDL-55832-master' of git://github.com/marinaglancy/moodle 2016-09-06 15:56:01 +02:00
Dan Poltawski 2e79c7305d MDL-42125 quiz stats: removal trivial additional phpdocs newline 2016-09-06 11:47:57 +01:00
Dan Poltawski 7c5b0bbcbe Merge branch 'MDL-42125' of git://github.com/timhunt/moodle 2016-09-06 11:46:52 +01:00
Dan Poltawski aed3367f1e MDL-55415 course: fix trailing whitespace 2016-09-06 10:50:49 +01:00
Dan Poltawski 05842d741b Merge branch 'MDL-55415-master' of git://github.com/jleyva/moodle 2016-09-06 10:49:39 +01:00
Dan Poltawski f0ca10fb1b Merge branch 'wip-mdl-55749' of https://github.com/rajeshtaneja/moodle 2016-09-06 08:43:52 +01:00
Marina Glancy 308ce5b46f MDL-55827 tests: @ does not suppress wrong number of arguments in php7.1 2016-09-06 15:37:30 +08:00
Cameron Ball ab3759fff5 MDL-55404 core_upgrade: Add libcurl environment checks
This patch adds logic to test whether or not the
libcurl (used by PHP/cURL)  was compiled against a compatible
SSL/TLS library.
2016-09-06 11:34:46 +08:00
David Monllao 500af4968b Merge branch 'MDL-55504' of https://github.com/mr-russ/moodle 2016-09-06 11:30:13 +08:00
Russell Smith 8f7dcb3453 MDL-55504 profiling: Support for PHPUnit and big profiles.
To support PHPUnit we need to support large profiles, these may
include backups and restores. To do that the following was required;
- gzcompress for database space saving.
- gzcompress for XML DomDocument field to say < 10Mb and allow imports.
- Save PHPUnit runs directly to a file so they can be imported to the normal database.
- Memory allowance on profiling view pages increases to support large profiles.
2016-09-06 12:41:56 +10:00
Rajesh Taneja 3b73ba8fa4 MDL-55749 badges: define global before using it 2016-09-06 10:27:44 +08:00
David Monllao 9f3ba5c425 Merge branch 'MDL-55617' of https://github.com/NeillM/moodle 2016-09-06 10:17:49 +08:00
David Monllao 6f42301b2e Merge branch 'wip-mdl-55288' of https://github.com/rajeshtaneja/moodle 2016-09-06 10:15:31 +08:00
David Monllao 370fe0634d Merge branch 'MDL-55587-master' of git://github.com/cameron1729/moodle 2016-09-06 10:07:00 +08:00
Eloy Lafuente (stronk7) e1683ea5a3 Merge branch 'MDL-55239_m32v1' of https://github.com/sbourget/moodle 2016-09-05 19:23:13 +02:00
Eloy Lafuente (stronk7) f30c075d69 Merge branch 'MDL-55663-master' of git://github.com/FMCorz/moodle 2016-09-05 18:06:40 +02:00
Eloy Lafuente (stronk7) a1a564c84a Merge branch 'MDL-55717_master' of git://github.com/markn86/moodle 2016-09-05 18:01:21 +02:00
Eloy Lafuente (stronk7) 5e16bdb25c Merge branch 'MDL-55724-master' of https://github.com/sammarshallou/moodle 2016-09-05 17:33:25 +02:00
Juan Leyva b9050b106e MDL-55415 course: New WS core_course_get_user_administration_options 2016-09-05 15:42:48 +01:00
Juan Leyva b2392037e7 MDL-55415 course: Move admin options permission check to API 2016-09-05 15:42:47 +01:00
Juan Leyva c115ff6ab5 MDL-55415 course: New WS core_course_get_user_navigation_options 2016-09-05 15:42:47 +01:00
Juan Leyva e200200938 MDL-55415 webservice: Allow validate_courses to return contexts 2016-09-05 15:42:45 +01:00
Juan Leyva d6cd89b110 MDL-55415 course: Move options permission check to API 2016-09-05 15:42:45 +01:00
Dan Poltawski 9423674717 Merge branch 'MDL-55627' of https://github.com/bostelm/moodle 2016-09-05 14:09:09 +01:00
Dan Poltawski dca4a87101 Merge branch 'MDL-55742-master' of https://github.com/xow/moodle 2016-09-05 10:50:47 +01:00
Henning Bostelmann f617ac5c75 MDL-55627 filter_mathjaxloader: use correct string concatenation op 2016-09-05 11:40:04 +02:00
Henning Bostelmann e5e89cacfb MDL-55236 mod_assign: Allow subplugins to backup files 2016-09-05 11:39:12 +02:00
Dan Poltawski 9dd516c432 Merge branch 'MDL-55771_master' of git://github.com/markn86/moodle 2016-09-05 10:18:53 +01:00
Dan Poltawski a46f187431 Merge branch 'wip-mdl-55766' of https://github.com/rajeshtaneja/moodle 2016-09-05 09:24:27 +01:00
Dan Poltawski eccebeebf5 Merge branch 'MDL-55815' of git://github.com/timhunt/moodle 2016-09-05 08:27:58 +01:00
Dan Poltawski e7b4f3d3ae Merge branch 'wip-MDL-55826-master' of git://github.com/marinaglancy/moodle 2016-09-05 08:18:32 +01:00
Dan Poltawski e5c5f5d3ff Merge branch 'MDL-54113-master' of git://github.com/andrewnicols/moodle 2016-09-05 07:53:26 +01:00
Rajesh Taneja 9b9afffe5b MDL-55288 forms: Set data attribute to form fields 2016-09-05 14:10:24 +08:00
David Monllao 94c9d470d1 Merge branch 'wip-MDL-41174-master' of git://github.com/abgreeve/moodle 2016-09-05 13:44:36 +08:00
Marina Glancy f9e2d3d451 MDL-55832 mod_feedback: apply filters to multichoice quesitons 2016-09-05 13:29:57 +08:00
Andrew Nicols 63d7b1acc0 MDL-42041 mod_book: Add Turn Editing On to page body 2016-09-05 13:08:24 +08:00
Marina Glancy c6745991b1 MDL-55844 profile: display formatted course name 2016-09-05 13:05:56 +08:00
David Monllao 2ab5bbc409 Merge branch 'MDL-55457-master' of https://github.com/xow/moodle 2016-09-05 11:48:34 +08:00
David Monllao af12b3c663 Merge branch 'wip_MDL-53724_master' of git://github.com/gjb2048/moodle 2016-09-05 11:34:06 +08:00
David Monllao f1ef913364 Merge branch 'wip-MDL-55707-master' of git://github.com/abgreeve/moodle 2016-09-05 10:46:57 +08:00
Rajesh Taneja 54ced30d03 MDL-55610 behat: Clear static file cache
php file cache might be out-of-sync
to ensure full directory is deleted
clear php file cache
2016-09-05 10:18:19 +08:00
Adrian Greeve 9851111f7a MDL-41174 course: Module name change updates calendar. 2016-09-02 11:46:09 +08:00
Marina Glancy d47af580bd MDL-55826 question: fix PHP7.1 strict warnings 2016-09-02 10:52:02 +08:00
John Okely d51757a729 MDL-55457 mod_lti: Support object icon_info in tool proxy 2016-09-02 09:39:31 +08:00
Gareth J Barnard efe67d05b2 MDL-53724 themes: Inconsistent padding when >= one blocks are docked. 2016-09-01 18:22:28 +01:00
Tim Hunt 6ae04c2684 MDL-42125 quiz stats: fix regression caused by MDL-51603 2016-09-01 12:38:30 +01:00
Tim Hunt 9e5e0d8de4 MDL-42125 quiz stats: clearer message when manual grading required 2016-09-01 12:34:40 +01:00
Neill Magill 31c62848f0 MDL-55617 backup: Possible fatal errors in backup and restore
The unserialize() function will not always return an object
especially when as can happen the controller field of a
record in the backup_controllers table is empty.

This change ensures that in this case the script will
not cause a fatal error, but instead throw an error.
2016-09-01 08:51:25 +01:00
Neill Magill fefd9fed83 MDL-55618 backup: Header should not be output twice
Before this patch if the pre-check failed during
the final stage of an import a request for the
page header to be output was made for a second
time, this caused a coding_error to occur.

This change removes the second request to
output the page header, which will allow the user
to see the reasons the pre-check failed.
2016-09-01 08:43:45 +01:00
Cameron Ball b8d0f90ec7 MDL-54793 webservice_xmlrpc: Don't treat GET and POST as arguments 2016-09-01 15:15:10 +08:00
John Okely 3b4491e8aa MDL-55742 mod_lti: Remove support for get_magic_quotes_gpc
Thanks to Bishop Bettini for the original patch.
2016-09-01 14:58:29 +08:00
David Monllao 5c33a0db21 weekly release 3.2dev 2016-09-01 11:14:03 +08:00
David Monllao c067ae4f33 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-09-01 11:14:01 +08:00
Adrian Greeve 93d3f310b0 MDL-55707 grades: Stop infinite loop when regrading. 2016-09-01 10:25:13 +08:00
Dan Marsden 5d453ff40e MDL-55820 scorm: use correct displayattempt default options 2016-09-01 13:19:35 +12:00
Marina Glancy 6f9f8b59fa MDL-55665 charts: correction to stacked bar charts 2016-09-01 09:17:36 +08:00
Tim Hunt d0f8daef12 MDL-55815 quiz review: after close should beat immediately after
This only arises in specific situations: student submitted less than 2
mintues before time close, or when a teacher previews after the close
date. However, in those cases, the old behaviour was confusing. Now,
'After the quiz is closed' takes priority.
2016-08-31 12:55:21 +01:00
Tim Hunt daf6becfb0 MDL-55815 quiz: convert attempt state tests to a data provider 2016-08-31 12:54:18 +01:00
David Monllao f038a3e670 Merge branch 'wip-MDL-38105-master' of https://github.com/marinaglancy/moodle 2016-08-31 09:57:31 +08:00
Rajesh Taneja 31c8fd3e83 MDL-55766 behat: set core behat selectors if not overridden by theme 2016-08-31 07:23:13 +08:00
Eloy Lafuente (stronk7) 4bdb1298c4 Merge branch 'MDL-55237_master' of git://github.com/dmonllao/moodle 2016-08-30 12:54:46 +02:00
sam marshall 3bf0482841 MDL-55724 Glossary: Prevent infinite loop in trusttext_strip 2016-08-30 10:25:38 +01:00
David Monllao dacfc6f816 Merge branch 'MDL-55372-master' of git://github.com/danpoltawski/moodle 2016-08-30 16:38:18 +08:00
David Monllao 7db19614f0 Merge branch 'MDL-55452-master' of git://github.com/danpoltawski/moodle 2016-08-30 16:25:28 +08:00
Marina Glancy dfc261be66 MDL-38105 gradingform_rubric: option to lock 0 level for rubrics
this also allows using negative scores
2016-08-30 14:55:43 +08:00
Mark Nelson 8354d12d39 MDL-55771 core: added title attribute when using JS to render {{pix}} 2016-08-30 14:49:44 +08:00
Rajesh Taneja b9b1ca9ed1 MDL-55759 behat: No profile guided alloaction in phpunit 2016-08-30 14:49:08 +08:00
Marina Glancy 0df9dce716 MDL-55581 htmlpurifier: test for attributes in video tag 2016-08-30 13:44:13 +08:00
David Monllao bb75b82e21 Merge branch 'MDL-54873-master' of git://github.com/andrewnicols/moodle 2016-08-30 12:52:38 +08:00
Andrew Nicols 5e171c6986 MDL-54873 assign: Seed recordid to print_recent_activity 2016-08-30 11:57:57 +08:00
Andrew Nicols c06ce32d85 MDL-54873 assign: Add recordid fetching participants
get_submission_info_for_participants is primarily used by externallib.php
2016-08-30 11:46:21 +08:00
Andrew Nicols cf29b1e08d MDL-54873 assign: Fetch mapping id for blind marking in cron 2016-08-30 11:46:20 +08:00
Andrew Nicols 4ed4be4988 MDL-54873 assign: Fetch mapping id for blind marking grading
This change modifies the grading table to pre-seed record ids where they
already exist.

Where they do not exist, they are still fetched.
2016-08-30 11:46:20 +08:00
Frederic Massart e5e2f39ed5 MDL-55663 filter: Filters could be incorrectly reported as inactive 2016-08-30 11:22:53 +08:00
David Monllao 8bee2d8df6 MDL-55237 core_component: Fix last namespace level matching
Thanks to Andreas Grabs for proposing a fix.
2016-08-30 11:15:27 +08:00
Eloy Lafuente (stronk7) e6166d9bf7 Merge branch 'MDL-53634-master' of git://github.com/andrewnicols/moodle 2016-08-30 02:28:32 +02:00
Rajesh Taneja cc0ac30488 MDL-55764 behat: Reset static update db list
While running multiple suites we should
ensure static cli cache is also reset.
2016-08-30 08:00:01 +08:00
Eloy Lafuente (stronk7) ba982fef66 Merge branch 'MDL-55660-master-tablesql' of git://github.com/mudrd8mz/moodle 2016-08-29 18:59:13 +02:00
AMOS bot 25d3cf24c5 Automatically generated installer lang files 2016-08-30 00:04:47 +08:00
Eloy Lafuente (stronk7) ff536f4b37 Merge branch 'MDL-55667-master-participantslink' of git://github.com/mudrd8mz/moodle 2016-08-29 16:53:46 +02:00
Eloy Lafuente (stronk7) b5776e1b9f Merge branch 'MDL-55741' of git://github.com/timhunt/moodle 2016-08-29 14:08:37 +02:00
Cameron Ball 0f826e9f36 MDL-55587 core_media: Properly escape ampersand 2016-08-29 19:16:01 +08:00
David Mudrák 57b81c93f5 MDL-55667 navigation: Do not display site participants link to students
The problem here was that user/index.php checks the system level
capability moodle/site:viewparticipants when the user is on the front
page, and the moodle/course:viewparticipants on non-front pages.

But the navigation displayed the link by mistake even in situations,
when the user has the capability moodle/course:viewparticipants on the
front page (typically when the default role for the front page is set to
student).

Added behat tests for reproducing the bug and also for checking the
basic functionality of the feature.
2016-08-29 12:11:46 +02:00
David Monllao c2df528806 Merge branch 'wip-MDL-55581-master' of git://github.com/marinaglancy/moodle 2016-08-29 16:53:46 +08:00
David Monllao 6893691b34 Merge branch 'MDL-55710-master' of git://github.com/lameze/moodle 2016-08-29 14:48:54 +08:00
David Monllao ea012c47b5 Merge branch 'MDL-55650-master' of https://github.com/sammarshallou/moodle 2016-08-29 14:42:55 +08:00
David Monllao a74218d464 Merge branch 'MDL-55661-master-enfix' of git://github.com/mudrd8mz/moodle 2016-08-29 14:40:03 +08:00
David Monllao 351081b06d Merge branch 'MDL-55312_load_timeout_for_amd_modules_master' of https://github.com/gthomas2/moodle 2016-08-29 14:31:11 +08:00
David Monllao b197b33564 Merge branch 'MDL-55665-master' of git://github.com/lameze/moodle 2016-08-29 13:26:28 +08:00
Marina Glancy 28e27ac837 MDL-55581 htmlpurifier: allow track tag in videos and audios 2016-08-29 13:25:10 +08:00
David Monllao bc1ac4a89d Merge branch 'wip-MDL-55708-master' of git://github.com/marinaglancy/moodle 2016-08-29 11:18:58 +08:00
David Monllao af1cacb586 Merge branch 'MDL-55477' of git://github.com/timhunt/moodle 2016-08-29 11:14:11 +08:00
David Monllao 80e31fdeaa Merge branch 'MDL-55668-master' of git://github.com/danpoltawski/moodle 2016-08-29 10:26:51 +08:00
Tim Hunt 972a367b98 MDL-55741 phpunit: does not reset get_log_manager cache 2016-08-26 17:14:17 +01:00
AMOS bot 3602db85e2 Automatically generated installer lang files 2016-08-27 00:04:38 +08:00
Dan Poltawski 6bb410c32e MDL-55372 stylelint: fully replace csslint
Remove the csslint config, remove an invalid property.

Kept csslint ignore lines becacase stylelint seems to respect them and
more work will be happening on css cleanup in MDL-55372.
2016-08-26 11:09:11 +01:00
Dan Poltawski eb69520763 MDL-55452 stylelint: prevent use of !important
Don't try and fix existing issues, just prevent new ones landing..
2016-08-26 11:08:14 +01:00
Andrew Nicols c42c23557e MDL-53634 forum: Switch digest selection to inplace_editable 2016-08-26 15:05:05 +08:00
Simey Lameze b02e738c4f MDL-55710 core: Add support for doughnut charts 2016-08-26 13:30:02 +08:00
Simey Lameze c574995dde MDL-55665 core: Add support for stacked bar charts 2016-08-26 13:30:01 +08:00
Dan Poltawski 35d5053ba2 weekly release 3.2dev 2016-08-25 16:07:36 +01:00
Dan Poltawski 05fd5c4d34 MDL-55072 tests: work around reset bug 2016-08-25 16:04:42 +01:00
Helen Foster b61b927356 MDL-55661 lang: Merge English strings from the en_fix language pack 2016-08-25 14:38:07 +02:00
Dan Poltawski 4c0385d5db weekly release 3.2dev 2016-08-25 12:09:35 +01:00
Dan Poltawski bcec0c3e0c Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-08-25 12:09:33 +01:00
Dan Poltawski baa5375a0c Merge branch 'MDL-55127_master-fix-everything' of git://github.com/dmonllao/moodle 2016-08-25 10:26:21 +01:00
David Monllao fa90f52986 MDL-55127 mod_data: Search entries fixes
- If the database contains has than 4 valid fields all fields from the 4th one
  to the last one will be merged into the 4th one so we index all entry contents
- get_content_value now receives the whole data_content record as fields may need
  other values than just the content to prepare the value
- phpunit database generator changes to separate checkboxes from radio buttons options
  and to separate multimenu options from menu options
2016-08-25 16:50:15 +08:00
Mark Nelson c0abfdabb4 MDL-55717 core: add 'ignoredirty' class to inplace editable 2016-08-25 16:01:53 +08:00
Dan Poltawski c52d34b255 Merge branch 'MDL-55320-master-fix2' of https://github.com/lameze/moodle 2016-08-25 08:07:31 +01:00
Simey Lameze 787a4da9f1 MDL-55320 core: Add generaltable class to chart data table 2016-08-25 14:38:36 +08:00
David Monllao 195288fb97 Merge branch 'wip-mdl-55072-fix' of git://github.com/rajeshtaneja/moodle 2016-08-25 10:58:01 +08:00
Simey Lameze a5ee89f817 MDL-55665 core: Add support for stacked bar charts 2016-08-25 10:37:20 +08:00
Rajesh Taneja cb5949e3f0 MDL-46514 behat: Get config value from db, to avoid cache 2016-08-25 10:33:32 +08:00
Marina Glancy 92c9be1978 MDL-55708 mod_assign: display formatted acitvity names 2016-08-25 09:53:29 +08:00
Rajesh Taneja 6c1cc55d92 MDL-55072 behat: Cache themesuite and theme contexts 2016-08-25 09:17:38 +08:00
Rajesh Taneja 14f3abee2e MDL-55072 behat: Changed option to run-with-theme 2016-08-25 08:36:08 +08:00
AMOS bot 587089a516 Automatically generated installer lang files 2016-08-25 00:05:02 +08:00
Damyon Wiese 43b0df2601 MDL-55668 assign: Don't link to user profile if blind marking is enabled 2016-08-24 11:21:31 +01:00
Dan Poltawski c46077284a Merge branch 'MDL-55320-fix' of https://github.com/lameze/moodle 2016-08-24 08:20:57 +01:00
Simey Lameze 21575ea31c MDL-55320 theme: remove unnecessary styling 2016-08-24 14:27:39 +08:00
Andrew Nicols 8497f5ece9 Merge branch 'MDL-55127_master-fix-requires' of git://github.com/dmonllao/moodle 2016-08-24 14:04:07 +08:00
David Monllao 70003837db MDL-55127 mod_data: Adding missing required classes 2016-08-24 13:57:44 +08:00
Rajesh Taneja 3037458049 MDL-55072 behat: Fixed behat_selectors to be removed from contexts 2016-08-24 13:24:34 +08:00
Andrew Nicols f42288ea62 MDL-54113 assign: Open files in new window
Open files in a new window when viewing to ensure that the form change
checker does not warn about the page reloading.
2016-08-24 11:33:09 +08:00
David Monllao 4b5e0c542a MDL-55604 cache: Updating comment according to code changes 2016-08-24 09:39:15 +08:00
David Monllao 086ef7d418 Merge branch 'MDL-55604' of https://github.com/mr-russ/moodle 2016-08-24 09:35:39 +08:00
David Monllao 30daa61475 Merge branch 'wip-mdl-55072' of https://github.com/rajeshtaneja/moodle 2016-08-24 09:26:29 +08:00
Russell Smith 7ff43e1acf MDL-55604 cache: Fix identifier and cacheable_object
When a cachable object is store in the static cache from
the backing store, it was incorrect serialised rather than
using the wake function.  This has been resolved and tests added.

During the investigation into cacheable_object, it was discovered
that set_identifiers never removes identifiers when you call it,
so set_identifiers(array('a')) and set_identifiers(array('b')) really
resulted in array('a','b') as the identifiers rather than 'b'.

The fix for this issue depends on the set_identifiers fix and
they have been coupled together as a result.
2016-08-24 11:26:20 +10:00
Rajesh Taneja b4bc4286bb MDL-55072 behat: Allow behat_selectors to be overridden
if theme/tests/behat/behat_theme_{THEME_NAME}_behat_selectors.php
file exits, and has class with same file name then we will
call behat_theme_{THEME_NAME}_behat_selectors::register_moodle_selectors()
to register theme specific selectors. If they are different
then core then they will override
2016-08-24 09:13:13 +08:00
Rajesh Taneja 5aa9b5cee3 MDL-55072 behat: Added support for overriding theme tests 2016-08-24 08:57:15 +08:00
David Monllao bae868b903 Merge branch 'MDL-55385_master' of https://github.com/marxjohnson/moodle 2016-08-24 08:24:21 +08:00
gthomas2 16ddfd5fc2 MDL-55312 requirejs: Fix timeouts with infinite waitSeconds 2016-08-23 17:48:35 +01:00
Dan Poltawski 28b606819b Merge branch 'MDL-55628-master' of https://github.com/sammarshallou/moodle 2016-08-23 15:48:11 +01:00
Dan Poltawski 13b3bf6cd5 MDL-55423 tests: remove non-cross-db testcase
This isn't used in moodle core and is problematic on oracle, don't test
it.
2016-08-23 12:36:28 +01:00
Mark Johnson e1093c7fa8 MDL-55385 output: Support non-integer output_buffering values 2016-08-23 11:19:04 +01:00
Dan Poltawski 7c085e1a2d Merge branch 'wip-MDL-55127_master' of https://github.com/dg711/moodle 2016-08-23 11:12:46 +01:00
Andrew Nicols f71df007d1 MDL-46654 mod_forum: Reduce complexity of closure 2016-08-23 16:17:07 +08:00
Dan Poltawski 3f92140fc8 Merge branch 'wip-mdl-46514' of https://github.com/rajeshtaneja/moodle 2016-08-23 08:59:24 +01:00
David Monllao 86d6ff2dc8 Merge branch 'MDL-46654-master' of git://github.com/andrewnicols/moodle 2016-08-23 15:30:54 +08:00
Dan Poltawski 0969f0da5b Merge branch 'MDL-48773_m32v1' of https://github.com/sbourget/moodle 2016-08-23 08:18:16 +01:00
Rajesh Taneja bdcd90b2f3 MDL-46514 behat: section should be set before switch-case 2016-08-23 15:14:39 +08:00
Rajesh Taneja 0c1bcb63c6 MDL-46514 behat: Catch php errors in shutdown hook
If error is not displayed in web browser then
it will be caught in shutdown hook, so we can
show it to user
2016-08-23 15:14:38 +08:00
David Monllao 132b75d067 Merge branch 'MDL-55391-master' of git://github.com/danpoltawski/moodle 2016-08-23 13:24:29 +08:00
David Monllao bab59f1c08 Merge branch 'MDL-54838-master' of https://github.com/nashtechdev01/moodle 2016-08-23 12:42:52 +08:00
sam marshall 5c2ef08fa3 MDL-55628 Completion: Use simpledata for completion cache
The completion cache is currently not marked as simpledata. On the
course page it is frequently retrieved hundreds of times which results
in many calls to the slow unserialize function. By making a slight
change to the data format (using arrays instead of objects) we can
mark it as simpledata, which will avoid using unserialize.
2016-08-22 17:13:36 +01:00
sam marshall b16b1f86b1 MDL-55650 Library: s() function - tweak parameters for performance
The s() function includes a comment saying that parameter options
should be modified to improve performance once PHP 5.4 is required.
Since Moodle has required PHP 5.4 for some time, we should probably
make the change and remove the comment.

According to my benchmarking, these changes make s() about 7% faster
and will save a staggering 2ms from a typical course view that calls
it 8,000 times.
2016-08-22 15:38:13 +01:00
David Mudrák 4e96165e59 MDL-55660 tablelib: Fetch only a single row when auto defining columns
In a very rare cases where the columns are not declared explicitly, we
want to fetch single row only without a warning raised. This seems like
a valid use case for IGNORE_MULTIPLE flag.
2016-08-22 16:34:13 +02:00
Dan Poltawski 080f292ed7 Merge branch 'MDL-55273-cookie-secure-default' of https://github.com/brendanheywood/moodle 2016-08-22 15:25:15 +01:00
Dan Poltawski c1d5d922a8 Merge branch 'MDL-55320-master' of git://github.com/lameze/moodle 2016-08-22 15:20:17 +01:00
Dan Poltawski 42def6ef5c Merge branch 'MDL-55565-master' of https://github.com/snake/moodle 2016-08-22 14:22:38 +01:00
Dan Poltawski 4ac1bb2f34 Merge branch 'MDL-55605-lesson-restore-bug' of https://github.com/kenneth-hendricks/moodle 2016-08-22 14:13:26 +01:00
Dan Poltawski 74a53156d6 Merge branch 'MDL-55551_m32v1' of https://github.com/sbourget/moodle 2016-08-22 12:53:31 +01:00
Dan Poltawski 293857b5eb Merge branch 'MDL-55557_m32v1' of https://github.com/sbourget/moodle 2016-08-22 12:45:18 +01:00
Dan Poltawski 6f9f149b04 MDL-44712 scorm: make upgrade match install.xml defintion 2016-08-22 12:40:03 +01:00
Andrew Nicols 8381ac52cd MDL-46654 mod_forum: Remove irrelevant digest/subscribe options
If the user cannot subscribe, there is no point showing the digest options.
2016-08-22 19:12:20 +08:00
Andrew Nicols d6c05ad1f1 MDL-46654 mod_forum: Hide digestoptions when no subscription
Daily digest options should not be generated if the user cannot subscribe
to anything in the first place.
2016-08-22 19:06:06 +08:00
Dan Poltawski cfbba4a94c Merge branch 'MDL-54864-master' of https://github.com/snake/moodle 2016-08-22 11:19:32 +01:00
Dan Poltawski ccee2dc2c5 MDL-44712 readme: fix trailing whitespace 2016-08-22 10:51:34 +01:00
Dan Poltawski 4d67694b10 Merge branch 'master_MDL-44712' of git://github.com/danmarsden/moodle 2016-08-22 10:33:31 +01:00
Dan Poltawski a55ff4d9fe Merge branch 'MDL_55423_master' of https://github.com/alexandru-elisei/moodle 2016-08-22 09:26:28 +01:00
Dan Poltawski cf6ae1205e Merge branch 'wip-MDL-22183-master' of git://github.com/abgreeve/moodle 2016-08-22 09:19:59 +01:00
Jake Dallimore d7d4a09707 MDL-54864 core_question: Enforce context,stamp uniqueness for category
Added an upgrade step to remove duplicate stamps, added a unique index
on (contextid, stamp) and modified the question_category edit code such
that stamp duplication in the same context is not permitted.
2016-08-22 09:44:52 +08:00
Brendan Heywood 657ddbf592 MDL-55273 admin: Change $CFG->cookiesecure default to on 2016-08-22 09:20:32 +10:00
Tim Hunt 12a725be10 MDL-55477 quiz reports: all user fields should have repeats suppressed 2016-08-19 18:04:51 +01:00
Dan Poltawski 217ef85633 MDL-55391 block_rss: fix typo preventing feed title display 2016-08-19 09:43:32 +01:00
Devang Gaur 2af9ad7d30 MDL-55127 mod_data: added database entries to globalsearch 2016-08-19 13:58:19 +05:30
An Pham Van d0207fdc06 MDL-54838 workshop: Differentiate labels for each comment field.
In a Workshop activity, comment fields on Assessment forms do not properly link to the corresponding Aspect.
So screen reader users may find it difficult to complete the Assessment forms.
There should be a hidden label text for each comment field.
2016-08-19 13:44:19 +07:00
Andrew Nicols 2e48384dea MDL-55632 mod_forum: Tidy up forum post messages 2016-08-19 09:38:57 +08:00
Rajesh Taneja e99f0cbba6 MDL-55072 behat: refactor behat_config_manager 2016-08-19 06:49:13 +08:00
Rajesh Taneja 39eb8abe15 MDL-46514 behat: Delete tablesupdatedbyscenario before suite
Delete tablesupdatedbyscenario before db reset to ensure
db is fully reset. In case user exits or process terminated
then the file will be left and can lead to wrong results
2016-08-19 06:46:27 +08:00
Rajesh Taneja 43759f5e23 MDL-46514 behat: Catch errors shown by JS 2016-08-19 06:46:27 +08:00
Kenneth Hendricks 504b65d2e5 MDL-55605 mod_lesson: Fix activitylinks restore bug 2016-08-18 16:35:34 +10:00
Jake Dallimore d8e73d61b9 MDL-55565 core_backup: Fix warning when restoring question categories
Fixed a call to get_records_sql, which was being used incorrectly in
restore_find_best_target_context to determine a unique contextid.
2016-08-18 10:15:51 +08:00
Adrian Greeve 3b873397e6 MDL-22183 lib: More unit tests for next day start. 2016-08-18 10:13:31 +08:00
Adrian Greeve 3cdc35b44d MDL-22183 lib: Cleanup of get_next functions. 2016-08-18 10:13:31 +08:00
Adrian Greeve 4ae0691169 MDL-22183 lib: Time settings removed for stats cron.
Old settings that should be ignored have been removed from the
statistics cron code.
2016-08-18 10:13:31 +08:00
Dan Marsden b30a884bfa MDL-44712 SCORM: Improve multi-sco activity completion. 2016-08-18 10:14:40 +12:00
Alexandru Elisei 03856ac5e8 MDL-55423 accesslib: Prevent get_role_users() false debugging messages 2016-08-17 20:43:39 +03:00
Dan Poltawski 3ca3cc77a2 weekly release 3.2dev 2016-08-17 14:47:04 +01:00
Dan Poltawski 40a952bf0f MDL-55585 bump versions 2016-08-17 12:12:00 +01:00
Dan Poltawski e3c9de6831 Merge branch 'MDL-55585_master' of git://github.com/dmonllao/moodle 2016-08-17 12:10:22 +01:00
Andrew Nicols 5019f9fd79 Merge branch 'wip-MDL-50586-master-fix' of https://github.com/marinaglancy/moodle 2016-08-17 13:22:50 +08:00
Marina Glancy a87b2d70ec MDL-50586 gradingform_rubric: 0-level warning during redirection 2016-08-17 12:59:02 +08:00
Andrew Nicols 72d088f229 Merge branch 'MDL-54973_master-fix' of git://github.com/dmonllao/moodle 2016-08-17 12:57:41 +08:00
David Monllao df762928f6 MDL-54973 message: Taking care of support and noreply users on search 2016-08-17 12:41:48 +08:00
Andrew Nicols b4bb1e65dc Merge branch 'MDL-55445-master-2nd' of git://github.com/FMCorz/moodle 2016-08-17 11:25:24 +08:00
Frederic Massart aa6b41293f MDL-55445 theme: Clean and More automatically use the branding logos
But in order to maintain smooth backwards compatibility, the logos
set in the themes themselves take precedence.
2016-08-17 10:26:31 +08:00
Frederic Massart 2258b4dc41 MDL-55445 core: New setting to host the logos 2016-08-17 10:26:31 +08:00
Frederic Massart 19efee14e2 MDL-55445 files: Helper functions related to serving and caching
The function send_content_uncached() is meant to be used when serving
content which should not be cached by browsers/proxies. You will
use this in development mode, or when the request is malformed
but you need to return some fallback content which shouldn't be stored
under the URL it was requested from.

The function file_safe_save_content() should only be used for content
not stored in the file API. Good candidates for this are resource
which fit well in the localcache. The function tries to write the
content in the most atomic way as possible to prevent incomplete
writes or concurrent writes.
2016-08-17 10:26:10 +08:00
Dan Poltawski 5fb09e48ce Merge branch 'MDL-55130-master' of git://github.com/crazyserver/moodle 2016-08-16 12:48:00 +01:00
Dan Poltawski d6e7b38844 Merge branch 'MDL-36713_m32v2' of https://github.com/sbourget/moodle 2016-08-16 12:04:18 +01:00
David Monllao 0c417cdc5c MDL-55585 search: Remove missing report/search file 2016-08-16 17:50:19 +08:00
Andrew Nicols 9d8a3055c0 Merge branch 'MDL-55272' of https://github.com/mr-russ/moodle 2016-08-16 14:55:49 +08:00
Andrew Nicols ccfd62a1ca MDL-54680 enrol_lti: Coding Style fixes 2016-08-16 14:48:17 +08:00
Andrew Nicols 88a0cdada4 Merge branch 'MDL-54680-master' of https://github.com/xow/moodle 2016-08-16 14:45:33 +08:00
John Okely 3e9ab40361 MDL-54680 enrol_lti: Offer cartridges in LTI provider 2016-08-16 14:15:02 +08:00
Damyon Wiese bb0b39b839 MDL-55520 forms: Properly format the grademax for the database 2016-08-16 11:19:51 +08:00
Andrew Nicols c544236647 Merge branch 'wip-MDL-18592-fix' of git://github.com/marinaglancy/moodle 2016-08-16 10:47:53 +08:00
Marina Glancy f32a984db7 MDL-18592 mod_choice: deprecate incorrect events 2016-08-16 10:43:54 +08:00
Russell Smith 6a3acc84de MDL-55272 lib: Improve test course create performance
Use core functions that are faster for test file creation.
To support large requests for hashes, the core hash function
must support large hashes without recursion.  PHP has a default
recursion depth of 100 and long hashes don't support this.

Remove transactions as they create performance problems for larger
courses and doesn't introduce significant benefit for developers.

Performance changes meant the times were much faster, a reasonable
guess was taken on performance of an average machine.
2016-08-16 12:00:21 +10:00
Stephen Bourget 67a1f63913 MDL-36713 Blog: Display accurate error when a guest views a user blog 2016-08-15 21:46:48 -04:00
Simey Lameze ff80d062de MDL-55320 theme: Fix chat data table alignment 2016-08-16 09:35:21 +08:00
Andrew Nicols 6677f64f8c Merge branch 'wip-MDL-50586-master' of git://github.com/marinaglancy/moodle 2016-08-16 08:52:17 +08:00
Andrew Nicols 1824951eef Merge branch 'MDL-54973_master' of https://github.com/dg711/moodle 2016-08-16 08:21:13 +08:00
Andrew Nicols e144182592 MDL-54647 tests: Clarify unoconv tests 2016-08-16 08:11:13 +08:00
Andrew Nicols 0a0eaa7dfc Merge branch 'MDL-54647-master' of git://github.com/damyon/moodle 2016-08-16 08:01:47 +08:00
Dan Poltawski c6970e9c16 Merge branch 'MDL-18592-master' of git://github.com/marinaglancy/moodle 2016-08-15 14:27:34 +01:00
Pau Ferrer Ocaña c13c21b9b5 MDL-55130 wiki: Reduce data usage when only renew lock is needed. 2016-08-15 14:40:38 +02:00
Dan Poltawski 8d37a33b16 Merge branch 'wip-MDL-55494-master' of git://github.com/marinaglancy/moodle 2016-08-15 13:15:15 +01:00
Dan Poltawski fb8723d9f5 MDL-52105 enrol_self: fix upgrade savepoint 2016-08-15 12:12:24 +01:00
Dan Poltawski 16d7b6b133 Merge branch 'MDL-55196_master' of https://github.com/andrewhancox/moodle 2016-08-15 12:00:47 +01:00
Dan Poltawski 338fd5dd57 Merge branch 'wip-MDL-55366-master' of git://github.com/abgreeve/moodle 2016-08-15 11:44:09 +01:00
Dan Poltawski e4346dad32 Merge branch 'wip-mdl-55380' of https://github.com/rajeshtaneja/moodle 2016-08-15 11:38:34 +01:00
Dan Poltawski 2595cb58c9 Merge branch 'wip-MDL-55397-master' of git://github.com/marinaglancy/moodle 2016-08-15 11:35:35 +01:00
Dan Poltawski 5e17cd21aa Merge branch 'MDL-52105-master' of git://github.com/lameze/moodle 2016-08-15 11:13:27 +01:00
Dan Poltawski 21b6554e2a Merge branch 'MDL-55533_multiresponse_feedback' of git://github.com/davosmith/moodle 2016-08-15 11:09:51 +01:00
Dan Poltawski 623f92f9f7 Merge branch 'MDL-46214-master' of git://github.com/andrewnicols/moodle 2016-08-15 09:47:02 +01:00
Damyon Wiese 36ba9c3e76 MDL-54647 tests: Reverse order of expected and actual 2016-08-15 16:34:11 +08:00
Damyon Wiese 300852ee30 MDL-54647 file_storage: Redo the test pdf every time it's viewed 2016-08-15 16:32:21 +08:00
Andrew Nicols 40cc0ba04e Merge branch 'MDL-55513-master' of https://github.com/lucisgit/moodle 2016-08-15 14:07:41 +08:00
Devang Gaur 26c0d75f3e MDL-54973 message: added messages to globalsearch 2016-08-15 11:27:25 +05:30
Simey Lameze 6fdd61a073 MDL-52105 enrol_self: Behat test for key holder feature 2016-08-15 12:56:52 +08:00
Simey Lameze 33b6da5327 MDL-52105 enrol_self: Fix wrong holdkey cap restriction for manager
This commit add an upgrade step to remove wrong CAP_PROHIBIT on enrol/self:holdkey for manager role.
Also remove the restriction from the self enrolment access file.
2016-08-15 12:56:51 +08:00
Andrew Nicols c470716854 Merge branch 'MDL-55229-master' of git://github.com/lameze/moodle 2016-08-15 12:18:19 +08:00
Andrew Nicols 098aad4f72 Merge branch 'MDL-55520-master' of git://github.com/damyon/moodle 2016-08-15 10:58:39 +08:00
Frederic Massart 0eb97bfa13 MDL-55445 files: Support for cacheability in send_file() 2016-08-15 10:54:29 +08:00
Frederic Massart 92b9ef9917 MDL-55445 gdlib: Support for resizing an image 2016-08-15 10:54:28 +08:00
Adrian Greeve bd576de814 MDL-55366 mod_lesson: Fix warning with TF page.
Having an image in the answer text would create a warning.
2016-08-15 10:17:41 +08:00
Andrew Nicols 62192d93ea MDL-46214 event: Mark previously deprecated events as deprecated 2016-08-15 09:17:02 +08:00
Andrew Nicols 51d85c7c6c MDL-46214 event: Support deprecation of events
This patch adds two new functions to the event base to allow deprecation of
the individual events, without entirely removing them from the UI.

This is different to our normal deprecation procedure because all events
must support display of historical data. It must also be possible to view
the event information in the event monitor.
2016-08-15 09:17:02 +08:00
Stephen Bourget 6ffb8fa21a MDL-55557 mod_wiki: Add missing MOODLE_INTERNAL checks 2016-08-13 21:40:41 -04:00
Stephen Bourget f12d9aa801 MDL-55551 Blog: Add missing MOODLE_INTERNAL check. 2016-08-12 20:16:04 -04:00
Marina Glancy d29a07030e MDL-55494 report_eventlist: ignore only logstore_legacy 2016-08-12 13:55:38 +08:00
Marina Glancy 951f77006a MDL-55494 tool_monitor: ignore only tool_monitor and logstore_legacy
previously any plugin type ending with _monitor or _legacy would be ignored
2016-08-12 13:40:28 +08:00
Marina Glancy 3d91ad9946 MDL-50586 gradingform_rubric: warn about missing 0-points levels 2016-08-12 13:25:54 +08:00
Rajesh Taneja 39515ba566 MDL-55380 behat: Fixed shared stats definition
Stats definition was being shared between
progress and moodle_progress format which
was causing double counting. Now they both
have there own stats counter definitions
2016-08-12 10:17:00 +08:00
Stephen Bourget dddadf5357 MDL-48773 mod_choice: Lock number of responses if selections are made. 2016-08-11 22:11:57 -04:00
Stephen Bourget 2ce8cf628f MDL-55239 Badges: Additional events for badges 2016-08-11 21:16:35 -04:00
Davo Smith a7b72fb291 MDL-55533 qtype_multianswer: fix feedback for multiresponse 2016-08-11 14:13:58 +01:00
Damyon Wiese a95014f5b4 MDL-55520 assign: Behat test for rescaling max grades bug
Verify the max grade is not silently changed back to 100 when you visit
and save the assignment settings form.
2016-08-11 15:13:31 +08:00
Damyon Wiese c3d4d3f7c1 MDL-55520 forms: Mod grade is changing values back to default
When a field is disabled in the page - no value is sent and modgrade is reverting
to the default. This change prevents the max grade from changing accidentally.
2016-08-11 14:43:05 +08:00
Andrew Nicols 6f302b17b9 weekly release 3.2dev 2016-08-11 13:17:01 +08:00
Andrew Nicols e8bfc39d07 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-08-11 13:16:58 +08:00
Tony Butler 2ee668ec56 MDL-55513 core_filestorage: Touch and test size instead of file_exists()
file_exists() can return false when file exists (in certain scenarios)
2016-08-10 09:35:23 +01:00
Tony Butler e98483d748 MDL-55513 core_filestorage: Pass full path of temp dir to remove_dir() 2016-08-10 09:35:23 +01:00
Andrew Nicols 0b490a1091 Merge branch 'MDL-41126_master' of git://github.com/dg711/moodle 2016-08-10 12:25:45 +08:00
Devang Gaur 2ac7ea8670 MDL-41126 mod_data: optimised data entry generator 2016-08-10 07:58:12 +05:30
Andrew Nicols 431a82bd8d MDL-55333 mod_feedback: Correct constant name 2016-08-10 10:13:07 +08:00
Andrew Nicols 82e025f7e3 Merge branch 'wip-MDL-55333-master' of git://github.com/marinaglancy/moodle 2016-08-10 10:01:05 +08:00
Simey Lameze 6b7a8e6682 MDL-55229 course: Handle invisible course categories 2016-08-10 09:54:17 +08:00
Andrew Nicols c3efb495fd Merge branch 'wip-mdl-52230' of https://github.com/rajeshtaneja/moodle 2016-08-10 09:53:24 +08:00
Rajesh Taneja b68de8cfe7 MDL-52230 mod_data: Fixed fieldname key for number field
AMOS BEGIN
 MOV [namedate, mod_data],[fieldtypelabel, datafield_date]
 MOV [namefile, mod_data],[fieldtypelabel, datafield_file]
 MOV [namecheckbox, mod_data],[fieldtypelabel, datafield_checkbox]
 MOV [namelatlong, mod_data],[fieldtypelabel, datafield_latlong]
 MOV [namemenu, mod_data],[fieldtypelabel, datafield_menu]
 MOV [namemultimenu, mod_data],[fieldtypelabel, datafield_multimenu]
 MOV [namenumber, mod_data],[fieldtypelabel, datafield_number]
 MOV [namepicture, mod_data],[fieldtypelabel, datafield_picture]
 MOV [nameradiobutton, mod_data],[fieldtypelabel, datafield_radiobutton]
 MOV [nametext, mod_data],[fieldtypelabel, datafield_text]
 MOV [nametextarea, mod_data],[fieldtypelabel, datafield_textarea]
 MOV [nameurl, mod_data],[fieldtypelabel, datafield_url]
AMOS END
2016-08-10 09:50:21 +08:00
AMOS bot 8400590f9a Automatically generated installer lang files 2016-08-10 00:04:38 +08:00
Dan Poltawski 298dd2f074 Merge branch 'MDL-55464_m32v1' of https://github.com/sbourget/moodle 2016-08-09 14:20:31 +01:00
Dan Poltawski 017230d576 Merge branch 'MDL-53765-master' of git://github.com/junpataleta/moodle 2016-08-09 13:56:49 +01:00
Dan Poltawski f616fc1b50 Merge branch 'wip-MDL-55425-master' of git://github.com/marinaglancy/moodle 2016-08-09 10:58:40 +01:00
Dan Poltawski a9dbd914a0 Merge branch 'MDL-55246_unoconv' of https://github.com/Syxton/moodle 2016-08-09 10:11:13 +01:00
Andrew Hancox be8c6766fd MDL-55196 mod_data: Refactor import to use update_content function 2016-08-09 09:57:27 +01:00
Dan Poltawski c728048846 Merge branch 'wip-MDL-52230-master' of git://github.com/abgreeve/moodle 2016-08-09 09:49:38 +01:00
Dan Poltawski 6259952eb2 Merge branch 'MDL-54606' of https://github.com/mr-russ/moodle 2016-08-09 09:32:46 +01:00
Dan Poltawski 8eb15b447a Merge branch 'MDL-55390_master-fix' of git://github.com/dmonllao/moodle 2016-08-09 09:29:49 +01:00
Andrew Hancox 421b2d44fe MDL-52230 mod_data: Take fieldname from field:name()
AMOS BEGIN
 CPY [namedate, mod_data],[fieldtypelable, datafield_date]
 CPY [namefile, mod_data],[fieldtypelable, datafield_file]
 CPY [namecheckbox, mod_data],[fieldtypelable, datafield_checkbox]
 CPY [namelatlong, mod_data],[fieldtypelable, datafield_latlong]
 CPY [namemenu, mod_data],[fieldtypelable, datafield_menu]
 CPY [namemultimenu, mod_data],[fieldtypelable, datafield_multimenu]
 CPY [namenumber, mod_data],[fieldtypelable, datafield_number]
 CPY [namepicture, mod_data],[fieldtypelable, datafield_picture]
 CPY [nameradiobutton, mod_data],[fieldtypelable, datafield_radiobutton]
 CPY [nametext, mod_data],[fieldtypelable, datafield_text]
 CPY [nametextarea, mod_data],[fieldtypelable, datafield_textarea]
 CPY [nameurl, mod_data],[fieldtypelable, datafield_url]
AMOS END
2016-08-09 16:22:00 +08:00
Dan Poltawski 372dd3711e Merge branch 'MDL-55225-master' of git://github.com/dpalou/moodle 2016-08-09 09:21:07 +01:00
Dan Poltawski 4aa5e355e6 MDL-51078 report_log: use simpler/faster str_split over preg_split 2016-08-09 09:04:31 +01:00
Dan Poltawski 4d31fc8444 Merge branch 'MDL-51078_m32v3' of https://github.com/sbourget/moodle 2016-08-09 08:57:09 +01:00
David Monllao f3d38863fe MDL-55390 search: is_search_area unit tests
Added extra checking for search manager get_search_area.
2016-08-09 15:51:30 +08:00
Dan Poltawski 05a9c36edc Merge branch 'MDL-54862-master' of git://github.com/dpalou/moodle 2016-08-09 08:06:35 +01:00
Andrew Nicols 5fa90114d7 MDL-55329 behat: Correct typo 2016-08-09 14:41:22 +08:00
Andrew Nicols 8173c3ef7f Merge branch 'wip-mdl-55329' of https://github.com/rajeshtaneja/moodle 2016-08-09 14:26:09 +08:00
Rajesh Taneja e259795c4f MDL-55329 behat: PyStrings should end with : (colon) 2016-08-09 14:22:21 +08:00
Andrew Nicols f1c6194f3d Merge branch 'MDL-55480-master' of git://github.com/FMCorz/moodle 2016-08-09 13:50:55 +08:00
Andrew Nicols 46c31069f3 MDL-55390 core_search: Correct variable name 2016-08-09 13:44:10 +08:00
Andrew Nicols aaf8d55a27 Merge branch 'MDL-55390' of https://github.com/dg711/moodle 2016-08-09 13:42:32 +08:00
Andrew Nicols 6c19db54f9 Merge branch 'MDL-53572-master' of git://github.com/danpoltawski/moodle 2016-08-09 12:52:13 +08:00
Andrew Nicols 19491e68fe MDL-41126 mod_data: Add type hinting 2016-08-09 12:49:01 +08:00
Andrew Nicols d5bd76f4e5 MDL-41126 mod_data: Styling fixes 2016-08-09 12:49:01 +08:00
Andrew Nicols 20195fb46a Merge branch 'wip-mdl-41126' of https://github.com/rajeshtaneja/moodle 2016-08-09 12:47:35 +08:00
Andrew Nicols 95a556c50a Merge branch 'MDL-55465-master' of git://github.com/danpoltawski/moodle 2016-08-09 12:31:46 +08:00
Andrew Nicols a5aa1b6b00 Merge branch 'MDL-53016-master' of https://github.com/xow/moodle 2016-08-09 11:41:09 +08:00
Jun Pataleta d3932d2b51 MDL-53765 core: Deprecate update_module_button functions
First stage deprecation for the functions update_module_button and
core_renderer::update_module_button().
2016-08-09 11:17:43 +08:00
Rajesh Taneja 9f2b916dee MDL_41126 phpunit: Timestamp should be less than 2038
http://php.net/manual/en/datetime.gettimestamp.php#114590
In 32-bit system the unix timestamp will overflow if the date goes beyond year 2038
and this method will return false.
2016-08-09 10:50:07 +08:00
Andrew Nicols 675345475d MDL-55274 mod_chat: Add unit tests for special commands 2016-08-09 10:44:08 +08:00
Rex Lorenzo 6a853f7521 MDL-53765 mod_resource/mod_wiki: Removed update_module_button() 2016-08-09 10:00:54 +08:00
Andrew Nicols fe88f065b7 Merge branch 'MDL-55274-master' of git://github.com/lameze/moodle 2016-08-09 09:05:09 +08:00
Dan Poltawski 763c5b0eb4 Merge branch 'MDL-48856' of https://github.com/mr-russ/moodle 2016-08-08 14:45:06 +01:00
Dan Poltawski 741bd4dfb7 Merge branch 'MDL-55061' of https://github.com/zanekarl17/moodle 2016-08-08 14:33:08 +01:00
Dan Poltawski 49924b335e Merge branch 'MDL-55398_m32v1' of https://github.com/sbourget/moodle 2016-08-08 10:40:42 +01:00
Dan Poltawski 0c4ccf73d9 Merge branch 'wip-MDL-55418-master' of https://github.com/marinaglancy/moodle 2016-08-08 10:33:46 +01:00
Dan Poltawski 1194324e80 Merge branch 'MDL-55453-master' of https://github.com/mrmark/moodle 2016-08-08 09:53:22 +01:00
Andrew Nicols 27a94d591d Merge branch 'MDL-55292' of https://github.com/mr-russ/moodle 2016-08-08 15:25:45 +08:00
Marina Glancy e96c826c3d MDL-55333 mod_feedback: work around MySQL tables in join limit 2016-08-08 14:40:27 +08:00
Marina Glancy 8676e7c3e0 MDL-18592 mod_choice: Allow teachers to make choice for students
Capability to delete reponses becomes capability to delete or modify
responses.

This also resolves MDL-51659 (incorrect events answer_submitted and
answer_updated) by deprecating them and replacing with the answer_created
2016-08-08 14:16:57 +08:00
Andrew Nicols be97f38188 Merge branch 'MDL-3782_multichoice_multiple' of git://github.com/davosmith/moodle 2016-08-08 14:04:53 +08:00
Andrew Nicols 6ab25fa0b2 Merge branch 'MDL-41126' of git://github.com/dg711/moodle 2016-08-08 13:24:25 +08:00
Nick Phillips 376be6ae86 MDL-55274 mod_chat: regain beep and / command in mod_chat.
format_text cannot be called on the whole input text, but must be
called on user-supplied text that will be output into chats. This
means it cannot simply be called in one place, but must instead be
called on the relevant parts of text once commands have been matched.
2016-08-08 12:30:33 +08:00
fhuebler 269bcf7e97 MDL-55480 competency: Added missing closing tag 2016-08-08 11:00:22 +08:00
Andrew Nicols e6ab38f3ca Merge branch 'MDL-55454' of git://github.com/timhunt/moodle 2016-08-08 10:00:30 +08:00
Dan Poltawski 70db37ba78 MDL-55465 grunt: ensure gruntfile is lint free
Not related to this patch, but fixed it while I was here..
2016-08-05 17:48:24 +01:00
Dan Poltawski a26d36738a MDL-55465 grunt: Add .stylelintignore
Allow it to be generated by grunt ignorefiles
Make grunt use it rather than ignoring things manually
2016-08-05 17:48:24 +01:00
AMOS bot ca0330bf8f Automatically generated installer lang files 2016-08-06 00:04:46 +08:00
Matt Davidson 826bb3547b MDL-55246 assign: convert files with spaces
If a file is sent to unoconv with a filename that contains spaces,
unoconv will fail to produce the intended results.
2016-08-05 08:14:20 -04:00
John Okely 64f631c128 MDL-53016 classloader: Load PSR-0 and PSR-4 separately, add unit tests 2016-08-05 10:11:52 +08:00
Dan Poltawski 91c07d06af MDL-53016 classloader: Load PSR-0 and PSR-4 namespaces dynamically 2016-08-05 10:11:52 +08:00
Marina Glancy e91b3e8282 MDL-55425 user: allow to update another user editor pref 2016-08-05 09:36:00 +08:00
Stephen Bourget 9f03fc3119 MDL-55464 mod_label: Add view permissions 2016-08-04 21:27:02 -04:00
Devang Gaur 400eb2d0e5 MDL-41126 mod_data: added field and entry generator 2016-08-05 04:08:50 +05:30
Devang Gaur 396d6f0a6e MDL-55390 core_search: check if a search area is real 2016-08-05 01:12:21 +05:30
Zane Karl 6db3b6d6a6 MDL-55061 Grade_Export: Grade Export Logging 2016-08-04 11:57:51 -07:00
Russell Smith 7f8a816a7d MDL-54606 session: Add redis handler with locking. 2016-08-04 21:50:11 +10:00
Russell Smith bdca62ac6d MDL-55292 performance: Allow Tideways profiler extension.
PHP7 doesn't have any default XHProf support and all other
investigated forks don't have stable PHP7.  Tideways is under
active development and is easy to install.  The data format
is compatible with XHProf so it is a drop-in replacement in that way.
2016-08-04 21:10:03 +10:00
Andrew Nicols 7752762674 weekly release 3.2dev 2016-08-04 09:58:40 +08:00
Andrew Nicols 30c7ec63df Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-08-04 09:58:34 +08:00
Rajesh Taneja 99ad3223a5 MDL-54656 behat: Skip test if db family is not mysql or postgres 2016-08-04 08:46:04 +08:00
Tim Hunt 0e9132e56e MDL-55454 quiz: loses shufflequestion setting restoring old backups 2016-08-03 18:42:51 +01:00
Mark Nielsen d900d61798 MDL-55453 core_lib: Fix usage of js_send_uncached 2016-08-03 10:18:41 -07:00
Davo Smith 946ab15c72 MDL-3782 qtype_multianswer: support 'multiple-answer' subquestions 2016-08-03 08:04:49 +01:00
Andrew Nicols d21942998c Merge branch 'MDL-55367-master-fix' of https://github.com/lameze/moodle 2016-08-03 14:41:47 +08:00
Andrew Nicols 0731226023 Merge branch 'MDL-54941-master-fixes' of https://github.com/andrewnicols/moodle 2016-08-03 14:35:08 +08:00
Andrew Nicols 1a354b81b6 MDL-54941 glossary: Correct variable naming for entry files 2016-08-03 14:33:53 +08:00
Simey Lameze e3df6df02e MDL-55367 report_log: declare log array indexes to avoid errors 2016-08-03 14:23:44 +08:00
Andrew Nicols 079e06adcd Merge branch 'MDL-55355-master-fix' of https://github.com/lameze/moodle 2016-08-03 10:45:15 +08:00
Simey Lameze 472ac2d390 MDL-55355 mod_feedback: Change show chart data step to avoid errors 2016-08-03 10:22:58 +08:00
Simey Lameze 14cc6df5f9 MDL-55355 core: Fix incorrect chart link selector 2016-08-03 10:21:48 +08:00
Eloy Lafuente (stronk7) 4a3a49353c Merge branch 'MDL-24343-master' of git://github.com/andrewnicols/moodle 2016-08-03 03:22:16 +02:00
Andrew Nicols 2c2f4f17c3 MDL-24343 core: Deprecate unzip_file 2016-08-03 09:05:55 +08:00
Eloy Lafuente (stronk7) f00780105c Merge branch 'MDL-55276-master' of git://github.com/junpataleta/moodle 2016-08-03 01:01:51 +02:00
Eloy Lafuente (stronk7) bc7817edab Merge branch 'MDL-54656_m32v3' of https://github.com/sbourget/moodle 2016-08-03 00:50:19 +02:00
Eloy Lafuente (stronk7) a9b1af901b Merge branch 'MDL-55166-master-blocksettings' of git://github.com/mudrd8mz/moodle 2016-08-03 00:33:58 +02:00
Eloy Lafuente (stronk7) 8c7840df32 Merge branch 'MDL-54941-master' of git://github.com/jleyva/moodle 2016-08-03 00:29:45 +02:00
Eloy Lafuente (stronk7) dffeff0a4b Merge branch 'MDL-55322-master' of https://github.com/snake/moodle 2016-08-03 00:12:10 +02:00
Eloy Lafuente (stronk7) 5fe1db394b Merge branch 'MDL-54745_master' of https://github.com/snake/moodle 2016-08-02 23:13:25 +02:00
Eloy Lafuente (stronk7) babfc9886c Merge branch 'MDL-44369_m32v3' of https://github.com/sbourget/moodle 2016-08-02 21:25:24 +02:00
Dan Poltawski de741b1551 MDL-54847 tests: fix unused var 2016-08-02 20:11:27 +01:00
Dan Poltawski 805f1c8d0b Merge branch 'MDL-54847-master-fix' of git://github.com/cameron1729/moodle 2016-08-02 20:09:45 +01:00
Cameron Ball c353674f21 MDL-54847 weblib: Test media attributes individually 2016-08-03 02:53:29 +08:00
Eloy Lafuente (stronk7) f31c65d784 Merge branch 'MDL-55167-master' of git://github.com/danpoltawski/moodle 2016-08-02 19:54:00 +02:00
Dan Poltawski 091a1f9290 MDL-55167 npm: add stylelint-checkstyle-formatter
Useful for automations (like the Moodle prechecker)
2016-08-02 18:52:41 +01:00
Eloy Lafuente (stronk7) 648bbbbbd0 Merge branch 'MDL-55167-master' of git://github.com/danpoltawski/moodle 2016-08-02 18:54:49 +02:00
Eloy Lafuente (stronk7) e0519d032d Merge branch 'MDL-55314-master' of https://github.com/mrmark/moodle 2016-08-02 17:16:07 +02:00
Eloy Lafuente (stronk7) 8a78cb42da Merge branch 'MDL-55315-master' of https://github.com/mrmark/moodle 2016-08-02 17:07:16 +02:00
Eloy Lafuente (stronk7) 2460f3be57 Merge branch 'MDL-55316-master' of https://github.com/mrmark/moodle 2016-08-02 17:01:46 +02:00
Dan Poltawski 8ce58c99f0 MDL-53572 mathjax: always load mathjax using https
It's considered an anti-pattern now to use protocol relative urls and
reduces a setting.

(Also fixed an incorrectly placed 3.1.0 upgrade marker)
2016-08-02 15:55:23 +01:00
Eloy Lafuente (stronk7) 03961256d1 Merge branch 'MDL-55348-master' of git://github.com/dpalou/moodle 2016-08-02 16:48:26 +02:00
Dan Poltawski 8ea6cc2455 Merge branch 'wip-MDL-33741-master' of git://github.com/marinaglancy/moodle 2016-08-02 12:20:11 +01:00
Dan Poltawski bf3b8a35d8 Merge branch 'MDL-45734_m32v4' of https://github.com/sbourget/moodle 2016-08-02 12:17:03 +01:00
Dan Poltawski 2961f1075b Merge branch 'MDL-55357_master' of git://github.com/dmonllao/moodle 2016-08-02 10:54:28 +01:00
Dan Poltawski 25054c40e1 Merge branch 'MDL-54847-master' of git://github.com/cameron1729/moodle 2016-08-02 10:54:21 +01:00
Marina Glancy 134494e07a MDL-55418 behat: correct exception class name 2016-08-02 17:45:12 +08:00
Marina Glancy 145f29034b MDL-55397 block_site_main_menu: eliminate CSS conflict
CSS for '.path-admin .buttons' defines padding, border and background that affected how main menu looks on admin pages
2016-08-02 14:20:18 +08:00
Cameron Ball 37c10287be MDL-54847 MDL-54847 weblib: Support basic HTML media tags 2016-08-02 10:58:48 +08:00
Andrew Nicols 8dc3b7697b Merge branch 'MDL-55355-master' of git://github.com/lameze/moodle 2016-08-02 10:29:30 +08:00
Andrew Nicols 346cf5abb9 Merge branch 'MDL-55352-master-fix' of https://github.com/lameze/moodle 2016-08-02 10:10:38 +08:00
Simey Lameze 30452f23cb MDL-55352 mod_feedback: Change series labels on multi choice rated 2016-08-02 09:23:18 +08:00
Stephen Bourget 7c4dfba89e MDL-51078 report_log: Allow filtering by all changes 2016-08-01 21:13:05 -04:00
Andrew Nicols b34d7e700b Merge branch 'MDL-54879-master' of git://github.com/junpataleta/moodle 2016-08-02 09:10:19 +08:00
Stephen Bourget 952c6e2697 MDL-55398 mod_feedback: prevent direct script access to lib files. 2016-08-01 20:53:46 -04:00
Andrew Nicols 8f33657dae Merge branch 'MDL-55140_m32v2' of https://github.com/sbourget/moodle 2016-08-02 08:48:36 +08:00
Dan Poltawski 6349765c44 Merge branch 'MDL-55360-master-workshopgradepass' of git://github.com/mudrd8mz/moodle 2016-08-01 18:57:00 +01:00
AMOS bot fa76a5b0af Automatically generated installer lang files 2016-08-02 00:04:17 +08:00
Dan Poltawski 4638a26eca MDL-55376 assign: trailing whitespace 2016-08-01 16:07:43 +01:00
Dan Poltawski b9fe2f38d4 Merge branch 'MDL-55376-master' of git://github.com/cameron1729/moodle 2016-08-01 16:07:00 +01:00
Dan Poltawski 65a427cc64 Merge branch 'MDL-55367-master' of git://github.com/lameze/moodle 2016-08-01 14:25:38 +01:00
Dan Poltawski 066e31fd74 Merge branch 'MDL-55323-master' of git://github.com/junpataleta/moodle 2016-08-01 13:58:20 +01:00
Dan Poltawski 307e63cb00 Merge branch 'MDL-55374-master' of git://github.com/damyon/moodle 2016-08-01 13:50:37 +01:00
Dan Poltawski a5cb07477c Merge branch 'MDL-55352-master' of git://github.com/lameze/moodle 2016-08-01 09:30:33 +01:00
Andrew Nicols 1a1771b944 Merge branch 'MDL-53152-master' of git://github.com/junpataleta/moodle 2016-08-01 15:04:17 +08:00
Jun Pataleta 259bf04f8a MDL-53152 theme: Add parentheses to variable calculations 2016-08-01 13:40:38 +08:00
Simey Lameze c5a90a4a5d MDL-55367 report_log: Prevent invalid time to be passed to Charts API 2016-08-01 12:57:57 +08:00
Jake Dallimore 0cced3ced3 MDL-54745 mod_assign: Remove leftover changegradewarning string and js 2016-08-01 12:48:25 +08:00
Andrew Nicols 5ee6125591 Merge branch 'MDL-55266-master' of git://github.com/jleyva/moodle 2016-08-01 10:49:15 +08:00
Andrew Nicols f00d967b43 Merge branch 'MDL-50286_m32v3' of https://github.com/sbourget/moodle 2016-08-01 09:54:06 +08:00
Stephen Bourget 3dee255163 MDL-50286 report_log: Allow filtering by event origin. 2016-07-31 21:45:27 -04:00
Jake Dallimore 243ddbcf50 MDL-55322 assignfeedback_editpdf: Prevent scroll when moving comments
Prevent the default scroll behaviour when using gestures to move
comments on the mobile site.
2016-08-01 09:43:03 +08:00
Simey Lameze 2356c4f6f2 MDL-55355 core: Change chart link text when status change 2016-08-01 09:13:59 +08:00
Marina Glancy 07d4777816 MDL-33741 file_info: show courses in hidden categories
This also has a couple of bugfixes:
- file_info_context_system::get_children() was looking for courses with parent=0, it is impossible, block removed;
- file_info_context_coursecat::get_area_coursecat_description() was checking the wrong capability to view files in description
2016-08-01 09:12:36 +08:00
Marina Glancy b195a5b331 MDL-33741 file_info: check capability when serving file in coursecat description 2016-08-01 09:12:18 +08:00
Andrew Nicols 78c19679d6 Merge branch 'MDL-55289-master-exsubmission' of git://github.com/mudrd8mz/moodle 2016-08-01 08:46:54 +08:00
Dan Poltawski b4fe4e25b2 MDL-55167 stylelint: disable some rules in grunt
These will be fixed in a later issue
2016-07-30 13:07:54 +01:00
Dan Poltawski 3bd777652e MDL-55167 less: Add some stylelint exceptions to deal with later
1) Use of REM units in course.less
2) CSS hacks (MDL-55142)
2016-07-30 13:07:54 +01:00
Dan Poltawski 16fed4663b MDL-55167 less: fix line over length 2016-07-30 13:07:54 +01:00
Dan Poltawski c73de4d5f1 MDL-55167 less: remove empty blocks 2016-07-30 13:07:54 +01:00
Dan Poltawski 75b68df3ee MDL-55167 less: reformat one line statemets into multiple lines 2016-07-30 13:07:53 +01:00
Dan Poltawski c2d3fe21ef MDL-55167 less: add missing linebreak seperators
Detected by
http://stylelint.io/user-guide/rules/at-rule-empty-line-before/
2016-07-30 13:07:53 +01:00
Dan Poltawski 0e878352f1 MDL-55167 less: fix spacing of selectors
Detected by
http://stylelint.io/user-guide/rules/block-opening-brace-space-before/
http://stylelint.io/user-guide/rules/selector-combinator-space-after/
http://stylelint.io/user-guide/rules/at-rule-name-space-after/
http://stylelint.io/user-guide/rules/selector-list-comma-space-before/
http://stylelint.io/user-guide/rules/media-feature-colon-space-before/
http://stylelint.io/user-guide/rules/selector-list-comma-newline-after/
2016-07-30 13:07:53 +01:00
Dan Poltawski 23bb9e242a MDL-55167 less: fix missing semi colons
Detected by:
http://stylelint.io/user-guide/rules/declaration-block-trailing-semicolon/
2016-07-30 13:07:52 +01:00
Dan Poltawski 418b932843 MDL-55167 less: fix spacing on properties
Detected by stylelint rules:
http://stylelint.io/user-guide/rules/declaration-colon-space-after/
http://stylelint.io/user-guide/rules/declaration-colon-space-before/
http://stylelint.io/user-guide/rules/function-comma-space-after/
http://stylelint.io/user-guide/rules/declaration-bang-space-before/
2016-07-30 13:07:52 +01:00
Dan Poltawski 855fc5d853 MDL-55167 grunt: add stylelint css linting 2016-07-30 13:07:52 +01:00
Stephen Bourget a0e13871cf MDL-45734 Badges: Add additional events 2016-07-29 21:51:05 -04:00
Stephen Bourget 756e3c55c0 MDL-44369 Calendar: add events for subscriptions 2016-07-29 08:56:20 -04:00
Cameron Ball 867b413181 MDL-55376 mod_assign: Fix bug stopping admin from editing submissions 2016-07-29 19:05:22 +08:00
David Monllao 2a36babbc8 MDL-55357 search: Contents include UTF8 characters, adding u modifier 2016-07-29 14:36:17 +08:00
Simey Lameze 9698ca2d20 MDL-55352 core: Label values series should override tooltip 2016-07-29 13:22:59 +08:00
Damyon Wiese fca211bf05 MDL-55374 mod_assign: Force utf-8 for DOMDocument
This prevents charset issues on some sites.
2016-07-29 10:43:25 +08:00
Andrew Nicols 56b9e796af MDL-24343 core: Deprecate zip_files 2016-07-29 08:15:16 +08:00
AMOS bot 72da3d5ef2 Automatically generated installer lang files 2016-07-29 00:05:37 +08:00
Juan Leyva 45fec98358 MDL-55266 user: New WS core_user_get_user_preferences 2016-07-28 12:08:58 +02:00
Juan Leyva 145900708c MDL-54941 webservice: Refactor file handling in WS
This commit reduces boilerplate code.
It also forces WS returning files to always return the following
fields: filename, filepath, mimetype, filesize, timemodified and
fileurl.
2016-07-28 12:07:04 +02:00
Dani Palou 3b40103c2f MDL-55348 wiki: Convert 'section' WS params to PARAM_RAW 2016-07-28 10:35:24 +02:00
David Mudrák aea8c5541e MDL-55360 workshop: Add tests for setting grades to pass via mod form
These scenarios should cover common cases of defining the grades to pass
pass via the workshop settings form. Note that behaviour of the fields
in terms of locale-specific decimals input (MDL-51806) is not covered
with these tests as I want to avoid installation of additional language
pack. Instead, I assume that functionality of unformat_float() is tested
separately in the core.
2016-07-28 09:54:43 +02:00
David Mudrák 3c4cc10eff MDL-55360 workshop: Emptying grades to pass should set them to zero
When editing existing workshop with a grade to pass defined, when the
field is emptied, it should be interpreted as setting it to zero. This
was not happening because unformat_float replaces the field with null,
therefore effectively unsetting it.

By casting to float, we interpret all empty values (including null) as
zeros. This behaviour is consistent with how gradebook setup UI works.
2016-07-28 09:54:43 +02:00
David Mudrák ebf0598e21 MDL-55360 workshop: Allow creating workshops with empty grades to pass
As a regression of MDL-55360, it was not possible to create new
workshops if the field "Submission grade to pass" or "Assessment grade
to pass" was left empty. The validation failed with "You must enter a
number here".

The fields submissiongradepass and gradinggradepass are always present
as we explicitly define them in the mod form. So the isset() condition
in the validation was useless and it did not allow to submit the form
with these fields empty.

Additionally, the unformat_float() returns null only if it receives
empty value on the input. Which can't happen in our case so I am
removing this condition to improve the readability of the code.
2016-07-28 09:54:43 +02:00
David Mudrák 87b5c584fb MDL-55289 workshop: Fix files processing in example submissions
While testing the issue MDL-55289 I realized that attaching files to
workshop example submissions does not work at all and throws an error.

The reason was that in MDL-50794 (996f7e82), the variables $contentopts
and $attachmentopts were replaced with the result of the methods
submission_content_options() and submission_attachment_options().
But I forgot to perform the full refactoring in exsubmission.php too.

Attached behat test should cover both issues on this branch.
2016-07-28 09:51:16 +02:00
David Mudrák 21d49a3f93 MDL-55289 workshop: Include repository/lib.php to use its constants
As a result of MDL-41556 (146893d6), the repository/lib.php was included
in submission.php so that its constant FILE_INTERNAL could be used in
field options. Recent development in MDL-50794 (996f7e8) moved the
options declaration to standalone methods but we forgot to check they
work in exsubmission.php too.

This patch moves the repository/lib.php inclusion to where the
library is actually needed.

Additionally it unifies how options are set for overall feedback content
and overall feedback attachment fields.
2016-07-28 09:51:16 +02:00
Jun Pataleta fe15136d37 MDL-55323 enrol_lti: Remove unused required parameter 2016-07-28 14:44:58 +08:00
Jun Pataleta 7a05bc92c9 MDL-55276 html: New down arrow entity output $OUTPUT->darrow 2016-07-28 14:43:11 +08:00
Jun Pataleta 653b8ef24b MDL-54879 mod_lti: Add fallback options for error message upon failure 2016-07-28 14:38:29 +08:00
David Monllao d1a3ea62ef weekly release 3.2dev 2016-07-28 12:07:20 +08:00
David Mudrák 0d7c417175 MDL-55166 admin: Fix display of misleading debug warning on manage block
Blocks can declare has_config() as true without actually using the
default node in the admin tree. Typical use case is when the block
injects its settings to other parts of the admin tree and it assigns
null to its $setting node in its settings.php file.

As Janek L.B. correctly spotted, this led to false debugging message
on admin/blocks.php as the code interpreted it as missing settings.php
file.

The patch adds explicit file existence test for this rare case.
2016-07-27 23:15:48 +02:00
Mark Nielsen 123cc912ec MDL-55314 mod_lti: Several fixes to lti_load_cartridge
* Fixed XML loading when there is an error
* Fixed exception thrown by lti_load_cartridge
* By default, don't allow LTI mod generator to
  use a toolurl as that results in a cURL call.
2016-07-27 09:08:21 -07:00
Dani Palou 33ef5cdcf9 MDL-54862 quiz: Return question blocked status in WS 2016-07-27 15:38:01 +02:00
Dani Palou 38b1f8fd99 MDL-55225 assign: Format assignment submission text in WS 2016-07-27 13:30:47 +02:00
Stephen Bourget 2ff504c6b2 MDL-55140 mod_choice: Allow independent open and close dates 2016-07-27 07:18:54 -04:00
Dan Poltawski fdf50e35b6 Merge branch 'MDL-55287_master-fix' of git://github.com/dmonllao/moodle 2016-07-27 07:58:33 +01:00
David Monllao e240a6132d MDL-55287 search: Custom error message if solr extension is not installed
Correcting engine is not installed lang string as well.
2016-07-27 13:57:15 +08:00
David Monllao 52872f66eb Merge branch 'wip-mdl-54987' of https://github.com/rajeshtaneja/moodle 2016-07-27 13:17:33 +08:00
Mark Nelson e1f53120dd MDL-54984 core_cache: corrected exception message 2016-07-27 11:42:47 +08:00
Rajesh Taneja 35f7cf429c MDL-54987 behat: Fixed feedback scenarios to display chart data
Now chart data is not visible by default,
we need to click 'Show chart data' to view.
Also, extra space is not required between
% as it's done by chart library
2016-07-27 11:00:54 +08:00
Eloy Lafuente (stronk7) bdce994c5f Merge branch 'MDL-50267-master' of git://github.com/junpataleta/moodle 2016-07-27 00:59:19 +02:00
Eloy Lafuente (stronk7) ddf1d5c692 Merge branch 'MDL-55244-master' of git://github.com/danpoltawski/moodle 2016-07-27 00:19:40 +02:00
Eloy Lafuente (stronk7) 7b146b5005 Merge branch 'MDL-55245-master' of https://github.com/lucisgit/moodle 2016-07-26 23:44:54 +02:00
Eloy Lafuente (stronk7) e90c60696a Merge branch 'wip-MDL-51735-master' of git://github.com/abgreeve/moodle 2016-07-26 20:15:13 +02:00
Eloy Lafuente (stronk7) f9c46195e4 Merge branch 'MDL-54657_m32v1' of https://github.com/sbourget/moodle 2016-07-26 19:56:20 +02:00
Eloy Lafuente (stronk7) 7647f3887f Merge branch 'MDL-54801-master' of git://github.com/jleyva/moodle 2016-07-26 19:54:53 +02:00
Eloy Lafuente (stronk7) 17b2cd6839 MDL-55046 assign: document the new return values 2016-07-26 19:45:18 +02:00
Eloy Lafuente (stronk7) e23faa4c81 Merge branch 'MDL-55046-master' of git://github.com/dpalou/moodle 2016-07-26 19:40:52 +02:00
Eloy Lafuente (stronk7) 8b13e09595 Merge branch 'wip-mdl-55337' of https://github.com/rajeshtaneja/moodle 2016-07-26 13:12:07 +02:00
Rajesh Taneja 4505459083 MDL-55337 behat: Added 1 sec delay between post
Ensure post is created at different timestamp, else
returned posts will be different and test fails.
This will happen on a fast machine.
2016-07-26 18:59:51 +08:00
Dan Poltawski 773a11519d Merge branch 'MDL-55278_master' of https://github.com/dmonllao/moodle 2016-07-26 11:57:09 +01:00
Dan Poltawski be5837d797 Merge branch 'MDL-54987-master-fixes' of https://github.com/lameze/moodle 2016-07-26 09:55:33 +01:00
Dan Poltawski 3624777b24 Merge branch 'MDL-54984-master' of git://github.com/junpataleta/moodle 2016-07-26 09:52:42 +01:00
Dan Poltawski 970c8e5ba4 MDL-49533 version: bump 2016-07-26 09:41:24 +01:00
Dan Poltawski e799990454 Merge branch 'MDL-49533-master' of git://github.com/andrewnicols/moodle 2016-07-26 09:40:17 +01:00
Simey Lameze e747d65514 MDL-54987 mod_choice: Fix notices and behat failures 2016-07-26 16:24:35 +08:00
Dan Poltawski d0733c7d69 Merge branch 'MDL-50051-master' of git://github.com/junpataleta/moodle 2016-07-26 09:14:45 +01:00
Dan Poltawski 6d5a7eee0c Merge branch 'MDL-54988-master' of git://github.com/junpataleta/moodle 2016-07-26 09:13:10 +01:00
Jun Pataleta fb77333453 MDL-50267 lang: Remove deprecated strings in 2.9 2016-07-26 16:03:32 +08:00
David Monllao 72e92d0ac2 Merge branch 'MDL-55325-master' of https://github.com/xow/moodle 2016-07-26 10:33:21 +08:00
David Monllao 837cec00f9 Merge branch 'wip-mdl-55091-m' of https://github.com/rajeshtaneja/moodle
Conflicts:
	lib/upgrade.txt
2016-07-26 10:14:30 +08:00
Rajesh Taneja 52f3e060e4 MDL-55091 phpunit: Following has been deprecated.
1. getMock()
2. setExpectedException()
3. checkForUnintentionallyCoveredCode renamed to beStrictAboutCoversAnnotation
4. beStrictAboutTestSize renamed to enforceTimeLimit
5. UnitTestCase class is now fully removed.
2016-07-26 10:11:30 +08:00
David Monllao 1a9c3d587f Merge branch 'wip-MDL-55183-master' of git://github.com/abgreeve/moodle
Conflicts:
	lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor-min.js
2016-07-26 09:52:51 +08:00
Andrew Nicols f1f94da496 MDL-49533 repository: Remove the Alfresco plugin
The SDK that this plugin was designed around is not compatible with recent
versions of Alfresco so the decisio has been made to move the repository to
the plugins database.
2016-07-26 08:57:34 +08:00
David Monllao db044a0997 Merge branch 'MDL-55251_m32v1' of https://github.com/sbourget/moodle 2016-07-26 05:12:00 +08:00
David Monllao 8bb1a64ad5 Merge branch 'MDL-55283-master' of git://github.com/andrewnicols/moodle 2016-07-26 05:04:03 +08:00
David Monllao 286a391b86 MDL-45753 test: Adding core_my testsuite 2016-07-26 04:35:02 +08:00
David Monllao fa2e488520 Merge branch 'MDL-55254_m32v3' of https://github.com/sbourget/moodle 2016-07-26 04:27:48 +08:00
David Monllao 46ac7b07d4 MDL-45753 events: Fix event context 2016-07-26 04:05:18 +08:00
David Monllao d6a85f46f7 Merge branch 'MDL-45753_m32v4' of https://github.com/sbourget/moodle
Conflicts:
	version.php
2016-07-26 04:03:14 +08:00
David Monllao 854695ee3f Merge branch 'MDL-51242-master' of git://github.com/andrewnicols/moodle 2016-07-26 02:40:35 +08:00
Jun Pataleta d6806d8eaf MDL-54984 cache: Added todo tags to items for 3.3 deprecations 2016-07-26 00:46:46 +08:00
Jun Pataleta 329642b9c5 MDL-54984 cache: 3.2 final deprecations 2016-07-26 00:46:37 +08:00
Jun Pataleta 7a07d34db8 MDL-54988 core: Final deprecation for lib/modinfolib methods
Final deprecation of the following methods:
- course_modinfo::build_section_cache()
- cm_info::get_deprecated_group_members_only()
- cm_info::is_user_access_restricted_by_group()

Plus throw coding exception for direct calls of the following:
- cm_info::get_url()
- cm_info::get_content()
- cm_info::get_extra_classes()
- cm_info::get_on_click()
- cm_info::get_custom_data()
- cm_info::get_after_link()
- cm_info::get_after_edit_icons()
- cm_info::obtain_dynamic_data()
2016-07-26 00:07:25 +08:00
Dan Poltawski 5d21ea9d3b Merge branch 'MDL-55287_master' of git://github.com/dmonllao/moodle 2016-07-25 15:55:48 +01:00
Dan Poltawski 12811fcc34 Merge branch 'MDL-55284-master' of git://github.com/damyon/moodle 2016-07-25 15:53:41 +01:00
Dan Poltawski c41ec1f55a Merge branch 'MDL-54987-master' of git://github.com/danpoltawski/moodle 2016-07-25 15:27:23 +01:00
Dan Poltawski 7eb71011dd MDL-54987 charts: fix method name to match coding style 2016-07-25 11:21:37 +01:00
Dan Poltawski ce323331f1 MDL-54987 charts: fix style issues 2016-07-25 11:21:31 +01:00
Simey Lameze 32917a9561 MDL-54987 core: final charts project polishing 2016-07-25 10:43:35 +01:00
Simey Lameze 1850e97e37 MDL-55208 mod_choice: Convert choice results chart to new library
Part of MDL-54987 epic.
2016-07-25 10:43:33 +01:00
Simey Lameze 7cd65bcb76 MDL-55308 mod_feedback: Convert analysis chart to the new library
Part of MDL-54987 epic.
2016-07-25 10:43:31 +01:00
Simey Lameze 08501958d3 MDL-55262 core: Add support for series values labels
Part of MDL-54987 epic.
2016-07-25 10:43:28 +01:00
Simey Lameze 5a6da80a5b MDL-55037 core: Define a set of default colors
Part of MDL-54987 epic.
2016-07-25 10:43:26 +01:00
Simey Lameze 01440dccb4 MDL-55219 core: Add support for horizontal bars
Part of MDL-54987 epic.
2016-07-25 10:43:24 +01:00
Simey Lameze 2aef5d2fd8 MDL-55025 report_stats: Use the new charting library
Part of MDL-54987 epic.
2016-07-25 10:43:22 +01:00
Simey Lameze f0f1e0310e MDL-55110 core: Add support for smooth lines
Part of MDL-54987 epic.
2016-07-25 10:43:20 +01:00
Frederic Massart cc8438d112 MDL-55146 core: Support custom labels on X axis
Note that this is still limited as the number of labels is locked
to the number of elements in the series.

Part of MDL-54987 epic.
2016-07-25 10:43:14 +01:00
Frederic Massart 2b01f9157a MDL-55146 core: Support multiple axes in charts
Part of MDL-54987 epic.
2016-07-25 10:43:12 +01:00
Frederic Massart 40912196a8 MDL-55089 core: Charts are displayed with a data table by default
Part of MDL-54987 epic.
2016-07-25 10:43:10 +01:00
Frederic Massart 4db37f3ac1 MDL-55039 core: First implementation of HTML table rendering for charts
Part of MDL-54987 epic.
2016-07-25 10:43:08 +01:00
Frederic Massart ccaa2b347d MDL-55038 core: Support multiple colours in the same series
Part of MDL-54987 epic.
2016-07-25 10:43:06 +01:00
Frederic Massart baea27e4d3 MDL-55026 quiz_statistics: Convert charts to the new library
Part of MDL-54987 epic.
2016-07-25 10:43:03 +01:00
Frederic Massart ec882623f3 MDL-55026 quiz_overview: Convert chart to the new library
Part of MDL-54987 epic.
2016-07-25 10:43:01 +01:00
Frederic Massart 601da0e693 MDL-55108 core: Document the charting library
Part of MDL-54987 epic.
2016-07-25 10:42:59 +01:00
Simey Lameze 6ce35fe0e1 MDL-55029 report_courseoverview: Convert report chart to the new library
Part of MDL-54987 epic.
2016-07-25 10:42:57 +01:00
Frederic Massart 681e1a7652 MDL-55092 core: Add support for custom Y axis labels
Part of MDL-54987 epic.
2016-07-25 10:42:54 +01:00
Frederic Massart c685dfabdc MDL-54989 scormreport_graphs: Use the new charting library
Part of MDL-54987 epic.
2016-07-25 10:42:52 +01:00
Frederic Massart 9b28bf0b83 MDL-55045 core: Remove the hardcoded canvas tag for chart.js
Part of MDL-54987 epic.
2016-07-25 10:42:49 +01:00
Simey Lameze 6cf5e0f263 MDL-54998 report_log: Convert log report graphs to the new API
Part of MDL-54987 epic.
2016-07-25 10:42:47 +01:00
Frederic Massart 8bc4583fc6 MDL-55031 core: Series color was not being exported
Part of MDL-54987 epic.
2016-07-25 10:42:44 +01:00
Frederic Massart 299e9aba66 MDL-55030 core: Bar charts defaults to using a Y axis starting at 0
Part of MDL-54987 epic.
2016-07-25 10:42:42 +01:00
Frederic Massart 826ade18f1 MDL-55030 core: Call class setter when creating a new axis
Part of MDL-54987 epic.
2016-07-25 10:42:39 +01:00
Frederic Massart a6c6faefb7 MDL-55030 core: Support setting defaults in charts
Part of MDL-54987 epic.
2016-07-25 10:42:37 +01:00
Frederic Massart 46de49dc9f MDL-55030 core: Support min and max in axes
Part of MDL-54987 epic.
2016-07-25 10:42:34 +01:00
Frederic Massart 909c5cf207 MDL-55016 core: Support stepSize in chart axes
Part of MDL-54987 epic.
2016-07-25 10:42:32 +01:00
Frederic Massart f5474e65fc MDL-55015 core: Add support for axis label in charts
Part of MDL-54987 epic.
2016-07-25 10:42:28 +01:00
Simey Lameze 858cbfdfd3 MDL-55013 core: add support for title
Part of MDL-54987 epic.
2016-07-25 10:42:19 +01:00
John Okely 4c3472a55c MDL-55325 mod_lti: Use .on('load') instead of .load()
Necessary after MDL-50937 JQuery upgrade to 3.1
2016-07-25 17:31:41 +08:00
Dan Poltawski a3ee51fe44 Merge branch 'wip-MDL-54796-master-v2' of git://github.com/abgreeve/moodle 2016-07-25 10:28:27 +01:00
Stephen Bourget 530d553580 MDL-55252 mod_chat: prevent direct script access to lib files. 2016-07-25 09:42:36 +01:00
Stephen Bourget 73b1d580aa MDL-55253 mod_choice: prevent direct script access to lib files. 2016-07-25 09:40:38 +01:00
Stephen Bourget c4b70cfc61 MDL-55255 mod_data: prevent direct script access to lib files. 2016-07-25 09:39:57 +01:00
Dan Poltawski 3a0bc0fdc4 MDL-55244 js: build changes
There should be no changes to minified code
2016-07-25 07:58:05 +01:00
Dan Poltawski bc8b6dc652 MDL-55244 js: fix various lint warnings in yui
* Incorrect brace style
* Empty functions
* Multiple var statemnts
2016-07-25 07:53:05 +01:00
Dan Poltawski 5bb4f444de MDL-55244 js: fix problems with eslint --fix
eslint --fix '**/yui/src/**/*.js'
2016-07-25 07:53:05 +01:00
Adrian Greeve 89644a400d MDL-51735 mod_lesson: A lesson with no content shows a message.
Before it would show an error.
2016-07-25 10:48:14 +08:00
Adrian Greeve b559497393 MDL-54796 forms: Editor restore event created.
The editor restore event is currently being subscribed
to by the change checkers to refresh their savedstate.
2016-07-25 10:42:58 +08:00
Adrian Greeve c17c25db05 MDL-55183 editor_atto: Fix requires error.
When using a different theme and removing an editor
plugin such as the equation plugin, atto will display
an error about a missing dependency.

A thank you to Anthony Forth for providing this patch.
2016-07-25 09:03:59 +08:00
Stephen Bourget 12306a9f0f MDL-55254 mod_data: Add view permissions 2016-07-24 21:00:57 -04:00
Mark Nielsen 3077ae6004 MDL-55315 mod_lti: Fix Nginx 405 error
It appears that Nginx doesn't allow POST
to static files.  So rename the fixture from
a HTML file to a PHP file.
2016-07-22 11:39:42 -07:00
Mark Nielsen 2b509dbc01 MDL-55316 core_completion: Expand fields for Behat
This only happens if you create the course with
one user and then try to enable completion
with another user.
2016-07-22 11:29:27 -07:00
Tony Butler b37b6cd8ef MDL-55245 assignfeedback_editpdf: Enable text in comments to be selected
Only move comment boxes if 'select' tool is selected, enabling users to
drag-select text within comments using the 'comment' tool.
2016-07-22 16:39:48 +01:00
Frederic Massart 357ec2d584 MDL-54987 core: New charting API 2016-07-22 17:33:30 +08:00
Frederic Massart 45feaec83b MDL-54987 core: Pull Chart.js in core 2016-07-22 17:33:30 +08:00
Russell Smith e868574f02 MDL-48856 dmllib: Adjust performance improvements. 2016-07-22 11:52:41 +10:00
David Monllao 379ca98642 MDL-55287 search: Check that an engine has been selected 2016-07-21 18:40:29 +02:00
David Monllao 0bd8383a8b MDL-55278 search: Updating references to area namespace 2016-07-21 18:38:18 +02:00
David Monllao 8fa1810cec MDL-55278 search: Get rid of core_search\area namespace 2016-07-21 18:38:18 +02:00
Eloy Lafuente (stronk7) 90a8bdbfc0 weekly release 3.2dev 2016-07-21 11:44:48 +02:00
Eloy Lafuente (stronk7) 3343737171 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-07-21 11:44:42 +02:00
Stephen Bourget 94c7e9f1de MDL-45753 Events: Add view and reset events for the dashboard 2016-07-20 22:50:55 -04:00
Tony Levi 73d37b20ed MDL-48856 pgsql: Performance tuning 2016-07-21 10:31:41 +10:00
Rajesh Taneja 165b70a16a MDL-55091 phpunit: Add support for findNodes, as they are now deprecated
https://github.com/sebastianbergmann/phpunit/issues/1292
2016-07-21 07:08:47 +08:00
Rajesh Taneja ef1d90480d MDL-55091 phpunit: Use latest phpunit 5.4.x 2016-07-21 07:08:46 +08:00
Damyon Wiese 771f8df153 MDL-55284 assign: Add missing webservice param 'onlyids'
Mod assign list_participants webservice is supposed to accept a param to limit the
returned data to only show user ids and not the full user details. It is missing
and so the full user records are fetched every time. This has a major impact on the
performance of the new assignment grading interface.
2016-07-20 15:18:01 +08:00
Andrew Nicols 78c09b9a60 Merge branch 'wip-mdl-51758' of https://github.com/rajeshtaneja/moodle 2016-07-20 13:06:22 +08:00
Rajesh Taneja 01082b50f0 MDL-51758 libraries: Reworded password.php not required 2016-07-20 12:55:09 +08:00
Andrew Nicols b2c2d18b28 MDL-55283 javascript: Check dir is readable before traversing them 2016-07-20 12:16:13 +08:00
Andrew Nicols 4cb32b2b52 Merge branch 'MDL-50937-fixes' of git://github.com/andrewnicols/moodle 2016-07-20 11:20:08 +08:00
Andrew Nicols eb3839dffd MDL-50937 tag: Stop using deprecated context
$.context has been deprecated for a long time - since before this code was
written. Unfortunately jQuery does not emit anything for deprecated code so
this was not picked up sooner.
2016-07-20 11:19:29 +08:00
Andrew Nicols 3c4778f5d2 MDL-50937 theme: langmenu should not have a href value 2016-07-20 11:19:23 +08:00
AMOS bot bde229738d Automatically generated installer lang files 2016-07-20 00:05:02 +08:00
Dan Poltawski ff0039689b Merge branch 'MDL-31356_master' of https://github.com/StudiUM/moodle 2016-07-19 13:01:34 +01:00
Eloy Lafuente (stronk7) 4feed61702 Merge branch 'MDL-55220-master' of git://github.com/jleyva/moodle 2016-07-19 13:21:36 +02:00
Eloy Lafuente (stronk7) a900c680ba Merge branch 'wip-mdl-55258-m' of https://github.com/rajeshtaneja/moodle 2016-07-19 12:13:00 +02:00
Dan Poltawski 29dcec6803 Merge branch 'MDL-55206-master' of git://github.com/junpataleta/moodle 2016-07-19 10:52:13 +01:00
Dan Poltawski 6851244452 MDL-50937 jquery: remove instances of migrate plugin 2016-07-19 10:34:17 +01:00
Dan Poltawski 11caf2e2e1 Merge branch 'MDL-50937-master' of git://github.com/damyon/moodle 2016-07-19 10:27:10 +01:00
Dan Poltawski 2c85472688 Merge branch 'MDL-54915-master' of http://github.com/damyon/moodle 2016-07-19 09:38:23 +01:00
Dan Poltawski 738430b863 Revert "Merge branch 'MDL-54915-master' of git://github.com/andrewnicols/moodle"
This reverts commit fa57043eb6, reversing
changes made to 36a19ecc26.
2016-07-19 09:37:01 +01:00
David Monllao 7bd5ce57d8 Merge branch 'MDL-51758-master' of git://github.com/andrewnicols/moodle
Conflicts:
	lib/upgrade.txt
2016-07-19 09:29:41 +02:00
David Monllao 8942afa981 Merge branch 'MDL-55141' of https://github.com/creator23/moodle 2016-07-19 08:58:09 +02:00
David Monllao 3e2b1e179f Merge branch 'MDL-49599-master' of git://github.com/andrewnicols/moodle 2016-07-19 08:53:28 +02:00
Andrew Nicols b34ed08a12 MDL-49599 core: Fully deprecate the boxclient class 2016-07-19 14:44:51 +08:00
David Monllao fa8f88095c Merge branch 'MDL-55157_m32v6' of https://github.com/sbourget/moodle 2016-07-19 08:41:29 +02:00
Jun Pataleta 3046ee9f0d MDL-50051 core: Update todo tag comment for get_referer 2016-07-19 13:40:09 +08:00
Jun Pataleta 2a72354167 MDL-50051 core: Add deprecated tags to deprecated methods 2016-07-19 13:39:39 +08:00
Damyon Wiese 8d00afb12c MDL-54915 templates: Fix async rendering of js blocks
Mustache JS helper can overwrite JS blocks when using nested templates.

Each call to render should have it's own scope.
2016-07-19 12:55:50 +08:00
Stephen Bourget 05fbbb7731 MDL-55157 mod_feedback: Deprecate unused strings 2016-07-18 22:08:47 -04:00
Stephen Bourget b28753f5bf MDL-55157 mod_feedback: Course reset should update dates 2016-07-18 22:08:00 -04:00
Eloy Lafuente (stronk7) 5281e6a082 MDL-52544 oracle: small tweaks
This commit just:

- Moves the null => '' to better place, restricting it to PHP >= 7.0
  (bug https://bugs.php.net/bug.php?id=72524)
- Adds a couple of notes here and there.
- Changes some small details to keep the file using the same coding.
2016-07-19 04:04:32 +02:00
Eloy Lafuente (stronk7) 74ec2dd63d Merge branch 'MDL-52544-master' of git://github.com/damyon/moodle 2016-07-19 04:04:18 +02:00
Damyon Wiese d863344ad7 MDL-50937 jquery: Upgrade to 3.1, remove migrate plugins 2016-07-19 09:27:40 +08:00
Rajesh Taneja ddf36bf5aa MDL-55258 behat: Set focus on button before clicking it
Set the focus on button to ensure it is in
viewport before clicking on it.
2016-07-19 09:23:44 +08:00
Eloy Lafuente (stronk7) 9e91ff52c9 Merge branch 'MDL-51410_m32v2' of https://github.com/sbourget/moodle 2016-07-19 02:31:24 +02:00
Eloy Lafuente (stronk7) f91d6783aa Merge branch 'MDL-55207-configiplist-errors' of https://github.com/brendanheywood/moodle 2016-07-19 02:26:58 +02:00
Eloy Lafuente (stronk7) b697ad409b Merge branch 'wip-mdl-55111' of https://github.com/rajeshtaneja/moodle 2016-07-19 02:09:17 +02:00
David Monllao db26654b70 Merge branch 'MDL-55173-master' of git://github.com/andrewnicols/moodle 2016-07-19 01:48:28 +02:00
David Monllao b3b1833097 Merge branch 'MDL-54943-master' of git://github.com/jleyva/moodle
Conflicts:
	version.php
2016-07-19 01:19:13 +02:00
David Monllao 2f8da1e814 Merge branch 'MDL-55158_m32v3' of https://github.com/sbourget/moodle 2016-07-19 00:50:41 +02:00
Stephen Bourget 87d6e85a9a MDL-55158 mod_data: Add calendar events for database activities 2016-07-18 18:35:37 -04:00
David Monllao c08a7eebb6 Merge branch 'wip-MDL-55126-master' of git://github.com/abgreeve/moodle
Conflicts:
	lib/upgrade.txt
2016-07-18 20:50:47 +02:00
David Monllao 8c00f1cbc7 Merge branch 'MDL-55200_master' 2016-07-18 20:41:07 +02:00
Steffen Pegenau 51ed23519a MDL-55200 question type ddmarker: Display coordinates on image
To make the creation of dropzones easier, the mouse coordinates are shown.
2016-07-18 20:40:49 +02:00
David Monllao f60a16ad9d Merge branch 'MDL-55162-master' of git://github.com/jleyva/moodle
Conflicts:
	mod/assign/externallib.php
2016-07-18 20:35:50 +02:00
David Monllao d66e54b021 Merge branch 'MDL-55161-m' of https://github.com/micaherne/moodle 2016-07-18 20:00:18 +02:00
David Monllao 90f3675d9c Merge branch 'MDL-55163-master' of git://github.com/jleyva/moodle 2016-07-18 19:42:46 +02:00
Dan Poltawski ae76b9ed17 Merge branch 'MDL-14448_m32v1' of https://github.com/sbourget/moodle 2016-07-18 15:06:22 +01:00
Dan Poltawski 3ed88885e5 Merge branch 'wip-mdl-55174' of https://github.com/rajeshtaneja/moodle 2016-07-18 14:49:48 +01:00
Dan Poltawski bbb826f48f Merge branch 'MDL-55190-master' of git://github.com/merrill-oakland/moodle 2016-07-18 14:21:03 +01:00
Dan Poltawski 151aaa2654 Merge branch 'MDL-55012-master' of git://github.com/damyon/moodle 2016-07-18 13:55:50 +01:00
Dan Poltawski 2dbaaa9bdc Merge branch 'MDL-54963_master' of git://github.com/dmonllao/moodle 2016-07-18 13:38:36 +01:00
Dan Poltawski eab9f3d32e Merge branch 'wip-mdl-54977' of https://github.com/rajeshtaneja/moodle 2016-07-18 13:27:48 +01:00
Dan Poltawski 5e60c1d436 Merge branch 'MDL-55240-master' of git://github.com/junpataleta/moodle 2016-07-18 10:51:06 +01:00
Dan Poltawski fa57043eb6 Merge branch 'MDL-54915-master' of git://github.com/andrewnicols/moodle 2016-07-18 09:17:53 +01:00
Dani Palou 9ac99220c5 MDL-55046 assign: Return submissionstatement in get_assignments 2016-07-18 09:22:12 +02:00
Rajesh Taneja ce78e33a84 MDL-55174 core_tests: Use proper itemid while creating file 2016-07-18 10:29:23 +08:00
Andrew Nicols 21e8b48d13 MDL-51758 libraries: Remove password_compat library from core 2016-07-18 10:06:57 +08:00
Andrew Nicols d16185fd4f MDL-55173 mod_forum: Perform final deprecations 2016-07-18 08:42:33 +08:00
Andrew Nicols 9a60d5f98f MDL-54915 core: JS Blocks must not used shared variables
The JS blocks in a template must _not_ use a shared variable as they can be
executed asynchronously and complete in any order.

Instead it is stored in the only local variable available - the current
context.

Since the context can be passed in from elsewhere, we namespace it to
reduce the chance of collission.
2016-07-18 08:29:52 +08:00
Stephen Bourget 0f256bc05e MDL-55251 mod_chat: Add view permissions 2016-07-15 16:13:06 -04:00
AMOS bot 05ce84fbc1 Automatically generated installer lang files 2016-07-16 00:05:30 +08:00
Jun Pataleta 49ccaee5a9 MDL-55206 admin: Some code cleanup
* Removed unnecessary TODOs.
* Changed message prompt case to sentence case.
2016-07-15 14:44:35 +08:00
Jun Pataleta 36b88f2486 MDL-55206 admin: Remove div tags in password policy error message 2016-07-15 14:40:54 +08:00
Brendan Heywood 685e5b002c MDL-55207 adminlib: Improve help and validation errors for configiplist 2016-07-15 16:38:54 +10:00
Rajesh Taneja fc2e137750 MDL-55174 core_testing: Use proper directory separator
While searching for existing files if directory
separator is not correct then original files
and directories will be deleted. So use DIRECTORY_SEPARATOR.
2016-07-15 13:51:41 +08:00
Damyon Wiese 91445c63f8 MDL-55012 Atto: no style attrs on paste
Specifically on paste - we don't need all the random style attributes
from content on the clipboard. When you copy from a webpage - the browser
inlines all the styles from the page so that the pasted content will look
like the place it was copied from. But this is never what you want - you
want the content on paste, but with no special styling.
2016-07-15 13:34:11 +08:00
Jun Pataleta 667cec9ba1 MDL-55240 editpdf: Revert changes in MDL-54772
* Revert rendering of annotations and comments back to the
  drawing region.
* Bind events to stamp annotation when editing only.
2016-07-15 10:36:45 +08:00
Anant e370e069a7 MDL-55141 task: Add CLI debugging for tasks 2016-07-14 09:24:52 -07:00
Serge Gauthier cc6b92483a MDL-31356 enrol_imsenterprise: Continue development for added features
* Add the possibility to make it works as before (with categrory name or idnumber).
    * Add possibility to specify nested categories by name or idnumber.
    * Fix error in core_course_courselib_testcase::test_course_created_event because dependency with imsenterprise
2016-07-14 09:36:03 -04:00
Serge Gauthier 08b29336b9 MDL-31356 enrol_imsenterprise: merge with moodle3.2 2016-07-14 09:36:03 -04:00
Dan Poltawski 81e849bc71 MDL-31356 enrol_imsenterprise: add additional test coverage 2016-07-14 09:36:03 -04:00
Dan Poltawski ecf6a0ab5b MDL-31356 enrol_imsenterprise: Fix behaviour with course idnumber
When not set we shouldn't throw a warning
2016-07-14 09:36:03 -04:00
Brian Biggs 93fdbb4292 MDL-31356 enrol_imsenterprise: New Features
* Feature 1: Allow nested categories when creating courses.
* Feature 2: Allow updates to course Full Name and Short Name.
* Feature 3: Allow setting authentication type for users.
* Feature 4: Allow updates to users.

Also added tests and updated course update routines so it doesn't
muck with DB directly.
2016-07-14 09:36:02 -04:00
David Monllao 36a19ecc26 weekly release 3.2dev 2016-07-14 11:28:40 +02:00
David Monllao 78f5b1841f Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-07-14 11:28:37 +02:00
Juan Leyva 55bb8189ba MDL-55220 forum: Add string filtering in WS
The following external functions now filter the discussion and post
name and subject.
- get_forum_discussions_paginated
- get_forum_discussion_posts
2016-07-14 09:10:07 +01:00
Stephen Bourget 25d8a63a4e MDL-54657 Behat: Add tests for section_links block 2016-07-13 21:38:31 -04:00
Stephen Bourget ca97b358bb MDL-14448 mod_lesson: Add view permissions 2016-07-13 19:10:06 -04:00
Eric Merrill e0867b2222 MDL-55190 search: Limit search to non-files if disabled 2016-07-13 06:05:33 -04:00
Michael Aherne b4beaed931 MDL-55161 assign: Check for existence of gradebook feedback plugin 2016-07-13 09:01:45 +01:00
Adrian Greeve f6f0ba2d45 MDL-55126 files: Deprecate get_records_csv and put_records_csv.
Initial deprecation of the above functions.
2016-07-13 14:22:46 +08:00
JD 560cea838b MDL-54977 blocks_navigation: Use html_writer::random_id for id
uniqid() may returns the same id for faster machines (seen on iis)
so use html_writer::random_id(), to ensure id is different and
navigation don't break
2016-07-13 14:04:16 +08:00
Andrew Nicols 3142a57c69 Merge branch 'MDL-47371-master-fix' of git://github.com/cameron1729/moodle 2016-07-13 12:07:36 +08:00
Cameron Ball 48ae4707cc MDL-47371 mod_book: Fix out of scope $unescapedtitle 2016-07-13 10:26:24 +08:00
Damyon Wiese 87c6f9ab23 MDL-52544 oracle: Apply upstream pull request to AdoDB oracle driver
Upstream: https://github.com/ADOdb/ADOdb/pull/259

Prevent segfault with ocipo driver on php7.

The OCIFetchinto function is causing segfaults on php7 - probably because the fields array
is not initialised or it is optimised out. This fixes just changes to use the safer function
oci_fetch_array instead.
2016-07-13 08:45:06 +08:00
Stephen Bourget 7040f90d07 MDL-51410 mod_survey: fix notifications when saving analysis 2016-07-12 20:07:35 -04:00
Eloy Lafuente (stronk7) 5968add63f Merge branch 'MDL-55083_master' of https://github.com/tunele/moodle 2016-07-13 00:09:08 +02:00
tunele f029401b36 MDL-55083 admin: provide friendly error in case phpxml is missing 2016-07-12 23:35:15 +02:00
Eloy Lafuente (stronk7) af8b948e2b Merge branch 'MDL-54629-master' of git://github.com/jleyva/moodle 2016-07-12 21:01:02 +02:00
Eloy Lafuente (stronk7) 5748e56242 Merge branch 'MDL-54671-master' of git://github.com/danpoltawski/moodle 2016-07-12 18:14:17 +02:00
Eloy Lafuente (stronk7) 731f2989c9 MDL-53803 mod_choice: fix trailing whitespace 2016-07-12 18:05:32 +02:00
Eloy Lafuente (stronk7) 4a5bbd9cda Merge branch 'MDL-53803_m32v1' of https://github.com/sbourget/moodle 2016-07-12 18:03:08 +02:00
Eloy Lafuente (stronk7) 4a132893e0 Merge branch 'MDL-54892-master' of https://github.com/tobiasreischmann/moodle 2016-07-12 17:51:36 +02:00
Juan Leyva c1da311ad6 MDL-54801 webservice: Support 'ids' search in get_categories 2016-07-12 15:41:32 +01:00
Eloy Lafuente (stronk7) bdfb19cc2a Merge branch 'MDL-11369_m32v2' of https://github.com/sbourget/moodle 2016-07-12 15:58:59 +02:00
Eloy Lafuente (stronk7) 3c724b4218 Merge branch 'MDL-55136_dataobject' of git://github.com/davosmith/moodle 2016-07-12 15:48:13 +02:00
Juan Leyva b93ea100fc MDL-55162 mod_assign: Refactor to use new validate_assign helper 2016-07-12 14:39:24 +01:00
Juan Leyva 7336b66f05 MDL-55162 mod_assign: New WS mod_assign_view_assign 2016-07-12 14:39:24 +01:00
David Monllao eb4f0d9c84 Merge branch 'MDL-54771-master' of git://github.com/cameron1729/moodle 2016-07-12 14:53:32 +02:00
Eloy Lafuente (stronk7) 9f4c5c542b MDL-37250 mod_lesson: Move conditions to queries for better performance
While this ony seems to affect MySQL, better put the filter/conditions
on every query so the temporary view/table does not need to handle
thousands of potentially unrelated records.
2016-07-12 13:31:25 +02:00
Eloy Lafuente (stronk7) 9401ee156c Merge branch 'wip-MDL-37250-master' of git://github.com/abgreeve/moodle 2016-07-12 13:21:19 +02:00
David Monllao 7aad43e13f Merge branch 'MDL-55133-master' of git://github.com/damyon/moodle 2016-07-12 13:16:27 +02:00
David Monllao 64c1e707a9 Merge branch 'wip-MDL-55107-master' of git://github.com/abgreeve/moodle 2016-07-12 13:03:19 +02:00
David Monllao b60d4fca13 Merge branch 'MDL-55048-master' of git://github.com/danpoltawski/moodle 2016-07-12 12:20:35 +02:00
Dan Poltawski 120f4ed7ee Merge branch 'MDL-54891-master' of git://github.com/ryanwyllie/moodle 2016-07-12 10:38:56 +01:00
Dan Poltawski 815abdf4db Merge branch 'MDL-47371-master' of git://github.com/cameron1729/moodle 2016-07-12 10:15:57 +01:00
Damyon Wiese eea2fc4319 MDL-52544 oracle: php7 fixes for oci driver
These are our bugs actually - the oci docs are very clear that bound
params should be in-scope when oci_execute is called - and due to pass by value etc,
this was not true for our driver.

There is another bug that needed fixing - OCI barfs if null values are bound - this
can be avoided by setting them to '' which oci treats as null.

And finally - all our lob/clob/blob hacks were also binding to local "out-of-scope" vars.
2016-07-12 16:55:47 +08:00
David Monllao 4fcca5378b Merge branch 'MDL-55170_master' of https://github.com/nadavkav/moodle
Conflicts:
	theme/bootstrapbase/style/moodle.css
2016-07-12 10:30:31 +02:00
David Monllao 8178b7824d MDL-54963 search: Show no results 2016-07-12 10:27:31 +02:00
Dan Poltawski acb75afe39 Merge branch 'MDL-55007-master' of https://github.com/dthies/moodle 2016-07-12 09:20:15 +01:00
Adrian Greeve 97a85bf6f0 MDL-55107 gradebook: Unit tests for the new setting check. 2016-07-12 13:30:10 +08:00
Adrian Greeve 05156571c0 MDL-55107 gradebook: Improve the 57 letter boundary upgrade.
This fixes a setting not being checked before and also
reduces the number of false positives.
2016-07-12 13:30:10 +08:00
Damyon Wiese a066cfc843 MDL-55133 javascript: Correctly use component names in requirejs
Core subsystems must use the 'core_' prefix always.
2016-07-12 11:15:17 +08:00
Cameron Ball a9ebd43b27 MDL-47371 mod_book: Don't double escape book titles 2016-07-12 10:31:17 +08:00
Cameron Ball a530cb93f5 MDL-47371 block_navigation: Don't double escape course titles 2016-07-12 10:31:17 +08:00
Cameron Ball 6fb1a7177f MDL-47371 weblib: Add option to disable escaping 2016-07-12 10:31:17 +08:00
Eloy Lafuente (stronk7) f71eaa794d Merge branch 'MDL-55134-master' of git://github.com/danpoltawski/moodle 2016-07-12 02:53:58 +02:00
Daniel Thies fa3f814792 MDL-5507 filter_mathjaxloader: Add commeents for regexes 2016-07-11 13:20:41 -05:00
Dan Poltawski b76edf3cfa Merge branch 'MDL-54926-master' of git://github.com/merrill-oakland/moodle 2016-07-11 16:54:40 +01:00
Dan Poltawski 7402479c45 MDL-55048 travis: check npm/grunt on multiple npm versions
Check npm install and grunt execution on the higest and lowest node
versions. Included some minor tweaks along the way:

* Move the grunt execution into scripts part of the configuration (that way
  the grunt output is not collapsed and is easily visible in build output).

* Restructure the install section to be task based (thanks to Eloy for
  the suggestion) and as such, don't run composer install on the grunt
  task (speed up the build slightly).

* Switch around the grunt job to a matrix include so that every
  variation of grunt job doesn't need to be excluded.
  ( https://docs.travis-ci.com/user/customizing-the-build/#Explicity-Including-Jobs )
2016-07-11 15:53:10 +01:00
Dan Poltawski 9b62a3eb71 MDL-55048 js: rebuilt files with new version of uglifyjs 2016-07-11 15:53:10 +01:00
Dan Poltawski 0e6e19179e MDL-55048 grunt: make uglify task behave as before
Don't output the status of uglifyied JS files, just the final result,
will still report what happens in detail in verbose mode
2016-07-11 15:53:10 +01:00
Dan Poltawski 2ce9109088 MDL-55048 grunt/npm: Update dependencies
* We bump our minimum node version up to >=4. Although this isn't yet
  necessarily *required* it was spurred on because grunt dropped support
  for very early node versions and so it's likely some devs will have to
  upgrade their npm.

  We do it now which gives us more flexibility for tools going forward
  (especially for things like new theme/testing). And node has matured
  the ecosystem (especially supporting properly semver) so should result
  in less edge cases.

* We make the minimum node version explicit in package.json. Though it
  doesn't help much for older versions of node because npm doesn't
  have the functionality to warn about it.. ;-)

* Left async dependency as it was, because it's only on an RC: 2.0.0-rc.6
2016-07-11 15:53:10 +01:00
Eloy Lafuente (stronk7) cf7dc57a91 Merge branch 'MDL-54944-master' of git://github.com/danpoltawski/moodle 2016-07-11 16:50:51 +02:00
Dan Poltawski 64ec975e19 Merge branch 'MDL-55082-master' of git://github.com/merrill-oakland/moodle 2016-07-11 15:20:48 +01:00
David Monllao 26140adbb9 Merge branch 'wip-MDL-54962-master' of git://github.com/abgreeve/moodle 2016-07-11 16:15:48 +02:00
David Monllao 034544ffda Merge branch 'MDL-18599-master' of git://github.com/junpataleta/moodle 2016-07-11 15:59:44 +02:00
David Monllao 27600832aa Merge branch 'MDL-49029_m32v2' of https://github.com/sbourget/moodle 2016-07-11 15:50:29 +02:00
Dan Poltawski 8846f9950f Merge branch 'MDL-55112-master' of git://github.com/junpataleta/moodle 2016-07-11 14:42:06 +01:00
Jun Pataleta af0fc6a254 MDL-18599 mod_forum: Hide single discussion owner's name and picture
* On the discussion's page.
* On the recent activity block.
* On the recent activity page.
2016-07-11 21:40:19 +08:00
Dan Poltawski 83ecbbc0b1 Merge branch 'MDL-55137-master' of git://github.com/cameron1729/moodle 2016-07-11 14:37:56 +01:00
David Monllao c68010eaee MDL-55048 cli: Add example using new cool options
Also added short option for ignore password policy.
2016-07-11 15:17:57 +02:00
David Monllao 34127afdb6 Merge branch 'MDL-55084' of git://github.com/prg3/moodle 2016-07-11 15:06:38 +02:00
Dan Poltawski 7d650df727 Merge branch 'MDL-55128-master' of git://github.com/jleyva/moodle 2016-07-11 13:33:23 +01:00
Dan Poltawski e9da895634 Merge branch 'wip-MDL-55154-master' of git://github.com/abgreeve/moodle 2016-07-11 13:31:24 +01:00
David Monllao 728faf96c4 Merge branch 'MDL-51373-master' of git://github.com/jleyva/moodle 2016-07-11 13:58:34 +02:00
Dan Poltawski ad3f8cd18c MDL-54944 eslint: make the .eslintrc default stricter
Instead of using the more rollup-tolerant config for all files, make the
configuration stricter by default but lower in grunt for yui modules.

This means that manual runs (prechecker) or editor integrations will
flag up the errors as well as grunt.

Also add ignore lines to the core files so that eslint isn't noisy when
not running with grunt.
2016-07-11 12:44:34 +01:00
Juan Leyva aa7e371af6 MDL-51373 grade: Deprecate WS core_grade_get_grades 2016-07-11 12:41:49 +01:00
Dan Poltawski e2f79e330d Merge branch 'MDL-53222_master' of git://github.com/dmonllao/moodle 2016-07-11 11:42:41 +01:00
David Monllao 6a4c2146f9 MDL-53222 search: Replace report_search by new searchareas admin page 2016-07-11 11:49:14 +02:00
Dan Poltawski c3a95c2840 MDL-53222 admin: rejig listing of search areas 2016-07-11 11:38:41 +02:00
David Monllao e704bcc776 MDL-53222 report_search: Delete from core 2016-07-11 11:38:41 +02:00
Juan Leyva 95624eef09 MDL-55163 mod_assign: Fix mod_assign_copy_previous_attempts
- Not exposed via WS
- Have a bug when calling the api function
2016-07-11 10:35:24 +01:00
David Monllao 1d17f51a8d Merge branch 'MDL-54832-master' of https://github.com/nashtechdev01/moodle 2016-07-11 06:47:13 +02:00
Adrian Greeve 681f8f09c0 MDL-37250 mod_lesson: All actual attempts on the lesson are displayed.
The lesson overview report now shows all attempts made including hitting
the page and immediately navigating away.
2016-07-11 08:18:41 +08:00
AMOS bot 65ec0d7d77 Automatically generated installer lang files 2016-07-11 00:05:50 +08:00
Rajesh Taneja d89dc6b123 MDL-55111 behat: Use option which is available everytime for export
recentupcoming option is always available everytime calendar export
is called, rest week and month is optionally shown and may not be
visible. So use recentupcoming event option and export calendar for test
2016-07-10 11:11:31 +08:00
Nadav Kavalerchik 3bce7d0880 MDL-55170 theme_bootstrapbase: Fix user enrollment dialog, RTL 2016-07-09 14:52:21 +03:00
Dan Poltawski d7f2176fd8 MDL-54671 css: fix lint errors 2016-07-08 12:58:54 +01:00
Dan Poltawski c5ec7b698b MDL-54671 css: reformat css 2016-07-08 12:54:13 +01:00
Stephen Bourget 03064d6a89 MDL-54891 Block_activity_results: Allow admin defaults 2016-07-08 05:10:27 +00:00
Adrian Greeve d58f3a4d2a MDL-54962 mod_data: Approval status is now translated.
It was using hardcoded English. Now it uses get_string.
2016-07-08 10:53:39 +08:00
Adrian Greeve 9582e530eb MDL-55154 mod_lesson: Lesson numerical response shows images. 2016-07-08 09:54:58 +08:00
Daniel Thies b54aeb5f83 MDL-55007 filter_mathjaxloader: Change unit test 2016-07-07 18:59:08 -05:00
Daniel Thies 638b473808 MDL-55007 filter_mathjaxloader: Wrap nolink around each expresssion 2016-07-07 18:58:15 -05:00
Stephen Bourget 9be8052937 MDL-11369 mod_choice: Add calendar events for choice activities 2016-07-07 16:56:17 -04:00
Stephen Bourget 1725216aee MDL-49029 mod_choice: Add view permissions 2016-07-07 15:10:17 -04:00
Dan Poltawski d3a93557d5 MDL-55134 less: make indentation consistent 2016-07-07 14:57:14 +01:00
Dan Poltawski 6e304922fb MDL-54944 js: built files after changes 2016-07-07 12:11:07 +01:00
Dan Poltawski 5602dc1735 MDL-54944 js: ensure functions are consistent in return val
Mostly we are being incosnistent when giving an early-exit shortcut.

Detected by http://eslint.org/docs/rules/consistent-return
2016-07-07 12:11:07 +01:00
Dan Poltawski 7b7d55e11a MDL-54944 js: split variable intialisations in multiple lines
To increase code clarity, we don't allow multiple intilisations to be
confused with each other.

Detected by http://eslint.org/docs/rules/one-var-declaration-per-line
2016-07-07 12:11:06 +01:00
Dan Poltawski 2d2b6c9d22 MDL-54944 js: remove uncessary .call() uses
Detected by http://eslint.org/docs/rules/no-useless-call
2016-07-07 12:11:06 +01:00
Dan Poltawski b1c4d0f2d7 MDL-54944 js: Remove uncessary bind() calls
Most of these cases, we are already capturing this in a temporary
variable, so the bind becomes uncessary.

Discovered by http://eslint.org/docs/rules/no-extra-bind
2016-07-07 12:11:06 +01:00
Dan Poltawski c905cd233d MDL-54944 js: fix quoting of object properities coding style
Detected by http://eslint.org/docs/rules/quote-props
2016-07-07 12:11:05 +01:00
Dan Poltawski 9f5f3dcc83 MDL-54944 js: Fix spacing of objects coding style
Fixed by http://eslint.org/docs/rules/object-curly-spacing
2016-07-07 12:11:05 +01:00
Dan Poltawski 037de71996 MDL-54944 eslint: Add rules from Policy decision
Also bump eslint to v2.13.1 and make the version explicit in
package.json
2016-07-07 12:10:49 +01:00
Eloy Lafuente (stronk7) 5a1728df39 weekly release 3.2dev 2016-07-07 10:19:49 +02:00
Eloy Lafuente (stronk7) ffe0699c44 NOBUG: Fixed SVG browser compatibility 2016-07-07 10:19:45 +02:00
Eloy Lafuente (stronk7) 2487a92837 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-07-07 10:19:44 +02:00
Andrew Nicols aa49ee0f29 Merge branch 'wip-mdl-55043' of https://github.com/rajeshtaneja/moodle 2016-07-07 11:27:58 +08:00
Rajesh Taneja 56c5c9a08a MDL-55043 core_competency: Sort by id to ensure we get expected result. 2016-07-10 11:25:06 +08:00
Andrew Nicols 71f81adce9 Merge branch 'MDL-54869-master' of git://github.com/jleyva/moodle 2016-07-07 10:30:17 +08:00
Stephen Bourget 025188da5f MDL-53803 mod_choice: remove orphaned answers when removing options 2016-07-06 17:08:50 -04:00
Cameron Ball aa60ab01c3 MDL-54771 tool_recyclebin: Don't add temp course to recycle bin 2016-07-06 23:18:36 +08:00
Cameron Ball 1706352d01 MDL-54771 restore: Add deletesource to course object
Since deleting a course now triggers the pre_course_delete hook
it may be useful for hook implementations to know whether it was
a "true" course deletion, or one originating from a temporary
course created during a restore.
2016-07-06 23:11:31 +08:00
Paul Greidanus c248c3f07f MDL-55084 admin: CLI driven password reset
This patch allows for changing a user's password via the command line.
This allows for scripted password changes easily.
2016-07-06 07:00:57 -06:00
Eloy Lafuente (stronk7) 9825afd76a Merge branch 'wip-MDL-46682-master' of git://github.com/abgreeve/moodle 2016-07-06 13:50:12 +02:00
Cameron Ball 977804ed9d MDL-55137: Update PHPDoc for external_format_text 2016-07-06 17:48:07 +08:00
Davo Smith a106fb8178 MDL-55136 data_object: fix param handling in fetch_all_helper 2016-07-06 10:33:06 +01:00
Eloy Lafuente (stronk7) 080c1e798b MDL-54934 workshop: ensure "Current phase" is always separated
Apparently some readers can join 2 adjacent spans completely, simply
adding a whitespace between them prevents that, ensuring separation.,
2016-07-06 11:30:40 +02:00
Cameron Ball c30bfed180 MDL-41945 mod_assign: Add empty submission check 2016-07-06 10:07:04 +01:00
Adrian Greeve 3261b9eeea MDL-46682 auth/db: Increase of chunk size and update change.
The update query was not checking the mnet auth id and could
have been updating the wrong entry.
2016-07-06 16:41:51 +08:00
Andrew Nicols 9ce2448091 Merge branch 'MDL-54734-master' of git://github.com/lameze/moodle 2016-07-06 15:01:06 +08:00
Andrew Nicols de374c3df1 Merge branch 'MDL-53495' of https://github.com/mr-russ/moodle 2016-07-06 13:29:18 +08:00
Simey Lameze ec90722870 MDL-54734 core_user: do not cache dummy user records 2016-07-06 13:07:03 +08:00
Russell Smith 848d212e7a MDL-53495 database xmldb: Ensure field tests use constant.
Some tests were still using hard coded values which break
if the constants are changed.
2016-07-06 14:45:00 +10:00
Andrew Nicols 42f7b608ed Merge branch 'MDL-54165-master' of git://github.com/ryanwyllie/moodle 2016-07-06 12:01:51 +08:00
Ryan Wyllie 2441100db9 MDL-54165 mod_assign: Fix doc in grading_events.js 2016-07-06 03:42:25 +00:00
Rajesh Taneja d44fc20414 MDL-54844 mod_glossary: Don't append AND as it's done later 2016-07-06 11:34:18 +08:00
Andrew Nicols 06d05f461e Merge branch 'MDL-54165-master' of git://github.com/ryanwyllie/moodle 2016-07-06 11:04:40 +08:00
Ryan Wyllie f6bb3f482d MDL-54165 mod_assign: Collapsible review and grade panel 2016-07-06 02:50:24 +00:00
Andrew Nicols aa03ced86c MDL-54734 user: Add tests to demonstrate multi-user issues 2016-07-06 09:27:44 +08:00
Adrian Greeve 6c04427daa MDL-54844 mod_glossary: Limiting of glossary searching.
Searching of the glossary was returning results from all
glossaries on the site. It has now been returned to just
the glossary that you are currently viewing.
2016-07-06 09:20:32 +08:00
Eloy Lafuente (stronk7) 6e24e529c9 Merge branch 'wip-mdl-55043' of https://github.com/rajeshtaneja/moodle 2016-07-06 03:19:08 +02:00
Jerome Mouneyrac 6f08f36c49 MDL-46682 auth/db: IN clause crashes when too many users to sync 2016-07-06 09:18:41 +08:00
Rajesh Taneja 2648dddd2a MDL-55043 core_competency: Set proper sort order for each field 2016-07-06 08:12:13 +08:00
Eloy Lafuente (stronk7) a339f0dde0 Merge branch 'wip-mdl-54860-m' of https://github.com/rajeshtaneja/moodle 2016-07-06 01:42:34 +02:00
Rajesh Taneja 25fbce21e7 MDL-54860 behat: Stop execution if setup problem found 2016-07-06 07:27:41 +08:00
Andrew Nicols 6f9ad7e2db MDL-54951 webservice: Add upgrade notes for external_files 2016-07-06 07:23:32 +08:00
Eloy Lafuente (stronk7) 006e2b787a Merge branch 'MDL-54857-master' of git://github.com/jleyva/moodle 2016-07-06 00:03:39 +02:00
Eloy Lafuente (stronk7) f5be4e3d91 Merge branch 'MDL-54856-master' of git://github.com/jleyva/moodle 2016-07-05 21:18:41 +02:00
Eloy Lafuente (stronk7) ed2d12a125 Merge branch 'MDL-54955-master' of git://github.com/jleyva/moodle 2016-07-05 21:15:31 +02:00
Eloy Lafuente (stronk7) 8a8e436cf7 Merge branch 'MDL-54800-master' of git://github.com/jleyva/moodle 2016-07-05 21:10:28 +02:00
Eloy Lafuente (stronk7) 6880e350d3 Merge branch 'MDL-54602-master' of git://github.com/jleyva/moodle 2016-07-05 20:59:52 +02:00
Eloy Lafuente (stronk7) 1d44e47cc4 Merge branch 'MDL-54934-master' of https://github.com/nashtechdev01/moodle 2016-07-05 20:44:14 +02:00
Eloy Lafuente (stronk7) 4b7ac6023c Merge branch 'MDL-54867-master' of git://github.com/jleyva/moodle 2016-07-05 20:25:54 +02:00
Eloy Lafuente (stronk7) e51f7a6a20 Merge branch 'MDL-49244-master' of git://github.com/jleyva/moodle 2016-07-05 20:16:44 +02:00
Eloy Lafuente (stronk7) efb2517a2f Merge branch 'MDL-54795_master' of https://github.com/snake/moodle 2016-07-05 20:10:33 +02:00
Eloy Lafuente (stronk7) 6b43e964ac MDL-55000 grade: Use correct component names + minor jsdocs
Note the js_call_amd() call still is using incorrect 'grades'
as component name where it should be core_grades. That will be
fixed by MDL-55133.
2016-07-05 19:59:24 +02:00
Eloy Lafuente (stronk7) 17695e4b4d Merge branch 'MDL-55000-master' of git://github.com/andrewnicols/moodle 2016-07-05 19:35:56 +02:00
Eloy Lafuente (stronk7) 46da6e14ec Merge branch 'MDL-29738-master' of git://github.com/andrewnicols/moodle 2016-07-05 17:05:28 +02:00
Loc Nguyen e9bf00fb14 MDL-54832 workshop: adding landmark for userplantable
Accessibility enhance: add an aria-label on the userplan table so
that it's accessible to me through my screen reader
2016-07-05 20:37:56 +07:00
Andrew Nicols b5233f9bc9 MDL-55000 grade: Convert remaining YUI2 -> AMD 2016-07-05 20:07:46 +08:00
Andrew Nicols ff3778bf97 MDL-29738 file: Remove unused stylesheet functionality
This functionality was commented out in
78946b9bdb for MDL-20204 back in 2009.
Since then it has been wasting cycles performing utterly pointless
preg_match and preg_replace calls.

The decision has been made to deprecate it in stables, and remove it in
3.2.
2016-07-05 19:31:22 +08:00
Eloy Lafuente (stronk7) eb3b4893b5 Merge branch 'MDL-55114-master' of git://github.com/andrewnicols/moodle 2016-07-05 12:44:52 +02:00
Eloy Lafuente (stronk7) 5920c233fe Merge branch 'MDL-55113-master' of git://github.com/dpalou/moodle 2016-07-05 12:21:46 +02:00
Dan Poltawski 88dd8edf7b Merge branch 'MDL-54928-master' of git://github.com/dpalou/moodle 2016-07-05 11:20:07 +01:00
Dan Poltawski 27ade02c67 Merge branch 'MDL-54841-master' of https://github.com/nashtechdev01/moodle 2016-07-05 11:06:38 +01:00
Juan Leyva 8908432fab MDL-55128 course: Fix param type for shortname 2016-07-05 09:50:32 +01:00
Dani Palou 6f2815fa51 MDL-54928 notifications: Add username to emailto users 2016-07-05 10:34:52 +02:00
Juan Leyva 7c4e686f94 MDL-54943 webservice: New WS core_course_get_activities_overview 2016-07-05 09:10:13 +01:00
Juan Leyva 6e7bf3963b MDL-54869 webservice: Fix core_user_add_user_private_files 2016-07-05 09:01:35 +01:00
Juan Leyva 460897052e MDL-54869 files: Create new required functions
This was a complex change requiring three new functions:
file_merge_files_from_draft_area_into_filearea - To just add files from a draft area into a real one (just adding or updating, not deleting)
file_merge_draft_area_into_draft_area - To merge files from two draft areas, used by the latest for creating a draft area with all the original files plus the new ones.
file_overwrite_existing_draftfile - Required to update existing files not losing metadata or references.

The whole process is the following:

    User uploads a file (upload.php)
    Client gets a new draftid A containing the file only (return of upload.php)
    Client requests to merge that draftid in the user's private files (core_user_add_user_private_files)
    Server prepares a new UNUSED draftid B from existing area
    Server merges A into B
    Server saves the draft B into the final area
2016-07-05 09:01:34 +01:00
Juan Leyva d089e4984d MDL-54869 files: Fix file_save_draft_area_files documentation 2016-07-05 08:40:06 +01:00
Andrew Nicols 69efe54640 Merge branch 'MDL-53495' of https://github.com/mr-russ/moodle 2016-07-05 15:07:21 +08:00
Andrew Nicols 275480a0de MDL-51242 messageinbound: Guess the port from hostspec
Existing language strings for the host component suggest that the host can
be provided in the format hostname:port, but we previously did not support
this.

This patch explodes the string based on the colon character and assumes
that if there are two parts, that they are in the format hostname:port.

Note: This does not attempt to deal with full host specifications (e.g.
protocol://hostname:port), as this is beyond the scope of this change.
2016-07-05 14:52:53 +08:00
An Pham Van 1b0276d4bb MDL-54841 workshop: Combine links for attachment icon and text.
In a workshop activity, on the view submission page where having attachment(s), there's an accessibility issue.
There're 2 separate links for the icon and text which causes an issue for keyboard and screen reader users.
So the text and icon should be combined in one link.
2016-07-05 13:21:59 +07:00
Andrew Nicols f0cae2e019 Merge branch 'MDL-55001-home-noredirect' of https://github.com/brendanheywood/moodle 2016-07-05 14:15:36 +08:00
Jake Dallimore ea106d2a1d MDL-53431 tool_monitor: Access control for tool monitor subscriptions 2016-07-05 10:36:27 +08:00
Andrew Nicols 5e47d5aee5 Merge branch 'MDL-54951-master' of git://github.com/jleyva/moodle 2016-07-05 09:41:31 +08:00
Andrew Nicols 9778aa4e9c Merge branch 'MDL-54889-master' of git://github.com/danpoltawski/moodle 2016-07-05 09:27:17 +08:00
Andrew Nicols 8efafb4625 Merge branch 'MDL-53019' of git://github.com/stronk7/moodle 2016-07-05 08:48:54 +08:00
Eloy Lafuente (stronk7) 6981a039c8 MDL-53019 travis: Don't run 5.6 mysql unit tests and minor cleanup 2016-07-05 02:35:26 +02:00
Andrew Nicols 642a1d5480 Merge branch 'MDL-53019' of git://github.com/stronk7/moodle 2016-07-05 08:15:02 +08:00
Eloy Lafuente (stronk7) ae96cf6246 MDL-53019 php: bump all harcoded versions to new 5.6.5 requirement
Moodle 3.2 and up will require PHP >= 5.6.5. Hopefully some day we'll
have this centralized with MDL-39007, just it's not done yet.

Thanks to Stephen Bourget for raising this!
2016-07-05 01:50:43 +02:00
Rajesh Taneja 0908069407 MDL-50758 behat: Fixed string changes 2016-07-05 07:40:03 +08:00
Eloy Lafuente (stronk7) 68ddadc180 Merge branch 'wip-MDL-37946-master' of https://github.com/marinaglancy/moodle 2016-07-05 00:19:59 +02:00
Dan Poltawski c145e290a3 Merge branch 'MDL-48944_m32v4' of https://github.com/sbourget/moodle 2016-07-04 15:56:00 +01:00
Dan Poltawski 7fddfd3768 Merge branch 'MDL-55019-master' of git://github.com/jleyva/moodle 2016-07-04 15:29:19 +01:00
Dan Poltawski 1f0daa292e Merge branch 'MDL-54976-master' of git://github.com/junpataleta/moodle 2016-07-04 14:51:59 +01:00
Juan Leyva 6a1131e2c2 MDL-55019 webservice: Course summary text should not be cleaned 2016-07-04 14:51:14 +01:00
Dan Poltawski 98ebfabc13 Merge branch 'MDL-54994' of git://github.com/stronk7/moodle 2016-07-04 14:18:15 +01:00
Dan Poltawski 970fcc44e6 MDL-54980 mod_assign: bump version 2016-07-04 14:10:24 +01:00
Dan Poltawski 351e06e424 Merge branch 'MDL-54980-master' of git://github.com/jleyva/moodle 2016-07-04 14:09:43 +01:00
Dan Poltawski a335305f46 Merge branch 'MDL-50758' of https://github.com/creator23/moodle 2016-07-04 14:08:39 +01:00
Dan Poltawski 6e57e78652 Merge branch 'MDL-55032-master' of git://github.com/marinaglancy/moodle 2016-07-04 13:28:48 +01:00
Dan Poltawski 0cf471fbdd Merge branch 'MDL-55041_master' of https://github.com/marxjohnson/moodle 2016-07-04 12:45:55 +01:00
Dan Poltawski 2e6f52212f Merge branch 'MDL-41945-master' of git://github.com/cameron1729/moodle 2016-07-04 12:39:35 +01:00
Marina Glancy ed63718caa MDL-55069 core: escape special characters in email headers 2016-07-04 12:27:58 +01:00
Dan Poltawski 50d64a6efa Merge branch 'MDL-54794_master' of https://github.com/dg711/moodle 2016-07-04 10:52:56 +01:00
Juan Leyva 7ef49bd393 MDL-54951 webservice: Return intro text files in modules 2016-07-04 09:24:28 +01:00
Juan Leyva ae584b3b5e MDL-54951 webservice: Utility methods for generating a list of files
It includes a new external_files structure and a get_area_files method
in external_util
2016-07-04 09:24:27 +01:00
Dani Palou 5609da91fa MDL-55113 assign: Use PARAM_RAW in onlinetext text 2016-07-04 09:53:36 +02:00
Andrew Nicols e1ca4da750 MDL-55114 chat: Remove commented-out variables 2016-07-04 15:29:04 +08:00
Jun Pataleta ca7e2fc21f MDL-55112 mod_forum: Query all forum fields to avoid debug messages 2016-07-04 15:22:56 +08:00
Andrew Nicols bfccdb9600 Merge branch 'MDL-54953-master' of git://github.com/marinaglancy/moodle 2016-07-04 15:11:14 +08:00
Barbara Ramiro 40be0da500 MDL-54165 mod_assign: Layout icons for the new grading interface 2016-07-04 07:00:11 +00:00
Andrew Nicols ab698201d7 Merge branch 'MDL-55049-master' of git://github.com/jleyva/moodle 2016-07-04 14:16:54 +08:00
Andrew Nicols 91dc1e8795 Merge branch 'MDL-55053-master' of git://github.com/merrill-oakland/moodle 2016-07-04 14:04:23 +08:00
Andrew Nicols 0f6f3ccc3c Merge branch 'MDL-55057_scorm_apostrophe' of git://github.com/davosmith/moodle 2016-07-04 12:59:09 +08:00
Andrew Nicols 2110dead4f Merge branch 'wip-mdl-48114' of https://github.com/rajeshtaneja/moodle 2016-07-04 12:18:34 +08:00
Andrew Nicols 97e0cc8dbe Merge branch 'MDL-55050-master' of git://github.com/danpoltawski/moodle 2016-07-04 12:16:31 +08:00
Andrew Nicols 91e46852fc Merge branch 'MDL-54877-master-clean-on-output' of git://github.com/junpataleta/moodle 2016-07-04 11:52:05 +08:00
Cameron Ball c89d23ee6d MDL-41945 mod_assign: Properly check if submission is empty
Previous empty submission checks required the submission to
be saved to the database. This patch adds a new method to
submission plugins that lets them report whether the submission
is empty before it is saved.
2016-07-04 10:55:06 +08:00
Andrew Nicols 4ffe12b0f8 Merge branch 'MDL-55020-master-pluginzip' of git://github.com/mudrd8mz/moodle 2016-07-04 10:54:59 +08:00
Cameron Ball 16b36d376a MDL-41945 mod_assign: Check if submission has been modified
This patch adds a check that stops a user submitting an assignment
if someone else has modified it in the meantime.
2016-07-04 10:51:57 +08:00
Andrew Nicols c3d8f27a95 Merge branch 'MDL-54968-master' of git://github.com/marinaglancy/moodle 2016-07-04 10:21:06 +08:00
Andrew Nicols b4d0244b7c Merge branch 'MDL-53019' of git://github.com/stronk7/moodle 2016-07-04 09:07:39 +08:00
Eloy Lafuente (stronk7) 1de0b34bed Merge branch 'MDL-54947' of https://github.com/mr-russ/moodle 2016-07-04 01:05:12 +02:00
Stephen Bourget 1a99786ff8 MDL-48944 mod_survey: Add activity completion on submission 2016-07-03 15:34:11 -04:00
Devang Gaur 7dc0db7195 MDL-54794 user: added Users to globalsearch 2016-07-02 01:12:36 +05:30
AMOS bot 6e9f743b13 Automatically generated installer lang files 2016-07-02 00:04:54 +08:00
Mark Johnson 4d9036d6eb MDL-55041 roles: Fix JSON parsing in permission manager 2016-07-01 14:54:01 +01:00
Juan Leyva ff092320a7 MDL-54867 webservice: Document webservice/upload.php deprecation
The 'private' file area is not supported anymore, only 'draft' is
supported right now.
2016-07-01 13:13:54 +01:00
Loc Nguyen ddc9cff68b MDL-54934 workshop: indicate current phase
Indicate phase in page titles, current phase in userplan table
so that it's accessible to me through my screen reader
2016-07-01 19:08:53 +07:00
Eloy Lafuente (stronk7) 9f29c65180 MDL-53019 travis: adjust runs to use PHP 5.6 2016-07-01 13:58:18 +02:00
Eloy Lafuente (stronk7) 59f22d4b19 MDL-53019 environment: 3.2 requirements added
Changes:
 - PHP 5.6.5 required
2016-07-01 13:44:36 +02:00
Eloy Lafuente (stronk7) a763bb0553 MDL-54994 badges: Count correctly the number of external badges shown 2016-07-01 13:40:47 +02:00
Jun Pataleta 9f83ce7e0c MDL-54976 mod_scorm: Add validation for availability dates 2016-07-01 14:50:20 +08:00
Jake Dallimore 9e12b0faf7 MDL-54795 mod_assign: Fix notifications JS error in grading interface 2016-07-01 13:49:02 +08:00
Dani Palou 3ce71f4eef MDL-54928 notifications: Retrieve username from DB if empty 2016-07-01 07:45:21 +02:00
Marina Glancy 799e001c15 MDL-55032 tool_lp: check access when showing link to competencies
Also if course competencies page is accessed without capabilities do
redirect before starting output.
2016-07-01 13:42:27 +08:00
Andrew Nicols ac8d6cff54 weekly release 3.2dev 2016-07-01 10:20:17 +08:00
Andrew Nicols 762499bcd4 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-07-01 10:20:11 +08:00
David Mudrák 2785fd193d MDL-55020 admin: Fix renaming of the plugin package root folder
There was a problem with core\update\code_manager::unzip_plugin_file()
if it was used to extract a plugin package into a non-empty target
directory and the plugin package root folder was being renamed at the
same time.

The problem was caused by the underlying helper method
rename_extracted_rootdir() that worked only for ZIPs extracted to an
empty temporary location. When the plugin was extracted to the actual
dirroot with other existing plugin folders present, the method failed
badly.

The solution in the patch is to always extract the ZIP into a temporary
empty location, perform the eventual root renaming there, and only then
move the extracted contents to the final destination. Additionally we
are changing the behaviour of the rename_extracted_rootdir() method so
that now it throws exception if the plugin package contains multiple
root folders (it should not happen in normal situations as such a plugin
would not pass the pre-install validation).

Unit tests did not catch this bug before because in the tests, the
target directory had been empty. Now we are adding a new directory
"aaa_another" to the target location to test in more realistic
environment. Tests for the new behaviour of the renaming method are
added, too.

p.s. I noticed that moodle_exception class was not imported into the
namespace and this is fixed now too (and covered with unit tests).
2016-07-01 01:13:21 +02:00
Anant 4358ee3892 MDL-50758 qtype_multichoice: Displays multiple correct answers 2016-06-30 10:40:38 -07:00
Eric Merrill 55b62370aa MDL-55082 search: Update core areas to return results in time ASC order 2016-06-30 11:11:35 -04:00
Juan Leyva b8b1be1554 MDL-49244 course: Clean parameters in core_course_get_categories 2016-06-30 13:26:54 +01:00
Dan Poltawski 1fe7dfd9f0 MDL-32135 mod_choice: fix behat tests 2016-06-30 09:24:59 +01:00
Stephen Bourget 7c2041b64d MDL-32135 mod_choice: update behat tests 2016-06-30 09:24:59 +01:00
Andrew Nicols 48d1322527 Merge branch 'MDL-54610_master' of https://github.com/snake/moodle 2016-06-30 09:24:58 +01:00
Eloy Lafuente (stronk7) 47d986828e Merge branch 'wip-MDL-47113-master' of git://github.com/abgreeve/moodle 2016-06-30 09:24:58 +01:00
Eloy Lafuente (stronk7) 4a365babb6 Merge branch 'MDL-54855-master' of git://github.com/crazyserver/moodle 2016-06-30 09:24:57 +01:00
Dan Poltawski 41c18b9681 Merge branch 'MDL-54104-master' of git://github.com/jleyva/moodle 2016-06-30 09:24:57 +01:00
Dan Poltawski ab8ef75406 Merge branch 'MDL-55022-master' of git://github.com/junpataleta/moodle 2016-06-30 09:24:56 +01:00
Dan Poltawski 941b725693 Merge branch 'MDL-55027_master' of git://github.com/markn86/moodle 2016-06-30 09:24:56 +01:00
Dan Poltawski 5fd469e921 Merge branch 'MDL-54993' of https://github.com/sk-unikent/moodle 2016-06-30 09:24:56 +01:00
Dan Poltawski bb2c042b96 Merge branch 'MDL-32135_m32v2' of https://github.com/sbourget/moodle 2016-06-30 09:24:55 +01:00
Dan Poltawski be7d86e8ce Merge branch 'MDL-54865-master' of git://github.com/ryanwyllie/moodle 2016-06-30 09:24:55 +01:00
Dan Poltawski 5f4d957c21 MDL-54889 jshint: stop using for everything but shifter
Now jshint has been replaced by eslint.
2016-06-30 09:14:57 +01:00
Jun Pataleta 5c1b749d55 MDL-54877 mod_lti: Clean LTI tool type name and description on output
* Use clean_param() for name and description when displaying the tool type.
    Basically in the following functions:
    - serialise_tool_type()
    - lti_get_configured_types()
* Changed name and description's type from PARAM_TEXT to PARAM_RAW
    in tool update parameters.
* Changed name and description's type from PARAM_TEXT to PARAM_RAW
   in mod_lti_external::tool_type_return_structure()
2016-06-30 15:55:43 +08:00
Russell Smith 1b0b082a08 MDL-54947 database: Update PostgreSQL binary handling.
PostgreSQL 9.1 allows hex formating for binary which is handled better
by pg_query_params().

Getting bytea isn't required on connection, it can be used as pg_field_type()
when binary needs to be checked.
2016-06-30 12:58:53 +10:00
Davo Smith 3bc7382d10 MDL-55057 mod_scorm: fix handling of SCO identifiers with apostrophes 2016-06-29 08:44:24 +01:00
Dan Poltawski 77369c8171 Merge branch 'MDL-54868-master' of git://github.com/cameron1729/moodle 2016-06-29 15:05:26 +08:00
Dan Poltawski ce63e9b2d7 Merge branch 'MDL-55002-master-enfix' of git://github.com/mudrd8mz/moodle 2016-06-29 15:05:25 +08:00
Andrew Nicols ea5241410d Merge branch 'MDL-54991-master' of git://github.com/crazyserver/moodle 2016-06-29 15:05:24 +08:00
Andrew Nicols df4b55e05b Merge branch 'MDL-54909-master' of git://github.com/crazyserver/moodle 2016-06-29 15:05:23 +08:00
Andrew Nicols 628c52e465 Merge branch 'MDL-54601-master' of git://github.com/jleyva/moodle 2016-06-29 15:05:22 +08:00
Andrew Nicols 3654734601 Merge branch 'MDL-54910_m32v2' of https://github.com/sbourget/moodle 2016-06-29 15:05:20 +08:00
Andrew Nicols be88488274 Merge branch 'MDL-54911_m32v3' of https://github.com/sbourget/moodle 2016-06-29 15:05:19 +08:00
Andrew Nicols 53190b8077 MDL-54755 core: Correct behat language 2016-06-29 15:05:18 +08:00
Andrew Nicols ffcbabcdd0 Merge branch 'MDL-54755_master' of https://github.com/StudiUM/moodle 2016-06-29 15:05:17 +08:00
Andrew Nicols e1ac41ecc4 Merge branch 'MDL-54935_m32v1' of git://github.com/sbourget/moodle 2016-06-29 15:05:16 +08:00
Andrew Nicols e683c0837c Merge branch 'MDL-54964-master' of git://github.com/jleyva/moodle 2016-06-29 15:05:15 +08:00
Andrew Nicols f9cabe8f99 Merge branch 'wip-mdl-54974' of https://github.com/rajeshtaneja/moodle 2016-06-29 15:05:13 +08:00
Eric Merrill a02fe723dd MDL-55053 search: Display search areas in alphabetical order 2016-06-28 17:19:09 -04:00
Eric Merrill 4e2b5191d4 MDL-54926 search: Reduce over-escaping in results 2016-06-28 16:33:29 -04:00
Dan Poltawski a382101c6e MDL-55050 grunt: make eslint only build changed files on watch
Previously a watch change was causing eslint to be re-run on every file.
2016-06-28 18:21:29 +01:00
Juan Leyva 7a8744dba7 MDL-55049 webservice: Scan for viruses in webservice/upload.php 2016-06-28 16:14:16 +01:00
Cameron Ball 94ada0eaf7 MDL-54868 webservice_xmlrpc: Don't escape non-ascii characters 2016-06-28 14:41:20 +08:00
David Mudrák 46994de566 MDL-55002 lang: Fix behat scenarios using modified strings 2016-06-27 22:57:34 +02:00
Eloy Lafuente (stronk7) 22a0896767 Merge branch 'MDL-55028-master' of git://github.com/junpataleta/moodle 2016-06-27 22:13:48 +02:00
Helen Foster 25558b808e MDL-55002 lang: Merge English strings from the en_fix language pack 2016-06-27 22:03:40 +02:00
Eloy Lafuente (stronk7) d4ca1215bb Merge branch 'MDL-54599-31' of git://github.com/vadimonus/moodle 2016-06-27 20:38:18 +02:00
Eloy Lafuente (stronk7) f8ca380b47 Merge branch 'MDL-54997-master' of git://github.com/damyon/moodle 2016-06-27 20:22:14 +02:00
Eloy Lafuente (stronk7) 74eb5bb9fe Merge branch 'MDL-54707_master' of git://github.com/dmonllao/moodle 2016-06-27 20:00:43 +02:00
Eloy Lafuente (stronk7) 0efd933a1f Merge branch 'MDL-54900-master' of git://github.com/marinaglancy/moodle 2016-06-27 18:53:23 +02:00
AMOS bot 1ac8c71f4b Automatically generated installer lang files 2016-06-28 00:05:34 +08:00
Eloy Lafuente (stronk7) bc413a6078 Merge branch 'MDL-52887-master' of git://github.com/marinaglancy/moodle 2016-06-27 16:13:25 +02:00
Eloy Lafuente (stronk7) f780baf063 Merge branch 'MDL-54663-master' of git://github.com/andrewnicols/moodle 2016-06-27 13:26:34 +02:00
Juan Leyva 64d2ac2145 MDL-54964 tool_mobile: Fix tests to make it work with non-core plugins 2016-06-27 09:45:23 +01:00
Juan Leyva 5b76f88cb5 MDL-54602 webservice: Remove core_grades_update_grades from mobile 2016-06-27 08:44:11 +01:00
Pau Ferrer Ocaña ff6de75396 MDL-54991 assign: Invalid submissiongroup when not using groups 2016-06-27 09:24:29 +02:00
Marina Glancy 17c78cceb0 MDL-54968 user: change query for resetting dashboard
In case of inconsistent data the fatal error could have happen.
Also improve performance by joining several queries into one.
2016-06-27 15:08:24 +08:00
Rajesh Taneja e5f2478b9f MDL-54974 behat: Handle interupts on PHP7
As https://bugs.php.net/bug.php?id=71448 is
not going to get fixed, we need to declare tick
2016-06-27 14:30:58 +08:00
Jun Pataleta ead440b649 MDL-55028 webservice_soap: Use strlen for setting Content-Length header 2016-06-27 13:59:20 +08:00
Andrew Nicols 623395ff7b Merge branch 'MDL-53111_m32v1' of https://github.com/sbourget/moodle 2016-06-27 13:30:51 +08:00
Mark Nelson a802be7e39 MDL-55027 enrol_lti: avoid invalid image URL causing an exception 2016-06-27 13:27:23 +08:00
Andrew Nicols 04b189a875 Merge branch 'MDL-54924-master' of git://github.com/junpataleta/moodle 2016-06-27 12:53:35 +08:00
Marina Glancy 540200aee5 MDL-54900 mod_choice: correctly count number of answered users 2016-06-27 12:47:49 +08:00
Jun Pataleta eb55f72d63 MDL-55022 mod_lti: Fix undefined variable 2016-06-27 11:40:03 +08:00
Andrew Nicols 607e900e2d Merge branch 'MDL-54785-master' of git://github.com/FMCorz/moodle 2016-06-27 08:59:49 +08:00
David Monllao 25ba053ff2 MDL-54707 search: Add user context to get_areas_user_accesses 2016-06-26 21:23:16 +02:00
Damyon Wiese e824cd502d MDL-54997 competencies: Fix random unit test fail
Sorting on timecreated is not unique enough to
guarantee a predictable ordering.
2016-06-25 08:04:15 -07:00
Juan Leyva 9df9f1f096 MDL-54104 webservice: Return section number in WS get_course_contents 2016-06-24 13:55:04 +01:00
Jake Dallimore f56cbd3bbf MDL-54610 mod_lti: Fix cartridge support for admin tool add/edit forms 2016-06-24 14:14:28 +08:00
Gilles-Philippe Leblanc 975bd11258 MDL-54755 core: Incorrect redirection after password change 2016-06-23 21:24:29 -04:00
Stephen Bourget 443ab2cea9 MDL-54911 mod_feedback: start date should be before the end date 2016-06-23 17:39:48 -04:00
Stephen Bourget 316f20a0b6 MDL-54910 mod_data: Open dates should be before close dates 2016-06-23 17:32:19 -04:00
Stephen Bourget 5d3821ebcc MDL-32135 mod_choice: Open time should be before close time 2016-06-23 17:21:27 -04:00
Damyon Wiese da880d320c MDL-54997 competencies: Listing evidence contexts
When listing the evidence for a user competency in a course,
the query is missing evidences for sub-contexts in the course.
2016-06-23 09:14:19 -07:00
Pau Ferrer Ocaña 36f1d79ea2 MDL-54909 assign: Style editpdf background to differ from page bg 2016-06-23 15:06:59 +02:00
Pau Ferrer Ocaña 796161018c MDL-54855 assign: Add missing field in get_assignments 2016-06-23 15:05:17 +02:00
Brendan Heywood a181471f4e MDL-55001 theme_clean: Avoid redirects in home url 2016-06-23 17:27:52 +10:00
Andrew Nicols b8474fe0c7 weekly release 3.2dev 2016-06-23 14:49:30 +08:00
Andrew Nicols de2f6d840a Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-06-23 14:49:25 +08:00
Frederic Massart df52c272cf MDL-54785 files: Deprecate the support for $usepost and related 2016-06-23 12:41:03 +08:00
Luca Bösch 013abd64cd MDL-54865 grade: student name hyperlinked in gradebook user report
In the Gradebook, User report, the student's name (at the top) is a hyperlink
to that student's account. In most places where a student's name shows
(e.g. the Grader report) it is most often a hyperlink.
2016-06-23 04:22:10 +00:00
Frederic Massart 4f9b94fdd5 Revert "MDL-44626 files: Show the PHP max upload size instead of 'unlimited'"
This reverts commit 6f0768618a.
2016-06-23 11:51:44 +08:00
Frederic Massart 048f8073d1 Revert "Merge branch 'MDL-54110_master' of https://github.com/marxjohnson/moodle"
This reverts commit 016e0abfbc, reversing
changes made to 58a2f0ac40.
2016-06-23 11:51:44 +08:00
Frederic Massart 796f86f753 Revert "MDL-54110 repositories: Whitespace, Typo + unit test fixes"
This reverts commit 7e4d43e1a2.
2016-06-23 11:51:44 +08:00
Andrew Nicols 0f56ea9d2f Merge branch 'MDL-54948-master-fix2' of https://github.com/lameze/moodle 2016-06-23 10:50:14 +08:00
Simey Lameze 37eafbb6dc MDL-54948 core_files: return false if theres no output from unoconv 2016-06-23 08:37:23 +08:00
Skylar Kelty a5deab2d72 MDL-54993 search: Provide areaid parts to template 2016-06-22 14:51:59 +01:00
Andrew Nicols 797b7efc0b Merge branch 'MDL-35104-master-fix' of https://github.com/cameron1729/moodle 2016-06-22 14:57:09 +08:00
Andrew Nicols 1331869eb2 Merge branch 'MDL-54948-master-fix' of https://github.com/lameze/moodle 2016-06-22 14:43:35 +08:00
Cameron Ball 6a80681112 MDL-35104 auth: Always allow editing username for new users 2016-06-22 13:59:39 +08:00
Marina Glancy dcd320b5ad MDL-52887 mod_choice: backup allowmultiple option 2016-06-22 13:51:36 +08:00
Simey Lameze 84440fe3d2 MDL-54948 core_upgrade: fix check_unoconv_version logic 2016-06-22 13:44:48 +08:00
Andrew Nicols d1a62a5046 MDL-54663 forum: Correct digest link to forum preferences 2016-06-22 13:11:23 +08:00
Marina Glancy d74d4f4aab MDL-54953 mod_chat: remove Safari hack
This hack was introduced in MDL-16878 and is not needed in modern Safari versions
but it was reported that it can breaks chat in IE
2016-06-22 12:21:40 +08:00
Andrew Nicols 6c8e98ddd2 Merge branch 'wip-mdl-53399' of https://github.com/rajeshtaneja/moodle 2016-06-22 09:10:19 +08:00
Rajesh Taneja f34ab57411 MDL-53399 behat: Activity chooser link is removed. 2016-06-22 09:07:31 +08:00
Eloy Lafuente (stronk7) 0f20bf7507 Merge branch 'wip-mdl-54589-mac' of https://github.com/rajeshtaneja/moodle 2016-06-22 01:42:15 +02:00
Eloy Lafuente (stronk7) e40dd1cdcd MDL-54778 form: Make it all js style (eslint) compliant
The changes in this commit should not be problematic, just:

- different whitespace.
- some docs.
- 1 variable to camelCase.

And then, less trivial, but safe enough IMO:

- a change to camelCase some identifiers and their calculation.
2016-06-22 01:29:51 +02:00
Eloy Lafuente (stronk7) 0f30b4beeb Merge branch 'MDL-54778-master' of git://github.com/andrewnicols/moodle 2016-06-22 01:29:39 +02:00
Dan Poltawski 6a6b0085e0 Merge branch 'MDL-54983-master' of git://github.com/damyon/moodle 2016-06-21 12:56:32 -07:00
Damyon Wiese 0edd7bd7bd MDL-54983 docs: Improve phpdocs for create_user_key
Also fixed the docs for get_user_key.
2016-06-21 12:46:59 -07:00
Eloy Lafuente (stronk7) e822312af3 Merge branch 'MDL-54939-master' of git://github.com/danpoltawski/moodle 2016-06-21 20:00:36 +02:00
AMOS bot 9c084c424f Automatically generated installer lang files 2016-06-22 00:06:06 +08:00
Juan Leyva 23717c804d MDL-54980 mod_assign: Add WS list_participants to the Mobile service 2016-06-21 15:30:58 +01:00
Juan Leyva 833be5e410 MDL-54629 webservice: Change required parameters in external_format_text
component, filearea and itemid are now optional parameters.
In some contexts those parameteres are not necessary because is not
required to do a file rewrite via file_rewrite_pluginfile_urls
2016-06-21 12:16:25 +01:00
Andrew Nicols 6a359c20fb Merge branch 'wip-mdl-54940' of https://github.com/rajeshtaneja/moodle 2016-06-21 19:00:33 +08:00
Rajesh Taneja f0be6b892e MDL-54940 behat: No need to press save
Previous step press save button, so no need to press again
2016-06-21 18:53:03 +08:00
Eloy Lafuente (stronk7) 878835db7f Merge branch 'MDL-54948-master' of git://github.com/lameze/moodle 2016-06-21 11:48:10 +02:00
Tobias Reischmann c05f3109d0 MDL-54892 core: Pass proper parameter for plugin uninstall queries 2016-06-21 09:20:54 +02:00
Andrew Nicols 3584865b3a MDL-51789 users: Correct deprecation version 2016-06-21 14:59:00 +08:00
Andrew Nicols 92e4d84b62 Merge branch 'MDL-51789' of https://github.com/mr-russ/moodle 2016-06-21 14:38:51 +08:00
Russell Smith 5407c5b0f4 MDL-51789 users: Allow picture update from webservices.
useredit_update_picture as moved to user_update_picture
as it's more general.  It was also moved to user/lib.php
so it can be used by both webservices and edit without more include files.
2016-06-21 16:36:53 +10:00
Andrew Nicols bc341d4f08 Merge branch 'MDL-54920-master' of https://github.com/sammarshallou/moodle 2016-06-21 14:15:41 +08:00
Andrew Nicols 65126de122 Merge branch 'MDL-54894-master' of git://github.com/crazyserver/moodle 2016-06-21 12:09:09 +08:00
Andrew Nicols 0871afcd5f Merge branch 'MDL-54940-master' of https://github.com/LukeCarrier/moodle 2016-06-21 11:53:05 +08:00
Andrew Nicols 4a837c7ba0 Merge branch 'MDL-54881' of https://github.com/mr-russ/moodle 2016-06-21 11:31:19 +08:00
Andrew Nicols ad6b958997 Merge branch 'MDL-54652-master' of git://github.com/danpoltawski/moodle 2016-06-21 11:26:42 +08:00
Andrew Nicols b3f25cbfbf Merge branch 'MDL-35104-master-2' of git://github.com/cameron1729/moodle 2016-06-21 11:18:03 +08:00
Cameron Ball 8c2b696bf7 MDL-35104 auth: Don't allow modification of username
Presently it is either unreliable, or not possible to change
the username of a user created with an authentication plugin.
In some cases it is even hard coded to fail. Ideally we would
sync the username, and the issue MDL-21928 exists to address
that. However, in the mean time we should not allow the
username of an external user to be modified.
2016-06-21 11:15:19 +08:00
Andrew Nicols 8a46580603 Merge branch 'MDL-51505-master' of git://github.com/FMCorz/moodle 2016-06-21 10:30:22 +08:00
Andrew Nicols 62d34a4af2 Merge branch 'MDL-54654-master' of git://github.com/danpoltawski/moodle 2016-06-21 09:58:18 +08:00
Simey Lameze 6937d89be6 MDL-54948 core_upgrade: fix unoconv check on the environment page 2016-06-21 09:38:01 +08:00
Simey Lameze 9254ba09e8 MDL-54948 core_files: make the check consistent on unoconv test page 2016-06-21 09:36:44 +08:00
Andrew Nicols c6d20e61e3 Merge branch 'wip-MDL-53399' of https://github.com/JoeyAndres/moodle 2016-06-21 09:03:48 +08:00
Andrew Nicols da871bb4c1 Merge branch 'wip-MDL-53292-master' of https://github.com/marinaglancy/moodle 2016-06-21 08:46:38 +08:00
Andrew Nicols badbaa64e3 MDL-54778 form: Fix lots of issues with form dependencies
The original issue here was that each loop of the named values did not
check for prototypal properties. As a result, if there were input fields
with names such as 'sort', 'valueOf', 'constructor', etc. these would
return their prototypal functions instead of a falsy value, and be treated
as though they are array - hence the 'Cannot push to Function' type error.

Following on from this I discovered that the data stores were being created
as arrays, but used as objects. This can also cause issues with some form
input names -- e.g. if they are numeric.

These two issues were resolved together by correctly storing them in
objects, and checking that those objects had real properties
(hasOwnProperty). This itself has to use the prototypal function to cater
for the potential of a field name called 'hasOwnProperty'.

I also found that the instance value stores were being initialised in the
prototype (and therefore shared), which meant that there were numerous
issues if two forms were present on the same page, or one form replaced an
existing one (e.g. forms initialised in JS).

In addition, it also became apparant that several values were being used
outside of scope, or in the wrong scope. This caused further issues when
creating multiple forms on a page.
2016-06-21 07:58:13 +08:00
Rajesh Taneja 481a5ee517 MDL-54589 behat: Update composer to point to new tag 2016-06-21 06:31:42 +08:00
Russell Smith 8675453e82 MDL-54881 quiz: Ensure user attempts are deterministic for testing. 2016-06-21 08:31:26 +10:00
Eloy Lafuente (stronk7) 795150c550 Merge branch 'MDL-37554-master-test' of git://github.com/cameron1729/moodle 2016-06-21 00:03:45 +02:00
AMOS bot 8e4ab79297 Automatically generated installer lang files 2016-06-21 00:05:07 +08:00
AMOS bot 11070d8d28 Automatically generated installer lang files 2016-06-21 00:05:06 +08:00
Juan Leyva d889b58747 MDL-54955 webservice: Apply external_format_string in course names 2016-06-20 13:16:52 +01:00
Rajesh Taneja f55d87c55c MDL-54589 behat: Fixed failures for phantomjs standalone 2016-06-20 16:03:36 +08:00
Rajesh Taneja 6a51c58542 MDL-54589 behat: Don't allow floating headers for behat 2016-06-20 16:03:36 +08:00
Rajesh Taneja fba0ac63b8 MDL-54589 behat: Added hack for some OS/browsers 2016-06-20 16:03:36 +08:00
Pau Ferrer Ocaña 6f26fcd7e0 MDL-54894 comments: Get course from context if not informed 2016-06-20 08:58:05 +02:00
Jun Pataleta a2d5c332a2 MDL-54924 tool_lp: Make the url property optional 2016-06-20 14:57:10 +08:00
Adrian Greeve ccc9777aee MDL-47113 mod_lti: Use of html_writer rather than hard coded HTML. 2016-06-20 14:49:04 +08:00
Ben Kelada b346737e75 MDL-47113 lti: Add link to open in new window, when popup blocked 2016-06-20 14:39:39 +08:00
Andrew Nicols 5c3de4fe55 Merge branch 'wip-MDL-54590-master-test' of git://github.com/abgreeve/moodle 2016-06-20 14:09:54 +08:00
Vadim Dvorovenko 68b50753ae MDL-54590 Installer: Additional info about database name
Additional info that creating database name containing dots is not
   supported
2016-06-20 14:06:14 +08:00
Andrew Nicols 0256b7a620 Merge branch 'MDL-51163-master' of git://github.com/cameron1729/moodle 2016-06-20 11:09:47 +08:00
Rajesh Taneja 6a021f59f3 MDL-54589 group: ensure loader is available before remobing 2016-06-20 09:43:08 +08:00
Rajesh Taneja 3aaf98f62c MDL-54589 behat: Trigger change event after selecting option
After selecting option, some browsers need
explicit change event
2016-06-20 09:43:08 +08:00
Luke Carrier a48f2d3d90 MDL-54940 behat: use the fixed step 2016-06-19 17:22:17 +01:00
Luke Carrier 3ceaea2638 MDL-54940 behat: rectify section edit regression in MDL-53381 2016-06-19 17:11:31 +01:00
AMOS bot 933de74287 Automatically generated installer lang files 2016-06-20 00:04:39 +08:00
AMOS bot a399892bfc Automatically generated installer lang files 2016-06-19 00:06:02 +08:00
Dan Poltawski 7f70d548fe MDL-54939 amd: build modified files 2016-06-17 09:03:18 +01:00
Dan Poltawski c96f55e6f9 MDL-54939 amd: fix lint issues
Mostly correcting jsdoc, some other line wrapping rules and empty
functions.
2016-06-17 09:03:18 +01:00
Dan Poltawski 926ac16ef3 MDL-54654 mod: fix forum/scorm invalid css 2016-06-16 20:52:04 +01:00
Dan Poltawski c6eddafcad MDL-54654 mod_data: fix invalid css for image gallery preset 2016-06-16 20:52:04 +01:00
Dan Poltawski f909e9e5a9 MDL-54654 choice: remove CSS definitions
The 'inherit' for border colour was not valid and so no border was
displayed.

The display:inline does not work with floated elemenets.
2016-06-16 20:52:04 +01:00
Dan Poltawski 48d5c2183a MDL-54654 choice: reformat CSS 2016-06-16 20:52:04 +01:00
Dan Poltawski f567699fe4 MDL-54654 book: silence csslint warning
(Important is by design for print layout)
2016-06-16 20:52:04 +01:00
Dan Poltawski 4c62bdab0d MDL-54654 assignfeedback_editpdf: remove invalid CSS
The 'left' positioing was invalid and conflicting with the
right definition anyway, so wasn't necessary.
2016-06-16 20:52:04 +01:00
Dan Poltawski cc3ca25e57 MDL-54652 singleview: remove invalid css decleration
margin-bottom can't be used with display: inline, so use padding
instead.
2016-06-16 20:49:04 +01:00
Dan Poltawski 9072631311 MDL-54652 grade_report: fix css lint issues
max-width: initial isn't valid css and in my testing it makes no
difference, so is removed.

We also remove invalid css on exception.

This reverts commit 72ece42858
2016-06-16 20:49:04 +01:00
Dan Poltawski f3ac852859 MDL-54652 block_community: remove unused css
Fixing lint errors
2016-06-16 20:49:04 +01:00
Dan Poltawski 8a802c9032 MDL-54652 filter_mediaplugin: refomat css 2016-06-16 20:49:04 +01:00
Dan Poltawski d8b5fb1255 MDL-54652 filter_mediaplugin: removed unused invalid css
It is override by core styles anyway.
2016-06-16 20:49:04 +01:00
Dan Poltawski 64527edca2 MDL-54652 tool_lp: remove invalid css on comeptency menu bar 2016-06-16 20:49:04 +01:00
Dan Poltawski c74b305dfa MDL-54652 tool_health: make css more specific to avoid '!important'
This admin tool is unsupported anyway..
2016-06-16 20:49:04 +01:00
Dan Poltawski 0d06a20038 MDL-54939 eslint: tweak rules
1) Allow jsdoc descriptions to be empty. I think that matches our phpdoc
checker, and I think its probably better than me filling the
descriptions in poorly.

2) For the captilisation rules, don't apply to object properties (this
is because jQuery has lots of violators of this rule)
2016-06-16 19:33:00 +01:00
Dan Poltawski 35be582696 MDL-54939 amd: Fix lint issues fixable with eslint --fix 2016-06-16 19:33:00 +01:00
Eloy Lafuente (stronk7) 49619ce243 weekly release 3.2dev 2016-06-16 17:01:29 +02:00
Eloy Lafuente (stronk7) badd6b2344 NOBUG: Fixed SVG browser compatibility 2016-06-16 17:01:25 +02:00
Juan Leyva 0002056f7a MDL-54857 tool_mobile: New WS get_site_public_settings 2016-06-16 11:26:35 +01:00
Andrew Nicols eddf7994f0 Merge branch 'MDL-52127-eloy' of https://github.com/danpoltawski/moodle 2016-06-16 09:04:17 +01:00
Andrew Nicols c3081f9fac Merge branch 'wip-mdl-54899' of git://github.com/rajeshtaneja/moodle 2016-06-16 09:04:16 +01:00
Andrew Nicols d91b6854e9 Merge branch 'MDL-45762-master' of https://github.com/xow/moodle 2016-06-16 09:04:16 +01:00
Andrew Nicols a029e5212d Merge branch 'MDL-53788_modlti_master' of git://github.com/nhoobin/moodle 2016-06-16 09:04:15 +01:00
Andrew Nicols 00f99e270a Merge branch 'MDL-54649-master' of git://github.com/danpoltawski/moodle 2016-06-16 09:04:14 +01:00
Andrew Nicols 5869e4b74f Merge branch 'MDL-54559-int-master' of https://github.com/merrill-oakland/moodle 2016-06-16 09:04:14 +01:00
Eric Merrill 9c6a38063b MDL-54559 theme: Recenter search box 2016-06-16 09:04:13 +01:00
Dan Poltawski 0fd08fc7e5 Merge branch 'MDL-35628' of https://github.com/mr-russ/moodle 2016-06-16 09:04:12 +01:00
Dan Poltawski 7d78a2eee2 Merge branch 'MDL-54563-master' of git://github.com/cameron1729/moodle 2016-06-16 09:04:12 +01:00
Dan Poltawski d7c9327d48 Merge branch 'MDL-51749-master' of git://github.com/junpataleta/moodle 2016-06-16 09:04:11 +01:00
Dan Poltawski 134e4566ff Merge branch 'MASTER_MDL-53306' of https://github.com/jacac/moodle 2016-06-16 09:04:10 +01:00
Dan Poltawski 435fb13814 Merge branch 'MDL-54617-master' of git://github.com/cameron1729/moodle 2016-06-16 09:04:10 +01:00
Dan Poltawski 4f400df523 Merge branch 'MDL-54036_master' of https://github.com/liorgil/moodle 2016-06-16 09:04:09 +01:00
Dan Poltawski b08523598b Merge branch 'MDL-54622_m32v1' of https://github.com/sbourget/moodle 2016-06-16 09:04:09 +01:00
Andrew Nicols 62bc2e84c5 Merge branch 'MDL-54712-master' of git://github.com/junpataleta/moodle 2016-06-16 09:04:08 +01:00
Andrew Nicols 168b1d9885 Merge branch 'MDL-54559-master' of git://github.com/junpataleta/moodle 2016-06-16 09:04:08 +01:00
Andrew Nicols 45a0932a9e Merge branch 'MDL-54797' of git://github.com/aolley/moodle 2016-06-16 09:04:07 +01:00
Andrew Nicols 337ee7ffa2 Merge branch 'MDL-54787_master' of https://github.com/snake/moodle 2016-06-16 09:04:07 +01:00
Andrew Nicols 1e7aaed887 Merge branch 'MDL-54576_themeSelector' of https://github.com/mrmark/moodle 2016-06-16 09:04:06 +01:00
Andrew Nicols de0298d5fd Merge branch 'MDL-54859_master' of git://github.com/dmonllao/moodle 2016-06-16 09:04:05 +01:00
Andrew Nicols bb15b62ce8 Merge branch 'MDL-52127-master' of git://github.com/danpoltawski/moodle 2016-06-16 09:04:05 +01:00
Andrew Nicols 860f76e11e Merge branch 'MDL-51978-master' of https://github.com/jtc/moodle 2016-06-16 09:04:04 +01:00
Eloy Lafuente (stronk7) 392c40467f Merge branch 'MDL-54890-master' of git://github.com/danpoltawski/moodle 2016-06-16 09:04:04 +01:00
Dan Poltawski d13f2a6934 Merge branch 'MDL-51683-master' of git://github.com/FMCorz/moodle 2016-06-16 09:04:03 +01:00
Stephen Bourget 77971021ff MDL-54935 Survey: Remove duplicate event trigger 2016-06-15 17:09:17 -04:00
Juan Leyva 27c7ed0b2e MDL-54800 core_enrol: Return category id in WS get_users_courses 2016-06-15 15:59:07 +01:00
Dan Poltawski f8731225f9 MDL-52127 grunt: add .eslingingore file, keep task
Eloy prefers we keep the ignorefiles grunt task
2016-06-15 15:52:34 +01:00
Juan Leyva 89823b1ae3 MDL-54601 webservice: Order services function list by name 2016-06-15 15:40:55 +01:00
Juan Leyva 331e038b2e MDL-54856 webservice: Add core_course_get_categories to mobile service 2016-06-15 15:05:52 +01:00
Guy Thomas 8e61e0f9b9 MDL-45762 course: Error when accessing a conditionally hidden section
Show a nice error when the user accidentally views a section
that is conditionally hidden.  Otherwise, continue to show
original error when section is just hidden to them.
2016-06-15 09:53:35 +08:00
Nicholas Hoobin 1512f61710 MDL-53788 multilangupgrade: fix aggressive course cache rebuilding 2016-06-15 10:49:28 +10:00
Nicholas Hoobin 2abe0ac5a9 MDL-53788 user: fix aggressive course cache rebuilding 2016-06-15 10:42:28 +10:00
Nicholas Hoobin 99a5377bb7 MDL-53788 mod_lti: fix aggressive course cache rebuilding 2016-06-15 10:42:27 +10:00
sam marshall 5a14c4d948 MDL-54920 Behat: Allow viewport size to be set consistently
Provides a new Behat step

And I set viewport size to "800x600"
2016-06-14 12:28:24 +01:00
Dan Poltawski b18478b935 MDL-52127 grunt: fix coding style issues in gruntfile 2016-06-14 00:37:29 +01:00
Dan Poltawski 30db70abdc MDL-52127 grunt: be aware of third party paths
1) Parse thirdpartylibs.xml and generate an array of third party
file paths to use in grunt tasks
2) In the lint tasks, we filter third party files from being linted
3) We add a new task to generate ignore files - currently for eslint,
but will be potentially useful for other things in the future
4) Remove .eslintignore from source control

Why have the ability to generate a .eslintignore file? For tooling
integration - by having the eslintignore file people can use other
eslint tools without having to just use grunt (e.g. editor
integrations).
2016-06-14 00:37:29 +01:00
Dan Poltawski be4b3cc6c7 MDL-52127 js: switch to a more YUI tolerant eslint config
Instead of having the stricter configuration for all files, use
the less strict default config and switch to the stricter config
for building AMD modules.

This means that the eslint commandline/editor inspections will work
better for all files and not generate false positives when using editor
integrations. But since grunt is required to build AMD modules we still
get the stricter checking for those files on build.
2016-06-14 00:37:28 +01:00
Dan Poltawski d25e8fde45 Merge branch 'MDL-54772-master' of git://github.com/junpataleta/moodle 2016-06-13 09:35:58 +01:00
Joby Harding def383943b MDL-51505 tool_templatelibrary: Prevent jumping when selecting template 2016-06-13 09:30:37 +01:00
Dan Poltawski 88b0045106 Merge branch 'MDL-54562_master' of git://github.com/dmonllao/moodle 2016-06-13 09:17:49 +01:00
Dan Poltawski f3caf30690 Merge branch 'MDL-54837-master' of git://github.com/marinaglancy/moodle 2016-06-13 08:51:56 +01:00
Dan Poltawski 8d7bd87e6e Merge branch 'MDL-54842-master' of git://github.com/junpataleta/moodle 2016-06-13 08:36:38 +01:00
Marina Glancy 8fef061da4 MDL-53292 core: deprecate callback delete_course 2016-06-13 10:48:06 +08:00
Cameron Ball 3f897b1966 MDL-51163 course: Remove course/category.php 2016-06-13 10:24:15 +08:00
eWallah 6ae9dbc2aa MDL-37554 activities select all option 2016-06-13 10:22:16 +08:00
Jun Pataleta cdbdb2f9b7 MDL-54772 mod_assign: Fixes for PDF editor
* Render the annotations and comments within the drawing canvas, not in
the drawing region.
* Remove edit-related event bindings for stamp annotations.
2016-06-13 09:54:02 +08:00
Andrew Nicols 377b29d826 Merge branch 'MDL-24064-master' of git://github.com/FMCorz/moodle 2016-06-13 09:17:53 +08:00
Stephen Bourget 1e93eb58ce MDL-54656 Behat: Additional tests for advanced search 2016-06-12 20:50:46 -04:00
Stephen Bourget a6540f38ce MDL-54656 Behat: Add tests for search_forums block 2016-06-12 20:50:21 -04:00
Rajesh Taneja ac22c86bed MDL-54899 behat: Tag for MOODLE 32 version 2016-06-13 07:26:51 +08:00
Dan Poltawski a1587268cb MDL-52127 js: check YUI modules with eslint
Because we don't have the entire YUI rollup, we can't apply some of the
rules safely, so we ignore some rules.

At this point I am not 100% certain this configuration is robust enough,
to deal with the lack fo rollup knowledge although its a good sign that
there are no errors on our entire yui codebase.
2016-06-11 10:14:35 +01:00
Dan Poltawski 3adb62b727 MDL-52127 js: check amd files with eslint grunt task
I have spent quite a lot of time working through the current list of
eslint options and configuring them for Moodle style and I think this is
a very good basis to start us at (as well as taking some of out jshint
options out with https://www.npmjs.com/package/polyjuice ). Thanks to
Andrew Nicols, Mark Johnson and Frédéric Massart for some refinements.

With this configuration the grunt build will fail if errors are present
in the js (though you can of course tell jshint to ignore some errors,
as I have done in admin/tool/lp/amd/src/competency_rule_points.js and
defining the Y global in lib/amd/src/yui.js ).

The grunt task will not report warnings by default, but a new
--show-lint-warnings flag will help achieve that. Editor
integrations/stanadalone eslint tool will surely be a better way of
getting eslint errors rather than using the grunt task.
2016-06-11 10:14:35 +01:00
Jake Dallimore cd6dfd68d8 MDL-54787 mod_quiz: Fix notification error on regrade 2016-06-10 18:26:30 +08:00
Dan Poltawski 834f1b66d4 MDL-54890 course: remove erranous duplicated switch label
Detected by eslint rule 'no-duplicate-case'
2016-06-10 10:06:28 +01:00
Dan Poltawski 8b766dd1d8 MDL-54890 assignfeedback_editpdf: Fix missing semicolon
Detected by eslint rule 'semi'
2016-06-10 10:06:25 +01:00
Jun Pataleta 93f3988cf7 MDL-54712 mod_lti: Remove markup from LTI admin notification messages 2016-06-10 15:10:45 +08:00
Jun Pataleta 5d01400a85 MDL-54842 core_renderer: Hide additional body HTML in embedded layout 2016-06-10 14:47:14 +08:00
Rajesh Taneja 06b2c25662 MDL-48114 core: Add meta information to composer.json 2016-06-10 06:29:16 +08:00
Russell Smith 1fcf0ca8a5 MDL-35628 performance: Remove dirname() where possible.
dirname() is a slow function compared with __DIR__ and using
'/../'.  Moodle has a large number of legacy files that are included
each time a page loads and is not able to use an autoloader as it is
functional code.  This allows those required includes to perform as
best as possible in this situation.
2016-06-10 08:06:49 +10:00
Stephen Bourget fb8b18a44d MDL-53111 Lesson: Allow "end reached" criteria to be disabled 2016-06-09 12:18:34 -04:00
Dan Poltawski a0a63678a9 weekly on-sync release 3.2dev 2016-06-09 11:25:51 +01:00
Dan Poltawski b86bba12d7 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-06-09 11:25:49 +01:00
Andrew Nicols 2c4e6d6252 MDL-54853 weblib: Specify version and fixed encoding 2016-06-09 09:53:48 +08:00
Andrew Nicols 360e819fd3 Merge branch 'MDL-54853-master' of git://github.com/cameron1729/moodle 2016-06-09 09:41:53 +08:00
Cameron Ball 2549f46f7c MDL-54853 weblib: Properly specify encoding for blanktarget 2016-06-08 18:29:19 +08:00
David Monllao dc4c357435 MDL-54859 mod_wiki: Client rules only when fields are visible 2016-06-08 16:44:45 +08:00
Russell Smith 0b768e744f MDL-53495 database xmldb: Use real length restriction. 2016-06-08 11:06:16 +10:00
Andrew Nicols 147df77923 Merge branch 'MDL-53947-master' of git://github.com/junpataleta/moodle 2016-06-08 08:15:23 +08:00
Dan Poltawski 631edc10ae MDL-46721 assign: clarify ternerary statement 2016-06-07 12:15:19 +01:00
Dan Poltawski db417025d7 Merge branch 'MDL-46721-master' of git://github.com/cameron1729/moodle 2016-06-07 12:12:28 +01:00
Dan Poltawski 7bcab9d1fd Merge branch 'MDL-48756-master' of git://github.com/FMCorz/moodle 2016-06-07 11:49:39 +01:00
Dan Poltawski 654e77e74d MDL-54729 mod_forum: clarify static variable usage
After some time discussing with integrators, we decided that this
slightly yukky solution probably fits safely, so just making its usage
better explained and speciifc.
2016-06-07 10:46:53 +01:00
Adrian Greeve 09fec72819 MDL-54729 mod_forum: Deep link highlighting works in IE. 2016-06-07 10:30:18 +01:00
Dan Poltawski df4af29945 Merge branch 'MDL-54765-master' of git://github.com/junpataleta/moodle 2016-06-07 09:41:27 +01:00
David Monllao 8a4f4f576e Merge branch 'MDL-54180_master' of https://github.com/marxjohnson/moodle 2016-06-07 16:15:43 +08:00
Eric Merrill 677650c327 MDL-54559 theme: Fix padding that pushes navbar down 2016-06-07 14:52:26 +08:00
Skylar Kelty 1f5a347b46 MDL-53947 memcached: Fix memcached session warning on PHP7 2016-06-07 10:25:07 +08:00
Marina Glancy 64e9180d2e MDL-54837 tags: allow to specify static function as callback 2016-06-07 08:58:59 +08:00
Marina Glancy 6ee5e596b8 MDL-54837 tags: fixed bug when collection is locked
also fixed fatal error for upgraded plugins that did not pass tag
component to the tag form element
2016-06-07 08:38:39 +08:00
Eloy Lafuente (stronk7) 31220d5a26 Merge branch 'MDL-54739-master' of git://github.com/lameze/moodle 2016-06-07 00:04:59 +02:00
Eloy Lafuente (stronk7) 512f9def5c Merge branch 'MDL-54769-master' of git://github.com/marinaglancy/moodle 2016-06-06 23:56:25 +02:00
Eloy Lafuente (stronk7) ccbb50d2e2 Merge branch 'MDL-54805-master' of git://github.com/junpataleta/moodle 2016-06-06 18:06:36 +02:00
Dan Poltawski 4bfeaf2d5f Merge branch 'wip-MDL-50824-master' of https://github.com/cdsmith-umn/moodle 2016-06-06 15:07:01 +01:00
Dan Poltawski 015b4d22a2 Merge branch 'MDL-54820-master' of git://github.com/jleyva/moodle 2016-06-06 14:09:59 +01:00
Dan Poltawski 5bd52435b4 Merge branch 'MDL-54702_master' of https://github.com/snake/moodle 2016-06-06 13:41:48 +01:00
Dan Poltawski e750544a06 Merge branch 'MDL-53392_master' of https://github.com/snake/moodle 2016-06-06 13:21:09 +01:00
Dan Poltawski 53ee327c69 Merge branch 'MDL-54557-master' of git://github.com/marinaglancy/moodle 2016-06-06 13:17:13 +01:00
Dan Poltawski a7de32a265 Merge branch 'wip-MDL-49852-master' of git://github.com/abgreeve/moodle 2016-06-06 11:59:42 +01:00
Eloy Lafuente (stronk7) 294c242532 Merge branch 'MDL-41922-master-c' of git://github.com/FMCorz/moodle 2016-06-06 11:23:09 +02:00
Dan Poltawski f549e4b7e8 MDL-54649 quiz/question: remove uncessary !important uses
They do not seem at all necessary in testing, so probably just legacy
from lack of css understanding when added.
2016-06-05 20:29:13 +01:00
Mike Churchward b96c9a1abe MDL-54805 portfolio_download: Adding a 'require' of necessary library file 2016-06-04 21:53:34 +08:00
AMOS bot 00eff42833 Automatically generated installer lang files 2016-06-04 00:04:17 +08:00
Dan Poltawski 996a1dab8f MDL-54649 quiz/question: fix css lint errors
Mostly the rules were not having any effect so have been removed.

The text-wrap rule was removed rather than corrected because overflow
was clipped with ellipsis anyway.

An exception for !important has been added to mod/quiz/styles.css
because the use in the secure style is by design. But the exception
isn't ideal because it applied to the whole file and csslint doesn't
seem to be very intelligent at appling line rules at a more granular
level at this point in time.
2016-06-03 14:18:57 +01:00
Juan Leyva 72ac2aacfa MDL-54820 webservice: Fix regression in core_course_search_courses
Regression caused by MDL-51324
2016-06-03 12:56:11 +02:00
Jun Pataleta bb2281d53c MDL-54765 mod_assign: Use selectedIndex for setting page selection
Set the 'selectedIndex' attribute of the page selection element instead of
the 'value' attribute since YUI is having trouble with this in IE.
2016-06-03 14:55:43 +08:00
Frederic Massart ac032e0e09 MDL-41922 mod_quiz: Don't report quiz due when an attempt was finished 2016-06-03 14:52:34 +08:00
Joey Andres fdac806aef MDL-53399 core: "activity chooser off/on" in user preference
- Created a "Course preferences" for user preference. This
  is where "activity chooser off/on" option is moved.
- Changed the lib/navigationlib.php to have a new user preference
  section, which is "Course preferences".
- Removed the "activity chooser" toggle codes in javascript.
2016-06-03 00:46:16 -06:00
Andrew Nicols 4ee8ef5d41 weekly on-sync release 3.2dev 2016-06-03 12:09:19 +08:00
Andrew Nicols 841f623dad Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-06-03 12:09:16 +08:00
Simey Lameze f49a3e1791 MDL-54739 blocks: fix activity chooser link alignment
Thanks Ryan Wyllie for the help.
2016-06-03 10:55:52 +08:00
Clement Smith 126a4bc47b MDL-50824 message/externallib.php: Fix get_string call
This fixes the get_string call by adding the intended recipient's
fullname as the third argument when a user tries to message the
recipient, the recipient is blocking non-contacts from messaging
them, and the user is not in the recipient's contact list.
2016-06-02 07:11:16 -05:00
Adam Olley e9f7c4a4b2 MDL-54797 course: Add indexed field to condition of delete query
Deleting records from the course_completion_criteria table goes much
faster when we include the indexed course field in the delete query.
2016-06-02 15:43:30 +09:30
Marina Glancy 5e717d10b4 MDL-54557 course: treat section summary as contents 2016-06-02 12:56:34 +08:00
Andrew Nicols 05263307d7 MDL-54722 javascript: Add YUI depend wrapper to global event 2016-06-02 10:07:56 +08:00
AMOS bot 7087d1cfde Automatically generated installer lang files 2016-06-02 00:04:13 +08:00
Frederic Massart a5ea5149b8 MDL-48248 enrol_manual: Handle durations more precise than int days 2016-06-01 15:57:12 +08:00
Frederic Massart 240a9de4ab MDL-48756 editor_atto: Bulk atto autosave queries 2016-06-01 12:49:15 +08:00
Andrew Nicols 69dcebb04d Merge branch 'MDL-54722-master' of git://github.com/cameron1729/moodle 2016-06-01 12:24:14 +08:00
Stephen Bourget 5b40141f6d MDL-54563 Block: Only Allow completion blocks on course pages 2016-06-01 10:42:01 +08:00
Cameron Ball fd5466af99 MDL-54722 navigation: Properly overflow expanded nav trees 2016-06-01 10:15:22 +08:00
Jake Dallimore c724c98829 MDL-54702 mod_lti: Support standard cartridge icons in LTI import 2016-06-01 09:49:10 +08:00
Marina Glancy 88038050b1 MDL-54769 backup: add missing error language string 2016-06-01 09:44:42 +08:00
Andrew Nicols e68dabc756 Merge branch 'MDL-53598-master' of git://github.com/marinaglancy/moodle 2016-06-01 08:02:32 +08:00
Mark Johnson be8b89500c MDL-54180 Behat: Handle exceptions from driver when saving screenshot 2016-05-31 12:32:57 +01:00
Marina Glancy 9c3710854b MDL-53598 block_glossary_random: do not fail if glossary was deleted
This commit refactors how associated glossary is searched for and removes
unnecessary DB queries. Also prevents from situations when the global glossary or course have
been deleted
2016-05-31 15:30:41 +08:00
David Monllao 19e078dd2a Merge branch 'MDL-54065-master' of git://github.com/marinaglancy/moodle 2016-05-31 15:27:29 +08:00
Andrew Nicols b29d2b2aa8 Merge branch 'MDL-54655_m32v1' of https://github.com/sbourget/moodle 2016-05-31 13:29:48 +08:00
David Monllao 5751f7a36c Merge branch 'MDL-54667-master' of git://github.com/junpataleta/moodle 2016-05-31 12:46:59 +08:00
David Monllao 694d8c4a9e Merge branch 'MDL-54763_master' of git://github.com/markn86/moodle 2016-05-31 12:31:36 +08:00
David Monllao ba4cd26414 Merge branch 'MDL-53851-master' of https://github.com/blckct/moodle 2016-05-31 11:46:09 +08:00
David Monllao 0cdef23bdb Merge branch 'MDL-53938' of git://github.com/timhunt/moodle 2016-05-31 11:42:17 +08:00
David Monllao d1577993b6 Merge branch 'MDL-54605' of git://github.com/timhunt/moodle 2016-05-31 11:32:11 +08:00
Andrew Nicols 73b0dcb106 Merge branch 'MDL-54579_m31v1' of https://github.com/sbourget/moodle 2016-05-31 11:18:27 +08:00
Barbara Ramiro 000d660fda MDL-51683 design: New icon for competencies 2016-05-31 10:48:18 +08:00
Jakob cffd0fa138 MDL-53306 auth: Add hook for auth plugins to access user object.
Add a hook for auth plugins to be able to modify or check a user, before
raising any authentication errors.

The auth plugin needs to add a public function like this:

/**
 * Pre user_login hook.
 * This method is called from authenticate_user_login() right after the user
 * object is generated. This gives the auth plugins an option to make adjustments
 * before the verification process starts.
 *
 * @param object $user user object, later used for $USER
*/
public function pre_user_login_hook(&$user) {
    // Override if needed.
}
2016-05-30 11:57:03 -07:00
Jakub Kania 81475d2602 MDL-54667 core_lib: Fix the param name in edit profile link 2016-05-30 16:34:02 +08:00
Cameron Ball af6a424054 MDL-37138 weblib: Document blanktarget in upgrade.txt 2016-05-30 16:12:17 +08:00
David Monllao abd5f819d0 Merge branch 'MDL-54002_m32v3' of https://github.com/sbourget/moodle 2016-05-30 16:08:53 +08:00
David Monllao 4f24176f17 Merge branch 'MDL-54010-master' of git://github.com/cameron1729/moodle 2016-05-30 16:04:04 +08:00
David Monllao 7e93c2e6f6 Merge branch 'MDL-54577-master' of git://github.com/cameron1729/moodle 2016-05-30 15:45:47 +08:00
David Monllao 9812222d21 Merge branch 'MDL-29905-master' of git://github.com/FMCorz/moodle 2016-05-30 15:40:43 +08:00
David Monllao 13d04ab6c1 Merge branch 'MDL-54116-master' of git://github.com/cameron1729/moodle 2016-05-30 15:36:01 +08:00
David Monllao 42d0093d6e Merge branch 'MDL-49943-master' of git://github.com/marinaglancy/moodle 2016-05-30 15:29:22 +08:00
Andrew Nicols a29e419b2c Merge branch 'MDL-54756' of git://github.com/timhunt/moodle 2016-05-30 15:19:04 +08:00
David Monllao 1e562ebc48 Merge branch 'MDL-37138-master-2' of git://github.com/cameron1729/moodle 2016-05-30 15:02:17 +08:00
Andrew Nicols 1f9c338bc1 Merge branch 'MDL-54567-master-build' of git://github.com/FMCorz/moodle 2016-05-30 14:39:23 +08:00
Marina Glancy 42dfbb5416 MDL-49943 mod_choice: display multiple answers in complete report 2016-05-30 14:17:17 +08:00
Jun Pataleta 46b888dbd6 MDL-53425 blocklib: Raise execution time for dashboard reset process 2016-05-30 14:12:28 +08:00
Andrew Nicols 7c8f4f6b70 Merge branch 'MDL-35987-master' of git://github.com/FMCorz/moodle 2016-05-30 13:38:52 +08:00
David Monllao 485de12199 Merge branch 'MDL-53425-master-delete-by-chunks' of git://github.com/junpataleta/moodle 2016-05-30 13:35:24 +08:00
Mark Nelson e0d60498d8 MDL-54763 tool_lp: fixed typo in HTML tag 2016-05-30 13:31:31 +08:00
Andrew Nicols e67da0d792 MDL-54567 backup: Fixtures for legacy grade value rewrite 2016-05-30 13:22:04 +08:00
Frederic Massart 2a64b641e6 MDL-54567 backup: Process the calculations_freeze item upon restore 2016-05-30 13:22:03 +08:00
Cameron Ball cd29373c35 MDL-37138 chat: Use blanktarget option for chat text 2016-05-30 13:18:02 +08:00
Cameron Ball 64e8311939 MDL-37138 message: Use blanktarget option for message text 2016-05-30 13:18:01 +08:00
Cameron Ball bf9974870b MDL-37138 weblib: Add blanktarget option to format_text 2016-05-30 13:17:59 +08:00
David Monllao edf842a462 Merge branch 'MDL-48248-master' of git://github.com/FMCorz/moodle 2016-05-30 13:02:34 +08:00
Frederic Massart 31031e98c7 MDL-29905 question: Auto remove stale questions upon category deletion 2016-05-30 12:26:09 +08:00
Eric Merrill 54640aba8a MDL-29905 question: Try to delete unused hidden/random questions
Before going to display the warning about moving in use questions,
try to delete unused Random qtype questions, as well as 'hidden'
questions (these are questions that were deleted from the category),
but were in use at the time.
2016-05-30 12:25:21 +08:00
Jun Pataleta 4eba620ae3 MDL-53425 blocklib: Perform deletion of block instances by chunk 2016-05-30 11:22:47 +08:00
David Monllao 571f30b376 Merge branch 'MDL-54721-master' of git://github.com/FMCorz/moodle 2016-05-30 11:15:20 +08:00
David Monllao 3300393d05 Merge branch 'MDL-43887-master' of git://github.com/cameron1729/moodle 2016-05-30 11:08:46 +08:00
David Monllao 5baf32c038 Merge branch 'MDL-51806_master' of https://github.com/snake/moodle 2016-05-30 10:51:33 +08:00
Jake Dallimore f747f5a0d5 MDL-51806 mod_workshop: Add locale support for grade values. 2016-05-30 10:25:26 +08:00
David Monllao 0196f0101c Merge branch 'wip-MDL-45427-master' of git://github.com/abgreeve/moodle 2016-05-30 10:19:24 +08:00
Marina Glancy bc6a7431a2 MDL-54065 gradebook: correctly display module icon 2016-05-30 10:07:40 +08:00
Stephen Bourget 18875f811a MDL-54655 Behat: Tests for the online_users block 2016-05-27 18:21:25 -04:00
Tim Hunt 31c07476db MDL-54756 moodle_url: remove dangerous trim from make_file_url
This was a regression caused by MDL-50268. It broke qtype_stack.
2016-05-27 19:55:25 +01:00
Tim Hunt f027922e4f MDL-54605 quiz regrading: incorrect DB query
There were two issues. With groups, the $params array was wrong
due to PHP + vs array_merge sillyness.

Also, the first column in the SQL was not necessarily unique,
so we need to use a recordset rather than get_records.
2016-05-27 08:11:32 +01:00
Adrian Greeve 0cf8082a8f MDL-49852 mod_assign: Unit tests for activity completion. 2016-05-27 14:10:55 +08:00
Cameron Ball e6e69969c1 MDL-43887 formslib: Allow not set date field
Previously if the date field was not enabled it would
be treated as having value 0. A bug would allow this 0
to pass through and save the date as 1 January 1970
2016-05-27 01:52:57 +08:00
AMOS bot 867181ab19 Automatically generated installer lang files 2016-05-27 00:04:40 +08:00
Frederic Massart 6e91817178 MDL-54721 report_competency: Do not ignore the first user selection 2016-05-26 17:54:52 +08:00
Jake Dallimore 7eafbbf7fa MDL-53392 mod_assign: Remove old Grade Max warning string references 2016-05-26 17:16:53 +08:00
Steve Bader 9569b01cc9 MDL-49852 mod_assign: Fix group assignment completion tracking
Fixes completion tracking for group assignments where either only
one student is required to click Submit when submitting the
assignment for grading, all students are required to submit,
or no students are required to click submit (meaning that simply
uploading submits for grading).
2016-05-26 16:03:03 +08:00
Cameron Ball bb30944f49 MDL-54010 roles: Specify encoding for escaped export data 2016-05-26 10:31:28 +08:00
Nigel Cunningham d50a9a9d30 MDL-54010 roles: Fix missing HTMLspecialchars in role export code.
Role name and description fields are currently not escaped when
exporting a role. This results in an unusable file when characters
such as ampersands are used in a name or description. Fix this by
using htmlspecialchars on both fields.

Signed-off-by: Nigel Cunningham <nigelc@catalyst-au.net>
2016-05-26 10:31:28 +08:00
Daniel Neis Araujo 4b2dbdecd1 MDL-54617 block_online_users: Always show count of online users 2016-05-26 10:24:30 +08:00
Stephen Bourget 71b1761337 MDL-54577 Behat: Add tests for messages block 2016-05-26 10:21:07 +08:00
Marina Glancy c0e3e9da37 MDL-54116 block_comments: warnings when commenting outside of a course 2016-05-26 10:19:31 +08:00
Stephen Bourget f2778cc5d6 MDL-54116 block_comments: behat test 2016-05-26 10:19:31 +08:00
Eloy Lafuente (stronk7) 6a74e76fb8 weekly on-sync release 3.2dev 2016-05-26 02:15:53 +02:00
Eloy Lafuente (stronk7) ea051ef170 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2016-05-26 02:15:50 +02:00
Jakub Kania 10186fe83d MDL-53851 news block: Display news from all the accessible groups 2016-05-25 16:54:45 +02:00
Marina Glancy 15a237cea6 MDL-37946 mod_choice: swap horizontal and vertical graphs 2016-05-25 21:31:36 +08:00
David Monllao 3f59e20eeb Merge branch 'MDL-54059-master' of git://github.com/andrewnicols/moodle 2016-05-25 16:17:44 +08:00
Adrian Greeve 43c762ef10 MDL-45427 mod_data: Inserting tags into templates.
Allows tags to be inserted into the editor without
having to touch Atto at all.
2016-05-25 15:24:41 +08:00
Frederic Massart 9a601adc9e MDL-35987 qtype_multianswer: Prevent restore failure due to bad sequence 2016-05-25 12:23:50 +08:00
Andrew Nicols c366cb08cf MDL-54059 testing: Add grunt test 2016-05-25 10:44:36 +08:00
Andrew Nicols a24aff4edf MDL-54059 testing: Simplify travis output 2016-05-25 10:44:01 +08:00
Frederic Massart b8f414c29f MDL-48248 enrol_manual: Ensure that the default value is always selected 2016-05-25 10:16:59 +08:00
Stephen Bourget 1633ec89ad MDL-54002 Behat: tests for recent blogs block 2016-05-24 12:42:31 -04:00
AMOS bot 0fcfcd8327 Automatically generated installer lang files 2016-05-25 00:04:41 +08:00
Frederic Massart 7c9968bd9f MDL-24064 admin: Remove unused code to bulk enrol users 2016-05-24 18:48:06 +08:00
Cameron Ball 4ca7fdd26e MDL-46721 assign: Make blind marking participant numbers match
Previously emails were setting the "From" header to the incorrect
participant number.
2016-05-24 18:19:54 +08:00
Andrew Nicols 979d5c0603 Merge branch 'MDL-54715-master' of git://github.com/marinaglancy/moodle 2016-05-24 14:53:24 +08:00
Marina Glancy 3e9437f412 MDL-54715 core_question: fixed bug when importing questions with tags
Thanks to WangYang for original patch
2016-05-24 14:37:53 +08:00
David Monllao 4024b94d17 Merge branch 'MDL-54675-forum-highlight' of https://github.com/brendanheywood/moodle 2016-05-24 14:20:13 +08:00
David Monllao 7b7b990e43 Merge branch 'MDL-54582' of git://github.com/timhunt/moodle 2016-05-24 11:17:08 +08:00
Brendan Heywood d0d6902a72 MDL-54675 forum: Fixed bug with multiple adjacent hash anchors 2016-05-24 13:07:07 +10:00
Andrew Nicols 13c6946d92 MDL-53687 core_media: Comment fix 2016-05-24 09:02:36 +08:00
Andrew Nicols 939f2b31f9 Merge branch 'MDL-53687-master' of git://github.com/FMCorz/moodle 2016-05-24 08:59:47 +08:00
AMOS bot bcb51b8c87 Automatically generated installer lang files 2016-05-24 00:04:21 +08:00
Frederic Massart c2f430a813 MDL-53687 core_media: Edge does not yet support WebM and OGG 2016-05-23 16:20:15 +08:00
David Monllao e5fa1c5781 MDL-54562 mod_data: Add activities info to search 2016-05-23 16:06:00 +08:00
David Monllao 21eef94436 Merge branch 'MDL-54642-master' of git://github.com/ryanwyllie/moodle 2016-05-23 14:52:54 +08:00
David Monllao 287074207f Merge branch 'MDL-46934-master' of git://github.com/FMCorz/moodle 2016-05-23 14:38:01 +08:00
David Monllao ec7ade95db Merge branch 'MDL-54661-master' of git://github.com/junpataleta/moodle 2016-05-23 14:23:57 +08:00
David Monllao 170402cb4e Merge branch 'MDL-54664-master' of git://github.com/junpataleta/moodle 2016-05-23 09:50:44 +08:00
David Monllao 2eb57cf7a2 Merge branch 'MDL-54677' of git://github.com/stronk7/moodle 2016-05-23 09:13:40 +08:00
Eloy Lafuente (stronk7) 4da854a68b MDL-54677 upgrade: add 3.1.0 separation line to all upgrade scripts 2016-05-23 01:31:34 +02:00
Eloy Lafuente (stronk7) 7a3a3246fa MDL-54676 backup: Bump release to 3.2 2016-05-23 00:23:31 +02:00
Eloy Lafuente (stronk7) 2c952b2f38 weekly back-to-dev release 3.2dev 2016-05-22 02:46:17 +02:00
Frederic Massart 4700c44c01 MDL-46934 webservice_rest: Fixed undefined index on XML output 2016-05-20 17:03:23 +08:00
Jun Pataleta 16fb3f4505 MDL-54664 blocks_lp: Set the layout of to review pages to standard 2016-05-20 16:58:54 +08:00
Jun Pataleta 7af009633a MDL-54661 mod_assign: Unescape course name in grading nav template 2016-05-20 15:28:37 +08:00
Ryan Wyllie 3fdc542fe4 MDL-54642 tool_lp: Fix learning plan button layout in FF
The learning plan buttons are floating left but the table below it wasn't
clearning floating elements so it was appearing on the same line.
2016-05-20 02:35:11 +00:00
Stephen Bourget 195b9ebb7c MDL-54579 Behat: tests for the private_files block 2016-05-19 20:01:55 -04:00
Stephen Bourget db5ab8f0bb MDL-54622 Block_myprofile: Remove unused setting 2016-05-17 19:58:53 -04:00
Vadim Dvorovenko 7025aeed03 MDL-54599 Navigation: Sorting plugins by visible name
Sorting plugins name in admin settings tree by visible (localized) name.
2016-05-16 23:08:05 +07:00
Tim Hunt 795efd9c1b MDL-54582 accesslib: improve performance of load_course_context
The new query is logically equivalen, but much, much faster, at
least on Postgred. (15ms, instead of 700ms, in one example I tried
on the database for the OU's main Moodle site.)
2016-05-13 20:36:33 +01:00
jogarcia 8dabb7200d MDL-54576 theme: Redirect to show confirmation
After selecting a new theme, save the new configs
then redirect to show the confirmation and the new
theme's read me.  This prevents any odd behavior
from the old theme bleeding into the display of
the confirmation.
2016-05-13 08:57:12 -07:00
Tim Hunt c76789f49a MDL-53938 qformat_gift: handle multi-choice MR with one 100% choice 2016-05-11 18:07:23 +01:00
Joshua Todd Cowper 78c2c3bb42 MDL-51978 admin: default course format to topics
Change default setting for default course format to topics, and also fix
coding style issue on same line (75) by adding a space after comma
Change default setting for default number of sections to 4
2016-05-08 22:38:00 +10:00
liorgi 68873d48be MDL-54036 mod_forum: Remove unused variable in forum_print_posts_flat 2016-05-03 16:30:58 +03:00
Jun Pataleta 3de445bb56 MDL-51749 calendar: Behat tests for calendar export and additional fixes 2016-04-18 15:02:50 +08:00
Alistair Spark 6552198130 MDL-51749 CALENDAR: Add ical export for user or group events 2016-04-16 23:43:23 +01:00
4922 changed files with 304859 additions and 109839 deletions
-3
View File
@@ -1,3 +0,0 @@
--errors=errors,duplicate-properties
--warnings=known-properties,display-property-grouping,empty-rules,important
--exclude-list=vendor/,lib/editor/tinymce/,lib/yuilib/,theme/bootstrapbase/style/
+79
View File
@@ -0,0 +1,79 @@
# Generated by "grunt ignorefiles"
*/**/yui/src/*/meta/
*/**/build/
node_modules/
vendor/
admin/tool/usertours/amd/src/tour.js
admin/tool/usertours/amd/src/popper.js
auth/cas/CAS/
auth/fc/fcFPP.php
enrol/lti/ims-blti/
filter/algebra/AlgParser.pm
filter/tex/mimetex.*
lib/editor/atto/yui/src/rangy/js/*.*
lib/editor/tinymce/plugins/pdw/tinymce/
lib/editor/tinymce/plugins/spellchecker/rpc.php
lib/editor/tinymce/tiny_mce/
lib/adodb/
lib/bennu/
lib/evalmath/
lib/lessphp/
lib/phpexcel/
lib/google/
lib/htmlpurifier/
lib/jabber/
lib/minify/matthiasmullie-minify/
lib/minify/matthiasmullie-pathconverter/
lib/pear/Auth/RADIUS.php
lib/pear/Crypt/CHAP.php
lib/pear/HTML/Common.php
lib/pear/HTML/QuickForm.php
lib/pear/HTML/QuickForm/
lib/pear/PEAR.php
lib/phpmailer/
lib/simplepie/
lib/tcpdf/
lib/typo3/
lib/yuilib/
lib/yuilib/gallery/
lib/jquery/
lib/html2text/
lib/markdown/
lib/recaptchalib.php
lib/xhprof/
lib/xmlize.php
lib/horde/
lib/requirejs/
lib/amd/src/loglevel.js
lib/mustache/
lib/amd/src/mustache.js
lib/graphlib.php
lib/php-css-parser/
lib/rtlcss/
lib/scssphp/
lib/spout/
lib/amd/src/chartjs-lazy.js
lib/maxmind/GeoIp2/
lib/maxmind/MaxMind/
lib/ltiprovider/
media/player/videojs/amd/src/video-lazy.js
media/player/videojs/amd/src/Youtube-lazy.js
media/player/videojs/videojs/
mod/assign/feedback/editpdf/fpdi/
repository/s3/S3.php
theme/boost/scss/bootstrap/
theme/boost/amd/src/alert.js
theme/boost/amd/src/button.js
theme/boost/amd/src/carousel.js
theme/boost/amd/src/collapse.js
theme/boost/amd/src/dropdown.js
theme/boost/amd/src/modal.js
theme/boost/amd/src/popover.js
theme/boost/amd/src/scrollspy.js
theme/boost/amd/src/tab.js
theme/boost/amd/src/tooltip.js
theme/boost/amd/src/util.js
theme/boost/amd/src/tether.js
theme/bootstrapbase/less/bootstrap/
theme/bootstrapbase/javascript/html5shiv.js
theme/bootstrapbase/amd/src/bootstrap.js
+180
View File
@@ -0,0 +1,180 @@
{
'env': {
'browser': true,
'amd': true
},
'globals': {
'M': true,
'Y': true
},
'rules': {
// See http://eslint.org/docs/rules/ for all rules and explanations of all
// rules.
// === Possible Errors ===
'comma-dangle': 'off',
'no-cond-assign': 'error',
'no-console': 'error',
'no-constant-condition': 'error',
'no-control-regex': 'error',
'no-debugger': 'error',
'no-dupe-args': 'error',
'no-dupe-keys': 'error',
'no-duplicate-case': 'error',
'no-empty': 'warn',
'no-empty-character-class': 'error',
'no-ex-assign': 'error',
'no-extra-boolean-cast': 'error',
'no-extra-parens': 'off',
'no-extra-semi': 'error',
'no-func-assign': 'error',
'no-inner-declarations': 'error',
'no-invalid-regexp': 'error',
'no-irregular-whitespace': 'error',
'no-obj-calls': 'error',
'no-prototype-builtins': 'off',
'no-regex-spaces': 'error',
'no-sparse-arrays': 'error',
'no-unexpected-multiline': 'error',
'no-unreachable': 'warn',
'no-unsafe-finally': 'error',
'no-unsafe-negation': 'error',
'use-isnan': 'error',
'valid-jsdoc': ['warn', { 'requireReturn': false, 'requireParamDescription': false, 'requireReturnDescription': false }],
'valid-typeof': 'error',
// === Best Practices ===
// (these mostly match our jshint config)
'array-callback-return': 'warn',
'block-scoped-var': 'warn',
'complexity': 'warn',
'consistent-return': 'warn',
'curly': 'error',
'dot-notation': 'warn',
'no-alert': 'warn',
'no-caller': 'error',
'no-case-declarations': 'error',
'no-div-regex': 'error',
'no-empty-pattern': 'error',
'no-empty-function': 'warn',
'no-eq-null': 'error',
'no-eval': 'error',
'no-extend-native': 'error',
'no-extra-bind': 'warn',
'no-fallthrough': 'error',
'no-floating-decimal': 'warn',
'no-global-assign': 'warn',
// Enabled by grunt for AMD modules: 'no-implicit-globals': 'error',
'no-implied-eval': 'error',
'no-invalid-this': 'error',
'no-iterator': 'error',
'no-labels': 'error',
'no-loop-func': 'error',
'no-multi-spaces': 'warn',
'no-multi-str': 'error',
'no-new-func': 'error',
'no-new-wrappers': 'error',
'no-octal': 'error',
'no-octal-escape': 'error',
'no-proto': 'error',
'no-redeclare': 'warn',
'no-return-assign': 'error',
'no-script-url': 'error',
'no-self-assign': 'error',
'no-self-compare': 'error',
'no-sequences': 'warn',
'no-throw-literal': 'warn',
'no-unmodified-loop-condition': 'error',
'no-unused-expressions': 'error',
'no-unused-labels': 'error',
'no-useless-call': 'warn',
'no-useless-escape': 'warn',
'no-with': 'error',
'wrap-iife': ['error', 'any'],
// === Variables ===
'no-delete-var': 'error',
'no-undef': 'error',
'no-undef-init': 'error',
'no-unused-vars': ['error', { 'caughtErrors': 'none' }],
// === Stylistic Issues ===
'array-bracket-spacing': 'warn',
'block-spacing': 'warn',
'brace-style': ['warn', '1tbs'],
'camelcase': 'warn',
'comma-spacing': ['warn', { 'before': false, 'after': true }],
'comma-style': ['warn', 'last'],
'computed-property-spacing': 'error',
'consistent-this': 'off',
'eol-last': 'off',
'func-call-spacing': ['warn', 'never'],
'func-names': 'off',
'func-style': 'off',
// indent currently not doing well with our wrapping style, so disabled.
'indent': ['off', 4, { 'SwitchCase': 1 }],
'key-spacing': ['warn', { 'beforeColon': false, 'afterColon': true, 'mode': minimum }],
'keyword-spacing': 'warn',
'linebreak-style': ['error', 'unix'],
'lines-around-comment': 'off',
'max-len': ['error', 132],
'max-lines': 'off',
'max-depth': 'warn',
'max-nested-callbacks': ['warn', 5],
'max-params': 'off',
'max-statements': 'off',
'max-statements-per-line': ['warn', { max: 2 }],
'new-cap': ['warn', { 'properties': false }],
'new-parens': 'warn',
'newline-after-var': 'off',
'newline-before-return': 'off',
'newline-per-chained-call': 'off',
'no-array-constructor': 'off',
'no-bitwise': 'error',
'no-continue': 'off',
'no-inline-comments': 'off',
'no-lonely-if': 'off',
'no-mixed-operators': 'off',
'no-mixed-spaces-and-tabs': 'error',
'no-multiple-empty-lines': 'warn',
'no-negated-condition': 'off',
'no-nested-ternary': 'warn',
'no-new-object': 'off',
'no-plusplus': 'off',
'no-tabs': 'error',
'no-ternary': 'off',
'no-trailing-spaces': 'error',
'no-underscore-dangle': 'off',
'no-unneeded-ternary': 'off',
'no-whitespace-before-property': 'warn',
'object-curly-newline': 'off',
'object-curly-spacing': 'warn',
'object-property-newline': 'off',
'one-var': 'off',
'one-var-declaration-per-line': ['warn', 'initializations'],
'operator-assignment': 'off',
'operator-linebreak': 'off',
'padded-blocks': 'off',
'quote-props': ['warn', 'as-needed', {'unnecessary': false, 'keywords': true, 'numbers': true}],
'quotes': 'off',
'require-jsdoc': 'warn',
'semi': 'error',
'semi-spacing': ['warn', {'before': false, 'after': true}],
'sort-vars': 'off',
'space-before-blocks': 'warn',
'space-before-function-paren': ['warn', 'never'],
'space-in-parens': 'warn',
'space-infix-ops': 'warn',
'space-unary-ops': 'warn',
'spaced-comment': 'warn',
'unicode-bom': 'error',
'wrap-regex': 'off',
// === Deprecations ===
"no-restricted-properties": ['warn', {
'object': 'M',
'property': 'str',
'message': 'Use AMD module "core/str" or M.util.get_string()'
}],
}
}
+3
View File
@@ -1,3 +1,6 @@
// NOTE: We use eslint now. This file is used only by shifter. We keep the configuration
// here because shifter uses jshint after modules have been concating. Eslint can't
// currently do this.
{
"asi": false,
"bitwise": true,
+80
View File
@@ -0,0 +1,80 @@
# Generated by "grunt ignorefiles"
theme/bootstrapbase/style/
theme/clean/style/custom.css
theme/more/style/custom.css
node_modules/
vendor/
admin/tool/usertours/amd/src/tour.js
admin/tool/usertours/amd/src/popper.js
auth/cas/CAS/
auth/fc/fcFPP.php
enrol/lti/ims-blti/
filter/algebra/AlgParser.pm
filter/tex/mimetex.*
lib/editor/atto/yui/src/rangy/js/*.*
lib/editor/tinymce/plugins/pdw/tinymce/
lib/editor/tinymce/plugins/spellchecker/rpc.php
lib/editor/tinymce/tiny_mce/
lib/adodb/
lib/bennu/
lib/evalmath/
lib/lessphp/
lib/phpexcel/
lib/google/
lib/htmlpurifier/
lib/jabber/
lib/minify/matthiasmullie-minify/
lib/minify/matthiasmullie-pathconverter/
lib/pear/Auth/RADIUS.php
lib/pear/Crypt/CHAP.php
lib/pear/HTML/Common.php
lib/pear/HTML/QuickForm.php
lib/pear/HTML/QuickForm/
lib/pear/PEAR.php
lib/phpmailer/
lib/simplepie/
lib/tcpdf/
lib/typo3/
lib/yuilib/
lib/yuilib/gallery/
lib/jquery/
lib/html2text/
lib/markdown/
lib/recaptchalib.php
lib/xhprof/
lib/xmlize.php
lib/horde/
lib/requirejs/
lib/amd/src/loglevel.js
lib/mustache/
lib/amd/src/mustache.js
lib/graphlib.php
lib/php-css-parser/
lib/rtlcss/
lib/scssphp/
lib/spout/
lib/amd/src/chartjs-lazy.js
lib/maxmind/GeoIp2/
lib/maxmind/MaxMind/
lib/ltiprovider/
media/player/videojs/amd/src/video-lazy.js
media/player/videojs/amd/src/Youtube-lazy.js
media/player/videojs/videojs/
mod/assign/feedback/editpdf/fpdi/
repository/s3/S3.php
theme/boost/scss/bootstrap/
theme/boost/amd/src/alert.js
theme/boost/amd/src/button.js
theme/boost/amd/src/carousel.js
theme/boost/amd/src/collapse.js
theme/boost/amd/src/dropdown.js
theme/boost/amd/src/modal.js
theme/boost/amd/src/popover.js
theme/boost/amd/src/scrollspy.js
theme/boost/amd/src/tab.js
theme/boost/amd/src/tooltip.js
theme/boost/amd/src/util.js
theme/boost/amd/src/tether.js
theme/bootstrapbase/less/bootstrap/
theme/bootstrapbase/javascript/html5shiv.js
theme/bootstrapbase/amd/src/bootstrap.js
+94
View File
@@ -0,0 +1,94 @@
{
"rules": {
"at-rule-empty-line-before": [ "always",
{"except": [ "blockless-group"], ignore: ["after-comment", "all-nested"]}
],
"at-rule-name-case": "lower",
"at-rule-name-space-after": "always-single-line",
"at-rule-no-unknown": null, # Enabled for non-scss in grunt.
"at-rule-semicolon-newline-after": "always",
"block-closing-brace-newline-after": "always",
"block-closing-brace-newline-before": "always-multi-line",
"block-closing-brace-space-before": "always-single-line",
"block-no-empty": true,
"block-no-single-line": true,
"block-opening-brace-newline-after": "always-multi-line",
"block-opening-brace-space-after": "always-single-line",
"block-opening-brace-space-before": "always",
"color-hex-case": ["lower", { "severity": "warning" }],
"color-hex-length": ["short", { "severity": "warning" }],
"color-no-invalid-hex": true,
"declaration-bang-space-after": "never",
"declaration-bang-space-before": "always",
"declaration-block-no-duplicate-properties": true,
"declaration-block-no-ignored-properties": true,
"declaration-block-no-shorthand-property-overrides": true,
"declaration-block-semicolon-newline-after": "always-multi-line",
"declaration-block-semicolon-space-after": "always-single-line",
"declaration-block-semicolon-space-before": "never",
"declaration-block-single-line-max-declarations": 1,
"declaration-block-trailing-semicolon": "always",
"declaration-colon-newline-after": "always-multi-line",
"declaration-colon-space-after": "always-single-line",
"declaration-colon-space-before": "never",
"declaration-no-important": true,
"function-calc-no-unspaced-operator": true,
"function-comma-newline-after": "always-multi-line",
"function-comma-space-after": "always-single-line",
"function-comma-space-before": "never",
"function-linear-gradient-no-nonstandard-direction": true,
"function-max-empty-lines": 0,
"function-name-case": "lower",
"function-parentheses-newline-inside": "always-multi-line",
"function-parentheses-space-inside": "never-single-line",
"function-url-data-uris": never,
"function-whitespace-after": "always",
"indentation": 4,
"keyframe-declaration-no-important": true,
"length-zero-no-unit": [true, { "severity": "warning" }],
"max-empty-lines": 2,
"max-line-length": [132, { "severity": "warning" }],
"media-feature-colon-space-after": "always",
"media-feature-colon-space-before": "never",
"media-feature-no-missing-punctuation": true,
"media-feature-parentheses-space-inside": "never",
"media-feature-range-operator-space-after": "always",
"media-feature-range-operator-space-before": "always",
"media-query-list-comma-newline-after": "always-multi-line",
"media-query-list-comma-space-after": "always-single-line",
"media-query-list-comma-space-before": "never",
"no-browser-hacks": null, # Enabled for non-scss in grunt.
"no-empty-source": true,
"no-eol-whitespace": true,
"no-extra-semicolons": [true, { "severity": "warning" }],
"no-invalid-double-slash-comments": true,
"no-unknown-animations": true,
"property-case": "lower",
"property-no-unknown": true,
"selector-attribute-brackets-space-inside": "never",
"selector-attribute-operator-space-after": "never",
"selector-attribute-operator-space-before": "never",
"selector-combinator-space-after": "always",
"selector-combinator-space-before": "always",
"selector-list-comma-newline-after": "always",
"selector-list-comma-space-before": "never",
"selector-max-empty-lines": 0,
"selector-pseudo-class-case": "lower",
"selector-pseudo-class-no-unknown": true,
"selector-pseudo-class-parentheses-space-inside": "never",
"selector-pseudo-element-case": "lower",
"selector-pseudo-element-no-unknown": true,
"selector-root-no-composition": true,
"selector-type-case": "lower",
"selector-type-no-unknown": true,
"string-no-newline": true,
"time-no-imperceptible": true,
"unit-blacklist": ["pt"],
"unit-case": "lower",
"unit-no-unknown": true,
"value-keyword-case": ["lower", {"ignoreKeywords": ["/(@|$)/"]}],
"value-list-comma-newline-after": "always-multi-line",
"value-list-comma-space-after": "always-single-line",
"value-list-comma-space-before": "never",
}
}
+104 -60
View File
@@ -13,30 +13,31 @@ language: php
php:
# We only run the highest and lowest supported versions to reduce the load on travis-ci.org.
- 7.0
# - 5.6
# - 5.5
- 5.4
- 7.1
- 5.6
services:
- redis-server
env:
# Although we want to run these jobs and see failures as quickly as possible, we also want to get the slowest job to
# start first so that the total run time is not too high.
#
# We only run MySQL on PHP 5.6, so run that first.
# We only run MySQL on PHP 7.1, so run that first.
# CI Tests should be second-highest in priority as these only take <= 60 seconds to run under normal circumstances.
# Postgres is significantly is pretty reasonable in its run-time.
# Run unit tests on MySQL
- DB=mysqli PHPUNIT=true INSTALL=false CITEST=false
- DB=mysqli TASK=PHPUNIT
# Run CI Tests without running PHPUnit.
- DB=none PHPUNIT=false INSTALL=false CITEST=true
- DB=none TASK=CITEST
# Run unit tests on Postgres
- DB=pgsql PHPUNIT=true INSTALL=false CITEST=false
- DB=pgsql TASK=PHPUNIT
# Perform an upgrade test too.
- DB=pgsql PHPUNIT=false INSTALL=true CITEST=false UPGRADE=true
- DB=pgsql TASK=UPGRADE
matrix:
# Enable fast finish.
@@ -44,41 +45,60 @@ matrix:
# It will not stop the jobs from running.
fast_finish: true
include:
# Run grunt/npm install on lowest supported npm version
- php: 7.1
env: DB=none TASK=GRUNT NVM_VERSION='4'
# Run grunt/npm install on highest version ('node' is an alias for the latest node.js version.)
- php: 7.1
env: DB=none TASK=GRUNT NVM_VERSION='node'
exclude:
# MySQL - it's just too slow.
# Exclude it on all versions except for 7.0
# - env: DB=mysqli PHPUNIT=true INSTALL=false CITEST=false
# php: 5.6
#
# - env: DB=mysqli PHPUNIT=true INSTALL=false CITEST=false
# php: 5.5
# Exclude it on all versions except for 7.1
- env: DB=mysqli PHPUNIT=true INSTALL=false CITEST=false
php: 5.4
- env: DB=mysqli TASK=PHPUNIT
php: 5.6
# Moodle 2.7 is not compatible with PHP 7 for the upgrade test.
- env: DB=pgsql PHPUNIT=false INSTALL=true CITEST=false UPGRADE=true
php: 7.0
- env: DB=pgsql TASK=UPGRADE
php: 7.1
cache:
directories:
- $HOME/.composer/cache
- $HOME/.npm
install:
# Disable xdebug. We aren't generating code coverage, and it has a huge impact upon test performance.
- rm /home/travis/.phpenv/versions/$(phpenv version-name)/etc/conf.d/xdebug.ini
- >
if [ "$TASK" = 'PHPUNIT' ];
then
if [ -n "$GITHUB_APITOKEN" ]; then
composer config github-oauth.github.com $GITHUB_APITOKEN;
echo 'auth.json' >> .git/info/exclude
fi
# Set the encrypted GITHUB_TOKEN if it's available to raise the API limit.
- if [ -n "$GITHUB_APITOKEN" ]; then composer config github-oauth.github.com $GITHUB_APITOKEN; fi
# Enable Redis.
echo 'extension="redis.so"' > /tmp/redis.ini
phpenv config-add /tmp/redis.ini
# Install composer dependencies.
# We need --no-interaction in case we hit API limits for composer. This causes it to fall back to a standard clone.
# Typically it should be able to use the Composer cache if any other job has already completed before we started here.
- travis_retry composer install --prefer-dist --no-interaction
# Install composer dependencies.
# We need --no-interaction in case we hit API limits for composer. This causes it to fall back to a standard clone.
# Typically it should be able to use the Composer cache if any other job has already completed before we started here.
travis_retry composer install --prefer-dist --no-interaction;
fi
- >
if [ "$TASK" = 'GRUNT' ];
then
nvm install $NVM_VERSION ;
nvm use $NVM_VERSION ;
fi
before_script:
- phpenv config-rm xdebug.ini
- >
if [ "$INSTALL" = 'true' -o "$PHPUNIT" = 'true' ];
if [ "$TASK" = 'PHPUNIT' -o "$TASK" = 'UPGRADE' ];
then
# Copy generic configuration in place.
cp config-dist.php config.php ;
@@ -114,44 +134,45 @@ before_script:
sed -i \
-e "s%= 'pgsql'%= 'mysqli'%" \
-e "s%= 'username'%= 'travis'%" \
-e "s%=> 'utf8mb4_unicode_ci'%=> 'utf8mb4_bin'%" \
config.php;
mysql -u root -e 'SET GLOBAL innodb_file_format=barracuda;' ;
mysql -u root -e 'SET GLOBAL innodb_file_per_table=ON;' ;
mysql -e 'CREATE DATABASE travis_ci_test DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_bin;' ;
fi
if [ "$PHPUNIT" = 'true' ];
then
# Create a directory for the phpunit dataroot.
mkdir -p "$HOME"/roots/phpunit
# The phpunit dataroot and prefix..
sed -i \
-e "/require_once/i \\\$CFG->phpunit_dataroot = '\/home\/travis\/roots\/phpunit';" \
-e "/require_once/i \\\$CFG->phpunit_prefix = 'p_';" \
config.php ;
# Initialise PHPUnit for Moodle.
php admin/tool/phpunit/cli/init.php
mysql -u root -e 'SET GLOBAL innodb_large_prefix=ON;' ;
mysql -e 'CREATE DATABASE travis_ci_test DEFAULT CHARACTER SET utf8mb4 DEFAULT COLLATE utf8mb4_bin;' ;
fi
fi
script:
########################################################################
# PHPUnit
########################################################################
- >
if [ "$PHPUNIT" = 'true' ];
if [ "$TASK" = 'PHPUNIT' ];
then
vendor/bin/phpunit;
# Create a directory for the phpunit dataroot.
mkdir -p "$HOME"/roots/phpunit
# The phpunit dataroot and prefix..
sed -i \
-e "/require_once/i \\\$CFG->phpunit_dataroot = '\/home\/travis\/roots\/phpunit';" \
-e "/require_once/i \\\$CFG->phpunit_prefix = 'p_';" \
-e "/require_once/i \\define('TEST_SESSION_REDIS_HOST', '127.0.0.1');" \
config.php ;
# Initialise PHPUnit for Moodle.
php admin/tool/phpunit/cli/init.php
fi
- >
if [ "$TASK" = 'GRUNT' ];
then
npm install --no-spin;
npm install --no-spin -g grunt ;
fi
########################################################################
# CI Tests
########################################################################
- >
if [ "$CITEST" = 'true' ];
if [ "$TASK" = 'CITEST' ];
then
# Note - this is deliberately placed in the script section as we
# should not add any code until after phpunit has run.
@@ -163,7 +184,7 @@ script:
# We need the official upstream for comparison
git remote add upstream https://github.com/moodle/moodle.git;
git fetch upstream master;
git fetch upstream MOODLE_32_STABLE;
export GIT_PREVIOUS_COMMIT="`git merge-base FETCH_HEAD $TRAVIS_COMMIT`";
export GIT_COMMIT="$TRAVIS_COMMIT";
export UPSTREAM_FETCH_HEAD=`git rev-parse FETCH_HEAD`
@@ -174,18 +195,11 @@ script:
export phpcmd=`which php`;
fi
# Actually run the CI Tests - do this outside of the main test to make output clearer.
- >
if [ "$CITEST" = 'true' ];
then
bash local/ci/php_lint/php_lint.sh;
fi
########################################################################
# Upgrade test
########################################################################
- >
if [ "$UPGRADE" = 'true' ];
if [ "$TASK" = 'UPGRADE' ];
then
# We need the official upstream.
git remote add upstream https://github.com/moodle/moodle.git;
@@ -205,7 +219,37 @@ script:
# The local_ci repository can be used to check upgrade savepoints.
git clone https://github.com/moodlehq/moodle-local_ci.git local/ci ;
fi
script:
- >
if [ "$TASK" = 'PHPUNIT' ];
then
vendor/bin/phpunit;
fi
- >
if [ "$TASK" = 'CITEST' ];
then
bash local/ci/php_lint/php_lint.sh;
fi
- >
if [ "$TASK" = 'GRUNT' ];
then
grunt ;
# Add all files to the git index and then run diff --cached to see all changes.
# This ensures that we get the status of all files, including new files.
git add . ;
git diff --cached --exit-code ;
fi
########################################################################
# Upgrade test
########################################################################
- >
if [ "$TASK" = 'UPGRADE' ];
then
cp local/ci/check_upgrade_savepoints/check_upgrade_savepoints.php ./check_upgrade_savepoints.php
result=`php check_upgrade_savepoints.php`;
# Check if there are problems
+145 -24
View File
@@ -13,6 +13,7 @@
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/* jshint node: true, browser: false */
/* eslint-env node */
/**
* @copyright 2014 Andrew Nicols
@@ -26,7 +27,18 @@
module.exports = function(grunt) {
var path = require('path'),
tasks = {},
cwd = process.env.PWD || process.cwd();
cwd = process.env.PWD || process.cwd(),
async = require('async'),
DOMParser = require('xmldom').DOMParser,
xpath = require('xpath'),
semver = require('semver');
// Verify the node version is new enough.
var expected = semver.validRange(grunt.file.readJSON('package.json').engines.node);
var actual = semver.valid(process.version);
if (!semver.satisfies(actual, expected)) {
grunt.fail.fatal('Node version too old. Require ' + expected + ', version installed: ' + actual);
}
// Windows users can't run grunt in a subdirectory, so allow them to set
// the root by passing --root=path/to/dir.
@@ -34,9 +46,9 @@ module.exports = function(grunt) {
var root = grunt.option('root');
if (grunt.file.exists(__dirname, root)) {
cwd = path.join(__dirname, root);
grunt.log.ok('Setting root to '+cwd);
grunt.log.ok('Setting root to ' + cwd);
} else {
grunt.fail.fatal('Setting root to '+root+' failed - path does not exist');
grunt.fail.fatal('Setting root to ' + root + ' failed - path does not exist');
}
}
@@ -55,26 +67,81 @@ module.exports = function(grunt) {
* @param {String} srcPath the matched src path
* @return {String} The rewritten destination path.
*/
var uglify_rename = function (destPath, srcPath) {
var uglifyRename = function(destPath, srcPath) {
destPath = srcPath.replace('src', 'build');
destPath = destPath.replace('.js', '.min.js');
destPath = path.resolve(cwd, destPath);
return destPath;
};
/**
* Find thirdpartylibs.xml and generate an array of paths contained within
* them (used to generate ignore files and so on).
*
* @return {array} The list of thirdparty paths.
*/
var getThirdPartyPathsFromXML = function() {
var thirdpartyfiles = grunt.file.expand('*/**/thirdpartylibs.xml');
var libs = ['node_modules/', 'vendor/'];
thirdpartyfiles.forEach(function(file) {
var dirname = path.dirname(file);
var doc = new DOMParser().parseFromString(grunt.file.read(file));
var nodes = xpath.select("/libraries/library/location/text()", doc);
nodes.forEach(function(node) {
var lib = path.join(dirname, node.toString());
if (grunt.file.isDir(lib)) {
// Ensure trailing slash on dirs.
lib = lib.replace(/\/?$/, '/');
}
// Look for duplicate paths before adding to array.
if (libs.indexOf(lib) === -1) {
libs.push(lib);
}
});
});
return libs;
};
// Project configuration.
grunt.initConfig({
jshint: {
options: {jshintrc: '.jshintrc'},
amd: { src: amdSrc }
eslint: {
// Even though warnings dont stop the build we don't display warnings by default because
// at this moment we've got too many core warnings.
options: {quiet: !grunt.option('show-lint-warnings')},
amd: {
src: amdSrc,
// Check AMD with some slightly stricter rules.
rules: {
'no-unused-vars': 'error',
'no-implicit-globals': 'error'
}
},
// Check YUI module source files.
yui: {
src: ['**/yui/src/**/*.js', '!*/**/yui/src/*/meta/*.js'],
options: {
// Disable some rules which we can't safely define for YUI rollups.
rules: {
'no-undef': 'off',
'no-unused-vars': 'off',
'no-unused-expressions': 'off'
}
}
}
},
uglify: {
amd: {
files: [{
expand: true,
src: amdSrc,
rename: uglify_rename
}]
rename: uglifyRename
}],
options: {report: 'none'}
}
},
less: {
@@ -84,7 +151,7 @@ module.exports = function(grunt) {
"theme/bootstrapbase/style/editor.css": "theme/bootstrapbase/less/editor.less",
},
options: {
compress: true
compress: false // We must not compress to keep the comments.
}
}
},
@@ -98,11 +165,11 @@ module.exports = function(grunt) {
},
bootstrapbase: {
files: ["theme/bootstrapbase/less/**/*.less"],
tasks: ["less:bootstrapbase"]
tasks: ["css"]
},
yui: {
files: ['**/yui/src/**/*.js'],
tasks: ['shifter']
tasks: ['yui']
},
},
shifter: {
@@ -110,9 +177,59 @@ module.exports = function(grunt) {
recursive: true,
paths: [cwd]
}
},
stylelint: {
less: {
options: {
syntax: 'less',
configOverrides: {
rules: {
// These rules have to be disabled in .stylelintrc for scss compat.
"at-rule-no-unknown": true,
"no-browser-hacks": [true, {"severity": "warning"}]
}
}
},
src: ['theme/**/*.less']
},
scss: {
options: {syntax: 'scss'},
src: ['*/**/*.scss']
},
css: {
src: ['*/**/*.css'],
options: {
configOverrides: {
rules: {
// These rules have to be disabled in .stylelintrc for scss compat.
"at-rule-no-unknown": true,
"no-browser-hacks": [true, {"severity": "warning"}]
}
}
}
}
}
});
/**
* Generate ignore files (utilising thirdpartylibs.xml data)
*/
tasks.ignorefiles = function() {
// An array of paths to third party directories.
var thirdPartyPaths = getThirdPartyPathsFromXML();
// Generate .eslintignore.
var eslintIgnores = ['# Generated by "grunt ignorefiles"', '*/**/yui/src/*/meta/', '*/**/build/'].concat(thirdPartyPaths);
grunt.file.write('.eslintignore', eslintIgnores.join('\n'));
// Generate .stylelintignore.
var stylelintIgnores = [
'# Generated by "grunt ignorefiles"',
'theme/bootstrapbase/style/',
'theme/clean/style/custom.css',
'theme/more/style/custom.css'
].concat(thirdPartyPaths);
grunt.file.write('.stylelintignore', stylelintIgnores.join('\n'));
};
/**
* Shifter task. Is configured with a path to a specific file or a directory,
* in the case of a specific file it will work out the right module to be built.
@@ -121,14 +238,13 @@ module.exports = function(grunt) {
* so be careful to to call done().
*/
tasks.shifter = function() {
var async = require('async'),
done = this.async(),
var done = this.async(),
options = grunt.config('shifter.options');
// Run the shifter processes one at a time to avoid confusing output.
async.eachSeries(options.paths, function (src, filedone) {
async.eachSeries(options.paths, function(src, filedone) {
var args = [];
args.push( path.normalize(__dirname + '/node_modules/shifter/bin/shifter'));
args.push(path.normalize(__dirname + '/node_modules/shifter/bin/shifter'));
// Always ignore the node_modules directory.
args.push('--excludes', 'node_modules');
@@ -176,7 +292,7 @@ module.exports = function(grunt) {
cmd: "node",
args: args,
opts: {cwd: src, stdio: 'inherit', env: process.env}
}, function (error, result, code) {
}, function(error, result, code) {
if (code) {
grunt.fail.fatal('Shifter failed with code: ' + code);
} else {
@@ -205,7 +321,7 @@ module.exports = function(grunt) {
tasks.startup = function() {
// Are we in a YUI directory?
if (path.basename(path.resolve(cwd, '../../')) == 'yui') {
grunt.task.run('shifter');
grunt.task.run('yui');
// Are we in an AMD directory?
} else if (inAMD) {
grunt.task.run('amd');
@@ -222,9 +338,11 @@ module.exports = function(grunt) {
var changedFiles = Object.create(null);
var onChange = grunt.util._.debounce(function() {
var files = Object.keys(changedFiles);
grunt.config('jshint.amd.src', files);
grunt.config('uglify.amd.files', [{ expand: true, src: files, rename: uglify_rename }]);
grunt.config('eslint.amd.src', files);
grunt.config('eslint.yui.src', files);
grunt.config('uglify.amd.files', [{expand: true, src: files, rename: uglifyRename}]);
grunt.config('shifter.options.paths', files);
grunt.config('stylelint.less.src', files);
changedFiles = Object.create(null);
}, 200);
@@ -235,17 +353,20 @@ module.exports = function(grunt) {
// Register NPM tasks.
grunt.loadNpmTasks('grunt-contrib-uglify');
grunt.loadNpmTasks('grunt-contrib-jshint');
grunt.loadNpmTasks('grunt-contrib-less');
grunt.loadNpmTasks('grunt-contrib-watch');
grunt.loadNpmTasks('grunt-eslint');
grunt.loadNpmTasks('grunt-stylelint');
// Register JS tasks.
grunt.registerTask('shifter', 'Run Shifter against the current directory', tasks.shifter);
grunt.registerTask('amd', ['jshint', 'uglify']);
grunt.registerTask('js', ['amd', 'shifter']);
grunt.registerTask('ignorefiles', 'Generate ignore files for linters', tasks.ignorefiles);
grunt.registerTask('yui', ['eslint:yui', 'shifter']);
grunt.registerTask('amd', ['eslint:amd', 'uglify']);
grunt.registerTask('js', ['amd', 'yui']);
// Register CSS taks.
grunt.registerTask('css', ['less:bootstrapbase']);
grunt.registerTask('css', ['stylelint:scss', 'stylelint:less', 'less:bootstrapbase', 'stylelint:css']);
// Register the startup task.
grunt.registerTask('startup', 'Run the correct tasks for the current directory', tasks.startup);
+48
View File
@@ -0,0 +1,48 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Admin settings search form
*
* @package admin
* @copyright 2016 Damyon Wiese
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
defined('MOODLE_INTERNAL') || die();
require_once $CFG->libdir.'/formslib.php';
/**
* Admin settings search form
*
* @package admin
* @copyright 2016 Damyon Wiese
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class admin_settings_search_form extends moodleform {
function definition () {
$mform = $this->_form;
//$mform->addElement('header', 'settingsheader', get_string('search', 'admin'));
$elements = [];
$elements[] = $mform->createElement('text', 'query', get_string('query', 'admin'));
$elements[] = $mform->createElement('submit', 'search', get_string('search'));
$mform->addGroup($elements);
$mform->setType('query', PARAM_RAW);
$mform->setDefault('query', optional_param('query', '', PARAM_RAW));
}
}
-2
View File
@@ -64,8 +64,6 @@ echo "<form id=\"authmenu\" method=\"post\" action=\"auth_config.php\">\n";
echo "<div>\n";
echo "<input type=\"hidden\" name=\"sesskey\" value=\"".sesskey()."\" />\n";
echo "<input type=\"hidden\" name=\"auth\" value=\"".$auth."\" />\n";
// HACK to prevent browsers from automatically inserting the user's password into the wrong fields.
echo prevent_form_autofill_password();
// auth plugin description
echo $OUTPUT->box_start();
+11 -23
View File
@@ -4,6 +4,7 @@
require_once('../config.php');
require_once($CFG->libdir.'/adminlib.php');
require_once($CFG->libdir.'/blocklib.php');
require_once($CFG->libdir.'/tablelib.php');
admin_externalpage_setup('manageblocks');
@@ -36,6 +37,7 @@
print_error('blockdoesnotexist', 'error');
}
$DB->set_field('block', 'visible', '0', array('id'=>$block->id)); // Hide block
add_to_config_log('block_visibility', $block->visible, '0', $block->name);
core_plugin_manager::reset_caches();
admin_get_root(true, false); // settings not required - only pages
}
@@ -45,40 +47,23 @@
print_error('blockdoesnotexist', 'error');
}
$DB->set_field('block', 'visible', '1', array('id'=>$block->id)); // Show block
add_to_config_log('block_visibility', $block->visible, '1', $block->name);
core_plugin_manager::reset_caches();
admin_get_root(true, false); // settings not required - only pages
}
if (!isset($CFG->undeletableblocktypes) || (!is_array($CFG->undeletableblocktypes) && !is_string($CFG->undeletableblocktypes))) {
$undeletableblocktypes = array('navigation', 'settings');
} else if (is_string($CFG->undeletableblocktypes)) {
$undeletableblocktypes = explode(',', $CFG->undeletableblocktypes);
} else {
$undeletableblocktypes = $CFG->undeletableblocktypes;
}
if (!empty($protect) && confirm_sesskey()) {
if (!$block = $DB->get_record('block', array('id'=>$protect))) {
print_error('blockdoesnotexist', 'error');
}
if (!in_array($block->name, $undeletableblocktypes)) {
$undeletableblocktypes[] = $block->name;
set_config('undeletableblocktypes', implode(',', $undeletableblocktypes));
}
block_manager::protect_block((int)$protect);
admin_get_root(true, false); // settings not required - only pages
}
if (!empty($unprotect) && confirm_sesskey()) {
if (!$block = $DB->get_record('block', array('id'=>$unprotect))) {
print_error('blockdoesnotexist', 'error');
}
if (in_array($block->name, $undeletableblocktypes)) {
$undeletableblocktypes = array_diff($undeletableblocktypes, array($block->name));
set_config('undeletableblocktypes', implode(',', $undeletableblocktypes));
}
block_manager::unprotect_block((int)$unprotect);
admin_get_root(true, false); // settings not required - only pages
}
$undeletableblocktypes = block_manager::get_undeletable_block_types();
echo $OUTPUT->header();
echo $OUTPUT->heading($strmanageblocks);
@@ -154,7 +139,10 @@
$settings = '<a href="' . $blocksettings->url . '">' . get_string('settings') . '</a>';
} else if ($blocksettings instanceof admin_settingpage) {
$settings = '<a href="'.$CFG->wwwroot.'/'.$CFG->admin.'/settings.php?section=blocksetting'.$block->name.'">'.$strsettings.'</a>';
} else {
} else if (!file_exists($CFG->dirroot.'/blocks/'.$block->name.'/settings.php')) {
// If the block's settings node was not found, we check that the block really provides the settings.php file.
// Note that blocks can inject their settings to other nodes in the admin tree without using the default locations.
// This can be done by assigning null to $setting in settings.php and it is a valid case.
debugging('Warning: block_'.$block->name.' returns true in has_config() but does not provide a settings.php file',
DEBUG_DEVELOPER);
}
+1 -1
View File
@@ -120,7 +120,7 @@ foreach ($settingspage->children as $childpage) {
}
if ($savebutton) {
$outputhtml .= html_writer::start_tag('div', array('class' => 'form-buttons'));
$outputhtml .= html_writer::empty_tag('input', array('class' => 'form-submit', 'type' => 'submit', 'value' => get_string('savechanges','admin')));
$outputhtml .= html_writer::empty_tag('input', array('class' => 'btn btn-primary form-submit', 'type' => 'submit', 'value' => get_string('savechanges','admin')));
$outputhtml .= html_writer::end_tag('div');
}
+1 -1
View File
@@ -28,7 +28,7 @@
define('CLI_SCRIPT', true);
require(dirname(dirname(dirname(__FILE__))).'/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/clilib.php'); // cli only functions
require_once($CFG->libdir.'/cronlib.php');
+1 -1
View File
@@ -25,7 +25,7 @@
define('CLI_SCRIPT', 1);
require(dirname(dirname(dirname(__FILE__))).'/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/clilib.php');
require_once($CFG->dirroot . '/backup/util/includes/backup_includes.php');
+1 -1
View File
@@ -30,7 +30,7 @@
define('CLI_SCRIPT', true);
require(dirname(dirname(dirname(__FILE__))).'/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/clilib.php'); // cli only functions
require_once($CFG->libdir.'/cronlib.php');
+7 -7
View File
@@ -90,7 +90,7 @@ Example:
// distro specific customisation
$distrolibfile = dirname(dirname(dirname(__FILE__))).'/install/distrolib.php';
$distrolibfile = __DIR__.'/../../install/distrolib.php';
$distro = null;
if (file_exists($distrolibfile)) {
require_once($distrolibfile);
@@ -100,7 +100,7 @@ if (file_exists($distrolibfile)) {
}
// Nothing to do if config.php exists
$configfile = dirname(dirname(dirname(__FILE__))).'/config.php';
$configfile = __DIR__.'/../../config.php';
if (file_exists($configfile)) {
require($configfile);
require_once($CFG->libdir.'/clilib.php');
@@ -147,10 +147,10 @@ define('PHPUNIT_TEST', false);
define('IGNORE_COMPONENT_CACHE', true);
// Check that PHP is of a sufficient version
if (version_compare(phpversion(), "5.4.4") < 0) {
if (version_compare(phpversion(), "5.6.5") < 0) {
$phpversion = phpversion();
// do NOT localise - lang strings would not work here and we CAN NOT move it after installib
fwrite(STDERR, "Moodle 2.7 or later requires at least PHP 5.4.4 (currently using version $phpversion).\n");
fwrite(STDERR, "Moodle 3.2 or later requires at least PHP 5.6.5 (currently using version $phpversion).\n");
fwrite(STDERR, "Please upgrade your server software or install older Moodle version.\n");
exit(1);
}
@@ -159,7 +159,7 @@ if (version_compare(phpversion(), "5.4.4") < 0) {
global $CFG;
$CFG = new stdClass();
$CFG->lang = 'en';
$CFG->dirroot = dirname(dirname(dirname(__FILE__)));
$CFG->dirroot = dirname(dirname(__DIR__));
$CFG->libdir = "$CFG->dirroot/lib";
$CFG->wwwroot = "http://localhost";
$CFG->httpswwwroot = $CFG->wwwroot;
@@ -172,7 +172,7 @@ $CFG->debug = (E_ALL | E_STRICT);
$CFG->debugdisplay = true;
$CFG->debugdeveloper = true;
$parts = explode('/', str_replace('\\', '/', dirname(dirname(__FILE__))));
$parts = explode('/', str_replace('\\', '/', dirname(__DIR__)));
$CFG->admin = array_pop($parts);
//point pear include path to moodles lib/pear so that includes and requires will search there for files before anywhere else
@@ -244,7 +244,7 @@ list($options, $unrecognized) = cli_get_params(
'chmod' => isset($distro->directorypermissions) ? sprintf('%04o',$distro->directorypermissions) : '2777', // let distros set dir permissions
'lang' => $CFG->lang,
'wwwroot' => '',
'dataroot' => empty($distro->dataroot) ? str_replace('\\', '/', dirname(dirname(dirname(dirname(__FILE__)))).'/moodledata'): $distro->dataroot, // initialised later after including libs or by distro
'dataroot' => empty($distro->dataroot) ? str_replace('\\', '/', dirname(dirname(dirname(__DIR__))).'/moodledata'): $distro->dataroot, // initialised later after including libs or by distro
'dbtype' => empty($distro->dbtype) ? $defaultdb : $distro->dbtype, // let distro skip dbtype selection
'dbhost' => empty($distro->dbhost) ? 'localhost' : $distro->dbhost, // let distros set dbhost
'dbname' => 'moodle',
+3 -3
View File
@@ -63,16 +63,16 @@ Example:
";
// Check that PHP is of a sufficient version
if (version_compare(phpversion(), "5.4.4") < 0) {
if (version_compare(phpversion(), "5.6.5") < 0) {
$phpversion = phpversion();
// do NOT localise - lang strings would not work here and we CAN NOT move it after installib
fwrite(STDERR, "Moodle 2.7 or later requires at least PHP 5.4.4 (currently using version $phpversion).\n");
fwrite(STDERR, "Moodle 3.2 or later requires at least PHP 5.6.5 (currently using version $phpversion).\n");
fwrite(STDERR, "Please upgrade your server software or install older Moodle version.\n");
exit(1);
}
// Nothing to do if config.php does not exist
$configfile = dirname(dirname(dirname(__FILE__))).'/config.php';
$configfile = __DIR__.'/../../config.php';
if (!file_exists($configfile)) {
fwrite(STDERR, 'config.php does not exist, can not continue'); // do not localize
fwrite(STDERR, "\n");
+87 -6
View File
@@ -24,7 +24,7 @@
define('CLI_SCRIPT', true);
require(dirname(dirname(dirname(__FILE__))).'/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/clilib.php'); // cli only functions
if ($DB->get_dbfamily() !== 'mysql') {
@@ -64,6 +64,71 @@ if (!empty($options['collation'])) {
cli_error("Error: collation '$collation' is not available on this server!");
}
$collationinfo = explode('_', $collation);
$charset = reset($collationinfo);
$engine = strtolower($DB->get_dbengine());
// Do checks for utf8mb4.
if (strpos($collation, 'utf8mb4') === 0) {
// Do we have the right engine?
if ($engine !== 'innodb' && $engine !== 'xtradb') {
cli_error("Error: '$collation' requires InnoDB or XtraDB set as the engine.");
}
// Are we using Barracuda?
if ($DB->get_row_format() != 'Barracuda') {
// Try setting it here.
try {
$DB->execute("SET GLOBAL innodb_file_format=Barracuda");
} catch (dml_exception $e) {
cli_error("Error: '$collation' requires the file format to be set to Barracuda.
An attempt was made to change the format, but it failed. Please try doing this manually.");
}
echo "GLOBAL SETTING: innodb_file_format changed to Barracuda\n";
}
// Is one file per table being used?
if (!$DB->is_file_per_table_enabled()) {
try {
$DB->execute("SET GLOBAL innodb_file_per_table=1");
} catch (dml_exception $e) {
cli_error("Error: '$collation' requires the setting 'innodb_file_per_table' be set to 'ON'.
An attempt was made to change the format, but it failed. Please try doing this manually.");
}
echo "GLOBAL SETTING: innodb_file_per_table changed to 1\n";
}
// Is large prefix set?
if (!$DB->is_large_prefix_enabled()) {
try {
$DB->execute("SET GLOBAL innodb_large_prefix=1");
} catch (dml_exception $e) {
cli_error("Error: '$collation' requires the setting 'innodb_large_prefix' be set to 'ON'.
An attempt was made to change the format, but it failed. Please try doing this manually.");
}
echo "GLOBAL SETTING: innodb_large_prefix changed to 1\n";
}
}
$sql = "SHOW VARIABLES LIKE 'collation_database'";
if (!$dbcollation = $DB->get_record_sql($sql)) {
cli_error("Error: Could not access collation information on the database.");
}
$sql = "SHOW VARIABLES LIKE 'character_set_database'";
if (!$dbcharset = $DB->get_record_sql($sql)) {
cli_error("Error: Could not access character set information on the database.");
}
if ($dbcollation->value !== $collation || $dbcharset->value !== $charset) {
// Try to convert the DB.
echo "Converting database to '$collation' for $CFG->wwwroot:\n";
$sql = "ALTER DATABASE $CFG->dbname DEFAULT CHARACTER SET $charset DEFAULT COLLATE = $collation";
try {
$DB->change_database_structure($sql);
} catch (exception $e) {
cli_error("Error: Tried to alter the database with no success. Please try manually changing the database
to the new collation and character set and then run this script again.");
}
echo "DATABASE CONVERTED\n";
}
echo "Converting tables and columns to '$collation' for $CFG->wwwroot:\n";
$prefix = $DB->get_prefix();
$prefix = str_replace('_', '\\_', $prefix);
@@ -80,7 +145,7 @@ if (!empty($options['collation'])) {
$skipped++;
} else {
$DB->change_database_structure("ALTER TABLE $table->name DEFAULT COLLATE = $collation");
$DB->change_database_structure("ALTER TABLE $table->name DEFAULT CHARACTER SET $charset DEFAULT COLLATE = $collation");
echo "CONVERTED\n";
$converted++;
}
@@ -96,18 +161,32 @@ if (!empty($options['collation'])) {
continue;
}
// Check for utf8mb4 collation.
$rowformat = $DB->get_row_format_sql($engine, $collation);
if ($column->type === 'tinytext' or $column->type === 'mediumtext' or $column->type === 'text' or $column->type === 'longtext') {
$notnull = ($column->null === 'NO') ? 'NOT NULL' : 'NULL';
$default = (!is_null($column->default) and $column->default !== '') ? "DEFAULT '$column->default'" : '';
// primary, unique and inc are not supported for texts
$sql = "ALTER TABLE $table->name MODIFY COLUMN $column->field $column->type COLLATE $collation $notnull $default";
$sql = "ALTER TABLE $table->name
MODIFY COLUMN $column->field $column->type
CHARACTER SET $charset
COLLATE $collation $notnull $default";
$DB->change_database_structure($sql);
} else if (strpos($column->type, 'varchar') === 0) {
$notnull = ($column->null === 'NO') ? 'NOT NULL' : 'NULL';
$default = !is_null($column->default) ? "DEFAULT '$column->default'" : '';
// primary, unique and inc are not supported for texts
$sql = "ALTER TABLE $table->name MODIFY COLUMN $column->field $column->type COLLATE $collation $notnull $default";
if ($rowformat != '') {
$sql = "ALTER TABLE $table->name $rowformat";
$DB->change_database_structure($sql);
}
$sql = "ALTER TABLE $table->name
MODIFY COLUMN $column->field $column->type
CHARACTER SET $charset
COLLATE $collation $notnull $default";
$DB->change_database_structure($sql);
} else {
echo "ERROR (unknown column type: $column->type)\n";
@@ -180,7 +259,9 @@ function mysql_get_collations() {
global $DB;
$collations = array();
$sql = "SHOW COLLATION WHERE Collation LIKE 'utf8\_%' AND Charset = 'utf8'";
$sql = "SHOW COLLATION
WHERE Collation LIKE 'utf8\_%' AND Charset = 'utf8'
OR Collation LIKE 'utf8mb4\_%' AND Charset = 'utf8mb4'";
$rs = $DB->get_recordset_sql($sql);
foreach ($rs as $collation) {
$collations[$collation->collation] = $collation->collation;
+1 -1
View File
@@ -25,7 +25,7 @@
define('CLI_SCRIPT', true);
require(dirname(__FILE__).'/../../config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir . '/clilib.php');
if ($DB->get_dbfamily() !== 'mysql') {
+1 -1
View File
@@ -26,7 +26,7 @@
define('CLI_SCRIPT', true);
require(dirname(dirname(dirname(__FILE__))).'/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/clilib.php'); // cli only functions
if ($DB->get_dbfamily() !== 'mysql') {
+1 -1
View File
@@ -23,7 +23,7 @@
define('CLI_SCRIPT', true);
require(dirname(dirname(dirname(__FILE__))).'/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/clilib.php');
list($options, $unrecognized) = cli_get_params(array('help' => false), array('h' => 'help'));
+40 -13
View File
@@ -26,13 +26,26 @@
define('CLI_SCRIPT', true);
require(dirname(dirname(dirname(__FILE__))).'/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/clilib.php'); // cli only functions
// Define the input options.
$longparams = array(
'help' => false,
'username' => '',
'password' => '',
'ignore-password-policy' => false
);
$shortparams = array(
'h' => 'help',
'u' => 'username',
'p' => 'password',
'i' => 'ignore-password-policy'
);
// now get cli options
list($options, $unrecognized) = cli_get_params(array('help'=>false),
array('h'=>'help'));
list($options, $unrecognized) = cli_get_params($longparams, $shortparams);
if ($unrecognized) {
$unrecognized = implode("\n ", $unrecognized);
@@ -47,29 +60,43 @@ There are no security checks here because anybody who is able to
execute this file may execute any PHP too.
Options:
-h, --help Print out this help
-h, --help Print out this help
-u, --username=username Specify username to change
-p, --password=newpassword Specify new password
--ignore-password-policy Ignore password policy when setting password
Example:
\$sudo -u www-data /usr/bin/php admin/cli/reset_password.php
"; //TODO: localize - to be translated later when everything is finished
\$sudo -u www-data /usr/bin/php admin/cli/reset_password.php --username=rosaura --password=jiu3jiu --ignore-password-policy
";
echo $help;
die;
}
cli_heading('Password reset'); // TODO: localize
$prompt = "enter username (manual authentication only)"; // TODO: localize
$username = cli_input($prompt);
if ($options['username'] == '' ) {
cli_heading('Password reset');
$prompt = "Enter username (manual authentication only)";
$username = cli_input($prompt);
} else {
$username = $options['username'];
}
if (!$user = $DB->get_record('user', array('auth'=>'manual', 'username'=>$username, 'mnethostid'=>$CFG->mnet_localhost_id))) {
cli_error("Can not find user '$username'");
}
$prompt = "Enter new password"; // TODO: localize
$password = cli_input($prompt);
if ($options['password'] == '' ) {
$prompt = "Enter new password";
$password = cli_input($prompt);
} else {
$password = $options['password'];
}
$errmsg = '';//prevent eclipse warning
if (!check_password_policy($password, $errmsg)) {
cli_error($errmsg);
if (!$options['ignore-password-policy'] ) {
if (!check_password_policy($password, $errmsg)) {
cli_error(html_to_text($errmsg, 0));
}
}
$hashedpassword = hash_internal_user_password($password);
@@ -78,4 +105,4 @@ $DB->set_field('user', 'password', $hashedpassword, array('id'=>$user->id));
echo "Password changed\n";
exit(0); // 0 means success
exit(0); // 0 means success.
@@ -17,7 +17,7 @@
/**
* This script implements some useful svg manipulation tricks.
*
* @package theme_base
* @package core_admin
* @subpackage cli
* @copyright 2012 Petr Skoda {@link http://skodak.org}
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
@@ -25,7 +25,7 @@
define('CLI_SCRIPT', true);
require(__DIR__.'/../../../config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/clilib.php');
// Now get cli options.
@@ -45,10 +45,10 @@ if (!file_exists($path)) {
}
if ($options['ie9fix']) {
theme_base_recurse_svgs($path, '', 'theme_base_svgtool_ie9fix', $blacklist);
core_admin_recurse_svgs($path, '', 'core_admin_svgtool_ie9fix', $blacklist);
} else if ($options['noaspectratio']) {
theme_base_recurse_svgs($path, '', 'theme_base_svgtool_noaspectratio', $blacklist);
core_admin_recurse_svgs($path, '', 'core_admin_svgtool_noaspectratio', $blacklist);
} else {
$help =
@@ -78,7 +78,7 @@ exit(0);
*
* @param string $file
*/
function theme_base_svgtool_ie9fix($file) {
function core_admin_svgtool_ie9fix($file) {
global $CFG;
if (strpos($file, $CFG->dirroot.DIRECTORY_SEPARATOR) === 0) {
@@ -115,7 +115,7 @@ function theme_base_svgtool_ie9fix($file) {
*
* @param string $file
*/
function theme_base_svgtool_noaspectratio($file) {
function core_admin_svgtool_noaspectratio($file) {
global $CFG;
if (strpos($file, $CFG->dirroot.DIRECTORY_SEPARATOR) === 0) {
@@ -155,7 +155,7 @@ function theme_base_svgtool_noaspectratio($file) {
* @param string $filecallback
* @param array $blacklist
*/
function theme_base_recurse_svgs($base, $sub, $filecallback, $blacklist) {
function core_admin_recurse_svgs($base, $sub, $filecallback, $blacklist) {
if (is_dir("$base/$sub")) {
$items = new DirectoryIterator("$base/$sub");
foreach ($items as $item) {
@@ -163,7 +163,7 @@ function theme_base_recurse_svgs($base, $sub, $filecallback, $blacklist) {
continue;
}
$file = $item->getFilename();
theme_base_recurse_svgs("$base/$sub", $file, $filecallback, $blacklist);
core_admin_recurse_svgs("$base/$sub", $file, $filecallback, $blacklist);
}
unset($item);
unset($items);
+1 -1
View File
@@ -38,7 +38,7 @@ if (function_exists('opcache_reset') and !isset($_SERVER['REMOTE_ADDR'])) {
define('CLI_SCRIPT', true);
define('CACHE_DISABLE_ALL', true);
require(dirname(dirname(dirname(__FILE__))).'/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/adminlib.php'); // various admin-only functions
require_once($CFG->libdir.'/upgradelib.php'); // general upgrade/install related functions
require_once($CFG->libdir.'/clilib.php'); // cli only functions
+202
View File
@@ -1145,6 +1145,11 @@
<ON_CHECK message="unsupporteddbtablerowformat" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_libcurl_version" level="optional">
<FEEDBACK>
<ON_CHECK message="libcurlwarning" />
</FEEDBACK>
</CUSTOM_CHECK>
</CUSTOM_CHECKS>
</MOODLE>
<MOODLE version="2.8" requires="2.2">
@@ -1418,6 +1423,11 @@
<ON_CHECK message="unsupporteddbtablerowformat" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_libcurl_version" level="optional">
<FEEDBACK>
<ON_CHECK message="libcurlwarning" />
</FEEDBACK>
</CUSTOM_CHECK>
</CUSTOM_CHECKS>
</MOODLE>
<MOODLE version="3.0" requires="2.2">
@@ -1434,6 +1444,7 @@
<VENDOR name="oracle" version="10.2" />
</DATABASE>
<PHP version="5.4.4" level="required">
<RESTRICT function="restrict_php_version_71" message="unsupportedphpversion71" />
</PHP>
<PCREUNICODE level="optional">
<FEEDBACK>
@@ -1556,6 +1567,11 @@
<ON_CHECK message="unsupporteddbtablerowformat" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_libcurl_version" level="optional">
<FEEDBACK>
<ON_CHECK message="libcurlwarning" />
</FEEDBACK>
</CUSTOM_CHECK>
</CUSTOM_CHECKS>
</MOODLE>
<MOODLE version="3.1" requires="2.7">
@@ -1572,6 +1588,7 @@
<VENDOR name="oracle" version="10.2" />
</DATABASE>
<PHP version="5.4.4" level="required">
<RESTRICT function="restrict_php_version_71" message="unsupportedphpversion71" />
</PHP>
<PCREUNICODE level="optional">
<FEEDBACK>
@@ -1701,6 +1718,191 @@
<ON_CHECK message="unoconvwarning" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_libcurl_version" level="optional">
<FEEDBACK>
<ON_CHECK message="libcurlwarning" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_mysql_file_format" level="required">
<FEEDBACK>
<ON_ERROR message="unsupporteddbfileformat" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_mysql_file_per_table" level="required">
<FEEDBACK>
<ON_ERROR message="unsupporteddbfilepertable" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_mysql_large_prefix" level="required">
<FEEDBACK>
<ON_ERROR message="unsupporteddblargeprefix" />
</FEEDBACK>
</CUSTOM_CHECK>
</CUSTOM_CHECKS>
</MOODLE>
<MOODLE version="3.2" requires="2.7">
<UNICODE level="required">
<FEEDBACK>
<ON_ERROR message="unicoderequired" />
</FEEDBACK>
</UNICODE>
<DATABASE level="required">
<VENDOR name="mariadb" version="5.5.31" />
<VENDOR name="mysql" version="5.5.31" />
<VENDOR name="postgres" version="9.1" />
<VENDOR name="mssql" version="10.0" />
<VENDOR name="oracle" version="10.2" />
</DATABASE>
<PHP version="5.6.5" level="required">
</PHP>
<PCREUNICODE level="optional">
<FEEDBACK>
<ON_CHECK message="pcreunicodewarning" />
</FEEDBACK>
</PCREUNICODE>
<PHP_EXTENSIONS>
<PHP_EXTENSION name="iconv" level="required">
<FEEDBACK>
<ON_ERROR message="iconvrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="mbstring" level="optional">
<FEEDBACK>
<ON_CHECK message="mbstringrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="curl" level="required">
<FEEDBACK>
<ON_ERROR message="curlrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="openssl" level="optional">
<FEEDBACK>
<ON_CHECK message="opensslrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="tokenizer" level="optional">
<FEEDBACK>
<ON_CHECK message="tokenizerrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="xmlrpc" level="optional">
<FEEDBACK>
<ON_CHECK message="xmlrpcrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="soap" level="optional">
<FEEDBACK>
<ON_CHECK message="soaprecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="ctype" level="required">
<FEEDBACK>
<ON_ERROR message="ctyperequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="zip" level="required">
<FEEDBACK>
<ON_ERROR message="ziprequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="zlib" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="gd" level="required">
<FEEDBACK>
<ON_ERROR message="gdrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="simplexml" level="required">
<FEEDBACK>
<ON_ERROR message="simplexmlrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="spl" level="required">
<FEEDBACK>
<ON_ERROR message="splrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="pcre" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="dom" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="xml" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="xmlreader" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="intl" level="optional">
<FEEDBACK>
<ON_CHECK message="intlrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="json" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="hash" level="required"/>
</PHP_EXTENSIONS>
<PHP_SETTINGS>
<PHP_SETTING name="memory_limit" value="96M" level="required">
<FEEDBACK>
<ON_ERROR message="settingmemorylimit" />
</FEEDBACK>
</PHP_SETTING>
<PHP_SETTING name="file_uploads" value="1" level="optional">
<FEEDBACK>
<ON_CHECK message="settingfileuploads" />
</FEEDBACK>
</PHP_SETTING>
<PHP_SETTING name="opcache.enable" value="1" level="optional">
<FEEDBACK>
<ON_CHECK message="opcacherecommended" />
</FEEDBACK>
</PHP_SETTING>
</PHP_SETTINGS>
<CUSTOM_CHECKS>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_database_storage_engine" level="required">
<FEEDBACK>
<ON_ERROR message="unsupporteddbstorageengine" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="question/engine/upgrade/upgradelib.php" function="quiz_attempts_upgraded" level="required">
<FEEDBACK>
<ON_ERROR message="quizattemptsupgradedmessage" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_slasharguments" level="optional">
<FEEDBACK>
<ON_CHECK message="slashargumentswarning" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_database_tables_row_format" level="optional">
<FEEDBACK>
<ON_CHECK message="unsupporteddbtablerowformat" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_unoconv_version" level="optional">
<FEEDBACK>
<ON_CHECK message="unoconvwarning" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_libcurl_version" level="optional">
<FEEDBACK>
<ON_CHECK message="libcurlwarning" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_mysql_file_format" level="required">
<FEEDBACK>
<ON_ERROR message="unsupporteddbfileformat" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_mysql_file_per_table" level="required">
<FEEDBACK>
<ON_ERROR message="unsupporteddbfilepertable" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_mysql_large_prefix" level="required">
<FEEDBACK>
<ON_ERROR message="unsupporteddblargeprefix" />
</FEEDBACK>
</CUSTOM_CHECK>
</CUSTOM_CHECKS>
</MOODLE>
</COMPATIBILITY_MATRIX>
+1 -1
View File
@@ -22,7 +22,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(__FILE__) . '/../config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->libdir . '/adminlib.php');
$action = optional_param('action', '', PARAM_ALPHA);
+20 -3
View File
@@ -30,10 +30,10 @@ if (!file_exists('../config.php')) {
}
// Check that PHP is of a sufficient version as soon as possible
if (version_compare(phpversion(), '5.4.4') < 0) {
if (version_compare(phpversion(), '5.6.5') < 0) {
$phpversion = phpversion();
// do NOT localise - lang strings would not work here and we CAN NOT move it to later place
echo "Moodle 2.7 or later requires at least PHP 5.4.4 (currently using version $phpversion).<br />";
echo "Moodle 3.2 or later requires at least PHP 5.6.5 (currently using version $phpversion).<br />";
echo "Please upgrade your server software or install older Moodle version.";
die();
}
@@ -52,6 +52,12 @@ if (!function_exists('json_encode') || !function_exists('json_decode')) {
die();
}
// Make sure xml extension is available.
if (!extension_loaded('xml')) {
echo 'Moodle requires the xml PHP extension. Please install or enable the xml extension.';
die();
}
define('NO_OUTPUT_BUFFERING', true);
if (isset($_POST['upgradekey'])) {
@@ -309,6 +315,11 @@ if (!$cache and $version > $CFG->version) { // upgrade
$testsite = 'behat';
}
if (isset($CFG->themerev)) {
// Store the themerev to restore after purging caches.
$themerev = $CFG->themerev;
}
// We purge all of MUC's caches here.
// Caches are disabled for upgrade by CACHE_DISABLE_ALL so we must set the first arg to true.
// This ensures a real config object is loaded and the stores will be purged.
@@ -318,6 +329,11 @@ if (!$cache and $version > $CFG->version) { // upgrade
// We then purge the regular caches.
purge_all_caches();
if (isset($themerev)) {
// Restore the themerev
set_config('themerev', $themerev);
}
$output = $PAGE->get_renderer('core', 'admin');
if (upgrade_stale_php_files_present()) {
@@ -845,6 +861,7 @@ $registered = $DB->count_records('registration_hubs', array('huburl' => HUB_MOOD
$cachewarnings = cache_helper::warnings();
// Check if there are events 1 API handlers.
$eventshandlers = $DB->get_records_sql('SELECT DISTINCT component FROM {events_handlers}');
$themedesignermode = !empty($CFG->themedesignermode);
admin_externalpage_setup('adminnotifications');
@@ -852,4 +869,4 @@ $output = $PAGE->get_renderer('core', 'admin');
echo $output->admin_notifications_page($maturity, $insecuredataroot, $errorsdisplayed, $cronoverdue, $dbproblems,
$maintenancemode, $availableupdates, $availableupdatesfetch, $buggyiconvnomb,
$registered, $cachewarnings, $eventshandlers);
$registered, $cachewarnings, $eventshandlers, $themedesignermode);
+85
View File
@@ -24,6 +24,8 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
defined('MOODLE_INTERNAL') || die();
/**
* Return a list of page types
* @param string $pagetype current page type
@@ -37,3 +39,86 @@ function admin_page_type_list($pagetype, $parentcontext, $currentcontext) {
);
return $array;
}
/**
* File serving.
*
* @param stdClass $course The course object.
* @param stdClass $cm The cm object.
* @param context $context The context object.
* @param string $filearea The file area.
* @param array $args List of arguments.
* @param bool $forcedownload Whether or not to force the download of the file.
* @param array $options Array of options.
* @return void|false
*/
function core_admin_pluginfile($course, $cm, $context, $filearea, $args, $forcedownload, array $options = array()) {
global $CFG;
if (in_array($filearea, ['logo', 'logocompact'])) {
$size = array_shift($args); // The path hides the size.
$itemid = clean_param(array_shift($args), PARAM_INT);
$filename = clean_param(array_shift($args), PARAM_FILE);
$themerev = theme_get_revision();
if ($themerev <= 0) {
// Normalise to 0 as -1 doesn't place well with paths.
$themerev = 0;
}
// Extract the requested width and height.
$maxwidth = 0;
$maxheight = 0;
if (preg_match('/^\d+x\d+$/', $size)) {
list($maxwidth, $maxheight) = explode('x', $size);
$maxwidth = clean_param($maxwidth, PARAM_INT);
$maxheight = clean_param($maxheight, PARAM_INT);
}
$lifetime = 0;
if ($itemid > 0 && $themerev == $itemid) {
// The itemid is $CFG->themerev, when 0 or less no caching. Also no caching when they don't match.
$lifetime = DAYSECS * 60;
}
// Anyone, including guests and non-logged in users, can view the logos.
$options = ['cacheability' => 'public'];
// Check if we've got a cached file to return. When lifetime is 0 then we don't want to cached one.
$candidate = $CFG->localcachedir . "/core_admin/$themerev/$filearea/{$maxwidth}x{$maxheight}/$filename";
if (file_exists($candidate) && $lifetime > 0) {
send_file($candidate, $filename, $lifetime, 0, false, false, '', false, $options);
}
// Find the original file.
$fs = get_file_storage();
$filepath = "/{$context->id}/core_admin/{$filearea}/0/{$filename}";
if (!$file = $fs->get_file_by_hash(sha1($filepath))) {
send_file_not_found();
}
// No need for resizing, but if the file should be cached we save it so we can serve it fast next time.
if (empty($maxwidth) && empty($maxheight)) {
if ($lifetime) {
file_safe_save_content($file->get_content(), $candidate);
}
send_stored_file($file, $lifetime, 0, false, $options);
}
// Proceed with the resizing.
$filedata = $file->resize_image($maxwidth, $maxheight);
if (!$filedata) {
send_file_not_found();
}
// If we don't want to cached the file, serve now and quit.
if (!$lifetime) {
send_content_uncached($filedata, $filename);
}
// Save, serve and quit.
file_safe_save_content($filedata, $candidate);
send_file($candidate, $filename, $lifetime, 0, false, false, '', false, $options);
}
send_file_not_found();
}
+1 -1
View File
@@ -27,7 +27,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(dirname(__FILE__)) . '/config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->libdir.'/adminlib.php');
require_once($CFG->libdir.'/tablelib.php');
+1 -1
View File
@@ -29,7 +29,7 @@
*/
// Security check.
if (!file_exists(dirname(__FILE__).'/mailout-debugger.enable')) {
if (!file_exists(__DIR__.'/mailout-debugger.enable')) {
mdie("Disabled.");
}
$tmpdir=sys_get_temp_dir(); // default
+79
View File
@@ -0,0 +1,79 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Enrol config manipulation script.
*
* @package core
* @subpackage media
* @copyright 2016 Marina Glancy
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
define('NO_OUTPUT_BUFFERING', true);
require_once('../config.php');
require_once($CFG->libdir.'/adminlib.php');
$action = required_param('action', PARAM_ALPHANUMEXT);
$media = required_param('media', PARAM_PLUGIN);
$confirm = optional_param('confirm', 0, PARAM_BOOL);
$PAGE->set_url('/admin/media.php');
$PAGE->set_context(context_system::instance());
require_login();
require_capability('moodle/site:config', context_system::instance());
require_sesskey();
$plugins = core_plugin_manager::instance()->get_plugins_of_type('media');
$sortorder = array_values(\core\plugininfo\media::get_enabled_plugins());
$return = new moodle_url('/admin/settings.php', array('section' => 'managemediaplayers'));
if (!array_key_exists($media, $plugins)) {
redirect($return);
}
switch ($action) {
case 'disable':
$plugins[$media]->set_enabled(false);
break;
case 'enable':
$plugins[$media]->set_enabled(true);
break;
case 'up':
if (($pos = array_search($media, $sortorder)) > 0) {
$tmp = $sortorder[$pos - 1];
$sortorder[$pos - 1] = $sortorder[$pos];
$sortorder[$pos] = $tmp;
\core\plugininfo\media::set_enabled_plugins($sortorder);
}
break;
case 'down':
if ((($pos = array_search($media, $sortorder)) !== false) && ($pos < count($sortorder) - 1)) {
$tmp = $sortorder[$pos + 1];
$sortorder[$pos + 1] = $sortorder[$pos];
$sortorder[$pos] = $tmp;
\core\plugininfo\media::set_enabled_plugins($sortorder);
}
break;
}
redirect($return);
+3 -3
View File
@@ -21,7 +21,7 @@
* @copyright 2011 Lancaster University Network Services Limited
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(__FILE__) . '/../config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->dirroot . '/message/lib.php');
require_once($CFG->libdir.'/adminlib.php');
@@ -41,7 +41,7 @@ if (!empty($disable) && confirm_sesskey()) {
if (!$processor = $DB->get_record('message_processors', array('id'=>$disable))) {
print_error('outputdoesnotexist', 'message');
}
$DB->set_field('message_processors', 'enabled', '0', array('id'=>$processor->id)); // Disable output
\core_message\api::update_processor_status($processor, 0); // Disable output.
core_plugin_manager::reset_caches();
}
@@ -49,7 +49,7 @@ if (!empty($enable) && confirm_sesskey()) {
if (!$processor = $DB->get_record('message_processors', array('id'=>$enable))) {
print_error('outputdoesnotexist', 'message');
}
$DB->set_field('message_processors', 'enabled', '1', array('id'=>$processor->id)); // Enable output
\core_message\api::update_processor_status($processor, 1); // Enable output.
core_plugin_manager::reset_caches();
}
+1 -1
View File
@@ -2,7 +2,7 @@
// Allows the admin to control user logins from remote moodles.
require_once dirname(dirname(dirname(__FILE__))) . '/config.php';
require_once(__DIR__ . '/../../config.php');
require_once($CFG->libdir.'/adminlib.php');
include_once($CFG->dirroot.'/mnet/lib.php');
+1 -1
View File
@@ -27,7 +27,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir . '/adminlib.php');
$step = optional_param('step', 'verify', PARAM_ALPHA);
+1 -1
View File
@@ -2,7 +2,7 @@
// Allows the admin to configure mnet stuff
require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/adminlib.php');
include_once($CFG->dirroot.'/mnet/lib.php');
+2 -1
View File
@@ -60,7 +60,8 @@ class mnet_simple_host_form extends moodleform {
}
if ($host = $DB->get_record('mnet_host', array('wwwroot' => $wwwroot))) {
global $CFG;
return array('wwwroot' => get_string('hostexists', 'mnet', $CFG->wwwroot . '/admin/mnet/peers.php?hostid=' . $host->id));
return array('wwwroot' => get_string('hostexists', 'mnet',
new moodle_url('/admin/mnet/peers.php', array('hostid' => $host->id))));
}
return array();
}
+3 -3
View File
@@ -27,7 +27,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/adminlib.php');
require_once($CFG->dirroot.'/mnet/lib.php');
require_once($CFG->dirroot.'/'.$CFG->admin.'/mnet/peer_forms.php');
@@ -109,7 +109,7 @@ if (!empty($hostid)) {
$mnet_peer->set_id($hostid);
echo $OUTPUT->header();
$currenttab = 'mnetdetails';
require_once($CFG->dirroot . '/admin/mnet/tabs.php');
require_once($CFG->dirroot . '/' . $CFG->admin . '/mnet/tabs.php');
if ($hostid != $CFG->mnet_all_hosts_id) {
$mnet_peer->currentkey = mnet_get_public_key($mnet_peer->wwwroot, $mnet_peer->application);
@@ -144,7 +144,7 @@ if (empty($noreviewform) && $id = optional_param('id', 0, PARAM_INT)) {
// we're editing an existing one, so set up the tabs
$currenttab = 'mnetdetails';
$mnet_peer->set_id($id);
require_once($CFG->dirroot . '/admin/mnet/tabs.php');
require_once($CFG->dirroot . '/' . $CFG->admin . '/mnet/tabs.php');
} else if (empty($noreviewform) && ($wwwroot = optional_param('wwwroot', '', PARAM_URL)) && ($applicationid = optional_param('applicationid', 0, PARAM_INT))) {
$application = $DB->get_field('mnet_application', 'name', array('id'=>$applicationid));
$mnet_peer->bootstrap($wwwroot, null, $application);
+2 -2
View File
@@ -24,9 +24,9 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require(dirname(dirname(dirname(__FILE__))).'/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/adminlib.php');
require_once($CFG->dirroot . '/admin/mnet/profilefields_form.php');
require_once($CFG->dirroot . '/' . $CFG->admin .'/mnet/profilefields_form.php');
$mnet = get_mnet_environment();
require_login();
+3 -3
View File
@@ -25,9 +25,9 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/adminlib.php');
require_once($CFG->dirroot . '/admin/mnet/services_form.php');
require_once($CFG->dirroot . '/' . $CFG->admin . '/mnet/services_form.php');
$mnet = get_mnet_environment();
require_login();
@@ -82,7 +82,7 @@ if ($formdata = $mform->get_data()) {
echo $OUTPUT->header();
$currenttab = 'mnetservices';
require_once($CFG->dirroot . '/admin/mnet/tabs.php');
require_once($CFG->dirroot . '/' . $CFG->admin . '/mnet/tabs.php');
echo $OUTPUT->box_start();
$s = mnet_get_service_info($mnet_peer, false); // basic data only
$mform->set_data($s);
+1 -1
View File
@@ -12,7 +12,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU Public License
* @package mnet
*/
require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
require(__DIR__.'/../../config.php');
require_once $CFG->dirroot.'/mnet/xmlrpc/client.php';
require_once($CFG->libdir.'/adminlib.php');
include_once($CFG->dirroot.'/mnet/lib.php');
+1 -1
View File
@@ -1,7 +1,7 @@
<?php
// Allows the admin to configure services for remote hosts
require_once(dirname(dirname(dirname(__FILE__))) . '/config.php');
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/adminlib.php');
include_once($CFG->dirroot.'/mnet/lib.php');
+1 -1
View File
@@ -28,7 +28,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(dirname(__FILE__)).'/config.php');
require_once(__DIR__ . '/../config.php');
// The authorization code generated by the authorization server.
$code = required_param('code', PARAM_RAW);
+1 -1
View File
@@ -8,7 +8,7 @@
echo $OUTPUT->header();
echo '<div class="phpinfo">';
echo '<div class="phpinfo text-ltr">';
ob_start();
phpinfo(INFO_GENERAL + INFO_CONFIGURATION + INFO_MODULES + INFO_VARIABLES);
+1 -1
View File
@@ -26,7 +26,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(dirname(__FILE__)) . '/config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->libdir.'/adminlib.php');
require_once($CFG->libdir.'/tablelib.php');
+1 -1
View File
@@ -24,7 +24,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(dirname(__FILE__)) . '/config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->libdir . '/adminlib.php');
require_once($CFG->libdir . '/filelib.php');
+1 -1
View File
@@ -1,6 +1,6 @@
<?php
require_once(dirname(dirname(__FILE__)) . '/config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->libdir . '/portfoliolib.php');
require_once($CFG->libdir . '/portfolio/forms.php');
require_once($CFG->libdir . '/adminlib.php');
+1 -1
View File
@@ -3,7 +3,7 @@
//error_reporting(0);
//ini_set('display_errors',0);
require_once(dirname(dirname(__FILE__)).'/config.php');
require_once(__DIR__ . '/../config.php');
$tmp = explode('@',$_ENV['RECIPIENT']);
$address = $tmp[0];
+1 -1
View File
@@ -25,7 +25,7 @@
*/
require_once(dirname(__FILE__) . '/../config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->libdir . '/questionlib.php');
require_once($CFG->libdir . '/adminlib.php');
require_once($CFG->libdir . '/tablelib.php');
+1 -1
View File
@@ -25,7 +25,7 @@
*/
require_once(dirname(__FILE__) . '/../config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->libdir . '/questionlib.php');
require_once($CFG->libdir . '/adminlib.php');
require_once($CFG->libdir . '/tablelib.php');
+1
View File
@@ -329,6 +329,7 @@ class site_registration_form extends moodleform {
array('class' => 'registration_textfield'));
$mform->setType('contactphone', PARAM_TEXT);
$mform->addHelpButton('contactphone', 'sitephone', 'hub');
$mform->setForceLtr('contactphone');
$mform->addElement('text', 'contactemail', get_string('siteemail', 'hub'),
array('class' => 'registration_textfield'));
+25 -4
View File
@@ -281,7 +281,7 @@ class core_admin_renderer extends plugin_renderer_base {
*/
public function admin_notifications_page($maturity, $insecuredataroot, $errorsdisplayed,
$cronoverdue, $dbproblems, $maintenancemode, $availableupdates, $availableupdatesfetch,
$buggyiconvnomb, $registered, array $cachewarnings = array(), $eventshandlers = 0) {
$buggyiconvnomb, $registered, array $cachewarnings = array(), $eventshandlers = 0, $themedesignermode = false) {
global $CFG;
$output = '';
@@ -290,6 +290,7 @@ class core_admin_renderer extends plugin_renderer_base {
$output .= $this->legacy_log_store_writing_error();
$output .= empty($CFG->disableupdatenotifications) ? $this->available_updates($availableupdates, $availableupdatesfetch) : '';
$output .= $this->insecure_dataroot_warning($insecuredataroot);
$output .= $this->themedesignermode_warning($themedesignermode);
$output .= $this->display_errors_warning($errorsdisplayed);
$output .= $this->buggy_iconv_warning($buggyiconvnomb);
$output .= $this->cron_overdue_warning($cronoverdue);
@@ -532,6 +533,19 @@ class core_admin_renderer extends plugin_renderer_base {
return $this->warning(get_string('displayerrorswarning', 'admin'));
}
/**
* Render an appropriate message if themdesignermode is enabled.
* @param bool $themedesignermode true if enabled
* @return string HTML to output.
*/
protected function themedesignermode_warning($themedesignermode) {
if (!$themedesignermode) {
return '';
}
return $this->warning(get_string('themedesignermodewarning', 'admin'));
}
/**
* Render an appropriate message if iconv is buggy and mbstring missing.
* @param bool $buggyiconvnomb
@@ -1885,14 +1899,21 @@ class core_admin_renderer extends plugin_renderer_base {
} else {
$report = $this->doc_link(join($linkparts, '/'), get_string($stringtouse, 'admin', $rec));
}
// Enclose report text in div so feedback text will be displayed underneath it.
$report = html_writer::div($report);
// Format error or warning line
if ($errorline || $warningline) {
$messagetype = $errorline? 'error':'warn';
if ($errorline) {
$messagetype = 'error';
$statusclass = 'label-important';
} else if ($warningline) {
$messagetype = 'warn';
$statusclass = 'label-warning';
} else {
$messagetype = 'ok';
$statusclass = 'label-success';
}
$status = '<span class="'.$messagetype.'">'.$status.'</span>';
$status = html_writer::span($status, 'label ' . $statusclass);
// Here we'll store all the feedback found
$feedbacktext = '';
// Append the feedback if there is some
+1 -1
View File
@@ -27,7 +27,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(__FILE__) . '/../config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->libdir.'/adminlib.php');
require_once($CFG->libdir.'/tablelib.php');
+1 -1
View File
@@ -14,7 +14,7 @@
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
require_once(dirname(dirname(__FILE__)) . '/config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->dirroot . '/repository/lib.php');
require_once($CFG->libdir . '/adminlib.php');
+1 -1
View File
@@ -14,7 +14,7 @@
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
require_once(dirname(dirname(__FILE__)) . '/config.php');
require_once(__DIR__ . '/../config.php');
require_once($CFG->dirroot . '/repository/lib.php');
require_once($CFG->libdir . '/adminlib.php');
+1 -1
View File
@@ -23,7 +23,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require(dirname(dirname(__FILE__)) . '/config.php');
require(__DIR__ . '/../config.php');
require_once($CFG->libdir.'/adminlib.php');
admin_externalpage_setup('resetemoticons');
+6 -3
View File
@@ -133,9 +133,12 @@ echo $OUTPUT->header();
</td>
<td id="buttonscell">
<p class="arrow_button">
<input name="add" id="add" type="submit" value="<?php echo $OUTPUT->larrow().'&nbsp;'.get_string('add'); ?>" title="<?php print_string('add'); ?>" /><br />
<input name="remove" id="remove" type="submit" value="<?php echo get_string('remove').'&nbsp;'.$OUTPUT->rarrow(); ?>" title="<?php print_string('remove'); ?>" />
<input name="main" id="main" type="submit" value="<?php echo get_string('mainadminset', 'core_role'); ?>" title="<?php print_string('mainadminset', 'core_role'); ?>" />
<input name="add" id="add" type="submit" value="<?php echo $OUTPUT->larrow().'&nbsp;'.get_string('add'); ?>"
title="<?php print_string('add'); ?>" class="btn btn-secondary"/><br />
<input name="remove" id="remove" type="submit" value="<?php echo get_string('remove').'&nbsp;'.$OUTPUT->rarrow(); ?>"
title="<?php print_string('remove'); ?>" class="btn btn-secondary"/><br />
<input name="main" id="main" type="submit" value="<?php echo get_string('mainadminset', 'core_role'); ?>"
title="<?php print_string('mainadminset', 'core_role'); ?>" class="btn btn-secondary"/>
</p>
</td>
<td id="potentialcell">
+4
View File
@@ -32,10 +32,14 @@ $getroles = optional_param('getroles', 0, PARAM_BOOL);
list($context, $course, $cm) = get_context_info_array($contextid);
$PAGE->set_context($context);
require_login($course, false, $cm);
require_capability('moodle/role:review', $context);
require_sesskey();
$OUTPUT->header();
list($overridableroles, $overridecounts, $nameswithcounts) = get_overridable_roles($context,
ROLENAME_BOTH, true);
+3 -2
View File
@@ -22,7 +22,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(__FILE__) . '/../../config.php');
require_once(__DIR__ . '/../../config.php');
require_once($CFG->libdir . '/adminlib.php');
$mode = required_param('mode', PARAM_ALPHANUMEXT);
@@ -80,7 +80,8 @@ echo $OUTPUT->box($controller->get_intro_text());
echo '<form action="' . $baseurl . '" method="post">';
echo '<input type="hidden" name="sesskey" value="' . sesskey() . '" />';
echo html_writer::table($table);
echo '<div class="buttons"><input type="submit" name="submit" value="'.get_string('savechanges').'"/>';
echo '<div class="buttons">';
echo '<input type="submit" class="btn btn-primary" name="submit" value="' . get_string('savechanges') . '"/>';
echo '</div></form>';
echo $OUTPUT->footer();
+20 -25
View File
@@ -29,7 +29,7 @@ define("MAX_USERS_TO_LIST_PER_ROLE", 10);
$contextid = required_param('contextid', PARAM_INT);
$roleid = optional_param('roleid', 0, PARAM_INT);
$returnto = optional_param('return', null, PARAM_ALPHANUMEXT);
$returnurl = optional_param('returnurl', null, PARAM_LOCALURL);
list($context, $course, $cm) = get_context_info_array($contextid);
@@ -53,7 +53,13 @@ if ($course) {
// Security.
require_login($course, false, $cm);
require_capability('moodle/role:assign', $context);
$PAGE->set_url($url);
navigation_node::override_active_url($url);
$pageurl = new moodle_url($url);
if ($returnurl) {
$pageurl->param('returnurl', $returnurl);
}
$PAGE->set_url($pageurl);
$PAGE->set_context($context);
$contextname = $context->get_context_name();
@@ -141,6 +147,10 @@ if (!empty($user) && ($user->id != $USER->id)) {
}
$PAGE->set_pagelayout('admin');
if ($context->contextlevel == CONTEXT_BLOCK) {
// Do not show blocks when changing block's settings, it is confusing.
$PAGE->blocks->show_only_fake_blocks(true);
}
$PAGE->set_title($title);
switch ($context->contextlevel) {
@@ -186,9 +196,6 @@ if ($roleid) {
// Print the form.
$assignurl = new moodle_url($PAGE->url, array('roleid'=>$roleid));
if ($returnto !== null) {
$assignurl->param('return', $returnto);
}
?>
<form id="assignform" method="post" action="<?php echo $assignurl ?>"><div>
<input type="hidden" name="sesskey" value="<?php echo sesskey() ?>" />
@@ -201,11 +208,13 @@ if ($roleid) {
</td>
<td id="buttonscell">
<div id="addcontrols">
<input name="add" id="add" type="submit" value="<?php echo $OUTPUT->larrow().'&nbsp;'.get_string('add'); ?>" title="<?php print_string('add'); ?>" /><br />
<input name="add" id="add" type="submit" value="<?php echo $OUTPUT->larrow().'&nbsp;'.get_string('add'); ?>"
title="<?php print_string('add'); ?>" class="btn btn-secondary"/><br />
</div>
<div id="removecontrols">
<input name="remove" id="remove" type="submit" value="<?php echo get_string('remove').'&nbsp;'.$OUTPUT->rarrow(); ?>" title="<?php print_string('remove'); ?>" />
<input name="remove" id="remove" type="submit" value="<?php echo get_string('remove').'&nbsp;'.$OUTPUT->rarrow(); ?>"
title="<?php print_string('remove'); ?>" class="btn btn-secondary"/>
</div>
</td>
<td id="potentialcell">
@@ -233,18 +242,10 @@ if ($roleid) {
// Print a form to swap roles, and a link back to the all roles list.
echo '<div class="backlink">';
$newroleurl = new moodle_url($PAGE->url);
if ($returnto !== null) {
$newroleurl->param('return', $returnto);
}
$select = new single_select($newroleurl, 'roleid', $nameswithcounts, $roleid, null);
$select = new single_select($PAGE->url, 'roleid', $nameswithcounts, $roleid, null);
$select->label = get_string('assignanotherrole', 'core_role');
echo $OUTPUT->render($select);
$backurl = new moodle_url('/admin/roles/assign.php', array('contextid' => $contextid));
if ($returnto !== null) {
$backurl->param('return', $returnto);
}
echo '<p><a href="' . $backurl->out() . '">' . get_string('backtoallroles', 'core_role') . '</a></p>';
echo '<p><a href="' . $PAGE->url . '">' . get_string('backtoallroles', 'core_role') . '</a></p>';
echo '</div>';
} else if (empty($assignableroles)) {
@@ -282,9 +283,6 @@ if ($roleid) {
}
} else if ($assigncounts[$roleid] > MAX_USERS_TO_LIST_PER_ROLE) {
$assignurl = new moodle_url($PAGE->url, array('roleid'=>$roleid));
if ($returnto !== null) {
$assignurl->param('return', $returnto);
}
$roleholdernames[$roleid] = '<a href="'.$assignurl.'">'.$strmorethanmax.'</a>';
} else {
$roleholdernames[$roleid] = '';
@@ -305,9 +303,6 @@ if ($roleid) {
foreach ($assignableroles as $roleid => $rolename) {
$description = format_string($DB->get_field('role', 'description', array('id'=>$roleid)));
$assignurl = new moodle_url($PAGE->url, array('roleid'=>$roleid));
if ($returnto !== null) {
$assignurl->param('return', $returnto);
}
$row = array('<a href="'.$assignurl.'">'.$rolename.'</a>',
$description, $assigncounts[$roleid]);
if ($showroleholders) {
@@ -320,8 +315,8 @@ if ($roleid) {
if ($context->contextlevel > CONTEXT_USER) {
if ($context->contextlevel === CONTEXT_COURSECAT && $returnto === 'management') {
$url = new moodle_url('/course/management.php', array('categoryid' => $context->instanceid));
if ($returnurl) {
$url = new moodle_url($returnurl);
} else {
$url = $context->get_url();
}
+22 -14
View File
@@ -22,9 +22,10 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(__FILE__) . '/../../config.php');
require_once(__DIR__ . '/../../config.php');
$contextid = required_param('contextid', PARAM_INT);
$returnurl = optional_param('returnurl', null, PARAM_LOCALURL);
list($context, $course, $cm) = get_context_info_array($contextid);
@@ -49,7 +50,13 @@ require_login($course, false, $cm);
if (!has_any_capability(array('moodle/role:assign', 'moodle/role:safeoverride', 'moodle/role:override', 'moodle/role:manage'), $context)) {
print_error('nopermissions', 'error', '', get_string('checkpermissions', 'core_role'));
}
$PAGE->set_url($url);
navigation_node::override_active_url($url);
$pageurl = new moodle_url($url);
if ($returnurl) {
$pageurl->param('returnurl', $returnurl);
}
$PAGE->set_url($pageurl);
if ($context->contextlevel == CONTEXT_USER and $USER->id != $context->instanceid) {
$PAGE->navbar->includesettingsbase = true;
@@ -75,6 +82,10 @@ $userselector->set_rows(20);
$title = get_string('checkpermissionsin', 'core_role', $contextname);
$PAGE->set_pagelayout('admin');
if ($context->contextlevel == CONTEXT_BLOCK) {
// Do not show blocks when changing block's settings, it is confusing.
$PAGE->blocks->show_only_fake_blocks(true);
}
$PAGE->set_title($title);
switch ($context->contextlevel) {
@@ -156,30 +167,27 @@ if (!is_null($reportuser)) {
// Show UI for choosing a user to report on.
echo $OUTPUT->box_start('generalbox boxwidthnormal boxaligncenter', 'chooseuser');
echo '<form method="get" action="' . $CFG->wwwroot . '/' . $CFG->admin . '/roles/check.php" >';
// Hidden fields.
echo '<input type="hidden" name="contextid" value="' . $context->id . '" />';
if (!empty($user->id)) {
echo '<input type="hidden" name="userid" value="' . $user->id . '" />';
}
if ($isfrontpage) {
echo '<input type="hidden" name="courseid" value="' . $courseid . '" />';
}
echo '<form method="post" action="' . $PAGE->url . '" >';
// User selector.
echo $OUTPUT->heading('<label for="reportuser">' . $selectheading . '</label>', 3);
$userselector->display();
// Submit button and the end of the form.
echo '<p id="chooseusersubmit"><input type="submit" value="' . get_string('showthisuserspermissions', 'core_role') . '" /></p>';
echo '<p id="chooseusersubmit"><input type="submit" value="' . get_string('showthisuserspermissions', 'core_role') . '" ' .
'class="btn btn-primary"/></p>';
echo '</form>';
echo $OUTPUT->box_end();
// Appropriate back link.
if ($context->contextlevel > CONTEXT_USER) {
echo html_writer::start_tag('div', array('class'=>'backlink'));
echo html_writer::tag('a', get_string('backto', '', $contextname), array('href'=>$context->get_url()));
if ($returnurl) {
$backurl = new moodle_url($returnurl);
} else {
$backurl = $context->get_url();
}
echo html_writer::link($backurl, get_string('backto', '', $contextname));
echo html_writer::end_tag('div');
}
@@ -471,15 +471,17 @@ class core_role_define_role_table_advanced extends core_role_capability_table_wi
}
protected function get_name_field($id) {
return '<input type="text" id="' . $id . '" name="' . $id . '" maxlength="254" value="' . s($this->role->name) . '" />';
return '<input type="text" id="' . $id . '" name="' . $id . '" maxlength="254" value="' . s($this->role->name) . '"' .
' class="form-control"/>';
}
protected function get_shortname_field($id) {
return '<input type="text" id="' . $id . '" name="' . $id . '" maxlength="254" value="' . s($this->role->shortname) . '" />';
return '<input type="text" id="' . $id . '" name="' . $id . '" maxlength="254" value="' . s($this->role->shortname) . '"' .
' class="form-control"/>';
}
protected function get_description_field($id) {
return '<textarea class="form-textarea" id="'. s($id) .'" name="description" rows="10" cols="50">' .
return '<textarea class="form-textarea form-control" id="'. s($id) .'" name="description" rows="10" cols="50">' .
htmlspecialchars($this->role->description) .
'</textarea>';
}
@@ -490,7 +492,8 @@ class core_role_define_role_table_advanced extends core_role_capability_table_wi
foreach (get_role_archetypes() as $type) {
$options[$type] = get_string('archetype'.$type, 'role');
}
return html_writer::select($options, 'archetype', $this->role->archetype, false);
return html_writer::select($options, 'archetype', $this->role->archetype, false,
array('class' => 'custom-select'));
}
protected function get_assignable_levels_control() {
@@ -563,7 +566,8 @@ class core_role_define_role_table_advanced extends core_role_capability_table_wi
if ($this->roleid == 0) {
$options[-1] = get_string('thisnewrole', 'core_role');
}
return html_writer::select($options, 'allow'.$type.'[]', $selected, false, array('multiple'=>'multiple', 'size'=>10));
return html_writer::select($options, 'allow'.$type.'[]', $selected, false, array('multiple' => 'multiple',
'size' => 10, 'class' => 'form-control'));
}
/**
@@ -575,11 +579,19 @@ class core_role_define_role_table_advanced extends core_role_capability_table_wi
return '';
}
protected function print_field($name, $caption, $field) {
/**
* Print labels, fields and help icon on role administration page.
*
* @param string $name The field name.
* @param string $caption The field caption.
* @param string $field The field type.
* @param null|string $helpicon The help icon content.
*/
protected function print_field($name, $caption, $field, $helpicon = null) {
global $OUTPUT;
// Attempt to generate HTML like formslib.
echo '<div class="fitem">';
echo '<div class="fitemtitle">';
echo '<div class="fitem row form-group">';
echo '<div class="fitemtitle col-md-3">';
if ($name) {
echo '<label for="' . $name . '">';
}
@@ -587,13 +599,16 @@ class core_role_define_role_table_advanced extends core_role_capability_table_wi
if ($name) {
echo "</label>\n";
}
if ($helpicon) {
echo '<span class="pull-xs-right text-nowrap">'.$helpicon.'</span>';
}
echo '</div>';
if (isset($this->errors[$name])) {
$extraclass = ' error';
} else {
$extraclass = '';
}
echo '<div class="felement' . $extraclass . '">';
echo '<div class="felement col-md-9 form-inline' . $extraclass . '">';
echo $field;
if (isset($this->errors[$name])) {
echo $OUTPUT->error_text($this->errors[$name]);
@@ -605,7 +620,8 @@ class core_role_define_role_table_advanced extends core_role_capability_table_wi
protected function print_show_hide_advanced_button() {
echo '<p class="definenotice">' . get_string('highlightedcellsshowdefault', 'core_role') . ' </p>';
echo '<div class="advancedbutton">';
echo '<input type="submit" name="toggleadvanced" value="' . get_string('hideadvanced', 'form') . '" />';
echo '<input type="submit" class="btn btn-secondary" name="toggleadvanced" value="' .
get_string('hideadvanced', 'form') . '" />';
echo '</div>';
}
@@ -613,11 +629,14 @@ class core_role_define_role_table_advanced extends core_role_capability_table_wi
global $OUTPUT;
// Extra fields at the top of the page.
echo '<div class="topfields clearfix">';
$this->print_field('shortname', get_string('roleshortname', 'core_role').'&nbsp;'.$OUTPUT->help_icon('roleshortname', 'core_role'), $this->get_shortname_field('shortname'));
$this->print_field('name', get_string('customrolename', 'core_role').'&nbsp;'.$OUTPUT->help_icon('customrolename', 'core_role'), $this->get_name_field('name'));
$this->print_field('edit-description', get_string('customroledescription', 'core_role').'&nbsp;'.$OUTPUT->help_icon('customroledescription', 'core_role'),
$this->get_description_field('description'));
$this->print_field('menuarchetype', get_string('archetype', 'core_role').'&nbsp;'.$OUTPUT->help_icon('archetype', 'core_role'), $this->get_archetype_field('archetype'));
$this->print_field('shortname', get_string('roleshortname', 'core_role'),
$this->get_shortname_field('shortname'), $OUTPUT->help_icon('roleshortname', 'core_role'));
$this->print_field('name', get_string('customrolename', 'core_role'), $this->get_name_field('name'),
$OUTPUT->help_icon('customrolename', 'core_role'));
$this->print_field('edit-description', get_string('customroledescription', 'core_role'),
$this->get_description_field('description'), $OUTPUT->help_icon('customroledescription', 'core_role'));
$this->print_field('menuarchetype', get_string('archetype', 'core_role'), $this->get_archetype_field('archetype'),
$OUTPUT->help_icon('archetype', 'core_role'));
$this->print_field('', get_string('maybeassignedin', 'core_role'), $this->get_assignable_levels_control());
$this->print_field('menuallowassign', get_string('allowassign', 'core_role'), $this->get_allow_role_control('assign'));
$this->print_field('menuallowoverride', get_string('allowoverride', 'core_role'), $this->get_allow_role_control('override'));
@@ -37,7 +37,8 @@ class core_role_define_role_table_basic extends core_role_define_role_table_adva
protected function print_show_hide_advanced_button() {
echo '<div class="advancedbutton">';
echo '<input type="submit" name="toggleadvanced" value="' . get_string('showadvanced', 'form') . '" />';
echo '<input type="submit" class="btn btn-secondary" name="toggleadvanced"
value="' . get_string('showadvanced', 'form') . '" />';
echo '</div>';
}
+1 -1
View File
@@ -132,7 +132,7 @@ class core_role_permissions_table extends core_role_capability_table_base {
$risks = $this->get_risks($capability);
$contents = html_writer::tag('td', $risks, array('class' => 'risks'));
$contents = html_writer::tag('td', $risks, array('class' => 'risks text-nowrap'));
$contents .= html_writer::tag('td', $neededroles, array('class' => 'allowedroles'));
$contents .= html_writer::tag('td', $forbiddenroles, array('class' => 'forbiddenroles'));
return $contents;
+3 -2
View File
@@ -71,8 +71,9 @@ class core_role_preset {
$dom->appendChild($top);
$top->appendChild($dom->createElement('shortname', $role->shortname));
$top->appendChild($dom->createElement('name', $role->name));
$top->appendChild($dom->createElement('description', $role->description));
$top->appendChild($dom->createElement('name', htmlspecialchars($role->name, ENT_COMPAT | ENT_HTML401, 'UTF-8')));
$top->appendChild($dom->createElement('description', htmlspecialchars($role->description, ENT_COMPAT | ENT_HTML401,
'UTF-8')));
$top->appendChild($dom->createElement('archetype', $role->archetype));
$contextlevels = $dom->createElement('contextlevels');
+8 -8
View File
@@ -28,7 +28,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(__FILE__) . '/../../config.php');
require_once(__DIR__ . '/../../config.php');
require_once($CFG->libdir.'/adminlib.php');
$action = required_param('action', PARAM_ALPHA);
@@ -252,13 +252,13 @@ if ($action === 'view') {
echo '<div class="mform">';
} else {
?>
<form id="rolesform" class="mform" action="<?php p($baseurl->out(false)); ?>" method="post"><div>
<form id="rolesform" class="mform fcontainer" action="<?php p($baseurl->out(false)); ?>" method="post"><div>
<input type="hidden" name="sesskey" value="<?php p(sesskey()) ?>" />
<input type="hidden" name="return" value="<?php p($return); ?>" />
<input type="hidden" name="resettype" value="none" />
<div class="submit buttons">
<input type="submit" name="savechanges" value="<?php p($submitlabel); ?>" />
<input type="submit" name="cancel" value="<?php print_string('cancel'); ?>" />
<div class="submitbuttons">
<input type="submit" name="savechanges" class="btn btn-primary" value="<?php p($submitlabel); ?>" />
<input type="submit" name="cancel" class="btn btn-secondary" value="<?php print_string('cancel'); ?>" />
</div>
<?php
}
@@ -271,9 +271,9 @@ if ($action === 'view') {
echo '</div>';
} else {
?>
<div class="submit buttons">
<input type="submit" name="savechanges" value="<?php p($submitlabel); ?>" />
<input type="submit" name="cancel" value="<?php print_string('cancel'); ?>" />
<div class="submitbuttons">
<input type="submit" name="savechanges" class="btn btn-primary" value="<?php p($submitlabel); ?>" />
<input type="submit" name="cancel" class="btn btn-secondary" value="<?php print_string('cancel'); ?>" />
</div>
</div></form>
<?php
+1 -1
View File
@@ -31,7 +31,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(dirname(__FILE__) . '/../../config.php');
require_once(__DIR__ . '/../../config.php');
require_once($CFG->libdir.'/adminlib.php');
require_once($CFG->dirroot . '/' . $CFG->admin . '/roles/lib.php');
+7 -4
View File
@@ -45,17 +45,20 @@ M.core_role.init_cap_table_filter = function(Y, tableid, contextid) {
this.table = Y.one('#'+this.tableid);
// Create a div to hold the search UI.
this.div = Y.Node.create('<div class="capabilitysearchui"></div>').setStyles({
this.div = Y.Node.create('<div class="capabilitysearchui form-inline"></div>').setStyles({
width : this.table.get('offsetWidth'),
marginLeft : 'auto',
marginRight : 'auto'
});
// Create the capability search input.
this.input = Y.Node.create('<input type="text" id="'+this.table.get('id')+'capabilitysearch" value="'+Y.Escape.html(filtervalue)+'" />');
this.input = Y.Node.create('<input class="form-control m-x-1" type="text"' +
' id="'+this.table.get('id')+'capabilitysearch" value="'+Y.Escape.html(filtervalue)+'" />');
// Create a label for the search input.
this.label = Y.Node.create('<label for="'+this.input.get('id')+'">'+M.util.get_string('filter', 'moodle')+' </label>');
this.label = Y.Node.create('<label for="' + this.input.get('id') + '">' +
M.util.get_string('filter', 'moodle') + ' </label>');
// Create a clear button to clear the input.
this.button = Y.Node.create('<input type="button" value="'+M.util.get_string('clear', 'moodle')+'" />').set('disabled', filtervalue=='');
this.button = Y.Node.create('<input type="button" class="btn btn-primary"' +
' value="'+M.util.get_string('clear', 'moodle')+'" />').set('disabled', filtervalue=='');
// Tie it all together
this.div.append(this.label).append(this.input).append(this.button);
+4 -2
View File
@@ -177,8 +177,10 @@ if (!empty($capabilities)) {
}
echo html_writer::start_tag('div', array('class'=>'submit_buttons'));
echo html_writer::empty_tag('input', array('type'=>'submit', 'name'=>'savechanges', 'value'=>get_string('savechanges')));
echo html_writer::empty_tag('input', array('type'=>'submit', 'name'=>'cancel', 'value'=>get_string('cancel')));
$attrs = array('type'=>'submit', 'name'=>'savechanges', 'value'=>get_string('savechanges'), 'class'=>'btn btn-primary');
echo html_writer::empty_tag('input', $attrs);
$attrs = array('type'=>'submit', 'name'=>'cancel', 'value'=>get_string('cancel'), 'class' => 'btn btn-secondary');
echo html_writer::empty_tag('input', $attrs);
echo html_writer::end_tag('div');
echo html_writer::end_tag('div');
echo html_writer::end_tag('form');
+15 -4
View File
@@ -33,7 +33,7 @@ $prevent = optional_param('prevent', 0, PARAM_BOOL);
$allow = optional_param('allow', 0, PARAM_BOOL);
$unprohibit = optional_param('unprohibit', 0, PARAM_BOOL);
$prohibit = optional_param('prohibit', 0, PARAM_BOOL);
$return = optional_param('return', null, PARAM_ALPHANUMEXT);
$returnurl = optional_param('returnurl', null, PARAM_LOCALURL);
list($context, $course, $cm) = get_context_info_array($contextid);
@@ -56,7 +56,13 @@ if ($course) {
// Security first.
require_login($course, false, $cm);
require_capability('moodle/role:review', $context);
$PAGE->set_url($url);
navigation_node::override_active_url($url);
$pageurl = new moodle_url($url);
if ($returnurl) {
$pageurl->param('returnurl', $returnurl);
}
$PAGE->set_url($pageurl);
if ($context->contextlevel == CONTEXT_USER and $USER->id != $context->instanceid) {
$PAGE->navbar->includesettingsbase = true;
@@ -85,6 +91,11 @@ $straction = get_string('permissions', 'core_role'); // Used by tabs.php.
$currenttab = 'permissions';
$PAGE->set_pagelayout('admin');
if ($context->contextlevel == CONTEXT_BLOCK) {
// Do not show blocks when changing block's settings, it is confusing.
$PAGE->blocks->show_only_fake_blocks(true);
}
$PAGE->set_title($title);
switch ($context->contextlevel) {
case CONTEXT_SYSTEM:
@@ -219,8 +230,8 @@ echo $OUTPUT->box_end();
if ($context->contextlevel > CONTEXT_USER) {
if ($context->contextlevel === CONTEXT_COURSECAT && $return === 'management') {
$url = new moodle_url('/course/management.php', array('categoryid' => $context->instanceid));
if ($returnurl) {
$url = new moodle_url($returnurl);
} else {
$url = $context->get_url();
}
+23 -19
View File
@@ -7,7 +7,8 @@ require_once($CFG->libdir.'/adminlib.php');
$query = trim(optional_param('query', '', PARAM_NOTAGS)); // Search string
$PAGE->set_context(context_system::instance());
$context = context_system::instance();
$PAGE->set_context($context);
admin_externalpage_setup('search', '', array('query' => $query)); // now hidden page
@@ -18,7 +19,8 @@ $errormsg = '';
$focus = '';
// now we'll deal with the case that the admin has submitted the form with changed settings
if ($data = data_submitted() and confirm_sesskey()) {
if ($data = data_submitted() and confirm_sesskey() and isset($data->action) and $data->action == 'save-settings') {
require_capability('moodle/site:config', $context);
if (admin_write_settings($data)) {
redirect($PAGE->url, get_string('changessaved'), null, \core\output\notification::NOTIFY_SUCCESS);
}
@@ -36,6 +38,8 @@ if ($data = data_submitted() and confirm_sesskey()) {
// to modify them
echo $OUTPUT->header($focus);
echo $OUTPUT->heading(get_string('administrationsite'));
if ($errormsg !== '') {
echo $OUTPUT->notification($errormsg);
@@ -43,24 +47,24 @@ if ($errormsg !== '') {
echo $OUTPUT->notification($statusmsg, 'notifysuccess');
}
$resultshtml = admin_search_settings_html($query); // case insensitive search only
$showsettingslinks = true;
echo '<form action="' . $PAGE->url->out(true) . '" method="post" id="adminsettings">';
echo '<div>';
echo '<input type="hidden" name="sesskey" value="'.sesskey().'" />';
// HACK to prevent browsers from automatically inserting the user's password into the wrong fields.
echo prevent_form_autofill_password();
echo '</div>';
echo '<fieldset>';
echo '<div class="clearer"><!-- --></div>';
if ($resultshtml != '') {
echo $resultshtml;
} else {
echo get_string('noresults','admin');
if (has_capability('moodle/site:config', $context)) {
require_once("admin_settings_search_form.php");
$form = new admin_settings_search_form();
$form->display();
echo '<hr>';
if ($query) {
echo admin_search_settings_html($query);
$showsettingslinks = false;
}
}
if ($showsettingslinks) {
$node = $PAGE->settingsnav->find('root', navigation_node::TYPE_SITE_ADMIN);
if ($node) {
echo $OUTPUT->render_from_template('core/settings_link_page', ['node' => $node]);
}
}
echo '</fieldset>';
echo '</form>';
echo $OUTPUT->footer();
+180
View File
@@ -0,0 +1,180 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Manage global search areas.
*
* @package core_search
* @copyright 2016 Dan Poltawski <dan@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
require_once(__DIR__ . '/../config.php');
require_once($CFG->libdir . '/adminlib.php');
admin_externalpage_setup('searchareas');
$areaid = optional_param('areaid', null, PARAM_ALPHAEXT);
$action = optional_param('action', null, PARAM_ALPHA);
try {
$searchmanager = \core_search\manager::instance();
} catch (core_search\engine_exception $searchmanagererror) {
// Continue, we return an error later depending on the requested action.
}
echo $OUTPUT->header();
if ($action) {
require_sesskey();
if ($areaid) {
// We need to check that the area exists.
$area = \core_search\manager::get_search_area($areaid);
if ($area === false) {
throw new moodle_exception('invalidrequest');
}
}
// All actions but enable/disable need the search engine to be ready.
if ($action !== 'enable' && $action !== 'disable') {
if (!empty($searchmanagererror)) {
throw $searchmanagererror;
}
}
switch ($action) {
case 'enable':
$area->set_enabled(true);
echo $OUTPUT->notification(get_string('searchareaenabled', 'admin'), \core\output\notification::NOTIFY_SUCCESS);
break;
case 'disable':
$area->set_enabled(false);
echo $OUTPUT->notification(get_string('searchareadisabled', 'admin'), \core\output\notification::NOTIFY_SUCCESS);
break;
case 'delete':
$search = \core_search\manager::instance();
$search->delete_index($areaid);
echo $OUTPUT->notification(get_string('searchindexdeleted', 'admin'), \core\output\notification::NOTIFY_SUCCESS);
break;
case 'indexall':
$searchmanager->index();
echo $OUTPUT->notification(get_string('searchindexupdated', 'admin'), \core\output\notification::NOTIFY_SUCCESS);
break;
case 'reindexall':
$searchmanager->index(true);
echo $OUTPUT->notification(get_string('searchreindexed', 'admin'), \core\output\notification::NOTIFY_SUCCESS);
break;
case 'deleteall':
$searchmanager->delete_index();
echo $OUTPUT->notification(get_string('searchalldeleted', 'admin'), \core\output\notification::NOTIFY_SUCCESS);
break;
default:
throw new moodle_exception('invalidaction');
break;
}
}
$searchareas = \core_search\manager::get_search_areas_list();
if (empty($searchmanagererror)) {
$areasconfig = $searchmanager->get_areas_config($searchareas);
} else {
$areasconfig = false;
}
if (!empty($searchmanagererror)) {
$errorstr = get_string($searchmanagererror->errorcode, $searchmanagererror->module, $searchmanagererror->a);
echo $OUTPUT->notification($errorstr, \core\output\notification::NOTIFY_ERROR);
} else {
echo $OUTPUT->notification(get_string('indexinginfo', 'admin'), \core\output\notification::NOTIFY_INFO);
}
$table = new html_table();
$table->id = 'core-search-areas';
$table->head = array(get_string('searcharea', 'search'), get_string('enable'), get_string('newestdocindexed', 'admin'),
get_string('searchlastrun', 'admin'), get_string('searchindexactions', 'admin'));
foreach ($searchareas as $area) {
$areaid = $area->get_area_id();
$columns = array(new html_table_cell($area->get_visible_name()));
if ($area->is_enabled()) {
$columns[] = $OUTPUT->action_icon(admin_searcharea_action_url('disable', $areaid),
new pix_icon('t/hide', get_string('disable'), 'moodle', array('title' => '', 'class' => 'iconsmall')),
null, array('title' => get_string('disable')));
if ($areasconfig) {
$columns[] = $areasconfig[$areaid]->lastindexrun;
if ($areasconfig[$areaid]->indexingstart) {
$timediff = $areasconfig[$areaid]->indexingend - $areasconfig[$areaid]->indexingstart;
$laststatus = $timediff . ' , ' .
$areasconfig[$areaid]->docsprocessed . ' , ' .
$areasconfig[$areaid]->recordsprocessed . ' , ' .
$areasconfig[$areaid]->docsignored;
} else {
$laststatus = '';
}
$columns[] = $laststatus;
$columns[] = html_writer::link(admin_searcharea_action_url('delete', $areaid), 'Delete index');
} else {
$blankrow = new html_table_cell(get_string('searchnotavailable', 'admin'));
$blankrow->colspan = 3;
$columns[] = $blankrow;
}
} else {
$columns[] = $OUTPUT->action_icon(admin_searcharea_action_url('enable', $areaid),
new pix_icon('t/show', get_string('enable'), 'moodle', array('title' => '', 'class' => 'iconsmall')),
null, array('title' => get_string('enable')));
$blankrow = new html_table_cell(get_string('searchareadisabled', 'admin'));
$blankrow->colspan = 3;
$columns[] = $blankrow;
}
$row = new html_table_row($columns);
$table->data[] = $row;
}
// Cross-search area tasks.
$options = array();
if (!empty($searchmanagererror)) {
$options['disabled'] = true;
}
echo $OUTPUT->box_start('search-areas-actions');
echo $OUTPUT->single_button(admin_searcharea_action_url('indexall'), get_string('searchupdateindex', 'admin'), 'get', $options);
echo $OUTPUT->single_button(admin_searcharea_action_url('reindexall'), get_string('searchreindexindex', 'admin'), 'get', $options);
echo $OUTPUT->single_button(admin_searcharea_action_url('deleteall'), get_string('searchdeleteindex', 'admin'), 'get', $options);
echo $OUTPUT->box_end();
echo html_writer::table($table);
echo $OUTPUT->footer();
/**
* Helper for generating url for management actions.
*
* @param string $action
* @param string $areaid
* @return moodle_url
*/
function admin_searcharea_action_url($action, $areaid = false) {
$params = array('action' => $action, 'sesskey' => sesskey());
if ($areaid) {
$params['areaid'] = $areaid;
}
return new moodle_url('/admin/searchareas.php', $params);
}
+32 -29
View File
@@ -77,20 +77,23 @@ if (empty($SITE->fullname)) {
// ---------------------------------------------------------------------------------------------------------------
echo '<form action="' . $PAGE->url . '" method="post" id="adminsettings">';
echo '<div class="settingsform clearfix">';
echo html_writer::input_hidden_params($PAGE->url);
echo '<input type="hidden" name="sesskey" value="'.sesskey().'" />';
echo '<input type="hidden" name="return" value="'.$return.'" />';
// HACK to prevent browsers from automatically inserting the user's password into the wrong fields.
echo prevent_form_autofill_password();
$pageparams = $PAGE->url->params();
$context = [
'actionurl' => $PAGE->url->out(false),
'params' => array_map(function($param) use ($pageparams) {
return [
'name' => $param,
'value' => $pageparams[$param]
];
}, array_keys($pageparams)),
'sesskey' => sesskey(),
'return' => $return,
'title' => null,
'settings' => $settingspage->output_html(),
'showsave' => true
];
echo $settingspage->output_html();
echo '<div class="form-buttons"><input class="form-submit" type="submit" value="'.get_string('savechanges','admin').'" /></div>';
echo '</div>';
echo '</form>';
echo $OUTPUT->render_from_template('core_admin/settings', $context);
} else {
if ($PAGE->user_allowed_editing()) {
@@ -121,23 +124,23 @@ if (empty($SITE->fullname)) {
// ---------------------------------------------------------------------------------------------------------------
echo '<form action="' . $PAGE->url . '" method="post" id="adminsettings">';
echo '<div class="settingsform clearfix">';
echo html_writer::input_hidden_params($PAGE->url);
echo '<input type="hidden" name="sesskey" value="'.sesskey().'" />';
echo '<input type="hidden" name="return" value="'.$return.'" />';
// HACK to prevent browsers from automatically inserting the user's password into the wrong fields.
echo prevent_form_autofill_password();
echo $OUTPUT->heading($settingspage->visiblename);
$pageparams = $PAGE->url->params();
$context = [
'actionurl' => $PAGE->url->out(false),
'params' => array_map(function($param) use ($pageparams) {
return [
'name' => $param,
'value' => $pageparams[$param]
];
}, array_keys($pageparams)),
'sesskey' => sesskey(),
'return' => $return,
'title' => $settingspage->visiblename,
'settings' => $settingspage->output_html(),
'showsave' => $settingspage->show_save()
];
echo $settingspage->output_html();
if ($settingspage->show_save()) {
echo '<div class="form-buttons"><input class="form-submit" type="submit" value="'.get_string('savechanges','admin').'" /></div>';
}
echo '</div>';
echo '</form>';
echo $OUTPUT->render_from_template('core_admin/settings', $context);
}
$PAGE->requires->yui_module('moodle-core-formchangechecker',
+33 -52
View File
@@ -12,7 +12,10 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) { // sp
$ADMIN->add('appearance', new admin_category('themes', new lang_string('themes')));
// "themesettings" settingpage
$temp = new admin_settingpage('themesettings', new lang_string('themesettings', 'admin'));
$temp->add(new admin_setting_configtext('themelist', new lang_string('themelist', 'admin'), new lang_string('configthemelist','admin'), '', PARAM_NOTAGS));
$setting = new admin_setting_configtext('themelist', new lang_string('themelist', 'admin'),
new lang_string('configthemelist', 'admin'), '', PARAM_NOTAGS);
$setting->set_force_ltr(true);
$temp->add($setting);
$setting = new admin_setting_configcheckbox('themedesignermode', new lang_string('themedesignermode', 'admin'), new lang_string('configthemedesignermode', 'admin'), 0);
$setting->set_updatedcallback('theme_reset_all_caches');
$temp->add($setting);
@@ -22,7 +25,8 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) { // sp
$temp->add(new admin_setting_configcheckbox('allowthemechangeonurl', new lang_string('allowthemechangeonurl', 'admin'), new lang_string('configallowthemechangeonurl', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('allowuserblockhiding', new lang_string('allowuserblockhiding', 'admin'), new lang_string('configallowuserblockhiding', 'admin'), 1));
$temp->add(new admin_setting_configcheckbox('allowblockstodock', new lang_string('allowblockstodock', 'admin'), new lang_string('configallowblockstodock', 'admin'), 1));
$temp->add(new admin_setting_configtextarea('custommenuitems', new lang_string('custommenuitems', 'admin'), new lang_string('configcustommenuitems', 'admin'), '', PARAM_TEXT, '50', '10'));
$temp->add(new admin_setting_configtextarea('custommenuitems', new lang_string('custommenuitems', 'admin'),
new lang_string('configcustommenuitems', 'admin'), '', PARAM_RAW, '50', '10'));
$temp->add(new admin_setting_configtextarea(
'customusermenuitems',
new lang_string('customusermenuitems', 'admin'),
@@ -30,7 +34,7 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) { // sp
'grades,grades|/grade/report/mygrades.php|grades
messages,message|/message/index.php|message
preferences,moodle|/user/preferences.php|preferences',
PARAM_TEXT,
PARAM_RAW,
'50',
'10'
));
@@ -51,6 +55,26 @@ preferences,moodle|/user/preferences.php|preferences',
}
}
// Logos section.
$temp = new admin_settingpage('logos', new lang_string('logossettings', 'admin'));
// Logo file setting.
$title = get_string('logo', 'admin');
$description = get_string('logo_desc', 'admin');
$setting = new admin_setting_configstoredfile('core_admin/logo', $title, $description, 'logo', 0,
['maxfiles' => 1, 'accepted_types' => ['.jpg', '.png']]);
$setting->set_updatedcallback('theme_reset_all_caches');
$temp->add($setting);
// Small logo file setting.
$title = get_string('logocompact', 'admin');
$description = get_string('logocompact_desc', 'admin');
$setting = new admin_setting_configstoredfile('core_admin/logocompact', $title, $description, 'logocompact', 0,
['maxfiles' => 1, 'accepted_types' => ['.jpg', '.png']]);
$setting->set_updatedcallback('theme_reset_all_caches');
$temp->add($setting);
$ADMIN->add('appearance', $temp);
// Calendar settings.
$temp = new admin_settingpage('calendar', new lang_string('calendarsettings','admin'));
@@ -148,7 +172,6 @@ preferences,moodle|/user/preferences.php|preferences',
$temp->add(new admin_setting_configcheckbox('navshowcategories', new lang_string('navshowcategories', 'admin'), new lang_string('confignavshowcategories', 'admin'), 1));
$temp->add(new admin_setting_configcheckbox('navshowmycoursecategories', new lang_string('navshowmycoursecategories', 'admin'), new lang_string('navshowmycoursecategories_help', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('navshowallcourses', new lang_string('navshowallcourses', 'admin'), new lang_string('confignavshowallcourses', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('navexpandmycourses', new lang_string('navexpandmycourses', 'admin'), new lang_string('navexpandmycourses_desc', 'admin'), 1));
$sortoptions = array(
'sortorder' => new lang_string('sort_sortorder', 'admin'),
'fullname' => new lang_string('sort_fullname', 'admin'),
@@ -158,7 +181,7 @@ preferences,moodle|/user/preferences.php|preferences',
$temp->add(new admin_setting_configselect('navsortmycoursessort', new lang_string('navsortmycoursessort', 'admin'), new lang_string('navsortmycoursessort_help', 'admin'), 'sortorder', $sortoptions));
$temp->add(new admin_setting_configtext('navcourselimit',new lang_string('navcourselimit','admin'),new lang_string('confignavcourselimit', 'admin'),20,PARAM_INT));
$temp->add(new admin_setting_configcheckbox('usesitenameforsitepages', new lang_string('usesitenameforsitepages', 'admin'), new lang_string('configusesitenameforsitepages', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('linkadmincategories', new lang_string('linkadmincategories', 'admin'), new lang_string('linkadmincategories_help', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('linkadmincategories', new lang_string('linkadmincategories', 'admin'), new lang_string('linkadmincategories_help', 'admin'), 1));
$temp->add(new admin_setting_configcheckbox('linkcoursesections', new lang_string('linkcoursesections', 'admin'), new lang_string('linkcoursesections_help', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('navshowfrontpagemods', new lang_string('navshowfrontpagemods', 'admin'), new lang_string('navshowfrontpagemods_help', 'admin'), 1));
$temp->add(new admin_setting_configcheckbox('navadduserpostslinks', new lang_string('navadduserpostslinks', 'admin'), new lang_string('navadduserpostslinks_help', 'admin'), 1));
@@ -173,49 +196,6 @@ preferences,moodle|/user/preferences.php|preferences',
$ADMIN->add('appearance', new admin_externalpage('resetemoticons', new lang_string('emoticonsreset', 'admin'),
new moodle_url('/admin/resetemoticons.php'), 'moodle/site:config', true));
// The "media" subpage.
$temp = new admin_settingpage('mediasettings', get_string('mediasettings', 'core_media'));
$temp->add(new admin_setting_heading('mediaformats', get_string('mediaformats', 'core_media'),
format_text(get_string('mediaformats_desc', 'core_media'), FORMAT_MARKDOWN)));
// External services.
$temp->add(new admin_setting_configcheckbox('core_media_enable_youtube',
get_string('siteyoutube', 'core_media'), get_string('siteyoutube_desc', 'core_media'), 1));
$temp->add(new admin_setting_configcheckbox('core_media_enable_vimeo',
get_string('sitevimeo', 'core_media'), get_string('sitevimeo_desc', 'core_media'), 0));
// Options which require Flash.
$temp->add(new admin_setting_configcheckbox('core_media_enable_mp3',
get_string('mp3audio', 'core_media'), get_string('mp3audio_desc', 'core_media'), 1));
$temp->add(new admin_setting_configcheckbox('core_media_enable_flv',
get_string('flashvideo', 'core_media'), get_string('flashvideo_desc', 'core_media'), 1));
$temp->add(new admin_setting_configcheckbox('core_media_enable_swf',
get_string('flashanimation', 'core_media'), get_string('flashanimation_desc', 'core_media'), 1));
// HTML 5 media.
// Audio now enabled by default so that it can provide a fallback for mp3 on devices without flash.
$temp->add(new admin_setting_configcheckbox('core_media_enable_html5audio',
get_string('html5audio', 'core_media'), get_string('html5audio_desc', 'core_media'), 1));
// Video now enabled by default so it can provide mp4 support.
$temp->add(new admin_setting_configcheckbox('core_media_enable_html5video',
get_string('html5video', 'core_media'), get_string('html5video_desc', 'core_media'), 1));
// Legacy players.
$temp->add(new admin_setting_heading('legacymediaformats',
get_string('legacyheading', 'core_media'), get_string('legacyheading_desc', 'core_media')));
$temp->add(new admin_setting_configcheckbox('core_media_enable_qt',
get_string('legacyquicktime', 'core_media'), get_string('legacyquicktime_desc', 'core_media'), 1));
$temp->add(new admin_setting_configcheckbox('core_media_enable_wmp',
get_string('legacywmp', 'core_media'), get_string('legacywmp_desc', 'core_media'), 1));
$temp->add(new admin_setting_configcheckbox('core_media_enable_rm',
get_string('legacyreal', 'core_media'), get_string('legacyreal_desc', 'core_media'), 1));
$ADMIN->add('appearance', $temp);
// "documentation" settingpage
$temp = new admin_settingpage('documentation', new lang_string('moodledocs'));
$temp->add(new admin_setting_configtext('docroot', new lang_string('docroot', 'admin'), new lang_string('configdocroot', 'admin'), 'http://docs.moodle.org', PARAM_URL));
@@ -254,12 +234,13 @@ preferences,moodle|/user/preferences.php|preferences',
$setting->set_updatedcallback('js_reset_all_caches');
$temp->add($setting);
$temp->add(new admin_setting_configcheckbox('modchooserdefault', new lang_string('modchooserdefault', 'admin'), new lang_string('configmodchooserdefault', 'admin'), 1));
$temp->add(new admin_setting_configcheckbox('modeditingmenu', new lang_string('modeditingmenu', 'admin'), new lang_string('modeditingmenu_desc', 'admin'), 1));
$temp->add(new admin_setting_configcheckbox('blockeditingmenu', new lang_string('blockeditingmenu', 'admin'), new lang_string('blockeditingmenu_desc', 'admin'), 1));
$ADMIN->add('appearance', $temp);
// link to tag management interface
$ADMIN->add('appearance', new admin_externalpage('managetags', new lang_string('managetags', 'tag'), $CFG->wwwroot.'/tag/manage.php', 'moodle/tag:manage'));
// Link to tag management interface.
$url = new moodle_url('/tag/manage.php');
$hidden = empty($CFG->usetags);
$page = new admin_externalpage('managetags', new lang_string('managetags', 'tag'), $url, 'moodle/tag:manage', $hidden);
$ADMIN->add('appearance', $page);
$temp = new admin_settingpage('additionalhtml', new lang_string('additionalhtml', 'admin'));
$temp->add(new admin_setting_heading('additionalhtml_heading', new lang_string('additionalhtml_heading', 'admin'), new lang_string('additionalhtml_desc', 'admin')));
+22 -2
View File
@@ -72,13 +72,13 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) {
$formcourseformats[$courseformat] = new lang_string('pluginname', "format_$courseformat");
}
$temp->add(new admin_setting_configselect('moodlecourse/format', new lang_string('format'), new lang_string('coursehelpformat'),
'weeks',$formcourseformats));
'topics', $formcourseformats));
$temp->add(new admin_setting_configtext('moodlecourse/maxsections', new lang_string('maxnumberweeks'),
new lang_string('maxnumberweeks_desc'), 52));
$temp->add(new admin_settings_num_course_sections('moodlecourse/numsections', new lang_string('numberweeks'),
new lang_string('coursehelpnumberweeks'), 10));
new lang_string('coursehelpnumberweeks'), 4));
$choices = array();
$choices['0'] = new lang_string('hiddensectionscollapsed');
@@ -92,6 +92,9 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) {
$temp->add(new admin_setting_configselect('moodlecourse/coursedisplay', new lang_string('coursedisplay'),
new lang_string('coursedisplay_help'), COURSE_DISPLAY_SINGLEPAGE, $choices));
$temp->add(new admin_setting_configduration('moodlecourse/courseduration', get_string('courseduration'),
get_string('courseduration_desc'), YEARSECS));
// Appearance.
$temp->add(new admin_setting_heading('appearancehdr', new lang_string('appearance'), ''));
@@ -192,6 +195,7 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) {
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_filters', new lang_string('generalfilters','backup'), new lang_string('configgeneralfilters','backup'), array('value'=>1, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_comments', new lang_string('generalcomments','backup'), new lang_string('configgeneralcomments','backup'), array('value'=>1, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_badges', new lang_string('generalbadges','backup'), new lang_string('configgeneralbadges','backup'), array('value'=>1,'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_calendarevents', new lang_string('generalcalendarevents','backup'), new lang_string('configgeneralcalendarevents','backup'), array('value'=>1, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_userscompletion', new lang_string('generaluserscompletion','backup'), new lang_string('configgeneraluserscompletion','backup'), array('value'=>1, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_logs', new lang_string('generallogs','backup'), new lang_string('configgenerallogs','backup'), array('value'=>0, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_histories', new lang_string('generalhistories','backup'), new lang_string('configgeneralhistories','backup'), array('value'=>0, 'locked'=>0)));
@@ -199,6 +203,7 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) {
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_groups',
new lang_string('generalgroups', 'backup'), new lang_string('configgeneralgroups', 'backup'),
array('value' => 1, 'locked' => 0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_general_competencies', new lang_string('generalcompetencies','backup'), new lang_string('configgeneralcompetencies','backup'), array('value'=>1, 'locked'=>0)));
$ADMIN->add('backups', $temp);
@@ -208,6 +213,19 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) {
$temp->add(new admin_setting_configcheckbox('backup/import_general_duplicate_admin_allowed',
new lang_string('importgeneralduplicateadminallowed', 'backup'),
new lang_string('importgeneralduplicateadminallowed_desc', 'backup'), 0));
// Import defaults section.
$temp->add(new admin_setting_heading('importsettings', new lang_string('importsettings', 'backup'), ''));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_import_activities', new lang_string('generalactivities','backup'), new lang_string('configgeneralactivities','backup'), array('value'=>1, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_import_blocks', new lang_string('generalblocks','backup'), new lang_string('configgeneralblocks','backup'), array('value'=>1, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_import_filters', new lang_string('generalfilters','backup'), new lang_string('configgeneralfilters','backup'), array('value'=>1, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_import_calendarevents', new lang_string('generalcalendarevents','backup'), new lang_string('configgeneralcalendarevents','backup'), array('value'=>1, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_import_questionbank', new lang_string('generalquestionbank','backup'), new lang_string('configgeneralquestionbank','backup'), array('value'=>1, 'locked'=>0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_import_groups',
new lang_string('generalgroups', 'backup'), new lang_string('configgeneralgroups', 'backup'),
array('value' => 1, 'locked' => 0)));
$temp->add(new admin_setting_configcheckbox_with_lock('backup/backup_import_competencies', new lang_string('generalcompetencies','backup'), new lang_string('configgeneralcompetencies','backup'), array('value'=>1, 'locked'=>0)));
$ADMIN->add('backups', $temp);
// Create a page for automated backups configuration and defaults.
@@ -312,12 +330,14 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) {
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_filters', new lang_string('generalfilters','backup'), new lang_string('configgeneralfilters','backup'), 1));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_comments', new lang_string('generalcomments','backup'), new lang_string('configgeneralcomments','backup'), 1));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_badges', new lang_string('generalbadges','backup'), new lang_string('configgeneralbadges','backup'), 1));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_calendarevents', new lang_string('generalcalendarevents','backup'), new lang_string('configgeneralcalendarevents','backup'), 1));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_userscompletion', new lang_string('generaluserscompletion','backup'), new lang_string('configgeneraluserscompletion','backup'), 1));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_logs', new lang_string('generallogs', 'backup'), new lang_string('configgenerallogs', 'backup'), 0));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_histories', new lang_string('generalhistories','backup'), new lang_string('configgeneralhistories','backup'), 0));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_questionbank', new lang_string('generalquestionbank','backup'), new lang_string('configgeneralquestionbank','backup'), 1));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_groups', new lang_string('generalgroups', 'backup'),
new lang_string('configgeneralgroups', 'backup'), 1));
$temp->add(new admin_setting_configcheckbox('backup/backup_auto_competencies', new lang_string('generalcompetencies','backup'), new lang_string('configgeneralcompetencies','backup'), 1));
//$temp->add(new admin_setting_configcheckbox('backup/backup_auto_messages', new lang_string('messages', 'message'), new lang_string('backupmessageshelp','message'), 0));
//$temp->add(new admin_setting_configcheckbox('backup/backup_auto_blogs', new lang_string('blogs', 'blog'), new lang_string('backupblogshelp','blog'), 0));
+1 -5
View File
@@ -13,10 +13,6 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
$temp->add(new admin_setting_configcheckbox('enablesafebrowserintegration', new lang_string('enablesafebrowserintegration', 'admin'), new lang_string('configenablesafebrowserintegration', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('dndallowtextandlinks', new lang_string('dndallowtextandlinks', 'admin'), new lang_string('configdndallowtextandlinks', 'admin'), 0));
// The CSS optimiser setting. When changed we need to reset the theme caches in order to ensure they are regenerated through the optimiser.
$enablecssoptimiser = new admin_setting_configcheckbox('enablecssoptimiser', new lang_string('enablecssoptimiser','admin'), new lang_string('enablecssoptimiser_desc','admin'), 0);
$enablecssoptimiser->set_updatedcallback('theme_reset_all_caches');
$temp->add($enablecssoptimiser);
$ADMIN->add('experimental', $temp);
@@ -32,7 +28,7 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
$ADMIN->add('development', $temp);
// "Profiling" settingpage (conditionally if the 'xhprof' extension is available only).
$xhprofenabled = extension_loaded('xhprof') && function_exists('xhprof_enable');
$xhprofenabled = extension_loaded('xhprof') || extension_loaded('tideways');
$temp = new admin_settingpage('profiling', new lang_string('profiling', 'admin'), 'moodle/site:config', !$xhprofenabled);
// Main profiling switch.
$temp->add(new admin_setting_configcheckbox('profilingenabled', new lang_string('profilingenabled', 'admin'), new lang_string('profilingenabled_help', 'admin'), false));
+13 -3
View File
@@ -53,14 +53,24 @@ if (has_capability('moodle/grade:manage', $systemcontext)
'3' => '3',
'4' => '4',
'5' => '5')));
$temp->add(new admin_setting_configselect('grade_navmethod', new lang_string('navmethod', 'grades'), null, 0,
$temp->add(new admin_setting_configselect('grade_navmethod', new lang_string('navmethod', 'grades'), null,
GRADE_NAVMETHOD_TABS,
array(GRADE_NAVMETHOD_DROPDOWN => new lang_string('dropdown', 'grades'),
GRADE_NAVMETHOD_TABS => new lang_string('tabs', 'grades'),
GRADE_NAVMETHOD_COMBO => new lang_string('combo', 'grades'))));
$temp->add(new admin_setting_configtext('grade_export_userprofilefields', new lang_string('gradeexportuserprofilefields', 'grades'), new lang_string('gradeexportuserprofilefields_desc', 'grades'), 'firstname,lastname,idnumber,institution,department,email', PARAM_TEXT));
$setting = new admin_setting_configtext('grade_export_userprofilefields',
new lang_string('gradeexportuserprofilefields', 'grades'),
new lang_string('gradeexportuserprofilefields_desc', 'grades'),
'firstname,lastname,idnumber,institution,department,email', PARAM_TEXT);
$setting->set_force_ltr(true);
$temp->add($setting);
$temp->add(new admin_setting_configtext('grade_export_customprofilefields', new lang_string('gradeexportcustomprofilefields', 'grades'), new lang_string('gradeexportcustomprofilefields_desc', 'grades'), '', PARAM_TEXT));
$setting = new admin_setting_configtext('grade_export_customprofilefields',
new lang_string('gradeexportcustomprofilefields', 'grades'),
new lang_string('gradeexportcustomprofilefields_desc', 'grades'), '', PARAM_TEXT);
$setting->set_force_ltr(true);
$temp->add($setting);
$temp->add(new admin_setting_configcheckbox('recovergradesdefault', new lang_string('recovergradesdefault', 'grades'), new lang_string('recovergradesdefault_help', 'grades'), 0));
+2 -1
View File
@@ -10,7 +10,8 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
$temp->add(new admin_setting_configtext('defaultcity', new lang_string('defaultcity', 'admin'), new lang_string('defaultcity_help', 'admin'), ''));
$temp->add(new admin_setting_heading('iplookup', new lang_string('iplookup', 'admin'), new lang_string('iplookupinfo', 'admin')));
$temp->add(new admin_setting_configfile('geoipfile', new lang_string('geoipfile', 'admin'), new lang_string('configgeoipfile', 'admin', $CFG->dataroot.'/geoip/'), $CFG->dataroot.'/geoip/GeoLiteCity.dat'));
$temp->add(new admin_setting_configfile('geoip2file', new lang_string('geoipfile', 'admin'),
new lang_string('configgeoipfile', 'admin', $CFG->dataroot.'/geoip/'), $CFG->dataroot.'/geoip/GeoLite2-City.mmdb'));
$temp->add(new admin_setting_configtext('googlemapkey3', new lang_string('googlemapkey3', 'admin'), new lang_string('googlemapkey3_help', 'admin'), '', PARAM_RAW, 60));
$temp->add(new admin_setting_configtext('allcountrycodes', new lang_string('allcountrycodes', 'admin'), new lang_string('configallcountrycodes', 'admin'), '', '/^(?:\w+(?:,\w+)*)?$/'));
+90 -43
View File
@@ -40,7 +40,9 @@ if ($hassiteconfig) {
get_string('requiremodintro', 'admin'), get_string('requiremodintro_desc', 'admin'), 0));
$ADMIN->add('modsettings', $temp);
foreach (core_plugin_manager::instance()->get_plugins_of_type('mod') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('mod');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\mod $plugin */
$plugin->load_settings($ADMIN, 'modsettings', $hassiteconfig);
}
@@ -50,7 +52,9 @@ if ($hassiteconfig) {
$temp = new admin_settingpage('manageformats', new lang_string('manageformats', 'core_admin'));
$temp->add(new admin_setting_manageformats());
$ADMIN->add('formatsettings', $temp);
foreach (core_plugin_manager::instance()->get_plugins_of_type('format') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('format');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\format $plugin */
$plugin->load_settings($ADMIN, 'formatsettings', $hassiteconfig);
}
@@ -58,7 +62,9 @@ if ($hassiteconfig) {
// blocks
$ADMIN->add('modules', new admin_category('blocksettings', new lang_string('blocks')));
$ADMIN->add('blocksettings', new admin_page_manageblocks());
foreach (core_plugin_manager::instance()->get_plugins_of_type('block') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('block');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\block $plugin */
$plugin->load_settings($ADMIN, 'blocksettings', $hassiteconfig);
}
@@ -67,7 +73,9 @@ if ($hassiteconfig) {
$ADMIN->add('modules', new admin_category('messageoutputs', new lang_string('messageoutputs', 'message')));
$ADMIN->add('messageoutputs', new admin_page_managemessageoutputs());
$ADMIN->add('messageoutputs', new admin_page_defaultmessageoutputs());
foreach (core_plugin_manager::instance()->get_plugins_of_type('message') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('message');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\message $plugin */
$plugin->load_settings($ADMIN, 'messageoutputs', $hassiteconfig);
}
@@ -97,18 +105,30 @@ if ($hassiteconfig) {
new lang_string('forgottenpassword', 'auth'), ''));
$temp->add(new admin_setting_confightmleditor('auth_instructions', new lang_string('instructions', 'auth'),
new lang_string('authinstructions', 'auth'), ''));
$temp->add(new admin_setting_configtext('allowemailaddresses', new lang_string('allowemailaddresses', 'admin'), new lang_string('configallowemailaddresses', 'admin'), '', PARAM_NOTAGS));
$temp->add(new admin_setting_configtext('denyemailaddresses', new lang_string('denyemailaddresses', 'admin'), new lang_string('configdenyemailaddresses', 'admin'), '', PARAM_NOTAGS));
$setting = new admin_setting_configtext('allowemailaddresses', new lang_string('allowemailaddresses', 'admin'),
new lang_string('configallowemailaddresses', 'admin'), '', PARAM_NOTAGS);
$setting->set_force_ltr(true);
$temp->add($setting);
$setting = new admin_setting_configtext('denyemailaddresses', new lang_string('denyemailaddresses', 'admin'),
new lang_string('configdenyemailaddresses', 'admin'), '', PARAM_NOTAGS);
$setting->set_force_ltr(true);
$temp->add($setting);
$temp->add(new admin_setting_configcheckbox('verifychangedemail', new lang_string('verifychangedemail', 'admin'), new lang_string('configverifychangedemail', 'admin'), 1));
$temp->add(new admin_setting_configtext('recaptchapublickey', new lang_string('recaptchapublickey', 'admin'), new lang_string('configrecaptchapublickey', 'admin'), '', PARAM_NOTAGS));
$temp->add(new admin_setting_configtext('recaptchaprivatekey', new lang_string('recaptchaprivatekey', 'admin'), new lang_string('configrecaptchaprivatekey', 'admin'), '', PARAM_NOTAGS));
$setting = new admin_setting_configtext('recaptchapublickey', new lang_string('recaptchapublickey', 'admin'), new lang_string('configrecaptchapublickey', 'admin'), '', PARAM_NOTAGS);
$setting->set_force_ltr(true);
$temp->add($setting);
$setting = new admin_setting_configtext('recaptchaprivatekey', new lang_string('recaptchaprivatekey', 'admin'), new lang_string('configrecaptchaprivatekey', 'admin'), '', PARAM_NOTAGS);
$setting->set_force_ltr(true);
$temp->add($setting);
$ADMIN->add('authsettings', $temp);
$temp = new admin_externalpage('authtestsettings', get_string('testsettings', 'core_auth'), new moodle_url("/auth/test_settings.php"), 'moodle/site:config', true);
$ADMIN->add('authsettings', $temp);
foreach (core_plugin_manager::instance()->get_plugins_of_type('auth') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('auth');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\auth $plugin */
$plugin->load_settings($ADMIN, 'authsettings', $hassiteconfig);
}
@@ -122,7 +142,9 @@ if ($hassiteconfig) {
$temp = new admin_externalpage('enroltestsettings', get_string('testsettings', 'core_enrol'), new moodle_url("/enrol/test_settings.php"), 'moodle/site:config', true);
$ADMIN->add('enrolments', $temp);
foreach(core_plugin_manager::instance()->get_plugins_of_type('enrol') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('enrol');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\enrol $plugin */
$plugin->load_settings($ADMIN, 'enrolments', $hassiteconfig);
}
@@ -133,7 +155,9 @@ if ($hassiteconfig) {
$temp = new admin_settingpage('manageeditors', new lang_string('editorsettings', 'editor'));
$temp->add(new admin_setting_manageeditors());
$ADMIN->add('editorsettings', $temp);
foreach (core_plugin_manager::instance()->get_plugins_of_type('editor') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('editor');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\editor $plugin */
$plugin->load_settings($ADMIN, 'editorsettings', $hassiteconfig);
}
@@ -143,7 +167,9 @@ if ($hassiteconfig) {
$temp = new admin_settingpage('manageantiviruses', new lang_string('antivirussettings', 'antivirus'));
$temp->add(new admin_setting_manageantiviruses());
$ADMIN->add('antivirussettings', $temp);
foreach (core_plugin_manager::instance()->get_plugins_of_type('antivirus') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('antivirus');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/* @var \core\plugininfo\antivirus $plugin */
$plugin->load_settings($ADMIN, 'antivirussettings', $hassiteconfig);
}
@@ -182,11 +208,35 @@ if ($hassiteconfig) {
}
$ADMIN->add('filtersettings', $temp);
foreach (core_plugin_manager::instance()->get_plugins_of_type('filter') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('filter');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\filter $plugin */
$plugin->load_settings($ADMIN, 'filtersettings', $hassiteconfig);
}
// Media players.
$ADMIN->add('modules', new admin_category('mediaplayers', new lang_string('type_media_plural', 'plugin')));
$temp = new admin_settingpage('managemediaplayers', new lang_string('managemediaplayers', 'media'));
$temp->add(new admin_setting_heading('mediaformats', get_string('mediaformats', 'core_media'),
format_text(get_string('mediaformats_desc', 'core_media'), FORMAT_MARKDOWN)));
$temp->add(new admin_setting_managemediaplayers());
$temp->add(new admin_setting_heading('managemediaplayerscommonheading', new lang_string('commonsettings', 'admin'), ''));
$temp->add(new admin_setting_configtext('media_default_width',
new lang_string('defaultwidth', 'core_media'), new lang_string('defaultwidthdesc', 'core_media'),
400, PARAM_INT, 10));
$temp->add(new admin_setting_configtext('media_default_height',
new lang_string('defaultheight', 'core_media'), new lang_string('defaultheightdesc', 'core_media'),
300, PARAM_INT, 10));
$ADMIN->add('mediaplayers', $temp);
$plugins = core_plugin_manager::instance()->get_plugins_of_type('media');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\media $plugin */
$plugin->load_settings($ADMIN, 'mediaplayers', $hassiteconfig);
}
// Data format settings.
$ADMIN->add('modules', new admin_category('dataformatsettings', new lang_string('dataformats')));
$temp = new admin_settingpage('managedataformats', new lang_string('managedataformats'));
@@ -283,29 +333,16 @@ if ($hassiteconfig) {
new lang_string('createrepository', 'repository'), $url, 'moodle/site:config', true));
$ADMIN->add('repositorysettings', new admin_externalpage('repositoryinstanceedit',
new lang_string('editrepositoryinstance', 'repository'), $url, 'moodle/site:config', true));
foreach (core_plugin_manager::instance()->get_plugins_of_type('repository') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('repository');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\repository $plugin */
$plugin->load_settings($ADMIN, 'repositorysettings', $hassiteconfig);
}
/// Web services
$ADMIN->add('modules', new admin_category('webservicesettings', new lang_string('webservices', 'webservice')));
// Mobile
$temp = new admin_settingpage('mobile', new lang_string('mobile','admin'), 'moodle/site:config', false);
// We should wait to the installation to finish since we depend on some configuration values that are set once
// the admin user profile is configured.
if (!during_initial_install()) {
$enablemobiledocurl = new moodle_url(get_docs_url('Enable_mobile_web_services'));
$enablemobiledoclink = html_writer::link($enablemobiledocurl, new lang_string('documentation'));
$default = is_https() ? 1 : 0;
$temp->add(new admin_setting_enablemobileservice('enablemobilewebservice',
new lang_string('enablemobilewebservice', 'admin'),
new lang_string('configenablemobilewebservice', 'admin', $enablemobiledoclink), $default));
}
$temp->add(new admin_setting_configtext('mobilecssurl', new lang_string('mobilecssurl', 'admin'), new lang_string('configmobilecssurl','admin'), '', PARAM_URL));
$ADMIN->add('webservicesettings', $temp);
/// overview page
$temp = new admin_settingpage('webservicesoverview', new lang_string('webservicesoverview', 'webservice'));
$temp->add(new admin_setting_webservicesoverview());
@@ -337,7 +374,9 @@ if ($hassiteconfig) {
'admin'), new lang_string('configenablewsdocumentation', 'admin', $wsdoclink), false));
$ADMIN->add('webservicesettings', $temp);
/// links to protocol pages
foreach (core_plugin_manager::instance()->get_plugins_of_type('webservice') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('webservice');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\webservice $plugin */
$plugin->load_settings($ADMIN, 'webservicesettings', $hassiteconfig);
}
@@ -409,7 +448,9 @@ if ($hassiteconfig || has_capability('moodle/question:config', $systemcontext))
get_string('responsehistory', 'question'), '', 0, $hiddenofvisible));
// Settings for particular question types.
foreach (core_plugin_manager::instance()->get_plugins_of_type('qtype') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('qtype');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\qtype $plugin */
$plugin->load_settings($ADMIN, 'qtypesettings', $hassiteconfig);
}
@@ -421,7 +462,9 @@ if ($hassiteconfig && !empty($CFG->enableplagiarism)) {
$ADMIN->add('plagiarism', new admin_externalpage('manageplagiarismplugins', new lang_string('manageplagiarism', 'plagiarism'),
$CFG->wwwroot . '/' . $CFG->admin . '/plagiarism.php'));
foreach (core_plugin_manager::instance()->get_plugins_of_type('plagiarism') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('plagiarism');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\plagiarism $plugin */
$plugin->load_settings($ADMIN, 'plagiarism', $hassiteconfig);
}
@@ -445,6 +488,7 @@ if ($hassiteconfig) {
}
if (!empty($pages)) {
$ADMIN->add('modules', new admin_category('coursereports', new lang_string('coursereports')));
core_collator::asort_objects_by_property($pages, 'visiblename');
foreach ($pages as $page) {
$ADMIN->add('coursereports', $page);
}
@@ -468,6 +512,7 @@ foreach (core_component::get_plugin_list('report') as $report => $plugindir) {
$ADMIN->add('modules', new admin_category('reportplugins', new lang_string('reports')));
$ADMIN->add('reportplugins', new admin_externalpage('managereports', new lang_string('reportsmanage', 'admin'),
$CFG->wwwroot . '/' . $CFG->admin . '/reports.php'));
core_collator::asort_objects_by_property($pages, 'visiblename');
foreach ($pages as $page) {
$ADMIN->add('reportplugins', $page);
}
@@ -500,16 +545,11 @@ if ($hassiteconfig) {
$temp->add(new admin_setting_configselect('searchengine',
new lang_string('selectsearchengine', 'admin'), '', 'solr', $engines));
// Enable search areas.
$temp->add(new admin_setting_heading('searchareasheading', new lang_string('availablesearchareas', 'admin'), ''));
$searchareas = \core_search\manager::get_search_areas_list();
foreach ($searchareas as $areaid => $searcharea) {
list($componentname, $varname) = $searcharea->get_config_var_name();
$temp->add(new admin_setting_configcheckbox($componentname . '/' . $varname . '_enabled', $searcharea->get_visible_name(true),
'', 1, 1, 0));
}
$ADMIN->add('searchplugins', $temp);
$ADMIN->add('searchplugins', new admin_externalpage('searchareas', new lang_string('searchareas', 'admin'),
new moodle_url('/admin/searchareas.php')));
core_collator::asort_objects_by_property($pages, 'visiblename');
foreach ($pages as $page) {
$ADMIN->add('searchplugins', $page);
}
@@ -523,7 +563,9 @@ if ($hassiteconfig) {
}
// Now add various admin tools.
foreach (core_plugin_manager::instance()->get_plugins_of_type('tool') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('tool');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\tool $plugin */
$plugin->load_settings($ADMIN, null, $hassiteconfig);
}
@@ -534,6 +576,7 @@ if ($hassiteconfig) {
$ADMIN->add('cache', new admin_externalpage('cacheconfig', new lang_string('cacheconfig', 'cache'), $CFG->wwwroot .'/cache/admin.php'));
$ADMIN->add('cache', new admin_externalpage('cachetestperformance', new lang_string('testperformance', 'cache'), $CFG->wwwroot . '/cache/testperformance.php'));
$ADMIN->add('cache', new admin_category('cachestores', new lang_string('cachestores', 'cache')));
$ADMIN->locate('cachestores')->set_sorting(true);
foreach (core_component::get_plugin_list('cachestore') as $plugin => $path) {
$settingspath = $path.'/settings.php';
if (file_exists($settingspath)) {
@@ -547,7 +590,9 @@ if ($hassiteconfig) {
// Add Calendar type settings.
if ($hassiteconfig) {
$ADMIN->add('modules', new admin_category('calendartype', new lang_string('calendartypes', 'calendar')));
foreach (core_plugin_manager::instance()->get_plugins_of_type('calendartype') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('calendartype');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\calendartype $plugin */
$plugin->load_settings($ADMIN, 'calendartype', $hassiteconfig);
}
@@ -562,7 +607,9 @@ if ($hassiteconfig) {
// Extend settings for each local plugin. Note that their settings may be in any part of the
// settings tree and may be visible not only for administrators.
foreach (core_plugin_manager::instance()->get_plugins_of_type('local') as $plugin) {
$plugins = core_plugin_manager::instance()->get_plugins_of_type('local');
core_collator::asort_objects_by_property($plugins, 'displayname');
foreach ($plugins as $plugin) {
/** @var \core\plugininfo\local $plugin */
$plugin->load_settings($ADMIN, null, $hassiteconfig);
}
+14 -2
View File
@@ -96,6 +96,11 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
$temp->add(new admin_setting_configcheckbox('passwordchangelogout',
new lang_string('passwordchangelogout', 'admin'),
new lang_string('passwordchangelogout_desc', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('passwordchangetokendeletion',
new lang_string('passwordchangetokendeletion', 'admin'),
new lang_string('passwordchangetokendeletion_desc', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('groupenrolmentkeypolicy', new lang_string('groupenrolmentkeypolicy', 'admin'), new lang_string('groupenrolmentkeypolicy_desc', 'admin'), 1));
$temp->add(new admin_setting_configcheckbox('disableuserimages', new lang_string('disableuserimages', 'admin'), new lang_string('configdisableuserimages', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('emailchangeconfirmation', new lang_string('emailchangeconfirmation', 'admin'), new lang_string('configemailchangeconfirmation', 'admin'), 1));
@@ -109,12 +114,19 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
// "httpsecurity" settingpage
$temp = new admin_settingpage('httpsecurity', new lang_string('httpsecurity', 'admin'));
$temp->add(new admin_setting_configcheckbox('loginhttps', new lang_string('loginhttps', 'admin'), new lang_string('configloginhttps', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('cookiesecure', new lang_string('cookiesecure', 'admin'), new lang_string('configcookiesecure', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('cookiesecure', new lang_string('cookiesecure', 'admin'), new lang_string('configcookiesecure', 'admin'), 1));
$temp->add(new admin_setting_configcheckbox('cookiehttponly', new lang_string('cookiehttponly', 'admin'), new lang_string('configcookiehttponly', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('allowframembedding', new lang_string('allowframembedding', 'admin'), new lang_string('allowframembedding_help', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('loginpasswordautocomplete', new lang_string('loginpasswordautocomplete', 'admin'), new lang_string('loginpasswordautocomplete_help', 'admin'), 0));
$ADMIN->add('security', $temp);
// Settings elements used by the \core\files\curl_security_helper class.
$temp->add(new admin_setting_configmixedhostiplist('curlsecurityblockedhosts',
new lang_string('curlsecurityblockedhosts', 'admin'),
new lang_string('curlsecurityblockedhostssyntax', 'admin'), ""));
$temp->add(new admin_setting_configportlist('curlsecurityallowedport',
new lang_string('curlsecurityallowedport', 'admin'),
new lang_string('curlsecurityallowedportsyntax', 'admin'), ""));
$ADMIN->add('security', $temp);
// "notifications" settingpage
$temp = new admin_settingpage('notifications', new lang_string('notifications', 'admin'));
+60 -3
View File
@@ -28,8 +28,12 @@ if ($primaryadmin) {
$primaryadminemail = NULL;
$primaryadminname = NULL;
}
$temp->add(new admin_setting_configtext('supportname', new lang_string('supportname', 'admin'), new lang_string('configsupportname', 'admin'), $primaryadminname, PARAM_NOTAGS));
$temp->add(new admin_setting_configtext('supportemail', new lang_string('supportemail', 'admin'), new lang_string('configsupportemail', 'admin'), $primaryadminemail, PARAM_NOTAGS));
$temp->add(new admin_setting_configtext('supportname', new lang_string('supportname', 'admin'),
new lang_string('configsupportname', 'admin'), $primaryadminname, PARAM_NOTAGS));
$setting = new admin_setting_configtext('supportemail', new lang_string('supportemail', 'admin'),
new lang_string('configsupportemail', 'admin'), $primaryadminemail, PARAM_EMAIL);
$setting->set_force_ltr(true);
$temp->add($setting);
$temp->add(new admin_setting_configtext('supportpage', new lang_string('supportpage', 'admin'), new lang_string('configsupportpage', 'admin'), '', PARAM_URL));
$ADMIN->add('server', $temp);
@@ -79,7 +83,6 @@ $temp->add(new admin_setting_configselect('statsmaxruntime', new lang_string('st
60*60*7 => '7 '.new lang_string('hours'),
60*60*8 => '8 '.new lang_string('hours') )));
$temp->add(new admin_setting_configtext('statsruntimedays', new lang_string('statsruntimedays', 'admin'), new lang_string('configstatsruntimedays', 'admin'), 31, PARAM_INT));
$temp->add(new admin_setting_configtime('statsruntimestarthour', 'statsruntimestartminute', new lang_string('statsruntimestart', 'admin'), new lang_string('configstatsruntimestart', 'admin'), array('h' => 0, 'm' => 0)));
$temp->add(new admin_setting_configtext('statsuserthreshold', new lang_string('statsuserthreshold', 'admin'), new lang_string('configstatsuserthreshold', 'admin'), 0, PARAM_INT));
$ADMIN->add('server', $temp);
@@ -210,6 +213,60 @@ $ADMIN->add('server', $temp);
$ADMIN->add('server', new admin_externalpage('adminregistration', new lang_string('hubs', 'admin'),
"$CFG->wwwroot/$CFG->admin/registration/index.php"));
// E-mail settings.
$ADMIN->add('server', new admin_category('email', new lang_string('categoryemail', 'admin')));
$temp = new admin_settingpage('outgoingmailconfig', new lang_string('outgoingmailconfig', 'admin'));
$temp->add(new admin_setting_heading('smtpheading', new lang_string('smtp', 'admin'),
new lang_string('smtpdetail', 'admin')));
$temp->add(new admin_setting_configtext('smtphosts', new lang_string('smtphosts', 'admin'),
new lang_string('configsmtphosts', 'admin'), '', PARAM_RAW));
$options = array('' => new lang_string('none', 'admin'), 'ssl' => 'SSL', 'tls' => 'TLS');
$temp->add(new admin_setting_configselect('smtpsecure', new lang_string('smtpsecure', 'admin'),
new lang_string('configsmtpsecure', 'admin'), '', $options));
$authtypeoptions = array('LOGIN' => 'LOGIN', 'PLAIN' => 'PLAIN', 'NTLM' => 'NTLM', 'CRAM-MD5' => 'CRAM-MD5');
$temp->add(new admin_setting_configselect('smtpauthtype', new lang_string('smtpauthtype', 'admin'),
new lang_string('configsmtpauthtype', 'admin'), 'LOGIN', $authtypeoptions));
$temp->add(new admin_setting_configtext('smtpuser', new lang_string('smtpuser', 'admin'),
new lang_string('configsmtpuser', 'admin'), '', PARAM_NOTAGS));
$temp->add(new admin_setting_configpasswordunmask('smtppass', new lang_string('smtppass', 'admin'),
new lang_string('configsmtpuser', 'admin'), ''));
$temp->add(new admin_setting_configtext('smtpmaxbulk', new lang_string('smtpmaxbulk', 'admin'),
new lang_string('configsmtpmaxbulk', 'admin'), 1, PARAM_INT));
$temp->add(new admin_setting_heading('noreplydomainheading', new lang_string('noreplydomain', 'admin'),
new lang_string('noreplydomaindetail', 'admin')));
$temp->add(new admin_setting_configtext('noreplyaddress', new lang_string('noreplyaddress', 'admin'),
new lang_string('confignoreplyaddress', 'admin'), 'noreply@' . get_host_from_url($CFG->wwwroot), PARAM_EMAIL));
$temp->add(new admin_setting_configtextarea('allowedemaildomains',
new lang_string('allowedemaildomains', 'admin'),
new lang_string('configallowedemaildomains', 'admin'),
''));
$temp->add(new admin_setting_heading('emaildoesnotfit', new lang_string('doesnotfit', 'admin'),
new lang_string('doesnotfitdetail', 'admin')));
$charsets = get_list_of_charsets();
unset($charsets['UTF-8']); // Not needed here.
$options = array();
$options['0'] = 'UTF-8';
$options = array_merge($options, $charsets);
$temp->add(new admin_setting_configselect('sitemailcharset', new lang_string('sitemailcharset', 'admin'),
new lang_string('configsitemailcharset','admin'), '0', $options));
$temp->add(new admin_setting_configcheckbox('allowusermailcharset', new lang_string('allowusermailcharset', 'admin'),
new lang_string('configallowusermailcharset', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('allowattachments', new lang_string('allowattachments', 'admin'),
new lang_string('configallowattachments', 'admin'), 1));
$options = array('LF' => 'LF', 'CRLF' => 'CRLF');
$temp->add(new admin_setting_configselect('mailnewline', new lang_string('mailnewline', 'admin'),
new lang_string('configmailnewline', 'admin'), 'LF', $options));
$choices = array(new lang_string('never', 'admin'),
new lang_string('always', 'admin'),
new lang_string('onlynoreply', 'admin'));
$temp->add(new admin_setting_configselect('emailfromvia', new lang_string('emailfromvia', 'admin'),
new lang_string('configemailfromvia', 'admin'), 1, $choices));
$ADMIN->add('email', $temp);
// "update notifications" settingpage
if (empty($CFG->disableupdatenotifications)) {
$temp = new admin_settingpage('updatenotifications', new lang_string('updatenotifications', 'core_admin'));
+1 -1
View File
@@ -47,4 +47,4 @@ $ADMIN->add('root', new admin_category('development', new lang_string('developme
$ADMIN->add('root', new admin_category('unsupported', new lang_string('unsupported', 'admin'), true));
// hidden search script
$ADMIN->add('root', new admin_externalpage('search', new lang_string('searchresults'), "$CFG->wwwroot/$CFG->admin/search.php", 'moodle/site:config', true));
$ADMIN->add('root', new admin_externalpage('search', new lang_string('search', 'admin'), "$CFG->wwwroot/$CFG->admin/search.php", 'moodle/site:configview', true));
+4 -1
View File
@@ -190,7 +190,10 @@ if ($hassiteconfig
'department' => new lang_string('department'),
'institution' => new lang_string('institution'),
)));
$temp->add(new admin_setting_configtext('fullnamedisplay', new lang_string('fullnamedisplay', 'admin'), new lang_string('configfullnamedisplay', 'admin'), 'language', PARAM_TEXT, 50));
$setting = new admin_setting_configtext('fullnamedisplay', new lang_string('fullnamedisplay', 'admin'),
new lang_string('configfullnamedisplay', 'admin'), 'language', PARAM_TEXT, 50);
$setting->set_force_ltr(true);
$temp->add($setting);
$temp->add(new admin_setting_configtext('alternativefullnameformat', new lang_string('alternativefullnameformat', 'admin'),
new lang_string('alternativefullnameformat_desc', 'admin'),
'language', PARAM_RAW, 50));
+69
View File
@@ -0,0 +1,69 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting
Admin setting template.
Context variables required for this template:
* labelfor - id of the form element
* title - Setting title
* override - Overridden message
* warning - Warning message
* name - Setting name
* error - Error message
* element - The Element HTML
* forceltr - Force this element to be displayed LTR
* default - Default value
Example context (json):
{
"title": "Setting title",
"labelfor": "id0",
"override": "Overidden",
"warning": "Warning",
"name": "Name",
"error": "Error",
"element": "Raw HTML",
"forceltr": false,
"default": "Default value"
}
}}
<div class="form-item clearfix" id="{{id}}">
<div class="form-label">
<label {{#labelfor}}for="{{labelfor}}"{{/labelfor}}>
{{{title}}}
{{#override}}
<div class="form-overridden">{{override}}</div>
{{/override}}
{{#warning}}
<div class="form-warning">{{warning}}</div>
{{/warning}}
</label>
<span class="form-shortname">{{{name}}}</span>
</div>
<div class="form-setting">
{{#error}}
<div><span class="error">{{error}}</span></div>
{{/error}}
{{{element}}}
{{#default}}
<div class="form-defaultinfo {{#forceltr}}text-ltr{{/forceltr}}">{{{default}}}</div>
{{/default}}
</div>
<div class="form-description">{{{description}}}</div>
</div>
@@ -0,0 +1,41 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configcheckbox
Admin checkbox setting template.
Context variables required for this template:
* name - form element name
* no - no value
* value - yes value
* id - element id
* checked - boole
Example context (json):
{
"name": "test",
"no": "False",
"value": "True",
"id": "test0",
"checked": "checked"
}
}}
<div class="form-checkbox defaultsnext">
<input type="hidden" name="{{name}}" value="{{no}}">
<input type="checkbox" name="{{name}}" value="{{value}}" id="{{id}}" {{#checked}}checked{{/checked}}>
</div>
@@ -0,0 +1,48 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configcolourpicker
Admin setting colour picker template.
Context variables required for this template:
* icon - optional icon context (see pix_icon)
* name - element name
* id - element id
* value - element value
* haspreviewconfig - show preview of selected color
Example context (json):
{
"icon": false,
"name": "name0",
"id": "id0",
"value": "#555655",
"haspreviewconfig": false
}
}}
<div class="form-colourpicker defaultsnext">
<div class="admin_colourpicker clearfix">
{{#icon}}
{{>core/pix_icon}}
{{/icon}}
</div>
<input type="text" name="{{name}}" id="{{id}}" value="{{value}}" size="12" class="text-ltr">
{{#haspreviewconfig}}
<input type="button" id="{{id}}_preview" value={{#quote}}{{#str}}preview{{/str}}{{/quote}} class="admin_colourpicker_preview">
{{/haspreviewconfig}}
</div>
@@ -0,0 +1,41 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configdirectory
Admin directory setting template.
Context variables required for this template:
* name - form element name
* id - element id
* size - size of the field
* readonly - Make the field readonly
* value - value
* showvalidity - Show a green check if the path is readable
* valid - True if the path is readable
Example context (json):
{
"name": "test",
"value": "/my-super-secret-path/",
"id": "test0",
"readonly": true,
"showvalidity": true,
"valid": false
}
}}
{{>core_admin/setting_configfile}}
@@ -0,0 +1,45 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configduration
Admin duration setting template.
Context variables required for this template:
* name - form element name
* options - list of options for units containing name, value, selected
* value - yes
* id - element id
Example context (json):
{
"name": "test",
"value": "5",
"id": "test0",
"options": [ { "name": "Minutes", "value": "mins", "selected": true } ]
}
}}
<div class="form-duration defaultsnext">
<input type="text" size="5" id="{{id}}v" name="{{name}}[v]" value="{{value}}" class="text-ltr">
<label class="accesshide" for="{{id}}u">{{#str}}durationunits, admin{{/str}}</label>
<select id="{{id}}u" name="{{name}}[u]">
{{#options}}
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
{{/options}}
</select>
</div>
@@ -0,0 +1,34 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configempty
Admin empty setting template.
Context variables required for this template:
* name - form element name
* id - element id
Example context (json):
{
"name": "test",
"id": "test0"
}
}}
<div class="form-empty">
<input type="hidden" name="{{name}}" id="{{id}}" value="">
</div>
@@ -0,0 +1,41 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configexecutable
Admin executable setting template.
Context variables required for this template:
* name - form element name
* id - element id
* size - size of the field
* readonly - Make the field readonly
* value - value
* showvalidity - Show a green check if the path is readable
* valid - True if the path is readable
Example context (json):
{
"name": "test",
"value": "/usr/bin/cowsay",
"id": "test0",
"readonly": true,
"showvalidity": true,
"valid": false
}
}}
{{>core_admin/setting_configfile}}
@@ -0,0 +1,52 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configfile
Admin file setting template.
Context variables required for this template:
* name - form element name
* id - element id
* size - size of the field
* readonly - Make the field readonly
* value - value
* showvalidity - Show a green check if the path is readable
* valid - True if the path is readable
Example context (json):
{
"name": "test",
"value": "/my-super-secret-path/file",
"id": "test0",
"readonly": true,
"showvalidity": true,
"valid": false
}
}}
<div class="form-file defaultsnext">
<input type="text" name="{{name}}" id="{{id}}" size="{{size}}" value="{{value}}" class="text-ltr" {{#readonly}}readonly{{/readonly}}>
{{#showvalidity}}
{{#valid}}
<span class="pathok">&#x2714;</span>
{{/valid}}
{{^valid}}
<span class="patherror">&#x2718;</span>
{{/valid}}
{{/showvalidity}}
</div>
@@ -0,0 +1,39 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_confightmleditor
Admin htmleditor setting template.
Context variables required for this template:
* rows - number of rows
* cols - number of cols
* id - element id
* name - element name
* value - default text
* forceltr - always ltr
Example context (json):
{
"name": "test",
"id": "test0",
"value": "Your aims are high, and you are capable of much.",
"rows": 5,
"cols": 30
}
}}
{{>core_admin/setting_configtextarea}}
@@ -0,0 +1,46 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configmulticheckbox
Admin multicheckbox setting template.
Context variables required for this template:
* name - form element name
* hasoptions - there are some options
* options - list of options containing name, key, id, checked, label
Example context (json):
{
"name": "test",
"hasoptions": true,
"options": [ { "name": "Option", "key": "k1", "id": "id0", "checked": true, "label": "Option label"} ]
}
}}
<div class="form-multicheckbox">
<input type="hidden" name="{{name}}[xxxxx]" value="1">
{{#hasoptions}}
<ul>
{{#options}}
<li>
<input type="checkbox" name="{{name}}[{{key}}]" value="1" id="{{id}}_{{key}}" {{#checked}}checked{{/checked}}>
<label for="{{id}}_{{key}}">{{{label}}}</label>
</li>
{{/options}}
</ul>
{{/hasoptions}}
</div>
@@ -0,0 +1,45 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configmultiselect
Admin multiselect setting template.
Context variables required for this template:
* name - form element name
* id - element id
* size - element size
* options - list of options containing name, value, selected
Example context (json):
{
"name": "test",
"id": "test0",
"size": "3",
"options": [ { "name": "Option 1", "value": "V", "selected": true },
{ "name": "Option 2", "value": "V", "selected": true } ]
}
}}
<div class="form-select">
<input type="hidden" name="{{name}}[xxxxx]" value="1">
<select id="{{id}}" name="{{name}}[]" size="{{size}}" multiple>
{{#options}}
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
{{/options}}
</select>
</div>
@@ -0,0 +1,63 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configpasswordunmask
Admin password unmask setting template.
Context variables required for this template:
* name - form element name
* size - form element size
* value - form element value
* id - element id
Example context (json):
{
"name": "test",
"id": "test0",
"size": "8",
"value": "secret"
}
}}
<div class="form-password">
<span data-passwordunmask="wrapper" data-passwordunmaskid="{{ id }}">
<span data-passwordunmask="editor">
<input type="hidden"
name="{{ name }}"
id="{{ id }}"
value="{{ value }}"
data-size="{{ size }}"
class="form-control d-inline-block"
>
</span>
<a href="#" data-passwordunmask="edit" title="{{ edithint }}">
<span data-passwordunmask="displayvalue">{{> core_form/element-passwordunmask-fill }}</span>
{{# pix }} t/passwordunmask-edit, core, {{# str }} passwordunmaskedithint, form {{/ str }}{{/ pix }}
</a>
<a href="#" data-passwordunmask="unmask" title="{{ unmaskhint }}">
{{# pix }} t/passwordunmask-reveal, core, {{# str }} passwordunmaskrevealhint, form {{/ str }}{{/ pix }}
</a>
<span data-passwordunmask="instructions" class="form-text text-muted" style="display: none;">
{{# str }} passwordunmaskinstructions, form {{/ str }}
</span>
</span>
</div>
{{#js}}
require(['core_form/passwordunmask'], function(PasswordUnmask) {
new PasswordUnmask("{{ id }}");
});
{{/js}}
@@ -0,0 +1,44 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configselect
Admin select setting template.
Context variables required for this template:
* name - form element name
* id - element id
* options - list of options containing name, value, selected
Example context (json):
{
"name": "test",
"id": "test0",
"options": [
{ "name": "Option 1", "value": "V", "selected": true },
{ "name": "Option 2", "value": "V", "selected": true }
]
}
}}
<div class="form-select defaultsnext">
<select id="{{id}}" name="{{name}}">
{{#options}}
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
{{/options}}
</select>
</div>
@@ -0,0 +1,42 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configtext
Admin text setting template.
Context variables required for this template:
* name - form element name
* id - element id
* value - element value
* size - element size
* forceltr - always display as ltr
* attributes - list of additional attributes containing name, value
Example context (json):
{
"name": "test",
"id": "test0",
"value": "A tall, dark stranger will have more fun than you.",
"size": "21",
"forceltr": false,
"attributes": [ { "name": "readonly", "value": "readonly" } ]
}
}}
<div class="form-text defaultsnext">
<input type="text" name="{{name}}" value="{{value}}" size="{{size}}" id="{{id}}" class="{{#forceltr}}text-ltr{{/forceltr}}"{{#attributes}} {{name}}="{{value}}"{{/attributes}}>
</div>
@@ -0,0 +1,41 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configtextarea
Admin textarea setting template.
Context variables required for this template:
* name - form element name
* id - element id
* rows - number of rows
* cols - number of cols
* value - default value
* forceltr - always display as ltr
Example context (json):
{
"name": "test",
"cols": "30",
"rows": "3",
"value": "Excellent day for putting Slinkies on an escalator.",
"id": "test0"
}
}}
<div class="form-textarea">
<textarea rows="{{rows}}" cols="{{cols}}" id="{{id}}" name="{{name}}" spellcheck="true" class="{{#forceltr}}text-ltr{{/forceltr}}">{{value}}</textarea>
</div>
@@ -0,0 +1,56 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_configtime
Admin time setting template.
Context variables required for this template:
* name - form element name
* id - element id
* hours - list of valid hour options containing name, value, selected
* minutes - list of valid minute options containing name, value, selected
Example context (json):
{
"name": "test",
"id": "test0",
"minutes": [
{ "name": "00", "value": "0", "selected": true },
{ "name": "01", "value": "1", "selected": false }
],
"hours": [
{ "name": "1", "value": "1", "selected": true },
{ "name": "2", "value": "2", "selected": false }
]
}
}}
<div class="form-time defaultsnext text-ltr">
<label class="accesshide" for="{{id}}h">{{#str}}hours{{/str}}</label>
<select id="{{id}}h" name="{{name}}[h]">
{{#hours}}
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
{{/hours}}
</select>:
<label class="accesshide" for="{{id}}m">{{#str}}minutes{{/str}}</label>
<select id="{{id}}m" name="{{name}}[m]">
{{#minutes}}
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
{{/minutes}}
</select>
</div>
@@ -0,0 +1,49 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_courselist_frontpage
Admin courselist_frontpage setting template.
Context variables required for this template:
* selects list of select objects containing id, name, key and options.
options is another nested list of items containing name, value and selected
Example context (json):
{
"selects": [
{
"id": "i1",
"name": "s1",
"key": "k1",
"options": [
{ "name": "Fish", "value": "snapper", "selected": true }
]
}
]
}
}}
<div class="form-group">
{{#selects}}
<select id="{{id}}{{key}}" name="{{name}}[]" class="form-select">
{{#options}}
<option value="{{value}}" {{#selected}}selected{{/selected}}>{{name}}</option>
{{/options}}
</select>
<br>
{{/selects}}
</div>
@@ -0,0 +1,51 @@
{{!
This file is part of Moodle - http://moodle.org/
Moodle is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.
Moodle is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with Moodle. If not, see <http://www.gnu.org/licenses/>.
}}
{{!
@template core_admin/setting_devicedetectregex
Admin devicedetectregex setting template.
Context variables required for this template:
* expressions - List of expressions containing index, name, expression and value
Example context (json):
{
"expressions": [
{ "index": "i1", "name": "Name", "expression": "/bird|yellow/", "value": "Canary" }
]
}
}}
<table class="generaltable">
<thead>
<tr>
<th>{{#str}}devicedetectregexexpression, admin{{/str}}</th>
<th>{{#str}}devicedetectregexvalue, admin{{/str}}</th>
</tr>
</thead>
<tbody>
{{#expressions}}
<tr>
<td class="c{{index}}">
<input type="text" name="{{name}}[expression{{index}}]" class="form-text text-ltr" value="{{expression}}">
</td>
<td class="c{{index}}">
<input type="text" name="{{name}}[value{{index}}]" class="form-text text-ltr" value="{{value}}">
</td>
</tr>
{{/expressions}}
</tbody>
</table>

Some files were not shown because too many files have changed in this diff Show More