MDL-57274 upgrade: fix curl security notices during upgrade/install

Handles the case where $CFG->curlsecurityxxx vars don't yet exist during install or upgrade by treating not set the same as empty.
2017-02-20 08:56:47 +08:00
parent 1a754e8446
commit 72e3ff3c15
1 changed files with 6 additions and 0 deletions
@@ -235,6 +235,9 @@ class curl_security_helper extends curl_security_helper_base {
     */
    protected function get_whitelisted_ports() {
        global $CFG;
+        if (!isset($CFG->curlsecurityallowedport)) {
+            return [];
+        }
        return array_filter(explode("\n", $CFG->curlsecurityallowedport), function($entry) {
            return !empty($entry);
        });
@@ -247,6 +250,9 @@ class curl_security_helper extends curl_security_helper_base {
     */
    protected function get_blacklisted_hosts() {
        global $CFG;
+        if (!isset($CFG->curlsecurityblockedhosts)) {
+            return [];
+        }
        return array_filter(array_map('trim', explode("\n", $CFG->curlsecurityblockedhosts)), function($entry) {
            return !empty($entry);
        });