MDL-54977 blocks_navigation: Use html_writer::random_id for id

uniqid() may returns the same id for faster machines (seen on iis)
so use html_writer::random_id(), to ensure id is different and
navigation don't break
This commit is contained in:
JD
2016-07-13 14:04:16 +08:00
committed by Rajesh Taneja
parent 5a1728df39
commit 560cea838b
2 changed files with 2 additions and 2 deletions
+1 -1
View File
@@ -86,7 +86,7 @@ class block_navigation_renderer extends plugin_renderer_base {
continue;
}
$id = $item->id ? $item->id : uniqid();
$id = $item->id ? $item->id : html_writer::random_id();
$content = $item->get_content();
$title = $item->get_title();
$ulattr = ['id' => $id . '_group', 'role' => 'group'];
+1 -1
View File
@@ -75,7 +75,7 @@ class block_settings_renderer extends plugin_renderer_base {
}
$content = $this->output->render($item);
$id = $item->id ? $item->id : uniqid();
$id = $item->id ? $item->id : html_writer::random_id();
$ulattr = ['id' => $id . '_group', 'role' => 'group'];
$liattr = ['class' => [$item->get_css_type(), 'depth_'.$depth], 'tabindex' => '-1'];
$pattr = ['class' => ['tree_item'], 'role' => 'treeitem'];