L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-56943 boost: correct ARIA roles

Browse Source 
* role="navigation" can't go directly on a list
* role="banner" should only be done once and not on a link
This commit is contained in:
Dan Poltawski
2016-11-16 16:52:03 +00:00
parent 310808b778
commit a4e2d64571
3 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
theme/boost/templates/core/navbar.mustache
+12 -10
View File
@@ -58,13 +58,15 @@
]
}
}}
<ol class="breadcrumb" role="navigation">
{{#get_items}}
{{#has_action}}
<li class="breadcrumb-item"><a href="{{{action}}}" {{#get_title}}title="{{get_title}}"{{/get_title}}>{{{text}}}</a></li>
{{/has_action}}
{{^has_action}}
<li class="breadcrumb-item">{{{text}}}</li>
{{/has_action}}
{{/get_items}}
</ol>
<nav role="navigation">
<ol class="breadcrumb">
{{#get_items}}
{{#has_action}}
<li class="breadcrumb-item"><a href="{{{action}}}" {{#get_title}}title="{{get_title}}"{{/get_title}}>{{{text}}}</a></li>
{{/has_action}}
{{^has_action}}
<li class="breadcrumb-item">{{{text}}}</li>
{{/has_action}}
{{/get_items}}
</ol>
</nav>
theme/boost/templates/header.mustache
+1 -1
View File
@@ -25,7 +25,7 @@
<button aria-expanded="{{#navdraweropen}}true{{/navdraweropen}}{{^navdraweropen}}false{{/navdraweropen}}" aria-controls="nav-drawer" type="button" class="btn pull-xs-left m-r-1 btn-secondary" data-action="toggle-drawer" data-side="left" data-preference="drawer-open-nav">&#9776;<span class="sr-only">{{#str}}expand, core{{/str}}</span></button>
</div>
<a role="banner" href="{{{ config.wwwroot }}}" class="navbar-brand {{# output.should_display_navbar_logo }}has-logo{{/ output.should_display_navbar_logo }}
<a href="{{{ config.wwwroot }}}" class="navbar-brand {{# output.should_display_navbar_logo }}has-logo{{/ output.should_display_navbar_logo }}
{{^ output.should_display_navbar_logo }}
hidden-sm-down
{{/ output.should_display_navbar_logo }}
theme/boost/templates/secure.mustache
+2 -2
View File
@@ -47,13 +47,13 @@
{{{ output.standard_top_of_body_html }}}
<header class="navbar navbar-full navbar-light bg-faded navbar-static-top moodle-has-zindex">
<header class="navbar navbar-full navbar-light bg-faded navbar-static-top moodle-has-zindex" role="banner">
<div class="container">
<div class="clearfix">
<button class="navbar-toggler pull-xs-right hidden-sm-up" data-toggle="collapse" data-target="#bd-main-mav">☰<span class="sr-only">{{#str}}expand{{/str}}</span></button>
</div>
<a role="banner" href="{{{ config.wwwroot }}}" class="navbar-brand">
<a href="{{{ config.wwwroot }}}" class="navbar-brand">
{{# output.should_display_navbar_logo }}
<div class="logo">
<img src="{{output.get_compact_logo_url}}" alt={{#quote}}{{sitename}}{{/quote}}>