L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-56516 tool_usertous: Remove eroneous test

Browse Source
This commit is contained in:
Andrew Nicols
2016-10-25 08:54:33 +08:00
parent 67b49f27a4
commit 6db92c6c37
2 changed files with 1 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/tool/usertours/classes/manager.php
-1
View File
@@ -561,7 +561,6 @@ class manager {
public static function get_matching_tours(\moodle_url $pageurl) {
global $PAGE;
$tours = cache::get_matching_tourdata($pageurl->out_as_local_url());
foreach ($tours as $record) {
admin/tool/usertours/tests/manager_test.php
+1 -28
View File
@@ -242,10 +242,7 @@ class tool_usertours_manager_testcase extends advanced_testcase {
$this->resetAfterTest();
foreach ($alltours as $tourconfig) {
$tourconfig = (object) $tourconfig;
$tourconfig->id = null;
$tour = \tool_usertours\tour::load_from_record($tourconfig, true);
$tour->persist(true);
$tour = $this->helper_create_tour((object) $tourconfig);
$this->helper_create_step((object) ['tourid' => $tour->get_id()]);
}
@@ -257,28 +254,4 @@ class tool_usertours_manager_testcase extends advanced_testcase {
$this->assertEquals($expected, $match->get_name());
}
}
/**
* Tests for the get_matching_tours function when requiring an upgrade
*
* @dataProvider get_matching_tours_provider
* @param array $alltours The list of tours to insert
* @param string $url The URL to test
* @param string $expected The name of the expected matching tour
*/
public function test_get_matching_tours_requires_upgrade($alltours, $url, $expected) {
$this->resetAfterTest();
global $CFG;
unset($CFG->version);
foreach ($alltours as $tourconfig) {
$tourconfig = (object) $tourconfig;
$tourconfig->id = null;
$tour = \tool_usertours\tour::load_from_record($tourconfig, true);
$tour->persist(true);
}
$this->assertNull(\tool_usertours\manager::get_matching_tours(new moodle_url($url)));
}
}