L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-57868 mod_feedback: Fix incorrect query parameters order

Browse Source 
get_records_menu call get_records using the same params ordering, it is
causing a duplicated value error for the first column
This commit is contained in:
Juan Leyva
2017-02-06 11:32:33 +01:00
parent a09a9879e5
commit 13a2a8344c
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/feedback/lib.php
+1 -2
View File
@@ -997,10 +997,9 @@ function feedback_get_incomplete_users(cm_info $cm,
//now get all completeds
$params = array('feedback'=>$cm->instance);
if (!$completedusers = $DB->get_records_menu('feedback_completed', $params, '', 'userid,id')) {
if (!$completedusers = $DB->get_records_menu('feedback_completed', $params, '', 'id, userid')) {
return $allusers;
}
$completedusers = array_keys($completedusers);
//now strike all completedusers from allusers
$allusers = array_diff($allusers, $completedusers);