Compare commits

..

2921 Commits

Author SHA1 Message Date
Eloy Lafuente (stronk7) ae1854f55c Moodle release 2.8.9 2015-11-06 20:51:38 +01:00
Dan Poltawski 394cba177e weekly release 2.8.8+ 2015-11-06 11:56:38 +00:00
Rajesh Taneja 9d9cfb8736 MDL-51685 unittest: Test functionality individually 2015-11-06 11:24:41 +01:00
Eloy Lafuente (stronk7) 8e2cd6b91a MDL-51861 enrol: added missing external cleanup for formal compliance 2015-11-06 10:05:56 +00:00
Dan Poltawski 6b9c205a99 MDL-51569 mod_choice: Fix use of hardcoded ids
(Previous approach of making up ids longer works now we are validating
them..)
2015-11-06 08:12:57 +00:00
Dani Palou 512633461a MDL-51861 enrol: Don't get all parts in get_enrolled_users with groups 2015-11-06 15:12:11 +08:00
Eloy Lafuente (stronk7) 61ecc0d5f0 MDL-51861 enrol: new unit test to verify all conditions and filters
This unit test does not verify contents, details, but only
that the returned users for every group mode, for every
filtering (active, groupid and withcapability) together
with permissions are correct.
2015-11-06 15:12:07 +08:00
John Okely 02d8c8ca39 MDL-51569 mod_choice: Prevent users from updating choices with curl 2015-11-06 14:53:26 +08:00
Andrew Nicols 11d4f442bb MDL-51685-master Fix unit tests following change
These unit tests were modifying the PAGE and other globals in the middle of
tests and were failing as a result.

Broke the tests up into separate tests where the functionality is now
tested individually.
2015-11-06 10:37:04 +08:00
Damyon Wiese 5c16db4fc5 MDL-51569 mod_choice: Validate the submitted optionid
Make sure any submitted choice options actually belong to the current choice
module.
2015-11-05 10:48:51 +00:00
Andrew Nicols 720d88779e Merge branch 'MDL-51395-28' of git://github.com/junpataleta/moodle into MOODLE_28_STABLE 2015-11-05 14:03:27 +08:00
Jun Pataleta 5dd381d25c MDL-51395 blog: Fix output of strings for blog comments 2015-11-04 23:47:59 -06:00
Andrew Nicols cb2220bfde Merge branch 'MDL-26429-28' of git://github.com/cameron1729/moodle into MOODLE_28_STABLE 2015-11-05 12:17:44 +08:00
Andrew Nicols c9d8b0d29a MDL-51899 mod_forum: Add test for allowing 0 grades 2015-11-05 12:08:54 +08:00
Cameron Ball 29d6115e65 MDL-26429 usability: Add course completion icons.
This patch adds a method to the course completion criteria classes
which allows them to specify an icon for display in the course
completion report table.

There is a default implementation which simply looks for an icon
in pix/i with a name matching the completion criteria type.
2015-11-05 11:41:49 +08:00
Barbara Ramiro 2dffff79c7 MDL-26429 Course completion icons for self, duration, and role. 2015-11-05 11:41:48 +08:00
Andrew Nicols 9be0bf1d10 Merge branch 'MDL-51899_28' of git://github.com/jacac/moodle into MOODLE_28_STABLE 2015-11-05 11:27:37 +08:00
Andrew Nicols 9ba8006955 Merge branch 'MDL-51685-28' of git://github.com/dpalou/moodle into MOODLE_28_STABLE 2015-11-05 10:42:29 +08:00
rajesh Taneja fe9bd2b8bb MDL-50837 mod_scorm: include locallib to access function 2015-11-05 10:25:05 +08:00
Jakob 57d281f554 MDL-51899 mod/assign: Allow 0.00 grades while editing a grade.
The function unformat_float can return 0 and false.
We need to do strict comparison for the return value on line 92 to accept grades 0.00.
2015-11-04 11:08:06 -08:00
David Monllao d41fa94a69 MDL-51684 badges: Make sure 'moodle/badges:viewbadges' is respected
Credit to Yuliya Bozhko.
2015-11-04 13:02:44 +00:00
Juan Leyva d28eedd536 MDL-50837 mod_scorm: Fix availability checks 2015-11-04 12:56:11 +01:00
Juan Leyva 72885a5725 MDL-51569 mod_choice: Check choice availability prior to do any action 2015-11-04 11:08:51 +00:00
Cameron Ball 7bf5c6a542 MDL-51091 core_registration: session key check in registration. 2015-11-04 18:46:26 +08:00
Simey Lameze b4f4232e1c MDL-49940 mod_survey: Fix XSS on survey module 2015-11-04 18:46:26 +08:00
Hugh Davenport f03ec4ce85 MDL-49940 mod_survey: Escape user comments
This patch fixes a XSS vulnerability with surveys where a student user
    could inject arbitrary HTML in a comment on the survey. The fix is to
    escape the comment before displaying it to the teacher.
2015-11-04 18:46:26 +08:00
David Monllao 50632a0681 MDL-51000 editor_atto: No autosave for guests 2015-11-04 18:46:26 +08:00
Simey Lameze dcb42c9ed1 MDL-48109 mod_lesson: prevent CSRF on lesson
This commit add a new session key hidden field on the lesson password form
and confirm if the session key is valid on related pages to prevent CSRF on
password protected lessons.
2015-11-04 18:46:26 +08:00
Petr Skoda 7db05ae3b2 MDL-48085 flowplayer: prevent flash parameters via url 2015-11-04 10:38:34 +00:00
Andrew Nicols 8e093acc9d Merge branch 'MDL-45814-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-11-04 14:05:19 +08:00
Andrew Nicols 5bd1977645 Merge branch 'MDL-52004-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE 2015-11-04 13:47:10 +08:00
Andrew Nicols 63d70b1eca Merge branch 'wip-MDL-51486-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-11-04 11:50:45 +08:00
Andrew Nicols 2c6d1dd02d Merge branch 'MDL-51918-28-navigable' of https://github.com/pauln/moodle into MOODLE_28_STABLE 2015-11-04 11:30:51 +08:00
Adrian Greeve 5c31064d5e MDL-51486 mod_data: Unit test update for item ratings.
Additional checks that access is available for item ratings
on records that have a group id of zero (all participants).
2015-11-04 10:17:08 +08:00
Adrian Greeve 6dfb7f0eca MDL-51486 mod_data: Can view rating information.
When students are given the appropriate permissions
to view ratings, in the situation where there are
separate groups. The students can view the ratings
of an entry that is in the all participants group.
2015-11-04 10:16:52 +08:00
Paul Nicholls 80ef82e3f3 MDL-51918 gradereport: Fix AJAX mode keyboard navigation
Keyboard navigation (ctrl+up/down/left/right) with AJAX enabled ceased
functioning with editing mode enabled after MDL-36606, as it was looking
for cells with a "clickable" class - but was only applying that class when
editing mode is NOT enabled.  This patch uses a new "gbnavigable" class to
control keyboard navigation, whether editing mode is on or not.  It also
addresses some browser compatibility and minor behavioural issues.

# Conflicts:
#	grade/report/grader/module.js
2015-11-04 11:53:57 +13:00
Eloy Lafuente (stronk7) 336f2e073b weekly release 2.8.8+ 2015-11-03 18:46:14 +01:00
Eloy Lafuente (stronk7) 27f5d818de Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-11-03 18:45:55 +01:00
Eloy Lafuente (stronk7) c2da1ffea9 Merge branch 'wip-mdl-52007-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-11-03 18:00:50 +01:00
Eloy Lafuente (stronk7) 7f50bc1d2f Merge branch 'wip-mdl-52020-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-11-03 18:00:50 +01:00
Dan Poltawski 12f93caf45 Merge branch 'MDL-52018-28-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-11-03 18:00:49 +01:00
AMOS bot 170bb2e118 Automatically generated installer lang files 2015-11-04 00:04:42 +08:00
Dan Poltawski 56272bb56d MDL-45814 login: don't prompt guest user to change password 2015-11-03 14:49:43 +00:00
rajesh Taneja 3c5a90d52d MDL-52020 behat: Removed text checking to ensure window switch
Comment question window closes after 2 sec.
which crashes win-FF as it's slow to check for
"Changes saved" text. As after switching it is
checked the changes are saved, this step can be
avoided to ensure robustness of the scenario
2015-11-03 16:58:23 +08:00
rajesh Taneja fc3ef232d1 MDL-52007 behat: Use extended timeout for site admin expansion 2015-11-03 16:09:45 +08:00
David Mudrák b4ccb13855 MDL-52018 lang: Fix behat test to use the new string 2015-11-02 22:52:20 +01:00
Helen Foster 9e0a879c0a MDL-52018 lang: Merge English strings from the en_fix language pack 2015-11-02 22:48:28 +01:00
Eloy Lafuente (stronk7) ca2d074d95 Merge branch 'MDL-52014-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-11-02 20:02:32 +01:00
Marina Glancy 5a22246905 MDL-51999 user: remove unnecessary continue 2015-11-02 19:59:45 +01:00
Eloy Lafuente (stronk7) 262289493d Merge branch 'MDL-51829-28' of git://github.com/dpalou/moodle into MOODLE_28_STABLE 2015-11-02 19:40:59 +01:00
Dan Poltawski 1dcf6b339a MDL-52014 quiz: do not log preview attempt deletions
This happens automatically by the system.
2015-11-02 16:19:19 +00:00
Marina Glancy 6dce2f64b8 MDL-50633 dml: deprecated var replaced in mysql 5.7
Thanks to Charles Verge for providing a patch
2015-11-02 14:05:04 +00:00
Dan Poltawski 29f19e7e3e Merge branch 'MDL-51128-28' of git://github.com/junpataleta/moodle into MOODLE_28_STABLE 2015-11-02 10:54:54 +00:00
Damyon Wiese b43abbdccc MDL-52004 assign: Set unique urls when grading so autosaves work
The Atto autosave feature uses the $PAGE->url to generate unique hashes for
each page. Assignment uses a MUC cache to persist ordering of lists - the result
is that the urls are not unique (they depend on the cached filter).

The fix is to spoof a unique url that will grade only that student with no
active grading list (no next/prev buttons).
2015-11-02 16:46:41 +08:00
Andrew Nicols 1af0fa4d1c Merge branch 'MDL-51707-m28' of https://github.com/micaherne/moodle into MOODLE_28_STABLE 2015-11-02 14:51:49 +08:00
Jun Pataleta 1a5b8567c8 MDL-47073 lib: Replace backslashes with slashes in jquery plugin urls
This patch replaces backslash characters in the generated jQuery
plugin URL to forward slashes when slasharguments is disabled and
 the Moodle server is running on IIS.
Thanks to Ryan Panning <Ryan.Panning@district196.org> for
reporting this issue and for suggesting a fix.
2015-10-30 17:06:19 -05:00
Dan Poltawski c12979c7df weekly release 2.8.8+ 2015-10-30 21:08:41 +00:00
Andrew Nicols 1d8090a7a6 Merge branch 'wip-MDL-51552-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-10-30 11:03:42 +08:00
Dan Poltawski 318f7454e0 Merge branch 'MDL-51939-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-10-29 13:55:06 +00:00
Eloy Lafuente (stronk7) 2d0a9d0255 MDL-51939 mod_forum: all participants discussions are viewed by students
Added scenario to verify that "all participants" discussions, under
separate-groups mode are, by default, visible for students.
2015-10-29 21:07:44 +08:00
Dan Poltawski 15dc45e953 Merge branch 'MDL-50811-28' of git://github.com/cameron1729/moodle into MOODLE_28_STABLE 2015-10-29 10:53:44 +00:00
Dan Poltawski eb1e78be45 Merge branch 'MDL-51921-28' of git://github.com/junpataleta/moodle into MOODLE_28_STABLE 2015-10-29 10:35:41 +00:00
Adrian Greeve 9323277c03 MDL-51552 gradebook: Update to bulk update behat test. 2015-10-29 16:16:00 +08:00
Adrian Greeve 017c71cfcf MDL-51552 gradebook: Single view bulk insert fix.
Single view now doesn't overwrite non-empty grades.

A thank you to Sam Anderson and Robert Russo for providing a patch.
2015-10-29 16:16:00 +08:00
Ryan Wyllie c07b265f77 MDL-51799 javascript: dialogue accessibility
Moved setting the aria visiblity of the dialogues from the show
and hide functions into the visibility change handler to stop
multiple calls.

Also made the visibility checker just continue to buffer the elements
it hides, rather than clearning them, on multiple calls.
2015-10-29 05:41:59 +00:00
Jun Pataleta 4b573f4d42 MDL-51921 files: Fixes for file manager issues
Fixed the issue where the file path select box goes beyond the
container with very long folder names. Instead of setting to
"width: auto", I set it the select box's "width: 100%" so that it will
just fill up its container's width.
Fixed the issue where markups are being shown on file aliases.
2015-10-28 04:51:12 -05:00
Andrew Nicols ba7fcebb79 MDL-51939 mod_forum: Correct empty groupinfo check 2015-10-28 14:04:44 +08:00
Andrew Nicols 53378d63e2 weekly release 2.8.8+ 2015-10-28 12:57:35 +08:00
Eloy Lafuente (stronk7) 2ff58a3b05 MDL-51863 packer: ensure empty zip files behavior remains consistent
With PHP bug #70322 fixed, ZipArchive::close() did start returning false
and throwing PHP Warnings with recent PHP versions (5.6.14 and up).
Previously (5.6.13 verified) it was returning true, and false in older
versions (5.4.x verified).

This change does silent the 2 "hacky" calls to close() that we perform
in core leaving the 3rd one (used for files having files) unmodified.

A new unit test has been created to cover the close() behavior, ideally
supporting both old and new PHP versions without harcoding any PHP
version.

Note that we don't use to rely much on results coming from close(), and
that's a good thing given the buggy behavior commented above. This just
keeps empty zips working like they were before.
2015-10-27 11:57:00 +00:00
Corey Wallis 7fa0d47cda MDL-50811 mod_forum: Add completion tracking for emailed replies 2015-10-27 15:55:29 +08:00
Andrew Nicols 6f3a4fb5c3 Merge branch 'MDL-51864-28' of git://github.com/junpataleta/moodle into MOODLE_28_STABLE 2015-10-27 10:58:47 +08:00
Kevin Wiliarty 5daffb32f3 MDL-51834 auth,profile: locks custom fields based on auth settings 2015-10-26 14:24:06 +00:00
Dan Poltawski 3561600a37 Merge branch 'MDL-51894-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-10-26 12:40:31 +00:00
Andrew Nicols d784ad13e8 MDL-51894 inboundmessage: Ensure that all mailboxes exist 2015-10-26 12:31:20 +08:00
Andrew Nicols a6cb45542d Merge branch 'MDL-51779_28' of https://github.com/Syxton/moodle into MOODLE_28_STABLE 2015-10-26 09:54:20 +08:00
Jun Pataleta c4350c40f5 MDL-51864 blocks: Fixed title display for block_course_summary 2015-10-24 00:04:42 -05:00
Matt Davidson cbb94a638e MDL-51779 assign: PDF annotate quality
Fixes the quality of pdf content when annotating.
2015-10-23 09:31:20 -04:00
Dan Poltawski 7eb88da0af weekly release 2.8.8+ 2015-10-23 12:51:47 +01:00
Andrew Nicols 5631e50ced Merge branch 'MDL-51822_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-10-22 13:22:24 +08:00
Dan Poltawski 23eb923bcc weekly release 2.8.8+ 2015-10-20 09:56:35 +01:00
Dani Palou 80bea94ffe MDL-51829 admin: Set userquota setting as PARAM_INT 2015-10-20 10:02:52 +02:00
Mark Nelson 1430b4dc8f MDL-51782 mod_forum: fixed unit test failing on certain DBs 2015-10-20 14:46:09 +08:00
Andrew Nicols 388efc9233 Merge branch 'MDL-51782_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-10-20 11:53:00 +08:00
Mark Nelson 9383deb075 MDL-51782 mod_forum: altered unit tests for the post_deleted event
This was done to ensure we are actually testing the API, and not
just creating and triggering the event manually.
2015-10-19 20:14:05 -07:00
Mark Nelson 102ffb8e18 MDL-51782 mod_forum: moved post_deleted event into function 2015-10-19 20:14:04 -07:00
Eloy Lafuente (stronk7) 6cf4677e78 Merge branch 'wip-mdl-48117-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-10-19 16:58:59 +02:00
Dan Poltawski e5ec55cbdd Merge branch 'm28_MDL-51554_Apache_PHP-FPM_Broken_File_Serving' of https://github.com/scara/moodle into MOODLE_28_STABLE 2015-10-19 15:19:38 +01:00
David Monllao 4ae6340719 Merge branch 'MDL-50483-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-10-19 17:06:59 +08:00
Eloy Lafuente (stronk7) 140bd7b3ca MDL-48117 behat: Use form field to check checkbox
On Mac-Chrome click checkbox is not generating
proper events and hence failing. Use behat_form_checkbox
to ensure checkbox is checked
2015-10-19 16:59:57 +08:00
David Monllao 1b851d1b1f Merge branch 'MDL-51771_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-10-19 16:28:17 +08:00
David Monllao 99482eb0bc MDL-51822 timezones: Update to IANA 2015g 2015-10-19 15:00:25 +08:00
Andrew Nicols 2ed5192a84 Merge branch 'MDL-51673-28' of git://github.com/junpataleta/moodle into MOODLE_28_STABLE 2015-10-19 13:50:31 +08:00
Andrew Nicols e1f8a35f27 Merge branch 'MDL-51772-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-10-19 13:35:34 +08:00
David Monllao 03f0dec4a4 Merge branch 'MDL-51759-28-2' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-10-19 13:31:17 +08:00
Simey Lameze 2ecb8fdea7 MDL-50483 gradereport_user: fix the fatal error of no enrolled users 2015-10-19 09:16:29 +08:00
Jinu Abraham 200522e7c6 MDL-50483 gradereport_user: fix the fatal error of no enrolled users 2015-10-19 09:15:50 +08:00
Andrew Nicols 131679eddc Merge branch 'MDL-50412-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-10-19 08:05:21 +08:00
Tim Hunt fb33a080dc MDL-51771 question engine: fix typo in SQL
Thanks to Pete at learningpool.com for finding thsi bug.
2015-10-18 16:05:41 +01:00
Jun Pataleta 61ba945d8d MDL-51673 messages: Added codes for the unit tests 2015-10-16 16:07:11 -05:00
Ben Kelada 0429a76370 MDL-51673 messages: remove strict type check of int vs string 2015-10-16 16:07:10 -05:00
Matteo Scaramuccia 0f0f997e61 MDL-51554 Files: Fix broken file serving under Apache + PHP-FPM 2015-10-16 22:06:51 +02:00
Eloy Lafuente (stronk7) e82ed9333b weekly release 2.8.8+ 2015-10-16 12:51:20 +02:00
Andrew Nicols 52b58e7cea Merge branch 'MDL-51565-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-10-16 09:37:15 +08:00
Andrew Nicols dff755c3e2 Merge branch 'MDL-51651-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-10-16 09:27:16 +08:00
Andrew Nicols 70f315edbc Merge branch 'MDL-50182_28' of git://github.com/stronk7/moodle into MOODLE_28_STABLE 2015-10-16 08:14:46 +08:00
Andrew Nicols d1bffa672f MDL-51759 theme: Ensure that non-svg images are cached and returned 2015-10-16 07:53:59 +08:00
Dan Poltawski 764057b0c3 Merge branch 'MDL-51703-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-10-15 13:58:20 +01:00
Dan Poltawski 2aea111faa Merge branch 'MDL-51500-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-10-15 13:52:48 +01:00
Dan Poltawski db4c084a63 Merge branch 'MDL-51563-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-10-15 13:50:13 +01:00
Dan Poltawski ec7af5aa0e Merge branch 'MDL-51652-m28' of https://github.com/sammarshallou/moodle into MOODLE_28_STABLE 2015-10-15 13:46:14 +01:00
Dan Poltawski 60e3abff94 Merge branch 'MOODLE_28_STABLE-MDL-51679-groupmode-ajax' of https://github.com/Dagefoerde/moodle into MOODLE_28_STABLE 2015-10-15 11:44:50 +01:00
Dan Poltawski 5e90e70643 MDL-51651 lang: add consitency for application of firstdayofweek
1) Set the site-wide default based on language pack
2) Use the site/user preference for js popups, like we do in /calendar/
2015-10-15 10:17:20 +01:00
Dan Poltawski 62897237f7 MDL-51651 lang: the first day of the week is Monday 2015-10-15 10:17:19 +01:00
Dan Poltawski d55e3b1fc5 Merge branch 'wip-mdl-50940-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-10-15 08:57:52 +01:00
Andrew Nicols a6e1c0afa7 Merge branch 'MDL-51756-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE 2015-10-15 15:25:24 +08:00
Andrew Nicols 9a9bfb41e2 MDL-51756 tests: Refactor test to use data-provider
The benefit is that this becomes one test per external function instead of one
test testing them all - so more information is shown on failure and we get lots
more dots (we love dots!).
2015-10-15 15:19:05 +08:00
Damyon Wiese 19ab1865e3 MDL-51756 externallib: Show debugging when optional params are wrong
Optional params are not allowed as the top level value for external_function_parameters.
This is because stricter protocols (xmlrpc and soap) cannot handle optional parameters, only
optional properties in a structure.
2015-10-15 14:20:25 +08:00
Ryan Wyllie d058095357 MDL-49545 backup: Restore does not respect some capabilities
Thanks to Daniel Neis for the original patch that formed the
basis of these changes.
2015-10-15 11:55:47 +08:00
Dan Poltawski f7393e447c Merge branch 'MDL-51399_28' of https://github.com/andrewhancox/moodle into MOODLE_28_STABLE 2015-10-14 15:02:47 +01:00
Dan Poltawski ae4e4e11ff Merge branch 'MDL-51467-m28' of https://github.com/sammarshallou/moodle into MOODLE_28_STABLE 2015-10-14 13:41:03 +01:00
Jan C. Dageförde 0da8db7426 MDL-51679 course: Update groupmode CSS class
Changing groupmode of an activity via AJAX did not change the button's CSS class accordingly.
2015-10-14 14:35:47 +02:00
Juan Leyva 2b6e9e40dc MDL-51772 webservice: Export add_user_private_files as Web Service 2015-10-14 14:09:14 +02:00
Dan Poltawski 5f21490c11 weekly release 2.8.8+ 2015-10-14 10:49:05 +01:00
Dan Poltawski 2148eb566c NOBUG: Fixed SVG browser compatibility 2015-10-14 10:49:04 +01:00
Dan Poltawski 2b18ca5e3f Merge branch 'MDL-40710-28' of git://github.com/barbararamiro/moodle into MOODLE_28_STABLE 2015-10-13 15:35:28 +01:00
Dan Poltawski 45d6ea0832 Merge branch 'MDL-51435-m28' of https://github.com/NeillM/moodle into MOODLE_28_STABLE 2015-10-13 11:43:52 +01:00
Dan Poltawski a8f9db70c6 MDL-47494 grade: even more complete copyright fix.
With thanks to Tim!
2015-10-13 09:55:18 +01:00
Dan Poltawski a7f765a7a9 MDL-47494 grade: fix incorrect copyright statement
(From copy/paste error, blame Tim :P)
2015-10-13 09:39:17 +01:00
Damyon Wiese 206e677358 MDL-48861 assign: Make the requires grading filter consistent
Consistently include submissions with a null grade (see MDL-47694).
2015-10-13 14:54:47 +08:00
Damyon Wiese 2d4cf584ca MDL-48861 assign: Fix unit tests and behat tests
The tests were not working with the change to the needs grading filter.
2015-10-13 13:06:48 +08:00
Andrew Nicols f58afe07e0 Merge branch 'MDL-51302-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-10-13 11:35:38 +08:00
Jun Pataleta c07f0799ed MDL-51128 course: Add startdate for generated course
Added course start date for the course generated by the course
generator in order to prevent incorrect date calculations
(i.e. in assignment due dates) when the generated course is reset.
2015-10-12 22:12:13 -05:00
Andrew Nicols 7914b0a2cf Merge branch 'MDL-51427-28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-10-13 10:15:35 +08:00
Andrew Nicols 1cf1b279da Merge branch 'MDL-40442-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-10-13 09:49:14 +08:00
Andrew Nicols 182a393e06 Merge branch 'MDL-50079-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-10-13 09:33:38 +08:00
Andrew Nicols ee8072e2a1 Merge branch 'MDL-50788-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-10-13 08:54:42 +08:00
Eloy Lafuente (stronk7) bf0e51d1a1 MDL-50182 core: add 3.0 environmental requirements
Only change from 2.9 is the modification of the slasharguments
admin setting string to recommend always to keep the setting enabled
and fix the problem in the server, warning about the drawbacks
of disabling it.

Also, there is a little phpdoc note added to one custom check
to have clearly specified when we can get rid of it.
2015-10-13 00:35:55 +02:00
sam marshall 378f34a469 MDL-51467 Availability: Course reset should change restrict dates 2015-10-12 17:36:00 +01:00
Dan Poltawski 2c9c7b1130 Merge branch 'MDL-51375_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-10-12 17:01:44 +01:00
Dan Poltawski a78d3fa10b Merge branch 'MDL-48861-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE 2015-10-12 16:53:21 +01:00
Juan Leyva 43654c4872 MDL-51563 core_user: Fix invalid passed parameteres in get_user 2015-10-12 13:54:27 +02:00
Dan Poltawski 989298d309 Merge branch 'MDL-36606-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-10-12 12:41:30 +01:00
Juan Leyva 8eb8681b5e MDL-51565 webservice: Fix return types definitions 2015-10-12 13:30:17 +02:00
Dan Poltawski 025b4cb5e9 Merge branch 'MDL-51586-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-10-12 10:47:17 +01:00
sam marshall 0273933079 MDL-51652 Availability: OR conditions fail when filtering user lists
When filtering a user list, if there is an OR tree where one of the
conditions does not restrict user lists such as a date condition,
then the overall result should include all users (not be filtered).
This was not working correctly.
2015-10-12 10:26:48 +01:00
David Monllao 28e4326cf1 Merge branch 'MDL-51083-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-10-12 16:58:13 +08:00
Andrew Nicols fb48641b5f MDL-46497 atto: Whitespace/coding style fix 2015-10-12 13:44:18 +08:00
Andrew Nicols 907093e131 Merge branch 'MDL-46497_M28' of https://github.com/nadavkav/moodle into MOODLE_28_STABLE 2015-10-12 13:43:33 +08:00
Andrew Nicols ce4c237787 Merge branch 'MDL-51451-m28' of https://github.com/sammarshallou/moodle into MOODLE_28_STABLE 2015-10-12 10:15:31 +08:00
Lior Gil 284ef7be8f MDL-46497 Atto: Fix adding redundant p elements in rtl/ltr actions 2015-10-10 01:34:07 +03:00
Juan Leyva cc595febe4 MDL-51703 mod_survey: Trigger response_submitted event in correct place 2015-10-09 16:27:20 +02:00
Dan Poltawski 6ff47714ac MDL-50412 admin: prevent fatal errors on reports admin page 2015-10-09 14:47:39 +01:00
Barbara Ramiro c3ece30f18 MDL-40710 Icon: More identifiable backpack icon 2015-10-09 18:40:19 +08:00
Dan Poltawski 1670fc84a7 MDL-50079 atto_link: respect new window option when creating from repo
Previously users had to go back and edit their link to set the new
window option.
2015-10-09 11:29:27 +01:00
Dani Palou b961b1c142 MDL-51685 user: Support gravatar images in user_get_user_details 2015-10-09 11:51:19 +02:00
Dan Poltawski d6e6b308c5 MDL-50788 classloader: Prevent cryptic errors on unreadable classes dir
Do not attempt to read an unreadable directory because previously the generated
errors were hard to fathom.

Thanks to James McQuillan for the basis of the patch.
2015-10-09 10:37:32 +01:00
Dan Poltawski 66ce9e9f1c MDL-51302 scorm: do not use invalid course urls
Previous behaviour of setting an empty sectionid was incorrect and we
were doing work which course_get_url() does for us.
2015-10-09 09:09:37 +01:00
Neill Magill c21fca27fd MDL-51435 Web Services: E_WARNING in core_webservice_get_site_info
$plugin was not being set before the version file was included.
This caused an E_WARNING: Creating default object from empty value

This change creates the plugin object before the version file sets its parameters.
2015-10-09 09:06:53 +01:00
John Okely 9b132c5b23 MDL-51586 enrol: Enrolment table displays fullname properly.
When the alternatefullnamedisplay was set to something that
didn't contain 'firstname' then nothing would be displayed
for the user's name.
2015-10-09 15:35:23 +08:00
Damyon Wiese 16ef0ac033 MDL-48861 mod_assign: use >= for requires grading filter
If the grade and submission were modified at exactly the same time,
assume that this means the grade was automatically created for the submission
and is not a real grade from a teacher interaction.
2015-10-09 15:10:46 +08:00
Mifsud Gaël f1afb82337 MDL-51083 admin: Prevent password autofill in authentication settings 2015-10-09 14:34:02 +08:00
Michael Aherne 545163440b MDL-51707 cron: Prevent finished tasks being returned 2015-10-08 16:44:08 +01:00
Eric Merrill 5c66e986ee MDL-36606 gradereport: Update AJAX grader to understand gradeless cells 2015-10-08 10:51:04 -04:00
Barbara Ramiro e4f2fb2665 MDL-40442 Icon: Improved svg download icon and png version 2015-10-08 13:31:46 +01:00
Dan Poltawski 6d8dbfee53 weekly release 2.8.8+ 2015-10-08 11:36:41 +01:00
Adam Olley 41c8edf46d MDL-51285 mod_forum: Posts all need to have different stamps 2015-10-08 12:23:31 +08:00
Eric Merrill 287e6a9772 MDL-51500 navigation: Compute links with destination context
We should calculate the links based on the destination context,
not the current course. Could show links that are not accessible.
2015-10-07 10:03:13 -04:00
sam marshall 735ef8ba92 MDL-51451 Moodle dialogues: Lock scroll causes background jump
When you add a module or otherwise cause a Moodle dialogue to appear, this
enables the 'lock scroll' feature (the scrollbar disappears).

On some browsers this causes the width of the viewport to change, which can
cause centered/right-aligned theme elements to move distractingly.

This change temporarily sets body max-width while lock scroll is active.
2015-10-07 10:32:59 +01:00
David Monllao a112d4ebfb Merge branch 'wip-mdl-51285-m28' of git://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-10-07 11:23:32 +08:00
Andrew Nicols 797ac16e88 Merge branch 'MDL-41042-28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-10-07 10:27:47 +08:00
David Monllao 1ce643eaad Merge branch 'MDL-51525-28' of git://github.com/ryanwyllie/moodle into MOODLE_28_STABLE 2015-10-07 09:23:24 +08:00
Dan Poltawski 936d11f137 Merge branch 'MDL-51588-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-10-06 11:42:58 +01:00
David Monllao c4dc0748a4 Merge branch 'MDL-51656_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-10-06 15:25:15 +08:00
Andrew Nicols cee7167b07 Merge branch 'MDL-51228-m28-master' of https://github.com/dthies/moodle into MOODLE_28_STABLE 2015-10-06 13:49:36 +08:00
Tim Hunt e8da65449a MDL-51375 excel output: more work to avoid invalid sheet names 2015-10-06 05:45:16 +01:00
Andrew Nicols 77712faa11 Merge branch 'MDL-44707-28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-10-06 11:36:30 +08:00
Andrew Nicols 71175baff9 Merge branch 'MDL-50805_MOODLE_28_STABLE' of https://github.com/crazyserver/moodle into MOODLE_28_STABLE 2015-10-06 10:36:32 +08:00
David Monllao 6641b6fb8a Merge branch 'MOODLE_28_STABLE-MDL-49750' of git://github.com/jojoob/moodle into MOODLE_28_STABLE 2015-10-06 09:30:04 +08:00
Dan Poltawski 4fbad85763 Merge branch 'wip-MDL-49189-MOODLE_28_STABLE' of https://github.com/kwiliarty/moodle into MOODLE_28_STABLE 2015-10-05 15:03:18 +01:00
Johannes Burk e33152d912 MDL-49750 mod_data: fix updating file/picture fields breaks references
Use file_save_draft_area_files on file/picture update and
set content to null if file was removed.
2015-10-05 11:45:18 +02:00
David Monllao 758b2d9b29 Merge branch 'MDL-51514_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-10-05 16:00:12 +08:00
rajesh Taneja b5b3a37049 MDL-50940 behat: Added support for field matching with xpath 2015-10-05 14:04:02 +08:00
David Monllao 06cb6e421b Merge branch 'MDL-51408-28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-10-05 13:50:34 +08:00
Andrew Hancox 08544e3bdb MDL-50940 behat: Added ability to check field value by xpath 2015-10-05 13:47:04 +08:00
David Monllao 192509762b MDL-50613 webservices: Upgrade info about riskbitmask 2015-10-05 12:19:07 +08:00
David Monllao f2ac95dfdf Merge branch 'MDL-50613-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-10-05 12:13:14 +08:00
Sam Chaffee f0d7264769 MDL-51514 gradebook: Optimize set_usedinaggregation query for MySQL 2015-10-04 13:20:47 -07:00
Kevin Wiliarty 36d44b206a MDL-49189 auth: Map data to profile fields with uppercase shortnames 2015-10-03 08:25:06 -04:00
Mark Nelson 2bec647d91 MDL-51656 auth_radius: fixed colon location 2015-10-02 16:35:41 -07:00
Dan Poltawski dc3850fc20 weekly release 2.8.8+ 2015-10-02 10:57:33 +01:00
Dan Poltawski 35f4f19770 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-10-02 10:57:31 +01:00
Pau Ferrer Ocaña 3262330d95 MDL-50805 Messages: Add index to message_read to speed up message crons 2015-10-01 10:37:16 +02:00
David Monllao 00f1a102ca MDL-46710 mod_lti: Removing duplicated generated events
Event generation and completion should be generated only once.
2015-10-01 12:07:07 +08:00
Eloy Lafuente (stronk7) 474b1e0040 Merge branch 'MDL-51227-m28-master' of https://github.com/dthies/moodle into MOODLE_28_STABLE 2015-10-01 00:35:25 +02:00
Andrew Robert Nicols 68dcf2dded MDL-36606 gradereport: Correctly handle ungraded assessment ajax grading 2015-09-30 15:04:12 -04:00
Eloy Lafuente (stronk7) 9194f5911b Merge branch 'wip-mdl-51266-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-09-30 20:34:59 +02:00
Andrew Hancox 4143c33d27 MDL-51399 report_outline: Hide blog column if blogs are disabled. 2015-09-30 17:04:59 +01:00
Juan Leyva ccefec7360 MDL-50613 webservice: Remove risk bit masks for Web Service protocols
This will prevent to show a 'Critical' status in security overview
report when mobile services are enabled
2015-09-30 11:18:01 +02:00
Tim Lock b68783c870 MDL-51440 gradeimport_direct: fix config require statement 2015-09-30 10:53:51 +08:00
Eloy Lafuente (stronk7) 9c46e281cb Merge branch 'MDL-49143-28' of git://github.com/cameron1729/moodle into MOODLE_28_STABLE
Note: Added small fix to unit test.
2015-09-30 03:21:07 +02:00
Dan Poltawski 773582db11 Merge branch 'MDL-51402_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-09-29 20:54:44 +01:00
Dan Poltawski 964c02c3fe Merge branch 'MDL-51424-m28-master' of https://github.com/dthies/moodle into MOODLE_28_STABLE 2015-09-29 20:33:30 +01:00
Dan Poltawski 868fb3adf9 Merge branch 'MDL-42639_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-09-29 10:20:15 +01:00
David Monllao 0b54d6d971 MDL-42639 user: user:viewalldetails enough to view some fields
The fields are:
- username
- idnumber
- institution
- department
2015-09-29 16:56:26 +08:00
Ryan Wyllie a6bd6b3cad MDL-51525 libraries: added graphlib to thirdpartylibs.xml 2015-09-29 07:32:57 +00:00
Frederic Massart 46067fbd30 MDL-51588 webservice: Allow CORS in webservice/pluginfile.php 2015-09-29 14:41:28 +08:00
Andrew Nicols acd86d0cf2 Merge branch 'MDL-43594-28' of git://github.com/junpataleta/moodle into MOODLE_28_STABLE 2015-09-29 14:01:33 +08:00
Jun Pataleta 365644eecf MDL-43594 mod_assign: Fix calendar update on course reset
This patch fixes the updating of calendar events when the course
is reset and its start date is changed.
2015-09-29 13:47:06 +08:00
Andrew Nicols 51d6415ef3 Merge branch 'MDL-35918-28' of git://github.com/ryanwyllie/moodle into MOODLE_28_STABLE 2015-09-29 13:43:32 +08:00
Eloy Lafuente (stronk7) c022a86c38 MDL-49143 LTI: Test resource_link_id in lti_build_request() 2015-09-29 13:42:43 +08:00
Cameron Ball fa3652ef9c MDL-49143 LTI: Fix missing resource id 2015-09-29 13:42:43 +08:00
Ryan Wyllie 08db4b5843 MDL-35918 javascript: dialogues screen reader support
The YUI notification dialogues will now set the appropriate
aria attributes when they are shown/hidden to allow screen
readers to navigate them correctly.

When the dialogue is shown all background elements will be marked
as hidden while the dialogue is marked as visible to a screen reader.

When the dialogue is closed the modified elements will be reverted
to their previous state and the dialogue will be marked as hidden to
a screen reader.
2015-09-29 04:53:23 +00:00
Andrew Nicols 3497350e2f Merge branch 'wip-MDL-51241-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-09-29 12:47:20 +08:00
Andrew Nicols 396f954b05 Merge branch 'MDL-51476_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-09-29 12:07:25 +08:00
Dan Poltawski 997e7a966b Merge branch 'MDL-51305_28_too_many_gradeitem_fetches' of https://github.com/colin-umn/moodle into MOODLE_28_STABLE 2015-09-28 16:25:57 +01:00
Dan Poltawski 94249aa198 Merge branch 'mdl46710-moodle28' of https://github.com/tlock/moodle into MOODLE_28_STABLE 2015-09-28 14:56:58 +01:00
Dan Poltawski 1916b2863c Merge branch 'MDL-51390_28' of https://github.com/totara/openbadges into MOODLE_28_STABLE 2015-09-28 13:27:17 +01:00
Mark Nielsen 0c2ddb687a MDL-51498 core_grades: Prevent unnecessary grade record fetching
All of these changes make use of already
fetched grade data.  Without these changes,
the gradebook regrade process does not scale
well with very large courses because it fetches
many grade records, one at a time.
2015-09-28 11:12:59 +01:00
Dan Poltawski 8ae33bc947 Merge branch 'MDL-49482-28' of https://github.com/blckct/moodle into MOODLE_28_STABLE 2015-09-28 10:31:50 +01:00
Yuliya Bozhko 8589530727 MDL-51390 badges: Switch backpack URL to use HTTPS
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
2015-09-28 10:08:00 +01:00
AMOS bot b9e92d05e1 Automatically generated installer lang files 2015-09-28 00:04:12 +08:00
Daniel Thies 45e591a85a MDL-51424 editor_atto: Save selection and editor contents after change
Conflicts:
	lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor-min.js
2015-09-25 09:50:06 -05:00
Daniel Thies a59f24b904 MDL-51227 editor_atto: Stop Chrome losing selection when formating
Conflicts:
	lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor-min.js
2015-09-25 09:38:48 -05:00
Tim Hunt 58d7de73ac MDL-51476 questions: manual grading validation for ungraded Qs
The change in MDL-51090 broke manually commenting on questions for which
no mark is given (max mark == 0). This fixes it, with unit tests.

Thanks to Nick Phillips for the original suggestion of the fix.
2015-09-25 14:02:32 +01:00
Tim Lock e87c74e9f5 MDL-46710 mod_lti: fix logging and completion tracking in new windows 2015-09-25 06:28:28 +09:30
Eloy Lafuente (stronk7) d8edd556ab MDL-49482 sqlsrv: Implement support of Offset/Fetch in SQL Server 2012+ 2015-09-24 20:13:17 +02:00
Jakub Kania 68629452fa MDL-49482 mssql: Implement support of Offset/Fetch in SQL Server 2012+. 2015-09-24 20:13:17 +02:00
Eloy Lafuente (stronk7) 3377cbc3ba weekly release 2.8.8+ 2015-09-24 16:07:14 +02:00
rajesh Taneja 07f3c02ec7 MDL-49973 behat: Fixed string change from Continue to Delete 2015-09-24 10:35:37 +08:00
Eloy Lafuente (stronk7) 837c4dab86 Merge branch 'wip-MDL-51259-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-09-23 16:29:06 +02:00
rajesh Taneja 551dce86ba MDL-51266 unittest: replaced low level phpunit_util calls 2015-09-23 15:44:57 +08:00
David Monllao f7666835c7 MDL-50332 enrol_self: Setting form url for guests
Credit to Andrew Nicols.
2015-09-23 11:53:12 +08:00
Adrian Greeve f9dfe738aa MDL-51241 cohorts: Update to cohort query.
This improves the speed of returning a list of
cohorts. Thanks to François Gannaz for providing
this patch.
2015-09-23 11:38:46 +08:00
Dan Poltawski 3bf8439e3a Merge branch 'MDL-49973-28' of git://github.com/cameron1729/moodle into MOODLE_28_STABLE 2015-09-22 09:44:46 +01:00
Dan Poltawski c6a6ce7914 Merge branch 'MDL-46157-28' of git://github.com/cameron1729/moodle into MOODLE_28_STABLE 2015-09-22 08:15:02 +01:00
Andrew Nicols 599eeea2a5 Merge branch 'MDL-51190-28' of https://github.com/pauln/moodle into MOODLE_28_STABLE 2015-09-22 08:32:18 +08:00
Ferenc Lengyel bfd6727b42 MDL-51402 quiz: notification emails should respect grouping
In the case where teachers do not have the accessallgroups capability,
we only send "an attempt has been sumbitted "notification to teachers
in the same group as the student who submitted.

At the moment this considers all groups in the course. If this
particular quiz has a grouping set, then the logic should only consider
the groups in that grouping.
2015-09-21 13:31:15 +01:00
Dan Poltawski 606cf274a7 Merge branch 'MDL-51052_28' of https://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-09-21 10:53:30 +01:00
Dan Poltawski 0dbd2594e8 Merge branch 'MDL-48165-28-dimgrades' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-09-21 10:14:50 +01:00
Andrew Nicols 0c73e5335c Merge branch 'MDL-50332_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-09-21 15:47:07 +08:00
David Monllao 18fd195086 MDL-50332 enrol_self: Formatting unavailable instances error messages
Many thanks to Andrew Nicols as this patch is based on his
proposal. Thanks Andrew.
2015-09-21 15:44:29 +08:00
Andrew Nicols 05c252e9b0 Merge branch 'MDL-51431_2_8' of https://github.com/andrewhancox/moodle into MOODLE_28_STABLE 2015-09-21 08:13:10 +08:00
David Monllao a23c44cddf MDL-51052 dml: More info about mysql and case & accent sensitiveness 2015-09-18 11:49:26 +08:00
Charles Fulton f8e0b4ece1 MDL-51052 dml: support for sql_like() under utf8_bin 2015-09-18 11:49:25 +08:00
Adrian Greeve 76ebf76be1 MDL-51259 mod_data: ratings of items not activated.
When selecting a rating method, the restrict rating
to items with dates would be automatically enabled if
not checked. This code brings the data module inline
with forum and glossary.
2015-09-18 07:28:56 +08:00
Eloy Lafuente (stronk7) a91caeefc7 weekly release 2.8.8+ 2015-09-17 18:01:22 +02:00
Simey Lameze e1efcbd1db MDL-50959 gradebook: fix XML grade export 2015-09-17 10:37:09 +08:00
Andrew Hancox 210349f647 MDL-51431 enrol_flatfile: Fix for startdate when updating users 2015-09-16 10:56:55 +01:00
Marina Glancy 193f5d4029 MDL-46705 admin: Validate unique shortname for frontpage course 2015-09-16 14:48:03 +08:00
Marina Glancy 489db61206 MDL-51427 user: correctly use strings for phone1 and phone2
Thanks to Olumuyiwa Taiwo for original patch
2015-09-16 13:36:54 +08:00
David Monllao 685aa0b7c9 Merge branch 'MDL-49561_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE
Conflicts:
	lib/bennu/readme_moodle.txt
2015-09-16 09:59:04 +08:00
David Monllao 57caaace44 Merge branch 'MDL-46705-28' of git://github.com/dkns/moodle into MOODLE_28_STABLE 2015-09-16 09:46:13 +08:00
Eloy Lafuente (stronk7) 42ba6f011e Merge branch 'MDL-50685_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-09-16 02:16:38 +02:00
Eloy Lafuente (stronk7) 8ada99201a Merge branch 'MDL-49032_28' of https://github.com/stronk7/moodle into MOODLE_28_STABLE 2015-09-16 00:58:56 +02:00
Eloy Lafuente (stronk7) 2fab7166b5 MDL-49032 lib/bennu: update readme to document the change 2015-09-16 00:54:15 +02:00
Joby Harding f27c022e5c MDL-49032 lib/bennu: use HTAB only when folding lines 2015-09-16 00:45:38 +02:00
Eloy Lafuente (stronk7) 16eedce0c6 Merge branch 'MDL-50959-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-09-15 23:36:31 +02:00
Eloy Lafuente (stronk7) 5d4bccd775 Merge branch 'MDL-50892-28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-09-15 23:35:23 +02:00
David Monllao 2648522e3d Merge branch 'MDL-50884-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-09-15 17:16:30 +08:00
Cameron Ball e13126f85a MDL-49973 behat: Update delete button names
Conflicts:
	course/format/topics/tests/behat/edit_delete_sections.feature
	course/format/weeks/tests/behat/edit_delete_sections.feature
2015-09-15 15:39:32 +08:00
Andrew Davis 1237ba1962 MDL-49973 changed continue to delete on delete confirmations
Conflicts:
	course/editsection.php
2015-09-15 15:38:08 +08:00
David Monllao 3e08b5c04e Merge branch 'MDL-50921-28' of git://github.com/ryanwyllie/moodle into MOODLE_28_STABLE 2015-09-15 14:27:32 +08:00
David Monllao 978ef29e47 MDL-51048 backup: Removing unnecessary var 2015-09-15 13:44:36 +08:00
David Monllao 5c03acf518 Merge branch 'MDL-51048_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-09-15 13:44:32 +08:00
Andrew Nicols 8d5092cd84 Merge branch 'MDL-51290-28' of git://github.com/cameron1729/moodle into MOODLE_28_STABLE 2015-09-15 13:06:54 +08:00
Paul Nicholls add6322e5a MDL-51190 javascript: Make "maximised embed" compatible with MS Edge
MS Edge exhibits strange behaviour when M.util.init_maximised_embed hides
the embedded document by setting its width and height to 0px.  Toggling
display:none instead achieves the intended goal without breaking Edge.
2015-09-15 16:28:42 +12:00
David Monllao c87b932f1c Merge branch 'MDL-51008-28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-09-15 11:22:16 +08:00
Marina Glancy 78eb3ee407 MDL-51408 badges: fix criteria for custom profile fields 2015-09-15 11:17:42 +08:00
David Monllao 38e0d68f0a Merge branch 'MDL-51147_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-09-15 10:09:52 +08:00
David Monllao 6c974ef376 MDL-51363 mod_scorm: Removing whitespaces 2015-09-15 10:03:27 +08:00
David Monllao 17c975874f Merge branch 'm28_MDL-51363_Fix_Default_Settings_1x_Restore' of git://github.com/scara/moodle into MOODLE_28_STABLE 2015-09-15 10:02:19 +08:00
Eloy Lafuente (stronk7) 07d52ad818 Merge branch 'MDL-46239-28-2' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-09-15 01:03:08 +02:00
Matteo Scaramuccia 3f121ac514 MDL-51363 SCORM: fixed default settings on restoring 1.x backups 2015-09-15 00:01:33 +02:00
Cameron Ball eddc63f4e8 MDL-51290 user: Expand picture section in profile by default 2015-09-14 17:54:06 +08:00
David Monllao 3f72e79ee1 Merge branch 'wip-mdl-51101-m28' of git://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-09-14 16:18:55 +08:00
David Monllao 000be9c016 Merge branch 'MDL-51170-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-09-14 14:14:48 +08:00
David Monllao 8a6c5244c4 Merge branch 'MDL-51191-moodle28' of git://github.com/StudiUM/moodle into MOODLE_28_STABLE 2015-09-14 13:59:40 +08:00
David Monllao 5319119569 Merge branch 'MDL-51253_MOODLE_28' of git://github.com/BenKelada/moodle into MOODLE_28_STABLE 2015-09-14 13:09:18 +08:00
Ben Kelada 6dd7f1d452 MDL-51253 forum: fix urls for exceptions and redirects 2015-09-14 14:20:43 +10:00
Simey Lameze 59d26c45d9 MDL-50884 auth_shibboleth: fix logout handler url generation
This patch fixes the shibboleth redirect url generation, that can create invalid url
if the shibboleth logout_handler setting has a parameter generating two parameters
with (?) instead of (&).

Thanks to Matteo Boni for the proposed solution.
2015-09-14 09:52:20 +08:00
David Monllao 596950852c Merge branch 'MDL-51232_28' of git://github.com/jinuabraham/moodle into MOODLE_28_STABLE 2015-09-14 09:39:30 +08:00
Simey Lameze 6deeba6bcc MDL-50959 gradebook: fix XML grade publishing score 2015-09-14 09:05:49 +08:00
Daniel Thies 85cf55ebaf MDL-51228 atto_editor: Add documententation for inlineFormat flag 2015-09-13 14:26:56 -05:00
Eloy Lafuente (stronk7) e494078a27 Moodle release 2.8.8 2015-09-12 02:03:02 +02:00
Colin Campbell a03a01f2ad MDL-51305 grade: Fix slow grade operations by setting grade_item early.
Exports were fetching the grade item for every item-user combination.
Setting the grade_item object on the grade_item early prevents that.
2015-09-11 15:23:06 -05:00
Jean-Philippe Gaudreau 80764a301f MDL-51191 assign: Optimizing slow SQL query for MySQL 2015-09-11 11:12:24 -04:00
Jetha Chan 596e4603ae MDL-50685 core_form: disable hidden options, don't just hide 2015-09-11 15:09:29 +08:00
Marina Glancy 355e943c4b MDL-50892 mod: allow activity to have name '0' 2015-09-11 10:52:35 +08:00
Eloy Lafuente (stronk7) 36750a2872 weekly release 2.8.7+ 2015-09-10 11:09:59 +02:00
Eloy Lafuente (stronk7) 6c5f24d74d Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-09-10 11:09:53 +02:00
Rajesh Taneja 8102007398 MDL-51101 behat: Fixed wrong hover step usage 2015-09-10 14:56:24 +08:00
rajesh Taneja c67f4ad661 MDL-50516 behat: Back/next button reloads page
When next/back button is pressed in phantomjs/browserkit
it reload page, so adding a bug_phantomjs, so that we can
test the lesson re-attempt scenario
2015-09-10 14:52:40 +08:00
Tim Hunt d881f12cde MDL-51147 qtype_match: stats should cope even if Q edited badly
The numbers become pretty meaningless, but we need to avoid fatal
errors.
2015-09-09 16:48:39 +01:00
Andrew Nicols 447e1a755f Merge branch 'MDL-50852-28' of git://github.com/junpataleta/moodle into MOODLE_28_STABLE 2015-09-09 15:40:11 +08:00
Jun Pataleta c845d8e2e0 MDL-50852 formslib: Fixed client-side form validation problem.
This patch fixes the problem of client validation being broken when
shortforms is not enabled. This issue is caused by moodle-core-event
module not being loaded and the broadcast parameter in the
Y.Global.publish set to 2 instead of true.
2015-09-09 15:36:25 +08:00
Mark Nelson 63c2a82186 MDL-50516 mod_lesson: changes to existing behat tests 2015-09-09 15:31:13 +08:00
Mark Nelson be1f371d0d MDL-50516 mod_lesson: added behat tests 2015-09-09 15:31:13 +08:00
Mark Nelson 3a25aa92e1 MDL-50516 core_behat: added ability to go back, forward and reload the browser 2015-09-09 15:31:13 +08:00
Mark Nelson 39b50f7d3e MDL-50516 mod_lesson: fixed issue with grade not using minquestions
It's possible to reach the end of the lesson, get your result,
click back until you get to the last question, answer it correctly
and then be awarded a result of 100%. This was because the grade
calculation would only include the questions answered, rather than
all of them in the lesson. However, you can not fix this by always
grading by the amount of questions in the lesson as some lessons
bypass certain questions depending on the answer to previous ones.
The minquestion setting can now successfully be used to prevent this
behaviour by rewording the misleading string and adding logic.
2015-09-09 15:31:13 +08:00
Mark Nelson 9d5b339126 MDL-50516 mod_lesson: prevented deletion of previous attempts
The 'startlastseen' flag was removing any previous attempts
the user had from the DB. This meant that the user could
simply re-answer the question, regardless of the number
of attempts allowed.
2015-09-09 15:31:13 +08:00
Mark Nelson 67e3f70bb1 MDL-50516 mod_lesson: prevented user from repeating question
It was possible in the lesson module for a user to
answer a question, get the result, then click back
in the browser and re-answer it, even if they exceeded
the number of attempts allowed per question.
2015-09-09 15:31:12 +08:00
Eloy Lafuente (stronk7) 84cccb56a1 Merge branch 'wip-mdl-51322-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-09-09 08:25:31 +02:00
Ankit Agarwal 20ff15e22b MDL-50173 ratings: Use proper checks to ensure ratings are viewable.
Mainly to verify groups visibility this new callback has been created.

Note this was originally 2 commits but for amending purposes they have
been squashed.
2015-09-09 04:42:19 +02:00
Andrew Nicols a20bcf6598 Merge branch 'wip-MDL-34938-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-09-09 09:48:24 +08:00
John Okely a44fed5c80 MDL-50709 groups: Prevent XSS in grouping description 2015-09-08 12:50:02 +02:00
Dan Poltawski 0394cd902d Merge branch 'wip-MDL-50323-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-09-08 09:14:11 +01:00
Cameron Ball 7b027ea79c MDL-46157 drag and drop: Improve item labels
Ignore the edit menu when determining the region to drag.

Conflicts:
	lib/yui/build/moodle-core-dragdrop/moodle-core-dragdrop-min.js
2015-09-08 11:46:37 +08:00
Marina Glancy b40159e771 MDL-34938 enrol_meta: sync enrolment start/end dates 2015-09-08 10:26:08 +08:00
Andrew Nicols b77fbfbc5d Merge branch 'MDL-51245_28' of git://github.com/stronk7/moodle into MOODLE_28_STABLE 2015-09-08 10:24:43 +08:00
Marina Glancy adb65a80f9 MDL-51008 grades: show correct default value in overview report 2015-09-08 10:11:47 +08:00
Adrian Greeve 5b9d6e3e7a MDL-50323 themes: Course unordered lists correctly styled.
Thank you to Ann Adamcik for providing this patch.
2015-09-08 09:39:07 +08:00
Eloy Lafuente (stronk7) a813129dc5 MDL-51245 sqlsrv: Diagnose missing READ_COMMITTED_SNAPSHOT mode
Without it, transactions are executed in standard READ_COMMITED
mode, without snapshoting/row versioning, leading to update
conflicts under high concurrency.
2015-09-08 02:59:53 +02:00
Eloy Lafuente (stronk7) 0e5bcf0a0b MDL-51245 mssql: Diagnose missing READ_COMMITTED_SNAPSHOT mode
Without it, transactions are executed in standard READ_COMMITED
mode, without snapshoting/row versioning, leading to update conflicts
under high concurrency.
2015-09-08 02:59:50 +02:00
Petr Skoda 5337b22952 MDL-50860 core: improve creation of random strings 2015-09-08 01:09:13 +02:00
Tim Lock 7fb8fcfd9d MDL-42670 mod_assign: Fix recent activity block when blind marking is on 2015-09-07 22:44:38 +02:00
Corey Wallis f558ddcc4f MDL-51048 IMS-CC: Fix import & export of true/false questions 2015-09-07 16:06:00 +01:00
Marina Glancy f7fbc80766 MDL-50744 enrol_meta: fix incorrect role assign 2015-09-07 10:29:08 +01:00
Adrian Greeve 1d70050f33 MDL-48371 editors: Option for removing managefiles
We want to remove the managefiles button from the
editors in the wiki so that students don't delete
each others files.
2015-09-07 09:59:32 +01:00
rajesh Taneja 8b55f35808 MDL-51322 behat: ensure the window is properly closed
This is to ensure we have other window closed
so there is no race-around condition
2015-09-07 16:54:21 +08:00
Marina Glancy f19717481d MDL-50921 message: allow popup messages from noreply user
Thanks Gary Harris for the patch
2015-09-07 08:15:10 +00:00
John Okely 8f4379b3d5 MDL-46239 task: Improve error message when timezone does not exist
Credit to Mark Nielsen for initial patch.
2015-09-07 15:51:27 +08:00
Mark Nelson dbeeebc0f6 MDL-49561 core_lib: added info to bennu readme
Also did some minor tweaks to existing code.
2015-09-04 19:40:02 -07:00
Lars Anderson e4d7edbf4f MDL-49561 core_calendar: Fix ical export for events with no duration 2015-09-04 19:40:01 -07:00
Marina Glancy 0e0c8c0dd7 MDL-41042 coursecat: better handle changes in coursecontact 2015-09-04 11:54:33 +08:00
Damyon Wiese f44ac5d3bf MDL-48861 assign: Fix the "needs grading" filter
When auto-creating a new grade record - do not set the timemodified > than the submission timemodified
2015-09-04 11:07:06 +08:00
rajesh Taneja 9c5a63ef1f MDL-51321 behat: Fixed save button name 2015-09-04 09:10:23 +08:00
AMOS bot 5304b65e2b Automatically generated installer lang files 2015-09-04 00:04:13 +08:00
Dan Poltawski a332c3c4e8 weekly release 2.8.7+ 2015-09-03 12:31:54 +01:00
Dan Poltawski 7dae6eede4 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-09-03 12:31:52 +01:00
rajesh Taneja d0ac61f870 MDL-51090 behat: switch to main window 2015-09-03 10:26:58 +01:00
David Monllao 684e59ea5f Merge branch 'MDL-51179-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE
Conflicts:
	lib/upgrade.txt
2015-09-03 10:38:36 +02:00
Ryan Wyllie 0b9cf14980 MDL-49536 theme_clean: update help text for logo
Updated the help text on the theme settings page to
mention that the theme logo will only be displayed on
the front page and login page.
2015-09-03 10:37:58 +02:00
rajesh Taneja f3661a7ea8 MDL-51285 mod_forum: Discussion post should not have same time stamp
Discussion post are sorted by timemodified
if they have same timemodified then results
will be random
2015-09-03 15:34:33 +08:00
Tim Hunt b099c22b24 MDL-51090 question manual grading: fixing for testing issues 2015-09-02 15:09:55 +08:00
David Monllao 9a7fa2710a Merge branch 'MDL-51090_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-09-02 09:50:17 +08:00
David Monllao d772d11aa6 Merge branch 'MDL-50971-m28' of git://github.com/NeillM/moodle into MOODLE_28_STABLE 2015-09-02 09:40:16 +08:00
David Monllao 41f04955f4 Merge branch 'MDL-50920-2.8' of git://github.com/sk-unikent/moodle into MOODLE_28_STABLE 2015-09-02 08:45:14 +08:00
Eloy Lafuente (stronk7) f1b608bb5a Merge branch 'MDL-50641-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-09-02 01:53:41 +02:00
Tim Hunt 5c97a8dae4 MDL-51090 question: further refinements to validating manual grades 2015-09-01 23:10:18 +01:00
Nelson Moller df0c2e9578 MDL-51090: mod_quiz grading validation of an essay question
An invalid format is casted to 0 (if a string) or to some truncated value in other cases (ex: 10..5).
2015-09-01 23:09:23 +01:00
David Mudrák fa36f1d1ab MDL-48165 workshop: Validate the rubric editing form 2015-09-01 23:39:43 +02:00
David Mudrák 235d8a4196 MDL-48165 workshop: Add support for assessment forms validation 2015-09-01 23:39:41 +02:00
Dan Poltawski 2583cc53e4 MDL-50690 themes: fix commenting coding style
(See also CONTRIB-5891)
2015-09-01 21:12:39 +01:00
Dan Poltawski 6430d84b77 Merge branch 'wip_MDL-50690_m28' of git://github.com/gjb2048/moodle into MOODLE_28_STABLE 2015-09-01 20:59:59 +01:00
AMOS bot da81de59d0 Automatically generated installer lang files 2015-09-02 00:05:35 +08:00
Dan Poltawski da0950d2c5 Merge branch 'MDL-51236-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-09-01 15:34:03 +01:00
David Monllao 836b029252 Merge branch 'MDL-51234-M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE
Conflicts:
	theme/bootstrapbase/style/moodle.css
2015-09-01 18:35:09 +08:00
David Monllao 486456d66c Merge branch 'MDL-51109-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-09-01 18:31:58 +08:00
Dan Poltawski 56a1ac4d38 MDL-51109 task: more debug info for failed scheduled tasks 2015-09-01 11:00:46 +01:00
Dan Poltawski 6b6905b69f Merge branch 'MDL-45841_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-09-01 10:14:47 +01:00
David Monllao 963b373666 Merge branch 'wip-mdl-50963-m28' of git://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-09-01 16:06:37 +08:00
rajesh Taneja 12804263f4 MDL-50963 behat: fixed error string in behat 2015-09-01 14:49:10 +08:00
David Monllao 99a146b552 Merge branch 'MDL-50999-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-09-01 14:35:57 +08:00
Damyon Wiese 42e3e29791 MDL-51179 Atto: Extend autosave fix to cover text changes
Added new functions to editor api - set/get_text so the
original form text can be determined from an editor.

When calling use_editor() you should first call set_text() with
the text that will be inserted in the form element.

There is also a new scheduled task for cleaning Atto autosave drafts.
2015-09-01 13:37:27 +08:00
Damyon Wiese 31b84bd279 MDL-51179 Atto: Add a behat test for autosave 2015-09-01 13:36:30 +08:00
Damyon Wiese 8162eb2133 MDL-51179 Atto: When a resume is aborted - create a fresh draft for future saves. 2015-09-01 13:36:30 +08:00
Damyon Wiese b938b7a76a MDL-51179 Atto: Abort autosave if there are more recent changes to the files
If the files in the draft area have been modified more recently than the timestamp
of the draft - do not restore the files, or you will delete any newer files. We
cannot really guess here - merging the 2 lists of files will be wrong.
2015-09-01 13:36:30 +08:00
Marina Glancy b524b28633 MDL-50791 auth: add heading on signup form page 2015-09-01 02:02:27 +02:00
Marina Glancy b8faa63b7c MDL-50791 forms: make server validation errors accessible 2015-09-01 02:02:21 +02:00
Clement Smith 454882a4fa MDL-50963 lang/en/grades.php: Improve bad grade error message
The error message received when inputting a grade value that is too
low indicates that zero is a valid grade value. This is incorrect as
the lowest valid grade value is 1. This updates the error message to
indicate the minimum acceptable grade value is 1, not 0.
2015-09-01 01:46:05 +02:00
Eloy Lafuente (stronk7) ab5884d16d Merge branch 'MDL-49536-28' of git://github.com/ryanwyllie/moodle into MOODLE_28_STABLE 2015-08-31 20:48:36 +02:00
David Monllao 0448dbe7c1 Merge branch 'MDL-51131-28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-08-31 14:08:10 +08:00
David Monllao 15737f3df5 Merge branch 'MDL-51084-28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-08-31 12:53:59 +08:00
Michael Aherne 4750b1379f MDL-51181 config: Correct documentation of lock_factory 2015-08-31 10:55:44 +08:00
David Monllao 16134e337f Merge branch 'MDL-51215-28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-08-31 10:45:51 +08:00
Jinu Abraham 12259f01ce MDL-51232 mod_book: Filter name header 2015-08-31 12:06:29 +09:30
lazydaisy 7d8bf42081 MDL-51234 theme_bootstrapbase: hover hardly visible on invert/collapse 2015-08-30 20:13:03 +01:00
Kevin Wiliarty 5608e36d11 MDL-51229 theme: display docked block on top of fixed navbar 2015-08-30 09:44:23 -04:00
Neill Magill 70fb7ac4b3 MDL-50971 ActionMenu: Action menus cause page to jump when closing
This patch changes the behavior of open action menus when using a mouse.

Before this patch when clicking on the page with an open action menu the focus would be
returned to the action menu's call button. This could cause the page to jump when a
mouse user did not close an action menu, scrolled and then tried to perform another
action on the page.

After this patch when clicking the focus will not be returned to the action menu's call button.
The behavior of the script will not be changed when using the keyboard.
2015-08-28 12:16:46 +01:00
Marina Glancy e564027dcf MDL-51084 tool_customlang: return to the same page after submit 2015-08-28 16:20:51 +08:00
Marina Glancy 82c123c722 MDL-44707 block_html: copy files when copying instance 2015-08-28 16:04:27 +08:00
Dan Poltawski f66090899d weekly release 2.8.7+ 2015-08-28 07:38:11 +01:00
Andrew Nicols 2ccd546b62 MDL-51236 phpunit: Prevent testsuite name conflicts
The testsuite name is fed straight into a class_exists() in
PHPUnit_Framework_TestSuite. In some cases, e.g. cachestore_static, the
class does exist, it's then fed into a ReflectionClass, and the test fails.

The testsuite needs to not conflict with any classes which could be
autoloaded in Moodle core.
2015-08-28 14:27:04 +08:00
Ryan Wyllie d74ec94722 MDL-49536 theme_clean: logo only on front and login
The logo for the clean and more themes will only be
displayed on the front page and login page as it was
replacing the header information on other pages within
Moodle, causing users to lose information on the page.
2015-08-28 02:43:21 +00:00
Daniel Thies 981379ffc2 MDL-51228 editor_atto: Apply style in plugins if selection is collapsed 2015-08-27 12:33:01 -05:00
Gareth J Barnard 048444fd21 MDL-50690 themes: Theme cache SVG images are not created. 2015-08-27 15:40:03 +01:00
Dan Poltawski e9e81544e3 MDL-49826 grade: hide singleview links when no permissions
Singleview only supports grade editors not viewers at this time.
2015-08-27 13:17:43 +02:00
Eloy Lafuente (stronk7) 09890fcd8e Merge branch 'MDL-51148-28-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-08-27 13:00:45 +02:00
Marina Glancy c34a1b7b3c MDL-51215 course: redirect to manage appropriate category 2015-08-27 11:14:47 +08:00
Helen Foster b0f17b55f3 MDL-51148 lang: Merge English strings from the en_fix language pack 2015-08-26 17:25:49 +02:00
Dan Poltawski 86867d3248 Merge branch 'MDL-49701-28' of github.com:lameze/moodle into MOODLE_28_STABLE 2015-08-26 08:13:51 +01:00
Dan Poltawski 5c82c8e43c MDL-50641 rss: fix front page rss links
Fallback to guest user token when no user is specified in rss_get_url
rather than generating a junk token which is no use to anyone, this
matches existing logic which has been in place in forum for a while
and avoids custom handling all over the place.
2015-08-26 08:10:17 +01:00
Simey Lameze d49bf95236 MDL-49701 mod_lesson: add missing closebeforeopen string 2015-08-26 10:39:28 +08:00
David Monllao c06e48e541 Merge branch 'wip_MDL-50869_m28' of git://github.com/gjb2048/moodle into MOODLE_28_STABLE 2015-08-26 09:45:29 +08:00
David Monllao fd44933e9c Merge branch 'MDL-50996_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-08-25 14:27:14 +08:00
Marina Glancy 66c0fccb9e MDL-51131 tags: remove instances when course is deleted 2015-08-25 13:15:07 +08:00
Marina Glancy 728f41933c MDL-50973 admin: do not throw exception on /admin/ 2015-08-25 10:15:52 +08:00
Clement Smith 3c23486ad2 MDL-50957 grade/report/user: Fix division by zero
When using "sum of grades" and $grademax is zero, a division by zero
error occurs in fill_contributions_column() in
grade/report/user/lib.php.
2015-08-25 10:09:08 +08:00
Eloy Lafuente (stronk7) fe9f648edc Merge branch 'MDL-50714-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-08-25 00:06:50 +02:00
Tim Hunt 8ebae0d3d6 MDL-45841 forum: show unread posts on blog-style forum front page 2015-08-24 21:45:46 +01:00
Dan Poltawski 9fa2166a7b Merge branch 'MDL-49701_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-08-24 15:14:16 +01:00
Dan Poltawski abf7126490 Merge branch 'MDL-40179-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-08-24 13:40:10 +01:00
Davo Smith 8781542c0f MDL-49826 gradereport_singleview: fix permission check
Users with capability 'moodle/grade:edit' should be able to edit grade values
- 'moodle/grade:manage' is not needed, as grade items are not being changed.
2015-08-24 10:39:46 +01:00
Dan Poltawski 549e0ff729 Merge branch 'MDL-47450-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-08-24 10:25:34 +01:00
Tim Hunt 552efbb499 MDL-50996 quiz: fix review error with unusual permissions 2015-08-24 10:02:12 +01:00
David Monllao 596aa615a3 Merge branch 'MDL-50958-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-08-24 15:41:58 +08:00
Marina Glancy b9228b0272 MDL-51184 themes: correctly check $CFG->svgicons
Thanks to Ralf Wiederhold for pointing out the bug
2015-08-24 11:08:33 +08:00
Andrew Nicols 61662e6896 MDL-51170 core: Scheme section of URL should be case insensitive 2015-08-21 12:27:16 +08:00
Bruce Silver 072ff98b64 MDL-50958 block_messages: declare missing stdClass object 2015-08-21 11:30:39 +08:00
Andrew Nicols 9fe894c779 MDL-50714 mod_forum: Add tests for all groupmodes 2015-08-21 08:22:31 +08:00
Andrew Nicols 7603f1589c MDL-50714 mod_forum: Correct use of movedicussions cap when posting
The ability to view the group dropdown was too closely related to the
movediscussions capability when posting, or editing a forum post.

The movedicussions capability should only be considered for some parts of
this logic. Users should be able to select the group to post to when
writing message, as long as they have access to that group.
2015-08-21 08:22:24 +08:00
Gareth J Barnard 7991c2d105 MDL-50869 themes: Quiz feedback colours are not accessible. 2015-08-20 16:54:50 +01:00
Dan Poltawski ef176837dc weekly release 2.8.7+ 2015-08-20 14:24:32 +01:00
Andrew Nicols 8511869bfd MDL-42634 theme: Increase margin on activity instance to not cover controls
Conflicts:
	theme/bootstrapbase/style/moodle.css
2015-08-20 15:45:21 +08:00
David Monllao 1c23a1c000 Merge branch 'wip-mdl-46387-m28' of git://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-08-20 11:22:39 +08:00
Rajesh Taneja 4a46739201 MDL-46387 behat: fixed subscript feature scenario 2015-08-20 11:20:10 +08:00
Marina Glancy ae125772a3 MDL-50880 message: correctly compare with empty string
Thanks to David Herney Bernal for providing a fix
2015-08-20 10:32:20 +08:00
David Monllao 6ff144eef4 MDL-50391 mod_lti: Fixing indentation 2015-08-20 09:49:36 +08:00
Eloy Lafuente (stronk7) a5514edf92 Merge branch 'MDL-50801_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-08-19 20:50:13 +02:00
Simey Lameze 24cb5ad791 MDL-40179 auth_cas: change is_proxybypass parameter to use server url 2015-08-19 14:33:44 +08:00
Rajesh Taneja cb8d778e68 MDL-46387 behat: Backport behat user menu step and modified scenario
- editor preference page is not available in 28
- Profile is My profile under user menu
2015-08-19 13:57:07 +08:00
Andrew Nicols e0d9de0f43 MDL-42634 theme: Increase margin on sectionname to not cover controls 2015-08-19 04:49:25 +02:00
Eloy Lafuente (stronk7) 7b52f14f0f Merge branch 'MDL-49085_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-08-19 01:07:13 +02:00
Eloy Lafuente (stronk7) 2fe5bfe2e1 Merge branch 'MDL-46078-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE 2015-08-19 01:00:07 +02:00
Dan Poltawski 5b8994d4aa Merge branch 'wip-MDL-30315-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-08-18 13:19:59 +01:00
Eloy Lafuente (stronk7) d99c11ecec Merge branch 'MDL-47449-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-08-18 13:35:53 +02:00
Dan Poltawski 81d52cc2df MDL-46387 shifter: missing built changes 2015-08-18 12:32:47 +01:00
Dan Poltawski 59031a90ad Merge branch 'MDL-46387-m28-master' of https://github.com/dthies/moodle into MOODLE_28_STABLE 2015-08-18 12:22:18 +01:00
Dan Poltawski 7709e41cfc Merge branch 'MDL-49841-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-08-18 11:02:57 +01:00
Adrian Greeve db99a3e09e MDL-30315 grades: Unit test for grade import. 2015-08-18 17:06:04 +08:00
Adrian Greeve 9784aa23e7 MDL-30315 gradebook: Uploading feedback doesn't override grades. 2015-08-18 17:06:04 +08:00
David Monllao 60a103b519 Merge branch 'MDL-50391-MOODLE_28' of git://github.com/aspark21/moodle into MOODLE_28_STABLE 2015-08-18 12:13:47 +08:00
David Monllao 3058d15ff4 MDL-49085 block_tag_youtube: Using Youtube data api v3 2015-08-18 11:16:44 +08:00
David Monllao 69199d4ccc Merge branch 'MDL-51102-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-08-18 10:41:19 +08:00
Dan Poltawski 869af180a6 Merge branch 'MDL-44828-28' of git://github.com/junpataleta/moodle into MOODLE_28_STABLE 2015-08-17 14:24:59 +01:00
Dan Poltawski eac5dcfe6c Merge branch 'MDL-42634-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-08-17 11:45:12 +01:00
David Monllao 1213a0e405 Merge branch 'MDL-51016-m28' of git://github.com/micaherne/moodle into MOODLE_28_STABLE 2015-08-17 14:22:38 +08:00
David Monllao 44cc619bbd Merge branch 'MDL-50637-2.8' of git://github.com/sk-unikent/moodle into MOODLE_28_STABLE 2015-08-17 13:56:58 +08:00
David Monllao 6ab5491bbf Merge branch 'wip-MDL-50881-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-08-17 12:04:11 +08:00
David Monllao b210b577ec Merge branch 'MDL-50911-moodle28' of git://github.com/StudiUM/moodle into MOODLE_28_STABLE 2015-08-17 11:59:22 +08:00
Marina Glancy 00390e5b14 MDL-50932 cache: fix bug in prescanned file store
Thanks to Mark Nielsen for providing a patch
2015-08-17 11:45:47 +08:00
David Monllao d66f3df82d Merge branch 'MDL-51057-M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE 2015-08-17 09:54:46 +08:00
David Monllao 93f2239726 Merge branch 'MDL-51077-m28' of git://github.com/sammarshallou/moodle into MOODLE_28_STABLE 2015-08-17 09:46:51 +08:00
David Monllao 1ed375f2f5 Merge branch 'MDL-51088-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-08-17 09:26:31 +08:00
Andrew Nicols 4291ad3e8e MDL-51102 behat: Add a non-JS version of wait 2015-08-17 08:14:02 +08:00
Daniel Thies 9957c7f7fd MDL-46387 editor_atto: Add behat test for sub/sup 2015-08-16 16:02:05 -05:00
sam marshall f69d98df43 MDL-51077 Availability: Date restriction unit test static not cleared 2015-08-14 10:54:00 +01:00
Andrew Nicols 305ee3fc27 MDL-47449 completion: Ignore timemodified when comparing 2015-08-14 10:55:06 +08:00
Andrew Nicols a4dc694d6c MDL-47449 phpunit: Add comparitor for isEqual with exceptions
We often do isEqual tests but where a field, may have a single exception.
Ordinarily we can handle this easily by breaking the test down, but when
dealing with mocked objects we can only pass an instance of a
PHPUnit_Framework_Constraint, or a single value (which is cast to an
instance of PHPUnit_Framework_Constraint_IsEqual).

To deal with instances of time-based exception, we need to be able to
compare simple objects and classes where one or two values may be
different.
2015-08-14 10:55:06 +08:00
Andrew Nicols 54013a3cd1 MDL-49841 testing: Correct composer incantation 2015-08-14 10:29:17 +08:00
Jun Pataleta 38547b00f5 MDL-44828 filelib: Fix open error for force-downloaded files in mobile
Allow guessing of file's MIME type by default. Fallback to
application/octet-stream if MIME type cannot be determined.
2015-08-14 10:18:51 +08:00
Andrew Nicols c658ddf129 MDL-51088 mod_forum: Improve mod_forum behat performance 2015-08-14 07:58:18 +08:00
Andrew Nicols 89b453d1f6 MDL-51088 completion: Do not require hover to confirm xpath 2015-08-14 07:58:18 +08:00
lazydaisy 6ee4250032 MDL-51057 theme_base: RTL fix adds missing padding to block header h2. 2015-08-14 00:29:19 +01:00
Alistair Spark bb0c37afd4 MDL-50391 format_singleactivity: fix LTI Tool opens in existing window 2015-08-13 14:10:56 +01:00
Marina Glancy 23c18ecdc8 MDL-50391 format_singleactivity: fix activity_has_subtypes() 2015-08-13 14:10:56 +01:00
Dan Poltawski 0571f136e6 MDL-51110 badges: prevent duplicate award of badges
Previously duplicate users could be returned when they had
done duplicate badge criteria - this would lead to a duplicate
constraint being hit as they were attempted to be awarded twice.
2015-08-13 13:28:22 +01:00
Eloy Lafuente (stronk7) 7da2ed7a24 weekly release 2.8.7+ 2015-08-13 12:16:54 +02:00
Eloy Lafuente (stronk7) 0747fe1269 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-08-13 12:16:48 +02:00
AMOS bot 4155a06f8f Automatically generated installer lang files 2015-08-13 00:04:29 +08:00
AMOS bot fbe7024b7f Automatically generated installer lang files 2015-08-13 00:04:28 +08:00
Skylar Kelty 50b2135b2f MDL-50920 enrol: Remove pointless DB update in enrol_meta 2015-08-12 11:56:00 +01:00
Skylar Kelty 8e606dcd69 MDL-50637 calendar: Fix subscription table layout 2015-08-12 11:43:13 +01:00
David Monllao 6bebc4092f Merge branch 'MDL-46860-28' of git://github.com/ryanwyllie/moodle into MOODLE_28_STABLE 2015-08-12 10:46:34 +08:00
David Monllao 782d3e03eb Merge branch 'MDL-51053-m28' of git://github.com/sammarshallou/moodle into MOODLE_28_STABLE 2015-08-12 08:24:29 +08:00
Eloy Lafuente (stronk7) 6d5b932b6f Merge branch 'MDL-50062-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-08-12 01:45:30 +02:00
Eloy Lafuente (stronk7) 9c257bdd4e Merge branch 'MDL-50307-28-3' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-08-11 23:45:21 +02:00
Andrew Nicols 8e58a58149 MDL-49293 db: Pass sql_concat_join to sql_concat 2015-08-11 23:12:11 +02:00
Andrew Nicols 878a6a938c MDL-49293 db: Test sql_concat_join with more conditions 2015-08-11 23:12:10 +02:00
Eloy Lafuente (stronk7) ffce730e38 Merge branch 'MDL-50642_28' of https://github.com/ecampbell/moodle into MOODLE_28_STABLE 2015-08-11 22:45:50 +02:00
Alain Benoit 3d6d4ec109 MDL-50911 Quiz: edit settings page not responsive 2015-08-11 09:20:20 -04:00
sam marshall 9cb8cd1a21 MDL-51053 Restore: Static cache breaks unit tests 2015-08-11 14:09:19 +01:00
Eloy Lafuente (stronk7) 6001950405 Merge branch 'MDL-50894_28' of https://github.com/gedion/moodle into MOODLE_28_STABLE 2015-08-11 14:18:51 +02:00
Eloy Lafuente (stronk7) 6e6fba961c Merge branch 'm28_MDL-51015' of git://github.com/danmarsden/moodle into MOODLE_28_STABLE 2015-08-11 14:09:59 +02:00
Frederic Massart 7c6925dbc1 MDL-42634 theme: Action menu is displayed correctly with hidden elements 2015-08-11 14:54:55 +08:00
David Monllao b9bdaf698c Merge branch 'MDL-51014-m28' of git://github.com/sammarshallou/moodle into MOODLE_28_STABLE 2015-08-11 13:08:56 +08:00
Marina Glancy 4889c541bd MDL-50881 calendar: do not throw exception without sesskey 2015-08-11 12:52:44 +08:00
John Okely 58dbfc1f37 MDL-50307 auth_db: Stop using AS to prevent error with some drivers 2015-08-11 12:14:17 +08:00
John Okely aa2f2a7dc9 MDL-50307 auth_db: Fix associative fetching in ADODB 2.19 2015-08-11 12:14:17 +08:00
Mark Johnson 78cd07f761 MDL-51014 behat: Wait for filepicker to load repository 2015-08-10 13:38:52 +01:00
David Monllao 48daac6bd8 Merge branch 'wip-MDL-51062-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-08-10 14:24:19 +08:00
Marina Glancy 018576944f MDL-51062 behat: permission steps should work without js 2015-08-10 12:01:50 +08:00
David Monllao dfaaeb73c8 Merge branch 'MDL-50992-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE 2015-08-10 11:18:10 +08:00
David Monllao 625d89ffce Merge branch 'MDL-51007-m28' of git://github.com/sammarshallou/moodle into MOODLE_28_STABLE 2015-08-10 11:09:06 +08:00
David Monllao df5be2eeb9 MDL-50801 atto_table: Closing caption tag 2015-08-10 10:56:14 +08:00
Ryan Wyllie c0450b9ab9 MDL-46860 filepicker: change responsive styling
Changed the filepicker's responsive styling to kick in
on screen width less than 768px (which is the bootstrap
standard) rather than 873px. This allows the standard
styling to apply within an iframe.
2015-08-10 02:21:57 +00:00
Ryan Wyllie 3ec071a091 MDL-46860 filepicker: iframe context aware
The filepicker now checks if it's within an iframe when
creating the dialogue, if so it will set the dialogue width
to fit within the iframe and disable dragging.
2015-08-10 02:21:28 +00:00
Andrew Nicols 79a2623413 MDL-50949 cache: Improve cache performance tests 2015-08-10 08:21:20 +08:00
Andrew Nicols 136f69e9bc Merge branch 'MDL-50949-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-08-10 08:20:58 +08:00
AMOS bot 21715a1049 Automatically generated installer lang files 2015-08-08 00:04:24 +08:00
Frederic Massart 1613ce1b04 MDL-47450 blocks: Blocks can be moved on the site profile 2015-08-07 15:10:47 +08:00
AMOS bot bfb1475d57 Automatically generated installer lang files 2015-08-07 00:04:09 +08:00
Eoin Campbell 07d6525594 MDL-50642 qformat_xml: fix import of tags in Cloze questions 2015-08-06 16:48:59 +01:00
Michael Aherne 53eaea5944 MDL-51016 messaging: Fix email attachments on Windows 2015-08-06 13:07:25 +01:00
Dan Marsden a3ca598f14 MDL-51015 mod_scorm: tidy up messy code, remove use of eval() 2015-08-06 22:21:48 +12:00
Andrew Nicols f593be963c weekly release 2.8.7+ 2015-08-06 12:11:28 +08:00
Andrew Nicols 93b713c120 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-08-06 12:11:19 +08:00
Frederic Massart e043a770e5 MDL-50062 behat: Handle category mapping for grade items generator 2015-08-06 12:01:21 +08:00
Frederic Massart 87e339c40e MDL-50062 grades: Behat tests for aggregation changes 2015-08-06 12:01:20 +08:00
Frederic Massart 6cb4558ece MDL-50062 grades: Fix false positives in Behat tests 2015-08-06 12:01:20 +08:00
Frederic Massart a77191fb62 MDL-50062 grades: Tests for item::set_aggregation_fields_for_aggregation 2015-08-06 12:01:19 +08:00
Frederic Massart b127b86fe3 MDL-50062 grades: Carry agg. settings between categories when possible 2015-08-06 12:01:19 +08:00
Dave Cooper 0bd275a9e2 MDL-50062 gradebook: Fixed behaviour when changing aggregation mathods. 2015-08-06 12:01:18 +08:00
Daniel Thies dc7e49f611 MDL-46387 editor-atto: Toggle sub/sup tags using rangy
In order to have a consistant browser behavior and prevent nesting of
subscripts and superscripts, tags are converted to CSS classes and then
the CSS classes in the selection are toggeled using the rangy crossbrowser
selection library already included in Atto without using an execCommand.
2015-08-05 16:04:53 -05:00
Eloy Lafuente (stronk7) 98011f0c2a Merge branch 'MDL-44840-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-08-05 20:47:51 +02:00
Eloy Lafuente (stronk7) afc52092bc Merge branch 'MDL-50816-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-08-05 18:22:17 +02:00
AMOS bot 26a9883a74 Automatically generated installer lang files 2015-08-06 00:04:18 +08:00
AMOS bot 8b6aacac49 Automatically generated installer lang files 2015-08-06 00:04:18 +08:00
Eloy Lafuente (stronk7) a34337ffdb Merge branch 'MDL-48970_2.8' of https://github.com/andrewhancox/moodle into MOODLE_28_STABLE 2015-08-05 16:20:56 +02:00
sam marshall 349ed8c86c MDL-51007 Availability: Unit test fails with extra plugins 2015-08-05 14:31:38 +01:00
Eloy Lafuente (stronk7) 71abb43154 Merge branch 'MDL-38230_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-08-05 12:40:06 +02:00
Andrew Nicols 3f98ccfbc3 MDL-50999 dock: Stop adding commands to DOM
The commands div should not be added to the DOM. The version shown in the
dock is different to the standard version in the block, and is manually
added to the dock panel when it is displayed.

The docked version contains additional actions (e.g. the undock button).

The original version of the dock should ideally remain untouched.

Note: A duplicate delegation was discovered when fixing this issue. This
was previosuly not triggered because the watched Node was removed
before the delegation took effect.
2015-08-05 10:09:42 +08:00
Andrew Nicols ec5c6bc193 Merge branch 'MDL-48202-M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE 2015-08-05 09:10:55 +08:00
Eloy Lafuente (stronk7) d7cc44a00d MDL-35027 mod_forum: verify forced subscriptions cannot be edited
This commit adds a new scenario to verify that the option
to turn edition of subscribers is not available anymore
for forced-subscription activities.

It also gets rid of the @javascript tag in a just introduced
scenario not needing it.
2015-08-05 02:11:32 +02:00
Eloy Lafuente (stronk7) ae26fc0bb4 Merge branch 'MDL-35027-B-28' of https://github.com/bostelm/moodle into MOODLE_28_STABLE 2015-08-05 02:10:28 +02:00
Eloy Lafuente (stronk7) a06efb59b3 Merge branch 'MDL-50416-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-08-04 20:00:43 +02:00
Eloy Lafuente (stronk7) fdf6a66c52 MDL-46963 env: adding missing check_database_tables_row_format check 2015-08-04 19:41:10 +02:00
Eloy Lafuente (stronk7) 2dfc646317 MDL-50624 env: adding missing restrict_php_version_7 check 2015-08-04 19:28:46 +02:00
Bruce Silver a8d049c89f MDL-50992 lti: Fix debugging warning when creating a new tool 2015-08-04 22:30:14 +08:00
Andrew Nicols ee18715ebc Merge branch 'MDL-50893_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-08-04 16:00:44 +08:00
Andrew Nicols da3fc40642 Merge branch 'MDL-45113-28' of https://github.com/mackensen/moodle into MOODLE_28_STABLE 2015-08-04 15:24:02 +08:00
Andrew Nicols f4c182048f Merge branch 'MDL-43709-28' of https://github.com/pauln/moodle into MOODLE_28_STABLE 2015-08-04 12:45:10 +08:00
Andrew Nicols 933f0b800a Merge branch 'MDL-50532-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-08-04 12:14:52 +08:00
Andrew Nicols 888cee2a2e MDL-50493 mod_forum: Correct style issues 2015-08-04 11:57:08 +08:00
Andrew Nicols e8084e04da Merge branch 'MDL-50493-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-08-04 11:56:54 +08:00
Andrew Nicols 7a97deebbc Merge branch 'MDL-50771_28' of git://github.com/stronk7/moodle into MOODLE_28_STABLE 2015-08-04 10:29:29 +08:00
Andrew Nicols 0013bab929 Merge branch 'MDL-42626-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-08-04 10:11:12 +08:00
Andrew Nicols adb6051f4c Merge branch 'MDL-45772-28-4' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-08-04 10:02:25 +08:00
Simey Lameze eb9bf73f21 MDL-50416 environment: add missing slasharguments checks 2015-08-04 09:55:49 +08:00
John Okely 9c336fdbe5 MDL-45772 admin: Stop browsers from autofilling passwords incorrectly 2015-08-04 09:55:07 +08:00
AMOS bot c256b7ba76 Automatically generated installer lang files 2015-08-04 00:04:26 +08:00
Henning Bostelmann 096dc2d33f MDL-35027 mod_forum: Fix subscriber list in hidden forums
If the forum is force-subscribed and hidden, only subscribers that can
view hidden activities will be shown in the subscriber list.
2015-08-03 12:14:41 +01:00
Eloy Lafuente (stronk7) 0494de7a1e MDL-50771 oracle: Bind long (>4000byte) text as CLOB
While we already were detecting @ normalise_value()
both BLOBs and CLOBs properly on insert and update
statements (by introspectind the column specs), when
a long TEXT is being passed as part of an arbitrary
SQL, or within the conditions... it was being bound
as VARCHAR, leading to problems if used in combination
with DBMS_LOB functions.

This patch just ensures that any TEXT > 4000 bytes not
detected by normalise_value() will be, always, bound as CLOB,
unconditionally.

Covered with tests both covering its use with DBMS_LOB (the
reported bug) and also in general raw statements.
2015-08-03 10:52:23 +02:00
Jean-Michel Vedrine ac2aa953ac MDL-38230 mod_quiz: Create UI for removing of quiz access rule addons
Conflicts:
	mod/quiz/version.php
2015-08-03 08:58:45 +02:00
Andrew Nicols b583b40de5 Merge branch 'wip-MDL-22819-m28' of https://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-08-03 10:23:35 +08:00
Andrew Nicols aa7ac17386 Merge branch 'MDL-49864-28' of git://github.com/junpataleta/moodle into MOODLE_28_STABLE 2015-08-03 09:44:31 +08:00
Andrew Nicols a989aac8fe Merge branch 'MDL-50624-28' of git://github.com/ryanwyllie/moodle into MOODLE_28_STABLE 2015-08-03 09:21:10 +08:00
Jun Pataleta 54f0ee08d8 MDL-49864 mod_assign: Fix missing annotations when viewing PDF
Added 'draft = 1' criteria for the delete query in
page_editor::set_annotations in order to prevent the deletion of non-draft
annotations while the PDF is being edited.
2015-08-03 09:12:32 +08:00
Ryan Wyllie 713927f915 MDL-50624 environment: add PHP7 as unsupported version
Added PHP7 as an unsupported version for Moodle 2.8 and 2.9 in
the environment checks
2015-08-03 01:04:45 +00:00
lazydaisy f8fa208894 MDL-48202 theme_bootstrapbase: blocks are 6px taller after undocking. 2015-08-02 21:29:42 +01:00
Jean-Michel Vedrine e3bc5a8e27 MDL-49701 mod_lesson: open time should be before close time
Conflicts:
	mod/lesson/mod_form.php
2015-08-02 10:41:01 +02:00
Charles Fulton c90d759569 MDL-45113 auth: add is_configured method and convert auth_db to use it 2015-07-31 15:18:43 +00:00
Simey Lameze 81e3985652 MDL-50416 environment: remove slasharguments warning from install 2015-07-31 11:40:10 +08:00
Andrew Nicols 9f405b6c6d weekly release 2.8.7+ 2015-07-30 14:42:04 +08:00
Andrew Nicols cc7d7fb648 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-07-30 14:41:58 +08:00
Frederic Massart 88158ed58a MDL-50949 cache: Tests for performance debugging of cache usage 2015-07-29 14:47:47 +08:00
Frederic Massart c535e62552 MDL-50532 tasks: Delete obsolete tasks during upgrade 2015-07-29 11:25:41 +08:00
Jean-Michel Vedrine d670ca4dcd MDL-44840 mod_lesson: fix import of truefalse questions 2015-07-29 11:06:06 +08:00
Tim Hunt a36bdaeb82 MDL-50893 questions: cannot create a question with name 0 2015-07-28 18:21:08 +01:00
Barbara Ramiro 3690dd25a1 MDL-50370 Icons: Filetype icon for ePub 2015-07-28 12:43:38 +01:00
Dan Poltawski 33fb1f3d9f Merge branch 'MDL-50833-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-07-28 12:38:54 +01:00
Dan Poltawski 417d607c56 Merge branch 'MDL-50868-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2015-07-28 12:19:03 +01:00
spvickers a73ee08811 MDL-49629 mod_lti: Add icon fields
Icon fields added to input form when defining an external tool at the
admin level.  The icon for a tool derived from a tool proxy can be
overridden.  Course cache is cleared if current icon value is changed.

Add text boxes to edit form for entering icon URLs.
2015-07-28 12:03:41 +01:00
Andrew Nicols 13613d3bab Merge branch 'wip-MDL-50874-m28' of https://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-07-28 15:03:00 +08:00
Andrew Nicols 63199d4418 Merge branch 'MDL-50295-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-07-28 14:03:46 +08:00
Andrew Nicols 681ef5e858 Merge branch 'MDL-44962_28' of https://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-07-28 11:38:04 +08:00
Andrew Nicols c47d5153ed Merge branch 'MDL-35148-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-07-28 11:08:35 +08:00
Frederic Massart 8ef5eea2db MDL-35148 themes: Updated checks deciding when mobile themes are used
Now, if a site-theme is set for tablet/phone AND the user is using
a tablet/phone that site-theme will be used, always. In any other
case the normal theme resolution will be used: course, category, ...
2015-07-28 11:01:31 +08:00
Damyon Wiese 05bbda7b40 MDL-46078 Assign: Completion is not using assignment API.
Should not be directly querying the DB to get the submission, use the API!
2015-07-28 10:29:18 +08:00
Juan Leyva e06ea6d9e2 MDL-42626 messages: Hide deleted users in contact/blocked list 2015-07-27 16:37:14 +02:00
Charles Fulton 9314573cf6 MDL-41598 auth_shibboleth: don't override wantsurl 2015-07-27 15:25:11 +01:00
Dan Poltawski 96b529314f Merge branch 'MDL-43785-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-07-27 14:49:42 +01:00
Dan Poltawski e205936ac9 Merge branch 'MDL-49360-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-07-27 12:08:47 +01:00
Dan Poltawski 27f5d33ad2 Merge branch 'wip-MDL-50649-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-07-27 12:00:03 +01:00
Andrew Nicols 08b7326cc5 Merge branch 'MDL-46232-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-07-27 15:58:39 +08:00
Frederic Massart 74e083713e MDL-46232 user: Handle bulk delete of users without email addresses 2015-07-27 15:48:16 +08:00
Andrew Nicols ea2e3f1c82 MDL-43785 lib: Improve session timeout warnings 2015-07-27 14:30:37 +08:00
Simey Lameze 185f689f77 MDL-49360 core_lib: add new method get_local_referer()
This commit also replace all usages of $_SERVER['HTTP_REFERER'] and get_referer().
2015-07-27 11:58:11 +08:00
AMOS bot 2644190a7b Automatically generated installer lang files 2015-07-26 00:04:07 +08:00
Gedion Woldeselassie ab49be1e54 MDL-50894 lib/conditionlib: Occasional cron error
Inhibit division by zero error warnings when rawgrademax and rawgrademin are
equal. The change does not affect existing functional behavior.
2015-07-24 10:14:45 -05:00
David Monllao f9c2569e00 MDL-44962 mod_wiki: No input filter
Thanks to Tim Lock for the partial fix.
2015-07-24 16:34:40 +02:00
Marina Glancy 88f5b27317 MDL-22819 tags: fix breadcrumb on manage tags page 2015-07-24 21:28:47 +08:00
Marina Glancy c537eb481d MDL-50649 report: query optimisation 2015-07-24 17:39:21 +08:00
Jetha Chan 8e074d1f69 MDL-50868 weblib: add unit test for ruby support 2015-07-24 14:11:53 +09:00
Jetha Chan 1e62e0c76c MDL-50868 weblib: add ruby support to purify_html 2015-07-24 14:11:53 +09:00
AMOS bot c7a40cf84a Automatically generated installer lang files 2015-07-24 00:04:25 +08:00
Dan Poltawski 97c2995445 weekly release 2.8.7+ 2015-07-22 20:42:58 +01:00
Dan Poltawski d03257d941 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-07-22 20:42:57 +01:00
Andrew Nicols 7fa65cdacf Merge branch 'MDL-50563-m28' of https://github.com/NeillM/moodle into MOODLE_28_STABLE 2015-07-22 09:37:47 +08:00
Andrew Nicols 52fccfe799 Merge branch 'MDL-50762-MOODLE28' of https://github.com/luryus/moodle into MOODLE_28_STABLE 2015-07-22 09:13:29 +08:00
Andrew Nicols f4fb074c23 Merge branch 'MDL-50699-28' of https://github.com/pauln/moodle into MOODLE_28_STABLE 2015-07-22 09:08:33 +08:00
Dan Poltawski 35bc4ecd94 Merge branch 'MDL-50293_28' of https://github.com/Syxton/moodle into MOODLE_28_STABLE 2015-07-21 12:51:58 +01:00
Marina Glancy 9df65abc4b MDL-50874 block: basic tests for tag-related blocks 2015-07-21 17:00:58 +08:00
Dan Poltawski e41fcbb337 Merge branch 'MDL-50639_mod_book_fontsize_M28' of https://github.com/barrysspace/moodle into MOODLE_28_STABLE 2015-07-21 09:08:13 +01:00
Andrew Nicols 73f2b4c674 Merge branch 'MDL-49618-m28' of https://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-07-21 12:17:43 +08:00
Andrew Nicols e53e48d459 Merge branch 'MDL-47230_M28' of https://github.com/barrysspace/moodle into MOODLE_28_STABLE 2015-07-21 11:23:52 +08:00
Andrew Nicols 06eae40f50 Merge branch 'wip-MDL-41650-m28' of https://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-07-21 10:03:12 +08:00
AMOS bot fc6277c149 Automatically generated installer lang files 2015-07-21 00:04:40 +08:00
pau.ferrer-ocana 5e56049641 MDL-49440 lib: Date picker duplicated week day names repaired
Thanks Marc Català for the patch
2015-07-20 14:04:47 +01:00
Dan Poltawski 4fb12f39be Merge branch 'wip-MDL-50678-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-07-20 13:54:05 +01:00
AMOS bot e8f903bc82 Automatically generated installer lang files 2015-07-20 00:05:07 +08:00
apsdehal e2c7d95dc4 MDL-41650 Tags: Changed css classes of errors and success notice 2015-07-19 20:23:53 +08:00
AMOS bot dcd6b60217 Automatically generated installer lang files 2015-07-18 00:05:24 +08:00
Lauri Koskela 43f957c3f9 MDL-50762 tool_capability: Do not hide first capability in list 2015-07-17 15:30:56 +03:00
Neill Magill f2d0c4b895 MDL-50563 blocks: A hidden block that is dropped should be dimmed
Before this patch when dragging and dropping a hidden block it would display as though visible when it was dropped.

This is only a display issue, as a page refresh caused it to be dimmed in its new position.
2015-07-17 09:08:18 +01:00
Barry Oosthuizen 4e0cd866c1 MDL-50639 mod_book: Remove 0.8em font sizes 2015-07-17 08:44:05 +01:00
AMOS bot 9a2fd1975f Automatically generated installer lang files 2015-07-17 00:05:11 +08:00
Syxton df0881384f MDL-50293 navigation: File name not wrapping
A long File name doesn't always wrap correctly in the Navigation block.
2015-07-16 10:23:19 -04:00
Michael Aherne a02fc8bb05 MDL-50490 cron: Prevent tasks from leaving uncommitted transactions 2015-07-16 11:41:16 +01:00
Dan Poltawski cecc0eb211 weekly release 2.8.7+ 2015-07-16 08:16:18 +01:00
Juan Leyva 94540f233e MDL-50816 notes: Delete never met condition code 2015-07-15 15:26:02 +02:00
Eric Merrill 2675bdb42d MDL-50833 report: Still make a chart if there are no logs 2015-07-15 09:13:53 -04:00
Barry Oosthuizen 08ed9c2f04 MDL-47230 mod_book: Sub chapter bullet formatting 2015-07-15 09:20:09 +01:00
Marina Glancy 94081247f8 MDL-50678 mod_glossary: removed extra login check 2015-07-15 14:19:09 +08:00
Dan Poltawski 41ac409428 Merge branch 'MDL-37832-M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE 2015-07-14 10:14:15 +01:00
Dan Poltawski 0446d70c4c Merge branch 'MDL-50814-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-07-14 08:55:20 +01:00
Mary Evans 24096407cc MDL-37832 theme: Improved "My Moodle" expandable/collapsible caption. 2015-07-14 08:50:29 +01:00
Dan Poltawski 91076c7400 Merge branch 'MDL-50711_M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE 2015-07-14 08:44:56 +01:00
Dan Poltawski a88e331243 Merge branch 'MDL-50799-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-07-13 16:08:22 +01:00
Juan Leyva 32d3490d55 MDL-50814 badges: Fix incorrect default ordering 2015-07-13 15:10:57 +02:00
Dan Poltawski 2562ca0bb6 Merge branch 'MDL-50806-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-07-13 13:45:59 +01:00
Dan Poltawski f72723f2b6 Merge branch 'MDL-50798-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-07-13 13:35:32 +01:00
Dan Poltawski f5e5c91b96 Merge branch 'MDL28-50800' of https://github.com/dkleto/moodle into MOODLE_28_STABLE 2015-07-13 13:27:40 +01:00
Dan Poltawski b27449ce44 Merge branch 'm28_MDL-49647' of https://github.com/danmarsden/moodle into MOODLE_28_STABLE 2015-07-13 10:05:24 +01:00
Paul Nicholls 18bc6d2177 MDL-43709 Forum: Reset forums not working with multiple forum types
The SQL being generated from the selected forum types on the course reset
form was using AND, resulting in never matching anything if more than one
forum type was selected for resetting (as each forum can only have one
type).  This should use $DB->get_in_or_equal() to generate sensible SQL.
2015-07-13 16:12:58 +12:00
Adam Riddell 2e3bc53fb3 MDL-50800 question: Add missing make_answer method
question/type/calculatedmulti/questiontype.php:
        - Add public make_answer method so that apply_attempt_state
          method in qtype_multichoice_base does not cause a fatal
          error when attempting to call make_answer.
2015-07-13 09:47:31 +10:00
Mary Evans 7b84e17a3a MDL-50711 theme_bootstrapbase: Added inverse horizontal divider colors. 2015-07-12 02:55:51 +01:00
Eloy Lafuente (stronk7) 4c7c7632dd weekly release 2.8.7+ 2015-07-10 18:11:22 +02:00
Eric Merrill a4bb044f62 MDL-50806 questions: Allow more memory when doing a question import 2015-07-09 12:46:47 -04:00
Dan Marsden c1e65f42a5 MDL-49647 mod_scorm: correct escaping of javascript content. 2015-07-09 16:58:03 +12:00
Eric Merrill 4a97af59ef MDL-50799 question: Improve Show all text to be more accurate 2015-07-08 22:03:16 -04:00
Marina Glancy 4a75799c9e MDL-49618 forum: apply format_string 2015-07-09 07:55:35 +08:00
Eric Merrill 92c067f617 MDL-50798 question: Raise time limit when rendering questions
Rendering a large number of questions may be quite slow, so we want to
raise the limit.

We don’t call raise() in the loop because the quiz buffer captures this
function for a AJAX script, and we should only call raise if we expect
a corresponding output to the users browser. This helps to prevent
unexpected load balancer disconnects. See core_php_time_limit::raise()
for more details.
2015-07-08 15:49:54 -04:00
Eloy Lafuente (stronk7) 2b5883adb0 Merge branch 'MDL-50489-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-07-07 19:13:21 +02:00
Eloy Lafuente (stronk7) 8f2a74ab57 Merge branch 'MDL-49185-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-07-07 16:59:13 +02:00
Dan Poltawski ec2342495d MDL-50466 logstore: bump version to load new task definitions 2015-07-07 15:09:01 +01:00
Dan Poltawski 220fbca1aa MDL-50295 output: prevent 'emoji' arrows
We need to append U+FE0E VARIATION SELECTOR-15 to the arrow to ensure
our l/rarrows are displayed as text icons, not 'emoji' icons.

See http://unicode.org/reports/tr51/#Diversity for more details of why
this changed in iOS 8.3+.
2015-07-07 14:27:05 +01:00
Michael Aherne 772dc9df94 MDL-50466 tasks: Specific minute values for log cleanup 2015-07-07 09:39:11 +01:00
Dan Poltawski 118c600ba5 MDL-50749 js: add some TODOs to some small hacks 2015-07-07 08:49:30 +01:00
Dan Poltawski 29f2ac3b81 Merge branch 'MDL-50749-28' of https://github.com/mackensen/moodle into MOODLE_28_STABLE 2015-07-07 08:38:46 +01:00
Charles Fulton 3b994f6ab2 MDL-50749 course: add fake element for behat compatibility 2015-07-03 20:01:40 +00:00
Eloy Lafuente (stronk7) 1f2979d0e5 Moodle release 2.8.7 2015-07-03 13:38:19 +02:00
Eloy Lafuente (stronk7) 385cd9ee23 Merge branch 'MDL-50757-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE 2015-07-03 11:27:58 +02:00
Damyon Wiese 3d517153fa MDL-50757 upgrade: Unset config value that will never be used again 2015-07-03 16:48:37 +08:00
Adrian Greeve 1d19128f68 MDL-50757 gradebook: Update fix for pre 2.8 upgrades.
Moodle installations that updated before the 2.8 grade push
were being flagged for a gradebook freeze. This was resulting in
calculated grades being shown as different to how they were
displayed before the upgrade. This fix retains the original
grade value.
2015-07-03 13:20:06 +08:00
Dan Poltawski c0ba953afc weekly release 2.8.6+ 2015-07-02 14:26:02 +01:00
Dan Poltawski 67d1edca87 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-07-02 14:25:59 +01:00
Juan Leyva e2b7ee6662 MDL-50489 forum: Handle qanda forums in get_forum_discussions_paginated
I removed the last qanda checks in forum_user_can_see_discussion because they are not necessary and
they make the external function fail.

A user in a qanda forum can always see a discussion (he needs to see the discussion to be able to reply).
What he cannot see are the other user posts unless he has replied to the discussion once and the edition period
(usually 30 minutes) has ended.

Note also that forum_user_can_see_discussion was originally only used when displaying forums in blog format
in order to display the button show more or not, this is the reason this wasn't detected before.
2015-07-02 10:41:00 +02:00
Marina Glancy b930e2005c MDL-48239 grades: corrected docs url for calculation changes 2015-07-02 15:50:24 +08:00
Marina Glancy 0c89600969 MDL-48239 grades: fix notification class 2015-07-02 15:50:22 +08:00
Adrian Greeve 801964cabb MDL-48239 gradebook: Oracle fix for string compare.
Update to upgradelib.php where string comparisions cause
phpunit failures in Oracle.
2015-07-02 12:30:40 +08:00
Eloy Lafuente (stronk7) 3a4cd8db0f Merge branch 'wip-MDL-48239-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-07-02 05:42:39 +02:00
Adrian Greeve 1a9f295e47 MDL-48239 gradebook: Change to calculated grade item min and max.
Regardless of the setting 'Min and max grades used in calculation'
Calculated grade items will always update the min and max raw grade.
2015-07-02 11:30:49 +08:00
Adrian Greeve 2adc935709 MDL-48239 gradebook: Unit test for upgrade function. 2015-07-02 11:30:49 +08:00
Adrian Greeve 98c04f38cd MDL-48239 gradebook: Behat tests for calculated grade items. 2015-07-02 11:30:48 +08:00
Adrian Greeve 02bc1d3b88 MDL-48239 gradebook: Calculated grades maxgrade now able to be set. 2015-07-02 11:30:48 +08:00
Andrew Hancox 0f8a6256d5 MDL-48970 groups: Fix hover description on groups overview page
If a course exists within multiple groupings then the description
should display when you mouseover any instance of it on the overview
page.
2015-07-01 21:28:20 +01:00
Rajesh Taneja 0996a2966c MDL-50481 behat: SingleSelect can be urlselect and should support id/name 2015-07-01 11:23:39 +08:00
David Monllao c556c5fca5 Merge branch 'MDL-50497-M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE
Conflicts:
	theme/bootstrapbase/style/moodle.css
2015-07-01 08:57:15 +08:00
Juan Leyva 7b15a36320 MDL-50130 users: Filter profile fields data in external functions 2015-06-30 19:51:20 +02:00
AMOS bot c0ce8e7ae5 Automatically generated installer lang files 2015-07-01 00:05:01 +08:00
Dan Poltawski 4f46506fdb Merge branch 'wip-mdl-50481-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-06-30 12:25:54 +02:00
Dan Poltawski 2f5e10392c Merge branch 'MDL-33765_m28_offset' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-06-30 12:20:09 +02:00
Dan Poltawski bc65073a61 Merge branch 'MDL-47787-m28' of https://github.com/tbannister/moodle into MOODLE_28_STABLE 2015-06-30 10:24:49 +02:00
David Monllao 41b330abe1 MDL-50569 backup: Missing get_target call 2015-06-30 10:33:44 +08:00
Dan Marsden d942f0311c MDL-50614 mod_scorm: Improve validation on currentorg 2015-06-30 10:14:33 +08:00
David Monllao 419f4c47e4 Merge branch 'MDL-50569-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-06-30 09:33:20 +08:00
Eloy Lafuente (stronk7) 1777d32cb2 Merge branch 'wip-mdl-50675-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-06-29 18:33:26 +02:00
Eloy Lafuente (stronk7) a8753fb85a MDL-50688 lib: small cleanup + http/https coverage. 2015-06-29 17:50:04 +02:00
Petr Skoda 980bd08bdc MDL-50688 lib: fix local url validation bug
Change-Id: I350bb8c9ace5cc0403f083f728c100097be7aa7e
Reviewed-on: https://review.totaralms.com/8101
Tested-by: Jenkins Automation <jenkins@totaralms.com>
Reviewed-by: Sam Hemelryk <sam.hemelryk@totaralms.com>
Reviewed-by: Alastair Munro <alastair.munro@totaralms.com>
2015-06-29 17:50:00 +02:00
Nadav Kavalerchik 3a8b5c11d2 MDL-50708 SCORM: Right align menu item folder icon, when in RTL mode. 2015-06-29 15:58:22 +08:00
Frederic Massart 3423321b32 MDL-50569 grades: Restore as merge always ignores minmaxtouse 2015-06-29 14:28:02 +08:00
Frederic Massart 7610449b02 MDL-50569 grades: Handle minmaxtouse in backup/restore 2015-06-29 14:28:02 +08:00
David Monllao 142d17da19 Merge branch 'MDL-50652_28' of git://github.com/reskit/moodle into MOODLE_28_STABLE 2015-06-29 13:02:56 +08:00
Mark Nelson 67e6cefa41 MDL-33765 filter_glossary: fixed jshint warning 2015-06-28 22:01:56 -07:00
Martin Mastny 025e0130c9 MDL-33765 filter_glossary: Stacking JS windows with offset 2015-06-28 21:16:29 -07:00
Martin Mastny 5a0a0a4d7e MDL-33765 mod_glossary: Concept in ajax request not linking to itself 2015-06-28 21:16:19 -07:00
David Monllao 860a35db66 Merge branch 'wip_MDL-50659_m28' of git://github.com/gjb2048/moodle into MOODLE_28_STABLE 2015-06-29 11:48:43 +08:00
Rajesh Taneja 82d0bd3246 MDL-50675 repository_wikimedia: Fixed title varaible 2015-06-29 09:57:36 +08:00
Rajesh Taneja ae7f9ead0e MDL-50675 repository_wikimedia: Wikimedia is using https and not http 2015-06-29 09:57:36 +08:00
Mary Evans 5856c76917 MDL-50497 theme_bootstrapbase: Divider colours look wrong when inverted 2015-06-26 23:10:03 +01:00
Gareth J Barnard 777a4a2d2e MDL-50659 themes: Regression: Drag a link makes icons move. 2015-06-26 11:46:20 +01:00
Paul Nicholls f97240de8a MDL-50699 Lesson: "Link to next activity" empty until Lesson saved
Due to a logic bug, the "Link to next activity" dropdown was empty (only
contains the "None" option) until the Lesson had been saved.  This minor
change allows a "next activity" to be specified when initially creating
the Lesson whilst still preventing the user from choosing the Lesson as its
own next activity.
2015-06-26 14:44:43 +12:00
Tyler Bannister d45b318a5d MDL-47787 course: Added question delete to cm delete. 2015-06-25 16:36:50 -04:00
Marc Català f81f6bbda5 MDL-50652 workshop: Workshop module allows duplicated ID number 2015-06-25 14:26:10 +02:00
Marina Glancy 40c3419184 MDL-49257 grades: apply freeze when restoring with contents deleting 2015-06-25 14:40:06 +08:00
David Monllao 47cbd1b42d weekly release 2.8.6+ 2015-06-25 13:50:06 +08:00
David Monllao 3fc06c5776 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-06-25 13:50:04 +08:00
Rajesh Taneja 6d55d3b4f8 MDL-50481 core_grades: Fixed behat feature and step to work with non-js
xPath used in step is not using proper oring
and fails with goutee driver. Also, feature don't
really need to be executed in js, so setting that
as non-js
2015-06-25 13:15:14 +08:00
Rajesh Taneja c74f4582c2 MDL-50481 behat: Press go button for given single select in non-js
For non-js mode, ensure we press the go button
for the specified single select, as there can be
multiple single selects on the page with go button
2015-06-25 13:15:14 +08:00
Marina Glancy 05fde3409f MDL-49257 grades: strings adjustments 2015-06-25 10:00:23 +08:00
Eloy Lafuente (stronk7) aa79c57c1e MDL-49022 auth_ldap: keep method visibility unmodified. 2015-06-24 03:04:59 +02:00
Eloy Lafuente (stronk7) fb124fc068 Merge branch 'wip-mdl-49022-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-06-24 03:03:18 +02:00
Eloy Lafuente (stronk7) 17d14ff177 MDL-49497 curl: keep api private and test it using reflection.
While strictly we should not be testing private APIs, in order
to get this backported to stables without changing visibility
we use reflection to access to such private properties and methods.

Also added one exttest to verify user agent is properly sent.

Finally, fix some wrong whitespace and changed the helper class name
to better alternative.
2015-06-23 16:25:59 +01:00
Dan Poltawski 54659b0a06 Merge branch 'MDL-49497-28' of git://github.com/gurgus/moodle into MOODLE_28_STABLE 2015-06-23 16:25:43 +01:00
Dan Poltawski dc129d0b68 Merge branch 'wip-MDL-49257-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-06-23 11:20:30 +01:00
Rajesh Taneja 7a26c7b0c3 MDL-49022 auth_ldap: Updated unit test, checking sync_user events 2015-06-23 17:05:38 +08:00
Mark Ward e7199f8944 MDL-49022 auth_ldap: trigger event when required.
When calling update_user_record() for auth_ldap the method
now has option to trigger event core\event\user_updated when
syncing with domain controller.
This means that the event will be triggered by sync_users()
but not by user_signup().
2015-06-23 17:05:38 +08:00
Marina Glancy 567f1c3c4c MDL-49257 grades: behat tests for extra credit 2015-06-23 14:25:27 +08:00
Marina Glancy e48f0ef106 MDL-49257 grades: fix bugs with extra credit weights
When we adjust the weights in natural grading (setup screen), the extra credit items
should not depend on other overrides. If extra credit item's weight was overriden, it stays as it is.
Otherwise it is calculated as itemgrademax / totalgrademax (total excludes extra credit items)
2015-06-23 14:25:27 +08:00
Marina Glancy 4a84177457 MDL-49257 grades: introduce calculation freeze
In order to prevent changes in the existing grades when we fix bugs
we are introducing the gradebook code versioning. Each course may
"freeze" the code version to the older date. Freezing is usually done
during upgrade or restore and can be removed by the teacher by pressing
the button and accepting potential grade changes. There is no visible
setting and not possible to change the version back manually.

See MDL-50432 and MDL-50522
2015-06-23 14:25:24 +08:00
David Monllao cd7544d403 MDL-50611 testing: Extra http status code checking 2015-06-23 10:37:00 +08:00
David Monllao 0691b264e2 Merge branch 'MDL-50611-28' of git://github.com/LukeCarrier/moodle into MOODLE_28_STABLE 2015-06-23 10:30:33 +08:00
spvickers e0cefc24ab MDL-49185 mod_lti: Check for all capabilities
Added check for explicit and implicit enabled capabilities when parsing
a custom parameter.
2015-06-23 10:26:42 +08:00
Eloy Lafuente (stronk7) 0b2c4cf27d Merge branch 'MDL-50089-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-06-22 19:59:24 +02:00
Eloy Lafuente (stronk7) a4f64284aa Merge branch 'MDL-50583_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-06-22 19:22:58 +02:00
Eric Merrill b60e213341 MDL-50089 grades: Use grade item min/max in exports 2015-06-22 12:59:36 -04:00
Luke Carrier 2af7590d98 MDL-50611 test: use cURL extension to download Composer
The curl binary is nowhere near as common in Windows environments as it is
in Linux and Mac ones. In order to encourage more users to adopt Behat and
PHPUnit for their testing, we should avoid introducing unnecessary
hurdles.
2015-06-22 15:53:26 +01:00
Dan Poltawski 8ce0acb5de Merge branch 'MDL-50091_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-06-22 12:06:53 +01:00
David Monllao ad02c3adf0 Merge branch 'MDL-50622-28-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-06-22 17:45:02 +08:00
Helen Foster d1d1d24396 MDL-50622 lang: Merge English strings from the en_fix language pack 2015-06-22 11:42:29 +02:00
David Monllao 8972c8627d Merge branch 'wip-MDL-50568-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-06-22 15:33:59 +08:00
Tim Hunt ce4d2810a0 MDL-50648 grader report: columns misaligned with some permissions
If a user can see the grader report and singleview report, but not
the user report ($CFG->grade_profilereport) then the colspans
were wrong and so the columns did not line up under the right headers.
2015-06-19 12:41:31 +01:00
AMOS bot 965fcec3a1 Automatically generated installer lang files 2015-06-19 00:04:14 +08:00
Dan Poltawski 89273142e2 weekly release 2.8.6+ 2015-06-18 14:03:06 +01:00
Dan Poltawski 2e8d88fe22 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-06-18 14:03:04 +01:00
Tim Hunt 8e3f31debe MDL-50091 grade singleview: use standard API to build the link
Acutally the necessary code was already there. There was just some
unnecessary code that was added with the issue number MDL-47746. I have
just stripped out the unused code, which fixes the bug where a missing
activity caused a fatal error.
2015-06-17 13:56:41 +01:00
Eloy Lafuente (stronk7) 23e1349810 Merge branch 'MDL-50004-M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE 2015-06-17 01:01:28 +02:00
Eloy Lafuente (stronk7) abf8b970be Merge branch 'MDL-50107-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-06-17 00:16:51 +02:00
AMOS bot b13273c21f Automatically generated installer lang files 2015-06-17 00:04:08 +08:00
AMOS bot 7871b634b2 Automatically generated installer lang files 2015-06-17 00:04:08 +08:00
Dan Poltawski eb98d24713 Merge branch 'MDL-49959_course_dnd_message_MDL28' of https://github.com/barrysspace/moodle into MOODLE_28_STABLE 2015-06-16 13:07:19 +01:00
Martin Mastny 3e8064b84a MDL-49744 JavaScript: Glossary term window is draggable 2015-06-16 10:20:23 +01:00
Andrew Nicols c1b716ed30 Merge branch 'wip-MDL-50216-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-06-16 12:22:59 +08:00
Martin Mastny 3e0a9b33d9 MDL-50216 JavaScript: Default visibility of M.core.info set to false
Conflicts:
	lib/yui/build/moodle-core-notification-dialogue/moodle-core-notification-dialogue-min.js
2015-06-16 11:35:55 +08:00
Andrew Nicols 7c4c64d821 MDL-39353 xmlrpc: Add note to upgrde.txt regarding proxybypass 2015-06-16 11:35:31 +08:00
Andrew Nicols 62a20889ef Merge branch 'MDL-39353-28' of https://github.com/rtcn2/moodle into MOODLE_28_STABLE 2015-06-16 11:34:57 +08:00
Andrew Nicols ca37641c24 Merge branch 'MDL-50380-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-06-16 07:58:42 +08:00
Dan Poltawski 90e175670a Merge branch 'MDL-49368_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-06-15 12:33:31 +01:00
Andrew Nicols 9b7d060c5e Merge branch 'MDL-50459-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-06-15 16:04:56 +08:00
Juan Leyva 346cd40859 MDL-50459 messages: Handle deleted users in external functions 2015-06-15 09:57:51 +02:00
Andrew Nicols 81de8dc4c1 Merge branch 'wip-MDL-50222-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-06-15 15:17:57 +08:00
GeekSmith d932630feb MDL-50583 upgrade: Optimize upgrade_minmaxgrade
Reverse join order to use existing database keys. Changed query to use the
more easily read NOT IN.
2015-06-15 10:41:37 +08:00
Andrew Nicols c7828a7e89 Merge branch 'MDL-50438-28' of git://github.com/mastnym/moodle into MOODLE_28_STABLE 2015-06-15 10:21:53 +08:00
Andrew Nicols 499c254bd9 Merge branch 'MDL-50509-28-vartypo' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-06-15 09:59:45 +08:00
Andrew Nicols b349a501bf MDL-50554 themes: Rebuild of bootstrapbase 2015-06-15 09:47:12 +08:00
Mary Evans 088528038c MDL-50004 theme: Fixes frontpage coursename and enrolment icons.
Conflicts:

	theme/bootstrapbase/style/moodle.css
2015-06-15 00:27:31 +01:00
Gareth J Barnard 8e78b057a3 MDL-50554 themes: Drag a link move mouse makes icons move in Chrome. 2015-06-14 21:49:11 +01:00
Dan Poltawski 49ec7f8b7a weekly release 2.8.6+ 2015-06-12 10:24:40 +01:00
Dan Poltawski 327132f929 Merge branch 'MDL-48618_28-test-calculated' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-06-12 10:19:41 +01:00
Eloy Lafuente (stronk7) c69966dc7b MDL-50176 repository_youtube: delay loading google service stuff
Loading Google client services is a little monster, eating around
2MB (opcache enabled) of memory. As far as we instantiate the
repository instances really early, no matter they are not used
later (editor, file picker, admin...).. we are delaying the
load of the service until we know we are going to use it.

Surely applying this very same (sort of lazy load) techinque
to other repositories could lead to a nice memory reduction
in lots of pages.

MDL-50176 repository_youtube: also delay the inclusion of client.

While memory was fixed with previous commit, still some extra included
files where being reported, so go crazy and move all the stuff to
the new init delayed method.
2015-06-12 10:31:50 +02:00
David Monllao 40765660a8 MDL-48618 grades: Testing calculated items with minmaxtouse 2015-06-12 14:31:29 +08:00
Marina Glancy e5871c89f5 MDL-50568 navigation: correct cap check 2015-06-12 10:46:09 +08:00
Frederic Massart 623ecdaddb MDL-48618 grades: Do not run minmax upgrade for fresh installs 2015-06-11 17:16:52 +08:00
Rajesh Taneja 4facd41f67 MDL-49659 theme_clean: Add login info in the nav bar 2015-06-11 10:00:36 +01:00
David Monllao 8dac9b29d4 MDL-48618 upgrade: Matching conditions and upgrade savepoints 2015-06-11 15:04:15 +08:00
David Monllao bf8ebd6d96 Merge branch 'MDL-48618-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-06-11 14:23:22 +08:00
Juan Leyva 13513264fa MDL-50107 webservices: Enable CORS in login/token.php 2015-06-10 11:34:24 +02:00
Rod Norfor 3b6d698f51 MDL-39353 xmlrpc: Add proxy support 2015-06-10 08:20:48 +01:00
Frederic Massart 965271de64 MDL-48618 grades: Test for the minmax upgrade step 2015-06-10 12:53:07 +08:00
Frederic Massart 4c796650e6 MDL-48618 grades: Behat tests to cover min/max grade changes
The values provided as part of this test are similar to values
that can be found in 2.7. This is to ensure that users will not
experience changes in grades.
2015-06-10 12:53:07 +08:00
Frederic Massart eff9e9ddea MDL-48618 grades: Unit tests for grade_grade::get_min/max_grade() 2015-06-10 12:53:07 +08:00
Frederic Massart 7907689825 MDL-48618 grades: Handling of inconsistencies due to min/max grades 2015-06-10 12:52:43 +08:00
Eric Merrill 582d2448b5 MDL-48618 gradebook: Only use individual min/max for aggrigate grades 2015-06-10 12:44:55 +08:00
Eloy Lafuente (stronk7) b0d06e3c2c Merge branch 'MDL-47480-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-06-10 00:33:28 +02:00
Eloy Lafuente (stronk7) 6d29831de6 Merge branch 'm28_MDL-50415_Add_PHP_Variables_In_PHPInfo_Admin_Page' of https://github.com/scara/moodle into MOODLE_28_STABLE 2015-06-09 20:37:36 +02:00
Eloy Lafuente (stronk7) bbef2dc030 Merge branch 'MDL-50176_28' of git://github.com/aolley/moodle into MOODLE_28_STABLE 2015-06-09 20:14:16 +02:00
Dan Poltawski aeae977eed Merge branch 'MDL-43731-28_STABLE' of https://github.com/ramdesh/moodle into MOODLE_28_STABLE 2015-06-09 14:57:02 +01:00
Dan Poltawski 5b5635628f Merge branch 'MDL-49659_M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE 2015-06-09 14:42:05 +01:00
Marina Glancy adc2d84d49 MDL-50222 admin: do not use deprecated print_textarea() 2015-06-09 20:59:09 +08:00
Dan Poltawski bbfc652b71 Merge branch 'MDL-49885_course_overview_block2_28' of https://github.com/andyjdavis/moodle into MOODLE_28_STABLE 2015-06-09 13:57:25 +01:00
Martin Mastny d89a43f195 MDL-50186 forms: Removed special characters from id attribute 2015-06-09 13:33:03 +01:00
Adam Olley 9e44b9e55d MDL-50176 repository_youtube: Switch to using YouTube Data API
As of April 20, 2015, the old API used by repository_youtube is no longer
accessible. This change switches over to using the standard Google Data
API v3.

Unfortunately this means that to search YouTube, a developer api key is now
*required*.

Special thanks to UNSW for sponsoring this work.
2015-06-09 09:48:22 +09:30
David Mudrák 1d19a5eb47 MDL-50509 datalib: Fix the typo in the variable name
The line is supposed to sanitize the function parameter.
2015-06-08 11:18:02 +02:00
Dave Cooper 3b6b8abc57 MDL-49497 curl: Add configurable User-Agent unit tests. 2015-06-08 17:03:41 +08:00
Dave Cooper 4193196b8f MDL-49497 curl: Allow configurable User-Agent.
Thanks to Kartik Yadav for assistance with this patch.
2015-06-08 17:02:50 +08:00
Barry Oosthuizen cbb3c3e0b9 MDL-49959 course: Fix hidden drag and drop message 2015-06-08 09:33:51 +01:00
Andrew Davis 933a5e26cc MDL-49885 core_blocks: fixed course_overview block applicable_formats() 2015-06-08 06:40:05 +08:00
Juan Leyva a4f93d57ac MDL-50493 forum: Handle correctly qanda forums in get_discussion_posts 2015-06-06 00:01:25 +02:00
Mary Evans b451b66b40 MDL-49659 theme: Removed home link and limited login info in secure.php
Credits: Thanks go to Andreas Hruska [https://github.com/ahruska] for the original patch for this issue.
2015-06-04 17:50:38 +01:00
Eloy Lafuente (stronk7) 570bcd8274 weekly release 2.8.6+ 2015-06-04 12:09:07 +02:00
Eloy Lafuente (stronk7) a777a3f222 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-06-04 12:09:01 +02:00
Rajesh Taneja 5a0a9c8e73 MDL-47995 lib: encode title properly, before additing it to image title 2015-06-04 12:56:30 +08:00
Matteo Scaramuccia fd4ae15898 MDL-50415 Admin: added the PHP Variables section in the PHPinfo page. 2015-06-03 21:23:46 +02:00
Eloy Lafuente (stronk7) c2a0ce47db Merge branch 'MDL-47995-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-06-03 11:11:35 +02:00
Simey Lameze 29010702b2 MDL-50380 mod_wiki: fix missing parameter on wiki edit files page
Also fixing a typo on the $referer variable.
2015-06-03 16:46:06 +08:00
Dan Poltawski 31aa2496d1 Merge branch 'MDL-49323-28' of git://github.com/nmoller/moodle into MOODLE_28_STABLE 2015-06-02 13:23:31 +01:00
Martin Mastny 029972ac7c MDL-50438 filter_glossary: Added missing exception classes 2015-06-02 16:31:50 +08:00
Dan Poltawski 8c37f8667e Merge branch 'MDL-46927_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-06-02 09:03:54 +01:00
Mark Nelson fee1d071bd MDL-46927 core_files: fixed issue with system course restores
When clicking on 'Restore' next to a file in the 'Course
backup area' in the system context the message 'Sorry,
the requested file could not be found' was displayed.
This fix adds missing functionality to the class
'file_info_context_system' so that the file information
is correctly returned.
2015-06-01 23:09:23 -07:00
Ankit Agarwal 6dbe2aaacb MDL-47480 tasks: Define order for getting tasks 2015-06-02 08:18:13 +05:30
AMOS bot 2562ce63d4 Automatically generated installer lang files 2015-06-02 00:04:20 +08:00
Nelson Moller 615d97944e MDL-49323 mod_assign: Fixed numeric validation in grade form.
The behat test for another decimal separator was incorporated.
2015-06-01 11:03:19 -04:00
Dan Poltawski 413288345c Merge branch 'MDL-50341_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-06-01 15:03:47 +01:00
Dan Poltawski 6e09b240bf MDL-50322 forum: add basic split post behat coverage
Also bump version for autoloading new class.
2015-06-01 15:00:01 +01:00
Dan Poltawski 2fef7540f1 Merge branch 'MDL-50322-28' of git://github.com/mastnym/moodle into MOODLE_28_STABLE 2015-06-01 14:55:32 +01:00
Dan Poltawski d0be17a749 Merge branch 'MDL-50304_28' of https://github.com/jinhofer/moodle into MOODLE_28_STABLE 2015-06-01 13:21:57 +01:00
Dan Poltawski c71949dc53 MDL-50406 less: built. 2015-06-01 11:56:51 +01:00
Dan Poltawski cd20ea8b95 Merge branch 'MDL-50406_M28' of git://github.com/nadavkav/moodle into MOODLE_28_STABLE 2015-06-01 11:42:25 +01:00
Dan Poltawski bc1a1aaf32 Merge branch 'MDL-49707-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-06-01 10:22:03 +01:00
Ankit Agarwal 51208a3c32 MDL-49707 inbound: localpart should be < 15 2015-06-01 10:10:09 +05:30
Tim Hunt 01b3b79a94 MDL-50341 quiz statistics: non-attempted questions broke first-try stats
For behaviours that allow multiple tries, and when the teacher had chosen to
generate statistics for the first tries only, and when a student had not
attempted one question, then an error occurred. It should have been classified
as no response.
2015-05-31 13:54:38 +01:00
Nadav Kavalerchik 50885a5b23 MDL-50406 Messages: Right align messages menu box, in RTL mode. 2015-05-30 12:22:39 +03:00
AMOS bot 9d759a8b9e Automatically generated installer lang files 2015-05-30 00:04:09 +08:00
Martin Mastny 183c8315d9 MDL-50322 mod_forum: Added validation when spliting discussions 2015-05-29 09:15:19 +08:00
AMOS bot 9c9f81b9e7 Automatically generated installer lang files 2015-05-29 00:04:03 +08:00
jinhofer fb06f2a87c MDL-50304 atto/plugins/table: Fixed _addRowAfter function 2015-05-28 07:54:17 -05:00
David Monllao 14d2791057 weekly release 2.8.6+ 2015-05-28 10:55:03 +08:00
David Monllao 66296d8f06 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-05-28 10:55:01 +08:00
Eloy Lafuente (stronk7) 6992979404 Merge branch 'wip-mdl-49806-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-05-27 12:52:10 +02:00
David Monllao 537361c5e4 Merge branch 'MDL-50340-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-05-27 11:59:00 +08:00
Rajesh Taneja f6fa9b4997 MDL-49806 behat: Ensure user is marked complete before runnning cron 2015-05-27 09:27:20 +08:00
David Monllao 330930ae62 MDL-49611 completion: Update dangling err_nocriteria lang strings
Credit to Aaron Barnes.
2015-05-27 08:52:59 +08:00
Eloy Lafuente (stronk7) 02ee1effbd Merge branch 'wip-MDL-50191-m28' of https://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-05-26 18:20:00 +02:00
AMOS bot aa0a762aa4 Automatically generated installer lang files 2015-05-27 00:03:54 +08:00
Dan Poltawski b6e389b74a Merge branch 'MDL-50318-28-courseresources' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-05-26 13:05:08 +01:00
Dan Poltawski d4f82690a5 Merge branch 'MDL-49787_email_attachments_symlink_fix_28' of https://github.com/iamandrew/moodle into MOODLE_28_STABLE 2015-05-26 12:56:32 +01:00
Dan Poltawski 744c5a5bb8 Merge branch 'MDL-49776-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-05-26 11:53:56 +01:00
Dan Poltawski 4ef0f57dbc Merge branch 'MDL-49560-28' of git://github.com/gurgus/moodle into MOODLE_28_STABLE 2015-05-26 11:33:47 +01:00
Dan Poltawski d88c3438c5 Merge branch 'MDL-50271-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-05-26 11:31:54 +01:00
David Monllao 8ff5016cef Merge branch 'MDL-50344-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-05-26 17:29:56 +08:00
David Monllao 2efaa63376 Merge branch 'MDL-48664-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2015-05-26 14:46:24 +08:00
Ankit Agarwal 1a7bdd06d7 MDL-50340 adminstration: Fix restore course links 2015-05-26 12:04:13 +05:30
David Monllao d35759ae7d Merge branch 'MDL-46550-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-05-26 12:29:36 +08:00
Ankit Agarwal 4cd93d2596 MDL-50315 behat: I am on site homepage behat step 2015-05-26 12:19:58 +08:00
Jetha Chan f678a6eec0 MDL-48664 output: change paging_bar to not use non-breaking spaces 2015-05-26 12:14:07 +08:00
Dan Poltawski 077eaa11a1 Merge branch 'MDL-50313-28-featureidnumber' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-05-25 13:54:08 +01:00
Dan Poltawski a56d0af3f6 Merge branch 'MDL-40592_M28' of https://github.com/nadavkav/moodle into MOODLE_28_STABLE 2015-05-25 12:28:40 +01:00
Dan Poltawski c237de3747 Merge branch 'MDL-49493-28' of git://github.com/mastnym/moodle into MOODLE_28_STABLE 2015-05-25 12:02:16 +01:00
David Monllao 59c638dc00 Merge branch 'wip-MDL-49572-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-05-25 17:54:59 +08:00
Marina Glancy 421f72704e MDL-49560 webservice: avoid recursion in soap
Thanks to El Leonidych for providing a patch
2015-05-25 16:01:25 +08:00
Ankit Agarwal e49a94cd14 MDL-50344 restore: Make restore file required 2015-05-25 12:08:26 +05:30
spvickers 0444eedad7 MDL-49776 mod_lti: Set parameter in privacy check
Moved sending of the lis_result_sourcedid parameter to within the block
which checks that grades are being accepted for the link.
2015-05-25 13:03:08 +08:00
iclearn 127b75e161 MDL-47995 mod_url: add proper title encoding on url mod 2015-05-25 12:55:40 +08:00
iclearn 42a3d7709d MDL-47995 mod_resource: properly encode resource title 2015-05-25 12:55:40 +08:00
Martin Mastny 69a1435d46 MDL-49493 backup: Implemented missing methods for anonymous backup 2015-05-25 10:41:49 +08:00
AMOS bot 892dba30c6 Automatically generated installer lang files 2015-05-23 00:04:08 +08:00
Juan Leyva caf3cb78e5 MDL-50271 webservices: Allow to load multiple themes in WS_SERVER mode 2015-05-22 13:27:06 +02:00
Damien Bezborodov 811f699514 MDL-50285 gradereport_user: Grade categories calculate wrong with suspended users (Student's view) 2015-05-22 17:53:07 +09:30
Nadav Kavalerchik 851bc55bde MDL-40592 assign/grading: Display default user picture, if none is set. 2015-05-22 10:37:23 +03:00
Tim Hunt 6f1b265a2b MDL-49368 qtypes match & multichice: cope with editing after attempt
Teachers should not radically edit a question after it has been
attempted. However, if they do, we should handle it gracefully, rather
than triggering PHP errors.
2015-05-21 18:17:45 +01:00
AMOS bot 1736fc82fa Automatically generated installer lang files 2015-05-22 00:03:54 +08:00
David Mudrák 2daaae15ea MDL-50318 course: Fix the URL of embedded images at resources overview
Not only mod_resource instances are listed here. All modules that
declare their FEATURE_MOD_ARCHETYPE as MOD_ARCHETYPE_RESOURCE (well, all
but those without own view page, such as mod_label) are listed. So we
must use the real plugin name when rendering the intro field.
2015-05-21 17:18:05 +02:00
David Mudrák 5157d7e013 MDL-50313 docs: Fix the documentation for the FEATURE_IDNUMBER constant
The constant is used by course/moodleform_mod.php to decide whether the
field 'ID number' (cmidnumber) should be included in the common module
settings section of the activity settings form. Activity modules that do
not use grades (such as the Label) can explicitly return false when
checking for this feature support. By default, all activity modules are
supposed to support it.
2015-05-21 16:50:15 +02:00
Eloy Lafuente (stronk7) 08d1c32b45 weekly release 2.8.6+ 2015-05-21 12:37:20 +02:00
Marina Glancy a5dcc1b90f MDL-50191 cohorts: check manage cap to display hide icon 2015-05-21 12:19:38 +08:00
Marina Glancy 4b74b4791f MDL-49572 cache: correctly purge cache on event 2015-05-20 14:06:43 +08:00
Rajesh Taneja 5a554e9746 MDL-49061 behat: Fixed input name to use full activity name 2015-05-20 10:19:10 +08:00
Eloy Lafuente (stronk7) 6c05d34bf4 Merge branch 'wip-mdl-50259-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-05-19 18:02:51 +02:00
Eloy Lafuente (stronk7) f790a5d1e4 Merge branch 'MDL-50275-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-05-19 17:46:03 +02:00
Dan Poltawski 9cc1cf5808 Merge branch 'MDL-49680_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE 2015-05-19 16:36:41 +01:00
Dan Poltawski cf14d5d951 MDL-50275 quiz: version bump for MDL-49941
Otherwise the new capability risk does not get loaded
2015-05-19 15:41:25 +01:00
Dan Poltawski 39baf6a0e2 Merge branch 'wip-MDL-49061-m28' of https://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-05-19 15:00:53 +01:00
Dan Poltawski ed1b321918 Merge branch 'wip-mdl-50203-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-05-19 12:39:00 +01:00
Rajesh Taneja 5dcbbcc117 MDL-50259 behat: Use strict activity name checking
contains might select wrong activity
so using strict activity text checking
2015-05-19 14:48:29 +08:00
Mark Nelson 8ee8195650 MDL-49680 core_question: added ability to order questions by dates
Backport of MDL-25721.
2015-05-18 19:06:09 -07:00
Skylar Kelty f8e680ca11 MDL-50169: Fix grade report SQL logic 2015-05-19 02:04:11 +02:00
Eloy Lafuente (stronk7) a942187816 Merge branch 'MDL-50280_28' of https://github.com/sk-unikent/moodle into MOODLE_28_STABLE 2015-05-19 01:43:21 +02:00
Eloy Lafuente (stronk7) fdcf4144dc Merge branch 'MDL-48467-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-05-19 01:33:14 +02:00
Eloy Lafuente (stronk7) da8ee816a7 Merge branch 'MDL-50197_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-05-19 00:35:47 +02:00
Eloy Lafuente (stronk7) 3c68e824d7 Merge branch 'MDL-50245_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-05-19 00:33:25 +02:00
Skylar Kelty 9d472d7319 MDL-50280 WebCT import scripts don't always clean up 2015-05-18 16:49:27 +01:00
Dan Poltawski f53c8c2a02 Merge branch 'MDL-49764_28' of https://github.com/jinhofer/moodle into MOODLE_28_STABLE 2015-05-18 15:29:02 +01:00
Dan Poltawski f324728737 Merge branch 'MDL-50092_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-05-18 13:59:50 +01:00
jinhofer ecf17cfd73 MDL-49764 grade/report/grader: Fixed height issue for IE 2015-05-18 07:48:14 -05:00
Dan Poltawski e8b9d60c27 Merge branch 'MDL-50177_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-05-18 13:01:48 +01:00
Andrew Davidson 4ee8f04bef MDL-49787 email: Updated email attachement path check to use realpath() in order to allow for symlinked temp directories 2015-05-18 12:04:50 +01:00
Ankit Agarwal b3b4c00d5b MDL-46550 logs: Fix incorrect url
Thanks to Nadav Kavalerchik for the suggestion on patch
2015-05-18 12:02:36 +05:30
Adrian Greeve cfa002f6ee MDL-49742 lib: Removed additional names on tables for sorting.
When additional names are disabled, they are no longer shown as
sortable headings in the enrolment and admin user tables.
2015-05-15 15:33:52 +08:00
Tim Hunt e5636f9aa4 MDL-50245 quiz: fix CSS of search options in the qbank dialogue 2015-05-14 14:41:22 +01:00
David Monllao 18202cbed7 weekly release 2.8.6+ 2015-05-14 11:34:27 +08:00
Rajesh Taneja bb4bc850f4 MDL-50203 behat: Click on link in student 1 row 2015-05-13 15:23:40 +08:00
Marina Glancy 5f7d350f72 MDL-49061 reports: call format_string on activities names 2015-05-13 12:18:31 +08:00
David Monllao 7ce3c31e12 Merge branch 'MDL-25138-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-05-13 10:26:00 +08:00
Damyon Wiese e9f173e2d4 MDL-25138 core_tags: remove duplicated related tags 2015-05-12 13:07:01 +08:00
Simey Lameze 916ac383ef MDL-25138 core_tag: fix correlated tags query unique error 2015-05-12 13:07:00 +08:00
David Monllao d1d546a0c4 MDL-50177 completion: Also accepting cm integer strings 2015-05-12 12:21:55 +08:00
David Monllao b26f0f688f Merge branch 'MDL-34102_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-05-12 12:12:50 +08:00
Tim Hunt bcda2f3745 MDL-50197 quiz editing: fix dialogue titles at the end of the quiz 2015-05-11 16:22:16 +01:00
David Monllao d11eec562a MDL-50092 enrol_imsenterprise: Fixing wrong field name
Thanks to JD for the fix.
2015-05-11 14:55:15 +08:00
Eloy Lafuente (stronk7) dc7b914677 Moodle release 2.8.6 2015-05-10 11:39:22 +02:00
Eloy Lafuente (stronk7) 8f018d49ac weekly release 2.8.5+ 2015-05-08 12:14:47 +02:00
Eloy Lafuente (stronk7) 5a71a6b7e5 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-05-08 12:14:30 +02:00
Andrew Nicols 0fee379892 MDL-50153 messageinbound: Normalise line endings instead of rtrim 2015-05-08 16:20:44 +08:00
Andrew Nicols 51483fe057 Merge branch 'wip-mdl-50154-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-05-08 13:42:17 +08:00
Rajesh Taneja cb2cf4a6a7 MDL-50154 behat: Click on Grades link under navigation 2015-05-08 13:08:38 +08:00
Rajesh Taneja b9acc1422a MDL-50154 behat: Resize pdf window so toolbar is always visible 2015-05-08 13:08:13 +08:00
Andrew Nicols 2ca3c8ad0d MDL-50153 messageinbound: Make messageinbound tests dos-safe 2015-05-08 12:17:21 +08:00
Andrew Nicols c1108ed7fc MDL-50153 core: Use directory_separator when autoloading psr0 classes 2015-05-08 12:17:20 +08:00
Ramindu Deshapriya c408fe813c MDL-43731 mod_book: Added Behat test to automate MDLQA-1791 2015-05-08 00:43:42 +05:30
Adrian Greeve b3ec0280ea MDL-50039 tool_monitor: Behat update to fix error.
The teacher does not have the option to select Site
level rules so this section has been removed.
2015-05-07 13:13:21 +08:00
Adrian Greeve ac6f7b18be MDL-50039 tool_monitor: Additional checks for subscription.
Additional capability checks are now in place to stop unauthorised
users from accessing the event monitor subscription page.
2015-05-07 13:13:21 +08:00
Frederic Massart c3bec9f51e MDL-50128 mod_data: String needed escaping before being used in regex 2015-05-07 11:21:09 +08:00
Andrew Nicols d186a97e10 Merge branch 'm28_MDL-50133' of https://github.com/danmarsden/moodle into MOODLE_28_STABLE 2015-05-07 10:25:18 +08:00
Andrew Nicols c1452371db Merge branch 'MDL-49783-28' of git://github.com/mastnym/moodle into MOODLE_28_STABLE 2015-05-07 09:42:51 +08:00
Martin Mastny 835bbc41fd MDL-49783 forms: Collapsed form section is opened on error 2015-05-07 09:14:34 +08:00
Dan Marsden 1a0d12e4a2 MDL-50133 mod_scorm: use correct captypes 2015-05-07 11:46:23 +12:00
Marina Glancy 032f18c4a5 MDL-49788 navigation: Ensure we only check active enrolments 2015-05-06 08:02:45 +01:00
Salih Gedik d7f66ebe07 MDL-49789 mod_book: filter book chapter content 2015-05-06 13:55:07 +08:00
Marina Glancy 7f5bd0da0e MDL-49718 externallib: unittest correction 2015-05-06 13:01:53 +08:00
Marina Glancy 98c38993fd MDL-50090 user: suspended user can login upon conrimation 2015-05-06 11:01:20 +08:00
Juan Leyva 77067fbb3a MDL-49718 webservices: Fix forced format and force external text cleaning 2015-05-06 10:56:17 +08:00
Juan Leyva 8e8ee75304 MDL-49994 files: Prevent to browse private files when are disabled 2015-05-06 10:27:32 +08:00
AMOS bot 9a1dc85511 Automatically generated installer lang files 2015-05-06 00:03:57 +08:00
Marina Glancy e2e7e35da3 MDL-50099 auth: less verbose account confirmed message 2015-05-05 15:33:50 +01:00
Frederic Massart 8c45d46d36 MDL-49179 setuplib: print_error() uses local URLs exclusively 2015-05-05 18:31:14 +08:00
Frederic Massart 17b8efa585 MDL-49179 weblib: Secure the direct usage of $_SERVER['HTTP_REFERER'] 2015-05-05 18:31:14 +08:00
Frederic Massart 71c1cfb143 MDL-49179 mod_forum, mod_quiz: Prevent misuse of get_referer() 2015-05-05 18:31:14 +08:00
Tim Hunt 1ce4f44df7 MDL-49941 quiz: mod/quiz:grade should declare RISK_XSS 2015-05-05 18:31:14 +08:00
Frederic Massart 9bf7fea937 MDL-49401 moodlelib: PARAM_LOCALURL supports loginhttps 2015-05-05 18:31:14 +08:00
Eloy Lafuente (stronk7) f3895b00a5 weekly release 2.8.5+ 2015-05-05 12:28:47 +02:00
David Monllao 1b1d0419a4 Merge branch 'wip-MDL-49778-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-05-05 15:05:50 +08:00
David Monllao a86de7c0d9 Merge branch 'MDL-49227-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-05-05 14:36:55 +08:00
Adrian Greeve ec2a1ba2fe MDL-49778 lib: Update to upgrade_stale_php_files_present() 2015-05-05 12:45:24 +08:00
Andrew Nicols 9b94fabcb0 MDL-48002 inbound: Tidy up language in unit test 2015-05-05 10:59:49 +08:00
David Monllao 2cd81b11b1 Merge branch 'MDL-50055-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-05-05 10:52:07 +08:00
David Monllao 6cb5fe8472 Merge branch 'MDL-49848-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-05-05 10:38:45 +08:00
John Okely 33b16dd3cd MDL-49848 message: Make messaging interface responsive 2015-05-05 10:31:52 +08:00
Andrew Nicols d4b4f96e6c MDL-50055 enrol: Stop requiring javascript for behat tests 2015-05-05 10:24:30 +08:00
Andrew Nicols 5e3fca4d3b MDL-50055 tests: Add new step to deal with Single Selects 2015-05-05 10:24:29 +08:00
David Monllao eaa13b3809 Merge branch 'MDL-48002-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-05-05 10:21:46 +08:00
Ankit Agarwal a2d176c2ed MDL-48002: inbound: Add outlook fixture 2015-05-04 15:21:51 +05:30
Ankit Agarwal d9e191b89e MDL-48002 inbound: Update regex for token matching 2015-05-04 15:21:51 +05:30
Ankit Agarwal 813c1136bc MDL-48002: inbound: Add ios fixture 2015-05-04 15:21:51 +05:30
Ankit Agarwal 149017a96c MDL-48002 inbound: Update fixtures to add client info 2015-05-04 15:21:51 +05:30
Ankit Agarwal e945517d66 MDL-48002 inbound: add tests for evolution 2015-05-04 15:21:51 +05:30
Andrew Nicols c712250d6b MDL-48002 inbound Unit tests from fixtures for quoted text 2015-05-04 15:21:51 +05:30
Ankit Agarwal e39a1db7b6 MDL-48002 inbound: Remove quoted text from forum emails 2015-05-04 15:21:51 +05:30
David Monllao d63c8ec710 Merge branch 'MDL-49954-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-05-04 15:16:19 +08:00
Andrew Nicols 62383073f5 MDL-49227 mod_forum: Improve discussion subscription on post
If the user has posted in the forum before, follow their previous
discussion preference.

If the user has not posted before, but is subscribed to the forum, follow
their forum preference.

Otherwise, follow their user-preference.

This has the result that if a user has unsubscribed from a forum and writes
their first response; the user preference will be followed. This may
override the forum subscription.

This commit also changes from a dropdown to a checkbox in the post form.

This is a backport of MDL-48221
2015-05-04 09:56:05 +08:00
Andrew Nicols 0013192227 Merge branch 'wip-mdl-50103-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-05-04 09:39:03 +08:00
David Monllao 1be0ead2d4 MDL-50103 mod_assign: Fixing behat test
The participant number is dynamically generated so it is not possible to
match known values.

Match on the submission text instead.
2015-05-04 09:33:05 +08:00
Andrew Nicols 5c8bc25cd1 Merge branch 'wip-MDL-50066-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-05-04 09:14:48 +08:00
David Monllao 0706e7ac17 weekly release 2.8.5+ 2015-05-01 16:47:25 +08:00
David Monllao 8069916549 MDL-49232 enrol_self: Adapting unit test to new can_self_enrol() output 2015-05-01 15:49:10 +08:00
Andrew Nicols f293278132 Merge branch 'MDL-49232_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-05-01 09:27:41 +08:00
Dan Poltawski e6a09c5359 Merge branch 'MDL-50028_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-04-30 16:07:16 +01:00
Jean-Michel Vedrine 06e7de3d96 MDL-34102 mod_lesson: display feedback
Feedback for incorrect answer was not diplayed when
Provide option to try a question again was set to Yes.

Conflicts:
	mod/lesson/locallib.php
2015-04-30 13:14:42 +02:00
Marina Glancy ed402015bb MDL-50066 strings: unable to deprecate string from moodle.php 2015-04-30 16:15:24 +08:00
Andrew Nicols 9495b310e5 Merge branch 'MDL-49583-m28' of https://github.com/NeillM/moodle into MOODLE_28_STABLE 2015-04-30 15:11:42 +08:00
Andrew Nicols e3a371a7a1 Merge branch 'MDL-50038-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-04-30 14:56:30 +08:00
David Monllao a3a4c4f028 Merge branch 'MDL-49281-28' of git://github.com/mastnym/moodle into MOODLE_28_STABLE 2015-04-30 14:54:04 +08:00
Martin Mastny 986ee9fd2a MDL-49281 grades: Calculation settings upgraded 2015-04-30 13:43:45 +08:00
Andrew Nicols 95bfd8108b Merge branch 'MDL-50033-28-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-04-30 10:51:37 +08:00
Andrew Nicols 23eee911ef MDL-49232 enrol_self: Add behat test for non-guest self-enrolment 2015-04-29 18:02:45 -07:00
Mark Nelson bbaf38b921 MDL-49232 enrol_self: display continue button 2015-04-29 18:02:44 -07:00
David Mudrák a0deded716 MDL-50033 lang: Update Behat scenario to use the new string 2015-04-29 23:35:28 +02:00
Helen Foster cdf4ba9549 MDL-50033 lang: Merge English strings from the en_fix language pack 2015-04-29 23:22:36 +02:00
Frederic Massart 4127b60cb5 MDL-50038 my: Redirect admin users to the notifications page when needed 2015-04-29 19:05:36 +08:00
Neill Magill eaba80f68d MDL-49583 enrol: enrol/index.php page doesn't handle direct access well
Before this patch if a user who is not logged in to Moodle accesses the
enrol/index.php page directly they were redirected to the Moodle front
page after login, rather than back to a page that would allow them to
self enrol, if it is enabled on the course.

This change will cause a user who directly accesses the page to be
redirected back to it after they have logged in, unless the course has guest
access enabled.

Thanks to Marina Glancy for suggesting the use of get_referer()
2015-04-29 09:19:00 +01:00
David Monllao 32f86cd8e9 Merge branch 'MDL-49637-m28' of git://github.com/NeillM/moodle into MOODLE_28_STABLE 2015-04-29 12:05:09 +08:00
Tim Hunt 00d5b5c9a3 MDL-50028 qtype_match: fix correct answer display
Atto's stupid tendency to create HTML like
<p>You don't need a br at the end of a paragraph!</br></p>
was breaking it.
2015-04-28 13:08:24 +01:00
Tim Hunt a81b8267c7 MDL-50028 questions: split into one testcase class per file 2015-04-28 13:08:22 +01:00
Dan Poltawski 9fb9aa7215 weekly release 2.8.5+ 2015-04-28 09:28:06 +01:00
Dan Poltawski 0309e1e39d Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-04-28 09:28:04 +01:00
Neill Magill 895d6c75a4 MDL-49637 assign: Workflow & blind marking do not always show feedback
Before this patch if an assignment has workflow and blind marking enabled if a teacher
sets a submission to have its grades released to students before they reveal student
identities the feedback they have given is not displayed to the student.

The patch causes the reveal_identities() method to pass the correct value to the
get_feedback_plugin_by_type() function in the assign class.
2015-04-28 09:09:08 +01:00
Neill Magill 4358b705e5 MDL-49637 assign: Behat test for blind marking with workflow
This test checks that that if reveal student identities is used before or after the submissions grades have
been set released that the teacher's feedback is displayed to students.
2015-04-28 09:08:53 +01:00
David Monllao 39daab950a Merge branch 'MDL-42449-2.8' of git://github.com/andrewhancox/moodle into MOODLE_28_STABLE 2015-04-28 11:08:29 +08:00
Andrew Nicols 3c3c41682c Merge branch 'MDL-49926-28' of git://github.com/mastnym/moodle into MOODLE_28_STABLE 2015-04-28 10:27:12 +08:00
Martin Mastny 93e4b10b8e MDL-49926 gradereport: Cursor changes to pointer on hover 2015-04-28 10:23:03 +08:00
David Monllao f8ef412113 Merge branch 'MDL-49911-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-04-28 09:47:01 +08:00
Juan Leyva 0c19d0828a MDL-49954 forum: Use clean_returnvalue properly in external unit tests 2015-04-27 18:26:06 +02:00
AMOS bot ee0cb8eb8d Automatically generated installer lang files 2015-04-28 00:04:14 +08:00
Dan Poltawski 5ff4e7ad7b Merge branch 'MDL-49993_28' of git://github.com/grabs/moodle into MOODLE_28_STABLE 2015-04-27 14:48:00 +01:00
Dan Poltawski 08c051c00b Merge branch 'MDL-49913_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-04-27 14:28:28 +01:00
Dan Poltawski 6a2192e887 Merge branch 'MDL-49977_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-04-27 10:53:18 +01:00
Andreas Grabs 6a7b2dd0cb MDL-49993 mod_feedback: Question auto numbers have no space between number and question 2015-04-26 19:04:21 +02:00
AMOS bot 796987c5f6 Automatically generated installer lang files 2015-04-25 00:04:08 +08:00
Andrew Hancox 8a5908a9b3 MDL-42449 backup: Fix for activity grade category
Retain grade category when restoring an activity into the course that
it came from
2015-04-24 14:01:31 +01:00
Dan Poltawski ee056895a3 weekly release 2.8.5+ 2015-04-24 12:10:52 +01:00
Dan Poltawski e61f453067 Merge branch 'MDL-49960-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-04-24 09:06:40 +01:00
Frederic Massart 2607a4e671 MDL-49911 admin: Prevent notices when updatenotifications is disabled 2015-04-24 14:49:15 +08:00
Martin Mastny 1ac7e7e5c8 MDL-49926 gradereport: Feedback gets saved when editing grade in ajax mode 2015-04-24 13:17:01 +08:00
Andrew Nicols e5bb411fe4 Merge branch 'MDL-49311-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-04-24 11:40:37 +08:00
papillon a65ba62f66 MDL-49311 user: fix default sorting problem 2015-04-24 09:13:53 +08:00
Mark Nelson 197824b5f8 MDL-49977 mod_assign: added missing page titles 2015-04-23 17:08:49 -07:00
Dan Poltawski 4a1a78244e Merge branch 'MDL-49946_28' of https://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-04-23 13:32:36 +01:00
Frederic Massart 53318d9fce MDL-49960 message: Adding behat test for recent conversations 2015-04-23 14:55:52 +08:00
Jean-Michel Vedrine a1be2ce57d MDL-49913 mod_lesson: studentanswer format should be HTML 2015-04-23 08:28:36 +02:00
Jean-Michel Vedrine 19a6d37b9f MDL-49913 mod_lesson: fix import scores and jumps 2015-04-23 08:28:34 +02:00
Jean-Michel Vedrine 34acf52a3f MDL-49913 mod_lesson: defaultanswer to avoid duplication 2015-04-23 08:28:31 +02:00
Jean-Michel Vedrine 837c7f5696 MDL-49913 mod_lesson: round question grades on import 2015-04-23 08:28:28 +02:00
Andrew Nicols 1498e02eba Merge branch 'MDL-49319_backport_28' of https://github.com/andyjdavis/moodle into MOODLE_28_STABLE 2015-04-23 14:13:51 +08:00
Andrew Nicols 1007677df4 Merge branch 'MDL-49477-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-04-23 13:52:15 +08:00
Andrew Nicols 38bf1824f8 Merge branch 'MDL-34921_28_unwanted-sitehome-redirects' of https://github.com/colin-umn/moodle into MOODLE_28_STABLE 2015-04-23 12:28:21 +08:00
Andrew Nicols e08df28765 Merge branch 'MDL-49613-m28' of https://github.com/NeillM/moodle into MOODLE_28_STABLE 2015-04-23 11:20:50 +08:00
Jean-Michel Vedrine 0de51e6ad1 MDL-49946 mod_lesson: improve qformat_default::defaultquestion 2015-04-22 19:49:59 +02:00
Dan Poltawski 52388b1bb4 Merge branch 'MDL-49921-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-04-22 16:41:35 +01:00
Andrew Davis 19a4bdb7f4 MDL-49319 core_registration: altered registration strings 2015-04-22 20:00:05 +08:00
Viduranga Wijesooriya cfd867e7d9 MDL-49477 availability_grade-form: checkbox disable problem fixed
Signed-off-by: Viduranga Wijesooriya <vpowerrc@gmail.com>
2015-04-22 17:35:41 +08:00
Tony Butler e8062e2cfe MDL-49933 mod_assign: Sort marker select lists alphabetically by name 2015-04-22 17:02:39 +08:00
Neill Magill e115db6dce MDL-49613 access: count_role_users gives unexpected results
The count_role_users function in lib/accesslib.php gives the wrong results if a user has the
same role at multiple levels in a context path.

For example a user is a coursecreator on a course and the category that the course is in,
in this case they would be counted twice, rather than being recognised as the same user.

This change will make the function only count unique users.
2015-04-22 09:31:27 +01:00
Neill Magill dd97173944 MDL-49613 access: Unit test for count_role_users 2015-04-22 09:31:26 +01:00
Juan Leyva 5f155af825 MDL-49921 forum: Handle exceptions correctly in get_forums_by_courses 2015-04-22 09:48:31 +02:00
Andrew Nicols c40fbd5e14 Merge branch 'MDL-49753-m28' of https://github.com/alexmitin/moodle into MOODLE_28_STABLE 2015-04-22 11:05:07 +08:00
Dan Poltawski 8fc43b0d64 weekly release 2.8.5+ 2015-04-21 11:16:27 +01:00
Dan Poltawski 8543e7c0d0 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-04-21 11:16:25 +01:00
Andrew Nicols fa35ed9955 MDL-40811 uploaduser: Optimise testuser code 2015-04-21 11:35:48 +08:00
Andrew Nicols b6f2ac8c59 Merge branch 'MDL-40881_M28' of https://github.com/nadavkav/moodle into MOODLE_28_STABLE 2015-04-21 11:34:20 +08:00
Brian Barnes c41e9a3312 MDL-49782 general: removed uses of window.status 2015-04-21 10:46:02 +08:00
AMOS bot 0ccc3820c4 Automatically generated installer lang files 2015-04-21 00:04:20 +08:00
Andrew Nicols 42adb9f74a Merge branch 'wip-mdl-49799-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-04-20 12:27:41 +08:00
David Monllao 5e67fb9442 Merge branch 'MDL-48187_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-04-20 12:20:04 +08:00
David Monllao 4d83fde993 Merge branch 'wip-MDL-49880-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-04-20 12:13:00 +08:00
Mark Nelson fb3a9ecb92 MDL-48187 core_course: use updated '$grade_item' 2015-04-19 20:30:34 -07:00
Rajesh Taneja 768d7fca5f MDL-49799 behat: replaced asd.com with example.com
asd.com is a valid domain, we should use reserved domain names for testing
2015-04-20 11:23:28 +08:00
David Monllao f5095227d3 Merge branch 'm28_MDL-49904' of git://github.com/totara/moodle into MOODLE_28_STABLE 2015-04-20 10:40:57 +08:00
Adrian Greeve 0485403978 MDL-49880 mod_lesson: Fixed notice while importing questions.
Cloze questions (not supported by lesson) threw up a notice saying that
the course wasn't set.
2015-04-20 08:41:09 +08:00
Dan Poltawski 81e0be88e9 weekly release 2.8.5+ 2015-04-17 10:53:53 +01:00
Dave Cooper da1af82875 MDL-49573 gradereport_singleview: Add tests for bulk grade inserts 2015-04-17 12:56:15 +08:00
David Monllao 52c475e082 Merge branch 'MDL-48723_28_forum-plagiarism_errors' of git://github.com/colin-umn/moodle into MOODLE_28_STABLE 2015-04-17 10:41:35 +08:00
Brian Barnes 2f2e2a3cc2 MDL-49904 user: set title when editing another user 2015-04-17 11:57:23 +12:00
Dan Poltawski 4140295c9f Merge branch 'MDL-49894-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-04-16 16:10:26 +01:00
Dan Poltawski 9d40bd98be Merge branch 'MDL-49573-28' of git://github.com/gurgus/moodle into MOODLE_28_STABLE 2015-04-16 16:08:24 +01:00
Juan Leyva c58cafbbaa MDL-49894 forum: Add deprecated information for get_forum_discussions 2015-04-16 15:21:58 +02:00
Dan Poltawski d902884587 Merge branch 'MDL-49837-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-04-16 12:17:51 +01:00
David Monllao 2a5a747fec Merge branch 'MDL-45131-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-04-16 17:04:56 +08:00
Juan Leyva 19ddaeb782 MDL-45131 notes: Add validation for returned parameters in WS tests 2015-04-16 10:35:52 +02:00
Juan Leyva 43d7576332 MDL-45131 course: Add validation for returned parameters in WS tests 2015-04-16 10:34:48 +02:00
Juan Leyva a1b54310e1 MDL-45131 user: Add validation for returned parameters in WS tests 2015-04-16 10:33:40 +02:00
Juan Leyva 728b068e24 MDL-45131 message: Add validation for returned parameters in WS tests 2015-04-16 10:33:40 +02:00
Juan Leyva 772f17a280 MDL-45131 files: Add validation for returned parameters in WS tests 2015-04-16 10:33:39 +02:00
Juan Leyva db4f496b52 MDL-45131 enrol: Add validation for returned parameters in WS tests 2015-04-16 10:33:38 +02:00
Juan Leyva 58611999f3 MDL-45131 cohort: Add validation for returned parameters in WS tests 2015-04-16 10:32:42 +02:00
Juan Leyva 1bfd51f16b MDL-45131 calendar: Add validation for returned parameters in WS tests 2015-04-16 10:32:41 +02:00
Dave Cooper c40624308f MDL-49573 gradereport_singleview: Add tests for bulk grade inserts 2015-04-16 13:26:47 +08:00
Dave Cooper 7fc9e24121 MDL-49573 gradereport_singleview: Fixed bulk insert override logic. 2015-04-16 13:26:46 +08:00
Skylar Kelty 4b55cb7109 MDL-49489 caching: Prevent full coursecontact purge 2015-04-16 07:49:59 +08:00
Dan Poltawski 27b7886b44 Merge branch 'MDL-49763-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-04-15 15:53:18 +01:00
Dan Poltawski 5ac077568d Merge branch 'MDL-49803_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-04-15 15:06:18 +01:00
David Monllao 1927f330c4 Revert "MDL-46963 core_upgrade: change the call to guess_antelope_row_size"
This reverts commit 55f4e4c9cf.
2015-04-15 15:52:51 +08:00
David Monllao e9e274d60b MDL-49803 mod_quiz: Fixing overrides restore 2015-04-15 15:30:26 +08:00
Simey Lameze 55f4e4c9cf MDL-46963 core_upgrade: change the call to guess_antelope_row_size 2015-04-15 15:01:34 +08:00
David Monllao e712433e97 Merge branch 'MDL-46963-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-04-15 13:36:48 +08:00
Nadav Kavalerchik e5e43e747a MDL-40881 uploaduser: Validate profile fields unique values 2015-04-14 19:12:10 +03:00
Dan Poltawski eb5fab4fd9 weekly release 2.8.5+ 2015-04-14 16:49:13 +01:00
Dan Poltawski 10787caae9 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-04-14 16:49:10 +01:00
Rajesh Taneja e2ca0b6e67 MDL-44611 behat: Description is required field and should be set 2015-04-14 12:16:49 +08:00
AMOS bot 36e07617ed Automatically generated installer lang files 2015-04-14 00:04:15 +08:00
Juan Leyva 7dedfc8b79 MDL-49837 assign: Use correct assertions and fix return params cleaning 2015-04-13 17:38:09 +02:00
Juan Leyva 88045d94ae MDL-49837 assign: Fix external functions return declaration
Incorrect use of external_warnings function
2015-04-13 17:38:00 +02:00
Dan Poltawski 1cc2d506aa Merge branch 'MDL-48702_backport_log' of https://github.com/andyjdavis/moodle into MOODLE_28_STABLE 2015-04-13 16:26:46 +01:00
Dan Poltawski 2d21dc38c6 Merge branch 'MDL-49166_site_rego_28' of https://github.com/andyjdavis/moodle into MOODLE_28_STABLE 2015-04-13 15:34:26 +01:00
Dan Poltawski d09ef20526 Merge branch 'MDL-49756-28' of git://github.com/mr-russ/moodle into MOODLE_28_STABLE 2015-04-13 15:05:42 +01:00
Andrew Nicols 351460000d Merge branch 'MDL-49426-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-04-13 14:32:35 +08:00
Simey Lameze 742bb09d38 MDL-46963 environment: add check for antelope row format 2015-04-13 14:24:50 +08:00
Andrew Nicols 71d8fb3c66 Merge branch 'MDL-33328_search_enrol_users_MDL28' of https://github.com/barrysspace/moodle into MOODLE_28_STABLE 2015-04-13 13:47:36 +08:00
Andrew Nicols 7955764966 Merge branch 'MDL-49762_M28' of git://github.com/nadavkav/moodle into MOODLE_28_STABLE 2015-04-13 13:39:36 +08:00
Andrew Nicols 7d621c689b Merge branch 'MDL-48836_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE 2015-04-13 13:28:53 +08:00
Ramindu Deshapriya eced61f6d1 MDL-44611 core_course: Added Behat test to automate MDLQA 5252 2015-04-13 11:12:57 +08:00
AMOS bot 11d14cacb9 Automatically generated installer lang files 2015-04-13 00:04:14 +08:00
Russell Smith 5ff1820a1f MDL-49756 course: Add unit tests for section_options. 2015-04-11 07:44:44 +10:00
Russell Smith 886fc0ba20 MDL-48836 backup: Use a trie for grouped path detection.
Backport of MDL-41674.
2015-04-10 14:11:47 -07:00
Juan Leyva e51a432d0f MDL-49763 webservices: Handle correctly deleted users for forums 2015-04-10 22:28:15 +02:00
Juan Leyva c8d1553d0e MDL-49426 webservices: Allow upload to draft area always 2015-04-10 10:44:47 +02:00
David Monllao 538b837c62 Merge branch 'MDL-49575-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-04-10 15:11:25 +08:00
Barry Oosthuizen b99dcf40fd MDL-33328 enrol_manual: use correct parameter in search function
Searching for user from "Enrol users" panel causes blocks to dock in IE
2015-04-09 19:01:24 +01:00
Nadav Kavalerchik 1ae727b538 MDL-49762 Atto: Set HTML directionality to LTR, in RTL mode. 2015-04-09 16:10:43 +03:00
Dan Poltawski d705b4abb4 weekly release 2.8.5+ 2015-04-09 10:27:07 +01:00
Dan Poltawski c3c06055f0 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-04-09 10:27:05 +01:00
Frederic Massart 6d2a555f8e MDL-49575 gradereport_singleview: Regrade item when (un)overriding 2015-04-09 16:26:19 +08:00
Colin Campbell 08fe5496d1 MDL-48723 mod/forum: Fix cron task error on digest attachments. 2015-04-08 13:06:13 -05:00
Andrew Davis 2721dc593e MDL-49166 registration: now states whether or not site is registered 2015-04-08 20:51:05 +08:00
AMOS bot 8efba305f2 Automatically generated installer lang files 2015-04-08 00:04:15 +08:00
Damyon Wiese 7d33c56890 Merge branch 'MDL-49736_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-04-07 21:43:47 +08:00
Eloy Lafuente (stronk7) 6dbfaf2235 Merge branch 'MDL-48205_28' of https://github.com/totara/openbadges into MOODLE_28_STABLE 2015-04-07 14:21:31 +02:00
Brendan Heywood be72c3df67 MDL-49740 Lock: Fixed task lock release bugs 2015-04-07 13:09:36 +01:00
David Monllao 996e83fdd4 MDL-43558 theme_base: We don't need edit toggle if modeditingmenu is disabled 2015-04-07 16:25:31 +08:00
David Monllao 1758e6efc0 Merge branch 'MDL-37984-28' of git://github.com/mastnym/moodle into MOODLE_28_STABLE 2015-04-07 16:08:43 +08:00
Alex Mitin c1e53206d1 MDL-49753 enrolments: preselct status filter if needed 2015-04-07 15:53:45 +08:00
Andrew Nicols 8527d33766 MDL-49395 core: add more unit tests for get_enrolled_sql 2015-04-07 15:29:07 +08:00
Andrew Nicols c7b415e792 Merge branch 'suspended_userids_memory_28' of git://github.com/tlevi/moodle into MOODLE_28_STABLE 2015-04-07 15:29:01 +08:00
Dan Poltawski 2615ec14ad Merge branch 'mdl38210-moodle28' of https://github.com/tlock/moodle into MOODLE_28_STABLE 2015-04-06 12:36:07 +01:00
Colin Campbell cf862db4bc MDL-34921 course/format: Fix unwanted redirects from Site home 2015-04-03 16:00:19 -05:00
AMOS bot 608ab1c385 Automatically generated installer lang files 2015-04-04 00:04:10 +08:00
Eloy Lafuente (stronk7) badfcb70e4 weekly release 2.8.5+ 2015-04-02 11:49:02 +02:00
David Monllao c582672225 MDL-46805 mod_scorm: Re-fix as previous object was removed in 2.8 2015-04-02 09:21:26 +01:00
Rajesh Taneja d406c3893e MDL-46805 scorm: Set user_id if scorm|aiccuserid config is set 2015-04-02 15:43:49 +08:00
Tony Levi 8e602172ff MDL-49395 accesslib: Make get_suspended_userids more efficient 2015-04-02 13:54:50 +10:30
Rajesh Taneja d21f9cc2dd MDL-49513 behat: Updated step name to match new step 2015-04-02 09:47:26 +08:00
Andrew Nicols 240d90b149 Merge branch 'MDL-49686-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE
Conflicts:
	lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor-min.js
2015-04-01 18:47:53 +08:00
Andrew Nicols 47f8e3e117 Merge branch 'wip-mdl-49513-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-04-01 18:34:08 +08:00
Rajesh Taneja f57728674e MDL-49513 behat: Set admin config using php api
Added a new set to set config using set_config() api
to make steps faster and more efficient
2015-04-01 14:28:27 +08:00
Mark Nelson 0f2786da69 MDL-49736 core_question: fixed ability to unhide questions 2015-03-31 23:06:07 -07:00
Andrew Nicols cd32489d7a Merge branch 'MDL-49693-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE
Conflicts:
	lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor-min.js
2015-04-01 12:37:37 +08:00
Tim Lock 0ea62d56c4 MDL-38210 report_participation: implement get view/post actions 2015-04-01 10:28:41 +10:30
Eloy Lafuente (stronk7) 16008dfd92 Merge branch 'wip-mdl-48605-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-04-01 01:13:20 +02:00
Dan Poltawski 811b80a4c5 Merge branch 'MDL-49564-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE
Conflicts:
	lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor-min.js
2015-03-31 19:29:23 +01:00
Dan Poltawski bbc9f54a6b Merge branch 'MDL-49666_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-03-31 19:18:11 +01:00
Tim Hunt 8d7fa47e0d MDL-49666 qbehaviour_informationitem: respect $options->readonly 2015-03-31 15:19:56 +01:00
Dan Poltawski 32623b4d3c Merge branch 'MDL-49671-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-03-31 15:11:06 +01:00
Rajesh Taneja c01741c8cc MDL-48605 unit_test: Only touch real file/dir 2015-03-31 21:46:21 +08:00
Dan Poltawski d128e18674 Merge branch 'MDL-49547_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-03-31 14:44:09 +01:00
Dan Poltawski 8794018916 Merge branch 'MDL-49645_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-03-31 13:28:20 +01:00
Dan Poltawski 664749aaea Merge branch 'MDL-49641-get_external_files_m28' of https://github.com/jpahullo/moodle into MOODLE_28_STABLE 2015-03-31 13:15:10 +01:00
Dan Poltawski c2ca02e489 Merge branch 'MDL-49674-28-commentformat' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-03-31 12:17:25 +01:00
Dan Poltawski 55d31273e3 Merge branch 'MDL-48880_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-03-31 11:19:21 +01:00
Dan Poltawski ccd4382245 Merge branch 'm28_MDL-43818_Unable_Download_Package_Via_URL' of https://github.com/scara/moodle into MOODLE_28_STABLE 2015-03-31 09:27:54 +01:00
Andrew Nicols e47d8445b9 Merge branch 'MDL-49695_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-03-31 15:15:15 +08:00
Rajesh Taneja f93ff30cde MDL-48605 unit_test: Fixed file_temp_cleanup_task
touch should only work on temp and below
dir's. With path we get temp/.. and temp/.
So we were modfying moodledata dir as well
and it was failing because of permission issues.
2015-03-31 14:58:51 +08:00
Andrew Nicols bc8acaffc1 MDL-49294 logging: Improve cleanup tests 2015-03-31 14:12:54 +08:00
Andrew Nicols eb9845115b Merge branch 'log_cleanup_28' of https://github.com/tlevi/moodle into MOODLE_28_STABLE 2015-03-31 14:01:30 +08:00
Andrew Nicols f2512fddb3 MDL-49669 badges: Add comment to explain CURLOPT_POSTREDIR 2015-03-31 12:24:32 +08:00
Andrew Nicols a3d579f922 Merge branch 'MDL-49669_28' of https://github.com/totara/openbadges into MOODLE_28_STABLE 2015-03-31 12:24:22 +08:00
Yuliya Bozhko d9dbcdf893 MDL-48205 badges: Get rid of ucfirst() and make modnames translatable
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
2015-03-31 16:46:01 +13:00
David Monllao ec148b2574 Merge branch 'MDL-49114-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-03-31 11:29:30 +08:00
David Monllao b7df272247 Merge branch 'MDL-49474_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-03-31 10:15:03 +08:00
Andrew Nicols 6ba6b23280 Merge branch 'm28_MDL-46805' of https://github.com/danmarsden/moodle into MOODLE_28_STABLE 2015-03-31 08:18:01 +08:00
Dan Marsden d444af3d74 MDL-46805 SCORM: AICC restricts allowed characters in the username 2015-03-31 10:39:26 +13:00
Matteo Scaramuccia a9e99ebd02 MDL-43818 SCORM: unable to download the Package via URL. 2015-03-30 20:38:50 +02:00
Eloy Lafuente (stronk7) b4e4c37e52 Merge branch 'wip-mdl-49708-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-03-30 13:27:32 +02:00
Dan Poltawski f9212fb311 Merge branch 'wip-MDL-47337-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-03-30 11:06:38 +01:00
Rajesh Taneja b070387e03 MDL-49708 behat: Resize window back to default
Leaving window size to large fails in chrome
Reset it to default size works to ensure stamp
is visible by selenium driver
2015-03-30 17:30:08 +08:00
Rajesh Taneja e0d460673a MDL-49708 behat: Fix chromedriver failure
Chromedriver tries to click in center of link
As these links wrap on next line it fails to
click on links on small screen
2015-03-30 12:35:32 +08:00
David Monllao 808836c60b Merge branch 'mdl36506-moodle28' of git://github.com/tlock/moodle into MOODLE_28_STABLE 2015-03-30 10:32:12 +08:00
Simey Lameze e22f5c6d87 MDL-49114 environment: add slasharguments warning message 2015-03-30 10:07:14 +08:00
Jean-Michel Vedrine e807911c99 MDL-48880 mod_lesson: clean lesson_branch on upgrade and restore 2015-03-29 21:37:01 +02:00
Jean-Michel Vedrine 0619c4ecc4 MDL-48880 mod_lesson: clean lesson_branch when a page is deleted 2015-03-29 21:37:01 +02:00
Mark Nelson 8624dcbc4d MDL-49695 tool_behat: fixed URL 2015-03-27 16:54:46 -07:00
Eric Merrill 89a50d82e3 MDL-48467 atto: Clean the textarea during submission when in HTML mode 2015-03-27 15:24:34 -04:00
Eric Merrill 93e80c9b45 MDL-49693 atto: Clean textarea contents before inserting into editor 2015-03-27 12:27:47 -04:00
Eric Merrill 42fb2c1b70 MDL-49686 atto: Process style and class attributes in sub-functions
To ensure we only clean style and classes, first we select the inside
of those attributes and "replace" them with handler functions. Those
functions scan the actual attribute values for class or styles that
we want to exclude.

The first level regex has 3 groups. group1 selects everything in the
tag leading up to the attribute values, group2 has the attributes,
group3 has the trailing quote mark. We work on group2 then return
the combination of group1, group2, and group3.
2015-03-27 11:36:26 -04:00
Eric Merrill fbcc8eba37 MDL-49671 atto: Any pastes that don't have html should clean everything
Browsers may not provide html content in the clipboard object event
though it will really be pasted as such. This includes Firefox on
Windows, Internet Explorer, and some niche cases in Safari.

Because of this, we need to scrub the entire editor anytime we can't
intercept a paste event.

In some magical day in the future when there is better cross browser
support, we can undo this.
2015-03-26 23:59:06 -04:00
Eric Merrill 0f9a1675cd MDL-49564 atto: Improve empty span removal
Paste from MS word, followed by cleaning, may leave many many unused
spans. Try to remove them.
2015-03-26 23:08:22 -04:00
Marina Glancy 7f1b995194 MDL-47337 course: merge section options during restore 2015-03-27 08:50:26 +08:00
Mark Nelson 1d663d1776 MDL-49645 core_backup: fixed 'expirythreshold' setting not being saved 2015-03-26 16:38:59 -07:00
Yuliya Bozhko b9aa500ea9 MDL-49669 badges: Handle curl redirects when posting to backpack
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
2015-03-27 09:30:12 +13:00
Tim Hunt 94fa39d226 MDL-49547 question restore: avoid tag-related notices. 2015-03-26 15:30:13 +00:00
David Mudrák 64bef5f9f6 MDL-49674 comment: Use correct format when displaying the comment
The plugin callback executed above can eventually change the format. We
need to use that one to have the formatting of the first AJAX response
consistent with following displays.
2015-03-26 13:00:56 +01:00
Eloy Lafuente (stronk7) 0a4b99f35b weekly release 2.8.5+ 2015-03-26 10:48:15 +01:00
Eloy Lafuente (stronk7) 36843ff28b Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-03-26 10:48:09 +01:00
David Monllao 49fad98ab2 MDL-47002 editor_atto: Remove all after html when pasting 2015-03-26 10:07:57 +01:00
David Monllao 5baa2de21e MDL-47002 editor_atto: Clean the comments separately 2015-03-26 14:50:17 +08:00
Tony Levi fd7dd8f237 MDL-49294 logging: Cleanup runs in smaller chunks
Just running a huge log cleanup will probably cause big problems on large sites.
So we break this down into smaller day-by-day chunks until reaching the target.
2015-03-26 12:01:53 +10:30
Eloy Lafuente (stronk7) ea1dba053d Merge branch 'MDL-47002-int-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-03-25 18:19:46 +01:00
Eric Merrill 0c2d24e908 MDL-47002 atto: Prevent removal of Rangy spans 2015-03-25 10:02:13 -04:00
David Monllao 751fe02a01 MDL-49558 gradereport_user: Fixing table border 2015-03-25 08:41:38 +00:00
Eric Merrill b8bf3fe36b MDL-47003 atto: Update behat test for copyright symbol 2015-03-25 15:20:39 +08:00
Jordi Pujol Ahulló b94e9188e7 MDL-49641 repository_dropbox: preventing poor performance.
get_external_files placed with second argument as '' to prevent poor performance.
2015-03-25 08:02:24 +01:00
Martin Mastny 08d18b09c1 MDL-37984 portfolio: Google drive using official client library 2015-03-25 12:40:40 +08:00
David Monllao be39358439 MDL-45619 repository: Don't allow repository_recent to be uninstalled
We have tests that depends on it and it
is a simple repo that can just be disabled.
2015-03-25 09:39:59 +08:00
David Monllao c34e3ca994 Merge branch 'MDL-45619_m28' of git://github.com/sbourget/moodle into MOODLE_28_STABLE 2015-03-25 09:39:48 +08:00
Daniel Kosinski 5d9bc0acc3 MDL-46705 admin: Check if course with same shortname already exists 2015-03-24 23:36:28 +01:00
Dan Poltawski 12fd2baec7 Merge branch 'MDL-49354-28' of https://github.com/mtavella-netspot/moodle into MOODLE_28_STABLE 2015-03-24 15:14:11 +00:00
Andrew Nicols 16dab5d9c7 MDL-48918 course: Fix keyboard drag/drop after dropped resource 2015-03-24 15:11:24 +00:00
Eloy Lafuente (stronk7) 3209753b78 Merge branch 'MDL-48795_28' of https://github.com/apsdehal/moodle into MOODLE_28_STABLE 2015-03-24 15:44:54 +01:00
Dan Poltawski 54924b24c7 Merge branch 'wip-mdl-49374-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-03-24 13:36:58 +00:00
Dan Poltawski 05de057c00 Merge branch 'MDL-49070_scheduled_28' of https://github.com/andyjdavis/moodle into MOODLE_28_STABLE 2015-03-24 13:33:53 +00:00
Dan Poltawski f7751d8cd6 Merge branch 'wip_MDL-49631_28_utfregex' of https://github.com/skodak/moodle into MOODLE_28_STABLE 2015-03-24 11:11:37 +00:00
Dan Poltawski 9e84f9063e Merge branch 'MDL-46746-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE
Conflicts:
	lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor-min.js
2015-03-24 11:04:18 +00:00
Dan Poltawski 932d1d33d1 Merge branch 'MDL-49565-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-03-24 09:57:20 +00:00
Dan Poltawski c4862951d8 Merge branch 'wip_MDL-49327_2.8_guide_getinstance' of https://github.com/nixorv/moodle into MOODLE_28_STABLE
Conflicts:
	grade/grading/form/guide/tests/guide_test.php
2015-03-24 09:31:13 +00:00
Nadav Kavalerchik 7204bbf743 MDL-49558 user grades: Fix range & percent grade display in RTL mode 2015-03-24 14:51:47 +08:00
David Monllao d794cb3935 Merge branch 'MDL-49555-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-03-24 11:00:27 +08:00
David Monllao 0a79d25826 Merge branch 'MDL-47003-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-03-24 10:17:40 +08:00
Tim Lock 4101e04265 MDL-36506 mod_book: Skip legacy files migration if missing a CM record 2015-03-24 12:47:18 +10:30
Mohamed Alsharaf 99046d557e MDL-35482 lesson: return to previous page after edit and page save 2015-03-24 00:41:17 +01:00
Nikita Kalinin 4ef8b1d07e MDL-49327 marking guide: Added condition on definitionid. 2015-03-24 00:12:17 +03:00
AMOS bot b1660e619b Automatically generated installer lang files 2015-03-24 00:06:32 +08:00
Dan Poltawski a3fcd87495 Merge branch 'wip_MDL-49327_2.8_guide_getinstance' of https://github.com/nixorv/moodle into MOODLE_28_STABLE 2015-03-23 15:49:05 +00:00
Dan Poltawski be8c5c6944 Merge branch 'MDL-48443-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-03-23 15:03:59 +00:00
Dan Poltawski c3ae3253d9 Merge branch 'wip-mdl-49432-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-03-23 12:37:06 +00:00
Dan Poltawski 77d0becd77 Merge branch 'm28_MDL-48419' of https://github.com/danmarsden/moodle into MOODLE_28_STABLE 2015-03-23 11:17:05 +00:00
Dan Poltawski 4bc1c5994d Merge branch 'MDL-21201-28-feedback_anon' of https://github.com/DSI-Universite-Rennes2/moodle into MOODLE_28_STABLE 2015-03-23 11:03:29 +00:00
David Monllao 01f0148c64 MDL-48456 course: Using default max int value 2015-03-23 15:18:06 +08:00
David Monllao 02a9c25040 Merge branch 'MDL-48456-28' of git://github.com/dkns/moodle into MOODLE_28_STABLE 2015-03-23 15:17:56 +08:00
David Monllao c0339626a2 Merge branch 'MDL-47002-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-03-23 14:59:23 +08:00
Petr Skoda 4f431ffe43 MDL-49631 fix incorrect whitespace remplacements 2015-03-23 17:40:45 +13:00
AMOS bot 727bbbfa03 Automatically generated installer lang files 2015-03-23 00:04:20 +08:00
Daniel Kosinski 482ad496c7 MDL-48456 course: increase timeout when deleting all courses in category 2015-03-22 16:24:13 +01:00
AMOS bot b1a5caec65 Automatically generated installer lang files 2015-03-21 00:04:08 +08:00
AMOS bot 4c7ec86fcd Automatically generated installer lang files 2015-03-21 00:04:08 +08:00
Julien Boulen b8e75114c9 MDL-21201 Feedback: hide anonymous responses in recent activity reports 2015-03-20 16:27:25 +01:00
Andrew Davis 3a389c1d46 MDL-49070 core_registration: removed now unused config setting 2015-03-20 20:58:57 +08:00
Andrew Davis 592608b287 MDL-49070 core_registration: improved site registration scheduled task 2015-03-20 20:55:06 +08:00
Nikita Kalinin 8060eb6fc7 MDL-49327 marking guide: Added condition on definitionid. 2015-03-20 12:20:46 +03:00
Rajesh Taneja cc8cc5c8b0 MDL-49374 behat: Get install or re-install error code after composer
After composer is installed make sure we just process only
install or re-install
2015-03-20 14:05:28 +08:00
Rajesh Taneja 895661bf74 MDL-49432 behat: guzzle packages has been unified
Current version of goutte is pointing to old guzzle packages
guzzle/common, guzzle/stream, guzzle/parser and guzzle/http.
They have been unified to guzzlehttp/guzzle, so include it to
avoid using old packages
2015-03-20 12:09:55 +08:00
Eloy Lafuente (stronk7) 3ea79917c9 weekly release 2.8.5+ 2015-03-19 12:42:13 +01:00
Eloy Lafuente (stronk7) 87a27b23a1 NOBUG: Fixed file access permissions 2015-03-19 12:42:13 +01:00
Jean-Michel Vedrine 53aad1f086 MDL-49474 mod_lesson: intro and introformat missing from backup/restore
Conflicts:
	mod/lesson/backup/moodle2/backup_lesson_stepslib.php
	mod/lesson/backup/moodle2/restore_lesson_stepslib.php
2015-03-18 23:27:13 +01:00
Marina Glancy 9cdcf8748d MDL-45619 repository: corrections to uninstall, display link 2015-03-18 13:45:09 -04:00
Stephen Bourget fad0019cb2 MDL-45619 Repository: Allow repositories to be uninstalled 2015-03-18 13:45:06 -04:00
Eric Merrill cf539782c0 MDL-49565 atto: Allow html comments in editor code 2015-03-18 12:30:06 -04:00
Eric Merrill d6ee0f6897 MDL-46746 atto: Remove unnecessary filtering of unicode characters 2015-03-18 12:09:51 -04:00
Eric Merrill 016c76ec57 MDL-47003 atto: Make code cleanup more targeted
Apply different, stricter, code cleanup when we receive HTML (WYSIWYG)
paste events, but be more lax the rest of the time.

Also, update the regexes to be more targeted for specific code patterns
pasted from office packages.
2015-03-18 11:47:22 -04:00
Eric Merrill 5cb7093166 MDL-47002 atto: Improve paste behaviour to ensure propper cleanup
Old code failed to clean the editor div which resulted in
undesirable code being being left in the div for editing. To properly
handel incoming code, we should try to intercept and clean before the
paste, or clean the entire editable div.
2015-03-18 09:29:43 -04:00
info@ewallah.net bb04cfe20e MDL-49555 enrol_paypal: Only display icon if method available 2015-03-18 14:23:25 +01:00
Juan Leyva abde87bf41 MDL-48443 webservices: Prevent duplicated user devices 2015-03-18 11:43:56 +01:00
Dan Marsden 5663c1771f MDL-48419 mod_scorm: Check net script too agressive
in some cases high latency and network issues result in longer
than 2 sec responses from a server, increase this to avoid
excessive warnings.
2015-03-18 20:05:36 +13:00
David Monllao 67258145ea Revert "Merge branch 'MDL-49445_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE"
This reverts commit ea505f1b35, reversing
changes made to bad69e63f5.
2015-03-18 10:51:15 +08:00
Eloy Lafuente (stronk7) 23be970b7f Merge branch 'MDL-49296_m28v3' of https://github.com/sbourget/moodle into MOODLE_28_STABLE 2015-03-17 12:05:25 +01:00
Dan Poltawski 58873bcae3 Merge branch 'MDL-49359_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE 2015-03-17 08:53:31 +00:00
Mark Nelson 3c2c8a0628 MDL-49359 install: warn against using MyISAM 2015-03-16 20:41:56 -07:00
Stephen Bourget 6ec0c5fba5 MDL-49296 Lesson: Add titles to action links 2015-03-16 20:35:15 -04:00
Eloy Lafuente (stronk7) 39a765703e Merge branch 'MDL-49389_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-03-17 00:29:22 +01:00
Mike Grant 87fd4f6b0d MDL-49276 config-dist: Removed legacy config options
Both $CFG->logsql and $CFG->dblogerror had no use in moodle core
since ages ago (just the former had one use for nothing). Good time
to get rid of both as they are 100% misleading.
2015-03-16 23:42:57 +01:00
Dan Poltawski 21acd586a8 Merge branch 'MDL-48965_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-03-16 21:05:57 +00:00
Dan Poltawski 8d8124fa9f Merge branch 'wip-MDL-49267-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-03-16 15:52:38 +00:00
Dan Poltawski b6c5e8f790 Merge branch 'MDL-49104-28' of git://github.com/DanBennettUK/moodle into MOODLE_28_STABLE 2015-03-16 15:05:13 +00:00
Dan Poltawski 8736f9b956 Merge branch 'MDL-49187-28' of https://github.com/spvickers/moodle into MOODLE_28_STABLE 2015-03-16 14:52:05 +00:00
Dan Poltawski d8088471b0 Merge branch 'MDL-49442-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2015-03-16 13:31:07 +00:00
David Monllao ea505f1b35 Merge branch 'MDL-49445_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-03-16 15:38:13 +08:00
David Monllao bad69e63f5 MDL-47712 question_multianswer: Concat as string 2015-03-16 13:51:17 +08:00
David Monllao 54fbcc3105 Merge branch 'MDL-47712-m28-master' of git://github.com/dthies/moodle into MOODLE_28_STABLE 2015-03-16 10:33:40 +08:00
David Monllao c35f3e97da Merge branch 'm28_MDL-44548' of git://github.com/danmarsden/moodle into MOODLE_28_STABLE 2015-03-16 10:04:34 +08:00
David Monllao 9455b8b96b Merge branch 'wip-MDL-47729-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-03-16 09:50:31 +08:00
Dan Marsden 4050f60b55 MDL-44548 mod_scorm: force an external sync to check for updated files. 2015-03-16 09:03:01 +13:00
Daniel Thies 55526a8a53 MDL-47712 qtype_multianswer: Move mathjaxloader spans to outer question 2015-03-13 21:33:16 -05:00
Tim Hunt 44242e1a40 MDL-49446 behat: should_not_be_visible steps were not working
I fixed all similar problems in this class, even ones where it did
actually work becuase the two exceptions were of different types.
This pattern seems to have been copied and pasted a lot in this class,
and I am sure that will happen again, so I did not want to leave any
dangerous potential examples around.
2015-03-13 14:22:52 +00:00
Tim Hunt 6d01dfe627 MDL-49445 behat: selectors should match the most specific tr or li
I also fixed the text rule, which already did this, to use the same
idiom. It is unnecessarily inefficient to count all the things and
compare to 0. Not exists should be faster.

Also, updated all the selectors here to consistently start relative to
the current node (.//, not //).
2015-03-13 14:22:44 +00:00
Tim Hunt d8ace7dd74 MDL-49389 blocklib: avoid notices when moving blocks to the bottom 2015-03-13 14:22:35 +00:00
Marina Glancy 1a17ca8bdd MDL-47729 repository_filesystem: smarter sync of references
It was noticed that if file content was once imported the following
synchronisations do not discover the changes
2015-03-13 11:21:14 +08:00
David Monllao 79dfb73824 weekly release 2.8.5+ 2015-03-13 10:27:41 +08:00
David Monllao 4d82d742c5 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-03-13 10:27:39 +08:00
David Monllao 4bb1c9764e Merge branch 'MDL-48897_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-03-11 08:51:57 +08:00
David Monllao 135aeaacc4 Merge branch 'MDL-48858-28' of git://github.com/mastnym/moodle into MOODLE_28_STABLE 2015-03-11 08:46:50 +08:00
Tim Hunt 0612ff1f56 MDL-49315 questions: unit tests for each behaviour type class 2015-03-11 08:28:18 +08:00
Eloy Lafuente (stronk7) 807e21f64e Merge branch 'MDL-49159-28' of https://github.com/spvickers/moodle into MOODLE_28_STABLE 2015-03-11 00:18:28 +01:00
AMOS bot 2229917a8f Automatically generated installer lang files 2015-03-11 00:04:06 +08:00
Dan Poltawski 1a72a44f97 Merge branch 'wip_MDL-49074_M28' of git://github.com/gjb2048/moodle into MOODLE_28_STABLE 2015-03-10 11:51:45 +00:00
David Monllao 0d87b1f548 Merge branch 'MDL-49256-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE
Conflicts:
	lib/editor/atto/yui/build/moodle-editor_atto-editor/moodle-editor_atto-editor-min.js
2015-03-10 17:46:01 +08:00
Dan Poltawski f09cb26d51 Merge branch 'wip-mdl-49402-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-03-10 08:33:35 +00:00
Dan Poltawski dd8b3324ef Merge branch 'MDL-48682_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-03-10 08:25:30 +00:00
David Monllao 3fca7fd7c7 Merge branch 'MDL-49346-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-03-10 15:32:05 +08:00
David Monllao 3622940192 Merge branch 'MDL-49351-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-03-10 15:21:30 +08:00
David Monllao 655193dc84 Merge branch 'MDL-49366_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-03-10 14:41:29 +08:00
Jetha Chan a34b18ad21 MDL-49442 javascript: add handlebars hashtable to support get_string 2015-03-10 13:07:28 +08:00
David Monllao 65b61b07e0 Merge branch 'MDL-49107-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-03-10 11:43:31 +08:00
David Monllao f61d29c317 Merge branch 'MDL-49332-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-03-10 10:43:11 +08:00
David Monllao 62d334e985 Merge branch 'MDL-48572_28' of git://github.com/rlorenzo/moodle into MOODLE_28_STABLE 2015-03-10 10:35:37 +08:00
David Monllao 0f9b21a5d7 Merge branch 'MDL-39262_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-03-10 10:13:00 +08:00
Eloy Lafuente (stronk7) be3e6f6202 Moodle release 2.8.5 2015-03-10 00:42:44 +01:00
Dan Bennett 116f2c5714 MDL-49104 repository_s3: backport of MDL-43725 2015-03-09 16:03:12 +00:00
Eloy Lafuente (stronk7) 49f4e7c976 weekly release 2.8.4+ 2015-03-09 16:47:53 +01:00
Marina Glancy 2d73956d8e MDL-49418 core: partial revert of MDL-48804
this is a quick fix for the issue 'Course module with two or more availability restrictions is not accessible'
MDL-49434 is created to deal with the renderer access inside availability check
2015-03-09 11:26:18 +08:00
Jean-Michel Vedrine a4ff234c80 MDL-39262 mod_lesson: disable shortforms in lesson question display
Conflicts:
	mod/lesson/pagetypes/shortanswer.php
2015-03-08 11:20:22 +01:00
Amanpreet Singh b2959e1323 MDL-48795 lang: Update message for nothingnew
In lang/en/moodle.php file
2015-03-08 10:06:39 +05:30
Jean-Michel Vedrine 10a40946c6 MDL-48897 mod_lesson: behat tests for pages edition
This is a backport of MDL-48675.
2015-03-07 22:52:02 +01:00
Jean-Michel Vedrine 5d911423dc MDL-48897 mod_lesson: Error displayed while editing content page jumps
This change also fix MDL-32343 and MDL-31778 related to problems
when editing cluster pages.

This is a backport of MDL-48675.
2015-03-07 22:52:02 +01:00
Jean-Michel Vedrine fbfa01b847 MDL-48965 mod_lesson: avoid short answer question without any answers 2015-03-07 22:07:00 +01:00
Eloy Lafuente (stronk7) f4dc567e79 Moodle release 2.8.4 2015-03-07 11:23:46 +01:00
Juan Leyva 4567c1c3a0 MDL-49346 ratings: ratingarea should be a required parameter 2015-03-06 11:45:03 +01:00
Juan Leyva b610727b5b MDL-49351 ratings: Correct check of viewallratings permission 2015-03-06 11:43:05 +01:00
Marina Glancy 1118c28a51 MDL-49267 mod_wiki: always apply filters to the wiki name 2015-03-06 13:54:29 +08:00
Andrew Nicols 1879f64350 MDL-49256 atto: Check form existence before resetAutosave 2015-03-06 12:01:50 +08:00
Rajesh Taneja 8b215b4110 MDL-49402 behat: Fixed feature file with same scenario name
1. We should not have same scanrio name in 1 feature file
   As it doesn't explain what is being tested. So modified.
2. Removed empty line, to keep it consistnet with other features
2015-03-06 11:47:56 +08:00
David Monllao 69023cd3e9 MDL-48682 behat: Changing window size on specific tests 2015-03-06 11:03:17 +08:00
David Monllao f4a201cdf2 MDL-49376 behat: Fixing resize step regex 2015-03-06 10:59:47 +08:00
Rex Lorenzo 086f4b6e4f MDL-48572 gradereport_grader: Average wrong with suspended users 2015-03-05 11:38:09 -08:00
Eric Merrill cf1a558531 MDL-49332 gradebook: Raise time limit if we get into regrade
Because all regrading should (and does) start from this point, it
is safe and best to call it just once, from this point.
2015-03-05 10:10:13 -05:00
Tim Hunt 3338ba48d9 MDL-49366 questions: avoid PHP notices from bad pluginfile URLs 2015-03-05 12:17:43 +00:00
Eloy Lafuente (stronk7) 67bbf0d422 weekly release 2.8.3+ 2015-03-05 11:26:48 +01:00
Eloy Lafuente (stronk7) 89784be6ff Merge branch 'MDL-49379_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-03-04 10:50:12 +01:00
Mark Nelson 8f938ff9a6 MDL-49379 core_webservice: fixed ability to edit services 2015-03-04 01:37:07 -08:00
David Monllao c35df119a5 MDL-49204 core_message: Checking current user 2015-03-04 10:05:44 +08:00
spvickers f9db06b107 MDL-49187 mod_lti: Fix tool config lookup
Changed code to look for a tool ID before then matching on the URL.
2015-03-03 18:56:41 -07:00
Andrew Nicols 98dfa7cae8 Merge branch 'MDL-49364_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-03-04 08:53:03 +08:00
Andrew Nicols 4d7ecf45a1 Merge branch 'mdl28_MDL-46390' of https://github.com/danmarsden/moodle into MOODLE_28_STABLE 2015-03-04 07:55:59 +08:00
Dan Marsden 2e12b4cffb MDL-46390 mod_scorm: Find correct sco to launch when org based sco is selected
Also tidies up some redundant code in scorm_format_toc_for_droplist()
2015-03-04 09:28:53 +13:00
Eloy Lafuente (stronk7) c2383703ea Merge branch 'MDL-49214_M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE 2015-03-03 19:36:19 +01:00
Dan Poltawski 9db4890064 Merge branch 'MDL-49335_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-03-03 14:46:34 +00:00
Dan Poltawski c6e925dbf0 Merge branch 'MDL-49334_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-03-03 13:25:33 +00:00
Dan Poltawski 35a615aa33 Merge branch 'MDL-47000-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-03-03 13:21:30 +00:00
Tim Hunt f1fb96b698 MDL-49364 quiz statistics: escape output in the response analysis 2015-03-03 13:04:59 +00:00
Tim Hunt b6f112957e MDL-49335 quiz behat: new test of attempting a quiz
This separates out attempting the quiz into a separate .feature, away
from the monolithic add_quiz.feature. At some point we should clean that
up, but for now I am just adding this.

Really, the main reason for this test is to verify the two Behat
enhancememnts I just did.
2015-03-03 11:23:55 +00:00
Tim Hunt ccc1e11099 MDL-49335 quiz behat: improved step for adding questions to a quiz
Explicit headings make the script more readable, and pave the way for
new options that are due to be added.
2015-03-03 11:23:54 +00:00
Tim Hunt 44f6bc4ead MDL-49335 Behat: new question selector
So you can say things like
    And I click on "True" "radio" in the "First question" "question"
2015-03-03 11:23:54 +00:00
Tim Hunt 6e650b4c0a MDL-49334 behat: sort selector lists 2015-03-03 11:20:55 +00:00
Dan Poltawski 84fd0fd52c Merge branch 'MDL-34006_m28v7' of https://github.com/sbourget/moodle into MOODLE_28_STABLE 2015-03-03 11:03:12 +00:00
Gareth J Barnard f300e1021b MDL-49074 themes: WOFF2 fonts are not supported. Backport of MDL-46728. 2015-03-03 10:45:30 +00:00
Stephen Bourget 2a433ad067 MDL-45621 Portfolio: Allow portfolios to be uninstalled 2015-03-03 10:59:48 +01:00
Dan Poltawski e527aff4d2 Merge branch 'MDL-49160-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-03-03 08:34:50 +00:00
Andrew Nicols da9dfe70d4 Merge branch 'wip-mdl-49110-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-03-03 16:27:03 +08:00
Andrew Nicols e2d00f5195 MDL-49285 mod_quiz: Remove unnecessary linebreak 2015-03-03 16:24:02 +08:00
Andrew Nicols 6afe470648 Merge branch 'MDL-49285-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-03-03 16:23:24 +08:00
Andrew Nicols 76bd7cea87 Merge branch 'MDL-38485-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-03-03 16:15:06 +08:00
Andrew Nicols 2b6bb87e59 Merge branch 'MDL-49075-28' of https://github.com/lucisgit/moodle into MOODLE_28_STABLE 2015-03-03 15:43:44 +08:00
pau.ferrer-ocana d259d014bb MDL-49234 oracle: Remove variables passed by reference error 2015-03-03 15:14:38 +08:00
Andrew Nicols fba097e3ce Merge branch 'MDL-49247_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-03-03 15:07:35 +08:00
Andrew Nicols 21b910b487 Merge branch 'MDL-49284_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-03-03 13:48:13 +08:00
Adrian Greeve 49308a3f57 MDL-48858 mod_data: Update to behat tests
A bulk delete of entries has been added to
the behat tests.
2015-03-03 11:34:14 +08:00
Eloy Lafuente (stronk7) 83866c3c2a MDL-49087 mdeploy: now relying on config.php documented 2015-03-03 02:44:49 +01:00
Andrew Nicols 4475f1e478 MDL-49087 mnet: Ensure typeroot is in dirroot 2015-03-03 02:40:50 +01:00
Andrew Nicols c353a62026 MDL-49087 mnet: Use real dataroot instead of user-provided 2015-03-03 02:40:50 +01:00
Eloy Lafuente (stronk7) 1a67f29f38 Merge branch 'MDL-37470_28' of https://github.com/mike-grant/moodle into MOODLE_28_STABLE 2015-03-03 01:43:54 +01:00
Eloy Lafuente (stronk7) 50f2d4d645 Merge branch 'MDL-49240-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE 2015-03-03 01:11:24 +01:00
Matthew Tavella 0d2a4f8ee9 MDL-49354 YUI: Remove event-autohide module from yui-moodlesimple rollup 2015-03-03 10:29:18 +10:30
Dan Poltawski f479a30931 Merge branch 'MOODLE_28_STABLE' of https://github.com/mitstek/moodle into MOODLE_28_STABLE 2015-03-02 17:27:15 +00:00
Dan Poltawski a62cc33c1f Merge branch '28_MDL-49303' of https://github.com/danmarsden/moodle into MOODLE_28_STABLE 2015-03-02 16:57:54 +00:00
Marina Glancy 4ab4ec652c MDL-48804 core: do not set current course until login validated 2015-03-02 16:49:44 +01:00
Juan Leyva 0899c0adc0 MDL-48691 webservices: Check if the user must be changing password 2015-03-02 14:40:01 +00:00
Simey Lameze 64e2179478 MDL-49084 core_tag: add capability check to flag as inappropriate action 2015-03-02 12:52:13 +00:00
Andrew Nicols 51094c6560 MDL-49144 blocks: Sanitise alt and title for block controls 2015-03-02 12:09:52 +00:00
Andrew Nicols 3f316035b4 MDL-49144 blocks: Add behat test to ensury sanity of block title 2015-03-02 12:09:52 +00:00
Dan Poltawski 0dedf765e0 Merge branch 'MDL-47911-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE 2015-03-02 11:06:19 +00:00
Ankit Agarwal 5219605a81 MDL-38466 filters: Redos protection and unit tests 2015-03-02 11:30:45 +01:00
Zachary Durber 1b24951778 MDL-38466 filters: ReDoS protection for text to URL conversion. 2015-03-02 11:30:44 +01:00
Dan Poltawski 952bc6c5a6 Merge branch 'MDL-23273-28' of git://github.com/zbdd/moodle into MOODLE_28_STABLE 2015-03-02 09:34:57 +00:00
Mary Evans 3cf5c751ed MDL-49214 theme_bootstrapbase: OL list numbers cut off in Clean theme
Conflicts:

	theme/bootstrapbase/style/moodle.css
2015-03-01 19:40:58 +00:00
spvickers 06085cc6d4 MDL-49159 mod_lti: Incorrect IDs in tools table
The "_tools" suffix for the IDs of tabs in the tools settings table was
being duplicated.
2015-02-27 11:32:34 -07:00
Eric Merrill fb50700b4e MDL-47911 gradebook: Improve the performance of set_usedinaggregation
This function is called many many times during grade calculation, so it
should be as efficient as possible.
2015-02-27 11:53:54 +08:00
Tony Butler 7c0e5b20b6 MDL-49075 mod_assign: Add assertions to marking workflow unit test
Make sure grades aren't pushed to gradebook for marking workflow
states other than 'released'.
2015-02-26 11:56:20 +00:00
Tony Butler bb790b84ca MDL-49075 mod_assign: Keep unreleased assign grades out of gradebook 2015-02-26 11:56:20 +00:00
Dan Marsden e1c81e5284 MDL-49303 mod_scorm: Initialise student preferences on re-entry. 2015-02-26 20:39:07 +13:00
Tim Hunt e89a286905 MDL-49284 formslib: fix strict validation of HTML. 2015-02-25 17:39:23 +00:00
Frederic Massart 7b414d50a8 MDL-49107 atto_link: Insert link even when selection is empty 2015-02-25 16:38:10 +01:00
Stephen Bourget c80f356bca MDL-34006 Lesson: Behat tests 2015-02-25 10:29:14 -05:00
Stephen Bourget cf49d1850e MDL-34006 Lesson: Resume lesson loads wrong page. 2015-02-25 10:29:01 -05:00
Dan Poltawski 2abfecbc8c weekly release 2.8.3+ 2015-02-25 14:57:39 +00:00
Dan Poltawski 6fe7343a94 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-02-25 14:57:36 +00:00
Mitsuhiro Yoshida 9b1c53771a MDL-49259 lib: Fix for unzipped Japanese filename character corruption 2015-02-25 23:28:29 +09:00
Andrew Nicols f18a66f1ea MDL-49008 lang: Revert unnecessary rename warning
This was failing unit tests because it does not check for the presence of
the source directory first. If there is no source directory, it cannot be
moved.
2015-02-25 08:55:56 +08:00
Eric Merrill 3272e14576 MDL-47000 session: Update memcached version referecnes to 2.2.0 2015-02-24 15:19:30 -05:00
Eric Merrill 181269bf32 MDL-49285 quiz: Include lib.php for phpunit test 2015-02-24 14:54:37 -05:00
Eric Merrill fc63b8cf81 MDL-49160 quiz: Make sure to not select an outcome grade item
When we are computing completion, make sure we select only the true
grade_item, not outcome grade items.
2015-02-24 14:43:37 -05:00
Dan Poltawski 84be895b94 Merge branch 'MDL-49241-28-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-02-24 16:50:15 +00:00
Dan Poltawski 8732862bb5 Merge branch 'wip_MDL-49184_m28_choice' of https://github.com/skodak/moodle into MOODLE_28_STABLE 2015-02-24 10:43:32 +00:00
Brian Barnes ede8ae0399 MDL-48519 accessibility: improved accessibility of user filters 2015-02-24 17:53:27 +08:00
Andrew Nicols 2d7c31b550 Merge branch 'MDL-49078_m28' of git://github.com/shashirepo/moodle into MOODLE_28_STABLE 2015-02-24 17:05:53 +08:00
Shashikant Vaishnav 9a055f40c2 MDL-49078 theme_bootstrapbase: 'Create new course' text too high
Thanks to  Gareth J Barnard  for the code suggestion
2015-02-24 14:21:09 +05:30
Dan Poltawski 40b53bda8c Merge branch 'MDL-49216-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-02-24 08:31:54 +00:00
Andrew Davis c49003263e MDL-29008 lang: reintroduced error silencing to prevent unit test failures 2015-02-24 16:16:20 +08:00
Zachary Durber c9e9862ed6 MDL-23273 mod_choice: error continue button redirects back to choice
Locks only occur when a choice is using limits.
2015-02-24 12:16:29 +08:00
Zachary Durber a455f2fa45 MDL-23273 mod_choice: Using locks to ensure choice limits 2015-02-24 12:16:29 +08:00
Andrew Nicols b34fc1800a Merge branch 'mdl28_MDL-46408' of https://github.com/danmarsden/moodle into MOODLE_28_STABLE 2015-02-24 11:35:53 +08:00
Ankit Agarwal 8a15bcf759 MDL-38485 calendar: Carry over line breaks on imports
Thanks to Matthias Schwabe for the patch suggestion
2015-02-24 08:55:40 +05:30
Andrew Nicols 4f2308d541 Merge branch 'MDL-49008_lang_vanish_28' of https://github.com/andyjdavis/moodle into MOODLE_28_STABLE 2015-02-24 11:08:28 +08:00
Andrew Nicols 41ab3ae676 MDL-49216 mod_forum: Move subquery to outer component
It is not possible to order sub-query results with some RDBMs, and the
subquery is not necessary anyway.
2015-02-24 08:30:24 +08:00
Andrew Nicols d2782c3d4b MDL-49216 mod_forum: Add tests for discussion reply count 2015-02-24 08:30:23 +08:00
Helen Foster b907bc26f6 MDL-49241 lang: Merge English strings from the en_fix language pack 2015-02-23 21:15:18 +01:00
Dan Poltawski 105e1af010 Merge branch 'MDL-49198_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE 2015-02-23 16:29:25 +00:00
Dan Poltawski 06b5e1f1e1 Merge branch 'MDL-49200_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE 2015-02-23 16:21:33 +00:00
Dan Poltawski 9c2e581e82 Merge branch 'MOODLE_28_STABLE' of https://github.com/eberhardt/moodle into MOODLE_28_STABLE 2015-02-23 15:55:37 +00:00
Andrew Nicols 0c8096792d MDL-48807 accesslib: Change create_level_instance to recordset 2015-02-23 16:03:17 +08:00
Andrew Nicols aa2b7c3b48 Merge branch 'MDL-48807-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-02-23 15:08:09 +08:00
Simey Lameze 56145a4d6e MDL-48807 core_task: change create_contexts_task to daily frequency 2015-02-23 14:40:37 +08:00
Simey Lameze 34fcdf2da4 MDL-48807 accesslib: table locking fix on all create_level_instance 2015-02-23 14:36:52 +08:00
David Monllao 5e872af220 MDL-49145 report_log: Moving conditions
Now get_url() does not need to be resolved when
we are downloading.
2015-02-23 10:38:47 +08:00
Andrew Nicols 40155b1ca0 Merge branch 'MDL-49174-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-02-23 09:36:21 +08:00
Andrew Nicols 75b594848e Merge branch 'MDL-35392-28' of git://github.com/zbdd/moodle into MOODLE_28_STABLE 2015-02-23 09:21:55 +08:00
Zachary Durber ad4d28ff76 MDL-35392 mod_assign: Push feedback to gradebook when releasing grades
When bulk changing workflow status a mismatch in variable
names meant that feedback wasn't being sent to the gradebook.
2015-02-23 09:17:30 +08:00
Andrew Nicols a721901beb Merge branch 'MDL-49145_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-02-23 09:05:58 +08:00
David Monllao e0c5923c07 MDL-49145 report_log: Fixing condition
Credit and thanks to Tyler Bannister and Renaat Debleu.
2015-02-23 08:46:56 +08:00
Andrew Davis bbc7df8d52 MDL-49008 lang: removed preemptive deleting of old language files 2015-02-22 21:08:31 +01:00
Andrew Davis 1ab376e86f MDL-49008 lang: made lang update error reporting work 2015-02-22 21:06:38 +01:00
Dan Marsden 4c30d78891 MDL-46408 mod_scorm: check param is set before using.
The default org is only set if it exists in the imsmanifest.xml
2015-02-20 13:42:23 +13:00
Tim Hunt 87e581f91a MDL-49247 question restore: avoid unique key errors from old bad data
Several tables have had unique keys added to enforce a constraint that
should always have been there. It is possible for old sites to have
data that violate the constraints, and sometimes people want to backup
data from those old sites, and restore them into a new Moodle.
Therefore, we need to guard agains the unique key violation errors.
2015-02-19 21:50:47 +00:00
AMOS bot 4571805430 Automatically generated installer lang files 2015-02-20 00:04:08 +08:00
Jan Eberhardt ec943fe107 MDL-31578 auth_shibboleth: Custom fields added to shibboleth settings
Since LDAP is able to sync custom user profile fields, this feature was
requested for Shibboleth.
2015-02-19 13:56:42 +00:00
Eloy Lafuente (stronk7) 8235b610bb weekly release 2.8.3+ 2015-02-19 10:44:47 +01:00
Eloy Lafuente (stronk7) aff125ae03 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-02-19 10:44:41 +01:00
Damyon Wiese 41adb95781 MDL-49240 webservices: core_get_string and friends bad lang handling
The core_get_string webservice and friends have never passed lang values
properly, (so never worked) and when I fixed that I found they were passing
lang parameter into the lazyload parameter.
2015-02-19 17:42:50 +08:00
Andrew Nicols 7546d2e1c3 Revert "Merge branch 'MDL-49154_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE"
This reverts commit f5a176c125, reversing
changes made to cf015aa1f0.
2015-02-19 09:18:06 +08:00
Rajesh Taneja 282fdb22ca MDL-48841 admin: Behat table row should start with first row 2015-02-18 15:34:12 +08:00
Botond Hegedus dac942ff58 MDL-49198 core_webservice: Fix error when using existing service name 2015-02-17 23:14:22 -08:00
David Monllao 38a219301e Merge branch 'MDL-49034_m28' of git://github.com/mattporritt/moodle into MOODLE_28_STABLE 2015-02-18 09:36:38 +08:00
Eloy Lafuente (stronk7) 7001bf9a8c Merge branch 'MDL-49211_M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE 2015-02-18 00:03:59 +01:00
Eloy Lafuente (stronk7) 7f8ae8f54e Merge branch 'MDL-48973_28' of https://github.com/pauln/moodle into MOODLE_28_STABLE 2015-02-17 23:52:48 +01:00
Eloy Lafuente (stronk7) f5a176c125 Merge branch 'MDL-49154_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-02-17 23:46:47 +01:00
Eloy Lafuente (stronk7) cf015aa1f0 Merge branch 'MDL-49170_28' of https://github.com/totara/openbadges into MOODLE_28_STABLE 2015-02-17 23:43:38 +01:00
Eloy Lafuente (stronk7) d34122424c Merge branch 'MDL-49205_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-02-17 22:18:51 +01:00
Juan Leyva 6c1a52e67c MDL-49174 webservices: Return front page contents in get_contents ws 2015-02-17 21:33:42 +01:00
Eloy Lafuente (stronk7) 373252e7da Merge branch 'MDL-49041_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-02-17 21:09:26 +01:00
Eloy Lafuente (stronk7) 2f4dfae509 Merge branch 'MDL-49059-split_28' of https://github.com/pauln/moodle into MOODLE_28_STABLE 2015-02-17 20:58:39 +01:00
Eric Merrill 68adf314ec MDL-48993 gradebook: When importing new items, treat blank or - as empty 2015-02-17 17:21:49 +08:00
David Monllao 1c703690cd Merge branch 'MDL-49167-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE 2015-02-17 17:01:26 +08:00
David Monllao 0289d8c766 MDL-48991 gradebook: Return value according to coding style 2015-02-17 16:48:44 +08:00
David Monllao a4e657878b Merge branch 'MDL-48991-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-02-17 16:43:44 +08:00
David Monllao b7a6e68906 Merge branch 'MDL-48884_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-02-17 14:44:05 +08:00
David Monllao 65b48f6850 Merge branch 'MDL-48841-MOODLE_28_STABLE' of git://github.com/lucisgit/moodle into MOODLE_28_STABLE 2015-02-17 14:25:02 +08:00
Andrew Nicols 6e84137b30 Merge branch 'wip-mdl-48670-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-02-17 14:07:15 +08:00
David Monllao e9a6191801 Merge branch 'MDL-49169_28' of git://github.com/grabs/moodle into MOODLE_28_STABLE 2015-02-17 14:01:14 +08:00
Mark Nelson 376d6d9bc0 MDL-49200 core_form: corrected string 2015-02-16 21:59:41 -08:00
David Monllao 94b3cc37aa Merge branch 'MDL-48215_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-02-17 13:24:36 +08:00
Petr Skoda 401465fe7c MDL-49184 choice: fix block actions
The problems was that blocks editing breaks if you redirect
after if (data_submitted()) - all form actions must make sure
it is really their form, otherwise they may hijack the post from
block actions.

Note that this is not a problem for mforms, only legacy forms
are affected.

# Conflicts:
#	mod/choice/view.php
2015-02-17 16:56:45 +13:00
David Monllao 95337e5974 Merge branch 'MDL-48543-28' of git://github.com/damyon/moodle into MOODLE_28_STABLE 2015-02-17 11:15:12 +08:00
David Monllao a9e2dd494b Merge branch 'MDL-48709_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-02-17 09:17:25 +08:00
AMOS bot d153a4a39d Automatically generated installer lang files 2015-02-17 00:04:18 +08:00
Michael Hughes 5b7e7362a9 MDL-48215 gradingform_guide: Name length validation
Validating both criterion name and guide name to be 255 chars.
2015-02-15 21:52:56 -08:00
David Monllao 5eed950dd2 Merge branch 'MDL-47529-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-02-16 11:55:39 +08:00
Damyon Wiese fe5ecacb2b MDL-49167 YUI: Fix for theme/yui_combo.php and $CFG->yuislashargs
It was too aggressively cleaning it's params (broken in MDL-48980).
2015-02-16 11:26:11 +08:00
Frederic Massart 84b1aeba07 MDL-47529 lock: Fix typo on lock factory in config-dist 2015-02-16 11:14:20 +08:00
Frederic Massart d940409a40 MDL-47529 task: Remove usage of lock when editing a task 2015-02-16 11:14:20 +08:00
Frederic Massart 58ebc0a42d MDL-47529 task: Do not use lock when updating task records 2015-02-16 11:14:20 +08:00
David Monllao 6eba5f4dfa Merge branch 'MDL-40776_28' of git://github.com/s-cenni/moodle into MOODLE_28_STABLE 2015-02-16 10:35:26 +08:00
Yuliya Bozhko a99654771f MDL-49170 badges: Backpack connection missing a port colon in URL
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
2015-02-16 09:34:39 +13:00
Mary Evans 27a5f957ba MDL-49211 theme_bootstrapbase: Text alignment issue in CLOZE questions.
Conflicts:

	theme/bootstrapbase/style/moodle.css
2015-02-15 19:18:17 +00:00
Jean-Michel Vedrine 1a825a276e MDL-48709 mod_lesson: subclusters are not working 2015-02-14 18:21:40 +01:00
Tim Hunt dabbf48f50 MDL-49205 behat: fix I set the field with xpath fail message. 2015-02-13 16:16:18 +00:00
Paul Nicholls 10a382f1c8 MDL-48973 Atto: Atto does not listen to the drop event
The 'drop' event fires before the native ContentEditable drop handler, so
in order to update the underlying textarea we need to call updateOriginal
with a brief delay so that the dropped content has actually been added to
the editor.
2015-02-13 14:50:14 +13:00
Rajesh Taneja 21e8f813dc MDL-48670 behat: Set timezone to Australia/perth
Behat tests might rely on time related tests
Ensure we have default timezone set to Australia/Perth
2015-02-13 08:12:42 +08:00
Eric Merrill 49f1acf174 MDL-48991 gradebook: Fix style problems 2015-02-12 16:50:17 -05:00
Matt Switlik 4f9ccc21d8 MDL-48991 gradebook: Properly import multiple new grade items
Work done in MDL-46547 caused a problem where multiple new grade items
were not imported. Fix up the passing of new grade objects.
2015-02-12 16:50:17 -05:00
Paul Nicholls a92cd1e420 MDL-49059 medialib: Add test cases for invalid Youtube URL param values
Tests to ensure that we're not allowing injection via invalid values of
the Youtube start time and playlist parameters.
2015-02-13 09:46:02 +13:00
Paul Nicholls 40b72c27e8 MDL-49059 medialib: Support links to Youtube videos within playlists
As well as embedding playlists, you can embed specific videos from them -
resulting in the playlist UI displaying, but starting with the specified
video rather than the first in the playlist.  Previously, just the
specified video would embed - without the playlist UI.
2015-02-13 09:46:02 +13:00
Paul Nicholls f266c90917 MDL-49059 medialib: Support start time params in Youtube URLs
Medialib (and thus the Multimedia Plugins filter) was ignoring start time
parameters on YouTube video URLs, meaning that the video would always
start at the start, even when the appropriate parameter was present.
2015-02-13 09:46:02 +13:00
Paul Nicholls 71ce7d03ee MDL-49059 medialib: Add tests for Youtube videos within playlists
As well as embedding playlists, you can embed specific videos from them -
resulting in the playlist UI displaying, but starting with the specified
video rather than the first in the playlist.  These URLs should be covered
by the tests to ensure that we're handling them properly.
2015-02-13 09:46:01 +13:00
Paul Nicholls 7c339df7cb MDL-49059 medialib: Add test cases for Youtube start times
Add test cases to core_medialib_testcase to cover YouTube videos with
start times.
2015-02-13 09:46:01 +13:00
Tim Hunt 8f990cc5bf MDL-49154 behat: step to type with focus on a given element 2015-02-12 20:15:49 +00:00
Andreas Grabs 51112014d2 MDL-49169 user - After MDL-48978-Fix description is not saved anymore 2015-02-12 12:26:03 +01:00
Mike Grant 361370bae3 MDL-37470 blocklib: Respect block weight and offset 2015-02-12 09:43:13 +00:00
David Monllao 201f5085c6 weekly release 2.8.3+ 2015-02-12 15:30:23 +08:00
David Monllao ea836818a5 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-02-12 15:30:21 +08:00
David Monllao 2fb32e8591 Revert "Merge branch 'MDL-36009-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE"
This reverts commit e89bda0f80, reversing
changes made to bec8c20cab.
2015-02-12 13:46:31 +08:00
Ruslan Kabalin d7e275f123 MDL-48841 admin: Fix scheduled task reset to defaults finctionality.
It is safe to make fields as non-required, because form validation will not
pass through any empty field anyway.
2015-02-11 11:18:40 +00:00
Marina Glancy 0a976df90c MDL-49003 login: prevent signup when user is logged in 2015-02-11 00:04:25 +01:00
AMOS bot 924ef95068 Automatically generated installer lang files 2015-02-11 00:04:12 +08:00
Eloy Lafuente (stronk7) 67c51ec7ec Merge branch 'MDL-48910_block_my_28' of https://github.com/andyjdavis/moodle into MOODLE_28_STABLE 2015-02-10 13:22:51 +01:00
Sara Cenni 6473207888 MDL-40776 grade: fix query for report outcomes
Add a missing space to the query for report outcomes to avoid error with Oracle.
2015-02-10 11:52:02 +01:00
David Monllao da6815741e MDL-48679 gradebook: Fixing trailing whitespace 2015-02-10 17:54:40 +08:00
David Monllao 537fd32c02 Merge branch 'MDL-48679-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2015-02-10 17:53:19 +08:00
Simey Lameze 9461ad93fd MDL-48679 gradebook: fix grade publishing feature 2015-02-10 17:40:29 +08:00
Simey Lameze 32a491a8d2 MDL-48679 gradebook: helper methods for grade publishing 2015-02-10 17:40:29 +08:00
Dan Poltawski f4241a5974 Merge branch 'wip-mdl-49081-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-02-10 09:17:58 +00:00
David Monllao 1c65824b82 MDL-48805 theme: Fixing trailing whitespace 2015-02-10 15:46:31 +08:00
David Monllao f556dce6a5 Merge branch 'm28_MDL-48805' of git://github.com/totara/moodle into MOODLE_28_STABLE 2015-02-10 15:27:04 +08:00
Andrew Davis 0cce3ea50d MDL-48910 core_block: user_can_addto() respects applicable formats 2015-02-10 08:17:32 +01:00
Mark Nelson 52781ec82f MDL-48884 mod_assign: prevented setting gradebook feedback unnecessarily 2015-02-09 22:18:15 -08:00
David Monllao 2ee301e041 Merge branch 'm28_MDL-49064' of git://github.com/totara/moodle into MOODLE_28_STABLE 2015-02-10 11:57:47 +08:00
David Monllao fdc6ac362e Merge branch 'MDL-48960-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-02-10 11:12:33 +08:00
Matt Porritt ceee804962 MDL-49034 enrol_self: Enforce maxlength in self enrolment form fields.
Alter self enrolment creation form to enforce max field lengths.
Limit "Custom instance name" (name) form field to 255 characters via maxlength.
Limit "Enrolment key" (password) form field to 50 characters via maxlength.

Fix for when the form is submitted causing a database write error to be thrown
as corresponding field "name" in the table mdl_enrol is set to varchar(255) and
database field "password" is varying(50).
2015-02-10 13:21:02 +11:00
Eloy Lafuente (stronk7) f16383191b Merge branch 'MDL-48964_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-02-10 01:10:17 +01:00
Eloy Lafuente (stronk7) 1e968e2d27 Merge branch 'MDL-49073-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2015-02-10 01:04:57 +01:00
Dan Poltawski fa75bb63e3 Merge branch 'MDL-48544-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-02-09 22:42:14 +00:00
Eloy Lafuente (stronk7) d71119dbc5 Merge branch 'wip_MDL-49125_m28_install' of https://github.com/skodak/moodle into MOODLE_28_STABLE 2015-02-09 20:02:05 +01:00
Eloy Lafuente (stronk7) b60a617d3d Merge branch 'MDL-48357-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-02-09 15:51:56 +01:00
Dan Poltawski a1504fd7bc Merge branch 'wip-MDL-47558-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-02-09 14:50:37 +00:00
Andrew Nicols 531cc5c727 MDL-48544 blocks: Only add docked tags if all blocks are docked
Previously, if all blocks were hidden, then the region was reported as
being docked eroniously and it was not possible to unhide the blocks.

Docking should have no relation to the presence of block content.
2015-02-09 20:55:44 +08:00
Eloy Lafuente (stronk7) 17f0e2a4af Merge branch 'wip-MDL-48794-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-02-09 13:05:16 +01:00
Dan Poltawski 6561015165 Merge branch 'MDL-44520-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-02-09 11:33:14 +00:00
Dan Poltawski 69d4a9b94f Merge branch 'MDL-48294-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-02-09 11:28:21 +00:00
Dan Poltawski de90103193 Merge branch 'MDL_47085_28' of https://github.com/totara/openbadges into MOODLE_28_STABLE 2015-02-09 10:29:19 +00:00
Dan Poltawski e470238304 Merge branch 'MDL-47953-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-02-09 10:21:42 +00:00
David Monllao 4d31580f93 Merge branch 'MDL-42138-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-02-09 17:18:48 +08:00
David Monllao e89bda0f80 Merge branch 'MDL-36009-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2015-02-09 16:59:28 +08:00
Damyon Wiese 68b7d5ce4a MDL-48543 Mathjax: Update default config for JAWS Math player
JAWS Maths player does not recognise the math content when manually specifying the config for MathJax.
If you use one of the default config files it works.
So - we switch our config to the Accessible.js config that it is based off anyway.
There are no features changes with this approach.
2015-02-09 16:32:32 +08:00
Jetha Chan 1f70c8582d MDL-36009 grader_gradereport: filler and extra user cells should not be headers 2015-02-09 13:53:21 +08:00
Yuliya Bozhko 6db8c22913 MDL-47085 badges: Fix badges file download issues
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
2015-02-09 16:01:09 +13:00
Petr Skoda 8b198fec72 MDL-49125 install: fix installer notices 2015-02-07 13:13:27 +13:00
Adrian Greeve bec8c20cab MDL-48038 mod_tag: Unit tests for tag cron functions. 2015-02-06 14:50:11 +08:00
Adrian Greeve 3359719ce9 MDL-48038 mod_tag: Improvement of tag cron. 2015-02-06 14:50:11 +08:00
Marina Glancy 9c6dab862a MDL-47558 resource: allow to edit module without being redirected
Thanks to Nathan Lewis for the code suggestion
2015-02-06 13:14:18 +08:00
Rajesh Taneja 6da3248b9f MDL-49110 behat: No expand form required in non-js mode 2015-02-06 13:06:52 +08:00
Tony Levi bd8926f9f3 MDL-49110 behat: Do not poll within spin for non-javascript mode 2015-02-06 13:06:44 +08:00
John Okely 93aa18b8de MDL-44520 behat: Change behat features to use new section selectors 2015-02-06 10:34:59 +08:00
John Okely 4dd5623f18 MDL-44520 behat: Add behat selectors for section, activity 2015-02-06 10:34:59 +08:00
John Okely 722e179f30 MDL-42138 user: Require custom profile fields when registering as guest
Previously when someone registers after logging in as a guest, required
custom profile fields would not be required.

Thanks to Andreas Diendorfer for providing the patch.
2015-02-06 10:11:42 +08:00
Tim Hunt c3ab0b8bbf MDL-49041 qtype_multianswer: don't reveal marks on partial responses
This commit also fixes MDL-32049 about the lack or valdiation message
when an incomplete respnses is submitted.

AMOS BEGIN
 CPY [pleaseananswerallparts,qtype_match],[pleaseananswerallparts,qtype_multianswer]
AMOS END
2015-02-05 20:00:53 +00:00
Jean-Michel Vedrine cc8ac87f01 MDL-48964 mod_lesson: Errors when updating matching questions 2015-02-05 13:23:51 +01:00
Dan Poltawski 96dc38c46a weekly release 2.8.3+ 2015-02-05 10:07:22 +00:00
Dan Poltawski 354e304f29 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-02-05 10:07:20 +00:00
Dan Poltawski 89b92ecbb9 MDL-48960 output: use nofollow attribute to stop crawling invalid links
Both the calendar set url and switch theme links are displayed to
non-logged in users which mean they get crawled by search bots. This
prevents the search bots following these links.
2015-02-05 08:14:02 +00:00
Frederic Massart 37dd88e750 MDL-47953 gradereport_grader: Accurate pagination with suspended users
Thanks to Zvonko Martinovic for pointing out the source of the bug.
2015-02-05 15:08:21 +08:00
AMOS bot 1e826d374e Automatically generated installer lang files 2015-02-05 00:04:10 +08:00
Juan Leyva 14a59f1eee MDL-48294 settings: enablemobilewebservice appears twice 2015-02-04 10:27:00 +01:00
Jetha Chan f4966d09b2 MDL-49073 timezones: update to 2015a (2323 rules) 2015-02-04 13:19:31 +08:00
Rajesh Taneja d603a9c792 MDL-49081 tests: Removed dev option from composer
dev option is enabled by default in composer, so not required.
https://github.com/composer/composer/blob/master/CHANGELOG.md
2015-02-04 10:21:01 +08:00
Dan Poltawski 7606f81a88 Merge branch 'MDL-48942_survey_28' of https://github.com/andyjdavis/moodle into MOODLE_28_STABLE 2015-02-03 15:55:24 +00:00
Dan Poltawski abb61b1a65 Merge branch 'MDL-48955-28' of https://github.com/vadimonus/moodle into MOODLE_28_STABLE 2015-02-03 14:04:37 +00:00
Dan Poltawski 14caa61bd4 Merge branch 'wip-mdl-49002-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-02-03 13:16:53 +00:00
Dan Poltawski 45acb77a3f Merge branch 'm28_MDL-48799_Incorrect_Legacy_Dir_Fallback' of https://github.com/scara/moodle into MOODLE_28_STABLE 2015-02-03 13:13:25 +00:00
Dan Poltawski 9e98e66cb2 Merge branch 'm28_MDL-48907' of https://github.com/totara/moodle into MOODLE_28_STABLE 2015-02-03 12:56:44 +00:00
Eloy Lafuente (stronk7) b7f6f1c601 MDL-48920 tool_generator: fix unit tests 2015-02-03 12:39:30 +00:00
Dan Poltawski 8bde103118 Merge branch 'MDL-44071-28' of git://github.com/zbdd/moodle into MOODLE_28_STABLE 2015-02-03 12:17:20 +00:00
Dan Poltawski ed67b6fb06 Merge branch 'MDL-48533_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE 2015-02-03 11:13:50 +00:00
Dan Poltawski 4151d0aa1f MDL-48624 behat: fix trailing whitespace 2015-02-03 11:02:20 +00:00
Dan Poltawski 8bca20b7ec Merge branch 'wip-mdl-48624-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-02-03 11:01:57 +00:00
Eloy Lafuente (stronk7) a6de116442 Merge branch 'wip-mdl-48403-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-02-03 11:57:53 +01:00
Eloy Lafuente (stronk7) 314c64ef2f Merge branch 'wip-mdl-49015-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-02-03 11:52:22 +01:00
Andrew Nicols a43f2c6338 Merge branch 'MDL-48865-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-02-03 16:41:30 +08:00
Neill Magill 401697c397 MDL-48865 core_block: Show regions with only hidden blocks when editing
Before this patch if all the blocks in a block region are set to hidden the region will be docked even when editing is enabled.
This meant that as a user I would need to add a new block to the page and move it to that region via the configuration
menu before I could manipulate the hidden blocks again.
2015-02-03 16:14:36 +08:00
Andrew Nicols 8060291174 Merge branch 'MDL-48920-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-02-03 16:11:44 +08:00
Andrew Nicols 45c07b94fd Merge branch 'tgz_fixing28' of https://github.com/tlevi/moodle into MOODLE_28_STABLE 2015-02-03 16:03:48 +08:00
Andrew Nicols 5b8a93a867 Merge branch '48968-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2015-02-03 14:24:42 +08:00
Andrew Nicols 93e95c2579 Merge branch 'MDL-48929-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-02-03 14:09:53 +08:00
Andrew Nicols 8298719c51 MDL-48484 admin: Improve coding style 2015-02-03 13:43:29 +08:00
Andrew Nicols 76ec958619 Merge branch 'm28_MDL-48484' of https://github.com/totara/moodle into MOODLE_28_STABLE 2015-02-03 13:16:36 +08:00
Andrew Nicols fa224641d8 Merge branch 'm28_MDL-46467' of https://github.com/totara/moodle into MOODLE_28_STABLE 2015-02-03 12:59:12 +08:00
Andrew Nicols d9324ce9ee Merge branch 'MDL-48608_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-02-03 12:31:06 +08:00
Mark Nelson 7728a2cae3 MDL-48608 mod_assign: correctly display grades for group assignments 2015-02-02 20:16:18 -08:00
Eloy Lafuente (stronk7) 36125f82fa Merge branch 'MDL-48525-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-02-03 00:57:46 +01:00
Eloy Lafuente (stronk7) 9555ae2d10 Merge branch 'MDL-48578-28' of git://github.com/jleyva/moodle into MOODLE_28_STABLE 2015-02-03 00:47:40 +01:00
Brian Barnes 8ead44805a MDL-49064 bootstrapbase: fixed rtl alignment of leftalign CSS class 2015-02-03 09:19:29 +13:00
David Monllao e2d914b204 Merge branch 'MDL-31036-28' of git://github.com/zbdd/moodle into MOODLE_28_STABLE 2015-02-02 14:55:01 +08:00
David Monllao 47c6fb2bd3 Merge branch 'MDL-48772-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-02-02 12:29:42 +08:00
David Monllao 8bb969d6cc Merge branch 'wip-mdl-46626-m28' of git://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-02-02 12:08:37 +08:00
Brian Barnes dcde7ca176 MDL-48484 admin: Added labels to configtime settings 2015-02-02 16:34:36 +13:00
AMOS bot 798790c4e8 Automatically generated installer lang files 2015-02-02 00:04:06 +08:00
Matteo Scaramuccia 48a515c37b MDL-48799 Files API: fixed legacy directory fallback. 2015-02-01 09:16:41 +01:00
Eloy Lafuente (stronk7) 68b1fd2c55 Moodle release 2.8.3 2015-01-30 12:35:40 +01:00
Zachary Durber 07f99ca6d6 MDL-31036 mod_assign: Don't strip quickgrading feedback of special chars 2015-01-30 14:37:55 +08:00
John Okely b4ac530cf2 MDL-48772 enrol_cohort: Replace hardcoded language with language strings 2015-01-30 11:36:06 +08:00
Rajesh Taneja b3486b0192 MDL-48403 behat: Select text in atto editor before inserting image 2015-01-30 10:10:46 +08:00
Tyler Bannister ab4a3e8cb1 MDL-46626 report_log: Removed HTML from log report export
This is a partial backport of MDL-34867
2015-01-30 09:09:37 +08:00
Rajesh Taneja c9d53c1e17 MDL-49002 mod_lesson: Added @_file_upload tag to avoid random fails 2015-01-30 09:01:13 +08:00
Rajesh Taneja 66293e8414 MDL-49015 mod_lesson: Removed unused image insert step in behat 2015-01-30 08:58:52 +08:00
Rajesh Taneja f8fe046fb5 MDL-49015 mod_lesson: Don't rely on external links in behat 2015-01-30 08:58:52 +08:00
Rajesh Taneja a686d8374a MDL-48624 behat: Added page load check in workshop step
i_allocate_submissions_in_workshop_as step sometimes
fails because of server speed. Added page load check
with extended timout.
2015-01-30 08:55:30 +08:00
Rajesh Taneja c441c21e7a MDL-48624 behat: Added extended timeout to ensure step pass
following_should_download_between_and_bytes step sometimes
fails because of server speed. Added extended timout
ensuring they wait enough before failing.
Also, not calling force download while running behat site
2015-01-30 08:55:29 +08:00
Vadim Dvorovenko d3f49a8c84 MDL-48955 filter_mathjax: Regexp fix for texfiltercompatibility mode
Fixing incorrect regexp for replacing text like
"$$a$$ and $$b$$" to "\(a\) and \(b\)". This is needed for
texfiltercompatibility to work as expected.
2015-01-29 23:16:51 +07:00
AMOS bot e5cfbd85d8 Automatically generated installer lang files 2015-01-30 00:04:12 +08:00
Juan Leyva 060c2d3c9c MDL-48357 webservices: Missing instance property in course contents ws 2015-01-29 14:15:16 +01:00
Tony Levi 846711d69f MDL-48924 backup: Fix some get_file_packer() calls for enabletgzbackups 2015-01-29 22:53:14 +10:30
Eloy Lafuente (stronk7) 6e1308b948 weekly release 2.8.2+ 2015-01-29 10:28:18 +01:00
Eloy Lafuente (stronk7) c889f1b592 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-01-29 10:28:13 +01:00
Andrew Nicols 4d3403d5a7 Merge branch 'MDL-36877_28' of https://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-01-29 09:10:04 +08:00
Jean-Michel Vedrine fc0613cb0c MDL-36877 mod_lesson: Fix while MDL-38578 is not solved 2015-01-28 21:25:55 +01:00
Juan Leyva 6dbf42a600 MDL-48525 webservices: Fixed profile user image is not always returned 2015-01-28 17:20:37 +01:00
Juan Leyva 4a97b8476b MDL-48578 webservices: Fixed missing required library 2015-01-28 14:44:48 +01:00
Simon Coggins 9b59baccb1 MDL-48855 dev: Fix ctags command to handle extra whitespace 2015-01-28 12:42:15 +01:00
Marina Glancy d08b45781f MDL-48978 user: fixed regression from MDL-37704 2015-01-28 11:58:48 +01:00
David Monllao 43439ea041 Merge branch 'MDL-48914-28' of git://github.com/rtcn2/moodle into MOODLE_28_STABLE 2015-01-28 17:44:49 +08:00
Andrew Nicols 2ceba911aa MDL-48542 user_menu: Handle invalid strings better 2015-01-28 15:38:56 +08:00
Damyon Wiese a72f2cca7f MDL-48980 Security: Always clean the result from min_get_slash_argument
The result from this function is used in send_file calls and if unclean
(windows dir separators, or .. path components) it could expose sensitive
files (e.g. .php files). Now we always clean the result from this function
even if it means double cleaning.

I also fixed the unit test for this function and added a new test for this cleaning.

I also updated the comments to point to get_file_argument as the full version of
min_get_slash_argument.
2015-01-28 14:38:11 +08:00
Andrew Nicols 2f12e58ce4 Merge branch 'MDL-41026-28-fixes' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-01-28 13:59:15 +08:00
Andrew Nicols e86817b76c MDL-41026 webservices: Correct unit tests 2015-01-28 13:58:46 +08:00
Andrew Nicols f6ab2b1ccf MDL-48542 user_menu: Increment index for all menu items
The invalid type was not causing the idx to incremented, thus missing off
the final divider.
2015-01-28 12:10:45 +08:00
Andrew Nicols ba43cfbd21 MDL-48542 user_menu: Improve user menu tests
Add additional test cases, and actually test that the output is roughly
what we expect.
2015-01-28 12:10:44 +08:00
Andrew Nicols cd1ea20389 Merge branch 'MDL-48542-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2015-01-28 12:09:46 +08:00
Andrew Nicols 412aa0210b Merge branch 'MDL-41026-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-01-28 10:06:28 +08:00
Eloy Lafuente (stronk7) 7e67e4d619 Merge branch 'MDL-48685-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-01-28 00:46:29 +01:00
Eloy Lafuente (stronk7) 510ffce704 Merge branch 'MDL-48660-m28' of https://github.com/sammarshallou/moodle into MOODLE_28_STABLE 2015-01-27 21:13:45 +01:00
AMOS bot ad93802610 Automatically generated installer lang files 2015-01-28 00:04:23 +08:00
Eloy Lafuente (stronk7) 8d4ef0df4b Merge branch 'MDL-40285_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-01-27 12:21:11 +01:00
Eloy Lafuente (stronk7) 01f200ad39 Merge branch 'MDL-48383-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-01-27 12:01:24 +01:00
sam marshall b749aaa935 MDL-48660 Availability: filter_user_list() should respect 'view hidden'
Updated filter_user_list and get_user_list_sql to account for
the viewhiddenactivities and viewhiddensections capabilities.
2015-01-27 10:59:53 +00:00
Mark Nelson 041dd2902d MDL-40285 mod_assign: added extra group submissions behat scenario
Thanks a lot to Jody Steele for providing the basis for the scenario.
2015-01-27 00:35:31 -08:00
Mark Nelson 790eb7ee05 MDL-40285 mod_assign: show details for all default group members 2015-01-27 00:35:31 -08:00
Andrew Nicols 97f243a916 Merge branch 'MDL-47871_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE 2015-01-27 13:13:57 +08:00
Jerome Mouneyrac 27acee5df2 MDL-41026 webservices: use correct param format in external apis 2015-01-27 10:08:25 +05:30
James Henestofel 9f5571d405 MDL-44071 webservices: Sorting courses post deletion.
Signed-off-by: Zachary Durber <zdurber@gmail.com>
2015-01-27 11:40:58 +08:00
Mark Nelson aee1045f7e MDL-47871 tool_monitor: allow teachers to duplicate site rules 2015-01-26 19:36:27 -08:00
Frederic Massart fa5aa434bd MDL-48920 tool_generator: Use 'real' names during course generation 2015-01-27 11:27:55 +08:00
Andrew Nicols d110033f81 Merge branch 'MDL-48491-28' of git://github.com/zbdd/moodle into MOODLE_28_STABLE 2015-01-27 10:57:57 +08:00
Brian Barnes 1ff8d56a2e MDL-46467 forms: Labels have "for" attribute even when frozen 2015-01-27 14:55:26 +13:00
Andrew Nicols eeaf95494f MDL-48685 core_useragent: Correct IE 5.0 issues 2015-01-27 08:36:28 +08:00
Andrew Nicols 483bdb5c24 MDL-48685 tests: Add testing for supports_json_contenttype 2015-01-27 08:36:28 +08:00
Andrew Nicols 54d3ed0357 MDL-48685 tests: Add additional User Agents
* Firefox 33; Mac OS X 10.10
* Chrome 39; Mac OS X
* Safari; iPhone 6 Plus; iOS 8.1; Build 12B411
* Opera 12.15 (Build 1748); Mac OS X
2015-01-27 08:36:28 +08:00
Andrew Nicols 89cb4f9f35 MDL-48685 tests: Rewrite useragent tests 2015-01-27 08:36:27 +08:00
Eloy Lafuente (stronk7) 0c6add5bf9 Merge branch 'MDL-48916_28' of https://github.com/wesleysitu/moodle into MOODLE_28_STABLE 2015-01-27 01:09:35 +01:00
Eloy Lafuente (stronk7) f3a8098268 Merge branch 'MDL-48921-28-2nd' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-01-27 01:02:46 +01:00
Eloy Lafuente (stronk7) c3e2b05d40 Merge branch 'wip-MDL-48325-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-01-27 00:25:57 +01:00
Eloy Lafuente (stronk7) 7458e60445 Merge branch 'MDL-48720-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-01-26 19:11:34 +01:00
Eloy Lafuente (stronk7) bf986b9e45 Merge branch 'MDL-35765-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-01-26 17:32:25 +01:00
Eloy Lafuente (stronk7) e534402886 Merge branch 'MDL-36877_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-01-26 16:04:37 +01:00
Andrew Davis 2e77d5ec7b MDL-48942 mod_survey: synced security checks in view.php and graph.php 2015-01-26 15:06:28 +01:00
Eloy Lafuente (stronk7) 22896c10ba Merge branch 'MDL-48711-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-01-26 11:14:42 +01:00
Eloy Lafuente (stronk7) 58ad8a2321 Merge branch 'MDL-43421-28' of git://github.com/mr-russ/moodle into MOODLE_28_STABLE 2015-01-26 10:24:59 +01:00
Brian Barnes e5a35eb25f MDL-48805 theme: Collapse now collapses all data-target 2015-01-26 11:32:10 +13:00
Valerii Kuznetsov d5da6e42c2 MDL-48968 blocks: fixed bug with pagetype handling 2015-01-26 09:28:41 +13:00
Jean-Michel Vedrine cbc028dbae MDL-36877 Lesson: final page not displayed if show gradebook set to no 2015-01-25 19:44:19 +01:00
Rod Norfor fc811dd468 MDL-48914 admin: check maxuserperpage in existingroleholders->find_users 2015-01-23 15:59:34 +00:00
Nelson Moller 116dd8a02f MDL-48929 repository_filesystem: Valide relative path against realpath
On Windows systems, there could have been a mix of back and forward
slashes, causing the validation of the relative path to fail. Now
we will always get the realpath before comparing.
2015-01-23 17:28:19 +08:00
Andrew Nicols c06aa292b1 weekly release 2.8.2+ 2015-01-23 08:28:04 +08:00
Andrew Nicols e52a55c407 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-01-23 08:27:57 +08:00
Dan Poltawski 0b331a73c6 Merge branch 'MDL-48949_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-01-22 17:53:23 +00:00
Tim Hunt a52b56b719 MDL-48949 mod_lti: tidy mod/lti/upgrade.txt 2015-01-22 17:29:39 +00:00
Adrian Greeve a6acd5ff4f MDL-48325 mod_data: Export to portfolio button uses capability.
The Export to portfolio button now checks the mod/data:exportownentry
capability to see if the export button should be shown.
2015-01-22 14:59:33 +08:00
Zachary Durber 3a57e2a532 MDL-48491 enrolments: Paypal enrolments send email as support user. 2015-01-22 13:47:45 +08:00
Andrew Nicols a1d1479ff1 Revert "Merge branch 'wip-mdl-48624-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE"
This reverts commit 48549b6515, reversing
changes made to 87802c924f.
2015-01-22 12:16:27 +08:00
Frederic Massart 737a5f7fe4 MDL-48383 task: Indicate when a task will not run if plugin is disabled 2015-01-22 11:08:10 +08:00
Eloy Lafuente (stronk7) a51d8d8560 Merge branch 'MDL-48823_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-01-21 12:32:28 +01:00
Frederic Massart b71598cf81 MDL-48921 admin: Keep the search string in the URL after form submission 2015-01-21 15:50:51 +08:00
Andrew Nicols 9a0284c657 MDL-48720 mod_forum: Tidy up whitespace to comply with coding style 2015-01-21 12:42:42 +08:00
Andrew Nicols 9a220d7976 MDL-48720 mod_forum: Only copy discussion preferences when moving posts
Rather than adding discussion preferences to a user based upon their
subscription to the source forum, only respect any actively selected
preference. That is to say that:
* if a user has opted into a discussion and following a move would be
  unsubscribed, re-subscribe them;
* if a user has opted out of a discussion and following a move would be
  subscribed once more, unsubscribe them; and
* if a user has not made an active choice, follow the discussion preference
  for the target forum.
2015-01-21 12:42:41 +08:00
David Monllao b550538ce3 MDL-48823 admin: Just one admin tree reload after settings changes 2015-01-21 10:42:17 +08:00
Andrew Nicols 89b5e52ba8 Merge branch 'wip-mdl-48761-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-01-21 10:22:01 +08:00
Rajesh Taneja e947035dc7 MDL-48761 behat: Added new step for debugging scenarios 2015-01-21 10:17:39 +08:00
Wesley Situ 0c8e82aade MDL-48916 atto_undo: Clarify text for "Undo/Redo" 2015-01-20 16:21:02 -08:00
Eloy Lafuente (stronk7) af04908d0d Merge branch 'wip-MDL-48847-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2015-01-21 00:28:38 +01:00
Eloy Lafuente (stronk7) 4c8fae005e Merge branch 'MDL-48830-m28' of https://github.com/micaherne/moodle into MOODLE_28_STABLE 2015-01-21 00:04:14 +01:00
Brian Barnes 044b689308 MDL-48907 grades: fixed display of grade tabs 2015-01-21 10:37:54 +13:00
Eric Merrill 2c1f64c0da MDL-48711 gradebook: Properly compute extra-redit status for cat grades
When seeing if a grade item for a category is computed for extra-credit
status, we need to use the *grandparent* of the item.
2015-01-20 16:06:02 -05:00
Eric Merrill e8a979d4bb MDL-35765 availability: Use category total full names 2015-01-20 15:38:07 -05:00
Eloy Lafuente (stronk7) c41fe79c85 Merge branch 'MDL-48873_moodle28' of https://github.com/StudiUM/moodle into MOODLE_28_STABLE 2015-01-20 19:27:22 +01:00
Eloy Lafuente (stronk7) 189dee55d4 Merge branch 'MDL-48813_m28' of git://github.com/sbourget/moodle into MOODLE_28_STABLE 2015-01-20 19:20:39 +01:00
Eloy Lafuente (stronk7) 7f2083fadf Merge branch 'wip-mdl-48837-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-01-20 18:52:14 +01:00
Dan Poltawski f11c6059ea Merge branch 'MDL-48798-28' of https://github.com/vadimonus/moodle into MOODLE_28_STABLE 2015-01-20 17:50:24 +00:00
Eloy Lafuente (stronk7) 45b68d3cdd Merge branch 'MDL-48477_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-01-20 18:44:43 +01:00
Eloy Lafuente (stronk7) 38e8b26234 Merge branch 'MDL-48779-28' of https://github.com/vadimonus/moodle into MOODLE_28_STABLE 2015-01-20 18:41:21 +01:00
Eloy Lafuente (stronk7) dfe44858da Merge branch 'MDL-47792_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2015-01-20 18:38:06 +01:00
Dan Poltawski 2f0f15c2e7 Merge branch 'wip-mdl-48831-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-01-20 17:30:50 +00:00
Dan Poltawski f40423c766 Merge branch 'MDL-48829_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-01-20 17:07:54 +00:00
Eloy Lafuente (stronk7) 48549b6515 Merge branch 'wip-mdl-48624-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2015-01-20 17:34:04 +01:00
Eloy Lafuente (stronk7) 87802c924f Merge branch 'MDL-47166-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2015-01-20 16:15:46 +01:00
David Monllao e31f7ac7b9 Merge branch 'MDL-48765-28' of git://github.com/gurgus/moodle into MOODLE_28_STABLE 2015-01-20 17:08:57 +08:00
David Monllao f3b0ba7c8f Merge branch 'MDL-48776-28' of git://github.com/gurgus/moodle into MOODLE_28_STABLE 2015-01-20 16:07:54 +08:00
Andrew Nicols 8b6412b1f7 Merge branch 'MDL-42172-28' of https://github.com/vadimonus/moodle into MOODLE_28_STABLE 2015-01-20 15:43:15 +08:00
Patrik Granlöv f9d5676c10 MDL-35486 outputlib: Fix typos in comments
Just a copy-past text error in two comments.
2015-01-20 14:03:34 +08:00
Andrew Nicols af152f8d1e Merge branch 'MDL-44560-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-01-20 13:26:02 +08:00
Andrew Nicols 628109a9cf Merge branch 'MDL-38277_m28' of https://github.com/sbourget/moodle into MOODLE_28_STABLE 2015-01-20 12:44:40 +08:00
Aaron Barnes 6aca5dd717 MDL-47792 javascript: Fix for cropped headers and horizontal align 2015-01-20 11:40:19 +08:00
Jean-Michel Vedrine 7e11f1b2f5 MDL-48596 mod_lesson: editing interface won't expand to full screen 2015-01-20 11:05:04 +08:00
Andrew Nicols 054221331a Merge branch 'MDL-48741_28' of git://github.com/stronk7/moodle into MOODLE_28_STABLE 2015-01-20 09:56:47 +08:00
Jetha Chan 2dfdb127b6 MDL-48542 user_menu: add proper divider support
Added divider support to the user menu; hardened the custom user menu against invalid input.
2015-01-19 23:58:40 +08:00
Jetha Chan 3014b8cb60 MDL-48542 user_menu: add custom user menu unit test 2015-01-19 23:58:40 +08:00
Dave Cooper 5c703c83fd MDL-48776 core_message: Fixed userid check.
Thanks to Oleg Demeshev for providing the patch.
2015-01-19 15:21:03 +08:00
Andrew Nicols 24b7c67edb Merge branch 'MDL-46976-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-01-19 12:19:16 +08:00
Andrew Nicols 695503a7f1 Merge branch 'MDL-48073-28' of git://github.com/gurgus/moodle into MOODLE_28_STABLE 2015-01-19 11:37:22 +08:00
Nivedita Setru 542db0f6fe MDL-48073 enrol: Fixed group filter resetting erroneously. 2015-01-19 11:26:07 +08:00
Rajesh Taneja 33211ce256 MDL-48624 behat: Added extended timeout in workshop step
i_allocate_submissions_in_workshop_as step sometimes
fails because of server speed. Added extended timout
ensuring they wait enough before failing.
2015-01-19 10:18:49 +08:00
Rajesh Taneja 20a095345b MDL-48624 behat: Added extended timeout to ensure step pass
following_should_download_between_and_bytes step sometimes
fails because of server speed. Added extended timout
ensuring they wait enough before failing.
Also, not calling force download while running behat site
2015-01-19 10:18:42 +08:00
Jean-Michel Vedrine 175b34c45d MDL-43386 Lesson: Grade essay student response formatting not correct 2015-01-18 20:41:51 +01:00
Vadim Dvorovenko a8808ad7ba MDL-42172 Authentification: Adding alternate names to "Lock user fields"
Adding alternate name fields (firstnamephonetic, lastnamephonetic,
middlename, alternatename) to "Lock user fields" for all
authentification plugins. This is needed to sync alternate name fields
with external data sources and to lock them for editing.
2015-01-17 23:10:09 +07:00
Vadim Dvorovenko 5e25d5630b MDL-48798 Statistics: Adding lang string for user activity.
New lang string for 'Activity' (meaning count of user actions) in stats
reports to disambiguate it with 'Activity' (meaning course module).

AMOS BEGIN
 CPY [activity,core],[useractivity,core]
AMOS END
2015-01-17 23:04:11 +07:00
AMOS bot 778e83669f Automatically generated installer lang files 2015-01-18 00:03:58 +08:00
Vadim Dvorovenko ad2c1a2156 MDL-48779 MNet: multibyte substr in certificate generation
Using core_text::substr instead of substr for trimming certificate
data. Is needed for sites with long unicode sitename to prevent
breaking line between unicode pair.
2015-01-17 23:01:47 +07:00
Gilles-Philippe Leblanc 6dc66f5a48 MDL-48873 auth_cas: Wrong redirection with bad multiauth login 2015-01-16 11:55:08 -05:00
Ray Bon 54ea4bee35 MDL-48837 phpunit: Restore system default timezone 2015-01-16 12:47:13 +08:00
John Okely 3bb4665841 MDL-44560 glossary: Fix pagination on glossary category view
Credit to Sebastian B for this fix
2015-01-16 11:12:42 +08:00
Rajesh Taneja f0724d200a MDL-48831 behat: Added behat test for label activity
Thanks to Neill Magill, for providing test feature.
2015-01-16 10:39:05 +08:00
Rajesh Taneja a43bbc7838 MDL-48831 behat: Fixed activity show hide for label
Labels are not links and have dimmed_text class
So updated find query for show/hide activity check
2015-01-16 10:39:05 +08:00
Eloy Lafuente (stronk7) 7e5840e4b6 MDL-48741 behat: add new moodle_list formatter (rerun compatible) 2015-01-16 03:14:56 +01:00
Stephen Bourget 521af16fe5 MDL-38277 Lesson: Fix strings on activity report 2015-01-15 12:56:25 -05:00
Tim Hunt 27fc1831e8 MDL-48829 quiz nav: add a data attr to buttons giving the page
This way, if you need to know which page each button goes to in
JavaScript, you can find out.
2015-01-15 10:18:39 +00:00
Tim Hunt 142c67ce07 MDL-48477 questions: no delete icon for only top-level category
The back end code already threw an exception if you clicked the icon,
so you could not delete the category, but we should not have shown the
icon in the first place.

Thanks to Pramith Dayananda for working out the fix for this issue. I am
just committing it.
2015-01-15 10:18:31 +00:00
Michael Aherne 5b469142de MDL-48830 accesslib: Add sort field to query 2015-01-15 10:17:08 +00:00
Andrew Nicols 2ea6a2b161 weekly release 2.8.2+ 2015-01-15 14:20:20 +08:00
Andrew Nicols 273eec1330 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-01-15 14:20:09 +08:00
Charles Fulton 147d54f9ff MDL-48765 enrol: do not use a non-breaking space as a separator 2015-01-15 11:21:19 +08:00
Marina Glancy a9bac80cac MDL-48847 groups: fixed incorrect user count 2015-01-15 11:12:25 +08:00
Dan Poltawski 1dcf25db8b MDL-46976 user: trim whitespace from input email address
Don't complain about invalid email address, we are a computer, we
love the jobs users hate.

ref: https://www.youtube.com/watch?v=5tquSbZEP-g
2015-01-14 17:14:50 +00:00
AMOS bot e6b538e2a2 Automatically generated installer lang files 2015-01-15 00:04:03 +08:00
Dan Poltawski c5203c98bf Merge branch 'MDL-14730_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-01-14 10:27:46 +00:00
John Okely 27cf863db5 MDL-47761 enrol: Show more detail for self-enrolment errors
Thanks to Mirko Otto for the solution
2015-01-14 00:30:15 +01:00
Eloy Lafuente (stronk7) 76da38fd5c Merge branch 'M28_MDL-48574_workflow_state_updated_batch_single' of https://github.com/Dave-B/moodle into MOODLE_28_STABLE 2015-01-14 00:14:45 +01:00
Eloy Lafuente (stronk7) 87caaf87e3 Merge branch 'MDL-41166-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-01-13 23:42:25 +01:00
Eloy Lafuente (stronk7) bb1aaadf48 Merge branch 'MDL-48753_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-01-13 15:48:42 +01:00
Dan Poltawski 601c8883c8 Merge branch 'MDL-36824_m28' of https://github.com/sbourget/moodle into MOODLE_28_STABLE 2015-01-13 13:15:06 +00:00
Dan Poltawski f049403ed1 Merge branch 'MDL-39103-28' of git://github.com/xow/moodle into MOODLE_28_STABLE
Conflicts:
	mod/lesson/lib.php
2015-01-13 12:54:53 +00:00
Dan Poltawski 7e6be7ba1f Merge branch 'MDL-45784-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2015-01-13 12:34:45 +00:00
Dan Poltawski 1d0a5a5be9 Merge branch 'MDL-48474_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-01-13 11:47:53 +00:00
Stephen Bourget 871a756d06 MDL-48750 Lesson: Behat test for lesson attempt info
behat test provided by Jean-Michel Vedrine
2015-01-13 10:59:53 +00:00
Stephen Bourget 6c5b72e889 MDL-48750 Lesson: Fix attempt info displayed by course overview block 2015-01-13 10:59:29 +00:00
Dan Poltawski 7f3932c840 Merge branch 'MDL-40326_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-01-13 10:08:18 +00:00
Dan Poltawski 4ed7ae68a0 Merge branch 'MDL-48510-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-01-13 08:29:11 +00:00
Ankit Agarwal 64a15b04b1 MDL-48510 inbound: use 0 expiration for private files handler 2015-01-13 09:29:13 +05:30
Ankit Agarwal 8293f6c86f MDL-48510 inbound: Support disabling of expiration changes in UI 2015-01-13 09:26:20 +05:30
Ankit Agarwal 5a8291753a MDL-48510 inbound: Use correct value of expiration 2015-01-13 09:26:20 +05:30
Andrew Nicols 312163cd26 Merge branch 'MDL-43898-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-01-13 10:28:12 +08:00
Stephen Bourget 282c5c2b7d MDL-48813 Lesson: Remove unused GROUPMEMBERSONLY 2015-01-12 16:38:47 -05:00
Eloy Lafuente (stronk7) de12ede98e MDL-35155 database: better sql_substr() impl. for mssql/sqlsrv + unit tests
MSSQL's substring() implementation is somehow silly/strict and unable to
perform implicit casts to integer both for the start and length parameters.

This hits Moodle badly because of another problems (MDL-23997) we decided
to cast to string all bound placeholders long ago.

So this commit just enforces the cast of the start and length parameters to
integer. And includes unit tests for using placeholders on all positions in
the sql_substr() method.
2015-01-12 18:26:38 +01:00
Eloy Lafuente (stronk7) 817f22818b Merge branch 'MDL-35155-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-01-12 18:26:29 +01:00
AMOS bot 2aaab5b275 Automatically generated installer lang files 2015-01-13 00:04:00 +08:00
AMOS bot 3571d0a90e Automatically generated installer lang files 2015-01-13 00:04:00 +08:00
Dan Poltawski d926178366 Merge branch 'MDL-31774_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-01-12 14:37:51 +00:00
Dan Poltawski 1cc4ac0486 Merge branch 'MDL-47935-28' of git://github.com/gurgus/moodle into MOODLE_28_STABLE 2015-01-12 12:59:39 +00:00
Dan Poltawski f7ae8d3b11 Merge branch 'MDL-44907-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-01-12 11:30:32 +00:00
Marina Glancy 054609f8b0 MDL-48794 report_log: make sure y-axis gridlines in graphs are integers 2015-01-12 16:21:37 +08:00
Andrew Nicols 595b56d28d Merge branch 'MDL-46671-28' of https://github.com/pjking07/moodle into MOODLE_28_STABLE 2015-01-12 13:57:10 +08:00
Andrew Nicols 55f84c72b4 Merge branch 'MDL-47425-28' of git://github.com/zbdd/moodle into MOODLE_28_STABLE 2015-01-12 13:44:26 +08:00
Sam Hemelryk 2dcc434f67 MDL-48753 badges: converted func to named params
Converted the SQL params within badges_get_user_badges to
named params.
Unit tests added for this function at the same time.
UI covered by behat already.
2015-01-11 20:12:29 -08:00
Andrew Nicols 80eec75b85 Merge branch 'MDL-38142-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-01-12 11:56:30 +08:00
Andrew Nicols 270c4a7fa3 Merge branch 'MDL-47692_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-01-12 11:30:00 +08:00
Jean-Michel Vedrine db63d99dbf MDL-31774 mod_lesson: Wrong jumps in lessons with mutiple clusters 2015-01-10 18:41:00 +01:00
AMOS bot 362834051b Automatically generated installer lang files 2015-01-11 00:04:06 +08:00
Eloy Lafuente (stronk7) f2c730fecf Moodle release 2.8.2 2015-01-10 13:12:58 +01:00
Stephen Bourget 26879477ce MDL-36824 Lesson: Media File should be displayed as a block 2015-01-09 18:17:15 -05:00
David Balch aed75e9597 MDL-48574 assign: Test workflow_state_updated fired on batch and single. 2015-01-09 15:24:25 +00:00
Jean-Michel Vedrine 6d4858392b MDL-14730 mod_lesson: allow linking to pages inside a lesson 2015-01-09 11:39:40 +01:00
Dave Cooper 19f78c1c84 MDL-47935 Atto: Moved atto notification message position 2015-01-09 15:55:18 +08:00
Zachary Durber b79691baea MDL-47425 mod_assign: Allow sorting by state without submissions.
Special thanks to Antton Rodriguez for the suggested patch.
2015-01-09 14:49:45 +08:00
Frederic Massart fec61db075 MDL-38142 mod_forum: Allow viewing of student posts in hidden courses 2015-01-09 11:38:12 +08:00
Andrew Nicols dde9be79c3 MDL-47166 atto_indent: Swap Outdent and Indent 2015-01-09 09:21:59 +08:00
Tim Hunt c38eb4e6e6 MDL-48474 qtype_shortanswer: answers were not being trimmed.
This fix is based on Oleg Sychev's suggestion. Thanks.
2015-01-08 17:43:18 +00:00
AMOS bot 812779dfa2 Automatically generated installer lang files 2015-01-09 00:04:08 +08:00
Dan Poltawski ed46f0deb1 weekly release 2.8.1+ 2015-01-08 10:00:28 +00:00
Dan Poltawski 9c1f1cda90 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2015-01-08 10:00:26 +00:00
Frederic Massart 2981fb45a0 MDL-44907 admin: Better styling of admin settings validation errors
Conflicts:
	theme/bootstrapbase/style/moodle.css
2015-01-08 16:23:34 +08:00
Dan Poltawski fa01f2b45a MDL-35155 dml: add unit test which exposes substr problem
Previously, when using parameters, substring broke on mssql.
2015-01-08 08:14:10 +00:00
Simon Coggins 48ddb7968f MDL-35155: Fix MSSQL bug in sql_substr() 2015-01-08 08:14:09 +00:00
Andrew Davis 73639b4124 MDL-48702 logs: switched retrieval to get_recordset_select() 2015-01-08 09:08:50 +01:00
Mark Nelson 7bc0151a4c MDL-48533 report_backups: added ability to view backup logs 2015-01-07 22:25:04 -08:00
Mark Nelson 85f5d4ac95 MDL-48533 core_backup: use default log level when none specified 2015-01-07 22:25:03 -08:00
John Okely fd648fd5f0 MDL-45784 lesson: Remove preview link for students viewing lesson
Credit to Pete Jones for the fix.
2015-01-08 13:28:48 +08:00
Eloy Lafuente (stronk7) b78438abc0 Merge branch 'MDL-37584-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-01-08 00:46:41 +01:00
Eloy Lafuente (stronk7) 19389fc511 Merge branch '37680-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2015-01-08 00:40:52 +01:00
Zachary Durber 63ed941a93 MDL-48546 filters: Split on all tags for multimedia filter check. 2015-01-07 18:56:49 +01:00
Eloy Lafuente (stronk7) 2d90c646be Merge branch 'MDL-48748-28-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2015-01-07 17:23:19 +01:00
AMOS bot 324dfc764c Automatically generated installer lang files 2015-01-08 00:03:59 +08:00
David Balch 0697df81aa MDL-48574 assign: Fire workflow_state_updated event on batch and single.
This change adds the workflow_state_updated event when changing workflow
state using the single grading page and the quick grading mechanisms.
Previously, it only fired for batch updates using
process_set_batch_marking_workflow_state().
2015-01-07 14:47:22 +00:00
Ankit Agarwal f517d1c20b MDL-48688: inbound: remove spaces from exception 2015-01-07 13:44:25 +08:00
Mark Nelson f7f477a65d MDL-46498 mod_assign: fixed failing behat test due to GS 2015-01-07 13:30:12 +08:00
Zachary Durber 01da07a42b MDL-48546 filters: ReDoS protection for multimedia links. 2015-01-07 12:28:22 +08:00
Andrew Nicols 5cb84b5ba4 Merge branch 'MDL-45930-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-01-07 12:08:16 +08:00
David Monllao fb270fd5de Merge branch 'MDL-48549_m28' of git://github.com/markn86/moodle into MOODLE_28_STABLE 2015-01-07 09:40:22 +08:00
David Monllao 2111c597ac Merge branch 'wip-MDL-48523-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-01-07 09:21:53 +08:00
Eloy Lafuente (stronk7) cd663df1ad Merge branch 'MDL-32088-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-01-07 02:11:48 +01:00
David Monllao b68c14c98d Merge branch 'MDL-48697-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-01-07 09:07:13 +08:00
David Monllao 2fe7bf0585 Merge branch 'MDL-48688-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-01-07 08:48:05 +08:00
Mark Nelson 7cadfa8e86 MDL-47692 mod_quiz: added additional question_manually_graded trigger 2015-01-06 15:13:28 -08:00
Helen Foster 59ea75fd37 MDL-48748 lang: Merge English strings from the en_fix language pack 2015-01-06 21:57:11 +01:00
Jean-Michel Vedrine c80603ddc4 MDL-48034 mod_lesson: grade capability missing RISK_XSS 2015-01-06 12:52:21 +00:00
Dan Poltawski 8b7e92206c Merge branch 'MDL-44393-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-01-06 12:21:04 +00:00
Dan Poltawski 787d05f3d3 Merge branch 'MDL-46015_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-01-06 12:04:09 +00:00
Dan Poltawski acb579245a Merge branch 'MDL-48372-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-01-06 11:24:30 +00:00
Dan Poltawski f704c30f8a Merge branch 'MDL-48442-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-01-06 11:19:33 +00:00
Dan Poltawski e54fe38e2b Merge branch 'MDL-48534_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE 2015-01-06 11:11:43 +00:00
Dan Poltawski 921e63c880 Merge branch 'MDL-48655-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-01-06 11:09:43 +00:00
Simey Lameze 693918c30e MDL-47964 auth_shibboleth: Fix DOS on the shibboleth logout 2015-01-06 11:05:25 +00:00
Marco Rougeth 6bb02c27d5 MDL-48640 report_configchanges: Remove duplicated code 2015-01-06 15:52:57 +08:00
John Okely 502a403b43 MDL-39103 lesson: Fix lesson administration block
Credit to Joseph Rézeau for the fix
2015-01-06 14:53:29 +08:00
David Monllao 63a07d3a21 Merge branch 'MDL-38222_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-01-06 12:27:20 +08:00
Andrew Nicols ac1c429ebd Merge branch 'MDL-48701-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-01-06 12:06:01 +08:00
Andrew Nicols 42f3477091 Merge branch 'MDL-48704-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2015-01-06 11:59:15 +08:00
Andrew Nicols 9b2438597a Merge branch 'MDL-48707_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-01-06 11:51:14 +08:00
Andrew Nicols 7a5e665072 Merge branch '28067-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2015-01-06 10:53:50 +08:00
Andrew Nicols 2c908ec30b MDL-20304 lesson: Uncomment tests following MDL-48631 2015-01-06 10:37:42 +08:00
Andrew Nicols f595e3cbae Merge branch 'MDL-20304-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-01-06 10:37:37 +08:00
David Monllao 1bacd164c3 Merge branch 'MDL-35078-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2015-01-06 10:34:50 +08:00
David Monllao 76dd58bb4f Merge branch 'MDL-48631_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2015-01-06 09:09:24 +08:00
Dan Poltawski 8e293f17cf Merge branch 'MDL-48441_profile_guest_28' of https://github.com/andyjdavis/moodle into MOODLE_28_STABLE 2015-01-05 18:30:25 +00:00
Dan Poltawski 4afd408b55 Merge branch 'MDL-46498_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE 2015-01-05 17:48:39 +00:00
Andrew Nicols 8d9a3b3b62 MDL-48104 mod_assign: Strip out use of eval() for string parsing
I've also replaced other  occurrences of M.str with the correct use of
M.util.get_string() instead.
2015-01-05 17:21:14 +00:00
Dan Poltawski 0aee829cd3 Merge branch 'MDL-43679-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-01-05 15:49:26 +00:00
Simey Lameze 88929ca824 MDL-48017 core_calendar: add context validation to get_calendar_events 2015-01-05 14:13:48 +00:00
Andrew Nicols 5770e51478 MDL-48106 mod_glossary: Add missing sesskey checks 2015-01-05 13:38:01 +00:00
David Monllao e72516ccde MDL-48329 core_message: Checking that messaging system is enabled 2015-01-05 13:14:03 +00:00
Simey Lameze 38ca8793b6 MDL-48368 course: fix xss on course request pending page 2015-01-05 12:58:53 +00:00
Jetha Chan faf0cd9098 MDL-47920 mod_lti: add capability checks, http headers 2015-01-05 12:50:18 +00:00
Andrew Nicols f7714bb67b Merge branch 'MDL-42519_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2015-01-05 16:18:13 +08:00
Andrew Nicols 764247be6b Merge branch 'MDL-48582-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-01-05 15:27:44 +08:00
Andrew Nicols 289ac435d1 Merge branch 'MDL-48644_restoreLegacyLogs28' of https://github.com/moodlerooms/moodle into MOODLE_28_STABLE 2015-01-05 14:32:28 +08:00
Andrew Nicols dcfe7694d4 Merge branch 'MDL-46183-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2015-01-05 13:58:12 +08:00
Andrew Nicols 34d16a7737 Merge branch 'wip-MDL-40097-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2015-01-05 13:41:28 +08:00
Andrew Nicols 863ffc884f Merge branch 'MDL-48700-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2015-01-05 13:31:42 +08:00
Aaron Barnes f8bebe363d MDL-40097 completion: Apply robust role detection to samesite restores. 2015-01-05 10:34:49 +08:00
Adrian Greeve 45151248c4 MDL-40097 completion: Update of code to meet guidlines. 2015-01-05 10:34:38 +08:00
Aaron Barnes 39ed46b158 MDL-40097 completion: Make restoring grade criteria more robust 2015-01-05 10:34:27 +08:00
Russell Smith 6e8d598cff MDL-43421 logging: Ignore race condition in access update. 2015-01-03 20:42:09 +11:00
PJ King 39afb9e4b3 MDL-46671 availability: DEBUG when course_module does not exist.
There was a fatal error when calendar event linked to non-extant activities.

Now, instead of throwing an exception when a course_module does not exist, is_user_visible() will print a debug statement.
2015-01-02 10:32:30 -05:00
Ankit Agarwal de290738c9 MDL-48442 tasks: Make sure first run is as per schedule 2015-01-02 14:55:22 +05:30
Ankit Agarwal 004ec71505 MDL-44393 tasks: Add unit tests for cron field validations 2015-01-02 11:03:03 +05:30
Ankit Agarwal 045b5235f2 MDL-44393 tasks: Validate cron fields 2015-01-02 11:03:03 +05:30
Ankit Agarwal 2d066f19ba MDL-48372 mod_data: Add http to urls without it during import 2015-01-02 10:47:34 +05:30
Frederic Massart b4e7dcaa8a MDL-43679 core: Handle Meridio user agents with MS Word 2015-01-02 11:24:00 +08:00
Frederic Massart e618263437 MDL-43679 core: Never use HTTP redirect when the user agent is MS Word 2015-01-02 11:24:00 +08:00
Paul Nicholls 04a2fc7427 MDL-43679 core_useragent: add test cases for MS Word
The new is_msword() check should always return false for regular browsers.
It should return true for known MS Word, but false for known MS Outlook.
2015-01-02 11:24:00 +08:00
Paul Nicholls 7ed6f826ad MDL-43679 core_useragent: add basic MS Word detection
Basic detection for MS Word's internal link checker.  This is not perfect,
as older versions use IE6/7 user agent string with no identifying marks,
and newer versions don't necessarily identify themselves as Word (just as
Office).  Version information is not reliably available, even when there
is sufficient other information to identify it as Word's link checker.
This is also based on a small sample of Word / OS version pairings, so
there may be some which are identifiable but not currently covered.
2015-01-02 11:23:59 +08:00
Jean-Michel Vedrine 986cc05789 MDL-40326 mod_lesson: progress bar is not reset by course reset 2015-01-01 13:22:28 +01:00
Lloyd Powell 7f15ca3eab MDL-43898 lesson: Fix for positioning of blocks on continue.php 2014-12-31 09:09:44 +00:00
Ankit Agarwal 07a06264dc MDL-37584 tasks: Use a senisible maximum time window for the task 2014-12-31 14:03:09 +05:30
Dan Poltawski 15252c8803 MDL-41166 assign: don't display portfolio button when no permissions
Thanks to Katja Krüger for the basis of the patch.
2014-12-30 16:48:44 +00:00
Dan Poltawski 73416d1b9a MDL-45930 filemanager: Don't display filesize when unknown
Thanks to Marina Glancy for the patch

Conflicts:
	theme/bootstrapbase/style/moodle.css
2014-12-30 14:24:29 +00:00
Vishal Raheja f70a6d3245 MDL-32088 user: Correct the Moodle docs link
This patch links the moodle docs link to user profile Moodle doc when
the user sees the user profile for a particular course. The page is set
to course view type to load course specific blocks. So, we use
set_docs_path to change the Moodle docs link instead of changing the
pagetype.
2014-12-30 13:47:41 +00:00
Mark Nielsen 2d18472382 MDL-48644 backup tool_log: Fixing coding style
Wrap long function definition
to next line.
2014-12-29 11:26:37 -08:00
Dan Poltawski 04babc675b MDL-43198 folder: respect ignorefilesizelimits permission
Thanks to Miryan Salas for the patch.
2014-12-29 12:13:37 +00:00
Jean-Michel Vedrine eeae1784c6 MDL-48631 mod_lesson: tables 'grade' item have incorrect precision
Conflicts:
	mod/lesson/db/upgrade.php
	mod/lesson/version.php
2014-12-29 10:54:01 +01:00
Ankit Agarwal 112e95f6b4 MDL-48704 inbound: Fix notices in pickup task 2014-12-29 14:40:41 +05:30
Eugene Venter 3e061bf55d MDL-46015 lesson: Optimise report - use recordsets
Change-Id: I61f3ed30c6dbd8f88d1dfb1adfe2fc291853e0e1
2014-12-28 11:09:38 +01:00
AMOS bot deb3e69e37 Automatically generated installer lang files 2014-12-28 00:04:15 +08:00
Mark Nelson 0532dad71b MDL-48549 mod_assign: added upgrade to clean the tables 2014-12-26 18:55:53 -08:00
Mark Nelson a0102708b6 MDL-48549 mod_assign: delete entries from the flags/mapping tables 2014-12-26 18:54:51 -08:00
Mark Nelson a12afaf7dd MDL-46498 mod_assign: added behat tests 2014-12-26 17:49:58 -08:00
Mark Nelson 57897685c0 MDL-46498 mod_assign: display correct grading status 2014-12-26 17:17:25 -08:00
Jean-Michel Vedrine 216655b54d MDL-48707 mod_lesson: ignore plugins question types during import 2014-12-26 08:29:33 +01:00
Jean-Michel Vedrine 899d7c1bb2 MDL-38222 mod_lesson: Error in Lesson Cluster for Unseen Questions 2014-12-25 21:19:33 +01:00
Dan Poltawski 440085ecf8 weekly release 2.8.1+ 2014-12-24 13:22:29 +00:00
Dan Poltawski a5e8cb4aea Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2014-12-24 13:22:26 +00:00
Mark Nelson d8d912443f MDL-48534 mod_assign: display correct workflow state and marker 2014-12-23 22:58:32 -08:00
Ankit Agarwal e3effa63fd MDL-48701 inbound: Use correct method in invalid email handler
Invalid email handler doesn't allow alteration in validate sender config. Make sure this is reflected in the UI as well
2014-12-24 10:20:43 +05:30
Ankit Agarwal 870e0fb822 MDL-48697 libraries: Use proper path for core_completion 2014-12-24 08:10:36 +05:30
Eric Merrill 4e8c1f2681 MDL-48700 gradereport_history: Don't limit downloads by pages. 2014-12-23 16:11:23 -05:00
Dan Poltawski 12f025749a MDL-20304 lesson: add behat test for practice lessons 2014-12-23 17:05:36 +00:00
Dan Poltawski 29006301ed MDL-20304 lesson: do not display gradebook link when in practice mode
Practice mode means the grades do not go to the gradebook, so do not
display the gradebook link at the end of the lesson
2014-12-23 17:05:35 +00:00
Atanas Atanasov c1eb2c3ddf MDL-20304 lesson: do not send practice lesson grades to gradebook 2014-12-23 17:05:35 +00:00
Dan Poltawski 7783fcd76f Merge branch 'MDL-48213-m28-master' of https://github.com/dthies/moodle into MOODLE_28_STABLE 2014-12-23 16:13:14 +00:00
AMOS bot 4dbc9b18b4 Automatically generated installer lang files 2014-12-24 00:04:15 +08:00
Eloy Lafuente (stronk7) e9b36ac653 MDL-45699 behat: Don't use behat/lib.php functions in core.
behat/lib.php script should not be usually included, neither any of its functions
used within mooodle code at all. It's for exclusive use of behat and
moodle setup.php. For places requiring a different/special behavior
needing to check if are being run  as part of behat tests, use:
    if (defined('BEHAT_SITE_RUNNING')) { ...
2014-12-23 13:28:46 +01:00
Dan Poltawski db5fb4ce76 Revert "Merge branch 'MDL-48534_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE"
This reverts commit 7c4b6a84dd, reversing
changes made to 03d3dfbfc5.
2014-12-23 10:46:30 +00:00
Dan Poltawski 008e28478d Revert "Merge branch 'MDL-48591_m28' of https://github.com/jrchamp/moodle into MOODLE_28_STABLE"
This reverts commit a6af290ea4, reversing
changes made to 267ac74ef3.
2014-12-23 10:43:37 +00:00
Frederic Massart 510fafed8a MDL-46183 theme_more: Background is seen through the activity chooser 2014-12-23 17:16:58 +08:00
Eloy Lafuente (stronk7) 7e911af220 Merge branch '45699-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE
Conflicts:
	cache/upgrade.txt
2014-12-23 02:04:12 +01:00
Eloy Lafuente (stronk7) d25a7f21a3 MDL-48568 cache: make tests aware of default application store
When an alternative cache configuration is used, aka:

define('TEST_CACHE_USING_ALT_CACHE_CONFIG_PATH', true);
$CFG->altcacheconfigpath = '/tmp/xxxxx.php';

the get_expected_application_cache_store() method was not able of
retroffiting the default application store being used.

This commit just implements that functionality so, when
executing unit tests using alternative configuration, assertions
looking for that will pass without a problem.
2014-12-23 02:03:06 +01:00
Eloy Lafuente (stronk7) 3c6dac879f Merge branch '48568-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2014-12-23 02:02:47 +01:00
Eloy Lafuente (stronk7) d81cdaaf13 Merge branch 'MDL-48593-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-12-22 21:51:20 +01:00
Tim Hunt 4a057abc11 MDL-42519 qformat_xml: Correctly export questions containing ]]> 2014-12-22 19:47:10 +00:00
Eloy Lafuente (stronk7) d102926592 Merge branch 'MDL-48639_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-12-22 19:09:52 +01:00
Dan Poltawski 05ea4e002d Merge branch 'MDL28-48421' of https://github.com/timpricecatalyst/moodle into MOODLE_28_STABLE 2014-12-22 17:01:06 +00:00
Dan Poltawski c6c1b3596f MDL-48638 course: update unit test to new message 2014-12-22 16:25:47 +00:00
Dan Poltawski bf671547ab Merge branch 'MDL-48638-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2014-12-22 15:25:35 +00:00
Dan Poltawski 1b78a209a0 Merge branch 'MDL-48643-28' of git://github.com/merrill-oakland/moodle into MOODLE_28_STABLE 2014-12-22 15:22:33 +00:00
Dan Poltawski 42486cac98 MDL-43004 blog: fix upgrade.txt typo 2014-12-22 15:14:05 +00:00
Dan Poltawski 9b27f063c8 Merge branch 'MDL-48062-m28-master' of https://github.com/dthies/moodle into MOODLE_28_STABLE 2014-12-22 14:36:42 +00:00
Brian Barnes 83a36ad89b MDL-48423 messages: improved accessibility of contacts list 2014-12-22 14:16:31 +00:00
Dan Poltawski 61040870bb Merge branch 'MDL-48224-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2014-12-22 14:04:23 +00:00
Josh Marshall 999f4ac9fa MDL-48445 report_loguser: Include logstore parameter for pagination 2014-12-22 13:56:59 +00:00
Dan Poltawski 7c4b6a84dd Merge branch 'MDL-48534_m28' of https://github.com/markn86/moodle into MOODLE_28_STABLE 2014-12-22 13:52:41 +00:00
Dan Poltawski 03d3dfbfc5 Merge branch 'm28_MDL-48483' of https://github.com/totara/moodle into MOODLE_28_STABLE 2014-12-22 13:44:29 +00:00
Dan Poltawski cf447b8c0f Merge branch 'MDL-48580-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2014-12-22 13:41:13 +00:00
Dan Poltawski a6af290ea4 Merge branch 'MDL-48591_m28' of https://github.com/jrchamp/moodle into MOODLE_28_STABLE 2014-12-22 13:38:06 +00:00
Dan Poltawski 267ac74ef3 MDL-48653 behat: fix incorrect phpdoc 2014-12-22 13:13:51 +00:00
Dan Poltawski a4b06536fb Merge branch 'MDL-48653_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-12-22 13:10:46 +00:00
Dan Poltawski 6303e895e4 Merge branch 'MDL-48088-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2014-12-22 13:07:46 +00:00
Dan Poltawski db6bbcbc16 Merge branch 'MDL-48666_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-12-22 12:09:18 +00:00
Andrew Davis 55f1261257 MDL-48441 core_user: profile.php, view.php now handle guests the same 2014-12-22 09:56:04 +01:00
Ankit Agarwal 6227a1f3e7 MDL-48688 inbound: Fix incorrect class names 2014-12-22 13:50:43 +05:30
Adrian Greeve 0f60d011dc MDL-48523 gradebook: Fix for incorrect behat steps. 2014-12-22 15:05:18 +08:00
Eric Merrill 21fa68e52f MDL-48643 Javascript: Create modals hidden, then show, to prevent scroll
Modal dialogs need to be created with visible: false and then call
.show() on it to make it visible. This prevents the page from jumping to
the top.
2014-12-21 22:58:59 -05:00
AMOS bot 085df3ed05 Automatically generated installer lang files 2014-12-22 00:04:10 +08:00
AMOS bot 4645ff7ddc Automatically generated installer lang files 2014-12-20 00:04:14 +08:00
Tim Hunt 2a6e070cd4 MDL-48666 quiz: let JS to get a Qs slot number on the summary page 2014-12-19 14:39:40 +00:00
Tim Hunt 3e8e8641b3 MDL-48639 behat upload: support absolute paths & better errors
In a custom step I needed to be able to upload a file I had previously
saved to $CFG->dataroot/temp, but that was not possible.

Also, the failure was not at all obvious. I have made it throw a clear
exception if the file you are trying to upload does not exist.
2014-12-19 12:00:17 +00:00
Brian Barnes 6f1e7d2db2 MDL-48483 admin: attached color label to input control 2014-12-19 14:19:39 +13:00
Daniel Thies 330ac09e0d MDL-48062 atto_image: Add image select on single click 2014-12-18 18:29:46 -06:00
Daniel Thies 37e2d30c84 MDL-48213 filter_algebra,filter_tex: Require sesskey for debug actions 2014-12-18 16:40:46 -06:00
Tim Price 4105c6c329 MDL-48421 navigation: accounting for potential regression 2014-12-19 09:18:35 +11:00
Tim Price 07bd586492 MDL-48421 navigation: correctly load child categories if parent is loaded 2014-12-19 09:18:35 +11:00
Eric Merrill ada9b1ed77 MDL-48655 gradebook: Don't treat a scale with a gradepass of 0 as passed 2014-12-18 16:18:28 -05:00
Mark Nielsen 60c034fe27 MDL-48644 backup: Preserve log IP and time during restore 2014-12-18 11:36:47 -08:00
Tim Hunt 8850deb74d MDL-48653 behat: Steps to click and dismiss a dialogue.
We already had the corresponding
    I click on "Home" "link" confirming the dialogue
but I needed the opposite
    I click on "Home" "link" dismissing the dialogue
2014-12-18 19:31:27 +00:00
Eric Merrill 4077b738a0 MDL-48582 gradereport_grader: Adding back grade pass/fail CSS 2014-12-18 14:13:21 -05:00
Eric Merrill 0ab4c9d029 MDL-48638 database SQL: Fix typo in exception constructor 2014-12-18 13:34:20 -05:00
jrchamp 3925c74634 MDL-48591 calendar: Mini Cal Display DST Events 2014-12-18 09:28:09 -05:00
Dan Poltawski 2c48f2ed4c weekly release 2.8.1+ 2014-12-18 11:25:09 +00:00
Dan Poltawski 88d1474104 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2014-12-18 11:25:07 +00:00
Mark Nelson b621820ea1 MDL-45324 mod_assign: always notify students when requested 2014-12-18 14:09:23 +08:00
Mark Nelson a2a8653aa2 MDL-48534 mod_assign: display correct workflow state and marker 2014-12-17 20:43:27 -08:00
David Monllao bfa4e840d8 Merge branch 'MDL-48235-28-fixes' of git://github.com/xow/moodle into MOODLE_28_STABLE 2014-12-18 12:37:01 +08:00
Zachary Durber dda30b1906 MDL-47442 mod_assign: Notify student when quick-grading grade 2014-12-18 12:15:41 +08:00
Marina Glancy c0070d8d88 MDL-48452 Completion: js correction to behat test 2014-12-18 11:28:31 +08:00
John Okely 582ab13d73 MDL-48235 mod_assign: Fix grade of 0 not showing on feedback page in oracle 2014-12-18 10:25:39 +08:00
Wiktor Wandachowicz f826599632 MDL-35078 enrol: allow times to be chose on bulk enrolment forms
Previously only a date was available, which made it ambigious whether
the the enrolment was inclusive of the date. Now we use a time to make
it less ambigious.

This matches changes done in other forms in MDL-41173.
2014-12-17 12:02:30 +00:00
Dan Poltawski cf7167cbae Merge branch 'MDL-44829_MOODLE_28_STABLE' of git://github.com/BenKelada/moodle into MOODLE_28_STABLE 2014-12-17 10:11:41 +00:00
BKelada 999f2b3aea MDL-44829 libraries: Update android user agent detection 2014-12-17 16:37:03 +11:00
David Monllao 5ef46dad4b Merge branch 'MDL-48243_M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE 2014-12-17 11:49:15 +08:00
Andrew Nicols 724b6446d1 MDL-48593 messageinbound: Correct header retrieval from IMAP server
Header retrieval should only be performed on the base message, and not each
part of the message as is currently performed.

This came to light because Google changed their IMAP server such that, if
you inform the data query that you wish to retrieve the headerText for a
part which does not contain a MIME header, then no message is retrieved in
the search causing a general failure of the IMAP fetch.

In normal circumstances, headers should only be a part of the base message
part.
2014-12-17 09:35:38 +08:00
Dan Poltawski 535a794f90 Merge branch 'MDL-43462_landscape_pdf_28' of git://github.com/davosmith/moodle into MOODLE_28_STABLE 2014-12-16 19:20:23 +00:00
Dan Poltawski fa59a794f6 Merge branch 'MDL-42501-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2014-12-16 19:18:03 +00:00
Eloy Lafuente (stronk7) f48a890017 Merge branch 'MDL-48452-m28' of https://github.com/sammarshallou/moodle into MOODLE_28_STABLE 2014-12-16 19:09:18 +01:00
sam marshall 78d8dc13c8 MDL-48452 Completion: Expected date doesn't save when form is locked
The completion fields are locked when a user has already completed the
task, to prevent you accidentally causing it to recalculate the data.

This lock doesn't apply to the expected date field, as this doesn't
affect user completion. However, changes to the field in this
situation were incorrectly not saved.
2014-12-16 17:31:36 +00:00
Dan Poltawski e42056413c Merge branch 'MDL-48587-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2014-12-16 17:05:04 +00:00
Eloy Lafuente (stronk7) e61ab464f3 Merge branch 'm28_MDL-48532' of https://github.com/totara/moodle into MOODLE_28_STABLE 2014-12-16 15:47:29 +01:00
Dan Poltawski f0066ff80c Merge branch 'MDL-46442-28' of git://github.com/zbdd/moodle into MOODLE_28_STABLE 2014-12-16 13:54:12 +00:00
Dan Poltawski 5ef5c6c1e2 Merge branch 'MDL-47610-28' of git://github.com/zbdd/moodle into MOODLE_28_STABLE 2014-12-16 13:00:02 +00:00
Davo Smith a4c72b69e8 MDL-43462 assignfeedback_editpdf: fix display of landscape PDFs
The size of the drawing canvas is now set from the size of the generated page image, with automatic
scrolling if it is too wide to display
Absolutely-positioned nodes (comments + stamps) are repositioned as the drawing canvas is scrolled
2014-12-16 12:01:42 +00:00
Dan Poltawski a95cd718f9 Merge branch 'MDL-46651-MOODLE_28_STABLE-restore-course-completion-duplicate-key' of https://github.com/Trii/moodle into MOODLE_28_STABLE 2014-12-16 11:58:47 +00:00
Zachary Durber df91b1d861 MDL-47694 mod_assign: Grades require a grade to show as graded
Special thanks to Howard Miller.
2014-12-16 11:20:09 +01:00
Frederic Massart f34fc42d9b MDL-48495 curl: Limit usage of curl to HTTP and HTTPS protocols 2014-12-16 10:08:47 +00:00
David Monllao 43c3b0ec7b Merge branch 'MDL-48318-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2014-12-16 16:41:21 +08:00
Zachary Durber 2a841b12fd MDL-46442 mod_assign: Notify users when grades are changed 2014-12-16 14:49:53 +08:00
David Monllao 73c991dd3f Merge branch 'MDL-48547-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2014-12-16 14:13:54 +08:00
David Monllao ecc60ffeb7 Merge branch 'm28_MDL-48567' of git://github.com/totara/moodle into MOODLE_28_STABLE 2014-12-16 13:34:41 +08:00
Brian Barnes 83ef244a83 MDL-48286 core_files: Improved accessibility of file management 2014-12-16 13:26:30 +08:00
Simey Lameze f6c149226f MDL-48580 report_log: fix site errors dropdown
Thanks Renaat Debleu for pointing this bug and share a solution.
2014-12-16 12:39:17 +08:00
David Monllao c0c2921586 Merge branch 'wip-MDL-48569-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2014-12-16 12:27:02 +08:00
David Monllao 2abcbc0251 Merge branch 'MDL-48164-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-12-16 12:03:35 +08:00
Andrew Nicols 270705c279 Merge branch 'MDL-46472_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2014-12-16 10:39:56 +08:00
Andrew Nicols 26156e72d9 MDL-48164 messageinbound: Attempt to detect autoreplies
Any message which includes:
* Precedence: bulk
* X-Autoreply: !no
* X-Autoresponse: !no
* Auto-Submitted: !no

Will not be detected as a bulk message and therefore ignored.
2014-12-16 09:35:58 +08:00
Andrew Nicols 7a56557c45 MDL-48164 mod_forum: Add additional headers to prevent OOF replies
This adds the X-Auto-Response-Suppress header to outbound messages.
2014-12-16 09:35:58 +08:00
Zachary Durber 4c23fb82ab MDL-47610 gradebook: Show extra credit icon in grades column 2014-12-16 09:17:00 +08:00
Eloy Lafuente (stronk7) 30fbe29595 Merge branch 'MDL-47037-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2014-12-16 01:42:39 +01:00
Eloy Lafuente (stronk7) 5e425cc89b Merge branch 'MDL-46491-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-12-16 00:36:18 +01:00
Eloy Lafuente (stronk7) b2a786539e Merge branch 'MDL-48556-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2014-12-15 17:54:04 +01:00
Dan Poltawski 744dc6e647 Merge branch 'MDL-38128_28' of https://github.com/dmonllao/moodle into MOODLE_28_STABLE 2014-12-15 16:10:17 +00:00
Dan Poltawski 0e956b0452 Merge branch 'MDL-45324_28' of git://github.com/jonof/moodle into MOODLE_28_STABLE 2014-12-15 14:59:37 +00:00
Dan Poltawski 82dd025984 Merge branch 'MDL-47176_MOODLE_28_STABLE' of https://github.com/crazyserver/moodle into MOODLE_28_STABLE 2014-12-15 14:14:24 +00:00
Dan Poltawski b2e9074f3c Merge branch 'MDL-48169-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2014-12-15 12:32:13 +00:00
Dan Poltawski 73ed5ce9fb Merge branch 'MDL-47475-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-12-15 12:21:11 +00:00
Joseph Rezeau cd16f43ba1 MDL-36673 mod_lesson: slideshow mode not working 2014-12-15 11:55:34 +00:00
David Monllao 49b881c876 Merge branch 'MDL-48235-assign-reopen-until-pass-28_STABLE' of git://github.com/mpetrowi/moodle into MOODLE_28_STABLE 2014-12-15 17:33:09 +08:00
John Okely ef19d61d4d MDL-48587 core: Fix error in getremoteaddr for unsupported php versions 2014-12-15 16:56:44 +08:00
Simey Lameze a54229b629 MDL-42501 course: add help icon on delete gradebook options 2014-12-15 16:23:11 +08:00
David Monllao 373fd13876 Merge branch 'wip-MDL-48347-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2014-12-15 13:45:22 +08:00
Jetha Chan 244c69709e MDL-48088 calendar: normalize DTEND, add romance standard time
Thanks to Cedric Mortiers (cmortiers@stjohns.be) for providing the patch.
2014-12-15 12:10:29 +08:00
Andrew Nicols 675564277d MDL-47475 mod_assign: Copy files to other group members for editpdf 2014-12-15 08:50:48 +08:00
AMOS bot 3e7b053221 Automatically generated installer lang files 2014-12-13 00:03:57 +08:00
Pau Ferrer Ocaña abcec0fe9a MDL-47176 qtype_match: Avoid sql_compare to solve problems with Oracle 2014-12-12 16:04:24 +01:00
David Monllao fa0a765c20 MDL-38128 mod_assign: Counts and groups unit tests 2014-12-12 15:07:57 +08:00
David Monllao 5ad9e84664 MDL-46472 theme: Removing standard as an uninstallable theme 2014-12-12 13:33:46 +08:00
David Monllao 79a143130b MDL-38128 mod_assign: Fixing count teams and submissions with status
We should restrict the groups to the activity active group. Also
improving performance caching get_submission_group() results.
2014-12-12 13:28:14 +08:00
David Monllao 08b7d0bacc MDL-38128 mod_assign: Adding group selector to grading summary page
Thanks to Pau Ferrer Ocaña and Avi Levy for
their work on this issue.
2014-12-12 13:28:14 +08:00
Andrew Nicols b1a381ffcf MDL-48224 cron: Buffer SMTP connections around tasks 2014-12-12 10:39:19 +08:00
Marina Glancy 3719994057 MDL-48569 profile: behat test for user full profile access 2014-12-12 10:29:22 +08:00
Marina Glancy be2641dc8c MDL-48569 profile: show link to full profile if anybody can see it 2014-12-12 10:29:22 +08:00
Daniel Thies 3c726433cc MDL-48213 filter_algebra: Allow cookies in debug script 2014-12-11 20:00:45 -06:00
Sam Hemelryk 78a4b45ffc MDL-28067 navigation: my private files in profile only 2014-12-12 13:48:10 +13:00
Sam Hemelryk 3900f28e28 MDL-37680 repositories: added blocks to manage page 2014-12-12 13:37:01 +13:00
Joshua Johnston 48d0e75068 MDL-46651 Backup: Handle duplicate course completions during restore
Cron can cause duplicate completion records if triggered during a long
running restore process. If this is the case, replace the new record
with the record from the backup file
2014-12-11 15:58:00 -05:00
Sam Hemelryk c7a0fb64a0 MDL-48568 cache: stores now determine testing
Cache stores are now responsible for deciding if they are suitable
for use as the primary cache store during unit and acceptance tests

Changes are as follows:
* New method: cache_store::ready_to_be_used_for_testing
* Core cache store have been updated to override this method as
  required.
* MongoDB usesafe default changed to true to match actual default
  behaviour.
2014-12-12 09:34:25 +13:00
Dan Poltawski 8542d1875f weekly release 2.8.1+ 2014-12-11 09:55:19 +00:00
Dan Poltawski 087fd13442 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2014-12-11 09:55:17 +00:00
Ankit Agarwal dd96737556 MDL-48556 backup: Use correct conditions before checking dir permissions 2014-12-11 14:34:10 +05:30
Andrew Nicols fde7c5f003 MDL-46491 course: Correct activity visibility on section show 2014-12-11 14:50:50 +08:00
Brian Barnes 4afb72f2de MDL-48567 core_badges: fixed display of badge created date 2014-12-11 14:50:33 +13:00
Avi Levy 23f751ee38 MDL-47037 grader_gradereport: Enable sort in other language then English 2014-12-11 07:39:42 +08:00
Frederic Massart 79fc19f5d7 MDL-48496 block_rss_client: Do not display curl error messages 2014-12-11 00:26:30 +01:00
AMOS bot f89ee726b4 Automatically generated installer lang files 2014-12-11 00:04:05 +08:00
Jonathon Fowler 9592c8e99c MDL-45324 assign: notify when workflow is Off, or if state is Released
When marking workflow is enabled, students will be notified only when
the workflow state transitions to 'Released'. Until that happens,
sending of messages will be held and the 'Notify students' grading
form option will be locked.

Additionally, the batch set marking workflow state facility gains
the 'Notify students' option.

Credit to Steve Upton and David Balch for the basis of this patch.
2014-12-10 22:28:20 +10:00
Sam Hemelryk 18453fec76 MDL-48430 customment: improved exception handling 2014-12-10 13:26:11 +01:00
pau.ferrer-ocana 4656c6ab53 MDL-48430 custom_menu: Malformed url in custom menu cannot break the platform 2014-12-10 13:26:11 +01:00
Dan Poltawski 36700a125e MDL-48547 thirdparty: remove incorrect entry 2014-12-09 23:12:36 +00:00
Dan Poltawski 80154bd033 Merge branch 'MDL-47323-enrol-plugin-backup-28_STABLE' of https://github.com/mpetrowi/moodle into MOODLE_28_STABLE 2014-12-09 22:30:01 +00:00
Dan Poltawski fd37fba94b Merge branch 'MDL-45430-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2014-12-09 21:22:18 +00:00
Sam Hemelryk f3586f59c4 Merge branch 'm28_MDL-48389' of https://github.com/totara/moodle into MOODLE_28_STABLE 2014-12-10 09:27:28 +13:00
Matt Petro 384f71b42c MDL-48235 mod_assign: Fix reopen until pass behavior 2014-12-09 10:45:23 -05:00
Eloy Lafuente (stronk7) 55f47d94f7 Merge branch 'MDL-31822_28' of https://github.com/dmonllao/moodle into MOODLE_28_STABLE 2014-12-09 16:12:24 +01:00
Dan Poltawski 673d38078c MDL-45679 mod_lesson: do not overqualify styles 2014-12-09 12:35:18 +00:00
Dan Poltawski e732d0d9ca Merge branch 'MDL-45679_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2014-12-09 12:34:20 +00:00
Dan Poltawski 28e38410c5 Merge branch 'MDL-48394-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2014-12-09 10:53:38 +00:00
Dan Poltawski b16b0a61a4 Merge branch 'MDL-41846-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2014-12-09 10:35:10 +00:00
Sam Hemelryk 19f5623bf6 Merge branch 'wip_MDL-36499_M28' of git://github.com/gjb2048/moodle into MOODLE_28_STABLE 2014-12-09 16:57:11 +13:00
David Monllao 6967547062 MDL-31822 course: Formatting the section name 2014-12-09 11:52:30 +08:00
David Balch 519413892e MDL-31822 course: Show custom Section name on Front page. 2014-12-09 11:52:28 +08:00
Sam Hemelryk ceee447066 Merge branch 'wip-MDL-46486-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2014-12-09 16:20:50 +13:00
Dan Poltawski 934c72979b MDL-40552 course: fixup unit test
Previously there was an assertion which was never used, now
we ensure to test the course themes functionality each time.
2014-12-09 16:14:23 +13:00
Sam Hemelryk bf42737370 Merge branch 'MDL-34437-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2014-12-09 15:58:56 +13:00
Sam Hemelryk 6966842459 Merge branch 'm28_MDL-46172' of https://github.com/greg-or/moodle-mod_assign into MOODLE_28_STABLE 2014-12-09 15:38:51 +13:00
Brian Barnes 9e06074bbe MDL-48389 forms: added page title to help text 2014-12-09 15:18:54 +13:00
Sam Hemelryk 41ea5affc4 Merge branch 'mdl48517_28' of https://github.com/tlevi/moodle into MOODLE_28_STABLE 2014-12-09 15:16:00 +13:00
Brian Barnes 8e0c012bbb MDL-48532 core_roles: Set correct heading on user roles page 2014-12-09 14:24:42 +13:00
Sam Hemelryk f071a177b0 Merge branch 'wip-MDL-48366-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2014-12-09 13:43:38 +13:00
Sam Hemelryk e0b7f5492a Merge branch 'wip-mdl-48426-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2014-12-09 12:13:36 +13:00
Sam Hemelryk 664d834cd1 MDL-45699 cache: renamed cache_config_phpunittest
Renamed cache_config_phpunittest to cache_config_testing
2014-12-09 10:51:20 +13:00
Sam Hemelryk faa3b4022f MDL-45699 cache: acceptance test improvements
We now use the unit test cache config class when running
acceptance tests so that the same defines are applicable there.
2014-12-09 10:51:17 +13:00
Eloy Lafuente (stronk7) 2d16c385d7 Merge branch 'MDL-48255-28' of git://github.com/lameze/moodle into MOODLE_28_STABLE 2014-12-08 19:15:12 +01:00
Eloy Lafuente (stronk7) b2959dbe9b Merge branch 'wip-MDL-48390-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2014-12-08 18:49:09 +01:00
Dan Poltawski 5eb62533cd Merge branch 'MDL-48410_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-12-08 15:19:11 +00:00
Dan Poltawski 7e5947b986 Merge branch 'MDL-48373_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-12-08 15:15:41 +00:00
Dongsheng Cai 592f05a064 MDL-35983 Try to use real file name from EQUELLA 2014-12-08 14:24:09 +00:00
Dan Poltawski 4f2e496184 Merge branch 'MDL-47246_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2014-12-08 13:34:03 +00:00
Dan Poltawski 793e74fef3 Merge branch 'MDL-14908-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2014-12-08 13:22:17 +00:00
Dan Poltawski bc11b6c138 MDL-48273 upgrade.txt version fix 2014-12-08 11:23:11 +00:00
Simey Lameze 788727862d MDL-48273 singleview: unit tests of load_user method 2014-12-08 11:22:38 +00:00
Simey Lameze adbbc7bd9e MDL-48273 singleview: add load_user method and other group validations
All credits goes to Damyon, thanks!
2014-12-08 11:22:38 +00:00
David Monllao 18450eab27 MDL-47246 mod_forum: Limit last post restriction to Q and A 2014-12-08 14:50:42 +08:00
Adrian Greeve aef3679316 MDL-48347 gradebook: More behat tests for single view. 2014-12-08 14:25:39 +08:00
Adrian Greeve fe32471819 MDL-48347 gradebook: Single view shows all grade items.
Manual grade items, course totals, and categroy totals
were not being displayed in the single view.
2014-12-08 14:24:39 +08:00
Jetha Chan c8316e2894 MDL-48169 themes: extra upgrade notes 2014-12-08 14:08:05 +08:00
Tony Levi 13dfdb0b5f MDL-48517: behat: Fix reset ordering reversal (MDL-48302) 2014-12-08 13:08:31 +10:30
Sam Hemelryk 36814aaec6 Merge branch 'MDL-37704-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2014-12-08 14:51:01 +13:00
Sam Hemelryk fef242fa65 Merge branch 'MDL-48058-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-12-08 13:58:24 +13:00
Gareth J Barnard 422d1c4625 MDL-36499 javascript: Expand height of the file element in embedded view. 2014-12-06 12:11:56 +00:00
Sam Hemelryk 0bd78bb334 MDL-45699 behat: can now use alt cache config 2014-12-06 12:09:49 +13:00
Gregory Faller 14cd37913c MDL-46172 mod/assign: Stop suspended users getting assign group emails 2014-12-06 08:29:08 +10:30
AMOS bot 3cca19d176 Automatically generated installer lang files 2014-12-06 00:03:54 +08:00
Jean-Michel Vedrine 468efb3171 MDL-45679 mod_lesson: Essay grading page has no mark for essay status 2014-12-05 15:04:58 +01:00
Tim Hunt b56a1518ad MDL-48410 behat, quiz: step for efficiently adding questions 2014-12-05 12:18:06 +00:00
Tim Hunt fed2e156e2 MDL-48373 behat, questions: convert tests to use the new steps
The new steps make it more efficient to create questions.

While making the changes, I took the opportunity to alter the tests to
follow Behat best practices, and only test one thing per scenario.
2014-12-05 12:18:05 +00:00
Tim Hunt 51a0c7cda7 MDL-48373 behat: generators for questions and categories 2014-12-05 12:18:05 +00:00
Tim Hunt 6292878644 MDL-48373 behat: find table columns better.
It was not possible to select the question bank 'Created by'
or 'Modified by' columns without this change.
2014-12-05 12:18:04 +00:00
Tim Hunt 201e19d7b6 MDL-48373 behat: new container selector for list items. 2014-12-05 12:18:04 +00:00
Eloy Lafuente (stronk7) ae2a9c0e66 weekly release 2.8.1+ 2014-12-05 11:05:30 +01:00
Eloy Lafuente (stronk7) dc2dd0cf72 Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2014-12-05 11:05:24 +01:00
Mark Nielsen 9c08bf4a6a MDL-48058 core_message: Default message outputs: Maintain Forced status 2014-12-05 14:43:57 +08:00
Ankit Agarwal ba1f0fbd39 MDL-45430 mod_book: Automate MDLQA-2428
This test verifies that an admin can generate and view all the book log entries
2014-12-05 09:26:32 +05:30
Rajesh Taneja e784850b5a MDL-48318 behat: Fixed JS Exception
M is not created on all pages, like cron and
Steps which check for exported data. So we need
to ensure M is defined, before using it in
behat_hooks::wait_for_pending_js()
2014-12-05 11:47:49 +08:00
John Okely 6ae671b784 MDL-41846 repository_url: Escape > < ' " in input url
And throw an exception when a url is incorrectly formatted
2014-12-05 11:23:42 +08:00
John Okely dbe6a4d188 MDL-41846 repository_url: Convert spaces to %20 in input url 2014-12-05 11:23:42 +08:00
Andrew Nicols 9427be40aa MDL-48309 mod_forum: Do not escape ampersands in plain text email 2014-12-04 12:59:08 +01:00
Eloy Lafuente (stronk7) acfbe693b2 Merge branch '48425-48374-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2014-12-04 12:59:07 +01:00
Eloy Lafuente (stronk7) 760c41ca09 MDL-48374 behat: Added missing $session 2014-12-04 12:59:07 +01:00
Rajesh Taneja 8d7e6ecfc8 MDL-48374 behat: Check flag before searching for span on page 2014-12-04 12:59:07 +01:00
Andrew Nicols aa39908cef MDL-48374 behat: improved page load detection
Check that page load detection was correctly started before testing that a
new page was loaded.

Without this, it is possible to have mutliple subsequent cases of:
    And a new page should have loaded since I started watching

Without first starting the page load detection.
2014-12-04 12:59:06 +01:00
Sam Hemelryk fba1d33198 Merge branch 'M28_MDL46116_IMSCP_container_items' of https://github.com/Dave-B/moodle into MOODLE_28_STABLE 2014-12-04 12:59:05 +01:00
Dan Poltawski f304fd2e6c Merge branch 'wip-mdl-48290-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2014-12-04 12:59:05 +01:00
Dan Poltawski c538b47443 Merge branch 'MDL-34627_28' of https://github.com/dmonllao/moodle into MOODLE_28_STABLE 2014-12-04 12:59:04 +01:00
Eloy Lafuente (stronk7) ea2a48fb4a Merge branch '48374-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2014-12-04 12:59:04 +01:00
Sam Hemelryk f40124002b Merge branch 'MDL-40419-28-2nd' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2014-12-04 12:59:03 +01:00
Dan Poltawski 8f8ace5cdd Merge branch 'wip_MDL-48420_m28_lasttypo' of https://github.com/skodak/moodle into MOODLE_28_STABLE 2014-12-04 12:59:03 +01:00
Dan Poltawski efc6ed5e34 Merge branch 'MDL-48342_28' of git://github.com/jmvedrine/moodle into MOODLE_28_STABLE 2014-12-04 12:59:02 +01:00
Dan Poltawski 7a1b7e41d9 Merge branch 'MDL-40241_28' of https://github.com/dmonllao/moodle into MOODLE_28_STABLE 2014-12-04 12:59:02 +01:00
Marina Glancy f8b446f399 MDL-48366 blocks: always display custom regions in dropdown 2014-12-04 16:08:28 +08:00
AMOS bot 708cabea4d Automatically generated installer lang files 2014-12-04 00:04:36 +08:00
Matt Petro 9f4662b228 MDL-47323 backup: added enrol plugin backup structure and annotation 2014-12-02 22:03:43 -05:00
David Balch 186f4563cb MDL-46116 mod_imscp: Fix some jshint issues. 2014-12-02 11:17:40 +00:00
Simey Lameze 53e96ae4e1 MDL-48255 auth_ldap: make ldap cookie check more robust
Thanks to Baptiste Desprez for spotting this and provide a solution.
2014-12-02 15:32:33 +08:00
Ankit Agarwal 39ab2e44d0 MDL-37704 user_profile: Make sure description field can be locked
Thanks JD for the initial patch.
2014-12-02 09:43:55 +05:30
Rajesh Taneja 5367656ae8 MDL-48290 behat: Add log out after checking exported file
If the download step is the last in the scenario then we
can sometimes run into the situation where the download page
causes a http redirect but behat has already conducted its
reset (generating an error). By putting a logout step we avoid
behat doing the reset until we are off that page.
2014-12-02 09:39:27 +08:00
Sam Hemelryk 2fca03ec2a MDL-48425 course: management behat tests improved 2014-12-02 11:45:16 +13:00
Sam Hemelryk f2ebd53dba MDL-48374 behat: improved page load exceptions
The following improvements have been made to the page load watching:
* Improved the exceptions when a page load expectation fails.
* Added an exception if start watching happens twice without a page load.
* Improved the page load span and xpath to make it faster and less likely
  to interfer in the future.
2014-12-02 11:44:02 +13:00
Tim Hunt 886bc21b8b MDL-48374 behat: new steps for detecting page loads. 2014-12-02 08:58:11 +13:00
Mary Evans 5b1efbcab4 MDL-48243 theme_bootstrapbase: Fixed inconsistancy between LTR/RTL LESS 2014-12-01 17:32:46 +00:00
Didier Raboud 9dfc203245 MDL-34437 shibboleth: Correct the shibboleth wiki links. 2014-12-01 14:57:37 +05:30
Frederic Massart 278642a380 MDL-14908 user: Parents are not restricted when separated groups is used 2014-12-01 15:16:15 +08:00
David Monllao 1101fd22f2 MDL-40241 core_completion: Minor fixes to provided patch
Thanks to Aaron Barnes and Jon Sharp for working on this issue.
2014-12-01 15:01:14 +08:00
Marina Glancy db956269fe MDL-46486 coursecat: remove function forgotten in MDL-38147 2014-12-01 13:22:38 +08:00
Rajesh Taneja 1538a20679 MDL-48426 behat: soft-reset mink session before scenario 2014-12-01 12:40:18 +08:00
Rajesh Taneja 4eac169974 MDL-48426 behat: Wait for redirection after save
After saving wiki comment, page is redirected
Make sure to wait for redirection after save
to avoid random fails
2014-12-01 11:25:26 +08:00
Charles Fulton 5445d98144 MDL-34627 feedback: Convert default format value during restore 2014-12-01 10:58:38 +08:00
Aaron Barnes 258c0449b6 MDL-40241 blocks_completionstatus: Fix notices 2014-12-01 10:05:50 +08:00
Aaron Barnes 0a39d64927 MDL-40241 completion: Default roles unable to manually complete course
Thanks to Jon Sharp for authoring the original patch!
2014-12-01 10:05:48 +08:00
Sam Hemelryk c40f1f184f Merge branch 'wip-MDL-48377-m28' of git://github.com/marinaglancy/moodle into MOODLE_28_STABLE 2014-12-01 14:02:15 +13:00
Sam Hemelryk fc7ab00709 Merge branch 'MDL-48382_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-12-01 13:58:20 +13:00
Sam Hemelryk a76c20c20e Merge branch 'MDL-46618_m28' of git://github.com/kordan/moodle into MOODLE_28_STABLE 2014-12-01 11:59:36 +13:00
Sam Hemelryk 824c31e592 Merge branch 'MDL-14402-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-12-01 11:35:53 +13:00
Sam Hemelryk cba386b636 Merge branch 'MDL-48384-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2014-12-01 11:31:36 +13:00
Sam Hemelryk 438b185951 Merge branch 'MDL-48309-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-12-01 11:10:29 +13:00
Sam Hemelryk 3f1b091aa2 MDL-47133 editor_atto: fixed lint errors 2014-12-01 10:36:38 +13:00
Sam Hemelryk 0fec60deea Merge branch 'MDL-47133-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2014-12-01 10:19:31 +13:00
Petr Skoda 9e28b040df MDL-48420 test: fix lasttnamephonetic typo 2014-12-01 09:26:22 +13:00
Sam Hemelryk f7e646a5c1 Merge branch 'MDL-48227-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2014-12-01 09:14:50 +13:00
Ankit Agarwal d2b8475e3e MDL-42717 backups: set correct backup status and add logs
Set a correct backup status of ERROR when we fail to copy a file to an external directory given the backup configs demand it.
Also a lot of logs are added around this area to let admins easily find the problem if backup fails because of directory permissions.
2014-12-01 09:11:06 +13:00
Sam Hemelryk af9e696b79 Merge branch 'wip-mdl-48192-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2014-12-01 08:33:57 +13:00
AMOS bot aa29beabe8 Automatically generated installer lang files 2014-11-29 00:04:01 +08:00
Jean-Michel Vedrine 71a673cc3b MDL-48342 Question: qformat_default::readquestion is broken 2014-11-28 15:38:21 +01:00
Tim Hunt 105dbe93d5 MDL-48382 quiz behat: make add question step more robust. 2014-11-28 13:43:31 +00:00
Ankit Agarwal d141109dc2 MDL-48227 forum: Update the message shown in emails
AMOS BEGIN
 CPY [deleteoriginalonreply,mod_forum],[replytopostbyemail,mod_forum]
AMOS END
2014-11-28 15:31:25 +05:30
Dan Poltawski 97cf440401 weekly release 2.8.1+ 2014-11-28 08:04:49 +00:00
Dan Poltawski bb2f54224c Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2014-11-28 08:04:47 +00:00
Damyon Wiese 6c20557845 Revert "Merge branch 'MDL-38128_28' of https://github.com/dmonllao/moodle into MOODLE_28_STABLE"
This reverts commit 349c877872.

This reverts commit f67638b05f, reversing
changes made to c604a8079a.
2014-11-28 15:12:30 +08:00
David Monllao 349c877872 MDL-38128 mod_assign: Changes in grading summary page using team submissions
If there is an active group and (groupmode != NOGROUPS)
the displayed info is related with that single group.
2014-11-28 05:49:22 +08:00
Dan Poltawski 5ae74cad15 Revert "Merge branch 'MDL-43127-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE"
This reverts commit d758f054b9, reversing
changes made to f67638b05f.
2014-11-27 09:35:00 +00:00
Dan Poltawski e393866a36 Revert "Merge branch 'MDL-43127-28-fixup' of https://github.com/FMCorz/moodle into MOODLE_28_STABLE"
This reverts commit f603096c47, reversing
changes made to 5169661ee2.
2014-11-27 09:34:58 +00:00
Rajesh Taneja 99c0919993 MDL-48192 tool_monitor: check output buffer and not ignore it.
Check what is thrown in output buffer and
make sure output is expected output.
2014-11-27 17:03:54 +08:00
Frederic Massart c83dc49d3c MDL-40419 backup: Advanced comparison when restoring blocks in course 2014-11-27 16:20:11 +08:00
Frederic Massart 9a59701f0f MDL-40419 blocks: Function to get page type patterns from pattern 2014-11-27 16:20:11 +08:00
Jetha Chan 1cd8f3c645 MDL-48394 core_renderers: remove role=presentation on user picture links 2014-11-27 15:34:10 +08:00
David Monllao c3e67edfac MDL-22309 enrol_self: Fixing get_role_users usage 2014-11-27 11:34:01 +08:00
Marina Glancy 92b71540b3 MDL-48390 cohorts: do not limit number of cohorts in dropdowns 2014-11-27 11:15:09 +08:00
Eloy Lafuente (stronk7) bba645d102 Merge branch 'wip-mdl-48190-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2014-11-26 13:25:41 +01:00
Dan Poltawski 7cc923f443 MDL-48384 thirdpartylibs: correct location of yui 2014-11-26 12:13:04 +00:00
Frederic Massart da53c524f1 MDL-47133 editor_atto: Use strict validation of keyboard shortcuts 2014-11-26 17:40:50 +08:00
Dan Poltawski f603096c47 Merge branch 'MDL-43127-28-fixup' of https://github.com/FMCorz/moodle into MOODLE_28_STABLE 2014-11-26 09:23:08 +00:00
Frederic Massart 480c254ac1 MDL-43127 tool_uploadcourse: Empty enrolment method is acceptable
Without the patch a course would not be created if it contained
an enrolment method column with an empty value. e.g.:

shortname,fullname,category,enrolment_1,enrolment_1_disable
courserestored,Course restored,1,,
courserestored2,Course restored 2,manual,1
2014-11-26 17:14:50 +08:00
Andrew Nicols 5169661ee2 MDL-48148 mod_forum: Use correct original subject when handling replies 2014-11-26 08:56:24 +00:00
Dan Poltawski a76630d700 Merge branch 'MDL-48210-28-checker-caching' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2014-11-26 08:20:42 +00:00
David Mudrák 475f4a6272 MDL-48210 updates checker: Fix empty return type
Credit goes to Marina Glancy for catching during the testing.
2014-11-26 09:07:50 +01:00
Marina Glancy 9e74aef0a9 MDL-48377 forum: do not swallow spaces in notification emails 2014-11-26 12:17:40 +08:00
Sam Hemelryk 58aabfcedd Merge branch 'MDL-22309_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2014-11-26 09:06:11 +13:00
Sam Hemelryk eccf806ad0 Merge branch 'MDL-48191-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE
Conflicts:
	grade/report/grader/yui/build/moodle-gradereport_grader-gradereporttable/moodle-gradereport_grader-gradereporttable-min.js
2014-11-26 08:59:13 +13:00
Sam Hemelryk 1198f5ae01 Merge branch 'MDL-47329-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2014-11-26 08:43:36 +13:00
Eloy Lafuente (stronk7) cc9161bebc Merge branch 'MDL-48276-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2014-11-25 18:45:31 +01:00
Eloy Lafuente (stronk7) bea43ad49a Merge branch 'MDL-48277-28' of git://github.com/danpoltawski/moodle into MOODLE_28_STABLE 2014-11-25 18:42:12 +01:00
Heiko Schach 9c41fd2377 MDL-48036 course: change multilang cache key 2014-11-25 14:35:14 +00:00
Dan Poltawski b0b7c2d808 Merge branch 'MDL-41155-28' of git://github.com/gurgus/moodle into MOODLE_28_STABLE 2014-11-25 13:18:14 +00:00
Eloy Lafuente (stronk7) 3ca610e89a Merge branch 'MDL-48210-28-checker-caching' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2014-11-25 13:22:14 +01:00
Dan Poltawski 71d7788366 Merge branch 'MDL-46416-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2014-11-25 11:21:21 +00:00
Dan Poltawski d758f054b9 Merge branch 'MDL-43127-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2014-11-25 11:18:52 +00:00
Dan Poltawski f67638b05f Merge branch 'MDL-38128_28' of https://github.com/dmonllao/moodle into MOODLE_28_STABLE 2014-11-25 11:07:53 +00:00
Eloy Lafuente (stronk7) c604a8079a Merge branch '48189-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2014-11-25 11:23:34 +01:00
Dave Cooper 9b36c64056 MDL-41155 Lesson: Fixed multiple question attempts logic
Thanks to Rajneel Totaram for providing this patch.
2014-11-25 14:16:37 +08:00
Dave Cooper b110dd77a4 MDL-41155 Lesson: Added behat tests for multiple question attempts 2014-11-25 14:16:37 +08:00
Frederic Massart 086199c4e9 MDL-43127 tool_uploadcourse: Add support for more enrolment methods 2014-11-25 11:01:30 +08:00
Sam Hemelryk b42123f38c Merge branch 'MDL-22043-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-11-25 15:54:20 +13:00
David Monllao c440b9947e MDL-38128 mod_assign: Adding group selector to grading summary page
Thanks to Pau Ferrer Ocaña and Avi Levy for
their work on this issue.
2014-11-25 10:52:29 +08:00
Rajesh Taneja b64a526dba MDL-48190 behat: Fixed visit background in MoodleScenarioTester 2014-11-25 09:42:38 +08:00
Sam Hemelryk b9bfc5f15a MDL-23839 navigation: fixed php5.5ism 2014-11-25 14:35:47 +13:00
Andrew Nicols 94ae0d9f3b MDL-48309 mod_forum: Handle discussion subscriptions correctly 2014-11-25 09:29:39 +08:00
Andrew Nicols da9d46b5c0 MDL-48309 mod_forum: Add discussion subscription to the navigation 2014-11-25 09:29:38 +08:00
Sam Hemelryk b3351c0133 Merge branch 'MDL-23839-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-11-25 14:07:24 +13:00
Sam Hemelryk e8ffea7bd5 Merge branch 'MDL-23912-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2014-11-25 12:29:04 +13:00
Eloy Lafuente (stronk7) 25e135af74 Merge branch '38343-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2014-11-25 00:28:18 +01:00
Eloy Lafuente (stronk7) e4e04cdb84 Merge branch '48304-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2014-11-25 00:23:49 +01:00
Sam Hemelryk 222f015381 Merge branch 'MDL-48246-M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE
Conflicts:
	theme/bootstrapbase/style/moodle.css
2014-11-25 10:52:59 +13:00
Sam Hemelryk 5a9e656628 Merge branch 'm28_MDL-48265' of https://github.com/totara/moodle into MOODLE_28_STABLE 2014-11-25 09:42:56 +13:00
Dan Poltawski 5ff9df857e Merge branch '47832-28-removed' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2014-11-24 17:30:20 +00:00
Dan Poltawski c97952e6af Merge branch 'MDL-45867-m28-master' of https://github.com/dthies/moodle into MOODLE_28_STABLE 2014-11-24 17:11:15 +00:00
Mark Nelson e2e8a3e859 MDL-47601 core_backup: ensure removal of automated backups 2014-11-24 17:03:04 +00:00
Dan Poltawski edfb84865a Merge branch 'wip-MDL-48252-28' of git://github.com/abgreeve/moodle into MOODLE_28_STABLE 2014-11-24 16:29:27 +00:00
AMOS bot 78d7e090b2 Automatically generated installer lang files 2014-11-25 00:04:11 +08:00
Dan Poltawski 774522ff7e Merge branch 'MDL-48274-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-11-24 15:37:53 +00:00
Dan Poltawski 3a9daf6f9a Merge branch 'wip-mdl-48302-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2014-11-24 11:57:11 +00:00
Dan Poltawski 1913d60133 Merge branch 'MDL-48180-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2014-11-24 11:53:55 +00:00
David Monllao 3aeec06364 MDL-22309 report_singleview: Fixing wrong uses of get_role_users() 2014-11-24 10:59:02 +08:00
David Monllao de64c655e2 MDL-22309 accesslib: Preventing incorrect get_role_users() uses 2014-11-24 10:59:02 +08:00
David Monllao 7d3f51c262 MDL-22309 accesslib: Adding unit test to expose the issue 2014-11-24 10:59:02 +08:00
Sam Hemelryk b4d7288e94 Merge branch 'MDL-48148-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-11-24 15:58:03 +13:00
Sam Hemelryk 43e413f93f Merge branch 'MDL-48064-m28-master' of https://github.com/dthies/moodle into MOODLE_28_STABLE 2014-11-24 14:54:25 +13:00
Andrew Nicols afcae55712 MDL-48148 mod_forum: Use the standard forum reply subject as default
When a user replies by e-mail, the course name has been included in the
original e-mail. As a result, the reply subject becomes longer and longer.

In cases whether either:
* the discussion name; or
* the replied-to-post subject

is present in the mail subject, the standard reply subject is instead used.
2014-11-24 09:11:22 +08:00
Mark Nelson 65e2d354aa MDL-35494 core_backup: fixed activity restoration issue 2014-11-24 10:33:50 +13:00
Sam Hemelryk c19e95c871 Merge branch 'MDL-48288-28' of git://github.com/jethac/moodle into MOODLE_28_STABLE 2014-11-24 10:02:47 +13:00
David Mudrák 6237bb2f2f MDL-48210 updates checker: Improve cron notifications processing
These are cosmetic improvements spotted while working on the issue.

1. Do not waste time if there are no changes to notify about.
2. Fix the legacy plugin manager's get_plugins() call.
2014-11-21 12:07:55 +01:00
David Mudrák 87082d0f1c MDL-48210 plugin_manager: Invalidate caches after fetching updates info 2014-11-21 12:07:55 +01:00
Jetha Chan 229171be1a MDL-48288 gradebook: fix floating footer exception when averages disabled
The code we use to update styles on floating elements did not account for
situations where those floating elements don't exist. This was discovered
when a test site didn't have column averages enabled, resulting in no
floating footer element being created, so when _handleScrollEvent was
fired the first time, a null reference exception was thrown trying to
apply styles to a non-existent element.
2014-11-21 10:56:47 +08:00
Rajesh Taneja 62a703b655 MDL-48302 behat: Reverted temp fix added by MDL-48251 2014-11-21 10:41:09 +08:00
Rajesh Taneja c4c810491a MDL-48302 behat: Reset all data, before starting behat suite 2014-11-21 10:41:03 +08:00
Rajesh Taneja 46388b5e48 MDL-48302 behat: Make sure to clear php file cache 2014-11-21 10:40:56 +08:00
Rajesh Taneja 54bd82d4ae MDL-48302 behat: Reset cache before scenario 2014-11-21 10:40:49 +08:00
Jetha Chan ffd5282986 MDL-47329 mod_book: missing RTL styles, added page body selectors 2014-11-21 10:24:45 +08:00
Jetha Chan 07bff34437 MDL-47329 mod_book: use embedded pagetype instead of hardcoded HTML 2014-11-21 10:04:50 +08:00
Kordan 66649405b5 MDL-46618 tool_xmldb: added styles_bootstrapbase.css 2014-11-20 10:42:10 +01:00
Dan Poltawski 702e65c9ed weekly release 2.8.1+ 2014-11-20 08:38:26 +00:00
Dan Poltawski 81c559d05e Merge branch 'install_28_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_28_STABLE 2014-11-20 08:38:24 +00:00
Sam Hemelryk fa23afbe30 MDL-48304 moodle_url: compare now considers anchor 2014-11-20 15:38:48 +13:00
Adrian Greeve 6d5f68a832 MDL-48252 scheduled tasks: file_temp_cleanup_task does full delete.
This scheduled task was previously only doing a partial delete
due to the fact that the directory modification time would be
updated when a child file was deleted. It would then have to
wait another week before that directory could be deleted.
2014-11-20 10:34:33 +08:00
Adrian Greeve 88690b92e4 MDL-48252 scheduled tasks: Unit test for file_temp_cleanup_task. 2014-11-20 10:28:18 +08:00
Sam Hemelryk 472b438486 MDL-47832 cache: removed data source aggregate functionality
Cache data source aggregate functionality was found to be broken
and unused, because of this the decision was made to remove it
rather than fix it.
As it was broken we did not follow typical deprecation methods and
instead the code was removed outright with only structure
remaining and left deprecated.
2014-11-20 11:25:04 +13:00
Sam Hemelryk 04c92d672f MDL-43628 mod_assign: fixed formatting of statement 2014-11-20 10:18:42 +13:00
Eloy Lafuente (stronk7) 57ebd7b1b1 Merge branch '48206-28' of git://github.com/samhemelryk/moodle into MOODLE_28_STABLE 2014-11-19 21:19:41 +01:00
Rajesh Taneja 1cda99f39b MDL-48251 behat: Shuffling activity creation fix quiz behat 2014-11-19 20:06:54 +01:00
Dan Poltawski 93d5459125 MDL-29585 wiki: fix unit test fails 2014-11-19 11:40:37 +00:00
Frederic Massart 62845bce83 MDL-29585 mod_wiki: Prevent broken links in editable sections
When a section name ended with a URL, the '<a' part of [edit] link
that is appended to the section was considered as part of the URL
in the section, thus causing the [edit] link to be broken.
2014-11-19 10:34:36 +00:00
Dan Poltawski d9eedd1a68 MDL-48277 css: initial csslint config file 2014-11-19 09:20:50 +00:00
Rajesh Taneja 3dfecf93cc MDL-46865 report_log: Fixed site name in behat step 2014-11-19 06:41:13 +00:00
Mario Wehr 0858e593e6 MDL-48274 mod_forum: Add missing context to has_capability call 2014-11-19 14:06:36 +08:00
Dan Poltawski ddf83f51d4 MDL-48276 qformat_xhtml: avoid uncessary html in .css file
In order to help automated tools move the html out of the css
file.
2014-11-19 05:56:41 +00:00
Andrew Nicols ba8ca6604d MDL-22043 mod_forum: Fix toggle subscription editing button behaviour
Update the user session property before generating the button which relies
upon it.
2014-11-19 13:32:23 +08:00
Andrew Nicols f8da8ae382 MDL-14402 blocks: Do not show assign roles on my home 2014-11-19 11:18:49 +08:00
Andrew Nicols 5c86569096 MDL-23839 navigation: Check for assignable course category roles 2014-11-19 08:55:56 +08:00
Sam Hemelryk 921d045174 MDL-33606 tests: fixed broken unit test 2014-11-19 11:30:42 +13:00
Sam Hemelryk c81ae06997 Merge branch 'MDL-33606_28' of git://github.com/dmonllao/moodle into MOODLE_28_STABLE 2014-11-19 09:37:24 +13:00
Daniel Thies 3228da2e5c MDL-45867 atto_equation: Change preview update to asynchronous 2014-11-18 13:30:33 -06:00
Mary Evans 236351fdc3 MDL-47915 mod/scorm: Added JS fallback for themes using copied layouts. 2014-11-18 17:49:08 +00:00
AMOS bot 752fdd2479 Automatically generated installer lang files 2014-11-19 00:05:40 +08:00
Dan Poltawski 29a036aa59 Merge branch 'MDL-48146_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-11-18 12:07:10 +00:00
Sam Hemelryk 299f1bcdbd Merge branch 'wip-mdl-48250-m28' of https://github.com/rajeshtaneja/moodle into MOODLE_28_STABLE 2014-11-18 17:38:08 +13:00
Sam Hemelryk 09de24667f Merge branch 'MDL-29585-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2014-11-18 16:47:30 +13:00
Brian Barnes a7d7354c85 MDL-48265 feedback: Added alt text to ghostscript test image 2014-11-18 16:46:00 +13:00
Jetha Chan 31830a539d MDL-23912 core_comment: update count after deletion 2014-11-18 09:35:23 +08:00
Sam Hemelryk 67ccf63800 MDL-38343 cache: better test server strings 2014-11-18 12:34:30 +13:00
Sam Hemelryk 292e991b86 Merge branch 'MDL-47618_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-11-18 11:12:32 +13:00
Daniel Thies 65e345c3f4 MDL-48064 atto_editor: Expand event subscription for saving selection 2014-11-17 11:36:43 -06:00
Mark Nelson 554f0bd206 MDL-30619 mod_data: fixed deletion of files on reset 2014-11-17 16:49:00 +00:00
Dan Poltawski 38d6b6eb17 Merge branch 'MDL-48199_M28' of git://github.com/lazydaisy/moodle into MOODLE_28_STABLE
Conflicts:
	theme/bootstrapbase/style/moodle.css
2014-11-17 16:42:44 +00:00
AMOS bot 931d7216cc Automatically generated installer lang files 2014-11-18 00:05:48 +08:00
Dan Poltawski 6dfc37accf Merge branch 'MDL-47648_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-11-17 15:41:38 +00:00
Rajesh Taneja 9e273e7556 MDL-46865 report_log: Fixed showuser and showcourse in report log 2014-11-17 15:34:16 +00:00
Dan Poltawski 2d747884c6 Merge branch 'm28_MDL-48023_Theme_Setting_Files_Cacheable_By_Both_Browsers_And_Proxies' of https://github.com/scara/moodle into MOODLE_28_STABLE 2014-11-17 15:20:17 +00:00
Dan Poltawski af2c296364 Merge branch 'MDL-48042_28' of git://github.com/ppichet/moodle into MOODLE_28_STABLE 2014-11-17 15:13:19 +00:00
Mary Evans ec1a6a6996 MDL-48246 theme: Fixed typo in 'hidepanelicon' 2014-11-17 15:06:34 +00:00
Dan Poltawski 3b8a871233 Merge branch 'MDL-42756_28' of git://github.com/aolley/moodle into MOODLE_28_STABLE 2014-11-17 13:52:49 +00:00
Adrian Greeve ccfd014d42 MDL-36240 backup: Activity calendar events backed up.
Activity calendar events can now be backed up and restored
when no user data is selected.
2014-11-17 13:31:19 +00:00
Dan Poltawski 0c0714ae3b Merge branch 'MDL-43987-28' of git://github.com/xow/moodle into MOODLE_28_STABLE 2014-11-17 13:17:40 +00:00
Dan Poltawski 4d7f88d55c Merge branch 'MDL-46640-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2014-11-17 12:52:36 +00:00
Dan Poltawski d5f6d962e2 Merge branch 'MDL-48150-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-11-17 11:44:15 +00:00
Andrew Nicols 97f5b7b8a2 MDL-48150 mod_forum: Generate message inbound keys for all posts
This code was previously misplaced so that only posts in discussion which
had not yet been processed in the current cron run would have keys
generated. If two posts were generated in the same discussion and sent out
on the same cron cycle, only the first post to be processed would have a
key generated.
2014-11-17 15:48:12 +08:00
Frederic Massart 410d8eda9a MDL-48180 mod_assign: By default do not count 'new' submissions 2014-11-17 15:14:59 +08:00
Rajesh Taneja c42974048a MDL-48250 enrol_ldap: set default category
As in other enrol plugins (database), set default
category to 1 (pointing to Miscellaneous)
2014-11-17 14:42:27 +08:00
Frederic Massart fce8127ff0 MDL-46640 navigation: Handle block contexts within a category 2014-11-17 12:42:09 +08:00
Frederic Massart 864e404348 MDL-29585 mod_wiki: Handle special characters in headings/sections 2014-11-17 10:39:26 +08:00
Jetha Chan cfbc7d903f MDL-48191 gradebook: fixed floating headers when emails not displayed 2014-11-17 10:17:53 +08:00
Sam Hemelryk 0b9dc284e8 MDL-48196 phpunit: fixed the fail after this change 2014-11-17 15:07:39 +13:00
John Okely e92d84244c MDL-43987 core: Remove port numbers in cleanremoteaddr 2014-11-17 09:48:32 +08:00
Sam Hemelryk e9f7276481 Merge branch 'MDL-48115_28' of https://github.com/totara/openbadges into MOODLE_28_STABLE 2014-11-17 14:37:58 +13:00
Sam Hemelryk b1dd1c8656 Merge branch 'MDL-48194-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-11-17 13:39:17 +13:00
Sam Hemelryk 6b5f44b214 Merge branch 'MDL-48171-28' of git://github.com/ankitagarwal/moodle into MOODLE_28_STABLE 2014-11-17 13:21:05 +13:00
Mary Evans 068c7a8706 MDL-48199 theme_bootstrapbase: Page padding left is wrong when in RTL 2014-11-17 00:02:13 +00:00
Sam Hemelryk e3adeba886 Merge branch 'MDL-48179-m28' of https://github.com/sammarshallou/moodle into MOODLE_28_STABLE 2014-11-17 12:48:12 +13:00
Sam Hemelryk 666ac939d5 Merge branch 'MDL-48196-28' of git://github.com/andrewnicols/moodle into MOODLE_28_STABLE 2014-11-17 12:34:16 +13:00
Sam Hemelryk d2fe097e20 Merge branch 'm28_MDL-47993' of https://github.com/totara/moodle into MOODLE_28_STABLE 2014-11-17 12:21:37 +13:00
Sam Hemelryk b1298c7690 Merge branch 'MDL-43628_v28' of https://github.com/scyrma/moodle into MOODLE_28_STABLE 2014-11-17 11:45:01 +13:00
Ankit Agarwal 6748b5ee5c MDL-35638 backup: Do not print headers during redirects 2014-11-17 10:38:50 +13:00
Sam Hemelryk 583cf99ebd Merge branch 'MDL-47590_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-11-17 10:38:49 +13:00
Sam Hemelryk c1ca23afa3 Merge branch 'MDL-44657-28' of git://github.com/FMCorz/moodle into MOODLE_28_STABLE 2014-11-17 10:38:49 +13:00
Sam Hemelryk 0c96741ef7 MDL-48189 grade: letters now covered by behat 2014-11-17 08:54:30 +13:00
Matteo Scaramuccia b73158d3d0 MDL-48023 Files API: Theme files must be cache-able by shared proxies.
The profile image AKA user icon will be cache-able by shared proxies too,
under its specific accessibility constraints/conditions.
2014-11-16 09:59:22 +01:00
Pierre Pichet f6fd6787d1 MDL-48042 Questions: Reset Calculated qtype comments on datasets
Reset back the modifications of Calculated qtype comments on datasets
    done by MDL-47224

Signed-off-by: Pierre Pichet <pichet.pierre@uqam.ca>
2014-11-15 16:54:27 -05:00
sam marshall 60fef215f6 MDL-48179 Backup progress: Can time out when compressing large backup 2014-11-14 18:30:17 +00:00
Daniel Thies 4587188ad9 MDL-48064 atto_editor: Check if activeElement is child node in isActive 2014-11-14 12:15:22 -06:00
Tim Hunt bc575d2bea MDL-47590 question backup: include response file only with userdata 2014-11-14 16:21:38 +00:00
Ankit Agarwal 806f6f642c MDL-48171 gradebook: Use proper apis to get item name 2014-11-14 14:05:52 +05:30
Sam Hemelryk acad969077 MDL-48206 block_comments: textarea width 100% 2014-11-14 11:40:32 +13:00
Oleg Demeshev 066751547d MDL-47993 calendar: Fix ical import Microsoft calendar issue 2014-11-14 10:39:34 +13:00
Eloy Lafuente (stronk7) 296b602f2c Moodle release 2.8.1 2014-11-13 12:22:51 +01:00
Eloy Lafuente (stronk7) 76db660264 Merge branch 'MDL-48214-28-enfix' of git://github.com/mudrd8mz/moodle into MOODLE_28_STABLE 2014-11-13 12:05:17 +01:00
Helen Foster e5381b67e9 MDL-48214 Merge English strings from the en_fix language pack 2014-11-13 11:32:24 +01:00
Paul Holden 309a919074 MDL-44657 forms: Form identifiers should only contain basic characters 2014-11-13 16:25:12 +08:00
Andrew Nicols 367a26d088 MDL-48196 phpunit: Set e-mail address for admin user at installation 2014-11-13 08:58:55 +08:00
Eugene Venter 8d4e07d86d MDL-48204 mod_wiki: admin.php - fix syntax error 2014-11-13 00:47:16 +01:00
Tim Hunt 89eb7cf302 MDL-48146 quiz settings: fix non-percent feedback boundaries 2014-11-12 15:46:55 +00:00
Dan Poltawski b37f9889d0 weekly release 2.8+ 2014-11-12 11:33:31 +00:00
Dan Poltawski c8900a5152 MDL-48174 tool_langimport: info about skipped update
So admins can work out why the task might not be having an effect.
2014-11-12 11:22:45 +00:00
Rajesh Taneja 4c4d53ebaf MDL-48174 core_lang: support for ->skiplangupgrade in lang cron task
Similar to upgrade_language_pack(), update_langpacks_task should
respect skiplangupgrade config. Also, this should be added to behat
whitelist, so it can be disabled during on-sync period, when lang
pack for master is not available.
2014-11-12 11:03:55 +00:00
David Monllao a26ce935c7 MDL-30968 mod_forum: No picture link to group when no groups mode 2014-11-12 07:43:08 +00:00
David Monllao 2a3e89465c MDL-33606 course: Adding section info to course_viewed log 2014-11-12 13:58:35 +08:00
Andrew Nicols 6d8019438f MDL-48194 testing: Adjust naming of testsuites in phpunit.xml
This will make it easier to run phpunit for a specific component by making
all testsuite names consistent, guessable, and in-line with the naming of
the parameter (testsuite vs. test suite).
2014-11-12 12:06:45 +08:00
Adam Olley b19e9ae457 MDL-42756 dock: Trigger actionmenu enhance when showing dock panel
Additionally fixes the styling for the actionmenu icon size in
bootstrapbase'd themes.
2014-11-12 14:11:33 +10:30
Frederic Massart c6a1e9bed3 MDL-46416 group: Use a revision number for group pictures 2014-11-12 11:29:22 +08:00
James Ballard 0df5893423 MDL-47391 Update pagelayout for default profile configuration 2014-11-12 12:34:27 +13:00
Frederic Massart dd818fdb44 MDL-39692 grade: Little code clean up of letter boundary deletion 2014-11-12 12:19:31 +13:00
Huy Hoang 1fd2bc4810 MDL-39692 grade: Ability to delete letter boundary 2014-11-12 12:19:31 +13:00
Yuliya Bozhko 3f3f7ce52a MDL-48115 badges: Fix strtoupper() output in badges
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
2014-11-12 09:30:29 +13:00
Amanda Doughty 088c4fb280 MDL-30968 mod/forum Fixed group link 2014-11-12 09:00:16 +13:00
Dan Poltawski 0ed92e6a37 MDL-47502 statslib tests: improve test
While integrating I noticed some problems which already existed in this
test:
* The enrolment data generator was not used
* The student roleid was hardocded
* The role assignment was at site level..
2014-11-11 19:26:03 +00:00
Eugene Venter afc8bd9672 MDL-47502 test_statslib_cron_daily: fix provider
Fiddling with the database in the data provider causes "out of sync"
errors when running suite tests.
2014-11-11 19:12:46 +00:00
Damyon Wiese c2dd91bfef MDL-47975 assign: Stop gap fix for random time fails. 2014-11-11 19:06:38 +00:00
sam marshall b0ac83b82b MDL-48093 HTML 5 video: Firefox now supports .mp4 2014-11-11 19:00:12 +00:00
Dan Poltawski 272ad5b577 Merge branch 'MDL-48168_28' of git://github.com/timhunt/moodle into MOODLE_28_STABLE 2014-11-11 18:48:36 +00:00
David Balch 7805d03a9e MDL-46116 mod_imscp: Display first item with content on load. 2014-11-11 18:42:29 +00:00
Tim Hunt ecb40b963d MDL-47618 quiz statistics: fatal error with groups.
The problem was that the names of query placeholders were changing. The
fix was to do things ourself, rather than using get_in_or_equal.
2014-11-11 18:29:31 +00:00
David Balch b45e110c3a MDL-46116 mod_imscp: Don't create links on items without content. 2014-11-11 18:16:39 +00:00
Darko Miletic 928497310e MDL-39376 enrol: Optimized setting for ldap and database 2014-11-11 17:23:01 +00:00
David Mudrák 5755d70f2e MDL-48156 task: Skip the scheduled task only for really disabled plugins 2014-11-11 17:18:03 +00:00
Tim Hunt ff8aaa2dd4 MDL-47648 admin unit tests: fix file perms on mimetex.exe
This was causing the
core_admintree_testcase::test_admin_setting_configexecutable unit test
to fail.
2014-11-11 14:04:20 +00:00
Mathieu Petit-Clair 5ebde631c0 MDL-43628 assign: make submissionagreement usable on multilingual sites 2014-11-10 16:53:49 -05:00
Tim Hunt 21c633a8c6 MDL-48168 quiz editing: max grade should be editable after attempts
Note that there was a lot of legacy code left from Moodle 2.7 which is
no longer required, and I took this opportunity to delete it.
2014-11-10 19:00:33 +00:00
Eloy Lafuente (stronk7) 25fe23f5f5 MDL-48144 upgrade: add v2.8.0 sep lines 2014-11-10 18:09:20 +01:00
Eloy Lafuente (stronk7) 21db825b19 Moodle release 2.8 2014-11-08 23:30:59 +01:00
Eloy Lafuente (stronk7) 3789b47f16 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2014-11-08 23:30:53 +01:00
AMOS bot 7a6b9b1e90 Automatically generated installer lang files 2014-11-09 00:05:33 +08:00
Eloy Lafuente (stronk7) bea7509414 Merge branch 'MDL-48107_master' of https://github.com/markn86/moodle 2014-11-08 11:19:59 +01:00
Mark Nelson 8145ab3372 MDL-48107 tool_monitor: extended automated tests
Also adjusted them so they will pass with these changes.
2014-11-08 00:50:51 -08:00
Mark Nelson 884652378a MDL-48107 tool_monitor: prevent site rule removal when deleting a course 2014-11-08 00:49:00 -08:00
Mark Nelson cbc4ecc7f9 MDL-48107 tool_monitor: added total subs to the delete rule string
Also made some minor language string changes.
2014-11-08 00:26:56 -08:00
Eloy Lafuente (stronk7) 17cc9fcd84 Moodle release 2.8rc2 2014-11-07 16:59:39 +01:00
Damyon Wiese f2e5a435a6 MDL-47900 Event monitor: Fix name of cache lang string for event monitor
AMOS BEGIN
 MOV [cachedef_rules, tool_monitor],[cachedef_eventsubscriptions, tool_monitor]
AMOS END
2014-11-07 17:40:21 +08:00
Damyon Wiese d04803595c Merge branch 'MDL-47900_master' of https://github.com/markn86/moodle 2014-11-07 16:58:52 +08:00
Eloy Lafuente (stronk7) d79af819c6 Merge branch 'wip-mdl-48035' of https://github.com/rajeshtaneja/moodle 2014-11-07 09:37:32 +01:00
Damyon Wiese 3d4de122f2 Merge branch 'MDL-46986-master' of https://github.com/lameze/moodle 2014-11-07 16:08:20 +08:00
Simey Lameze 8c674e80ec MDL-46986 mod_assign: Change the asserting to false 2014-11-07 15:54:14 +08:00
John Okely a481e32f02 MDL-47949 mod_wiki: Validate parameters for page deletion 2014-11-07 15:29:40 +08:00
Marina Glancy 293f1b4d85 Merge branch 'MDL-47869-master' of git://github.com/lameze/moodle 2014-11-07 15:03:32 +08:00
Rajesh Taneja ea2b511d9a MDL-48035 mod_forum: Reverted string change in step to keep correct functionality 2014-11-07 13:43:19 +08:00
Marina Glancy 2f1d0ea663 Merge branch 'MDL-46986-master' of git://github.com/lameze/moodle 2014-11-07 11:54:13 +08:00
Mark Nelson c490ede369 MDL-47900 tool_monitor: expanded unit tests
Expanded the unit tests to ensure unnecessary events are not
saved in the DB and altered existing tests so they pass with
the introduction of this feature.
2014-11-06 18:46:45 -08:00
Mark Nelson 475635f52d MDL-47900 tool_monitor: created list of rules MUC 2014-11-06 18:46:44 -08:00
Damyon Wiese 419d1abdad MDL-48091 users: Revert "MDL-42875 users: Show only profile visible..."
This reverts commit a09a837f20.
2014-11-07 09:30:42 +08:00
Simey Lameze 274962a1e7 MDL-46986 mod_assign: Remove duplicate column identifier 2014-11-07 09:19:18 +08:00
Eloy Lafuente (stronk7) 415fc3d2f9 Merge branch 'MDL-47943-master' of https://github.com/dthies/moodle 2014-11-06 18:44:38 +01:00
Eloy Lafuente (stronk7) ed34ab47e1 Merge branch 'MDL-48035-master-enfix' of git://github.com/mudrd8mz/moodle 2014-11-06 17:40:50 +01:00
David Mudrák f7dd19f01d MDL-48035 Fix more Behat tests regressions after merging en_fix strings 2014-11-06 16:19:11 +01:00
Andrew Nicols a211c54388 MDL-48090 mod_forum: Optimise subquery out of discussion subs list 2014-11-06 13:39:44 +00:00
Eloy Lafuente (stronk7) 6fdd4633a7 Merge branch 'MDL-48035-master-enfix' of git://github.com/mudrd8mz/moodle 2014-11-06 11:14:52 +01:00
David Mudrák 6887e2e53e MDL-48035 Fix Behat tests regressions after merging en_fix strings 2014-11-06 10:54:27 +01:00
Dan Poltawski e323635e1b Merge branch 'MDL-47390-master-fixes' of git://github.com/andrewnicols/moodle 2014-11-06 09:14:48 +00:00
Dan Poltawski 4c37593dcd Merge branch 'MDL-47980-master-fixup' of https://github.com/jethac/moodle 2014-11-06 08:58:27 +00:00
Dan Poltawski 4aeebe34b4 Merge branch 'MDL-47922-master' of git://github.com/ankitagarwal/moodle 2014-11-06 08:53:55 +00:00
Andrew Nicols 2b0a7419c6 MDL-47390 mod_forum: Provide ID and Discussion ID for discussion unsub 2014-11-06 16:50:36 +08:00
Jetha Chan b7ee86966b MDL-47980 gradebook: fixed label for bulk insert select box 2014-11-06 16:37:23 +08:00
Marina Glancy f2db391f59 Merge branch 'MDL-47980-master' of git://github.com/jethac/moodle 2014-11-06 15:14:05 +08:00
Simey Lameze 7c2a2e1a93 MDL-47869 tool_monitor: Add sorting on event monitor pages 2014-11-06 14:53:10 +08:00
Damyon Wiese 527464a618 MDL-43430 ldap: whitespace fix 2014-11-06 12:05:32 +08:00
Damyon Wiese bd6ee5c58a Merge branch 'wip_master_mdl-43430' of https://github.com/iarenaza/moodle 2014-11-06 12:00:12 +08:00
Marina Glancy 253b93f720 Merge branch 'wip_MDL-48083_m28_rollback' of git://github.com/skodak/moodle 2014-11-06 11:42:10 +08:00
Damyon Wiese ce1b8779df Merge branch 'MDL-48061-master-fixes' of https://github.com/andrewnicols/moodle 2014-11-06 11:30:42 +08:00
Andrew Nicols 4ee412613b MDL-48061 mod_forum: posttext should concat 2014-11-06 11:29:25 +08:00
Damyon Wiese b0637c57ad Merge branch 'MDL-48061-master-fixes' of https://github.com/andrewnicols/moodle 2014-11-06 11:22:42 +08:00
Andrew Nicols a41cff4e23 MDL-48061 mod_forum: Correct variable name in HTML warning message 2014-11-06 11:05:44 +08:00
Petr Skoda 5cf50f96e7 MDL-48083 dml: Empty buffers on forced rollback 2014-11-06 15:52:37 +13:00
Andrew Nicols ddb4a31d54 MDL-48029 mod_forum: Check for subscription before enrolling 2014-11-06 10:42:09 +08:00
Jetha Chan dd01789b4f MDL-47980 gradebook: add labels and legends missing from single view 2014-11-06 10:40:36 +08:00
Ankit Agarwal e53a4b88d6 MDL-47922 tool_monitor: Update strings 2014-11-06 07:42:24 +05:30
Eloy Lafuente (stronk7) dc3fab74ae Merge branch 'wip-MDL-47174-master' of git://github.com/marinaglancy/moodle 2014-11-06 02:15:44 +01:00
Marina Glancy 8f94164df3 MDL-47174 events: new calendar event may have 0 timestart 2014-11-06 08:57:29 +08:00
Eloy Lafuente (stronk7) a376c72a05 Merge branch 'wip-mdl-45416' of https://github.com/rajeshtaneja/moodle 2014-11-06 00:57:45 +01:00
Eloy Lafuente (stronk7) ec070d2cf7 Merge branch '48026-28' of git://github.com/samhemelryk/moodle 2014-11-06 00:33:46 +01:00
John Okely 9aa9a1c70a MDL-47862 tool_monitor: Fix tool monitor navigation tree
Added event monitor rules link to the frontpage navigation tree, when
editing the frontpage rules. Added hack so that when viewing the site
context subscriptions, the link in navigation is correct, allowing the
breadcrumbs to appear
2014-11-06 12:27:51 +13:00
John Okely 8f6b6982fa MDL-47862 event_monitor: Fix context for capability check on subscription page 2014-11-06 12:27:51 +13:00
Eloy Lafuente (stronk7) 4723da1bff Merge branch 'MDL-47990' of git://github.com/timhunt/moodle 2014-11-06 00:22:32 +01:00
Eloy Lafuente (stronk7) 862b76f39b Merge branch 'MDL-48050-master' of git://github.com/damyon/moodle 2014-11-06 00:01:26 +01:00
Sam Hemelryk 12a312ac6a Merge branch 'MDL-48044-master' of git://github.com/andrewnicols/moodle 2014-11-06 11:55:46 +13:00
Eloy Lafuente (stronk7) 97100bea54 Merge branch 'MDL-48054-master' of git://github.com/andrewnicols/moodle 2014-11-05 21:34:37 +01:00
Dan Poltawski 62e965c9b8 Merge branch 'MDL-47466-master' of https://github.com/tehanuyor/moodle 2014-11-05 16:24:14 +00:00
Daniel Thies 8160d004ce MDL-47943 editor_atto: Save selection on mouseleave for Chrome 2014-11-05 09:34:20 -06:00
Dan Poltawski c293eb004b Merge branch 'MDL-47874' of git://github.com/stronk7/moodle 2014-11-05 14:27:12 +00:00
Dan Poltawski 5a6c9f1cfb Merge branch 'MDL-48021' of git://github.com/stronk7/moodle
Conflicts:
	admin/tool/monitor/version.php
	mod/lesson/version.php
2014-11-05 12:11:16 +00:00
Dan Poltawski 35d236c1ea Merge branch 'MDL-48047-master' of git://github.com/lameze/moodle 2014-11-05 12:05:58 +00:00
Dan Poltawski 90de57db26 Merge branch 'MDL-48068-master' of git://github.com/FMCorz/moodle 2014-11-05 12:03:48 +00:00
Dan Poltawski f3fd919187 Merge branch 'MDL-47981-master' of git://github.com/damyon/moodle 2014-11-05 12:00:19 +00:00
Dan Poltawski 7aedf52716 MDL-47922 tool_monitor: bump version 2014-11-05 11:42:37 +00:00
Dan Poltawski 7ea14bb819 Merge branch 'MDL-47922-master' of git://github.com/ankitagarwal/moodle 2014-11-05 11:18:22 +00:00
Dan Poltawski a0cba367bd Merge branch 'MDL-47982-master' of git://github.com/gurgus/moodle 2014-11-05 11:03:57 +00:00
Andrew Nicols 7a311adbba MDL-48019 mod_forum: Add sesskey checks when setting tracking prefs
This also removes set_url() and changes require_course_login to
require_login as guests cannot set tracking.
2014-11-05 10:35:12 +00:00
Dan Poltawski fb3e9ea25d Merge branch 'MDL-48067-master' of git://github.com/jethac/moodle 2014-11-05 10:15:41 +00:00
Damyon Wiese a75cc21442 Merge branch 'MDL-48061-master' of git://github.com/andrewnicols/moodle 2014-11-05 16:54:32 +08:00
Damyon Wiese ec57e8b3f4 Merge branch 'MDL-46500_master' of https://github.com/dmonllao/moodle 2014-11-05 16:52:07 +08:00
Marina Glancy 93a4f8b5fc Merge branch 'MDL-47390-master' of git://github.com/andrewnicols/moodle 2014-11-05 16:35:05 +08:00
Iñaki Arenaza cc22032502 MDL-43430 enrol_ldap: Enrolment lost if member of group with parenthesis
While testing the fix, it was found that ldap_stripslashes() was broken and
using a deprecated PCRE patter modifier, so it's also been fixed.

Thanks to Damyon Wiese, some units tests have been added to cover
ldap_addslashes() and ldap_stripslashes().
2014-11-05 09:01:27 +01:00
Iñaki Arenaza 21302343ee MDL-43430 enrol_ldap: Enrolment lost if member of group with parenthesis
The group names we get from ldap_find_user_groups() can contain invalid LDAP
filter characters. So we need to escape them for LDAP filter usage.
2014-11-05 09:00:17 +01:00
Iñaki Arenaza 9807737734 MDL-43430 enrol_ldap: Enrolment lost if member of group with parenthesis
As part of fixing MDL-43430, a typo has been detected in the
quoted alphanumeric characters (the '=' and '>' were transposed).
2014-11-05 09:00:17 +01:00
Damyon Wiese 2f1637f09b Merge branch '48025-28' of git://github.com/samhemelryk/moodle 2014-11-05 15:39:27 +08:00
Simey Lameze b52b1ee9a4 MDL-48047 gradebook: change the missing ID number to checkbox on XML export 2014-11-05 15:24:09 +08:00
Damyon Wiese b729370ebe Merge branch 'MDL-47893-master-fix' of https://github.com/zbdd/moodle 2014-11-05 15:22:55 +08:00
Damyon Wiese 086e5b7b9e Merge branch 'MDL-47360-master' of git://github.com/lameze/moodle 2014-11-05 15:12:56 +08:00
Frederic Massart 00d03b0b8a MDL-48068 tool_monitor: Link to course points to the right course 2014-11-05 15:06:27 +08:00
Simey Lameze 0194d87ec5 MDL-47360 tool_monitor: add more help link and default template message 2014-11-05 14:57:53 +08:00
Andrew Nicols 7122e1543a MDL-48054 mod_forum: Fix unit test failures
These sporadic unit test failures were happening because the post time and
subscription time sometimes differ depending on the amount of time it takes
to complete the different components of the test.

To reliably address these issues, the post creation, and the discussion
subscription times are manually updated by different factors to ensure a
more realistic state of affairs.
2014-11-05 14:49:02 +08:00
Zachary Durber 4fb6b62c42 MDL-47893 gradebook: Fix for bulk updating single view. 2014-11-05 14:44:15 +08:00
Damyon Wiese 5ab68de8f0 Merge branch 'wip-MDL-46262-master' of git://github.com/marinaglancy/moodle 2014-11-05 14:38:11 +08:00
Jetha Chan 088fcf90ca MDL-48067 user_menu: allow empty customusermenuitems setting 2014-11-05 14:37:33 +08:00
Damyon Wiese 225fa27fc2 MDL-47793 assign: trivial fix for inconsistent use of get_instance() 2014-11-05 14:27:58 +08:00
Damyon Wiese 43db479d51 Merge branch 'MDL-47793-m' of https://github.com/micaherne/moodle 2014-11-05 14:25:22 +08:00
Damyon Wiese 686150130e Merge branch 'MDL-47930-master' of git://github.com/andrewnicols/moodle 2014-11-05 14:18:07 +08:00
Damyon Wiese c5d4633fed Merge branch 'MDL-47902_scorm_inappropriate_default_values' of https://github.com/MorrisR2/moodle 2014-11-05 14:05:32 +08:00
Damyon Wiese 8a9fd2d4cf MDL-27930 lesson: Remove custom styling from timer 2014-11-05 13:58:38 +08:00
Damyon Wiese c86477aa88 Merge branch 'MDL-27930' of git://github.com/jmvedrine/moodle 2014-11-05 13:34:07 +08:00
Zachary Durber 5467cc051c MDL-48031 gradebook: Fix for bulk updating users in single view. 2014-11-05 13:20:40 +08:00
Ankit Agarwal f63c5b0413 MDL-47922 behat: Add a behat test 2014-11-05 10:19:45 +05:30
Ankit Agarwal 236a1f8d31 MDL-47922 tests: Enable tool monitor in various tests 2014-11-05 10:19:45 +05:30
Ankit Agarwal 5ff867362a MDL-47922 tool_monitor: Add a config to disable the tool 2014-11-05 10:19:44 +05:30
Andrew Nicols 6a5b087163 MDL-48061 mod_forum: Tidy up reply-by-email information in emails
* Add a reminder to remove the original message; and
* Remove the reply-to address from the text.
2014-11-05 11:20:59 +08:00
Rajesh Taneja e790a3ecc7 MDL-45416 enrol_ldap: Use null_progress_trace while running phpunit 2014-11-05 10:43:16 +08:00
Eloy Lafuente (stronk7) 8d3c518bd5 Merge branch 'MDL-48035-master-enfix' of git://github.com/mudrd8mz/moodle 2014-11-05 01:16:05 +01:00
Helen Foster ba033b861e MDL-48035 Merge English strings from the en_fix language pack 2014-11-04 21:55:26 +01:00
Eloy Lafuente (stronk7) de881693f7 MDL-48021 bump: Bump all versions to planned release
This bumps all versions to planned 2.8 release
(2014111000) version and all the dependencies to
current 2.8rc1 (2014110400)
2014-11-04 17:52:35 +01:00
Dan Poltawski f61619597b Merge branch 'MDL-47893-master' of git://github.com/zbdd/moodle 2014-11-04 16:50:47 +00:00
Dan Poltawski f820acf01e Merge branch 'MDL-47944-master' of git://github.com/andrewnicols/moodle 2014-11-04 16:30:17 +00:00
Jean-Michel Vedrine 50d70c5caf MDL-27930 Lesson: the count-down timer does not work 2014-11-04 15:12:42 +01:00
Eloy Lafuente (stronk7) 6ce4b8ea30 Moodle release 2.8rc1 2014-11-04 11:45:59 +01:00
Damyon Wiese 12938e894d MDL-48050 Libraries - fake HTTPS detection needs the correct port 2014-11-04 16:50:25 +08:00
Andrew Nicols 1008dd8ef0 MDL-47390 mod_forum: Correct check for groups when subscribing 2014-11-04 16:35:47 +08:00
Andrew Nicols da30d04408 MDL-47390 mod_forum: Add discussion unsub to email footer 2014-11-04 16:35:47 +08:00
Mark Nelson 4e86f45a3e MDL-47361 tool_monitor: added missing column
Also reworded a string as the fields have been renamed.
2014-11-04 00:15:41 -08:00
Andrew Nicols 548453ecde MDL-48044 mod_forum: Preload icons for discussion subscription toggles 2014-11-04 16:09:19 +08:00
Andrew Nicols a35ce611cf MDL-47944 mod_forum: Improve discussion subscription icon/link
* make the link text clickable
* changes the link text when unsubscribed to the action text "Subscribe"
2014-11-04 15:46:05 +08:00
Damyon Wiese 888d0822bd Merge branch 'MDL-47806' of github.com:mr-russ/moodle 2014-11-04 14:34:43 +08:00
Damyon Wiese 0c4a7f96cc Merge branch 'MDL-47810_master-fix-MDL-47758-changes' of git://github.com/dmonllao/moodle 2014-11-04 14:17:46 +08:00
Zachary Durber 50e30bd4e3 MDL-47893 gradebook: Progress bar and continues for grade saving.
When you save a grade you are notified of how many grades have
been updated and any warnings.
2014-11-04 13:57:03 +08:00
Damyon Wiese 7a056947e3 Merge branch 'MDL-45636-course_master' of https://github.com/eSrem/moodle 2014-11-04 13:47:51 +08:00
David Monllao 0907f49b4e MDL-47810 tool_monitor: Updating behat scenarios introduced in MDL-47758 2014-11-04 12:23:42 +08:00
Marina Glancy 1d9155872f Merge branch 'MDL-48006-master' of git://github.com/damyon/moodle 2014-11-04 10:47:09 +08:00
Eloy Lafuente (stronk7) 990ebf08c7 Merge branch 'MDL-47883-master-foundlangfile' of git://github.com/mudrd8mz/moodle 2014-11-04 02:03:11 +01:00
Eloy Lafuente (stronk7) b53c2a92d0 Merge branch 'wip-MDL-47976-master' of git://github.com/marinaglancy/moodle 2014-11-04 01:59:23 +01:00
Eloy Lafuente (stronk7) ddb5bc5fcd Merge branch '47969-28' of git://github.com/samhemelryk/moodle 2014-11-04 01:56:59 +01:00
Eloy Lafuente (stronk7) 882f915922 Merge branch '47968-28' of git://github.com/samhemelryk/moodle 2014-11-04 01:55:08 +01:00
Petr Skoda 76ae1f6068 MDL-47868 ws: verify upload areas 2014-11-04 01:48:17 +01:00
Petr Skoda 7ee4642bcb MDL-48013 calendar: force download of user files 2014-11-04 01:40:52 +01:00
Eloy Lafuente (stronk7) bebd3ce8fc Merge branch 'MDL-47207_master' of git://github.com/dmonllao/moodle 2014-11-04 01:20:51 +01:00
Eloy Lafuente (stronk7) 1ebcb0080b Merge branch '47917-28' of git://github.com/samhemelryk/moodle 2014-11-04 00:03:42 +01:00
Damyon Wiese edc89dfecb MDL-47927 LTI: Use PARAM_TEXT and p() for returned messages and errors 2014-11-04 11:46:57 +13:00
Frederic Massart 5d0b3b21d6 MDL-47965 tag: Enforcing security of tag auto completion 2014-11-04 11:28:17 +13:00
David Monllao babaf596e1 MDL-47924 mod_lti: Fixing missing sesskey checkings
Also fixing a missing capability checking.
2014-11-04 11:00:51 +13:00
Yuliya Bozhko d0053d29ed MDL-47190 Ensure badges cannot be awarded without a role
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
2014-11-04 10:16:45 +13:00
Frederic Massart eb46bf2f4e MDL-47321 iplookup: Prevent guest users from using iplookup 2014-11-04 10:01:43 +13:00
Adrian Greeve c4a6c65c1b MDL-47697 mod_data: Fix group id change when editing.
When a teacher edits an entry in the database module
it would change the group ID to the one that the teacher
currently had selected.

Thanks to Steve Bond for providing a patch.
2014-11-04 09:58:11 +13:00
Juan Leyva 40afeb4044 MDL-45303 Web Services: forum_discussions not checking groups 2014-11-03 21:55:03 +01:00
Juan Leyva a0095e5a89 MDL-47766 web services: get_grades exposes hidden grades to students 2014-11-04 09:13:46 +13:00
John Okely c844af2569 MDL-47921 mod_lti: Add access control to mod/lti/launch.php 2014-11-04 09:09:26 +13:00
Dave Cooper 40a0465823 MDL-47050 core_wordlist: Updated wordlist to include only animals. 2014-11-04 09:03:08 +13:00
Dan Poltawski 712b72c0f0 Merge branch 'MDL-47864_master' of git://github.com/dmonllao/moodle 2014-11-03 15:20:58 +00:00
Dan Poltawski 971163afaa Merge branch 'MDL-47810_master' of git://github.com/dmonllao/moodle 2014-11-03 15:03:51 +00:00
Dan Poltawski a46b057572 Merge branch 'MDL-47983_master' of git://github.com/dmonllao/moodle 2014-11-03 15:01:59 +00:00
Dan Poltawski 5904a6abe3 MDL-47361 tool_monitor: exit after printing footer 2014-11-03 14:21:50 +00:00
Dan Poltawski e3d86c322b Merge branch 'MDL-47361_master' of https://github.com/markn86/moodle
Conflicts:
	admin/tool/monitor/edit.php
	admin/tool/monitor/lang/en/tool_monitor.php
2014-11-03 13:55:31 +00:00
Dan Poltawski 1a27142afe Merge branch 'MDL-47903-master' of git://github.com/andrewnicols/moodle
Conflicts:
	mod/forum/version.php
    mod/forum/db/upgrade.php
2014-11-03 12:28:33 +00:00
Andrew Nicols a6d7a81271 MDL-48020 mod_forum: Add missing sesskey check in AJAX subscription 2014-11-03 11:02:41 +00:00
Marina Glancy 8bd6b270b2 Merge branch 'MDL-47987-master' of git://github.com/andrewnicols/moodle 2014-11-03 17:21:55 +08:00
Damyon Wiese ac87cab989 Merge branch 'MDL-48010' of git://github.com/timhunt/moodle 2014-11-03 17:15:25 +08:00
Petr Skoda 1993cc02b6 MDL-47287 prevent web access to phpunit boostrap 2014-11-03 17:10:33 +08:00
Marina Glancy d9fb78c981 Merge branch 'wip-mdl-45204-m' of git://github.com/rajeshtaneja/moodle 2014-11-03 17:03:57 +08:00
David Monllao 88f64b5111 MDL-47810 tool_monitor: action_link when there is only 1 option
When the rule plugin is not a module you can subscribe
to it without having to select to which module instance
you want to subscribe, so there is no need to display
a drop down menu.
2014-11-03 15:22:24 +08:00
Andreas Grabs b7f75a9c05 MDL-47865 mod_feedback - XSS through $searchstring in mod/feedback/mapcourse.php 2014-11-03 14:56:10 +08:00
Damyon Wiese c3a0452a5b MDL-47926 LTI: Fix missing sesskey checks and add content type headers to redirect 2014-11-03 14:43:54 +08:00
Damyon Wiese 219ebf9bb4 Merge branch 'wip-MDL-45538-master' of git://github.com/marinaglancy/moodle
Conflicts:
	version.php
2014-11-03 14:10:43 +08:00
Damyon Wiese f6b7d7322a Merge branch 'MDL-26447_master' of https://github.com/crazyserver/moodle 2014-11-03 13:50:38 +08:00
David Monllao 5cfaaf2d7a MDL-47983 tool_monitor: Removing only-for-admins restriction 2014-11-03 13:22:19 +08:00
Mark Nelson 8ad2de40b1 MDL-47361 tool_monitor: altered behat tests so they pass 2014-11-02 20:50:16 -08:00
Damyon Wiese 520a32c3d4 Merge branch 'wip_MDL-47966_m28_defaultheaders' of https://github.com/skodak/moodle 2014-11-03 12:20:58 +08:00
Damyon Wiese c942fddf93 MDL-48006 Atto autosave: Never restore text that is empty. 2014-11-03 11:30:30 +08:00
Mark Nelson 7293e97162 MDL-47361 tooL_monitor: string and UI changes 2014-11-02 19:05:29 -08:00
Sam Hemelryk cf03313342 Merge branch 'MDL-47465-master' of git://github.com/ankitagarwal/moodle 2014-11-03 15:30:08 +13:00
Ankit Agarwal c4e3e12884 MDL-47465 tool_monitor: Ignore used events
An event that has already contributed to a notification should not contribute to another notification for the same subscription.
This needs to be done so we do not overwhelm the user.
2014-11-03 07:18:13 +05:30
Ankit Agarwal 1af956998e MDL-47465 tool_monitor: add a new column to subs 2014-11-03 07:18:13 +05:30
Sam Hemelryk 1b5b97fac5 MDL-47917 cachestore_memcached: fixed get_many ordering 2014-11-03 14:08:25 +13:00
Sam Hemelryk 84d5a89c84 MDL-48026 usermenu: convert menu nowrap from CSS to method 2014-11-03 13:44:58 +13:00
Sam Hemelryk 8a375d27f2 MDL-48026 mod_quiz: convert menu nowrap from CSS to method 2014-11-03 13:35:29 +13:00
Sam Hemelryk a2a9468f01 MDL-48026 output: action_menu no wrap improvement
Action menu output component has a new method set_nowrap_on_items
that sets a property to toggle nowrap on menu items.
That can be used to avoid problems when the menu appears within
an absolutely positioned or floated element.
2014-11-03 13:34:02 +13:00
Sam Hemelryk ac4ed127de MDL-47978 mod_quiz: more explicit selector for action menu change 2014-11-03 11:39:30 +13:00
Sam Hemelryk 968cc37437 Merge branch 'MDL-47978' of git://github.com/timhunt/moodle 2014-11-03 11:27:55 +13:00
Sam Hemelryk f836166a8a MDL-48025 user: fixed typo in user_search HTML 2014-11-03 10:08:03 +13:00
Sam Hemelryk 70739e6e30 MDL-47969 mod_survey: fixed HTML5 validation of index.php 2014-11-03 08:55:12 +13:00
Sam Hemelryk e014b6f2c4 MDL-47968 mod_forum: fixed search form HTML5 validation 2014-11-03 08:54:56 +13:00
Eloy Lafuente (stronk7) bacbb4e279 MDL-47874 dml: add support for replace_all_text to oracle
And, at the same time, fix the implementation so all databases
will be using sql_substr() instead of harcoded "SUBSTRING".
2014-11-02 18:26:18 +01:00
Marina Glancy 41107173e4 MDL-46262 availability: validation of fields without value
Thanks to Tomasz Pawlik | CKO USl for the patch
2014-11-01 16:58:14 +08:00
Tim Hunt f9476f4d0e MDL-48010 grade import from URL: don't corrupt the URL. 2014-10-31 19:52:33 +00:00
Tim Hunt b4a40e451d MDL-48008 gradeimport_xml: report errors usefully 2014-10-31 19:52:31 +00:00
Tim Hunt 262105faf9 MDL-47978 quiz editing: fix display of last add menu 2014-10-31 18:23:45 +00:00
Eloy Lafuente (stronk7) 6863c0de49 Merge branch 'MDL-47892-master' of git://github.com/lameze/moodle 2014-10-31 18:57:30 +01:00
Tim Hunt 58413f613e MDL-47963 quiz editing: fix failing unit tests
The unit tests were initialising the structure class in a different way
from real use. That was clearly silly, so I got rid of create_for,
leaving just the real create_for_quiz.
2014-10-31 17:22:38 +00:00
Dan Poltawski 1de9b5072a Merge branch 'MDL-47797' of git://github.com/timhunt/moodle 2014-10-31 16:48:30 +00:00
Tim Hunt 234c5337f7 MDL-47797 quesion preview: improve the behat script
Tests a few more buttons, and also verify more of the UI.
2014-10-31 15:52:55 +00:00
Tim Hunt 40459677a0 MDL-47797 question preview: show more technical info
It is helpful for developers creating question types (at least) to be
able to see this.
2014-10-31 15:52:54 +00:00
Dan Poltawski b4eaafd744 Merge branch 'MDL-47963' of git://github.com/timhunt/moodle 2014-10-31 13:14:59 +00:00
David Mudrák fb1f2b9b27 MDL-47883 admin: Fix missing string in the plugin validation 2014-10-31 12:54:22 +01:00
Dan Poltawski 9ebee5df8e on-demand release 2.8beta+ 2014-10-31 09:09:03 +00:00
Mark Nelson eb0aabde73 MDL-47758 tool_monitor: altered behat tests so they pass 2014-10-31 01:16:10 -07:00
Mark Nelson c4701daa75 MDL-47758 tool_monitor: prevent DB error when revisiting a delete URL 2014-10-31 01:16:10 -07:00
Rajesh Taneja 54957bdbf7 MDL-45204 phpunit: Fixed test_localcachedir test
make_localcache_directory is the first call to make
localcache, which is already created by reset. So deleting
existing localcache directory will pass this test
2014-10-31 16:07:47 +08:00
Dave Cooper c7ef2c4c63 MDL-47982 gradebook: Remove tabindex from all elements. 2014-10-31 16:06:46 +08:00
Mark Nelson a724ceb99f MDL-47919 tool_monitor: only use set_label() on valid object 2014-10-31 00:56:47 -07:00
Marina Glancy 2e7eca137c MDL-47976 tool_monitor: fix ordering in unittest 2014-10-31 15:25:54 +08:00
Simey Lameze ed9084f70b MDL-47892 tool_monitor: add count_rule_subscriptions method and unit tests 2014-10-31 15:10:19 +08:00
Simey Lameze 107b55bd74 MDL-47892 tool_monitor: disable plugin and event fields if theres subscriptions for the rule 2014-10-31 14:41:24 +08:00
Damyon Wiese d61dc26e12 MDL-47981 Grade single view: Prevent nasty scroll jumping. 2014-10-31 14:07:58 +08:00
David Monllao 0151ef57f5 MDL-47864 tool_monitor: Change edulevels
Considering that the most common use case
to manage rules is an admin CRUDing them.
2014-10-31 14:01:31 +08:00
David Monllao f5d3d0f498 MDL-47864 grade_report: Edulevels according to default user permissions 2014-10-31 14:01:30 +08:00
Andrew Nicols 2a9f525bcf MDL-47390 mod_forum: Correct check for groups when subscribing 2014-10-31 08:54:02 +08:00
Sam Hemelryk 1a14f8a6de MDL-47959 mod_quiz: fixed 0 questions bug 2014-10-31 13:35:25 +13:00
Andrew Nicols 4c34089889 MDL-47987 mod_forum: Users subscribe to discussions not forums
Correct language string which describes users subscribing to a discussion,
and use it when subscribing on post.
2014-10-31 07:51:48 +08:00
Sam Hemelryk 323ed3bbf0 Merge branch 'MDL-47875_master' of https://github.com/crazyserver/moodle 2014-10-31 11:15:12 +13:00
pau.ferrer-ocana 5ea0d026b0 MDL-47875 choice: chat module strings not required from Choice anymore
AMOS BEGIN
 CPY [chatintro,mod_chat],[description,mod_choice]
AMOS END
2014-10-30 22:41:23 +01:00
Sam Hemelryk 3ea5ff8941 Merge branch 'MDL-42875_master' of https://github.com/crazyserver/moodle 2014-10-31 10:27:46 +13:00
Tim Hunt 749606288e MDL-47990 qtype_multichoice: fix test response import/export 2014-10-30 18:19:45 +00:00
Dan Poltawski fca969b9bb Merge branch 'MDL-47972' of git://github.com/timhunt/moodle 2014-10-30 17:31:12 +00:00
Colin Chambers 77dca4d0a8 MDL-47972 mod_quiz: Fix new quiz on themes based on base. 2014-10-30 17:11:23 +00:00
David Monllao f31d564133 MDL-47950 course: Adding sesskey confirmation when duplicating activities 2014-10-30 16:58:45 +00:00
Dan Poltawski 0a92904c47 MDL-47918 forum: Coding style fix 2014-10-30 16:46:46 +00:00
Tim Hunt 6870a6b8d0 MDL-47963 quiz editing: block ajax edits once there are attempts 2014-10-30 16:24:55 +00:00
Dan Poltawski ebbf039d07 Merge branch 'MDL-47746-master' of git://github.com/zbdd/moodle 2014-10-30 15:39:46 +00:00
Dan Poltawski 665611454d Merge branch 'MDL-47896-master' of git://github.com/zbdd/moodle 2014-10-30 15:15:28 +00:00
Dan Poltawski fb9604d67c Merge branch 'MDL-47918-master' of git://github.com/andrewnicols/moodle 2014-10-30 14:31:38 +00:00
Dan Poltawski f976c8e468 Merge branch 'MDL-47959' of git://github.com/colchambers/moodle 2014-10-30 14:24:35 +00:00
Marina Glancy 08674d83c1 Merge branch 'MDL-25057-master' of git://github.com/andrewnicols/moodle 2014-10-30 17:14:09 +08:00
pau.ferrer-ocana afa0968d5d MDL-26447 gradebook: Default gradedisplaytype fixed for all locales 2014-10-30 09:43:43 +01:00
Dan Poltawski fe5c340197 Merge branch 'wip-MDL-47919-master2' of https://github.com/marinaglancy/moodle 2014-10-30 08:30:43 +00:00
Marina Glancy 89da9fa67b Merge branch 'MDL-47569_CC_Errors' of git://github.com/moodlerooms/moodle 2014-10-30 16:15:51 +08:00
Marina Glancy 61138e352d Merge branch '47970-28' of git://github.com/samhemelryk/moodle 2014-10-30 16:15:38 +08:00
Marina Glancy 9e432c22cd Merge branch 'MDL-47909-master' of git://github.com/andrewnicols/moodle 2014-10-30 16:15:10 +08:00
David Monllao 57a69e7151 MDL-46500 mod_data: Removing duplicate filemanager initialisations 2014-10-30 16:10:15 +08:00
Marina Glancy f1d3d8ccb3 Merge branch 'MDL-47310-master' of git://github.com/jethac/moodle 2014-10-30 14:22:48 +08:00
Marina Glancy 3dc7afc186 Merge branch 'MDL-47349-master' of git://github.com/andrewnicols/moodle 2014-10-30 14:19:52 +08:00
Marina Glancy 2f28c71186 Merge branch 'MDL-29873' of git://github.com/jmvedrine/moodle 2014-10-30 14:17:32 +08:00
Ben Kelada 848e04183f MDL-46500 filepicker: prevent error when element does not exist 2014-10-30 14:14:15 +08:00
Marina Glancy 376d0317f1 MDL-47919 tool_monitor: refer to fields by labels in behat 2014-10-30 14:03:10 +08:00
Zachary Durber 7c5721f915 MDL-47746 gradebook: Visual bug fix for Scales in Singleview. 2014-10-30 14:00:44 +08:00
Andrew Nicols 02cf3958d2 MDL-47909 mod_forum: Respect user autosubscribe setting on post
Re-appropriate the forum autosubscribe setting as a discussion
autosubscribe setting.

The setting was no longer used after the per-discussion changes. The
original plan had been to remove this setting, but there is some benefit to
respecting it for discussion subscriptions instead.
2014-10-30 13:36:06 +08:00
Jetha Chan 43cd76e848 MDL-47310 gradebook: accessibility improvements 2014-10-30 13:28:15 +08:00
Zachary Durber 70d0de18d6 MDL-47896 gradebook: Fix for non-overridden grades. 2014-10-30 13:26:44 +08:00
Andrew Nicols 611a5ef714 MDL-25057 mod_forum: Stop duplicating forum_read posts from cron
This also includes an upgrade script to delete the existing duplicates.
2014-10-30 13:23:29 +08:00
David Monllao b2b70eea49 MDL-47207 mod_forum: Unifying criteria 2014-10-30 12:50:17 +08:00
Andrew Nicols a54702b234 MDL-47903 mod_forum: Correct test fails related to caching and time
This adds a reset of the discussion and forum cache when running the mail
and maildigest tests.

These test fails were highlighted by the addition of new tests which
add similar post ids.
2014-10-30 12:02:35 +08:00
Andrew Nicols eb451c7981 MDL-47903 mod_forum: Add discussion subscription time
This helps us to only send notifications for messages the user should have
already seen.
2014-10-30 12:02:34 +08:00
Rajesh Taneja b7ff40301d MDL-47960 behat: Fixed message node navigation
in i_send_message_to_user, we should use navigation node
step, as there might be multiple links with same name.
2014-10-30 10:56:56 +08:00
Dan Poltawski 490d009a57 MDL-47960 messages: behat failures caused by user menu 2014-10-30 10:56:17 +08:00
Dan Poltawski e0a1801e27 MDL-47960 badges: behat failures caused by usermenu 2014-10-30 10:56:16 +08:00
Dan Poltawski 6469803f68 MDL-47960 behat: fix my private files navigation
Caused by the my private files link being in user menu too..
2014-10-30 10:56:16 +08:00
Sam Hemelryk 0025296f19 MDL-47970 mod_scorm: fixed HTML5 validation error 2014-10-30 14:56:15 +13:00
Andrew Nicols 41e62a9093 MDL-47349 gradereport: Use category title on report 2014-10-30 09:53:36 +08:00
Andrew Nicols 4e3af3cf42 MDL-47390 mod_forum: Add discussion unsub to email footer 2014-10-30 09:07:36 +08:00
Petr Skoda 3c98b7a5ad MDL-47966 Add default content type and encoding 2014-10-30 11:38:07 +13:00
Colin Chambers 6375e98cbb MDL-47959 Number of questions not updated dynamically in new quiz edit page 2014-10-29 16:26:49 +00:00
Dan Poltawski 4f82670250 Merge branch 'wip_MDL-40949_m28_pathsettings' of https://github.com/skodak/moodle 2014-10-29 13:04:46 +00:00
Dan Poltawski 5d5e545fc7 Merge branch 'MDL-47945-master' of git://github.com/jethac/moodle 2014-10-29 12:56:03 +00:00
Dan Poltawski b373c35071 Merge branch 'wip-MDL-47919-master' of git://github.com/marinaglancy/moodle 2014-10-29 12:42:55 +00:00
Dan Poltawski 290bcd3476 MDL-47368 fix trailing whitespace 2014-10-29 11:20:29 +00:00
Dan Poltawski 0af29b0383 Merge branch 'MDL-47368' of git://github.com/timhunt/moodle 2014-10-29 11:18:15 +00:00
Michael Aherne 48242bf33f MDL-47793 assign: Reset reveal identities 2014-10-29 11:18:06 +00:00
pau.ferrer-ocana a09a837f20 MDL-42875 users: Show only profile visible roles on participants list 2014-10-29 11:24:19 +01:00
Julien Boulen 9b45b74e8f MDL-47584 database SQL: add debug info on connection error notices 2014-10-29 16:59:56 +08:00
Damyon Wiese 60c1108c30 Merge branch 'wip-MDL-47647-master' of git://github.com/abgreeve/moodle 2014-10-29 16:18:03 +08:00
Marina Glancy 72dbe74e7e Merge branch 'MDL-47916-master' of git://github.com/jleyva/moodle 2014-10-29 16:15:07 +08:00
Damyon Wiese 520bcbb9ab Merge branch 'MDL-47946-master' of git://github.com/andrewnicols/moodle 2014-10-29 15:53:17 +08:00
Damyon Wiese e562a1b25b Merge branch 'MDL-46219' of https://github.com/dkns/moodle 2014-10-29 15:37:47 +08:00
Damyon Wiese 7154f954c7 Merge branch 'MDL-47755_master' of https://github.com/totara/openbadges 2014-10-29 15:31:58 +08:00
Marina Glancy 941de29601 MDL-45538 files: restore missing records in draft areas 2014-10-29 15:26:54 +08:00
Damyon Wiese 3c459b6300 Merge branch 'wip-MDL-47796-master' of git://github.com/abgreeve/moodle 2014-10-29 15:15:14 +08:00
Damyon Wiese 412430c392 Merge branch 'MDL-47805-master' of git://github.com/ankitagarwal/moodle 2014-10-29 14:46:06 +08:00
Damyon Wiese cf63799155 Merge branch 'MDL-47227_master' of https://github.com/crazyserver/moodle 2014-10-29 14:44:08 +08:00
Damyon Wiese 857c7b4986 Merge branch 'MDL-47201-master' of git://github.com/xow/moodle 2014-10-29 14:24:28 +08:00
Adrian Greeve 7e7715fb6b MDL-47796 mod_data: Fix display of group records.
When viewing entries as a teacher in separate group
mode, changing the group would result in random
entries being shown.
2014-10-29 13:52:29 +08:00
Jetha Chan 8744529ff6 MDL-47945 mod_forum: neighbour links at bottom of discussion 2014-10-29 13:46:46 +08:00
Damyon Wiese cf13ece570 Merge branch 'MDL-47898-master' of git://github.com/andrewnicols/moodle 2014-10-29 13:36:17 +08:00
Damyon Wiese e30a684a4b Merge branch 'master_MDL-33939' of https://github.com/danmarsden/moodle 2014-10-29 13:23:28 +08:00
Damyon Wiese 5bfca73e5d Merge branch 'wip-MDL-46517-master' of git://github.com/marinaglancy/moodle 2014-10-29 13:01:35 +08:00
Damyon Wiese d7c1945472 Merge branch 'wip-MDL-40343-master' of git://github.com/ds125v/moodle
Conflicts:
	mod/forum/styles.css
2014-10-29 12:53:21 +08:00
Andrea Bicciolo 087be6ca90 MDL-47201 Reports: Read from multiple log stores in outline report 2014-10-29 12:49:12 +08:00
Andrew Nicols 8271c89a94 MDL-47946 mod_forum: Correct strings in behat features
These are a regression from MDL-46215.
2014-10-29 12:01:41 +08:00
Andrew Nicols 0d7cb0f805 MDL-47930 mod_forum: Display all forum statuses correctly
It is possible for users with the mod/forum:managesubscriptions to
subscribe to forums with subscription disabled. This is handled by
forum_get_subscribe_link() already and should have been handled here all
along.
2014-10-29 11:52:54 +08:00
Damyon Wiese d9033c0e6d Merge branch 'MDL-47835_master' of git://github.com/dmonllao/moodle 2014-10-29 11:19:46 +08:00
David Monllao 3c26a30799 MDL-47835 block_recent_activity: Same entry keys order
insert_records() is sensitive to the order of the keys
assigned to the inserted objects (inserted as arrays in
this case). Now keys are assigned using the same order.
2014-10-29 10:54:11 +08:00
Marina Glancy a0ef87de1f MDL-46517 calendar: adjust display for DST
Thanks to Jo Matthews for providing a patch
2014-10-29 10:31:28 +08:00
Corey Wallis 91465b5095 MDL-46517 calendar: adjust dates for DST
Change-Id: I269382031e4ffa714396f3d9ce2315a5c96d929c
2014-10-29 10:31:28 +08:00
Damyon Wiese 4d0fe0ec94 Merge branch 'wip-MDL-36987-master' of git://github.com/marinaglancy/moodle 2014-10-29 10:20:47 +08:00
Petr Skoda 5aaac8b2d6 MDL-40949 admin: Fix $CFG->preventexecpath hints
This setting restricts all local paths, not just
executables.
2014-10-29 10:45:44 +13:00
Tim Hunt e3d3e1e652 MDL-47368 quiz editing: fix icon url generation. 2014-10-28 18:45:17 +00:00
Dan Poltawski 32a69a7d7a on-demand release 2.8beta+ 2014-10-28 12:32:50 +00:00
Dan Poltawski 3f80a7edce Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2014-10-28 12:32:48 +00:00
Dan Poltawski ac3d43b6ec Merge branch 'MDL-47877-master' of git://github.com/andrewnicols/moodle 2014-10-28 12:25:27 +00:00
Dan Poltawski 08f289c617 MDL-47703 fix trailing whitespace 2014-10-28 12:21:30 +00:00
Dan Poltawski 31d6d2ae41 Merge branch 'MDL-47703-master' of git://github.com/FMCorz/moodle 2014-10-28 11:40:27 +00:00
Tim Hunt 08ab7a3c10 MDL-47368 core JS: dragdrop click move fills the dom with divs
Every time you click the move icon, it builds a new dialogue with a list
of drop targets, but it never discards the old ones. Not only does this
fill the DOM with junk, but it also causes Behat tests to fail, since
the old dialogues come first, and are hidden, but contain links with the
same text that you are trying to click.
2014-10-28 11:32:44 +00:00
Colin Chambers a69f81f0d3 MDL-47368 Edit quiz: page should not reload so often
The approach is that we have a new JavaScript function
M.mod_quiz.resource_toolbox.reorganise_edit_page which, after a ajax
action, fixes up everything like page breaks, page and question numbers,
that might now be wrong.

We call that function instead of reloading the page.

Also, there are a lot more Behat tests to verify this works correctly.

AMOS BEGIN
 MOV [joinpages,mod_quiz],[removepagebreak,mod_quiz]
 MOV [splitpages,mod_quiz],[addpagebreak,mod_quiz]
AMOS END
2014-10-28 11:32:42 +00:00
Marina Glancy b5478757c6 Merge branch 'MDL-47889-master' of git://github.com/FMCorz/moodle 2014-10-28 17:55:06 +08:00
Marina Glancy 001652d743 Merge branch 'wip-mdl-47850-m' of git://github.com/rajeshtaneja/moodle 2014-10-28 17:26:57 +08:00
Marina Glancy cc37a58d06 MDL-47919 tool_monitor: adjustments to behat tests 2014-10-28 17:17:00 +08:00
Andrew Nicols 7545e84661 MDL-47877 mod_forum: Correct subscription options for forums
Test was the wrong way around when checking subscription state.
2014-10-28 15:57:12 +08:00
Marina Glancy 45b7a397bb Merge branch 'MDL-46215-master-fixes' of git://github.com/andrewnicols/moodle 2014-10-28 15:37:05 +08:00
Pau Ferrer Ocaña 912296ad30 MDL-47227 admin: Fix user bulk selection over 1000 2014-10-28 08:34:01 +01:00
Andrew Nicols 79b4fb1282 MDL-46215 mod_forum: Only add text on discussion view
Do not show the status text in the thread list.
2014-10-28 14:27:05 +08:00
Frederic Massart d9e879e5d1 MDL-47889 tool_monitor: Test handles random DB ordering
On Oracle, the subscriptions are not ordered in the same way
than in other DB engines, so we do not rely on that ordering
any more in the test.
2014-10-28 13:52:45 +08:00
Andrew Nicols 1d8e8494bf MDL-47918 mod_forum: Unsubscribe all - remove discussion subscriptions 2014-10-28 13:29:51 +08:00
Rajesh Taneja b159589d9b MDL-47850 message_airnotifier: Fixed airnotifier web service url 2014-10-28 13:24:03 +08:00
Sam Hemelryk db310f7737 Merge branch 'MDL-47870-master2' of git://github.com/ankitagarwal/moodle 2014-10-28 17:27:09 +13:00
Marina Glancy 7d79115f3d Merge branch '47914-28' of git://github.com/samhemelryk/moodle 2014-10-28 12:23:33 +08:00
Marina Glancy f173ae2014 Merge branch 'MDL-814-master' of git://github.com/danpoltawski/moodle 2014-10-28 12:23:23 +08:00
Ankit Agarwal d71e42d7e8 MDL-47870 tool_monitor: Fix event select dropdown 2014-10-28 09:49:08 +05:30
Damyon Wiese c5258dfa04 MDL-47559 User menu: version bump for new settings 2014-10-28 11:06:40 +08:00
Sam Hemelryk 45ad1693cd MDL-47183 post-integration fixes
* Fixed typo with context_module::instance
* Fixed use of $mod->get_context()
2014-10-28 15:59:59 +13:00
Damyon Wiese 5baf74a327 Merge branch 'MDL-47559-master' of git://github.com/jethac/moodle 2014-10-28 09:59:04 +08:00
Sam Hemelryk 77b31ba2ce Merge branch 'MDL-47183-master' of git://github.com/andrewnicols/moodle 2014-10-28 14:02:19 +13:00
Sam Hemelryk fc8977fbca MDL-47914 report_stats: better handling of user and mode 2014-10-28 11:52:41 +13:00
Juan Leyva f47eeafdfd MDL-47916 web services: Fixed invalid returned value type 2014-10-27 23:14:13 +01:00
Marina Glancy 960bb64a2e MDL-47585 stats: fixed incorrect user dropdown 2014-10-28 10:51:02 +13:00
Ray Morris 9f56cc3794 MDL-47902 mod_scorm: Inappropriate default values for SCORM 1.3 variables 2014-10-27 15:06:42 -05:00
Dan Poltawski f3206dfc36 MDL-814 forum: provide cancel button when posting
This is the way to clear atto drafts
2014-10-27 16:44:47 +00:00
AMOS bot 86bd173927 Automatically generated installer lang files 2014-10-28 00:05:34 +08:00
Dan Poltawski b5780fbd18 Merge branch 'MDL-46215-master' of git://github.com/andrewnicols/moodle 2014-10-27 14:51:04 +00:00
Jetha Chan b865a3e2d1 MDL-47559 user_menu: customusermenu setting 2014-10-27 20:04:45 +08:00
Andrew Nicols d5653c6968 MDL-47898 mod_quiz: Correct path when checking content_editable
Addresses a number of issues when using the text editor in a quiz using
secure mode.
2014-10-27 19:23:56 +08:00
Adrian Greeve afc3431413 MDL-47647 lib: Fix message unit test failure.
Messaging unit tests on Windows were failing because
of a comparison between two file paths. Part of the
path would have a forward slash instead of a backslash
and so would fail.
2014-10-27 16:35:06 +08:00
Dan Poltawski 7c636855e2 Merge branch 'MDL-47839-master' of git://github.com/FMCorz/moodle 2014-10-27 08:01:33 +00:00
Frederic Massart f2823ec4bc MDL-47839 core_grades: Minor styling improvements to setup/user report 2014-10-27 15:59:21 +08:00
Dan Poltawski 77733e6b89 Merge branch 'wip-mdl-47676-m' of https://github.com/rajeshtaneja/moodle 2014-10-27 07:47:07 +00:00
Dan Poltawski a1ac634692 Merge branch 'MDL-47734-master-fixes' of git://github.com/andrewnicols/moodle 2014-10-27 07:40:06 +00:00
Rajesh Taneja d6040f0366 MDL-47676 core_grades: reset is hidden in menu, using proper step 2014-10-27 15:21:11 +08:00
Damyon Wiese 837862579e Merge branch 'm28_MDL-47210_IIS_PATH_INFO_Ignored_In_Required_Login_Pluginfile_Redirect' of https://github.com/scara/moodle 2014-10-27 13:58:15 +08:00
Frederic Massart 37fc69a019 MDL-47703 core_grades: Behat test for (non) aggregated scales 2014-10-27 13:00:58 +08:00
Andrew Nicols 517e17826b MDL-46215 mod_forum: Improve style of subscription state
With the implementation of per-discussion subscription, the current
discussion's subscription state must be shown.

Since this state belongs to the discussion rather than the forum, it
should be shown accordingly.  This change therefore includes the addition
of the discussion name as a heading on the page.
2014-10-27 12:37:05 +08:00
Dave Cooper d7f9acc46a MDL-47833 core: Change default expiry for message inbound handlers 2014-10-27 11:53:33 +08:00
Marina Glancy f2bec5d9ba Merge branch 'MDL-47850-master' of git://github.com/jleyva/moodle 2014-10-27 11:52:35 +08:00
Marina Glancy a8668e161a Merge branch 'MDL-47882_scorm_loadsco_invalid_html' of git://github.com/MorrisR2/moodle 2014-10-27 11:52:18 +08:00
Damyon Wiese ae0711d861 MDL-47690 Course: Remove unused variable from unit tests. 2014-10-27 11:26:35 +08:00
Frederic Massart 8b5c454562 MDL-47703 core_grades: Prevent use of weights with non-aggregated scales 2014-10-27 11:23:54 +08:00
Andrew Nicols 2af57bdbc5 MDL-47734 core: Do not set scrolltop on fixed dialogues
Fixed position dialogues use a different xy positioning than standard
dialogues so cannot use the scrollTop positioning method.
2014-10-27 11:22:30 +08:00
Damyon Wiese d2dbc373f8 Merge branch 'MDL-47690-master' of git://github.com/jleyva/moodle 2014-10-27 11:11:53 +08:00
Damyon Wiese 2b97417296 Merge branch 'wip-MDL-30358-master' of git://github.com/marinaglancy/moodle 2014-10-27 10:30:44 +08:00
Matteo Scaramuccia ce1cc198bb MDL-47210 Files API: IIS, PATH_INFO ignored in required login redirect. 2014-10-26 08:03:27 +01:00
Ray Morris a53bf3a031 MDL-47882 SCORM: invalid HTML in loadSCO.php 2014-10-24 16:45:32 -05:00
Dan Poltawski 42b6b39136 Merge branch 'MDL-46088-master' of git://github.com/timhunt/moodle 2014-10-24 17:10:56 +01:00
Dan Poltawski 8d1c5eceb3 Merge branch 'MDL-47545-master' of git://github.com/jleyva/moodle 2014-10-24 16:40:06 +01:00
Juan Leyva 3ca3d259e5 MDL-47545 web services: Allow cross origin requests for file downloads 2014-10-24 17:10:44 +02:00
Dan Poltawski cb1bc5eb6b Merge branch 'MDL-46712-master' of git://github.com/jethac/moodle 2014-10-24 15:37:26 +01:00
Dan Poltawski f6dbc2bb9c Merge branch 'MDL-47782-master' of git://github.com/lameze/moodle
Conflicts:
	admin/tool/monitor/lang/en/tool_monitor.php
2014-10-24 15:25:42 +01:00
Dan Poltawski 22ef599c5d Merge branch 'MDL-47780_master' of https://github.com/markn86/moodle 2014-10-24 15:19:48 +01:00
Dan Poltawski 519fd3dd4c Merge branch 'wip-MDL-47760-master' of git://github.com/marinaglancy/moodle 2014-10-24 15:18:32 +01:00
Dan Poltawski d6eff32be0 Merge branch '46518-28' of git://github.com/samhemelryk/moodle 2014-10-24 15:16:55 +01:00
Dan Poltawski 0b03353433 Merge branch 'MDL-47804' of git://github.com/aolley/moodle 2014-10-24 15:14:53 +01:00
Dan Poltawski 7638a4366f Merge branch '47608-28' of git://github.com/samhemelryk/moodle 2014-10-24 15:12:59 +01:00
Frederic Massart 20942dd702 MDL-47397 assignfeedback_editpdf: Copy stamps to other students in team
During a team submission the stamps were attached to the user that
was graded and not to the other users. This could lead to errors when
generating the PDF for each user.
2014-10-24 15:09:06 +01:00
Frederic Massart 47ff1cd93b MDL-47397 assignfeedback_editpdf: Tests use reliable way to annotate PDF
The drag and drop step did not work, so we moved to using the stamps
to annotate the PDF. They do not rely on drag&drop and produce the same
effects.
2014-10-24 15:09:06 +01:00
Frederic Massart aad194b19a MDL-47397 editor_atto: Properly close confirm dialogue in Behat test 2014-10-24 15:09:06 +01:00
Dan Poltawski e29ec53238 Merge branch 'MDL-47778_master' of https://github.com/markn86/moodle 2014-10-24 14:53:21 +01:00
Andrew Nicols 71bc139d63 MDL-47802 mod_forum: Check for required subscription capabilities
Users must be able to both view, and manage their subscription in order to
subscribe or be subscribed to a discussion.
2014-10-24 14:44:21 +01:00
Andrew Nicols 0603df04da MDL-47802 mod_forum: Include discussion subscriptions when moving
Check for both forum, and discussion subscriptions when moving a discussion
to a different forum.
2014-10-24 14:44:21 +01:00
Zachary Durber 5b2571547f MDL-47873 gradebook: Fix for missing override checkboxes. 2014-10-24 14:39:20 +01:00
Dan Poltawski 6c6375e438 Merge branch 'MDL-47866-master' of git://github.com/andrewnicols/moodle
Conflicts:
	version.php
2014-10-24 14:34:09 +01:00
Dan Poltawski 7dc62ed3cb Merge branch 'wip-MDL-47676-master' of git://github.com/abgreeve/moodle 2014-10-24 14:30:44 +01:00
Dan Poltawski 1429a25cd8 Merge branch 'MDL-47734-master' of git://github.com/andrewnicols/moodle 2014-10-24 14:13:59 +01:00
Dan Poltawski d63a81c507 on-demand release 2.8beta+ 2014-10-24 11:15:32 +01:00
Damyon Wiese 4bb46504ee Merge branch 'wip-MDL-47542-master' of git://github.com/marinaglancy/moodle 2014-10-24 11:49:19 +02:00
Marina Glancy 079b2e5202 MDL-47542 core_grades: action menu for grade setup 2014-10-24 11:49:19 +02:00
Marina Glancy 4ea3258af9 Merge branch 'MDL-47813-master' of git://github.com/xow/moodle 2014-10-24 11:49:18 +02:00
John Okely 4809376f13 MDL-47813 tool_monitor: Fix rule manager unit tests in oracle 2014-10-24 11:49:18 +02:00
Damyon Wiese 996de187a5 MDL-47704 Grades: Behat fix - dropped items have no contribution
We see "-" instead of "0.00 %"
2014-10-24 11:49:17 +02:00
Damyon Wiese d8e98c3178 Merge branch 'MDL-47637-master-fixup' of https://github.com/FMCorz/moodle 2014-10-24 11:49:17 +02:00
Marina Glancy 681276aad2 Merge branch 'MDL-47838-master-fix3' of https://github.com/damyon/moodle 2014-10-24 11:49:16 +02:00
Frederic Massart 2eb60f110d MDL-47637 core_grades: Remove extra credit field in outcome test 2014-10-24 11:49:16 +02:00
Andrew Nicols 504d0a1821 MDL-47513 theme_base: Fix grader report when blocks are docked 2014-10-24 11:49:15 +02:00
Damyon Wiese 0ce4642864 MDL-47838 gradereport_singleview: Reuse get_element_header instead of rolling our own.
This means the grade.php / index.php is kept in one place.
2014-10-24 11:49:15 +02:00
Marina Glancy c785cc9893 Merge branch 'MDL-47340-master' of git://github.com/jethac/moodle 2014-10-24 11:49:11 +02:00
Damyon Wiese d700fa463e Merge branch 'MDL-47838-master' of git://github.com/zbdd/moodle 2014-10-24 11:48:25 +02:00
Damyon Wiese 0b9635cba4 Merge branch '46499-28' of git://github.com/samhemelryk/moodle 2014-10-24 11:48:24 +02:00
Zachary Durber 237f76ce14 MDL-47838 gradebook: Singleview fix for invalid links. 2014-10-24 11:48:24 +02:00
Sam Hemelryk fad1a02d21 MDL-46332 fixed whitespace 2014-10-24 11:48:23 +02:00
Sam Hemelryk a1428d4be6 Merge branch 'MDL-46332-grouping-remove-button-master' of git://github.com/DanBennettUK/moodle 2014-10-24 11:48:23 +02:00
Sam Hemelryk 065448834c Merge branch 'wip-MDL-47757-master' of git://github.com/abgreeve/moodle 2014-10-24 11:48:22 +02:00
Sam Hemelryk fc91acc813 Merge branch 'MDL-47738-master' of git://github.com/FMCorz/moodle 2014-10-24 11:48:22 +02:00
Sam Hemelryk 614820522f Merge branch 'm28_MDL-47632' of https://github.com/totara/moodle 2014-10-24 11:48:21 +02:00
Sam Hemelryk 7117571c34 Merge branch 'MDL-47555' of https://github.com/rlorenzo/moodle 2014-10-24 11:48:21 +02:00
Sam Hemelryk 1e97569713 Merge branch 'wip_MDL-47795_master' of git://github.com/gjb2048/moodle 2014-10-24 11:48:20 +02:00
gdharris ee19ae694a MDL-46853 calendar: fix import of no duration events 2014-10-24 11:48:20 +02:00
Dan Poltawski 0255780b9c Merge branch 'MDL-47791' of git://github.com/timhunt/moodle 2014-10-24 11:48:19 +02:00
Dan Poltawski a5f9fc6be3 Merge branch 'MDL-47815-master' of git://github.com/damyon/moodle 2014-10-24 11:48:19 +02:00
Damyon Wiese 8112670d62 MDL-47815 assign: Fix random unit test fails
This test was failing when it was run really slowly (looking at you oracle).
2014-10-24 11:48:18 +02:00
Dan Poltawski ad968a36d6 Merge branch 'MDL-47847-master' of git://github.com/jleyva/moodle 2014-10-24 11:48:17 +02:00
Juan Leyva 938728739b MDL-47847 Web Services: Add messaging functions to the mobile service 2014-10-24 11:48:17 +02:00
Dan Poltawski 0ca7a4b75b Merge branch '47752-28' of git://github.com/samhemelryk/moodle 2014-10-24 11:48:16 +02:00
Dan Poltawski 3456ac3ba0 Merge branch '47684-28' of git://github.com/samhemelryk/moodle 2014-10-24 11:48:16 +02:00
Dan Poltawski 276af2a44d Merge branch 'MDL-47513-master' of git://github.com/andrewnicols/moodle 2014-10-24 11:48:15 +02:00
Dan Poltawski f335c9a1f1 Merge branch 'MDL-47637-master' of git://github.com/FMCorz/moodle 2014-10-24 11:48:15 +02:00
Dan Poltawski 4ade5b11b2 Merge branch 'MDL-47814-master' of git://github.com/FMCorz/moodle 2014-10-24 11:48:14 +02:00
Frederic Massart 3e5a4c9047 MDL-47814 core_grades: Improved coverage of user_graded event tests
The tests needed to use the API in order to trigger the user_graded
event that occurs when the course final grade has changed.
2014-10-24 11:48:14 +02:00
Dan Poltawski 4fdd69373b Merge branch 'MDL-47767-master' of git://github.com/xow/moodle 2014-10-24 11:48:13 +02:00
John Okely 6a6dd57c90 MDL-47767 tool_monitor: Use renderers for links between subscription and rule managers 2014-10-24 11:48:13 +02:00
Dan Poltawski fc533908b0 Merge branch 'MDL-20367-master' of git://github.com/damyon/moodle 2014-10-24 11:48:12 +02:00
John Okely 220602b7f0 MDL-47767 tool_monitor: Add links between subscribe and rule manager 2014-10-24 11:48:12 +02:00
Dan Poltawski 1153177851 Merge branch 'MDL-47499-master' of git://github.com/damyon/moodle 2014-10-24 11:48:11 +02:00
Marina Glancy 2a9bc5909d Merge branch 'MDL-47808-master' of git://github.com/andrewnicols/moodle 2014-10-24 11:48:11 +02:00
Marina Glancy bb030ebc2a Merge branch 'MDL-47689-master' of git://github.com/gurgus/moodle 2014-10-24 11:48:10 +02:00
Dave Cooper 368f0bf8f6 MDL-47689 user: Add duplicate field check to avoid oracle db error. 2014-10-24 11:48:10 +02:00
Marina Glancy c3b545a92a Merge branch 'wip-MDL-47675-master' of git://github.com/abgreeve/moodle 2014-10-24 11:48:09 +02:00
Marina Glancy 13c9e9c043 Merge branch 'MDL-47759-master' of git://github.com/ankitagarwal/moodle 2014-10-24 11:48:08 +02:00
Damyon Wiese 578d905ec0 Merge branch '47077-28' of git://github.com/samhemelryk/moodle 2014-10-24 11:48:08 +02:00
Frederic Massart 5dd0cb7bce MDL-47762 gradereport_user: Hide contribution and weights when relevant
The contribution and weight columns should be hidden when the course
total is because they can be used to compute the hidden course total.
2014-10-24 11:48:07 +02:00
Damyon Wiese 444ff60526 Merge branch 'MDL-47153_master' of https://github.com/markn86/moodle 2014-10-24 11:48:07 +02:00
Marina Glancy 3824556c9a Merge branch 'MDL-47704-master' of git://github.com/damyon/moodle 2014-10-24 11:48:06 +02:00
Marina Glancy 65504187d8 Merge branch 'MDL-47763-master' of git://github.com/damyon/moodle 2014-10-24 11:48:06 +02:00
Damyon Wiese 2c89eeeb8e Merge branch 'wip-MDL-43245-master-lang' of git://github.com/abgreeve/moodle 2014-10-24 11:48:05 +02:00
Damyon Wiese edffadfd1c MDL-47763 Grades: Handle the case when a grade category is hidden.
This was breaking the contribution column, which needs to know the
weights of all the categories up the tree, whether they are visible or
not.
2014-10-24 11:48:05 +02:00
Marina Glancy 1e3dc6ed9c Merge branch 'MDL-47836-master' of git://github.com/damyon/moodle 2014-10-24 11:48:04 +02:00
Adrian Greeve 780ff300a8 MDL-43245 mod_lesson: Add string for essay grading permission. 2014-10-24 11:48:04 +02:00
Marina Glancy b7840d4783 Merge branch 'MDL-47819-master' of git://github.com/jethac/moodle 2014-10-24 11:48:03 +02:00
Damyon Wiese f01972d95e MDL-47836 Grades: Fix the url for the upgraded grades warning page url. 2014-10-24 11:48:03 +02:00
Dan Poltawski ea4361b3a5 Merge branch 'MDL-47713-master-fix1' of http://github.com/damyon/moodle 2014-10-24 11:48:02 +02:00
Jetha Chan edcca18f8d MDL-47819 user_menu: fixed showing up in popups 2014-10-24 11:48:02 +02:00
Damyon Wiese bdb319a5b1 Merge branch 'MDL-47740' of git://github.com/timhunt/moodle 2014-10-24 11:48:01 +02:00
Damyon Wiese a7c37934cc MDL-47713 Grades: Fix new behat test after conversion from points to %
The contribution to course total column was changed from points to % but
this new test was submitted using points. It just needs the numbers converted
to %.
2014-10-24 11:48:01 +02:00
Damyon Wiese 721c6d397c Merge branch 'MDL-43245' of git://github.com/jmvedrine/moodle 2014-10-24 11:48:00 +02:00
Jean-Michel Vedrine 5fc6a9e77b MDL-43245 Lesson: non editing teacher cannot grade lesson essay 2014-10-24 11:48:00 +02:00
Dan Poltawski 7a811fb63a Merge branch 'MDL-47713-master' of git://github.com/damyon/moodle 2014-10-24 11:47:59 +02:00
Damyon Wiese 96ef037856 Merge branch 'MDL-32616' of git://github.com/timhunt/moodle 2014-10-24 11:47:59 +02:00
Eloy Lafuente (stronk7) e739fbcf27 Merge branch 'wip-MDL-47812-master2' of git://github.com/marinaglancy/moodle 2014-10-24 11:05:54 +02:00
Juan Leyva a7b572e29d MDL-47850 message_airnotifier: Incorrect Airnotifier Web Service URL 2014-10-24 10:40:06 +02:00
Juan Leyva e13c152e82 MDL-47690 web services: Fixed invalid return parameter type in mod_url 2014-10-24 09:54:35 +02:00
Simey Lameze 7bd88b0039 MDL-47782 tool_monitor: Added context column on rule management page.
AMOS BEGIN
CPY [context,message],[context,tool_monitor]
AMOS END
2014-10-24 15:41:45 +08:00
Marina Glancy d4a9e66130 MDL-47812 mod_lti: execute upgrade script for all DBs 2014-10-24 14:00:30 +08:00
Ankit Agarwal a8ea7cccce MDL-47805 tool_monitor: More info in adhoc task 2014-10-24 11:24:53 +05:30
Adam Olley 4ac478a3ed MDL-47804 events: calendar_event_updated needs to accept a timestart == 0 2014-10-24 15:34:30 +10:30
Andrew Nicols 107e82f6a6 MDL-47866 gradereport_grader: Remove border radius from cells 2014-10-24 11:54:56 +08:00
Mark Nelson 5e83b20527 MDL-47778 tool_monitor: changes made to get_user_courses_select()
The changes -

1) Ensure courses exist before we loop to avoid PHP warning.
2) Checked that the number of courses to display do not exceed the max setting.
3) Used format_string() instead of format_text().
4) Used the course context instead of system context.
2014-10-23 20:20:41 -07:00
Sam Hemelryk 00b568bd09 MDL-46332 fixed whitespace 2014-10-24 14:34:36 +13:00
Adrian Greeve 65e274d76f MDL-47676 core_grades: Behat test for negative weights. 2014-10-24 08:43:16 +08:00
Adrian Greeve cd5c7965e0 MDL-47676 core_grades: Negative positive weight combo working.
The combination of negative and positive weights was not normalising
properly.
2014-10-24 08:43:16 +08:00
Sam Hemelryk 68085f2bd5 Merge branch 'MDL-46332-grouping-remove-button-master' of git://github.com/DanBennettUK/moodle 2014-10-24 12:02:14 +13:00
Sam Hemelryk 29a3060265 Merge branch 'wip-MDL-47757-master' of git://github.com/abgreeve/moodle 2014-10-24 11:58:36 +13:00
Sam Hemelryk 124932d223 Merge branch 'MDL-47738-master' of git://github.com/FMCorz/moodle 2014-10-24 11:23:04 +13:00
Sam Hemelryk ef54717024 Merge branch 'm28_MDL-47632' of https://github.com/totara/moodle 2014-10-24 11:19:43 +13:00
Sam Hemelryk ec998f7487 Merge branch 'MDL-47555' of https://github.com/rlorenzo/moodle 2014-10-24 11:17:00 +13:00
Sam Hemelryk 18f1797517 Merge branch 'wip_MDL-47795_master' of git://github.com/gjb2048/moodle 2014-10-24 09:58:53 +13:00
gdharris 04f7dcebe4 MDL-46853 calendar: fix import of no duration events 2014-10-24 09:55:11 +13:00
Dan Poltawski 89df18c73d Merge branch 'MDL-47791' of git://github.com/timhunt/moodle 2014-10-23 17:30:28 +01:00
Dan Poltawski f01242a3b4 Merge branch 'MDL-47815-master' of git://github.com/damyon/moodle 2014-10-23 17:28:36 +01:00
Dan Poltawski a92008ed25 Merge branch 'MDL-47847-master' of git://github.com/jleyva/moodle 2014-10-23 16:35:50 +01:00
Dan Poltawski aed3a3430f Merge branch '47752-28' of git://github.com/samhemelryk/moodle 2014-10-23 16:31:24 +01:00
Dan Poltawski 9a3385cb2d Merge branch '47684-28' of git://github.com/samhemelryk/moodle 2014-10-23 16:31:08 +01:00
Dan Poltawski 25bd390b4b Merge branch 'MDL-47513-master' of git://github.com/andrewnicols/moodle 2014-10-23 16:17:49 +01:00
Dan Poltawski 7b57a751ae Merge branch 'MDL-47637-master' of git://github.com/FMCorz/moodle 2014-10-23 16:16:07 +01:00
Dan Poltawski 98122f9ad4 Merge branch 'MDL-47814-master' of git://github.com/FMCorz/moodle 2014-10-23 16:13:11 +01:00
Juan Leyva 0c5481e43d MDL-47847 Web Services: Add messaging functions to the mobile service 2014-10-23 15:24:07 +02:00
Dan Poltawski cd9f037e04 Merge branch 'MDL-47767-master' of git://github.com/xow/moodle 2014-10-23 10:50:01 +01:00
Dan Poltawski 7ea782ab3c Merge branch 'MDL-20367-master' of git://github.com/damyon/moodle 2014-10-23 10:41:58 +01:00
Dan Poltawski ec007900c0 Merge branch 'MDL-47499-master' of git://github.com/damyon/moodle 2014-10-23 10:19:53 +01:00
Juan Leyva 5e28991e78 MDL-47545 web services: Allow cross origin requests 2014-10-23 11:17:41 +02:00
Marina Glancy 36594faebb Merge branch 'MDL-47808-master' of git://github.com/andrewnicols/moodle 2014-10-23 17:16:44 +08:00
Marina Glancy aeeccb1697 Merge branch 'MDL-47689-master' of git://github.com/gurgus/moodle 2014-10-23 17:09:32 +08:00
Marina Glancy d129a0ffe9 Merge branch 'wip-MDL-47675-master' of git://github.com/abgreeve/moodle 2014-10-23 16:57:56 +08:00
Marina Glancy d3312bb6ac Merge branch 'MDL-47759-master' of git://github.com/ankitagarwal/moodle 2014-10-23 16:35:59 +08:00
Damyon Wiese 99cc87e913 Merge branch '47077-28' of git://github.com/samhemelryk/moodle 2014-10-23 16:09:29 +08:00
Frederic Massart 67ba66e1d2 MDL-47762 gradereport_user: Hide contribution and weights when relevant
The contribution and weight columns should be hidden when the course
total is because they can be used to compute the hidden course total.
2014-10-23 16:04:11 +08:00
Damyon Wiese 2fd07711e9 Merge branch 'MDL-47153_master' of https://github.com/markn86/moodle 2014-10-23 15:47:10 +08:00
Marina Glancy 05599c47cb Merge branch 'MDL-47704-master' of git://github.com/damyon/moodle 2014-10-23 15:45:54 +08:00
Marina Glancy 41d58f6f4c Merge branch 'MDL-47763-master' of git://github.com/damyon/moodle 2014-10-23 15:42:46 +08:00
Damyon Wiese 3a3fe4bf37 Merge branch 'wip-MDL-43245-master-lang' of git://github.com/abgreeve/moodle 2014-10-23 15:38:35 +08:00
Marina Glancy 653f6c23cb Merge branch 'MDL-47836-master' of git://github.com/damyon/moodle 2014-10-23 15:23:52 +08:00
Marina Glancy 18ebeed5e9 Merge branch 'MDL-47819-master' of git://github.com/jethac/moodle 2014-10-23 15:21:28 +08:00
Dan Poltawski bcd015bea6 Merge branch 'MDL-47713-master-fix1' of http://github.com/damyon/moodle 2014-10-23 08:18:31 +01:00
Dave Cooper 17472f57b9 MDL-47689 user: Add duplicate field check to avoid oracle db error. 2014-10-23 15:10:31 +08:00
Adrian Greeve 1785e49f26 MDL-43245 mod_lesson: Add string for essay grading permission. 2014-10-23 15:05:32 +08:00
Andrew Nicols d247a50113 MDL-47734 core: Prevent jumping of YUI dialogues
When a YUI dialogue was opened, it was focusing on the boundingBox, with
the browser moving the scroll position to focus on the top of the
boundingBox. This caused a jump. This only happens when the dialogue is
modal and consequentially has a maskNode present as it changes the initial
positioning behaviour of the boundingBox.

To avoid this, when the maskNode is shown, the dialogue is position at 0,0
in the current viewport. For centered dialogues, the dialogue is
automatically re-positioned after the window has shown. For non-centered
dialogues, the original position is stored and the dialogue is restored to
that position after it has been displayed.

This should not interfere with use of the align function as this will be
called later in the proceedings, after the show has run.
2014-10-23 14:44:14 +08:00
Damyon Wiese 99e455c7ea Merge branch 'MDL-47740' of git://github.com/timhunt/moodle 2014-10-23 14:24:47 +08:00
Damyon Wiese 54420a98b1 Merge branch 'MDL-43245' of git://github.com/jmvedrine/moodle 2014-10-23 13:52:15 +08:00
Damyon Wiese ed60e0eac5 MDL-47713 Grades: Fix new behat test after conversion from points to %
The contribution to course total column was changed from points to % but
this new test was submitted using points. It just needs the numbers converted
to %.
2014-10-23 13:37:24 +08:00
Damyon Wiese f9c90d8751 MDL-47763 Grades: Handle the case when a grade category is hidden.
This was breaking the contribution column, which needs to know the
weights of all the categories up the tree, whether they are visible or
not.
2014-10-23 13:26:40 +08:00
Damyon Wiese 79bf093ee2 Merge branch 'MDL-32616' of git://github.com/timhunt/moodle 2014-10-23 12:02:22 +08:00
Jetha Chan beb7456e3e MDL-47819 user_menu: fixed showing up in popups 2014-10-23 11:58:11 +08:00
Damyon Wiese f3d7cdffda MDL-47836 Grades: Fix the url for the upgraded grades warning page url. 2014-10-23 11:31:55 +08:00
Andrew Nicols 4a8c380abb MDL-47513 Fix RTL issues with grade report 2014-10-23 11:15:35 +08:00
John Okely 66f5e82b66 MDL-47767 tool_monitor: Use renderers for links between subscription and rule managers 2014-10-23 10:33:15 +08:00
John Okely 0cafac69f2 MDL-47767 tool_monitor: Add links between subscribe and rule manager 2014-10-23 10:33:15 +08:00
Andrew Nicols 555837c5d4 MDL-47808 mod_forum: Correct maxeditingtime for unit tests
The maxeditingtime needs to be a negative value for unit tests to ensure
that the messages are actually sent out.

Whilst fixing this I also discovered that the create_discussion part of the
generator also creates the first post.
2014-10-23 08:43:29 +08:00
Jean-Michel Vedrine d3c4d50f1f MDL-43245 Lesson: non editing teacher cannot grade lesson essay 2014-10-22 18:00:49 +02:00
Dan Poltawski e6afd45f96 Merge branch 'MDL-47713-master' of git://github.com/damyon/moodle 2014-10-22 10:49:07 +01:00
Frederic Massart 40a603c79d MDL-47814 core_grades: Improved coverage of user_graded event tests
The tests needed to use the API in order to trigger the user_graded
event that occurs when the course final grade has changed.
2014-10-22 16:53:16 +08:00
Damyon Wiese d1020cd5d4 MDL-47815 assign: Fix random unit test fails
This test was failing when it was run really slowly (looking at you oracle).
2014-10-22 16:49:00 +08:00
Damyon Wiese b0c5a9c491 MDL-47713 Grades: Update all the behat tests to use % in contribution column 2014-10-22 16:20:15 +08:00
Damyon Wiese 8950e7f535 on-demand release 2.8beta+ 2014-10-22 15:06:37 +08:00
Damyon Wiese 6a196cf14d NOBUG: Fixed file access permissions 2014-10-22 15:06:36 +08:00
Damyon Wiese 2746fbe47c Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2014-10-22 15:06:33 +08:00
Frederic Massart 6aeebc259a MDL-47637 core_grades: Outcomes must not be weighted when non aggregated 2014-10-22 14:58:17 +08:00
Damyon Wiese 718f179c22 Merge branch 'MDL-47706-master' of git://github.com/andrewnicols/moodle 2014-10-22 14:50:53 +08:00
Marina Glancy fca97cbec4 MDL-47673 grades: unittest change caused by generator change
Unit test was introduced in MDL-40697 when the generator for quiz activity was setting grade=0
2014-10-22 14:14:49 +08:00
Andrew Nicols bedcf338dc MDL-47706 gradebook: Update pageload time between changes
Since MDL-38732 we reject changes if another change has been made more
recently. As a result, if process_data is called, and then we roll into the
next millisecond period before process_data is called again, the change is
rejected.

Different errors were seen because the millisecond rollover occurred at
different time within the test.

Different error conditions were seen because not all of the tests check for
an error from the call to process_data(), instead just checking that the
value had been updated correctly.
2014-10-22 12:56:07 +08:00
Russell Smith 34f5a2bc4f MDL-47806: Add footer function for command line output. 2014-10-22 14:32:15 +11:00
Damyon Wiese 7a61e645c3 MDL-46527 Grades: Webservice only returns first activity grade. 2014-10-22 11:21:51 +08:00
Damyon Wiese 53f26095c6 Merge branch 'MDL-46527-master' of git://github.com/jleyva/moodle 2014-10-22 10:45:57 +08:00
Mark Nelson 8a0c649637 MDL-47153 tool_monitor: altered unit tests to pass 2014-10-21 16:00:26 -07:00
Mark Nelson 11c2bf3f73 MDL-47153 tool_monitor: added subscription_criteria_met event 2014-10-21 16:00:18 -07:00
Mark Nelson 1adb0031c0 MDL-47153 tool_monitor: added subscription_deleted event 2014-10-21 15:48:10 -07:00
Mark Nelson 229f841907 MDL-47153 tool_monitor: added subscription_created event 2014-10-21 15:48:10 -07:00
Mark Nelson 91df5f7e37 MDL-47153 tool_monitor: added rule_deleted event 2014-10-21 15:48:09 -07:00
Mark Nelson 12b9969ef9 MDL-47153 tool_monitor: added rule_updated event 2014-10-21 15:48:09 -07:00
Mark Nelson e9da23369f MDL-47153 tool_monitor: added rule_created event 2014-10-21 14:19:16 -07:00
AMOS bot e15766c19c Automatically generated installer lang files 2014-10-22 00:07:37 +08:00
Gareth J Barnard a024eaa5fc MDL-47795 SCORM: SCORM report not a report. 2014-10-21 15:37:31 +01:00
Tim Hunt cda62a3829 MDL-47791 question editing: remove permission info from above the form
This information is not really meaningful for users, and takes up prime
real-estate, so we are removing it.
2014-10-21 15:03:20 +01:00
Tim Hunt a8de866712 MDL-47740 question engine: let qs update variant later if appropriate
Variant has two purposes. First to determine which version of the
question the student will see. Hence it is used to set up the state
of the quetsion when the question is started. Then the internal state of
the question is saved in the first step.

Once that has been done, the variant number is purely informative, and
just used to break down the statistics.

In some cases (the one I have in mind is qtype_opaque) then there is a
complex randomisation process, which may lead to several inital variant
numbers acutally giving the same version of the question. In this case
it is nice if the question can update the stored variant number, to make
the statistics more meaningful.
2014-10-21 11:43:57 +01:00
Juan Leyva a7888487f0 MDL-46527 grades: grade_get_grades external function rewritten 2014-10-21 12:10:01 +02:00
Mark Nelson 6c271ab5e6 MDL-47780 core: corrected docs for get_user_capability_course() 2014-10-21 00:52:54 -07:00
Marina Glancy b1b66a3d12 Merge branch 'MDL-47736_master_fix2' of git://github.com/markn86/moodle 2014-10-21 15:49:10 +08:00
Mark Nelson 7b62567e85 MDL-47736 editor_atto: added fix for IE 9 and 10 2014-10-21 00:46:35 -07:00
Marina Glancy fb32a64efc Merge branch 'MDL-47736_master_fix' of git://github.com/markn86/moodle 2014-10-21 14:34:05 +08:00
Mark Nelson 3c15d25bcf MDL-47736 editor_atto: exclude <br> from being restored 2014-10-20 23:24:08 -07:00
Damyon Wiese fc9150cb0e MDL-47713 Grades: Change contribution column to a percent of grademax 2014-10-21 13:50:18 +08:00
Damyon Wiese a6396272f8 Merge branch 'wip_MDL-41593_m28_preventexecdefault' of https://github.com/skodak/moodle 2014-10-21 13:11:27 +08:00
Marina Glancy e94925ddd2 Merge branch 'MDL-47728_master' of git://github.com/markn86/moodle 2014-10-21 11:56:31 +08:00
Yuliya Bozhko 1f258cd8ce MDL-47755 badges: Fix internal message output
Signed-off-by: Yuliya Bozhko <yuliya.bozhko@totaralms.com>
2014-10-21 16:25:13 +13:00
Damyon Wiese a9a02e9170 MDL-20367 Grades: Allow real numbers as grade boundaries
Patch by Huy Hoang (I just git-ified it).
2014-10-21 11:15:39 +08:00
Marina Glancy 8b2d85406a Merge branch 'MDL-47400-master-2' of git://github.com/andrewnicols/moodle 2014-10-21 10:55:54 +08:00
Andrew Nicols 82e3440aec MDL-47400 gradereport_history: Fix string notempty test for Oracle 2014-10-21 10:48:28 +08:00
Sam Hemelryk 56f9e921f4 MDL-46133 tool_monitor: version bump for events 2014-10-21 15:22:10 +13:00
Sam Hemelryk 258d9af845 Merge branch 'm28_MDL-36669_UFO_references_in_filelib' of https://github.com/scara/moodle 2014-10-21 15:17:53 +13:00
Sam Hemelryk 7a126c94a4 Merge branch 'MDL-47739-master' of git://github.com/FMCorz/moodle 2014-10-21 14:44:01 +13:00
Sam Hemelryk 28f1bd0106 Merge branch 'MDL-47695' of git://github.com/timhunt/moodle 2014-10-21 14:42:36 +13:00
Sam Hemelryk 263f8cff7e Merge branch 'MDL-46133_master' of https://github.com/markn86/moodle 2014-10-21 14:39:34 +13:00
Matteo Scaramuccia 8045696b37 MDL-36669 Filters: Remove the last ref to the UFO library. 2014-10-20 23:17:50 +02:00
Dan Poltawski 96b1223387 Merge branch 'MDL-38172' of git://github.com/jmvedrine/moodle 2014-10-20 18:28:44 +01:00
Dan Poltawski 83b49754d3 Merge branch 'MDL-47400-master' of git://github.com/andrewnicols/moodle 2014-10-20 18:12:38 +01:00
Dan Poltawski cf3fbf8a0e Merge branch 'MDL-47664-master' of git://github.com/andrewnicols/moodle 2014-10-20 17:49:02 +01:00
Dan Poltawski 6c75bcb5d6 Merge branch 'MDL-47651' of git://github.com/timhunt/moodle 2014-10-20 17:44:33 +01:00
Dan Poltawski fb45249754 Merge branch 'MDL-47666' of git://github.com/timhunt/moodle 2014-10-20 17:31:20 +01:00
Dan Poltawski 6366cc0774 Merge branch 'MDL-47711' of git://github.com/timhunt/moodle 2014-10-20 17:28:50 +01:00
Dan Poltawski 30fac84578 Merge branch 'MDL-47726' of git://github.com/timhunt/moodle 2014-10-20 17:26:36 +01:00
Dan Poltawski 670b0d0283 Merge branch 'MDL-47691' of git://github.com/timhunt/moodle 2014-10-20 17:24:22 +01:00
Dan Poltawski 22c4db3ede Merge branch 'MDL-47673' of git://github.com/timhunt/moodle 2014-10-20 17:20:26 +01:00
Tim Hunt a3d5068083 MDL-47726 availability: fix tests when there is a text custom field
This unit tests assumed that on a fresh install, there were no custom
user-profile fields. Given some third-party plugins, that assumption is
false.
2014-10-20 16:15:34 +01:00
Tim Hunt 97ef7ea2ce MDL-47695 quiz editing: descritions don't have a max mark!
So don't show the UI for editing it.

Also, don't show non-functional page split/join icons after the quiz has
been attempted.
2014-10-20 15:30:35 +01:00
Dan Poltawski 11c6debb0a Merge branch 'MDL-47588' of git://github.com/timhunt/moodle 2014-10-20 14:30:46 +01:00
Tim Hunt d69a6ad965 MDL-47711 behat: make it easier to copy the init.php command. 2014-10-20 12:11:28 +01:00
Tim Hunt 1c2e05c060 MDL-47691 quiz: only warn re overdue attempts if a Q has been answered
If a quiz is set to have a grace period when time has expired, we only
email studnets to warn them about their overdue attempt if they have put
in an answer to at least one question that is worth some marks.
2014-10-20 12:11:10 +01:00
Tim Hunt 0233e2a973 MDL-47673 quiz generator: default grade 100 & fix review options
The review option defaults need to be like what you get from the editing
form, no what is stored in the database, or they don't work!
2014-10-20 12:11:01 +01:00
Tim Hunt a20d675250 MDL-47666 DB auth & enrol: unit tests fail with custom DB drivers
Changed to used $DB->get_db_family, rather than hard-coding the list of
class names.
2014-10-20 12:10:52 +01:00
Tim Hunt a40eaaa28f MDL-47651 quiz responses: allow for qtypes without responses 2014-10-20 12:10:43 +01:00
Tim Hunt 6f336f3602 MDL-47588 question behat tests: don't close the preview window.
If you do. Chrome + Selenium2 gets stuck (on Windows at least). Selenium
must be trying to send commands ot a window that does not exist any
more.
2014-10-20 12:10:15 +01:00
Tim Hunt a92105fd3f MDL-47588 behat: fix switching back to the main window in Chrome
This fix is mostly based on what Colin Chambers found out. This commit
is a simplification of his work.

The problem is that the Chrome / Selenium 2 integration cannot swich to
a window with a blank name. The work-around applied here is, when we
switch away from an unnamed window, we set a name on it. Then we can use
that name to switch back.
2014-10-20 12:10:14 +01:00
Tim Hunt cf256c05d8 MDL-32616 question engine: set_max_mark_in_attempts MySQL perf
The MySQL (& Maria DB) query 'optimizer' was failing to handle this
query, so for that DB only, we give it an equivalent query that it can
get right.

With unit test.
2014-10-20 12:06:39 +01:00
Tim Hunt 7ad0e2e654 MDL-32616 question engine: move unit test to better name 2014-10-20 12:06:38 +01:00
Jetha Chan 6287692843 MDL-47340 action_menu: selector, RTL, consistency fixes 2014-10-20 17:09:16 +08:00
Marina Glancy 2d2661e3d7 Merge branch 'MDL-47503-master' of git://github.com/damyon/moodle 2014-10-20 17:08:20 +08:00
Marina Glancy 24c11785b3 Merge branch 'wip_MDL-47754_m28_installredir' of git://github.com/skodak/moodle 2014-10-20 17:02:28 +08:00
Dan Bennett f181e4ac45 MDL-46332 : Display of 'Remove' button in Add/Remove Groups in Grouping
Fixed styling of Add/Remove Groups in Grouping to now use the same
layout as the Group Members page.
This fixes the issue with buttons being unaligned and introduces
consistency between pages.
2014-10-20 09:48:50 +01:00
Ankit Agarwal 5875e287a5 MDL-47759 tool_monitor: Fix permissions issue 2014-10-20 13:45:51 +05:30
Damyon Wiese eafab79941 MDL-47503 Grades: Display the notice about upgraded grades on all grade report pages.
Moved this to the print_grade_page_head function and added an access check so it only
displays for teachers.
2014-10-20 16:15:51 +08:00
Andrew Nicols a07ec4565f MDL-47400 gradereport_history: Ensure float precision is enforced
Format floats according to the grade item config.
2014-10-20 15:42:31 +08:00
Marina Glancy f75f2ecdf4 Merge branch 'MDL-47489-master' of git://github.com/FMCorz/moodle 2014-10-20 15:19:57 +08:00
Marina Glancy d90f0cab6d Merge branch 'MDL-47736_master' of git://github.com/markn86/moodle 2014-10-20 15:06:43 +08:00
Marina Glancy 1d67a8f209 Merge branch 'MDL-47725-master' of git://github.com/FMCorz/moodle 2014-10-20 15:06:29 +08:00
Adrian Greeve c42d18183a MDL-47675 phpunit: Update unit tests to pass on MSSQL
Unit tests were failing on MSSQL. gc_collect_cycles() was
removed from the phpunit utils.php file to save time in running
the tests, but MSSQL doesn't clean up open files as well as
other databases.

This patch includes the garbage collection for the unit tests
that require it.
2014-10-20 14:26:11 +08:00
Frederic Massart 263bf1a10f MDL-47725 gradereport_user: Only hide grades when they were altered
The method blank_hidden_total_and_adjust_bounds() now checks for more
than just a grade change, and in that cause would hide the grade. We
added a condition to only hide the grade when it effectively changed,
not when its other properties have.
2014-10-20 14:19:02 +08:00
Marina Glancy b3729c99aa Merge branch 'MDL-38065-fix-master' of git://github.com/jmarthaler/moodle 2014-10-20 14:08:06 +08:00
Marina Glancy 82c662d347 MDL-47760 grades: dim category name if hidden 2014-10-20 14:02:25 +08:00
Frederic Massart 40f874ce29 MDL-47489 core_grades: Behat tests covering contributions with extra credit 2014-10-20 13:52:18 +08:00
Frederic Massart 8427dc3a23 MDL-47489 core_grades: Adjust weights of extra credit items for Simple 2014-10-20 13:52:18 +08:00
Frederic Massart e8ac04c191 MDL-47489 core_grades: Adjust weights of extra credit items for Mean 2014-10-20 13:52:17 +08:00
Mark Nelson e924e1b33a MDL-47736 editor_atto: only save/restore draft when necessary 2014-10-19 22:14:15 -07:00
Marina Glancy c57681ed49 Merge branch 'MDL-47737-master' of git://github.com/FMCorz/moodle 2014-10-20 12:43:52 +08:00
Damyon Wiese 47d6e6a7d3 MDL-47503 Grades: Completely remove aggregationsubcats
This setting is not compatible with combinations of aggregation methods
and the ways in which it does and does not work are not documented. It
was voted to remove it completely by the gradebook workshop, so I have
completely removed it and added a warning for all affected courses + restored
backups.
2014-10-20 12:03:18 +08:00
Frederic Massart 86974893c8 MDL-47489 core_grades: Adjust weights of extra credit items for Natural 2014-10-20 11:50:43 +08:00
Frederic Massart 74d0ca1543 MDL-47739 form: Calendar widget causes unintentional focus and scroll 2014-10-20 10:55:49 +08:00
Adrian Greeve 3275892c03 MDL-47757 events: Fixed doc block and missing string.
The language events were missing the @since tag and
the grade single view report was missing a language
string.
2014-10-20 09:55:09 +08:00
Mark Nelson 4afd26a618 MDL-47735 mod_forum: added 'My profile' -> 'Forum posts' behat test 2014-10-19 18:44:22 -07:00
Petr Skoda f1cac3d515 MDL-47754 install: fix redirect loop 2014-10-20 12:52:35 +13:00
Sam Hemelryk 5c28d15985 MDL-46518 navigation: site glossaries now expand properly 2014-10-20 11:18:36 +13:00
Sam Hemelryk c1db791e98 MDL-47608 cachestore_mongo: fixed unit test error
If you configured your site to run mongo unit tests and had
the mongo extension and backend installed but did not have the
mongo service running you would get a fatal error when running
the unit tests.
That problem has been fixed by checking the mongo test instance
is ready before returning it.
2014-10-20 11:03:57 +13:00
Sam Hemelryk d5ae34a5a7 MDL-47077 report_participation: fixed pagination in groups 2014-10-20 11:01:04 +13:00
Sam Hemelryk 30aca4a74b MDL-46499 navigation: better enrolled course limit
We now user $CFG->navcourselimit to limit the number of
courses shown in the navigation when browsing another users
full profile. Previously it showed all courses which caused
some slowdown.
2014-10-20 10:58:40 +13:00
Sam Hemelryk ed7605f481 MDL-47752 grading: fixed bugs with the modgrade element 2014-10-20 10:32:13 +13:00
Sam Hemelryk d28e0a2f76 MDL-47684 mod: better validation of rating options 2014-10-20 08:44:35 +13:00
Mark Nelson 0b0a08e7b0 MDL-47728 tool_monitor: added capability check before displaying link 2014-10-18 20:15:35 -07:00
Jean-Michel Vedrine 814e381a47 MDL-29873 Lesson: Essays not shown on grade page with SQL server 2014-10-18 19:40:20 +02:00
Mark Nelson c62ba9b8ca MDL-47735 core: prevented iteration of 'groupmembersonly'
The course module variable 'groupmembersonly' was removed in 2.8.
2014-10-17 18:23:35 -07:00
Jean-Michel Vedrine 28928667a0 MDL-38172 Lesson: Additional Info not displayed at end of lesson 2014-10-17 17:04:57 +02:00
Dan Poltawski b49de5d930 on-demand release 2.8beta+ 2014-10-17 16:02:28 +01:00
Dan Poltawski cd2cfb5783 Merge branch 'MDL-47363' of git://github.com/marinaglancy/moodle 2014-10-17 14:46:30 +01:00
Dan Poltawski 9f67037a5f on-demand release 2.8beta+ 2014-10-17 14:32:19 +01:00
Dan Poltawski 624926e42c NOBUG: Fixed file access permissions 2014-10-17 14:32:19 +01:00
Dan Poltawski f6aaa184ab Revert "MDL-47684 mod: better validation of rating options"
This reverts commit 8028df293a.
2014-10-17 14:27:49 +01:00
Frederic Massart 53cca2274e MDL-47737 editor_atto: Prevent false negative when saving draft on IE9 2014-10-17 20:48:43 +08:00
Frederic Massart 2ccbcf0169 MDL-47738 gradereport_history: User selector handles broke with 0 user
It was impossible to reopen the dialogue when the last search result
did not return any user.
2014-10-17 19:34:16 +08:00
Dan Poltawski 9b4a87f7e6 Merge branch 'MDL-47733-master' of git://github.com/FMCorz/moodle 2014-10-17 11:44:58 +01:00
Frederic Massart 5aafc6f425 MDL-47733 editor_atto: Do not prompt error when draft is empty 2014-10-17 18:19:11 +08:00
Dan Poltawski bef6e88b5d Merge branch 'MDL-45843-master-fix1' of http://github.com/damyon/moodle 2014-10-17 09:34:39 +01:00
Dan Poltawski e435f174d3 Revert "MDL-44548 mod_scorm: force an external sync to check for updated files."
This reverts commit 2d9a4a5f93.
2014-10-17 09:30:38 +01:00
Damyon Wiese 7c2977bc5b MDL-45843 LTI: Fixes for sloppy form handling 2014-10-17 16:24:26 +08:00
Eloy Lafuente (stronk7) d8e909dc10 Merge branch 'MDL-47655-master-fix1' of git://github.com/damyon/moodle 2014-10-17 09:37:55 +02:00
Marina Glancy a96ca70064 MDL-47290 Grades: added bold for course total 2014-10-17 15:22:32 +08:00
Barbara Ramiro 0947172dba MDL-47290 Grades: Minified CSS and applied coding style standards 2014-10-17 15:03:53 +08:00
Barbara Ramiro 601af6666d MDL-47290 Grades: Style for the Single view table 2014-10-17 15:01:20 +08:00
Barbara Ramiro d70e86b1bd MDL-47363 Grades: Style for the Setup grades 2014-10-17 14:59:09 +08:00
Barbara Ramiro 2c7a86eb7f MDL-47363 Grades: Style for the User report 2014-10-17 14:56:31 +08:00
Andrew Nicols 3fa0daa90f MDL-47664 phpunit: Do not use sequence number changes for Oracle
When resetting a sequence number, we call change_database_structure()
which in turns clears the MUC cache for databasemeta. This cache contains
information about the table, columns, etc.

After the cache is cleared, it must be re-filled, and it was discovered
that the get_columns() code which fills this cache can take a particularly
long time. Given that this is called for every table in Moodle, this can
add up to a significant period, and this is done on a per-testsuite basis.

On my SSD install this was taking approximately 40 seconds on each re-fill
of the cache.
2014-10-17 13:28:46 +08:00
Marina Glancy 3279fe928f MDL-18229 gradebook: missing 'use' in singleview 2014-10-17 12:25:44 +08:00
Zachary Durber f86233a41e MDL-18229 gradebook: Fixes for Singleview behat tests. 2014-10-17 11:56:39 +08:00
Mark Nelson 154423f6fb MDL-46133 tool_monitor: added unit tests 2014-10-16 20:42:38 -07:00
Mark Nelson ad6f25cd8e MDL-46133 tool_monitor: added event cleanup task 2014-10-16 20:42:25 -07:00
Jon Marthaler a4bd536688 MDL-38065 gradebook: Fix issue with hidden categories breaking rowspan.
Hidden subcategories break the rowspan in the gradebook; this fix corrects
the calculation of the rowspan.
2014-10-16 22:27:52 -05:00
Zachary Durber f548d49f01 MDL-18229 gradebook: Sesskey required for all actions. 2014-10-17 10:51:45 +08:00
Damyon Wiese 821ce4d63b MDL-47655 assign: Fix unit tests triggering debugging
Test was triggering notifications - so needs to use a message sink.
2014-10-17 09:45:02 +08:00
Zachary Durber 900944385d MDL-18229 gradebook: Fix for min/max grades and large numbers. 2014-10-17 09:40:01 +08:00
Dan Poltawski e2270952c5 Merge branch 'MDL-46599-master' of git://github.com/lameze/moodle 2014-10-16 17:30:27 +01:00
Dan Poltawski f931c9245e Merge branch 'MDL-47681-master' of git://github.com/FMCorz/moodle 2014-10-16 15:14:20 +01:00
Dan Poltawski 5763316186 Merge branch '47631-28' of git://github.com/samhemelryk/moodle 2014-10-16 15:02:24 +01:00
Dan Poltawski 73f94e88ff MDL-18229 gradereport_singleview: missing MOODLE_INTERNAL 2014-10-16 13:58:37 +01:00
Dan Poltawski 992159f450 MDL-18229 grade report: coding style fixes
global definitions must be at the top of functions.
2014-10-16 13:49:44 +01:00
Dan Poltawski d65eefdbf1 Merge branch 'MDL-18229-master' of git://github.com/zbdd/moodle 2014-10-16 13:44:48 +01:00
Dan Poltawski 01c3b4c50b Merge branch 'MDL-47564-master' of https://github.com/sammarshallou/moodle 2014-10-16 11:50:38 +01:00
Dan Poltawski afb5161f37 Merge branch 'master_MDL-44548' of https://github.com/danmarsden/moodle 2014-10-16 11:45:22 +01:00
Frederic Massart f8c8f980c7 MDL-47681 core_grades: Ignore weights of grade items 'none' or 'text'
It can happen that some grade items with the type 'None' have a max
grade different than 0, in which case we would have set a weight for
them which is wrong as they must not have any. This patch always
ignores the grade items 'None' and 'Text' when calculating the
weights and locks the weight UI fields for those items too.
2014-10-16 18:42:27 +08:00
Dan Poltawski 799190cd2d Merge branch 'MDL-47710' of git://github.com/timhunt/moodle 2014-10-16 11:35:19 +01:00
Marina Glancy c74ec3e619 MDL-36987 auth_manual: fix config for field locking
Thanks to Sergey for the patch
2014-10-16 18:16:50 +08:00
Dan Poltawski 7829a6d1ca Merge branch 'MDL-47392-master' of git://github.com/xow/moodle 2014-10-16 11:12:01 +01:00
Dan Poltawski 50c4e8e8b6 Merge branch 'MDL-47696' of https://github.com/willylee/moodle 2014-10-16 11:07:27 +01:00
Dan Poltawski 3370412306 Merge branch '47684-28' of git://github.com/samhemelryk/moodle 2014-10-16 11:02:03 +01:00
Tim Hunt 9abf2d1417 MDL-47710 qformat_gift: fix bahat fails due to different ids in exports 2014-10-16 11:00:32 +01:00
Dan Poltawski 5708376927 Merge branch 'MDL-47655-master' of git://github.com/damyon/moodle 2014-10-16 10:57:06 +01:00
Dan Poltawski 62b5979cb1 Merge branch 'MDL-47657-master' of git://github.com/gurgus/moodle 2014-10-16 10:52:40 +01:00
Dan Poltawski 42da111dbe Merge branch 'MDL-47707-master' of git://github.com/gurgus/moodle 2014-10-16 10:43:52 +01:00
Dan Poltawski bb48e33fda Merge branch 'MDL-47686-master' of git://github.com/damyon/moodle 2014-10-16 10:39:12 +01:00
Damyon Wiese ba0d27735a MDL-47704 Grades: Fix for set_usedinaggregation
Used in aggregation was not resetting previously set values
when recalculating an aggregation. This meant that items no longer
in the aggregation, were displayed with stale weights in the user report.
2014-10-16 17:14:02 +08:00
Dan Poltawski 387cb9586e Merge branch 'MDL-47576-master-fixup' of https://github.com/jethac/moodle 2014-10-16 10:03:08 +01:00
Dave Cooper b0001c15f2 MDL-47707 tool_monitor: Changed navigation position of event monitor.
This issue is part of the MDL-45758 epic.
2014-10-16 16:50:11 +08:00
Jetha Chan 8ef43cfde6 MDL-47576 user_menu: theme_base fixes 2014-10-16 16:18:38 +08:00
John Okely 044a298e6f MDL-47392 core_grades: Consolidate grade item weight setting location 2014-10-16 15:21:53 +08:00
Damyon Wiese 973840f7d5 MDL-47575 Whitespace fix. 2014-10-16 15:20:07 +08:00
Damyon Wiese 3fa81fabc3 Merge branch 'MDL-47575-master' of git://github.com/zbdd/moodle 2014-10-16 14:49:49 +08:00
Damyon Wiese bd71cb83df MDL-45758 Event monitor: Improve the help string. 2014-10-16 14:34:52 +08:00
Damyon Wiese 9e035dae1b MDL-47655 assign: Treat 'new' status as never submitted.
This fixes the recent activity callbacks to ignore submissions with a 'new' status.

The unit tests for recent activity were modified, because they were relying on the old behaviour of 'submitted' being the default status.

AMOS BEGIN
     CPY [submissionstatus_,mod_assign],[submissionstatus_new,mod_assign]
AMOS END
2014-10-16 13:56:07 +08:00
Damyon Wiese b8bd29da41 Merge branch 'event_monitor' of git://github.com/ankitagarwal/moodle 2014-10-16 13:20:45 +08:00
Zachary Durber 6deb0344c5 MDL-47575 gradebook: Show weights and contribution by default. 2014-10-16 13:11:47 +08:00
Damyon Wiese 8ae6df3798 Merge branch 'MDL-47667' of git://github.com/timhunt/moodle 2014-10-16 13:00:22 +08:00
Adrian Greeve b9cafe3b40 MDL-46599 gradebook: Added a time exported column to grade export via csv.
This will be useful for checking if a csv import is trying to overwrite
new grade updates.
2014-10-16 10:31:10 +08:00
Simey Lameze a5240a82a6 MDL-46599 gradebook: Add force import option on CSV file and direct importing 2014-10-16 10:22:45 +08:00
Simey Lameze ce8f9c9b87 MDL-46599 gradebook: Add last exported date column on ODS and XLS export formats 2014-10-16 10:22:20 +08:00
Sam Hemelryk 8028df293a MDL-47684 mod: better validation of rating options 2014-10-16 14:50:56 +13:00
Sam Hemelryk 2fdb4c6b00 Merge branch 'MDL-47594_master' of git://github.com/kordan/moodle 2014-10-16 11:04:53 +13:00
Sam Hemelryk edfeca582e Merge branch 'wip-MDL-47629-master' of https://github.com/kwiliarty/moodle 2014-10-16 10:31:20 +13:00
Sam Hemelryk b1b2999206 MDL-45843 mod_lti: bumped ltiservice dependency versions 2014-10-16 09:59:06 +13:00
spvickers e3f69b58a2 MDL-45843 mod_lti: introduced support to LTI 2.0
This commit introduces support to the LTI module for LTI 2.0.
As well as the initial commit the following changes were made
and then squashed into the single commit for integration:

* Fixed bug in services
  Fixed bug which limited characters allowed in values of template
  variables (e.g. vendor ID) in service endpoints.
  Changed language file to refer to tool registrations rather than
  tool proxies.

* Refactored service classes
  Moved classes relating to services into areas where Moodle will
  autoload them

* Ran code through code checker
  Removed all errors reported by the Code checker module
  excluding third-party OAuth.php file.

* UI improvements
  Mainly when adding an external tool to a course - fields which
  should not be changed for a selected tool are either hidden or
  disabled. Admin settings page now shows the Tool Registration
  name against a tool rather than the launch URL, and the
  registration URL replaces the GUID on the tool registrations
  page.

* Updated tool proxy registration
  Added check of tool proxy to ensure only offered capabilities
  and services are included.  Also check tool proxy when processing
  a service request.

* Code review changes
  Some fixes based on code review by Mark Nielsen and addition of
  some PHPDocs comments.

* Updates from code/PHPdocs checks
  Removed use of eval and corrected invalid PHPdocs for new
  functions/classes

* Corrected namespace error and incorrect string terminator

* Updates based on forum feedback
  Added dependencies and backup, restore and uninstall methods for
  ltiservice subplugins.
  Changed most uses of is_null to empty

* Updated custom parameters test
  Updated test_split_custom_parameters to include new function
  parameters.
  Corrected PHPdoc entry for lti_split_custom_parameters
  Fixed incorrect line separators in ltiservice.php

* Added require_capability to registrationreturn.php

* SQL and EOL updates
  Moved PHP variable in SQL into a named parameter
  Improved checks for end-of-line characters to include CR and LF
  on their own or together

* Check for semicolon separators
  Semicolon separators in custom parameters are changed to EOL
  characters when upgrading to the 2014100100 version.

* Remove unused file
  basiclti.js file not being used so removed.

* Adjust line lengths
  Split long lines in upgrade.php

* Added savepoint to upgrade.php
  savepoint omitted from earlier update to upgrade.php

* Updated namespaces and upgrade
  Service and resource classes moved into .../local/...
  Upgrade SQL moved into a function and unit test created

* Updated lti_tool_proxies table
  Added indices and foreign keys to lti_tool_proxies table

* Fixed formatting and documentation issues

* ltiservice class moved into local

* Replaced lti_scale_used comments
  Put back commented out code for lti_scale_used

* Removed redundant sesskey code

* Fixed namespace and path check
  Updated ltiservice namespace for move into local
  Added check for existence of $_SERVER['PATH_INFO']

* Updated upgrade code
  Added indices and keys to lti_tool_settings table when upgrading
  Fixed errors in upgradelib_test.php (thanks to jleyva)
  Update SQL to use Moodle functions

* Use of empty with class method
  PHP 5.4 does not like the use of empty with a class method so saved the
  value to a variable first.  PHP 5.5 seems to accept the use of a method
  with empty.

* Removed redundant indices
  Removed creation of indices for foreign keys on lti_tool_settings table
  from install.xml and upgrade.php

* Fixes based on feedback
  Minor changes and corrections based on review in JIRA

* Fixed bug in toolproxy service
  Corrected bug which failed to respond properly to an invalid request
  Also updated upgrade.txt file

* Improved admin navigation
  Added the manage tool registrations page as a separate entry on the
  admin menu (within a folder named LTI).  Made this entry the current
  position for the related pages.

* Updated PHPdocs with class names
  Added class names with namespaces to PHPdocs to replace generic
  references to "object"

* Changed object to iframe
  Use of object tag in register.php changed to use an iframe tag in line
  with the similar update made to view.php.

* Improved registration process
  A message is now displayed if the registration page has not been loaded
  in the iframe within 20 seconds.  If a user is returned to Moodle
  without a tool proxy being sent, the registration is moved back from
  pending to configured.

* Fixes for integration
  Removed comment - the template is the default path unless overridden, so
  get_path and get_template should both be defined.
  Added comment and intval to fix the issue with obtaining an error
  reason.
2014-10-16 09:33:33 +13:00
Dan Poltawski 529e38d141 Merge branch 'MDL-47576-master' of git://github.com/jethac/moodle
Conflicts:
	theme/bootstrapbase/style/moodle.css
2014-10-15 16:59:06 +01:00
Dan Poltawski 33ccfc1f13 Merge branch 'MDL-47560-master' of git://github.com/gurgus/moodle 2014-10-15 16:56:43 +01:00
Willy Lee 8f16523082 MDL-47696 assign: allow 'not submitted' filter to get all other submission statuses 2014-10-15 08:16:37 -07:00
Dan Poltawski 560b04b408 Merge branch 'MDL-47243-master' of git://github.com/xow/moodle 2014-10-15 16:14:39 +01:00
Damyon Wiese b065b569af Merge branch 'wip-MDL-47613-master' of git://github.com/marinaglancy/moodle 2014-10-15 16:59:57 +08:00
Ankit Agarwal d6e0e275dd MDL-45758 tool_monitor: Update behat tests 2014-10-15 13:59:19 +05:30
Ankit Agarwal ffe9ed541c MDL-45758 tool_monitor: Update subscriptions management UI 2014-10-15 13:59:18 +05:30
Damyon Wiese 127b3915df MDL-47686 assign: Fix restoring from a mod_assignment backup.
This was only working for admins.
2014-10-15 15:56:30 +08:00
Dan Poltawski 22caa080f9 Merge branch 'MDL-38732-master-2nd' of git://github.com/FMCorz/moodle 2014-10-15 08:41:23 +01:00
Damyon Wiese 87ea3e7e37 Merge branch 'master_MDL-47431' of https://github.com/danmarsden/moodle 2014-10-15 14:52:42 +08:00
Dave Cooper d0d59df939 MDL-47657 mod_glossary: Fixed wrong error message on edit timeout. 2014-10-15 14:48:18 +08:00
John Okely 3087835ae3 MDL-47243 core_grades: Add behat tests for outcomes in Natural 2014-10-15 14:33:31 +08:00
John Okely 5e18456631 MDL-47243 core_grades: Allow extra credit on outcome grade items 2014-10-15 14:33:31 +08:00
John Okely c53708d9c0 MDL-47243 core_grades: Add weight settings to outcome edit page 2014-10-15 14:33:31 +08:00
John Okely cfa91962d1 MDL-47243 behat: Add data generators for gradeitems scales and outcomes 2014-10-15 14:33:26 +08:00
Damyon Wiese 1a847ddaf8 Merge branch 'MDL-47646' of git://github.com/timhunt/moodle 2014-10-15 14:26:49 +08:00
Ankit Agarwal 067e9599ac MDL-45758 tool_monitor: Update navigation nodes 2014-10-15 11:33:31 +05:30
Damyon Wiese b51c2c4f8c Merge branch 'wip-MDL-47572-master' of git://github.com/marinaglancy/moodle 2014-10-15 13:58:32 +08:00
Damyon Wiese 5d70f2303a Merge branch 'wip-MDL-47583-master' of git://github.com/marinaglancy/moodle 2014-10-15 13:46:28 +08:00
Frederic Massart e813b7286e MDL-38732 gradereport_grader: Undefined variable in unit tests 2014-10-15 12:22:35 +08:00
Marina Glancy bf8542ce3a MDL-30358 forms: strict validation is too strict 2014-10-15 11:57:01 +08:00
Dave Cooper c8eb1fae64 MDL-47560 Grades: Unset config when gradebook upgrade acknowledged. 2014-10-15 11:00:57 +08:00
Damyon Wiese e9e3c0dcfd Merge branch 'MDL-47575-master' of git://github.com/zbdd/moodle 2014-10-15 10:19:05 +08:00
Ankit Agarwal b9ba26b222 MDL-45758 tool_monitor: Update navigation to add callbacks
User settings node now checks for callbacks in various admin tools
2014-10-15 07:41:06 +05:30
Ankit Agarwal e8a925a60e MDL-45758 tool_monitor: Update js to get around chrome bug 2014-10-15 07:41:06 +05:30
Ankit Agarwal 75cae53b7b MDL-45758 tool_monitor: Peer review changes 2014-10-15 07:41:06 +05:30
Ankit Agarwal 758793d889 MDL-45758 tool_monitor: Fix lang strings for caps 2014-10-15 07:41:06 +05:30
Simey Lameze 77098e6dc1 MDL-45758 tool_monitor: Add behat tests to subscription management
Original issue - MDL-47148
2014-10-15 07:41:06 +05:30
Simey Lameze 9031b34da3 MDL-45758 tool_monitor: Behat tests for rule management
Original issue - MDL-47148
2014-10-15 07:41:06 +05:30
Ankit Agarwal 2161de73d8 MDL-45758 tool_monitor: Add tests for the observers
Original issue - MDL-47376
2014-10-15 07:41:06 +05:30
Ankit Agarwal e24e0d24b9 MDL-45758 tool_monitor: Add observers to handle user and module deletion
Original issue - MDL-47376
2014-10-15 07:41:06 +05:30
Ankit Agarwal 5833307eab MDL-45758 tool_monitor: Add unit tests for the universal observer
Original issue - MDL-46132
2014-10-15 07:41:06 +05:30
Ankit Agarwal bb550efc0d MDL-45758 tool_monitor: Add a universal event observer
This observer does the following task:-
1) It monitors all events and stores relevant data in a temporary table
2) It doesn't write the events straight away, it buffers them, so there is only one db write per request
3) It calculates and sees if there are subscriptions related to those events who need to be notified
4) If there are such cases, it schedules a adhoc task for the same

Original issue - MDL-46132
2014-10-15 07:41:06 +05:30
Ankit Agarwal 1ebfdaec04 MDL-45758 tool_monitor: Add a adhock task to send notifications
Original issue - MDL-46132
2014-10-15 07:41:05 +05:30
Ankit Agarwal 01d070e74b MDL-45758 tool_monitor: Modifiy manager classes to return instances
Original issue - MDL-46132
2014-10-15 07:41:05 +05:30
Ankit Agarwal d18c425d51 MDL-45758 tool_monitor: Add a new message provider
Original issue - MDL-46132
2014-10-15 07:41:05 +05:30
Simey Lameze 84be4f6af4 MDL-45758 tool_monitor: add missing alt on manage icons
Original issue - MDL-47460
2014-10-15 07:41:05 +05:30
Mark Nelson c47eb61a48 MDL-45758 tool_monitor: added help icon for rules
Original issue - MDL-47152
2014-10-15 07:41:05 +05:30
Mark Nelson 4e18940f83 MDL-45758 tool_monitor: added help icon for subscriptions
Original issue - MDL-47152
2014-10-15 07:41:05 +05:30
Mark Nelson d55f3e03b1 MDL-45758 tool_monitor: added help icon renderer
Original issue - MDL-47152
2014-10-15 07:41:05 +05:30
Mark Nelson 27b6839fe2 MDL-45758 core: edited get_formatted_help_string
Edited the api to accept string parameters

Original issue - MDL-47152
2014-10-15 07:41:05 +05:30
Mark Nelson 5b8aa8f700 MDL-45758 tool_monitor: fixed typo
Original issue - MDL-47152
2014-10-15 07:41:05 +05:30
Ankit Agarwal e1a6022802 MDL-45758 tool_monitor: Add unit tests for the course deleted observer
Original issue - MDL-46510
2014-10-15 07:41:05 +05:30
Ankit Agarwal 6a7de0d243 MDL-45758 tool_monitor: Add a course delete observer
Original issue - MDL-46510
2014-10-15 07:41:05 +05:30
Ankit Agarwal 044503e33d MDL-45758 tool_monitor: Add a UI page to manage subscriptions
Original issue - MDL-46111
2014-10-15 07:41:05 +05:30
Ankit Agarwal ac0e4dad7f MDL-45758 tool_monitor: Update subscription manager class
Update the class to support the subs renderable

Original issue - MDL-461111
2014-10-15 07:41:05 +05:30
Ankit Agarwal 58dcafb05a MDL-45758 tool_monitor: Add renderables for the subscription page
Original issue - MDL-46111
2014-10-15 07:41:05 +05:30
Ankit Agarwal 76b7ce41ab MDL-45758 tool_monitor: Add a renderer for the subscription page
Original issue - MDL-46111
2014-10-15 07:41:05 +05:30
Ankit Agarwal 3432c96d3a MDL-45758 tool_monitor: Create a subscription instance class
Original issue - MDL-46241
2014-10-15 07:41:04 +05:30
Ankit Agarwal 3870ad7a2f MDL-45758 tool_monitor: Handle rule managment
Original issue - MDL-46130
2014-10-15 07:41:04 +05:30
Ankit Agarwal 22f4231631 MDL-45758 tool_monitor: Display a rule managment interface
Original issue - MDL-46110
2014-10-15 07:41:04 +05:30
Ankit Agarwal 371d5e0b66 MDL-45758 tool_monitor: Create rendering code for manage rules page
Original issue - MDL-46110
2014-10-15 07:41:04 +05:30
Ankit Agarwal 58097ddf9b MDL-45758 tool_monitor: Add support for editing/creating a rule
Original issue - MDL-45938
2014-10-15 07:41:04 +05:30
Ankit Agarwal 2fd010b886 MDL-45758 tool_monitor: YUI module to handle event selection dropdown
Original issue - MDL-45938
2014-10-15 07:41:04 +05:30
Simey Lameze 48cc3a8d4d MDL-45758 tool_monitor: Initial version of rule form.
Original issue - MDL-45938
2014-10-15 07:41:04 +05:30
Ankit Agarwal 3d27d680a8 MDL-45758 tool_monitor: Polish the code for rule manager and unit tests
Original issue - MDL-45918
2014-10-15 07:41:04 +05:30
Simey Lameze 7bdbb4dc2d MDL-45758 tool_monitor: Rule manager class and data generators
This issue introduces rule manager class, data generators and unit tests
associated with them.

Original issue - MDL-45918
2014-10-15 07:41:04 +05:30
Ankit Agarwal c8a081cc6b MDL-45758 tool_monitor: Add a subscription manager class
Original issue - MDL-45919
2014-10-15 07:41:04 +05:30
Ankit Agarwal 3883eee06b MDL-45758 tool_monitor: Build the navigation tree for the tool
Original issue - MDL-46131
2014-10-15 07:41:04 +05:30
Ankit Agarwal eccf301acf MDL-45758 navigation: updates to navigation
This patch does the following:-
Start using proper key for course report node
Allow admin tools to hook into course navigation

Original issue - MDL-46131
2014-10-15 07:41:04 +05:30
Ankit Agarwal 5f68d9ee2b MDL-45758 tool_monitor: Implement a rule instance class
Original issue - MDL-45939
2014-10-15 07:41:04 +05:30
Ankit Agarwal f235cae41f MDL-45758 tool_monitor: Implement a class to generate list of events
Original issue - MDL-46109
2014-10-15 07:41:04 +05:30
Ankit Agarwal d0d6c72de2 MDL-45758 tool_monitor: Adding xml file defining the db tables
Original issue - MDL-45916
2014-10-15 07:41:03 +05:30
Ankit Agarwal 92b40de9de MDL-45758 tool_monitor: Add basic file structure of the report
Original issue - MDL-45916
2014-10-15 07:41:03 +05:30
Brian Barnes a87c17d14f MDL-47632 calendar: Fixed iCal link going blue after visiting it 2014-10-15 08:46:07 +13:00
Kevin Wiliarty 3d1c2898c1 MDL-47629 quiz review: display cloze feedback on top of "Check" button 2014-10-14 15:36:34 -04:00
Dan Poltawski 4f639ec86b Merge branch 'MDL-47463-master' of git://github.com/FMCorz/moodle 2014-10-14 19:11:57 +01:00
Dan Poltawski 1b07195b28 Merge branch 'MDL-38732-master-2nd' of git://github.com/FMCorz/moodle 2014-10-14 19:00:28 +01:00
Dan Poltawski 5a94eeb56d Merge branch 'MDL-47614-master' of git://github.com/andrewnicols/moodle 2014-10-14 18:47:30 +01:00
Dan Poltawski 050b930fa7 on-demand release 2.8beta+ 2014-10-14 18:00:47 +01:00
Dan Poltawski f47265d3a0 Merge branch 'install_master' of https://git.in.moodle.com/amosbot/moodle-install 2014-10-14 18:00:44 +01:00
Dan Poltawski df11019a82 MDL-46235/MDL-46971 mysql_compress_rows: fix typo 2014-10-14 16:36:47 +01:00
Yolanda Ordóñez Rufat c3f51a3c79 MDL-47466 calendar: fixed error ORA-01795 in calendar_get_events 2014-10-14 14:58:05 +02:00
Dan Poltawski 8a7b6d292d Merge branch 'wip-MDL-47617-master' of git://github.com/abgreeve/moodle 2014-10-14 13:17:36 +01:00
Dan Poltawski 3be2f6ac0b Merge branch 'MDL-47649' of git://github.com/timhunt/moodle 2014-10-14 13:14:19 +01:00
Helen Foster a1b152f5db MDL-47140 atto: improved wording of error message 2014-10-14 12:20:58 +01:00
Tim Hunt 01e7c3bf4e MDL-47667 profile unit tests: don't assume none by default.
E.g. if an add-on creates a user profile field on install, the test was
failing.
2014-10-14 12:09:51 +01:00
Marina Glancy acab649e06 Merge branch 'MDL-47189-master-2nd' of git://github.com/FMCorz/moodle 2014-10-14 18:34:14 +08:00
Tim Hunt a866538b9b MDL-47649 csvlib: must not leave files open
I added a destructor to csv_import_reader ensure the file is closed.

I also ensured that the gradeimport_csv unit tests did not hold onto a
reference to the csv_import_reader object while the phpunit framework
tries to tidy up moodledata.

Finally, to stop CiBoT complaining, I fixed up the PHP4-style
declarations in the CSV import class.
2014-10-14 10:36:25 +01:00
Frederic Massart da45dc0497 MDL-47189 my: Update test to check that existing blocks remain after add
Specifically checking for strings in the blocks because the tests
passed when looking for the string anywhere.
2014-10-14 16:03:12 +08:00
Frederic Massart 00fd3c1aad MDL-47189 my: Fix the addition of default blocks to my/ page
Fixing the upgrade script so that they attach the new blocks
to the right my_pages entry. An upgrade script has also been
added to fix the existing bad data.
2014-10-14 16:03:12 +08:00
Andrew Nicols 906de1b640 MDL-47614 gradereport: Apply a background colour
Apply the page background colour to the table for all bootstrap base
themes.

Whis will ensure that the table does not stand out strangely on a non-white
background.
2014-10-14 15:41:21 +08:00
Damyon Wiese f50395b402 Merge branch '46151-28' of git://github.com/samhemelryk/moodle 2014-10-14 15:34:25 +08:00
Jetha Chan f89a85f81c MDL-47576 user_menu: improved dropdown styles, added JS-less styles 2014-10-14 14:59:42 +08:00
Damyon Wiese 852ff0372f MDL-47499 tasks: Scheduled tasks custom schedule is reset on upgrade.
Add a unit test for reset_scheduled_tasks_for_component and make sure it doesn't clear
customised schedules for existing tasks.
2014-10-14 14:59:24 +08:00
Zachary Durber f4278326c0 MDL-47575 gradebook: Show weights and contribution by default. 2014-10-14 14:22:08 +08:00
Frederic Massart 09171b955e MDL-38732 gradereport_grader: Handle simultaneous graders 2014-10-14 13:52:42 +08:00
Zachary Durber 1b2c1ccb4c MDL-18229 gradebook: Fixes for bulk insert and checkboxes. 2014-10-14 13:18:45 +08:00
Adrian Greeve c1a27029fe MDL-47617 behat: Fixed behat sorting failure
Postgres and MySQL treat values that are null differently
when sorting. MySQL will sort null values above fields with
values and Postgres will be vice versa. I removed the checks
against the Admin User.

Oracle treats lower case values different to upper case values
and so I have modified the test so that all Names start with
an Uppercase letter.
2014-10-14 11:30:01 +08:00
Damyon Wiese 57fac09a40 MDL-18229 Grades: singleview report mega cleanup.
Fix all the things, including:
* Fix $PAGE->url
* Fix coding style.
* Add event for reportviewed
* Removed broken callback  gradereport_singleview_profilereport
* Removed vertical-align-middle
* Changed prefixes in css
* phpcs fixes
* moodlecheck fixes including phpdocs
* Move classes to use autoloading
* Remove all smelly code tricks like func_get_args, scandir etc (lots).
2014-10-14 10:26:46 +08:00
Zachary Durber 5f3decb5cb MDL-18229 gradebook: Additional fixes.
Random foo left in options. (test code)
Allowed editing link for Course total.
Fixes based on Apu's review.
2014-10-14 10:26:46 +08:00
Aparup Banerjee 0a55da571a MDL-18229 gradereport: updated index.php test to calculate navigation based on new class name 'gradereport_selectable_items' 2014-10-14 10:26:46 +08:00
Zachary Durber 8ec7b088ef MDL-18229 gradereport: Fixes and improvements from review.
Added pagination back in with some general fixes.

AMOS BEGIN
 CPY [override,mod_quiz],[override,gradereport_singleview]
AMOS END
2014-10-14 10:26:46 +08:00
Zachary Durber 2fd9718d8b MDL-18229 gradereport: Behat tests added. 2014-10-14 10:26:46 +08:00
Zachary Durber 7bd3932e76 MDL-18229 gradereport: Labels for table items added. 2014-10-14 10:26:46 +08:00
Zachary Durber 65c134f98a MDL-18229 gradebook: Updating code to Moodle standard. 2014-10-14 10:26:46 +08:00
Zachary Durber 92c61fee64 MDL-18229 gradebook: Links to Single view via icons on Grade Report. 2014-10-14 10:26:45 +08:00
Zachary Durber d124a60b33 MDL-18229 gradebook: Renaming of Single_view to Single view 2014-10-14 10:26:45 +08:00
Zachary Durber edd8b27923 MDL-18229 gradebook: Fix for loading activities.
Was using local variable iteminstance rather than cmid.
2014-10-14 10:26:45 +08:00
Zachary Durber 6a555b99f7 MDL-18229 gradebook: Linking activities and usernames correctly.
Activities to their course page and usernames to their
profile page as per standard.
2014-10-14 10:26:45 +08:00
Aparup Banerjee 7cdbf79dd9 MDL-47347 added basic navigation to top and bottom of gradereport_singleview
Part of MDL-18229
2014-10-14 10:26:45 +08:00
Zachary Durber 508f23f1e5 MDL-18229 gradebook: Single view navigation corrected.
Usernames link to user profiles.
Activities to their activity page.
2014-10-14 10:26:45 +08:00
Zachary Durber 4229e9fa8d MDL-18229 gradebook: Added filter icons for activities and users.
Corrected CSS for grades column, was far too large.
2014-10-14 10:26:45 +08:00
Zachary Durber 7bd4a361b3 MDL-18229 gradebook: Initial commit of LSUs Quick Edit Plugin
Renamed to Single View in MDL-47289.
2014-10-14 10:26:45 +08:00
Simey Lameze 372997907f MDL-46599 gradebook: Unit tests for last exported date and force import option 2014-10-14 09:30:04 +08:00
Dan Marsden 711910ec0d MDL-33939 gradingform_guide: use correct max grade for scales. 2014-10-14 08:42:30 +13:00
Sam Hemelryk c1fb8f6d2e MDL-46151 cachestore_memcache: now checks extension version for support 2014-10-14 08:27:45 +13:00
AMOS bot ad7f22c055 Automatically generated installer lang files 2014-10-14 00:05:32 +08:00
Tim Hunt 90048c7cfa MDL-47646 CURL redirect unit test: handle broken servers 2014-10-13 15:52:04 +01:00
Dan Poltawski ec72585d64 Merge branch 'MDL-47603' of git://github.com/timhunt/moodle 2014-10-13 13:33:56 +01:00
Frederic Massart 1d65db8b39 MDL-47463 core_grades: Behat checks the contribution of single item scales 2014-10-13 18:23:03 +08:00
Dan Poltawski bb29fe900e Merge branch 'wip-MDL-46819-master' of git://github.com/abgreeve/moodle 2014-10-13 11:02:59 +01:00
Dan Poltawski 42b0ce301d Merge branch 'wip-MDL-46546-master' of git://github.com/abgreeve/moodle 2014-10-13 10:57:17 +01:00
Dan Poltawski 7c50998039 Merge branch 'MDL-47140-master' of git://github.com/gurgus/moodle 2014-10-13 09:54:02 +01:00
Frederic Massart 21dd684207 MDL-47463 core_grades: Behat checks the contribution of scales 2014-10-13 16:01:32 +08:00
Frederic Massart 87e1e53c97 MDL-47463 core_grades: Handle course contribution of scales 2014-10-13 15:54:58 +08:00
Dave Cooper b6da971b4a MDL-47140 editor_atto: Improved error handling 2014-10-13 10:51:17 +08:00
Adrian Greeve a2809ae2c9 MDL-46546 core_grades: Notice display for bad import.
If the initial import of csv data is bad, a notification
will be displayed to the user.
2014-10-13 10:36:38 +08:00
Adrian Greeve 0cf122171b MDL-46819 core_grades: Negative weights are changed to 0
Negative weights in the natural aggregation are not currently permitted.
Any figure below zero is changed to a zero.
2014-10-13 08:19:24 +08:00
Sam Hemelryk 0e6d8ed261 MDL-47631 report_participation: fixed filtering by letter 2014-10-13 12:27:48 +13:00
Rex Lorenzo 6fa877e243 MDL-47555 core_availability: Issue with page layout & grade restriction
* Set pagelayout before getting section info, otherwise conditional activity renderers will default to the default 'base' layout.
2014-10-10 14:57:21 -07:00
Tim Hunt 84b45a24a1 MDL-47603 quiz edit: qbank popup preview icon needs new window
Also, ensure that clicking the + icon adds the question on the right
page.

Bit of this fix are a bit hacky, but we have to deal with the fact there
is not a good general solution to MDL-47604.
2014-10-10 13:40:16 +01:00
Marina Glancy d8773d64fc MDL-47613 wiki: allow searching several words
Thanks to Sandeep B for suggested solution
2014-10-10 16:35:13 +08:00
Dan Marsden 2d9a4a5f93 MDL-44548 mod_scorm: force an external sync to check for updated files.
also remove some globals no longer needed (not used in function or in required files.
2014-10-10 15:10:08 +13:00
Dan Marsden 6cdfe1a824 MDL-47431 advanced grading: correct use of frankenstyle names for consistency 2014-10-10 14:57:29 +13:00
Kordan f656df787f MDL-47594 core_accesslib: removed three useless lines of code 2014-10-09 11:04:36 +02:00
Marina Glancy 8c2fc797a0 MDL-47583 atto_managefiles: correctly decode filename 2014-10-09 10:59:33 +08:00
Marina Glancy c84d8cc452 MDL-47583 tinymce_managefiles: correctly decode filename 2014-10-09 10:59:21 +08:00
Marina Glancy 54f7d2d7f4 MDL-47572 libraries: modify unittest to avoid random timing fail
Thanks to Nigel Cunningham
2014-10-08 11:32:10 +08:00
Mark Nielsen 292f663581 MDL-47569 backup: Do not close questions tag if never opened
This can happen when restoring quizzes that
do not have any questions.
2014-10-07 11:48:35 -07:00
Mark Nielsen 95dc1e42d5 MDL-47569 backup: Escape section summary for XML
This was causing the parsing of the XML
to fail because things like & were not
escaped.
2014-10-07 11:47:40 -07:00
sam marshall c0d92241f1 MDL-47564 Availability: incorrect use of defined('PHP_UNIT') 2014-10-07 14:47:29 +01:00
Petr Skoda 41186f4f80 MDL-41593 admin: use default setting if preventexecpath active
This resolves problems when installing Moodle
and addons when preventexecpath active.

Please note the admin_setting_configfile is still
incorrectly restricted - this will be resolved by
MDL-40949.
2014-10-07 11:30:08 +13:00
Gregory Faller 452beca98d MDL-46712: Center EditPDF window on browser resize / zoom 2014-10-06 14:44:51 +08:00
Andrew Nicols f67b5c995e MDL-47183: viewhiddenactivities should use the module context
Thanks to Paulo Matos for the forum part of this change.
2014-10-06 12:21:49 +08:00
Yolanda Ordóñez Rufat a2ed10a5e7 MDL-47466 calendar: use get_in_or_equal() in function calendar_get_events to fix problem with ORA-01795 2014-09-30 13:23:33 +02:00
Tim Hunt dc37223bff MDL-46088 quiz secure window: further Atto JS fixes. 2014-09-19 22:03:24 +01:00
Damyon Wiese d250083e03 MDL-46088 Quiz: Prevent alert when clicking in editor in secure popup 2014-09-19 22:03:24 +01:00
Tim Hunt 339554aa21 MDL-46088 Impossible to click on Atto in a Quiz in 'Secure' mode. 2014-09-19 22:03:23 +01:00
Virgil Ashruf 118a9b4308 MDL-45636 course_rest: changed modcontext to coursecontext 2014-09-01 12:36:04 +02:00
Daniel Kosinski 43fb9ced67 MDL-46219 assignment: delete files when resetting assign activities 2014-08-05 23:31:20 +02:00
David Scotson fbfc7d252c MDL-40343 forum: indent less when mobile, nested
Changes the indenting of forum replies to be relative to the width of
the parent container, so the indent decreases as threads get nested
deeper. Also reduces the indent size automatically for smaller screen
sizes.
2014-02-04 16:34:49 +00:00
2144 changed files with 65043 additions and 14711 deletions
+3
View File
@@ -0,0 +1,3 @@
--errors=errors,duplicate-properties
--warnings=known-properties,display-property-grouping,empty-rules,important
--exclude-list=vendor/,lib/editor/tinymce/,lib/yuilib/,theme/bootstrapbase/style/
+4 -2
View File
@@ -64,6 +64,8 @@ echo "<form id=\"authmenu\" method=\"post\" action=\"auth_config.php\">\n";
echo "<div>\n";
echo "<input type=\"hidden\" name=\"sesskey\" value=\"".sesskey()."\" />\n";
echo "<input type=\"hidden\" name=\"auth\" value=\"".$auth."\" />\n";
// HACK to prevent browsers from automatically inserting the user's password into the wrong fields.
echo prevent_form_autofill_password();
// auth plugin description
echo $OUTPUT->box_start();
@@ -146,8 +148,8 @@ function print_auth_lock_options($auth, $user_fields, $helptext, $retrieveopts,
// If custom field then pick name from database.
$fieldshortname = str_replace('profile_field_', '', $fieldname);
$fieldname = $customfieldname[$fieldshortname]->name;
} elseif (preg_match('/^(.+?)(\d+)$/', $fieldname, $matches)) {
$fieldname = get_string($matches[1]) . ' ' . $matches[2];
} elseif ($fieldname == 'phone1') {
$fieldname = get_string('phone');
} elseif ($fieldname == 'url') {
$fieldname = get_string('webpage');
} else {
+1 -2
View File
@@ -67,7 +67,6 @@ if ($data = data_submitted() and confirm_sesskey()) {
$errormsg = get_string('errorwithsettings', 'admin');
$firsterror = reset($adminroot->errors);
}
$adminroot = admin_get_root(true); //reload tree
$settingspage = $adminroot->locate($category, true);
}
@@ -156,4 +155,4 @@ echo $outputhtml;
echo html_writer::end_tag('fieldset');
echo html_writer::end_tag('form');
echo $OUTPUT->footer();
echo $OUTPUT->footer();
@@ -0,0 +1,103 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* This script fixes orphaned question categories.
*
* Orphaned question categories have had their associated context deleted
* but the category itself remains in the database with an invalid context.
*
* @package core
* @subpackage cli
* @copyright 2013 Tyler Bannister (tyler.bannister@remote-learner.net)
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
define('CLI_SCRIPT', true);
require(__DIR__.'/../../config.php');
require_once($CFG->libdir.'/clilib.php');
require_once($CFG->libdir.'/questionlib.php');
$long = array('fix' => false, 'help' => false);
$short = array('f' => 'fix', 'h' => 'help');
// Now get cli options.
list($options, $unrecognized) = cli_get_params($long, $short);
if ($unrecognized) {
$unrecognized = implode("\n ", $unrecognized);
cli_error(get_string('cliunknowoption', 'admin', $unrecognized));
}
if ($options['help']) {
$help =
"Fix orphaned question categories.
This scripts detects question categories that have had their
context deleted, thus severing them from their original purpose.
This script will find the orphaned categories and delete the unused
questions in each category found. Used questions will not be
deleted, instead they will be moved to a rescue question category.
Options:
-h, --help Print out this help
-f, --fix Fix the orphaned question categories in the DB.
If not specified only check and report problems to STDERR.
Example:
\$sudo -u www-data /usr/bin/php admin/cli/fix_orphaned_question_categories.php
\$sudo -u www-data /usr/bin/php admin/cli/fix_orphaned_question_categories.php -f
";
echo $help;
die;
}
cli_heading('Checking for orphaned categories');
$sql = 'SELECT qc.id, qc.contextid, qc.name
FROM {question_categories} qc
LEFT JOIN {context} c ON qc.contextid = c.id
WHERE c.id IS NULL';
$categories = $DB->get_recordset_sql($sql);
$i = 0;
foreach ($categories as $category) {
$i += 1;
echo "Found orphaned category: {$category->name}\n";
if (!empty($options['fix'])) {
echo "Cleaning...";
// One transaction per category.
$transaction = $DB->start_delegated_transaction();
question_category_delete_safe($category);
$transaction->allow_commit();
echo " Done!\n";
}
}
if (($i > 0) && !empty($options['fix'])) {
echo "Found and removed {$i} orphaned question categories\n";
} else if ($i > 0) {
echo "Found {$i} orphaned question categories. To fix, run:\n";
echo "\$sudo -u www-data /usr/bin/php admin/cli/fix_orphaned_question_categories.php --fix\n";
} else {
echo "No orphaned question categories found.\n";
}
$categories->close();
+1 -1
View File
@@ -52,7 +52,7 @@ $help =
By default InnoDB storage table is using legacy Antelope file format
which has major restriction on database row size.
Use this script to detect and fix database tables with potentail data
Use this script to detect and fix database tables with potential data
overflow problems.
Options:
+300
View File
@@ -1027,6 +1027,7 @@
<VENDOR name="oracle" version="10.2" />
</DATABASE>
<PHP version="5.4.4" level="required">
<RESTRICT function="restrict_php_version_7" message="unsupportedphpversion7" />
</PHP>
<PCREUNICODE level="optional">
<FEEDBACK>
@@ -1134,6 +1135,16 @@
<ON_ERROR message="quizattemptsupgradedmessage" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_slasharguments" level="optional">
<FEEDBACK>
<ON_CHECK message="slashargumentswarning" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_database_tables_row_format" level="optional">
<FEEDBACK>
<ON_CHECK message="unsupporteddbtablerowformat" />
</FEEDBACK>
</CUSTOM_CHECK>
</CUSTOM_CHECKS>
</MOODLE>
<MOODLE version="2.8" requires="2.2">
@@ -1150,6 +1161,7 @@
<VENDOR name="oracle" version="10.2" />
</DATABASE>
<PHP version="5.4.4" level="required">
<RESTRICT function="restrict_php_version_7" message="unsupportedphpversion7" />
</PHP>
<PCREUNICODE level="optional">
<FEEDBACK>
@@ -1257,6 +1269,294 @@
<ON_ERROR message="quizattemptsupgradedmessage" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_slasharguments" level="optional">
<FEEDBACK>
<ON_CHECK message="slashargumentswarning" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_database_tables_row_format" level="optional">
<FEEDBACK>
<ON_CHECK message="unsupporteddbtablerowformat" />
</FEEDBACK>
</CUSTOM_CHECK>
</CUSTOM_CHECKS>
</MOODLE>
<MOODLE version="2.9" requires="2.2">
<UNICODE level="required">
<FEEDBACK>
<ON_ERROR message="unicoderequired" />
</FEEDBACK>
</UNICODE>
<DATABASE level="required">
<VENDOR name="mariadb" version="5.5.31" />
<VENDOR name="mysql" version="5.5.31" />
<VENDOR name="postgres" version="9.1" />
<VENDOR name="mssql" version="10.0" />
<VENDOR name="oracle" version="10.2" />
</DATABASE>
<PHP version="5.4.4" level="required">
<RESTRICT function="restrict_php_version_7" message="unsupportedphpversion7" />
</PHP>
<PCREUNICODE level="optional">
<FEEDBACK>
<ON_CHECK message="pcreunicodewarning" />
</FEEDBACK>
</PCREUNICODE>
<PHP_EXTENSIONS>
<PHP_EXTENSION name="iconv" level="required">
<FEEDBACK>
<ON_ERROR message="iconvrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="mbstring" level="optional">
<FEEDBACK>
<ON_CHECK message="mbstringrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="curl" level="required">
<FEEDBACK>
<ON_ERROR message="curlrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="openssl" level="optional">
<FEEDBACK>
<ON_CHECK message="opensslrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="tokenizer" level="optional">
<FEEDBACK>
<ON_CHECK message="tokenizerrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="xmlrpc" level="optional">
<FEEDBACK>
<ON_CHECK message="xmlrpcrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="soap" level="optional">
<FEEDBACK>
<ON_CHECK message="soaprecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="ctype" level="required">
<FEEDBACK>
<ON_ERROR message="ctyperequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="zip" level="required">
<FEEDBACK>
<ON_ERROR message="ziprequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="zlib" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="gd" level="required">
<FEEDBACK>
<ON_ERROR message="gdrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="simplexml" level="required">
<FEEDBACK>
<ON_ERROR message="simplexmlrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="spl" level="required">
<FEEDBACK>
<ON_ERROR message="splrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="pcre" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="dom" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="xml" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="intl" level="optional">
<FEEDBACK>
<ON_CHECK message="intlrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="json" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="hash" level="required"/>
</PHP_EXTENSIONS>
<PHP_SETTINGS>
<PHP_SETTING name="memory_limit" value="96M" level="required">
<FEEDBACK>
<ON_ERROR message="settingmemorylimit" />
</FEEDBACK>
</PHP_SETTING>
<PHP_SETTING name="file_uploads" value="1" level="optional">
<FEEDBACK>
<ON_CHECK message="settingfileuploads" />
</FEEDBACK>
</PHP_SETTING>
<PHP_SETTING name="opcache.enable" value="1" level="optional">
<FEEDBACK>
<ON_CHECK message="opcacherecommended" />
</FEEDBACK>
</PHP_SETTING>
</PHP_SETTINGS>
<CUSTOM_CHECKS>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_database_storage_engine" level="required">
<FEEDBACK>
<ON_ERROR message="unsupporteddbstorageengine" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="question/engine/upgrade/upgradelib.php" function="quiz_attempts_upgraded" level="required">
<FEEDBACK>
<ON_ERROR message="quizattemptsupgradedmessage" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_slasharguments" level="optional">
<FEEDBACK>
<ON_CHECK message="slashargumentswarning" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_database_tables_row_format" level="optional">
<FEEDBACK>
<ON_CHECK message="unsupporteddbtablerowformat" />
</FEEDBACK>
</CUSTOM_CHECK>
</CUSTOM_CHECKS>
</MOODLE>
<MOODLE version="3.0" requires="2.2">
<UNICODE level="required">
<FEEDBACK>
<ON_ERROR message="unicoderequired" />
</FEEDBACK>
</UNICODE>
<DATABASE level="required">
<VENDOR name="mariadb" version="5.5.31" />
<VENDOR name="mysql" version="5.5.31" />
<VENDOR name="postgres" version="9.1" />
<VENDOR name="mssql" version="10.0" />
<VENDOR name="oracle" version="10.2" />
</DATABASE>
<PHP version="5.4.4" level="required">
<RESTRICT function="restrict_php_version_7" message="unsupportedphpversion7" />
</PHP>
<PCREUNICODE level="optional">
<FEEDBACK>
<ON_CHECK message="pcreunicodewarning" />
</FEEDBACK>
</PCREUNICODE>
<PHP_EXTENSIONS>
<PHP_EXTENSION name="iconv" level="required">
<FEEDBACK>
<ON_ERROR message="iconvrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="mbstring" level="optional">
<FEEDBACK>
<ON_CHECK message="mbstringrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="curl" level="required">
<FEEDBACK>
<ON_ERROR message="curlrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="openssl" level="optional">
<FEEDBACK>
<ON_CHECK message="opensslrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="tokenizer" level="optional">
<FEEDBACK>
<ON_CHECK message="tokenizerrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="xmlrpc" level="optional">
<FEEDBACK>
<ON_CHECK message="xmlrpcrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="soap" level="optional">
<FEEDBACK>
<ON_CHECK message="soaprecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="ctype" level="required">
<FEEDBACK>
<ON_ERROR message="ctyperequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="zip" level="required">
<FEEDBACK>
<ON_ERROR message="ziprequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="zlib" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="gd" level="required">
<FEEDBACK>
<ON_ERROR message="gdrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="simplexml" level="required">
<FEEDBACK>
<ON_ERROR message="simplexmlrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="spl" level="required">
<FEEDBACK>
<ON_ERROR message="splrequired" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="pcre" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="dom" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="xml" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="intl" level="optional">
<FEEDBACK>
<ON_CHECK message="intlrecommended" />
</FEEDBACK>
</PHP_EXTENSION>
<PHP_EXTENSION name="json" level="required">
</PHP_EXTENSION>
<PHP_EXTENSION name="hash" level="required"/>
</PHP_EXTENSIONS>
<PHP_SETTINGS>
<PHP_SETTING name="memory_limit" value="96M" level="required">
<FEEDBACK>
<ON_ERROR message="settingmemorylimit" />
</FEEDBACK>
</PHP_SETTING>
<PHP_SETTING name="file_uploads" value="1" level="optional">
<FEEDBACK>
<ON_CHECK message="settingfileuploads" />
</FEEDBACK>
</PHP_SETTING>
<PHP_SETTING name="opcache.enable" value="1" level="optional">
<FEEDBACK>
<ON_CHECK message="opcacherecommended" />
</FEEDBACK>
</PHP_SETTING>
</PHP_SETTINGS>
<CUSTOM_CHECKS>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_database_storage_engine" level="required">
<FEEDBACK>
<ON_ERROR message="unsupporteddbstorageengine" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="question/engine/upgrade/upgradelib.php" function="quiz_attempts_upgraded" level="required">
<FEEDBACK>
<ON_ERROR message="quizattemptsupgradedmessage" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_slasharguments" level="optional">
<FEEDBACK>
<ON_CHECK message="slashargumentswarning" />
</FEEDBACK>
</CUSTOM_CHECK>
<CUSTOM_CHECK file="lib/upgradelib.php" function="check_database_tables_row_format" level="optional">
<FEEDBACK>
<ON_CHECK message="unsupporteddbtablerowformat" />
</FEEDBACK>
</CUSTOM_CHECK>
</CUSTOM_CHECKS>
</MOODLE>
</COMPATIBILITY_MATRIX>
+30 -17
View File
@@ -514,7 +514,15 @@ if (isguestuser()) {
redirect(get_login_url());
}
$context = context_system::instance();
require_capability('moodle/site:config', $context);
if (!has_capability('moodle/site:config', $context)) {
// Do not throw exception display an empty page with administration menu if visible for current user.
$PAGE->set_title($SITE->fullname);
$PAGE->set_heading($SITE->fullname);
echo $OUTPUT->header();
echo $OUTPUT->footer();
exit;
}
// check that site is properly customized
$site = get_site();
@@ -561,31 +569,36 @@ $cronoverdue = ($lastcron < time() - 3600 * 24);
$dbproblems = $DB->diagnose();
$maintenancemode = !empty($CFG->maintenance_enabled);
// Available updates for Moodle core
// Available updates for Moodle core.
$updateschecker = \core\update\checker::instance();
$availableupdates = array();
$availableupdates['core'] = $updateschecker->get_update_info('core',
array('minmaturity' => $CFG->updateminmaturity, 'notifybuilds' => $CFG->updatenotifybuilds));
$availableupdatesfetch = null;
// Available updates for contributed plugins
$pluginman = core_plugin_manager::instance();
foreach ($pluginman->get_plugins() as $plugintype => $plugintypeinstances) {
foreach ($plugintypeinstances as $pluginname => $plugininfo) {
if (!empty($plugininfo->availableupdates)) {
foreach ($plugininfo->availableupdates as $pluginavailableupdate) {
if ($pluginavailableupdate->version > $plugininfo->versiondisk) {
if (!isset($availableupdates[$plugintype.'_'.$pluginname])) {
$availableupdates[$plugintype.'_'.$pluginname] = array();
if (empty($CFG->disableupdatenotifications)) {
// Only compute the update information when it is going to be displayed to the user.
$availableupdates['core'] = $updateschecker->get_update_info('core',
array('minmaturity' => $CFG->updateminmaturity, 'notifybuilds' => $CFG->updatenotifybuilds));
// Available updates for contributed plugins
$pluginman = core_plugin_manager::instance();
foreach ($pluginman->get_plugins() as $plugintype => $plugintypeinstances) {
foreach ($plugintypeinstances as $pluginname => $plugininfo) {
if (!empty($plugininfo->availableupdates)) {
foreach ($plugininfo->availableupdates as $pluginavailableupdate) {
if ($pluginavailableupdate->version > $plugininfo->versiondisk) {
if (!isset($availableupdates[$plugintype.'_'.$pluginname])) {
$availableupdates[$plugintype.'_'.$pluginname] = array();
}
$availableupdates[$plugintype.'_'.$pluginname][] = $pluginavailableupdate;
}
$availableupdates[$plugintype.'_'.$pluginname][] = $pluginavailableupdate;
}
}
}
}
}
// The timestamp of the most recent check for available updates
$availableupdatesfetch = $updateschecker->get_last_timefetched();
// The timestamp of the most recent check for available updates
$availableupdatesfetch = $updateschecker->get_last_timefetched();
}
$buggyiconvnomb = (!function_exists('mb_convert_encoding') and @iconv('UTF-8', 'UTF-8//IGNORE', '100'.chr(130).'€') !== '100€');
//check if the site is registered on Moodle.org
+1 -1
View File
@@ -11,7 +11,7 @@
echo '<div class="phpinfo">';
ob_start();
phpinfo(INFO_GENERAL + INFO_CONFIGURATION + INFO_MODULES);
phpinfo(INFO_GENERAL + INFO_CONFIGURATION + INFO_MODULES + INFO_VARIABLES);
$html = ob_get_contents();
ob_end_clean();
+1 -1
View File
@@ -65,7 +65,7 @@ if (!empty($registeredhub) and $registeredhub->token == $token) {
$registeredhub->hubname = $hubname;
$registrationmanager->update_registeredhub($registeredhub);
//display notficiation message
// Display notification message.
$notificationmessage = $OUTPUT->notification(
get_string('registrationconfirmedon', 'hub', $hublink), 'notifysuccess');
echo $notificationmessage;
+3 -3
View File
@@ -22,9 +22,9 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL
* @copyright (C) 1999 onwards Martin Dougiamas http://dougiamas.com
*
* On this page the administrator selects which hub he wants to register,
* except for MOOCH. Admins can register with MOOCH with the top admin menu "Registration" link.
* On this page the administrator can also unregister from any hubs, including MOOCH.
* On this page the administrator selects which hub he wants to register (except for moodle.net)
* Admins can register with moodle.net via the site admin menu "Registration" link.
* On this page the administrator can also unregister from any hubs including moodle.net.
*/
require('../../config.php');
+22 -23
View File
@@ -53,31 +53,30 @@ class registration_manager {
public function cron() {
global $CFG;
if (extension_loaded('xmlrpc')) {
//check if the last registration cron update was less than a week ago
$lastcron = get_config('registration', 'crontime');
if ($lastcron === false or $lastcron < strtotime("-7 day")) { //set to a week, see MDL-23704
$function = 'hub_update_site_info';
require_once($CFG->dirroot . "/webservice/xmlrpc/lib.php");
$function = 'hub_update_site_info';
require_once($CFG->dirroot . "/webservice/xmlrpc/lib.php");
//update all hub where the site is registered on
$hubs = $this->get_registered_on_hubs();
foreach ($hubs as $hub) {
//update the registration
$siteinfo = $this->get_site_info($hub->huburl);
$params = array('siteinfo' => $siteinfo);
$serverurl = $hub->huburl . "/local/hub/webservice/webservices.php";
$xmlrpcclient = new webservice_xmlrpc_client($serverurl, $hub->token);
try {
$result = $xmlrpcclient->call($function, $params);
mtrace(get_string('siteupdatedcron', 'hub', $hub->hubname));
} catch (Exception $e) {
$errorparam = new stdClass();
$errorparam->errormessage = $e->getMessage();
$errorparam->hubname = $hub->hubname;
mtrace(get_string('errorcron', 'hub', $errorparam));
}
// Update all hubs where the site is registered.
$hubs = $this->get_registered_on_hubs();
if (empty($hubs)) {
mtrace(get_string('registrationwarning', 'admin'));
}
foreach ($hubs as $hub) {
// Update the registration.
$siteinfo = $this->get_site_info($hub->huburl);
$params = array('siteinfo' => $siteinfo);
$serverurl = $hub->huburl . "/local/hub/webservice/webservices.php";
$xmlrpcclient = new webservice_xmlrpc_client($serverurl, $hub->token);
try {
$result = $xmlrpcclient->call($function, $params);
$this->update_registeredhub($hub); // To update timemodified.
mtrace(get_string('siteupdatedcron', 'hub', $hub->hubname));
} catch (Exception $e) {
$errorparam = new stdClass();
$errorparam->errormessage = $e->getMessage();
$errorparam->hubname = $hub->hubname;
mtrace(get_string('errorcron', 'hub', $errorparam));
}
set_config('crontime', time(), 'registration');
}
} else {
mtrace(get_string('errorcronnoxmlrpc', 'hub'));
+9
View File
@@ -39,6 +39,8 @@ require_once($CFG->dirroot . '/' . $CFG->admin . '/registration/forms.php');
require_once($CFG->dirroot . '/webservice/lib.php');
require_once($CFG->dirroot . '/' . $CFG->admin . '/registration/lib.php');
require_sesskey();
$huburl = required_param('huburl', PARAM_URL);
$huburl = rtrim($huburl, "/");
@@ -177,6 +179,13 @@ if (!empty($error)) {
//some Moodle.org resitration explanation
if ($huburl == HUB_MOODLEORGHUBURL) {
if (!empty($registeredhub->token)) {
$registrationmessage = get_string('pleaserefreshregistration', 'admin');
} else {
$registrationmessage = get_string('registrationwarning', 'admin');
}
echo $OUTPUT->notification($registrationmessage);
echo $OUTPUT->heading(get_string('registerwithmoodleorg', 'admin'));
$renderer = $PAGE->get_renderer('core', 'register');
echo $renderer->moodleorg_registration_message();
+11 -6
View File
@@ -36,13 +36,18 @@ class core_register_renderer extends plugin_renderer_base {
* @return string
*/
public function moodleorg_registration_message() {
$moodleorgurl = html_writer::link('http://moodle.org', 'Moodle.org');
$moodleorgstatsurl = html_writer::link('http://moodle.org/stats', get_string('statsmoodleorg', 'admin'));
$moochurl = html_writer::link(HUB_MOODLEORGHUBURL, get_string('moodleorghubname', 'admin'));
$moodleorgregmsg = get_string('registermoodleorg', 'admin', $moodleorgurl);
$moodleorgstatslink = html_writer::link('http://moodle.net/stats',
get_string('statsmoodleorg', 'admin'),
array('target' => '_blank'));
$hublink = html_writer::link('https://moodle.net/mod/page/view.php?id=1',
get_string('moodleorghubname', 'admin'),
array('target' => '_blank'));
$moodleorgregmsg = get_string('registermoodleorg', 'admin', $hublink);
$items = array(get_string('registermoodleorgli1', 'admin'),
get_string('registermoodleorgli2', 'admin', $moodleorgstatsurl),
get_string('registermoodleorgli3', 'admin', $moochurl));
get_string('registermoodleorgli2', 'admin', $moodleorgstatslink));
$moodleorgregmsg .= html_writer::alist($items);
return $moodleorgregmsg;
}
+6 -2
View File
@@ -50,7 +50,8 @@ $table->set_attribute('class', 'admintable generaltable');
$table->setup();
$plugins = array();
foreach (core_component::get_plugin_list('report') as $plugin => $plugindir) {
$availableplugins = core_component::get_plugin_list('report');
foreach ($availableplugins as $plugin => $plugindir) {
if (get_string_manager()->string_exists('pluginname', 'report_' . $plugin)) {
$strpluginname = get_string('pluginname', 'report_' . $plugin);
} else {
@@ -80,7 +81,10 @@ foreach ($plugins as $plugin => $name) {
$uninstall = html_writer::link($uninstallurl, $struninstall);
}
$stores = $logmanager->get_supported_logstores('report_' . $plugin);
$stores = array();
if (isset($availableplugins[$plugin])) {
$stores = $logmanager->get_supported_logstores('report_' . $plugin);
}
if ($stores === false) {
$supportedstores = get_string('logstorenotrequired', 'admin');
} else if (!empty($stores)) {
+14 -4
View File
@@ -264,6 +264,7 @@ if (($action == 'edit') || ($action == 'new')) {
$strshow = get_string('on', 'repository');
$strhide = get_string('off', 'repository');
$strdelete = get_string('disabled', 'repository');
$struninstall = get_string('uninstallplugin', 'core_admin');
$actionchoicesforexisting = array(
'show' => $strshow,
@@ -286,9 +287,9 @@ if (($action == 'edit') || ($action == 'new')) {
// Table to list plug-ins
$table = new html_table();
$table->head = array(get_string('name'), get_string('isactive', 'repository'), get_string('order'), $settingsstr);
$table->head = array(get_string('name'), get_string('isactive', 'repository'), get_string('order'), $settingsstr, $struninstall);
$table->colclasses = array('leftalign', 'centeralign', 'centeralign', 'centeralign', 'centeralign');
$table->colclasses = array('leftalign', 'centeralign', 'centeralign', 'centeralign', 'centeralign', 'centeralign');
$table->id = 'repositoriessetting';
$table->data = array();
$table->attributes['class'] = 'admintable generaltable';
@@ -384,7 +385,12 @@ if (($action == 'edit') || ($action == 'new')) {
$updowncount++;
$table->data[] = array($i->get_readablename(), $OUTPUT->render($select), $updown, $settings);
$uninstall = '';
if ($uninstallurl = core_plugin_manager::instance()->get_uninstall_url('repository_' . $typename, 'manage')) {
$uninstall = html_writer::link($uninstallurl, $struninstall);
}
$table->data[] = array($i->get_readablename(), $OUTPUT->render($select), $updown, $settings, $uninstall);
if (!in_array($typename, $alreadyplugins)) {
$alreadyplugins[] = $typename;
@@ -400,7 +406,11 @@ if (($action == 'edit') || ($action == 'new')) {
if (!in_array($plugin, $alreadyplugins)) {
$select = new single_select(repository_action_url($plugin, 'repos'), 'action', $actionchoicesfornew, 'delete', null, 'applyto' . basename($plugin));
$select->set_label(get_string('action'), array('class' => 'accesshide'));
$table->data[] = array(get_string('pluginname', 'repository_'.$plugin), $OUTPUT->render($select), '', '');
$uninstall = '';
if ($uninstallurl = core_plugin_manager::instance()->get_uninstall_url('repository_' . $plugin, 'manage')) {
$uninstall = html_writer::link($uninstallurl, $struninstall);
}
$table->data[] = array(get_string('pluginname', 'repository_'.$plugin), $OUTPUT->render($select), '', '', $uninstall);
}
}
}
@@ -472,7 +472,9 @@ class core_role_define_role_table_advanced extends core_role_capability_table_wi
}
protected function get_description_field($id) {
return print_textarea(true, 10, 50, 50, 10, 'description', $this->role->description, 0, true);
return '<textarea class="form-textarea" id="'. s($id) .'" name="description" rows="10" cols="50">' .
htmlspecialchars($this->role->description) .
'</textarea>';
}
protected function get_archetype_field($id) {
+14 -5
View File
@@ -41,15 +41,24 @@ class core_role_existing_role_holders extends core_role_assign_user_selector_bas
list($sort, $sortparams) = users_order_by_sql('u', $search, $this->accesscontext);
$params = array_merge($params, $sortparams);
$sql = "SELECT ra.id AS raid," . $this->required_fields_sql('u') . ",ra.contextid,ra.component
FROM {role_assignments} ra
$fields = "SELECT ra.id AS raid," . $this->required_fields_sql('u') . ",ra.contextid,ra.component ";
$countfields = "SELECT COUNT(1) ";
$sql = "FROM {role_assignments} ra
JOIN {user} u ON u.id = ra.userid
JOIN {context} ctx ON ra.contextid = ctx.id
WHERE $wherecondition
AND ctx.id $ctxcondition
AND ra.roleid = :roleid
ORDER BY ctx.depth DESC, ra.component, $sort";
$contextusers = $DB->get_records_sql($sql, $params);
AND ra.roleid = :roleid";
$order = " ORDER BY ctx.depth DESC, ra.component, $sort";
if (!$this->is_validating()) {
$existinguserscount = $DB->count_records_sql($countfields . $sql, $params);
if ($existinguserscount > $this->maxusersperpage) {
return $this->too_many_results($search, $existinguserscount);
}
}
$contextusers = $DB->get_records_sql($fields . $sql . $order, $params);
// No users at all.
if (empty($contextusers)) {
+1 -1
View File
@@ -132,7 +132,7 @@ if ($courseid == SITEID) {
$PAGE->set_heading($course->fullname.': '.$fullname);
}
echo $OUTPUT->header();
echo $OUTPUT->heading($title, 3);
echo $OUTPUT->heading($title);
echo $OUTPUT->box_start('generalbox boxaligncenter boxwidthnormal');
// Display them.
+3 -3
View File
@@ -22,7 +22,6 @@ if ($data = data_submitted() and confirm_sesskey()) {
if (admin_write_settings($data)) {
$statusmsg = get_string('changessaved');
}
$adminroot = admin_get_root(true); //reload tree
if (!empty($adminroot->errors)) {
$errormsg = get_string('errorwithsettings', 'admin');
@@ -44,10 +43,11 @@ if ($errormsg !== '') {
$resultshtml = admin_search_settings_html($query); // case insensitive search only
echo '<form action="search.php" method="post" id="adminsettings">';
echo '<form action="' . $PAGE->url->out(true) . '" method="post" id="adminsettings">';
echo '<div>';
echo '<input type="hidden" name="sesskey" value="'.sesskey().'" />';
echo '<input type="hidden" name="query" value="'.s($query).'" />';
// HACK to prevent browsers from automatically inserting the user's password into the wrong fields.
echo prevent_form_autofill_password();
echo '</div>';
echo '<fieldset>';
echo '<div class="clearer"><!-- --></div>';
+4 -1
View File
@@ -48,7 +48,6 @@ if ($data = data_submitted() and confirm_sesskey()) {
$errormsg = get_string('errorwithsettings', 'admin');
$firsterror = reset($adminroot->errors);
}
$adminroot = admin_get_root(true); //reload tree
$settingspage = $adminroot->locate($section, true);
}
@@ -78,6 +77,8 @@ if (empty($SITE->fullname)) {
echo html_writer::input_hidden_params($PAGE->url);
echo '<input type="hidden" name="sesskey" value="'.sesskey().'" />';
echo '<input type="hidden" name="return" value="'.$return.'" />';
// HACK to prevent browsers from automatically inserting the user's password into the wrong fields.
echo prevent_form_autofill_password();
echo $settingspage->output_html();
@@ -120,6 +121,8 @@ if (empty($SITE->fullname)) {
echo html_writer::input_hidden_params($PAGE->url);
echo '<input type="hidden" name="sesskey" value="'.sesskey().'" />';
echo '<input type="hidden" name="return" value="'.$return.'" />';
// HACK to prevent browsers from automatically inserting the user's password into the wrong fields.
echo prevent_form_autofill_password();
echo $OUTPUT->heading($settingspage->visiblename);
echo $settingspage->output_html();
+13 -1
View File
@@ -23,6 +23,17 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) { // sp
$temp->add(new admin_setting_configcheckbox('allowuserblockhiding', new lang_string('allowuserblockhiding', 'admin'), new lang_string('configallowuserblockhiding', 'admin'), 1));
$temp->add(new admin_setting_configcheckbox('allowblockstodock', new lang_string('allowblockstodock', 'admin'), new lang_string('configallowblockstodock', 'admin'), 1));
$temp->add(new admin_setting_configtextarea('custommenuitems', new lang_string('custommenuitems', 'admin'), new lang_string('configcustommenuitems', 'admin'), '', PARAM_TEXT, '50', '10'));
$temp->add(new admin_setting_configtextarea(
'customusermenuitems',
new lang_string('customusermenuitems', 'admin'),
new lang_string('configcustomusermenuitems', 'admin'),
'messages,message|/message/index.php|message
myfiles,moodle|/user/files.php|download
mybadges,badges|/badges/mybadges.php|award',
PARAM_TEXT,
'50',
'10'
));
$temp->add(new admin_setting_configcheckbox('enabledevicedetection', new lang_string('enabledevicedetection', 'admin'), new lang_string('configenabledevicedetection', 'admin'), 1));
$temp->add(new admin_setting_devicedetectregex('devicedetectregex', new lang_string('devicedetectregex', 'admin'), new lang_string('devicedetectregex_desc', 'admin'), ''));
$ADMIN->add('themes', $temp);
@@ -53,7 +64,8 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) { // sp
array('0' => new lang_string('default', 'calendar'),
'%I:%M %p' => new lang_string('timeformat_12', 'calendar'),
'%H:%M' => new lang_string('timeformat_24', 'calendar'))));
$temp->add(new admin_setting_configselect('calendar_startwday', new lang_string('configstartwday', 'admin'), new lang_string('helpstartofweek', 'admin'), 0,
$temp->add(new admin_setting_configselect('calendar_startwday', new lang_string('configstartwday', 'admin'),
new lang_string('helpstartofweek', 'admin'), get_string('firstdayofweek', 'langconfig'),
array(
0 => new lang_string('sunday', 'calendar'),
1 => new lang_string('monday', 'calendar'),
+1 -1
View File
@@ -46,7 +46,7 @@ if ($hassiteconfig or has_any_capability($capabilities, $systemcontext)) {
$ADMIN->add('courses',
new admin_externalpage('restorecourse', new lang_string('restorecourse', 'admin'),
new moodle_url('/backup/restorefile.php', array('contextid' => context_system::instance()->id)),
array('moodle/course:create')
array('moodle/restore:restorecourse')
)
);
+2 -2
View File
@@ -75,6 +75,8 @@ if (has_capability('moodle/grade:manage', $systemcontext)
$temp->add(new admin_setting_special_gradepointmax());
$temp->add(new admin_setting_special_gradepointdefault());
$temp->add(new admin_setting_special_grademinmaxtouse());
}
$ADMIN->add('grades', $temp);
@@ -112,8 +114,6 @@ if (has_capability('moodle/grade:manage', $systemcontext)
$defaults = array('value'=>0, 'forced'=>false, 'adv'=>true);
$temp->add(new admin_setting_gradecat_combo('grade_aggregateoutcomes', new lang_string('aggregateoutcomes', 'grades'),
new lang_string('aggregateoutcomes_help', 'grades'), $defaults, $options));
$temp->add(new admin_setting_gradecat_combo('grade_aggregatesubcats', new lang_string('aggregatesubcats', 'grades'),
new lang_string('aggregatesubcats_help', 'grades'), $defaults, $options));
$options = array(0 => new lang_string('none'));
for ($i=1; $i<=20; $i++) {
-3
View File
@@ -278,9 +278,6 @@ if ($hassiteconfig) {
$ADMIN->add('webservicesettings', new admin_externalpage('webservicedocumentation', new lang_string('wsdocapi', 'webservice'), "$CFG->wwwroot/$CFG->admin/webservice/documentation.php", 'moodle/site:config', false));
/// manage service
$temp = new admin_settingpage('externalservices', new lang_string('externalservices', 'webservice'));
$temp->add(new admin_setting_enablemobileservice('enablemobilewebservice',
new lang_string('enablemobilewebservice', 'admin'),
new lang_string('configenablemobilewebservice', 'admin', $enablemobiledoclink), 0));
$temp->add(new admin_setting_heading('manageserviceshelpexplaination', new lang_string('information', 'webservice'), new lang_string('servicehelpexplanation', 'webservice')));
$temp->add(new admin_setting_manageexternalservices());
$ADMIN->add('webservicesettings', $temp);
+2 -1
View File
@@ -35,7 +35,8 @@ if ($hassiteconfig) { // speedup for non-admins, add all caps used on this page
$params = new stdClass();
$params->bytes = $defaultuserquota;
$params->displaysize = display_size($defaultuserquota);
$temp->add(new admin_setting_configtext('userquota', new lang_string('userquota', 'admin'), new lang_string('configuserquota', 'admin', $params), $defaultuserquota));
$temp->add(new admin_setting_configtext('userquota', new lang_string('userquota', 'admin'),
new lang_string('configuserquota', 'admin', $params), $defaultuserquota, PARAM_INT, 30));
$temp->add(new admin_setting_configcheckbox('allowobjectembed', new lang_string('allowobjectembed', 'admin'), new lang_string('configallowobjectembed', 'admin'), 0));
$temp->add(new admin_setting_configcheckbox('enabletrusttext', new lang_string('enabletrusttext', 'admin'), new lang_string('configenabletrusttext', 'admin'), 0));
+1 -1
View File
@@ -11,7 +11,7 @@ $hassiteconfig = has_capability('moodle/site:config', $systemcontext);
$ADMIN->add('root', new admin_externalpage('adminnotifications', new lang_string('notifications'), "$CFG->wwwroot/$CFG->admin/index.php"));
$ADMIN->add('root', new admin_externalpage('registrationmoodleorg', new lang_string('registration', 'admin'),
"$CFG->wwwroot/$CFG->admin/registration/register.php?huburl=" . HUB_MOODLEORGHUBURL . "&hubname=Moodle.org"));
"$CFG->wwwroot/$CFG->admin/registration/register.php?huburl=" . HUB_MOODLEORGHUBURL . "&hubname=Moodle.org&sesskey=" . sesskey()));
$ADMIN->add('root', new admin_externalpage('registrationhub', new lang_string('registerwith', 'hub'),
"$CFG->wwwroot/$CFG->admin/registration/register.php", 'moodle/site:config', true));
$ADMIN->add('root', new admin_externalpage('registrationhubs', new lang_string('hubs', 'admin'),
+24
View File
@@ -114,6 +114,30 @@ class behat_admin extends behat_base {
}
}
/**
* Sets the specified site settings. A table with | config | value | (optional)plugin | is expected.
*
* @Given /^the following config values are set as admin:$/
* @param TableNode $table
*/
public function the_following_config_values_are_set_as_admin(TableNode $table) {
if (!$data = $table->getRowsHash()) {
return;
}
foreach ($data as $config => $value) {
// Default plugin value is null.
$plugin = null;
if (is_array($value)) {
$plugin = $value[1];
$value = $value[0];
}
set_config($config, $value, $plugin);
}
}
/**
* Waits with the provided params if we are running a JS session.
*
+6 -6
View File
@@ -7,10 +7,10 @@ Feature: An administrator can filter user accounts by role, cohort and other pro
Background:
Given the following "users" exist:
| username | firstname | lastname | email | auth | confirmed |
| user1 | User | One | one@asd.com | manual | 0 |
| user2 | User | Two | two@asd.com | ldap | 1 |
| user3 | User | Three | three@asd.com | manual | 1 |
| user4 | User | Four | four@asd.com | ldap | 0 |
| user1 | User | One | one@example.com | manual | 0 |
| user2 | User | Two | two@example.com | ldap | 1 |
| user3 | User | Three | three@example.com | manual | 1 |
| user4 | User | Four | four@example.com | ldap | 0 |
And the following "cohorts" exist:
| name | idnumber |
| Cohort 1 | CH1 |
@@ -23,8 +23,8 @@ Feature: An administrator can filter user accounts by role, cohort and other pro
| user2 | C1 | student |
| user3 | C1 | student |
And I log in as "admin"
And I add "User Two (two@asd.com)" user to "CH1" cohort members
And I add "User Three (three@asd.com)" user to "CH1" cohort members
And I add "User Two (two@example.com)" user to "CH1" cohort members
And I add "User Three (three@example.com)" user to "CH1" cohort members
And I follow "Browse list of users"
@javascript
@@ -13,15 +13,13 @@ Feature: Set admin settings value
And I should not see "C_shortname Course fullname"
Scenario: set admin value with full name
Given I set the following administration settings values:
| Display extended course names | 1 |
When I press "Save changes"
Given the following config values are set as admin:
| courselistshortnames | 1 |
And I am on homepage
Then I should see "C_shortname Course fullname"
Scenario: set admin value with short name
Given I set the following administration settings values:
Given the following config values are set as admin:
| courselistshortnames | 1 |
When I press "Save changes"
And I am on homepage
Then I should see "C_shortname Course fullname"
+2 -2
View File
@@ -21,7 +21,7 @@ Feature: Upload users
And I should see "Tom"
And I should see "Jones"
And I should see "verysecret"
And I should see "jonest@someplace.edu"
And I should see "jonest@example.com"
And I should see "Reznor"
And I should see "course1"
And I should see "math102"
@@ -32,7 +32,7 @@ Feature: Upload users
And I follow "Browse list of users"
And I should see "Tom Jones"
And I should see "Trent Reznor"
And I should see "reznor@someplace.edu"
And I should see "reznor@example.com"
And I am on homepage
And I follow "Maths"
And I expand "Users" node
+3 -3
View File
@@ -24,7 +24,7 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200;
$plugin->requires = 2014050800;
$plugin->version = 2014111000;
$plugin->requires = 2014110400;
$plugin->component = 'tool_assignmentupgrade';
$plugin->dependencies = array('mod_assign' => 2014050800);
$plugin->dependencies = array('mod_assign' => 2014110400);
@@ -13,8 +13,8 @@ Feature: Manage availability conditions
Then I should not see "Availability restrictions"
# Enable it and check I can now see and click on it.
And I set the following administration settings values:
| Enable conditional access | 1 |
And the following config values are set as admin:
| enableavailability | 1 |
And I am on homepage
And I navigate to "Manage restrictions" node in "Site administration > Plugins > Availability restrictions"
@@ -28,9 +28,9 @@ Feature: Manage availability conditions
Given the following "courses" exist:
| fullname | shortname | format |
| Course 1 | C1 | topics |
And the following config values are set as admin:
| enableavailability | 1 |
And I log in as "admin"
And I set the following administration settings values:
| Enable conditional access | 1 |
And I am on homepage
When I navigate to "Manage restrictions" node in "Site administration > Plugins > Availability restrictions"
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200;
$plugin->requires = 2014050800;
$plugin->version = 2014111000;
$plugin->requires = 2014110400;
$plugin->component = 'tool_availabilityconditions';
+8 -16
View File
@@ -44,13 +44,19 @@ require_once(__DIR__ . '/../../../../lib/behat/lib.php');
chdir(__DIR__);
$output = null;
exec("php util.php --diag", $output, $code);
// Ensure we have composer installed, before we install or re-install test site.
if ($code == TESTING_EXITCODE_COMPOSER || $code == BEHAT_EXITCODE_INSTALL || $code == BEHAT_EXITCODE_REINSTALL) {
testing_update_composer_dependencies();
chdir(__DIR__);
exec("php util.php --diag", $output, $code);
}
if ($code == 0) {
echo "Behat test environment already installed\n";
} else if ($code == BEHAT_EXITCODE_INSTALL) {
testing_update_composer_dependencies();
// Behat and dependencies are installed and we need to install the test site.
chdir(__DIR__);
passthru("php util.php --install", $code);
@@ -60,8 +66,6 @@ if ($code == 0) {
} else if ($code == BEHAT_EXITCODE_REINSTALL) {
testing_update_composer_dependencies();
// Test site data is outdated.
chdir(__DIR__);
passthru("php util.php --drop", $code);
@@ -74,18 +78,6 @@ if ($code == 0) {
exit($code);
}
} else if ($code == BEHAT_EXITCODE_COMPOSER) {
// Missing Behat dependencies.
testing_update_composer_dependencies();
// Returning to admin/tool/behat/cli.
chdir(__DIR__);
passthru("php util.php --install", $code);
if ($code != 0) {
exit($code);
}
} else {
// Generic error, we just output it.
echo implode("\n", $output)."\n";
+1 -1
View File
@@ -165,7 +165,7 @@ class tool_behat_renderer extends plugin_renderer_base {
// Info.
$installurl = behat_command::DOCS_URL . '#Installation';
$installlink = html_writer::tag('a', $installurl, array('href' => $installurl, 'target' => '_blank'));
$writetestsurl = behat_command::DOCS_URL . '#Writting_features';
$writetestsurl = behat_command::DOCS_URL . '#Writing_features';
$writetestslink = html_writer::tag('a', $writetestsurl, array('href' => $writetestsurl, 'target' => '_blank'));
$writestepsurl = behat_command::DOCS_URL . '#Adding_steps_definitions';
$writestepslink = html_writer::tag('a', $writestepsurl, array('href' => $writestepsurl, 'target' => '_blank'));
@@ -69,8 +69,8 @@ Feature: Set up contextual data for tests
Scenario: Role overrides
Given the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Teacher | 1 | teacher1@asd.com |
| student1 | Student | 1 | student1@asd.com |
| teacher1 | Teacher | 1 | teacher1@example.com |
| student1 | Student | 1 | student1@example.com |
And the following "categories" exist:
| name | category | idnumber |
| Cat 1 | 0 | CAT1 |
@@ -99,7 +99,7 @@ Feature: Set up contextual data for tests
Scenario: Add course enrolments
Given the following "users" exist:
| username | firstname | lastname | email |
| student1 | Student | 1 | student1@asd.com |
| student1 | Student | 1 | student1@example.com |
And the following "courses" exist:
| fullname | shortname | format |
| Course 1 | C1 | topics |
@@ -117,11 +117,11 @@ Feature: Set up contextual data for tests
| Custom student | custom2 | | |
And the following "users" exist:
| username | firstname | lastname | email |
| user1 | User | 1 | user1@moodlemoodle.com |
| user2 | User | 2 | user2@moodlemoodle.com |
| user3 | User | 3 | user3@moodlemoodle.com |
| user4 | User | 4 | user4@moodlemoodle.com |
| user5 | User | 5 | user5@moodlemoodle.com |
| user1 | User | 1 | user1@example.com |
| user2 | User | 2 | user2@example.com |
| user3 | User | 3 | user3@example.com |
| user4 | User | 4 | user4@example.com |
| user5 | User | 5 | user5@example.com |
And the following "categories" exist:
| name | category | idnumber |
| Cat 1 | 0 | CAT1 |
@@ -185,6 +185,12 @@ Feature: Set up contextual data for tests
| url | Test url name | Test url description | C1 | url1 |
| wiki | Test wiki name | Test wiki description | C1 | wiki1 |
| workshop | Test workshop name | Test workshop description | C1 | workshop1 |
And the following "scales" exist:
| name | scale |
| Test Scale 1 | Disappointing, Good, Very good, Excellent |
And the following "activities" exist:
| activity | name | intro | course | idnumber | grade |
| assign | Test assignment name with scale | Test assignment description | C1 | assign1 | Test Scale 1 |
When I log in as "admin"
And I follow "Course 1"
Then I should see "Test assignment name"
@@ -214,13 +220,17 @@ Feature: Set up contextual data for tests
And I should see "Test workshop name"
And I follow "Test assignment name"
And I should see "Test assignment description"
And I follow "C1"
And I follow "Test assignment name with scale"
And I follow "Edit settings"
And the field "Type" matches value "Scale"
@javascript
Scenario: Add relations between users and groups
Given the following "users" exist:
| username | firstname | lastname | email |
| student1 | Student | 1 | student1@asd.com |
| student2 | Student | 2 | student2@asd.com |
| student1 | Student | 1 | student1@example.com |
| student2 | Student | 2 | student2@example.com |
And the following "courses" exist:
| fullname | shortname |
| Course 1 | C1 |
@@ -259,8 +269,8 @@ Feature: Set up contextual data for tests
| Cat 1 | 0 | CAT1 |
And the following "users" exist:
| username | firstname | lastname | email |
| student1 | Student | 1 | student1@asd.com |
| student2 | Student | 2 | student2@asd.com |
| student1 | Student | 1 | student1@example.com |
| student2 | Student | 2 | student2@example.com |
And the following "cohorts" exist:
| name | idnumber |
| System cohort A | CHSA |
@@ -297,13 +307,124 @@ Feature: Set up contextual data for tests
| Course 1 | C1 |
And the following "grade categories" exist:
| fullname | course |
| Grade category 1 | C1|
| Grade category 1 | C1 |
And the following "grade categories" exist:
| fullname | course | gradecategory |
| Grade sub category 2 | C1 | Grade category 1|
| Grade sub category 2 | C1 | Grade category 1 |
When I log in as "admin"
And I follow "Courses"
And I follow "Course 1"
And I navigate to "Grades" node in "Course administration"
Then I should see "Grade category 1"
And I should see "Grade sub category 2"
Scenario: Add a bunch of grade items
Given the following "courses" exist:
| fullname | shortname |
| Course 1 | C1 |
And the following "grade categories" exist:
| fullname | course |
| Grade category 1 | C1 |
And the following "grade categories" exist:
| fullname | course | gradecategory |
| Grade sub category 2 | C1 | Grade category 1 |
And the following "grade items" exist:
| itemname | course |
| Test Grade Item 1 | C1 |
And the following "grade items" exist:
| itemname | course | gradecategory |
| Test Grade Item 2 | C1 | Grade category 1 |
| Test Grade Item 3 | C1 | Grade sub category 2 |
When I log in as "admin"
And I follow "Course 1"
And I follow "Grades"
And I expand "Setup" node
And I follow "Categories and items"
Then I should see "Test Grade Item 1"
And I follow "Edit Test Grade Item 1"
And I expand all fieldsets
And I should see "Course 1"
And I press "Cancel"
And I should see "Grade category 1"
And I should see "Test Grade Item 2"
And I follow "Edit Test Grade Item 2"
And I expand all fieldsets
And I should see "Grade category 1"
And I press "Cancel"
And I should see "Grade sub category 2"
And I should see "Test Grade Item 3"
And I follow "Edit Test Grade Item 3"
And I expand all fieldsets
And I should see "Grade sub category 2"
And I press "Cancel"
Scenario: Add a bunch of scales
Given the following "courses" exist:
| fullname | shortname |
| Course 1 | C1 |
And the following "scales" exist:
| name | scale |
| Test Scale 1 | Disappointing, Good, Very good, Excellent |
When I log in as "admin"
And I follow "Course 1"
And I follow "Grades"
And I follow "Scales"
Then I should see "Test Scale 1"
And I should see "Disappointing, Good, Very good, Excellent"
Scenario: Add a bunch of outcomes
Given the following "courses" exist:
| fullname | shortname |
| Course 1 | C1 |
And the following "scales" exist:
| name | scale |
| Test Scale 1 | Disappointing, Good, Very good, Excellent |
And the following "grade outcomes" exist:
| fullname | shortname | scale |
| Grade outcome 1 | OT1 | Test Scale 1 |
And the following "grade outcomes" exist:
| fullname | shortname | course | scale |
| Grade outcome 2 | OT2 | C1 | Test Scale 1 |
And the following config values are set as admin:
| enableoutcomes | 1 |
When I log in as "admin"
And I follow "Home"
And I follow "Course 1"
And I follow "Outcomes"
Then I should see "Grade outcome 1" in the "#addoutcomes" "css_element"
And I should see "Grade outcome 2" in the "#removeoutcomes" "css_element"
And I follow "Edit outcomes"
And the following should exist in the "generaltable" table:
| Full name | Short name | Scale |
| Grade outcome 2 | OT2 | Test Scale 1 |
Scenario: Add a bunch of outcome grade items
Given the following "courses" exist:
| fullname | shortname |
| Course 1 | C1 |
And the following "scales" exist:
| name | scale |
| Test Scale 1 | Disappointing, Good, Very good, Excellent |
And the following "grade outcomes" exist:
| fullname | shortname | course | scale |
| Grade outcome 1 | OT1 | C1 | Test Scale 1 |
And the following "grade categories" exist:
| fullname | course |
| Grade category 1 | C1 |
And the following "grade items" exist:
| itemname | course | outcome | gradecategory |
| Test Outcome Grade Item 1 | C1 | OT1 | Grade category 1 |
And the following config values are set as admin:
| enableoutcomes | 1 |
When I log in as "admin"
And I follow "Home"
And I follow "Course 1"
And I follow "Grades"
And I expand "Setup" node
And I follow "Categories and items"
Then I should see "Test Outcome Grade Item 1"
And I follow "Edit Test Outcome Grade Item 1"
And the field "Outcome" matches value "Grade outcome 1"
And I expand all fieldsets
And "//div[contains(@class, 'fitem')]/div[contains(@class, 'fitemtitle')]/div[contains(@class, fstaticlabel) and contains(., 'Grade category')]/../../div[contains(@class, 'felement') and contains(., 'Grade category 1')]" "xpath_element" should exist
And I press "Cancel"
@@ -7,7 +7,7 @@ Feature: Edit capabilities
Background:
Given the following "users" exist:
| username | firstname | lastname | email |
| teacher1 | Teacher | 1 | teacher1@asd.com |
| teacher1 | Teacher | 1 | teacher1@example.com |
And the following "courses" exist:
| fullname | shortname | category |
| Course 1 | C1 | 0 |
@@ -15,7 +15,6 @@ Feature: Edit capabilities
| user | course | role |
| teacher1 | C1 | editingteacher |
@javascript
Scenario: Default system capabilities modification
Given I log in as "admin"
And I set the following system permissions of "Teacher" role:
@@ -30,7 +29,6 @@ Feature: Edit capabilities
And "moodle/grade:managesharedforms" capability has "Prevent" permission
And "moodle/course:request" capability has "Prohibit" permission
@javascript
Scenario: Course capabilities overrides
Given I log in as "teacher1"
And I follow "Course 1"
@@ -41,11 +39,11 @@ Feature: Edit capabilities
| mod/forum:editanypost | Prevent |
| mod/forum:addquestion | Allow |
When I set the field "Advanced role override" to "Student (3)"
And I press "Go"
Then "mod/forum:deleteanypost" capability has "Prohibit" permission
And "mod/forum:editanypost" capability has "Prevent" permission
And "mod/forum:addquestion" capability has "Allow" permission
@javascript
Scenario: Module capabilities overrides
Given I log in as "teacher1"
And I follow "Course 1"
@@ -60,6 +58,7 @@ Feature: Edit capabilities
| mod/forum:editanypost | Prevent |
| mod/forum:addquestion | Allow |
When I set the field "Advanced role override" to "Student (3)"
And I press "Go"
Then "mod/forum:deleteanypost" capability has "Prohibit" permission
And "mod/forum:editanypost" capability has "Prevent" permission
And "mod/forum:addquestion" capability has "Allow" permission
@@ -10,9 +10,9 @@ Feature: Verify that all form fields values can be get and set
| Course 1 | C1 | 0 |
And the following "users" exist:
| username | email | firstname | lastname |
| student1 | s1@asd.com | Student | 1 |
| student2 | s2@asd.com | Student | 2 |
| student3 | s3@asd.com | Student | 3 |
| student1 | s1@example.com | Student | 1 |
| student2 | s2@example.com | Student | 2 |
| student3 | s3@example.com | Student | 3 |
And the following "course enrolments" exist:
| user | course | role |
| student1 | C1 | student |
@@ -137,6 +137,17 @@ Feature: Verify that all form fields values can be get and set
And I press "Save my choice"
And the field "one" matches value "1"
And the field "two" matches value ""
# Check if field xpath set/match works.
And I am on site homepage
And I follow "Course 1"
And I navigate to "Edit settings" node in "Course administration"
And I set the field with xpath "//input[@id='id_idnumber']" to "Course id number"
And the field with xpath "//input[@name='idnumber']" matches value "Course id number"
And the field with xpath "//input[@name='idnumber']" does not match value ""
And I press "Save changes"
And I navigate to "Edit settings" node in "Course administration"
And the field "Course ID number" matches value "Course id number"
Scenario: with JS disabled all form fields getters and setters works as expected
+2 -2
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200; // The current plugin version (Date: YYYYMMDDXX)
$plugin->requires = 2014050800; // Requires this Moodle version
$plugin->version = 2014111000; // The current plugin version (Date: YYYYMMDDXX)
$plugin->requires = 2014110400; // Requires this Moodle version
$plugin->component = 'tool_behat'; // Full name of the plugin (used for diagnostics)
+2 -2
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014050800; // Requires this Moodle version.
$plugin->version = 2014111000; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014110400; // Requires this Moodle version.
$plugin->component = 'tool_capability'; // Full name of the plugin (used for diagnostics).
@@ -83,7 +83,6 @@ SEARCH.prototype = {
div.append(label).append(this.input);
this.select.insert(div, 'before');
this.select.one('option').setStyle('display', 'none');
this.input.on('keyup', this.typed, this);
this.select.on('change', this.validate, this);
@@ -1 +1 @@
YUI.add("moodle-tool_capability-search",function(e,t){var n=function(){n.superclass.constructor.apply(this,arguments)};n.prototype={form:null,select:null,selectoptions:{},input:null,button:null,lastsearch:null,initializer:function(){this.form=e.one("#capability-overview-form"),this.select=this.form.one("select[data-search=capability]"),this.select.setStyle("minWidth",this.select.get("offsetWidth")),this.select.get("options").each(function(e){var t=e.get("value");this.selectoptions[t]=e},this),this.button=this.form.all("input[type=submit]"),this.lastsearch=this.form.one("input[name=search]");var t=e.Node.create('<div id="capabilitysearchui"></div>'),n=e.Node.create('<label for="capabilitysearch">'+this.get("strsearch")+"</label>");this.input=e.Node.create('<input type="text" id="capabilitysearch" />'),t.append(n).append(this.input),this.select.insert(t,"before"),this.select.one("option").setStyle("display","none"),this.input.on("keyup",this.typed,this),this.select.on("change",this.validate,this),this.lastsearch&&(this.input.set("value",this.lastsearch.get("value")),this.typed(),this.select.one("option[selected]")&&this.select.set("scrollTop",this.select.one("option[selected]").get("getX"))),this.validate()},validate:function(){this.button.set("disabled",this.select.get("value")==="")},typed:function(){var e=this.input.get("value"),t=0,n=null,r;this.lastsearch&&this.lastsearch.set("value",e),this.select.all("option").remove();for(r in this.selectoptions)r.indexOf(e)>=0&&(t++,n=this.selectoptions[r],this.select.append(this.selectoptions[r]));t===0?this.input.addClass("error"):(this.input.removeClass("error"),t===1&&n.set("selected",!0)),this.validate()}},e.extend(n,e.Base,n.prototype,{NAME:"tool_capability-search",ATTRS:{strsearch:{}}}),M.tool_capability=M.tool_capability||{},M.tool_capability.init_capability_search=function(e){new n(e)}},"@VERSION@",{requires:["base","node"]});
YUI.add("moodle-tool_capability-search",function(e,t){var n=function(){n.superclass.constructor.apply(this,arguments)};n.prototype={form:null,select:null,selectoptions:{},input:null,button:null,lastsearch:null,initializer:function(){this.form=e.one("#capability-overview-form"),this.select=this.form.one("select[data-search=capability]"),this.select.setStyle("minWidth",this.select.get("offsetWidth")),this.select.get("options").each(function(e){var t=e.get("value");this.selectoptions[t]=e},this),this.button=this.form.all("input[type=submit]"),this.lastsearch=this.form.one("input[name=search]");var t=e.Node.create('<div id="capabilitysearchui"></div>'),n=e.Node.create('<label for="capabilitysearch">'+this.get("strsearch")+"</label>");this.input=e.Node.create('<input type="text" id="capabilitysearch" />'),t.append(n).append(this.input),this.select.insert(t,"before"),this.input.on("keyup",this.typed,this),this.select.on("change",this.validate,this),this.lastsearch&&(this.input.set("value",this.lastsearch.get("value")),this.typed(),this.select.one("option[selected]")&&this.select.set("scrollTop",this.select.one("option[selected]").get("getX"))),this.validate()},validate:function(){this.button.set("disabled",this.select.get("value")==="")},typed:function(){var e=this.input.get("value"),t=0,n=null,r;this.lastsearch&&this.lastsearch.set("value",e),this.select.all("option").remove();for(r in this.selectoptions)r.indexOf(e)>=0&&(t++,n=this.selectoptions[r],this.select.append(this.selectoptions[r]));t===0?this.input.addClass("error"):(this.input.removeClass("error"),t===1&&n.set("selected",!0)),this.validate()}},e.extend(n,e.Base,n.prototype,{NAME:"tool_capability-search",ATTRS:{strsearch:{}}}),M.tool_capability=M.tool_capability||{},M.tool_capability.init_capability_search=function(e){new n(e)}},"@VERSION@",{requires:["base","node"]});
@@ -83,7 +83,6 @@ SEARCH.prototype = {
div.append(label).append(this.input);
this.select.insert(div, 'before');
this.select.one('option').setStyle('display', 'none');
this.input.on('keyup', this.typed, this);
this.select.on('change', this.validate, this);
-1
View File
@@ -81,7 +81,6 @@ SEARCH.prototype = {
div.append(label).append(this.input);
this.select.insert(div, 'before');
this.select.one('option').setStyle('display', 'none');
this.input.on('keyup', this.typed, this);
this.select.on('change', this.validate, this);
+3
View File
@@ -48,5 +48,8 @@ function xmldb_tool_customlang_upgrade($oldversion) {
// Moodle v2.7.0 release upgrade line.
// Put any upgrade step following this.
// Moodle v2.8.0 release upgrade line.
// Put any upgrade step following this.
return true;
}
+1 -1
View File
@@ -63,7 +63,7 @@ if ($translatorsubmitted) {
$checkin = optional_param('savecheckin', false, PARAM_RAW);
if ($checkin === false) {
$nexturl = $PAGE->url;
$nexturl = new moodle_url($PAGE->url, array('p' => $currentpage));
} else {
$nexturl = new moodle_url('/admin/tool/customlang/index.php', array('action'=>'checkin', 'lng' => $lng, 'sesskey'=>sesskey()));
}
+1
View File
@@ -133,6 +133,7 @@ class tool_customlang_renderer extends plugin_renderer_base {
$output .= html_writer::start_tag('div');
$output .= html_writer::empty_tag('input', array('type'=>'hidden', 'name'=>'translatorsubmitted', 'value'=>1));
$output .= html_writer::empty_tag('input', array('type'=>'hidden', 'name'=>'sesskey', 'value'=>sesskey()));
$output .= html_writer::empty_tag('input', array('type'=>'hidden', 'name'=>'p', 'value'=>$translator->currentpage));
$save1 = html_writer::empty_tag('input', array('type'=>'submit', 'name'=>'savecontinue', 'value'=>get_string('savecontinue', 'tool_customlang')));
$save2 = html_writer::empty_tag('input', array('type'=>'submit', 'name'=>'savecheckin', 'value'=>get_string('savecheckin', 'tool_customlang')));
$output .= html_writer::tag('fieldset', $save1.$save2, array('class'=>'buttonsbar'));
+2 -2
View File
@@ -25,6 +25,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200;
$plugin->requires = 2014050800;
$plugin->version = 2014111000;
$plugin->requires = 2014110400;
$plugin->component = 'tool_customlang'; // Full name of the plugin (used for diagnostics)
+2 -2
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014050800; // Requires this Moodle version.
$plugin->version = 2014111000; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014110400; // Requires this Moodle version.
$plugin->component = 'tool_dbtransfer'; // Full name of the plugin (used for diagnostics).
@@ -208,10 +208,13 @@ class tool_generator_course_backend extends tool_generator_backend {
*/
private function create_course() {
$this->log('createcourse', $this->shortname);
$courserecord = array('shortname' => $this->shortname,
'fullname' => get_string('fullname', 'tool_generator',
array('size' => get_string('shortsize_' . $this->size, 'tool_generator'))),
'numsections' => self::$paramsections[$this->size]);
$courserecord = array(
'shortname' => $this->shortname,
'fullname' => get_string('fullname', 'tool_generator',
array('size' => get_string('shortsize_' . $this->size, 'tool_generator'))),
'numsections' => self::$paramsections[$this->size],
'startdate' => usergetmidnight(time())
);
return $this->generator->create_course($courserecord, array('createsections' => true));
}
@@ -308,8 +311,7 @@ class tool_generator_course_backend extends tool_generator_backend {
$username = 'tool_generator_' . $textnumber;
// Create user account.
$record = array('firstname' => get_string('firstname', 'tool_generator'),
'lastname' => $number, 'username' => $username);
$record = array('username' => $username, 'idnumber' => $number);
// We add a user password if it has been specified.
if (!empty($CFG->tool_generator_users_password)) {
@@ -62,7 +62,6 @@ $string['error_nonexistingcourse'] = 'The specified course does not exist';
$string['error_nopageinstances'] = 'The selected course does not contain page module instances';
$string['error_notdebugging'] = 'Not available on this server because debugging is not set to DEVELOPER';
$string['error_nouserspassword'] = 'You need to set $CFG->tool_generator_users_password in config.php to generate the test plan';
$string['firstname'] = 'Test course user';
$string['fullname'] = 'Test course: {$a->size}';
$string['maketestcourse'] = 'Make test course';
$string['maketestplan'] = 'Make JMeter test plan';
@@ -136,7 +136,7 @@ class tool_generator_maketestcourse_testcase extends advanced_testcase {
$lastusernumber = 0;
$discussionstarters = array();
foreach ($discussions as $discussion) {
$usernumber = intval($discussion->lastname);
$usernumber = core_user::get_user($discussion->userid, 'id, idnumber')->idnumber;
// Checks that the users are odd numbers.
$this->assertEquals(1, $usernumber % 2);
+2 -2
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200;
$plugin->requires = 2014050800;
$plugin->version = 2014111000;
$plugin->requires = 2014110400;
$plugin->component = 'tool_generator';
+1 -1
View File
@@ -23,7 +23,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
$string['healthnoproblemsfound'] = 'There is no health problem found!';
$string['healthnoproblemsfound'] = 'No health problems were found!';
$string['healthproblemsdetected'] = 'Health problems detected!';
$string['healthproblemsolution'] = 'Health problem solution';
$string['healthreturntomain'] = 'Continue';
+2 -2
View File
@@ -25,8 +25,8 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200; // The current plugin version (Date: YYYYMMDDXX)
$plugin->requires = 2014050800; // Requires this Moodle version
$plugin->version = 2014111000; // The current plugin version (Date: YYYYMMDDXX)
$plugin->requires = 2014110400; // Requires this Moodle version
$plugin->component = 'tool_health'; // Full name of the plugin (used for diagnostics)
$plugin->maturity = MATURITY_ALPHA; // this version's maturity level
+2 -2
View File
@@ -25,6 +25,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200; // The current plugin version (Date: YYYYMMDDXX)
$plugin->requires = 2014050800; // Requires this Moodle version
$plugin->version = 2014111000; // The current plugin version (Date: YYYYMMDDXX)
$plugin->requires = 2014110400; // Requires this Moodle version
$plugin->component = 'tool_innodb'; // Full name of the plugin (used for diagnostics)
@@ -66,6 +66,7 @@ $string['validationmsg_filenotexists'] = 'Extracted file not found';
$string['validationmsg_filesnumber'] = 'Not enough files found in the package';
$string['validationmsg_filestatus'] = 'Unable to extract all files';
$string['validationmsg_filestatus_info'] = 'Attempting to extract file {$a->file} resulted in error \'{$a->status}\'.';
$string['validationmsg_foundlangfile'] = 'Found language file';
$string['validationmsg_maturity'] = 'Declared maturity level';
$string['validationmsg_maturity_help'] = 'The plugin can declare its maturity level. If the maintainer considers the plugin stable, the declared maturity level will read MATURITY_STABLE. All other maturity levels (such as alpha or beta) should be considered unstable and a warning is raised.';
$string['validationmsg_missingexpectedlangenfile'] = 'English language file name mismatch';
+2 -2
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->component = 'tool_installaddon';
$plugin->version = 2014051200;
$plugin->requires = 2014050800;
$plugin->version = 2014111000;
$plugin->requires = 2014110400;
$plugin->maturity = MATURITY_STABLE;
+2 -28
View File
@@ -156,7 +156,7 @@ class controller {
$updateablelangs = array();
foreach ($currentlangs as $clang) {
if (!array_key_exists($clang, $md5array)) {
$noticeok[] = get_string('langpackupdateskipped', 'tool_langimport', $clang);
$this->info[] = get_string('langpackupdateskipped', 'tool_langimport', $clang);
continue;
}
$dest1 = $CFG->dataroot.'/lang/'.$clang;
@@ -175,36 +175,10 @@ class controller {
}
}
// Clean-up currently installed versions of the packs.
foreach ($neededlangs as $packindex => $pack) {
if ($pack == 'en') {
continue;
}
// Delete old directories.
$dest1 = $CFG->dataroot.'/lang/'.$pack;
$dest2 = $CFG->dirroot.'/lang/'.$pack;
if (file_exists($dest1)) {
if (!remove_dir($dest1)) {
$noticeerror[] = 'Could not delete old directory '.$dest1.', update of '.$pack
.' failed, please check permissions.';
unset($neededlangs[$packindex]);
continue;
}
}
if (file_exists($dest2)) {
if (!remove_dir($dest2)) {
$noticeerror[] = 'Could not delete old directory '.$dest2.', update of '.$pack
.' failed, please check permissions.';
unset($neededlangs[$packindex]);
continue;
}
}
}
try {
$updated = $this->install_languagepacks($neededlangs, true);
} catch (\moodle_exception $e) {
$this->errors[] = 'An exception occurred while installing language packs: ' . $e->getMessage();
return false;
}
@@ -36,6 +36,7 @@ defined('MOODLE_INTERNAL') || die();
* }
*
* @package tool_langimport
* @since Moodle 2.8
* @copyright 2014 Dan Poltawski <dan@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
@@ -36,6 +36,7 @@ defined('MOODLE_INTERNAL') || die();
* }
*
* @package tool_langimport
* @since Moodle 2.8
* @copyright 2014 Dan Poltawski <dan@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
@@ -36,6 +36,7 @@ defined('MOODLE_INTERNAL') || die();
* }
*
* @package tool_langimport
* @since Moodle 2.8
* @copyright 2014 Dan Poltawski <dan@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
@@ -45,6 +45,14 @@ class update_langpacks_task extends \core\task\scheduled_task {
* Run langpack update
*/
public function execute() {
global $CFG;
if (!empty($CFG->skiplangupgrade)) {
mtrace('Langpack update skipped. ($CFG->skiplangupgrade set)');
return;
}
$controller = new \tool_langimport\controller();
if ($controller->update_all_installed_languages()) {
foreach ($controller->info as $message) {
+2 -2
View File
@@ -25,6 +25,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014092801; // The current plugin version (Date: YYYYMMDDXX)
$plugin->requires = 2014050800; // Requires this Moodle version
$plugin->version = 2014111000; // The current plugin version (Date: YYYYMMDDXX)
$plugin->requires = 2014110400; // Requires this Moodle version
$plugin->component = 'tool_langimport'; // Full name of the plugin (used for diagnostics)
+5 -2
View File
@@ -213,11 +213,14 @@ class manager implements \core\log\manager {
* @param string $info Additional description information
* @param int $cm The course_module->id if there is one
* @param int|\stdClass $user If log regards $user other than $USER
* @param string $ip Override the IP, should only be used for restore.
* @param int $time Override the log time, should only be used for restore.
*/
public function legacy_add_to_log($courseid, $module, $action, $url = '', $info = '', $cm = 0, $user = 0) {
public function legacy_add_to_log($courseid, $module, $action, $url = '', $info = '',
$cm = 0, $user = 0, $ip = null, $time = null) {
$this->init();
if (isset($this->stores['logstore_legacy'])) {
$this->stores['logstore_legacy']->legacy_add_to_log($courseid, $module, $action, $url, $info, $cm, $user);
$this->stores['logstore_legacy']->legacy_add_to_log($courseid, $module, $action, $url, $info, $cm, $user, $ip, $time);
}
}
}
+3
View File
@@ -46,5 +46,8 @@ function xmldb_tool_log_upgrade($oldversion) {
// Moodle v2.7.0 release upgrade line.
// Put any upgrade step following this.
// Moodle v2.8.0 release upgrade line.
// Put any upgrade step following this.
return true;
}
@@ -36,5 +36,8 @@ function xmldb_logstore_database_upgrade($oldversion) {
// Moodle v2.7.0 release upgrade line.
// Put any upgrade step following this.
// Moodle v2.8.0 release upgrade line.
// Put any upgrade step following this.
return true;
}
+2 -2
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014050800; // Requires this Moodle version.
$plugin->version = 2014111000; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014110400; // Requires this Moodle version.
$plugin->component = 'logstore_database'; // Full name of the plugin (used for diagnostics).
@@ -91,19 +91,24 @@ class store implements \tool_log\log\store, \core\log\sql_select_reader {
// Replace the query with hardcoded mappings required for core.
list($selectwhere, $params, $sort) = self::replace_sql_legacy($selectwhere, $params, $sort);
$events = array();
$records = array();
try {
$records = $DB->get_records_select('log', $selectwhere, $params, $sort, '*', $limitfrom, $limitnum);
// A custom report + on the fly SQL rewriting = a possible exception.
$records = $DB->get_recordset_select('log', $selectwhere, $params, $sort, '*', $limitfrom, $limitnum);
} catch (\moodle_exception $ex) {
debugging("error converting legacy event data " . $ex->getMessage() . $ex->debuginfo, DEBUG_DEVELOPER);
return array();
}
$events = array();
foreach ($records as $data) {
$events[$data->id] = \logstore_legacy\event\legacy_logged::restore_legacy($data);
}
$records->close();
return $events;
}
@@ -143,8 +148,10 @@ class store implements \tool_log\log\store, \core\log\sql_select_reader {
* @param string $info Additional description information
* @param int $cm The course_module->id if there is one
* @param int|\stdClass $user If log regards $user other than $USER
* @param string $ip Override the IP, should only be used for restore.
* @param int $time Override the log time, should only be used for restore.
*/
public function legacy_add_to_log($courseid, $module, $action, $url, $info, $cm, $user) {
public function legacy_add_to_log($courseid, $module, $action, $url, $info, $cm, $user, $ip = null, $time = null) {
// Note that this function intentionally does not follow the normal Moodle DB access idioms.
// This is for a good reason: it is the most frequently used DB update function,
// so it has been optimised for speed.
@@ -172,9 +179,9 @@ class store implements \tool_log\log\store, \core\log\sql_select_reader {
}
}
$remoteaddr = getremoteaddr();
$remoteaddr = (is_null($ip)) ? getremoteaddr() : $ip;
$timenow = time();
$timenow = (is_null($time)) ? time() : $time;
if (!empty($url)) { // Could break doing html_entity_decode on an empty var.
$url = html_entity_decode($url, ENT_QUOTES, 'UTF-8');
} else {
@@ -44,11 +44,26 @@ class cleanup_task extends \core\task\scheduled_task {
public function execute() {
global $CFG, $DB;
// Delete old logs to save space (this might need a timer to slow it down...).
if (!empty($CFG->loglifetime)) { // Value in days.
$loglifetime = time(0) - ($CFG->loglifetime * 3600 * 24);
$DB->delete_records_select("log", "time < ?", array($loglifetime));
mtrace(" Deleted old legacy log records");
if (empty($CFG->loglifetime)) {
return;
}
$loglifetime = time() - ($CFG->loglifetime * 3600 * 24); // Value in days.
$lifetimep = array($loglifetime);
$start = time();
while ($min = $DB->get_field_select("log", "MIN(time)", "time < ?", $lifetimep)) {
// Break this down into chunks to avoid transaction for too long and generally thrashing database.
// Experiments suggest deleting one day takes up to a few seconds; probably a reasonable chunk size usually.
// If the cleanup has just been enabled, it might take e.g a month to clean the years of logs.
$params = array(min($min + 3600 * 24, $loglifetime));
$DB->delete_records_select("log", "time < ?", $params);
if (time() > $start + 300) {
// Do not churn on log deletion for too long each run.
break;
}
}
mtrace(" Deleted old legacy log records");
}
}
+1 -1
View File
@@ -28,7 +28,7 @@ $tasks = array(
array(
'classname' => '\logstore_legacy\task\cleanup_task',
'blocking' => 0,
'minute' => '*',
'minute' => 'R',
'hour' => '5',
'day' => '*',
'dayofweek' => '*',
@@ -273,4 +273,33 @@ class logstore_legacy_store_testcase extends advanced_testcase {
$this->assertContains($expectedreport, $reports);
}
}
/**
* Test that the legacy log cleanup works correctly.
*/
public function test_cleanup_task() {
global $DB;
$this->resetAfterTest();
// Create some records spread over various days; test multiple iterations in cleanup.
$record = (object) array('time' => time());
$DB->insert_record('log', $record);
$record->time -= 3600 * 24 * 30;
$DB->insert_record('log', $record);
$record->time -= 3600 * 24 * 30;
$DB->insert_record('log', $record);
$record->time -= 3600 * 24 * 30;
$DB->insert_record('log', $record);
$this->assertEquals(4, $DB->count_records('log'));
// Remove all logs before "today".
set_config('loglifetime', 1);
$this->expectOutputString(" Deleted old legacy log records\n");
$clean = new \logstore_legacy\task\cleanup_task();
$clean->execute();
$this->assertEquals(1, $DB->count_records('log'));
}
}
+2 -2
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014050800; // Requires this Moodle version.
$plugin->version = 2014111001; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014110400; // Requires this Moodle version.
$plugin->component = 'logstore_legacy'; // Full name of the plugin (used for diagnostics).
@@ -72,7 +72,7 @@ class store implements \tool_log\log\writer, \core\log\sql_internal_reader {
$sort = self::tweak_sort_by_id($sort);
$events = array();
$records = $DB->get_records_select('logstore_standard_log', $selectwhere, $params, $sort, '*', $limitfrom, $limitnum);
$records = $DB->get_recordset_select('logstore_standard_log', $selectwhere, $params, $sort, '*', $limitfrom, $limitnum);
foreach ($records as $data) {
$extra = array('origin' => $data->origin, 'ip' => $data->ip, 'realuserid' => $data->realuserid);
@@ -94,6 +94,8 @@ class store implements \tool_log\log\writer, \core\log\sql_internal_reader {
}
}
$records->close();
return $events;
}
@@ -43,12 +43,29 @@ class cleanup_task extends \core\task\scheduled_task {
*/
public function execute() {
global $DB;
$loglifetime = (int)get_config('logstore_standard', 'loglifetime');
if ($loglifetime > 0) {
$loglifetime = time() - ($loglifetime * 3600 * 24); // Value in days.
$DB->delete_records_select("logstore_standard_log", "timecreated < ?", array($loglifetime));
mtrace(" Deleted old log records from standard store.");
if (empty($loglifetime) || $loglifetime < 0) {
return;
}
$loglifetime = time() - ($loglifetime * 3600 * 24); // Value in days.
$lifetimep = array($loglifetime);
$start = time();
while ($min = $DB->get_field_select("logstore_standard_log", "MIN(timecreated)", "timecreated < ?", $lifetimep)) {
// Break this down into chunks to avoid transaction for too long and generally thrashing database.
// Experiments suggest deleting one day takes up to a few seconds; probably a reasonable chunk size usually.
// If the cleanup has just been enabled, it might take e.g a month to clean the years of logs.
$params = array(min($min + 3600 * 24, $loglifetime));
$DB->delete_records_select("logstore_standard_log", "timecreated < ?", $params);
if (time() > $start + 300) {
// Do not churn on log deletion for too long each run.
break;
}
}
mtrace(" Deleted old log records from standard store.");
}
}
+1 -1
View File
@@ -28,7 +28,7 @@ $tasks = array(
array(
'classname' => '\logstore_standard\task\cleanup_task',
'blocking' => 0,
'minute' => '*',
'minute' => 'R',
'hour' => '4',
'day' => '*',
'dayofweek' => '*',
@@ -114,5 +114,8 @@ function xmldb_logstore_standard_upgrade($oldversion) {
// Moodle v2.7.0 release upgrade line.
// Put any upgrade step following this.
// Moodle v2.8.0 release upgrade line.
// Put any upgrade step following this.
return true;
}
@@ -218,4 +218,41 @@ class logstore_standard_store_testcase extends advanced_testcase {
$this->assertContains($expectedreport, $reports);
}
}
/**
* Test that the standard log cleanup works correctly.
*/
public function test_cleanup_task() {
global $DB;
$this->resetAfterTest();
// Create some records spread over various days; test multiple iterations in cleanup.
$ctx = context_course::instance(1);
$record = (object) array(
'edulevel' => 0,
'contextid' => $ctx->id,
'contextlevel' => $ctx->contextlevel,
'contextinstanceid' => $ctx->instanceid,
'userid' => 1,
'timecreated' => time(),
);
$DB->insert_record('logstore_standard_log', $record);
$record->timecreated -= 3600 * 24 * 30;
$DB->insert_record('logstore_standard_log', $record);
$record->timecreated -= 3600 * 24 * 30;
$DB->insert_record('logstore_standard_log', $record);
$record->timecreated -= 3600 * 24 * 30;
$DB->insert_record('logstore_standard_log', $record);
$this->assertEquals(4, $DB->count_records('logstore_standard_log'));
// Remove all logs before "today".
set_config('loglifetime', 1, 'logstore_standard');
$this->expectOutputString(" Deleted old log records from standard store.\n");
$clean = new \logstore_standard\task\cleanup_task();
$clean->execute();
$this->assertEquals(1, $DB->count_records('logstore_standard_log'));
}
}
+2 -2
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014050800; // Requires this Moodle version.
$plugin->version = 2014111001; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014110400; // Requires this Moodle version.
$plugin->component = 'logstore_standard'; // Full name of the plugin (used for diagnostics).
+2 -2
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014051200; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014050800; // Requires this Moodle version.
$plugin->version = 2014111000; // The current plugin version (Date: YYYYMMDDXX).
$plugin->requires = 2014110400; // Requires this Moodle version.
$plugin->component = 'tool_log'; // Full name of the plugin (used for diagnostics).
@@ -62,15 +62,24 @@ class tool_messageinbound_edit_handler_form extends moodleform {
// Items which can be configured.
$mform->addElement('header', 'configuration', get_string('configuration'));
$options = array(
HOURSECS => get_string('onehour', 'tool_messageinbound'),
DAYSECS => get_string('oneday', 'tool_messageinbound'),
WEEKSECS => get_string('oneweek', 'tool_messageinbound'),
YEARSECS => get_string('oneyear', 'tool_messageinbound'),
'' => get_string('noexpiry', 'tool_messageinbound'),
);
$mform->addElement('select', 'defaultexpiration', get_string('defaultexpiration', 'tool_messageinbound'), $options);
$mform->addHelpButton('defaultexpiration', 'defaultexpiration', 'tool_messageinbound');
if ($handler->can_change_defaultexpiration()) {
// Show option to change expiry only if the handler supports it.
$options = array(
HOURSECS => get_string('onehour', 'tool_messageinbound'),
DAYSECS => get_string('oneday', 'tool_messageinbound'),
WEEKSECS => get_string('oneweek', 'tool_messageinbound'),
YEARSECS => get_string('oneyear', 'tool_messageinbound'),
0 => get_string('noexpiry', 'tool_messageinbound'),
);
$mform->addElement('select', 'defaultexpiration', get_string('defaultexpiration', 'tool_messageinbound'), $options);
$mform->addHelpButton('defaultexpiration', 'defaultexpiration', 'tool_messageinbound');
} else {
$text = $this->get_defaultexpiration_text($handler);
$mform->addElement('static', 'defaultexpiration_fake', get_string('defaultexpiration', 'tool_messageinbound'), $text);
$mform->addElement('hidden', 'defaultexpiration');
$mform->addHelpButton('defaultexpiration_fake', 'defaultexpiration', 'tool_messageinbound');
$mform->setType('defaultexpiration', PARAM_INT);
}
if ($handler->can_change_validateaddress()) {
$mform->addElement('checkbox', 'validateaddress', get_string('requirevalidation', 'tool_messageinbound'));
@@ -103,4 +112,28 @@ class tool_messageinbound_edit_handler_form extends moodleform {
$this->add_action_buttons(true, get_string('savechanges'));
}
/**
* Return a text string representing the selected default expiration for the handler.
*
* @param \core\message\inbound\handler $handler handler instance.
*
* @return string localised text string.
*/
protected function get_defaultexpiration_text(\core\message\inbound\handler $handler) {
switch($handler->defaultexpiration) {
case HOURSECS :
return get_string('onehour', 'tool_messageinbound');
case DAYSECS :
return get_string('oneday', 'tool_messageinbound');
case WEEKSECS :
return get_string('oneweek', 'tool_messageinbound');
case YEARSECS :
return get_string('oneyear', 'tool_messageinbound');
case 0:
return get_string('noexpiry', 'tool_messageinbound');
default:
return ''; // Should never happen.
}
}
}
+87 -26
View File
@@ -102,6 +102,10 @@ class manager {
try {
$this->client->login();
mtrace("Connection established.");
// Ensure that mailboxes exist.
$this->ensure_mailboxes_exist();
return true;
} catch (\Horde_Imap_Client_Exception $e) {
@@ -291,6 +295,11 @@ class manager {
// First flag this message to prevent another running hitting this message while we look at the headers.
$this->add_flag_to_message($messageid, self::MESSAGE_FLAGGED);
if ($this->is_bulk_message($message, $messageid)) {
mtrace("- The message has a bulk header set. This is likely an auto-generated reply - discarding.");
return;
}
// Record the user that this script is currently being run as. This is important when re-processing existing
// messages, as cron_setup_user is called multiple times.
$originaluser = $USER;
@@ -363,7 +372,10 @@ class manager {
// Process and retrieve the message data for this message.
// This includes fetching the full content, as well as all headers, and attachments.
$this->process_message_data($envelope, $messagedata, $messageid);
if (!$this->process_message_data($envelope, $messagedata, $messageid)) {
mtrace("--- Message could not be found on the server. Is another process removing messages?");
return;
}
// When processing validation replies, we need to skip the sender verification phase as this has been
// manually completed.
@@ -403,7 +415,7 @@ class manager {
mtrace("-- Returning to the original user.");
cron_setup_user($originaluser);
return;
} catch (Exception $e) {
} catch (\Exception $e) {
// An unknown error occurred. The user is not informed, but the administrator is.
mtrace("-- Message processing failed. An unexpected exception was thrown. Details follow.");
mtrace($e->getMessage());
@@ -457,36 +469,25 @@ class manager {
$query = new \Horde_Imap_Client_Fetch_Query();
$query->imapDate();
// Fetch all of the message parts too.
$typemap = $structure->contentTypeMap();
foreach ($typemap as $part => $type) {
// The header.
$query->headerText(array(
'id' => $part,
));
}
// Fetch the message header.
$query->headerText();
// Retrieve the message with the above components.
$messagedata = $this->client->fetch($mailbox, $query, array('ids' => $messageid))->first();
// Store the data for this message.
$headers = '';
foreach ($typemap as $part => $type) {
// Grab all of the header data into a string.
$headers .= $messagedata->getHeaderText($part);
// We don't handle any of the other MIME content at this stage.
if (!$messagedata) {
// Message was not found! Somehow it has been removed or is no longer returned.
return null;
}
$data = new \stdClass();
// The message ID should always be in the first part.
$data = new \stdClass();
$data->messageid = $messagedata->getHeaderText(0, \Horde_Imap_Client_Data_Fetch::HEADER_PARSE)->getValue('Message-ID');
$data->subject = $envelope->subject;
$data->timestamp = $messagedata->getImapDate()->__toString();
$data->envelope = $envelope;
$data->data = $this->addressmanager->get_data();
$data->headers = $headers;
$data->headers = $messagedata->getHeaderText();
$this->currentmessagedata = $data;
@@ -496,9 +497,8 @@ class manager {
/**
* Process a message again to add body and attachment data.
*
* @param Horde_Imap_Client_Data_Envelope $envelope The Envelope of the message
* @param Horde_Imap_Client_Data_Fetch $basemessagedata The structure and part of the message body
* @param string|Horde_Imap_Client_Ids $messageid The Hore message Uid
* @param \Horde_Imap_Client_Data_Fetch $basemessagedata The structure and part of the message body
* @param string|\Horde_Imap_Client_Ids $messageid The Hore message Uid
* @return \stdClass The current value of the messagedata
*/
private function process_message_data_body(
@@ -616,6 +616,9 @@ class manager {
private function process_message_part_attachment($messagedata, $partdata, $part, $filename) {
global $CFG;
// For Antivirus, the repository/lib.php must be included as it is not autoloaded.
require_once($CFG->dirroot . '/repository/lib.php');
// If a filename is present, assume that this part is an attachment.
$attachment = new \stdClass();
$attachment->filename = $filename;
@@ -647,7 +650,7 @@ class manager {
// Perform a virus scan now.
try {
\repository::antivir_scan_file($filepath, $attachment->filename, true);
} catch (moodle_exception $e) {
} catch (\moodle_exception $e) {
mtrace("--> A virus was found in the attachment '{$attachment->filename}'.");
$this->inform_attachment_virus();
return;
@@ -736,6 +739,64 @@ class manager {
return in_array($flag, $flags);
}
/**
* Ensure that all mailboxes exist.
*/
private function ensure_mailboxes_exist() {
$requiredmailboxes = array(
self::MAILBOX,
self::CONFIRMATIONFOLDER,
);
$existingmailboxes = $this->client->listMailboxes($requiredmailboxes);
foreach ($requiredmailboxes as $mailbox) {
if (isset($existingmailboxes[$mailbox])) {
// This mailbox was found.
continue;
}
mtrace("Unable to find the '{$mailbox}' mailbox - creating it.");
$this->client->createMailbox($mailbox);
}
}
/**
* Attempt to determine whether this message is a bulk message (e.g. automated reply).
*
* @param \Horde_Imap_Client_Data_Fetch $message The message to process
* @param string|\Horde_Imap_Client_Ids $messageid The Hore message Uid
* @return boolean
*/
private function is_bulk_message(
\Horde_Imap_Client_Data_Fetch $message,
$messageid) {
$query = new \Horde_Imap_Client_Fetch_Query();
$query->headerText(array('peek' => true));
$messagedata = $this->client->fetch($this->get_mailbox(), $query, array('ids' => $messageid))->first();
// Assume that this message is not bulk to begin with.
$isbulk = false;
// An auto-reply may itself include the Bulk Precedence.
$precedence = $messagedata->getHeaderText(0, \Horde_Imap_Client_Data_Fetch::HEADER_PARSE)->getValue('Precedence');
$isbulk = $isbulk || strtolower($precedence) == 'bulk';
// If the X-Autoreply header is set, and not 'no', then this is an automatic reply.
$autoreply = $messagedata->getHeaderText(0, \Horde_Imap_Client_Data_Fetch::HEADER_PARSE)->getValue('X-Autoreply');
$isbulk = $isbulk || ($autoreply && $autoreply != 'no');
// If the X-Autorespond header is set, and not 'no', then this is an automatic response.
$autorespond = $messagedata->getHeaderText(0, \Horde_Imap_Client_Data_Fetch::HEADER_PARSE)->getValue('X-Autorespond');
$isbulk = $isbulk || ($autorespond && $autorespond != 'no');
// If the Auto-Submitted header is set, and not 'no', then this is a non-human response.
$autosubmitted = $messagedata->getHeaderText(0, \Horde_Imap_Client_Data_Fetch::HEADER_PARSE)->getValue('Auto-Submitted');
$isbulk = $isbulk || ($autosubmitted && $autosubmitted != 'no');
return $isbulk;
}
/**
* Send the message to the appropriate handler.
*
@@ -758,7 +819,7 @@ class manager {
$error->message = $e->getMessage();
throw new \core\message\inbound\processing_failed_exception('messageprocessingfailed', 'tool_messageinbound', $error);
} catch (Exception $e) {
} catch (\Exception $e) {
mtrace("-> The Inbound Message handler threw an exception. Unable to process this message. User informed.");
mtrace("--> " . $e->getMessage());
// An unknown error occurred. Still inform the user but, this time do not include the specific
@@ -46,7 +46,7 @@ class invalid_recipient_handler extends \core\message\inbound\handler {
/**
* Do not allow changes to the address validation setting.
*/
public function allow_validateaddress_change() {
public function can_change_validateaddress() {
return false;
}
+4 -1
View File
@@ -58,8 +58,11 @@ if (empty($classname)) {
if ($mform->is_cancelled()) {
redirect($PAGE->url);
} else if ($data = $mform->get_data()) {
// Update the record from the form.
$record->defaultexpiration = (int) $data->defaultexpiration;
if ($handler->can_change_defaultexpiration()) {
$record->defaultexpiration = (int) $data->defaultexpiration;
}
if ($handler->can_change_validateaddress()) {
$record->validateaddress = !empty($data->validateaddress);
@@ -28,7 +28,7 @@ $string['configmessageinboundhost'] = 'The address of the server that Moodle sho
$string['defaultexpiration'] = 'Default address expiry period';
$string['defaultexpiration_help'] = 'When an email address is generated by the handler, it can be set to automatically expire after a period of time, so that it can no longer be used. It is advisable to set an expiry period.';
$string['description'] = 'Description';
$string['domain'] = 'Email Domain';
$string['domain'] = 'Email domain';
$string['edit'] = 'Edit';
$string['edithandler'] = 'Edit settings for the {$a} handler';
$string['editinghandler'] = 'Editing {$a}';
@@ -48,22 +48,22 @@ It is not possible to disable sender verification of this handler because the us
$string['invalid_recipient_handler_name'] = 'Invalid recipient handler';
$string['invalidrecipientdescription'] = 'The message "{$a->subject}" could not be authenticated, since it was sent from a different email address than in your user profile. For the message to be authenticated, you need to reply to this message.';
$string['invalidrecipientdescriptionhtml'] = 'The message "{$a->subject}" could not be authenticated, since it was sent from a different email address than in your user profile. For the message to be authenticated, you need to reply to this message.';
$string['invalidrecipientfinal'] = 'The message you sent with subject "{$a->subject}" could not be authenticated. Please check that you are sending your message from the e-mail account listed in your Moodle profile.';
$string['invalidrecipientfinal'] = 'The message "{$a->subject}" could not be authenticated. Please check that you are sending your message from the same email address as in your profile.';
$string['mailbox'] = 'Mailbox name';
$string['mailboxconfiguration'] = 'Mailbox configuration';
$string['mailboxdescription'] = '[mailbox]+subaddress@[domain]';
$string['mailsettings'] = 'Mail settings';
$string['message_handlers'] = 'Message handlers';
$string['messageprocessingerror'] = 'You recently sent an e-mail to Moodle with the subject "{$a->subject}" but Moodle was unable to process it.
$string['messageprocessingerror'] = 'You recently sent an email "{$a->subject}" but unfortunately it could not be processed.
The details of the error are shown below.
{$a->error}';
$string['messageprocessingerrorhtml'] = '<p>You recently sent an e-mail to Moodle with the subject "{$a->subject}" but Moodle was unable to process it.</p>
$string['messageprocessingerrorhtml'] = '<p>You recently sent an email "{$a->subject}" but unfortunately it could not be processed.</p>
<p>The details of the error are shown below.</p>
<p>{$a->error}</p>';
$string['messageprocessingfailed'] = 'Moodle was unable to process the e-mail you sent with subject "{$a->subject}". The following error was given: "{$a->message}".';
$string['messageprocessingfailedunknown'] = 'Moodle was unable to process the e-mail you sent with subject "{$a->subject}". Contact your system administrator for further information.';
$string['messageprocessingfailed'] = 'The email "{$a->subject}" could not be processed. The error is as follows: "{$a->message}".';
$string['messageprocessingfailedunknown'] = 'The email "{$a->subject}" could not be processed. Contact your administrator for further information.';
$string['messageprocessingsuccess'] = '{$a->plain}
If you do not wish to receive these notifications in the future, you can edit your personal messaging preferences by opening {$a->messagepreferencesurl} in your browser.';
@@ -76,14 +76,14 @@ $string['messageinboundgeneralconfiguration'] = 'General configuration';
$string['messageinboundgeneralconfiguration_desc'] = 'Inbound message processing allows you to receive and process email within Moodle. This has applications such as sending email replies to forum posts or adding files to a user\'s private files.';
$string['messageinboundhost'] = 'Incoming Mail Server';
$string['messageinboundhostpass'] = 'Password';
$string['messageinboundhostpass_desc'] = 'This is the password your service provider will have provided to log into your e-mail account with.';
$string['messageinboundhostpass_desc'] = 'This is the password your service provider will have provided to log in to your email account with.';
$string['messageinboundhostssl'] = 'Use SSL';
$string['messageinboundhostssl_desc'] = 'Some mail servers support an additional level of security by encrypting communication between Moodle and your server. We recommend using this SSL encryption if your server supports it.';
$string['messageinboundhosttype'] = 'Server type';
$string['messageinboundhostuser'] = 'Username';
$string['messageinboundhostuser_desc'] = 'This is the username your service provider will have provided to log into your e-mail account with.';
$string['messageinboundhostuser_desc'] = 'This is the username your service provider will have provided to log in to your email account with.';
$string['messageinboundmailboxconfiguration_desc'] = 'When messages are sent out, they fit into the format address+data@example.com. To reliably generate addresses from Moodle, please specify the address that you would normally use before the @ sign, and the domain after the @ sign separately. For example, the Mailbox name in the example would be "address", and the E-mail domain would be "example.com". You should use a dedicated e-mail account for this purpose.';
$string['messageprovider:invalidrecipienthandler'] = 'Messages to confirm that an inbound messages came from you';
$string['messageprovider:invalidrecipienthandler'] = 'Message to confirm that an inbound message came from you';
$string['messageprovider:messageprocessingerror'] = 'Warning when an inbound message could not be processed';
$string['messageprovider:messageprocessingsuccess'] = 'Confirmation that a message was successfully processed';
$string['noencryption'] = 'Off - No encryption';
+2 -2
View File
@@ -41,9 +41,9 @@ if ($hassiteconfig) {
$settings->add(new admin_setting_heading('messageinbound_mailboxconfiguration',
new lang_string('mailboxconfiguration', 'tool_messageinbound'),
new lang_string('messageinboundmailboxconfiguration_desc', 'tool_messageinbound'), ''));
$settings->add(new admin_setting_configtext('messageinbound_mailbox',
$settings->add(new admin_setting_configtext_with_maxlength('messageinbound_mailbox',
new lang_string('mailbox', 'tool_messageinbound'),
null, '', PARAM_RAW));
null, '', PARAM_RAW, null, 15));
$settings->add(new admin_setting_configtext('messageinbound_domain',
new lang_string('domain', 'tool_messageinbound'),
null, '', PARAM_RAW));
+2 -2
View File
@@ -24,6 +24,6 @@
defined('MOODLE_INTERNAL') || die();
$plugin->version = 2014091200;
$plugin->requires = 2014050800;
$plugin->version = 2014111000;
$plugin->requires = 2014110400;
$plugin->component = 'tool_messageinbound';
@@ -0,0 +1,77 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* The tool_monitor rule created event.
*
* @package tool_monitor
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor\event;
defined('MOODLE_INTERNAL') || die();
/**
* The tool_monitor rule created event class.
*
* @package tool_monitor
* @since Moodle 2.8
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class rule_created extends \core\event\base {
/**
* Init method.
*
* @return void
*/
protected function init() {
$this->data['objecttable'] = 'tool_monitor_rules';
$this->data['crud'] = 'c';
$this->data['edulevel'] = self::LEVEL_OTHER;
}
/**
* Return localised event name.
*
* @return string
*/
public static function get_name() {
return get_string('eventrulecreated', 'tool_monitor');
}
/**
* Returns description of what happened.
*
* @return string
*/
public function get_description() {
return "The user with id '$this->userid' created the event monitor rule with id '$this->objectid'.";
}
/**
* Get URL related to the action
*
* @return \moodle_url
*/
public function get_url() {
return new \moodle_url('/admin/tool/monitor/edit.php', array('ruleid' => $this->objectid,
'courseid' => $this->courseid));
}
}
@@ -0,0 +1,76 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* The tool_monitor rule deleted event.
*
* @package tool_monitor
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor\event;
defined('MOODLE_INTERNAL') || die();
/**
* The tool_monitor rule deleted event class.
*
* @package tool_monitor
* @since Moodle 2.8
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class rule_deleted extends \core\event\base {
/**
* Init method.
*
* @return void
*/
protected function init() {
$this->data['objecttable'] = 'tool_monitor_rules';
$this->data['crud'] = 'd';
$this->data['edulevel'] = self::LEVEL_OTHER;
}
/**
* Return localised event name.
*
* @return string
*/
public static function get_name() {
return get_string('eventruledeleted', 'tool_monitor');
}
/**
* Returns description of what happened.
*
* @return string
*/
public function get_description() {
return "The user with id '$this->userid' deleted the event monitor rule with id '$this->objectid'.";
}
/**
* Get URL related to the action
*
* @return \moodle_url
*/
public function get_url() {
return new \moodle_url('/admin/tool/monitor/managerules.php', array('courseid' => $this->courseid));
}
}
@@ -0,0 +1,77 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* The tool_monitor rule updated event.
*
* @package tool_monitor
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor\event;
defined('MOODLE_INTERNAL') || die();
/**
* The tool_monitor rule updated event class.
*
* @package tool_monitor
* @since Moodle 2.8
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class rule_updated extends \core\event\base {
/**
* Init method.
*
* @return void
*/
protected function init() {
$this->data['objecttable'] = 'tool_monitor_rules';
$this->data['crud'] = 'u';
$this->data['edulevel'] = self::LEVEL_OTHER;
}
/**
* Return localised event name.
*
* @return string
*/
public static function get_name() {
return get_string('eventruleupdated', 'tool_monitor');
}
/**
* Returns description of what happened.
*
* @return string
*/
public function get_description() {
return "The user with id '$this->userid' updated the event monitor rule with id '$this->objectid'.";
}
/**
* Get URL related to the action
*
* @return \moodle_url
*/
public function get_url() {
return new \moodle_url('/admin/tool/monitor/edit.php', array('ruleid' => $this->objectid,
'courseid' => $this->courseid));
}
}
@@ -0,0 +1,67 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* The tool_monitor subscription created event.
*
* @package tool_monitor
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor\event;
defined('MOODLE_INTERNAL') || die();
/**
* The tool_monitor subscription created event class.
*
* @package tool_monitor
* @since Moodle 2.8
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class subscription_created extends \core\event\base {
/**
* Init method.
*
* @return void
*/
protected function init() {
$this->data['objecttable'] = 'tool_monitor_subscriptions';
$this->data['crud'] = 'c';
$this->data['edulevel'] = self::LEVEL_TEACHING;
}
/**
* Return localised event name.
*
* @return string
*/
public static function get_name() {
return get_string('eventsubcreated', 'tool_monitor');
}
/**
* Returns description of what happened.
*
* @return string
*/
public function get_description() {
return "The user with id '$this->userid' created the event monitor subscription with id '$this->objectid'.";
}
}
@@ -0,0 +1,86 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* The tool_monitor subscription criteria met event.
*
* @package tool_monitor
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor\event;
defined('MOODLE_INTERNAL') || die();
/**
* The tool_monitor subscription criteria met event class.
*
* @property-read array $other {
* Extra information about event.
*
* - string subscriptionid: id of the subscription.
* }
*
* @package tool_monitor
* @since Moodle 2.8
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class subscription_criteria_met extends \core\event\base {
/**
* Init method.
*
* @return void
*/
protected function init() {
$this->data['crud'] = 'c';
$this->data['edulevel'] = self::LEVEL_TEACHING;
}
/**
* Return localised event name.
*
* @return string
*/
public static function get_name() {
return get_string('eventsubcriteriamet', 'tool_monitor');
}
/**
* Returns description of what happened.
*
* @return string
*/
public function get_description() {
return "The criteria for the subscription with id '{$this->other['subscriptionid']}' was met.";
}
/**
* Custom validation.
*
* @throws \coding_exception
* @return void
*/
protected function validate_data() {
parent::validate_data();
if (!isset($this->other['subscriptionid'])) {
throw new \coding_exception('The \'subscriptionid\' value must be set in other.');
}
}
}
@@ -0,0 +1,67 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* The tool_monitor subscription deleted event.
*
* @package tool_monitor
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor\event;
defined('MOODLE_INTERNAL') || die();
/**
* The tool_monitor subscription deleted event class.
*
* @package tool_monitor
* @since Moodle 2.8
* @copyright 2014 Mark Nelson <markn@moodle.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class subscription_deleted extends \core\event\base {
/**
* Init method.
*
* @return void
*/
protected function init() {
$this->data['objecttable'] = 'tool_monitor_subscriptions';
$this->data['crud'] = 'd';
$this->data['edulevel'] = self::LEVEL_TEACHING;
}
/**
* Return localised event name.
*
* @return string
*/
public static function get_name() {
return get_string('eventsubdeleted', 'tool_monitor');
}
/**
* Returns description of what happened.
*
* @return string
*/
public function get_description() {
return "The user with id '$this->userid' deleted the event monitor subscription with id '$this->objectid'.";
}
}
+221
View File
@@ -0,0 +1,221 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Event documentation
*
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor;
defined('MOODLE_INTERNAL') || die();
/**
* Class for returning event information.
*
* @since Moodle 2.8
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class eventlist {
/**
* Return all of the core event files.
*
* @return array Core events.
*/
protected static function get_core_eventlist() {
global $CFG;
// Disable developer debugging as deprecated events will fire warnings.
// Setup backup variables to restore the following settings back to what they were when we are finished.
$debuglevel = $CFG->debug;
$debugdisplay = $CFG->debugdisplay;
$debugdeveloper = $CFG->debugdeveloper;
$CFG->debug = 0;
$CFG->debugdisplay = false;
$CFG->debugdeveloper = false;
$eventinformation = array();
$directory = $CFG->libdir . '/classes/event';
$files = self::get_file_list($directory);
// Remove exceptional events that will cause problems being displayed.
if (isset($files['unknown_logged'])) {
unset($files['unknown_logged']);
}
foreach ($files as $file => $location) {
$classname = '\\core\\event\\' . $file;
// Check to see if this is actually a valid event.
if (method_exists($classname, 'get_static_info')) {
$ref = new \ReflectionClass($classname);
// Ignore abstracts.
if (!$ref->isAbstract() && $file != 'manager') {
$eventinformation[$classname] = $classname::get_name();
}
}
}
// Now enable developer debugging as event information has been retrieved.
$CFG->debug = $debuglevel;
$CFG->debugdisplay = $debugdisplay;
$CFG->debugdeveloper = $debugdeveloper;
return $eventinformation;
}
/**
* This function returns an array of all events for the plugins of the system.
*
* @param bool $withoutcomponent Return an eventlist without associated components.
*
* @return array A list of events from all plug-ins.
*/
protected static function get_non_core_eventlist($withoutcomponent = false) {
global $CFG;
// Disable developer debugging as deprecated events will fire warnings.
// Setup backup variables to restore the following settings back to what they were when we are finished.
$debuglevel = $CFG->debug;
$debugdisplay = $CFG->debugdisplay;
$debugdeveloper = $CFG->debugdeveloper;
$CFG->debug = 0;
$CFG->debugdisplay = false;
$CFG->debugdeveloper = false;
$noncorepluginlist = array();
$plugintypes = \core_component::get_plugin_types();
foreach ($plugintypes as $plugintype => $notused) {
$pluginlist = \core_component::get_plugin_list($plugintype);
foreach ($pluginlist as $plugin => $directory) {
$plugindirectory = $directory . '/classes/event';
foreach (self::get_file_list($plugindirectory) as $eventname => $notused) {
$plugineventname = '\\' . $plugintype . '_' . $plugin . '\\event\\' . $eventname;
// Check that this is actually an event.
if (method_exists($plugineventname, 'get_static_info') && $plugin != 'monitor') { // No selfie here.
$ref = new \ReflectionClass($plugineventname);
if (!$ref->isAbstract() && $plugin != 'legacy') {
if ($withoutcomponent) {
$noncorepluginlist[$plugineventname] = $plugineventname::get_name();
} else {
$noncorepluginlist[$plugintype . '_' . $plugin][$plugineventname] = $plugineventname::get_name();
}
}
}
}
}
}
// Now enable developer debugging as event information has been retrieved.
$CFG->debug = $debuglevel;
$CFG->debugdisplay = $debugdisplay;
$CFG->debugdeveloper = $debugdeveloper;
return $noncorepluginlist;
}
/**
* Returns a list of files with a full directory path in a specified directory.
*
* @param string $directory location of files.
* @return array full location of files from the specified directory.
*/
protected static function get_file_list($directory) {
global $CFG;
$directoryroot = $CFG->dirroot;
$finalfiles = array();
if (is_dir($directory)) {
if ($handle = opendir($directory)) {
$files = scandir($directory);
foreach ($files as $file) {
if ($file != '.' && $file != '..') {
// Ignore the file if it is external to the system.
if (strrpos($directory, $directoryroot) !== false) {
$location = substr($directory, strlen($directoryroot));
$name = substr($file, 0, -4);
$finalfiles[$name] = $location . '/' . $file;
}
}
}
}
}
return $finalfiles;
}
/**
* Get a list of events present in the system.
*
* @param bool $withoutcomponent Return an eventlist without associated components.
*
* @return array list of events present in the system.
*/
public static function get_all_eventlist($withoutcomponent = false) {
if ($withoutcomponent) {
$return = array_merge(self::get_core_eventlist(), self::get_non_core_eventlist($withoutcomponent));
array_multisort($return, SORT_NATURAL);
} else {
$return = array_merge(array('core' => self::get_core_eventlist()),
self::get_non_core_eventlist($withoutcomponent = false));
}
return $return;
}
/**
* Return list of plugins that have events.
*
* @param array $eventlist a list of events present in the system {@link eventlist::get_all_eventlist}.
*
* @return array list of plugins with human readable name.
*/
public static function get_plugin_list($eventlist = array()) {
if (empty($eventlist)) {
$eventlist = self::get_all_eventlist();
}
$plugins = array_keys($eventlist);
$return = array();
foreach ($plugins as $plugin) {
if ($plugin === 'core') {
$return[$plugin] = get_string('core', 'tool_monitor');
} else if (get_string_manager()->string_exists('pluginname', $plugin)) {
$return[$plugin] = get_string('pluginname', $plugin);
} else {
$return[$plugin] = $plugin;
}
}
return $return;
}
/**
* validate if the given event belongs to the given plugin.
*
* @param string $plugin Frankenstyle name of the plugin.
* @param string $eventname Full qualified event name.
* @param array $eventlist List of events generated by {@link eventlist::get_all_eventlist}
*
* @return bool Returns true if the selected event belongs to the selected plugin, false otherwise.
*/
public static function validate_event_plugin($plugin, $eventname, $eventlist = array()) {
if (empty($eventlist)) {
$eventlist = self::get_all_eventlist();
}
if (isset($eventlist[$plugin][$eventname])) {
return true;
}
return false;
}
}
@@ -0,0 +1,253 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Observer class containing methods monitoring various events.
*
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor;
defined('MOODLE_INTERNAL') || die();
/**
* Observer class containing methods monitoring various events.
*
* @since Moodle 2.8
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class eventobservers {
/** @var array $buffer buffer of events. */
protected $buffer = array();
/** @var int Number of entries in the buffer. */
protected $count = 0;
/** @var eventobservers a reference to a self instance. */
protected static $instance;
/**
* Course delete event observer.
* This observer monitors course delete event, and when a course is deleted it deletes any rules and subscriptions associated
* with it, so no orphan data is left behind.
*
* @param \core\event\course_deleted $event The course deleted event.
*/
public static function course_deleted(\core\event\course_deleted $event) {
$rules = rule_manager::get_rules_by_courseid($event->courseid, 0, 0, false);
foreach ($rules as $rule) {
rule_manager::delete_rule($rule->id, $event->get_context());
}
}
/**
* The observer monitoring all the events.
*
* This observers puts small event objects in buffer for later writing to the database. At the end of the request the buffer
* is cleaned up and all data dumped into the tool_monitor_events table.
*
* @param \core\event\base $event event object
*/
public static function process_event(\core\event\base $event) {
if (!get_config('tool_monitor', 'enablemonitor')) {
return; // The tool is disabled. Nothing to do.
}
if (empty(self::$instance)) {
self::$instance = new static();
// Register shutdown handler - this is useful for buffering, processing events, etc.
\core_shutdown_manager::register_function(array(self::$instance, 'process_buffer'));
}
self::$instance->buffer_event($event);
if (PHPUNIT_TEST) {
// Process buffer after every event when unit testing.
self::$instance->process_buffer();
}
}
/**
* Api to buffer events to store, to reduce db queries.
*
* @param \core\event\base $event
*/
protected function buffer_event(\core\event\base $event) {
// If there are no subscriptions for this event do not buffer it.
if (!\tool_monitor\subscription_manager::event_has_subscriptions($event->eventname, $event->courseid)) {
return;
}
$eventdata = $event->get_data();
$eventobj = new \stdClass();
$eventobj->eventname = $eventdata['eventname'];
$eventobj->contextid = $eventdata['contextid'];
$eventobj->contextlevel = $eventdata['contextlevel'];
$eventobj->contextinstanceid = $eventdata['contextinstanceid'];
if ($event->get_url()) {
// Get link url if exists.
$eventobj->link = $event->get_url()->out();
} else {
$eventobj->link = '';
}
$eventobj->courseid = $eventdata['courseid'];
$eventobj->timecreated = $eventdata['timecreated'];
$this->buffer[] = $eventobj;
$this->count++;
}
/**
* This method process all events stored in the buffer.
*
* This is a multi purpose api. It does the following:-
* 1. Write event data to tool_monitor_events
* 2. Find out users that need to be notified about rule completion and schedule a task to send them messages.
*/
public function process_buffer() {
global $DB;
$events = $this->flush(); // Flush data.
$select = "SELECT COUNT(id) FROM {tool_monitor_events} ";
$now = time();
$messagestosend = array();
$allsubids = array();
// Let us now process the events and check for subscriptions.
foreach ($events as $eventobj) {
$subscriptions = subscription_manager::get_subscriptions_by_event($eventobj);
$idstosend = array();
foreach ($subscriptions as $subscription) {
$starttime = $now - $subscription->timewindow;
$starttime = ($starttime > $subscription->lastnotificationsent) ? $starttime : $subscription->lastnotificationsent;
if ($subscription->courseid == 0) {
// Site level subscription. Count all events.
$where = "eventname = :eventname AND timecreated > :starttime";
$params = array('eventname' => $eventobj->eventname, 'starttime' => $starttime);
} else {
// Course level subscription.
if ($subscription->cmid == 0) {
// All modules.
$where = "eventname = :eventname AND courseid = :courseid AND timecreated > :starttime";
$params = array('eventname' => $eventobj->eventname, 'courseid' => $eventobj->courseid,
'starttime' => $starttime);
} else {
// Specific module.
$where = "eventname = :eventname AND courseid = :courseid AND contextinstanceid = :cmid
AND timecreated > :starttime";
$params = array('eventname' => $eventobj->eventname, 'courseid' => $eventobj->courseid,
'cmid' => $eventobj->contextinstanceid, 'starttime' => $starttime);
}
}
$sql = $select . "WHERE " . $where;
$count = $DB->count_records_sql($sql, $params);
if (!empty($count) && $count >= $subscription->frequency) {
$idstosend[] = $subscription->id;
// Trigger a subscription_criteria_met event.
// It's possible that the course has been deleted since the criteria was met, so in that case use
// the system context. Set it here and change later if needed.
$context = \context_system::instance();
// We can't perform if (!empty($subscription->courseid)) below as it uses the magic method
// __get to return the variable, which will always result in being empty.
$courseid = $subscription->courseid;
if (!empty($courseid)) {
if ($coursecontext = \context_course::instance($courseid, IGNORE_MISSING)) {
$context = $coursecontext;
}
}
$params = array(
'userid' => $subscription->userid,
'courseid' => $subscription->courseid,
'context' => $context,
'other' => array(
'subscriptionid' => $subscription->id
)
);
$event = \tool_monitor\event\subscription_criteria_met::create($params);
$event->trigger();
}
}
if (!empty($idstosend)) {
$messagestosend[] = array('subscriptionids' => $idstosend, 'event' => $eventobj);
$allsubids = array_merge($allsubids, $idstosend);
}
}
if (!empty($allsubids)) {
// Update the last trigger flag.
list($sql, $params) = $DB->get_in_or_equal($allsubids, SQL_PARAMS_NAMED);
$params['now'] = $now;
$sql = "UPDATE {tool_monitor_subscriptions} SET lastnotificationsent = :now WHERE id $sql";
$DB->execute($sql, $params);
}
// Schedule a task to send notification.
if (!empty($messagestosend)) {
$adhocktask = new notification_task();
$adhocktask->set_custom_data($messagestosend);
$adhocktask->set_component('tool_monitor');
\core\task\manager::queue_adhoc_task($adhocktask);
}
}
/**
* Protected method that flushes the buffer of events and writes them to the database.
*
* @return array a copy of the events buffer.
*/
protected function flush() {
global $DB;
// Flush the buffer to the db.
$events = $this->buffer;
$DB->insert_records('tool_monitor_events', $events); // Insert the whole chunk into the database.
$this->buffer = array();
$this->count = 0;
return $events;
}
/**
* Observer that monitors user deleted event and delete user subscriptions.
*
* @param \core\event\user_deleted $event the event object.
*/
public static function user_deleted(\core\event\user_deleted $event) {
$userid = $event->objectid;
subscription_manager::delete_user_subscriptions($userid);
}
/**
* Observer that monitors course module deleted event and delete user subscriptions.
*
* @param \core\event\course_module_deleted $event the event object.
*/
public static function course_module_deleted(\core\event\course_module_deleted $event) {
$cmid = $event->contextinstanceid;
subscription_manager::delete_cm_subscriptions($cmid);
}
}
@@ -0,0 +1,124 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* This file defines an adhoc task to send notifications.
*
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor;
defined('MOODLE_INTERNAL') || die();
/**
* Adhock class, used to send notifications to users.
*
* @since Moodle 2.8
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class notification_task extends \core\task\adhoc_task {
/**
* Send out messages.
*/
public function execute() {
foreach ($this->get_custom_data() as $data) {
$eventobj = $data->event;
$subscriptionids = $data->subscriptionids;
foreach ($subscriptionids as $id) {
if ($message = $this->generate_message($id, $eventobj)) {
mtrace("Sending message to the user with id " . $message->userto->id . " for the subscription with id $id...");
message_send($message);
mtrace("Sent.");
}
}
}
}
/**
* Generates the message object for a give subscription and event.
*
* @param int $subscriptionid Subscription instance
* @param \stdClass $eventobj Event data
*
* @return false|\stdClass message object
*/
protected function generate_message($subscriptionid, \stdClass $eventobj) {
try {
$subscription = subscription_manager::get_subscription($subscriptionid);
} catch (\dml_exception $e) {
// Race condition, someone deleted the subscription.
return false;
}
$user = \core_user::get_user($subscription->userid);
if (empty($user)) {
// User doesn't exist. Should never happen, nothing to do return.
return false;
}
$context = \context_user::instance($user->id, IGNORE_MISSING);
if ($context === false) {
// User context doesn't exist. Should never happen, nothing to do return.
return false;
}
$template = $subscription->template;
$template = $this->replace_placeholders($template, $subscription, $eventobj, $context);
$msgdata = new \stdClass();
$msgdata->component = 'tool_monitor'; // Your component name.
$msgdata->name = 'notification'; // This is the message name from messages.php.
$msgdata->userfrom = \core_user::get_noreply_user();
$msgdata->userto = $user;
$msgdata->subject = $subscription->get_name($context);
$msgdata->fullmessage = format_text($template, $subscription->templateformat, array('context' => $context));
$msgdata->fullmessageformat = $subscription->templateformat;
$msgdata->fullmessagehtml = format_text($template, $subscription->templateformat, array('context' => $context));
$msgdata->smallmessage = '';
$msgdata->notification = 1; // This is only set to 0 for personal messages between users.
return $msgdata;
}
/**
* Replace place holders in the template with respective content.
*
* @param string $template Message template.
* @param subscription $subscription subscription instance
* @param \stdclass $eventobj Event data
* @param \context $context context object
*
* @return mixed final template string.
*/
protected function replace_placeholders($template, subscription $subscription, $eventobj, $context) {
$template = str_replace('{link}', $eventobj->link, $template);
if ($eventobj->contextlevel == CONTEXT_MODULE && !empty($eventobj->contextinstanceid)
&& (strpos($template, '{modulelink}') !== false)) {
$cm = get_fast_modinfo($eventobj->courseid)->get_cm($eventobj->contextinstanceid);
$modulelink = $cm->url;
$template = str_replace('{modulelink}', $modulelink, $template);
}
$template = str_replace('{rulename}', $subscription->get_name($context), $template);
$template = str_replace('{description}', $subscription->get_description($context), $template);
$template = str_replace('{eventname}', $subscription->get_event_name(), $template);
return $template;
}
}
@@ -0,0 +1,214 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Renderable class for manage rules page.
*
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor\output\managerules;
defined('MOODLE_INTERNAL') || die;
require_once($CFG->libdir . '/tablelib.php');
/**
* Renderable class for manage rules page.
*
* @since Moodle 2.8
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class renderable extends \table_sql implements \renderable {
/**
* @var int course id.
*/
public $courseid;
/**
* @var \context_course|\context_system context of the page to be rendered.
*/
protected $context;
/**
* @var bool Does the user have capability to manage rules at site context.
*/
protected $hassystemcap;
/**
* Sets up the table_log parameters.
*
* @param string $uniqueid unique id of form.
* @param \moodle_url $url url where this table is displayed.
* @param int $courseid course id.
* @param int $perpage Number of rules to display per page.
*/
public function __construct($uniqueid, \moodle_url $url, $courseid = 0, $perpage = 100) {
parent::__construct($uniqueid);
$this->set_attribute('id', 'toolmonitorrules_table');
$this->set_attribute('class', 'toolmonitor managerules generaltable generalbox');
$this->define_columns(array('name', 'description', 'course', 'plugin', 'eventname', 'filters', 'manage'));
$this->define_headers(array(
get_string('rulename', 'tool_monitor'),
get_string('description'),
get_string('course'),
get_string('area', 'tool_monitor'),
get_string('event', 'tool_monitor'),
get_string('frequency', 'tool_monitor'),
get_string('manage', 'tool_monitor'),
)
);
$this->courseid = $courseid;
$this->pagesize = $perpage;
$systemcontext = \context_system::instance();
$this->context = empty($courseid) ? $systemcontext : \context_course::instance($courseid);
$this->hassystemcap = has_capability('tool/monitor:managerules', $systemcontext);
$this->collapsible(false);
$this->sortable(false);
$this->pageable(true);
$this->is_downloadable(false);
$this->define_baseurl($url);
}
/**
* Generate content for name column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the column field.
*/
public function col_name(\tool_monitor\rule $rule) {
return $rule->get_name($this->context);
}
/**
* Generate content for description column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the column field.
*/
public function col_description(\tool_monitor\rule $rule) {
return $rule->get_description($this->context);
}
/**
* Generate content for course column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the context column field.
*/
public function col_course(\tool_monitor\rule $rule) {
$coursename = $rule->get_course_name($this->context);
$courseid = $rule->courseid;
if (empty($courseid)) {
return $coursename;
} else {
return \html_writer::link(new \moodle_url('/course/view.php', array('id' => $courseid)), $coursename);
}
}
/**
* Generate content for plugin column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the column field.
*/
public function col_plugin(\tool_monitor\rule $rule) {
return $rule->get_plugin_name();
}
/**
* Generate content for eventname column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the column field.
*/
public function col_eventname(\tool_monitor\rule $rule) {
return $rule->get_event_name();
}
/**
* Generate content for filters column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the filters column field.
*/
public function col_filters(\tool_monitor\rule $rule) {
return $rule->get_filters_description();
}
/**
* Generate content for manage column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the manage column field.
*/
public function col_manage(\tool_monitor\rule $rule) {
global $OUTPUT, $CFG;
$manage = '';
// Do not allow the user to edit the rule unless they have the system capability, or we are viewing the rules
// for a course, and not the site. Note - we don't need to check for the capability at a course level since
// the user is never shown this page otherwise.
if ($this->hassystemcap || ($rule->courseid != 0)) {
$editurl = new \moodle_url($CFG->wwwroot. '/admin/tool/monitor/edit.php', array('ruleid' => $rule->id,
'courseid' => $rule->courseid, 'sesskey' => sesskey()));
$icon = $OUTPUT->render(new \pix_icon('t/edit', get_string('editrule', 'tool_monitor')));
$manage .= \html_writer::link($editurl, $icon, array('class' => 'action-icon'));
}
// The user should always be able to copy the rule if they are able to view the page.
$copyurl = new \moodle_url($CFG->wwwroot. '/admin/tool/monitor/managerules.php',
array('ruleid' => $rule->id, 'action' => 'copy', 'courseid' => $this->courseid, 'sesskey' => sesskey()));
$icon = $OUTPUT->render(new \pix_icon('t/copy', get_string('duplicaterule', 'tool_monitor')));
$manage .= \html_writer::link($copyurl, $icon, array('class' => 'action-icon'));
if ($this->hassystemcap || ($rule->courseid != 0)) {
$deleteurl = new \moodle_url($CFG->wwwroot. '/admin/tool/monitor/managerules.php', array('ruleid' => $rule->id,
'action' => 'delete', 'courseid' => $rule->courseid, 'sesskey' => sesskey()));
$icon = $OUTPUT->render(new \pix_icon('t/delete', get_string('deleterule', 'tool_monitor')));
$manage .= \html_writer::link($deleteurl, $icon, array('class' => 'action-icon'));
}
return $manage;
}
/**
* Query the reader. Store results in the object for use by build_table.
*
* @param int $pagesize size of page for paginated displayed table.
* @param bool $useinitialsbar do you want to use the initials bar.
*/
public function query_db($pagesize, $useinitialsbar = true) {
$total = \tool_monitor\rule_manager::count_rules_by_courseid($this->courseid);
$this->pagesize($pagesize, $total);
$rules = \tool_monitor\rule_manager::get_rules_by_courseid($this->courseid, $this->get_page_start(),
$this->get_page_size());
$this->rawdata = $rules;
// Set initial bars.
if ($useinitialsbar) {
$this->initialbars($total > $pagesize);
}
}
}
@@ -0,0 +1,99 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Renderer class for manage rules page.
*
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor\output\managerules;
defined('MOODLE_INTERNAL') || die;
/**
* Renderer class for manage rules page.
*
* @since Moodle 2.8
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class renderer extends \plugin_renderer_base {
/**
* Get html to display on the page.
*
* @param renderable $renderable renderable widget
*
* @return string to display on the mangerules page.
*/
protected function render_renderable(renderable $renderable) {
$o = $this->render_table($renderable);
$o .= $this->render_add_button($renderable->courseid);
return $o;
}
/**
* Get html to display on the page.
*
* @param renderable $renderable renderable widget
*
* @return string to display on the mangerules page.
*/
protected function render_table(renderable $renderable) {
$o = '';
ob_start();
$renderable->out($renderable->pagesize, true);
$o = ob_get_contents();
ob_end_clean();
return $o;
}
/**
* Html to add a button for adding a new rule.
*
* @param int $courseid course id.
*
* @return string html for the button.
*/
protected function render_add_button($courseid) {
global $CFG;
$button = \html_writer::tag('button', get_string('addrule', 'tool_monitor'));
$addurl = new \moodle_url($CFG->wwwroot. '/admin/tool/monitor/edit.php', array('courseid' => $courseid));
return \html_writer::link($addurl, $button);
}
/**
* Html to add a link to go to the subscription page.
*
* @param moodle_url $manageurl The url of the subscription page.
*
* @return string html for the link to the subscription page.
*/
public function render_subscriptions_link($manageurl) {
echo \html_writer::start_div();
$a = \html_writer::link($manageurl, get_string('managesubscriptions', 'tool_monitor'));
$link = \html_writer::tag('span', get_string('managesubscriptionslink', 'tool_monitor', $a));
echo $link;
echo \html_writer::end_div();
}
}
@@ -0,0 +1,110 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Renderer class for manage subscriptions page.
*
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor\output\managesubs;
defined('MOODLE_INTERNAL') || die;
/**
* Renderer class for manage subscriptions page.
*
* @since Moodle 2.8
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class renderer extends \plugin_renderer_base {
/**
* Get html to display on the page.
*
* @param subs $renderable renderable widget
*
* @return string to display on the mangesubs page.
*/
protected function render_subs(subs $renderable) {
$o = $this->render_table($renderable);
return $o;
}
/**
* Get html to display on the page.
*
* @param rules $renderable renderable widget
*
* @return string to display on the mangesubs page.
*/
protected function render_rules(rules $renderable) {
$o = $this->render_course_select($renderable);
if (!empty($renderable->totalcount)) {
$o .= $this->render_table($renderable);
}
return $o;
}
/**
* Get html to display on the page for select dropdown..
*
* @param rules $renderable renderable widget
*
* @return string to display on the mangesubs page.
*/
protected function render_course_select(rules $renderable) {
if ($select = $renderable->get_user_courses_select()) {
return $this->render($select);
}
}
/**
* Get html to display on the page.
*
* @param rules|subs $renderable renderable widget
*
* @return string to display on the mangesubs page.
*/
protected function render_table($renderable) {
$o = '';
ob_start();
$renderable->out($renderable->pagesize, true);
$o = ob_get_contents();
ob_end_clean();
return $o;
}
/**
* Html to add a link to go to the rule manager page.
*
* @param moodle_url $ruleurl The url of the rule manager page.
*
* @return string html for the link to the rule manager page.
*/
public function render_rules_link($ruleurl) {
echo \html_writer::start_div();
$a = \html_writer::link($ruleurl, get_string('managerules', 'tool_monitor'));
$link = \html_writer::tag('span', get_string('manageruleslink', 'tool_monitor', $a));
echo $link;
echo \html_writer::end_div();
}
}
@@ -0,0 +1,233 @@
<?php
// This file is part of Moodle - http://moodle.org/
//
// Moodle is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
// Moodle is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
//
// You should have received a copy of the GNU General Public License
// along with Moodle. If not, see <http://www.gnu.org/licenses/>.
/**
* Renderable class to display a set of rules in the manage subscriptions page.
*
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
namespace tool_monitor\output\managesubs;
defined('MOODLE_INTERNAL') || die;
require_once($CFG->libdir . '/tablelib.php');
/**
* Renderable class to display a set of rules in the manage subscriptions page.
*
* @since Moodle 2.8
* @package tool_monitor
* @copyright 2014 onwards Ankit Agarwal <ankit.agrr@gmail.com>
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class rules extends \table_sql implements \renderable {
/**
* @var int course id.
*/
public $courseid;
/**
* @var int total rules present.
*/
public $totalcount = 0;
/**
* @var \context_course|\context_system context of the page to be rendered.
*/
protected $context;
/**
* Sets up the table_log parameters.
*
* @param string $uniqueid unique id of form.
* @param \moodle_url $url url where this table is displayed.
* @param int $courseid course id.
* @param int $perpage Number of rules to display per page.
*/
public function __construct($uniqueid, \moodle_url $url, $courseid = 0, $perpage = 100) {
parent::__construct($uniqueid);
$this->set_attribute('class', 'toolmonitor subscriberules generaltable generalbox');
$this->define_columns(array('name', 'description', 'course', 'plugin', 'eventname', 'filters', 'select'));
$this->define_headers(array(
get_string('rulename', 'tool_monitor'),
get_string('description'),
get_string('course'),
get_string('area', 'tool_monitor'),
get_string('event', 'tool_monitor'),
get_string('frequency', 'tool_monitor'),
''
)
);
$this->courseid = $courseid;
$this->pagesize = $perpage;
$systemcontext = \context_system::instance();
$this->context = empty($courseid) ? $systemcontext : \context_course::instance($courseid);
$this->collapsible(false);
$this->sortable(false);
$this->pageable(true);
$this->is_downloadable(false);
$this->define_baseurl($url);
$total = \tool_monitor\rule_manager::count_rules_by_courseid($this->courseid);
$this->totalcount = $total;
}
/**
* Generate content for name column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the rule name.
*/
public function col_name(\tool_monitor\rule $rule) {
return $rule->get_name($this->context);
}
/**
* Generate content for description column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the description.
*/
public function col_description(\tool_monitor\rule $rule) {
return $rule->get_description($this->context);
}
/**
* Generate content for course column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the course name.
*/
public function col_course(\tool_monitor\rule $rule) {
$coursename = $rule->get_course_name($this->context);
$courseid = $rule->courseid;
if (empty($courseid)) {
return $coursename;
} else {
return \html_writer::link(new \moodle_url('/course/view.php', array('id' => $this->courseid)), $coursename);
}
}
/**
* Generate content for plugin column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the plugin name.
*/
public function col_plugin(\tool_monitor\rule $rule) {
return $rule->get_plugin_name();
}
/**
* Generate content for eventname column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the event name.
*/
public function col_eventname(\tool_monitor\rule $rule) {
return $rule->get_event_name();
}
/**
* Generate content for filters column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the filters.
*/
public function col_filters(\tool_monitor\rule $rule) {
return $rule->get_filters_description();
}
/**
* Generate content for select column.
*
* @param \tool_monitor\rule $rule rule object
* @return string html used to display the select field.
*/
public function col_select(\tool_monitor\rule $rule) {
global $OUTPUT;
$options = $rule->get_subscribe_options($this->courseid);
$text = get_string('subscribeto', 'tool_monitor', $rule->get_name($this->context));
if ($options instanceof \single_select) {
$options->set_label($text, array('class' => 'accesshide'));
return $OUTPUT->render($options);
} else if ($options instanceof \moodle_url) {
// A \moodle_url to subscribe.
$icon = $OUTPUT->pix_icon('t/add', $text);
$link = new \action_link($options, $icon);
return $OUTPUT->render($link);
} else {
return $options;
}
}
/**
* Query the reader. Store results in the object for use by build_table.
*
* @param int $pagesize size of page for paginated displayed table.
* @param bool $useinitialsbar do you want to use the initials bar.
*/
public function query_db($pagesize, $useinitialsbar = true) {
$total = \tool_monitor\rule_manager::count_rules_by_courseid($this->courseid);
$this->pagesize($pagesize, $total);
$rules = \tool_monitor\rule_manager::get_rules_by_courseid($this->courseid, $this->get_page_start(),
$this->get_page_size());
$this->rawdata = $rules;
// Set initial bars.
if ($useinitialsbar) {
$this->initialbars($total > $pagesize);
}
}
/**
* Gets a list of courses where the current user can subscribe to rules as a dropdown.
*
* @return \single_select|bool returns the list of courses, or false if the select box
* should not be displayed.
*/
public function get_user_courses_select() {
global $DB;
// If the number of courses on the site exceed the maximum drop down limit do not display the select box.
$numcourses = $DB->count_records('course');
if ($numcourses > COURSE_MAX_COURSES_PER_DROPDOWN) {
return false;
}
$orderby = 'visible DESC, sortorder ASC';
$options = array();
if (has_capability('tool/monitor:subscribe', \context_system::instance())) {
$options[0] = get_string('site');
}
if ($courses = get_user_capability_course('tool/monitor:subscribe', null, true, 'fullname', $orderby)) {
foreach ($courses as $course) {
$options[$course->id] = format_string($course->fullname, true,
array('context' => \context_course::instance($course->id)));
}
}
$url = new \moodle_url('/admin/tool/monitor/index.php');
$select = new \single_select($url, 'courseid', $options, $this->courseid, array());
$select->set_label(get_string('selectacourse', 'tool_monitor'));
return $select;
}
}

Some files were not shown because too many files have changed in this diff Show More