L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-22309 report_singleview: Fixing wrong uses of get_role_users()

Browse Source
This commit is contained in:
David Monllao
2014-11-24 10:59:02 +08:00
parent de64c655e2
commit 3aeec06364
2 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
grade/report/singleview/classes/local/screen/grade.php
+7 -3
View File
@@ -123,9 +123,13 @@ class grade extends tablelike implements selectable_items, filterable_items {
public function init($selfitemisempty = false) {
$roleids = explode(',', get_config('moodle', 'gradebookroles'));
$this->items = get_role_users(
$roleids, $this->context, false, '',
'u.lastname, u.firstname', null, $this->groupid);
$this->items = array();
foreach ($roleids as $roleid) {
// Keeping the first user appearance.
$this->items = $this->items + get_role_users(
$roleid, $this->context, false, '',
'u.lastname, u.firstname', null, $this->groupid);
}
$this->totalitemcount = count_role_users($roleids, $this->context);
grade/report/singleview/classes/local/screen/select.php
+9 -5
View File
@@ -48,11 +48,15 @@ class select extends screen {
$roleids = explode(',', get_config('moodle', 'gradebookroles'));
$this->items = get_role_users(
$roleids, $this->context, false, '',
'u.id, u.lastname, u.firstname', null, $this->groupid,
$this->perpage * $this->page, $this->perpage
);
$this->items = array();
foreach ($roleids as $roleid) {
// Keeping the first user appearance.
$this->items = $this->items + get_role_users(
$roleid, $this->context, false, '',
'u.id, u.lastname, u.firstname', null, $this->groupid,
$this->perpage * $this->page, $this->perpage
);
}
$this->item = $DB->get_record('course', array('id' => $this->courseid));
}