MDL-47949 mod_wiki: Validate parameters for page deletion

This commit is contained in:
John Okely
2014-11-07 15:29:40 +08:00
committed by Damyon Wiese
parent 293f1b4d85
commit a481e32f02
+8 -1
View File
@@ -64,6 +64,13 @@ require_capability('mod/wiki:managewiki', $context);
//Delete page if a page ID to delete was supplied
if (!empty($delete) && confirm_sesskey()) {
if ($pageid != $delete) {
// Validate that we are deleting from the same subwiki.
$deletepage = wiki_get_page($delete)
if (!$deletepage || $deletepage->subwikiid != $page->subwikiid) {
print_error('incorrectsubwikiid', 'wiki');
}
}
wiki_delete_pages($context, $delete, $page->subwikiid);
//when current wiki page is deleted, then redirect user to create that page, as
//current pageid is invalid after deletion.
@@ -105,4 +112,4 @@ $wikipage->print_header();
$wikipage->set_view($option, empty($listall)?true:false);
$wikipage->print_content();
$wikipage->print_footer();
$wikipage->print_footer();