MDL-51015 mod_scorm: tidy up messy code, remove use of eval()

2015-08-06 22:21:48 +12:00
parent f593be963c
commit a3ca598f14
1 changed files with 6 additions and 4 deletions
@@ -1302,7 +1302,7 @@ function scorm_get_attempt_count($userid, $scorm, $returnobjects = false, $ignor
 * @return boolean - debugging true/false
 */
 function scorm_debugging($scorm) {
-    global $CFG, $USER;
+    global $USER;
    $cfgscorm = get_config('scorm');

    if (!$cfgscorm->allowapidebug) {
@@ -1314,9 +1314,11 @@ function scorm_debugging($scorm) {
    if (!preg_match('/^[\w\s\*\.\?\+\:\_\\\]+$/', $test)) {
        return false;
    }
-    $res = false;
-    eval('$res = preg_match(\'/^'.$test.'/\', $identifier) ? true : false;');
-    return $res;
+
+    if (preg_match('/^'.$test.'/', $identifier)) {
+        return true;
+    }
+    return false;
 }

 /**