L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-47400 gradereport_history: Ensure float precision is enforced

Browse Source 
Format floats according to the grade item config.
This commit is contained in:
Andrew Nicols
2014-10-20 15:42:31 +08:00
parent b49de5d930
commit a07ec4565f
1 changed files with 42 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
grade/report/history/classes/output/tablelog.php
+42
View File
@@ -63,6 +63,12 @@ class tablelog extends \table_sql implements \renderable {
*/
protected $cms;
/**
* @var int The default number of decimal points to use in this course
* when a grade item does not itself define the number of decimal points.
*/
protected $defaultdecimalpoints;
/**
* Sets up the table_log parameters.
*
@@ -83,6 +89,7 @@ class tablelog extends \table_sql implements \renderable {
*/
public function __construct($uniqueid, \context_course $context, $url, $filters = array(), $download = '', $page = 0,
$perpage = 100) {
global $CFG;
parent::__construct($uniqueid);
$this->set_attribute('class', 'gradereport_history generaltable generalbox');
@@ -96,6 +103,7 @@ class tablelog extends \table_sql implements \renderable {
$this->gradeitems = \grade_item::fetch_all(array('courseid' => $this->courseid));
$this->cms = get_fast_modinfo($this->courseid);
$this->useridfield = 'userid';
$this->defaultdecimalpoints = grade_get_setting($this->courseid, 'decimalpoints', $CFG->grade_decimalpoints);
// Define columns in the table.
$this->define_table_columns();
@@ -167,6 +175,40 @@ class tablelog extends \table_sql implements \renderable {
$this->define_headers(array_values($cols));
}
/**
* Method to display the final grade.
*
* @param \stdClass $history an entry of history record.
*
* @return string HTML to display
*/
public function col_finalgrade(\stdClass $history) {
if (!empty($this->gradeitems[$history->itemid])) {
$decimalpoints = $this->gradeitems[$history->itemid]->get_decimals();
} else {
$decimalpoints = $this->defaultdecimalpoints;
}
return format_float($history->finalgrade, $decimalpoints);
}
/**
* Method to display the previous grade.
*
* @param \stdClass $history an entry of history record.
*
* @return string HTML to display
*/
public function col_prevgrade(\stdClass $history) {
if (!empty($this->gradeitems[$history->itemid])) {
$decimalpoints = $this->gradeitems[$history->itemid]->get_decimals();
} else {
$decimalpoints = $this->defaultdecimalpoints;
}
return format_float($history->prevgrade, $decimalpoints);
}
/**
* Method to display column timemodifed.
*