Jun Pataleta
b72ce02928
Moodle release 4.0.11
2023-10-07 11:29:58 +08:00
Sara Arjona
bec75acf94
weekly release 4.0.10+
2023-10-06 14:02:34 +02:00
Laurent David
a58f091184
MDL-77795 mod_bigbluebuttonbn: Change meetingID on duplicate
...
* We need to set a different meetingID when duplicating or importing a
BigBlueButtonBN activity to prevent unwanted sharing of recordings between
meetings.
2023-10-06 08:49:29 +08:00
Paul Holden
21cb1ae77a
MDL-79310 enrol: restrict searched users to those user can view.
2023-10-04 14:31:52 +08:00
Paul Holden
c78948fe55
MDL-79310 forumreport_summary: report only on users who can be viewed.
2023-10-04 14:31:52 +08:00
Paul Holden
c64f39d187
MDL-79310 mod_forum: ensure only visible users can be exported.
2023-10-04 14:31:51 +08:00
Mikel Martín
4777e96a28
MDL-79509 mod_wiki: Improve comment editing
2023-10-04 02:05:15 +02:00
Paul Holden
ce38fda651
MDL-72249 message: stricter cleaning of processor type parameter.
2023-10-04 02:05:15 +02:00
Paul Holden
42fb4b1a6c
MDL-79426 gradeimport_csv: safely preview CSV content during import.
2023-10-04 02:05:15 +02:00
Paul Holden
96223014bd
MDL-79455 tool_uploadcourse: clean course data fields individually.
2023-10-04 02:05:15 +02:00
Paul Holden
5975ced7e1
MDL-79455 tool_uploadcourse: safe preview of uploaded course data.
2023-10-04 02:05:15 +02:00
Paul Holden
c1663de71e
MDL-79409 mod_imscp: appropriate unserialization of package structure.
2023-10-04 02:05:15 +02:00
Paul Holden
de05fca77a
MDL-79408 mod_lesson: safer unserializing/comparison of properties.
2023-10-04 02:05:15 +02:00
David Woloszyn
42518c7c4a
MDL-77846 core: Make endpoint revision number checks stricter
...
In some places we prevented cache poisoning, in others we did not. We
also did not place any restriction on the minimum value for a revision.
This change introduces a new set of functions for configonly endpoints
which validates the revision numbers passed in. If the revision is
either too old, or too new, it is rejected and the file content is not
cached. The content is still served, but caching headers are not sent,
and any local storage caching is prevented.
The current time is used as the maximum version, with 60 seconds added
to allow for any clock skew between cluster nodes. Previously some
locations used one hour, but there should never be such a large clock
skew on a correctly configured system.
Co-authored-by: Andrew Nicols <andrew@nicols.co.uk >
2023-10-04 02:05:15 +02:00
Huong Nguyen
5316b55716
MDL-66730 core_course: Improve permission check for category moving
...
Co-authored-by: Erica Bithell <egb10@cam.ac.uk >
2023-10-04 02:05:15 +02:00
Paul Holden
1ae0262730
MDL-78820 h5p: use fullname of current user as the xAPI actor name.
2023-10-04 02:05:15 +02:00
meirzamoodle
f0c3a4ae7c
MDL-78969 oauth2: remove auto-login after successful confirmation
...
With the new flow, users can go to the login page from the confirmed page,
and if the user successfully logs in, the user will be directed to the confirmed page.
To avoid that, the confirmed page can only be seen by users who are not logged in.
2023-10-04 02:05:15 +02:00
Paul Holden
1139407107
MDL-78971 quiz_grading: escape user identity fields on display.
2023-10-04 02:05:15 +02:00
Jun Pataleta
92b81af0a0
weekly release 4.0.10+
2023-10-04 07:49:22 +08:00
Huong Nguyen
3dc44686bc
Merge branch 'MDL-79247_400' of https://github.com/stronk7/moodle into MOODLE_400_STABLE
2023-10-03 09:58:25 +07:00
Eloy Lafuente (stronk7)
7db3ed235b
MDL-79247 forum: Workaround same-time discussion modified dates bug
...
Within the forum_get_discussion_neighbours() function of forum
when the discussions timemodified (last post) is the same, there
is a bug that does strange things when calculating the prev and
next discussions.
Note that, in real life, this is really hard to achieve, but in tests,
when multiple discussions and post can be created by generators in the
same second (specially when the test machine is quick), chances of
facing that problem are higher.
By adding 1 second wait, we ensure that the discussions won't have
the same timemodified (last post) and workaround the problem.
No mater of that, the problem deserves an issue to be created
so we guarantee from code that it also works ok when the same
timemodified (last post) situation happens.
2023-10-01 23:47:02 +02:00
Eloy Lafuente (stronk7)
c0587ac3a4
MDL-79247 forum: Make discussion list ordering deterministic
...
Note that normally this doesn't matter much, but there are situations
when we want the discussion list ordering fully consistent /
deterministic.
Specifically, when discussions (or forum posts )are created in the
same second, or when the discussion titles are repeated, or 2
discussions have the same number of votes... (any criteria in general),
in the context of testing, we don't want the order
to be non-consistent, so we need to provide an extra sorting
criterion to make it fully deterministic.
So, in this case, we are adding a sort by discussion.id <<DIRECTION>>
that is an unique value, primary key... so cheap to calculate and,
that way, when the 1st sorting column has repeated values, the id
will decide.
2023-10-01 23:47:02 +02:00
Jun Pataleta
0f8e3e7b88
weekly release 4.0.10+
2023-09-29 22:07:26 +08:00
Jun Pataleta
43d08df446
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-09-29 22:07:24 +08:00
AMOS bot
32e72da2aa
Automatically generated installer lang files
2023-09-29 00:08:01 +00:00
Ilya Tregubov
55430e7995
Merge branch 'MDL-79360/400' of https://github.com/skodak/moodle into MOODLE_400_STABLE
2023-09-28 09:38:59 +08:00
Sara Arjona
a55231cec8
weekly release 4.0.10+
2023-09-26 16:17:09 +02:00
Shamim Rezaie
af6368c392
Merge branch 'MDL-75928-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-09-25 17:52:35 +10:00
Simey Lameze
7a9b169ec3
MDL-75928 format_week: improve get_section_dates one week calc
2023-09-22 08:48:47 +08:00
Sara Arjona
168b8d84da
weekly release 4.0.10+
2023-09-15 17:34:16 +02:00
Petr Skoda
25bc96c1c1
MDL-79360 filter: fix nolink tag regression from MDL-77525
2023-09-15 12:45:31 +02:00
Ilya Tregubov
12fc97c1b7
Merge branch 'MDL-79220-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-09-14 17:44:18 +08:00
Ilya Tregubov
660a6b1172
Merge branch 'MDL-79195-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-09-14 09:38:25 +08:00
Ilya Tregubov
46ddf24625
Merge branch 'MDL-78806-400' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-09-13 10:56:10 +08:00
Eloy Lafuente (stronk7)
548b78ea84
weekly release 4.0.10+
2023-09-12 18:54:12 +02:00
Angelia Dela Cruz
f2eaea0ac3
MDL-79195 core_course: Activity and resource description display behat
2023-09-12 12:38:36 +08:00
Huong Nguyen
6c0eb76077
Merge branch 'MDL-79246-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-09-12 08:51:48 +07:00
Jun Pataleta
b82333dfd5
MDL-78806 mod_assign: Use new Behat step for checking page title
2023-09-10 23:33:44 +08:00
Jun Pataleta
21feaf77ba
MDL-78806 behat: Create a step that for checking the page title
...
Create a Behat step "the page title should contain ':title'" to check
the page title.
2023-09-10 23:33:43 +08:00
Jun Pataleta
d011da5803
weekly release 4.0.10+
2023-09-08 22:35:19 +08:00
Jun Pataleta
05b96be8d6
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-09-08 22:35:18 +08:00
Jun Pataleta
ade72f1cb2
MDL-78549 multianswer: Prevent default when clicking feedback trigger
2023-09-08 14:50:44 +08:00
Huong Nguyen
0832e78ba9
Merge branch 'MDL-78549-400' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-09-08 10:59:06 +07:00
AMOS bot
ccc82fc95a
Automatically generated installer lang files
2023-09-08 00:10:42 +00:00
Angelia Dela Cruz
48c594202a
MDL-79220 mod_glossary: Behat for glossary entry with attachment
2023-09-07 10:31:16 +08:00
Ilya Tregubov
0add4b7a6f
Merge branch 'MDL-76459_400' of https://github.com/stronk7/moodle into MOODLE_400_STABLE
2023-09-06 10:03:42 +08:00
AMOS bot
1d92692ad4
Automatically generated installer lang files
2023-09-05 14:25:06 +00:00
Jun Pataleta
d70101e521
MDL-78549 qtype_multianswer: Configure feedback popover trigger via JS
...
* For some reason, the `data-trigger="hover focus"` does not work when
rendering the popover via HTML. It just defaults to click, so the
feedback popover for qtype_multianswer questions does not show on hover.
Configuring the feedback popover's trigger via JS seems to work.
2023-09-05 09:36:16 +08:00
AMOS bot
b78c185e31
Automatically generated installer lang files
2023-09-05 00:11:46 +00:00
Andrew Nicols
2576867e7a
MDL-79246 gradingform_rubric: Use i_click_on for behat clicks
2023-09-04 09:13:09 +08:00
Eloy Lafuente (stronk7)
955a276e6e
MDL-76459 xmldb: Add environmental check to verify $CFG->prefix
...
While, right now, sites using long (> 10 chars) $CFG->prefix
can continue working (because we still don't have any table
> 28 chars), as soon as some new table with long name is added,
it won't work with PostgreSQL anymore (if the 63 limit is raised).
Hence, this environmental check will verify on both install and
upgrade that the $CFG->prefix is always <= 10 chars.
Sites with longer prefixes will need to rename all their tables
(and maybe other objects, depending on the dbtype) to use a shorter
prefix.
2023-09-02 09:22:36 +02:00
Andrew Nicols
e2111d83ee
weekly release 4.0.10+
2023-09-02 08:18:38 +08:00
Andrew Nicols
c1b33a6caf
Merge branch 'MDL-77831-400' of https://github.com/mickhawkins/moodle into MOODLE_400_STABLE
2023-09-01 10:38:44 +08:00
Jun Pataleta
c5231e4d28
Merge branch 'MDL-79017-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-08-31 20:31:53 +08:00
Michael Hawkins
573aa1c5bc
MDL-77831 core: Updated security.txt expiry and added additional info
2023-08-31 18:29:59 +08:00
Huong Nguyen
cae6b09efa
Merge branch 'MDL-79207-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-08-31 12:27:27 +07:00
Angelia Dela Cruz
676f899142
MDL-79207 core_course: Behat coverage for activity and resource deletion
2023-08-31 11:01:54 +08:00
Sara Arjona
91c90b6f5d
Merge branch 'MDL-78612-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-08-30 17:55:52 +02:00
Andrew Nicols
2e9dbfd2d1
MDL-78612 core: Wrap modal_factory.create in pendingPromise
2023-08-30 13:36:26 +08:00
Jun Pataleta
2ece3b7a84
weekly release 4.0.10+
2023-08-26 11:03:29 +08:00
Jun Pataleta
57c7642210
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-08-26 11:03:26 +08:00
Jun Pataleta
11f782c4a4
Merge branch 'MDL-79015-400-fix' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-08-25 09:53:54 +08:00
Simey Lameze
57a985b035
MDL-79015 behat: make verification step more specific
2023-08-25 08:59:13 +08:00
AMOS bot
7b63b9ad6c
Automatically generated installer lang files
2023-08-25 00:11:54 +00:00
Sara Arjona
b6a5b0c5d9
Merge branch 'MDL-78965-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-08-24 16:38:45 +02:00
Jun Pataleta
f636d3b8dc
Merge branch 'MDL-79015-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-08-24 15:53:20 +08:00
Angelia Dela Cruz
f3dbd537a5
MDL-78965 mod_quiz: Behat coverage for quiz with certainty-based marking
2023-08-24 15:13:41 +08:00
Jun Pataleta
f77b73fe51
Merge branch 'MDL-78941-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-08-24 13:05:37 +08:00
Angelia Dela Cruz
599cd75fe6
MDL-79015 mod_lesson: Behat coverage for lesson with access restriction
2023-08-24 13:05:31 +08:00
Angelia Dela Cruz
b784e61a0f
MDL-78941 mod_quiz: Behat coverage for student flagging quiz questions
2023-08-24 11:13:50 +08:00
Huong Nguyen
ac35349fcc
Merge branch 'MDL-78843-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-08-24 08:58:31 +07:00
Sara Arjona
567bb622b4
weekly release 4.0.10+
2023-08-22 15:51:07 +02:00
Ilya Tregubov
818ac5cc6c
Merge branch 'MDL-79078-400' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-08-22 09:11:03 +08:00
Paul Holden
5e91f88d4b
MDL-79017 core: re-factor method to unserialize array.
...
We can use the existing helper for object unserialization as the
base for this method, rather than manual string parsing.
2023-08-21 21:02:48 +01:00
Jun Pataleta
e9906db076
MDL-79078 grades: Wait for pending JS when navigating gradebook
2023-08-21 17:30:41 +08:00
Ilya Tregubov
456e8d0f73
weekly release 4.0.10+
2023-08-18 11:24:03 +08:00
Eloy Lafuente (stronk7)
2c6c256c51
Merge branch 'MDL-78684-400-fix-2' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-08-17 19:57:33 +02:00
Simey Lameze
e6684a65d7
MDL-78684 behat: fix behat failures
2023-08-17 21:15:45 +08:00
Jun Pataleta
1bae9ad509
Merge branch 'MDL-78938-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-08-17 09:58:16 +08:00
Andrew Nicols
d79615711c
Merge branch 'MDL-77695-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-08-16 23:23:37 +08:00
Andrew Nicols
c9682dfece
Merge branch 'MDL-78684-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-08-16 22:45:00 +08:00
Andrew Nicols
72ec24d812
MDL-78938 course: Wrap manual completion toggle in pending
...
This commit makes two changes to reduce random failures in behat:
- wrap the toggling of manually configured completion in pendingjs
- set the loading spinner content without forcing the completion toggle
ws to wait for the loading spinner to update.
2023-08-16 20:05:34 +08:00
Andrew Nicols
27efd067f8
MDL-78938 report_progres: Wrap completion status update in pending
2023-08-16 20:05:33 +08:00
Simey Lameze
750da4a57d
MDL-77695 behat: use automatic completion to award badges
2023-08-16 11:22:33 +08:00
Shamim Rezaie
358e1793f2
Moodle release 4.0.10
2023-08-11 23:20:17 +10:00
Huong Nguyen
3a794f0e78
weekly release 4.0.9+
2023-08-10 22:50:58 +07:00
Huong Nguyen
2a724ee1b9
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-08-10 22:50:56 +07:00
meirzamoodle
b797c1314f
MDL-78685 auth_oauth2: Added logged-in status check
2023-08-10 18:45:15 +07:00
Jun Pataleta
1f8f229ff0
MDL-78620 auth_cas: Pass base service URL for the CAS client
...
Since phpCAS v1.6.0, a required base service URL parameterneeds to be
passed to phpCAS::client(). This is basically the protocol, hostname,
and port number (optional) of the site connecting to the CAS server
in order for it to perform service URL discovery.
2023-08-10 18:45:15 +07:00
Jun Pataleta
4a3ef2c34d
MDL-78620 auth_cas: Bump thirdpartylibs version to 1.6.0
2023-08-10 18:45:15 +07:00
Jun Pataleta
3bef4646fa
MDL-78620 auth_cas: Update phpCAS to v1.6.0
2023-08-10 18:45:15 +07:00
David Woloszyn
56557c04a7
MDL-78620 lib: Set Moodle files after phpCAS upgrade
2023-08-10 18:45:15 +07:00
David Woloszyn
79d7685763
MDL-78620 lib: Upgrade phpCAS to 1.5.0
2023-08-10 18:45:14 +07:00
Michael Hawkins
7d120086ae
MDL-78763 tool_policy: Initialise returnurl as a moodle_url in viewall
2023-08-10 18:45:14 +07:00
Paul Holden
98078b96c8
MDL-78792 message: access checks in processor fragment callback.
2023-08-10 18:45:14 +07:00
raortegar
c1ed3e422d
MDL-74289 lib: Improve the proxy bypass matching
2023-08-10 18:45:11 +07:00
Simey Lameze
c7e549a46f
MDL-78843 behat: update get_forum_id to search for idnumber or name
...
This commit also converts manual steps to create discussions on the
Annoucements forum to data generator.
2023-08-10 10:05:24 +08:00
AMOS bot
57fa64c768
Automatically generated installer lang files
2023-08-08 00:10:27 +00:00
Paul Holden
a524ac4bb3
MDL-78647 files: safer unserializing of file reference data.
2023-08-04 12:55:23 +02:00
Shamim Rezaie
cddb24754e
MDL-66212 tool_lpimport: properly check capabilities
...
The moodle/competency:competencymanage capability should be checked
before showing the import and export pages.
2023-08-04 12:55:23 +02:00
Matt Porritt
eed4592b7c
MDL-78340 Blocks: Dashboards now respect block permission overrides
...
Patch makes user dashboard respect permission overrides
that have been set on individual blocks on the system
dashboard (indexsys.php). When a user dashboard is created
either when the user visits their dashboard for the first
time or after an admin reset. When blcoks are copied to
the new dashbaord overriden permissions are also copied.
2023-08-04 12:55:23 +02:00
Rajneel Totaram
00569bf0fe
MDL-71728 mod_quiz: check if user can access this page
2023-08-04 12:55:23 +02:00
Sara Arjona
d2b3068edb
weekly release 4.0.9+
2023-08-04 12:40:15 +02:00
Jun Pataleta
af2d5ea945
MDL-78498 mod_forum: Prevent race condition in forum recent activity
...
* Using the generator to create the forum discussions, the timecreated
of a discussion can be set before the user's last course access which
will prevent forum_print_recent_activity() from including this generated
discussion in the recent activity results. To work around this, generate
the forum discussion 1 second after the current time to make sure that
the user's last course access will always be before the discussion's
creation time.
* This patch also includes some optimisations by:
- Removing the unnecessary @javascript tag for the
`Time limit expires` scenario
- Bringing the discussion generation to each scenario to allow each
scenario to customise the data passed to the generator like for the
`Time limit expires` scenario.
- Navigating directly to the forum instance.
2023-08-03 11:33:38 +08:00
Jun Pataleta
cdfb51b114
Merge branch 'MDL-78498-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-08-02 11:22:50 +08:00
Sara Arjona
9077bade59
Merge branch 'MDL-78703-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-08-01 13:45:19 +02:00
Simey Lameze
066ea59ae5
MDL-78498 behat: add support for private replies
...
This commit adds support for private replies in the
'the following forum replies exist in course' custom step.
2023-08-01 16:08:18 +08:00
Angelia Dela Cruz
e24eb760ae
MDL-78498 Behat: Use data generators for forum posts and replies
...
This commit does few things:
* Replace manual forum posts and replies to use data generator.
* It also changes the code to handle social forums.
* Other behat clean-ups and optimization.
Co-authored-by: Simey Lameze <simey@moodle.com >
2023-08-01 16:08:18 +08:00
Angelia Dela Cruz
5017f192ba
MDL-78684 Behat: Replace gradebook navigation to use page resolvers
...
This commit also does other things such as:
- Replace manual steps to setup gradebook by data generators
- Added support for outcomes and scales page resolvers
- Behat clean up
2023-08-01 15:53:59 +08:00
Ilya Tregubov
5ab94239f4
weekly release 4.0.9+
2023-07-28 10:44:21 +08:00
Ilya Tregubov
a42e7c9294
Merge branch 'MDL-78782-400' of https://github.com/ferranrecio/moodle into MOODLE_400_STABLE
2023-07-27 10:00:40 +08:00
Ferran Recio
78d7191ea5
MDL-78782 behat: optimize with editing mode step
...
The current I am on course homepage with editing mode loads twice the
course page. This patch prevents this from happening by going directly
to editmode.php.
2023-07-26 16:19:48 +02:00
Huong Nguyen
95b25c6049
weekly release 4.0.9+
2023-07-21 20:56:36 +07:00
AMOS bot
1f18fb7f06
Automatically generated installer lang files
2023-07-19 00:10:57 +00:00
Paul Holden
dcc6ad76f1
MDL-78703 behat: fix HTTP GET method capitalization on redirect.
2023-07-15 01:00:09 +01:00
Ilya Tregubov
147c818fb0
weekly release 4.0.9+
2023-07-14 09:25:45 +08:00
Andrew Nicols
bfc7a5e99f
Merge branch 'MDL-78157-400' of https://github.com/golenkovm/moodle into MOODLE_400_STABLE
2023-07-13 09:48:31 +08:00
Eloy Lafuente (stronk7)
a84a4414da
Merge branch 'MDL-78673-400-fix' of https://github.com/sarjona/moodle into MOODLE_400_STABLE
2023-07-12 19:03:31 +02:00
Sara Arjona
90423dac85
MDL-78673 behat: Replace arrow function
2023-07-12 18:46:18 +02:00
Sara Arjona
ad99d89bfb
Merge branch 'MDL-78673-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-07-12 18:18:27 +02:00
Andrew Nicols
24e0649aa2
Merge branch 'MDL-77450-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-07-13 00:10:32 +08:00
Sara Arjona
66b25cb692
Merge branch 'MDL-78455-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-07-12 17:37:26 +02:00
Angelia Dela Cruz
6fcd9b72ba
MDL-77450 Behat: Behat cleanup and optimisation
2023-07-11 14:42:44 +08:00
Andrew Nicols
4136c6b0c9
MDL-78673 grade: Switch test to use generators
2023-07-10 11:31:55 +08:00
Andrew Nicols
64e4988bd6
MDL-78673 grade: Switch to behat navigation steps
2023-07-10 11:31:55 +08:00
Andrew Nicols
7fe6a2d902
MDL-78673 grade: Address random failure due to toast
2023-07-10 11:31:54 +08:00
Andrew Nicols
b621be27c7
MDL-78673 behat: Allow plugins to define their expansion of >
2023-07-10 11:31:54 +08:00
Ilya Tregubov
9544616f4c
weekly release 4.0.9+
2023-07-07 11:52:36 +08:00
Ilya Tregubov
ef6f73cb66
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-07-07 11:52:33 +08:00
Misha Golenkov
4d1b3728ea
MDL-78379 js: Add missing newline character
2023-07-06 16:18:07 +10:00
Jun Pataleta
dd7db44ee4
Merge branch 'MDL-78488_400' of https://github.com/t-schroeder/moodle into MOODLE_400_STABLE
2023-07-06 11:18:05 +08:00
Andrew Nicols
f3d31d27cf
Merge branch 'MDL-78614-400' of https://github.com/noeldemartin/moodle into MOODLE_400_STABLE
2023-07-05 20:31:15 +08:00
Andrew Nicols
256809abf5
Merge branch 'MDL-78158-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-07-05 10:24:19 +08:00
Andrew Nicols
4f39c6e364
Merge branch 'MDL-75324-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-07-04 13:30:26 +08:00
Simey Lameze
7b3360099d
MDL-75324 behat: use a proper step to verify completion status
2023-07-04 11:20:32 +08:00
Angelia Dela Cruz
5309a9d11a
MDL-78158 behat: Behat cleanup and optimisation
2023-07-04 09:32:31 +08:00
Angelia Dela Cruz
37ec0892ec
MDL-78158 Behat: Use data generators to add blocks
2023-07-04 09:11:12 +08:00
AMOS bot
5d1519b3a2
Automatically generated installer lang files
2023-07-04 00:11:34 +00:00
Noel De Martin
498d9ccb4a
MDL-78614 behat: Remove trailing quotes
2023-07-03 11:18:56 +02:00
Tim Schroeder
5dbc4d269d
MDL-78488 question bank: don't load statistics when they are disabled
2023-06-30 11:45:27 +02:00
AMOS bot
26c2bb411e
Automatically generated installer lang files
2023-06-30 00:08:36 +00:00
Huong Nguyen
7a98a43042
weekly release 4.0.9+
2023-06-29 22:22:26 +07:00
Paul Holden
ca3ec4d0b9
Merge branch 'MDL-78521-fix' of https://github.com/sarjona/moodle into MOODLE_400_STABLE
2023-06-29 11:53:29 +01:00
Sara Arjona
efc3e28c31
MDL-78521 badges: FixingPHP lint
...
This patch fixes a PHP lint error introduced in MDL-75552.
As this issue was closed a few weeks ago, I'm adding it to one
random issue integrated this week.
Thanks Eloy and Paul for your help! :-*
2023-06-29 12:39:54 +02:00
Ilya Tregubov
00916e1031
Merge branch 'MDL-77286-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-06-29 09:44:08 +08:00
Ilya Tregubov
0e60bb75f1
Merge branch 'MDL-78521-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-06-29 09:38:49 +08:00
Simey Lameze
52966bf12f
MDL-77286 behat: change window size to large to avoid random fails
2023-06-27 17:12:28 +08:00
Jun Pataleta
98823e97ce
Merge branch 'MDL-76724_400' of https://github.com/stronk7/moodle into MOODLE_400_STABLE
2023-06-26 19:38:17 +08:00
Simey Lameze
3c143613aa
MDL-78521 behat: reload page before asserting content
...
This commit also reword a Scenario name to make it unique
2023-06-26 11:19:56 +08:00
Eloy Lafuente (stronk7)
1b8b3e9ac8
MDL-76724 environment: Moodle 4.3 requirements
...
Note that there aren't changes since Moodle 4.2
so this is a complete copy of the information
for that version.
2023-06-24 12:30:08 +02:00
Sara Arjona
5d634426a5
weekly release 4.0.9+
2023-06-23 09:00:29 +02:00
Sara Arjona
ae430b853d
Merge branch 'MDL-76635-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-06-21 14:02:33 +02:00
Simey Lameze
a135175c9c
MDL-76635 comment: render the delete icon in the right place
...
Special thanks to Andrew Lyons.
2023-06-21 12:45:45 +08:00
Simey Lameze
aa0cef5e5b
MDL-76635 behat: improve submission comments test
2023-06-21 12:45:45 +08:00
Ilya Tregubov
5371d63c1a
Merge branch 'MDL-77525/400' of https://github.com/skodak/moodle into MOODLE_400_STABLE
2023-06-20 13:06:07 +08:00
Jun Pataleta
c2e6b8083a
Merge branch 'MDL-74021-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-06-20 10:13:13 +08:00
Angelia Dela Cruz
2c8f3c7ed5
MDL-74021 behat: Page behat generators use UI
...
Replace steps that manually add page instances via the UI and use
Behat generators. This improves the speed of Behat test runs.
Co-authored-by: Simey Lameze <simey@moodle.com >
2023-06-19 17:20:13 +08:00
Petr Skoda
abc2201890
MDL-77525 filter: add filtering stages
2023-06-17 16:51:08 +02:00
Andrew Nicols
2c14ed0469
weekly release 4.0.9+
2023-06-16 12:04:34 +08:00
Andrew Nicols
1650d0a1a8
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-06-16 12:04:30 +08:00
Angelia Dela Cruz
e79a71ca41
MDL-78455 Behat: Behat cleanup and optimisation for blog/tests/behat
2023-06-16 09:21:57 +08:00
Angelia Dela Cruz
cb0d17f530
MDL-78455 Behat: Add Behat for adding, editing and deleting blog entries
2023-06-16 09:21:22 +08:00
Ilya Tregubov
00fbed085a
Merge branch 'MDL-70152-400-fix' of https://github.com/ilyatregubov/moodle into MOODLE_400_STABLE
2023-06-15 12:11:59 +08:00
Simey Lameze
224da4b2b0
MDL-70152 behat: reply to post using data generator
2023-06-15 12:07:11 +08:00
Andrew Nicols
8ff3117478
Merge branch 'MDL-69231-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-06-15 10:55:48 +08:00
Ilya Tregubov
4ce13b411d
Merge branch 'MDL-76733-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-06-15 10:24:50 +08:00
Andrew Nicols
220132391e
MDL-76733 mod_assign: Remove JS requirement for time-based tests
...
Converting these tests to use an onlinetext submission and drop the JS
requirement means that they are much less susceptible to runtime issues,
and not susceptible to those caused by JS at all.
2023-06-15 09:34:06 +08:00
Andrew Nicols
75f833524b
MDL-76733 mod_assign: Address random failure
...
This random failure was happening because of the time required to render
and interact with the file picker which sometimes exceeded 2 seconds,
depending on the speed of the machine running the tests.
Converting these tests to use an onlinetext submission and drop the JS
requirement means that they are much less susceptible to runtime issues,
and not susceptible to those caused by JS at all.
2023-06-15 09:33:42 +08:00
AMOS bot
afedc33bd5
Automatically generated installer lang files
2023-06-15 00:16:18 +00:00
Sara Arjona
f0de6ba61b
Merge branch 'MDL-76733-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-06-14 16:22:49 +02:00
Jun Pataleta
2b4e791a66
Merge branch 'MDL-78466-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-06-14 16:00:04 +08:00
Ilya Tregubov
cbea4fa598
Merge branch 'MDL-70152-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-06-14 13:25:29 +08:00
Andrew Nicols
01e9d88cef
MDL-78466 cache: Add new result_found helper
...
This helper is intended to prevent recurrences of this issue by moving
the guess-work to something well tested.
2023-06-14 09:35:40 +08:00
Andrew Nicols
dbdd331392
MDL-78466 cache: Perform strict test on static cache values
...
If a statically accelerated cache returns an empty array then the value
was still fetched from the non-static cache store.
The check of the `$result` should be strictly checked against `false`,
which is the value used if no value was found.
2023-06-14 09:28:48 +08:00
Ilya Tregubov
19c271d45e
Moodle release 4.0.9
2023-06-10 14:08:16 +08:00
Ilya Tregubov
c24ae4c087
weekly release 4.0.8+
2023-06-09 13:14:32 +08:00
Sara Arjona
3828e7ad80
Merge branch 'MDL-78415-400-enfix' of https://github.com/vmdef/moodle into MOODLE_400_STABLE
2023-06-08 20:33:22 +02:00
Helen Foster
3c37cae46b
MDL-78415 lang: Import fixed English strings (en_fix)
2023-06-08 12:07:48 +01:00
Sara Arjona
792c35ac30
Merge branch 'MDL-77946-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-06-08 06:57:02 +02:00
Sara Arjona
87945beba8
Merge branch 'MDL-78308-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-06-08 06:48:46 +02:00
Andrew Nicols
bafc80cb04
Merge branch 'MDL-75696_400_STABLE' of https://github.com/marxjohnson/moodle into MOODLE_400_STABLE
2023-06-08 12:31:43 +08:00
Andrew Nicols
d253d86307
Merge branch 'MDL-78364-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-06-08 12:20:04 +08:00
Andrew Nicols
3b1205dae8
Merge branch 'MDL-78008_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-06-08 12:10:48 +08:00
Andrew Nicols
382f973727
Merge branch 'MDL-77933-400' of https://github.com/snake/moodle into MOODLE_400_STABLE
2023-06-08 12:03:54 +08:00
Andrew Nicols
546baf2d7a
MDL-76838 core: Add unit test for invalid unicode sequences
2023-06-08 11:59:28 +08:00
Jake Dallimore
5a423b4e56
MDL-77933 enrol_lti: return site name and logo during registration
...
Instead of the Moodle icon and the 'moodle' lang string, return the
site fullname and compact logo during dynamic registration.
2023-06-08 11:59:12 +08:00
Andrew Nicols
3801d87036
Merge branch 'MDL-76838-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-06-08 11:54:54 +08:00
Jun Pataleta
dbf53a848a
Merge branch 'MDL-75898-40' of https://github.com/matthewhilton/moodle into MOODLE_400_STABLE
2023-06-08 11:42:59 +08:00
Andrew Nicols
23376f93b8
Merge branch 'MDL-78026-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-06-08 11:37:17 +08:00
Andrew Nicols
eb9c234345
Merge branch 'MDL-77264-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-06-08 11:33:17 +08:00
Andrew Nicols
bbe3109992
Merge branch 'MDL-76821-400' of https://github.com/snake/moodle into MOODLE_400_STABLE
2023-06-08 11:30:23 +08:00
Andrew Nicols
72e923f90b
Merge branch 'MDL-77799-m400' of https://github.com/sammarshallou/moodle into MOODLE_400_STABLE
2023-06-08 11:21:48 +08:00
Jun Pataleta
452d18a8bc
Merge branch 'MDL-70833_400' of https://github.com/stronk7/moodle into MOODLE_400_STABLE
2023-06-08 11:12:30 +08:00
Andrew Nicols
bc50b73d15
Merge branch 'MDL-78408-400' of https://github.com/snake/moodle into MOODLE_400_STABLE
2023-06-08 11:06:14 +08:00
Andrew Nicols
2f42e68b80
Merge branch 'wip_MDL-78400_m40' of https://github.com/gjb2048/moodle into MOODLE_400_STABLE
2023-06-08 10:59:32 +08:00
Andrew Nicols
27249f3681
Merge branch 'MDL-76406-400' of https://github.com/safatshahin/moodle into MOODLE_400_STABLE
2023-06-08 10:41:47 +08:00
Jun Pataleta
68fa6f77d1
Merge branch 'MDL-76842-400' of https://github.com/snake/moodle into MOODLE_400_STABLE
2023-06-08 10:34:05 +08:00
Jun Pataleta
0f4f1c60d4
Merge branch 'MDL-78229-400' of https://github.com/lucaboesch/moodle into MOODLE_400_STABLE
2023-06-08 10:30:15 +08:00
Jake Dallimore
e76dd382a0
MDL-76842 enrol_lti: fix user record updates in user_repository
...
Only call user_update_user when the relevant user data has changed,
preventing unnecessary user_updated events. This also removes the
line setting timemodified on the user since user_update_user already
handles this.
2023-06-08 10:29:40 +08:00
Jun Pataleta
5a04d7fc30
Merge branch 'MDL-78431-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-06-08 10:28:12 +08:00
Jake Dallimore
ddcb3c7d13
MDL-76842 enrol_lti: test confirming the erroneous user_updated events
...
This test will fail until the fix - only updating users when data has
changed - is put in place in the following commit.
2023-06-08 09:43:11 +08:00
Jake Dallimore
1946ca5954
MDL-76842 auth_lti: don't update the user unless data has changed
...
When receiving data from the LTI launch, or service call, only update
the user record when we know something has changed. This prevents the
creation of many \core\event\user_updated events.
2023-06-08 09:43:10 +08:00
Jake Dallimore
2dcd4f8e78
MDL-76842 auth_lti: don't update the user after membership creation
...
This isn't required and generates excess events. The only thing update
does, other than update the user fields, is to update the picture, but
in this case, that's unset in membership-based auths anyway, so it's
entirely safe to remove this.
2023-06-08 09:42:19 +08:00
Jake Dallimore
bc29553eb7
MDL-76842 auth_lti: test confirming the erroneous user_updated events
...
This test will fail until the fix - only updating users when data has
changed - is put in place in the following commit.
2023-06-08 09:42:19 +08:00
Stevani Andolo
777e72beff
MDL-78215 core: Added support unit test
2023-06-08 09:37:21 +08:00
Stevani Andolo
6ae19a6c9a
MDL-78215 core: support checking if 0.0.0.0 is in subnet
2023-06-08 09:37:21 +08:00
Jun Pataleta
ae685a0809
Merge branch 'MDL-78378-400' of https://github.com/sarjona/moodle into MOODLE_400_STABLE
2023-06-07 23:25:28 +08:00
Andrew Nicols
555622abf2
MDL-78431 core: Abort after config for source maps
2023-06-07 21:08:00 +08:00
Sara Arjona
815f0b338f
Merge branch 'MDL-78322-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-06-07 12:43:16 +02:00
Sara Arjona
52ea8ee444
Merge branch 'MDL-78352-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-06-07 12:41:21 +02:00
Sara Arjona
f64987f510
Merge branch 'MDL-78047-400' of https://github.com/stevandoMoodle/moodle into MOODLE_400_STABLE
2023-06-07 18:20:27 +08:00
Sara Arjona
12a20b2d7a
Merge branch 'MDL-78010-400' of https://github.com/ferranrecio/moodle into MOODLE_400_STABLE
2023-06-07 18:20:27 +08:00
sam marshall
16cb641103
MDL-77799 webservice_rest: unhandled exception should go in server log
2023-06-07 10:05:43 +01:00
Jake Dallimore
d293744f08
MDL-78408 core: fix restoration of anchor to wantsurl during login
2023-06-07 14:31:58 +08:00
Stevani Andolo
6b4ae661dc
MDL-78047 core_courseformat: Wrapping added to text and media activity
2023-06-07 12:58:27 +08:00
Paul Holden
e8cc468184
MDL-77193 mnet: correct sorting of access control table.
2023-06-07 09:53:57 +08:00
Ferran Recio
e71f208a90
MDL-78010 mod_label: improve upgrade performance
2023-06-06 21:33:11 +02:00
Petr Skoda
90c23c7543
MDL-76683 core_group: fix template
2023-06-06 09:25:17 +00:00
Sara Arjona
34fbef096e
Merge branch 'MDL-76936-400' of https://github.com/HirotoKagotani/moodle into MOODLE_400_STABLE
2023-06-06 11:22:21 +02:00
Paul Holden
403bf57a8c
MDL-78364 reportbuilder: earlier calculation of schedule recipients.
2023-06-05 16:22:35 +01:00
Gareth Barnard
4fbc60a455
MDL-78400 JavaScript: Building JS puts build files in src dir on Win.
2023-06-05 14:50:45 +01:00
Luca Bösch
bb54ea04ea
MDL-78229 quiz: quiz editing page less narrow.
...
This is a backport of MDL-77872.
2023-06-02 08:34:50 +02:00
Sara Arjona
70f5d8d547
MDL-78378 survey: Display default introduction when description is empty
...
This is a regression when the activity pages were redessigned in Moodle
4.0. The default introduction should be displayed when the activity
description is empty.
2023-06-02 08:19:43 +02:00
Simey Lameze
78aa80dd5f
MDL-69231 behat: remaining work for role capability generator
...
This commit does few things:
* Unify data generators usage to role short name.
* Replace remaining manual steps to use the new data generator.
* Also replaced other manual steps to set config to use data generators.
* Tidy up of some tests, aligning pipes and splitting one line steps into multiple lines.
* Fixes tests to have one Given/When/Then per scenario.
2023-06-02 12:39:52 +08:00
Andrew Nicols
063e8fb534
MDL-69231 behat: Update tests to use new generator
2023-06-02 12:39:52 +08:00
Andrew Nicols
091aa9b872
MDL-69231 tests: Add role capability setting generator
2023-06-02 12:39:52 +08:00
Andrew Nicols
521e21d842
MDL-69231 tests: Improve existing role generator
...
Support definition of context levels and permissions.
2023-06-02 12:39:52 +08:00
Safat
c2e0c4a533
MDL-76406 core: Add environment check for versions not supporting 8.2
2023-06-02 12:09:41 +10:00
Ilya Tregubov
52a4f2d030
weekly release 4.0.8+
2023-06-02 09:55:48 +08:00
Ilya Tregubov
0630a13602
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-06-02 09:55:46 +08:00
Andrew Nicols
36ee03c6f2
Merge branch 'MDL-77749-unset-config-duration-MOODLE_400_STABLE' of https://github.com/brendanheywood/moodle into MOODLE_400_STABLE
2023-06-01 12:03:46 +08:00
Andrew Nicols
38e27840b7
Merge branch 'MDL-78327_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-06-01 10:53:22 +08:00
Ilya Tregubov
dbbd50c5d2
Merge branch 'MDL-78196-400' of https://github.com/jleyva/moodle into MOODLE_400_STABLE
2023-06-01 10:40:57 +08:00
Ilya Tregubov
c7262e9ffb
Merge branch 'MDL-77259-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-06-01 09:30:34 +08:00
Ilya Tregubov
57faab092e
Merge branch 'MDL-75961-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-06-01 09:08:52 +08:00
AMOS bot
1868ec834e
Automatically generated installer lang files
2023-06-01 00:10:59 +00:00
Sara Arjona
7d496dcfda
Merge branch 'MDL-76693-400' of https://github.com/roland04/moodle into MOODLE_400_STABLE
2023-05-31 17:09:10 +02:00
Simey Lameze
770cb3107b
MDL-77547 behat: run recalculate task before checking values
2023-05-31 15:04:57 +02:00
Tim Hunt
32909a830d
MDL-78327 question stats: store same timestamp for all question stats
2023-05-31 12:04:53 +01:00
Sara Arjona
3c93359478
Merge branch 'MDL-77547-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-05-31 12:51:49 +02:00
Sara Arjona
3f70b37d28
Merge branch 'MDL-77907-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-05-31 12:18:18 +02:00
Sara Arjona
3c84e5e76f
Merge branch 'MDL-78148-400' of https://github.com/ferranrecio/moodle into MOODLE_400_STABLE
2023-05-31 11:42:22 +02:00
Ilya Tregubov
5ab14b5143
Merge branch 'MDL-73138-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-30 12:54:39 +08:00
Ilya Tregubov
71ff178dd1
Merge branch 'MDL-77723-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-30 12:45:27 +08:00
AMOS bot
6478958c64
Automatically generated installer lang files
2023-05-30 00:10:32 +00:00
Jun Pataleta
14be143e7d
Merge branch 'MDL-78314-400' of https://github.com/lucaboesch/moodle into MOODLE_400_STABLE
2023-05-29 17:34:54 +08:00
Mikel Martín
957c2121b3
MDL-76693 core_course: Fix activity chooser summary overlap
...
In activity chooser modal, there is an overlap issue in the information "sub-page".
Changing some classes in the layout solves the problem.
2023-05-29 09:38:25 +02:00
Ferran Recio
a32e4be652
MDL-78148 core_courseformat: reduce the use of uniqid in templates
2023-05-29 08:40:15 +02:00
Angelia Dela Cruz
e0e4b2fad2
MDL-70152 behat: Forum behat generators use UI
...
Behat cleanup and optimisation
2023-05-29 10:24:10 +08:00
Angelia Dela Cruz
b6928826e1
MDL-70152 behat: Forum behat generators use UI
...
Replace steps that manually add forum and forum post instances
via the UI and use Behat generators. This improves the speed of
Behat test runs.
2023-05-29 10:24:02 +08:00
Andrew Nicols
35cea45566
MDL-70152 forum: Create behat data generator
...
* Convert track_read_posts.feature to use activity and discussion
data generators as exmaple.
Co-authored-by: Jun Pataleta <jun@moodle.com >
2023-05-29 10:24:02 +08:00
Eloy Lafuente (stronk7)
f9e4dcba02
MDL-70833 auth_mnet: Fix update_enrolments request
...
This is a backport of the commit integrated as part
of MDL-76055 where we needed the update_enrolments
working to be able to test them. Summary:
- Fixes a typo in table name preventing it to be updated ever.
- Fix outer join that was missing records.
- Stop playing and mixing ids (local and remote).
- Better control which enrolments have to be kept (previously
they were being deleted immediately after creating them).
- Improve the coding style of inserts.
- Modernise the deletions to use sql helper and work win 0..n ids.
2023-05-26 18:05:31 +02:00
Luca Bösch
d175832b54
MDL-78314 quiz: style button fieldset in "Manually grade question".
2023-05-26 15:11:33 +02:00
Paul Holden
959bb8ba01
MDL-78352 webservice: use default user context page heading.
2023-05-26 12:27:48 +01:00
Paul Holden
d9f99faf70
MDL-73138 user: avoid double encoding participant filter values.
2023-05-26 10:25:56 +01:00
Paul Holden
53dad06c2f
MDL-73138 group: remove double encoding of group/role names.
2023-05-26 10:25:56 +01:00
Sara Arjona
abb8647b62
weekly release 4.0.8+
2023-05-26 09:29:00 +02:00
Sara Arjona
2f36b9f6b8
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-05-26 09:28:56 +02:00
Jun Pataleta
fcf13290e9
Merge branch 'MDL-78346-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-05-25 16:22:28 +08:00
Andrew Nicols
fbc7ce063f
MDL-78346 tool_langimport: Print any notifications before redirect
2023-05-25 14:55:42 +08:00
Jun Pataleta
723c26a244
Merge branch 'MDL-76065-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-05-25 11:57:17 +08:00
Jun Pataleta
2e7b8495b9
Merge branch 'MDL-78320-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-25 11:49:00 +08:00
Jun Pataleta
403534f4d1
Merge branch 'MDL-78346-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-05-25 11:46:46 +08:00
Andrew Nicols
57e7158352
MDL-78346 tool_langimport: Redirect after action to prevent resubmission
2023-05-25 11:43:41 +08:00
Andrew Nicols
6f3c18b235
MDL-78346 tool_langimport: Prevent uninstallation of invalid targets
2023-05-25 11:43:41 +08:00
Andrew Nicols
a110b023da
Merge branch 'MDL-77995-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-25 09:50:57 +08:00
Paul Holden
877abfd439
MDL-78320 quiz_overview: format group names in overview report.
2023-05-24 16:19:37 +01:00
Simey Lameze
70d21a7e13
MDL-75961 behat: review and enhance mod_imscp tests
...
This commit makes the following improvements to mod_imscp tests:
* Removes unnecessary @javascript and @_file_upload tags from non-JS tests.
* Removes user/enrol data generation from tests that can be performed as admin.
* Removes "I log out" and other unnecessary steps.
2023-05-24 10:42:44 +08:00
Angelia Dela Cruz
e00ab12485
MDL-75961 behat: IMSCP behat generators use UI
...
Replace steps that manually add IMSCP instances via the UI and use
Behat generators. This improves the speed of the Behat test runs.
2023-05-24 10:42:44 +08:00
Sara Arjona
9749d7021b
Merge branch 'MDL-78176_400' of https://github.com/AnupamaSarjoshi/moodle into MOODLE_400_STABLE
2023-05-23 17:46:06 +02:00
Sara Arjona
41692c0191
Merge branch 'MDL-78242-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-23 17:37:05 +02:00
Angelia Dela Cruz
3b1625e332
MDL-77547 Behat: Coverage to check for bad multichoice questions
2023-05-23 15:23:46 +08:00
Jun Pataleta
5fa205bc47
Merge branch 'MDL-76688/400' of https://github.com/skodak/moodle into MOODLE_400_STABLE
2023-05-23 15:21:52 +08:00
Simey Lameze
81bb508e7e
MDL-76065 behat: Review and enhance mod_lti Behat tests
...
In this commit, the following improvements were made to the mod_lti Behat tests:
* Replaced manual steps with data generators to set completion.
* Eliminated unnecessary user and course enrolments data generation as some tests can be performed as an admin.
* Removed the @javascript tag from non-JS tests.
* Updated the LTI data generator to generate an internal Moodle URL in the toolurl field, enabling the use of XML files.
2023-05-23 12:28:44 +08:00
Angelia Dela Cruz
6d35e44e17
MDL-76065 behat: LTI behat generators use UI
...
Replace steps that manually add LTI instances via the UI and use
Behat generators. This improves the speed of the Behat test runs.
2023-05-23 12:28:32 +08:00
Andrew Nicols
8340d958cd
MDL-76733 mod_assign: Tidy up availability behat tests
...
This feature had lots of small issues and it made sense to fix it whilst
investigating a query:
* most of the steps do not require JavaScript
* it uses the UI to set an admin setting, for every scenario:
** only 3-4 of the scenarios actually test that setting
** it is very slow to do it his way when we have a generator step we can use
* we create two assignments in the Background, but each test only uses one of them
* we create the assignments in the Background with a generator, but
update them to modify various settings in each Scenario using the UI
when we should just create one assignment for each test and set it up
correctly for that Scenario
2023-05-23 10:58:07 +08:00
Andrew Nicols
b3d5c50f90
Merge branch 'MDL-78170-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-23 10:28:47 +08:00
AMOS bot
75636cd51d
Automatically generated installer lang files
2023-05-23 00:10:24 +00:00
Paul Holden
fa042d8849
MDL-76838 backup: remove invalid utf8 code sequences writing XML.
...
The surrogate blocks FFFE and FFFF are non-characters, specifically
disallowed in the character range for XML documents.
2023-05-22 21:04:17 +01:00
Paul Holden
744a3438d8
MDL-78322 tool_cohortroles: don't assign roles to deleted users.
2023-05-22 20:14:45 +01:00
Tim Hunt
d550d1361d
MDL-78008 qtype_multianswer: random guess score with missing subqs
...
Sometimes, due to other bugs, subquestions can get lost, so the code
needs to be robust to this.
2023-05-22 17:02:39 +01:00
Sara Arjona
0d650c383f
Merge branch 'MDL-78211-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-22 17:41:53 +02:00
Sara Arjona
127d614364
Merge branch 'MDL-78226-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-22 17:29:32 +02:00
Sara Arjona
5f0c5919c7
Merge branch 'MDL-78225-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-22 12:04:24 +02:00
Jun Pataleta
3cd579649d
Merge branch 'MDL-78157-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-05-22 15:29:23 +08:00
Andrew Nicols
e4f344282e
MDL-78157 js: Be more careful about inserting missing module names
...
It is perfectly legitimate to create and/or use a method named `define`
in JS outside of RequireJS.
Unfortunately our requirejs.php wrapper is dumb and does not understand
this.
In the long term we need to stop doing this at all. We really should be
able to already, but every time I try to something prevents it.
In the interim, this change adds a secondary check to see if there is an
existing define which _does_ have the right name in it already.
2023-05-22 14:40:41 +08:00
Anupama Sarjoshi
dc2d6f879a
MDL-78176 Question: Fix D&D onto image and D&D markers theme issue
2023-05-19 16:26:01 +01:00
Jun Pataleta
d6707840e0
weekly release 4.0.8+
2023-05-19 21:14:04 +08:00
Jun Pataleta
c94c9f4769
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-05-19 21:14:01 +08:00
Andrew Nicols
2fdf057520
MDL-77733 behat: Remove extraneous no-axe option
...
There is no need for no-axe if we make axe a boolean value. We already
have automatic support for negated boolean flags.
2023-05-19 11:28:19 +08:00
Mark Johnson
34134cdfc0
MDL-75696 quiz: Fix restoring pre-4.0 quizzes with random questions
...
Restoring multiple quizzes from a pre-4.0 backup was broken when
the quizzes shared a random question. This is because after the
first quiz created a set reference in place of the random question,
it deleted the question record so it was not there for the second
quiz to use. This change tracks the IDs of random questions so
they can be deleted at the end.
2023-05-18 16:01:03 +01:00
Mark Johnson
ad0ea3ea97
MDL-75696 quiz: Set default value for includingsubcategories on restore
2023-05-18 16:01:03 +01:00
Mark Johnson
e815a1c376
MDL-75696 backup: Fix backup version checks
...
Several version checks were incorrectly using
restore_controller::info::moodle_release instead of moodle_version as a
version number. This replaces all of those checks with a common pair of
methods to make the checks clearer and more maintainable.
2023-05-18 16:01:02 +01:00
Paul Holden
01b12e91ac
MDL-78308 output: better parsing of custom menu item configuration.
...
Previously certain values would cause deprecation notices in PHP8.1.
2023-05-18 10:19:16 +01:00
Jun Pataleta
2798d551c5
Merge branch 'MDL-78135-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-18 11:54:40 +08:00
Andrew Nicols
357a23967e
Merge branch 'MDL-78260_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-05-18 11:51:58 +08:00
Andrew Nicols
83c9db9e08
Merge branch 'MDL-77733-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-05-18 11:44:47 +08:00
Tim Hunt
0a42c83bce
MDL-78260 quiz stats: fix View details for random questions
2023-05-17 09:05:33 +01:00
Ilya Tregubov
2fa03a28ea
Merge branch 'MDL-78152-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-17 15:08:04 +08:00
AMOS bot
f7200165ec
Automatically generated installer lang files
2023-05-17 00:10:54 +00:00
Jun Pataleta
df846aca78
Merge branch 'MDL-77439-400' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-05-16 20:39:22 +08:00
Peter Mayer
11d09e2a4c
MDL-77439 lib_filebrowser: Splitup query to speedup get_courses
2023-05-16 20:38:06 +08:00
Paul Holden
41f5254aab
MDL-78026 group: format retrieved group names from external methods.
2023-05-16 10:10:12 +01:00
Paul Holden
4acab9aaaf
MDL-77264 grade: define fallback name of abstract export event.
2023-05-16 09:54:46 +01:00
Paul Holden
aab6b69293
MDL-77259 tool_monitor: use core component API for event list.
...
The previous method of hardcoded filepaths, specifically for events
belonging to core, meant that any events belongs to core subsystems
were omitted (core_customfield, core_h5p, core_payment, etc).
2023-05-16 09:50:28 +01:00
Angelia Dela Cruz
cd4b6f36ab
MDL-77907 Behat: Coverage for duplicating competency framework
2023-05-16 16:28:01 +08:00
Jun Pataleta
db862f2be8
Merge branch 'MDL-75576_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-05-16 09:58:54 +08:00
Andrew Nicols
a18b419ad1
Merge branch 'MDL-77432-400' of https://github.com/lucaboesch/moodle into MOODLE_400_STABLE
2023-05-15 22:12:56 +08:00
Andrew Nicols
6131e8c4a2
Merge branch 'MDL-78140-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-15 22:04:07 +08:00
Paul Holden
4b8c829ea8
MDL-78242 roles: consistently check course contact config.
2023-05-15 13:04:50 +01:00
Tim Hunt
118d3e855a
MDL-75576 quiz/question statistics: don't expire by time
...
Previously, a set of calculated quiz statistics would only 'last' for
15 minutes. Then they would be considered invalid and not used.
Now, computed statistics are kept indefinitely. Instead, when a new
batch of values are computed for a particular set of settings, older numbers
for the same settings are deleted first. Therefore,
question_stats_cleanup_task is no more.
2023-05-15 10:05:45 +01:00
Tim Hunt
a3ba4772a5
MDL-75576 quiz statistics: don't time-limit the use of cached values
...
This should have been done as part of MDL-74762, but was missed.
2023-05-15 10:05:43 +01:00
Tim Hunt
5f2ce7c383
MDL-75576 quiz statistics: don't compute when a user views the qbank
...
Previously, when users viewed the question bank, if the quiz statistics
had not already been calculated, we would try to compute them there an then.
This could be very, very slow, leading to session lock problems.
Now, we never try to compute the statistics on the fly. Instead, we rely
on the existing \quiz_statistics\task\recalculate scheduled task to do it.
2023-05-15 10:05:43 +01:00
Tim Hunt
a187d7930d
MDL-75576 question bank: bulk-load statistics for all questions at once
...
There is a new method on the column class, for the column to declare any
statistics it requires. The question then efficiently loads all those
statistics in one go, and makes them available as the columns are
rendererd, or do any subsequent processing.
2023-05-15 10:05:43 +01:00
Tim Hunt
9deabf8344
MDL-75576 qbank_statistics: remove copy-pasted PHPdoc comments
...
These methods are already correctly documented on the base class.
2023-05-15 10:05:43 +01:00
Paul Holden
1a217b5b0e
MDL-77995 javascript: more precise path matching building JS.
2023-05-15 09:05:56 +01:00
Paul Holden
236befd139
MDL-77723 user: ensure identity refers to a valid custom profile field.
2023-05-15 09:03:45 +01:00
Jun Pataleta
eb836fee86
Merge branch 'MDL-76903-400' of https://github.com/laurentdavid/moodle into MOODLE_400_STABLE
2023-05-15 12:05:56 +08:00
Andrew Nicols
a0fe28c1b7
Merge branch 'MDL-78125-400' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-05-15 11:59:21 +08:00
Jun Pataleta
63ae4b4297
MDL-78125 qtype_multianswer: Convert popover trigger to link
...
According to Boostrap Popovers documentation for popovers triggered
on focus:
"For proper cross-browser and cross-platform behavior, you must use the
<a> tag, not the <button> tag, and you also must include a tabindex
attribute."
2023-05-12 22:47:28 +08:00
Luca Bösch
d7c80d9c14
MDL-77432 mod_assign: Confirm submission page standard and not incourse
2023-05-12 09:42:22 +02:00
Ilya Tregubov
0ec98042d6
weekly release 4.0.8+
2023-05-12 08:56:56 +08:00
Ilya Tregubov
4a1e0aa084
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-05-12 08:56:54 +08:00
Cameron Ball
89d8c9ec0a
MDL-75898 assignfeedback_editpdf: Add randomness to PDF annotations
...
The behat step "I draw on the pdf" creates the exact same line every
time it is called. This can cause issues in a situation like the following:
- Student uploads PDF
- Teacher annotates page 1
- Student edits submission, adding another PDF
- Teacher annotates page 1 again
- When the student looks at their annotated PDF it appears the same as
before they added the second PDF (i.e., they don't see extra pages for
the second PDF)
Exactly why this happens isn't clear, and in practice this probably never
happens because the chances of drawing the exact same line twice are almost
0. However, when testing the functionality added in MDL-45580 it was causing
issues.
2023-05-12 09:18:40 +10:00
Cameron Ball
fc66d6cfd9
MDL-75898 assignfeedback_editpdf: Don't poll readonly pages
...
When requesting the readonly version of pages (which contain
teacher annotations), they should always be available - the
PHP side even throws an exception when they're not. This
means we don't need to worry about polling document converters
from the JS side and can just return the pages immediately.
2023-05-12 09:18:40 +10:00
Cameron Ball
0c2a15738f
MDL-75898 assignfeedback_editpdf: Improve page count mismatch logic
...
MDL-45580 introduced the readonlypages filearea, and when loading
page images for an attempt, the code would check if the pages existed
, creating them if not. The code inside this block also contained
a guard clause for the case where no readonly pages existed - which
is a situation that should not happen. Whenever readonly pages are
requested, they should exist.
MDL-66626 introduced a situation where page counts not matching would
also retrigger page generation. However this led to a situation where
the guard clause could be entered when requesting readonly pages.
This patch refactors the guard clause, and improves the logic to
regenerate pages.
2023-05-12 09:18:40 +10:00
Paul Holden
92547b151a
MDL-78226 contentbank: verify presence of bank heading element.
2023-05-11 23:16:35 +01:00
Paul Holden
141afa84b4
MDL-78225 output: add sesskey for post requests only in renderables.
2023-05-11 22:48:57 +01:00
Laurent David
5270236fc4
MDL-76903 mod_book: Fix activity completion
...
* Check only visibles pages to set completion status.
* Make sure we have consistent completion value in API and on the view page.
2023-05-11 12:09:21 +02:00
Paul Holden
3f05904a07
MDL-78140 analytics: improve context restrictions manager test.
...
This test apparently fails sporadically on Oracle, without obvious
causes. The failure however was hard to interpret, and the test
itself made a lot of assumptions about the system re. naming of
categories/courses. This could be prone to errors, so improve that.
2023-05-11 09:39:32 +01:00
Paul Holden
ad238868ed
MDL-77946 access: fix category sort order of capability contexts.
2023-05-11 08:33:37 +01:00
Jun Pataleta
1072a3c9e3
Merge branch 'MDL-76344-400-fix' of https://github.com/stevandoMoodle/moodle into MOODLE_400_STABLE
2023-05-11 14:35:46 +08:00
Stevani Andolo
13c4b9089d
MDL-76344 course: Fixed course image 'non image file' layout
2023-05-11 14:16:41 +08:00
Jake Dallimore
edda29c185
Merge branch 'MDL-75552-400' of https://github.com/sarjona/moodle into MOODLE_400_STABLE
2023-05-11 11:24:10 +08:00
Sara Arjona
4aecc7b5df
Merge branch 'MDL-78040-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-10 19:45:25 +02:00
Paul Holden
38941d0fda
MDL-78211 contentbank: fix context option when formatting categories.
2023-05-10 17:42:31 +01:00
Juan Leyva
339244d1b7
MDL-78196 user: Fix files used space check
2023-05-10 17:17:44 +02:00
Andrew Nicols
7371e3562f
Merge branch 'MDL-77592-400' of https://github.com/golenkovm/moodle into MOODLE_400_STABLE
2023-05-10 13:04:09 +08:00
Andrew Nicols
bdd433354d
Merge branch 'MDL-78034-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-10 13:00:45 +08:00
Ilya Tregubov
a2665c8778
Merge branch 'MDL-75623-MOODLE_400_STABLE' of https://github.com/sh-csg/moodle into MOODLE_400_STABLE
2023-05-10 11:47:10 +08:00
Paul Holden
1acaa4e4a0
MDL-78170 rating: consistently calculate average rating aggregation.
...
Ensure it's always cast by the database as a float, to avoid loss of
precision.
2023-05-09 15:57:44 +01:00
Paul Holden
a1ea84198c
MDL-78152 mod_book: set permissions required for page editing.
2023-05-09 12:11:34 +01:00
Andrew Nicols
a2c1c036a9
MDL-75552 badges: move apiBase consumption to backpack
...
The apiBase in .well-known/badgeconnect.json was ignored and it was
causing some failures when connecting or sending badges to an
external backpack.
For OBv2.1, it has been changed to always use the apiBase defined
in the badgeconnect.json backpack provider.
2023-05-09 08:51:36 +02:00
Petr Skoda
bcaa98bb44
MDL-76688 filter_text: prevent LaTeX3 syntax
2023-05-08 10:12:55 +02:00
AMOS bot
50f6d69ea3
Automatically generated installer lang files
2023-05-07 00:07:22 +00:00
Paul Holden
939412bcb7
MDL-78135 completion: include required criteria library in test.
2023-05-05 16:45:50 +01:00
Jake Dallimore
660ea3df56
MDL-76821 enrol_lti: prevent legacy launches via upgraded enrolment
...
If the enrolment instance (the 'published resource') has been upgraded
from LTI 1.1/2.0 to LTI 1.3 (i.e. a new instance was not created),
prevent legacy launches which may occur from old resource links. Only
LTI Advantage launches should be permitted through the method.
2023-05-05 17:12:03 +08:00
Jake Dallimore
ae736cca94
MDL-76821 enrol_lti: fix bug in repo causing return of legacy lti users
...
If the enrolment method is updated from an LTI 1.1/2.0 tool to an LTI
1.3 tool, it may have associated enrol_lti_users records not having
ltideploymentid values. These are legacy users and must not be returned
by the repository, which deals only with LTI 1.3 LTI users.
2023-05-05 17:12:00 +08:00
Jun Pataleta
36624fee4d
Merge branch 'MDL-76344-400' of https://github.com/stevandoMoodle/moodle into MOODLE_400_STABLE
2023-05-05 10:34:48 +08:00
Sara Arjona
9deb29c0d6
weekly release 4.0.8+
2023-05-04 12:43:00 +02:00
Stevani Andolo
691e7952c8
MDL-76344 course: Fixed course image 'non image file' layout
2023-05-04 10:28:29 +08:00
Paul Holden
685a2dfb73
MDL-78040 block_glossary_random: switch to block test generator.
...
Random failures after manually adding block instances (specifically
on slow/Oracle systems) can be entirely avoided by using the block
test generator for scenarios that are not specifically concerned with
manually adding blocks.
2023-05-03 17:17:52 +01:00
Jun Pataleta
d04c0b5dae
Merge branch 'MDL-77398-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-03 20:36:07 +08:00
Jake Dallimore
fd643cf459
Merge branch 'MDL-77384-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-03 16:54:16 +08:00
Jake Dallimore
39a94da184
Merge branch 'MDL-78023-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-03 16:16:16 +08:00
Sara Arjona
4b0a13b2ed
Merge branch 'MDL-77312-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-03 09:59:27 +02:00
Ilya Tregubov
63d423fc6d
Merge branch 'MDL-77320-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-03 15:37:26 +08:00
Ilya Tregubov
4b962ce9c3
Merge branch 'MDL-77987_400' of https://github.com/AnupamaSarjoshi/moodle into MOODLE_400_STABLE
2023-05-03 12:41:02 +08:00
Jun Pataleta
3895d92601
Merge branch 'MDL-77394-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-03 10:30:53 +08:00
Jun Pataleta
bc0a1b6166
Merge branch 'MDL-78038-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-03 10:25:24 +08:00
Ilya Tregubov
994d7dd845
Merge branch 'MDL-76835-400' of https://github.com/aya-saad1/moodle into MOODLE_400_STABLE
2023-05-03 09:30:25 +08:00
Sara Arjona
77cd241bdc
Merge branch 'MDL-77858-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-05-02 16:49:58 +02:00
Sara Arjona
2720d9a6db
Merge branch 'MDL-77791_400' of https://github.com/dvdcastro/moodle into MOODLE_400_STABLE
2023-05-02 12:04:05 +02:00
Jun Pataleta
e4134fafc2
Merge branch 'MDL-76857-400' of https://github.com/sarjona/moodle into MOODLE_400_STABLE
2023-05-02 15:44:43 +08:00
Ilya Tregubov
025202b865
Merge branch 'MDL-78025_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-05-02 11:43:49 +08:00
Ilya Tregubov
c36636264f
weekly release 4.0.8+
2023-04-27 19:28:42 +08:00
Sara Arjona
149319befe
MDL-76857 filter_displayh5p: Improve behat tests
...
Although the screenshots in the failures for some of the scenarios in
filter/displayh5p/tests/behat/h5p_filter.feature, like "Render a local
H5P file as teacher" were displaying the expected result, there were
some javascript errors (probably due to behat is quicker and the
iframes were not always ready).
I've added one extra step before accessing the iframe to give more
time to the H5P player to load and confirm the page is displayed
properly.
2023-04-27 11:21:47 +02:00
Paul Holden
b1f4566f5e
MDL-77320 tool_licensemanager: restrict exposure of user sesskey.
2023-04-27 09:32:43 +01:00
Jun Pataleta
6bab38c1b0
Merge branch 'MDL-77883-400' of https://github.com/danghieu1407/moodle into MOODLE_400_STABLE
2023-04-27 11:09:00 +08:00
Jun Pataleta
64d50b27e6
Merge branch 'MDL-77997_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-04-27 10:40:36 +08:00
Paul Holden
726d3324d3
MDL-78038 mod_bigbluebuttonbn: observe course format section config.
2023-04-26 16:10:54 +01:00
Tim Hunt
68cbd1a772
MDL-78025 questions: improve the comment on question_references.version
2023-04-26 15:52:23 +01:00
Tim Hunt
263960469b
MDL-78025 questions: fix PHPdoc on question_require_capability_on
2023-04-26 15:52:20 +01:00
Tim Hunt
480699449b
MDL-78025 quiz: fix the quiz_questions_in_use logic
2023-04-26 15:52:15 +01:00
Tim Hunt
62fdb2db50
MDL-78025 questions: questions_in_use should check question_references
...
This avoids the needs for plugins to do separate queries, which is
easier for them, and better performing.
2023-04-26 15:50:37 +01:00
Tim Hunt
e98ec3b520
MDL-78025 question generator: make the behaviour less surprising
...
* The object returned by update_question is alwasy a new clone
and the $question passed in will not be modified.
* The returned object has the fields like questionbankentryid and
the ones related to versionning, so it is more like the data
returned by question_bank::load_question_data.
2023-04-26 15:50:33 +01:00
Tim Hunt
ed605e65d9
MDL-78025 question: move hiding logic into question_delete_question
...
This logic belongs in the API, so it is applied consistently.
Also this avoids calling the expensive function questions_in_use
twice per question.
2023-04-26 15:46:45 +01:00
Paul Holden
13b4cf6a38
MDL-78034 mod_bigbluebuttonbn: format instance group names.
2023-04-26 15:31:46 +01:00
Aya Saad
7f10c075bc
MDL-76835 theme: Fix unordered lists indentation
2023-04-26 13:21:01 +02:00
David Castro
38a7817ba6
MDL-77791 data: Fix file attachment to search doc
2023-04-25 19:54:13 -05:00
Paul Holden
6a2c9cfbc7
MDL-78023 tool_policy: cast timemodified column on table download.
2023-04-25 14:51:14 +01:00
Sara Arjona
1ee2a41142
Merge branch 'MDL-77313-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-04-25 15:18:49 +02:00
Paul Holden
41a6048b0b
Merge branch 'MDL-73331_400_toolbrickfieldadvancedtab' of https://github.com/brickfield/moodle into MOODLE_400_STABLE
2023-04-25 11:54:18 +01:00
Paul Holden
d6362e1bd8
Merge branch 'MDL-77766-400-2' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-04-25 09:38:38 +01:00
Paul Holden
93dfd51516
MDL-77384 check: clarify statistics check name.
2023-04-25 09:04:47 +01:00
Jun Pataleta
bd8df1ac79
MDL-77766 qtype_multichoice: Respect showstandardinstruction
...
* When showstandardinstruction is set to no, replace the standard
instruction with the generic "Answer" text for the answer options
fieldset's legend.
2023-04-24 20:12:44 +08:00
Tim Hunt
c5cd5a0a11
MDL-77997 questions: add back Export as XML to the preview screen
...
The used the exist in Moodle up to 3.11, but then was removed with
insufficient thought in 4.0 (because we had grander long-term plans
which still have not happened). Until those plans happen, this
commit adds the simple link back on the preview screen.
2023-04-24 11:23:27 +01:00
Anupama Sarjoshi
1e8842726c
MDL-77987 Backup: add progress tracking to some slow steps
2023-04-24 11:12:30 +01:00
Paul Holden
71cc91a810
MDL-77312 files: exclude drafts when determining license usage.
2023-04-24 11:07:43 +01:00
Paul Holden
8ce75290f2
MDL-77313 restore: re-add field to indicate course/category search.
...
When the two restore forms for searching courses and categories were
converted to core templates in eb9935c9 they lost the named submit
button, which broke searching.
2023-04-24 11:04:32 +01:00
Paul Holden
cb6fd51254
MDL-77858 javascript: correct core/notification exception imports.
2023-04-24 10:44:19 +01:00
Paul Holden
d9dbf8f710
MDL-77394 mod_forum: de-couple discussion pinned/starred options.
2023-04-24 10:38:07 +01:00
Paul Holden
6e914f9a4e
MDL-77398 mod_assign: disable form submit protection for batch options.
2023-04-24 10:35:21 +01:00
danghieu1407
d3e2835171
MDL-77883 forms: fix display of client-side validation for textareas
2023-04-24 14:02:16 +07:00
Jun Pataleta
2caed2991e
Moodle release 4.0.8
2023-04-22 16:22:46 +08:00
Eloy Lafuente (stronk7)
3552ac0622
weekly release 4.0.7+
2023-04-21 19:19:20 +02:00
Eloy Lafuente (stronk7)
b665e63be8
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-04-21 19:19:15 +02:00
Jun Pataleta
8e2239f1a7
Merge branch 'MDL-77927-400' of https://github.com/stevandoMoodle/moodle into MOODLE_400_STABLE
2023-04-21 16:52:09 +08:00
Jun Pataleta
4e9a6ef5be
Merge branch 'MDL-77229-patch-400' of https://github.com/ilyatregubov/moodle into MOODLE_400_STABLE
2023-04-21 16:45:01 +08:00
Jun Pataleta
c4f58034ab
MDL-77927 core: mod_assignment subplugins environment check
2023-04-21 15:55:13 +08:00
Ilya Tregubov
313d3d76eb
MDL-77229 mod_lesson: Black list detailed statistics in classic Behat.
...
The nav element to go to detailed stats page is missing in classic
2023-04-21 15:08:45 +08:00
Ilya Tregubov
881cc1da19
Merge branch 'MDL-77229-400' of https://github.com/ilyatregubov/moodle into MOODLE_400_STABLE
2023-04-21 12:10:28 +08:00
Ilya Tregubov
553ea69c3f
MDL-77229 lesson: Add Behat test
2023-04-21 12:05:52 +08:00
AMOS bot
72c5bcc745
Automatically generated installer lang files
2023-04-21 00:07:38 +00:00
Juan Leyva
d2a623971c
MDL-77229 lesson: Fix error for empty responses (numerical pagetype)
2023-04-20 12:46:38 +02:00
Jun Pataleta
b0d5d0ebc5
Merge branch 'MDL-73012-400' of https://github.com/ferranrecio/moodle into MOODLE_400_STABLE
2023-04-20 16:44:46 +08:00
Jun Pataleta
636890e5f6
Merge branch 'MDL-77922-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-04-20 16:10:21 +08:00
Ferran Recio
7fe5196a52
MDL-73012 core_courseformat: add pending to move section modal
2023-04-20 09:53:04 +02:00
Ferran Recio
cc46c0158a
MDL-77922 core_courseformat: add pending to move activity modal
2023-04-20 14:49:27 +08:00
Ilya Tregubov
1a2ca071eb
Merge branch 'MDL-77577-400' of https://github.com/andelacruz/moodle into MOODLE_400_STABLE
2023-04-20 12:33:50 +08:00
Paul Holden
b17f5b6337
MDL-77187 mod_wiki: validate external method sort parameters.
2023-04-19 12:55:22 +00:00
Paul Holden
7daac50b35
Merge branch 'MDL-77960-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-04-19 13:41:34 +01:00
Max Larkin
addb8f1c03
MDL-73331 tool_brickfield: Update advanced tab display
2023-04-19 13:24:06 +01:00
Paul Holden
1ee4d7da64
Merge branch 'MDL-77944-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-04-19 13:06:42 +01:00
Paul Holden
9540c536d8
Merge branch 'MDL-77898-400' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-04-19 09:03:24 +01:00
Simey Lameze
a96de1c74d
MDL-77960 behat: make verification steps more specific
2023-04-19 13:33:36 +08:00
Ilya Tregubov
d2790cca27
Merge branch 'MDL-77935-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-04-19 13:33:00 +08:00
Andrew Nicols
69e8820de1
weekly release 4.0.7+
2023-04-18 22:28:15 +08:00
Andrew Nicols
8d9daa91ba
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-04-18 22:28:12 +08:00
Jun Pataleta
4027721841
MDL-77898 calendar: Add iconclass for upcoming_mini template
...
The icon's iconclass context data adds additional CSS class(es) to
calendar event icons to better control how the event icon is displayed.
e.g. without filtering for activity events that don't hae monologo
versions of their icons.
2023-04-18 15:58:37 +08:00
Ilya Tregubov
475256b621
Merge branch 'MDL-77916-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-04-18 14:29:07 +08:00
Andrew Nicols
ddc8ddb047
Merge branch 'MDL-77829-400' of https://github.com/stevandoMoodle/moodle into MOODLE_400_STABLE
2023-04-18 12:32:46 +08:00
Andrew Nicols
7f349d6552
Merge branch 'MDL-77735-400' of https://github.com/sarjona/moodle into MOODLE_400_STABLE
2023-04-18 12:10:40 +08:00
Andrew Nicols
2bbb3d0eb4
MDL-77944 behat: Rename chrome options for w3c support
...
From Selenium 4.8.0, support for non-w3c browser control has ended.
We only use W3C browser control these days, and this was missed as part
of the move to W3C. All browser options must be vendor-prefixed.
2023-04-18 09:04:17 +08:00
Ilya Tregubov
68d1a0c1c0
Merge branch 'MDL-77827-400' of https://github.com/HuongNV13/moodle into MOODLE_400_STABLE
2023-04-18 08:59:41 +08:00
AMOS bot
a84fb29fcb
Automatically generated installer lang files
2023-04-18 00:07:35 +00:00
Paul Holden
5158c1533c
Merge branch 'MDL-77878-400-enfix' of https://github.com/vmdef/moodle into MOODLE_400_STABLE
2023-04-17 19:12:38 +01:00
Shamim Rezaie
c8defec8dd
Merge branch 'MDL-76998-400' of https://github.com/aanabit/moodle into MOODLE_400_STABLE
2023-04-17 21:28:24 +10:00
Víctor Déniz
532c3eb7b0
MDL-77878 lang: Use fixed strings in tests
2023-04-17 09:29:47 +01:00
Paul Holden
f1949fe80c
MDL-77935 contentbank: avoid phpunit crashes during isolated tests.
...
Simplify the test for allowed contexts by removing problematic use of
data provider annotation.
See: https://github.com/sebastianbergmann/phpunit/issues/2739
2023-04-17 09:28:46 +01:00
Andrew Nicols
2ac6d6a7d3
Merge branch 'MDL-76995-400' of https://github.com/aanabit/moodle into MOODLE_400_STABLE
2023-04-17 11:15:25 +08:00
Ilya Tregubov
75226d8c9e
MDL-76994 core_course: Fix version for weeks and topics course formats
2023-04-17 11:02:36 +08:00
Ilya Tregubov
6496dd5277
Merge branch 'MDL-76994-400' of https://github.com/aanabit/moodle into MOODLE_400_STABLE
2023-04-17 09:47:30 +08:00
Víctor Déniz
3ef7b399a8
MDL-77878 lang: Import fixed English strings (en_fix)
2023-04-16 22:04:03 +01:00
Sara Arjona
95b427d8fe
Merge branch 'MDL-77913-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-04-14 14:02:23 +02:00
Sara Arjona
18886c271f
MDL-77735 core: Check $CFG->lang isset
...
In some cases, $CFG->lang might not be set, and this is causing a
Notice to be displayed when, for instance, database connection fails.
This patch should fix this case.
2023-04-14 13:46:45 +02:00
Sara Arjona
9cae11732f
weekly release 4.0.7+
2023-04-14 10:50:13 +02:00
Sara Arjona
9600731821
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-04-14 10:50:10 +02:00
Huong Nguyen
44a8713267
MDL-77827 events: Changed JSON comparison to be less strict
2023-04-14 12:29:38 +07:00
Paul Holden
75b6190bde
MDL-77916 h5p: register autoloader in helper testcase.
2023-04-13 23:17:08 +01:00
Paul Holden
53f5432d89
MDL-77913 qbank_previewquestion: deterministic ordering of versions.
...
Ensure the ordering of loaded question versions is consistent, avoids
random Oracle failures.
2023-04-13 21:45:30 +01:00
Amaia Anabitarte
b456e7aa18
MDL-76995 core_courseindex: Apply indentation in the course index
2023-04-13 16:58:21 +02:00
Amaia Anabitarte
75bf395e47
MDL-76998 admin: Option to reset course indentation
2023-04-13 16:57:03 +02:00
Amaia Anabitarte
029457a0a6
MDL-76994 tool_mobile: Return course format indentation setting
2023-04-13 16:56:09 +02:00
Amaia Anabitarte
d23ff0a5b3
MDL-76994 core_course: New course format setting to enable indentation
2023-04-13 16:53:22 +02:00
Sara Arjona
a2e0dec53b
Merge branch 'MDL-76859-400' of https://github.com/sarjona/moodle into MOODLE_400_STABLE
2023-04-13 16:24:32 +02:00
Sara Arjona
2867735f7e
Merge branch 'MDL77833-course-content-chng-notificatn-multilang-m4' of https://github.com/Amrita1991/moodle into MOODLE_400_STABLE
2023-04-13 16:20:11 +02:00
Sara Arjona
dbb0410d58
Merge branch 'MDL-77860-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-04-13 13:45:06 +02:00
Sara Arjona
4721df9f4c
Merge branch 'MDL-77788-400' of https://github.com/rmady/moodle into MOODLE_400_STABLE
2023-04-13 13:18:27 +02:00
Sara Arjona
243c35b3e8
Merge branch 'MDL-77618-admin-password-autocomplete-MOODLE_400_STABLE' of https://github.com/brendanheywood/moodle into MOODLE_400_STABLE
2023-04-13 12:19:21 +02:00
Amrita1991
4d5ea5e9a9
MDL-77833 course: content change notification multilang processing
...
changing context parameter
2023-04-13 11:27:00 +02:00
Sara Arjona
b47fa670f0
Merge branch 'MDL-77256-400' of https://github.com/rbravod/moodle into MOODLE_400_STABLE
2023-04-13 11:20:38 +02:00
Sara Arjona
e196979e09
Merge branch 'MDL-77856-400' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-04-13 09:43:10 +02:00
Sara Arjona
50a79addb1
Merge branch 'MDL-77468-400' of https://github.com/rmady/moodle into MOODLE_400_STABLE
2023-04-13 09:20:04 +02:00
Juan Leyva
5f7b44fe70
MDL-77468 user: Fix invalid check for group belonging
2023-04-12 20:24:43 -03:00
Juan Leyva
a18deeb18b
MDL-77468 user: Make user profile visibility consistent web and ws
2023-04-12 20:21:32 -03:00
Sara Arjona
893bdf2603
Merge branch 'MDL-73610_400' of https://github.com/stronk7/moodle into MOODLE_400_STABLE
2023-04-12 18:19:47 +02:00
Petr Skoda
c08401f159
MDL-76859 h5p: Fix behat failures
...
- Only resize if the H5P EmbedCommunicator is defined (otherwise, it was causing a
JS error)
- An unnecessary image has been removed from the greeting-card.h5p fixture package.
That way, the text will always be displayed (even if the iframe is still not
resized). Instead of replacing the original greeting-card-887.h5p file, I've
renamed it to greeting-card.h5p, to remove these ugly and unnecessary numbers
at the end of the file name).
2023-04-12 15:47:19 +02:00
Amaia Anabitarte
26ffef4f6d
MDL-76993 core_course: Recover move right/left functionality
...
This is a backport of MDL-76990
2023-04-12 09:56:26 +02:00
Amaia Anabitarte
a066890881
MDL-76993 core_course: Functions need to backport MDL-76990
...
MDL-76990 will be backported to 4.1 and 4.0. This commit adds the
methods needed to backport it which were not in 4.0.
2023-04-12 09:55:00 +02:00
Sara Arjona
65532b40c9
Merge branch 'MDL-77837-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-04-11 12:12:57 +02:00
Sara Arjona
b61400d504
Merge branch 'MDL-77552-400' of https://github.com/ferranrecio/moodle into MOODLE_400_STABLE
2023-04-11 11:13:46 +02:00
Sara Arjona
9079a52348
Merge branch 'MDL-77148_400' of https://github.com/AnupamaSarjoshi/moodle into MOODLE_400_STABLE
2023-04-11 10:17:14 +02:00
Sara Arjona
64038bd1d2
Merge branch 'MDL-77612-400' of https://github.com/laurentdavid/moodle into MOODLE_400_STABLE
2023-04-11 10:04:48 +02:00
Laurent David
dad1f86b28
MDL-77612 mod_label: Label name fix
...
* The @@PLUGINFILE@@ placeholder or URLs should not be displayed in the
course index for labels
2023-04-11 05:25:40 +02:00
Stevani Andolo
8ec461823a
MDL-77829 core: Added environment check for mod_assignment
...
Decided to add an environment check before uninstalling the
mod_assignment plugin to prevent data lost.
2023-04-10 13:55:20 +08:00
AMOS bot
2397eee6cb
Automatically generated installer lang files
2023-04-07 00:07:30 +00:00
Andrew Nicols
875c1d9638
MDL-77837 core: Improve usage docs for cron_setup_user
2023-04-06 23:21:29 +08:00
Andrew Nicols
46ea3269fc
MDL-77837 phpunit: Ensure that the cron user setter is used
...
When running an adhoc task in a unit test we should use the cron variant
of the set user method to mimic the behaviour of a real cron run.
2023-04-06 23:21:29 +08:00
Andrew Nicols
be8fac6291
MDL-77837 cron: Ensure user is set when running tasks
...
We should be proactive in ensuring that the environment is clean when
running a task. We already ensure that we have a clean renderer and
other parts of the output chain, but we were not setting a clean user.
This change adds a call to setup the cron user before each task is
actually executed.
2023-04-06 23:21:29 +08:00
Eloy Lafuente (stronk7)
7d9d0f35a0
MDL-73610 nodejs: Small updates to required packages
...
The main goal of this issue is to avoid scanners (Dependabot
and friends), reporting about security issues with the current
xmldom 0.6.0 package.
Note that this doesn't affect prod at all, because it's a dev
dependency, hardly exploitable. So it's not a security fix, just
a security_benefit, if something.
So here, we are updating from xmldom 0.6.0 to @xmldom/xmldom 0.8.7
(note that the package was renamed in 0.7.0, so it's the very same)
Also, when proceeding with the changes, it was detected that we
are incorrectly declaring @babel/eslint-parser as a normal dependency
instead of a development one, so we are also fixing that little detail.
The commands executed to get the changes above applied have been:
- nvm use
- npm install @xmldom/xmldom@^0.8.7 --save-dev
- npm uninstall xmldom
- npm install @babel/eslint-parser@^7.17.0 --save-dev
(we haven't run a complete re-install because we only want to modify
the minimum possible at this stage).
2023-04-06 14:59:52 +02:00
Anupama Sarjoshi
6bee956ede
MDL-77148 core: Fix to export params for templates in correct format
...
When questions are filtered by tags in the question bank, the qtagids
params are passed in the array format. Though moodle_url handles this,
single_button::export_for_template cannot. Hence changes done in
weblib.php to provide params for export_for_template in the
suitable format.
Thanks Huong. I have added the Behat test you provided in the patch.
2023-04-06 13:57:40 +01:00
Sara Arjona
7d8f31dbe7
weekly release 4.0.7+
2023-04-06 14:02:24 +02:00
Sara Arjona
e4e7902d7c
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-04-06 14:02:19 +02:00
AMOS bot
946ff0171c
Automatically generated installer lang files
2023-04-06 00:07:34 +00:00
Paul Holden
9cf38cfd39
MDL-77860 tool_moodlenet: use localised language strings for import.
2023-04-05 23:05:34 +01:00
Jun Pataleta
b3eb942301
MDL-77856 qtype_multianswer: Use Bootstrap Popover for subq feedback
...
The YUI Overlay widget encloses the subquestion feedback in a div
which causes a div element to be enclosed in the subquestion span. This
leads to an accessibility issue in terms of HTML parsing as inline
elements (span) should not contain block elements (div)
The YUI Overlay widget is also not accessible as it does not really hide
the overlay contents via aria-hidden when the overlay is not being
shown. It's better if we stop using this and use Bootstrap's
popover component which is more accessible by default.
This patch also removes module.js for the qtype_multianswer plugin as
it only contains codes related to rendering the feedback contents in the
YUI overlay widget which is no longer necessary.
2023-04-06 05:35:19 +08:00
Sara Arjona
fce3ba9b11
Merge branch 'MDL-73642_MOODLE_400_STABLE' of https://github.com/tasosb/moodle into MOODLE_400_STABLE
2023-04-05 17:17:41 +02:00
Sara Arjona
42b6a39808
Merge branch 'MDL-75301_400_STABLE' of https://github.com/marxjohnson/moodle into MOODLE_400_STABLE
2023-04-05 12:49:34 +02:00
Shamim Rezaie
df17b180f2
Merge branch 'MDL-77555-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-04-05 20:15:09 +10:00
Mark Johnson
6ff023d292
MDL-75301 quiz: Use "always latest" option for question previews
...
This will set the "alwayslatest" option when previewing a question from
the quiz according to the version setting used in the quiz slot.
2023-04-05 10:23:26 +01:00
Mark Johnson
8043b7838a
MDL-75301 question: Add "always latest" option to previews
2023-04-05 10:23:26 +01:00
Paul Holden
60ecd6cef5
Merge branch 'MDL-69551_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-04-05 08:56:46 +01:00
AMOS bot
558585b1ed
Automatically generated installer lang files
2023-04-05 00:07:39 +00:00
Juan Leyva
5292926ebb
MDL-77788 mod_assign: Apply format_string to group names in WS
2023-04-04 18:12:13 -03:00
Tim Hunt
e19cbda970
MDL-69551 quiz: start quiz password field should be a passwordunmask
...
This help accessibility and usability
2023-04-04 12:21:26 +01:00
Paul Holden
b559b84774
Merge branch 'MDL-77712-400' of https://github.com/laurentdavid/moodle into MOODLE_400_STABLE
2023-04-04 12:06:43 +01:00
Andrew Nicols
4406bcd17a
Merge branch 'MDL-77584-400' of https://github.com/ewallah/moodle into MOODLE_400_STABLE
2023-04-04 12:07:33 +08:00
Simey Lameze
56bfaebb70
MDL-77733 behat: enable Axe accessibility tests by default
2023-04-04 09:20:19 +08:00
AMOS bot
f8e7a1e24b
Automatically generated installer lang files
2023-04-04 00:07:40 +00:00
Paul Holden
0bfa7ee0a7
Merge branch 'MDL-75906-400' of https://github.com/mickhawkins/moodle into MOODLE_400_STABLE
2023-04-03 14:54:06 +01:00
Mark Johnson
6f61f48e20
MDL-75301 question: Add behat generator for updating questions
...
This adds "core_question > updated question" as an entity for `the
following "X" exist` and calls the existing update_question() generator
which will create a new question version with the supplied data.
2023-04-03 12:35:08 +01:00
Paul Holden
dec59bd614
Merge branch 'MDL-77227-400' of https://github.com/aanabit/moodle into MOODLE_400_STABLE
2023-04-03 10:47:38 +01:00
Michael Hawkins
f37baf7b59
MDL-75906 core: Updated security.txt expiry
2023-04-03 17:27:48 +08:00
Laurent David
03c1095379
MDL-77712 core_course: Fix exception with inplace editor
...
* On fresh install, an exception is raised when we try to modify
the name of a newly inserted activity in the front page
2023-04-03 10:44:49 +02:00
Ferran Recio
55139ae744
MDL-77552 core_courseformat: add plugin and module to cm state
...
Backport of MDL-77386
2023-04-03 09:34:21 +02:00
AMOS bot
6cf8bd9832
Automatically generated installer lang files
2023-04-02 00:07:33 +00:00
Stefan Hanauska
95d8d5316c
MDL-75623 backup: Encode pluginfile URLs
2023-04-01 09:09:34 +02:00
AMOS bot
ed4e4660db
Automatically generated installer lang files
2023-04-01 00:07:42 +00:00
Paul Holden
8400206468
weekly release 4.0.7+
2023-03-31 18:11:57 +01:00
Paul Holden
32a944bac8
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-03-31 18:11:55 +01:00
Jake Dallimore
d7185519c3
Merge branch 'MDL-59175-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-03-31 11:57:43 +08:00
Jake Dallimore
9daaca2400
Merge branch 'MDL-77794-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-03-31 11:48:56 +08:00
Mikhail Golenkov
427dff5ce1
MDL-77592 filter_tex: Use request dir instead of temp shared storage
2023-03-31 14:36:07 +11:00
Andrew Nicols
dc2b74c749
Merge branch 'MDL-77783-400' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-03-31 11:31:16 +08:00
Ilya Tregubov
db31cd37b2
Merge branch 'MDL-70976-400' of https://github.com/laurentdavid/moodle into MOODLE_400_STABLE
2023-03-31 09:42:34 +08:00
AMOS bot
d8d79addc4
Automatically generated installer lang files
2023-03-31 00:07:37 +00:00
Laurent David
178cc61b18
MDL-77456 core_courseformat: Fix highlight in course index
...
* When navigating to a restricted activity as a student from the course index
the item is not highlighted when refreshing the page.
2023-03-30 18:57:56 +02:00
Sara Arjona
5f87d91315
Merge branch 'MDL-77761-400' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-03-30 17:53:25 +02:00
Sara Arjona
3cd54831ea
Merge branch 'MDL-77764-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-03-30 16:31:26 +02:00
Paul Holden
166c6cc61e
Merge branch 'MDL-76481_400_Brickfield_TCPDF_error' of https://github.com/brickfield/moodle into MOODLE_400_STABLE
2023-03-30 12:50:11 +01:00
Sara Arjona
f616930138
Merge branch 'MDL-77762-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-03-30 13:45:23 +02:00
Jun Pataleta
8420c58e69
Merge branch 'MDL-77333_400' of https://github.com/stronk7/moodle into MOODLE_400_STABLE
2023-03-30 19:03:32 +08:00
Paul Holden
4a603fe534
MDL-77794 contentbank: fix plugin type language strings.
...
AMOS BEGIN
CPY [type_contentbank,core_plugin],[type_contenttype,core_plugin]
CPY [type_contentbank_plural,core_plugin],[type_contenttype_plural,core_plugin]
AMOS END
2023-03-30 09:58:40 +01:00
Max Larkin
7956a8d814
MDL-76481 tool_brickfield: Fix PHP 8 report download
2023-03-30 09:15:28 +01:00
Paul Holden
fba11f5c29
Merge branch 'MDL-75017_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-03-30 08:47:56 +01:00
Ilya Tregubov
b83db3be01
Merge branch 'MDL-73771_400' of https://github.com/lostrogit/moodle into MOODLE_400_STABLE
2023-03-30 14:23:08 +08:00
AMOS bot
b74ee3931c
Automatically generated installer lang files
2023-03-30 00:07:41 +00:00
Amaia Anabitarte
d9f694bfa8
MDL-77227 roles: Remove extra information for override page
2023-03-29 18:19:26 +02:00
Carlos Castillo
bdc55fbffc
MDL-73771 theme: Fix scrollbar position
2023-03-29 09:07:51 -05:00
Shamim Rezaie
4b39aecb10
Merge branch 'MDL-74452_400_STABLE' of https://github.com/marxjohnson/moodle into MOODLE_400_STABLE
2023-03-29 15:27:36 +11:00
Jun Pataleta
2834086d07
Merge branch 'MDL-77382-400' of https://github.com/snake/moodle into MOODLE_400_STABLE
2023-03-29 09:48:11 +08:00
Jun Pataleta
b6604a3a19
Merge branch 'MDL-76941-400-2' of https://github.com/HuongNV13/moodle into MOODLE_400_STABLE
2023-03-29 09:31:43 +08:00
Jun Pataleta
13fec4131e
MDL-77783 core: Validate sublugins.json
...
* Validate the decoded subplugins.json before processing it.
* Log errors if subplugins.json is invalid or if plugintypes is not
defined.
2023-03-29 09:29:51 +08:00
Jun Pataleta
9ebea4011e
MDL-77761 core_form: Add label for editor format selector
2023-03-29 08:09:46 +08:00
Eloy Lafuente (stronk7)
87fbf39aae
MDL-77333 mod_resource: fixes generator uploading files + tests
...
MDL-76499 revealed a few problems with resource generators:
1. We were not covering with unit tests the upload of files from disk
(and here it's where the problem was).
2. There was a little of confusion between disk paths (only needed
to upload files) and file_area paths (the generator only creates
or uploads files to the root directory of the file area.
3. It was possible to request the upload of a file to the generator
without that file effectively existing.
This commit fixes those points and covers 99% of the generator code.
2023-03-28 19:06:26 +02:00
Paul Holden
6273e6fdf3
weekly release 4.0.7+
2023-03-28 15:55:22 +01:00
Paul Holden
e8be539742
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-03-28 15:55:20 +01:00
Paul Holden
5b94923b7a
Merge branch 'MDL-77105-400-4' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-03-28 12:39:05 +01:00
Jun Pataleta
e736f80017
MDL-77105 core: Cast custom data to an array when evaluating filtericon
...
Since other modules may treat custom data as an object, we need to make
cast it to an array before evaluating for the `filtericon` custom data.
2023-03-28 18:54:04 +08:00
Huong Nguyen
c7cc232e16
MDL-76941 tool_usertours: Fix accessibility issue when resizing
2023-03-28 12:18:24 +07:00
Jun Pataleta
07a3a15eb7
Merge branch 'MDL-77630-400' of https://github.com/meirzamoodle/moodle into MOODLE_400_STABLE
2023-03-28 12:06:24 +08:00
Jake Dallimore
07f644d2ec
Merge branch 'MDL-77105-400-4' of https://github.com/junpataleta/moodle into MOODLE_400_STABLE
2023-03-28 11:42:54 +08:00
Meirza
aac223ade5
MDL-77630 mod_forum: correct typo in variable names
2023-03-28 09:42:07 +07:00
Jun Pataleta
c1a94a7d52
Merge branch 'MDL-77670-400' of https://github.com/juancs/moodle into MOODLE_400_STABLE
2023-03-28 07:05:30 +08:00
Paul Holden
beaff418ba
MDL-77762 contentbank: always provide exit button when appropriate.
...
If the current user can access the content bank in the context of the
current item, then provide link back to it.
2023-03-27 18:08:50 +01:00
Paul Holden
ff1b86ab60
MDL-77764 contentbank: add field label to context selection element.
2023-03-27 16:55:00 +01:00
Sara Arjona
191ef569b5
Merge branch 'MDL-76376_m40' of https://github.com/jrchamp/moodle into MOODLE_400_STABLE
2023-03-27 16:56:36 +02:00
Sara Arjona
307be1189c
Merge branch 'MDL-77659_400' of https://github.com/AnupamaSarjoshi/moodle into MOODLE_400_STABLE
2023-03-27 16:50:37 +02:00
Sara Arjona
3cfe37dd29
Merge branch 'MDL-73226-400' of https://github.com/jleyva/moodle into MOODLE_400_STABLE
2023-03-27 16:08:32 +02:00
Juan Leyva
bb4329278b
MDL-73226 files: Add quota checks to core_user_add_user_private_files
2023-03-27 13:27:59 +02:00
Sara Arjona
f6d297a920
Merge branch 'MDL-76303-400' of https://github.com/ssj365/moodle into MOODLE_400_STABLE
2023-03-27 12:41:50 +02:00
Paul Holden
36edc365ea
Merge branch 'MDL-77729_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-03-27 11:09:27 +01:00
Sara Arjona
ed55a94fe8
Merge branch 'MDL-77561-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-03-27 11:43:32 +02:00
Paul Holden
551edbb9a6
MDL-77555 reportbuilder: improve SQL generation within filters.
...
Use native ANSI SQL syntax for numeric comparisons where possible,
define filter API for the case where filters must re-use the given
field SQL while ensuring uniqueness of any field parameters.
2023-03-27 10:29:37 +01:00
Paul Holden
478861b4d1
MDL-77555 reportbuilder: method to ensure unique parameters in SQL.
2023-03-27 10:29:37 +01:00
Jun Pataleta
22768e349a
MDL-77105 core: Add upgrade.txt notes
2023-03-27 14:03:48 +08:00
Jun Pataleta
6ad9bb2482
MDL-77105 mod_url: Declare filtericon custom data
...
* Set a custom data `filtericon` when the icon being rendered for the
URL resource is not equal to the default plugin icon.
2023-03-27 14:03:47 +08:00
Jun Pataleta
fd953966d8
MDL-77105 mod_lti: Add 'nofilter' class for custom tool icons
...
Add a '.nofilter' class when rendering custom tool icons in order
to render them as is and without CSS filter on the activity chooser.
2023-03-27 14:03:34 +08:00
Jun Pataleta
82db828016
MDL-77105 core_course: Add 'nofilter' class for non-monologo icons
...
When rendering content items, check whether the plugin has monologo
icons. If so, add a 'nofilter' class so the plugin icon can be
rendered as is and without the CSS filter.
2023-03-27 14:03:21 +08:00
Jun Pataleta
6a409c4cd4
MDL-77105 block_timeline: Add 'nofilter' class when necessary
...
Add the `.nofilter` class for activity icons when the icon URL's
`filtericon` parameter is not set, so they get rendered as they are on
the timeline block.
2023-03-27 14:03:07 +08:00
Jun Pataleta
894a6ab5ad
MDL-77105 block_recentlyaccesseditems: Add 'nofilter' class
...
Add the `.nofilter` class for activity icons when the icon URL's
`filtericon` parameter is not set, so they get rendered as they are on
the recently accessed items block.
2023-03-27 14:02:51 +08:00
Jun Pataleta
5b1daccb92
MDL-77105 theme_boost: Add 'nofilter' class when necessary
...
Add the `.nofilter` class for activity icons when the icon URL's
`filtericon` parameter is not set, so they get rendered as they are on
the context header on the activity page.
2023-03-27 13:48:47 +08:00
Jun Pataleta
f005111165
MDL-77105 course_format: Add 'nofilter' class when necessary
...
Add the `.nofilter` class for activity icons when the icon URL's
`filtericon` parameter is not set, so they get rendered as they are on
the course homepage.
2023-03-27 13:48:46 +08:00
Jun Pataleta
1e30a80b7f
MDL-77105 core: Conditionally apply icon filter
...
* Apply the filter CSS property only to activity icons
that don't have the ".nofilter" class. This will allow
activities with non-SVG icons to be rendered as they are.
2023-03-27 13:48:44 +08:00
Jun Pataleta
0778d512fe
MDL-77105 core: Add a filtericon parameter to course mod icon URLs
...
* If a plugin defines a `filtericon` custom data or uses its monologo
version of the icon, a `filtericon` parameter is being added to the
icon's URL. This information can help plugins determine whether to
render the activity icon as is or with CSS filtering.
2023-03-27 13:45:35 +08:00
Jun Pataleta
8812990c85
MDL-77105 core: Method to determine whether a plugin has monolog icons
2023-03-27 13:45:32 +08:00
Brendan Heywood
2d651dc665
MDL-77749 admin: Fix code error with unset config duration
2023-03-26 16:14:11 +11:00
AMOS bot
1018c8a4c5
Automatically generated installer lang files
2023-03-26 00:07:38 +00:00
Tim Hunt
60220de680
MDL-77729 qformat_missingword: fix form of help link
2023-03-25 15:40:27 +00:00
Tim Hunt
b7d7b84d30
MDL-75017 questions: give a clear error if the context type is invalid
2023-03-24 13:02:30 +00:00
Tim Hunt
8169d1da07
MDL-75017 questions: fix weird setup in qformat_xml_import_export_test
2023-03-24 13:02:28 +00:00
Sara Arjona
8af994f1f0
weekly release 4.0.7+
2023-03-24 13:59:36 +01:00
Jun Pataleta
8ca6ffa077
Merge branch 'MDL-77669-400' of https://github.com/andrewnicols/moodle into MOODLE_400_STABLE
2023-03-24 11:51:25 +08:00
Jun Pataleta
3904547719
Merge branch 'MDL-77626_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-03-24 10:40:30 +08:00
Simey Lameze
74a28bde79
MDL-77561 behat: add step to accept dpa and enable bigbluebutton
...
The step i_enable_plugin cannot be used as bigbluebuttonbn_default_dpa_accepted
setting needs to be enable in order for the BigBlueButton plugin to be enabled.
2023-03-24 08:23:27 +08:00
Sara Arjona
5fb543fa45
Merge branch 'MDL-77666-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-03-23 17:53:53 +01:00
Shamiso.Jaravaza
f19e245f29
MDL-76303 mod_bigbluebuttonbn: Fix userlimit
2023-03-23 08:22:29 -06:00
Paul Holden
922713d626
Merge branch 'MDL-77392-400' of https://github.com/srobotta/moodle into MOODLE_400_STABLE
2023-03-23 12:25:24 +00:00
Stephan Robotta
ac7720b956
MDL-77392 calendar: calendar items are hidden because of settings
2023-03-23 12:52:32 +01:00
Paul Holden
712cdd0fc6
Merge branch 'MDL-77691-400' of https://github.com/roland04/moodle into MOODLE_400_STABLE
2023-03-23 11:43:42 +00:00
Sara Arjona
f575d8fc82
Merge branch 'MDL-77380-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-03-22 14:06:14 +01:00
Sara Arjona
03a41fa881
Merge branch 'MDL-77692-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-03-22 13:50:19 +01:00
Ilya Tregubov
11a1ac8913
weekly release 4.0.7+
2023-03-22 09:37:13 +08:00
Ilya Tregubov
c35fd3566c
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-03-22 09:37:11 +08:00
Mark Johnson
6597f8f7f5
MDL-74452 quiz: Display an error if all versions are in draft status
2023-03-21 15:24:52 +00:00
Mikel Martín
e04daa31e4
MDL-77691 behat: Add step to navigate to profile page directly
2023-03-21 08:10:16 +01:00
Simey Lameze
bde844c57c
MDL-77380 block_myoverview: improve show toggle functionality test
2023-03-21 14:47:33 +08:00
Angelia Dela Cruz
7c007b8f32
MDL-77577 Behat: Replaced the use of "Install selected language pack(s)
...
Evaluated usage of "Install selected language pack(s)" in Behat and
replaced the steps to use generator to install language packs as part
of test setup.
2023-03-21 12:13:20 +08:00
Jun Pataleta
c68493a349
Merge branch 'MDL-75746_400_STABLE' of https://github.com/marxjohnson/moodle into MOODLE_400_STABLE
2023-03-21 12:00:55 +08:00
Meirza
529187a82a
MDL-77669 dml: Added extrainfo in the DB options config.
...
extrainfo is an extra information for the DB driver, e.g. SQL Server,
has additional configuration according to its environment,
which the administrator can specify to alter and override any connection options.
Co-authored-by: LukeCarrier <luke@carrier.im >
This is a backport of MDL-64153.
2023-03-21 08:48:39 +08:00
Ilya Tregubov
c38582b409
Merge branch 'mdl-72533-event-table-performance-MOODLE_400_STABLE' of https://github.com/petersistrom/moodle into MOODLE_400_STABLE
2023-03-21 08:24:54 +08:00
Paul Holden
b0872b6aa5
Merge branch 'MDL-72124_400_STABLE' of https://github.com/marxjohnson/moodle into MOODLE_400_STABLE
2023-03-20 17:04:56 +00:00
Paul Holden
8f296f6528
MDL-77692 reportbuilder: format custom field condition/filter names.
2023-03-20 16:32:16 +00:00
Sara Arjona
1b7f761528
Merge branch 'MDL-77574-400' of https://github.com/lameze/moodle into MOODLE_400_STABLE
2023-03-20 17:06:11 +01:00
Anupama Sarjoshi
2d9536f980
MDL-77659 core_reportbuilder: fix user profile fields phpunit tests
2023-03-20 13:46:36 +00:00
Sara Arjona
9845799ed6
Merge branch 'MDL-77523-400' of https://github.com/juancs/moodle into MOODLE_400_STABLE
2023-03-20 13:42:55 +01:00
Mark Sharp
23e15c1ae2
MDL-72533 core_calendar: improve calendar event table peformance
...
- Filter searchable courses if set.
- Sites with large groups should now experience better performance.
- Applies and optimises query against a proper date range.
Co-authored-by: Mark Sharp <mark.sharp@solent.ac.uk >
Co-authored-by: Peter Sistrom <petersistrom@catalyst-au.net >
Co-authored-by: Kevin Pham <keevan.pham@gmail.com >
2023-03-20 12:17:31 +11:00
AMOS bot
5bbdf8ab51
Automatically generated installer lang files
2023-03-20 00:07:37 +00:00
Brendan Heywood
f42ac85b7e
MDL-77618 admin: Passwords should not auto complete
2023-03-18 13:03:38 +11:00
AMOS bot
6a566abcd9
Automatically generated installer lang files
2023-03-18 00:07:38 +00:00
Juan Segarra Montesinos
c0a05c9d8a
MDL-77670 course: Preserve course summary format
2023-03-17 20:53:08 +01:00
Sara Arjona
a971b89389
weekly release 4.0.7+
2023-03-17 17:58:33 +01:00
Sara Arjona
10a640c25e
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-03-17 17:58:25 +01:00
Jun Pataleta
c0373ed7f7
Merge branch 'MDL-76257-400' of https://github.com/juancs/moodle into MOODLE_400_STABLE
2023-03-17 11:01:14 +08:00
Jun Pataleta
6b7b12c790
Merge branch 'MDL-77608-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE
2023-03-17 10:29:40 +08:00
AMOS bot
213935c460
Automatically generated installer lang files
2023-03-17 00:07:40 +00:00
Paul Holden
75a1e8d843
MDL-77666 contentbank: format category names for display.
2023-03-16 23:27:20 +00:00
info@eWallah.net
c5bea842a9
MDL-77584 currencies: Fix outdated ISO 4217 code for Zambian Kwacha
...
On 2013-01-01 the ZMK code got replaced by the new ZMW code.
AMOS BEGIN
MOV [ZMK,core_currencies],[ZMW,core_currencies]
AMOS END
2023-03-16 19:53:34 +01:00
Paul Holden
4e758d343a
MDL-76339 mod_bigbluebuttonbn: correct upgrade note fix versions.
2023-03-15 19:15:53 +00:00
Paul Holden
e889cc49c2
Merge branch 'MDL-76339-400' of https://github.com/call-learning/moodle into MOODLE_400_STABLE
2023-03-15 19:06:02 +00:00
Andrew Nicols
06fa0aad49
Merge branch 'MDL-77550-400' of https://github.com/dpalou/moodle into MOODLE_400_STABLE
2023-03-15 14:26:38 +08:00
Jun Pataleta
4a60dd3205
Merge branch 'MDL-77611_400' of https://github.com/timhunt/moodle into MOODLE_400_STABLE
2023-03-15 10:00:58 +08:00
AMOS bot
7c18bb6833
Automatically generated installer lang files
2023-03-15 00:07:36 +00:00
Paul Holden
5eb255f051
MDL-59175 theme_boost: style inherited permission on overide page.
2023-03-14 20:58:04 +00:00
Tim Hunt
88cedd9f99
MDL-77626 quiz statistics: Divide by zero if a random Q has max mark 0
2023-03-14 16:29:59 +00:00
Mark Johnson
d1254b0c8d
MDL-75746 mod_quiz: Fix backup and restore of quiz slots
2023-03-14 16:07:35 +00:00
Mark Johnson
962ab85122
MDL-72124 question: Fix system-level URLs in question events
2023-03-14 15:40:51 +00:00
Eloy Lafuente (stronk7)
264f458417
weekly release 4.0.7+
2023-03-14 16:07:41 +01:00
Eloy Lafuente (stronk7)
adc9c66e75
Merge branch 'install_400_STABLE' of https://git.in.moodle.com/amosbot/moodle-install into MOODLE_400_STABLE
2023-03-14 16:07:36 +01:00
Jun Pataleta
6ddeef9cab
Merge branch 'MDL-76680/400' of https://github.com/skodak/moodle into MOODLE_400_STABLE
2023-03-14 21:44:14 +08:00
Laurent David
68456ca14f
MDL-70976 core_files: Allow for draft files url inserted in content
...
* The file file_remove_editor_orphaned_files should take into account URL that
have been embedded in a tag content instead of an attribute (like src attribute)
* This will fix issue with inserting H5P content in calendar events.
2023-03-14 08:48:40 +01:00
Juan Segarra Montesinos
45d7645598
MDL-76257 core: Activity intro should honor user preference on creation
2023-03-14 06:06:27 +01:00
AMOS bot
2c2bd9e2af
Automatically generated installer lang files
2023-03-14 00:07:38 +00:00
Tim Hunt
9cf379579b
MDL-77611 tool_uploaduser: fix phpunit assumptions about profile fields
2023-03-13 13:37:52 +00:00
Paul Holden
2919cf9e1b
MDL-77608 mod_h5pactivity: namespace component lib testcase.
2023-03-13 09:44:05 +00:00
Simey Lameze
136e636bf0
MDL-77574 myoverview: wait until next button exists before clicking
2023-03-13 14:12:33 +08:00
Jake Dallimore
622f98e637
MDL-77382 core: fix error handling in oauth2 callback for auth'd users
...
Pass the errors back to the calling code when the user is authenticated,
otherwise, fall back on the existing redirection to the login page.
2023-03-13 10:50:15 +08:00
AMOS bot
aa6bfe07ef
Automatically generated installer lang files
2023-03-12 00:07:44 +00:00
Petr Skoda
712391f96b
MDL-76680 core: disable $USER->ignoresesskey on next page
2023-03-11 10:37:34 +01:00
Dani Palou
778840f1d7
MDL-77550 lesson: Format decimals in feedback page
2023-03-08 07:45:05 +01:00
Roberto Bravo
756f56492e
MDL-77256 tool_uploaduser: fix get allowed roles for courses
...
During user upload the permission to assign roles is checked in the wrong context
2023-03-07 18:38:46 +01:00
Juan Segarra Montesinos
5fc2612d25
MDL-77523 mod_data: textarea field should honor editor preferred format
2023-03-05 08:53:02 +01:00
Laurent David
55620756a5
MDL-76339 mod_bigbluebuttonbn: Update dismissed recordings
...
* When the server is not reachable (or recordings are not reacheable)
the recording is set to RECORDING_STATUS_DISMISSED and is then
not visible in the list.
* Add a CLI script to solve potential issue with DISMISSED recordings
2023-03-03 06:38:26 +01:00
Anastasios Bithas
9079e01d44
MDL-73642 mod_assign: Disable draft option if submission already made
2023-02-04 18:49:21 +02:00
Hiroto Kagotani
7b79101032
MDL-76936 course: purge course cache on resetting start date
2023-01-19 20:01:03 +09:00
Mark Holliday
801e7d9fe4
MDL-76376 scorm: fix PHP8 TypeError (null is not Countable)
2022-11-28 17:52:33 -05:00