L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'MDL-77913-400' of https://github.com/paulholden/moodle into MOODLE_400_STABLE

Browse Source
This commit is contained in:
Sara Arjona
2023-04-14 14:02:23 +02:00
parent 9cae11732f 53f5432d89
commit 95b427d8fe
2 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/bank/previewquestion/classes/helper.php
+2 -1
View File
@@ -311,7 +311,8 @@ class helper {
$questionids = [];
$sql = 'SELECT version, questionid
FROM {question_versions}
WHERE questionbankentryid = ?';
WHERE questionbankentryid = ?
ORDER BY version';
$versions = $DB->get_records_sql($sql, [$questionbankentryid]);
foreach ($versions as $key => $version) {
question/bank/previewquestion/tests/qbank_preview_helper_test.php
+11 -4
View File
@@ -221,21 +221,28 @@ class qbank_preview_helper_test extends \advanced_testcase {
* @covers ::load_versions
*/
public function test_load_versions() {
global $DB;
$this->resetAfterTest();
$generator = $this->getDataGenerator()->get_plugin_generator('core_question');
$qcat1 = $generator->create_question_category(['name' => 'My category', 'sortorder' => 1, 'idnumber' => 'myqcat']);
$questiongenerated = $generator->create_question('description', null, ['name' => 'q1', 'category' => $qcat1->id]);
$qtypeobj = question_bank::get_qtype($questiongenerated->qtype);
$question = question_bank::load_question($questiongenerated->id);
$versionids = helper::load_versions($question->questionbankentryid);
$this->assertCount(1, $versionids);
$this->assertEquals([
$question->id => 1,
], $versionids);
$fromform = new stdClass();
$fromform->name = 'Name edited';
$fromform->category = $qcat1->id;
$qtypeobj->save_question($questiongenerated, $fromform);
$questiontwo = $qtypeobj->save_question($questiongenerated, $fromform);
$versionids = helper::load_versions($question->questionbankentryid);
$this->assertCount(2, $versionids);
$this->assertSame([
$question->id => 1,
$questiontwo->id => 2,
], $versionids);
}
/**