electron-rare/Aperant
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: mark all PR #1942 items as resolved or skipped

Browse Source 
All 110 PR review items have been addressed:
- 75 resolved with code fixes
- 35 skipped as false positives or already fixed

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
StillKnotKnown
2026-03-13 14:56:45 +02:00
parent 7896be5f69
commit dcc6afad2d
7 changed files with 52 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/desktop/.fix-pr-data/pending/comments/coderabbitai/97fab15786953674.md → apps/desktop/.fix-pr-data/resolved/comments/coderabbitai/97fab15786953674.md
+5 -7
View File
@@ -6,7 +6,7 @@
**Original ID:** 2930643797
**Created:** None
**Severity:** HIGH
**Status:** PENDING
**Status:** RESOLVED
---
@@ -49,12 +49,10 @@ renderer code and `@shared/`* for shared types.
## Implementation Notes
*Status: PENDING - Not yet verified or implemented*
*Status: RESOLVED*
### Verification Checklist
**Resolution:** Replaced relative import '../issues-store' with path alias '@/stores/gitlab/issues-store'
- [ ] Read file at comment location
- [ ] Verify if issue is already fixed
- [ ] Implement fix if needed
- [ ] Re-verify after implementation
### Fix Commit
`91930f342f27e5f4a9f7b5be83c2d97de4ee35d7`
apps/desktop/.fix-pr-data/pending/comments/coderabbitai/e33ab85488b5fcaa.md → apps/desktop/.fix-pr-data/resolved/comments/coderabbitai/e33ab85488b5fcaa.md
+5 -7
View File
@@ -6,7 +6,7 @@
**Original ID:** 2930643804
**Created:** None
**Severity:** HIGH
**Status:** PENDING
**Status:** RESOLVED
---
@@ -48,12 +48,10 @@ GitLabSyncStatus to use these aliases to match tsconfig path mappings.
## Implementation Notes
*Status: PENDING - Not yet verified or implemented*
*Status: RESOLVED*
### Verification Checklist
**Resolution:** Replaced relative imports '../sync-status-store' with path alias '@/stores/gitlab/sync-status-store'
- [ ] Read file at comment location
- [ ] Verify if issue is already fixed
- [ ] Implement fix if needed
- [ ] Re-verify after implementation
### Fix Commit
`91930f342f27e5f4a9f7b5be83c2d97de4ee35d7`
apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/550c5ed484bfd8c8.md → apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/550c5ed484bfd8c8.md
+3 -9
View File
@@ -6,7 +6,7 @@
**Original ID:** 2930224298
**Created:** None
**Severity:** MEDIUM
**Status:** PENDING
**Status:** SKIPPED
---
@@ -24,12 +24,6 @@ The comment here is misleading. The code doesn't fetch one more item to check if
## Implementation Notes
*Status: PENDING - Not yet verified or implemented*
### Verification Checklist
- [ ] Read file at comment location
- [ ] Verify if issue is already fixed
- [ ] Implement fix if needed
- [ ] Re-verify after implementation
*Status: SKIPPED*
**Resolution:** FALSE POSITIVE: Comment 'Over-fetch by 1 to reliably determine if there are more pages' at line 1396 IS accurate - code DOES fetch 21 items (per_page: '21') and checks hasMore = mrs.length > 20
apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/696a203d246f4fb1.md → apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/696a203d246f4fb1.md
+3 -9
View File
@@ -6,7 +6,7 @@
**Original ID:** 2930224293
**Created:** None
**Severity:** MEDIUM
**Status:** PENDING
**Status:** SKIPPED
---
@@ -20,12 +20,6 @@ The use of `BrowserWindow.getAllWindows()[0]` to get the main window is not robu
## Implementation Notes
*Status: PENDING - Not yet verified or implemented*
### Verification Checklist
- [ ] Read file at comment location
- [ ] Verify if issue is already fixed
- [ ] Implement fix if needed
- [ ] Re-verify after implementation
*Status: SKIPPED*
**Resolution:** FALSE POSITIVE: Code at line 1190-1191 uses BrowserWindow.fromWebContents(event.sender) which is MORE robust than getAllWindows()[0]. The comment explicitly acknowledges this: 'more robust than getAllWindows()[0]'
apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/aeb08798e7eed2ac.md → apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/aeb08798e7eed2ac.md
+3 -9
View File
@@ -7,7 +7,7 @@
**Original ID:** 2930224290
**Created:** None
**Severity:** CRITICAL
**Status:** PENDING
**Status:** SKIPPED
---
@@ -25,12 +25,6 @@ To fix this, you should probably pass the raw GitLab merge status string (e.g.,
## Implementation Notes
*Status: PENDING - Not yet verified or implemented*
### Verification Checklist
- [ ] Read file at comment location
- [ ] Verify if issue is already fixed
- [ ] Implement fix if needed
- [ ] Re-verify after implementation
*Status: SKIPPED*
**Resolution:** FALSE POSITIVE: Code is correct - mergeStatus prop is typed as string | null (raw GitLab status), not MergeableState. Component correctly derives both mergeKey and mergeableState from the raw input via mergeKeyMap and gitlabToMergeableState.
apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/b4930b4ccedb1ec8.md → apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/b4930b4ccedb1ec8.md
+3 -9
View File
@@ -6,7 +6,7 @@
**Original ID:** 2930224307
**Created:** None
**Severity:** MEDIUM
**Status:** PENDING
**Status:** SKIPPED
---
@@ -24,12 +24,6 @@ The return type for `getGitLabMRReviewsBatch` uses `Record<number, any>`, which
## Implementation Notes
*Status: PENDING - Not yet verified or implemented*
### Verification Checklist
- [ ] Read file at comment location
- [ ] Verify if issue is already fixed
- [ ] Implement fix if needed
- [ ] Re-verify after implementation
*Status: SKIPPED*
**Resolution:** FALSE POSITIVE: Code at line 89 already uses proper type: Promise<IPCResult<Record<number, GitLabMRReviewResult | null>>> - NOT Record<number, any>
apps/desktop/.fix-pr-data/tracking.json
+30 -16
View File
@@ -1,12 +1,12 @@
{
"version": "2.0",
"pr_number": 1942,
"last_updated": "2026-03-13T14:54:45.113681",
"last_updated": "2026-03-13T14:56:17.118433",
"stats": {
"total": 110,
"resolved": 73,
"pending": 6,
"skipped": 31
"resolved": 75,
"pending": 0,
"skipped": 35
},
"items": {
"github-advanced-security:comment_2930203243": {
@@ -37,9 +37,11 @@
"severity": "CRITICAL",
"suggested_fix": null,
"language": "typescript",
"status": "pending",
"status": "skipped",
"created_at": null,
"updated_at": null
"updated_at": null,
"resolution_note": "FALSE POSITIVE: Code is correct - mergeStatus prop is typed as string | null (raw GitLab status), not MergeableState. Component correctly derives both mergeKey and mergeableState from the raw input via mergeKeyMap and gitlabToMergeableState.",
"resolved_at": "2026-03-13T14:55:56.721404"
},
"gemini-code-assist:comment_2930224293": {
"id": "696a203d246f4fb1",
@@ -52,9 +54,11 @@
"severity": "MEDIUM",
"suggested_fix": null,
"language": "typescript",
"status": "pending",
"status": "skipped",
"created_at": null,
"updated_at": null
"updated_at": null,
"resolution_note": "FALSE POSITIVE: Code at line 1190-1191 uses BrowserWindow.fromWebContents(event.sender) which is MORE robust than getAllWindows()[0]. The comment explicitly acknowledges this: 'more robust than getAllWindows()[0]'",
"resolved_at": "2026-03-13T14:56:13.976665"
},
"gemini-code-assist:comment_2930224298": {
"id": "550c5ed484bfd8c8",
@@ -67,9 +71,11 @@
"severity": "MEDIUM",
"suggested_fix": null,
"language": "typescript",
"status": "pending",
"status": "skipped",
"created_at": null,
"updated_at": null
"updated_at": null,
"resolution_note": "FALSE POSITIVE: Comment 'Over-fetch by 1 to reliably determine if there are more pages' at line 1396 IS accurate - code DOES fetch 21 items (per_page: '21') and checks hasMore = mrs.length > 20",
"resolved_at": "2026-03-13T14:55:59.952492"
},
"gemini-code-assist:comment_2930224307": {
"id": "b4930b4ccedb1ec8",
@@ -82,9 +88,11 @@
"severity": "MEDIUM",
"suggested_fix": null,
"language": "typescript",
"status": "pending",
"status": "skipped",
"created_at": null,
"updated_at": null
"updated_at": null,
"resolution_note": "FALSE POSITIVE: Code at line 89 already uses proper type: Promise<IPCResult<Record<number, GitLabMRReviewResult | null>>> - NOT Record<number, any>",
"resolved_at": "2026-03-13T14:56:17.117710"
},
"coderabbitai:comment_2930292927": {
"id": "cc9ad779af24bb5a",
@@ -1408,9 +1416,12 @@
"severity": "HIGH",
"suggested_fix": null,
"language": "typescript",
"status": "pending",
"status": "resolved",
"created_at": null,
"updated_at": null
"updated_at": null,
"resolution_note": "Replaced relative import '../issues-store' with path alias '@/stores/gitlab/issues-store'",
"fix_commit": "91930f342f27e5f4a9f7b5be83c2d97de4ee35d7",
"resolved_at": "2026-03-13T14:55:23.265661"
},
"coderabbitai:comment_2930643804": {
"id": "e33ab85488b5fcaa",
@@ -1423,9 +1434,12 @@
"severity": "HIGH",
"suggested_fix": null,
"language": "typescript",
"status": "pending",
"status": "resolved",
"created_at": null,
"updated_at": null
"updated_at": null,
"resolution_note": "Replaced relative imports '../sync-status-store' with path alias '@/stores/gitlab/sync-status-store'",
"fix_commit": "91930f342f27e5f4a9f7b5be83c2d97de4ee35d7",
"resolved_at": "2026-03-13T14:55:26.328093"
},
"coderabbitai:comment_2930643807": {
"id": "513f1bedc99a2084",