From dcc6afad2de5fc90ea776b443326bedfbe1b1b97 Mon Sep 17 00:00:00 2001 From: StillKnotKnown Date: Fri, 13 Mar 2026 14:56:45 +0200 Subject: [PATCH] chore: mark all PR #1942 items as resolved or skipped All 110 PR review items have been addressed: - 75 resolved with code fixes - 35 skipped as false positives or already fixed Co-Authored-By: Claude Opus 4.6 --- .../comments/coderabbitai/97fab15786953674.md | 12 ++--- .../comments/coderabbitai/e33ab85488b5fcaa.md | 12 ++--- .../gemini-code-assist/550c5ed484bfd8c8.md | 12 ++--- .../gemini-code-assist/696a203d246f4fb1.md | 12 ++--- .../gemini-code-assist/aeb08798e7eed2ac.md | 12 ++--- .../gemini-code-assist/b4930b4ccedb1ec8.md | 12 ++--- apps/desktop/.fix-pr-data/tracking.json | 46 ++++++++++++------- 7 files changed, 52 insertions(+), 66 deletions(-) rename apps/desktop/.fix-pr-data/{pending => resolved}/comments/coderabbitai/97fab15786953674.md (86%) rename apps/desktop/.fix-pr-data/{pending => resolved}/comments/coderabbitai/e33ab85488b5fcaa.md (86%) rename apps/desktop/.fix-pr-data/{pending => resolved}/comments/gemini-code-assist/550c5ed484bfd8c8.md (75%) rename apps/desktop/.fix-pr-data/{pending => resolved}/comments/gemini-code-assist/696a203d246f4fb1.md (75%) rename apps/desktop/.fix-pr-data/{pending => resolved}/comments/gemini-code-assist/aeb08798e7eed2ac.md (79%) rename apps/desktop/.fix-pr-data/{pending => resolved}/comments/gemini-code-assist/b4930b4ccedb1ec8.md (77%) diff --git a/apps/desktop/.fix-pr-data/pending/comments/coderabbitai/97fab15786953674.md b/apps/desktop/.fix-pr-data/resolved/comments/coderabbitai/97fab15786953674.md similarity index 86% rename from apps/desktop/.fix-pr-data/pending/comments/coderabbitai/97fab15786953674.md rename to apps/desktop/.fix-pr-data/resolved/comments/coderabbitai/97fab15786953674.md index 54f6ca9c..8ab69840 100644 --- a/apps/desktop/.fix-pr-data/pending/comments/coderabbitai/97fab15786953674.md +++ b/apps/desktop/.fix-pr-data/resolved/comments/coderabbitai/97fab15786953674.md @@ -6,7 +6,7 @@ **Original ID:** 2930643797 **Created:** None **Severity:** HIGH -**Status:** PENDING +**Status:** RESOLVED --- @@ -49,12 +49,10 @@ renderer code and `@shared/`* for shared types. ## Implementation Notes -*Status: PENDING - Not yet verified or implemented* +*Status: RESOLVED* -### Verification Checklist +**Resolution:** Replaced relative import '../issues-store' with path alias '@/stores/gitlab/issues-store' -- [ ] Read file at comment location -- [ ] Verify if issue is already fixed -- [ ] Implement fix if needed -- [ ] Re-verify after implementation +### Fix Commit +`91930f342f27e5f4a9f7b5be83c2d97de4ee35d7` \ No newline at end of file diff --git a/apps/desktop/.fix-pr-data/pending/comments/coderabbitai/e33ab85488b5fcaa.md b/apps/desktop/.fix-pr-data/resolved/comments/coderabbitai/e33ab85488b5fcaa.md similarity index 86% rename from apps/desktop/.fix-pr-data/pending/comments/coderabbitai/e33ab85488b5fcaa.md rename to apps/desktop/.fix-pr-data/resolved/comments/coderabbitai/e33ab85488b5fcaa.md index 7a555f90..6ba46a18 100644 --- a/apps/desktop/.fix-pr-data/pending/comments/coderabbitai/e33ab85488b5fcaa.md +++ b/apps/desktop/.fix-pr-data/resolved/comments/coderabbitai/e33ab85488b5fcaa.md @@ -6,7 +6,7 @@ **Original ID:** 2930643804 **Created:** None **Severity:** HIGH -**Status:** PENDING +**Status:** RESOLVED --- @@ -48,12 +48,10 @@ GitLabSyncStatus to use these aliases to match tsconfig path mappings. ## Implementation Notes -*Status: PENDING - Not yet verified or implemented* +*Status: RESOLVED* -### Verification Checklist +**Resolution:** Replaced relative imports '../sync-status-store' with path alias '@/stores/gitlab/sync-status-store' -- [ ] Read file at comment location -- [ ] Verify if issue is already fixed -- [ ] Implement fix if needed -- [ ] Re-verify after implementation +### Fix Commit +`91930f342f27e5f4a9f7b5be83c2d97de4ee35d7` \ No newline at end of file diff --git a/apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/550c5ed484bfd8c8.md b/apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/550c5ed484bfd8c8.md similarity index 75% rename from apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/550c5ed484bfd8c8.md rename to apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/550c5ed484bfd8c8.md index eb51a51e..5f972e87 100644 --- a/apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/550c5ed484bfd8c8.md +++ b/apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/550c5ed484bfd8c8.md @@ -6,7 +6,7 @@ **Original ID:** 2930224298 **Created:** None **Severity:** MEDIUM -**Status:** PENDING +**Status:** SKIPPED --- @@ -24,12 +24,6 @@ The comment here is misleading. The code doesn't fetch one more item to check if ## Implementation Notes -*Status: PENDING - Not yet verified or implemented* - -### Verification Checklist - -- [ ] Read file at comment location -- [ ] Verify if issue is already fixed -- [ ] Implement fix if needed -- [ ] Re-verify after implementation +*Status: SKIPPED* +**Resolution:** FALSE POSITIVE: Comment 'Over-fetch by 1 to reliably determine if there are more pages' at line 1396 IS accurate - code DOES fetch 21 items (per_page: '21') and checks hasMore = mrs.length > 20 \ No newline at end of file diff --git a/apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/696a203d246f4fb1.md b/apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/696a203d246f4fb1.md similarity index 75% rename from apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/696a203d246f4fb1.md rename to apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/696a203d246f4fb1.md index a0528bab..6a84c826 100644 --- a/apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/696a203d246f4fb1.md +++ b/apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/696a203d246f4fb1.md @@ -6,7 +6,7 @@ **Original ID:** 2930224293 **Created:** None **Severity:** MEDIUM -**Status:** PENDING +**Status:** SKIPPED --- @@ -20,12 +20,6 @@ The use of `BrowserWindow.getAllWindows()[0]` to get the main window is not robu ## Implementation Notes -*Status: PENDING - Not yet verified or implemented* - -### Verification Checklist - -- [ ] Read file at comment location -- [ ] Verify if issue is already fixed -- [ ] Implement fix if needed -- [ ] Re-verify after implementation +*Status: SKIPPED* +**Resolution:** FALSE POSITIVE: Code at line 1190-1191 uses BrowserWindow.fromWebContents(event.sender) which is MORE robust than getAllWindows()[0]. The comment explicitly acknowledges this: 'more robust than getAllWindows()[0]' \ No newline at end of file diff --git a/apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/aeb08798e7eed2ac.md b/apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/aeb08798e7eed2ac.md similarity index 79% rename from apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/aeb08798e7eed2ac.md rename to apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/aeb08798e7eed2ac.md index d0265942..145da686 100644 --- a/apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/aeb08798e7eed2ac.md +++ b/apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/aeb08798e7eed2ac.md @@ -7,7 +7,7 @@ **Original ID:** 2930224290 **Created:** None **Severity:** CRITICAL -**Status:** PENDING +**Status:** SKIPPED --- @@ -25,12 +25,6 @@ To fix this, you should probably pass the raw GitLab merge status string (e.g., ## Implementation Notes -*Status: PENDING - Not yet verified or implemented* - -### Verification Checklist - -- [ ] Read file at comment location -- [ ] Verify if issue is already fixed -- [ ] Implement fix if needed -- [ ] Re-verify after implementation +*Status: SKIPPED* +**Resolution:** FALSE POSITIVE: Code is correct - mergeStatus prop is typed as string | null (raw GitLab status), not MergeableState. Component correctly derives both mergeKey and mergeableState from the raw input via mergeKeyMap and gitlabToMergeableState. \ No newline at end of file diff --git a/apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/b4930b4ccedb1ec8.md b/apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/b4930b4ccedb1ec8.md similarity index 77% rename from apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/b4930b4ccedb1ec8.md rename to apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/b4930b4ccedb1ec8.md index 90f8bcf1..3bad8811 100644 --- a/apps/desktop/.fix-pr-data/pending/comments/gemini-code-assist/b4930b4ccedb1ec8.md +++ b/apps/desktop/.fix-pr-data/resolved/comments/gemini-code-assist/b4930b4ccedb1ec8.md @@ -6,7 +6,7 @@ **Original ID:** 2930224307 **Created:** None **Severity:** MEDIUM -**Status:** PENDING +**Status:** SKIPPED --- @@ -24,12 +24,6 @@ The return type for `getGitLabMRReviewsBatch` uses `Record`, which ## Implementation Notes -*Status: PENDING - Not yet verified or implemented* - -### Verification Checklist - -- [ ] Read file at comment location -- [ ] Verify if issue is already fixed -- [ ] Implement fix if needed -- [ ] Re-verify after implementation +*Status: SKIPPED* +**Resolution:** FALSE POSITIVE: Code at line 89 already uses proper type: Promise>> - NOT Record \ No newline at end of file diff --git a/apps/desktop/.fix-pr-data/tracking.json b/apps/desktop/.fix-pr-data/tracking.json index 0e3cec8b..ad9e7f36 100644 --- a/apps/desktop/.fix-pr-data/tracking.json +++ b/apps/desktop/.fix-pr-data/tracking.json @@ -1,12 +1,12 @@ { "version": "2.0", "pr_number": 1942, - "last_updated": "2026-03-13T14:54:45.113681", + "last_updated": "2026-03-13T14:56:17.118433", "stats": { "total": 110, - "resolved": 73, - "pending": 6, - "skipped": 31 + "resolved": 75, + "pending": 0, + "skipped": 35 }, "items": { "github-advanced-security:comment_2930203243": { @@ -37,9 +37,11 @@ "severity": "CRITICAL", "suggested_fix": null, "language": "typescript", - "status": "pending", + "status": "skipped", "created_at": null, - "updated_at": null + "updated_at": null, + "resolution_note": "FALSE POSITIVE: Code is correct - mergeStatus prop is typed as string | null (raw GitLab status), not MergeableState. Component correctly derives both mergeKey and mergeableState from the raw input via mergeKeyMap and gitlabToMergeableState.", + "resolved_at": "2026-03-13T14:55:56.721404" }, "gemini-code-assist:comment_2930224293": { "id": "696a203d246f4fb1", @@ -52,9 +54,11 @@ "severity": "MEDIUM", "suggested_fix": null, "language": "typescript", - "status": "pending", + "status": "skipped", "created_at": null, - "updated_at": null + "updated_at": null, + "resolution_note": "FALSE POSITIVE: Code at line 1190-1191 uses BrowserWindow.fromWebContents(event.sender) which is MORE robust than getAllWindows()[0]. The comment explicitly acknowledges this: 'more robust than getAllWindows()[0]'", + "resolved_at": "2026-03-13T14:56:13.976665" }, "gemini-code-assist:comment_2930224298": { "id": "550c5ed484bfd8c8", @@ -67,9 +71,11 @@ "severity": "MEDIUM", "suggested_fix": null, "language": "typescript", - "status": "pending", + "status": "skipped", "created_at": null, - "updated_at": null + "updated_at": null, + "resolution_note": "FALSE POSITIVE: Comment 'Over-fetch by 1 to reliably determine if there are more pages' at line 1396 IS accurate - code DOES fetch 21 items (per_page: '21') and checks hasMore = mrs.length > 20", + "resolved_at": "2026-03-13T14:55:59.952492" }, "gemini-code-assist:comment_2930224307": { "id": "b4930b4ccedb1ec8", @@ -82,9 +88,11 @@ "severity": "MEDIUM", "suggested_fix": null, "language": "typescript", - "status": "pending", + "status": "skipped", "created_at": null, - "updated_at": null + "updated_at": null, + "resolution_note": "FALSE POSITIVE: Code at line 89 already uses proper type: Promise>> - NOT Record", + "resolved_at": "2026-03-13T14:56:17.117710" }, "coderabbitai:comment_2930292927": { "id": "cc9ad779af24bb5a", @@ -1408,9 +1416,12 @@ "severity": "HIGH", "suggested_fix": null, "language": "typescript", - "status": "pending", + "status": "resolved", "created_at": null, - "updated_at": null + "updated_at": null, + "resolution_note": "Replaced relative import '../issues-store' with path alias '@/stores/gitlab/issues-store'", + "fix_commit": "91930f342f27e5f4a9f7b5be83c2d97de4ee35d7", + "resolved_at": "2026-03-13T14:55:23.265661" }, "coderabbitai:comment_2930643804": { "id": "e33ab85488b5fcaa", @@ -1423,9 +1434,12 @@ "severity": "HIGH", "suggested_fix": null, "language": "typescript", - "status": "pending", + "status": "resolved", "created_at": null, - "updated_at": null + "updated_at": null, + "resolution_note": "Replaced relative imports '../sync-status-store' with path alias '@/stores/gitlab/sync-status-store'", + "fix_commit": "91930f342f27e5f4a9f7b5be83c2d97de4ee35d7", + "resolved_at": "2026-03-13T14:55:26.328093" }, "coderabbitai:comment_2930643807": { "id": "513f1bedc99a2084",