Commit Graph

83 Commits

Author SHA1 Message Date
Damyon Wiese 2c6fe0c698 MDL-30852 grade report: More coding guideline cleanups. 2013-08-05 11:24:06 +08:00
Damyon Wiese da6fc6fe17 MDL-30852 grade: Coding style fix for user report. 2013-08-05 11:24:06 +08:00
Steve Bader 8460efc65b MDL-30852 grade report: Add aria attributes
Converted to git branch by Damyon
2013-08-05 11:24:05 +08:00
Tim Hunt f30c9280d4 MDL-40854 fix mod/...:view capabilities
Prior to the fix, if you did not have a capability like mod/page:view,
then you woulds still see the link to the Page activity in the course
section, but when you clicked on it, you would run into a
require_capability error.

It is a principle that we never show users a link to a page they are not
allowed to access, therefore, when users do not have mod/...:view, they
should not see the link on the course page.

This patch implements this in the cm_info class, in a similar way to how
access restrictions by groups works.

It does not assume that the mod/...:view capability exists. If the
capability does not exist, then users are not prevented from seeing the
link.
2013-07-26 11:51:31 +01:00
Andrew Davis 4b280ca679 MDL-37475 core_grade:fixed the handling of show totals 2013-05-08 10:35:17 +12:00
Andrew Davis 662cfbc7e1 MDL-33117 grade: adding unit tests for the user report function inject_rowspans() 2013-01-07 11:59:58 +08:00
Andrew Davis 5e76227126 MDL-35762 core_grade: altered the code that determines whether an activity is visible on the user report 2012-11-05 09:35:10 +08:00
Dan Poltawski f7e8f312ca Revert "MDL-33117 grade: added some smarts to the user report method inject_rowspans() to deal with activity conditional availability"
This reverts commit 69c8bcec70.
2012-10-05 16:21:14 +08:00
Dan Poltawski 229f543881 Merge branch 'MDL-33117_grade_display' of git://github.com/andyjdavis/moodle 2012-10-02 09:32:58 +08:00
Andrew Davis 69c8bcec70 MDL-33117 grade: added some smarts to the user report method inject_rowspans() to deal with activity conditional availability 2012-09-28 12:06:44 +08:00
Frederic Massart 5fee56d5c3 MDL-34931 core_grade: Fixed grades hidden when activity is hidden 2012-09-28 11:39:46 +08:00
Adrian Greeve d40604724b MDL-34463 - lib - Alteration of the get_context_instance function to utilize the new function context_XXXX::instance(). 2012-07-24 14:04:40 +08:00
Sam Hemelryk 49ddf4195c MDL-31510 grader report: Fixed whitespace 2012-04-30 12:13:00 +12:00
Andrew Davis aee748d32c MDL-31510 grade: made the user report observe $cm->uservisible so that activities not available to a student because of groups do not appear on their user report 2012-04-26 16:31:56 +07:00
Andrew Davis 62a966ada0 MDL-31841 grade: prevented the feedback column on the user report from being centered 2012-03-08 15:19:17 +07:00
Andrew Davis a153c9f2fe MDL-30999 grade: updated Grade API phpdocs 2012-02-14 14:04:19 +07:00
andrew d3e303470d MDL-27703 gradebook: altered an sql query in the user report. join with no on clause causes an error in some DBs 2011-11-16 09:56:46 +08:00
Marina Glancy c97933ffa3 MDL-30161: link from gradebook (grading analysis) only appears now in Grader report but for all items; in User report the link under activity name contains userid 2011-11-08 14:09:50 +08:00
David Mudrak 0455c99864 MDL-29920 User report may display the grade analysis link, too
The original idea was to use the link in the row header (the activity
link). However, for both unified user experience and the overall patch
design reasons, I finally decided not to alter the activity link but to
append the analysis icon. The user experience should be the same as in
the grader report.
2011-11-03 13:51:45 +01:00
Andrew Davis (andyjdavis) 656d17c2c6 gradebook MDL-20946 fixed average calculation where users have multiple gradeable roles 2011-04-04 11:35:47 +02:00
Eloy Lafuente (stronk7) cc65dc366d MDL-25708 recordsets - found one more recent use. fixed. 2011-01-30 13:43:06 +01:00
Sam Hemelryk a1e26b5e46 gradebook MDL-20617 Fixed SQL formatting 2011-01-18 17:17:14 +08:00
andyjdavis a071dbb66b gradebook MDL-20617 added more control over what columns are displayed on the user report 2011-01-18 17:13:06 +08:00
Sam Hemelryk 367a75fae4 themes lib MDL-24895 Multiple fixes to better handle overflow.
Major tasks undertaken in this patch:
* New format_text argument, overflowdiv.
* New page layout Report.
* Review of all format_text calls.
* Added support for the report layout to all themes.
* Changed forum post display from tables to divs.
2010-11-05 02:53:47 +00:00
Inaki d09cad434b grade/report: MDL-21001 Gradebook shows ranges always
We unconditionnally set them to visible, ignoring configured settings.
Fix it.
2010-11-01 10:24:21 +00:00
Petr Skoda 4d27bc7929 fixed phpdocs and using property_exists() which is required by PHP 5.3 2010-09-17 19:05:23 +00:00
Petr Skoda b5e7b2bf2b MDL-23071 standardising gradebook plugin names
AMOS BEGIN
 MOV [modulename,gradeimport_csv],[pluginname,gradeimport_csv]
 MOV [modulename,gradeimport_xml],[pluginname,gradeimport_xml]
 MOV [modulename,gradeexport_ods],[pluginname,gradeexport_ods]
 MOV [modulename,gradeexport_txt],[pluginname,gradeexport_txt]
 MOV [modulename,gradeexport_xls],[pluginname,gradeexport_xls]
 MOV [modulename,gradeexport_xml],[pluginname,gradeexport_xml]
 MOV [modulename,gradereport_grader],[pluginname,gradereport_grader]
 MOV [modulename,gradereport_outcomes],[pluginname,gradereport_outcomes]
 MOV [modulename,gradereport_overview],[pluginname,gradereport_overview]
 MOV [modulename,gradereport_user],[pluginname,gradereport_user]
AMOS END
2010-07-04 13:08:11 +00:00
David Mudrak 1cc3165e18 MDL-21695 Replaced grade/showrank.html
AMOS BEGIN
 MOV [configshowrank,core_grades],[showrank_help,core_grades]
 HLP grade/showrank.html,[showrank_help,core_grades]
AMOS END
2010-06-25 17:19:34 +00:00
David Mudrak ff268dcb28 MDL-21695 Replaced grade/showpercentage.html
AMOS BEGIN
 MOV [configshowpercentage,core_grades],[showpercentage_help,core_grades]
 HLP grade/showpercentage.html,[showpercentage_help,core_grades]
AMOS END
2010-06-21 08:39:27 +00:00
David Mudrak 69e3e962b1 MDL-21695 Replaced grade/showhiddenitems.html
AMOS BEGIN
 MOV [configshowhiddenitems,core_grades],[showhiddenitems_help,core_grades]
 HLP grade/showhiddenitems.html,[showhiddenitems_help,core_grades]
AMOS END
2010-06-21 06:57:46 +00:00
David Mudrak 0459cc4d9e MDL-21695 Replaced grade/hidetotalifhiddenitems.html
AMOS BEGIN
 HLP grade/hidetotalifhiddenitems.html,[hidetotalifhiddenitems_help,core_grades]
AMOS END
2010-06-07 09:56:33 +00:00
Andrew Davis 1762a2642a gradebook MDL-21514 Ironed out a bug with hiding course totals 2010-02-12 03:39:40 +00:00
Andrew Davis 61541a5a46 gradebook MDL-21218 Improved the hiding/displaying of category and course totals when they contain hidden items 2010-02-08 06:27:04 +00:00
Andrew Davis a83507f284 grader report MDL-21270 Use constants instead of integers 2010-01-08 07:48:37 +00:00
Petr Skoda 6c3ef4103a MDL-20700 coding style cleanup - cvs keywords removed, closign php tag removed, trailing whitespace cleanup 2009-11-01 12:11:29 +00:00
samhemelryk 91152a3518 navigation MDL-20216 Refactored add arguments
Moved $action argument from arg5 to arg2
2009-09-04 03:12:01 +00:00
nicolasconnault c018f97328 MDL-19797 Migrated calls to print_heading 2009-08-06 08:16:46 +00:00
nicolasconnault e060e33dc3 MDL-19727 Replaced boilerplates and removed ID tags. Merged from MOODLE_19_STABLE 2009-07-07 02:26:36 +00:00
nicolasconnault ec3f20419a MDL-19583 Showing outcomes in user report if enabled at site level. Merged from MOODLE_19_STABLE 2009-06-23 00:38:29 +00:00
skodak d69ef28b77 MDL-19090 fixed user report preferences; merged from MOODLE_19_STABLE 2009-05-07 07:38:02 +00:00
nicolasconnault 9e322c8c54 MDL-19028 Hiding hidden category from student report instead of grade items. See code diff for better explanation. Merged from MOODLE_19_STABLE 2009-04-30 08:40:22 +00:00
skodak 81f4918e0c MDL-18943 xhtml strict - using class instead of repeated id attribute; merged from MOODLE_19_STABLE 2009-04-23 20:20:41 +00:00
nicolasconnault 653a86489e MDL-18083 Committing gradebook improvements to head 2009-04-16 07:16:44 +00:00
nicolasconnault bb776ef478 MDL-17991 Fixed a bug with the user selector 2009-02-25 09:17:48 +00:00
nicolasconnault 5528217eda MDL-17991 Implementing user report improvements 2009-02-25 07:56:11 +00:00
skodak bba9b20e0e MDL-17677 fixed string locations - patch by Vlas Voloshin; merged from MOODLE_19_STABLE 2008-12-29 20:21:01 +00:00
nicolasconnault aea45e7ef1 MDL-15887 Merging from MOODLE_19_STABLE 2008-10-13 08:44:10 +00:00
nicolasconnault 699da6b5d5 MDL-15887 Implemented new setting, Merged from MOODLE_19_STABLE 2008-10-08 11:06:05 +00:00
skodak ea1e551da6 MDL-15100 gradebook conversion 2008-06-05 14:08:58 +00:00
nicolasconnault 5c75a0a3b4 MDL-14967 DB upgrades. All done. Just bug fixing now ;) 2008-06-03 16:10:57 +00:00