MDL-21695 Replaced grade/showpercentage.html

AMOS BEGIN
 MOV [configshowpercentage,core_grades],[showpercentage_help,core_grades]
 HLP grade/showpercentage.html,[showpercentage_help,core_grades]
AMOS END

grade/report/user/lib.php

@@ -449,7 +449,7 @@ function grade_report_user_settings_definition(&$mform) {
     }
 
     $mform->addElement('select', 'report_user_showpercentage', get_string('showpercentage', 'grades'), $options);
-    $mform->setHelpButton('report_user_showpercentage', array('showpercentage', get_string('showpercentage', 'grades'), 'grade'));
+    $mform->addHelpButton('report_user_showpercentage', 'showpercentage', 'grades');
 
     $options = array(-1 => get_string('default', 'grades'),
                       0 => get_string('shownohidden', 'grades'),

grade/report/user/settings.php

@@ -18,7 +18,7 @@
 /// Add settings for this module to the $settings object (it's already defined)
 
 $settings->add(new admin_setting_configcheckbox('grade_report_user_showrank', get_string('showrank', 'grades'), get_string('configshowrank', 'grades'), 0, PARAM_INT));
-$settings->add(new admin_setting_configcheckbox('grade_report_user_showpercentage', get_string('showpercentage', 'grades'), get_string('configshowpercentage', 'grades'), 2, PARAM_INT));
+$settings->add(new admin_setting_configcheckbox('grade_report_user_showpercentage', get_string('showpercentage', 'grades'), get_string('showpercentage_help', 'grades'), 2, PARAM_INT));
 
 $options = array(0 => get_string('shownohidden', 'grades'),
                  1 => get_string('showhiddenuntilonly', 'grades'),

lang/en/grades.php

@@ -129,7 +129,6 @@ $string['confighiddenasdate'] = 'If user can not see hidden grades show date of
 $string['confighideforcedsettings'] = 'Do not show forced settings in grading UI.';
 $string['configincludescalesinaggregation'] = 'You can change whether scales are to be included as numbers in all aggregated grades across all gradebooks in all courses. CAUTION: changing this setting will force all aggregated grades to be recalculated.';
 $string['configprofilereport'] = 'Grade report used on user profile page.';
-$string['configshowpercentage'] = 'Whether to show the percentage value of each grade item.';
 $string['configshowquickfeedback'] = 'Quick Feedback adds a text input element in each grade cell on the grader report, allowing you to edit the feedback for many grades at once. You can then click the Update button to perform all these changes at once, instead of one at a time.';
 $string['configshowranges'] = 'Whether to show the range of grades for each column in an additional row.';
 $string['configshowrank'] = 'Whether to show the position of the user in relation to the rest of the class, for each grade item.';

lang/en/help/grade/showpercentage.html

@@ -1,2 +0,0 @@
-<h1>Show percentage</h1>
-<p>Whether to show the percentage value of each grade item.</p>