MDL-21695 Replaced grade/showrank.html

AMOS BEGIN
 MOV [configshowrank,core_grades],[showrank_help,core_grades]
 HLP grade/showrank.html,[showrank_help,core_grades]
AMOS END

grade/report/overview/lib.php

@@ -212,7 +212,7 @@ function grade_report_overview_settings_definition(&$mform) {
     }
 
     $mform->addElement('select', 'report_overview_showrank', get_string('showrank', 'grades'), $options);
-    $mform->setHelpButton('report_overview_showrank', array('showrank', get_string('showrank', 'grades'), 'grade'));
+    $mform->addHelpButton('report_overview_showrank', 'showrank');
 
     //showtotalsifcontainhidden
     $options = array(-1 => get_string('default', 'grades'),

grade/report/overview/settings.php

@@ -17,7 +17,7 @@
 
 /// Add settings for this module to the $settings object (it's already defined)
 
-$settings->add(new admin_setting_configcheckbox('grade_report_overview_showrank', get_string('showrank', 'grades'), get_string('configshowrank', 'grades'), 0, PARAM_INT));
+$settings->add(new admin_setting_configcheckbox('grade_report_overview_showrank', get_string('showrank', 'grades'), get_string('showrank_help', 'grades'), 0, PARAM_INT));
 
 $settings->add(new admin_setting_configselect('grade_report_overview_showtotalsifcontainhidden', get_string('hidetotalifhiddenitems', 'grades'),
                                                   get_string('hidetotalifhiddenitems_help', 'grades'), GRADE_REPORT_HIDE_TOTAL_IF_CONTAINS_HIDDEN,

grade/report/user/lib.php

@@ -440,7 +440,7 @@ function grade_report_user_settings_definition(&$mform) {
     }
 
     $mform->addElement('select', 'report_user_showrank', get_string('showrank', 'grades'), $options);
-    $mform->setHelpButton('report_user_showrank', array('showrank', get_string('showrank', 'grades'), 'grade'));
+    $mform->addHelpButton('report_user_showrank', 'showrank', 'grades');
 
     if (empty($CFG->grade_report_user_showpercentage)) {
         $options[-1] = get_string('defaultprev', 'grades', $options[0]);

grade/report/user/settings.php

@@ -17,7 +17,7 @@
 
 /// Add settings for this module to the $settings object (it's already defined)
 
-$settings->add(new admin_setting_configcheckbox('grade_report_user_showrank', get_string('showrank', 'grades'), get_string('configshowrank', 'grades'), 0, PARAM_INT));
+$settings->add(new admin_setting_configcheckbox('grade_report_user_showrank', get_string('showrank', 'grades'), get_string('showrank_help', 'grades'), 0, PARAM_INT));
 $settings->add(new admin_setting_configcheckbox('grade_report_user_showpercentage', get_string('showpercentage', 'grades'), get_string('showpercentage_help', 'grades'), 2, PARAM_INT));
 
 $options = array(0 => get_string('shownohidden', 'grades'),

lang/en/grades.php

@@ -129,7 +129,6 @@ $string['confighiddenasdate'] = 'If user can not see hidden grades show date of
 $string['confighideforcedsettings'] = 'Do not show forced settings in grading UI.';
 $string['configincludescalesinaggregation'] = 'You can change whether scales are to be included as numbers in all aggregated grades across all gradebooks in all courses. CAUTION: changing this setting will force all aggregated grades to be recalculated.';
 $string['configprofilereport'] = 'Grade report used on user profile page.';
-$string['configshowrank'] = 'Whether to show the position of the user in relation to the rest of the class, for each grade item.';
 $string['configshowuseridnumber'] = 'Whether to show user ID numbers in an additional column.';
 $string['configshowuserimage'] = 'Whether to show the user\'s profile image next to the name in the grader report.';
 $string['configstudentsperpage'] = 'The number of students to display per page in the grader report.';

lang/en/help/grade/showrank.html

@@ -1,2 +0,0 @@
-<h1>Show rank</h1>
-<p>Whether to show the position of the user in relation to the rest of the class, for each grade item.</p>