MDL-32899: Assignment upgrade tool fails to upgrade some online text submissions

This is a fix for onlinetext assignments with submissions that have feedback but no
actual submission (data1 and data2 are NULL)
This commit is contained in:
Damyon Wiese
2012-05-10 14:00:23 +08:00
committed by Dan Poltawski
parent 3388649065
commit d82bb44d74
@@ -310,6 +310,15 @@ class assign_submission_onlinetext extends assign_submission_plugin {
$onlinetextsubmission->submission = $submission->id;
$onlinetextsubmission->assignment = $this->assignment->get_instance()->id;
if ($onlinetextsubmission->onlinetext === null) {
$onlinetextsubmission->onlinetext = '';
}
if ($onlinetextsubmission->onlineformat === null) {
$onlinetextsubmission->onlineformat = editors_get_preferred_format();
}
if (!$DB->insert_record('assignsubmission_onlinetext', $onlinetextsubmission) > 0) {
$log .= get_string('couldnotconvertsubmission', 'mod_assign', $submission->userid);
return false;