From d82bb44d74b087ffedd8850d2b7347a331ef5ffe Mon Sep 17 00:00:00 2001 From: Damyon Wiese Date: Thu, 10 May 2012 12:07:49 +0800 Subject: [PATCH] MDL-32899: Assignment upgrade tool fails to upgrade some online text submissions This is a fix for onlinetext assignments with submissions that have feedback but no actual submission (data1 and data2 are NULL) --- mod/assign/submission/onlinetext/locallib.php | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/mod/assign/submission/onlinetext/locallib.php b/mod/assign/submission/onlinetext/locallib.php index 23ca0c775e0..dcaf0c5531a 100644 --- a/mod/assign/submission/onlinetext/locallib.php +++ b/mod/assign/submission/onlinetext/locallib.php @@ -310,6 +310,15 @@ class assign_submission_onlinetext extends assign_submission_plugin { $onlinetextsubmission->submission = $submission->id; $onlinetextsubmission->assignment = $this->assignment->get_instance()->id; + + if ($onlinetextsubmission->onlinetext === null) { + $onlinetextsubmission->onlinetext = ''; + } + + if ($onlinetextsubmission->onlineformat === null) { + $onlinetextsubmission->onlineformat = editors_get_preferred_format(); + } + if (!$DB->insert_record('assignsubmission_onlinetext', $onlinetextsubmission) > 0) { $log .= get_string('couldnotconvertsubmission', 'mod_assign', $submission->userid); return false;