MDL-69684 session_redis: Improve PHPUnit test

This commit is contained in:
Huong Nguyen
2024-08-26 10:52:26 +07:00
parent 1d501e682e
commit d585ad91b6
2 changed files with 4 additions and 3 deletions
+1 -1
View File
@@ -56,7 +56,7 @@ class redis extends handler implements SessionHandlerInterface {
/**
* Minimum version of the Redis extension required.
*/
private const REDIS_EXTENSION_MIN_VERSION = '2.2.4';
public const REDIS_EXTENSION_MIN_VERSION = '2.2.4';
/**
* Minimum version of the Redis extension required.
*/
+3 -2
View File
@@ -62,8 +62,9 @@ class session_redis_test extends \advanced_testcase {
$version = phpversion('Redis');
if (!$version) {
$this->markTestSkipped('Redis extension version missing');
} else if (version_compare($version, '2.0') <= 0) {
$this->markTestSkipped('Redis extension version must be at least 2.0: now running "' . $version . '"');
} else if (version_compare($version, \core\session\redis::REDIS_EXTENSION_MIN_VERSION) <= 0) {
$this->markTestSkipped('Redis extension version must be at least ' . \core\session\redis::REDIS_EXTENSION_MIN_VERSION .
': now running "' . $version . '"');
}
$this->resetAfterTest();