From d585ad91b67d03ba3b4ba5fa5defd55a24d6e4e5 Mon Sep 17 00:00:00 2001 From: Huong Nguyen Date: Mon, 26 Aug 2024 10:52:26 +0700 Subject: [PATCH] MDL-69684 session_redis: Improve PHPUnit test --- lib/classes/session/redis.php | 2 +- lib/tests/session_redis_test.php | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/classes/session/redis.php b/lib/classes/session/redis.php index 9c36ad507c3..bd69c3f3ee4 100644 --- a/lib/classes/session/redis.php +++ b/lib/classes/session/redis.php @@ -56,7 +56,7 @@ class redis extends handler implements SessionHandlerInterface { /** * Minimum version of the Redis extension required. */ - private const REDIS_EXTENSION_MIN_VERSION = '2.2.4'; + public const REDIS_EXTENSION_MIN_VERSION = '2.2.4'; /** * Minimum version of the Redis extension required. */ diff --git a/lib/tests/session_redis_test.php b/lib/tests/session_redis_test.php index acba4eeeb98..d86eefc04cf 100644 --- a/lib/tests/session_redis_test.php +++ b/lib/tests/session_redis_test.php @@ -62,8 +62,9 @@ class session_redis_test extends \advanced_testcase { $version = phpversion('Redis'); if (!$version) { $this->markTestSkipped('Redis extension version missing'); - } else if (version_compare($version, '2.0') <= 0) { - $this->markTestSkipped('Redis extension version must be at least 2.0: now running "' . $version . '"'); + } else if (version_compare($version, \core\session\redis::REDIS_EXTENSION_MIN_VERSION) <= 0) { + $this->markTestSkipped('Redis extension version must be at least ' . \core\session\redis::REDIS_EXTENSION_MIN_VERSION . + ': now running "' . $version . '"'); } $this->resetAfterTest();