L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-63408 core_message: remove no longer needed code

Browse Source 
We only allow the functionality of adding/removing
members on group conversations, which will never have
a conversation hash.
This commit is contained in:
Mark Nelson
2018-10-22 10:26:30 +08:00
parent 83e3a4fe26
commit cbf9e41c2d
1 changed files with 0 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files
message/classes/api.php
-28
View File
@@ -1798,21 +1798,7 @@ class api {
$members[] = $member;
}
$transaction = $DB->start_delegated_transaction();
$DB->insert_records('message_conversation_members', $members);
// Hash is usefull only for 1-to-1 convs, so we don't update null conversation hashes.
if (isset($conversation->convhash)) {
// Getting all conversation members to create a new hash.
$newuserids = array_values($DB->get_records_menu(
'message_conversation_members', ['conversationid' => $convid], 'id', 'id, userid')
);
$conversation->convhash = helper::get_conversation_hash($newuserids);
$DB->update_record('message_conversations', $conversation);
}
$transaction->allow_commit();
}
/**
@@ -1835,22 +1821,8 @@ class api {
list($useridcondition, $params) = $DB->get_in_or_equal($userids, SQL_PARAMS_NAMED);
$params['convid'] = $convid;
$transaction = $DB->start_delegated_transaction();
$DB->delete_records_select('message_conversation_members',
"conversationid = :convid AND userid $useridcondition", $params);
// Hash is usefull only for 1-to-1 convs, so we don't update null conversation hashes.
if (isset($conversation->convhash)) {
// Getting all conversation members to create a new hash.
$newuserids = array_values($DB->get_records_menu(
'message_conversation_members', ['conversationid' => $convid], 'id', 'id, userid')
);
$conversation->convhash = helper::get_conversation_hash($newuserids);
$DB->update_record('message_conversations', $conversation);
}
$transaction->allow_commit();
}
/**