From cbf9e41c2de34349d513e1899d51849093f02b13 Mon Sep 17 00:00:00 2001 From: Mark Nelson Date: Sat, 20 Oct 2018 16:55:22 +0800 Subject: [PATCH] MDL-63408 core_message: remove no longer needed code We only allow the functionality of adding/removing members on group conversations, which will never have a conversation hash. --- message/classes/api.php | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/message/classes/api.php b/message/classes/api.php index da02414af20..58e6a44f1d5 100644 --- a/message/classes/api.php +++ b/message/classes/api.php @@ -1798,21 +1798,7 @@ class api { $members[] = $member; } - $transaction = $DB->start_delegated_transaction(); - $DB->insert_records('message_conversation_members', $members); - - // Hash is usefull only for 1-to-1 convs, so we don't update null conversation hashes. - if (isset($conversation->convhash)) { - // Getting all conversation members to create a new hash. - $newuserids = array_values($DB->get_records_menu( - 'message_conversation_members', ['conversationid' => $convid], 'id', 'id, userid') - ); - - $conversation->convhash = helper::get_conversation_hash($newuserids); - $DB->update_record('message_conversations', $conversation); - } - $transaction->allow_commit(); } /** @@ -1835,22 +1821,8 @@ class api { list($useridcondition, $params) = $DB->get_in_or_equal($userids, SQL_PARAMS_NAMED); $params['convid'] = $convid; - $transaction = $DB->start_delegated_transaction(); - $DB->delete_records_select('message_conversation_members', "conversationid = :convid AND userid $useridcondition", $params); - - // Hash is usefull only for 1-to-1 convs, so we don't update null conversation hashes. - if (isset($conversation->convhash)) { - // Getting all conversation members to create a new hash. - $newuserids = array_values($DB->get_records_menu( - 'message_conversation_members', ['conversationid' => $convid], 'id', 'id, userid') - ); - - $conversation->convhash = helper::get_conversation_hash($newuserids); - $DB->update_record('message_conversations', $conversation); - } - $transaction->allow_commit(); } /**