MDL-61121 assign: Declare variables in the local scope

This commit is contained in:
Mihail Geshoski
2019-10-18 13:59:58 +08:00
parent 542e7b52f2
commit 84801cd656
+21 -21
View File
@@ -163,28 +163,28 @@ M.mod_assign.init_grading_options = function(Y) {
};
M.mod_assign.init_plugin_summary = function(Y, subtype, type, submissionid) {
suffix = subtype + '_' + type + '_' + submissionid;
classname = 'contract_' + suffix;
contract = Y.one('.' + classname);
var suffix = subtype + '_' + type + '_' + submissionid;
var classname = 'contract_' + suffix;
var contract = Y.one('.' + classname);
if (contract) {
contract.on('click', function(e) {
e.preventDefault();
link = e.target;
linkclasses = link.getAttribute('class').split(' ');
thissuffix = '';
for (i = 0; i < linkclasses.length; i++) {
var link = e.target;
var linkclasses = link.getAttribute('class').split(' ');
var thissuffix = '';
for (var i = 0; i < linkclasses.length; i++) {
classname = linkclasses[i];
if (classname.indexOf('contract_') == 0) {
thissuffix = classname.substr(9);
}
}
fullclassname = 'full_' + thissuffix;
full = Y.one('.' + fullclassname);
var fullclassname = 'full_' + thissuffix;
var full = Y.one('.' + fullclassname);
if (full) {
full.hide(false);
}
summaryclassname = 'summary_' + thissuffix;
summary = Y.one('.' + summaryclassname);
var summaryclassname = 'summary_' + thissuffix;
var summary = Y.one('.' + summaryclassname);
if (summary) {
summary.show(false);
summary.one('a.expand_' + thissuffix).focus();
@@ -192,9 +192,9 @@ M.mod_assign.init_plugin_summary = function(Y, subtype, type, submissionid) {
});
}
classname = 'expand_' + suffix;
expand = Y.one('.' + classname);
var expand = Y.one('.' + classname);
full = Y.one('.full_' + suffix);
var full = Y.one('.full_' + suffix);
if (full) {
full.hide(false);
full.toggleClass('hidefull');
@@ -202,21 +202,21 @@ M.mod_assign.init_plugin_summary = function(Y, subtype, type, submissionid) {
if (expand) {
expand.on('click', function(e) {
e.preventDefault();
link = e.target;
linkclasses = link.getAttribute('class').split(' ');
thissuffix = '';
for (i = 0; i < linkclasses.length; i++) {
var link = e.target;
var linkclasses = link.getAttribute('class').split(' ');
var thissuffix = '';
for (var i = 0; i < linkclasses.length; i++) {
classname = linkclasses[i];
if (classname.indexOf('expand_') == 0) {
thissuffix = classname.substr(7);
}
}
summaryclassname = 'summary_' + thissuffix;
summary = Y.one('.' + summaryclassname);
var summaryclassname = 'summary_' + thissuffix;
var summary = Y.one('.' + summaryclassname);
if (summary) {
summary.hide(false);
}
fullclassname = 'full_' + thissuffix;
var fullclassname = 'full_' + thissuffix;
full = Y.one('.' + fullclassname);
if (full) {
full.show(false);
@@ -224,4 +224,4 @@ M.mod_assign.init_plugin_summary = function(Y, subtype, type, submissionid) {
}
});
}
}
};