From 84801cd656d4cef9f35d968c05904eb92145a93a Mon Sep 17 00:00:00 2001
From: Mihail Geshoski <mihail@moodle.com>
Date: Fri, 18 Oct 2019 13:59:10 +0800
Subject: [PATCH] MDL-61121 assign: Declare variables in the local scope

---
 mod/assign/module.js | 42 +++++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/mod/assign/module.js b/mod/assign/module.js
index a44f7d00dd3..70a1d609c6a 100644
--- a/mod/assign/module.js
+++ b/mod/assign/module.js
@@ -163,28 +163,28 @@ M.mod_assign.init_grading_options = function(Y) {
 };
 
 M.mod_assign.init_plugin_summary = function(Y, subtype, type, submissionid) {
-    suffix = subtype + '_' + type + '_' + submissionid;
-    classname = 'contract_' + suffix;
-    contract = Y.one('.' + classname);
+    var suffix = subtype + '_' + type + '_' + submissionid;
+    var classname = 'contract_' + suffix;
+    var contract = Y.one('.' + classname);
     if (contract) {
         contract.on('click', function(e) {
             e.preventDefault();
-            link = e.target;
-            linkclasses = link.getAttribute('class').split(' ');
-            thissuffix = '';
-            for (i = 0; i < linkclasses.length; i++) {
+            var link = e.target;
+            var linkclasses = link.getAttribute('class').split(' ');
+            var thissuffix = '';
+            for (var i = 0; i < linkclasses.length; i++) {
                 classname = linkclasses[i];
                 if (classname.indexOf('contract_') == 0) {
                     thissuffix = classname.substr(9);
                 }
             }
-            fullclassname = 'full_' + thissuffix;
-            full = Y.one('.' + fullclassname);
+            var fullclassname = 'full_' + thissuffix;
+            var full = Y.one('.' + fullclassname);
             if (full) {
                 full.hide(false);
             }
-            summaryclassname = 'summary_' + thissuffix;
-            summary = Y.one('.' + summaryclassname);
+            var summaryclassname = 'summary_' + thissuffix;
+            var summary = Y.one('.' + summaryclassname);
             if (summary) {
                 summary.show(false);
                 summary.one('a.expand_' + thissuffix).focus();
@@ -192,9 +192,9 @@ M.mod_assign.init_plugin_summary = function(Y, subtype, type, submissionid) {
         });
     }
     classname = 'expand_' + suffix;
-    expand = Y.one('.' + classname);
+    var expand = Y.one('.' + classname);
 
-    full = Y.one('.full_' + suffix);
+    var full = Y.one('.full_' + suffix);
     if (full) {
         full.hide(false);
         full.toggleClass('hidefull');
@@ -202,21 +202,21 @@ M.mod_assign.init_plugin_summary = function(Y, subtype, type, submissionid) {
     if (expand) {
         expand.on('click', function(e) {
             e.preventDefault();
-            link = e.target;
-            linkclasses = link.getAttribute('class').split(' ');
-            thissuffix = '';
-            for (i = 0; i < linkclasses.length; i++) {
+            var link = e.target;
+            var linkclasses = link.getAttribute('class').split(' ');
+            var thissuffix = '';
+            for (var i = 0; i < linkclasses.length; i++) {
                 classname = linkclasses[i];
                 if (classname.indexOf('expand_') == 0) {
                     thissuffix = classname.substr(7);
                 }
             }
-            summaryclassname = 'summary_' + thissuffix;
-            summary = Y.one('.' + summaryclassname);
+            var summaryclassname = 'summary_' + thissuffix;
+            var summary = Y.one('.' + summaryclassname);
             if (summary) {
                 summary.hide(false);
             }
-            fullclassname = 'full_' + thissuffix;
+            var fullclassname = 'full_' + thissuffix;
             full = Y.one('.' + fullclassname);
             if (full) {
                 full.show(false);
@@ -224,4 +224,4 @@ M.mod_assign.init_plugin_summary = function(Y, subtype, type, submissionid) {
             }
         });
     }
-}
+};