L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-60653 Navigation: Fixed loose string comparison.

Browse Source 
The previous comparison would sometimes evaluate to true when the
navigation key was not a string.
This commit is contained in:
Tyler Bannister
2017-12-12 12:34:57 +08:00
committed by Shamim Rezaie
parent 1bc5a5abe9
commit 74af3b176d
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/navigationlib.php
+1 -1
View File
@@ -434,7 +434,7 @@ class navigation_node implements renderable {
public function build_flat_navigation_list(flat_navigation $nodes, $showdivider = false) {
if ($this->showinflatnavigation) {
$indent = 0;
if ($this->type == self::TYPE_COURSE || $this->key == self::COURSE_INDEX_PAGE) {
if ($this->type == self::TYPE_COURSE || $this->key === self::COURSE_INDEX_PAGE) {
$indent = 1;
}
$flat = new flat_navigation_node($this, $indent);