From 74af3b176d8534045cb73b824c5aaa8568bb366a Mon Sep 17 00:00:00 2001 From: Tyler Bannister Date: Wed, 1 Nov 2017 13:24:06 -0400 Subject: [PATCH] MDL-60653 Navigation: Fixed loose string comparison. The previous comparison would sometimes evaluate to true when the navigation key was not a string. --- lib/navigationlib.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/navigationlib.php b/lib/navigationlib.php index 7c46fc357f5..ca6b2cb8251 100644 --- a/lib/navigationlib.php +++ b/lib/navigationlib.php @@ -434,7 +434,7 @@ class navigation_node implements renderable { public function build_flat_navigation_list(flat_navigation $nodes, $showdivider = false) { if ($this->showinflatnavigation) { $indent = 0; - if ($this->type == self::TYPE_COURSE || $this->key == self::COURSE_INDEX_PAGE) { + if ($this->type == self::TYPE_COURSE || $this->key === self::COURSE_INDEX_PAGE) { $indent = 1; } $flat = new flat_navigation_node($this, $indent);