MDL-83235 qbank_columnsortorder: correct config retrieval ordering.

There is a unique index on plugin/name, so having a trailing order
clause on value would produce no effect. We also cannot order by
CLOB fields on Oracle, lest it complain loudly.
This commit is contained in:
Paul Holden
2024-09-23 08:56:38 +01:00
parent 11fc78ed62
commit 6865cf828b
+1 -1
View File
@@ -39,7 +39,7 @@ function xmldb_qbank_columnsortorder_upgrade(int $oldversion): bool {
// In Moodle 4.3, the values are stored as qbank_statistics\columns\discriminative_efficiency-discriminative_efficiency.
// So updating the old values to match the new format.
// Update the columns records for qbank_columnsortorder plugin.
$pluginconfigs = $DB->get_records('config_plugins', ['plugin' => 'qbank_columnsortorder'], 'name, value');
$pluginconfigs = $DB->get_records('config_plugins', ['plugin' => 'qbank_columnsortorder'], 'name');
foreach ($pluginconfigs as $config) {
if ($config->name == 'version') {