From 6865cf828ba82f7a82282bc5de8015d4364cb6a7 Mon Sep 17 00:00:00 2001 From: Paul Holden Date: Mon, 23 Sep 2024 08:51:05 +0100 Subject: [PATCH] MDL-83235 qbank_columnsortorder: correct config retrieval ordering. There is a unique index on plugin/name, so having a trailing order clause on value would produce no effect. We also cannot order by CLOB fields on Oracle, lest it complain loudly. --- question/bank/columnsortorder/db/upgrade.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/question/bank/columnsortorder/db/upgrade.php b/question/bank/columnsortorder/db/upgrade.php index eea69272092..0d540bb4bdf 100644 --- a/question/bank/columnsortorder/db/upgrade.php +++ b/question/bank/columnsortorder/db/upgrade.php @@ -39,7 +39,7 @@ function xmldb_qbank_columnsortorder_upgrade(int $oldversion): bool { // In Moodle 4.3, the values are stored as qbank_statistics\columns\discriminative_efficiency-discriminative_efficiency. // So updating the old values to match the new format. // Update the columns records for qbank_columnsortorder plugin. - $pluginconfigs = $DB->get_records('config_plugins', ['plugin' => 'qbank_columnsortorder'], 'name, value'); + $pluginconfigs = $DB->get_records('config_plugins', ['plugin' => 'qbank_columnsortorder'], 'name'); foreach ($pluginconfigs as $config) { if ($config->name == 'version') {