Rating MDL-22270 Prevented fetching of ratings when ratings are turned off

2010-05-03 02:00:33 +00:00
parent 4b3176d1e6
commit 54bc6de2eb
1 changed files with 6 additions and 2 deletions
@@ -241,6 +241,12 @@ class rating_manager {
    public function get_ratings($options) {
        global $DB, $USER, $PAGE, $CFG;

+        //are ratings enabled?
+        if ($options->aggregate==RATING_AGGREGATE_NONE) {
+            return $options->items;
+        }
+        $aggregatestr = $this->get_aggregation_method($options->aggregate);
+
        if(empty($options->items)) {
            return $options->items;
        }
@@ -251,8 +257,6 @@ class rating_manager {
            $userid = $options->userid;
        }

-        $aggregatestr = $this->get_aggregation_method($options->aggregate);
-
        //create an array of item ids
        $itemids = array();
        foreach($options->items as $item) {