From 54bc6de2ebf3f4199690f4f55efd4978e3097b2d Mon Sep 17 00:00:00 2001 From: Andrew Davis Date: Mon, 3 May 2010 02:00:33 +0000 Subject: [PATCH] Rating MDL-22270 Prevented fetching of ratings when ratings are turned off --- rating/lib.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/rating/lib.php b/rating/lib.php index cad11760105..8a01d51f858 100644 --- a/rating/lib.php +++ b/rating/lib.php @@ -241,6 +241,12 @@ class rating_manager { public function get_ratings($options) { global $DB, $USER, $PAGE, $CFG; + //are ratings enabled? + if ($options->aggregate==RATING_AGGREGATE_NONE) { + return $options->items; + } + $aggregatestr = $this->get_aggregation_method($options->aggregate); + if(empty($options->items)) { return $options->items; } @@ -251,8 +257,6 @@ class rating_manager { $userid = $options->userid; } - $aggregatestr = $this->get_aggregation_method($options->aggregate); - //create an array of item ids $itemids = array(); foreach($options->items as $item) {