MDL-30652 SCORM Fixing report prefrences display issue for basic report

2012-01-03 10:38:37 +05:30
parent e12459baa2
commit 2af0e47259
1 changed files with 6 additions and 5 deletions
@@ -519,17 +519,18 @@ class scorm_basic_report extends scorm_default_report {
                        echo '</tr></table>';
                    }
                }
-                if (!$download) {
-                    $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode'));
-                    $mform->display();
-                }
            } else {
                if ($candelete && !$download) {
                    echo '</div>';
                    echo '</form>';
+                    $table->finish_output();
                }
                echo '</div>';
-                echo $OUTPUT->notification(get_string('noactivity', 'scorm'));
+            }
+            // Show preferences form irrespective of attempts are there to report or not
+            if (!$download) {
+                $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode'));
+                $mform->display();
            }
            if ($download == 'Excel' or $download == 'ODS') {
                $workbook->close();