From 2af0e47259bd962cb667b0e8e72aa58f2aeff8cf Mon Sep 17 00:00:00 2001
From: Ankit Kumar Agarwal <ankit@moodle.com>
Date: Fri, 16 Dec 2011 13:26:00 +0530
Subject: [PATCH] MDL-30652 SCORM Fixing report prefrences display issue for
 basic report

---
 mod/scorm/report/basic/report.php | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/mod/scorm/report/basic/report.php b/mod/scorm/report/basic/report.php
index 032f0dd7f77..a201cd444eb 100644
--- a/mod/scorm/report/basic/report.php
+++ b/mod/scorm/report/basic/report.php
@@ -519,17 +519,18 @@ class scorm_basic_report extends scorm_default_report {
                         echo '</tr></table>';
                     }
                 }
-                if (!$download) {
-                    $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode'));
-                    $mform->display();
-                }
             } else {
                 if ($candelete && !$download) {
                     echo '</div>';
                     echo '</form>';
+                    $table->finish_output();
                 }
                 echo '</div>';
-                echo $OUTPUT->notification(get_string('noactivity', 'scorm'));
+            }
+            // Show preferences form irrespective of attempts are there to report or not
+            if (!$download) {
+                $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode'));
+                $mform->display();
             }
             if ($download == 'Excel' or $download == 'ODS') {
                 $workbook->close();