L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-80488 mod_lesson: avoid overflowing length of page titles.

Browse Source
This commit is contained in:
Paul Holden
2024-03-20 23:51:12 +00:00
parent 39b8e198ff
commit 16b73bf993
5 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/lesson/locallib.php
+2 -1
View File
@@ -1355,8 +1355,9 @@ abstract class lesson_add_page_form_base extends moodleform {
$mform->addElement('hidden', 'qtype');
$mform->setType('qtype', PARAM_INT);
$mform->addElement('text', 'title', get_string('pagetitle', 'lesson'), array('size'=>70));
$mform->addElement('text', 'title', get_string('pagetitle', 'lesson'), ['size' => 70, 'maxlength' => 255]);
$mform->addRule('title', get_string('required'), 'required', null, 'client');
$mform->addRule('title', get_string('maximumchars', '', 255), 'maxlength', 255, 'client');
if (!empty($CFG->formatstringstriptags)) {
$mform->setType('title', PARAM_TEXT);
} else {
mod/lesson/pagetypes/branchtable.php
+3 -2
View File
@@ -339,8 +339,9 @@ class lesson_add_page_form_branchtable extends lesson_add_page_form_base {
$mform->addElement('hidden', 'qtype');
$mform->setType('qtype', PARAM_INT);
$mform->addElement('text', 'title', get_string("pagetitle", "lesson"), array('size'=>70));
$mform->addRule('title', null, 'required', null, 'server');
$mform->addElement('text', 'title', get_string("pagetitle", "lesson"), ['size' => 70, 'maxlength' => 255]);
$mform->addRule('title', null, 'required', null, 'client');
$mform->addRule('title', get_string('maximumchars', '', 255), 'maxlength', 255, 'client');
if (!empty($CFG->formatstringstriptags)) {
$mform->setType('title', PARAM_TEXT);
} else {
mod/lesson/pagetypes/cluster.php
+2 -1
View File
@@ -131,7 +131,8 @@ class lesson_add_page_form_cluster extends lesson_add_page_form_base {
$mform->addElement('hidden', 'qtype');
$mform->setType('qtype', PARAM_TEXT);
$mform->addElement('text', 'title', get_string("pagetitle", "lesson"), array('size'=>70));
$mform->addElement('text', 'title', get_string("pagetitle", "lesson"), ['size' => 70, 'maxlength' => 255]);
$mform->addRule('title', get_string('maximumchars', '', 255), 'maxlength', 255, 'client');
if (!empty($CFG->formatstringstriptags)) {
$mform->setType('title', PARAM_TEXT);
} else {
mod/lesson/pagetypes/endofbranch.php
+2 -1
View File
@@ -159,7 +159,8 @@ class lesson_add_page_form_endofbranch extends lesson_add_page_form_base {
$mform->addElement('hidden', 'qtype');
$mform->setType('qtype', PARAM_TEXT);
$mform->addElement('text', 'title', get_string("pagetitle", "lesson"), array('size'=>70));
$mform->addElement('text', 'title', get_string("pagetitle", "lesson"), ['size' => 70, 'maxlength' => 255]);
$mform->addRule('title', get_string('maximumchars', '', 255), 'maxlength', 255, 'client');
if (!empty($CFG->formatstringstriptags)) {
$mform->setType('title', PARAM_TEXT);
} else {
mod/lesson/pagetypes/endofcluster.php
+2 -1
View File
@@ -139,7 +139,8 @@ class lesson_add_page_form_endofcluster extends lesson_add_page_form_base {
$mform->addElement('hidden', 'qtype');
$mform->setType('qtype', PARAM_TEXT);
$mform->addElement('text', 'title', get_string("pagetitle", "lesson"), array('size'=>70));
$mform->addElement('text', 'title', get_string("pagetitle", "lesson"), ['size' => 70, 'maxlength' => 255]);
$mform->addRule('title', get_string('maximumchars', '', 255), 'maxlength', 255, 'client');
if (!empty($CFG->formatstringstriptags)) {
$mform->setType('title', PARAM_TEXT);
} else {