From 16b73bf993f3440c68a40464815452fe222d56f3 Mon Sep 17 00:00:00 2001
From: Paul Holden <paulh@moodle.com>
Date: Thu, 4 Jan 2024 15:07:03 +0000
Subject: [PATCH] MDL-80488 mod_lesson: avoid overflowing length of page
 titles.

---
 mod/lesson/locallib.php               | 3 ++-
 mod/lesson/pagetypes/branchtable.php  | 5 +++--
 mod/lesson/pagetypes/cluster.php      | 3 ++-
 mod/lesson/pagetypes/endofbranch.php  | 3 ++-
 mod/lesson/pagetypes/endofcluster.php | 3 ++-
 5 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/mod/lesson/locallib.php b/mod/lesson/locallib.php
index a780601b4e5..238e2ddddbd 100644
--- a/mod/lesson/locallib.php
+++ b/mod/lesson/locallib.php
@@ -1355,8 +1355,9 @@ abstract class lesson_add_page_form_base extends moodleform {
             $mform->addElement('hidden', 'qtype');
             $mform->setType('qtype', PARAM_INT);
 
-            $mform->addElement('text', 'title', get_string('pagetitle', 'lesson'), array('size'=>70));
+            $mform->addElement('text', 'title', get_string('pagetitle', 'lesson'), ['size' => 70, 'maxlength' => 255]);
             $mform->addRule('title', get_string('required'), 'required', null, 'client');
+            $mform->addRule('title', get_string('maximumchars', '', 255), 'maxlength', 255, 'client');
             if (!empty($CFG->formatstringstriptags)) {
                 $mform->setType('title', PARAM_TEXT);
             } else {
diff --git a/mod/lesson/pagetypes/branchtable.php b/mod/lesson/pagetypes/branchtable.php
index 7ce0f2c8d1f..6f0f5155d59 100644
--- a/mod/lesson/pagetypes/branchtable.php
+++ b/mod/lesson/pagetypes/branchtable.php
@@ -339,8 +339,9 @@ class lesson_add_page_form_branchtable extends lesson_add_page_form_base {
         $mform->addElement('hidden', 'qtype');
         $mform->setType('qtype', PARAM_INT);
 
-        $mform->addElement('text', 'title', get_string("pagetitle", "lesson"), array('size'=>70));
-        $mform->addRule('title', null, 'required', null, 'server');
+        $mform->addElement('text', 'title', get_string("pagetitle", "lesson"), ['size' => 70, 'maxlength' => 255]);
+        $mform->addRule('title', null, 'required', null, 'client');
+        $mform->addRule('title', get_string('maximumchars', '', 255), 'maxlength', 255, 'client');
         if (!empty($CFG->formatstringstriptags)) {
             $mform->setType('title', PARAM_TEXT);
         } else {
diff --git a/mod/lesson/pagetypes/cluster.php b/mod/lesson/pagetypes/cluster.php
index 74948d04730..d3a315cd4e0 100644
--- a/mod/lesson/pagetypes/cluster.php
+++ b/mod/lesson/pagetypes/cluster.php
@@ -131,7 +131,8 @@ class lesson_add_page_form_cluster extends lesson_add_page_form_base {
         $mform->addElement('hidden', 'qtype');
         $mform->setType('qtype', PARAM_TEXT);
 
-        $mform->addElement('text', 'title', get_string("pagetitle", "lesson"), array('size'=>70));
+        $mform->addElement('text', 'title', get_string("pagetitle", "lesson"), ['size' => 70, 'maxlength' => 255]);
+        $mform->addRule('title', get_string('maximumchars', '', 255), 'maxlength', 255, 'client');
         if (!empty($CFG->formatstringstriptags)) {
             $mform->setType('title', PARAM_TEXT);
         } else {
diff --git a/mod/lesson/pagetypes/endofbranch.php b/mod/lesson/pagetypes/endofbranch.php
index dc5409cee79..c8974a4dfd0 100644
--- a/mod/lesson/pagetypes/endofbranch.php
+++ b/mod/lesson/pagetypes/endofbranch.php
@@ -159,7 +159,8 @@ class lesson_add_page_form_endofbranch extends lesson_add_page_form_base {
         $mform->addElement('hidden', 'qtype');
         $mform->setType('qtype', PARAM_TEXT);
 
-        $mform->addElement('text', 'title', get_string("pagetitle", "lesson"), array('size'=>70));
+        $mform->addElement('text', 'title', get_string("pagetitle", "lesson"), ['size' => 70, 'maxlength' => 255]);
+        $mform->addRule('title', get_string('maximumchars', '', 255), 'maxlength', 255, 'client');
         if (!empty($CFG->formatstringstriptags)) {
             $mform->setType('title', PARAM_TEXT);
         } else {
diff --git a/mod/lesson/pagetypes/endofcluster.php b/mod/lesson/pagetypes/endofcluster.php
index 05050139565..ba493535c02 100644
--- a/mod/lesson/pagetypes/endofcluster.php
+++ b/mod/lesson/pagetypes/endofcluster.php
@@ -139,7 +139,8 @@ class lesson_add_page_form_endofcluster extends lesson_add_page_form_base {
         $mform->addElement('hidden', 'qtype');
         $mform->setType('qtype', PARAM_TEXT);
 
-        $mform->addElement('text', 'title', get_string("pagetitle", "lesson"), array('size'=>70));
+        $mform->addElement('text', 'title', get_string("pagetitle", "lesson"), ['size' => 70, 'maxlength' => 255]);
+        $mform->addRule('title', get_string('maximumchars', '', 255), 'maxlength', 255, 'client');
         if (!empty($CFG->formatstringstriptags)) {
             $mform->setType('title', PARAM_TEXT);
         } else {