Freenove source-of-truth sync (story/ui/audio/hotline) #111
Reference in New Issue
Block a user
Delete Branch "codex/freenove-source-of-truth-20260227"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Scope\n- Push current source-of-truth state requested in session\n- Includes Freenove story/UI LGFX text and scene flow updates\n- Includes LA detector/hourglass and U_SON audio behavior updates\n\n## Validation\n- PLATFORMIO_BUILD_DIR=/tmp/pio_build_zacus pio run -e freenove_esp32s3_full_with_ui\n\n## Notes\n- Branch created from detached HEAD state after clearing in-progress rebase metadata () to unblock push.\n
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:
fc5f23a61eℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
@@ -77,0 +80,4 @@-<ui_freenove_allinone/src/hardware_manager.cpp>-<ui_freenove_allinone/src/network_manager.cpp>-<ui_freenove_allinone/src/media_manager.cpp>+<../libs/story/src/core/scenario_def.cpp>This environment hardcodes a single macOS device path for both upload and monitor. Any developer/CI host that does not expose
/dev/cu.usbmodem5AB907*(Linux, Windows, or a different USB ID) will fail-t upload/monitor workflows unless they edit committed config locally, which breaks reproducible shared tooling forfreenove_esp32s3_full_with_ui.Useful? React with 👍 / 👎.
@@ -35,3 +36,4 @@StepExpect("SC_EVENT button ANY", "SCENE_LEFOU_DETECTOR", "SCENE_LEFOU_DETECTOR"),)The updated smoke sequence no longer matches the DEFAULT scenario definition shipped in this same commit:
RTC_ESP_ETAPE1now usesscreen_scene_id: SCENE_WIN_ETAPEand onlyespnowtransitions (ACK_WIN1/ACK_WIN2), but this check still expectsSCENE_WIN_ETAPE1and drivesSC_EVENT serial FORCE_DONE. Runningverify_story_default_flow.pyagainst current content will therefore fail deterministically in the middle of the flow, producing a false regression signal instead of validating runtime behavior.Useful? React with 👍 / 👎.