electron-rare/kicad-source-mirror
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix out of bounds crash in SHAPE_LINE_CHAIN::splitArc

Browse Source 
Check that the index references a point that is part of an arc
This commit is contained in:
Roberto Fernandez Bautista
2021-07-05 20:29:24 +01:00
parent f6aaaff81a
commit 72435c78af
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libs/kimath/src/geometry/shape_line_chain.cpp
+2 -2
View File
@@ -532,12 +532,12 @@ void SHAPE_LINE_CHAIN::Remove( int aStartIndex, int aEndIndex )
aEndIndex = std::min( aEndIndex, PointCount() - 1 );
// Split arcs at start index and end just after the end index
if( aStartIndex < m_points.size() && m_shapes[aStartIndex] != SHAPES_ARE_PT )
if( IsPtOnArc( aStartIndex ) )
splitArc( aStartIndex );
size_t nextIndex = static_cast<size_t>( aEndIndex ) + 1;
if( nextIndex < m_points.size() && m_shapes[aEndIndex] != SHAPES_ARE_PT )
if( IsPtOnArc( nextIndex ) )
splitArc( nextIndex );
std::set<size_t> extra_arcs;