Fix Wmismatched-tags, Wreorder-ctor, and Wunneeded-internal-declaration warnings

pcbnew/connectivity/topo_match.cpp

@@ -991,8 +991,9 @@ int main()
 
 COMPONENT::COMPONENT( const wxString& aRef, FOOTPRINT* aParentFp,
                       std::optional<VECTOR2I> aRaOffset ) :
+        m_raOffset( aRaOffset ),
         m_reference( aRef ),
-        m_parentFootprint( aParentFp ), m_raOffset( aRaOffset )
+        m_parentFootprint( aParentFp )
 {
     m_prefix = UTIL::GetRefDesPrefix( aRef );
 }

pcbnew/pcb_io/allegro/convert/allegro_db.h

@@ -39,7 +39,7 @@ namespace ALLEGRO
 {
 
 class BLOCK_BASE;
-class DB_OBJ;
+struct DB_OBJ;
 class DB_OBJ_RESOLVER;
 
 
@@ -318,7 +318,7 @@ public:
 };
 
 
-struct BRD_DB;
+class BRD_DB;
 struct COMPONENT;
 struct COMPONENT_INST;
 struct FOOTPRINT_INSTANCE;

pcbnew/pcb_io/cadstar/cadstar_pcb_archive_parser.h

@@ -43,8 +43,9 @@ class CADSTAR_PCB_ARCHIVE_PARSER : public CADSTAR_ARCHIVE_PARSER
 {
 public:
     explicit CADSTAR_PCB_ARCHIVE_PARSER( const wxString& aFilename ) :
+            CADSTAR_ARCHIVE_PARSER(),
             Filename( aFilename ), Header(), Assignments(),
-            m_rootNode( nullptr ), CADSTAR_ARCHIVE_PARSER()
+            m_rootNode( nullptr )
     {
         KiCadUnitMultiplier = 10; // assume hundredth micron
     }

pcbnew/router/pns_logger.h

@@ -62,8 +62,8 @@ public:
         int layer;
 
         EVENT_ENTRY() :
-                layer( 0 ),
-                type( EVT_START_ROUTE )
+                type( EVT_START_ROUTE ),
+                layer( 0 )
         {
         }
 

pcbnew/router/router_preview_item.cpp

@@ -42,8 +42,8 @@ using namespace KIGFX;
 ROUTER_PREVIEW_ITEM::ROUTER_PREVIEW_ITEM( const PNS::ITEM* aItem, PNS::ROUTER_IFACE* aIface,
                                           KIGFX::VIEW* aView, int aFlags ) :
         EDA_ITEM( NOT_USED ),
-        m_iface( aIface ),
         m_view( aView ),
+        m_iface( aIface ),
         m_shape( nullptr ),
         m_hole( nullptr ),
         m_flags( aFlags )
@@ -91,8 +91,8 @@ ROUTER_PREVIEW_ITEM::ROUTER_PREVIEW_ITEM( const PNS::ITEM* aItem, PNS::ROUTER_IF
 ROUTER_PREVIEW_ITEM::ROUTER_PREVIEW_ITEM( const SHAPE& aShape, PNS::ROUTER_IFACE* aIface,
                                           KIGFX::VIEW* aView ) :
         EDA_ITEM( NOT_USED ),
-        m_iface( aIface ),
         m_view( aView ),
+        m_iface( aIface ),
         m_flags( 0 )
 {
     m_shape = aShape.Clone();

thirdparty/compoundfilereader/utf.h

@@ -49,7 +49,7 @@ static bool GetNextCodePointFromUTF16(const T* u16, size_t len, size_t* pos, uin
     return true;
 }
 
-static int CodePointToUTF8(uint32_t cp, uint32_t* c1, uint32_t* c2, uint32_t* c3, uint32_t* c4)
+static inline int CodePointToUTF8(uint32_t cp, uint32_t* c1, uint32_t* c2, uint32_t* c3, uint32_t* c4)
 {
     if (cp < 0x80)
     {