fix: remove silent instance_meta override for single-node placements
All combinations of sharding (Pipeline/Tensor) and instance type (MlxRing/MlxJaccl) are equivalent and valid for n=1, so there is no reason to override the user's selection. Removing the override also fixes the preview type mismatch reported in #1426. Supersedes #1509. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This commit is contained in:
co-authored by
Claude Opus 4.6
parent
7312c535b4
commit
c1ce541901
@@ -138,9 +138,6 @@ def place_instance(
|
||||
instance_id = InstanceId()
|
||||
target_instances = dict(deepcopy(current_instances))
|
||||
|
||||
if len(selected_cycle) == 1:
|
||||
command.instance_meta = InstanceMeta.MlxRing
|
||||
|
||||
match command.instance_meta:
|
||||
case InstanceMeta.MlxJaccl:
|
||||
# TODO(evan): shard assignments should contain information about ranks, this is ugly
|
||||
|
||||
Reference in New Issue
Block a user