Esp32_RTC_ZACUS #27

2026-02-23T20:34:55Z

electron-rare commented

2026-02-23 20:34:55 +00:00

(Migrated from github.com)

No description provided.

chatgpt-codex-connector[bot] (Migrated from github.com) reviewed 2026-02-23 20:39:25 +00:00

chatgpt-codex-connector[bot] (Migrated from github.com) left a comment

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: efeacb79f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

### 💡 Codex Review Here are some automated review suggestions for this pull request. **Reviewed commit:** `efeacb79f8` <details> <summary>ℹ️ About Codex in GitHub</summary> [Your team has set up Codex to review pull requests in this repo](http://chatgpt.com/codex/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details>

src/audio/AudioEngine.cpp

						
				@@ -148,3 +193,2 @@

				        ensureDialToneWav();

				    }

				    stopPlaybackFile();

				    startTask();

chatgpt-codex-connector[bot] (Migrated from github.com) commented

2026-02-23 20:39:25 +00:00

Allow SD mount retry after initial failure

ensureSdMounted() latches the first attempt result and never retries once sd_mount_attempted_ is true. If the first mount occurs while no card is inserted (or mount transiently fails), later PLAY attempts continue to fail permanently even after inserting a card, because the code always returns the cached false value until reboot.

Useful? React with 👍 / 👎.

**![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat) Allow SD mount retry after initial failure** `ensureSdMounted()` latches the first attempt result and never retries once `sd_mount_attempted_` is true. If the first mount occurs while no card is inserted (or mount transiently fails), later `PLAY` attempts continue to fail permanently even after inserting a card, because the code always returns the cached false value until reboot. Useful? React with 👍 / 👎.

src/main.cpp

chatgpt-codex-connector[bot] (Migrated from github.com) commented

2026-02-23 20:39:25 +00:00

Mount SD before replying to STORY_REFRESH_SD

STORY_REFRESH_SD currently just returns g_audio.isSdReady() and never triggers any mount/refresh logic. Since sd_ready_ stays false until playFile() calls ensureSdMounted(), this command reports failure on a normal boot even when a valid SD card is present, so clients cannot actually use it to refresh/check media availability before playback.

Useful? React with 👍 / 👎.

**![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat) Mount SD before replying to STORY_REFRESH_SD** `STORY_REFRESH_SD` currently just returns `g_audio.isSdReady()` and never triggers any mount/refresh logic. Since `sd_ready_` stays false until `playFile()` calls `ensureSdMounted()`, this command reports failure on a normal boot even when a valid SD card is present, so clients cannot actually use it to refresh/check media availability before playback. Useful? React with 👍 / 👎.

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: electron-rare/RTC_BL_PHONE#27