electron-rare/RTC_BL_PHONE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Esp32_RTC_ZACUS #27

Closed
electron-rare wants to merge 2 commits from esp32_RTC_ZACUS into main
pull from: esp32_RTC_ZACUS
merge into: electron-rare:main
Conversation 1 Commits 2 Files Changed 9
+519 -662
electron-rare commented 2026-02-23 20:34:55 +00:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
chatgpt-codex-connector[bot] (Migrated from github.com) reviewed 2026-02-23 20:39:25 +00:00
chatgpt-codex-connector[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: efeacb79f8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

### 💡 Codex Review Here are some automated review suggestions for this pull request. **Reviewed commit:** `efeacb79f8` <details> <summary>ℹ️ About Codex in GitHub</summary> <br/> [Your team has set up Codex to review pull requests in this repo](http://chatgpt.com/codex/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details>
src/audio/AudioEngine.cpp
@@ -148,3 +193,2 @@
ensureDialToneWav();
}
stopPlaybackFile();
startTask();
chatgpt-codex-connector[bot] (Migrated from github.com) commented 2026-02-23 20:39:25 +00:00
Copy Link
Copy Source

P1 Badge Allow SD mount retry after initial failure

ensureSdMounted() latches the first attempt result and never retries once sd_mount_attempted_ is true. If the first mount occurs while no card is inserted (or mount transiently fails), later PLAY attempts continue to fail permanently even after inserting a card, because the code always returns the cached false value until reboot.

Useful? React with 👍 / 👎.

**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Allow SD mount retry after initial failure** `ensureSdMounted()` latches the first attempt result and never retries once `sd_mount_attempted_` is true. If the first mount occurs while no card is inserted (or mount transiently fails), later `PLAY` attempts continue to fail permanently even after inserting a card, because the code always returns the cached false value until reboot. Useful? React with 👍 / 👎.
src/main.cpp
chatgpt-codex-connector[bot] (Migrated from github.com) commented 2026-02-23 20:39:25 +00:00
Copy Link
Copy Source

P2 Badge Mount SD before replying to STORY_REFRESH_SD

STORY_REFRESH_SD currently just returns g_audio.isSdReady() and never triggers any mount/refresh logic. Since sd_ready_ stays false until playFile() calls ensureSdMounted(), this command reports failure on a normal boot even when a valid SD card is present, so clients cannot actually use it to refresh/check media availability before playback.

Useful? React with 👍 / 👎.

**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Mount SD before replying to STORY_REFRESH_SD** `STORY_REFRESH_SD` currently just returns `g_audio.isSdReady()` and never triggers any mount/refresh logic. Since `sd_ready_` stays false until `playFile()` calls `ensureSdMounted()`, this command reports failure on a normal boot even when a valid SD card is present, so clients cannot actually use it to refresh/check media availability before playback. Useful? React with 👍 / 👎.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
chatgpt-codex-connector[bot]
Labels
Clear labels
bug
Something isn't working
 codex
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
electron (Clément Saillant)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: electron-rare/RTC_BL_PHONE#27
Delete Branch "esp32_RTC_ZACUS"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?