electron-rare/Kill_LIFE
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(specs): sync ai-agentic embedded spec_kit state #13

Merged
electron-rare merged 1 commits from codex/agentic-credit-local-optimization into main 2026-02-21 18:44:56 +00:00
Conversation 1 Commits 1 Files Changed 2
+206 -127
electron-rare commented 2026-02-21 18:44:13 +00:00 (Migrated from github.com)
Copy Link
Copy Source

watcher 1min + realtime log

  • No runtime script changes in this PR (already in earlier merges).
  • This PR only aligns spec_kit with operational specs.

spec_kit sync

  • Updated ai-agentic-embedded-base/specs/04_tasks.md
  • Updated ai-agentic-embedded-base/specs/zeroclaw_dual_hw_todo.md

Validation context

  • bash -n + shellcheck on watcher/stack/webhook/chat scripts already green.
  • Endpoint smoke pass in this environment: 3000/health, 8788/, 8788/realtime_1min.log, 9090/-/ready.
## watcher 1min + realtime log - No runtime script changes in this PR (already in earlier merges). - This PR only aligns spec_kit with operational specs. ## spec_kit sync - Updated `ai-agentic-embedded-base/specs/04_tasks.md` - Updated `ai-agentic-embedded-base/specs/zeroclaw_dual_hw_todo.md` ## Validation context - `bash -n` + `shellcheck` on watcher/stack/webhook/chat scripts already green. - Endpoint smoke pass in this environment: `3000/health`, `8788/`, `8788/realtime_1min.log`, `9090/-/ready`.
chatgpt-codex-connector[bot] (Migrated from github.com) reviewed 2026-02-21 18:46:36 +00:00
chatgpt-codex-connector[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0d67307c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

### 💡 Codex Review Here are some automated review suggestions for this pull request. **Reviewed commit:** `d0d67307c2` <details> <summary>ℹ️ About Codex in GitHub</summary> <br/> [Your team has set up Codex to review pull requests in this repo](http://chatgpt.com/codex/settings/general). Reviews are triggered when you - Open a pull request for review - Mark a draft as ready - Comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". </details>
ai-agentic-embedded-base/specs/04_tasks.md
@@ -29,0 +66,4 @@
- Status: `2026-02-21` done.
- [x] T-103 - Upload + monitor RTC (forced default)
- AC: `pio run -e esp32dev -t upload` puis monitor 60s executes.
chatgpt-codex-connector[bot] (Migrated from github.com) commented 2026-02-21 18:46:36 +00:00
Copy Link
Copy Source

P2 Badge Remove unsupported --local-only invocation from acceptance criteria

The AC here requires tools/ai/zeroclaw_dual_chat.sh <repo> --local-only --provider-check, but tools/ai/zeroclaw_dual_chat.sh does not implement a --local-only flag (usage only lists --hardware, --provider-check, --cheap, and the parser falls back to usage/error for unknown first options). As written, operators following this spec cannot reproduce the claimed check and will hit a failure path instead of enforcing local-provider-only behavior.

Useful? React with 👍 / 👎.

**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Remove unsupported --local-only invocation from acceptance criteria** The AC here requires `tools/ai/zeroclaw_dual_chat.sh <repo> --local-only --provider-check`, but `tools/ai/zeroclaw_dual_chat.sh` does not implement a `--local-only` flag (usage only lists `--hardware`, `--provider-check`, `--cheap`, and the parser falls back to usage/error for unknown first options). As written, operators following this spec cannot reproduce the claimed check and will hit a failure path instead of enforcing local-provider-only behavior. Useful? React with 👍 / 👎.
ai-agentic-embedded-base/specs/04_tasks.md
@@ -29,0 +79,4 @@
- [x] T-201 - Discover hardware Zacus
- AC: au moins un port detecte pour carte Zacus.
- Evidence: `tools/ai/zeroclaw_dual_chat.sh zacus --hardware`
chatgpt-codex-connector[bot] (Migrated from github.com) commented 2026-02-21 18:46:36 +00:00
Copy Link
Copy Source

P2 Badge Replace ineffective port-hint vars with supported upload settings

These evidence commands rely on ZEROCLAW_ZACUS_UPLOAD_PORT_HINT and ZEROCLAW_RTC_UPLOAD_PORT_HINT to lock board-to-port mapping, but tools/ai/zeroclaw_hw_firmware_loop.sh only reads ZEROCLAW_UPLOAD_PORT (or --port) and otherwise auto-detects from pio device list; it never consumes either hint variable. That means the documented procedure does not actually enforce the claimed mapping fix and can still select the wrong serial device during hardware loops.

Useful? React with 👍 / 👎.

**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Replace ineffective port-hint vars with supported upload settings** These evidence commands rely on `ZEROCLAW_ZACUS_UPLOAD_PORT_HINT` and `ZEROCLAW_RTC_UPLOAD_PORT_HINT` to lock board-to-port mapping, but `tools/ai/zeroclaw_hw_firmware_loop.sh` only reads `ZEROCLAW_UPLOAD_PORT` (or `--port`) and otherwise auto-detects from `pio device list`; it never consumes either hint variable. That means the documented procedure does not actually enforce the claimed mapping fix and can still select the wrong serial device during hardware loops. Useful? React with 👍 / 👎.
Sign in to join this conversation.
Reviewers
No Reviewers
chatgpt-codex-connector[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
electron (Clément Saillant)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: electron-rare/Kill_LIFE#13
Delete Branch "codex/agentic-credit-local-optimization"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?