Bump actions/cache from 5.0.3 to 5.0.4

Bumps [actions/cache](https://github.com/actions/cache) from 5.0.3 to 5.0.4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](https://github.com/actions/cache/compare/cdf6c1fa76f9f475f3d7449005a359c84ca0f306...668228422ae6a00e4ad889ee87cd7109ec5666a7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-version: 5.0.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

.github/workflows/sub_buildPixi.yml

@@ -124,7 +124,7 @@ jobs:
     - name: Restore Compiler Cache
       id: cache-restore
       if: always()
-      uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
+      uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
       with:
         path: ${{ env.CCACHE_DIR }}
         key: FC-${{ env.cacheKey }}-${{ github.ref }}-${{ github.run_id }}
@@ -209,7 +209,7 @@ jobs:
     - name: Save Compiler Cache
       id: cache-save
       if: always()
-      uses: actions/cache/save@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
+      uses: actions/cache/save@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
       with:
         path: ${{ env.CCACHE_DIR }}
         key: FC-${{ env.cacheKey }}-${{ github.ref }}-${{ github.run_id }}

.github/workflows/sub_buildUbuntu.yml

@@ -116,7 +116,7 @@ jobs:
       - name: Restore Compiler Cache
         id: cache-restore
         if: always()
-        uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
+        uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
         with:
           path: ${{ env.CCACHE_DIR }}
           key: FC-${{ steps.genCacheKey.outputs.cacheKey }}-${{ github.ref }}-${{ github.run_id }}
@@ -216,7 +216,7 @@ jobs:
       - name: Save Compiler Cache
         id: cache-save
         if: always()
-        uses: actions/cache/save@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
+        uses: actions/cache/save@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
         with:
           path: ${{ env.CCACHE_DIR }}
           key: FC-${{ steps.genCacheKey.outputs.cacheKey }}-${{ github.ref }}-${{ github.run_id }}

.github/workflows/sub_buildWindows.yml

@@ -111,7 +111,7 @@ jobs:
       - name: Restore compiler cache
         id: cache-restore
         if: always()
-        uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
+        uses: actions/cache/restore@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
         with:
           path: ${{ env.CCACHE_DIR }}
           key: FC-${{ env.cacheKey }}-${{ github.ref }}-${{ github.run_id }}
@@ -169,7 +169,7 @@ jobs:
       - name: Save Compiler Cache
         id: cache-save
         if: always()
-        uses: actions/cache/save@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
+        uses: actions/cache/save@668228422ae6a00e4ad889ee87cd7109ec5666a7 # v5.0.4
         with:
           path: ${{ env.CCACHE_DIR }}
           key: FC-${{ env.cacheKey }}-${{ github.ref }}-${{ github.run_id }}

src/App/Application.h

@@ -310,7 +310,11 @@ public:
      * @return The new transaction ID.
      */
 
-    int setActiveTransaction(TransactionName name);
+     int setActiveTransaction(TransactionName name);
+
+    /// Return the current global transaction name and ID if such a global transaction is
+    /// setup (uncommon)
+    std::string getActiveTransaction(int *tid=nullptr) const;
 
     int openGlobalTransaction(TransactionName name);
     int getGlobalTransaction() const;

src/App/ApplicationPy.cpp

@@ -1221,10 +1221,9 @@ PyObject* ApplicationPy::sGetActiveTransaction(PyObject* /*self*/, PyObject* arg
     PY_TRY
     {
         int id = 0;
-        std::string name = "";
-        if (Document* doc = GetApplication().getActiveDocument()) {
-            id = doc->getBookedTransactionID();
-            name = GetApplication().getTransactionName(id);
+        std::string name = GetApplication().getActiveTransaction(&id);
+        if (name.empty() || id <= 0) {
+            Py_Return;
         }
         Py::Tuple ret(2);
         ret.setItem(0, Py::String(name));

src/App/AutoTransaction.cpp

@@ -71,6 +71,13 @@ int Application::setActiveTransaction(TransactionName name)
     return openGlobalTransaction(name);
 }
 
+std::string Application::getActiveTransaction(int* id) const
+{
+    if (id != nullptr) {
+        *id = _globalTransactionID;
+    }
+    return _globalTransactionID != 0 ? getTransactionName(_globalTransactionID) : "";
+}
 int Application::openGlobalTransaction(TransactionName name)
 {
     if (name.name.empty()) {

src/Gui/propertyeditor/PropertyEditor.cpp

@@ -403,7 +403,7 @@ void PropertyEditor::openEditor(const QModelIndex& index)
         str << "...";
     }
     transactionID = obj->getDocument()->openTransaction(str.str().c_str());
-    FC_LOG("editor transaction " << App::GetApplication().getTransactionName(transactionID));
+    FC_LOG("editor transaction " << App::GetApplication().getActiveTransaction(&transactionID));
 }
 
 void PropertyEditor::onItemActivated(const QModelIndex& index)

src/Mod/CAM/Path/Post/Processor.py

@@ -1887,6 +1887,13 @@ class PostProcessor:
         postables = self._buildPostList(early_tool_prep)
         Path.Log.debug(f"postables {postables}")
 
+        # Process canned cycles for drilling operations
+        for _, section in enumerate(postables):
+            _, sublist = section
+            for obj in sublist:
+                if hasattr(obj, "Path"):
+                    obj.Path = PostUtils.cannedCycleTerminator(obj.Path)
+
         Path.Log.debug(f"postables count: {len(postables)}")
 
         g_code_sections = []

src/Mod/CAM/Path/Post/UtilsParse.py

@@ -708,12 +708,8 @@ def parse_a_path(values: Values, gcode: Gcode, pathobj) -> None:
     )
     adaptive_op_variables = determine_adaptive_op(values, pathobj)
 
-    path_to_process = pathobj.Path
-
-    # Process canned cycles for drilling operations
-    path_to_process = PostUtils.cannedCycleTerminator(path_to_process)
-
     # Apply arc splitting if requested
+    path_to_process = pathobj.Path
     if values["SPLIT_ARCS"]:
         path_to_process = PostUtils.splitArcs(path_to_process)
 

src/Mod/Fem/femtaskpanels/base_fempostpanel.py

@@ -64,7 +64,7 @@ class _BasePostTaskPanel(base_femtaskpanel._BaseTaskPanel):
 
     def open(self):
         # open a new transaction if non is open
-        if FreeCAD.ActiveDocument.getBookedTransactionID() == 0:
+        if not FreeCAD.getActiveTransaction():
             FreeCAD.ActiveDocument.openTransaction(
                 translate("FEM", "Edit {}").format(self.obj.Label)
             )

src/Mod/PartDesign/Gui/TaskFeatureParameters.cpp

@@ -217,6 +217,7 @@ bool TaskDlgFeatureParameters::accept()
         feature->getDocument()->commitTransaction();
     }
     catch (const Base::Exception& e) {
+        feature->getDocument()->abortTransaction();
         QString errorText = QString::fromUtf8(e.what());
         QString statusText = QString::fromUtf8(getObject()->getStatusString());
 

src/Mod/PartDesign/Gui/ViewProviderHole.cpp

@@ -333,11 +333,15 @@ std::optional<gp_Pnt> ViewProviderHole::getHoleOrigin(const PartDesign::Hole* pc
     if (!pcHole) {
         return std::nullopt;
     }
-    if (auto* profile = pcHole->Profile.getValue()) {
-        const Base::Vector3d pos = profile->getPlacement().getPosition();
-        return Base::convertTo<gp_Pnt>(pos);
+
+    auto* sketch = freecad_cast<Part::Part2DObject*>(pcHole->Profile.getValue());
+
+    if (!sketch) {
+        return std::nullopt;
     }
-    return std::nullopt;
+
+    const Base::Vector3d& pos = sketch->Placement.getValue().getPosition();
+    return Base::convertTo<gp_Pnt>(pos);
 }
 
 std::vector<TopoDS_Face> ViewProviderHole::collectBoreFaces(const PartDesign::Hole* pcHole) const