Commit Graph

1348 Commits

Author SHA1 Message Date
Abdullah Tahiri e4a5d8b862 PartDesign: Chamfer feature corrections and improvements
========================================================

- Correction to mustExecute() to account for the new properties
- Make properties not used by the mode as read-only.
- Gui: apply() only for construction mode valid features
2020-05-23 12:24:08 +02:00
Armandas Jarušauskas e1240fb18d PartDesign: Chamfer direction flipping support 2020-05-23 12:24:08 +02:00
Armandas Jarušauskas d2d26ab8d0 PartDesign: Chamfer icon art - flip icon 2020-05-23 12:24:08 +02:00
Armandas Jarušauskas de02063f05 PartDesign: Chamfer - updated parameter validation code. 2020-05-23 12:24:08 +02:00
Armandas Jarušauskas 262841bb3c PartDesign: Chamfer with multiple creation modes 2020-05-23 12:24:08 +02:00
Zolko fc4e83ad63 setting Datum Line size manually 2020-05-13 11:23:28 +02:00
wmayer 6b022b277a PartDesign: [skip ci] fix ambiguous widget name 2020-05-12 14:30:53 +02:00
Armandas Jarušauskas 4669b6c88d Fixed issues introduced in #3456
- Copy-paste error when setting angle dimensions.
- Max angle limit set to 180 degrees.
2020-05-12 14:29:28 +02:00
wmayer 618089d6d8 remove deprecated std::binary_function 2020-05-11 13:46:37 +02:00
Armandas Jarušauskas cc82cf3e50 Added chamfer angle support to PartDesign. 2020-05-10 18:59:30 +02:00
lorenz 8be2c08141 partdesign: fix failing tapered hole test
The given parameters return an invalid shape. This fails with occt7.4 but doesn't with occt7.3. If the angle is 45 degree the cone is self-intersecting as Hole.Depth > Hole.Diameter/2. Changing the Hole.TaperedAngle to 60 degree solves this issue.
2020-05-03 17:49:13 +02:00
Yorik van Havre 28b51cf28a Merged crowdin translations 2020-04-29 16:08:23 +02:00
Abdullah Tahiri 0ec3cb16cb Remove hard-coded font families 2020-04-28 14:53:28 +02:00
Yorik van Havre 2ce452c650 Fixed bad conflict merge in PArtDesign 2020-04-20 13:34:38 +02:00
Adam Spontarelli add624353d Converted class names from private to public, per feedback from pull request 2020-04-20 12:30:08 +02:00
Adam Spontarelli 1123e271a9 Converted class names from private to public and corrected docstring formatting, per feedback from pull request 2020-04-20 12:28:27 +02:00
Adam Spontarelli 1eef7064f8 Initial addition of fcsprocket feature. This is a PartDesign tool that allows for the simple creation of ANSI standard roller chain sprockets. 2020-04-20 12:28:27 +02:00
0penBrain f9fc96047d [PartDesign] Remove 'Set tip' from Body contextual menu ; fixes #4304 2020-04-07 19:38:01 +02:00
luz.paz 2ed5786d07 [skip-ci] Various typo fixes
Found via codespell  v1.17.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-07 18:17:03 +02:00
wmayer 107831e0a7 PartDesign: [skip ci] fixes #0004254: Crash when canceling duplicate sketch in PartDesign 2020-03-24 15:15:25 +01:00
donovaly 0a1312e9f5 [PD] fix logic of TaskPrimitiveParameters dialog
- only allow geometrically possible values for the different parameters
- this way also fix a crash
- fix a typo

see https://forum.freecadweb.org/viewtopic.php?f=3&t=44467
2020-03-24 08:36:06 +01:00
Zheng, Lei 18054d95f3 PartDesign: fix SubShapeBinder make command 2020-03-21 22:12:27 +01:00
donovaly 172e28b6b4 [PD] add expressions to primitive dialog
see https://forum.freecadweb.org/viewtopic.php?f=3&t=36458
(a step forward to fix bug https://tracker.freecadweb.org/view.php?id=3981 )
2020-03-21 22:06:40 +01:00
Zheng, Lei 509cbfa53c PartDesign: allow making new ProfileBased feature using multiple faces 2020-03-20 16:38:00 +01:00
Zheng, Lei 4dd16c58ed PartDesign: allow multiple faces in feature ProfileBased 2020-03-20 16:38:00 +01:00
Zheng, Lei 5eb298ddcd PartDesign: fix SubShapeBinder solids fuse 2020-03-20 15:02:20 +01:00
Zheng, Lei 3366a245f5 PartDesign: improve SubShapeBinder make command 2020-03-20 15:02:20 +01:00
Zheng, Lei b3835cd69d PartDesign: remove SubShapeBinder.Support hidden status
Change Immutable status to ReadOnly, which makes it easy to set value
in script, but still block editing in property view by default. This is
to discourage user editing support using property editor, because
SubShapeBinder requires relative link correction.
2020-03-20 15:02:20 +01:00
Zheng, Lei 179a2c2547 PartDesign: improve SubShapeBinder property documentation 2020-03-20 15:02:20 +01:00
Zheng, Lei d949447f89 PartDesign: change SubShapeBinder claim children behavior 2020-03-20 15:02:20 +01:00
Zheng, Lei 4a26bd0b2f PartDesign: disable SupportTransform on legacy dressup feature
Because in order to SupportTransform, dressup must calculate its
AddSubShape, which is empty for existing legacy dressup feature.
2020-03-20 14:50:59 +01:00
Zheng, Lei 974267bc6e PartDesign: fix dressup AddSubShape transformation
AddSubShape must not have local transformation.
2020-03-20 14:50:59 +01:00
wmayer 8c0dc92426 PartDesign: fix issues of PR #3108
* in the undo/redo list use an object's label and not the internal name
* check by the transaction ID instead of name to open a transaction to make the workbenches independent of implementation details of the core system
* when rejecting a task do not call undo() because this is not the same as aborting a pending transaction
* this also fixes the warning: <App> Document.cpp(1182): Cannot commit transaction while transacting
2020-03-14 14:51:45 +01:00
Zheng, Lei 096f64cca6 PartDesign: fix task dressup/transformed creation cancel 2020-03-14 14:51:45 +01:00
wmayer e9aeef17ab fixes #0004286: PartDesign hole: angle of the tapered hole does not match the tapered angle specified [skip ci]
See https://forum.freecadweb.org/viewtopic.php?f=13&t=44056#p375915
2020-03-12 11:39:09 +01:00
wmayer dce426bf8f PartDesign: [skip ci] New sketch function doesn't try any more to edit a selected sketch 2020-03-11 15:14:18 +01:00
luz.paz 180805c55e Fix typos
Found via  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-03-06 14:50:35 +01:00
Yorik van Havre 0c1289282b Merged latest translations from crowdin 2020-03-05 11:58:03 -03:00
wmayer a34cd69125 PartDesign: [skip ci] fixes #0004276: Loading a project takes much more time compared to previous versions 2020-03-02 10:06:16 +01:00
wmayer bdd8d257d9 PartDesign: [skip ci] optimize when removing items from dress-up features 2020-02-23 14:58:48 +01:00
donovaly da6352c43d [PD] only recompute once per deletion action
see https://forum.freecadweb.org/viewtopic.php?f=19&t=43383&p=370357#p370357
2020-02-23 12:43:11 +01:00
Zheng, Lei c6bb533541 PartDesign: fix DressUp base shape checking 2020-02-23 11:04:54 +01:00
donovaly 361acd5a84 [PD] enable selection of fillets etc. using arrow keys in Dlg
see https://forum.freecadweb.org/viewtopic.php?f=19&t=43383&p=370758#p370758
2020-02-21 09:27:00 +01:00
wmayer 389b26c48e PartDesign/Fem: [skip ci] when handling Del key make sure that deleteAction is instantiated 2020-02-19 11:31:40 +01:00
wmayer 19148d3051 PartDesign: [skip ci] add missing header 2020-02-18 23:23:49 +01:00
donovaly cc3b21fa0b improve code as suggested by Werner
see https://forum.freecadweb.org/viewtopic.php?p=369921#p369921
2020-02-18 23:16:48 +01:00
donovaly 69f97014e7 [PD] missing changed from commit d4be4a02
(key event handling for more dialogs)
2020-02-18 22:29:53 +01:00
donovaly 01e8e7f777 try to squash GCC compile error 2020-02-18 00:08:58 +01:00
donovaly b86d97b9bc catch case that users tries to delete all items in the dialog list 2020-02-18 00:08:28 +01:00
donovaly 316a8840b4 remove unnecessary code and comment 2020-02-18 00:07:01 +01:00