electron-rare/FreeCAD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CAM: CircularHoleBase.holeDiameter() - Fix face

Browse Source
This commit is contained in:
tarman3
2026-02-27 20:41:07 +02:00
parent b8f98e2842
commit eaf76e4d0a
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Mod/CAM/Path/Op/CircularHoleBase.py
+6 -10
View File
@@ -92,20 +92,16 @@ class ObjectOp(PathOp.ObjectOp):
"""holeDiameter(obj, base, sub) ... returns the diameter of the specified hole."""
try:
shape = base.Shape.getElement(sub)
if shape.ShapeType == "Vertex":
if isinstance(shape, Part.Vertex):
return 0
if shape.ShapeType == "Edge" and type(shape.Curve) == Part.Circle:
if isinstance(shape, Part.Edge) and isinstance(shape.Curve, Part.Circle):
return shape.Curve.Radius * 2
if shape.ShapeType == "Face":
for i in range(len(shape.Edges)):
if (
type(shape.Edges[i].Curve) == Part.Circle
and shape.Edges[i].Curve.Radius * 2 < shape.BoundBox.XLength * 1.1
and shape.Edges[i].Curve.Radius * 2 > shape.BoundBox.XLength * 0.9
):
return shape.Edges[i].Curve.Radius * 2
if isinstance(shape, Part.Face):
for edge in shape.Edges:
if isinstance(edge.Curve, Part.Circle):
return edge.Curve.Radius * 2
# for all other shapes the diameter is just the dimension in X.
# This may be inaccurate as the BoundBox is calculated on the tessellated geometry