electron-rare/FreeCAD
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #27587 from WandererFan/BrokenViewRemoveFCBRepAlgoAPI_Cut2

Browse Source 
TechDraw: FCBRepAlgoAPI_Cut returns null shape for BrokenView break
This commit is contained in:
Chris Hennes
2026-02-16 10:51:06 -06:00
committed by GitHub
parent e0cd49e670 6d73f9173c
commit 72a024aaeb
1 changed files with 21 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Mod/TechDraw/App/DrawBrokenView.cpp
+21 -6
View File
@@ -173,7 +173,12 @@ TopoDS_Shape DrawBrokenView::breakShape(const TopoDS_Shape& shapeToBreak) const
auto breaksAll = Breaks.getValues();
TopoDS_Shape updatedShape = shapeToBreak;
for (auto& item : breaksAll) {
TopoDS_Shape previousShape = updatedShape;
updatedShape = apply1Break(*item, updatedShape);
if (updatedShape.IsNull()) {
Base::Console().warning("Failed to apply break %s\n", item->Label.getValue());
updatedShape = previousShape;
}
}
return updatedShape;
}
@@ -198,20 +203,30 @@ TopoDS_Shape DrawBrokenView::apply1Break(const App::DocumentObject& breakObj, co
moveDir0.Normalize();
moveDir0 = DU::closestBasisOriented(moveDir0);
auto halfSpace0 = makeHalfSpace(breakPoints.first, moveDir0, breakPoints.second);
FCBRepAlgoAPI_Cut mkCut0(inShape, halfSpace0);
if (!mkCut0.IsDone()) {
Base::Console().message("DBV::apply1Break - cut0 failed\n");
// FCBRepAlgoAPI_Cut gets upset about cutting non-solids?? "XXX is not a solid" from Boolean::execute().
// We are cutting Compounds and that is valid in BRepAlgoAPI_Cut, but maybe not in FCBRepAlgoAPI_Cut?
// See sample file here: https://github.com/FreeCAD/FreeCAD/issues/27414
BRepAlgoAPI_Cut mkCut0(inShape, halfSpace0);
if (!mkCut0.IsDone() || mkCut0.Shape().IsNull()) {
Base::Console().warning("Failed to make first cut for break %s.\n", breakObj.Label.getValue());
return {};
}
TopoDS_Shape cut0 = mkCut0.Shape();
// make a halfspace that is positioned at the second breakpoint and extends
// in the direction of the first point
Base::Vector3d moveDir1 = breakPoints.first - breakPoints.second;
moveDir1.Normalize();
moveDir1 = DU::closestBasisOriented(moveDir1);
auto halfSpace1 = makeHalfSpace(breakPoints.second, moveDir1, breakPoints.first);
FCBRepAlgoAPI_Cut mkCut1(inShape, halfSpace1);
if (!mkCut1.IsDone()) {
Base::Console().message("DBV::apply1Break - cut1 failed\n");
// see mkCut0 above
BRepAlgoAPI_Cut mkCut1(inShape, halfSpace1);
if (!mkCut1.IsDone()|| mkCut1.Shape().IsNull()) {
Base::Console().warning("Failed to make second cut for break %s.\n", breakObj.Label.getValue());
return {};
}
TopoDS_Shape cut1 = mkCut1.Shape();