PD: Remove unused parameter from getTopoShapeVerifiedFace
This commit is contained in:
@@ -202,7 +202,6 @@ Part::Feature* ProfileBased::getVerifiedObject(bool silent) const
|
||||
}
|
||||
TopoShape ProfileBased::getTopoShapeVerifiedFace(
|
||||
bool silent,
|
||||
[[maybe_unused]] bool doFit, // TODO: Remove parameter
|
||||
bool allowOpen,
|
||||
const App::DocumentObject* profile,
|
||||
const std::vector<std::string>& _subs
|
||||
@@ -1374,11 +1373,7 @@ Base::Vector3d ProfileBased::getProfileNormal() const
|
||||
return SketchVector;
|
||||
}
|
||||
|
||||
// For newer version, do not do fitting, as it may flip the face normal for
|
||||
// some reason.
|
||||
TopoShape shape = getTopoShapeVerifiedFace(true, true, true); //, _ProfileBasedVersion.getValue()
|
||||
//<= 0);
|
||||
|
||||
TopoShape shape = getTopoShapeVerifiedFace(true, true);
|
||||
if (shape.isNull()) {
|
||||
return SketchVector;
|
||||
}
|
||||
|
||||
@@ -111,14 +111,12 @@ public:
|
||||
* @param silent: if profile property is malformed and the parameter is true
|
||||
* silently returns nullptr, otherwise throw a Base::Exception.
|
||||
* Default is false.
|
||||
* @param doFit: Whether to fitting according to the 'Fit' property
|
||||
* @param allowOpen: Whether allow open wire
|
||||
* @param profile: optional profile object, if not given then use 'Profile' property
|
||||
* @param subs: optional profile sub-object names, if not given then use 'Profile' property
|
||||
*/
|
||||
TopoShape getTopoShapeVerifiedFace(
|
||||
bool silent = false,
|
||||
bool doFit = true,
|
||||
bool allowOpen = false,
|
||||
const App::DocumentObject* profile = nullptr,
|
||||
const std::vector<std::string>& subs = {}
|
||||
|
||||
Reference in New Issue
Block a user