electron-rare/ESP32_ZACUS
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(npc): wire scene notify into apply_step #32

Merged
electron merged 1 commits from fix/wire-scene-notify into main 2026-06-18 13:52:50 +00:00
Conversation 0 Commits 1 Files Changed 6
+45 -1
electron commented 2026-06-18 13:52:39 +00:00
Owner
Copy Link
Copy Source

notify_gateway_scene lived in npc_engine_set_step which had no callers (dead code). apply_step now resolves the step scene_id and calls npc_engine_set_scene_by_id. Hardware-validated end to end: STEP_WARNING -> gateway notify -> auto-ring Zacus on the PLIP.

notify_gateway_scene lived in npc_engine_set_step which had no callers (dead code). apply_step now resolves the step scene_id and calls npc_engine_set_scene_by_id. Hardware-validated end to end: STEP_WARNING -> gateway notify -> auto-ring Zacus on the PLIP.
electron added 1 commit 2026-06-18 13:52:40 +00:00
fix(npc): wire scene notify into apply_step
CI / platformio (push) Failing after 6m10s
Details
CI / platformio (pull_request) Failing after 17m59s
Details
ace740a629 
notify_gateway_scene() + hints puzzle_start lived only in
npc_engine_set_step(), which had NO callers — the runtime->gateway
sync was dead code, so scripted incoming calls would never fire in a
real game. POST /game/step goes through game_endpoint_apply_step(),
which now resolves the step's scene_id (new field on scene_binding,
parsed straight from the IR) and calls the new
npc_engine_set_scene_by_id(). Hardware-validated: STEP_WARNING ->
scene 3 -> gateway notify -> auto-ring Professeur Zacus on the PLIP.
electron merged commit ace740a629 into main 2026-06-18 13:52:50 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
electron (Clément Saillant)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: electron-rare/ESP32_ZACUS#32
Delete Branch "fix/wire-scene-notify"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?